platform/upstream/freerdp.git
8 years agoFixed possible memory leak.
Armin Novak [Tue, 1 Sep 2015 10:34:40 +0000 (12:34 +0200)]
Fixed possible memory leak.

8 years agoFixed uninitialized values.
Armin Novak [Tue, 1 Sep 2015 10:27:54 +0000 (12:27 +0200)]
Fixed uninitialized values.

8 years agoFixed uninitialized values.
Armin Novak [Tue, 1 Sep 2015 10:21:25 +0000 (12:21 +0200)]
Fixed uninitialized values.

8 years agoFixed zero length allocation.
Armin Novak [Tue, 1 Sep 2015 10:05:22 +0000 (12:05 +0200)]
Fixed zero length allocation.

8 years agoFixed zero lenght allocation.
Armin Novak [Tue, 1 Sep 2015 09:58:43 +0000 (11:58 +0200)]
Fixed zero lenght allocation.

8 years agoFixed zero length allocation.
Armin Novak [Tue, 1 Sep 2015 09:57:22 +0000 (11:57 +0200)]
Fixed zero length allocation.

8 years agoFixed zero length allocation.
Armin Novak [Tue, 1 Sep 2015 09:56:02 +0000 (11:56 +0200)]
Fixed zero length allocation.

8 years agoFixed uninitialized memory.
Armin Novak [Tue, 1 Sep 2015 09:49:11 +0000 (11:49 +0200)]
Fixed uninitialized memory.

8 years agoFixed array out of bound access.
Armin Novak [Tue, 1 Sep 2015 09:44:15 +0000 (11:44 +0200)]
Fixed array out of bound access.

8 years agoFixed broken structure comparison.
Armin Novak [Tue, 1 Sep 2015 09:41:45 +0000 (11:41 +0200)]
Fixed broken structure comparison.

8 years agoFixed error handling of OSS audio plugin.
Armin Novak [Tue, 1 Sep 2015 09:39:56 +0000 (11:39 +0200)]
Fixed error handling of OSS audio plugin.

8 years agoFixed resource leak.
Armin Novak [Tue, 1 Sep 2015 09:31:12 +0000 (11:31 +0200)]
Fixed resource leak.

8 years agoMerge pull request #2825 from akallabeth/pointer_decoding_fix
Norbert Federa [Tue, 1 Sep 2015 09:09:42 +0000 (11:09 +0200)]
Merge pull request #2825 from akallabeth/pointer_decoding_fix

Fixed color pointer decoding.

8 years agoIgnore AND mask for 32 bit pointer.
Armin Novak [Tue, 1 Sep 2015 07:25:41 +0000 (09:25 +0200)]
Ignore AND mask for 32 bit pointer.

8 years agoMerge pull request #2855 from akallabeth/memleak_fixes
Bernhard Miklautz [Mon, 31 Aug 2015 07:50:21 +0000 (09:50 +0200)]
Merge pull request #2855 from akallabeth/memleak_fixes

Memleak fixes

8 years agoMerge pull request #2854 from bmiklautz/issue/2853
Hardening [Sun, 30 Aug 2015 20:31:08 +0000 (22:31 +0200)]
Merge pull request #2854 from bmiklautz/issue/2853

settings: update settings/help to match

8 years agoFixed cleanup code.
Armin Novak [Fri, 28 Aug 2015 09:46:24 +0000 (11:46 +0200)]
Fixed cleanup code.

8 years agoFixed memory leak.
Armin Novak [Fri, 28 Aug 2015 09:17:20 +0000 (11:17 +0200)]
Fixed memory leak.

8 years agosettings: update settings/help to match
Bernhard Miklautz [Fri, 28 Aug 2015 09:09:38 +0000 (11:09 +0200)]
settings: update settings/help to match

* wallpaper was off but help said "default: on"
* compression is on but help said "default: off"

Fixes #2853

8 years agoFixed memory leak.
Armin Novak [Fri, 28 Aug 2015 09:07:25 +0000 (11:07 +0200)]
Fixed memory leak.

8 years agoFixed memory leak.
Armin Novak [Fri, 28 Aug 2015 09:06:26 +0000 (11:06 +0200)]
Fixed memory leak.

8 years agoFixed memory leak.
Armin Novak [Fri, 28 Aug 2015 09:05:44 +0000 (11:05 +0200)]
Fixed memory leak.

8 years agoFixed memory leak.
Armin Novak [Fri, 28 Aug 2015 09:01:34 +0000 (11:01 +0200)]
Fixed memory leak.

8 years agoFixed NONNULL argument warnings.
Armin Novak [Fri, 28 Aug 2015 08:59:48 +0000 (10:59 +0200)]
Fixed NONNULL argument warnings.

8 years agoFixed NONNULL argument warnings.
Armin Novak [Fri, 28 Aug 2015 08:58:20 +0000 (10:58 +0200)]
Fixed NONNULL argument warnings.

8 years agoFixed resource leak.
Armin Novak [Fri, 28 Aug 2015 08:53:43 +0000 (10:53 +0200)]
Fixed resource leak.

8 years agoFixed resource cleanup double free.
Armin Novak [Fri, 28 Aug 2015 08:51:27 +0000 (10:51 +0200)]
Fixed resource cleanup double free.

8 years agoMerge pull request #2716 from realjiangms/shadow_xor_pointer
Marc-André Moreau [Thu, 27 Aug 2015 14:20:18 +0000 (10:20 -0400)]
Merge pull request #2716 from realjiangms/shadow_xor_pointer

server/shadow: Fix alpha pointer message so that it allows pixel with both 'xor' and 'and'

8 years agoMerge pull request #2739 from realjiangms/shadow_resize
Marc-André Moreau [Thu, 27 Aug 2015 14:19:25 +0000 (10:19 -0400)]
Merge pull request #2739 from realjiangms/shadow_resize

server/shadow: Enhancement regarding the screen and resolution - addresize support and fix subRect feature

8 years agoMerge pull request #2798 from psumbera/master
Marc-André Moreau [Thu, 27 Aug 2015 14:15:29 +0000 (10:15 -0400)]
Merge pull request #2798 from psumbera/master

This array is so big that it eats whole stack for the thread and makes

8 years agoMerge pull request #2827 from HenryJacques/winpr_cleanup
Marc-André Moreau [Thu, 27 Aug 2015 14:11:50 +0000 (10:11 -0400)]
Merge pull request #2827 from HenryJacques/winpr_cleanup

Remove unused variable in RegQueryValueExA()

8 years agoMerge pull request #2838 from akallabeth/smartcard_no_readers
Marc-André Moreau [Thu, 27 Aug 2015 14:05:23 +0000 (10:05 -0400)]
Merge pull request #2838 from akallabeth/smartcard_no_readers

Added return value checks for smartcard functions.

8 years agoMerge pull request #2844 from akallabeth/getcomputername_fix
Marc-André Moreau [Thu, 27 Aug 2015 14:04:48 +0000 (10:04 -0400)]
Merge pull request #2844 from akallabeth/getcomputername_fix

Getcomputername fix

8 years agoMerge pull request #2829 from akallabeth/mf_compile_option
Marc-André Moreau [Thu, 27 Aug 2015 14:00:47 +0000 (10:00 -0400)]
Merge pull request #2829 from akallabeth/mf_compile_option

media foundation support now a compile time option.

8 years agoMerge pull request #2785 from MartinHaimberger/mh-channel-fix
Marc-André Moreau [Thu, 27 Aug 2015 13:24:10 +0000 (09:24 -0400)]
Merge pull request #2785 from MartinHaimberger/mh-channel-fix

Channel hardening and fixing

8 years agoRemove WIN32ERROR type
Martin Haimberger [Thu, 27 Aug 2015 12:25:09 +0000 (05:25 -0700)]
Remove WIN32ERROR type

All return values are UINT now.

8 years agoMerge pull request #2846 from llyzs/monitor
Hardening [Thu, 27 Aug 2015 09:42:45 +0000 (11:42 +0200)]
Merge pull request #2846 from llyzs/monitor

Read and write desktop and monitor data.

8 years agoMerge pull request #2847 from akallabeth/base64_decode_ensure_null_termination
Martin Fleisz [Thu, 27 Aug 2015 09:28:37 +0000 (11:28 +0200)]
Merge pull request #2847 from akallabeth/base64_decode_ensure_null_termination

Ensure output of crypto_base64_decode is NULL terminated.

8 years agogcc: read and write desktop scale settings in core data.
Vic Lee [Thu, 27 Aug 2015 08:18:22 +0000 (16:18 +0800)]
gcc: read and write desktop scale settings in core data.

8 years agoEnsure output of crypto_base64_decode is NULL terminated.
Armin Novak [Thu, 27 Aug 2015 07:27:23 +0000 (09:27 +0200)]
Ensure output of crypto_base64_decode is NULL terminated.

8 years agogcc: read and write monitor extended data.
Vic Lee [Thu, 27 Aug 2015 06:10:42 +0000 (14:10 +0800)]
gcc: read and write monitor extended data.

8 years agox509_get_default_name tries to get FQDN before hostname now.
Armin Novak [Tue, 25 Aug 2015 15:44:03 +0000 (17:44 +0200)]
x509_get_default_name tries to get FQDN before hostname now.

8 years agoFixed GetComputerNameExA and GetComputerNameA.
Armin Novak [Tue, 25 Aug 2015 15:43:22 +0000 (17:43 +0200)]
Fixed GetComputerNameExA and GetComputerNameA.

8 years agoMerge remote-tracking branch 'upstream/master' into mh-channel-fix
Martin Haimberger [Tue, 25 Aug 2015 07:07:04 +0000 (00:07 -0700)]
Merge remote-tracking branch 'upstream/master' into mh-channel-fix

Conflicts:
channels/drdynvc/client/drdynvc_main.c
channels/rdpgfx/client/rdpgfx_main.c
client/X11/xf_gfx.c

8 years agoAdded return value checks.
Armin Novak [Wed, 19 Aug 2015 10:50:48 +0000 (12:50 +0200)]
Added return value checks.

8 years agomedia foundation support now a compile time option.
Armin Novak [Tue, 11 Aug 2015 05:51:59 +0000 (07:51 +0200)]
media foundation support now a compile time option.

8 years agoFixed duplicate int.
Armin Novak [Thu, 6 Aug 2015 12:43:39 +0000 (14:43 +0200)]
Fixed duplicate int.

8 years agoFixed mac API.
Armin Novak [Thu, 6 Aug 2015 12:11:36 +0000 (14:11 +0200)]
Fixed mac API.

8 years agoAdded length arguments and checks.
Armin Novak [Thu, 6 Aug 2015 09:24:42 +0000 (11:24 +0200)]
Added length arguments and checks.

8 years agoRemove unused variable
HenryJacques [Wed, 5 Aug 2015 16:38:50 +0000 (18:38 +0200)]
Remove unused variable

8 years agoFixed return and argument checks.
Armin Novak [Wed, 5 Aug 2015 15:32:46 +0000 (17:32 +0200)]
Fixed return and argument checks.

8 years agoFixed argument checks.
Armin Novak [Wed, 5 Aug 2015 15:32:38 +0000 (17:32 +0200)]
Fixed argument checks.

8 years agoFixed pointer update decoding with NULL mask.
Armin Novak [Wed, 5 Aug 2015 15:19:46 +0000 (17:19 +0200)]
Fixed pointer update decoding with NULL mask.

8 years agoMerge pull request #2823 from awakecoding/master
Marc-André Moreau [Tue, 4 Aug 2015 16:33:37 +0000 (12:33 -0400)]
Merge pull request #2823 from awakecoding/master

egfx channel open/close fix, H.264 Media Foundation decoder support

8 years agoMerge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Tue, 4 Aug 2015 15:55:38 +0000 (11:55 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP

8 years agolibfreerdp-codec: fix Windows XP build for H.264 decoder
Marc-André Moreau [Tue, 4 Aug 2015 15:55:03 +0000 (11:55 -0400)]
libfreerdp-codec: fix Windows XP build for H.264 decoder

8 years agolibfreerdp-codec: fix leaks in H.264 Media Foundation decoder
Marc-André Moreau [Tue, 4 Aug 2015 14:26:13 +0000 (10:26 -0400)]
libfreerdp-codec: fix leaks in H.264 Media Foundation decoder

8 years agolibfreerdp-codec: initial Media Foundation H.264 decoder support
Marc-André Moreau [Mon, 3 Aug 2015 20:21:48 +0000 (16:21 -0400)]
libfreerdp-codec: initial Media Foundation H.264 decoder support

8 years agoMerge pull request #2811 from clivest/client_channel_interface_leak_fix
Bernhard Miklautz [Mon, 3 Aug 2015 07:23:54 +0000 (09:23 +0200)]
Merge pull request #2811 from clivest/client_channel_interface_leak_fix

Fix race condition in freerdp_channels_client_load that could cause memory leak

8 years agoMerge pull request #2817 from FreeRDP/mh-fix-collection-free
Martin Fleisz [Fri, 31 Jul 2015 06:19:03 +0000 (08:19 +0200)]
Merge pull request #2817 from FreeRDP/mh-fix-collection-free

fixed misc *_free functions to accept NULL

8 years agolibfreerdp-codec: add more Media Foundation H.264 code
Marc-André Moreau [Thu, 30 Jul 2015 18:07:35 +0000 (14:07 -0400)]
libfreerdp-codec: add more Media Foundation H.264 code

8 years agofixed wrong returntype under windows
Martin Haimberger [Thu, 30 Jul 2015 14:50:10 +0000 (07:50 -0700)]
fixed wrong returntype under windows

8 years agoMerge remote-tracking branch 'upstream/master' into mh-channel-fix
Martin Haimberger [Thu, 30 Jul 2015 14:29:12 +0000 (07:29 -0700)]
Merge remote-tracking branch 'upstream/master' into mh-channel-fix

Conflicts:
channels/smartcard/client/smartcard_main.c
channels/smartcard/client/smartcard_operations.c

8 years agofixed misc *_free functions to accept NULL
Martin Haimberger [Thu, 30 Jul 2015 14:02:36 +0000 (07:02 -0700)]
fixed misc *_free functions to accept NULL

Following types of collections support now
NULL in the free call:

* ArrayList
* BitStream
* ContdownEvent
* Dictionary
* KeyValuePair
* MessageQueue

8 years agomisc fixes:
Martin Haimberger [Thu, 30 Jul 2015 13:49:21 +0000 (06:49 -0700)]
misc fixes:

fixed all bugs from the review
checking all WaitFor*Object/s calls

8 years agoMerge pull request #2815 from FreeRDP/mh-wait-SetLastError
Hardening [Thu, 30 Jul 2015 12:09:13 +0000 (14:09 +0200)]
Merge pull request #2815 from FreeRDP/mh-wait-SetLastError

winpr: WaitFor*Ojbect/s set lastError now

8 years agowinpr: WaitFor*Ojbect/s set lastError now
Martin Haimberger [Thu, 30 Jul 2015 09:52:11 +0000 (02:52 -0700)]
winpr: WaitFor*Ojbect/s set lastError now

8 years agoMerge pull request #3 from bmiklautz/pull/2785
MartinHaimberger [Thu, 30 Jul 2015 09:05:00 +0000 (11:05 +0200)]
Merge pull request #3 from bmiklautz/pull/2785

Misc fixes

8 years agolibfreerdp-codec: start H.264 MediaFoundation support
Marc-André Moreau [Wed, 29 Jul 2015 20:33:04 +0000 (16:33 -0400)]
libfreerdp-codec: start H.264 MediaFoundation support

8 years agoremdesk,encomps: misc fixes
Bernhard Miklautz [Wed, 29 Jul 2015 15:32:09 +0000 (17:32 +0200)]
remdesk,encomps: misc fixes

* only free stream when an error occurs
* ignore unhanded messages instead of throwing an error
* fix memory leak in settings

8 years agoFix race condition in freerdp_channels_client_load
Clive Stevens [Wed, 29 Jul 2015 13:08:31 +0000 (14:08 +0100)]
Fix race condition in freerdp_channels_client_load

If g_pInterface is set to NULL outside the critical section in one thread
while another thread is in the critical section, the channel client context
allocated in the VirtualChannelEntry won't end up getting freed.

The channel client context is normally loaded from g_pInterface in
FreeRDP_VirtualChannelInit and stored in the pChannelInitData, then copied
from there onto the pChannelOpenData structure in FreeRDP_VirtualChannelOpen
and finally freed in freerdp_channels_free.

8 years agolibfreerdp-codec: add x264 stubs
Marc-André Moreau [Tue, 28 Jul 2015 20:01:34 +0000 (16:01 -0400)]
libfreerdp-codec: add x264 stubs

8 years agoUpdate version to 1.4.5
Bernhard Miklautz [Tue, 28 Jul 2015 15:23:16 +0000 (17:23 +0200)]
Update version to 1.4.5

8 years agoMerge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Tue, 28 Jul 2015 13:21:33 +0000 (09:21 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP

8 years agoMerge pull request #2799 from kaliway/scardlistreaders-fix
Marc-André Moreau [Tue, 28 Jul 2015 12:51:03 +0000 (08:51 -0400)]
Merge pull request #2799 from kaliway/scardlistreaders-fix

Smartcard Reader Connection Handling

8 years agoMerge pull request #2801 from bmiklautz/fix/thread
Marc-André Moreau [Tue, 28 Jul 2015 12:47:06 +0000 (08:47 -0400)]
Merge pull request #2801 from bmiklautz/fix/thread

winpr/thread: small cleanups

8 years agoMerge pull request #2804 from bmiklautz/fix/misc
Marc-André Moreau [Tue, 28 Jul 2015 12:46:27 +0000 (08:46 -0400)]
Merge pull request #2804 from bmiklautz/fix/misc

Misc fixes

8 years agoMerge pull request #2793 from rkondratenko/pcsclite-transactions
Marc-André Moreau [Tue, 28 Jul 2015 12:44:58 +0000 (08:44 -0400)]
Merge pull request #2793 from rkondratenko/pcsclite-transactions

Fix for transactions support for Smart Cards

8 years agordpdr/printer: ignore unhanded packetID
Bernhard Miklautz [Tue, 28 Jul 2015 12:05:57 +0000 (14:05 +0200)]
rdpdr/printer: ignore unhanded packetID

Ignore packetIDs PRN_CACHE_DATA and PRN_USING_XPS instead of returning
an error.

9 years agordpsnd: include win32error.h
Bernhard Miklautz [Mon, 27 Jul 2015 17:24:41 +0000 (19:24 +0200)]
rdpsnd: include win32error.h

If using rdpsnd externally (for example in other projects) WIN32ERROR
needs to be defined otherwise some compilers might create a warning or
error.

9 years agocore/listner: fix possible problem in _free
Bernhard Miklautz [Mon, 27 Jul 2015 09:24:21 +0000 (11:24 +0200)]
core/listner: fix possible problem in _free

9 years agowinpr/thread: don't close invalid file descriptors
Bernhard Miklautz [Fri, 24 Jul 2015 12:57:47 +0000 (14:57 +0200)]
winpr/thread: don't close invalid file descriptors

In case the file descriptor is -1 don't call close.

9 years agowinrp/thread: don't call pthread_exit on return
Bernhard Miklautz [Fri, 24 Jul 2015 12:52:31 +0000 (14:52 +0200)]
winrp/thread: don't call pthread_exit on return

As the pthread_exit man page states pthread_exit is called implicitly
when the start function returns.

9 years agowinpr/event: remove critical section
Bernhard Miklautz [Fri, 24 Jul 2015 11:29:48 +0000 (13:29 +0200)]
winpr/event: remove critical section

The critical section isn't required and not used anymore since
commit 8a2220a3d9c5ad70b425a33772f14f3dbe956841.

9 years agowinpr/thread: small cleanups
Bernhard Miklautz [Thu, 23 Jul 2015 09:52:24 +0000 (11:52 +0200)]
winpr/thread: small cleanups

Also adds error checking of winpr_StartThread in winpr_StartThread.

9 years agoMerge pull request #2789 from akallabeth/start_thread_fix
Bernhard Miklautz [Thu, 23 Jul 2015 09:14:39 +0000 (11:14 +0200)]
Merge pull request #2789 from akallabeth/start_thread_fix

[Thread] Fixed mutex unlocking and return checks.

9 years agoRemoves unused (big big) array. Adds ifdef for debug stuff.
Petr Sumbera [Wed, 22 Jul 2015 15:51:09 +0000 (08:51 -0700)]
Removes unused (big big) array. Adds ifdef for debug stuff.

9 years agochannels/smartcard: fix possible mszReaders leak in smartcard_ListReaders(A/W)_Call
Kirill Kotyagin [Wed, 22 Jul 2015 14:25:17 +0000 (17:25 +0300)]
channels/smartcard: fix possible mszReaders leak in smartcard_ListReaders(A/W)_Call

9 years agochannels/smartcard: make smartcard_ListReaders(A/W)_Call return PCSC error statuses...
Kirill Kotyagin [Wed, 22 Jul 2015 13:56:24 +0000 (16:56 +0300)]
channels/smartcard: make smartcard_ListReaders(A/W)_Call return PCSC error statuses to the server

9 years agofixed audioserver
Martin Haimberger [Wed, 22 Jul 2015 10:16:46 +0000 (03:16 -0700)]
fixed audioserver

if no data could be read, the ERROR_NO_DATA is returend to
indicate a further read.

9 years agofixed some remakes and compiler errors
Martin Haimberger [Wed, 22 Jul 2015 09:36:24 +0000 (02:36 -0700)]
fixed some remakes and compiler errors

9 years agoThis array is so big that it eats whole stack for the thread and makes
Petr Sumbera [Tue, 21 Jul 2015 16:20:57 +0000 (09:20 -0700)]
This array is so big that it eats whole stack for the thread and makes
the process dump core on some systems (e.g. Solaris).

9 years agoMerge pull request #2751 from realjiangms/shadow_fix_compile_error_win
Bernhard Miklautz [Mon, 20 Jul 2015 15:23:23 +0000 (17:23 +0200)]
Merge pull request #2751 from realjiangms/shadow_fix_compile_error_win

server/shadow: Fix compile error on win32.

9 years agoMerge pull request #2 from bmiklautz/pull/2785
MartinHaimberger [Mon, 20 Jul 2015 13:10:55 +0000 (15:10 +0200)]
Merge pull request #2 from bmiklautz/pull/2785

rdpsnd: restore old behavior and fixes

9 years agordpsnd: restore old behavior and fixes
Bernhard Miklautz [Mon, 20 Jul 2015 10:28:49 +0000 (12:28 +0200)]
rdpsnd: restore old behavior and fixes

* oss: fix function signature
* autodetection - if only /sound is given all enabled
  plugins are tried in order and the first successful loaded is used.
- this restores the previous behavior
* alsa/pulse fix command line parsing - no parameters shouldn't be
  treated as error

9 years agoRemoving private context on hCard so that transaction will properly unlock when conte...
Rostislav Kondratenko [Fri, 17 Jul 2015 15:13:41 +0000 (18:13 +0300)]
Removing private context on hCard so that transaction will properly unlock when context is released.

9 years agoFixing condition on SCardIsValidContext to be true when context is valid
Rostislav Kondratenko [Fri, 17 Jul 2015 15:13:02 +0000 (18:13 +0300)]
Fixing condition on SCardIsValidContext to be true when context is valid

9 years agoRe-enabled PCSC-Lite transactions and fixed smartcard deinitialization so it will...
Rostislav Kondratenko [Fri, 17 Jul 2015 13:37:44 +0000 (16:37 +0300)]
Re-enabled PCSC-Lite transactions and fixed smartcard deinitialization so it will release all contexts to unblock calls waiting for transactions

9 years agoMerge pull request #2791 from bmiklautz/100percent
MartinHaimberger [Fri, 17 Jul 2015 10:30:20 +0000 (12:30 +0200)]
Merge pull request #2791 from bmiklautz/100percent

transport: fix regression introduced with PR #2770

9 years agotransport: fix regression introduced with PR #2770
Bernhard Miklautz [Fri, 17 Jul 2015 10:06:41 +0000 (12:06 +0200)]
transport: fix regression introduced with PR #2770

When the event is reset in transport_check_fds xfreerdp doesn't work and
consumes 100% CPU (see #2790). On windows this is require otherwise the
CPU consumption is 100% there.
This quick fix only resets the event on windows. It's a working approach
but definitely not the final solution.