Richard Lander [Thu, 12 Feb 2015 06:59:38 +0000 (22:59 -0800)]
Respond to PR feedback on DAC filenames
dotnet-bot [Thu, 12 Feb 2015 06:49:15 +0000 (22:49 -0800)]
Add CLR coding guide
dotnet-bot [Thu, 12 Feb 2015 06:48:26 +0000 (22:48 -0800)]
Add stack walking document
Richard Lander [Thu, 12 Feb 2015 06:40:28 +0000 (22:40 -0800)]
Update glossary based on issue #209
Jan Kotas [Thu, 12 Feb 2015 02:52:52 +0000 (18:52 -0800)]
Merge pull request #211 from kangaroo/issue-199
Implement JIT_MemSet and JIT_MemCpy for clang
Jan Kotas [Thu, 12 Feb 2015 02:46:19 +0000 (18:46 -0800)]
Merge pull request #207 from poizan42/fix-abs-64bit
Add abs(__int64) overload for 64-bit targets. Fixes #143
Matt Ellis [Thu, 12 Feb 2015 01:47:26 +0000 (17:47 -0800)]
Merge pull request #221 from ellismg/palsuite-line-endings
Force PAL test lists to have Unix line endings
Geoff Norton [Thu, 12 Feb 2015 01:26:34 +0000 (17:26 -0800)]
Ensure that we call memcpy from the PLT on linux
Jan Kotas [Thu, 12 Feb 2015 01:20:21 +0000 (17:20 -0800)]
Merge pull request #219 from dotnet-bot/from-tfs
Merge changes from TFS
Matt Ellis [Wed, 11 Feb 2015 22:22:26 +0000 (14:22 -0800)]
Force PAL test lists to have Unix line endings
A common workflow for some folks on our team is to check out the Git
repository, then share that folder out over to Linux. In this case,
we need the pal test files to have Unix line endings, even in the case
where core.autocrlf = true, which is the case on Windows.
My hunch is that we would also need this even if we didn't do this,
since otherwise changes to this file will be mirrored back to TFS with
DOS line endings, which would break building the TFS version when
checked out, so it's likely a good idea to do this anyway, even if the
leading factor is a somewhat odd workflow.
Matt Mitchell [Thu, 12 Feb 2015 00:21:59 +0000 (00:21 +0000)]
Merge pull request #215 from mmitche/sos-in-dev-package
Add sos to the development package
John Chen [Thu, 12 Feb 2015 00:05:19 +0000 (16:05 -0800)]
Fix ARM Ready To Run: A dynamic helper generator was not allocating enough memory.
[tfs-changeset: 1414126]
Jan Vorlicek [Thu, 12 Feb 2015 00:00:34 +0000 (01:00 +0100)]
Merge pull request #217 from sergiy-k/disable-pal-sscanf-tests
Disable a few PAL sscanf test cases
Sergiy Kuryata [Wed, 11 Feb 2015 23:13:42 +0000 (15:13 -0800)]
Disable a few PAL sscanf test cases
These tests need to be temporary disabled untill the issue https://github.com/dotnet/coreclr/issues/161 is fixed. This needs to be done in order to enable running PAL tests in the lab. Currently these test cases fail on Mac and Linux release builds.
Kasper F. Brandt [Wed, 11 Feb 2015 09:02:49 +0000 (10:02 +0100)]
Add abs(__int64) overload for 64-bit targets. Fixes #143
Matt Mitchell [Wed, 11 Feb 2015 22:03:09 +0000 (14:03 -0800)]
Add sos to the development package
AlexGhiondea [Wed, 11 Feb 2015 21:01:55 +0000 (13:01 -0800)]
Merge pull request #189 from akoeplinger/fix-filename-casing
Correct casing of file paths in mscorlib
AlexGhiondea [Wed, 11 Feb 2015 19:53:04 +0000 (11:53 -0800)]
Merge pull request #212 from poizan42/fix-hardcoded-tools-resgen-path
Use $(SDK40ToolsPath) to get path to ResGen instead of hardcoding "NETFX 4.5.1 Tools".
Geoff Norton [Wed, 11 Feb 2015 19:31:28 +0000 (11:31 -0800)]
Remove the CPP stubs and ensure to mark the leaf end
Kasper F. Brandt [Wed, 11 Feb 2015 19:07:17 +0000 (20:07 +0100)]
Use $(SDK40ToolsPath) to get path to ResGen instead of hardcoding "NETFX 4.5.1 Tools".
Fixes #210
Geoff Norton [Wed, 11 Feb 2015 05:56:48 +0000 (21:56 -0800)]
Implement JIT_MemSet and JIT_MemCpy for clang
The windows build has a hand written version of these functions, but
modern systems should have an equivalent performant version of this.
We do need to wrap them to get the trap for a null reference exception,
but after that we can tail call directly.
Alexander Köplinger [Tue, 10 Feb 2015 18:54:29 +0000 (19:54 +0100)]
Correct casing of file paths in mscorlib
Some of the files had a different path/filename casing in the project reference than on disk.
Jan Kotas [Wed, 11 Feb 2015 07:14:37 +0000 (23:14 -0800)]
Merge pull request #179 from maksqwe/hresult_return_fix
AcquireNoThrow(): return type must be HRESULT
Jan Kotas [Wed, 11 Feb 2015 06:44:58 +0000 (22:44 -0800)]
Merge pull request #180 from maksqwe/check_result_fix
Properly check return value of OpenProcessToken()
Rich Lander [Wed, 11 Feb 2015 06:44:11 +0000 (22:44 -0800)]
Merge pull request #205 from richlander/master
Update docs and links to docs
Richard Lander [Wed, 11 Feb 2015 06:29:07 +0000 (22:29 -0800)]
Make links repo-relative
Richard Lander [Wed, 11 Feb 2015 06:25:29 +0000 (22:25 -0800)]
Update documentation and links
Sergiy Kuryata [Wed, 11 Feb 2015 04:56:50 +0000 (20:56 -0800)]
Merge pull request #191 from dotnet-bot/from-tfs
Merge changes from TFS
Lubomir Litchev [Wed, 11 Feb 2015 04:21:41 +0000 (20:21 -0800)]
Fix assignment of float register when this present for System V systems
This change addresses few issues:
1. It shuts off an assert that is relevant for Windows AMD64 calling conventions.
2. It doesn't initialize stack offset for any args - on System V there is no outgoing args space for the callee reserved. And the spilled param offsets are calculated later than the init of arg vars.
3. It stops assigning the first float register to use to the last used int register. The float registers are managed independently. In presence of this pointer the first float register on the callee side was calculated wrongly.
No asmdiffs for Windows. DDR tests passed.
[tfs-changeset: 1413622]
AlexGhiondea [Wed, 11 Feb 2015 03:31:46 +0000 (19:31 -0800)]
Merge pull request #172 from KindDragon/master
Add an .editorconfig file
Rich Lander [Wed, 11 Feb 2015 00:32:41 +0000 (16:32 -0800)]
Merge pull request #190 from akoeplinger/patch-1
Fix typos in botr-faq.md
Rich Lander [Wed, 11 Feb 2015 00:31:42 +0000 (16:31 -0800)]
Merge pull request #134 from poizan42/add-glossary
Add glossary to documentation
Alexander Köplinger [Wed, 11 Feb 2015 00:05:22 +0000 (01:05 +0100)]
Fix typos in botr-faq.md
Sergiy Kuryata [Tue, 10 Feb 2015 23:32:45 +0000 (15:32 -0800)]
Merge pull request #187 from nico/warnfix
Fix a few Wextra-tokens warnings.
Nico Weber [Tue, 10 Feb 2015 22:16:47 +0000 (14:16 -0800)]
Fix a few Wextra-tokens warnings.
Rich Lander [Tue, 10 Feb 2015 18:47:39 +0000 (10:47 -0800)]
Merge pull request #184 from richlander/master
Add BotR FAQ
Matt Mitchell [Tue, 10 Feb 2015 17:27:03 +0000 (17:27 +0000)]
Merge pull request #185 from mmitche/gitter-badger
Gitter badger
Matt Mitchell [Tue, 10 Feb 2015 17:26:17 +0000 (09:26 -0800)]
Make column bold
Matt Mitchell [Tue, 10 Feb 2015 17:23:58 +0000 (09:23 -0800)]
Add gitter badge
dotnet-bot [Tue, 10 Feb 2015 16:28:49 +0000 (08:28 -0800)]
Add BOTR FAQ
Maks Naumov [Tue, 10 Feb 2015 07:43:45 +0000 (09:43 +0200)]
Properly check return value of OpenProcessToken()
Return type of OpenProcessToken() is BOOL.
Maks Naumov [Tue, 10 Feb 2015 07:17:57 +0000 (09:17 +0200)]
AcquireNoThrow(): return type must be HRESULT
But all users of this function take result like "HRESULT".
Wes Haggard [Tue, 10 Feb 2015 05:30:30 +0000 (21:30 -0800)]
Merge pull request #173 from AlexGhiondea/fixbuild
Provide defaults for the values that come from the build.cmd script.
Matt Mitchell [Mon, 9 Feb 2015 23:45:30 +0000 (23:45 +0000)]
Merge pull request #97 from mmitche/dev-package
Add development package to build
Rama krishnan Raghupathy [Mon, 9 Feb 2015 23:38:57 +0000 (15:38 -0800)]
Merge pull request #175 from nicodeslandes/fix_buildtest_error_message
Fixed error message when running tests\buildtest.cmd
Matt Mitchell [Wed, 4 Feb 2015 22:30:08 +0000 (14:30 -0800)]
Add new nuget package for development usage
Add new nuget package that can be developed against. Also modify the cmake lists of a few directories to add in missing PDBs.
alexghiondea [Mon, 9 Feb 2015 21:32:28 +0000 (13:32 -0800)]
Provide defaults for the values that come from the build.cmd script.
Arkady Shapkin [Mon, 9 Feb 2015 20:23:03 +0000 (23:23 +0300)]
Add an .editorconfig file
What is .editorconfig:
http://editorconfig.org/#overview
Plugins for IDEs to support:
http://editorconfig.org/#download
Sergiy Kuryata [Mon, 9 Feb 2015 18:56:09 +0000 (10:56 -0800)]
Merge pull request #160 from kangaroo/master
Set the mach exception default to MachException_SuppressDebugging
Nicolas Deslandes [Mon, 9 Feb 2015 18:37:25 +0000 (18:37 +0000)]
Removed an extra space in buildtest.cmd, causing it to display an error.
Jan Kotas [Mon, 9 Feb 2015 17:47:08 +0000 (09:47 -0800)]
Merge pull request #167 from dotnet-bot/from-tfs
Merge changes from TFS
Jan Kotas [Mon, 9 Feb 2015 17:21:18 +0000 (09:21 -0800)]
Fix build break with minimal Windows OS CRT
va_copy is not available in the minimal Windows OS CRT
[tfs-changeset: 1412529]
Jan Kotas [Mon, 9 Feb 2015 17:00:39 +0000 (09:00 -0800)]
Merge pull request #166 from richlander/master
Update mscorlib doc and add entry to readme
Richard Lander [Mon, 9 Feb 2015 16:23:41 +0000 (08:23 -0800)]
Update mscorlib doc and add entry to readme
Jan Kotas [Mon, 9 Feb 2015 15:04:56 +0000 (07:04 -0800)]
Merge pull request #163 from richlander/master
Add Mscorlib and Calling Into the Runtime document
Sergiy Kuryata [Mon, 9 Feb 2015 07:15:12 +0000 (23:15 -0800)]
Merge pull request #138 from kangaroo/va_list_safety
va_list safety
dotnet-bot [Mon, 9 Feb 2015 06:43:11 +0000 (22:43 -0800)]
Add Mscorlib and Calling Into the Runtime document
Matt Ellis [Mon, 9 Feb 2015 06:42:45 +0000 (22:42 -0800)]
Merge pull request #162 from dotnet-bot/from-tfs
Merge changes from TFS
Rahul Kumar [Mon, 9 Feb 2015 06:04:06 +0000 (22:04 -0800)]
precompile common headers to reduce build time for win builds. With this build time on my machine has reduced from 19mins to 10mins.
[tfs-changeset: 1412352]
Geoff Norton [Mon, 9 Feb 2015 04:36:28 +0000 (20:36 -0800)]
Set the mach exception default to MachException_SuppressDebugging for now, so that debugging with lldb isnt painful
Jan Kotas [Sun, 8 Feb 2015 19:06:12 +0000 (11:06 -0800)]
Merge pull request #155 from kangaroo/master
config.h.osx was debug generated, causing issues with release builds
Sergiy Kuryata [Sun, 8 Feb 2015 19:02:29 +0000 (11:02 -0800)]
Merge pull request #146 from poizan42/fix-writeable-strings
Fix writeable string warnings. Closes #139
Geoff Norton [Sun, 8 Feb 2015 18:12:12 +0000 (10:12 -0800)]
Minor code structure refactoring as requested by @jkotas in PR #138
Geoff Norton [Sun, 8 Feb 2015 18:04:55 +0000 (10:04 -0800)]
Merge remote-tracking branch 'origin/master' into va_list_safety
Geoff Norton [Sun, 8 Feb 2015 17:59:22 +0000 (09:59 -0800)]
Merge remote-tracking branch 'origin/master'
Geoff Norton [Sun, 8 Feb 2015 17:59:09 +0000 (09:59 -0800)]
Do not define _DEBUG on all builds.
Jan Kotas [Sun, 8 Feb 2015 14:29:44 +0000 (06:29 -0800)]
Merge pull request #69 from mathstuf/cmake-touchups
CMake touchups
Jan Kotas [Sun, 8 Feb 2015 06:19:15 +0000 (22:19 -0800)]
Merge pull request #149 from richlander/master
Update author format
Rich Lander [Sun, 8 Feb 2015 06:14:14 +0000 (22:14 -0800)]
Update author format
Kasper F. Brandt [Sun, 8 Feb 2015 02:39:59 +0000 (03:39 +0100)]
Fix writeable string warnings. Closes #139
Ben Boeckel [Wed, 4 Feb 2015 16:53:59 +0000 (11:53 -0500)]
Use list(APPEND) rather than set(var ${var} ...) in CMake
This avoids a variable expansion and avoids the chances of a typo being
introduced in variable names.
Ben Boeckel [Wed, 4 Feb 2015 16:41:05 +0000 (11:41 -0500)]
Simplify configuration-specific definitions in CMake
Factor out the configurations supported rather than duplicating the
logic three times.
Ben Boeckel [Wed, 4 Feb 2015 16:39:06 +0000 (11:39 -0500)]
Use foreach(IN LISTS) syntax in CMake code
It avoids extra separation on semicolons if there are any and skips a
variable expansion.
Ben Boeckel [Wed, 4 Feb 2015 16:34:34 +0000 (11:34 -0500)]
Remove excess arguments to endfunction() and else()
Arguments to else() are always confusing and endfunction only needs to
match the first argument.
Matt Ellis [Sun, 8 Feb 2015 01:35:26 +0000 (17:35 -0800)]
Merge pull request #142 from dotnet-bot/from-tfs
Merge changes from TFS
Matt Ellis [Sun, 8 Feb 2015 00:00:27 +0000 (16:00 -0800)]
Merge pull request #140 from dotnet-bot/from-tfs
Merge changes from TFS
Sergiy Kuryata [Sat, 7 Feb 2015 23:16:27 +0000 (15:16 -0800)]
Fix undefined symbols in release build of libcoreclr on Linux
When building a release version of libcoreclr.so on Linux the LLVM toolchain makes optimizations that result in undefined symbols in libcoreclr.so which causes dlopen(“libcoreclr.so”) to fail at runtime. There were three problematic functions:
1. CQuickMemoryBase<SIZE, INCREMENT>::ReSizeNoThrow(SIZE_T iItems)
2. FixupDispatcherContext(...)
3. CodeGen::inst_set_SV_var(GenTreePtr tree); - this function is marked as inline and has the entire body under “#ifdef DEBUG”.
To fix the problem with ReSizeNoThrow I added the “__attribute__((used))” attribute to the declaration of the function. This attribute is enabled for the llvm toolchain only. For the other two functions I have simply removed ‘inline’ since these functions are not performance critical.
[tfs-changeset: 1412107]
Matt Ellis [Sat, 7 Feb 2015 23:09:23 +0000 (15:09 -0800)]
Add missing .gitmirrorall file.
We mirror the newly created Documentation fully between TFS and Git.
[tfs-changeset: 1412105]
Geoff Norton [Sat, 7 Feb 2015 21:48:51 +0000 (13:48 -0800)]
va_copy exists on windows now as well as a define, so we can unify this code
Geoff Norton [Sat, 7 Feb 2015 20:09:33 +0000 (12:09 -0800)]
Ensure that every usage of va_start is complemented by a va_end
Geoff Norton [Sat, 7 Feb 2015 19:03:46 +0000 (11:03 -0800)]
va_arg can modify the va_list according to the specification
SString will attempt to use va_list multiple times in the scenario where the
target buffer is not large enough. On platforms like OSX, va_arg modifies
the va_list, making these re-attempts overread and fault. The solution is to
va_copy the va_list prior to use, to ensure the original is maintained for
future use.
Gaurav Khanna [Sat, 7 Feb 2015 17:15:45 +0000 (09:15 -0800)]
Merge pull request #108 from jkotas/master
Fix Windows x64 corerun.exe to run anycpu 32-bit preferred exe
Jan Kotas [Sat, 7 Feb 2015 17:15:06 +0000 (09:15 -0800)]
Merge pull request #130 from njy/patch-1
possible unresolved tension
Jan Kotas [Sat, 7 Feb 2015 16:58:04 +0000 (08:58 -0800)]
Merge pull request #119 from cwmiller/fix-linux-short-filenames
Fix std::out_of_range exception with short filenames (Linux)
Kasper F. Brandt [Sat, 7 Feb 2015 15:47:28 +0000 (16:47 +0100)]
Add glossary to documentation
njy [Sat, 7 Feb 2015 12:28:41 +0000 (13:28 +0100)]
possible unresolved tension
http://xkcd.com/859/
Jan Kotas [Sat, 7 Feb 2015 10:29:31 +0000 (02:29 -0800)]
Merge pull request #75 from PashaPash/resourceset_deadlock
Fixed deadlock in System.Resources.ResourceSet
Jan Kotas [Sat, 7 Feb 2015 10:14:47 +0000 (02:14 -0800)]
Merge pull request #125 from kangaroo/issue-120
-nostdinc++ is not recognized by apple clang, but its also not needed
Jan Kotas [Sat, 7 Feb 2015 10:03:18 +0000 (02:03 -0800)]
Merge pull request #126 from vkairys/documentation-links
Update intro-to-clr.md
vkairys [Sat, 7 Feb 2015 08:28:46 +0000 (10:28 +0200)]
Update intro-to-clr.md
Geoff Norton [Sat, 7 Feb 2015 06:41:41 +0000 (22:41 -0800)]
-nostdinc++ is not recognized by apple clang, but its also not needed
Jan Kotas [Sat, 7 Feb 2015 03:49:05 +0000 (19:49 -0800)]
Merge pull request #117 from kangaroo/osx
Initial Mac OSX Support
Geoff Norton [Sat, 7 Feb 2015 03:18:03 +0000 (19:18 -0800)]
Remove static casting in favor of a helper method so we retain type safety with the compiler
Chase Miller [Sat, 7 Feb 2015 03:04:39 +0000 (22:04 -0500)]
Fix std::out_of_range exception with short filenames (Linux)
An unsigned integer was being used while scanning the CLR path to locate assemblies. If a file existed in the directory with a name shorter than the longest extension being checked for (.ni.dll), then the variable would underflow and cause an exception when used as an index on the filename.
Geoff Norton [Sat, 7 Feb 2015 02:53:57 +0000 (18:53 -0800)]
Refactor to be explicit about the fact that there is no handler yet
Geoff Norton [Sat, 7 Feb 2015 02:51:55 +0000 (18:51 -0800)]
Remove PowerPC code, as its unused anymore
Geoff Norton [Sat, 7 Feb 2015 02:51:33 +0000 (18:51 -0800)]
Remove the old version of DBG_CheckStackAlignment and make sure the assembly version is guarded on _DEBUG like the original
Geoff Norton [Sat, 7 Feb 2015 02:48:29 +0000 (18:48 -0800)]
Remove dead NPROCS code now that we use getconf
Geoff Norton [Sat, 7 Feb 2015 02:40:15 +0000 (18:40 -0800)]
Remove cordbi from the OSX build, since its still missing some symbols
Geoff Norton [Sat, 7 Feb 2015 01:09:25 +0000 (17:09 -0800)]
Refactor the DBG_CheckStackAlignment support to be more consistent with the rest of the PAL