Geoff Kizer [Tue, 2 Jul 2019 10:22:04 +0000 (03:22 -0700)]
clean up HTTP2 protocol exception handling
Commit migrated from https://github.com/dotnet/corefx/commit/
63e8aa4481928d4dc58c4cb563bfab7fdde322d0
Krzysztof Wicher [Mon, 1 Jul 2019 20:44:59 +0000 (13:44 -0700)]
Do not directly abort connection on GOAWAY (dotnet/corefx#39036)
* Do not directly abort connection on GOAWAY
* Address feedback and add disabled GOAWAY tests
* remove redundant frame ignoring logic
Commit migrated from https://github.com/dotnet/corefx/commit/
cc6435bb9ec069c57a3d155944b5729b3f06439f
Tanner Gooding [Mon, 1 Jul 2019 20:06:12 +0000 (13:06 -0700)]
Fixing up the System.Text.Json to handle floats/doubles according to the underlying framework (dotnet/corefx#38322)
* Fixing some doc comments and adjusting Utf8JsonWriter to try and roundtrip float/double on .NET Framework.
* Fixing up various tests to handle framework vs core differences for float/double
* Changing the Utf8JsonWriter to replicate the .NET Core 3.0 Utf8Formatter.TryFormat method.
* Modifying some tests to enforce netfx and netcore test the same things.
* Fixing up some code comments to clarify .NET Core 3.0 or higher vs anything else.
* Adding code comments explaining why we duplicate the netcoreapp3.0 Utf8Formatter logic.
* Removing three usages of var.
* Responding to more PR feedback.
* ifdef out the ISpanFormattable parts of the TryFormatDouble and TryFormatSingle shims for netfx
* Removing an unnecessary using that was added during a rebase.
* Changing some RangePassFloatingPoint scenarios to epect JsonException rather than FormatException
* Removing dependency on Span from the TryFormatSingle/TryFormatDouble fallback paths
* Resolving some more PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
ea33aae808f5f7d26109db5571640d1c4a9ee700
Levi Broderick [Mon, 1 Jul 2019 19:52:46 +0000 (12:52 -0700)]
Add unit tests for EncoderNLS / DecoderNLS fallbacks (dotnet/corefx#38937)
Commit migrated from https://github.com/dotnet/corefx/commit/
ef5b086fc5f134e3244d0bca10d70db8055fa1c6
Jeremy Barton [Mon, 1 Jul 2019 19:15:15 +0000 (12:15 -0700)]
Standardize error for RSACng.ImportParameters (dotnet/corefx#39087)
Windows 7, 8.1, 10-RS4, and 10-19H1 all fail to import the key described in the
RSAXml.FromNonsenseXml test with a WindowsCryptographicException from
NCryptImportKey reporting NTE_NOT_SUPPORTED.
Windows 10-RS1 successfully imports the invalid key, not realizing that it is
invalid until use -- e.g. calling SignData throws a
WindowsCryptographicException reporting NTE_INVALID_PARAMETER.
By copying the same D.Length == Modulus.Length, everything else == halfModulusLength
check from RSACryptoServiceProvider, invalid keys of this form are now
consistently rejected in ImportParameters, and the exception message is
a bit friendlier.
Commit migrated from https://github.com/dotnet/corefx/commit/
be698f30a88cf5c287f01276587ea5c740db8802
Stephen Toub [Mon, 1 Jul 2019 19:12:54 +0000 (15:12 -0400)]
Fix MaxResponseHeadersLength assert for value string (dotnet/corefx#39085)
I'd fixed the assert message to contain the right value when MaxResponseHeadersLength was exceeded, but this error message isn't used for WinHttpHandler, and thus it doesn't contain the value. Special-case the check for just SocketsHttpHandler.
Commit migrated from https://github.com/dotnet/corefx/commit/
e78b22b59d52e14d6099fd96cd713dc9d400103c
Carlos Sanchez Lopez [Mon, 1 Jul 2019 19:10:57 +0000 (12:10 -0700)]
Update ownership for System.IO.Packaging (dotnet/corefx#39088)
Commit migrated from https://github.com/dotnet/corefx/commit/
5465357d7396730da415ab3406aa288c8e13140c
Steve Harter [Mon, 1 Jul 2019 18:51:16 +0000 (11:51 -0700)]
JsonElement null support and serialize ext data without ext prop name (dotnet/corefx#39042)
Commit migrated from https://github.com/dotnet/corefx/commit/
8e2f9a765f6533d17e711365ce2a3064b8d1dfc6
Viktor Hofer [Mon, 1 Jul 2019 17:48:45 +0000 (19:48 +0200)]
Generate framework manifest file (dotnet/corefx#38792)
* Generate framework manifest file
* Manual darc update from build '
20190629.2'
* Handle DefaultReferenceExclusions
* Add runtime assets filter
* Generate manifest file for all verticals
Commit migrated from https://github.com/dotnet/corefx/commit/
c224a2400aae6abab701120f9e081bb0707d69f2
Tom Deseyn [Mon, 1 Jul 2019 16:15:24 +0000 (18:15 +0200)]
WaitIdAnyExitedNoHangNoWait: handle waitid returning 0 for no waitable children (dotnet/corefx#39078)
* WaitIdAnyExitedNoHangNoWait: handle waitid returning 0 for no waitable children
* clear using memset
Commit migrated from https://github.com/dotnet/corefx/commit/
5c83394112febe1b481ab1c0b61a45c850677165
Konstantin Baladurin [Mon, 1 Jul 2019 16:14:24 +0000 (19:14 +0300)]
Fix arm32-ci-script.sh (dotnet/corefx#38398)
Commit migrated from https://github.com/dotnet/corefx/commit/
d42fc2fe49b7915aa9ad1bb1998f325761691de6
Matt Kotsenas [Mon, 1 Jul 2019 15:46:25 +0000 (08:46 -0700)]
Remove dead code in System.Private.* namespaces (dotnet/corefx#36588)
* Remove dead code in System.Private.DataContractSerialization
* Remove dead code in System.Private.Uri
* Remove dead code in System.Private.Xml
* Remove dead code in System.Private.Xml.Linq
* Partial revert of
ab0a4ab9f47721b3eabf07d29
Partial revert of
ab0a4ab9f47721b3eabf07d29 for public APIs that got
flagged by accident.
Commit migrated from https://github.com/dotnet/corefx/commit/
d130beae519dc1486cb2af6251c089b6400e6eaf
Stephen Toub [Mon, 1 Jul 2019 15:09:52 +0000 (11:09 -0400)]
Disable Http2_PendingSend_SendsReset test sporadically failing in CI (dotnet/corefx#39077)
Commit migrated from https://github.com/dotnet/corefx/commit/
3a3c44a93ba968ada2d0c3ea0e997fcb4849a7d5
Stephen Toub [Mon, 1 Jul 2019 15:09:38 +0000 (11:09 -0400)]
Disable VeryLargePart Packaging test (dotnet/corefx#39076)
Commit migrated from https://github.com/dotnet/corefx/commit/
3a27e26eae2e84a58bc92e4f4549313a81af8533
Tomas Weinfurt [Mon, 1 Jul 2019 13:35:16 +0000 (15:35 +0200)]
move tests with SlowTestStream to outerloop (dotnet/corefx#39071)
Commit migrated from https://github.com/dotnet/corefx/commit/
fcaeb097c91b1dbf75ff675442a624802460fb47
Viktor Hofer [Sat, 29 Jun 2019 19:53:19 +0000 (21:53 +0200)]
Make CoreFx.Private.TestUtilites RID-agnostic (dotnet/corefx#36207)
* Make CoreFx.Private.TestUtilites RID-agnostic
* Add version checks for other distros
https://github.com/dotnet/corefx/commit/dotnet/corefx@
4f0d10773ccbb4849b869b6a0a73d5938f1804bd
Porting fix over into PlatformDetection.
* Build test lib in advance for VS support
* Disable pretest in AllConfigurations
Commit migrated from https://github.com/dotnet/corefx/commit/
d3d144fad9b600a0fc1ca6fc7d65c247fddd9f04
Stephen Toub [Sat, 29 Jun 2019 19:38:08 +0000 (15:38 -0400)]
Fix exception messages for max response headers length (dotnet/corefx#39038)
Some of the call sites use a value whose units is kbytes, but the exception message refers to bytes.
Commit migrated from https://github.com/dotnet/corefx/commit/
0decf070fb59b22b13d43082ac5333028ff53b1b
Jose Perez Rodriguez [Sat, 29 Jun 2019 07:06:28 +0000 (00:06 -0700)]
Fixing small issue with reference assemblies not setting BaseIntermediateOutputPath (dotnet/corefx#39003)
* Fixing small issue with reference assemblies not setting BaseIntermediateOutputPath
* Add BaseOutputPath to ref assembly
Commit migrated from https://github.com/dotnet/corefx/commit/
901a1d554a7bcb489eb363fb724c9d294ec35940
Geoff Kizer [Sat, 29 Jun 2019 06:11:32 +0000 (23:11 -0700)]
Merge pull request dotnet/corefx#39047 from geoffkizer/refusedstream
enable request retry when receiving REFUSED_STREAM protocol error
Commit migrated from https://github.com/dotnet/corefx/commit/
1b71b8945c506c801fbc77e61a85df630440b3af
Kevin Jones [Sat, 29 Jun 2019 06:01:53 +0000 (02:01 -0400)]
Lookup OID if only friendly name is specified for ECCurve
Fixes the use of Windows-specific curve identifiers with ECDsaOpenSsl
Commit migrated from https://github.com/dotnet/corefx/commit/
0509d602e8b83468279151cdec11694484b07a86
Geoff Kizer [Sat, 29 Jun 2019 03:18:27 +0000 (20:18 -0700)]
review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
95bca001973dfcd512de1830fd3898306462d1cf
Stephen Toub [Fri, 28 Jun 2019 19:42:42 +0000 (15:42 -0400)]
Ignore NullableContextAttributes in System.ComponentModel.Composition.Registration tests
Commit migrated from https://github.com/dotnet/corefx/commit/
794eaed96342da0072279d0936fafa9d16a468ae
Stephen Toub [Fri, 28 Jun 2019 14:50:25 +0000 (10:50 -0400)]
Workaround potential compiler nullability bug
Commit migrated from https://github.com/dotnet/corefx/commit/
5e3b0ae04986e9527eb51d3717ab96727c215c03
Jan Kotas [Thu, 27 Jun 2019 17:38:07 +0000 (10:38 -0700)]
Fix StackTrace test for pretty-printing updates
Commit migrated from https://github.com/dotnet/corefx/commit/
031cf3cd15684cb6f80d2a7e9038c99a430ab449
Geoff Kizer [Sat, 29 Jun 2019 00:42:27 +0000 (17:42 -0700)]
enable request retry when receiving REFUSED_STREAM protocol error
Commit migrated from https://github.com/dotnet/corefx/commit/
b251108b7fd0b3601eb6f8561ec11fd966671a0e
Krzysztof Wicher [Fri, 28 Jun 2019 22:45:40 +0000 (15:45 -0700)]
Harden System.Net.Http.Functional.Tests.HttpClientHandlerTest_Http2.Dispose_ProcessingResponse_OK (dotnet/corefx#39008)
* harden Dispose_ProcessingResponse_OK
* Add timeout to MRE.Wait
* remove duplicate test
Commit migrated from https://github.com/dotnet/corefx/commit/
124cceaae8309fe0d357e142ae5a0084101107c2
Stephen Toub [Fri, 28 Jun 2019 20:12:44 +0000 (16:12 -0400)]
Added a few more options to the HttpStress test (dotnet/corefx#39040)
- Ability to specify most options on the command-line.
- Several more client operations, including one with lots of headers and one where the server aborts the connection.
Commit migrated from https://github.com/dotnet/corefx/commit/
a13789324692ffa1f8c42c1da34c2c1de2103ba7
Eric Erhardt [Fri, 28 Jun 2019 20:12:19 +0000 (15:12 -0500)]
Clean up unnecessary ObjectModel suppressions from ApiCompat baseline. (dotnet/corefx#39029)
Commit migrated from https://github.com/dotnet/corefx/commit/
ca85abea33bfd01770c252b46dec7783761bf0b6
Steve Harter [Fri, 28 Jun 2019 19:20:24 +0000 (12:20 -0700)]
Add depth check for bad converters (dotnet/corefx#38956)
Commit migrated from https://github.com/dotnet/corefx/commit/
1232838843670020a7128ca548abeafb13164e86
Hugh Bellamy [Fri, 28 Jun 2019 18:09:44 +0000 (19:09 +0100)]
Fix System.ComponentModel.Primitives NREs (dotnet/corefx#39000)
Commit migrated from https://github.com/dotnet/corefx/commit/
98cebc878259cb614c5d360cbbce20dba3547e2b
Prashanth Govindarajan [Fri, 28 Jun 2019 16:42:10 +0000 (09:42 -0700)]
Improve default handling in ReadOnlySequence.Slice (dotnet/corefx#38431)
* Improve default handling in ReadOnlySequence.Slice
Commit migrated from https://github.com/dotnet/corefx/commit/
5f6cba88228bc48e4d0cb6ce2608eeeb7938c71b
Hugh Bellamy [Fri, 28 Jun 2019 13:17:50 +0000 (14:17 +0100)]
Fix typos in test names (dotnet/corefx#39025)
Commit migrated from https://github.com/dotnet/corefx/commit/
59d4a3ed40125b377083b10c8cb58d5f48522c0a
Stephen Toub [Fri, 28 Jun 2019 13:11:09 +0000 (09:11 -0400)]
Add standalone HTTP stress test (dotnet/corefx#39021)
* Add standalone HTTP stress test
This is a simple standalone stress test that launches Kestrel in-proc, creates an HttpClient, and then concurrently makes lots of requests of varying kinds from the client to the server. It's already discovered a plethora of issues in our HTTP/2 implementation, so I'm checking it in hopes that it can help to enable others to discover more.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
3298cd55f840a8a3fab4450ac64ff3547073f651
Carlos Sanchez Lopez [Fri, 28 Jun 2019 13:07:08 +0000 (06:07 -0700)]
Re-add removed Packaging.props lines related to IntelliSense packages (dotnet/corefx#39017)
* Re-add removed Packaging.props lines related to IntelliSense
* Move intellisense package to common versions.props
Commit migrated from https://github.com/dotnet/corefx/commit/
2e76f3ec5a956547119c653f82f3dbb004f52b8d
Stephen Toub [Fri, 28 Jun 2019 01:24:48 +0000 (21:24 -0400)]
Add more HTTP2 tracing (dotnet/corefx#39011)
Commit migrated from https://github.com/dotnet/corefx/commit/
b8761d4848d42040c81ec25c8b51fd386b97f5f4
Stephen Toub [Thu, 27 Jun 2019 23:30:11 +0000 (19:30 -0400)]
Fix HTTP2 duplex communication with Expect: 100-continue (dotnet/corefx#38995)
Duplex communication (allowing the request body to continue sending as the response body is processed) is currently broken with Expect: 100-continue: it's waiting for the request body to send before it'll return the stream for the response body to the caller. The fix is to simplify the code, and minimize the special handling for Expect: 100-continue to just control if/when the request body is sent, rather than forking all of the logic around the handling of the request/response.
As part of diagnosing this, I added a lot more tracing, which I'm also including.
I also streamlined the CreditManager's wait list to make it slimmer.
Commit migrated from https://github.com/dotnet/corefx/commit/
1833ec4769749dfce2b6dadad5882f208b499796
Stephen Toub [Thu, 27 Jun 2019 23:29:23 +0000 (19:29 -0400)]
Stop disposing of the proxy in HttpConnectionPoolManager.Dispose (dotnet/corefx#38991)
SocketsHttpHandler doesn't own the proxy its given; the lifetime of that proxy is up to the developer supplying it. We may also end up using a global proxy instance if the developer hasn't explicitly supplied one. However, SocketsHttpHandler's internal HttpConnectionPoolManager was disposing of this proxy instance on its disposal. For proxies that implement IDisposable, as our global default proxy does, that can be very problematic; on Windows, our default proxy has a SafeHandle, and once its disposed, every subsequent request to the proxy will fail (an exception gets thrown and then internally eaten). The fix is simply to stop disposing a proxy instance we don't own.
While investigating this, I also made a few style tweaks to WinInetProxyHelper, removing private property setters, so as to better be able to see that certain values were readonly and never changed after construction.
Commit migrated from https://github.com/dotnet/corefx/commit/
c6a849b8d24fc48bb0bbdb9f9165752a4a19459b
Stephen Toub [Thu, 27 Jun 2019 23:27:58 +0000 (19:27 -0400)]
Change CreateProcessLong test helper to use 5m rather than 30s sleep (dotnet/corefx#39002)
The ProcessTestBase.CreateProcessLong helper function is used in situations where we effectively want an infinitely running process, which we then terminate when the test creating it completes. But we also don't want the process to live in forever if something goes wrong with killing it, such as if the parent hangs or is itself terminated. So we instead have it sleep for a "long" period of time, currently 30s. However, in stress runs, that may not be long enough. This bumps it to 5m.
Commit migrated from https://github.com/dotnet/corefx/commit/
1ef14e50f9449544e38091ccb0930bb3d5b97f07
Andy Gocke [Thu, 27 Jun 2019 03:25:53 +0000 (20:25 -0700)]
Ignore NullableContextAttribute in API Compat and fix build break due to Range parsing change
Commit migrated from https://github.com/dotnet/corefx/commit/
b3643ab830694eedffb1c9c80051e41517ea0d5f
Hugh Bellamy [Thu, 27 Jun 2019 18:10:37 +0000 (19:10 +0100)]
Add back support for InstanceDescriptor in DateTimeOffsetConverter (dotnet/corefx#38952)
Commit migrated from https://github.com/dotnet/corefx/commit/
4fd677a3a3d56eea0a934dac398eb3bfd0f0fed1
Krzysztof Wicher [Thu, 27 Jun 2019 17:14:05 +0000 (10:14 -0700)]
Fix BytesConsumed when skipping single line comments (multi-segment) (dotnet/corefx#38965)
* Fix BytesConsumed when skipping single line comments (multi-segment)
* rename ret -> skipSucceeded
Commit migrated from https://github.com/dotnet/corefx/commit/
32f061ccb2d2b6a804f8040717f448d97cbf862d
Santiago Fernandez Madero [Thu, 27 Jun 2019 13:58:49 +0000 (06:58 -0700)]
Tweak custom nullable attributes based on API Review (dotnet/corefx#38977)
Commit migrated from https://github.com/dotnet/corefx/commit/
7dce7868e3b3023ee96edebb96042ca01a8ec368
Jan Kotas [Thu, 27 Jun 2019 06:29:32 +0000 (23:29 -0700)]
Update SDK to 3.0.100-preview7 (dotnet/corefx#38964)
Validate fix for dotnet/coreclrdotnet/corefx#25427
Commit migrated from https://github.com/dotnet/corefx/commit/
6d723b8e5ae3129c0a94252292322fc19673478f
David Cantu [Thu, 27 Jun 2019 01:03:44 +0000 (18:03 -0700)]
Fixed address and port formatting for TCs to use portNumber instead of i incremental (dotnet/corefx#38962)
Commit migrated from https://github.com/dotnet/corefx/commit/
488a6fca1b9f7a9b8c8a945259e8f9e92ef073d3
Jeremy Kuhne [Wed, 26 Jun 2019 23:16:42 +0000 (16:16 -0700)]
Fix array size used by LookupOverflow json test (dotnet/corefx#38961)
dotnet/corefx#37911 fixed a 2x overstimation of the possible byte size of a converted UTF-16 string. The outerloop test that was validating the code wasn't updated to match.
fixes dotnet/corefx#38221
Commit migrated from https://github.com/dotnet/corefx/commit/
7e6534becebff78b567d57c39021a9f511acf140
Frederik Carlier [Wed, 26 Jun 2019 22:32:15 +0000 (00:32 +0200)]
System.Drawing: Consolidate BitmapData class (dotnet/corefx#38838)
* Add shared BitmapData class
* Consolidate BitmapData class
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
e78cb04d339aa9206b6db8eb8224904ecc4529e1
Jeremy Barton [Wed, 26 Jun 2019 22:07:46 +0000 (15:07 -0700)]
Prevent OpenSSL unload at process exit (dotnet/corefx#38936)
* Set OPENSSL_INIT_NO_ATEXIT to prevent shutdown errors from crashing on string lookup
* Fix compilation with 1.1.0 headers
* Remove semi-redundant define of OPENSSL_INIT_NO_ATEXIT
Commit migrated from https://github.com/dotnet/corefx/commit/
324f8ee8c2b0bb5ec316421159f5d3a10f6b6908
Hugh Bellamy [Wed, 26 Jun 2019 22:02:58 +0000 (23:02 +0100)]
Remove dead remoting IUnimplemented code from TypeDescriptor (dotnet/corefx#38940)
Commit migrated from https://github.com/dotnet/corefx/commit/
def264136eb89eeb204ddd90b8781979a703dcbe
Geoff Kizer [Wed, 26 Jun 2019 21:59:38 +0000 (14:59 -0700)]
improve write buffer management and fix buffer size calculation in SendHeadersAsync (dotnet/corefx#38953)
* improve write buffer management and fix buffer size calculation in SendHeadersAsync
* review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
6c6545143ac5bd4c438fad790899124312e1ffe1
Tomáš Matoušek [Wed, 26 Jun 2019 21:30:02 +0000 (14:30 -0700)]
Remove incorrect statement from Portable PDB spec (dotnet/corefx#38963)
Commit migrated from https://github.com/dotnet/corefx/commit/
d91384ac28ecf8e3ac7bae769cd542c2e00717ed
Krzysztof Wicher [Wed, 26 Jun 2019 19:50:43 +0000 (12:50 -0700)]
Utf8JsonReader: Do not allow non-standard line endings in single-line comments (dotnet/corefx#38036)
* Fix handling comments
* Apply feedback, unify Consume and Skip for multi-segment
* address some missed comments
* micro changes
* replace tab with spaces
* apply feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
fc8bd8ec1c622dd27f96d05f1bf05909f3b3cde0
Geoff Kizer [Wed, 26 Jun 2019 19:31:58 +0000 (12:31 -0700)]
Merge pull request dotnet/corefx#38918 from geoffkizer/ignoreframesonclosedstream
ignore invalid frames on closed streams
Commit migrated from https://github.com/dotnet/corefx/commit/
b9c89c4fe2454268a5e883ab269c877287f703ed
Ahson Khan [Wed, 26 Jun 2019 19:01:47 +0000 (12:01 -0700)]
Move Comment token type within the TokenType enum. (dotnet/corefx#38950)
* Move Comment token type within the TokenType enum.
* Fix JsonTokenType to JsonValueType mapping.
* Moves Comment down after PropertyName and address feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
8e5cacf4578feea6ffc533700bcd0e3ebd99c4e3
Jose Perez Rodriguez [Wed, 26 Jun 2019 18:59:59 +0000 (11:59 -0700)]
Making Exceptions serializable (dotnet/corefx#38893)
* Making Exceptions serializable
* Remove EventLog serialization exceptions from tests since they won't work on non-Windows platforms
* Fix build and add internal exceptions as well
* Add parameter-less constructor to RethrowException
* Adding PR Feedback
* Fix allConfigurations build
Commit migrated from https://github.com/dotnet/corefx/commit/
7075587321a1b6b59248b1a6c7ea04fc803eab96
Ahson Khan [Wed, 26 Jun 2019 18:59:32 +0000 (11:59 -0700)]
Do not pass ReadOnlySequence by "in" to the Utf8JsonReader. (dotnet/corefx#38930)
* Do not pass ReadOnlySequence by "in" to the Utf8JsonReader.
* Remove in from the new ctor as well.
Commit migrated from https://github.com/dotnet/corefx/commit/
563bbef3ed9c7029238ae9dbaf61129deee3c53f
Ahson Khan [Wed, 26 Jun 2019 18:58:52 +0000 (11:58 -0700)]
Rename JsonValueType to JsonValueKind and JsonElement.Type to JsonElement.ValueKind. (dotnet/corefx#38943)
* Add JsonDocument.Write, JsonProperty.Write, and rename JsonValueTupe to
JsonValueKind.
* Add JsonDocument.Write API tests.
* Don't use GetPropertyRawBytes and add JsonProperty.Write API tests.
* Make GetPropertyRawValue private again.
* Remove the new Write APIs on JsonDocument, JsonProperty.
Commit migrated from https://github.com/dotnet/corefx/commit/
f08256cbba2b249cc1e5ca67cf4a1c074adf035b
Anirudh Agnihotry [Wed, 26 Jun 2019 18:54:06 +0000 (11:54 -0700)]
Tests for nullable reference types in Span apis (dotnet/corefx#38625)
* Some more null index checks
* adding test for ReadonlySpan overload and refactoring all overloads into a single test
* FIxing the tests with ben change and rebasing
Commit migrated from https://github.com/dotnet/corefx/commit/
96a713d3434af8d443f87874e915f5d36c47a564
Steve Harter [Wed, 26 Jun 2019 18:41:29 +0000 (11:41 -0700)]
Allow Ignore and JsonName attributes to use same property name (dotnet/corefx#38935)
* Allow Ignore and JsonName attributes to use same property name
* Merge
Commit migrated from https://github.com/dotnet/corefx/commit/
0fcf8096d10f8a4192f8ff7281f49d3ae1621b7f
Steve Harter [Wed, 26 Jun 2019 18:11:04 +0000 (11:11 -0700)]
Remove converter Write() that takes property name (dotnet/corefx#38932)
Commit migrated from https://github.com/dotnet/corefx/commit/
d33be8575490a723395f7fcce1be1fd735405406
Santiago Fernandez Madero [Wed, 26 Jun 2019 17:51:01 +0000 (10:51 -0700)]
Fix nullable annotations for EventRegistrationTokenTable<T> (dotnet/corefx#38942)
Commit migrated from https://github.com/dotnet/corefx/commit/
deb5c2bebdc7d50a9c3ef1be87aee091e56894b6
Ahson Khan [Wed, 26 Jun 2019 17:49:53 +0000 (10:49 -0700)]
Add simpler Utf8JsonReader ctors that dont require JsonReaderState or IsFinalBlock. (dotnet/corefx#38868)
* Add simpler Utf8JsonReader ctors that dont require JsonReaderState or
IsFinalBlock.
* Update ctors and add tests for simple ctor.
* Address PR feedback.
* Implement the convenience ctor over the existing one.
* Update new tests to remove the BytesConsumed, Position usage.
Commit migrated from https://github.com/dotnet/corefx/commit/
7f8333149a0f24fc3f007eefb976118cf9ab06c5
buyaa-n [Wed, 26 Jun 2019 17:37:12 +0000 (10:37 -0700)]
Check uncompressed size before decompressing a zip file. Fixes 33058 (dotnet/corefx#38314)
Account uncompressed size while decompressing a zip file. Fixes 33058
I am sure now the fix is good enough for merging, if anyone has more question/comment please let me know/comment
Commit migrated from https://github.com/dotnet/corefx/commit/
cece0df13a74d188f96b08ae5af0cd4cd60f8f76
Geoff Kizer [Wed, 26 Jun 2019 16:29:55 +0000 (09:29 -0700)]
fix connection level window accounting
Commit migrated from https://github.com/dotnet/corefx/commit/
50b8897591b64c0cecc4561b6a314c4149350bef
Cory Nelson [Wed, 26 Jun 2019 16:16:08 +0000 (09:16 -0700)]
Add HPACK integer validation to prevent wrapping and overlong encodings. (dotnet/corefx#38910)
* Add HPACK integer validation to prevent wrapping and overlong encodings. Resolves dotnet/corefx#38626.
* Improve documentation and add an assert to help avoid confusion and misuse of IntegerDecoder.StartDecode.
Commit migrated from https://github.com/dotnet/corefx/commit/
5b29cd3efe43f83bee732263e4113448ae60d4d3
Geoff Kizer [Wed, 26 Jun 2019 16:07:01 +0000 (09:07 -0700)]
ignore frame processing callbacks on aborted streams
Commit migrated from https://github.com/dotnet/corefx/commit/
281fdc6ba485126258466ea5c1486c79c46f8dbb
Krzysztof Wicher [Wed, 26 Jun 2019 15:49:50 +0000 (08:49 -0700)]
Clear plaintext when AesCcm authentication fails (dotnet/corefx#38899)
* Re-enable disabled AesCcm test cases
* Clear plaintext on failure
Commit migrated from https://github.com/dotnet/corefx/commit/
b958f70b06826095c5b0e15bb566f300b96094ce
Ahson Khan [Wed, 26 Jun 2019 15:30:30 +0000 (08:30 -0700)]
Rename JsonSerializer.Parse/ToString to Deserialize/Serialize. (dotnet/corefx#38933)
* Rename JsonSerializer.Parse/ToString to Deserialize/Serialize.
* Update the API names in source/tests.
* Update other API calls in the tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
32776a3e25aa5b47c96ea2dd588c2201ca18a048
Ahson Khan [Wed, 26 Jun 2019 15:26:34 +0000 (08:26 -0700)]
Fix typo while merging conflicting PRs (s_readerOptions was renamed to s_options) (dotnet/corefx#38934)
Commit migrated from https://github.com/dotnet/corefx/commit/
a72deda9c19ca48bc5ec81650f5b4d7da780d75f
dotnet-maestro[bot] [Wed, 26 Jun 2019 14:57:30 +0000 (14:57 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38929)
* Update dependencies from https://github.com/dotnet/coreclr build
20190625.3
- Microsoft.NET.Sdk.IL - 3.0.0-preview7.19325.3
- Microsoft.NETCore.ILAsm - 3.0.0-preview7.19325.3
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview7.19325.3
* Adapt to ResourceManager.BaseName behavior change
Commit migrated from https://github.com/dotnet/corefx/commit/
38ac1edd43d27f8d1133156a09e91916e66f9701
Ahson Khan [Wed, 26 Jun 2019 14:35:09 +0000 (07:35 -0700)]
Remove BytesConsumed and Position from JsonReaderState. (dotnet/corefx#38928)
* Remove BytesConsumed and Position from JsonReaderState.
* Fix the tests that were not properly restoring state.
* Disable failing test that was written incorrectly, previously.
Commit migrated from https://github.com/dotnet/corefx/commit/
faa6ab48904c98147bef5754b74eac1fb5fe1af0
Ahson Khan [Wed, 26 Jun 2019 14:32:53 +0000 (07:32 -0700)]
Add JsonElement.WriteProperty that takes JsonEncodedText. (dotnet/corefx#38869)
* Add JsonElement.WriteProperty that takes JsonEncodedText.
* Add tests.
* Auto-gen the ref.
Commit migrated from https://github.com/dotnet/corefx/commit/
5134166832b430ccf2d05193cda9036d9a55356b
Ahson Khan [Wed, 26 Jun 2019 14:29:43 +0000 (07:29 -0700)]
Add JsonDocumentOptions and use that instead of JsonReaderOptions. (dotnet/corefx#38866)
* Add JsonDocumentOptions and use that instead of JsonReaderOptions.
* Address PR feedback.
* Auto-generate the reference assembly.
* Auto-gen the ref from the source.
* Explicitly mark property getters as readonly.
* Cleanup and fix converter argument name to typeToConvert.
Commit migrated from https://github.com/dotnet/corefx/commit/
e4d329737f0ab5c413c98a90ff485f91fd3f5fd0
Stephen Toub [Wed, 26 Jun 2019 14:24:55 +0000 (10:24 -0400)]
Add test for sync completion behavior with multiple awaits (dotnet/corefx#38812)
* Add test for sync completion behavior with multiple awaits
* Remove SkipOnTargetFramework for netfx
Commit migrated from https://github.com/dotnet/corefx/commit/
cf5787ca4d7a29b0f34cd103c5b8207cd74a6216
Kevin Jones [Wed, 26 Jun 2019 14:03:10 +0000 (10:03 -0400)]
Validate RSA parameters when importing to OpenSSL
This imports a key explicitly into the OpenSSL default software RSA implementation to call
`RSA_check_key` to determine that the key parameters are consistent.
After the key consistency is determined, then it imports into a second new key handle, using the
configured default (which may also be the default software RSA implementation), and returns that one.
Commit migrated from https://github.com/dotnet/corefx/commit/
5590a9172a65be8cd6f93fdd76f547e63006c837
Ahson Khan [Wed, 26 Jun 2019 13:57:12 +0000 (06:57 -0700)]
Add more Utf8JsonWriter.WritePropertyName test cases. (dotnet/corefx#38921)
* Revert "Fix build break for TestHelpers, move to common and rename to MemoryTestHelpers"
This reverts commit dotnet/corefx@
61f9b4c44336a7e32f8679e0a186a9177d384c49.
* Add more Utf8JsonWriter.WritePropertyName test cases.
Commit migrated from https://github.com/dotnet/corefx/commit/
42b4bf7af587942429fbd9775d7edc8850312dcb
Steve Harter [Wed, 26 Jun 2019 13:46:23 +0000 (06:46 -0700)]
Performance improvements on property lookup (dotnet/corefx#38902)
Commit migrated from https://github.com/dotnet/corefx/commit/
5e6c939705fd23e81d2a74c4a00e236a3d4289b5
Frederik Carlier [Wed, 26 Jun 2019 13:41:44 +0000 (15:41 +0200)]
Fix and re-enable AddFontFile_Directory_ThrowsFileNotFoundException test, rename GetAdjustedPalette_InvalidTypes_ThrowsArgumentException (dotnet/corefx#38873)
* Fix and re-enable AddFontFile_Directory_ThrowsFileNotFoundException test
* Accept Desktop exception, too.
* Avoid two unit test with the same name
Commit migrated from https://github.com/dotnet/corefx/commit/
d73a90663d15b7d80dcecb026b37d3b87267d116
Dan Moseley [Wed, 26 Jun 2019 13:36:14 +0000 (06:36 -0700)]
Disable some tests for Windows IoT (dotnet/corefx#38912)
* Disable for IoT
* IconConverter tests
* S.DS
* S.DS.AM
* typo
* Fact to Theory
Commit migrated from https://github.com/dotnet/corefx/commit/
56e68cff21c62181bb0b8d8d3302cbbbeef8eb57
Geoff Kizer [Wed, 26 Jun 2019 08:47:41 +0000 (01:47 -0700)]
ignore invalid frames on closed streams
Commit migrated from https://github.com/dotnet/corefx/commit/
10ae10869a86e0ad9dc2d789b2da0c9b9acec2c1
buyaa-n [Wed, 26 Jun 2019 07:27:55 +0000 (00:27 -0700)]
Enable fixed tests, formatting update (dotnet/corefx#38909)
Commit migrated from https://github.com/dotnet/corefx/commit/
219b67118e3a2d539afc1ff3bb2c10e1bc7b03d2
Mandar Sahasrabuddhe [Wed, 26 Jun 2019 07:27:00 +0000 (12:57 +0530)]
CoreFx dotnet/corefx#38894: Use (s)byte and (u)int16 get apis (dotnet/corefx#38905)
Commit migrated from https://github.com/dotnet/corefx/commit/
dad20ba6f801ac7089f73b828ea2296b0d1348f9
Cory Nelson [Wed, 26 Jun 2019 07:04:36 +0000 (00:04 -0700)]
Implement MaxResponseHeadersLength for HTTP2 (dotnet/corefx#38560)
Implement MaxResponseHeadersLength for HTTP2. Resolves dotnet/corefx#35528.
Implement huffman-coded header support in Http2LoopbackServer.
Move HuffmanDecodingTests from functional to unit tests to avoid reflection.
Commit migrated from https://github.com/dotnet/corefx/commit/
f0ec881bbb7945e35e3cf6862ea309b1143659f7
Dan Moseley [Wed, 26 Jun 2019 02:44:22 +0000 (19:44 -0700)]
Default distro version for tests (dotnet/corefx#38860)
* Default distro version for tests
* Move it
* typo
* typo
* Update PlatformApis.Unix.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
4f0d10773ccbb4849b869b6a0a73d5938f1804bd
Anirudh Agnihotry [Wed, 26 Jun 2019 01:48:20 +0000 (18:48 -0700)]
Checking if the eventlog registry key is actually an eventlog (dotnet/corefx#38430)
* checking if the eventlog registry key is actually an eventlog
* optimising the code a little bit
* modified test
* skipping test on .net frameworj
Commit migrated from https://github.com/dotnet/corefx/commit/
18f5e7b7f9c13b309f7ac978747c828ed417e543
Ahson Khan [Tue, 25 Jun 2019 22:07:36 +0000 (15:07 -0700)]
Add WritePropertyName standlone API on the Utf8JsonWriter. (dotnet/corefx#38864)
* Add WritePropertyName standlone API on the Utf8JsonWriter.
* Fix write indented, add more tests, and more debug.asserts.
* Remove _isProperty field and rely on _tokenType ==
JsonTokenType.PropertyName
* Auto-gen the ref.
* Address PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
a5b35f5600b615d4f30c64183891c83fd76bf491
Jan Kotas [Tue, 25 Jun 2019 20:11:52 +0000 (13:11 -0700)]
Remove IFormattable implementations on intrinsic Vector types
Commit migrated from https://github.com/dotnet/corefx/commit/
aba8dac72c4a672305b25a1a9a05befad1a55c70
Ahson Khan [Tue, 25 Jun 2019 21:14:47 +0000 (14:14 -0700)]
Add better validation for JsonCommentHandling enum and re-order the values. (dotnet/corefx#38622)
* Add validation for JsonCommentHandling enum.
* Address PR feedback.
* Fix typos and make the checks consistent.
* Add parameter name to the argument OOR exception and update tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
0691e5ffc5b569730688f0a61aa63555db2b1e47
Viktor Hofer [Tue, 25 Jun 2019 20:45:17 +0000 (22:45 +0200)]
Normalize generate ref source paths correctly (dotnet/corefx#38870)
* Normalize generate ref source paths correctly
* Trim trailing slash from RefPath
Commit migrated from https://github.com/dotnet/corefx/commit/
27411a58170810f6334a722ae73e8354601dcb85
Brennan [Tue, 25 Jun 2019 20:32:00 +0000 (13:32 -0700)]
Fix infinite loop in JsonSerializer.WriteValue (dotnet/corefx#38892)
Commit migrated from https://github.com/dotnet/corefx/commit/
98937e7f1d4882395722dedadcf57df23d0ea13f
Tanner Gooding [Tue, 25 Jun 2019 19:46:27 +0000 (12:46 -0700)]
Fixing up HandleNull in JsonSerializer.Read to reset the property for dictionaries. (dotnet/corefx#38704)
* Fixing up HandleNull in JsonSerializer.Read to reset the property for dictionaries.
* Adding regression tests for dotnet/corefx#38565
* Fixing HandleDictionary in JsonSerializer.Write to respect IgnoreNullValues
* Updating the Regression38565_Serialize test to not expect null
* Responding to PR feedback and adding a regression test for dotnet/corefx#38557
Commit migrated from https://github.com/dotnet/corefx/commit/
78e00d4b0ad5b390c9a54431c632062392c3ed7e
Tarek Mahmoud Sayed [Tue, 25 Jun 2019 19:45:33 +0000 (12:45 -0700)]
Preserve more envirnment variables during tests remote execution (dotnet/corefx#38889)
Commit migrated from https://github.com/dotnet/corefx/commit/
3b25185ca127fdb8e31fc51854ce44484c758143
Mandar Sahasrabuddhe [Tue, 25 Jun 2019 19:03:33 +0000 (00:33 +0530)]
CoreFx dotnet/corefx#36125 (Try)Get for byte sbyte short ushort (dotnet/corefx#38469)
* CoreFx dotnet/corefx#36125 (Try)Get for byte sbyte short ushort
* Init out values on failure return paths.
* APIs in JsonElement and related tests
* More test cases, test bug fixes, code fixes
Commit migrated from https://github.com/dotnet/corefx/commit/
b2af402ee9f169be00b4be09887e6db0dba2bff1
William Godbe [Tue, 25 Jun 2019 19:00:44 +0000 (12:00 -0700)]
Disable failing Process test (dotnet/corefx#38885)
Commit migrated from https://github.com/dotnet/corefx/commit/
e4d34071b2049268283676152a61d1ed2cd52879
Ahson Khan [Tue, 25 Jun 2019 18:36:15 +0000 (11:36 -0700)]
Use SpanTestHelpers from Common within StringTests rather than TestHelpers which doesn't exist (dotnet/corefx#38865)
* Revert "Fix build break for TestHelpers, move to common and rename to MemoryTestHelpers"
This reverts commit dotnet/corefx@
61f9b4c44336a7e32f8679e0a186a9177d384c49.
* Use SpanTestHelpers from Common rather than TestHelpers which doesn't
exist.
Commit migrated from https://github.com/dotnet/corefx/commit/
edbee902747970e86dbcf19727e72b8216946bb8
Tanner Gooding [Tue, 25 Jun 2019 18:11:44 +0000 (11:11 -0700)]
Adding tests covering the scenario listed in dotnet/corefx#38643 (dotnet/corefx#38696)
Commit migrated from https://github.com/dotnet/corefx/commit/
2439b9a00bd3a8c4e4714470fee4f224978b5678
Stephen Toub [Tue, 25 Jun 2019 15:39:51 +0000 (11:39 -0400)]
Disable nano in PR CI (dotnet/corefx#38883)
Commit migrated from https://github.com/dotnet/corefx/commit/
16dd0366218f18065eb31e0f59bb0c0b63b62954
Kevin Jones [Tue, 25 Jun 2019 14:45:59 +0000 (10:45 -0400)]
Support additional OIDs for SignedCms digest algorithms
If an existing CMS has a digest algorithm identifier of {Digest}withRSA, the algorithm will be treated as unknown, however this works in the Desktop .NET Framework. This adds support for those algorithm identifiers for signature verification, but not for creation.
Commit migrated from https://github.com/dotnet/corefx/commit/
e40dbeb9c4adfec29e291e11e98d92924efea673
Yoh Deadfall [Tue, 25 Jun 2019 14:18:12 +0000 (17:18 +0300)]
Added reflection emit member accessor (dotnet/corefx#38233)
Commit migrated from https://github.com/dotnet/corefx/commit/
25374d33af29283db17bab255971b3f6f17c0fbf
Jeremy Barton [Tue, 25 Jun 2019 13:47:49 +0000 (06:47 -0700)]
Fix exception type tested for in SignerIdentifierType_InvalidValues (dotnet/corefx#38847)
Commit migrated from https://github.com/dotnet/corefx/commit/
df7147a81d664c1462bfa6e7bc2042b2afca4072
Viktor Hofer [Tue, 25 Jun 2019 13:23:21 +0000 (15:23 +0200)]
Update docker images on linux (dotnet/corefx#38867)
Commit migrated from https://github.com/dotnet/corefx/commit/
c12b7dcd08eda9489d88fa808707fda28f60b24d