review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 31 Jan 2014 00:04:25 +0000 (00:04 +0000)]

initial import of Chrome's trace_event into skia framework

This patch includes a modified version of Chrome's trace_event.h, which provides
tracing macros that can easily integrate into the about://tracing framework.

Currently the macros link to a default implementation of the (narrow) tracing
class SkDefaultEventTracer which does nothing; next step will be to have Chrome
subclass the SkEventTracer with a shim that bolts Skia's trace events to its own,
allowing Skia's trace events to show up in about://tracing.

I've verified that this file builds properly, and when I added a simple scoped
TRACE_EVENT0 to SkCanvas::drawRect, along with some debug prints in the NOP
implementation of tracing, I saw what I expected printed to the screen.

BUG=skia:
R=nduca@chromium.org, reed@google.com, mtklein@google.com, bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/149563004

git-svn-id: http://skia.googlecode.com/svn/trunk@13256 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 23:10:41 +0000 (23:10 +0000)]

even more rebaselines for blur

BUG=skia:2108
R=epoger@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/149823003

git-svn-id: http://skia.googlecode.com/svn/trunk@13255 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

tfarina@chromium.org [Thu, 30 Jan 2014 22:51:42 +0000 (22:51 +0000)]

Port SkBase64 test to our test driver.

BUG=None
TESTS=tests --match SkBase64Test
R=mtklein@google.com, reed@google.com

Review URL: https://codereview.chromium.org/132233060

git-svn-id: http://skia.googlecode.com/svn/trunk@13254 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 22:16:32 +0000 (22:16 +0000)]

Set write buffer flags only in SkWriteBuffer and SkFlatController constructors.

This is a baby step toward refactored (and faster in-process) typeface and flattenable factory encoding and decoding. The sooner SkWriteBuffer knows its flags, the better.

Next steps will be to rearrange Sk{Read,Write}Buffer members into disjoint strategies to handle typefaces and flattenable factories: one for in-process, one for cross-process, one when validating.

BUG=skia:
R=reed@google.com, scroggo@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/138803005

git-svn-id: http://skia.googlecode.com/svn/trunk@13253 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 22:13:12 +0000 (22:13 +0000)]

remove (unnecessary) SkScalarMul and SkScalarMulAdd macros from SkMatrix.cpp.

SkScalarMulDiv remains, but it can be removed later (though it is slightly clearer to use it at times).

BUG=skia:
R=caryclark@google.com, mtklein@google.com, halcanary@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/150493002

git-svn-id: http://skia.googlecode.com/svn/trunk@13252 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 22:12:30 +0000 (22:12 +0000)]

add_codereview_message script to append messages to a CL

Add add_codereview_message.py script.  This script takes a message and
a codereview URL as arguments calls `git cl upload` to append the
message to the given codereview issue.

Motivation: We are automating a process of testing Chromium/Skia DEPS
rolls where roll_deps.py is automatically run every night, and then at
a later time, compare_codereview.py is run to generate a report of the
trybot results.  This script can be used to append that report to the
DEPS roll Cl.

This CL also refactors functioanlity common to roll_deps and
add_codereview_message:
*   Add tools/git_utils.py module.
    -   ChangeGitBranch class was factored out of
        roll_deps.GitBranchCLUpload.  The other half of that class
        became roll_deps.git_cl_uploader function.  I make use of
        this new class in both roll_deps and upload_deps_roll.
    -   test_git_executable moved to this new module.
*   Add tools/misc_utils.py - move VerboseSubprocess, ChangeDir,
    and ReSearch classes from roll_deps module.
*   Remove generic functions from roll_deps.
*   Add git_cl_uploader function to roll_deps.  Refactor
    roll_deps.roll_deps function to make use of it

BUG=skia:
R=borenet@google.com, robertphillips@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/141483011

git-svn-id: http://skia.googlecode.com/svn/trunk@13251 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 22:08:36 +0000 (22:08 +0000)]

mark imageblur_gpu gm tests as ignore-failure on IntelRhb

BUG=skia:2085
NOTRY=True
R=senorblanco@google.com
TBR=senorblanco

Author: epoger@google.com

Review URL: https://codereview.chromium.org/150813002

git-svn-id: http://skia.googlecode.com/svn/trunk@13250 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 22:05:47 +0000 (22:05 +0000)]

Replace factory generation of TextContexts with persistent objects.

BUG=skia:2018
R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/150743002

git-svn-id: http://skia.googlecode.com/svn/trunk@13249 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 22:00:56 +0000 (22:00 +0000)]

remove GM expectations for all ASAN/Valgrind builders

BUG=skia:2112
NOTRY=True
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/140323020

git-svn-id: http://skia.googlecode.com/svn/trunk@13248 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 21:07:33 +0000 (21:07 +0000)]

more blurrect rebaselines

BUG=skia:2108
R=epoger@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/136813005

git-svn-id: http://skia.googlecode.com/svn/trunk@13247 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 19:22:33 +0000 (19:22 +0000)]

create empty expectations for Logan bots

BUG=skia:2107
NOTRY=True
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/150543004

git-svn-id: http://skia.googlecode.com/svn/trunk@13246 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 18:58:24 +0000 (18:58 +0000)]

Refactor read and write buffers.

Eliminates SkFlattenable{Read,Write}Buffer, promoting SkOrdered{Read,Write}Buffer
a step each in the hierarchy.

What used to be this:

SkFlattenableWriteBuffer -> SkOrderedWriteBuffer
SkFlattenableReadBuffer  -> SkOrderedReadBuffer
SkFlattenableReadBuffer  -> SkValidatingReadBuffer

is now

SkWriteBuffer
SkReadBuffer -> SkValidatingReadBuffer

Benefits:
  - code is simpler, names are less wordy
  - the generic SkFlattenableFooBuffer code in SkPaint was incorrect; removed
  - write buffers are completely devirtualized, important for record speed

This refactoring was mostly mechanical.  You aren't going to find anything
interesting in files with less than 10 lines changed.

BUG=skia:
R=reed@google.com, scroggo@google.com, djsollen@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/134163010

git-svn-id: http://skia.googlecode.com/svn/trunk@13245 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 30 Jan 2014 18:51:29 +0000 (18:51 +0000)]

Suppress new valgrind complaint

https://codereview.chromium.org/144853006/

git-svn-id: http://skia.googlecode.com/svn/trunk@13244 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 18:17:06 +0000 (18:17 +0000)]

rebaseline GM changes resulting from fast GPU blur algorithm

BUG=skia:
R=bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/150493005

git-svn-id: http://skia.googlecode.com/svn/trunk@13243 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 18:15:51 +0000 (18:15 +0000)]

Add convex polygon rendering effect and GM to test it.

BUG=skia:2051
R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/149683004

git-svn-id: http://skia.googlecode.com/svn/trunk@13242 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 17:59:22 +0000 (17:59 +0000)]

rebaseline imagefiltersgraph_gpu GMs on Nexus10

BUG=skia:2106
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon

Author: epoger@google.com

Review URL: https://codereview.chromium.org/150113003

git-svn-id: http://skia.googlecode.com/svn/trunk@13241 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 17:27:45 +0000 (17:27 +0000)]

rebaseline perf because of faster tests after GPU glur changes

BUG=skia:
R=robertphillips@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/150563002

git-svn-id: http://skia.googlecode.com/svn/trunk@13240 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 16:41:23 +0000 (16:41 +0000)]

Move GrTextContext to private interface

NOTRY=true
R=bsalomon@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/145073005

git-svn-id: http://skia.googlecode.com/svn/trunk@13239 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 15:34:43 +0000 (15:34 +0000)]

patch from issue 119343003
compile on 10.6, exclude failing gms

Sorry for making another CL; rebasing ToT on the old one ended up with code in a tangled mess; was easier to start over.

NOTRY=true
R=bsalomon@google.com, epoger@google.com, reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/148883005

git-svn-id: http://skia.googlecode.com/svn/trunk@13238 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 15:30:50 +0000 (15:30 +0000)]

Reland "Add --skip_cpu and --skip_gpu options to tests"

NOTRY=true

BUG=skia:2074
R=djsollen@google.com, mtklein@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/135163004

git-svn-id: http://skia.googlecode.com/svn/trunk@13237 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 30 Jan 2014 15:22:54 +0000 (15:22 +0000)]

Add fallback code for TextContexts that don't support all features

BUG=skia:2018

NOTRY=true
R=bsalomon@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/135683006

git-svn-id: http://skia.googlecode.com/svn/trunk@13236 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

tfarina@chromium.org [Thu, 30 Jan 2014 00:58:02 +0000 (00:58 +0000)]

And before I forget: Remove UnitTest() method declaration from GrRedBlackTree

I forgot to remove it while doing r13233
(https://codereview.chromium.org/137423009/)

BUG=None
TEST=tests
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/145973010

git-svn-id: http://skia.googlecode.com/svn/trunk@13235 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

tfarina@chromium.org [Thu, 30 Jan 2014 00:28:54 +0000 (00:28 +0000)]

GrRedBlackTree test is GPU specific.

Wrapp the entire file/test in a SK_SUPPORT_GPU.

This should fix the tree breakage.

BUG=None
TEST=tests
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/147843006

git-svn-id: http://skia.googlecode.com/svn/trunk@13234 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

tfarina@chromium.org [Wed, 29 Jan 2014 23:56:40 +0000 (23:56 +0000)]

Reland "Unwrap GrRedBlackTree unit test and use REPORTER_ASSERT()."

BUG=None
TEST=tests
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/137423009

git-svn-id: http://skia.googlecode.com/svn/trunk@13233 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Wed, 29 Jan 2014 22:28:26 +0000 (22:28 +0000)]

Win8 baselines for displacement GM (razzin' frazzin' --keep-going-on-failure).

TBR=epoger
BUG=skia:

Review URL: https://codereview.chromium.org/149073008

git-svn-id: http://skia.googlecode.com/svn/trunk@13232 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Wed, 29 Jan 2014 21:41:39 +0000 (21:41 +0000)]

New baselines for displacement GM.

This had a new test case added in r12773.

TBR=epoger@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/143263020

git-svn-id: http://skia.googlecode.com/svn/trunk@13231 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Wed, 29 Jan 2014 20:00:54 +0000 (20:00 +0000)]

New baselines for GM tests affected by r13221.

The following tests were affected:

imagefiltersbase
imagefilterscropped
imagefiltersgraph
imagefiltersscaled
dropshadowimagefilter
offsetimagefilter
spritebitmap
tileimagefilter

TBR=epoger@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/148283008

git-svn-id: http://skia.googlecode.com/svn/trunk@13230 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 29 Jan 2014 11:48:31 +0000 (11:48 +0000)]

Rebaslines for https://codereview.chromium.org/23835006/

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com, reed@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/137833005

git-svn-id: http://skia.googlecode.com/svn/trunk@13229 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 29 Jan 2014 07:01:48 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13228 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 28 Jan 2014 22:02:07 +0000 (22:02 +0000)]

Add standalone drawText for GrTextContext.

This unifies the interface between GrBitmapTextContext and
GrDistanceFieldTextContext so that they don't need special case code.
The future GrNVPRTextContext will also use this interface.

BUG=skia:2018
R=bsalomon@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/141863005

git-svn-id: http://skia.googlecode.com/svn/trunk@13227 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 28 Jan 2014 21:15:42 +0000 (21:15 +0000)]

tests: add --veryVerbose / -V

BUG=skia:
R=caryclark@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/135723013

git-svn-id: http://skia.googlecode.com/svn/trunk@13226 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Tue, 28 Jan 2014 20:33:09 +0000 (20:33 +0000)]

Remove BOM from SkFontHost_FreeType.cpp.

With r12822 a UTF-8 BOM was added to SkFontHost_FreeType.cpp.
This change removes it.

Running

find . -type f \( -name '*.cpp' -o -name '*.h' \) -exec file {} \; | grep BOM

makes it look like this is the only file with a UTF-8 BOM at this time.
The BOM is easily removed with

tail -c +4 <filename>

R=rmistry@google.com

Review URL: https://codereview.chromium.org/141433025

git-svn-id: http://skia.googlecode.com/svn/trunk@13225 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 28 Jan 2014 20:21:23 +0000 (20:21 +0000)]

Revert of Add --skip_cpu and --skip_gpu options to tests (https://codereview.chromium.org/144343004/)

Reason for revert:
Broke tests on Win7 and Mac

Original issue's description:
> Add --skip_cpu and --skip_gpu options to tests
>
> BUG=skia:2074
>
> Committed: http://code.google.com/p/skia/source/detail?r=13223

R=djsollen@google.com, mtklein@google.com
TBR=djsollen@google.com, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2074

Author: borenet@google.com

Review URL: https://codereview.chromium.org/148173010

git-svn-id: http://skia.googlecode.com/svn/trunk@13224 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 28 Jan 2014 20:02:45 +0000 (20:02 +0000)]

Add --skip_cpu and --skip_gpu options to tests

BUG=skia:2074
R=djsollen@google.com, mtklein@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/144343004

git-svn-id: http://skia.googlecode.com/svn/trunk@13223 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Tue, 28 Jan 2014 19:22:35 +0000 (19:22 +0000)]

Give correct bounds to SkCanvas's AutoDrawLooper use for filter draws.

In conjuction with https://codereview.chromium.org/137423005/, this allows the canvas to tighten the bounds passed to saveLayer() only the affected region.

R=reed@google.com
BUG=100703

Review URL: https://codereview.chromium.org/141433017

git-svn-id: http://skia.googlecode.com/svn/trunk@13221 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Tue, 28 Jan 2014 17:57:26 +0000 (17:57 +0000)]

Clamp negative sigma to 0 in SkDropShadowImageFilter.

This can occur when the matrix includes a perspective transform.

BUG=skia:2094
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/137833004

git-svn-id: http://skia.googlecode.com/svn/trunk@13220 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 28 Jan 2014 16:05:39 +0000 (16:05 +0000)]

change setAlphaType to not modify the pixelref's genID

BUG=skia:
R=bsalomon@google.com, halcanary@google.com

Review URL: https://codereview.chromium.org/137263009

git-svn-id: http://skia.googlecode.com/svn/trunk@13219 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 28 Jan 2014 15:18:54 +0000 (15:18 +0000)]

ARM Skia NEON patches - 20 - New improved BitmapProcState code

BitmapProcState: new factorised code

This one basically factorises the clamp and repeat transformations with
some performance improvements. It has the benefit of being faster, much
easier to maintain (nearly three times less code for more work
done :-)), and more complete (all persp transformations weren't optimised
in the previous version).

It also introduces the use of can_truncate_to_fixed_for_decal where
useful.

The effect on benchmarks ranges from a 5% penalty to a 25% gain on a
Cortex-A9 and from a 5% penalty to a 100% gain on a Cortex-A15.

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com, mtklein@google.com, luisjoseromeroesclusa@hotmail.com, reed@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/23835006

git-svn-id: http://skia.googlecode.com/svn/trunk@13218 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 28 Jan 2014 15:16:45 +0000 (15:16 +0000)]

SkGrPixelRef can only reference the subset of the Surface specified by its SkImageInfo

BUG=skia:
R=bsalomon@google.com, halcanary@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/138143022

git-svn-id: http://skia.googlecode.com/svn/trunk@13217 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 28 Jan 2014 14:36:52 +0000 (14:36 +0000)]

That's confusing. Make it clear we're working with 3 points == 9 scalars.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/148383009

git-svn-id: http://skia.googlecode.com/svn/trunk@13216 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 28 Jan 2014 14:35:51 +0000 (14:35 +0000)]

Remove nvpr bench_pictures_cfg

BUG=skia:2042
R=bsalomon@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/148393002

git-svn-id: http://skia.googlecode.com/svn/trunk@13215 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Tue, 28 Jan 2014 07:01:53 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13214 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 28 Jan 2014 01:55:24 +0000 (01:55 +0000)]

Revert of Fast blurred rectangles on GPU (https://codereview.chromium.org/119343003/)

Reason for revert:
Two problems:

1. broke compile on Build-Mac10.6-* bots
2. broke GM expectations on many bots

We'll need to examine the GM impact before re-landing. I can work with you to do this on Tuesday if you like; just IM or email me.

Original issue's description:
> Perform the same analytic blur calculation on the GPU that we do on the CPU. Results in significant performance gains when using Ganesh to render drop shadows in Chrome.
>
> BUG=
>
> Committed: http://code.google.com/p/skia/source/detail?r=13210

R=bsalomon@google.com, reed@google.com, humper@google.com, rmistry@google.com
TBR=bsalomon@google.com, humper@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=

Author: epoger@google.com

Review URL: https://codereview.chromium.org/140853008

git-svn-id: http://skia.googlecode.com/svn/trunk@13213 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 28 Jan 2014 01:52:49 +0000 (01:52 +0000)]

Adding rmistry for emergency reverts.

(SkipBuildbotRuns)

TBR=
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/148583005

git-svn-id: http://skia.googlecode.com/svn/trunk@13212 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 27 Jan 2014 22:42:51 +0000 (22:42 +0000)]

Add the NOTRY command on roll_deps.py

Motivation: The current workflow is to submit via `git cl dcommit`.
As we move to automated nightly creation of the DEPS roll CLs, we want
to make it easier for the submitter to speed along a clean roll.

BUG=skia:
R=borenet@google.com, robertphillips@google.com, rmistry@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/133933009

git-svn-id: http://skia.googlecode.com/svn/trunk@13211 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 27 Jan 2014 22:41:45 +0000 (22:41 +0000)]

Perform the same analytic blur calculation on the GPU that we do on the CPU. Results in significant performance gains when using Ganesh to render drop shadows in Chrome.

BUG=
R=bsalomon@google.com, reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/119343003

git-svn-id: http://skia.googlecode.com/svn/trunk@13210 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 27 Jan 2014 21:54:18 +0000 (21:54 +0000)]

Revert of Unwrap GrRedBlackTree unit test and use REPORTER_ASSERT(). (https://codereview.chromium.org/147713002/)

Reason for revert:
broke http://108.170.217.252:10115/builders/Build-Mac10.8-Clang-x86_64-Release/builds/2908/steps/Retry_BuildTests/logs/stdio and other builders:

GrRedBlackTreeTest.cpp:24:36: error: use of undeclared identifier 'xi'

Original issue's description:
> Unwrap GrRedBlackTree unit test and use REPORTER_ASSERT().
>
> This fixes the mtklein's TODO in GrUnitTests.cpp.
>
> BUG=None
> TEST=out/Debug/tests
> R=mtklein@google.com, robertphillips@google.com
>
> Committed: https://code.google.com/p/skia/source/detail?r=13208

R=mtklein@google.com, robertphillips@google.com, reed@google.com, tfarina@chromium.org
TBR=mtklein@google.com, reed@google.com, robertphillips@google.com, tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Author: epoger@google.com

Review URL: https://codereview.chromium.org/148653002

git-svn-id: http://skia.googlecode.com/svn/trunk@13209 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

tfarina@chromium.org [Mon, 27 Jan 2014 21:40:14 +0000 (21:40 +0000)]

Unwrap GrRedBlackTree unit test and use REPORTER_ASSERT().

This fixes the mtklein's TODO in GrUnitTests.cpp.

BUG=None
TEST=out/Debug/tests
R=mtklein@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/147713002

git-svn-id: http://skia.googlecode.com/svn/trunk@13208 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Mon, 27 Jan 2014 21:03:17 +0000 (21:03 +0000)]

Implement a computeFastBounds() traversal for SkImageFilter.

This allows for correct culling of primitives which have image filters applied.

R=reed@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/137423005

git-svn-id: http://skia.googlecode.com/svn/trunk@13207 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 27 Jan 2014 21:02:14 +0000 (21:02 +0000)]

move getAdvancedTypefaceMetrics into private, as only skia internals call it

BUG=skia:
R=bungeman@google.com, vandebo@chromium.org

Review URL: https://codereview.chromium.org/148583002

git-svn-id: http://skia.googlecode.com/svn/trunk@13206 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Mon, 27 Jan 2014 20:47:11 +0000 (20:47 +0000)]

Trying once again to rebaseline IntelRhb bots.

This seems to be putting the hashes back to what they were at r13191, so if this doesn't work I'm going to call flake and suppress the failures.

TBR=epoger@google.com

Review URL: https://codereview.chromium.org/148573003

git-svn-id: http://skia.googlecode.com/svn/trunk@13205 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 27 Jan 2014 20:41:03 +0000 (20:41 +0000)]

Ensure SSE2/3 is always enabled on Android.

R=mtklein@google.com, reed@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/132883008

git-svn-id: http://skia.googlecode.com/svn/trunk@13204 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 27 Jan 2014 19:52:51 +0000 (19:52 +0000)]

Revert "Revert of Workaround for assertion in NVPR config in bench. (https://codereview.chromium.org/131503007/)"

add SK_SUPPORT_GPU check

BUG=skia:2042

TBR=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/148173005

git-svn-id: http://skia.googlecode.com/svn/trunk@13203 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 27 Jan 2014 19:45:02 +0000 (19:45 +0000)]

Revert "Revert of nvpr baselines (https://codereview.chromium.org/132333008/)"

BUG=skia:2042

TBR=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/131513012

git-svn-id: http://skia.googlecode.com/svn/trunk@13202 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Mon, 27 Jan 2014 18:15:49 +0000 (18:15 +0000)]

Rebaseline imageblur on IntelRhb Debug.

TBR=epoger@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/148263004

git-svn-id: http://skia.googlecode.com/svn/trunk@13201 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Mon, 27 Jan 2014 18:08:55 +0000 (18:08 +0000)]

roll_deps.py: Make default_bots_list a module-level variable

This allows us to import the script rather than run it in a sub-shell.

BUG=skia:
R=halcanary@google.com

Review URL: https://codereview.chromium.org/140973003

git-svn-id: http://skia.googlecode.com/svn/trunk@13200 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 27 Jan 2014 18:06:03 +0000 (18:06 +0000)]

Revert of Workaround for assertion in NVPR config in bench. (https://codereview.chromium.org/131503007/)

Reason for revert:
broke the build.

Original issue's description:
> Workaround for assertion in NVPR config in bench.
>
> BUG=skia:2078
>
> Committed: http://code.google.com/p/skia/source/detail?r=13196

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2078

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/148473002

git-svn-id: http://skia.googlecode.com/svn/trunk@13199 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 27 Jan 2014 18:05:21 +0000 (18:05 +0000)]

Revert of nvpr baselines (https://codereview.chromium.org/132333008/)

Reason for revert:
broke the build

Original issue's description:
> nvpr baselines
>
> BUG=skia:2042
>
> Committed: https://code.google.com/p/skia/source/detail?r=13195

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=skia:2042

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/148013003

git-svn-id: http://skia.googlecode.com/svn/trunk@13198 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Mon, 27 Jan 2014 17:51:12 +0000 (17:51 +0000)]

New baselines for Win7 DirectWrite (shader2 and bezier_conic) and Intel Rhb (imagefiltersbase and imageblur). All failures are pixel intensity mismatch <= 3.

BUG=skia:2085,skia:2081
TBR=epoger@google.com

Review URL: https://codereview.chromium.org/138623007

git-svn-id: http://skia.googlecode.com/svn/trunk@13197 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 27 Jan 2014 17:36:38 +0000 (17:36 +0000)]

Workaround for assertion in NVPR config in bench.

BUG=skia:2078
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/131503007

git-svn-id: http://skia.googlecode.com/svn/trunk@13196 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Mon, 27 Jan 2014 17:04:00 +0000 (17:04 +0000)]

nvpr baselines

BUG=skia:2042

Review URL: https://codereview.chromium.org/132333008

git-svn-id: http://skia.googlecode.com/svn/trunk@13195 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 27 Jan 2014 16:34:45 +0000 (16:34 +0000)]

Explain empty report in compare_codereview.py.

Let user know when control and roll have no common trybots, instead of
being silent.

BUG=skia:
R=borenet@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/135683003

git-svn-id: http://skia.googlecode.com/svn/trunk@13194 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Mon, 27 Jan 2014 16:22:36 +0000 (16:22 +0000)]

Rebaseline some GPU and ANGLE results which started failing on Win7.

BUG=skia:2081
TBR=epoger@google.com

Review URL: https://codereview.chromium.org/135593005

git-svn-id: http://skia.googlecode.com/svn/trunk@13193 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 27 Jan 2014 15:41:07 +0000 (15:41 +0000)]

add optional SkAlphaType parameter to notifyPixelsChanged

R=scroggo@google.com, halcanary@google.com, robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/147213002

git-svn-id: http://skia.googlecode.com/svn/trunk@13192 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Mon, 27 Jan 2014 15:05:39 +0000 (15:05 +0000)]

Remove misc. suppressions from ignored-tests.txt added in https://codereview.chromium.org/105893003. These tests were rebaselined shortly after that patch landed, but the suppressions weren't removed, so differences have snuck in and not been rebaselined.

New Android baselines for imagefiltersgraph, imagefilterscropped, imagefiltersbase, imageblur GMs.
New Nexus4 baselines for testimagefilters, spritebitmap GM.

R=borenet@google.com
TBR=borenet, bungeman
BUG=skia:

Review URL: https://codereview.chromium.org/141033008

git-svn-id: http://skia.googlecode.com/svn/trunk@13191 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 27 Jan 2014 13:42:58 +0000 (13:42 +0000)]

fix more 64bit warnings

BUG=skia:

Review URL: https://codereview.chromium.org/147683003

git-svn-id: http://skia.googlecode.com/svn/trunk@13190 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 27 Jan 2014 13:41:02 +0000 (13:41 +0000)]

remove SkScalarMul from public headers

BUG=skia:

Review URL: https://codereview.chromium.org/132453008

git-svn-id: http://skia.googlecode.com/svn/trunk@13189 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Sun, 26 Jan 2014 20:51:00 +0000 (20:51 +0000)]

Add NVPR configs to bench

BUG=skia:2042
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/145943003

git-svn-id: http://skia.googlecode.com/svn/trunk@13188 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Sun, 26 Jan 2014 18:07:40 +0000 (18:07 +0000)]

Add NVPR configs to GM

BUG=skia:2042
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/139803003

git-svn-id: http://skia.googlecode.com/svn/trunk@13187 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Sun, 26 Jan 2014 17:51:22 +0000 (17:51 +0000)]

rebaselines from NVPR enable and nexus4 blur radius

BUG=skia:2042

Review URL: https://codereview.chromium.org/146593003

git-svn-id: http://skia.googlecode.com/svn/trunk@13186 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sun, 26 Jan 2014 07:01:45 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13185 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

tfarina@chromium.org [Sat, 25 Jan 2014 18:45:45 +0000 (18:45 +0000)]

Remove unused methods from SkWindow.

I came to this while grepping for deprecated SkBitmap's eraseRGB()
method.

BUG=None
TEST=SampleApp still links
R=reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/147433002

git-svn-id: http://skia.googlecode.com/svn/trunk@13184 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Sat, 25 Jan 2014 16:54:31 +0000 (16:54 +0000)]

add alternative to isRect named asRect

This defines yunchao's proposed interface in terms of
an existing implementation.

BUG=skia:
R=reed@google.com, yunchao.he@intel.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/140953003

git-svn-id: http://skia.googlecode.com/svn/trunk@13183 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Sat, 25 Jan 2014 16:46:20 +0000 (16:46 +0000)]

add legacy/helper allocN32Pixels, and convert gm to use it

This is an intermediate api, but might help us quickly get to a point where
no one is creating bitmaps in a 2-step process (setConfig + alloc).

BUG=skia:
R=halcanary@google.com

Review URL: https://codereview.chromium.org/140593005

git-svn-id: http://skia.googlecode.com/svn/trunk@13182 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 25 Jan 2014 07:01:49 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13181 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 24 Jan 2014 22:38:39 +0000 (22:38 +0000)]

SkOnce: add option to call another cleanup function once at exit.

Use this to clean up empty SkData and SkPathRef.

Current leaks:
  Leaked SkRefCntBase: 40
     Leaked SkFlattenable: 32
         Leaked SkPixelRef: 32
             Leaked SkMallocPixelRef: 32
     Leaked SkFontConfigInterface: 1
     Leaked SkWeakRefCnt: 1
         Leaked SkTypeface: 1
     Leaked SkFontMgr: 1
     Leaked SkDataTable: 3
     Leaked SkImage: 1
         Leaked ???: 1
     Leaked ???: 1

BUG=skia:
R=halcanary@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/132803005

git-svn-id: http://skia.googlecode.com/svn/trunk@13180 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 24 Jan 2014 21:50:03 +0000 (21:50 +0000)]

Updates bench expectations; adds new platforms.

BUG=skia:
R=borenet@google.com, robertphillips@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/131343009

git-svn-id: http://skia.googlecode.com/svn/trunk@13179 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 24 Jan 2014 21:46:29 +0000 (21:46 +0000)]

fix (some) 64bit warnings -- size_t -> int

BUG=skia:
R=mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/147053003

git-svn-id: http://skia.googlecode.com/svn/trunk@13178 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

tfarina@chromium.org [Fri, 24 Jan 2014 20:56:26 +0000 (20:56 +0000)]

Cleanup: Sanitize the order of includes under tests/

Initially this was to make sure Test.h appeared after the Sk*.h includes.

Patch generated by the following command line:

$ ~/chromium/src/tools/sort-headers.py tests/*.cpp

BUG=None
TEST=tests
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/145313004

git-svn-id: http://skia.googlecode.com/svn/trunk@13177 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 24 Jan 2014 20:49:44 +0000 (20:49 +0000)]

Turn NVPR on by default (but off in tools).

BUG=skia:2042

Committed: http://code.google.com/p/skia/source/detail?r=13164

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/144003006

git-svn-id: http://skia.googlecode.com/svn/trunk@13176 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 24 Jan 2014 19:25:39 +0000 (19:25 +0000)]

Add a sample doc in markdown format.

BUG=skia:
R=epoger@google.com, halcanary@google.com, borenet@google.com, jcgregorio@google.com, bungeman@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/146943002

git-svn-id: http://skia.googlecode.com/svn/trunk@13175 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 24 Jan 2014 18:53:42 +0000 (18:53 +0000)]

add installPixels

BUG=skia:
R=halcanary@google.com

Review URL: https://codereview.chromium.org/143073008

git-svn-id: http://skia.googlecode.com/svn/trunk@13174 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 24 Jan 2014 18:48:00 +0000 (18:48 +0000)]

Revert of Use SkMScalar as intermediates in SkMatrix44::setConcat. (https://codereview.chromium.org/146823002/)

Reason for revert:
This will break many Chromium tests when we roll.

Original issue's description:
> Use SkMScalar as intermediates in SkMatrix44::setConcat.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13167

R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/147033002

git-svn-id: http://skia.googlecode.com/svn/trunk@13173 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 24 Jan 2014 18:34:11 +0000 (18:34 +0000)]

new tool: download all GM images for a given builder, ready for skdiff
BUG=skia:1919
R=rmistry@google.com, bsalomon@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/143653006

git-svn-id: http://skia.googlecode.com/svn/trunk@13172 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 24 Jan 2014 18:33:07 +0000 (18:33 +0000)]

Resolve a few memory leaks in tests.

Purge the global scaled image cache after use in tests. The cache was
right to hold on to the pixels indefinitely, but this change makes it
easier to run down actual memory leaks.

Add SK_DECLARE_INST_COUNT to several classes.

BUG=skia:
R=reed@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/145443004

git-svn-id: http://skia.googlecode.com/svn/trunk@13171 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 24 Jan 2014 18:28:35 +0000 (18:28 +0000)]

make GM self-test run gm/rebaseline_server unittests

R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/143983017

git-svn-id: http://skia.googlecode.com/svn/trunk@13170 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

halcanary@google.com [Fri, 24 Jan 2014 16:04:09 +0000 (16:04 +0000)]

Revert "Turn NVPR on by default (but off in tools)."

This reverts commit 83d81c96de34950bdd84dc575997a250b685a3d6.

Broke Windows build. Autorevert didn't work.

TBR=bsalomon@google.com,robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
BUG=skia:2042

Review URL: https://codereview.chromium.org/146863003

git-svn-id: http://skia.googlecode.com/svn/trunk@13169 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 24 Jan 2014 15:43:50 +0000 (15:43 +0000)]

[Reland of r13154, since the Housekeeping bot seems to have reverted it in r13155. Next time I'll put the "do not disturb" sign on my commit.]

Refactor SkMorphologyImageFilter, CPU and GPU paths. This required making opts/ dependent on effects/, so that we could use the SkMorphologyProc type in SkMorphologyImageFilter.h.

Correctness and performance covered by existing tests; no change in functionality.

R=bsalomon@google.com, djsollen@google.com, reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=13154

BUG=skia:

Review URL: https://codereview.chromium.org/135013004

git-svn-id: http://skia.googlecode.com/svn/trunk@13168 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 24 Jan 2014 15:30:46 +0000 (15:30 +0000)]

Use SkMScalar as intermediates in SkMatrix44::setConcat.

BUG=skia:
R=reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/146823002

git-svn-id: http://skia.googlecode.com/svn/trunk@13167 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 24 Jan 2014 15:02:11 +0000 (15:02 +0000)]

Add new baselines for imagefiltersscaled GM.

TBR=borenet

Review URL: https://codereview.chromium.org/145993005

git-svn-id: http://skia.googlecode.com/svn/trunk@13166 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 24 Jan 2014 14:38:27 +0000 (14:38 +0000)]

Add factory class for generating various flavors of GrTextContext.

This is the first pass of making Gr*TextContext more generic and easily
subclassed. The next stage will be making GrBitmapTextContext and
GrDistanceFieldTextContext more similar by moving the SkDraw loop into
each subclass.

BUG=skia:2018

Committed: http://code.google.com/p/skia/source/detail?r=13142

R=bsalomon@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/144283002

git-svn-id: http://skia.googlecode.com/svn/trunk@13165 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 24 Jan 2014 14:38:13 +0000 (14:38 +0000)]

Turn NVPR on by default (but off in tools).

BUG=skia:2042
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/144003006

git-svn-id: http://skia.googlecode.com/svn/trunk@13164 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 24 Jan 2014 12:39:25 +0000 (12:39 +0000)]

modify authors file format to use python fnmatch

BUG=skia:2060
R=rmistry@google.com

Author: hcm@google.com

Review URL: https://codereview.chromium.org/145963002

git-svn-id: http://skia.googlecode.com/svn/trunk@13163 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 23 Jan 2014 23:34:38 +0000 (23:34 +0000)]

Rebaselines for r13156.

There seems to be an issue where expectations are missing from storage.
Either they didn't actually upload, we pointed at the wrong one.

git-svn-id: http://skia.googlecode.com/svn/trunk@13162 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 23 Jan 2014 23:25:19 +0000 (23:25 +0000)]

Rebaselines for r13156.

The thing blurred in imageblur is actually text.
Who knew?

git-svn-id: http://skia.googlecode.com/svn/trunk@13161 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 23 Jan 2014 22:26:04 +0000 (22:26 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13160 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 23 Jan 2014 22:24:41 +0000 (22:24 +0000)]

Rebaselines for r13156.

These are for affected baselines which are now failing,
but the expected image appears to be unavailable.

git-svn-id: http://skia.googlecode.com/svn/trunk@13159 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 23 Jan 2014 22:19:16 +0000 (22:19 +0000)]

Rebaseline for r13156.

git-svn-id: http://skia.googlecode.com/svn/trunk@13158 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

tfarina@chromium.org [Thu, 23 Jan 2014 21:30:43 +0000 (21:30 +0000)]

Remove unused SampleTests.cpp source file.

We never compile this file.

BUG=None
TEST=tests
R=reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/143823016

git-svn-id: http://skia.googlecode.com/svn/trunk@13157 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 23 Jan 2014 19:01:36 +0000 (19:01 +0000)]

Clarify kAutohinting is kForceAutohinting.

BUG=skia:2047
R=reed@google.com

Review URL: https://codereview.chromium.org/139943004

git-svn-id: http://skia.googlecode.com/svn/trunk@13156 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;