Behdad Esfahbod [Tue, 30 Oct 2018 07:38:01 +0000 (00:38 -0700)]
[util] Don't close stdin/stdout
Behdad Esfahbod [Tue, 30 Oct 2018 06:31:42 +0000 (23:31 -0700)]
Fix spurious warning re uninitialized use
Ebrahim Byagowi [Tue, 30 Oct 2018 06:49:40 +0000 (10:19 +0330)]
[cmake] Make build of tests and subset optional (#1329)
Behdad Esfahbod [Tue, 30 Oct 2018 06:21:14 +0000 (23:21 -0700)]
[set/map] Fix uninitialized memory
I keep forgetting that primitive types are NOT initialized during construction. :|
Behdad Esfahbod [Tue, 30 Oct 2018 05:53:16 +0000 (22:53 -0700)]
[fuzzing] Make test runners less verbose
Behdad Esfahbod [Tue, 30 Oct 2018 05:46:19 +0000 (22:46 -0700)]
[unicode] Fix a long-standing double-declaration warning
Behdad Esfahbod [Tue, 30 Oct 2018 05:40:37 +0000 (22:40 -0700)]
Remove now unused hb_auto_t<>
Behdad Esfahbod [Tue, 30 Oct 2018 05:35:44 +0000 (22:35 -0700)]
Remove last use of hb_auto_t<>
Behdad Esfahbod [Tue, 30 Oct 2018 05:30:21 +0000 (22:30 -0700)]
Port Coverage::Iter off hb_auto_t<>
Behdad Esfahbod [Tue, 30 Oct 2018 01:05:25 +0000 (18:05 -0700)]
Remove a few unnecessary hb_auto_t<>'s
See
a85641446c30247c4e948263f0f8c1147ed4efb9
Behdad Esfahbod [Tue, 30 Oct 2018 00:37:41 +0000 (17:37 -0700)]
[set/map/vector] Make constructable, but not copy or assignable
Disable copy/assign on them, as they shouldn't.
Make constructor / destructor call init_shallow/fini_shallow,
and make those idempotent. So, these three can be constructed
on stack now and no init/fini call is needed. As such,
hb_auto_t<> is not needed anymore. I'll remove that separately.
Behdad Esfahbod [Mon, 29 Oct 2018 23:00:23 +0000 (16:00 -0700)]
Add HB_NO_CREATE_COPY_ASSIGN
Behdad Esfahbod [Mon, 29 Oct 2018 22:58:44 +0000 (15:58 -0700)]
Remove HB_DISALLOW_COPY_AND_ASSIGN from hb_ot_shape_planner_t
It was arbitrary that this struct had it and not dozens of others.
Behdad Esfahbod [Mon, 29 Oct 2018 22:29:13 +0000 (15:29 -0700)]
One more iteration
Behdad Esfahbod [Mon, 29 Oct 2018 22:16:52 +0000 (15:16 -0700)]
Try fixing older bots
Older C++ doesn't allow struct-with-constructor in union.
Behdad Esfahbod [Mon, 29 Oct 2018 22:16:38 +0000 (15:16 -0700)]
[cmap] Minor
Behdad Esfahbod [Mon, 29 Oct 2018 21:45:44 +0000 (14:45 -0700)]
Remove ASSERT_POD
Newer compilers / language allows structs with constructor in union.
So, this was not actually testing anything. Indeed, the recent
change in DISALLOW_COPY *is* making some of our types non-POD.
That broke some bots.
Just remove this since it wasn't doing much, and I'd rather have
DISALLOW_COPY.
Behdad Esfahbod [Mon, 29 Oct 2018 20:51:15 +0000 (13:51 -0700)]
Fix extra-semicolon warnings
Behdad Esfahbod [Mon, 29 Oct 2018 18:25:35 +0000 (11:25 -0700)]
Make Array types uncopyable-unassignable
Finally! Catches hard-to-find errors like this:
- const SortedArrayOf<SVGDocumentIndexEntry> docs = this+svgDocEntries;
+ const SortedArrayOf<SVGDocumentIndexEntry> &docs = this+svgDocEntries;
We implement this for our array types. This, in turn, trickles down
into all types that embed the arrays. So, as long as we define all
open-ended structs in terms of Array types (all can be done using
UnsizedArrayOf), this achieves the goal of making uncopyable all
structs that are variable-sized. Yay!
Behdad Esfahbod [Mon, 29 Oct 2018 18:14:37 +0000 (11:14 -0700)]
[svg] Minor
Behdad Esfahbod [Mon, 29 Oct 2018 18:01:25 +0000 (11:01 -0700)]
Fix g-i warnings
Ebrahim Byagowi [Mon, 29 Oct 2018 10:12:14 +0000 (13:42 +0330)]
[test-ot-color] Minor
Ebrahim Byagowi [Mon, 29 Oct 2018 09:41:01 +0000 (13:11 +0330)]
Rename deprecated symbols list file name and clean it up (#1328)
Ebrahim Byagowi [Mon, 29 Oct 2018 09:04:33 +0000 (12:34 +0330)]
Merge pull request #1326 from ebraminio/test-ot-color
Revive and rename dump-emoji to test-ot-color but use public APIs instead
Ebrahim Byagowi [Mon, 29 Oct 2018 08:06:11 +0000 (11:36 +0330)]
[test-ot-color] Use public APIs on the tool
Ebrahim Byagowi [Mon, 29 Oct 2018 06:13:17 +0000 (09:43 +0330)]
Rename dump-emoji to test-ot-color
Ebrahim Byagowi [Mon, 29 Oct 2018 06:10:39 +0000 (09:40 +0330)]
Revive dump-emoji
Ebrahim Byagowi [Mon, 29 Oct 2018 06:59:58 +0000 (10:29 +0330)]
[svg] Fix incorrect array referencing
Behdad Esfahbod [Mon, 29 Oct 2018 06:16:13 +0000 (23:16 -0700)]
[cbdt] Implement strike selection logic
Behdad Esfahbod [Mon, 29 Oct 2018 06:14:15 +0000 (23:14 -0700)]
[sbix] Minor
Behdad Esfahbod [Mon, 29 Oct 2018 06:07:59 +0000 (23:07 -0700)]
[cbdt] Simplify more
Behdad Esfahbod [Mon, 29 Oct 2018 06:04:37 +0000 (23:04 -0700)]
[color] Rename get_strike() to choose_strike()
Behdad Esfahbod [Mon, 29 Oct 2018 06:03:20 +0000 (23:03 -0700)]
[tests] Fix for recent rounding change in CBDT
Behdad Esfahbod [Mon, 29 Oct 2018 06:01:57 +0000 (23:01 -0700)]
[cbdt] Refactor get_strike()
Behdad Esfahbod [Mon, 29 Oct 2018 05:46:18 +0000 (22:46 -0700)]
[cbdt] Minor
Behdad Esfahbod [Mon, 29 Oct 2018 05:45:53 +0000 (22:45 -0700)]
[color] Round extents when scaling
Ebrahim Byagowi [Mon, 29 Oct 2018 05:11:13 +0000 (08:41 +0330)]
[ot-color/png] Consider strike ppem on scaling
Behdad Esfahbod [Mon, 29 Oct 2018 01:32:37 +0000 (18:32 -0700)]
[svg] Cosmetic
Behdad Esfahbod [Mon, 29 Oct 2018 01:29:14 +0000 (18:29 -0700)]
[svg] Use SortedArrayOf.bsearch
Behdad Esfahbod [Mon, 29 Oct 2018 01:26:49 +0000 (18:26 -0700)]
[svg] Minor
Behdad Esfahbod [Mon, 29 Oct 2018 01:01:25 +0000 (18:01 -0700)]
[sbix] Comment
Behdad Esfahbod [Sun, 28 Oct 2018 23:32:20 +0000 (16:32 -0700)]
[color] Minor
Behdad Esfahbod [Sun, 28 Oct 2018 23:29:09 +0000 (16:29 -0700)]
Minor
Behdad Esfahbod [Sun, 28 Oct 2018 23:27:18 +0000 (16:27 -0700)]
[sbix] Use LOffsetLArrayOf<>
Behdad Esfahbod [Sun, 28 Oct 2018 23:26:03 +0000 (16:26 -0700)]
[sbix] Add get_strike
Behdad Esfahbod [Sun, 28 Oct 2018 22:58:48 +0000 (15:58 -0700)]
[sbix] Remove sbix_len
Behdad Esfahbod [Sun, 28 Oct 2018 22:53:11 +0000 (15:53 -0700)]
[sbix] Fix get_glyph_blob() on Null object
Behdad Esfahbod [Sun, 28 Oct 2018 22:44:40 +0000 (15:44 -0700)]
[sbix] Simplify ppem access
If struct members are simple and needed publicly, we make them public.
Behdad Esfahbod [Sun, 28 Oct 2018 22:43:54 +0000 (15:43 -0700)]
[sbix] Simplify glyph_length calc
Behdad Esfahbod [Sun, 28 Oct 2018 22:38:42 +0000 (15:38 -0700)]
[sbix] Check glyph data end is in range
Behdad Esfahbod [Sun, 28 Oct 2018 22:36:17 +0000 (15:36 -0700)]
[sbix] Reduce code
Behdad Esfahbod [Sun, 28 Oct 2018 22:33:12 +0000 (15:33 -0700)]
[sbix] Check glyph id before looking into unsafe array
That 'Z' at end of imageOffsetsZ is a reminder that you should check...
Behdad Esfahbod [Sun, 28 Oct 2018 22:30:57 +0000 (15:30 -0700)]
[sbix] Simplify 'dupe' handling logic
Behdad Esfahbod [Sun, 28 Oct 2018 22:27:04 +0000 (15:27 -0700)]
[sbix] Check offsets before proceeding
Behdad Esfahbod [Sun, 28 Oct 2018 22:20:33 +0000 (15:20 -0700)]
[color] Remove more dump-emoji cruft
Behdad Esfahbod [Sun, 28 Oct 2018 22:18:55 +0000 (15:18 -0700)]
Remove dump-emoji
Behdad Esfahbod [Sun, 28 Oct 2018 22:13:45 +0000 (15:13 -0700)]
[sbix] Fix order of parameters
Behdad Esfahbod [Sun, 28 Oct 2018 22:12:05 +0000 (15:12 -0700)]
[sbix] Remove redundant parameter
Behdad Esfahbod [Sun, 28 Oct 2018 22:11:10 +0000 (15:11 -0700)]
[sbix] Add get_strike()
Behdad Esfahbod [Sun, 28 Oct 2018 22:05:40 +0000 (15:05 -0700)]
[sbix] Remove a couple of extra checks
Behdad Esfahbod [Sun, 28 Oct 2018 22:02:53 +0000 (15:02 -0700)]
[sbix] Rename sbix_table to table in accelerator
Behdad Esfahbod [Sun, 28 Oct 2018 22:00:13 +0000 (15:00 -0700)]
[cbdt] Rename reference_blob_for_glyph() to reference_png()
Behdad Esfahbod [Sun, 28 Oct 2018 21:56:55 +0000 (14:56 -0700)]
[sbix] Rename ugly reference_blob_for_glyph() to reference_png()
Behdad Esfahbod [Sun, 28 Oct 2018 21:52:25 +0000 (14:52 -0700)]
[sbix] Fix uninitialized variables
Behdad Esfahbod [Sun, 28 Oct 2018 21:51:18 +0000 (14:51 -0700)]
[sbix] Select best strike based on ppem
Behdad Esfahbod [Sun, 28 Oct 2018 21:20:50 +0000 (14:20 -0700)]
[sbix] Move code around. Add get_extents()
Behdad Esfahbod [Sun, 28 Oct 2018 21:16:52 +0000 (14:16 -0700)]
[sbix] Check blob length against PNG header leangth
Ebrahim Byagowi [Sun, 28 Oct 2018 20:58:44 +0000 (00:28 +0330)]
[ot-color] More on PNGHeader fields
Ebrahim Byagowi [Sun, 28 Oct 2018 20:37:26 +0000 (00:07 +0330)]
[ot-color] Apply Behdad comment
Ebrahim Byagowi [Sun, 28 Oct 2018 20:33:01 +0000 (00:03 +0330)]
[ot-color] Make PNGHeader reading actually work
Ebrahim Byagowi [Sun, 28 Oct 2018 20:13:50 +0000 (23:43 +0330)]
[ot-color] Implement PNGHeader and test it, it doesn't work however
Ebrahim Byagowi [Sun, 28 Oct 2018 19:49:04 +0000 (23:19 +0330)]
[ot-color] Preparation for setting PNG width/height in extents
Behdad Esfahbod [Sun, 28 Oct 2018 18:41:33 +0000 (11:41 -0700)]
[docs] Add comment
Ebrahim Byagowi [Sun, 28 Oct 2018 18:08:56 +0000 (21:38 +0330)]
[ot-color] Apply Behdad reviews
Ebrahim Byagowi [Sun, 28 Oct 2018 16:39:40 +0000 (20:09 +0330)]
[ot-color] Apply Behdad comment
Ebrahim Byagowi [Sat, 27 Oct 2018 11:45:24 +0000 (15:15 +0330)]
[ot-color] Add public API for CBDT/sbix/SVG color Emojis
Behdad Esfahbod [Sun, 28 Oct 2018 15:26:30 +0000 (08:26 -0700)]
[name] Change hb_name_id_t back to unsigned int
https://github.com/harfbuzz/harfbuzz/commit/
d941f66c75fe26f909b1ba248535cc372bbde851#commitcomment-
31076011
Behdad Esfahbod [Sun, 28 Oct 2018 15:23:36 +0000 (08:23 -0700)]
[docs] Fix titles here as well
Behdad Esfahbod [Sun, 28 Oct 2018 01:36:24 +0000 (18:36 -0700)]
[name] Make sure hb_name_id_t is int-sized
https://github.com/harfbuzz/harfbuzz/commit/
d941f66c75fe26f909b1ba248535cc372bbde851#commitcomment-
31068905
Behdad Esfahbod [Sat, 27 Oct 2018 12:07:54 +0000 (05:07 -0700)]
[docs] Divide reference API into three chapters
Behdad Esfahbod [Sat, 27 Oct 2018 12:00:42 +0000 (05:00 -0700)]
[docs] Hook up hb-var
Behdad Esfahbod [Sat, 27 Oct 2018 11:58:32 +0000 (04:58 -0700)]
[docs] Document remaining sections
Behdad Esfahbod [Sat, 27 Oct 2018 11:50:38 +0000 (04:50 -0700)]
[docs] Change section titles again
I think I like the uniform "hb-*" more.
Behdad Esfahbod [Sat, 27 Oct 2018 11:40:43 +0000 (04:40 -0700)]
[docs] More
Behdad Esfahbod [Sat, 27 Oct 2018 11:28:40 +0000 (04:28 -0700)]
[docs] Rename section titles to object names
More useful.
Behdad Esfahbod [Sat, 27 Oct 2018 11:27:36 +0000 (04:27 -0700)]
[docs] More
Behdad Esfahbod [Sat, 27 Oct 2018 11:21:20 +0000 (04:21 -0700)]
[ot] Fold hb-ot-tag.h into hb-ot-layout.h
Behdad Esfahbod [Sat, 27 Oct 2018 11:07:33 +0000 (04:07 -0700)]
[docs] Fill in some sections
Behdad Esfahbod [Sat, 27 Oct 2018 11:01:19 +0000 (04:01 -0700)]
Move HB_EXTERN
Ebrahim Byagowi [Sat, 27 Oct 2018 11:34:43 +0000 (15:04 +0330)]
Merge pull request #1318 from ebraminio/png
Add a non-hooked _png _svg get emoji blob
Ebrahim Byagowi [Sat, 27 Oct 2018 11:15:00 +0000 (14:45 +0330)]
[ot-color] Remove _png and _svg public APIs
Ebrahim Byagowi [Sat, 27 Oct 2018 10:54:58 +0000 (14:24 +0330)]
[ot-color/png] Try to get image blob from sbix first options.aat is set
Ebrahim Byagowi [Sat, 27 Oct 2018 10:45:38 +0000 (14:15 +0330)]
[ot-color] Add some documentation
Behdad Esfahbod [Sat, 27 Oct 2018 10:18:45 +0000 (03:18 -0700)]
[docs] Fix hb_name_id_t
Yep, was not recognized without this patch!
Ebrahim Byagowi [Sat, 27 Oct 2018 10:02:14 +0000 (13:32 +0330)]
[ot-color/png] Implement CBDT part
Behdad Esfahbod [Sat, 27 Oct 2018 10:15:34 +0000 (03:15 -0700)]
[docs] Hook up hb-map
Behdad Esfahbod [Sat, 27 Oct 2018 09:55:52 +0000 (02:55 -0700)]
[name] Make hb_name_id_t be the enum
This is like hb_script_t.
We had this exposed as unsigned int since 2.0.0 release in two APIs,
as well as hb_ot_layout_get_size_params() from earlier.
But since no one uses those (right?!), let's just fix this now.
Behdad Esfahbod [Sat, 27 Oct 2018 09:49:32 +0000 (02:49 -0700)]
[name] Move HB_NAME_ID_INVALID into the enum
Don't know how to document anonymous enum members.
Behdad Esfahbod [Sat, 27 Oct 2018 09:45:57 +0000 (02:45 -0700)]
[name] Move around
Behdad Esfahbod [Sat, 27 Oct 2018 09:39:20 +0000 (02:39 -0700)]
[name] Rename hb_ot_name_get_names() to hb_ot_name_list_names()
And swap return value positions, so can be annotated for gobject-introspectin.