Kristian Høgsberg [Tue, 6 Mar 2012 01:51:34 +0000 (20:51 -0500)]
shell: Put popups and transients on top of their parent
In other words, don't map the panel menu under the panel.
Kristian Høgsberg [Tue, 6 Mar 2012 01:38:08 +0000 (20:38 -0500)]
window: Compute frame boundary for all windows except fullscreen
We were only computing it for toplevel type windows, which broke
the unlock dialog size allocation and repainting.
Kristian Høgsberg [Tue, 6 Mar 2012 01:37:51 +0000 (20:37 -0500)]
desktop-shell: Simplify unlock dialog redraw function
Kristian Høgsberg [Tue, 6 Mar 2012 00:57:35 +0000 (19:57 -0500)]
drm: Disable sprites if they're broken
Current sprite implementation has a color format bug. Disable sprites
if they don't work and avoid spamming stderr and syslog.
Kristian Høgsberg [Tue, 6 Mar 2012 00:50:08 +0000 (19:50 -0500)]
compositor: Only process input once per frame
When we're repainting, there's no point in polling for input events.
We just read input events once before each repaint and send out events
as needed. The input events come with an accurate timestamp, so this
doesn't affect the timing information and client should always look at
the event timestamps if they're trying to determine pointer motion
speed or double click speed. If we go idle (stop repainting) we add the
input devices back into the primary main loop and wait for the next event.
This avoids waking up the compositor separately (one or more times per
frame) to handle input events. We also avoid updating cursor position
and other compositor state after the client has rendered its new
frame, reducing lag between what the client renders and the pointer
position.
Kristian Høgsberg [Mon, 5 Mar 2012 22:49:30 +0000 (17:49 -0500)]
compositor: Move input devices to their own event loop
First step towards only handling input at repaint time.
Kristian Høgsberg [Mon, 5 Mar 2012 22:47:15 +0000 (17:47 -0500)]
compositor: Swallow binding key for bindings that don't set up a grab
This prevents passing the key press and release to the keyboard focus client.
Kristian Høgsberg [Mon, 5 Mar 2012 04:47:56 +0000 (23:47 -0500)]
window: Only set opaque and input regions if they change
Setting these regions damages the entire window or causes a repick, which
we don't want to trigger if we don't need to.
Kristian Høgsberg [Mon, 5 Mar 2012 03:35:47 +0000 (22:35 -0500)]
Use wl_array_for_each() where possible
Pekka Paalanen [Fri, 2 Mar 2012 15:33:17 +0000 (17:33 +0200)]
compositor-drm: fix libbacklight build
Bad inclusion of DRM headers, missing some system headers.
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Kristian Høgsberg [Mon, 5 Mar 2012 02:57:37 +0000 (21:57 -0500)]
Use typesafe server-side stubs
Kristian Høgsberg [Sun, 4 Mar 2012 19:53:40 +0000 (14:53 -0500)]
compositor: Add a repaint debugging mechanism
Toggle on/off with Super+SPACE.
Kristian Høgsberg [Fri, 2 Mar 2012 13:14:40 +0000 (08:14 -0500)]
Merge branch 'layers'
I was integrating patches on the 'layers' branch and had a fixed version of
the fullscreen patch there. My master branch had the fullscreen patch with
the resize bug, and when I pushed I meant to push the layers branch to master.
Conflicts:
src/shell.c
Kristian Høgsberg [Thu, 1 Mar 2012 22:11:36 +0000 (17:11 -0500)]
shell: Don't launch a new screensaver if the old one is still running
Kristian Høgsberg [Thu, 1 Mar 2012 22:10:25 +0000 (17:10 -0500)]
compositor: Damage sprite surface on attach
Normally the client is responsible for damaging the surface after attach,
but the sprite surface is an internal surface.
Kristian Høgsberg [Thu, 1 Mar 2012 22:09:37 +0000 (17:09 -0500)]
compositor: Post keyboard leave before destroying surface
We may want to move this into wayland-server.
Ander Conselvan de Oliveira [Thu, 1 Mar 2012 12:09:44 +0000 (14:09 +0200)]
compositor: split drag surface update into smaller functions
Ander Conselvan de Oliveira [Thu, 1 Mar 2012 12:09:44 +0000 (14:09 +0200)]
compositor: fix crash when a drag surface is destroyed during the drag
This can happen for instance if the client that started the drag
crashes. Weston would crash because of the invalid surface pointed by
device->drag_surface.
Fix this by reseting the drag surface to nil on a destroy listener.
Kristian Høgsberg [Wed, 29 Feb 2012 17:42:35 +0000 (12:42 -0500)]
compositor: Organize surface stack using new struct weston_layer
The surface data structure is now a list of list of surfaces. The core
compositor defines the fade and cursor layer, and it's up to the shell to
provide more layers for the various surface types it implements.
Kristian Høgsberg [Wed, 29 Feb 2012 04:07:47 +0000 (23:07 -0500)]
compositor: Just damage compositor->damage in weston_output_damage()
Kristian Høgsberg [Wed, 29 Feb 2012 03:47:14 +0000 (22:47 -0500)]
compositor: Implement damage_below by using the new compositor->damage
We can now clip the surface bounding box against the previous frame
opaque clip, and then just union the result (visible damage) into
compositor->damage immediately.
Kristian Høgsberg [Wed, 29 Feb 2012 03:31:58 +0000 (22:31 -0500)]
compositor: Store opaque clip for previous frame in weston_surface
Alex Wu [Thu, 1 Mar 2012 04:57:46 +0000 (12:57 +0800)]
shell: Add implementation of fullscreen.
Undo fullscreen in shell_unset_fullscreen(), do all the stacking order
in shell_stack_fullscreen(), and configure black surface, method in
shell_configure_fullscreen().
Signed-off-by: Alex Wu <zhiwen.wu@linux.intel.com>
Signed-off-by: Juan Zhao <juan.j.zhao@linux.intel.com>
Alex Wu [Thu, 1 Mar 2012 04:57:46 +0000 (12:57 +0800)]
shell: Add implementation of fullscreen.
Undo fullscreen in shell_unset_fullscreen(), do all the stacking order
in shell_stack_fullscreen(), and configure black surface, method in
shell_configure_fullscreen().
Signed-off-by: Alex Wu <zhiwen.wu@linux.intel.com>
Signed-off-by: Juan Zhao <juan.j.zhao@linux.intel.com>
Kristian Høgsberg [Wed, 29 Feb 2012 21:15:53 +0000 (16:15 -0500)]
window.c: Drop support for rgb contexts
Kristian Høgsberg [Wed, 29 Feb 2012 21:14:22 +0000 (16:14 -0500)]
wscreensaver: Use the argb config, rgb is not compatible with window.c
Fixes the config/surface mismatch, spotted by Scott Moreau.
Kristian Høgsberg [Wed, 29 Feb 2012 19:23:51 +0000 (14:23 -0500)]
compositor-drm: Just pull in libbacklight source for now
libbacklight is 300 lines of code in one .c file, and we're relying on
udev changes that aren't yet upstream. For now, let's just keep a
copy in weston and if the Xorg DDX drivers start using libbacklight and
it becomes more widely available, we'll make it an external dependency.
Tiago Vignatti [Wed, 29 Feb 2012 17:53:50 +0000 (19:53 +0200)]
compositor: add dpms and backlight support
DPMS kicks in only when wscreensaver is launched, in the moment that shell
call lock() for the second time. Backlight control internals are managed by
libbacklight:
http://cgit.freedesktop.org/~vignatti/libbacklight/
Signed-off-by: Tiago Vignatti <tiago.vignatti@intel.com>
Kristian Høgsberg [Wed, 29 Feb 2012 04:12:52 +0000 (23:12 -0500)]
zoom: Don't damage_all here
Setting geometry.dirty = 1 is enough.
Kristian Høgsberg [Wed, 29 Feb 2012 04:38:53 +0000 (23:38 -0500)]
compositor: Insert dnd icon surface below device sprite surface
Kristian Høgsberg [Wed, 29 Feb 2012 17:22:38 +0000 (12:22 -0500)]
compositor: Set an empty input region for the fade surface
Otherwise we don't set the cursor until the fade is done.
Kristian Høgsberg [Wed, 29 Feb 2012 02:52:12 +0000 (21:52 -0500)]
window: Set opaque region after child widget adjusts size
Rodney Lorrimar [Wed, 29 Feb 2012 16:31:03 +0000 (17:31 +0100)]
weston: Change path for default terminal launcher to ${prefix}/bin
If you don't have anything at ~/.config/weston-desktop-shell.ini and
have weston installed somewhere other than /usr, then this patch will
help.
Cheers,
Signed-off-by: Rodney Lorrimar <rodney@rodney.id.au>
Kristian Høgsberg [Tue, 28 Feb 2012 19:29:19 +0000 (14:29 -0500)]
clients: Use wl_display_disconnect()
Ander Conselvan de Oliveira [Tue, 28 Feb 2012 15:59:33 +0000 (17:59 +0200)]
compositor: make the input region of drag surfaces empty
With the input region changes, drag surfaces were being picked and
receiving events which led to problems on the client side.
Kristian Høgsberg [Tue, 28 Feb 2012 14:20:21 +0000 (09:20 -0500)]
shell: Mark geometry dirty when we change surface alpha
We need to recompute the opaque region when the alpha changes.
Kristian Høgsberg [Tue, 28 Feb 2012 14:19:39 +0000 (09:19 -0500)]
compositor: Dont set the opaque region if we have an overall surface alpha
Kristian Høgsberg [Tue, 28 Feb 2012 14:17:32 +0000 (09:17 -0500)]
terminal: Don't queue a resize after setting fullscreen
We end up doing an attach at the non-fullscreen size before resizing to
fullscreen, causing the terminal to jump to the center for a frame before we
render the fullscreen image.
Alex Wu [Tue, 28 Feb 2012 10:07:54 +0000 (18:07 +0800)]
compositor: Export functions and add weston_suface::force_configure for fullscreen
This will facilitate the implementation of fullscreen.
Signed-off-by: Alex Wu <zhiwen.wu@linux.intel.com>
Scott Moreau [Fri, 24 Feb 2012 05:28:37 +0000 (22:28 -0700)]
Restructure output zoom key handling.
This effectively eats the keybinding events, as we don't want them sent
to clients.
Kristian Høgsberg [Fri, 24 Feb 2012 16:03:27 +0000 (11:03 -0500)]
drm: Remove redundant cursor region math
We already check this in weston_output_set_cursor().
Kristian Høgsberg [Fri, 24 Feb 2012 04:07:45 +0000 (23:07 -0500)]
drm: Remove redundant weston_surface_update_transform() call
Kristian Høgsberg [Fri, 24 Feb 2012 04:06:13 +0000 (23:06 -0500)]
compositor: Remove surface overlapped attribute
We need to compute this as we assign surfaces to overlays, so that
if we assign a surface to an overlay, it isn't considered overlapping.
Kristian Høgsberg [Fri, 24 Feb 2012 04:03:14 +0000 (23:03 -0500)]
Move weston_output_set_cursor into compositor-drm.c
First step towards moving hw cursor handling into compositor-drm.c a its
general overlay handling.
Kristian Høgsberg [Fri, 24 Feb 2012 02:45:32 +0000 (21:45 -0500)]
compositor-drm: Destroy sprites on shutdown, turn off on vt switch
Kristian Høgsberg [Fri, 24 Feb 2012 02:29:55 +0000 (21:29 -0500)]
compositor: Remove unused compositor vfunc create_cursor_image
Jesse Barnes [Thu, 23 Feb 2012 14:45:49 +0000 (09:45 -0500)]
compositor-drm: Add sprite support
Add support for assigning surfaces to overlay sprites using the new
assign_planes hook.
Jesse Barnes [Thu, 9 Feb 2012 21:12:57 +0000 (13:12 -0800)]
compositor: add an assign_planes hook to the output
This allows each output back end to optimize drawing using overlay planes
and cursors (yet to be integrated). If a surface is assigned to a
plane, the back end should clear its damage field so that the later
repaint code won't look at it.
Scott Moreau [Wed, 22 Feb 2012 20:57:51 +0000 (13:57 -0700)]
Fix pointer position clipping.
Scott Moreau [Wed, 22 Feb 2012 21:21:41 +0000 (14:21 -0700)]
Introduce output zoom.
Ideally, we would want to use <modifier>+Scroll binding but that will have
to wait for axis events. For now we just use keybindings. Zoom in/out with
Super+Up/Down.
Kristian Høgsberg [Thu, 23 Feb 2012 22:38:33 +0000 (17:38 -0500)]
compositor: Initialize destroy_listener_list for internal surfaces too
We use this to look up user data on the surface, so make sure the list is
always valid.
Kristian Høgsberg [Thu, 23 Feb 2012 22:30:45 +0000 (17:30 -0500)]
window: Track and report input and opaque regions
We just set the input region to the bounding box of the window frame
and set the opaque region to be the opaque rectangle inside the window
if the child widget is opaque.
Kristian Høgsberg [Thu, 23 Feb 2012 21:20:38 +0000 (16:20 -0500)]
simple-touch: Update to enter/leave changes
Kristian Høgsberg [Thu, 23 Feb 2012 21:11:59 +0000 (16:11 -0500)]
compositor: Implement opqaue and input regions
Ander Conselvan de Oliveira [Thu, 23 Feb 2012 11:29:26 +0000 (13:29 +0200)]
compositor: assign output to drag surfaces
Otherwise we endup with a surface that is mapped but with outtup nil.
Ander Conselvan de Oliveira [Thu, 23 Feb 2012 11:29:25 +0000 (13:29 +0200)]
shell: don't assign output for surface of type none
If map is called with a surface of type none it will call
weston_surface_assign_output, even though the surface will
not be mapped.
Kristian Høgsberg [Thu, 23 Feb 2012 14:59:05 +0000 (09:59 -0500)]
Update to enter/leave events for pointer and keyboard
Alex Wu [Wed, 22 Feb 2012 06:50:46 +0000 (14:50 +0800)]
shell: Fix never map fullscreen/transient surface.
If client send set_fullscreen/set_transient request before the first attach,
compositor has no chance to map the surface due to "if (es->output == NULL)".
You can pull it from git://gitorious.org/wayland-for-krh/weston.git map-bug
Kristian Høgsberg [Mon, 20 Feb 2012 03:46:13 +0000 (22:46 -0500)]
compositor: Remove redundant weston_surface_damage_below() calls
In the attach case we always end up calling weston_surface_damage_below()
through weston_surface_update_transform() if and only if we need it.
Kristian Høgsberg [Mon, 20 Feb 2012 03:15:21 +0000 (22:15 -0500)]
compositor: Surface is unmapped when surface->output is NULL
surface->buffer can be NULL, which happens when a client destroys the
attached buffer. Fixes list corruption on resize.
Kristian Høgsberg [Sun, 19 Feb 2012 23:52:44 +0000 (18:52 -0500)]
shell: Revive super-tab application switcher
We can do this right, now that we have keyboard grabs.
Kristian Høgsberg [Sun, 19 Feb 2012 23:50:55 +0000 (18:50 -0500)]
compositor: Don't run keybindings if we have a key grab
Scott Moreau [Sat, 18 Feb 2012 12:05:30 +0000 (05:05 -0700)]
compositor: Setup for keyboard grabs.
Scott Moreau [Sat, 18 Feb 2012 12:05:29 +0000 (05:05 -0700)]
Track server changes.
Kristian Høgsberg [Sat, 18 Feb 2012 04:49:07 +0000 (23:49 -0500)]
compositor: Move fullscreen_output to shell_surface
Kristian Høgsberg [Fri, 17 Feb 2012 17:45:43 +0000 (12:45 -0500)]
compositor: Make weston_surface_damage_below_noupdate() the default
We never want to update the transform and then damage below. Damage
below is always used to trigger a repaint where the surface used to be
so we need to record the damage before updating the transform.
Kristian Høgsberg [Fri, 17 Feb 2012 17:43:56 +0000 (12:43 -0500)]
compositor: Move unmap logic to new function weston_surface_unmap()
Kristian Høgsberg [Fri, 17 Feb 2012 17:15:27 +0000 (12:15 -0500)]
compositor: Only delete surface texture if we have one
Kristian Høgsberg [Fri, 17 Feb 2012 15:45:16 +0000 (10:45 -0500)]
compositor: Get rid of surface->visual
Kristian Høgsberg [Fri, 17 Feb 2012 04:43:59 +0000 (23:43 -0500)]
shell: Set geometry directly in configure
We already set half of it directly, and overwrite it in other cases, so
just skip weston_surface_configure().
Kristian Høgsberg [Fri, 17 Feb 2012 04:38:14 +0000 (23:38 -0500)]
shell: Restore basic fullscreen functionality
This just fixes the default case.
Kristian Høgsberg [Fri, 17 Feb 2012 03:57:21 +0000 (22:57 -0500)]
window: Don't draw decorations in fullscreen mode
Kristian Høgsberg [Fri, 17 Feb 2012 03:56:12 +0000 (22:56 -0500)]
window: Set window type as it changes, not on every attach
It was always a bit sloppy, and the new fullscreen request doesn't work
that way.
Kristian Høgsberg [Fri, 17 Feb 2012 03:51:33 +0000 (22:51 -0500)]
view: Don't schedule resize after setting fullscreen
window_set_fullscreen will schedule a resize or wait for the configure
event as needed.
Daniel Stone [Thu, 16 Feb 2012 12:48:00 +0000 (12:48 +0000)]
window: Use constant keycode offset of 8
The X11 compositor currently posts its key presses as keycode - 8; this
is due to X11 having a historical minimum keycode of 8, whereas evdev is
numbered starting from 1. So while the KEY_* constants begin with
KEY_ESC at 1, the corresponding keycode in both X11 and the XKB keymaps
is 9.
window, on the other hand, was relying on xkb->min_key_code being 8 to
translate its keycodes back to useful values in the XKB 'evdev' keycode
map. min_key_code may not always be 8, for restricted subsets of the
keycode map.
Perhaps not the best solution, but at least consistent.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Daniel Stone [Wed, 15 Feb 2012 16:33:21 +0000 (16:33 +0000)]
window: Use new xkbcommon include path
xkbcommon in current git has moved its include files.
Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Pekka Paalanen [Tue, 14 Feb 2012 12:59:18 +0000 (14:59 +0200)]
protocol: remove absolute coordinates from pointer
This change depens on the Wayland core commit:
"protocol: remove absolute coordinates from pointer".
Remove the absolute coordinates from pointer motion and pointer_focus
events.
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Pekka Paalanen [Mon, 13 Feb 2012 13:33:28 +0000 (15:33 +0200)]
window: do not store absolute coordinates
These were not used for anything, anyway.
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Ander Conselvan de Oliveira [Wed, 15 Feb 2012 15:02:58 +0000 (17:02 +0200)]
clients/dnd: adapt to new data_device icon protocol
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Ander Conselvan de Oliveira [Wed, 15 Feb 2012 15:02:57 +0000 (17:02 +0200)]
compositor: implement drag'n'drop icons
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Ander Conselvan de Oliveira [Wed, 15 Feb 2012 15:02:56 +0000 (17:02 +0200)]
shell: update position of surfaces with type none on map()
Needed for implementing drag'n'drop icons. When a drag starts, the
compositor will position the top-left corner of the client supplied
icon surface at the cursor hotspot. On the first attach to that
surface, the client may want to reposition it but shell->map did not
take sx and sy parameters.
This changes shell->map interface to take sx and sy parameters and
change dekstop shell implementation to update the position of a
surface of type none according to those parameters. Since a surface
of type none won't actually be mapped, the effect of this change is
only visible for surfaces that are made visible by the compositor.
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Ander Conselvan de Oliveira [Wed, 15 Feb 2012 15:02:55 +0000 (17:02 +0200)]
compositor: add a way to disable picking of client surfaces
Surfaces like drag'n'drop icons shouldn't receive events as a normal
surface but are still created by the client so add a way for the
compositor to enable or disable the picking of a client surface.
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Ander Conselvan de Oliveira [Wed, 15 Feb 2012 15:02:54 +0000 (17:02 +0200)]
shell: don't map surfaces with type NONE
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Ander Conselvan de Oliveira [Wed, 15 Feb 2012 15:02:53 +0000 (17:02 +0200)]
compositor: fix two crashs on surface_attach() with null buffer
The condition to return from surface_attach with a null buffer involves
es->output being non-null. However if a surface was just created this
field would be null and an attach of a null buffer would cause the
compositor to crash.
The other crash happened if surface_attach was called twice with a
null buffer after a valid buffer was attached to the surface. Since
es->buffer was not being set to NULL, surface_attach() would call
wl_list_remove(&es->buffer_destroy_listener.link) twice for the same
surface.
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Kristian Høgsberg [Thu, 16 Feb 2012 20:58:14 +0000 (15:58 -0500)]
Follow set_fullscreen protocol change
Kristian Høgsberg [Thu, 16 Feb 2012 20:53:46 +0000 (15:53 -0500)]
window: Toggle maximized with super-f5
Juan Zhao [Tue, 7 Feb 2012 00:45:41 +0000 (08:45 +0800)]
shell: Add the set_maximized implementation
Pekka Paalanen [Mon, 13 Feb 2012 11:03:59 +0000 (13:03 +0200)]
compositor, shell: add and use weston_surface_set_position()
Another shorthand like weston_surface_configure().
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Pekka Paalanen [Fri, 10 Feb 2012 14:40:22 +0000 (16:40 +0200)]
shell: remove two redundant statements from map()
I stared at this function for some time, and these were the only lines
I could sanely remove.
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Tiago Vignatti [Fri, 10 Feb 2012 14:26:19 +0000 (16:26 +0200)]
compositor: make functions static
I know it's hard to figure out what the shells or backends will be
using as internal API at this point but we can try to minimize the
amount of WL_EXPORT being used anyway.
[pq: redone due to my earlier changes]
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Tiago Vignatti [Fri, 10 Feb 2012 14:17:23 +0000 (16:17 +0200)]
shell: remove duplicated code
This clean-up seems alright, but someone with better knowledge has to
doublecheck this function. I guess there's a lot of space for clean-up
there.
[pq: looks ok, redone since did not apply after my changes]
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Tiago Vignatti [Thu, 9 Feb 2012 17:06:56 +0000 (19:06 +0200)]
clients: fix spelling
Signed-off-by: Tiago Vignatti <vignatti@freedesktop.org>
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Tiago Vignatti [Thu, 9 Feb 2012 17:06:55 +0000 (19:06 +0200)]
window: simplify a bit widget_set_size and widget_set_allocation
Signed-off-by: Tiago Vignatti <vignatti@freedesktop.org>
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Tiago Vignatti [Thu, 9 Feb 2012 17:06:54 +0000 (19:06 +0200)]
window: explicitly set TYPE_TOPLEVEL for new windows
Signed-off-by: Tiago Vignatti <vignatti@freedesktop.org>
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Pekka Paalanen [Mon, 13 Feb 2012 09:04:30 +0000 (11:04 +0200)]
shell: do not apply damage on window type set
Setting a window type is a non-visual operation, it is not supposed to
affect the rendering immediately. Therefore it does not need to apply
surface damage.
The proper surface damage is applied on an attach request following a
window type change.
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Pekka Paalanen [Mon, 13 Feb 2012 09:01:59 +0000 (11:01 +0200)]
compositor: remove redundant cursor damage calls
As weston_surface_update_transform() automatically applies before and
after damage on surface geometry change, we don't need to explicitly add
the same damage in motion_notify() for the cursor surface.
We still need the side-effect, that is scheduling a repaint.
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Pekka Paalanen [Mon, 13 Feb 2012 08:34:04 +0000 (10:34 +0200)]
compositor: round off fractions
Round off fractions from non-transformed surface position coordinates.
Transformed surface moved by a client may have non-integer position
coordinates. That is required to prevent drifting on continuous
resizing.
We can round the position to integers when the surface is not (anymore)
transformed.
This change may fix a rounding inconsistency in the opaque region setup,
where the rectangle is initialised from the coordinates without explicit
rounding operation.
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Pekka Paalanen [Fri, 10 Feb 2012 13:33:10 +0000 (15:33 +0200)]
shell: replace identity calls to weston_surface_configure()
In the past, weston_surface_configure() was used to change the geometry,
apply damage, and assign an output.
Remove all calls to weston_surface_configure() that do not change the
surface geometry. Add damage calls where needed to keep the wanted
configure side-effects.
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Pekka Paalanen [Fri, 10 Feb 2012 11:34:36 +0000 (13:34 +0200)]
compositor: move output assignment to update_transform
Move the call to assign an output from weston_surface_configure() to
weston_surface_update_transform().
As update_transform takes new geometry into use, it should also reassign
the output for the surface, but only if an output was already assigned.
Add explicit assing output calls to where we relied on
weston_surface_configure() unconditionally assigning the output.
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>
Pekka Paalanen [Thu, 9 Feb 2012 14:39:38 +0000 (16:39 +0200)]
compositor: move opaque tracking into transform
Move the surface opaque region setup from weston_surface_configure() to
weston_surface_update_transform(), so we have less reason to call
update_transform from configure. Opaque region depends on geometry,
after all.
Also move the opaque field from weston_surface to
weston_surface::transform to make this obvious.
Signed-off-by: Pekka Paalanen <ppaalanen@gmail.com>