platform/upstream/dotnet/runtime.git
5 years agoFix order of "static public" in test file
Stephen Toub [Wed, 1 May 2019 02:04:13 +0000 (22:04 -0400)]
Fix order of "static public" in test file

Commit migrated from https://github.com/dotnet/corefx/commit/ebba368b0f5e37cf12a22774b90cb54600ce6760

5 years agodisable ParallelQueryCombinationTests on ARM systems with high core count (dotnet...
Tomas Weinfurt [Wed, 1 May 2019 02:03:23 +0000 (19:03 -0700)]
disable ParallelQueryCombinationTests on ARM systems with high core count (dotnet/corefx#37319)

Commit migrated from https://github.com/dotnet/corefx/commit/0409c03ac353f93e7598d0ebd19017f43b944efb

5 years agoAdd more UTF-16 validation tests (dotnet/corefx#37252)
Levi Broderick [Wed, 1 May 2019 01:51:57 +0000 (18:51 -0700)]
Add more UTF-16 validation tests (dotnet/corefx#37252)

Commit migrated from https://github.com/dotnet/corefx/commit/a8dacfb2d4fd38aafce49adc8de30f31e08bd598

5 years agoRemoving the System.Numerics.Vectors pkgproj (dotnet/corefx#37301)
Tanner Gooding [Wed, 1 May 2019 00:53:08 +0000 (17:53 -0700)]
Removing the System.Numerics.Vectors pkgproj (dotnet/corefx#37301)

Commit migrated from https://github.com/dotnet/corefx/commit/9e4e45d6af3facb06726e659e612a943c11f4d26

5 years agoAdditional unit test cases for UTF-8 validation (dotnet/corefx#37162)
Levi Broderick [Wed, 1 May 2019 00:02:33 +0000 (17:02 -0700)]
Additional unit test cases for UTF-8 validation (dotnet/corefx#37162)

Commit migrated from https://github.com/dotnet/corefx/commit/97fb23198aadfb48f27ac39e96358d4990b1700d

5 years agoEnable test for dotnet/coreclrdotnet/corefx#24191 (dotnet/corefx#37311)
Steve MacLean [Tue, 30 Apr 2019 22:45:21 +0000 (18:45 -0400)]
Enable test for dotnet/coreclrdotnet/corefx#24191 (dotnet/corefx#37311)

Enable SatelliteAssembly tests relying on dotnet/coreclrdotnet/corefx#24191

Commit migrated from https://github.com/dotnet/corefx/commit/b1448c5e4e744e1b24852fbd972b5208cb69157e

5 years agoAdd TokenStartIndex property to Utf8JsonReader and fix bug in ConsumeNumber (dotnet...
Ahson Khan [Tue, 30 Apr 2019 22:09:36 +0000 (15:09 -0700)]
Add TokenStartIndex property to Utf8JsonReader and fix bug in ConsumeNumber (dotnet/corefx#37167)

* Add TokenStartIndex property to Utf8JsonReader with basic tests.

* Add more token start index tests and fix bug in ConsumeNumber which was
throwing too aggressively.

* Update ref to match normalized alpha ordering.

* Use TokenStartIndex in more places, i.e. in JsonDocument.TryParseValue

* Address PR feedback.

* Restructure condition with string first to avoid duplication.

Commit migrated from https://github.com/dotnet/corefx/commit/7d2af717439d1b60969c712376b842a12c5769cc

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37298)
dotnet-maestro[bot] [Tue, 30 Apr 2019 20:40:12 +0000 (16:40 -0400)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37298)

* Update dependencies from https://github.com/dotnet/coreclr build 20190429.75

- Microsoft.NET.Sdk.IL - 3.0.0-preview6-27629-75
- Microsoft.NETCore.ILAsm - 3.0.0-preview6-27629-75
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6-27629-75

* Disable NullEncodingThrows test on all but netfx

* add precision

precision tests added and precision increased in current tests

fixing max value test

* Fixing tests for netfx

Commit migrated from https://github.com/dotnet/corefx/commit/33f3985174a8f7727cfeaa507963c0f76b8a0908

5 years agoMove to new BYOC pools (dotnet/corefx#37303)
Santiago Fernandez Madero [Tue, 30 Apr 2019 20:32:10 +0000 (13:32 -0700)]
Move to new BYOC pools (dotnet/corefx#37303)

Commit migrated from https://github.com/dotnet/corefx/commit/4a4b2cfd556feaa1c112afc604217d5c628385a2

5 years agoMerge pull request dotnet/corefx#37307 from dotnet/update-1904-image
Matt Galbraith [Tue, 30 Apr 2019 19:57:09 +0000 (12:57 -0700)]
Merge pull request dotnet/corefx#37307 from dotnet/update-1904-image

Update Docker image for Ubuntu 19.04

Commit migrated from https://github.com/dotnet/corefx/commit/56115730ea260dd27cf74818dff858cb8424e61a

5 years agoUpdate Docker image for Ubuntu 19.04
Matt Galbraith [Tue, 30 Apr 2019 19:55:51 +0000 (12:55 -0700)]
Update Docker image for Ubuntu 19.04

Commit migrated from https://github.com/dotnet/corefx/commit/ee67e75c1ae98ef73a32aa0a4f1b9c1d9ef392d8

5 years agoFix bad usage of ArrayPool in TdsParserStateObject (dotnet/corefx#37270)
Jeremy Barton [Tue, 30 Apr 2019 19:25:58 +0000 (12:25 -0700)]
Fix bad usage of ArrayPool in TdsParserStateObject (dotnet/corefx#37270)

If TdsParserStateObject.TryReadString or
TdsParserStateObject.TryReadStringWithEncoding hit the growth case they
would rent an array, save it into a field, use the array, return the array to the pool,
but keep it assigned to the field and continue using it.

Since other writes to _bTmp use fresh arrays in an instance-cached-growth
pattern, this change restores these two methods to that same approach, rather
than renting to a local buffer and not renting into a field.

Commit migrated from https://github.com/dotnet/corefx/commit/e89d17a0a97d5de707f24587118acc8072667b78

5 years agoHarden several SocketsHttpHandler streams against unexpected Dispose (dotnet/corefx...
Stephen Toub [Tue, 30 Apr 2019 18:58:25 +0000 (14:58 -0400)]
Harden several SocketsHttpHandler streams against unexpected Dispose (dotnet/corefx#37299)

A few tweaks:
- We hand out the ChunkedEncodingWriteStream and ContentLengthWriteStream to an HttpContent.SerializeToStreamAsync.  If that user code disposes of the Stream, then we end up null ref'ing when we try to finish the processing.  We should instead throw a more descriptive error about the misuse.
- Make the non-pooled response streams slightly more robust against concurrent disposal (which is not a supported use, but it happens).

Commit migrated from https://github.com/dotnet/corefx/commit/422565673deb849b42f656f4a68bec791ee4bed9

5 years agoAdd a test for Stopwatch.Elapsed to ensure it's within reason (dotnet/corefx#37279)
Stephen Toub [Tue, 30 Apr 2019 00:52:59 +0000 (20:52 -0400)]
Add a test for Stopwatch.Elapsed to ensure it's within reason (dotnet/corefx#37279)

If this experiences flakiness in CI, we can tweak it, replace it with something better, etc.

Commit migrated from https://github.com/dotnet/corefx/commit/c28dbd19fda676a57fb3edf25aaa42196ed36f05

5 years agoRemove dotnet/sdkdotnet/corefx#3185 (dotnet/corefx#37289)
Steve MacLean [Tue, 30 Apr 2019 00:43:06 +0000 (20:43 -0400)]
Remove dotnet/sdkdotnet/corefx#3185 (dotnet/corefx#37289)

Issue closed

Commit migrated from https://github.com/dotnet/corefx/commit/a25531fc1f49e5c2d5453c62b0df730000f0896e

5 years agoMerge pull request dotnet/corefx#37287 from dotnet/add-ubuntu-1904
Matt Galbraith [Tue, 30 Apr 2019 00:34:55 +0000 (17:34 -0700)]
Merge pull request dotnet/corefx#37287 from dotnet/add-ubuntu-1904

Add Ubuntu 19.04 to official runs

Commit migrated from https://github.com/dotnet/corefx/commit/ae8426b9da0151a616a73767f64468e3f71bd0cc

5 years agoALC SatelliteAssemblies tests (dotnet/corefx#37248)
Steve MacLean [Tue, 30 Apr 2019 00:33:31 +0000 (20:33 -0400)]
ALC SatelliteAssemblies tests (dotnet/corefx#37248)

* Add AssemblyLoadCcontext SatelliteAssemblies tests

Commit migrated from https://github.com/dotnet/corefx/commit/9c05364f2eddbb7ef741abb975728b050980097a

5 years agoAdd Ubuntu 19.04 to official runs
Matt Galbraith [Tue, 30 Apr 2019 00:27:02 +0000 (17:27 -0700)]
Add Ubuntu 19.04 to official runs

Add runs using Ubuntu.1904.Amd64 (docker image) ; this is an AMD image based off requirements used in ARM64 version.

Commit migrated from https://github.com/dotnet/corefx/commit/13c18aed49389d7dd00a1da7fc9a2e714943c9d5

5 years agoDisable failing Process name test (dotnet/corefx#37283)
Stephen Toub [Mon, 29 Apr 2019 22:28:34 +0000 (18:28 -0400)]
Disable failing Process name test (dotnet/corefx#37283)

https://github.com/dotnet/corefx/issues/37198
Regression caused by https://github.com/dotnet/corefx/pull/37144

Commit migrated from https://github.com/dotnet/corefx/commit/a26fd9bb1b17510d51a9b5a2ce7aadc1a5b631ee

5 years agoMaking BaseNumberConverter Internal (dotnet/corefx#37278)
Anirudh Agnihotry [Mon, 29 Apr 2019 22:27:05 +0000 (15:27 -0700)]
Making BaseNumberConverter Internal (dotnet/corefx#37278)

* type converter ctor made internal

* diasabling apicompat for the change

* Fixing uap app compat

Commit migrated from https://github.com/dotnet/corefx/commit/fe807da325e532aaabec338c3ecd78b1a7e5efe8

5 years agoPlumb cancellation through SslStream.AuthenticateAsXxAsync (dotnet/corefx#37259)
Stephen Toub [Mon, 29 Apr 2019 22:24:48 +0000 (18:24 -0400)]
Plumb cancellation through SslStream.AuthenticateAsXxAsync (dotnet/corefx#37259)

We accept a CancellationToken into several of the overloads, but it's then dropped and not actually used.  This fixes that to ensure it's passed through to the underlying Read/WriteAsync operations.

Commit migrated from https://github.com/dotnet/corefx/commit/ff1db9b09082dfd0dcdeaf8ffa291a825916a7f6

5 years agoPort Microsoft.VisualBasic.MyServices.FileSystemProxy and move FileIOTests to C#...
Charles Stoner [Mon, 29 Apr 2019 21:48:19 +0000 (14:48 -0700)]
Port Microsoft.VisualBasic.MyServices.FileSystemProxy and move FileIOTests to C# (dotnet/corefx#37277)

Commit migrated from https://github.com/dotnet/corefx/commit/8c167e3c0fd7958acac17f88f241865dbff3eed9

5 years agoCleanup some WebSocket tests (dotnet/corefx#37271)
David Shulman [Mon, 29 Apr 2019 19:38:00 +0000 (12:38 -0700)]
Cleanup some WebSocket tests (dotnet/corefx#37271)

Skip some tests on .NET Framework due to bugs in .NET Framework.

Modify the TestCancellation helper method for the WebSocket client tests to not check for string matching in exception messages. This makes the test too brittle. We're already checking for other important fields in the WebSocket object.

Re-enable some UAP tests since the fixes are in master branch.

Closes dotnet/corefx#13302
Closes dotnet/corefx#22635
Closes dotnet/corefx#23204
Closes dotnet/corefx#28777
Closes dotnet/corefx#33401

Commit migrated from https://github.com/dotnet/corefx/commit/98c8597706bee4a7e21648deb62c72ce198076f6

5 years agoClean up HTTP/2 protocol exception handling (dotnet/corefx#37223)
Stephen Toub [Mon, 29 Apr 2019 17:51:29 +0000 (13:51 -0400)]
Clean up HTTP/2 protocol exception handling (dotnet/corefx#37223)

* Clean up HTTP/2 protocol exception handling

- Propagate the GOAWAY and RST_STREAM error codes to the calling code via an exception.
- Propagate to the Http2Stream exceptions incurred in the Http2Connection and that result in an Abort.
- Don't Dispose of the Http2Stream before we try to Cancel it.
- Make Http2ProtocolException serializable, as we generally do that for all of our exception types.
- Add tests that verify sufficient HTTP/2 protocol details are in the exception messages.
- Clean up the error message for the exception.
- Separate the error code and exception into their own files.
- Leave Http2ProtocolException internal for now; we can expose it publicly when we design the all-up public error model for HttpClient.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/7237da089c09531c36a2110a3bdd9ccaf7c05d77

5 years agoImprove a ClientWebSocket connection failure error message (dotnet/corefx#37267)
Stephen Toub [Mon, 29 Apr 2019 17:02:51 +0000 (13:02 -0400)]
Improve a ClientWebSocket connection failure error message (dotnet/corefx#37267)

Commit migrated from https://github.com/dotnet/corefx/commit/d6e7cbf4f3226f644c114443e617ba53fe686be7

5 years agofix noencryption tests on platforms with tls1.3 (dotnet/corefx#37213)
Tomas Weinfurt [Mon, 29 Apr 2019 16:41:33 +0000 (09:41 -0700)]
fix noencryption tests on platforms with tls1.3 (dotnet/corefx#37213)

* fix noencryption tests on platforms with tls1.3

* feedback from review

* fix platform detection

Commit migrated from https://github.com/dotnet/corefx/commit/5a36da2d2cc19718dfffc5f05ca42541f4d8d8c6

5 years agoRemove `Partial` from `EnablePartialNgenOptimization` (dotnet/corefx#36962)
Michal Strehovský [Mon, 29 Apr 2019 13:06:36 +0000 (15:06 +0200)]
Remove `Partial` from `EnablePartialNgenOptimization` (dotnet/corefx#36962)

Ngen optimizations are controlled with two properties - one is EnableNgen, the other is ApplyNgen. We were already using the ApplyNgen property with value of `full` (as of dotnet/corefx#36450), so this was already doing full Ngen, but we still used EnablePartialNgen to control the EnableNgen property. It's a roundabout way to EnableNgen, but does the same thing. This pull request removes the indirection.

Commit migrated from https://github.com/dotnet/corefx/commit/7066a0cac2cadd21ca144cc78d1b1fab9b1f9cd7

5 years agoDon't allocate two strings in Activity.GenerateRootId (dotnet/corefx#37165)
Ben Adams [Mon, 29 Apr 2019 09:18:30 +0000 (10:18 +0100)]
Don't allocate two strings in Activity.GenerateRootId (dotnet/corefx#37165)

* Don't allocate two strings in Activity.GenerateRootId

* Packaging

* packaging

* Feedback

* feedback

Commit migrated from https://github.com/dotnet/corefx/commit/173a2a165316af9a4e211ceab8c8d9692de8a528

5 years agoAdd proxy environment variables support for Windows (dotnet/corefx#37238)
David Shulman [Sun, 28 Apr 2019 00:06:35 +0000 (17:06 -0700)]
Add proxy environment variables support for Windows (dotnet/corefx#37238)

Changed the Windows version of SocketsHttpHandler so that it will honor the same environment
variables similar to the Linux and OSX versions. If the environment variables are not set
then it reverts back to the Windows WinInet/IE settings behavior.

I added several kinds of unit and end-to-end tests to verify the SystemProxyInfo class is
making the correct choice for all the different platforms regarding whether the
HttpEnvironmentProxy or platform proxy (HttpSystemProxy for Windows and MacProxy for OSX)
is used.

Fixes dotnet/corefx#37187

Commit migrated from https://github.com/dotnet/corefx/commit/4f27d0f84c17850ef02ea7b330908fddcdf73c86

5 years agoGive SocketsHttpHandler more descriptive error messages (dotnet/corefx#37251)
Stephen Toub [Sat, 27 Apr 2019 23:22:33 +0000 (19:22 -0400)]
Give SocketsHttpHandler more descriptive error messages (dotnet/corefx#37251)

Currently lots of parsing failures just result in an exception stating "The server returned an invalid or unrecognized response."  We can instead be more descriptive about what the problem is in most cases.

Commit migrated from https://github.com/dotnet/corefx/commit/8e551d4dc7464a465b00ac1bf9a632ea9c3bb5a1

5 years agoDisable sporadically failing HttpClientHandler test (dotnet/corefx#37253)
Stephen Toub [Sat, 27 Apr 2019 21:11:53 +0000 (17:11 -0400)]
Disable sporadically failing HttpClientHandler test (dotnet/corefx#37253)

Commit migrated from https://github.com/dotnet/corefx/commit/610fa286999c78b841e17ea0c301c0986426635d

5 years agoTweak a comment in HttpHandlerDefaults.cs
Stephen Toub [Sat, 27 Apr 2019 20:47:21 +0000 (16:47 -0400)]
Tweak a comment in HttpHandlerDefaults.cs

Fixes https://github.com/dotnet/corefx/issues/34966

Commit migrated from https://github.com/dotnet/corefx/commit/c0c370e0576574d8985970200c00ca83ae366d2e

5 years agoEnsure that invalid AIA, CDP, and OCSP extensions don't throw. (dotnet/corefx#37237)
Jeremy Barton [Sat, 27 Apr 2019 18:48:52 +0000 (11:48 -0700)]
Ensure that invalid AIA, CDP, and OCSP extensions don't throw. (dotnet/corefx#37237)

Commit migrated from https://github.com/dotnet/corefx/commit/a3ee315cd5e4f4d3ce8fb60a24aa8bd0c9c9ae82

5 years agoAdd Ubuntu 19.04 RID (dotnet/corefx#37233)
Jeremy Barton [Sat, 27 Apr 2019 18:47:35 +0000 (11:47 -0700)]
Add Ubuntu 19.04 RID (dotnet/corefx#37233)

Commit migrated from https://github.com/dotnet/corefx/commit/ad4b12cbc4563b346f0de48fda06c41292650611

5 years agoFixing the logic in SystemNative_GetTimestampResolution to return the correct "ticks...
Tanner Gooding [Sat, 27 Apr 2019 01:05:18 +0000 (18:05 -0700)]
Fixing the logic in SystemNative_GetTimestampResolution to return the correct "ticks per second" (dotnet/corefx#37236)

Commit migrated from https://github.com/dotnet/corefx/commit/4ff66e551b07802a4021d538633d77d3ee66ec89

5 years agoAdding System.Text.Json OOB package (dotnet/corefx#37129)
Jose Perez Rodriguez [Fri, 26 Apr 2019 23:49:25 +0000 (16:49 -0700)]
Adding System.Text.Json OOB package (dotnet/corefx#37129)

* Adding System.Text.Json OOB package

* Removing SourceRewriter dependency as it won't be used by the repo any longer

* Address PR Feedback

Commit migrated from https://github.com/dotnet/corefx/commit/61024c30b966ee63c357a491370a2daf94c4c42f

5 years agoDon't copy state unnecessarily (dotnet/corefx#37206)
BrennanConroy [Fri, 26 Apr 2019 23:24:42 +0000 (16:24 -0700)]
Don't copy state unnecessarily (dotnet/corefx#37206)

Commit migrated from https://github.com/dotnet/corefx/commit/e6a090157875122b0aeacd1e05741fdc3c143bf0

5 years agoImprove Utf8JsonWriter code coverage (dotnet/corefx#36811)
madmir [Fri, 26 Apr 2019 23:07:54 +0000 (01:07 +0200)]
Improve Utf8JsonWriter code coverage (dotnet/corefx#36811)

* Added test for expected argument exception when property name or value arguments reach MaxTokenSize

Commit migrated from https://github.com/dotnet/corefx/commit/b35cd0db472434cc5991f305de4557d51991b4a4

5 years agoFixes relative path at configSource on linux (dotnet/corefx#37146)
Jim Demis [Fri, 26 Apr 2019 22:33:31 +0000 (01:33 +0300)]
Fixes relative path at configSource on linux (dotnet/corefx#37146)

Commit migrated from https://github.com/dotnet/corefx/commit/224e16d1e88baf45ce53388fe7fd0f3e6673ee88

5 years agoPort Microsoft.VisualBasic.FileSystem (dotnet/corefx#37201)
Charles Stoner [Fri, 26 Apr 2019 22:14:16 +0000 (15:14 -0700)]
Port Microsoft.VisualBasic.FileSystem (dotnet/corefx#37201)

Commit migrated from https://github.com/dotnet/corefx/commit/58e336ab4476ce57a3b44d87351299cfe9a6458d

5 years agoReenable tests (dotnet/corefx#37081)
Steve MacLean [Fri, 26 Apr 2019 20:03:22 +0000 (16:03 -0400)]
Reenable tests (dotnet/corefx#37081)

Commit migrated from https://github.com/dotnet/corefx/commit/111632ce7af9f2ffbf117045ea098bd3f0116ccb

5 years agoAdd serializer support for IDictionary non-primitive types (dotnet/corefx#37186)
Steve Harter [Fri, 26 Apr 2019 18:59:28 +0000 (11:59 -0700)]
Add serializer support for IDictionary non-primitive types (dotnet/corefx#37186)

Commit migrated from https://github.com/dotnet/corefx/commit/c5bb6abec986627f90b2e7e648dc4e733cdbf63b

5 years agodeal with empty response headers for HTTP2 (dotnet/corefx#37160)
Tomas Weinfurt [Fri, 26 Apr 2019 18:02:06 +0000 (11:02 -0700)]
deal with empty response headers for HTTP2 (dotnet/corefx#37160)

* deal with empty response headers for HTTP2

* fix test for http1.1

* feedback from review

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/e95b369aa20d551cef59f7bda3aff0ddbd4119c7

5 years agoupdate GatewayAddresses() to return IPv6 address on Unix (dotnet/corefx#37132)
Tomas Weinfurt [Fri, 26 Apr 2019 18:01:37 +0000 (11:01 -0700)]
update GatewayAddresses() to return IPv6 address on Unix (dotnet/corefx#37132)

* process IPv6 for GatewayAddresses

* fix GatewayAddresses for OSX and FreeBSD

* feedback from review

* feedback from review

* add updated ipv6_route for tests

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/a612f42c3310f4c66abc0aafc9d6a6a55b07334a

5 years agodeal with dualmode sockets (dotnet/corefx#37194)
Tomas Weinfurt [Fri, 26 Apr 2019 18:00:41 +0000 (11:00 -0700)]
deal with dualmode sockets (dotnet/corefx#37194)

Commit migrated from https://github.com/dotnet/corefx/commit/4f781a4df027bc3cc80f034bf05ff4f93dd193d9

5 years agoFix DateTime(Offset) formatting bugs in Utf8JsonWriter (dotnet/corefx#37159)
Layomi Akinrinade [Fri, 26 Apr 2019 17:57:36 +0000 (13:57 -0400)]
Fix DateTime(Offset) formatting bugs in Utf8JsonWriter (dotnet/corefx#37159)

* Fix DateTime(Offset) formatting bugs in Utf8JsonWriter

Fixes https://github.com/dotnet/corefx/issues/37147.

- The period token was being omitted for some inputs.
- Some offset tokens were being omitted for some inputs.

* Address review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/5f4dedeb0db50f7d5224fe29a9c6d27cf03fa26b

5 years agoAllow uppercase HTTP_PROXY and NO_PROXY variables (dotnet/corefx#37200)
David Shulman [Fri, 26 Apr 2019 13:23:55 +0000 (06:23 -0700)]
Allow uppercase HTTP_PROXY and NO_PROXY variables (dotnet/corefx#37200)

This is a redo of PR dotnet/corefx#35887.

Added support for uppercase HTTP_PROXY and NO_PROXY environment variables.
The uppercase versions are being used by Docker and other tools. This now
completes the set of environment variables that are already handling both
lower and upper case variants.

Note: This HttpEnvironmentProxy class is currently only used on Linux and OSX.
It is not used on Windows yet. I do plan to add support for this to Windows
at a later time, see dotnet/corefx#37187.

Added detection of CGI environments in order to suppress using the uppercase
HTTP_PROXY environment variable. See https://httpoxy.org/

Fixed some typos in the CSPROJ of the Http Unit Tests.

Commit migrated from https://github.com/dotnet/corefx/commit/dfe7593397bf5c598548486c6cb774ebf60e9d69

5 years agoAdd System.Resources.Extensions (dotnet/corefx#36906)
Eric StJohn [Fri, 26 Apr 2019 05:05:19 +0000 (22:05 -0700)]
Add System.Resources.Extensions (dotnet/corefx#36906)

* Add System.Resources.Binary.Reader|Writer

* Fix ResourceWriter tests

* Test fixes and PR feedback

* More test fixes

* Add packages for System.Resources.Binary.*

* Suppress duplicate types in System.Resources.Binary.*

* Test refactoring and adding RuntimeResourceSet

It turns out me must have our own ResourceSet since the CoreLib resource set doesn't
expose a constructor that takes an IResourceReader.

I've shared the code since it does a bit of non-trivial caching.

* Don't use auto-property initializers for platfrom sensitive test data

For some reason I thought these lazy-initialized the properties but they don't.

As a result we were hitting the platform sensitive code even when we never
called the getter.  Switch to an expression instead.

* Only use Drawing converters on Windows

* Fix test failures

* Don't leak System.Private.CoreLib into resources

* Make sure RuntimeResourceSet doesn't call ResourceReader(IResourceReader)

* WIP

* Rename types in System.Resources.Extensions

Leave RuntimeResourceSet internal as it doesn't need to be public.

* Update packages

* Respond to API review feedback

Remove abstraction for ResourceReader/Writer: just reuse the source.

Remove non-essential members.

* Clean up

* Further cleanup

* Further cleanup

* Review feedback

* Ensure we have stable type names in Resources.Extensions

We don't want to use the runtime type identity when doing type checks or writing
types as this may change.  Instead, check-in hard-coded strings that match the
type identity.

Add a test case to ensure the resources we generate match what we
test the reader against in the resource manager case (also to track any
change to the binary format).

Commit migrated from https://github.com/dotnet/corefx/commit/da36ea268c778200dc676d294667eb76146e1a01

5 years agoPick up last build runtime.native.System.IO.Ports during testing (dotnet/corefx#37195)
Eric StJohn [Thu, 25 Apr 2019 22:09:50 +0000 (15:09 -0700)]
Pick up last build runtime.native.System.IO.Ports during testing (dotnet/corefx#37195)

Commit migrated from https://github.com/dotnet/corefx/commit/4b82e7e79c9468fc4d0d58ee617be0b7729fa613

5 years agoimproving error message for non-windows platform (dotnet/corefx#37193)
Anirudh Agnihotry [Thu, 25 Apr 2019 19:54:10 +0000 (12:54 -0700)]
improving error message for non-windows platform (dotnet/corefx#37193)

Commit migrated from https://github.com/dotnet/corefx/commit/3fd90668431a51fc1c0ec330db20d1dfde7c147d

5 years agoFix SocketsHttpHandler system proxy usage logic (dotnet/corefx#37153)
David Shulman [Thu, 25 Apr 2019 17:58:44 +0000 (10:58 -0700)]
Fix SocketsHttpHandler system proxy usage logic (dotnet/corefx#37153)

SocketsHttpHandler was not using the proxy bypass list specified in IE settings in cases where
there is a combination of both 'AutoDetect' and 'Manual' settings in the IE settings dialog.

SocketsHttpHandler uses WinHttpHandler's WinInetProxyHelper class as part of the HttpSystemProxy
class. But it was consuming it in an incorrect way. WinInetProxyHelper was originally written to
be used only with the rest of the WinHTTP stack for WinHttpHandler. When WinHTTP GetProxyForUrl() was returning a ProxyBypass string, HttpSystemProxy was ignoring it. It was
assuming that the string for Proxy was correct. But in cases where ProxyBypass is returned, the
Proxy string is only used if the destination uri doesn't match any of the strings in the ProxyBypass
list. That logic would normally be handled automatically by WinHttpHandler. But HttpSystemProxy
was simply discarding the ProxyBypass string returned by WinHTTP GetProxyForUrl().

In order to address this fix, I added new tests for HttpSystemProxy. I utilized the existing mock
layers for registry and WinHTTP interop that are contained in the WinHttpHandler Unit Tests. It might
seem weird to have tests for the internal HttpSystemProxy class located in the WinHttpHandler folder.
But, we already pull in the source code for WinInetProxyHelper from WinHttpHandler into the
SocketsHttpHandler compilation. Using these Unit Tests with the mocking layers allows us to test a
broad range of scenarios (registry settings and network failures) that are normally difficult to test.
I have a plan, though, to refactor the system proxy code and tests as part of implementing dotnet/corefx#36553.
That will result in the system proxy code and tests ending up in a more logical place.

Fixes dotnet/corefx#33866

Commit migrated from https://github.com/dotnet/corefx/commit/6da9a3b80c2ac56c641fa22157607860f6b9387f

5 years agoMerge pull request dotnet/corefx#36678 from Wraith2/sqlfeat-udtbytes
Afsaneh Rafighi [Thu, 25 Apr 2019 16:34:24 +0000 (09:34 -0700)]
Merge pull request dotnet/corefx#36678 from Wraith2/sqlfeat-udtbytes

SqlClient Allow specifying a UDT SqlParameter value as bytes

Commit migrated from https://github.com/dotnet/corefx/commit/aff33dce8057538524af37ab00e09a21b56e6d3e

5 years agoFixes compression method override of zero-length files (dotnet/corefx#37079)
Jim Demis [Thu, 25 Apr 2019 15:40:08 +0000 (18:40 +0300)]
Fixes compression method override of zero-length files (dotnet/corefx#37079)

* Fixes compression method override of zero-length files

When a zero-length file is stored using compression method, ZipArchive still overrides the method to “not compressed”, and ignore compressed bytes that are still present, rendering the zip file unusable.

Fixes dotnet/corefx#30317

* Ignore uncompressed data for zero-byte files

* Removed unnecesary compressed data and resolved review feedback

*  Changed to assert lengths from stream and removed forgotten debug assert

* Moved compressed size reset before WriteLocalFileHeader to keep assert

* Applied test feedback

* Renamed few fields

Commit migrated from https://github.com/dotnet/corefx/commit/bdd2014f2d1863a296f76b5c90152ae016854afc

5 years agoLinux: determine ProcessName using /proc cmdline to avoid truncated names (dotnet...
Tom Deseyn [Thu, 25 Apr 2019 15:36:23 +0000 (17:36 +0200)]
Linux: determine ProcessName using /proc cmdline to avoid truncated names (dotnet/corefx#37144)

* Linux: determine ProcessName using /proc cmdline to avoid truncated names

* PR feedback

* LongProcessNamesAreSupported test: ensure Process gets killed when Assert throws

Commit migrated from https://github.com/dotnet/corefx/commit/4214b09864bea0416f17727ffa39a55d950035d1

5 years agoEnable CoreLib coverage (dotnet/corefx#37172)
Viktor Hofer [Thu, 25 Apr 2019 14:48:24 +0000 (16:48 +0200)]
Enable CoreLib coverage (dotnet/corefx#37172)

* Enable CoreLib coverage

Commit migrated from https://github.com/dotnet/corefx/commit/eb2d732bf8d35186c70c743812e5d17584b6975f

5 years agoUse Coreclr transport packages (dotnet/corefx#37163)
Eric StJohn [Thu, 25 Apr 2019 09:25:08 +0000 (02:25 -0700)]
Use Coreclr transport packages (dotnet/corefx#37163)

* Replace CoreCLR package with transport package

This allows us to remove the manual download step

* Remove IL and NI folders, use IL in debug or when specified

I also simplified some of these targets.   NuGet automatically includes all files in native,
so additional inclusion was unnecessary.

* Disable IL CoreLib swap for UAP10.0.16299 and AOT

Commit migrated from https://github.com/dotnet/corefx/commit/8c7afe67ee2e9bd21a4412265b66f875cfafaede

5 years agoEmbedded resources may not have extension in the name (dotnet/corefx#37048)
Devendar Reddy Adulla [Thu, 25 Apr 2019 01:16:26 +0000 (18:16 -0700)]
Embedded resources may not have extension in the name (dotnet/corefx#37048)

* Bitmaps are replaced with Icons and Logical names are changed to not having any extensions.

* Checking for Rawformat before calling MakeTransparent method.

* Adding a test attribute

* Adding test.

Commit migrated from https://github.com/dotnet/corefx/commit/27d0597c556d7a4040571d09ede9b84bc1cc6b85

5 years agoUnify WIN32_FIND_DATA (dotnet/corefx#37158)
Jan Kotas [Thu, 25 Apr 2019 00:06:30 +0000 (17:06 -0700)]
Unify WIN32_FIND_DATA (dotnet/corefx#37158)

Commit migrated from https://github.com/dotnet/corefx/commit/51922de496a713568b493e791c60e419042d19b5

5 years agoFix JSON deserializer property name escaping and address naming feedback (dotnet...
Steve Harter [Wed, 24 Apr 2019 18:37:04 +0000 (11:37 -0700)]
Fix JSON deserializer property name escaping and address naming feedback (dotnet/corefx#37124)

Commit migrated from https://github.com/dotnet/corefx/commit/cf0624854a1a4d8eda961a6eb06bb803b0555dfd

5 years agoFix link to Preview SDKs (dotnet/corefx#37150)
Zachary Danz [Wed, 24 Apr 2019 17:57:55 +0000 (10:57 -0700)]
Fix link to Preview SDKs (dotnet/corefx#37150)

Commit migrated from https://github.com/dotnet/corefx/commit/c73d2c15c0194ead26d54cb72224f2daf1e1c5cc

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37141)
dotnet-maestro[bot] [Wed, 24 Apr 2019 17:33:37 +0000 (17:33 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37141)

* Update dependencies from https://github.com/dotnet/coreclr build 20190423.74

- Microsoft.NET.Sdk.IL - 3.0.0-preview6-27623-74
- Microsoft.NETCore.ILAsm - 3.0.0-preview6-27623-74
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6-27623-74

* Update ThreadPool test for revised behavior

Commit migrated from https://github.com/dotnet/corefx/commit/7f60d72fb64cfacec41f47d59ac5e35ed54aa442

5 years agoFix CPINFOEXW definition (dotnet/corefx#37131)
Jan Kotas [Wed, 24 Apr 2019 15:46:42 +0000 (08:46 -0700)]
Fix CPINFOEXW definition (dotnet/corefx#37131)

* Fix CPINFOEXW definition

* Unify MAX_PATH definition and switch to use it for GetCPInfoEx

Commit migrated from https://github.com/dotnet/corefx/commit/24efeca2cb7e8a83125ecdbc62c95040fddabdf2

5 years agoAdd missing 'if' in summary comment (dotnet/corefx#37136)
Stefan [Wed, 24 Apr 2019 15:05:14 +0000 (17:05 +0200)]
Add missing 'if' in summary comment (dotnet/corefx#37136)

Add missing 'if' in summary comment

Commit migrated from https://github.com/dotnet/corefx/commit/7a60f1e1ef6080e0f29e007ae6218043abdef3ad

5 years agofix ReadAtLeastAsync (dotnet/corefx#37130)
Tomas Weinfurt [Wed, 24 Apr 2019 11:02:23 +0000 (04:02 -0700)]
fix ReadAtLeastAsync (dotnet/corefx#37130)

Commit migrated from https://github.com/dotnet/corefx/commit/c75330881567febca956696e0cc0bd66687bc1bc

5 years agoUpdate System.IO* areas ownership
Karel Zikmund [Wed, 24 Apr 2019 10:09:47 +0000 (03:09 -0700)]
Update System.IO* areas ownership

Commit migrated from https://github.com/dotnet/corefx/commit/ad01dd1c314485bb2b86ed6743004a132912754d

5 years agoFix test asset publishing when retrying (dotnet/corefx#37116)
Viktor Hofer [Wed, 24 Apr 2019 03:02:17 +0000 (05:02 +0200)]
Fix test asset publishing when retrying (dotnet/corefx#37116)

Fixes official builds that are retried, i.e.: https://dev.azure.com/dnceng/internal/_build/results?buildId=165244

Commit migrated from https://github.com/dotnet/corefx/commit/918609481617f5c167496925c02bf0329afbff76

5 years agoPort remaining members of Microsoft.VisualBasic.Strings (dotnet/corefx#37123)
Charles Stoner [Wed, 24 Apr 2019 01:11:11 +0000 (18:11 -0700)]
Port remaining members of Microsoft.VisualBasic.Strings (dotnet/corefx#37123)

Commit migrated from https://github.com/dotnet/corefx/commit/48cc70c649b7876ca43155451cafba5499107c07

5 years agoMake GC.GetGCMemoryInfo public (dotnet/corefx#37092)
Ludovic Henry [Tue, 23 Apr 2019 21:39:47 +0000 (14:39 -0700)]
Make GC.GetGCMemoryInfo public (dotnet/corefx#37092)

* Make GC.GetGCMemoryInfo public

Fix https://github.com/dotnet/corefx/issues/34631

* Fix uapaot framework

* Address review

* Add some tests

* Harden some tests

* Merge the GCMemoryInfo tests

* Simplify test

We are in a remote process, no need to clean up the GCHandle at the end of the test

Commit migrated from https://github.com/dotnet/corefx/commit/9e2f3b630a51875fc0455a7cabb8803f6527f81e

5 years agoFixes an issue with some characters not recognized as ASCII (dotnet/corefx#36879)
Jim [Tue, 23 Apr 2019 21:29:19 +0000 (00:29 +0300)]
Fixes an issue with some characters not recognized as ASCII (dotnet/corefx#36879)

* Fixes an issue with some characters not recognized as ASCII

Three characters "{","|" and "}" was being wrongfully marked as NonAscii, thus making IsWellFormedUriString function return false when combined with any other Unicode character(s).

Fix dotnet/corefx#36101

* restored original solution file

* Updated test

Added "|" character to test string
Removed not needed unicode string
Added skip om Net Framework

* Added more strings to test

* Added comment and removed not needed check for escaping

Commit migrated from https://github.com/dotnet/corefx/commit/e13d1c997475e938f6e1eee8c3c73cd166033090

5 years agoDirectory.Move behaves differently on Unix vs. Windows (dotnet/corefx#37121)
Carlos Sanchez Lopez [Tue, 23 Apr 2019 20:46:50 +0000 (13:46 -0700)]
Directory.Move behaves differently on Unix vs. Windows (dotnet/corefx#37121)

* Directory.Move behaves differently on Unix vs. Windows

We will now throw an exception in Unix platforms like in Windows, if the destination path already exists.

* Modifying ExistingDirectory test method that verifies Move overwrite so its called by all platforms.

We already had a test method that tests Move when the destination path exists. I simply removed the platform attribute that restricted it to Windows and renamed the test method so its universal (as opposed to platform specific).

Commit migrated from https://github.com/dotnet/corefx/commit/f9c85c033361ee5bfcf43707dc6d29731f8bc3cb

5 years agoRegenerating reference sources in order to reorder enum fields (dotnet/corefx#37045)
Tanner Gooding [Tue, 23 Apr 2019 20:40:45 +0000 (13:40 -0700)]
Regenerating reference sources in order to reorder enum fields (dotnet/corefx#37045)

Commit migrated from https://github.com/dotnet/corefx/commit/17382def0f680653870c31af1acf086ac41dcc0b

5 years agoAdding a few serialization attributes back to the reference assemblies (dotnet/corefx...
Jose Perez Rodriguez [Tue, 23 Apr 2019 19:59:02 +0000 (12:59 -0700)]
Adding a few serialization attributes back to the reference assemblies (dotnet/corefx#37005)

* Adding a few serialization attributes back to the reference assemblies

* Use GenerateReferenceSource for the contracts that were changed

Commit migrated from https://github.com/dotnet/corefx/commit/eea71b082b9f3d7ac74fe9297b1a5d66c1372508

5 years agoMerge pull request dotnet/corefx#37059 from dotnet/darc-master-64fc4629-3427-4547...
William Godbe [Tue, 23 Apr 2019 19:27:57 +0000 (12:27 -0700)]
Merge pull request dotnet/corefx#37059 from dotnet/darc-master-64fc4629-3427-4547-a455-773e6620fa4c

[master] Update dependencies from dotnet/standard

Commit migrated from https://github.com/dotnet/corefx/commit/50919ec6cd7f580d12c7c06909cbe812d3196e3d

5 years agospecial case bytes in udt parameter write
Wraith2 [Sun, 7 Apr 2019 19:18:43 +0000 (20:18 +0100)]
special case bytes in udt parameter write

Commit migrated from https://github.com/dotnet/corefx/commit/21e1b5d53c9b778ec53be473b612aa880005b3be

5 years agoUpdate APICompat baseline
wtgodbe [Tue, 23 Apr 2019 17:06:19 +0000 (10:06 -0700)]
Update APICompat baseline

Commit migrated from https://github.com/dotnet/corefx/commit/50e72c8b4a1b87872d1e35ae17fef4312c939488

5 years agomake invalidUri more invalid (dotnet/corefx#37109)
Tomas Weinfurt [Tue, 23 Apr 2019 14:42:24 +0000 (07:42 -0700)]
make invalidUri more invalid (dotnet/corefx#37109)

Commit migrated from https://github.com/dotnet/corefx/commit/69d2e45a8a8840ba7a90e4ad2d2805d9033aabfc

5 years agoRevert "Squash fix for process name. (dotnet/corefx#36913)" (dotnet/corefx#37113)
Stephen Toub [Tue, 23 Apr 2019 11:47:02 +0000 (07:47 -0400)]
Revert "Squash fix for process name. (dotnet/corefx#36913)" (dotnet/corefx#37113)

This reverts commit dotnet/corefx@8b515adcd4ea0b8233f018f9e87ef946ce0e7c42.

Commit migrated from https://github.com/dotnet/corefx/commit/9b71f88a2a02bba67c5eb8764b4770535a8e904a

5 years agoFix flaky test (dotnet/corefx#37106)
David Fowler [Tue, 23 Apr 2019 04:26:44 +0000 (21:26 -0700)]
Fix flaky test (dotnet/corefx#37106)

- Synchronize reads and writes using a tcs.

Commit migrated from https://github.com/dotnet/corefx/commit/a78bd0c13887e26372aafdffb8f06be26563c4a8

5 years agoSupport RSAES-OAEP encryption with EnvelopedCms
Kevin Jones [Mon, 22 Apr 2019 22:46:00 +0000 (18:46 -0400)]
Support RSAES-OAEP encryption with EnvelopedCms

Allow an RSA recipient to indicate the encryption padding that should be used.  This makes it easier to get RSA-OAEP-SHA1, and makes it possible to get RSA-OAEP-SHA2 (for some specific SHA-2).

Commit migrated from https://github.com/dotnet/corefx/commit/6cc58374f68b28ef991c3f155f1e87a5902cacf8

5 years agoAdded code for removing oleHeader (dotnet/corefx#36891)
Anirudh Agnihotry [Mon, 22 Apr 2019 22:14:35 +0000 (15:14 -0700)]
Added code for removing oleHeader (dotnet/corefx#36891)

* added code for removing oleHeader and modifiying it to use span

* updating the testdata version and reading only the header signature first

* removing size check on the size of object header as welll as we are catching ArgumentOutOfRangeException

* Updating verison numbers

Commit migrated from https://github.com/dotnet/corefx/commit/eb9b565f13905624ba01464c876dc06a83a3d9e2

5 years agoMerge pull request dotnet/corefx#37027 from Wraith2/sqltest-concurrentload
Afsaneh Rafighi [Mon, 22 Apr 2019 20:09:20 +0000 (13:09 -0700)]
Merge pull request dotnet/corefx#37027 from Wraith2/sqltest-concurrentload

SqlClient add concurrent load tests

Commit migrated from https://github.com/dotnet/corefx/commit/a3ab91e10045bb298f48c1d1f9bd5b0782a8ac46

5 years agowrite Host header first if we need to add it (dotnet/corefx#37007)
Tomas Weinfurt [Mon, 22 Apr 2019 19:28:16 +0000 (12:28 -0700)]
write Host header first if we need to add it (dotnet/corefx#37007)

* write Host header first if we need to add it

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/724d8f73e66b747e079875d431d4c1fa546119e1

5 years agoInitial port of Microsoft.VisualBasic.Devices and Microsoft.VisualBasic.MyServices...
Charles Stoner [Mon, 22 Apr 2019 18:32:16 +0000 (11:32 -0700)]
Initial port of Microsoft.VisualBasic.Devices and Microsoft.VisualBasic.MyServices (dotnet/corefx#37085)

Commit migrated from https://github.com/dotnet/corefx/commit/37703f186d593425418a7fcf705173c707da30d4

5 years agoFix conditional fact in ArrayBufferWriter tests (dotnet/corefx#37086)
Stephen Toub [Mon, 22 Apr 2019 16:03:51 +0000 (12:03 -0400)]
Fix conditional fact in ArrayBufferWriter tests (dotnet/corefx#37086)

Commit migrated from https://github.com/dotnet/corefx/commit/3bda413dc3ae242a7f47967dceb9ffbc13024c78

5 years agoRevise and fix CreateInstanceAssemblyResolve (dotnet/corefx#37080)
Steve MacLean [Mon, 22 Apr 2019 14:06:21 +0000 (10:06 -0400)]
Revise and fix CreateInstanceAssemblyResolve (dotnet/corefx#37080)

dotnet/coreclrdotnet/corefx#24154 will remove the quirk the CreateInstanceAssemblyResolve
test was testing. It will now throw a FileNotFoundException, without triggering
a resolving event.

Commit migrated from https://github.com/dotnet/corefx/commit/ea10af28f44e473f3f71934c6bfa9a2830403153

5 years agoAdd ContextualReflection tests (dotnet/corefx#37052)
Steve MacLean [Sun, 21 Apr 2019 20:19:00 +0000 (16:19 -0400)]
Add ContextualReflection tests (dotnet/corefx#37052)

* Add ContextualReflection tests

Commit migrated from https://github.com/dotnet/corefx/commit/b96247e76506e81ff6eb28dd2a14914a59e2a257

5 years agoAdd Dictionary support to JsonSerializer (dotnet/corefx#37070)
Steve Harter [Sun, 21 Apr 2019 16:13:09 +0000 (09:13 -0700)]
Add Dictionary support to JsonSerializer (dotnet/corefx#37070)

* Add Dictionary support to JsonSerializer

This partially addresses https://github.com/dotnet/corefx/issues/36024.
For the intial version, only `Dictionary<string, [some concrete type]>`
is supported.

* Refactor

* Add more tests

Commit migrated from https://github.com/dotnet/corefx/commit/431f6557d0089e07c953934583e1decca3c90831

5 years agoFix DefaultLoadContextTest (dotnet/corefx#37071)
Steve MacLean [Sun, 21 Apr 2019 15:09:43 +0000 (11:09 -0400)]
Fix DefaultLoadContextTest (dotnet/corefx#37071)

Move clear of olc.LoadedFromContext earlier before System.Runtime is loaded.

Commit migrated from https://github.com/dotnet/corefx/commit/0ac3306ffe66327ec6360694579fe1fe786816e1

5 years agoAdd EnumeratorCancellationAttribute (dotnet/corefx#37064)
Stephen Toub [Sat, 20 Apr 2019 20:07:52 +0000 (16:07 -0400)]
Add EnumeratorCancellationAttribute (dotnet/corefx#37064)

* Update ChannelReader.ReadAllAsync for EnumeratorCancellationAttribute

* Add EnumeratorCancellationAttribute

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/13cd96122c25328a1b180a6289923657180a7b69

5 years agoSquash fix for process name. (dotnet/corefx#36913)
Peter Stevenson [Sat, 20 Apr 2019 15:40:41 +0000 (16:40 +0100)]
Squash fix for process name. (dotnet/corefx#36913)

Handle long process names on Linux

See: https://github.com/2E0PGS/corefx/commit/dotnet/corefx@56e73858adb046b57165eae44af111d64e2fcd98

* add test

* update test

* update test

* address PR feedback

* fix alpine ci

* fix compilation

* add some log for alpine fail

* address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/8b515adcd4ea0b8233f018f9e87ef946ce0e7c42

5 years agoskip GetAsync_IPv6LinkLocalAddressUri_Success if address is not available (dotnet...
Tomas Weinfurt [Sat, 20 Apr 2019 13:36:43 +0000 (06:36 -0700)]
skip GetAsync_IPv6LinkLocalAddressUri_Success if address is not available (dotnet/corefx#37051)

Commit migrated from https://github.com/dotnet/corefx/commit/8e2e72b2683a4b4b983b184f1e703a3174b8566c

5 years agoPort Microsoft.VisualBasic.Conversion class (dotnet/corefx#37047)
Charles Stoner [Sat, 20 Apr 2019 06:31:00 +0000 (23:31 -0700)]
Port Microsoft.VisualBasic.Conversion class (dotnet/corefx#37047)

Commit migrated from https://github.com/dotnet/corefx/commit/c608ddaa2a024dde2510f3c1122c89ba07b4325d

5 years agoAddress and fix ArrayBufferWriter and Utf8JsonWriter feedback and nits (dotnet/corefx...
Ahson Khan [Sat, 20 Apr 2019 00:35:24 +0000 (17:35 -0700)]
Address and fix ArrayBufferWriter and Utf8JsonWriter feedback and nits (dotnet/corefx#37017)

* Address ABW and Utf8JsonWriter feedback and nits.

* Address ABW init and test feedback.

* Fix up JsonWriter usage of ABW and update tests.

* Address PR feedback.

Commit migrated from https://github.com/dotnet/corefx/commit/4a25e4b03bcb5b9b1b2319b4178d2dfcfe05b3b1

5 years agoFix doc comment for Utf8JsonReader.ValueSequence (dotnet/corefx#37038)
Stephan Tolksdorf [Fri, 19 Apr 2019 22:05:14 +0000 (00:05 +0200)]
Fix doc comment for Utf8JsonReader.ValueSequence (dotnet/corefx#37038)

Fixes issue dotnet/corefx#37036.

Commit migrated from https://github.com/dotnet/corefx/commit/c0cd09bb7fb1d40e51e4fdab1822a50a2b322260

5 years agoremove commented code and address feedback
Wraith2 [Fri, 19 Apr 2019 21:52:40 +0000 (22:52 +0100)]
remove commented code and address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/23a78c29abb05724c69fb81603542aeefb617f78

5 years agoUpdate windows instructions to encourage VS 2019 preview explicitly (dotnet/corefx...
Zachary Danz [Fri, 19 Apr 2019 21:38:42 +0000 (14:38 -0700)]
Update windows instructions to encourage VS 2019 preview explicitly  (dotnet/corefx#37013)

* Update windows instructions to encourage 16 preview

* Update windows-instructions.md

Commit migrated from https://github.com/dotnet/corefx/commit/feb534bfdf8695068cfd85a6e39e57ecb6373371

5 years agoMore porting of vbruntime (dotnet/corefx#37010)
Charles Stoner [Fri, 19 Apr 2019 20:11:39 +0000 (13:11 -0700)]
More porting of vbruntime (dotnet/corefx#37010)

Commit migrated from https://github.com/dotnet/corefx/commit/432a34fed6f0db6d76d5b3f8bbc8297fb0aa5f6b

5 years agoSupport XmlKnownDtds in XmlPreloadedResolver (dotnet/corefx#36971)
Ian Griffiths [Fri, 19 Apr 2019 17:44:08 +0000 (18:44 +0100)]
Support XmlKnownDtds in XmlPreloadedResolver (dotnet/corefx#36971)

* Support XmlKnownDtds in XmlPreloadedResolver

The XmlPreloadedResolver class purports to provide certain well-known DTDs - its constructor accepts a value from the XmlKnownDtds enumeration, and if you specify either of the supported DTD sets (sXHTML 1.0, and RSS 0.91) it is meant to make the relevant DTDs available.

In desktop .NET, this works as advertised. In .NET Core, it does not, for the reasons described in https://github.com/dotnet/corefx/issues/36929

This was missed because there are no tests to verify that the XmlPreloadedResolver makes the relevant DTDs available when asked to. (In fact, the tests that existed seemed to be based on a misunderstanding of how this class works.) This adds tests that verify that the known DTDs are provided when requested. And it reinstates the relevant EmbeddedResource entries required to enable the functionality. (The code for this has been in .NET Core's XmlPreloadedResolver all along. It was only the absence of the necessary embedded resources preventing it from working.)

* Completed refactoring that was half-complete

In the previous commit I introduced the NormalizeContent method to avoid duplication of various calls to string.Replace but I left in one such call. This replaces it with a call to the new NormalizeContent, as intended.

* Replace \ with / in test paths

Tests failed on Linux with this:

Could not find a part of the path '/root/helix/work/workitem/Utils\\DTDs\\/XHTML10\

I'm hoping that replacing the backslashes with forward slashes will get the tests passing.

* Replaced fixed / and \ with Path.Combine

Although using / everywhere did seem to work, the preferred way to generate paths is Path.Combine.

Note that this still uses string concatenation for the system ID URI because that's not a path, it's just an identifier.

Commit migrated from https://github.com/dotnet/corefx/commit/eb63183901fbe6afc2be4e1ff0f365fe20cefbf5

5 years agoRenaming the Sse2.StoreLow(ulong/long*, ...) methods to Sse2.StoreScalar (dotnet...
Tanner Gooding [Fri, 19 Apr 2019 16:33:54 +0000 (09:33 -0700)]
Renaming the Sse2.StoreLow(ulong/long*, ...) methods to Sse2.StoreScalar (dotnet/corefx#37029)

Commit migrated from https://github.com/dotnet/corefx/commit/9ca73f6b6ab92a977e6191e64ae09baf7d0bf131

5 years agoFix IDN Tests to support Unicode 11 (dotnet/corefx#37011)
Tarek Mahmoud Sayed [Fri, 19 Apr 2019 15:46:25 +0000 (08:46 -0700)]
Fix IDN Tests to support Unicode 11 (dotnet/corefx#37011)

Windows 19H1  upgraded the IDN data to Unicode 11. The change here is to to use the new Unicode 11 IDN test data  in our tests.

Commit migrated from https://github.com/dotnet/corefx/commit/3679699457b7cf7ece9c6f82f214346cfb07eff9