Steve MacLean [Thu, 28 Mar 2019 21:09:50 +0000 (17:09 -0400)]
Amend ALC tests
Add simple assertions to test:
Test new public constructor
Test instantiating AssemblyLoadContext as a concrete type
Test All
Test Name
Test ToString
Test Assemblies
Commit migrated from https://github.com/dotnet/corefx/commit/
3db3261f39945567d818b10a562acf86d334e07a
Santiago Fernandez Madero [Fri, 29 Mar 2019 21:33:58 +0000 (14:33 -0700)]
Move package testing to RS5 (less busy queue)
Commit migrated from https://github.com/dotnet/corefx/commit/
512cde947d9e4345ef3bd5f75da0bc18b808b836
Jeremy Barton [Fri, 29 Mar 2019 23:31:29 +0000 (16:31 -0700)]
Add JsonElement.WriteAs{Property|Value}
These methods allow sending a JsonElement to a Utf8JsonWriter, respecting its options for formatting the content.
Commit migrated from https://github.com/dotnet/corefx/commit/
d3eed78a3765aef0325384c61a4593570ae3622b
Afsaneh Rafighi [Fri, 29 Mar 2019 22:43:54 +0000 (15:43 -0700)]
Merge pull request dotnet/corefx#34573 from Wraith2/sqlperf-envchange
SqlClient enviroment change optimization
Commit migrated from https://github.com/dotnet/corefx/commit/
6977dddc03f8263ad82228558eb9b02e2e6f530c
Tanner Gooding [Fri, 29 Mar 2019 21:47:04 +0000 (14:47 -0700)]
Moving the System.Runtime.Intrinsics.Arm namespace into System.Runtime.Intrinsics.Experimental (dotnet/corefx#36466)
* Pulling the System.Runtime.Intrinsics.Arm namespace out of System.Runtime.Intrinsics
* Moving the System.Runtime.Intrinsics.Arm namespace into System.Runtime.Intrinsics.Experimental
* Adding an entry for S.R.I.Experimental to the pkg/descriptions.json
* Adding a project reference from S.R.I.Experimental to S.R.Intrinsics
* Adding IgnoreTypes entries for the System.Runtime.Intrinsics.Arm.Arm64 namespace
Commit migrated from https://github.com/dotnet/corefx/commit/
84e89f69c7f00e44bae5d960784bbc829b6f8feb
Dan Moseley [Fri, 29 Mar 2019 21:40:55 +0000 (14:40 -0700)]
Increase timeout for 2 socket option name tests (dotnet/corefx#36485)
* Increase timeout for 2 socket option name tests
* More
Commit migrated from https://github.com/dotnet/corefx/commit/
785423a8831f9b68aaa99cedf08df8f98439b434
Stephen Toub [Fri, 29 Mar 2019 21:40:05 +0000 (17:40 -0400)]
Improve StaticTestGenerator and fix some visibility (dotnet/corefx#36472)
Worked through a bunch of additional assemblies and fixed cases where StaticTestGenerator was doing the wrong thing. Also fixed the visibility on a bunch of test methods it wasn't able to access.
Commit migrated from https://github.com/dotnet/corefx/commit/
475542441df2f054d5e9aa39576019775a5d2f52
Tomas Weinfurt [Fri, 29 Mar 2019 21:16:43 +0000 (14:16 -0700)]
add instrumentation to PingResultValidator (dotnet/corefx#36489)
Commit migrated from https://github.com/dotnet/corefx/commit/
68d3220f239c10001005bc0b2dad511ff262f285
Wraith2 [Fri, 29 Mar 2019 20:52:29 +0000 (20:52 +0000)]
Merge remote-tracking branch 'dotnet/master' into sqlperf-envchange
Commit migrated from https://github.com/dotnet/corefx/commit/
63434297df1d18b7289669120eeaadc0849c1ad7
Matt Galbraith [Fri, 29 Mar 2019 20:31:56 +0000 (13:31 -0700)]
Fix extra ' character
Commit migrated from https://github.com/dotnet/corefx/commit/
7de3b64e231b1b2d74c1fb7dadb753a40c1a949e
Maryam Ariyan [Fri, 29 Mar 2019 18:19:11 +0000 (11:19 -0700)]
Add ReadOnlySequence<T>.FirstSpan (dotnet/corefx#36194)
* Add ReadOnlySequence<T>.FirstSpan
Fixes: dotnet/corefx#33029
Commit migrated from https://github.com/dotnet/corefx/commit/
8292e4556eae08f497e3d8666c001b5ea75f0d3b
Matt Galbraith [Fri, 29 Mar 2019 17:12:42 +0000 (10:12 -0700)]
Merge pull request dotnet/corefx#36471 from dotnet/use-more-docker
Update docker usage and EOL Fedora 27
Commit migrated from https://github.com/dotnet/corefx/commit/
5340f987d8e665fe105934b8f09cb7799a58702d
Matt Galbraith [Fri, 29 Mar 2019 16:26:51 +0000 (09:26 -0700)]
switch CI back to regular fedora 28, as the docker image has some network config stuff we need to figure out
Commit migrated from https://github.com/dotnet/corefx/commit/
2ac692d1ac7aa4c7196ca1230249397c4d56d3e2
Layomi Akinrinade [Fri, 29 Mar 2019 16:23:08 +0000 (12:23 -0400)]
Add DateTimeOffset converter to JsonSerializer (dotnet/corefx#36372)
* Add DateTimeOffset converter to JsonSerializer
Also, use reader/writer parsing/formatting methods for DateTime(Offset) converters.
* Remove duplicate unexpected string exception assertions
Commit migrated from https://github.com/dotnet/corefx/commit/
864bc8a12dfcd561f79820641f60cb96d6c81512
Essam Almohammadi [Mon, 18 Mar 2019 17:53:54 +0000 (18:53 +0100)]
Add string overloads to DbDataReader.Get*() as extensions
Also, add `GetFieldValueAsync<T>()` and `IsDBNullAsync()` string overloads.
Addresses dotnet/corefx#31595
Commit migrated from https://github.com/dotnet/corefx/commit/
ff56b16493fdd07dc8be323ffd8c8fa4075ec8eb
Matt Galbraith [Fri, 29 Mar 2019 16:05:54 +0000 (09:05 -0700)]
Add Fedora 29; will still need to figure out the failures in two networking tests
Commit migrated from https://github.com/dotnet/corefx/commit/
2012d05b1aa185af369801ef5124ac2ae5941c3f
Matt Galbraith [Fri, 29 Mar 2019 01:02:23 +0000 (18:02 -0700)]
Update linux.yml
Remove Fedora 27 (EOL), move Fedora 28 and Alpine 3.6/3.8 to docker tags
Commit migrated from https://github.com/dotnet/corefx/commit/
fa2bdab2227fb2e9ac99667a8fd5f0cc7d20a0a5
Karel Zikmund [Fri, 29 Mar 2019 00:53:43 +0000 (17:53 -0700)]
Update issue-guide.md
Typo
Commit migrated from https://github.com/dotnet/corefx/commit/
c141b8c7aed44817baad190d35d0f29408eb3f7a
Steve MacLean [Thu, 28 Mar 2019 18:21:14 +0000 (14:21 -0400)]
Update ApiCompatBaseline.uapaot.txt
Commit migrated from https://github.com/dotnet/corefx/commit/
7c0e40bd2377b78e82ef0c1780bae80f03e29778
Steve MacLean [Thu, 28 Mar 2019 16:02:54 +0000 (12:02 -0400)]
Update AssemblyLoadContext ref assembly
Fixes dotnet/corefx#34791
Commit migrated from https://github.com/dotnet/corefx/commit/
c42e9e46ea5ec4d706748bec89776951df5292d7
Michal Strehovský [Thu, 28 Mar 2019 20:26:07 +0000 (21:26 +0100)]
Fix IBC data embedding (dotnet/corefx#36450)
An arcade change broke IBC data embedding and we were not doing it.
This fixes that issue and also bumps embedded IBC from being `partial` to `full`.
Commit migrated from https://github.com/dotnet/corefx/commit/
719eee95faa5d638bf9959f263b428dc69a2f234
Santiago Fernandez Madero [Thu, 28 Mar 2019 18:00:25 +0000 (11:00 -0700)]
Disable push to myget and increase publish timeout (dotnet/corefx#36458)
Commit migrated from https://github.com/dotnet/corefx/commit/
98dacbcbfd8853f1fdedf84e6b33acd3998ab899
Max Kerr [Thu, 28 Mar 2019 17:31:18 +0000 (10:31 -0700)]
HTTP2: Don't send RST_STREAM in response to window update on closed stream (dotnet/corefx#36410)
Commit migrated from https://github.com/dotnet/corefx/commit/
b867bfef3f7e3951b47134c75ebbaae0a5ca9dd3
Dávid Kaya [Thu, 28 Mar 2019 13:56:08 +0000 (00:56 +1100)]
Added support for UF_HIDDEN flag on macOS and FreeBSD (dotnet/corefx#29323) (dotnet/corefx#34560)
* Added support for UF_HIDDEN flag on macOS and FreeBSD (dotnet/corefx#29323)
* Changes based on review
* Reverted UserFlags field
* Sorted include in csproj
* Changed comparison style
* Reverted UserFlags field
* Fixed parentheses
* Changes based on PR review
* Add missing newline
* Add missing newline
Commit migrated from https://github.com/dotnet/corefx/commit/
b37f0185ac05c9431389f333f5b2b0fc5fe93e6a
Stephen Toub [Thu, 28 Mar 2019 13:46:43 +0000 (09:46 -0400)]
Add standalone test runner generator utility (dotnet/corefx#36434)
A console app that reflects over a corefx test assembly and generates another console app that can invoke most of the tests without any reflection and minimal additional code execution. This is helpful when bringing up new platforms.
Commit migrated from https://github.com/dotnet/corefx/commit/
ea48dae8a957f189c9812cc13ebaec8237dc6bc7
Stephen Toub [Thu, 28 Mar 2019 03:08:19 +0000 (23:08 -0400)]
Add standalone test runner generator utility
A console app that reflects over a corefx test assembly and generates another console app that can invoke most of the tests without any reflection and minimal additional code execution. This is helpful when bringing up new platforms.
Commit migrated from https://github.com/dotnet/corefx/commit/
8a3a8c826d4ab9d0be1da11da13f586e4259c3cc
Jan Kotas [Thu, 28 Mar 2019 05:37:22 +0000 (22:37 -0700)]
Move QueryPerformanceCounter PInvokes to shared (dotnet/corefx#36409)
Commit migrated from https://github.com/dotnet/corefx/commit/
560dbe850a77d51437039495b87b1819d1f7a5b2
Tarek Mahmoud Sayed [Thu, 28 Mar 2019 05:36:19 +0000 (22:36 -0700)]
Fix Korean Calendar Test (dotnet/corefx#36429)
Commit migrated from https://github.com/dotnet/corefx/commit/
24995ed7dbfdf7aa284197fa77e9d619e3d60a14
Stephen Toub [Thu, 28 Mar 2019 05:33:06 +0000 (01:33 -0400)]
Fix more test visibility issues (dotnet/corefx#36435)
Commit migrated from https://github.com/dotnet/corefx/commit/
3356cc71c5b125ce6f721ed37c23f7ca51c95178
Tomas Weinfurt [Thu, 28 Mar 2019 04:24:17 +0000 (21:24 -0700)]
increase max test duration from 10 to 15 minutes (dotnet/corefx#36432)
Commit migrated from https://github.com/dotnet/corefx/commit/
b98aad34981a3d8c45edee4aee99a99a02b3bb80
Steven Kirbach [Wed, 27 Mar 2019 21:13:38 +0000 (14:13 -0700)]
Merge pull request dotnet/corefx#36389 from dotnet/dev/stevenbrix/addBackSupportForIncrementalParts
ensuring that calling GetPart will call GetPartCore
Commit migrated from https://github.com/dotnet/corefx/commit/
3862b1bf2f5bdd5c7c5f77e64cd23dffe5ebb9d0
Jeremy Koritzinsky [Wed, 27 Mar 2019 20:25:12 +0000 (13:25 -0700)]
Fix inverted initialization check.
Commit migrated from https://github.com/dotnet/corefx/commit/
a009ac0f0dc42ae0eb5752a7d602b784eb563bc5
Steven Kirbach [Wed, 27 Mar 2019 20:14:49 +0000 (13:14 -0700)]
pr feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
14cb70116924fbbfd15c3fdc6a069833a7d37108
Steven Kirbach [Wed, 27 Mar 2019 19:04:15 +0000 (12:04 -0700)]
PR Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
ddbae8b0b8ffc092ba24badb355bed204c249583
Levi Broderick [Wed, 27 Mar 2019 15:30:47 +0000 (08:30 -0700)]
Add Utf8String package, reference APIs, and unit tests (dotnet/corefx#35989)
Commit migrated from https://github.com/dotnet/corefx/commit/
1453863bc998b63024987e13b1e7a45659b452de
Viktor Hofer [Wed, 27 Mar 2019 15:24:05 +0000 (16:24 +0100)]
Merge pull request dotnet/corefx#36183 from ViktorHofer/ConfigurationUppercase
Uppercase configuration string
Commit migrated from https://github.com/dotnet/corefx/commit/
e0cf67ab5c60f41c7c8860c74063b20f77e8a347
Viktor Hofer [Wed, 27 Mar 2019 15:04:36 +0000 (16:04 +0100)]
Merge pull request dotnet/corefx#36387 from ericstj/sourceBuildFixes
Make some packages optional for source build
Commit migrated from https://github.com/dotnet/corefx/commit/
04eba1a41579b3f9d9dbfdc72a96977f5897ff9d
Stephen Toub [Wed, 27 Mar 2019 14:05:19 +0000 (10:05 -0400)]
Fix visibility of several test methods (dotnet/corefx#36380)
Commit migrated from https://github.com/dotnet/corefx/commit/
6038ddaa0ff66984fe157958ded2a2327ba1e743
Levi Broderick [Wed, 27 Mar 2019 06:23:21 +0000 (23:23 -0700)]
Add ref asms and unit tests for Rune.Encode APIs (dotnet/corefx#36035)
Commit migrated from https://github.com/dotnet/corefx/commit/
9da775f39d7cd3a20ae4732b96d7174ca634339a
dotnet-maestro-bot [Wed, 27 Mar 2019 06:04:03 +0000 (23:04 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27527-00, beta-27527-00, respectively (dotnet/corefx#36357)
Commit migrated from https://github.com/dotnet/corefx/commit/
d5874e37801c48ffd15e743a1e78f5c0d535c0d2
Santiago Fernandez Madero [Wed, 27 Mar 2019 03:04:55 +0000 (20:04 -0700)]
Fix CI, use helix secret only for official builds (dotnet/corefx#36390)
Commit migrated from https://github.com/dotnet/corefx/commit/
477f208f350119a311eb6397b3ac8f19c7ed7a8c
Steven Kirbach [Wed, 27 Mar 2019 00:14:11 +0000 (17:14 -0700)]
ensuring that calling GetPart will call GetPartCore
Package is an abstract class that others can derive from. Those derived classes can override GetPartsCore and potentially not return anything. Furthermore, it is not guaranteed that GetPartsCore will have been called if the package wasn't created using the Package.Open API, which only ensures that ZipPackage's internal data structures are filled in.
Commit migrated from https://github.com/dotnet/corefx/commit/
8f1d205116dd7dec996baa3276e73070c4f59ed5
Steve Harter [Tue, 26 Mar 2019 23:10:28 +0000 (16:10 -0700)]
Update API based on review (dotnet/corefx#36385)
Commit migrated from https://github.com/dotnet/corefx/commit/
bfdc19995af287c2028c59cbbeee1497d1e34e58
Tomas Weinfurt [Tue, 26 Mar 2019 22:36:33 +0000 (15:36 -0700)]
32bit process may not throw on negative allocation (dotnet/corefx#36381)
Commit migrated from https://github.com/dotnet/corefx/commit/
8c0f15cb5fa7919056f0882660556ead69fe9887
Tomas Weinfurt [Tue, 26 Mar 2019 22:35:03 +0000 (15:35 -0700)]
add Alpine.39 and update ARM64 container (dotnet/corefx#36377)
Commit migrated from https://github.com/dotnet/corefx/commit/
d44c43b64de0f942c81fea7a535bf8bade508db0
Eric StJohn [Tue, 26 Mar 2019 21:41:45 +0000 (14:41 -0700)]
Use Microsoft.DotNet.VersionTools.Tasks (dotnet/corefx#36369)
Commit migrated from https://github.com/dotnet/corefx/commit/
0e672db1594b72f9af5de60ea959ec7b78ae3e5f
Tanner Gooding [Tue, 26 Mar 2019 20:56:13 +0000 (13:56 -0700)]
Adding more floating-point parsing test coverage and re-enabling some tests (dotnet/corefx#35899)
* Adding some tests to validate too large exponents are handled correctly.
* Re-enabling the tests that were skipped due to 35566
* Re-enabling the tests that were skipped due to 35864
* Changing RealFormatterTestsBase to be UTF8
Commit migrated from https://github.com/dotnet/corefx/commit/
9e9b1d05358bddbf5aa74224c91784322897f5ad
Liudmila Molkova [Tue, 26 Mar 2019 20:41:25 +0000 (13:41 -0700)]
Fix: TraceId is not available before Activity starts (dotnet/corefx#36345)
* Fix: TraceId is not available before Activity starts
* minor fixes
* review: Move TraceId parsing from parent to helper method
* fix netfx
Commit migrated from https://github.com/dotnet/corefx/commit/
b1f81d6480909bfe41fa6299fbfd38376df6f240
Wraith2 [Tue, 26 Mar 2019 19:26:55 +0000 (19:26 +0000)]
Merge remote-tracking branch 'dotnet/master' into sqlperf-envchange
Commit migrated from https://github.com/dotnet/corefx/commit/
e3862c88c0f154e7a6191f3eb7b5a7a255c0444c
Tomas Weinfurt [Tue, 26 Mar 2019 19:26:11 +0000 (12:26 -0700)]
disable UWP on arm (dotnet/corefx#36356)
* disable UWP on arm
* build but not test UAP_arm_Release
Commit migrated from https://github.com/dotnet/corefx/commit/
c0e280d22177f9a471b2f80ef7e1bcba59c438a1
Jeremy Koritzinsky [Tue, 26 Mar 2019 19:24:45 +0000 (12:24 -0700)]
Fix WinRT marshalling for NotifyPropertyChangedEventArgs and NotifyCollectionChangedEventArgs (CoreFX side) (dotnet/corefx#36224)
The fix for dotnet/corefxdotnet/corefx#35909 requires both some runtime work and some framework work since the marshalling helpers for NotifyPropertyChangedEventArgs and NotifyCollectionChangedEventArgs lives in corefx.
In this PR:
- Update the signatures of `INotifyCollectionChangedEventArgsFactory.CreateInstanceWithAllParameters` and `INotifyPropertyChangedEventArgsFactory.CreateInstance` to be as close to their official `winmd` signature as possible.
We cannot update the return types since we need to make sure we return the raw COM object pointer and not a pointer to an RCW that was projected through our WinRT type projection back to managed. (depends on dotnet/coreclrdotnet/corefx#23401)
- Call a new function on `System.Runtime.InteropServices.WindowsRuntimeMarshal` called `GetUniqueObjectForIUnknownWithoutUnboxing` (introduced in dotnet/coreclrdotnet/corefx#23401) to get back an RCW for the IUnknown pointer without going through the WinRT projections. The WinRT projections for `INotifyPropertyChangedEventArgs` and `INotifyCollectionChangedEventArgs` go through this code to project themselves to the managed code, so we need a way to get back a "raw" RCW that is not projected to avoid infinitely recursing into a stack-overflow (current behavior) and avoid having to manually traversing the vtable of the native interfaces (impractical to implement).
Depends on dotnet/coreclrdotnet/corefx#23401
Fixes dotnet/corefx#35909
Co-authored-by: Jeff Schwartz <JeffSchw@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
b0123b9bdd9a4bf0b1447d9d2a4c4b77ed708f05
Tanner Gooding [Tue, 26 Mar 2019 15:48:03 +0000 (08:48 -0700)]
Cleaning up the P/Invoke signatures for QPF and QPC to avoid marshalling and pinning (dotnet/corefx#36071)
* Cleaning up the P/Invoke signatures for QPF and QPC to avoid marshalling and pinning
* Responding to PR feedback.
* Dropping support for low resolution stopwatch
* Removing BestFitMapping=false
* Removing unneeded unsafe declarations
* Addressing more PR feedback
* Fixing the pal_time header file
* Fixing the Unix P/Invoke signatures for GetTimestamp and GetTimestampResolution to return ulong.
* Fixing GetTimestampResolution to scale the result for HAVE_CLOCK_MONOTONIC
Commit migrated from https://github.com/dotnet/corefx/commit/
c1328f49f69d501618f1d867265efacedf107f23
Afsaneh Rafighi [Tue, 26 Mar 2019 15:18:51 +0000 (08:18 -0700)]
Merge pull request dotnet/corefx#34709 from Wraith2/sqlfix-13439
SqlClient add TestPacketNumberWraparound fix and test
Commit migrated from https://github.com/dotnet/corefx/commit/
d4e6617c6a1a63b3d58e7ab4d8d52c1ff679eb3e
Levi Broderick [Tue, 26 Mar 2019 01:05:53 +0000 (18:05 -0700)]
Remove corefx references to String.Copy and mark it obsolete (dotnet/corefx#36131)
* Remove references to string.Copy.
* Obsolete String.Copy and mark EditorBrowsable.Never
* Suppress String.Copy obsolete warning from String unit tests
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
dd917a1ce1f812fbd6d3d2268c9ebc3728fd2dfb
Steve Harter [Tue, 26 Mar 2019 00:09:49 +0000 (17:09 -0700)]
Add ignore and propertyname features (dotnet/corefx#36353)
Commit migrated from https://github.com/dotnet/corefx/commit/
f4fa8a1c44d1d675d7f60e320f36da195ab56633
Tomas Weinfurt [Mon, 25 Mar 2019 23:30:53 +0000 (16:30 -0700)]
test Linux/arm32 queue (dotnet/corefx#36054)
* add test queue for Linux/arm32
Commit migrated from https://github.com/dotnet/corefx/commit/
df31ca60165196a4de06615faf0dfb91a9de2688
Santiago Fernandez Madero [Mon, 25 Mar 2019 23:26:30 +0000 (16:26 -0700)]
Fix corefx official builds (dotnet/corefx#36344)
Commit migrated from https://github.com/dotnet/corefx/commit/
8e31744bf284cd03469c876833d450ad30d915c7
Tomas Weinfurt [Mon, 25 Mar 2019 21:43:28 +0000 (14:43 -0700)]
make mmap tests friendlier to containers (dotnet/corefx#36342)
* make mmap tests friendlier to containers
* move { to right place
Commit migrated from https://github.com/dotnet/corefx/commit/
7cdbadc0399009202d3821024f106efcf12b23c4
Tom Deseyn [Mon, 25 Mar 2019 21:15:45 +0000 (22:15 +0100)]
Process.Unix: fix unexpected Process.Exited events (dotnet/corefx#36333)
* Process.Unix: fix unexpected Process.Exited events
Extract ProcessWaitHandle creation from EnsureWatchingForExit to avoid
Process.Exited events when user hasn't set EnableRaisingEvents.
Fixes https://github.com/dotnet/corefx/issues/36331
* Rework
* Move GetOrOpenProcessHandle into Windows EnsureWatchingForExit
* Code formatting
Commit migrated from https://github.com/dotnet/corefx/commit/
cd710b371a1ae86f0c215261b021101d491910a1
David Shulman [Mon, 25 Mar 2019 18:39:33 +0000 (11:39 -0700)]
Fix Kerberos/NTLM for multiple domain/realm environments in Linux (dotnet/corefx#36329)
This PR addresses some issues reported by a customer (not thru GitHub). They noticed that
multiple domain scenarios were working in .NET Core 2.0 but broke in .NET Core 2.1 on Linux.
While the previous PR dotnet/corefx#35383 solved the Negotiate Kerberos to NTLM fallback issue,
it added more complexity than necessary. The retry logic I added wasn't really necessary
because the original code that used GSS_KRB5_NT_PRINCIPAL_NAME format for the target name
was wrong. That logic only works for pure Kerberos environments and doesn't handle domain
or realm referrals. So, it only handles the default Kerberos realm on the the single Linux
client. In addition, using GSS_KRB5_NT_PRINCIPAL_NAME defeats the logic of the SPNEGO mechanism. That is why I originally needed to add the retry logic using GSS_C_NT_HOSTBASED_SERVICE format for the target name.
The multiple domain/realm scenario worked in .NET Core 2.0 because it used CurlHandler.
And libcurl always uses GSS_C_NT_HOSTBASED_SERVICE format for target name.
This PR reworks the logic to use the GSS_C_NT_HOSTBASED_SERVICE format. It also removes the
now unneeded retry logic. I tested this against Windows and Linux as well as pure Kerberos
and Kerberos to NTLM fallback (using SPNEGO).
I added more tests. These tests are currently part of the enterprise scenario tests we are
building. They are activated via environment variables.
By defining all of the environment variables below, I am able to run the System.Net.Security
and System.Net.Http enterprise-scenario tests. Both SocketsHttpHandler in System.Net.Http and
NegotiateStream in System.Net.Security use the same common GSS-API logic in CoreFx.
Define domain-joined server remote endpoint:
* COREFX_NET_SECURITY_NEGOSERVERURI
* COREFX_DOMAINJOINED_HTTPHOST
* COREFX_NET_AD_DOMAINNAME
* COREFX_NET_AD_PASSWORD
* COREFX_NET_AD_USERNAME
Define standalone server remote endpoint:
* COREFX_WINDOWSSERVER_HTTPHOST
* COREFX_NET_SERVER_PASSWORD
* COREFX_NET_SERVER_USERNAME
Commit migrated from https://github.com/dotnet/corefx/commit/
658ec735698affec9ce99a59a9342bf7ac5778db
dotnet-maestro-bot [Mon, 25 Mar 2019 14:42:06 +0000 (07:42 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27525-00, beta-27525-00, respectively (dotnet/corefx#36332)
Commit migrated from https://github.com/dotnet/corefx/commit/
aed4009a7d58a34c2fb9f3b4739a027a8309f4da
Nick Schonning [Sun, 24 Mar 2019 20:47:05 +0000 (16:47 -0400)]
typo: infering -> inferring (dotnet/corefx#36315)
Commit migrated from https://github.com/dotnet/corefx/commit/
d3942d4671919edb0cca6ddc1840190f524a809d
Nick Schonning [Sun, 24 Mar 2019 20:45:38 +0000 (16:45 -0400)]
typo: ArgumenNullException -> ArgumentNullException (dotnet/corefx#36316)
Commit migrated from https://github.com/dotnet/corefx/commit/
07a810549072855ea5214060d0ca6e50fd634f33
Nick Schonning [Sun, 24 Mar 2019 20:44:51 +0000 (16:44 -0400)]
typo: Double word "never" (dotnet/corefx#36300)
Commit migrated from https://github.com/dotnet/corefx/commit/
e86b522c7d25985224e6e06f4746e2ae42a50b77
Nick Schonning [Sun, 24 Mar 2019 20:44:15 +0000 (16:44 -0400)]
typo: Double word "on" (dotnet/corefx#36265)
Commit migrated from https://github.com/dotnet/corefx/commit/
63d0fb143a66400fd62099f60cd7958b8461ffda
Nick Schonning [Sun, 24 Mar 2019 20:43:54 +0000 (16:43 -0400)]
typo: Double word "to" (dotnet/corefx#36264)
Commit migrated from https://github.com/dotnet/corefx/commit/
2a3bb4814319b31de87d5ff2c73c2b55f5e209f1
Nick Schonning [Sun, 24 Mar 2019 20:43:29 +0000 (16:43 -0400)]
typo: Double word "from" (dotnet/corefx#36266)
Commit migrated from https://github.com/dotnet/corefx/commit/
47b33a152bce3a8c097de62dec9c0dd10826c2aa
Nick Schonning [Sun, 24 Mar 2019 20:43:04 +0000 (16:43 -0400)]
typo: Double word "that" (dotnet/corefx#36269)
Commit migrated from https://github.com/dotnet/corefx/commit/
591afaa5155b7f4402ab67ab827df29bb941b99a
Nick Schonning [Sun, 24 Mar 2019 20:42:29 +0000 (16:42 -0400)]
typo: Double word "be" (dotnet/corefx#36267)
Commit migrated from https://github.com/dotnet/corefx/commit/
1a31fdb873bf998a93aa4715a66e83d7b9d208b4
Nick Schonning [Sun, 24 Mar 2019 20:42:07 +0000 (16:42 -0400)]
typo: Double word "they" (dotnet/corefx#36268)
Commit migrated from https://github.com/dotnet/corefx/commit/
075b85c5e23ce3a7d1de3b647827563fcd3e5c00
Nick Schonning [Sun, 24 Mar 2019 20:41:37 +0000 (16:41 -0400)]
typo: Double word "in" (dotnet/corefx#36270)
* typo: Double word "in"
* Update src/System.Console/src/System/Console.cs
Co-Authored-By: nschonni <nschonni@gmail.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
be1561c8fd02411c60edf551aa2c4f48377281d6
Nick Schonning [Sun, 24 Mar 2019 20:41:06 +0000 (16:41 -0400)]
typo: Double word "a" (dotnet/corefx#36271)
Commit migrated from https://github.com/dotnet/corefx/commit/
7cfd38ee1b889cf5e5d47e78e9c6579856ce6b3c
Nick Schonning [Sun, 24 Mar 2019 20:40:35 +0000 (16:40 -0400)]
typo: Double word "this" (dotnet/corefx#36273)
Commit migrated from https://github.com/dotnet/corefx/commit/
97e6256f05945f7b20025e5c14cae6a8871c87ef
Nick Schonning [Sun, 24 Mar 2019 20:40:10 +0000 (16:40 -0400)]
typo: Double word "the" (dotnet/corefx#36274)
* typo: Double word "the"
* Apply suggestions from code review
Co-Authored-By: nschonni <nschonni@gmail.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
aa67d40064f652b48f7ee0cd85dbfe39c7deebac
Nick Schonning [Sun, 24 Mar 2019 20:38:32 +0000 (16:38 -0400)]
typo: Double word "for" (dotnet/corefx#36278)
Commit migrated from https://github.com/dotnet/corefx/commit/
45e06bf1dc8c95ba60a89c253ceefb75200f427e
Nick Schonning [Sun, 24 Mar 2019 20:38:10 +0000 (16:38 -0400)]
typo: Double word "should" (dotnet/corefx#36279)
Commit migrated from https://github.com/dotnet/corefx/commit/
25de6ddf6ba4248a1225762fa71a3793fd6a98e8
Nick Schonning [Sun, 24 Mar 2019 20:37:48 +0000 (16:37 -0400)]
typo: Double word "it" (dotnet/corefx#36280)
Commit migrated from https://github.com/dotnet/corefx/commit/
e8ce19a3485646cb45a8cecf30566629b98c04ff
Nick Schonning [Sun, 24 Mar 2019 20:37:20 +0000 (16:37 -0400)]
typo: Double word "when" (dotnet/corefx#36281)
Commit migrated from https://github.com/dotnet/corefx/commit/
bb7f2008c6ae0f391d7969ad5f102ff40f8acd83
Nick Schonning [Sun, 24 Mar 2019 20:36:59 +0000 (16:36 -0400)]
typo: Double word "at" (dotnet/corefx#36282)
Commit migrated from https://github.com/dotnet/corefx/commit/
9a8df7168eb30c760880c4b78976048f24ea373f
Nick Schonning [Sun, 24 Mar 2019 20:36:34 +0000 (16:36 -0400)]
typo: Double word "is" (dotnet/corefx#36283)
Commit migrated from https://github.com/dotnet/corefx/commit/
6322be5f3b6010b29dd2402eb236c5881f7ae6de
Nick Schonning [Sun, 24 Mar 2019 20:36:10 +0000 (16:36 -0400)]
typo: Double word "were" (dotnet/corefx#36284)
Commit migrated from https://github.com/dotnet/corefx/commit/
3cc4cd7585e71741b5b4e3a4a9e84abf5a5b3545
Nick Schonning [Sun, 24 Mar 2019 20:35:42 +0000 (16:35 -0400)]
typo: Double word "into" (dotnet/corefx#36285)
Commit migrated from https://github.com/dotnet/corefx/commit/
98b3c513c6961a84c2fd4a34fa2899dd5b0211c0
Nick Schonning [Sun, 24 Mar 2019 20:35:19 +0000 (16:35 -0400)]
typo: Double word "if" (dotnet/corefx#36287)
Commit migrated from https://github.com/dotnet/corefx/commit/
1d90371b87ace4c18de620c0df9365592c378743
Nick Schonning [Sun, 24 Mar 2019 20:34:57 +0000 (16:34 -0400)]
typo: Double word "we" (dotnet/corefx#36288)
Commit migrated from https://github.com/dotnet/corefx/commit/
e949cd08e8dded42cad58f451fc12f5c75949780
Nick Schonning [Sun, 24 Mar 2019 20:34:26 +0000 (16:34 -0400)]
typo: Double word "old" (dotnet/corefx#36289)
Commit migrated from https://github.com/dotnet/corefx/commit/
bf57fa6009a0b82e5a011a42770ce9b77a41c276
Nick Schonning [Sun, 24 Mar 2019 20:34:02 +0000 (16:34 -0400)]
typo: Double word "get" (dotnet/corefx#36290)
Commit migrated from https://github.com/dotnet/corefx/commit/
8d8efa4f09e216242f16910c3b0b3be173a7c2c7
Nick Schonning [Sun, 24 Mar 2019 20:33:40 +0000 (16:33 -0400)]
typo: Double word "no" (dotnet/corefx#36299)
Commit migrated from https://github.com/dotnet/corefx/commit/
20bfcdab43877055a8e0b7dc910cd7e66f3a9903
Nick Schonning [Sun, 24 Mar 2019 20:33:08 +0000 (16:33 -0400)]
typo: arguemnts -> arguments (dotnet/corefx#36306)
Commit migrated from https://github.com/dotnet/corefx/commit/
ff82f8b010021657c7e8dc40a2f78e8ed443fec9
Nick Schonning [Sun, 24 Mar 2019 20:32:44 +0000 (16:32 -0400)]
typo: Double word "over" (dotnet/corefx#36296)
Commit migrated from https://github.com/dotnet/corefx/commit/
5bddeb29c4821ab13c2b26338a90e9ff18c9afb8
Nick Schonning [Sun, 24 Mar 2019 20:32:15 +0000 (16:32 -0400)]
typo: Double word "than" (dotnet/corefx#36295)
Commit migrated from https://github.com/dotnet/corefx/commit/
86af3ac4c9d1d34c4bdf61a2a170ed83bf937696
Nick Schonning [Sun, 24 Mar 2019 20:31:53 +0000 (16:31 -0400)]
typo: Double word "or" (dotnet/corefx#36291)
Commit migrated from https://github.com/dotnet/corefx/commit/
35f52c329dffbeb6e79cc2b51e2d966bbb3402fd
Nick Schonning [Sun, 24 Mar 2019 20:31:24 +0000 (16:31 -0400)]
typo: Double word "and" (dotnet/corefx#36301)
* typo: Double word "and"
* Update src/System.Linq.Expressions/tests/BinaryOperators/Bitwise/BinaryExclusiveOrTests.cs
Co-Authored-By: nschonni <nschonni@gmail.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
9978c8db1d5d6496d133627446bfc9165f207264
Nick Schonning [Sun, 24 Mar 2019 20:30:29 +0000 (16:30 -0400)]
typo: Double word "set" (dotnet/corefx#36293)
Commit migrated from https://github.com/dotnet/corefx/commit/
2a1f9024a44865cd46fb43795bd3ddad6e379e87
Nick Schonning [Sun, 24 Mar 2019 20:29:41 +0000 (16:29 -0400)]
typo: Similarily -> Similarly (dotnet/corefx#36305)
Commit migrated from https://github.com/dotnet/corefx/commit/
eef2c036a727bdae8f94b06b319a8f223a9403c5
Nick Schonning [Sun, 24 Mar 2019 20:29:15 +0000 (16:29 -0400)]
typo: rearange -> rearrange (dotnet/corefx#36302)
Commit migrated from https://github.com/dotnet/corefx/commit/
c7184a05826f62d090c71368661149b4fb1909c3
Nick Schonning [Sun, 24 Mar 2019 20:28:44 +0000 (16:28 -0400)]
typo: Simplied -> Simplified (dotnet/corefx#36313)
- Falback -> Fallback
Commit migrated from https://github.com/dotnet/corefx/commit/
0306790ea27c2f40b34de7ee5ced4565249d14a0
Nick Schonning [Sun, 24 Mar 2019 20:27:50 +0000 (16:27 -0400)]
typo: Procider -> Provider (dotnet/corefx#36310)
Commit migrated from https://github.com/dotnet/corefx/commit/
21e6dc84663aa8b9036730733c1c4b8854e5dbf9
Nick Schonning [Sun, 24 Mar 2019 20:27:27 +0000 (16:27 -0400)]
typo: excpetions -> exceptions (dotnet/corefx#36308)
Commit migrated from https://github.com/dotnet/corefx/commit/
e25fd65195e9538499d9f65fdd1c8536830b9170
Nick Schonning [Sun, 24 Mar 2019 20:27:03 +0000 (16:27 -0400)]
typo: Double word "Version" (dotnet/corefx#36297)
Looks like old commented out code
Commit migrated from https://github.com/dotnet/corefx/commit/
3ff2bf2051e030c8e30c1e98550fa45736b9b143
Nick Schonning [Sun, 24 Mar 2019 20:26:37 +0000 (16:26 -0400)]
typo: Double word "my" (dotnet/corefx#36298)
* typo: Double word "my"
* Update src/System.Private.Xml/src/System/Xml/Xsl/Xslt/XslAstAnalyzer.cs
Co-Authored-By: nschonni <nschonni@gmail.com>
* typo: depend -> depends
Commit migrated from https://github.com/dotnet/corefx/commit/
8676c526ade623c0eb41a09deb9b11ae718a89c8