platform/upstream/libSkiaSharp.git
9 years agoRuntime configuration section of docs
hcm [Wed, 18 Feb 2015 20:55:04 +0000 (12:55 -0800)]
Runtime configuration section of docs

Preview here: http://skiadocs.com:8000/dev/runtime/?cl=940663002

BUG=skia:

Review URL: https://codereview.chromium.org/940663002

9 years agoPass Rendertarget into context.
joshualitt [Wed, 18 Feb 2015 20:29:52 +0000 (12:29 -0800)]
Pass Rendertarget into context.

Adding Jim for text context stuff, and Steven for image blur stuff.

BUG=skia:

Review URL: https://codereview.chromium.org/939623005

9 years agoUse uint16s for texture coordinates when rendering text.
jvanverth [Wed, 18 Feb 2015 19:36:35 +0000 (11:36 -0800)]
Use uint16s for texture coordinates when rendering text.

Allows us to push more vertices into a given vertex buffer, with
a slight performance improvement.

Committed: https://skia.googlesource.com/skia/+/059034d252007d0dd86fff5ffdbb53cbcb10d34b

Review URL: https://codereview.chromium.org/917373002

9 years agoUse SkAutoSTMalloc in GrResourceKey
bsalomon [Wed, 18 Feb 2015 19:33:04 +0000 (11:33 -0800)]
Use SkAutoSTMalloc in GrResourceKey

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/935863003

9 years agoPDF: Add (low-memory) SkPDFBitmap class
halcanary [Wed, 18 Feb 2015 19:29:56 +0000 (11:29 -0800)]
PDF: Add (low-memory) SkPDFBitmap class

Also: Add SkDeflateWStream and associated unit tests.

SkPDFBitmap is a replacement for SkPDFImage.  As of now, it only
supports 8888 bitmaps (the most common case).

SkPDFBitmap takes very little extra memory (aside from refing the
bitmap's pixels), and its emitObject() does not cache any data.

The SkPDFBitmap::Create function will check the canon for duplicates.
This can reduce the size of the output PDF.

Motivation:  this gives another ~40% decrease in PDF memory overhead

TODO: Support other ColorTypes and scrap SkPDFImage.

BUG=skia:3030

Review URL: https://codereview.chromium.org/918813002

9 years agoUpdate DirectWrite streams to SkStreamAsset.
bungeman [Wed, 18 Feb 2015 19:01:05 +0000 (11:01 -0800)]
Update DirectWrite streams to SkStreamAsset.

SkTypefaces now deal in terms of SkStreamAsset, but the DirectWrite port
was never fully converted.

Review URL: https://codereview.chromium.org/940563002

9 years agoRemove Chromium staging in SkDrawCommand
robertphillips [Wed, 18 Feb 2015 18:56:05 +0000 (10:56 -0800)]
Remove Chromium staging in SkDrawCommand

This cannot land until https://codereview.chromium.org/917063008/ (Cleanup lingering scaffolding for Skia change) has landed.

TBR=joshualitt@chromium.org

Review URL: https://codereview.chromium.org/930973002

9 years agoupdate sampleapp for stroking experiment
caryclark [Wed, 18 Feb 2015 18:56:00 +0000 (10:56 -0800)]
update sampleapp for stroking experiment

Add RotateCircles3 back as better-named QuadStroker.

Switch pathfill test to call skia before draw instead of in
initializer to avoid triggering debugging breakpoints.

Review URL: https://codereview.chromium.org/912273003

9 years agoExpose method to retrieve CTFont
dominik.rottsches [Wed, 18 Feb 2015 18:50:58 +0000 (10:50 -0800)]
Expose method to retrieve CTFont

BUG=skia:3351
R=bungeman@chromium.org

Review URL: https://codereview.chromium.org/872963003

9 years agoMake SkImage::getTexture() const
kkinnunen [Wed, 18 Feb 2015 18:50:52 +0000 (10:50 -0800)]
Make SkImage::getTexture() const

Make SkImage::getTexture() const. At the moment the function
does not mutate the state.

One use-case is that this makes it possible in the future to add draw
function to SkBaseDevice functions. The device draw functions take
const ref objects, but SkGpuDevice likely would benefit of using the
getTexture().

BUG=skia:3388
R=reed@google.com

Review URL: https://codereview.chromium.org/925853002

9 years agofix xcode build
mtklein [Wed, 18 Feb 2015 17:35:49 +0000 (09:35 -0800)]
fix xcode build

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/936033003

9 years agoRevert of Use uint16s for texture coordinates when rendering text. (patchset #5 id...
reed [Wed, 18 Feb 2015 02:38:38 +0000 (18:38 -0800)]
Revert of Use uint16s for texture coordinates when rendering text. (patchset #5 id:80001 of https://codereview.chromium.org/917373002/)

Reason for revert:
speculative revert for DEPS failures

https://codereview.chromium.org/932973002/

Original issue's description:
> Use uint16s for texture coordinates when rendering text.
>
> Allows us to push more vertices into a given vertex buffer, with
> a slight performance improvement.
>
> Committed: https://skia.googlesource.com/skia/+/059034d252007d0dd86fff5ffdbb53cbcb10d34b

TBR=joshualitt@google.com,robertphillips@google.com,bsalomon@google.com,reed@google.com,djsollen@google.com,jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/920333003

9 years agoUse an array of nonpurgeable resources in GrResourceCache
bsalomon [Tue, 17 Feb 2015 23:09:34 +0000 (15:09 -0800)]
Use an array of nonpurgeable resources in GrResourceCache

Review URL: https://codereview.chromium.org/932863004

9 years agozlib/pdf: remove HaveFlate(), depend on preprocessor defines
halcanary [Tue, 17 Feb 2015 22:43:06 +0000 (14:43 -0800)]
zlib/pdf: remove HaveFlate(), depend on preprocessor defines

Review URL: https://codereview.chromium.org/933523007

9 years agoDM: move ext into key
mtklein [Tue, 17 Feb 2015 21:18:04 +0000 (13:18 -0800)]
DM: move ext into key

BUG=skia:

Review URL: https://codereview.chromium.org/925523003

9 years agoSK_NO_FLATE
mtklein [Tue, 17 Feb 2015 21:10:43 +0000 (13:10 -0800)]
SK_NO_FLATE

Also remove skia_zlib_static.  We're not using it.  We don't even have zlib in DEPS.

No public API changes.
TBR=reed@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/936583002

9 years agoMake GrResourceCache use a priority queue of purgeable resources.
bsalomon [Tue, 17 Feb 2015 19:47:40 +0000 (11:47 -0800)]
Make GrResourceCache use a priority queue of purgeable resources.

Review URL: https://codereview.chromium.org/921323002

9 years agoadd gm for path-arcs, and catch degenerate arc in conic-case
reed [Tue, 17 Feb 2015 19:43:14 +0000 (11:43 -0800)]
add gm for path-arcs, and catch degenerate arc in conic-case

BUG=skia:3428

Review URL: https://codereview.chromium.org/931183002

9 years agoDecrease number of allowed stages for Angle on GLProgramTest
egdaniel [Tue, 17 Feb 2015 19:18:38 +0000 (11:18 -0800)]
Decrease number of allowed stages for Angle on GLProgramTest

BUG=skia:3435

Review URL: https://codereview.chromium.org/931783003

9 years agoUse dst copies in porter duffer XP to correctly render certain blends.
egdaniel [Tue, 17 Feb 2015 19:15:47 +0000 (11:15 -0800)]
Use dst copies in porter duffer XP to correctly render certain blends.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/997c6358d94e188b1a7b89a4f86e24cbe0f5a164

Review URL: https://codereview.chromium.org/914003003

9 years agoSuggested version with 'undo'.
mtklein [Tue, 17 Feb 2015 19:13:33 +0000 (11:13 -0800)]
Suggested version with 'undo'.

BUG=skia:

Review URL: https://codereview.chromium.org/931483002

9 years agouse common impl for drawTextOnPath
reed [Tue, 17 Feb 2015 18:33:54 +0000 (10:33 -0800)]
use common impl for drawTextOnPath

BUG=skia:

Review URL: https://codereview.chromium.org/925343003

9 years agoRemove SK_SUPPORT_LEGACY_ADDRRECT
fmalita [Tue, 17 Feb 2015 17:25:49 +0000 (09:25 -0800)]
Remove SK_SUPPORT_LEGACY_ADDRRECT

The flag is no longer used in Chromium.

BUG=458898
R=reed@google.com,robertphillips@google.com

Review URL: https://codereview.chromium.org/929173002

9 years agoRemove SK_SUPPORT_LEGACY_CONIC_COMPUTE_QUAD_POW2
fmalita [Tue, 17 Feb 2015 17:18:33 +0000 (09:18 -0800)]
Remove SK_SUPPORT_LEGACY_CONIC_COMPUTE_QUAD_POW2

The flag is no longer used in Chromium.

BUG=458898
R=reed@google.com,robertphillips@google.com

Review URL: https://codereview.chromium.org/931663004

9 years agoImprove GrInOrderDrawBuffer::Cmd encapsulation
robertphillips [Tue, 17 Feb 2015 17:14:33 +0000 (09:14 -0800)]
Improve GrInOrderDrawBuffer::Cmd encapsulation

In preparation for moving all the Cmds out of GrInOrderDrawBuffer.

Review URL: https://codereview.chromium.org/931673002

9 years agoFix broken build due to updated #define
djsollen [Tue, 17 Feb 2015 17:09:53 +0000 (09:09 -0800)]
Fix broken build due to updated #define

TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/934803003

9 years agoUse uint16s for texture coordinates when rendering text.
jvanverth [Tue, 17 Feb 2015 16:39:56 +0000 (08:39 -0800)]
Use uint16s for texture coordinates when rendering text.

Allows us to push more vertices into a given vertex buffer, with
a slight performance improvement.

Review URL: https://codereview.chromium.org/917373002

9 years agoRemove android specific srcPath from SkPath
djsollen [Tue, 17 Feb 2015 16:06:32 +0000 (08:06 -0800)]
Remove android specific srcPath from SkPath

Review URL: https://codereview.chromium.org/926693002

9 years agoFix skia bug 2845
kui.zheng [Tue, 17 Feb 2015 16:01:52 +0000 (08:01 -0800)]
Fix skia bug 2845

Shouldn't call Fast Blur path(DoubleRowBoxBlur_NEON)
when kernelsize is 1. Or, uint16x8_t resultPixels will be overflow.

BUG=skia:2845
R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/587543003

9 years agoUse SkXfermode as public facing enum for GrPorterDuffXP
egdaniel [Tue, 17 Feb 2015 15:34:43 +0000 (07:34 -0800)]
Use SkXfermode as public facing enum for GrPorterDuffXP

BUG=skia:

Review URL: https://codereview.chromium.org/926593005

9 years agoUpstream support for sfntly in Google3
mtklein [Tue, 17 Feb 2015 14:33:38 +0000 (06:33 -0800)]
Upstream support for sfntly in Google3

See cr/86110021.

BUG=skia:

Review URL: https://codereview.chromium.org/913143007

9 years agoMinor refactoring
robertphillips [Mon, 16 Feb 2015 17:35:50 +0000 (09:35 -0800)]
Minor refactoring

This CL just de-dups some code in GrInOrderDrawBuffer.

Review URL: https://codereview.chromium.org/930953003

9 years agofix for ASAN heap overflow
joshualitt [Mon, 16 Feb 2015 16:33:19 +0000 (08:33 -0800)]
fix for ASAN heap overflow

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/930123002

9 years agoremove unneeded preroll
reed [Sun, 15 Feb 2015 19:08:40 +0000 (11:08 -0800)]
remove unneeded preroll

BUG=skia:
TBR=robertphilips

Review URL: https://codereview.chromium.org/927443006

9 years agoUpdate SKP version
skia.buildbots [Sun, 15 Feb 2015 09:33:06 +0000 (01:33 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/928823002

9 years agoNegative numbers are not flags.
mtklein [Sun, 15 Feb 2015 02:56:31 +0000 (18:56 -0800)]
Negative numbers are not flags.

tested: d dm --matrix 1 -0.3 0 0.7 1 0 0 0 1 --src gm --config matrix-8888 -w bad

BUG=skia:

Review URL: https://codereview.chromium.org/924343002

9 years agogit: add skps to .gitignore
halcanary [Sat, 14 Feb 2015 02:57:33 +0000 (18:57 -0800)]
git: add skps to .gitignore

NOTRY=true

Review URL: https://codereview.chromium.org/924163003

9 years agoLabels when dumping fonts in Android parser test.
bungeman [Sat, 14 Feb 2015 02:30:11 +0000 (18:30 -0800)]
Labels when dumping fonts in Android parser test.

When the FontConfigParserAndroid test runs, it optionally dumps the
configurations it creates for manual inspection. This is useful, but
since three different configurations exist, it can be difficult to tell
them apart. This simply prints a short header before each dump so that
the dump can be identified.

Review URL: https://codereview.chromium.org/927533004

9 years agoMulti-string shaders
joshualitt [Sat, 14 Feb 2015 01:18:27 +0000 (17:18 -0800)]
Multi-string shaders

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/1c3c2d83364ee228e0751df0e1b9c161c0ba8c1e

Review URL: https://codereview.chromium.org/929503002

9 years agoRevert of Multi-string shaders (patchset #4 id:60001 of https://codereview.chromium...
joshualitt [Sat, 14 Feb 2015 00:31:46 +0000 (16:31 -0800)]
Revert of Multi-string shaders (patchset #4 id:60001 of https://codereview.chromium.org/929503002/)

Reason for revert:
windows warnings

Original issue's description:
> Multi-string shaders
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/1c3c2d83364ee228e0751df0e1b9c161c0ba8c1e

TBR=bsalomon@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/924973002

9 years agoMulti-string shaders
joshualitt [Sat, 14 Feb 2015 00:23:48 +0000 (16:23 -0800)]
Multi-string shaders

BUG=skia:

Review URL: https://codereview.chromium.org/929503002

9 years agoC++11 Unit Test for RValue semantics.
halcanary [Fri, 13 Feb 2015 23:12:52 +0000 (15:12 -0800)]
C++11 Unit Test for RValue semantics.

Motivation:  test that these works on all possible bots and for all possible clients (clients do run these unit tests, right?)

Dear clients:  if this unit test fails, let us know!

BUG=skia:3427

Review URL: https://codereview.chromium.org/922043004

9 years agoDM: don't leak the null canvas in NullSink.
mtklein [Fri, 13 Feb 2015 23:11:10 +0000 (15:11 -0800)]
DM: don't leak the null canvas in NullSink.

Also make NullSink a real boy: declared among the other Sinks, impl in .cpp.

BUG=skia:

Review URL: https://codereview.chromium.org/922293003

9 years agofix more tricky-float cases in SkRRect validate
reed [Fri, 13 Feb 2015 22:33:02 +0000 (14:33 -0800)]
fix more tricky-float cases in SkRRect validate

BUG=458524,458522

Review URL: https://codereview.chromium.org/921163003

9 years agoAA stroke rects batch
joshualitt [Fri, 13 Feb 2015 22:25:10 +0000 (14:25 -0800)]
AA stroke rects batch

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/68c7b6aa98816badbbb69ef65a84a932b8dd58f3

Committed: https://skia.googlesource.com/skia/+/b0fb935bd544b0c6f68c692c7e1ee40876184a1a

Review URL: https://codereview.chromium.org/912483004

9 years agoSplit out methods in GrGpuResource::CacheAccess that can be called outside of the...
bsalomon [Fri, 13 Feb 2015 22:20:05 +0000 (14:20 -0800)]
Split out methods in GrGpuResource::CacheAccess that can be called outside of the cache.

Review URL: https://codereview.chromium.org/923143002

9 years agoYUV scale fix
sugoi [Fri, 13 Feb 2015 21:57:09 +0000 (13:57 -0800)]
YUV scale fix

There was a scaling mistake visible in some JPEG images because the ratio between Y, U and V planes were assumed to be the same ratios as the ratio between texture sizes, which was wrong because texture have a minimum size of 16 and are rounded up to the next POT. Since the ratios between Y and UV planes are generally 1, 2 or 4, rounding up to the next POT would generally preserve this ratio, so that this bug was not very visible, apart from very small jpeg images of 8 or less pixels in either width or height.

BUG=457954

Committed: https://skia.googlesource.com/skia/+/e6eddf7dd85add7da41f22f2643bdd573ad1f1cf

Review URL: https://codereview.chromium.org/922273002

9 years agoStop lieing about GrBatch color for Rects
joshualitt [Fri, 13 Feb 2015 20:50:09 +0000 (12:50 -0800)]
Stop lieing about GrBatch color for Rects

BUG=skia:

Review URL: https://codereview.chromium.org/920423003

9 years agoFix conversion from enum to bool error.
scroggo [Fri, 13 Feb 2015 20:45:52 +0000 (12:45 -0800)]
Fix conversion from enum to bool error.

Needed for the DEPS roll.

TBR=jvanverth@google.com

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/921293002

9 years agoDetermine whether we can tweakAlphaForCoverage during Pipeline/XP creation.
egdaniel [Fri, 13 Feb 2015 20:11:00 +0000 (12:11 -0800)]
Determine whether we can tweakAlphaForCoverage during Pipeline/XP creation.

BUG=skia:

Review URL: https://codereview.chromium.org/927623002

9 years agoRevert of YUV scale fix (patchset #2 id:20001 of https://codereview.chromium.org...
jvanverth [Fri, 13 Feb 2015 20:02:22 +0000 (12:02 -0800)]
Revert of YUV scale fix (patchset #2 id:20001 of https://codereview.chromium.org/922273002/)

Reason for revert:
Turning Windows compile bots red.

Original issue's description:
> YUV scale fix
>
> There was a scaling mistake visible in some JPEG images because the ratio between Y, U and V planes were assumed to be the same ratios as the ratio between texture sizes, which was wrong because texture have a minimum size of 16 and are rounded up to the next POT. Since the ratios between Y and UV planes are generally 1, 2 or 4, rounding up to the next POT would generally preserve this ratio, so that this bug was not very visible, apart from very small jpeg images of 8 or less pixels in either width or height.
>
> BUG=457954
>
> Committed: https://skia.googlesource.com/skia/+/e6eddf7dd85add7da41f22f2643bdd573ad1f1cf

TBR=bsalomon@google.com,sugoi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=457954

Review URL: https://codereview.chromium.org/926123002

9 years agoFontFamily SkTArrays can be moved.
bungeman [Fri, 13 Feb 2015 19:49:07 +0000 (11:49 -0800)]
FontFamily SkTArrays can be moved.

The FontFamily type in SkFontConfigParser_android.h contains two fields
of type SkTArray. Both of these contain types which can be moved
instead of calling constructors and destructors on resize. This change
avoids a number of unneeded SkString refs and unrefs.

Review URL: https://codereview.chromium.org/929473002

9 years agoYUV scale fix
sugoi [Fri, 13 Feb 2015 19:47:11 +0000 (11:47 -0800)]
YUV scale fix

There was a scaling mistake visible in some JPEG images because the ratio between Y, U and V planes were assumed to be the same ratios as the ratio between texture sizes, which was wrong because texture have a minimum size of 16 and are rounded up to the next POT. Since the ratios between Y and UV planes are generally 1, 2 or 4, rounding up to the next POT would generally preserve this ratio, so that this bug was not very visible, apart from very small jpeg images of 8 or less pixels in either width or height.

BUG=457954

Review URL: https://codereview.chromium.org/922273002

9 years agoMake SkImageGenerator::getPixels() return an enum.
scroggo [Fri, 13 Feb 2015 19:13:34 +0000 (11:13 -0800)]
Make SkImageGenerator::getPixels() return an enum.

The new enum describes the nature of the failure. This is in
preparation for writing a replacement for SkImageDecoder, which will
use this interface.

Update the comments for getPixels() to specify what it means to pass
an SkImageInfo with a different size.

Make SkImageGenerator Noncopyable.

Leave onGetYUV8Planes alone, since we have separate discussions
regarding modifying that API.

Make callers of SkImageDecoder consistently handle kPartialSuccess.
Previously, some callers considered it a failure, and others considered
it a success.

BUG=skia:3257

Review URL: https://codereview.chromium.org/919693002

9 years agoRemove SkPictureFlat.h include from SkDrawCommands.h
robertphillips [Fri, 13 Feb 2015 19:13:00 +0000 (11:13 -0800)]
Remove SkPictureFlat.h include from SkDrawCommands.h

This cannot land until https://codereview.chromium.org/909353004/ (Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes) lands in Chromium

Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976

Committed: https://skia.googlesource.com/skia/+/fa3a83d0fe53907e618346d3f1c17a95da1a9d22

Review URL: https://codereview.chromium.org/912403004

9 years agoAdd a templated priority queue class.
bsalomon [Fri, 13 Feb 2015 19:08:21 +0000 (11:08 -0800)]
Add a templated priority queue class.

Review URL: https://codereview.chromium.org/914003004

9 years agoRevert of Use dst copies in porter duffer XP to correctly render certain blends....
egdaniel [Fri, 13 Feb 2015 19:07:54 +0000 (11:07 -0800)]
Revert of Use dst copies in porter duffer XP to correctly render certain blends. (patchset #4 id:60001 of https://codereview.chromium.org/914003003/)

Reason for revert:
Failing GLProgramTest passing in stupid coeffs

Original issue's description:
> Use dst copies in porter duffer XP to correctly render certain blends.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/997c6358d94e188b1a7b89a4f86e24cbe0f5a164

TBR=bsalomon@google.com,joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/923153003

9 years agoUse dst copies in porter duffer XP to correctly render certain blends.
egdaniel [Fri, 13 Feb 2015 18:23:19 +0000 (10:23 -0800)]
Use dst copies in porter duffer XP to correctly render certain blends.

BUG=skia:

Review URL: https://codereview.chromium.org/914003003

9 years agoFix leak in ComposedImageFilterOffset test
ajuma [Fri, 13 Feb 2015 18:15:46 +0000 (10:15 -0800)]
Fix leak in ComposedImageFilterOffset test

This fixes a leak in the ComposedImageFilterOffset test that was
introduced in https://codereview.chromium.org/908273002/.

BUG=chromium:453924

Review URL: https://codereview.chromium.org/922063005

9 years agoFix SkComposeImageFilter's bounds computation and offset handling
ajuma [Fri, 13 Feb 2015 17:05:47 +0000 (09:05 -0800)]
Fix SkComposeImageFilter's bounds computation and offset handling

This makes SkComposeImageFilter::computeFastBounds compose its
filters' bounds (rather than falling back to
SkImageFilter::computeFastBounds, which takes the union of the bounds).

This also makes SkComposeImageFilter::onFilterImage correctly handle
an offset produced when applying the inner filter; such offsets were
previously ignored.

BUG=chromium:453924

Review URL: https://codereview.chromium.org/908273002

9 years agoAdding new benchmark to test image decoding performance.
msarett [Fri, 13 Feb 2015 17:05:41 +0000 (09:05 -0800)]
Adding new benchmark to test image decoding performance.

BUG=skia:

Review URL: https://codereview.chromium.org/918673002

9 years agoLimit clear as draw workaround to Adreno 3xx.
bsalomon [Fri, 13 Feb 2015 17:00:39 +0000 (09:00 -0800)]
Limit clear as draw workaround to Adreno 3xx.

This causes more problems than it fixes on the Nexus 6.

Review URL: https://codereview.chromium.org/917313005

9 years agoPass in ProcOptInfos into willNeedDstCopy on XPs
egdaniel [Fri, 13 Feb 2015 17:00:33 +0000 (09:00 -0800)]
Pass in ProcOptInfos into willNeedDstCopy on XPs

BUG=skia:

Review URL: https://codereview.chromium.org/912413002

9 years ago[SkSVGDevice] Full font family support
fmalita [Fri, 13 Feb 2015 16:55:24 +0000 (08:55 -0800)]
[SkSVGDevice] Full font family support

Use a family name iterator and list all names instead of just one
returned by SkTypeface::getFamilyName().

R=reed@google.com,mtklein@google.com

Review URL: https://codereview.chromium.org/923583002

9 years agoVerify all parsed test font files start with cap.
bungeman [Fri, 13 Feb 2015 16:55:16 +0000 (08:55 -0800)]
Verify all parsed test font files start with cap.

All of the Android test font configuration files have file names which
start with a capital latin letter. Verify this is true of the parsed file
names. This would have caught previous issues with slicing, and will
hopefully prevent such issues going unnoticed in the future.

Review URL: https://codereview.chromium.org/925933003

9 years agointerpret conic tolerance correctly -- big rebaseline
reed [Fri, 13 Feb 2015 01:56:21 +0000 (17:56 -0800)]
interpret conic tolerance correctly -- big rebaseline

need this to land in chrome
https://codereview.chromium.org/918233002/

NOTREECHECKS=True

Review URL: https://codereview.chromium.org/915103002

9 years agoMinimize SkTHash object copying
fmalita [Fri, 13 Feb 2015 01:32:49 +0000 (17:32 -0800)]
Minimize SkTHash object copying

AKA ref-constify the world.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/919193002

9 years agoRevert of I cannot remember what the race here actually was. (patchset #1 id:1 of...
mtklein [Thu, 12 Feb 2015 23:32:07 +0000 (15:32 -0800)]
Revert of I cannot remember what the race here actually was. (patchset #1 id:1 of https://codereview.chromium.org/922873002/)

Reason for revert:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN/builds/1557/steps/dm/logs/stdio

Original issue's description:
> I cannot remember what the race here actually was.
>
> Removing SkTRacy will show us, or perhaps show us we already fixed the race.
>
> BUG=chromium:437511
>
> No public API changes.
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/71409c83e69b387b3c5d567197d0421c36baf68d

TBR=bungeman@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:437511

Review URL: https://codereview.chromium.org/923543003

9 years agoI cannot remember what the race here actually was.
mtklein [Thu, 12 Feb 2015 23:24:51 +0000 (15:24 -0800)]
I cannot remember what the race here actually was.

Removing SkTRacy will show us, or perhaps show us we already fixed the race.

BUG=chromium:437511

No public API changes.
TBR=reed@google.com

Review URL: https://codereview.chromium.org/922873002

9 years agoRevert of AA stroke rects batch (patchset #6 id:100001 of https://codereview.chromium...
joshualitt [Thu, 12 Feb 2015 23:03:49 +0000 (15:03 -0800)]
Revert of AA stroke rects batch (patchset #6 id:100001 of https://codereview.chromium.org/912483004/)

Reason for revert:
breaks in debug nanobench

Original issue's description:
> AA stroke rects batch
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/68c7b6aa98816badbbb69ef65a84a932b8dd58f3
>
> Committed: https://skia.googlesource.com/skia/+/b0fb935bd544b0c6f68c692c7e1ee40876184a1a

TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/924533004

9 years agofix for uniform view matrix being uploaded but not used
joshualitt [Thu, 12 Feb 2015 22:48:42 +0000 (14:48 -0800)]
fix for uniform view matrix being uploaded but not used

As discussed, I'll follow this up by removing localmatrix/uniform view matrix from the base classe

BUG=skia:

Review URL: https://codereview.chromium.org/920933002

9 years agoA simple change to move a bunch of stuff out of Gr*Geometry.h
joshualitt [Thu, 12 Feb 2015 22:20:52 +0000 (14:20 -0800)]
A simple change to move a bunch of stuff out of Gr*Geometry.h

BUG=skia:

Review URL: https://codereview.chromium.org/920863002

9 years agoAA stroke rects batch
joshualitt [Thu, 12 Feb 2015 22:18:47 +0000 (14:18 -0800)]
AA stroke rects batch

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/68c7b6aa98816badbbb69ef65a84a932b8dd58f3

Review URL: https://codereview.chromium.org/912483004

9 years ago[PDF] Fix shader fallback mapping when clipped
fmalita [Thu, 12 Feb 2015 21:56:50 +0000 (13:56 -0800)]
[PDF] Fix shader fallback mapping when clipped

The bounding box used for our pattern sizing is in device coordinates,
but SkPDFImageShader::Create() runs it through the inverse CTM to map
into shader space (with a notable effect of vertical flipping).

In order not to implode, the fallback shader path needs to compute its
adjustments in a consistent space.

BUG=skia:3398, chromium:454591, chromium:455052
R=halcanary@google.com

Review URL: https://codereview.chromium.org/901303003

9 years agofix windows build
Mike Klein [Thu, 12 Feb 2015 21:41:57 +0000 (16:41 -0500)]
fix windows build

BUG=skia:

Review URL: https://codereview.chromium.org/917363002

9 years agooptional res-scale parameter to getFillPath
reed [Thu, 12 Feb 2015 21:35:52 +0000 (13:35 -0800)]
optional res-scale parameter to getFillPath

BUG=skia:
NOTREECHECKS=True
TBR=

Review URL: https://codereview.chromium.org/911053005

9 years agoRevert of Remove SkPictureFlat.h include from SkDrawCommands.h (patchset #3 id:40001...
robertphillips [Thu, 12 Feb 2015 21:29:15 +0000 (13:29 -0800)]
Revert of Remove SkPictureFlat.h include from SkDrawCommands.h (patchset #3 id:40001 of https://codereview.chromium.org/912403004/)

Reason for revert:
Erm - Chrome.

Original issue's description:
> Remove SkPictureFlat.h include from SkDrawCommands.h
>
> This cannot land until https://codereview.chromium.org/909353004/ (Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes) lands in Chromium
>
> Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976
>
> Committed: https://skia.googlesource.com/skia/+/fa3a83d0fe53907e618346d3f1c17a95da1a9d22

TBR=reed@google.com,fmalita@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/923753002

9 years agoStop adding mssse3 & m32/m64 for Android framework.
scroggo [Thu, 12 Feb 2015 21:27:40 +0000 (13:27 -0800)]
Stop adding mssse3 & m32/m64 for Android framework.

BUG=skia:3423

Review URL: https://codereview.chromium.org/920703005

9 years agoSpin off SkTHashTable, SkTHashMap, SkTHashSet
mtklein [Thu, 12 Feb 2015 21:20:08 +0000 (13:20 -0800)]
Spin off SkTHashTable, SkTHashMap, SkTHashSet

SkTHashTable is very similar to SkTDynamicHash, except it's generalized to support non-pointer value types.

It doesn't support remove(), just to keep things simple (it's not hard to add).
Instead of an iterator, it has foreach(), again, to keep things simple.

SkTHashMap<K,V> and SkTHashSet<T> build a friendlier experience on top of SkTHashTable.

BUG=skia:

Review URL: https://codereview.chromium.org/925613002

9 years agoRevert of AA stroke rects batch (patchset #5 id:80001 of https://codereview.chromium...
joshualitt [Thu, 12 Feb 2015 21:02:57 +0000 (13:02 -0800)]
Revert of AA stroke rects batch (patchset #5 id:80001 of https://codereview.chromium.org/912483004/)

Reason for revert:
breaks windows

Original issue's description:
> AA stroke rects batch
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/68c7b6aa98816badbbb69ef65a84a932b8dd58f3

TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/921923002

9 years agoRevert of fix for windows bot (patchset #1 id:1 of https://codereview.chromium.org...
joshualitt [Thu, 12 Feb 2015 21:01:52 +0000 (13:01 -0800)]
Revert of fix for windows bot (patchset #1 id:1 of https://codereview.chromium.org/917933005/)

Reason for revert:
breaks windows

Original issue's description:
> fix for windows bot
>
> TBR=
> NOTREECHECKS=True
> NOTRY=True
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c43a4d868ad93666daf35641e63c70534013a488

TBR=joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/918303003

9 years agofix for windows bot
joshualitt [Thu, 12 Feb 2015 20:57:53 +0000 (12:57 -0800)]
fix for windows bot

TBR=
NOTREECHECKS=True
NOTRY=True
BUG=skia:

Review URL: https://codereview.chromium.org/917933005

9 years agoAA stroke rects batch
joshualitt [Thu, 12 Feb 2015 20:32:26 +0000 (12:32 -0800)]
AA stroke rects batch

BUG=skia:

Review URL: https://codereview.chromium.org/912483004

9 years agoRemove SkPictureFlat.h include from SkDrawCommands.h
robertphillips [Thu, 12 Feb 2015 20:30:42 +0000 (12:30 -0800)]
Remove SkPictureFlat.h include from SkDrawCommands.h

This cannot land until https://codereview.chromium.org/909353004/ (Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes) lands in Chromium

Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976

Review URL: https://codereview.chromium.org/912403004

9 years agoExpose SkPathRef::unique through SkPath.
djsollen [Thu, 12 Feb 2015 20:08:40 +0000 (12:08 -0800)]
Expose SkPathRef::unique through SkPath.

This allows for the removal of SkPath::mSourcePath on Android
as they now have a better indicator of whether or not the path
can be used again via the Java API.

Review URL: https://codereview.chromium.org/913413004

9 years agoset skia_arch_type in nacl_make
mtklein [Thu, 12 Feb 2015 19:34:09 +0000 (11:34 -0800)]
set skia_arch_type in nacl_make

BUG=skia:

Review URL: https://codereview.chromium.org/914413003

9 years agoDon't use m32 cflag for x86_64.
scroggo [Thu, 12 Feb 2015 18:48:25 +0000 (10:48 -0800)]
Don't use m32 cflag for x86_64.

When checking the skia_arch_type for "x86", instead of doing an
== compare, check if "x86" in skia_arch_type, so it will cover
both x86 and x86_64.

Except when we specifically want x86.

Set skia_arch_width based on "64" in skia_arch_type. No need to specify
in scripts.

In gyp_to_android.py, create a separate var_dict for x86_64.

BUG=skia:3419

Review URL: https://codereview.chromium.org/916113002

9 years agoGenerated makefile now includes people to contact.
scroggo [Thu, 12 Feb 2015 16:20:40 +0000 (08:20 -0800)]
Generated makefile now includes people to contact.

Review URL: https://codereview.chromium.org/917913004

9 years agoDM: document -r
mtklein [Thu, 12 Feb 2015 15:34:27 +0000 (07:34 -0800)]
DM: document -r

https://skia.org/dev/contrib/testing?cl=923543002

BUG=skia:

Review URL: https://codereview.chromium.org/923543002

9 years agoMove SkOSFile::Iter impls into ports.
bungeman [Thu, 12 Feb 2015 15:18:27 +0000 (07:18 -0800)]
Move SkOSFile::Iter impls into ports.

This was one large ifdef in SkOSFile.cpp in utils.
This moves the code to existing ports files.

Review URL: https://codereview.chromium.org/920593002

9 years agoAdd staging for Chromium
robertphillips [Thu, 12 Feb 2015 14:37:12 +0000 (06:37 -0800)]
Add staging for Chromium

This staging is needed to land https://codereview.chromium.org/912403004/ (Remove SkPictureFlat.h include from SkDrawCommands.h)

Review URL: https://codereview.chromium.org/916983002

9 years agofix for xoom
joshualitt [Thu, 12 Feb 2015 01:36:30 +0000 (17:36 -0800)]
fix for xoom

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/918833003

9 years agoMake null GL context use callback to make current
bsalomon [Wed, 11 Feb 2015 22:19:18 +0000 (14:19 -0800)]
Make null GL context use callback to make current

Review URL: https://codereview.chromium.org/919783002

9 years agoGMs now use batch
joshualitt [Wed, 11 Feb 2015 21:45:50 +0000 (13:45 -0800)]
GMs now use batch

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/3f284d7758d7f35b59d93a22d126f7cd8423be44

Review URL: https://codereview.chromium.org/865313004

9 years agoRevert of Fix Chromium build (patchset #2 id:20001 of https://codereview.chromium...
robertphillips [Wed, 11 Feb 2015 21:18:14 +0000 (13:18 -0800)]
Revert of Fix Chromium build (patchset #2 id:20001 of https://codereview.chromium.org/916763003/)

Reason for revert:
Chrome

Original issue's description:
> Fix Chromium build
>
> TBR=jvanverth@google.com
>
> Committed: https://skia.googlesource.com/skia/+/f5e89c8f685ac8a5c4d117e087b4111d613106db

TBR=jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/916963002

9 years agoRevert of Fix Chromium build (again) (patchset #2 id:20001 of https://codereview...
robertphillips [Wed, 11 Feb 2015 21:15:12 +0000 (13:15 -0800)]
Revert of Fix Chromium build (again) (patchset #2 id:20001 of https://codereview.chromium.org/916193002/)

Reason for revert:
Chrome

Original issue's description:
> Fix Chromium build (again)
>
> TBR=jvanverth@google.com
>
> Committed: https://skia.googlesource.com/skia/+/b48e08e03a7573c6917d9932a60af5822c009abd

TBR=jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/920573002

9 years agoRevert of Remove SkPictureFlat.h include from SkDrawCommands.h (patchset #2 id:20001...
robertphillips [Wed, 11 Feb 2015 21:07:12 +0000 (13:07 -0800)]
Revert of Remove SkPictureFlat.h include from SkDrawCommands.h (patchset #2 id:20001 of https://codereview.chromium.org/912403004/)

Reason for revert:
Chrome

Original issue's description:
> Remove SkPictureFlat.h include from SkDrawCommands.h
>
> Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976

TBR=reed@google.com,fmalita@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/917933002

9 years agoRevert of GMs now use batch (patchset #3 id:40001 of https://codereview.chromium...
joshualitt [Wed, 11 Feb 2015 21:03:15 +0000 (13:03 -0800)]
Revert of GMs now use batch (patchset #3 id:40001 of https://codereview.chromium.org/865313004/)

Reason for revert:
missing hairlines on gms

Original issue's description:
> GMs now use batch
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/3f284d7758d7f35b59d93a22d126f7cd8423be44

TBR=bsalomon@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/913153003

9 years agoFix Chromium build (again)
robertphillips [Wed, 11 Feb 2015 20:52:08 +0000 (12:52 -0800)]
Fix Chromium build (again)

TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/916193002

9 years agoAdd GrGLCreateNullInterface.cpp back to gyp, and put contents in namespace.
bsalomon [Wed, 11 Feb 2015 20:07:31 +0000 (12:07 -0800)]
Add GrGLCreateNullInterface.cpp back to gyp, and put contents in namespace.

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/899803004