platform/upstream/freerdp.git
3 years agoFix color fidelity issues with windows 7
Armin Novak [Wed, 13 Jan 2021 15:09:07 +0000 (16:09 +0100)]
Fix color fidelity issues with windows 7

(cherry picked from commit 57b58df80644f142067a489640edc40f006329a7)

3 years agoFixed problematic cast of integer mask to bool
Armin Novak [Wed, 13 Jan 2021 10:52:24 +0000 (11:52 +0100)]
Fixed problematic cast of integer mask to bool

(cherry picked from commit 8c353e9292f18e938b21f3369ba86d0f71359815)

3 years agoprimitives: Respect alpha values in YUV444 SSE pixel routine
Martin Fleisz [Mon, 11 Jan 2021 12:22:28 +0000 (13:22 +0100)]
primitives: Respect alpha values in YUV444 SSE pixel routine

(cherry picked from commit 9eaa820818571d23bd8604fbbc1ff9fa7c634967)

3 years agocore: Remove error code from string returned by rpc_error_to_string
Martin Fleisz [Thu, 7 Jan 2021 15:28:34 +0000 (16:28 +0100)]
core: Remove error code from string returned by rpc_error_to_string

This PR removes the error code from the error string returned by
rpc_error_to_string. The error code is passed into the function so it is
not necessary to append it to the returned string as well.

The PR also fixes the screwed formatting of the error code tables.

(cherry picked from commit c78566d2a239648087949dc4ae58e18093f8bf6c)

3 years agowinpr/clipboard: Also save lastWriteTime for FILEDESCRIPTORW
Pascal Nowack [Wed, 30 Dec 2020 01:17:43 +0000 (02:17 +0100)]
winpr/clipboard: Also save lastWriteTime for FILEDESCRIPTORW

Currently, when a local uri-list is converted into a FILEDESCRIPTORW
list, WinPR doesn't submit the last write time for each file.
The result of this is that the last write time of each file on the
other peer will have the current time and not the actual last write
time that is present on the peer, where the files were copied from.

Fix this by also writing the last write time in addition to the
FD_WRITESTIME flag.

(cherry picked from commit 9ba614a1e3314d9d3daa6e461e7d360c67c8d000)

3 years agox11: use correct contact flag names in xf_input_touch_state_string
kubistika [Sun, 27 Dec 2020 15:12:18 +0000 (17:12 +0200)]
x11: use correct contact flag names in xf_input_touch_state_string

(cherry picked from commit a94fe816a4dce96a26cd2ef284f525181d75c865)

3 years agoFix parsing of current keyboard locale
Martin Fleisz [Wed, 23 Dec 2020 13:44:31 +0000 (14:44 +0100)]
Fix parsing of current keyboard locale

(cherry picked from commit 2e59baa33c23cbd0e0ef6e432d8ef202caa34303)

3 years agoFixed definition of FILEDESCRIPTORW
akallabeth [Tue, 22 Sep 2020 10:58:41 +0000 (12:58 +0200)]
Fixed definition of FILEDESCRIPTORW

(cherry picked from commit 33df98f204ad72a34c1d0bb32859e3b8c030af7d)

3 years agoMerge pull request #6623 from akallabeth/stable-2.0-backports
Martin Fleisz [Mon, 11 Jan 2021 09:47:45 +0000 (10:47 +0100)]
Merge pull request #6623 from akallabeth/stable-2.0-backports

stable backports

3 years agoMerge pull request #6671 from akallabeth/stable-2.0-progressive
Martin Fleisz [Mon, 11 Jan 2021 09:36:52 +0000 (10:36 +0100)]
Merge pull request #6671 from akallabeth/stable-2.0-progressive

Backported #6670: Progressive decoding of subbanddiff

3 years agoBackported #6670: Progressive decoding of subbanddiff
akallabeth [Tue, 15 Dec 2020 16:00:22 +0000 (17:00 +0100)]
Backported #6670: Progressive decoding of subbanddiff

Properly decode tiles without subbanddiff so connections with
xfreerdp /gfx /v:<foo> work with ogon and the required progressive
codec is correct.

3 years agoFixed #6656: invalid read of proxy port.
akallabeth [Thu, 10 Dec 2020 06:38:13 +0000 (07:38 +0100)]
Fixed #6656: invalid read of proxy port.

(cherry picked from commit 3c237fd687c043d4488113d21292f1103bac9769)

3 years agoMoved clipboard hasHugeFileSupport to end of struct
akallabeth [Fri, 4 Dec 2020 13:09:28 +0000 (14:09 +0100)]
Moved clipboard hasHugeFileSupport to end of struct

(cherry picked from commit 0c96c3a71c1c74fb16131f4fa8266d2ae4d73367)

3 years agoFixed #6632
akallabeth [Thu, 3 Dec 2020 06:22:17 +0000 (07:22 +0100)]
Fixed #6632

(cherry picked from commit ceb0e8b4f1facb58849b2573fe60e3e512879a77)

3 years agoFix for mac mousewheel.
Keith Johnston [Tue, 6 Oct 2020 23:11:36 +0000 (16:11 -0700)]
Fix for mac mousewheel.

(cherry picked from commit 87a4a8484e65ab591ef815ed0700ab0c90994a77)
(cherry picked from commit c0ecee9d69533095bfdb3dbaf9e76747e5e3a7ab)

3 years agoRemoved obsolete connectErrorCode
Armin Novak [Fri, 11 Sep 2020 08:14:14 +0000 (10:14 +0200)]
Removed obsolete connectErrorCode

(cherry picked from commit 3b63903d3fbca0c1b1614aa93ea9ede955da692d)

3 years agoAllow autoreconnect for ERRINFO_GRAPHICS_SUBSYSTEM_FAILED
akallabeth [Thu, 26 Nov 2020 14:38:17 +0000 (15:38 +0100)]
Allow autoreconnect for ERRINFO_GRAPHICS_SUBSYSTEM_FAILED

As discussed in #4717 allow autoreconnect to succeed if that
specific error code was returned as disconnection reason.

(cherry picked from commit 552a7ca25f60e9a00585ec298c816911dcf71383)

3 years agochannels/audin: Request correct media type in audin channel on Mac
Martin Fleisz [Fri, 20 Nov 2020 13:09:37 +0000 (14:09 +0100)]
channels/audin: Request correct media type in audin channel on Mac

(cherry picked from commit 4a952977c17001b3bb8becdeb4547846ca2b392a)

3 years agoAdded permission checks for mac audio backend.
Armin Novak [Mon, 19 Oct 2020 10:08:13 +0000 (12:08 +0200)]
Added permission checks for mac audio backend.

(cherry picked from commit 0e0eb5f41fe5f80385e83132972f9c00cb0b61cb)

3 years agoFixed mac app termination and warnings
Armin Novak [Tue, 20 Oct 2020 07:08:37 +0000 (09:08 +0200)]
Fixed mac app termination and warnings

(cherry picked from commit a2e9f5efcb54a409ca67b2794ab20c391d732fe6)

3 years agoFixed remarks.
akallabeth [Thu, 15 Oct 2020 09:03:29 +0000 (11:03 +0200)]
Fixed remarks.

(cherry picked from commit c0284239a759f47670c164e0f3ae9b29676e07f3)

3 years agonew [orders]: BMF_24BPP support and some comments
Bernhard Miklautz [Wed, 15 Jul 2020 16:04:02 +0000 (18:04 +0200)]
new [orders]: BMF_24BPP support and some comments

* cached brush orders missed the BMF_24BPP documented case
  ([MS-RDPEGDI] 2.2.2.2.1.2.7)
* add some comments on secondary (brush) order details

(cherry picked from commit efdc99528f6fb6d56537a5420bfa8e735219eba0)

3 years agoDisable building OpenH264 in Andriod CI builds
Christian Plattner [Fri, 20 Nov 2020 12:28:16 +0000 (13:28 +0100)]
Disable building OpenH264 in Andriod CI builds

(cherry picked from commit f4b3ba92fc541488a9c1b9e251b42f8ea69ba08c)

3 years agoFix Android release target API level
Christian Plattner [Sun, 15 Nov 2020 09:51:57 +0000 (10:51 +0100)]
Fix Android release target API level

(cherry picked from commit 199e38c9b4df2109e07dfd795a0e7859243003a8)

3 years agoFix Android build paths
Christian Plattner [Sun, 15 Nov 2020 03:38:11 +0000 (04:38 +0100)]
Fix Android build paths

(cherry picked from commit 00173a0ef3a9ad5eb0511f800d910f463bd8bac1)

3 years agoFix #6565: streamline android build configuration
Christian Plattner [Sun, 15 Nov 2020 03:10:41 +0000 (04:10 +0100)]
Fix #6565: streamline android build configuration

(cherry picked from commit 0270932d96b6dd9a6c6c57e6c48eb5081fd122ef)

3 years agoAdded support for xwayland keyboard grab
akallabeth [Tue, 27 Oct 2020 13:17:37 +0000 (14:17 +0100)]
Added support for xwayland keyboard grab

(cherry picked from commit 896b7bc711f9e47620078507074960a68309576b)

3 years agoFix warning #6515
akallabeth [Fri, 16 Oct 2020 06:14:13 +0000 (08:14 +0200)]
Fix warning #6515

(cherry picked from commit 6d8f355633b7381745a55d48301e7f1e17d8efb4)

3 years agoreset codecs in gdi_pipeline_init
kubistika [Tue, 1 Dec 2020 11:35:38 +0000 (13:35 +0200)]
reset codecs in gdi_pipeline_init

(cherry picked from commit 42e63cbf9879048e36cb953fcebc24f3493e9568)

3 years agoremove unwanted log level set to debug in rfx
Fabio Fantoni [Sat, 28 Nov 2020 12:50:42 +0000 (13:50 +0100)]
remove unwanted log level set to debug in rfx

I saw on debian packages (that have -DWITH_DEBUG_ALL=ON) remotefx logs always to
debug without respect log-level and log-filters settings making diffult
debugging of issue on other parts.
After a search I found this that set loglevel to debug that akallabeth confirmed
is unwanted, this patch remove it.

Closes #6606

(cherry picked from commit f3e5ebe315f81f61688b79aa979c8d4ea89f8e87)

3 years agoFixed sound buffering issues with compressed formats
akallabeth [Thu, 26 Nov 2020 13:49:42 +0000 (14:49 +0100)]
Fixed sound buffering issues with compressed formats

(cherry picked from commit d9d22aa42207e4d8e23ec5337bce83f87726cd20)

3 years agoAdded CMake warning messages for expensive debug options
akallabeth [Thu, 26 Nov 2020 13:41:59 +0000 (14:41 +0100)]
Added CMake warning messages for expensive debug options

(cherry picked from commit d82c14c3d8d14e3e05d2b8fc2101043599fbe04f)

3 years agoDisable ios client until maintained.
akallabeth [Thu, 15 Oct 2020 08:23:44 +0000 (10:23 +0200)]
Disable ios client until maintained.

(cherry picked from commit f3c29852498c78b6b74227c8e7cf7fe3f08dc8d2)

3 years agoIncreased minimum ios deployment target.
akallabeth [Thu, 15 Oct 2020 07:49:02 +0000 (09:49 +0200)]
Increased minimum ios deployment target.

(cherry picked from commit a7b210d44854873a3218f987063d66e804b0e9b9)

3 years agoRefactored reading of optional order bytes
akallabeth [Mon, 12 Oct 2020 09:09:10 +0000 (11:09 +0200)]
Refactored reading of optional order bytes

(cherry picked from commit ef8f1fd9f0880bf786a0da3b567a4eb33d2bb230)

3 years agoFixed parsing of FastGlyph order.
akallabeth [Mon, 12 Oct 2020 08:29:30 +0000 (10:29 +0200)]
Fixed parsing of FastGlyph order.

(cherry picked from commit 0456fc307c2c6754f15e37de263f4465ec520975)

3 years agoCorrected clipboard capability mask
akallabeth [Fri, 2 Oct 2020 11:17:00 +0000 (13:17 +0200)]
Corrected clipboard capability mask

(cherry picked from commit e4243bb33cde0549fb04b112066d32545526f3f0)

3 years agoAdded clipboard CB_HUGE_FILE_SUPPORT_ENABLED flag
akallabeth [Tue, 29 Sep 2020 06:22:28 +0000 (08:22 +0200)]
Added clipboard CB_HUGE_FILE_SUPPORT_ENABLED flag

(cherry picked from commit f282c55c7a02caa80a53e88931725efedcae7085)

3 years agoFixes #5747: Only activate sound output device (#6467)
Felix Deimel [Tue, 8 Sep 2020 08:55:49 +0000 (10:55 +0200)]
Fixes #5747: Only activate sound output device (#6467)

* Fixes #5747: Only activate sound output device

(cherry picked from commit 19f74a269837d62dff0b3541aa8108159bc22064)

3 years agoFix #6461: Generate config.h after all subdirectories are parsed.
Armin Novak [Mon, 7 Sep 2020 06:21:16 +0000 (08:21 +0200)]
Fix #6461: Generate config.h after all subdirectories are parsed.

(cherry picked from commit 3310e388034d0271e06c175b78a99abf87011475)

3 years agoUse settings string setter to overwrite computername
akallabeth [Tue, 1 Sep 2020 09:15:44 +0000 (11:15 +0200)]
Use settings string setter to overwrite computername

(cherry picked from commit 4d7cddd7c64c75d824d8a1eb0babcfc71f0df8d4)

3 years agoIgnore NULL streams in StreamPool_Return
Armin Novak [Wed, 2 Sep 2020 08:09:48 +0000 (10:09 +0200)]
Ignore NULL streams in StreamPool_Return

(cherry picked from commit 6351885488c38327b4f59f3686d68ddd8dc0f745)

3 years agoFixed #6442: Use cmake to provide source directory for test pem
akallabeth [Mon, 24 Aug 2020 07:44:41 +0000 (09:44 +0200)]
Fixed #6442: Use cmake to provide source directory for test pem

(cherry picked from commit 70881d39578177d3229f01011f62021b1b069cb5)

3 years agoFixed short length for usb io control return.
akallabeth [Thu, 13 Aug 2020 11:51:38 +0000 (13:51 +0200)]
Fixed short length for usb io control return.

(cherry picked from commit 6f00308db78f27d6daee9a85ff3baec7cd8e8443)

3 years agoManually free up libusb transfer data to avoid double free
Armin Novak [Wed, 12 Aug 2020 08:28:21 +0000 (10:28 +0200)]
Manually free up libusb transfer data to avoid double free

(cherry picked from commit 6ce051759306219c49d4fb39a2bd9cc94c2c5afc)

3 years agoFixed double free on channel close in channel write.
Armin Novak [Wed, 12 Aug 2020 08:10:18 +0000 (10:10 +0200)]
Fixed double free on channel close in channel write.

(cherry picked from commit 81d59b2d47f1a68f4db97e2e4636d93be69892cc)

3 years agoFixed missing async user data extraction from libusb transfer
akallabeth [Tue, 11 Aug 2020 12:12:36 +0000 (14:12 +0200)]
Fixed missing async user data extraction from libusb transfer

(cherry picked from commit 786f6bbfe8ac63eb2e069a7b83b0a49b2a9a664b)

3 years agoFixed urbdrc server notification of channel close
Armin Novak [Mon, 10 Aug 2020 11:30:41 +0000 (13:30 +0200)]
Fixed urbdrc server notification of channel close

There was a recursion issue with usb device channel closing and
local redirected device removal.
If the local redirected device is removed due to hotplug events,
the device channel needs to be closed, which in turn checks if
the local device list contains the device. Ensure that the
channel close code is only executed when not called from the
channel side.

(cherry picked from commit 93ee13245ce7fe78ffbc9694bfac3da30844296a)

3 years agoRemoved channel close in USB channel done after channel is freed
akallabeth [Fri, 10 Jul 2020 08:49:25 +0000 (10:49 +0200)]
Removed channel close in USB channel done after channel is freed

(cherry picked from commit dbeaa614d6e369d3809e04be24f1d6b98e3d9e50)

3 years agoFixed access to user_data after free
akallabeth [Thu, 9 Jul 2020 10:27:17 +0000 (12:27 +0200)]
Fixed access to user_data after free

(cherry picked from commit 8c859575cfb0fc9e35d7b211993174af444ff780)

3 years agoFixed invalid buffer length and duplicated write function.
akallabeth [Thu, 9 Jul 2020 10:20:48 +0000 (12:20 +0200)]
Fixed invalid buffer length and duplicated write function.

(cherry picked from commit 54c92e78e6031d1e075625699e2d677af583716a)

3 years agoFixed urbdrc arraylist locking
akallabeth [Thu, 9 Jul 2020 09:47:06 +0000 (11:47 +0200)]
Fixed urbdrc arraylist locking

(cherry picked from commit e7533130a6bf08959670264e797487b00305e9f7)

3 years agoUnified streamID read/write
Armin Novak [Wed, 8 Jul 2020 16:18:51 +0000 (18:18 +0200)]
Unified streamID read/write

(cherry picked from commit 28bc636d5377b01936e161af9e94438a7e592f1d)

3 years agoReplace wHashTable with wArrayList in USB channel
Armin Novak [Wed, 8 Jul 2020 16:11:05 +0000 (18:11 +0200)]
Replace wHashTable with wArrayList in USB channel

The streamID is not guaranteed to be uniqe, so add all transfers
to a list and remove by checking pointers instead of the streamID

(cherry picked from commit 3ebc71abf3709871ca1609b9c99b7d234000da4a)

3 years agoAdded return checks for HashTable_Add
Armin Novak [Wed, 8 Jul 2020 08:26:34 +0000 (10:26 +0200)]
Added return checks for HashTable_Add

(cherry picked from commit ea8f93441d523e103746dfeceab98420c05e0bac)

3 years agoAdded duplicate initialization check for plugins.
Armin Novak [Mon, 10 Aug 2020 13:36:31 +0000 (15:36 +0200)]
Added duplicate initialization check for plugins.

(cherry picked from commit 75aab487e242f347868bd6c2ad5872d25a7c2c9a)

3 years agoRefactored rdg_read_http_unicode_string warning fixes
Armin Novak [Mon, 10 Aug 2020 14:39:49 +0000 (16:39 +0200)]
Refactored rdg_read_http_unicode_string warning fixes

(cherry picked from commit bfa07e701d25fc936c84ad36d58c6ab1a9a33ec9)

3 years agoRefactored socket warning fixes to be more readable.
Armin Novak [Mon, 10 Aug 2020 14:39:19 +0000 (16:39 +0200)]
Refactored socket warning fixes to be more readable.

(cherry picked from commit 57de0aebb5ee1d3458f74f9a98b99245719aa2f4)

3 years agoFixed warnings.
Armin Novak [Mon, 10 Aug 2020 10:26:46 +0000 (12:26 +0200)]
Fixed warnings.

(cherry picked from commit e50a8e09ee3feba4975c488618f5af350d851ad9)

3 years agoFixed missing input length check for color pointer.
Armin Novak [Mon, 10 Aug 2020 10:26:33 +0000 (12:26 +0200)]
Fixed missing input length check for color pointer.

(cherry picked from commit 47d02a76ce07cbfc655754a1ccfe79a9b6bc9357)

3 years agoFixed compilation warnings.
Armin Novak [Mon, 10 Aug 2020 10:04:02 +0000 (12:04 +0200)]
Fixed compilation warnings.

(cherry picked from commit 57b405ca265966fd3790cb3f30d0b0c073268e7c)

3 years agoFixed #6418: Warning due to invalid const qualifier
Armin Novak [Mon, 10 Aug 2020 09:47:52 +0000 (11:47 +0200)]
Fixed #6418: Warning due to invalid const qualifier

(cherry picked from commit 226b072af82ab7000d26a2bf76ee585098b27875)

3 years agoImprove NLA auth token debugging
Armin Novak [Mon, 10 Aug 2020 14:56:27 +0000 (16:56 +0200)]
Improve NLA auth token debugging

(cherry picked from commit 10ed4ec42204aa4f56c5a4d82732ced6359f088c)

3 years agoAdded log message for not implemented WinPR SSPI_WINPR functions.
Armin Novak [Mon, 10 Aug 2020 12:59:07 +0000 (14:59 +0200)]
Added log message for not implemented WinPR SSPI_WINPR functions.

(cherry picked from commit a9d9908bdedb8f4f3fbf8956ac96eb06375798e2)

3 years agoAdded log message for not implemented WinPR SSPI functions.
Armin Novak [Mon, 10 Aug 2020 12:57:39 +0000 (14:57 +0200)]
Added log message for not implemented WinPR SSPI functions.

(cherry picked from commit 2686200c3b95d03d5d81be124159fed2be744797)

3 years agoAdded log message for not implemented WinPR SSPI GSS functions.
Armin Novak [Mon, 10 Aug 2020 12:57:27 +0000 (14:57 +0200)]
Added log message for not implemented WinPR SSPI GSS functions.

(cherry picked from commit ef791456e3281aee75ac736f66b7444c9e12ca7b)

3 years agoAdded log message for not implemented Schannel functions.
Armin Novak [Mon, 10 Aug 2020 12:48:51 +0000 (14:48 +0200)]
Added log message for not implemented Schannel functions.

(cherry picked from commit 65819a721577fd997e159b059a3c1fe4c153cdd2)

3 years agoAdded log message for not implemented CREDSSP functions.
Armin Novak [Mon, 10 Aug 2020 12:43:37 +0000 (14:43 +0200)]
Added log message for not implemented CREDSSP functions.

(cherry picked from commit 7837f517e5771a33b4bd00cdf948706ae3d8aa55)

3 years agoAdded log message for not implemented NEGOTIATE functions.
Armin Novak [Mon, 10 Aug 2020 12:42:05 +0000 (14:42 +0200)]
Added log message for not implemented NEGOTIATE functions.

(cherry picked from commit 7d0e54e5f8d8009f8c5655b45dccdf425b9ac8d6)

3 years agoAdded log message for not implemented NTLM functions.
Armin Novak [Mon, 10 Aug 2020 12:41:20 +0000 (14:41 +0200)]
Added log message for not implemented NTLM functions.

(cherry picked from commit 58f471c7d9fa1ffcb03198ac919a05e1f13aee03)

3 years agoImprove NLA error code logging.
Armin Novak [Mon, 10 Aug 2020 12:35:40 +0000 (14:35 +0200)]
Improve NLA error code logging.

(cherry picked from commit 32c9a519dfec5ee7c7bf815298c9650e5a7aabff)

4 years agoMerge pull request #6405 from akallabeth/an-stable-2.0
Martin Fleisz [Wed, 5 Aug 2020 10:21:48 +0000 (12:21 +0200)]
Merge pull request #6405 from akallabeth/an-stable-2.0

stable 2.0 backports

4 years agoUse freerdp_settings_[s|g]et* api to access proxy vaiables.
akallabeth [Tue, 4 Aug 2020 06:49:46 +0000 (08:49 +0200)]
Use freerdp_settings_[s|g]et* api to access proxy vaiables.

Fixes #6414

(cherry picked from commit 44ea09e7ad0123b8486428c1ceaeeb96b5c01d35)

4 years agoAdd GatewayMessageType to public API
Martin Fleisz [Tue, 4 Aug 2020 07:11:41 +0000 (09:11 +0200)]
Add GatewayMessageType to public API

(cherry picked from commit 174f3257c9213e77663020d0b8a41220889848fd)

4 years agoImplement gateway message callback for Windows, Wayland and X11 clients
Martin Fleisz [Mon, 3 Aug 2020 10:06:08 +0000 (12:06 +0200)]
Implement gateway message callback for Windows, Wayland and X11 clients

(cherry picked from commit 2fe8e762d2b6765b486513159d18ffd98e267873)

4 years agogateway: Add processing of consent and service messages with HTTP gateway
Martin Fleisz [Thu, 30 Jul 2020 13:22:40 +0000 (15:22 +0200)]
gateway: Add processing of consent and service messages with HTTP gateway

(cherry picked from commit 130494e34a26d0b7065a2daddb56dd7b63241647)

4 years agoclang-format
Gluzskiy Alexandr [Mon, 27 Jul 2020 07:34:40 +0000 (10:34 +0300)]
clang-format

(cherry picked from commit 481f3b32f6f0fd7fdc304e192f5661e2fa2e4aa9)

4 years agofixed build on freebsd
Gluzskiy Alexandr [Mon, 27 Jul 2020 06:01:35 +0000 (09:01 +0300)]
fixed build on freebsd

(cherry picked from commit 3bb5d57b70896dd677c8971c4c15dfade529ccd6)

4 years agoAdd support for getmntent support on Illumos
Marco van Wieringen [Thu, 23 Jul 2020 11:22:34 +0000 (13:22 +0200)]
Add support for getmntent support on Illumos

This implements reading mount entries on Solarish operating systems like
OpenIndiana etc using the somewhat different getmntent support available
there.

(cherry picked from commit 56260c0cdb24fb7e10e97a70160737c0652090fd)

4 years agoFix #6399: Call ConvertFromUnicode with length -1.
akallabeth [Thu, 30 Jul 2020 14:16:01 +0000 (16:16 +0200)]
Fix #6399: Call ConvertFromUnicode with length -1.

The input string has ensured NULL termination, so let the function
determine the correct length.

(cherry picked from commit 36499527e747283019c21dbc84c5eff0a564e1d8)

4 years agocliprdr_common.c: fix memory leak in certain error condition
Zhu Qun-Ying [Fri, 24 Jul 2020 16:16:18 +0000 (09:16 -0700)]
cliprdr_common.c: fix memory leak in certain error condition

(cherry picked from commit 2b315e8bfa50cbf8adaf64a82307cc7d0dded395)

4 years agoSet BIO data NULL on cleanup
Armin Novak [Thu, 23 Jul 2020 08:48:39 +0000 (10:48 +0200)]
Set BIO data NULL on cleanup

Recursive BIO free could double free, if the BIO data is not set
NULL when removed.

(cherry picked from commit 76d10561bbf24b82df43771e93a1692790c3dbbc)

4 years agoMerge pull request #6382 from bmiklautz/release_220 2.2.0
Martin Fleisz [Mon, 20 Jul 2020 13:38:46 +0000 (15:38 +0200)]
Merge pull request #6382 from bmiklautz/release_220

FreeRDP security and version 2.2.0 release

4 years agonew: Changelog for 2.2.0
Bernhard Miklautz [Mon, 20 Jul 2020 12:21:59 +0000 (14:21 +0200)]
new: Changelog for 2.2.0

4 years agocore: fix invalid inttype and reference
Norbert Federa [Mon, 20 Jul 2020 11:18:45 +0000 (13:18 +0200)]
core: fix invalid inttype and reference

The error message in tpdu_read_header() printed the pointer address and
used PRIu16 for an UINT8 type

(cherry picked from commit 54fdf7947d4d35589dab9ec3e37839606ffcc985)

Fixes #6380

4 years agoFixed missing input sanitation for GFX surfaces.
akallabeth [Fri, 3 Jul 2020 08:29:13 +0000 (10:29 +0200)]
Fixed missing input sanitation for GFX surfaces.

Thanks to Sunglin and HuanGMz of the Knownsec 404 security team and pangzi of pwnzen

(cherry picked from commit 5592cb2e10da42592af98f5533d2e42181e86821)

4 years agoFixed input sanitation in rdpgfx_recv_solid_fill_pdu
akallabeth [Fri, 3 Jul 2020 08:26:38 +0000 (10:26 +0200)]
Fixed input sanitation in rdpgfx_recv_solid_fill_pdu

The input rectangle must be checked for plausibility.

Thanks to Sunglin and HuanGMz of the Knownsec 404 security team and pangzi of pwnzen

(cherry picked from commit d862a03cbf88ec6e76e47b84eae7e214690cb607)

4 years agoFix seeking in Cache Brush and other Secondary Drawing Orders
Giovanni Panozzo [Tue, 14 Jul 2020 22:08:15 +0000 (00:08 +0200)]
Fix seeking in Cache Brush and other Secondary Drawing Orders

(cherry picked from commit 9f7e475c1652c2b1e30e0406ec0bc7ea3f2330ff)

Fixes #6374

4 years agoMerge pull request #6319 from akallabeth/stable-2.0-backports3
Bernhard Miklautz [Wed, 15 Jul 2020 14:42:24 +0000 (16:42 +0200)]
Merge pull request #6319 from akallabeth/stable-2.0-backports3

Stable 2 backports from master

4 years agoserver: proxy: add extern C for c++ plugins
Kobi Mizrachi [Wed, 8 Jul 2020 08:53:26 +0000 (11:53 +0300)]
server: proxy: add extern C for c++ plugins

(cherry picked from commit 755d20501bac9c935a88d0ba040a4410681c1aa7)

4 years agoserver: proxy: rail: Fix rail handshake flags sync issue at reconnect
Kobi Mizrachi [Tue, 7 Jul 2020 12:31:31 +0000 (15:31 +0300)]
server: proxy: rail: Fix rail handshake flags sync issue at reconnect

(cherry picked from commit cc9ef8f74e59f9351aca84a2a95048a4af274af6)

4 years agorail: server: add API to set railHandshakeExflags
Kobi Mizrachi [Tue, 7 Jul 2020 12:31:20 +0000 (15:31 +0300)]
rail: server: add API to set railHandshakeExflags

(cherry picked from commit 004c2f49e4068270cbd5cfb9f44c015c6fb931ea)

4 years agoserver: proxy: fix race issue
Kobi Mizrachi [Sun, 5 Jul 2020 06:11:56 +0000 (09:11 +0300)]
server: proxy: fix race issue

Proxy server might receive input updates while client side being
redirected (and reset), then a heap-after-free might occur. To solve
this, we register server input/update callbacks only after client is
fully activated.

(cherry picked from commit db0196fd01faa4234a4b2cabadb5f4cb16edeef1)

4 years agoUpdated version information for 2.2.0 release
akallabeth [Tue, 7 Jul 2020 08:56:21 +0000 (10:56 +0200)]
Updated version information for 2.2.0 release

4 years agoFixed urbdrc device path
Armin Novak [Mon, 6 Jul 2020 09:09:14 +0000 (11:09 +0200)]
Fixed urbdrc device path

(cherry picked from commit 63747000982f70bc169ff037bccb1bbcfd697747)

4 years agoFixed bDeviceClass check in udev_init
Armin Novak [Mon, 6 Jul 2020 07:59:15 +0000 (09:59 +0200)]
Fixed bDeviceClass check in udev_init

Use the proper constant  0xef (Miscellaneous) instead of
0xfe (Application Specific)
See https://www.usb.org/defined-class-codes

(cherry picked from commit b97cb4c95dd085142cadf1645505264632d1af21)

4 years agoReplaced malloc in urbdrc channel
akallabeth [Fri, 3 Jul 2020 14:20:12 +0000 (16:20 +0200)]
Replaced malloc in urbdrc channel

(cherry picked from commit 3ae6feeebe8638c3bea76fd270f3fd46ee768ff2)

4 years agoFixed discrepancy in string descriptor default
akallabeth [Fri, 3 Jul 2020 14:04:23 +0000 (16:04 +0200)]
Fixed discrepancy in string descriptor default

(cherry picked from commit 747513d901ae50c8223a5ddd5b447436bb782a66)

4 years agoReplaced memset in urbdrc
akallabeth [Fri, 3 Jul 2020 13:47:53 +0000 (15:47 +0200)]
Replaced memset in urbdrc

(cherry picked from commit e84c3829bf942b28cd6ef4d7cff4d5f8cca8a5f8)

4 years agoUnified logging for urbdrc libusb wrapper
akallabeth [Fri, 3 Jul 2020 13:14:15 +0000 (15:14 +0200)]
Unified logging for urbdrc libusb wrapper

(cherry picked from commit a81001c3a33818561bf0e6193e219b1b3245391d)