platform/upstream/libSkiaSharp.git
10 years agoMove GrInvariantOutput out of GrProcessor and into its own class.
egdaniel [Wed, 12 Nov 2014 16:35:25 +0000 (08:35 -0800)]
Move GrInvariantOutput out of GrProcessor and into its own class.

This will help with the ability to subclass, add to, etc. GrInvariantOutput. Also it was simply
getting a little too big to be a "supporting" subclass
BUG=skia:

Review URL: https://codereview.chromium.org/699943003

10 years agoSk4x_sse.h
mtklein [Wed, 12 Nov 2014 16:32:49 +0000 (08:32 -0800)]
Sk4x_sse.h

BUG=skia:

Review URL: https://codereview.chromium.org/698873003

10 years agoRemove SK_USE_SCALED_FONTMETRICS.
bungeman [Wed, 12 Nov 2014 16:29:15 +0000 (08:29 -0800)]
Remove SK_USE_SCALED_FONTMETRICS.

This define was added in
"SK_USE_SCALED_FONTMETRICS for correct scaling"
c17c6582ec0b7bc211d7de9e8d634692d239c123.
Users all now define this flag, so it may now be removed.

BUG=chromium:420901

Review URL: https://codereview.chromium.org/720743003

10 years agoAdd more tests.
mtklein [Wed, 12 Nov 2014 15:27:01 +0000 (07:27 -0800)]
Add more tests.

BUG=skia:

Review URL: https://codereview.chromium.org/717143003

10 years agoClean up CollectLayers code
robertphillips [Wed, 12 Nov 2014 15:25:02 +0000 (07:25 -0800)]
Clean up CollectLayers code

Now that CollectLayers directly uses FillBounds we can:

skip the explicit intersection with the clipBounds after an adjustAndMap call

skip the storage and use of the clipBounds in SaveLayerInfo

Review URL: https://codereview.chromium.org/719793002

10 years agoMove SkRecordComputeLayers and CollectLayers into SkRecordDraw.cpp
robertphillips [Wed, 12 Nov 2014 14:46:08 +0000 (06:46 -0800)]
Move SkRecordComputeLayers and CollectLayers into SkRecordDraw.cpp

Rather then exposing parts of FillBounds (as in Expose FillBounds to allow GrPictureUtils::CollectLayers to be layered on top of it - https://codereview.chromium.org/698643002/), this CL moves CollectLayers into SkRecordDraw.cpp to accomplish the layering.

Review URL: https://codereview.chromium.org/716913003

10 years agorebase
joshualitt [Wed, 12 Nov 2014 13:44:24 +0000 (05:44 -0800)]
rebase

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/717033002

10 years agoCleanup: Remove submit_try script.
tfarina [Wed, 12 Nov 2014 13:34:47 +0000 (05:34 -0800)]
Cleanup: Remove submit_try script.

It is probably broken, and by now nobody should be using it really
anyway.

BUG=None
R=borenet@google.com

Review URL: https://codereview.chromium.org/720603002

10 years agoexperimental
reed [Wed, 12 Nov 2014 03:36:09 +0000 (19:36 -0800)]
experimental

BUG=skia:

Review URL: https://codereview.chromium.org/716793004

10 years agoClang incorrectly thinks this typedef is unused.
mtklein [Wed, 12 Nov 2014 02:52:02 +0000 (18:52 -0800)]
Clang incorrectly thinks this typedef is unused.

BUG=skia:3059

Review URL: https://codereview.chromium.org/715093003

10 years agoAdd isUnblended query to GrDrawState.
egdaniel [Tue, 11 Nov 2014 22:46:05 +0000 (14:46 -0800)]
Add isUnblended query to GrDrawState.

BUG=skia:

Review URL: https://codereview.chromium.org/715873002

10 years agoAdd GrGpuResource::CacheAccess
bsalomon [Tue, 11 Nov 2014 22:15:57 +0000 (14:15 -0800)]
Add GrGpuResource::CacheAccess

Internal only helper class for manipulating and accessing cache keys.

BUG=skia:2889

Review URL: https://codereview.chromium.org/703303003

10 years agoRevert of Move from libstlport to libc++ for Android framework builds (patchset ...
scroggo [Tue, 11 Nov 2014 21:58:44 +0000 (13:58 -0800)]
Revert of Move from libstlport to libc++ for Android framework builds (patchset #1 id:1 of https://codereview.chromium.org/714113002/)

Reason for revert:
The code this depends on is not ready yet. We can submit once https://android-review.googlesource.com/#/c/113924/ is submitted.

Original issue's description:
> Move from libstlport to libc++ for Android framework builds
>
> Committed: https://skia.googlesource.com/skia/+/ce259510a738fab05a0d456440104f5aba1c9d72

TBR=tomhudson@google.com,djsollen@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/718793003

10 years agoRemove coverage from grpaint
joshualitt [Tue, 11 Nov 2014 21:46:30 +0000 (13:46 -0800)]
Remove coverage from grpaint

BUG=skia:

Review URL: https://codereview.chromium.org/683133006

10 years agonotice null colorfilter in legacy unflattening
reed [Tue, 11 Nov 2014 21:13:35 +0000 (13:13 -0800)]
notice null colorfilter in legacy unflattening

BUG=skia:3117

Review URL: https://codereview.chromium.org/691383003

10 years agomodify nothingToDraw to notice filters
reed [Tue, 11 Nov 2014 20:51:33 +0000 (12:51 -0800)]
modify nothingToDraw to notice filters

This reverts commit c71ffd4e76d1abcd28ac74463349970f60a3350f.

TBR=

Review URL: https://codereview.chromium.org/683003003

10 years agoFix "Add support for rebaselining from trybots."
bungeman [Tue, 11 Nov 2014 20:28:02 +0000 (15:28 -0500)]
Fix "Add support for rebaselining from trybots."

Commit d09ade4b44edc11 was missing a needed edit.

10 years agoRevert of modify nothingToDraw to notice filters (patchset #1 id:1 of https://coderev...
mtklein [Tue, 11 Nov 2014 20:13:16 +0000 (12:13 -0800)]
Revert of modify nothingToDraw to notice filters (patchset #1 id:1 of https://codereview.chromium.org/717753002/)

Reason for revert:
modecolorfilters, perhaps more changed

Original issue's description:
> modify nothingToDraw to notice filters
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/d5688c509293a450c058e0cc1f4673be2931bb5c

TBR=djsollen@google.com,reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/717813002

10 years agomodify nothingToDraw to notice filters
reed [Tue, 11 Nov 2014 19:00:55 +0000 (11:00 -0800)]
modify nothingToDraw to notice filters

BUG=skia:

Review URL: https://codereview.chromium.org/717753002

10 years agoAdd benchmark to compare different BBH query patterns.
mtklein [Tue, 11 Nov 2014 18:39:27 +0000 (10:39 -0800)]
Add benchmark to compare different BBH query patterns.

On my laptop:
maxrss loops min median mean max stddev samples    config bench
  37M 1 14ms 14.2ms 14.6ms 18.2ms 9% ▁█▁▁▁▁▂▂▂▁ gpu tiled_playback_tilegrid_tiled
  40M 1 17ms 17.2ms 17.2ms 17.6ms 1% ▆▃▁█▄▇▂▁▁▁ gpu tiled_playback_tilegrid_random
  40M 1 14.6ms 14.9ms 15.8ms 19.1ms 11% ▂▁▁▁▁▁▁█▅█ gpu tiled_playback_rtree_tiled
  43M 1 16.5ms 16.7ms 16.8ms 17.4ms 1% ▂▃▅█▃▂▁▃▃▂ gpu tiled_playback_rtree_random
  43M 1 15.9ms 16.1ms 16.5ms 18.7ms 6% ▁▁█▇▁▁▁▂▁▁ gpu tiled_playback_none_tiled
  44M 1 17.9ms 17.9ms 18ms 18.1ms 1% ▂▁▅▁▇▃▁▂█▇ gpu tiled_playback_none_random

TileGrid and RTree perform pretty much the same, both beating no BBH.

BUG=skia:3085

Review URL: https://codereview.chromium.org/699313006

10 years agoFix Android framework build.
scroggo [Tue, 11 Nov 2014 17:45:32 +0000 (09:45 -0800)]
Fix Android framework build.

Need to include (transitively) SkUserConfig before checking
SK_SUPPORT_GPU.

Review URL: https://codereview.chromium.org/693613005

10 years agoRemove multipicturedraw GMs from ignored-tests.txt
robertphillips [Tue, 11 Nov 2014 17:42:38 +0000 (09:42 -0800)]
Remove multipicturedraw GMs from ignored-tests.txt

TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/718763002

10 years agomore gms to ignore
joshualitt [Tue, 11 Nov 2014 17:28:30 +0000 (09:28 -0800)]
more gms to ignore

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/691143006

10 years agoremove separate color from coverage
joshualitt [Tue, 11 Nov 2014 16:51:30 +0000 (08:51 -0800)]
remove separate color from coverage

BUG=skia:

Review URL: https://codereview.chromium.org/699023003

10 years agoRemove bogus assert
bsalomon [Tue, 11 Nov 2014 16:29:01 +0000 (08:29 -0800)]
Remove bogus assert

content key can be set after pending io scheduled (e.g. when scaling up a npot texture to pot).

BUG=skia:2889
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/693843004

10 years agoRebaseline problem (Galaxy S4) multipicturedraw GMs
robertphillips [Tue, 11 Nov 2014 16:17:39 +0000 (08:17 -0800)]
Rebaseline problem (Galaxy S4) multipicturedraw GMs

This CL rebaselines the buggy multipicturedraw GMs related to:

Always enable layer hoisting in Skia (https://codereview.chromium.org/698493002/)

TBR=jcgregorio@google.com

BUG=skia:3116

Review URL: https://codereview.chromium.org/715823002

10 years agoAdd support for rebaselining from trybots.
bungeman [Tue, 11 Nov 2014 16:11:55 +0000 (08:11 -0800)]
Add support for rebaselining from trybots.

This adds support to rebaseline_server to fetch actual results from
tryjobs run on rietveld issues.

Review URL: https://codereview.chromium.org/688353003

10 years agoRebaseline multipicturedraw GMs
robertphillips [Tue, 11 Nov 2014 15:55:45 +0000 (07:55 -0800)]
Rebaseline multipicturedraw GMs

This CL rebaselines the multipicturedraw GMs as a follow up to:

Always enable layer hoisting in Skia (https://codereview.chromium.org/698493002/)

TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/714153002

10 years agoupdate dox
reed [Tue, 11 Nov 2014 15:54:10 +0000 (07:54 -0800)]
update dox

BUG=skia:
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/697363004

10 years agorebase from early clip
joshualitt [Tue, 11 Nov 2014 15:40:15 +0000 (07:40 -0800)]
rebase from early clip

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/707413003

10 years agoRemove cached OptDrawState from GrDrawState.
egdaniel [Tue, 11 Nov 2014 15:32:45 +0000 (07:32 -0800)]
Remove cached OptDrawState from GrDrawState.

Since we now snap and create the ODS one time in the inorder draw buffer,
there is no need for us to keep a cached version of it around.

BUG=skia:

Review URL: https://codereview.chromium.org/701123003

10 years agoguard call to CGColorSpaceCopyICCProfile in case we're building for iOS
reed [Tue, 11 Nov 2014 15:27:25 +0000 (07:27 -0800)]
guard call to CGColorSpaceCopyICCProfile in case we're building for iOS

BUG=skia:

Review URL: https://codereview.chromium.org/712363003

10 years agoRemove all knowledge of resource keys from the legacy cache.
bsalomon [Tue, 11 Nov 2014 15:27:16 +0000 (07:27 -0800)]
Remove all knowledge of resource keys from the legacy cache.

BUG=skia:2889

Review URL: https://codereview.chromium.org/705413002

10 years agoReenable deprecation warnings on Android framework.
scroggo [Tue, 11 Nov 2014 15:04:32 +0000 (07:04 -0800)]
Reenable deprecation warnings on Android framework.

Most recently introduced here: https://codereview.chromium.org/304333002

It appears these are not currently needed (I just disabled it and
successfully built).

Since we appear to be out of the transitional period, I propose we
remove them so we can know if we deprecate something Android uses
(and fix the call site).

Review URL: https://codereview.chromium.org/696063006

10 years agoMove from libstlport to libc++ for Android framework builds
djsollen [Tue, 11 Nov 2014 15:02:03 +0000 (07:02 -0800)]
Move from libstlport to libc++ for Android framework builds

Review URL: https://codereview.chromium.org/714113002

10 years agoAvoid warning in nanobench related to loop count with nvprmsaa4
kkinnunen [Tue, 11 Nov 2014 14:57:07 +0000 (06:57 -0800)]
Avoid warning in nanobench related to loop count with nvprmsaa4

The tests path_hairline_{small,big}_AA_conic were calling the test
function with NVPR. This caused a warning in nanobench.

The here removed hunk comes from commit referring to skia:2042 ("Enable
NVPR by default"). This is a workaround for a bug. The bug is fixed by
the commit referring to skia:2078 ("Logan bot fails NVPR assertion in
bench").

The proper fix is indeed make sure that path renderer chain ends up
trying software path renderer, if the path contains conics and is a
hairline.

The removed hunk refers also to skia:2033 ("Figure out what is happening
with conic path segments in NVPR"). The above solution is correct also in case
NVPR would support conics, as NVPR would not still support hairlines.

BUG=skia:2078

Review URL: https://codereview.chromium.org/685213005

10 years agostart again on Sk4x with portable version and unit tests
mtklein [Tue, 11 Nov 2014 14:16:42 +0000 (06:16 -0800)]
start again on Sk4x with portable version and unit tests
work on tests

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN-Trybot,Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot,Test-Win7-ShuttleA-HD2000-x86_64-Debug-Trybot,Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot
BUG=skia:

Review URL: https://codereview.chromium.org/704923003

10 years agoinitial checkin for experimenting
reed [Tue, 11 Nov 2014 12:56:05 +0000 (04:56 -0800)]
initial checkin for experimenting

BUG=skia:

Review URL: https://codereview.chromium.org/696063005

10 years agoChange where layer hoisting data is gathered
robertphillips [Tue, 11 Nov 2014 12:54:49 +0000 (04:54 -0800)]
Change where layer hoisting data is gathered

This CL:
1) removes the EXPERIMENTAL_optimize on SkCanvas & SkDevice
2) moves the saveLayer gathering step to endRecording
3) Replaces GPUOptimize with SkRecordComputeLayers
4) Update bench_pictures & render_pictures to provide the new flag

#2 also necessitated moving the BBH computation (and record optimization) out of SkPicture's ctor (and into endRecording)

Review URL: https://codereview.chromium.org/718443002

10 years agoUpdate SKP version
skia.buildbots [Tue, 11 Nov 2014 07:03:28 +0000 (23:03 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/711253003

10 years agoSnap optdrawstate in inorder draw buffer and pass into gpu
joshualitt [Tue, 11 Nov 2014 00:03:14 +0000 (16:03 -0800)]
Snap optdrawstate in inorder draw buffer and pass into gpu

BUG=skia:

Review URL: https://codereview.chromium.org/709133003

10 years agotests/Time.cpp: more verbose errors
halcanary [Mon, 10 Nov 2014 22:39:24 +0000 (14:39 -0800)]
tests/Time.cpp: more verbose errors

Review URL: https://codereview.chromium.org/711143002

10 years agoSimplify canvas calls in SkDocument_PDF
halcanary [Mon, 10 Nov 2014 22:22:14 +0000 (14:22 -0800)]
Simplify canvas calls in SkDocument_PDF

As suggested by reed@ in http://crrev.com/711133002

TBR=reed@google.com

Review URL: https://codereview.chromium.org/707533003

10 years agoRemove outdated comment in SkImageDecoder.h
scroggo [Mon, 10 Nov 2014 22:18:24 +0000 (14:18 -0800)]
Remove outdated comment in SkImageDecoder.h

The comment was no longer relevant with
https://codereview.chromium.org/483593002

Review URL: https://codereview.chromium.org/715673002

10 years agoSkDocument_PDF does somthing with the trimBox parameter.
halcanary [Mon, 10 Nov 2014 22:01:57 +0000 (14:01 -0800)]
SkDocument_PDF does somthing with the trimBox parameter.

Fixes change introduced in http://crrev.com/645563002

This will allow SkDocument to be a drop-in repalcement to
SkPDFDocument/SkPDFDevice in Chromium.

Review URL: https://codereview.chromium.org/711133002

10 years agoRemove SK_FM_NEW_MATCH_FAMILY_STYLE_CHARACTER.
bungeman [Mon, 10 Nov 2014 21:29:33 +0000 (13:29 -0800)]
Remove SK_FM_NEW_MATCH_FAMILY_STYLE_CHARACTER.

This removes the old guarded code and enables the new api
introduced with "Update fontMgr to take list of bcp47 language tags."
c20386e3937d3d398ac9b35f9c7d997e972ade98 . Blink on Android is
already using the new code.

Review URL: https://codereview.chromium.org/705843004

10 years agoAdd tests (and fix!) for known bad ICO files.
scroggo [Mon, 10 Nov 2014 21:12:25 +0000 (13:12 -0800)]
Add tests (and fix!) for known bad ICO files.

We previously saw crashes decoding bad ICO files. Add tests for
known bad files.

While testing, I learned that one of them still crashes. Check for
large offset and size separately to fix the crash.

BUG=skia:2878

Review URL: https://codereview.chromium.org/712123002

10 years agoRe-enable no-longer-flaky GMs
jvanverth [Mon, 10 Nov 2014 20:12:55 +0000 (12:12 -0800)]
Re-enable no-longer-flaky GMs

TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/684413004

10 years agoMove GrResourceKey static functions from .h to .cpp to fix shared lib builds
bsalomon [Mon, 10 Nov 2014 19:59:06 +0000 (11:59 -0800)]
Move GrResourceKey static functions from .h to .cpp to fix shared lib builds
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/718493002

10 years agoUse GrResourceCache2 to service content key lookups
bsalomon [Mon, 10 Nov 2014 18:19:06 +0000 (10:19 -0800)]
Use GrResourceCache2 to service content key lookups

BUG=skia:2889

Review URL: https://codereview.chromium.org/707493002

10 years agoFix SkTime::GetDateTime Posix implementation, add unit test.
halcanary [Mon, 10 Nov 2014 17:20:22 +0000 (09:20 -0800)]
Fix SkTime::GetDateTime Posix implementation, add unit test.

The year was off by 1900

Review URL: https://codereview.chromium.org/714633002

10 years agoflag imageinfo as srgb
reed [Mon, 10 Nov 2014 16:57:21 +0000 (08:57 -0800)]
flag imageinfo as srgb

intended uses:
- flag a SkSurface as sRGB (only supported by Ganesh for now)
- flag images (e.g. png or jpeg) as sRGB if the codec tells us that

wins:
- faster gamma-correct text (esp. w/ distance-fields) when we can use sRGB for text
- better color fidelity when the screen really is sRGB

Review URL: https://codereview.chromium.org/676883003

10 years agoSmall refactoring of layer discovery code
robertphillips [Mon, 10 Nov 2014 16:48:29 +0000 (08:48 -0800)]
Small refactoring of layer discovery code

This CL removes CollectLayers' reliance on having the top most picture (by removing the unused fPictureID member). This then allows making CollectLayers' API closer to that of SkRecordFillBounds in order to facilitate using them interchangeably.

Review URL: https://codereview.chromium.org/714533002

10 years agoUpdate some flaky GMs to see if they stick.
jvanverth [Mon, 10 Nov 2014 16:27:31 +0000 (08:27 -0800)]
Update some flaky GMs to see if they stick.

TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/713893002

10 years agoAddress MSAA rendering in layer hoisting
robertphillips [Mon, 10 Nov 2014 16:10:42 +0000 (08:10 -0800)]
Address MSAA rendering in layer hoisting

This became relevant whilst attempting to rebaseline the multipicturedraw GMs after turning on layer hoisting inside Skia.

Review URL: https://codereview.chromium.org/709943003

10 years agoRebase verttext once more
egdaniel [Mon, 10 Nov 2014 16:07:37 +0000 (08:07 -0800)]
Rebase verttext once more

TBR=jvanverth@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/717553002

10 years agoWith https://chromium.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a2...
bungeman [Mon, 10 Nov 2014 15:48:55 +0000 (07:48 -0800)]
With https://chromium.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 blink_perf.layout regressed. It appears that the typeface cache is being missed. This is a partial revert of the Skia change which reverts the smallest amount of code to restore performance.

BUG=chromium:425566

Committed: https://skia.googlesource.com/skia/+/47eda52e8fb88f0725b401762a3e0bddc98e9fb3

Review URL: https://codereview.chromium.org/693213002

10 years agoUpdate SKP version
skia.buildbots [Mon, 10 Nov 2014 06:41:22 +0000 (22:41 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/717463002

10 years agoRevert of Revert of SkDrawCommand scrubbing (patchset #1 id:1 of https://codereview...
fmalita [Sun, 9 Nov 2014 00:18:56 +0000 (16:18 -0800)]
Revert of Revert of SkDrawCommand scrubbing (patchset #1 id:1 of https://codereview.chromium.org/712683002/)

Reason for revert:
Chromium clients updated, this should be canary-proof now.

Original issue's description:
> Revert of SkDrawCommand scrubbing (patchset #2 id:20001 of https://codereview.chromium.org/706363002/)
>
> Reason for revert:
> Canary borkage.
>
> Original issue's description:
> > SkDrawCommand scrubbing
> >
> > Remove unused ctor, constify, etc.
> >
> > R=robertphillips@google.com
> >
> > Committed: https://skia.googlesource.com/skia/+/1931ec5b5dac68f1e452af0c65161bdce35b2dec
>
> TBR=robertphillips@google.com
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/9063ddd511f8e0d8c7454950cbc56e273678bf60

TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/708333002

10 years agoDefault geometry processor
joshualitt [Sat, 8 Nov 2014 17:24:25 +0000 (09:24 -0800)]
Default geometry processor

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/ff343074b2a3fdaa5f120600e28717e366bceadd

Review URL: https://codereview.chromium.org/678953002

10 years agorebasing some gms
joshualitt [Sat, 8 Nov 2014 15:09:38 +0000 (07:09 -0800)]
rebasing some gms

TBR=
BUG=skia:

Review URL: https://codereview.chromium.org/713633002

10 years agoReignore some tests that use distance fields
jvanverth [Fri, 7 Nov 2014 22:57:13 +0000 (14:57 -0800)]
Reignore some tests that use distance fields

NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/708173002

10 years agoRebase for win7 x86 gpu
egdaniel [Fri, 7 Nov 2014 22:22:57 +0000 (14:22 -0800)]
Rebase for win7 x86 gpu

TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/708153002

10 years agosimple cl to cleanup friends in GrGpu
joshualitt [Fri, 7 Nov 2014 22:11:45 +0000 (14:11 -0800)]
simple cl to cleanup friends in GrGpu

BUG=skia:

Review URL: https://codereview.chromium.org/709003006

10 years agoMake gpudft non-default config for gm
jvanverth [Fri, 7 Nov 2014 21:49:49 +0000 (13:49 -0800)]
Make gpudft non-default config for gm

Review URL: https://codereview.chromium.org/692153003

10 years agoFinish rebase from df and add baseline images for n10 debug
egdaniel [Fri, 7 Nov 2014 21:19:22 +0000 (13:19 -0800)]
Finish rebase from df and add baseline images for n10 debug

TBR=jvanverth@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/705353003

10 years agocleaning up geometry handling in gpu
joshualitt [Fri, 7 Nov 2014 20:58:46 +0000 (12:58 -0800)]
cleaning up geometry handling in gpu

BUG=skia:

Review URL: https://codereview.chromium.org/707953004

10 years agoRebaseline s4 gms
egdaniel [Fri, 7 Nov 2014 20:56:35 +0000 (12:56 -0800)]
Rebaseline s4  gms

TBR=bsalomon@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/712693002

10 years agoUpdate GrTRecorder to preserve memory allocations
cdalton [Fri, 7 Nov 2014 20:51:18 +0000 (12:51 -0800)]
Update GrTRecorder to preserve memory allocations

Rather than freeing almost all of its memory on calls to reset(), this
change updates GrTRecorder so it keeps around enough to satisfy the
storage requirements from last time, plus up to ~50% growth. This is
based on the assumption that subsequent draw calls require roughly the
same amount of memory.

BUG=skia:

Review URL: https://codereview.chromium.org/684203003

10 years agoRevert of SkDrawCommand scrubbing (patchset #2 id:20001 of https://codereview.chromiu...
fmalita [Fri, 7 Nov 2014 20:26:46 +0000 (12:26 -0800)]
Revert of SkDrawCommand scrubbing (patchset #2 id:20001 of https://codereview.chromium.org/706363002/)

Reason for revert:
Canary borkage.

Original issue's description:
> SkDrawCommand scrubbing
>
> Remove unused ctor, constify, etc.
>
> R=robertphillips@google.com
>
> Committed: https://skia.googlesource.com/skia/+/1931ec5b5dac68f1e452af0c65161bdce35b2dec

TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/712683002

10 years agoSkDrawCommand scrubbing
fmalita [Fri, 7 Nov 2014 20:09:20 +0000 (12:09 -0800)]
SkDrawCommand scrubbing

Remove unused ctor, constify, etc.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/706363002

10 years agoRevert of Default geometry processor (patchset #9 id:160001 of https://codereview...
joshualitt [Fri, 7 Nov 2014 20:08:03 +0000 (12:08 -0800)]
Revert of Default geometry processor (patchset #9 id:160001 of https://codereview.chromium.org/678953002/)

Reason for revert:
breaks nexus 5

Original issue's description:
> Default geometry processor
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/ff343074b2a3fdaa5f120600e28717e366bceadd

TBR=bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/691313003

10 years agoDefault geometry processor
joshualitt [Fri, 7 Nov 2014 19:47:10 +0000 (11:47 -0800)]
Default geometry processor

BUG=skia:

Review URL: https://codereview.chromium.org/678953002

10 years agoadd patch and clicktracking to lua
reed [Fri, 7 Nov 2014 18:23:55 +0000 (10:23 -0800)]
add patch and clicktracking to lua

BUG=skia:

Review URL: https://codereview.chromium.org/712613002

10 years agoOne more attempt at rebaselining
jvanverth [Fri, 7 Nov 2014 18:17:36 +0000 (10:17 -0800)]
One more attempt at rebaselining

TBR=egdaniel@google.com
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/708903006

10 years agoMesa ES 3.0 requires sized internal formats
derekf [Fri, 7 Nov 2014 17:39:26 +0000 (09:39 -0800)]
Mesa ES 3.0 requires sized internal formats

Mesa's ES 3.0 implementation requires GL_R8 as an internal format instead
of GL_RED

Review URL: https://codereview.chromium.org/705183002

10 years agoMissed some expectations
jvanverth [Fri, 7 Nov 2014 16:50:16 +0000 (08:50 -0800)]
Missed some expectations

TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/705293002

10 years agoRefactor DrawTarget and GPU to be independent
joshualitt [Fri, 7 Nov 2014 16:48:51 +0000 (08:48 -0800)]
Refactor DrawTarget and GPU to be independent

BUG=skia:

Review URL: https://codereview.chromium.org/705593002

10 years agoRebaseline for https://codereview.chromium.org/703463002/.
jvanverth [Fri, 7 Nov 2014 16:16:49 +0000 (08:16 -0800)]
Rebaseline for https://codereview.chromium.org/703463002/.

TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/709043002

10 years agodocument the SkStrAppend methods
reed [Fri, 7 Nov 2014 15:37:33 +0000 (07:37 -0800)]
document the SkStrAppend methods

BUG=skia:

Review URL: https://codereview.chromium.org/709063002

10 years agoGet gpudft support working in dm, gm, nanobench and bench_pictures
jvanverth [Fri, 7 Nov 2014 15:12:46 +0000 (07:12 -0800)]
Get gpudft support working in dm, gm, nanobench and bench_pictures

Adds a new config to test distance field text.
Clean up some flags and #defines to read "distance field text",
not "distance field fonts" to be consistent with Chromium

NOTREECHECKS=true

Committed: https://skia.googlesource.com/skia/+/06ba179838ba4fe187cf290750aeeb4a02a2960b

Review URL: https://codereview.chromium.org/699453005

10 years agoUpdate SKP version
skia.buildbots [Fri, 7 Nov 2014 14:12:39 +0000 (06:12 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/693583003

10 years agoCleanup: Use SkAutoGraphics in gm and tests.
tfarina [Fri, 7 Nov 2014 14:12:30 +0000 (06:12 -0800)]
Cleanup: Use SkAutoGraphics in gm and tests.

BUG=None
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/704413002

10 years agoWhen running DM, write test failures to json.
scroggo [Fri, 7 Nov 2014 14:07:32 +0000 (06:07 -0800)]
When running DM, write test failures to json.

Add skiatest::Failure to keep track of data about a test failure.

Reporter::reportFailed and ::onReportFailed now take Failure as a
parameter. This allows the implementation to treat the failure as it
wishes. Provide a helper to format the failure the same as prior to
the change.

Update the macros for calling reportFailed (REPORTER_ASSERT etc) to
create a Failure object.

Convert a direct call to reportFailed to the macro ERRORF.

Write Failures to Json.
Sample output when running dm on the dummy test crrev.com/705723004:
{
   "test_results" : {
      "failures" : [
         {
            "condition" : "0 > 3",
            "file_name" : "../../tests/DummyTest.cpp",
            "line_no" : 10,
            "message" : ""
         },
         {
            "condition" : "false",
            "file_name" : "../../tests/DummyTest.cpp",
            "line_no" : 4,
            "message" : ""
         },
         {
            "condition" : "1 == 3",
            "file_name" : "../../tests/DummyTest.cpp",
            "line_no" : 5,
            "message" : "I can too count!"
         },
         {
            "condition" : "",
            "file_name" : "../../tests/DummyTest.cpp",
            "line_no" : 6,
            "message" : "seven is 7"
         },
         {
            "condition" : "1 == 3",
            "file_name" : "../../tests/DummyTest.cpp",
            "line_no" : 14,
            "message" : "I can too count!"
         }
      ]
   }
}

Report all of the failures from one test.
Previously, if one test had multiple failures, only one was reportered.
e.g:

Failures:
  test Dummy: ../../tests/DummyTest.cpp:6   seven is 7
  test Dummy2: ../../tests/DummyTest.cpp:10 0 > 3
  test Dummy3: ../../tests/DummyTest.cpp:14 I can too count!: 1 == 3
3 failures.

Now, we get all the messages:

Failures:
  test Dummy: ../../tests/DummyTest.cpp:4   false
        ../../tests/DummyTest.cpp:5 I can too count!: 1 == 3
        ../../tests/DummyTest.cpp:6 seven is 7
  test Dummy2: ../../tests/DummyTest.cpp:10 0 > 3
  test Dummy3: ../../tests/DummyTest.cpp:14 I can too count!: 1 == 3
3 failures.

(Note that we still state "3 failures" because 3 DM::Tasks failed.)

BUG=skia:3082
BUG=skia:2454

Review URL: https://codereview.chromium.org/694703005

10 years agofor X in {Dec,BigDec,Scalar}, SkWStream::write"X"AsText no longer mallocs
halcanary [Fri, 7 Nov 2014 14:07:23 +0000 (06:07 -0800)]
for X in {Dec,BigDec,Scalar}, SkWStream::write"X"AsText no longer mallocs

Review URL: https://codereview.chromium.org/706063002

10 years agoAdd LOCAL_PICKUP_FILES to dm and bench makefiles.
scroggo [Fri, 7 Nov 2014 14:02:20 +0000 (06:02 -0800)]
Add LOCAL_PICKUP_FILES to dm and bench makefiles.

Update the generator to include a line for LOCAL_PICKUP_FILES. When
generating makefiles for our tests, they will now have the following line:

LOCAL_PICKUP_FILES := \
    $(LOCAL_PATH)/../resources

This allows testing infrastructure to pick up resource files used by
our tests.

Update expectations files to test LOCAL_PICKUP_FILES.

BUG=skia:2454

Review URL: https://codereview.chromium.org/704393002

10 years agoRemove 1d glyph positions from nvpr text
cdalton [Fri, 7 Nov 2014 14:02:15 +0000 (06:02 -0800)]
Remove 1d glyph positions from nvpr text

Removes the case for x-only glyph positions from nvpr text, opting to
always send 2d glyph positions instead. The 1d glyph positions saved a
bit on memory bandwidth, but ended up a net loss because they required
more updates to the view matrix. Now we can draw an entire paragraph
without touching the GL state, whereas before we would have to update
the view matrix at every new line.

BUG=skia:

Review URL: https://codereview.chromium.org/700283002

10 years agoRevert of Get gpudft support working in dm, gm, nanobench and bench_pictures (patchse...
jvanverth [Thu, 6 Nov 2014 21:52:45 +0000 (13:52 -0800)]
Revert of Get gpudft support working in dm, gm, nanobench and bench_pictures (patchset #2 id:20001 of https://codereview.chromium.org/699453005/)

Reason for revert:
Not compiling in ANGLE build

Original issue's description:
> Get gpudft support working in dm, gm, nanobench and bench_pictures
>
> Adds a new config to test distance field text.
> Clean up some flags and #defines to read "distance field text",
> not "distance field fonts" to be consistent with Chromium
>
> NOTREECHECKS=true
>
> Committed: https://skia.googlesource.com/skia/+/06ba179838ba4fe187cf290750aeeb4a02a2960b

TBR=bsalomon@google.com,mtklein@google.com,reed@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/707723005

10 years agoGet gpudft support working in dm, gm, nanobench and bench_pictures
jvanverth [Thu, 6 Nov 2014 21:38:52 +0000 (13:38 -0800)]
Get gpudft support working in dm, gm, nanobench and bench_pictures

Adds a new config to test distance field text.
Clean up some flags and #defines to read "distance field text",
not "distance field fonts" to be consistent with Chromium

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/699453005

10 years agoClip in grdrawtarget
joshualitt [Thu, 6 Nov 2014 20:57:13 +0000 (12:57 -0800)]
Clip in grdrawtarget

NOTREECHECKS=true
BUG=skia:

Review URL: https://codereview.chromium.org/685883003

10 years agoRevert of Revert of Turn on NVPR 4x MSAA by default when supported in DM and nanobenc...
mtklein [Thu, 6 Nov 2014 16:06:39 +0000 (08:06 -0800)]
Revert of Revert of Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (patchset #1 id:1 of https://codereview.chromium.org/693933004/)

Reason for revert:
Try again with loops overflow fix landed.

Original issue's description:
> Revert of Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (patchset #2 id:20001 of https://codereview.chromium.org/704563003/)
>
> Reason for revert:
> Timing out on nvpr when drawing conics. Fix will take some thought so reverting for now.
>
> Original issue's description:
> > Turn on NVPR 4x MSAA by default when supported in DM and nanobench.
> >
> > This brings DM and nanobench's default configs in line with GM's.
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/31f88675718966bbb7f09718b40de10c7e214739
>
> TBR=bsalomon@google.com,mtklein@google.com,mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/d5cd4ee5b81b51e43be7ed13f3c0f0f6c1b3fe14

TBR=bsalomon@google.com,mtklein@chromium.org,egdaniel@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/685923003

10 years agoDetect loops overflow for gpu benches.
mtklein [Thu, 6 Nov 2014 16:04:34 +0000 (08:04 -0800)]
Detect loops overflow for gpu benches.

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/709473002

10 years agoSend coverage VA as floats instead of bytes
egdaniel [Thu, 6 Nov 2014 16:00:48 +0000 (08:00 -0800)]
Send coverage VA as floats instead of bytes
NOTREECHECKS=True

BUG=skia:

Review URL: https://codereview.chromium.org/700943005

10 years agoUpdate SKP version
skia.buildbots [Thu, 6 Nov 2014 07:19:12 +0000 (23:19 -0800)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/701363002

10 years agoAdd mock context and use in ResourceCacheTest.
bsalomon [Wed, 5 Nov 2014 22:47:41 +0000 (14:47 -0800)]
Add mock context and use in ResourceCacheTest.

BUG=skia:2889

Committed: https://skia.googlesource.com/skia/+/820dd6c335411aad889c1d7e8a857642ecd87e30

Review URL: https://codereview.chromium.org/702083003

10 years agoRevert of Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (patchs...
egdaniel [Wed, 5 Nov 2014 22:21:33 +0000 (14:21 -0800)]
Revert of Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (patchset #2 id:20001 of https://codereview.chromium.org/704563003/)

Reason for revert:
Timing out on nvpr when drawing conics. Fix will take some thought so reverting for now.

Original issue's description:
> Turn on NVPR 4x MSAA by default when supported in DM and nanobench.
>
> This brings DM and nanobench's default configs in line with GM's.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/31f88675718966bbb7f09718b40de10c7e214739

TBR=bsalomon@google.com,mtklein@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/693933004

10 years agoRevert of Add mock context and use in ResourceCacheTest. (patchset #4 id:60001 of...
bsalomon [Wed, 5 Nov 2014 20:30:32 +0000 (12:30 -0800)]
Revert of Add mock context and use in ResourceCacheTest. (patchset #4 id:60001 of https://codereview.chromium.org/702083003/)

Reason for revert:
Breaking tests

Original issue's description:
> Add mock context and use in ResourceCacheTest.
>
> BUG=skia:2889
>
> Committed: https://skia.googlesource.com/skia/+/820dd6c335411aad889c1d7e8a857642ecd87e30

TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2889

Review URL: https://codereview.chromium.org/704563004

10 years agoTurn on NVPR 4x MSAA by default when supported in DM and nanobench.
mtklein [Wed, 5 Nov 2014 20:28:26 +0000 (12:28 -0800)]
Turn on NVPR 4x MSAA by default when supported in DM and nanobench.

This brings DM and nanobench's default configs in line with GM's.

BUG=skia:

Review URL: https://codereview.chromium.org/704563003

10 years agoAdd mock context and use in ResourceCacheTest.
bsalomon [Wed, 5 Nov 2014 20:09:45 +0000 (12:09 -0800)]
Add mock context and use in ResourceCacheTest.

BUG=skia:2889

Review URL: https://codereview.chromium.org/702083003

10 years agoS4 Rebaselines
bsalomon [Wed, 5 Nov 2014 19:59:25 +0000 (11:59 -0800)]
S4 Rebaselines

TBR=

Review URL: https://codereview.chromium.org/706653003