Chris Michael [Fri, 4 Dec 2015 15:47:44 +0000 (10:47 -0500)]
elementary: Don't call ecore_wl2_shutdown unless we have a display
During _elm_config_sub_shutdown we were explicitly calling
ecore_wl2_shutdown. We should only be doing this if we are actually in
a wayland environment.
@fix
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Vincent Torri [Mon, 19 Oct 2015 18:43:36 +0000 (20:43 +0200)]
cursor: add cursor support on Windows.
@feature
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Thu, 15 Oct 2015 21:35:23 +0000 (23:35 +0200)]
win32: call ecore_win32 shutdown as part of the shutdown subsystem.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Thu, 15 Oct 2015 21:13:42 +0000 (23:13 +0200)]
cnp: add Copy & Paste support for Windows
It needs the clipboard management in Ecore_Win32
@feature
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Thu, 15 Oct 2015 13:02:56 +0000 (15:02 +0200)]
elementary_test: fix memory leak
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Wed, 14 Oct 2015 07:12:28 +0000 (09:12 +0200)]
priv: centralized and safe inclusion of Ecore_Cocoa.h
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Tue, 13 Oct 2015 14:40:49 +0000 (16:40 +0200)]
win: add Cocoa support for elm_win_window_id_get() API
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Tue, 13 Oct 2015 08:40:30 +0000 (10:40 +0200)]
win: use EINA_UNUSED instead of void casting.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Fri, 9 Oct 2015 15:18:20 +0000 (17:18 +0200)]
cnp: cocoa support for copy and paste (text only).
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Thu, 8 Oct 2015 10:01:38 +0000 (12:01 +0200)]
cursor: add support for Cocoa system cursors.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Mon, 12 Oct 2015 16:01:39 +0000 (18:01 +0200)]
config: add error messages when profile or config could not be saved.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Nicolas Aguirre [Thu, 6 Aug 2015 22:16:34 +0000 (00:16 +0200)]
cocoa: call ecore_cocoa_init as part of the init process.
This mimic what x and wayland do. This is need if you want
that ecore_event was inited early.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Chris Michael [Thu, 3 Dec 2015 17:30:46 +0000 (12:30 -0500)]
elementary: Port elementary to use Ecore_Wl2 library
This is a merge of branch 'devs/devilhorns/ecore_wl2' that ports
Elementary to use the new Ecore_Wl2 library. This port allows for
improved time to first frame, reduced input latency, and proper
support for xdg window geometry.
@feature
Chris Michael [Fri, 9 Oct 2015 15:40:10 +0000 (11:40 -0400)]
elementary: Remove misuse of EINA_UNUSED
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 1 Oct 2015 14:25:57 +0000 (10:25 -0400)]
elementary: Port elementary config code to use Ecore_Wl2 library
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 1 Oct 2015 14:25:38 +0000 (10:25 -0400)]
elementary: Port elementary copy/paste code to use Ecore_Wl2 library
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 1 Oct 2015 14:25:23 +0000 (10:25 -0400)]
elementary: Port elementary window code to use Ecore_Wl2
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 1 Oct 2015 14:24:43 +0000 (10:24 -0400)]
elementary: Port elementary cursor code to use ecore_wl2 library
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 1 Oct 2015 14:23:55 +0000 (10:23 -0400)]
elementary: Include header for Ecore_Wl2 and add external display
variable
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 1 Oct 2015 14:23:28 +0000 (10:23 -0400)]
elementary: Use ecore_wl2 library for elementary
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Daniel Hirt [Thu, 3 Dec 2015 08:06:03 +0000 (10:06 +0200)]
Entry: add "selection,reset" state
This change will hide the cursor once there is an actual change, and
there is a difference between the selection cursors. If there is no
difference, then it is better to show the cursor again.
woochan lee [Wed, 2 Dec 2015 22:56:39 +0000 (14:56 -0800)]
spinner: prevent scrolling when longpress timer enabled.
Summary:
Spinner on scroller case.
Scroll should be freeze when spinner button in long press state.
If not, the scolling will be started after delete longpress timer.
Like a other widgets, scroll not allowing is correct action for this.
@fix
Reviewers: jaehwan, Hermet, eagleeye, cedric
Differential Revision: https://phab.enlightenment.org/D3334
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Shilpa Singh [Wed, 2 Dec 2015 22:55:10 +0000 (14:55 -0800)]
elm: set language to edje when elm_language_set is called.
Summary:
Application set language using elm_language_set and when elm_language_set is called
language should be set to edje as well
@fix
Test Plan:
Call elm_language_set and check language should be set to
edje as well.
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3365
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Lukasz Stanislawski [Fri, 27 Nov 2015 17:14:54 +0000 (18:14 +0100)]
menu: enhance accessibility support
Lukasz Stanislawski [Tue, 1 Dec 2015 11:29:02 +0000 (12:29 +0100)]
box: skip box in accessibility tree by default
Lukasz Stanislawski [Tue, 1 Dec 2015 15:55:12 +0000 (16:55 +0100)]
atspi: always use widget's subobj as accessible children
Patch fixes issue when widgets could be orphaned in accessibility tree
due to overloaded accessible_children_get methods in widgets returning
Elm_Object_Items. Widgets like genlist, gengrid, list and toolbar returned
only items as its accessibility children so if some widget was attached
directly to those widgets (like ctxpopup/popup) it become orphaned
in accessibility tree.
Lukasz Stanislawski [Mon, 30 Nov 2015 09:46:19 +0000 (10:46 +0100)]
bg: do not make background accessibility object.
Lukasz Stanislawski [Thu, 26 Nov 2015 15:53:32 +0000 (16:53 +0100)]
atspi: add type of accessibility object
Type API provides possibility to skip/ignore widgets in accessiblity
tree. It make sense to ignore object if it do not provide any valuable contextual
information for disabled users. Skipped objects are usually container objects
and are ommited in parent-child relationship.
@feature
Stefan Schmidt [Mon, 30 Nov 2015 20:58:39 +0000 (21:58 +0100)]
elm_font: correct argument order for calloc()
calloc() expects count first and the actual size to allocate as second
argument. Say Thank You to smatch for finding this issues for us.
Stefan Schmidt [Mon, 30 Nov 2015 20:57:58 +0000 (21:57 +0100)]
test: correct argument order for calloc()
calloc() expects count first and the actual size to allocate as second
argument. Say Thank You to smatch for finding this issues for us.
Stefan Schmidt [Mon, 30 Nov 2015 14:37:10 +0000 (15:37 +0100)]
test_gesture_layer: correct argument order for calloc()
calloc() expects count first and the actual size to allocate as second
argument. Say Thank You to smatch for finding this issues for us.
Stefan Schmidt [Mon, 30 Nov 2015 14:15:52 +0000 (15:15 +0100)]
atspi: correct argument order for calloc()
calloc() expects count first and the actual size to allocate as second
argument. Say Thank You to smatch for finding this issues for us.
Stefan Schmidt [Mon, 30 Nov 2015 14:11:06 +0000 (15:11 +0100)]
test_access: correct argument order for calloc()
calloc() expects count first and the actual size to allocate as second
argument. Say Thank You to smatch for finding this issues for us.
Chris Michael [Mon, 30 Nov 2015 14:45:12 +0000 (09:45 -0500)]
elementary: Fix test_colorclass function
The test_colorclass function (and prototype) were incorrect in that
they did not have the proper function parameters defined. This lead to
a warning when building elementary tests.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Daniel Hirt [Mon, 30 Nov 2015 13:29:06 +0000 (15:29 +0200)]
Entry: add markup cnp handlers
In Elm_Cnp, a markup data preparer was missing, which resulted
in _x11_notify_handler_targets not requesting
"application/x-elementary-markup" (requested "UTF8_STRING" instead) when
trying to paste markup text from one entry to another (or itself).
Also, there was a missing handling in the selection data callback for
ELM_SEL_FORMAT_MARKUP data format.
This fixes issues like not being able to paste "item" formats to the
entry widget.
@fix
Stefan Schmidt [Thu, 26 Nov 2015 16:50:14 +0000 (17:50 +0100)]
elm_widget: correct declaration of function with no parameters
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Thanks for the sparse semantic parser for pointing this out.
Stefan Schmidt [Thu, 26 Nov 2015 16:49:55 +0000 (17:49 +0100)]
test: correct declaration of function with no parameters
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Thanks for the sparse semantic parser for pointing this out.
Stefan Schmidt [Thu, 26 Nov 2015 16:48:01 +0000 (17:48 +0100)]
elm_prefcs_cc: correct declaration of function with no parameters
We have to use void in a function declaration if we want no function
parameters. Using just empty parenthesis means the function takes an
unspecified number of parameters.
We had it correct for most declarations and this series fixes it for
the rest.
Thanks for the sparse semantic parser for pointing this out.
Lukasz Stanislawski [Wed, 25 Nov 2015 13:02:25 +0000 (14:02 +0100)]
atspi: remove useless "GetDefaultAttributeSet" method
This method exists in atspi spec, however is not implemented
in libatspi library. Drop it for now as it seems useless.
Mike Blumenkrantz [Wed, 25 Nov 2015 17:35:28 +0000 (12:35 -0500)]
comp base: allow mouse events to propagate through comp base -> wallpaper
@fix
Lukasz Stanislawski [Wed, 25 Nov 2015 13:01:44 +0000 (14:01 +0100)]
atspi: fix default text attribute signature
Amitesh Singh [Tue, 24 Nov 2015 10:58:01 +0000 (16:28 +0530)]
notify: remove duplicate call of _sizing_eval.
we are already calling _sizing_eval() inside _calc().
Aditya Raj [Tue, 24 Nov 2015 04:27:53 +0000 (13:27 +0900)]
Popup Example: Fix size calculation issue in popup
Summary:
The function evas_object_resize(win, 480, 800) was being called after evas_object_show(popup)
so size calculations of popup were going wrong(height was 0).
It should be called before creating popup as win is parent of popup,
This fix needs to be done only here as in other cases window is already present before creating popup
but here both are being created for exmaple purposes.
Signed-off-by: Aditya Raj <aditya1.raj@samsung.com>
Reviewers: singh.amitesh, raster
Subscribers: jpeg, tanwar.umesh07, sachin.dev
Differential Revision: https://phab.enlightenment.org/D3360
Mike Blumenkrantz [Mon, 23 Nov 2015 17:26:57 +0000 (12:26 -0500)]
table: implement Evas.Object_Smart.calculate
this allows tables to be manually calculated
ref T2836
Mike Blumenkrantz [Mon, 23 Nov 2015 17:14:48 +0000 (12:14 -0500)]
ibar: stop mouse-in animation after current animation completes
previously, mousing out of an icon during the pulse animation would
instantly stop the animation. this looks strange and is quite noticeable
when mousing through a bar
indefini [Mon, 23 Nov 2015 16:44:57 +0000 (16:44 +0000)]
Entry focus region : if single line, show the whole object.
Summary:
If the entry is a single line, rather than return the cursor height,
it is better to return the height of the object.
Reviewers: herdsman, tasn
Differential Revision: https://phab.enlightenment.org/D3169
Jee-Yong Um [Mon, 23 Nov 2015 07:26:52 +0000 (08:26 +0100)]
theme: add DBG() message when style is set to default (fallback)
Summary:
When _elm_theme_set() failed to set given style, it sets style
as "default".
However, setting style to "default" can be unintended behavior,
so developer should have the chance to get to know fallback.
Reviewers: cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3352
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
woochan lee [Mon, 23 Nov 2015 07:00:45 +0000 (08:00 +0100)]
datetime: fix field arrange code for dynamically field sequence change case.
Summary:
This is for support dynamically field sequence changing case
for example
User sets datetime format as "%d/%b/%y" first.
Then change the format dynamically in runtime to "%I:%M %p"
Previous format datetime items still there.
It breaks view(object dulicated on same geometry)
@fix
Test Plan:
Run datetime sample.
Add changed callback.
Change format in changed callback function.
Check the bug state.
Reviewers: jaehwan, id213sin, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3340
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
woochan lee [Mon, 23 Nov 2015 06:50:17 +0000 (07:50 +0100)]
multibuttonentry: internal entry cnp mode set as "ELM_CNP_MODE_PLAINTEXT".
Summary:
To prevent pasted markup text in entry.
User want tags removed text when paste text into entry.
@fix
Reviewers: jaehwan, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3333
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
woochan lee [Mon, 23 Nov 2015 06:48:32 +0000 (07:48 +0100)]
multibuttonentry: change default format count.
Summary:
There is no need ellipsis, space as well before "%d".
The "%d" will show the actual invisible item count.
@fix
Reviewers: jaehwan, Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3332
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Lukasz Stanislawski [Sat, 21 Nov 2015 15:19:53 +0000 (16:19 +0100)]
atspi: typo fix
Lukasz Stanislawski [Sat, 21 Nov 2015 13:01:54 +0000 (14:01 +0100)]
atspi: support key modifers in bridge.
@feature
Lukasz Stanislawski [Wed, 9 Sep 2015 11:58:14 +0000 (13:58 +0200)]
atspi: move root object creation to atspi class.
Amitesh Singh [Fri, 20 Nov 2015 11:11:30 +0000 (16:41 +0530)]
notify: fix hide animation
This feature has been added long time ago but it never worked before.
I delayed the parent object hide call when hide signal is present
in theme.
Test:
1. elementary_test -to notify
2. Click Left and wait for timer to expire
3. Click Left and click "close" button on notify. Now hide animation
happens when notify hides.
@fix
Amitesh Singh [Fri, 20 Nov 2015 08:56:36 +0000 (14:26 +0530)]
notify: fix broken timeout feature in elm_notify
Add missing signal "elm,action,hide,finished" in notify theme
and hide the notify object when hide is finished.
fixes T2853
@fix
Lukasz Stanislawski [Wed, 18 Nov 2015 12:34:39 +0000 (13:34 +0100)]
atspi: unprotect subset of methods
Unprotect methods which are ment to be a part of public API.
This methods were initially unprotected, however it looks like
during eo refactoring @protect tags were added by mistake.
@fix
Youngbok Shin [Wed, 18 Nov 2015 10:39:13 +0000 (19:39 +0900)]
gengrid: Prevent duplicated selected function calls when item is unselected in the function.
Summary:
If item is unselected in a selected function,
selected function will be called once more from _elm_gengrid_elm_widget_on_focus.
It is happened when elm_gengrid object has no focus and one of item is selected by mouse up event.
To fix this issue, we need to set focus to item and keep the address of selected item before calling selected function.
@fix
Test Plan:
1. Install & Run efbb (Escape From Booty Bay: https://git.enlightenment.org/games/efbb.git/)
2. Select a level in the main menu. (It is using elm_gengrid).
3. See duplicated target images.
Reviewers: cedric, SanghyeonLee
Reviewed By: SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D3323
Subodh Kumar [Wed, 18 Nov 2015 02:57:49 +0000 (11:57 +0900)]
Elm entry: Keep cursor at inserted position after dnd.
Summary:
Keep cursor at inserted position after dnd.
For good user experience, after dnd users expect
the cursor should be at the last inserted position.
@feature
Test Plan: NA
Reviewers: thiepha, herdsman, cedric, tasn
Subscribers: shilpasingh
Differential Revision: https://phab.enlightenment.org/D3267
Mike Blumenkrantz [Tue, 17 Nov 2015 23:19:15 +0000 (18:19 -0500)]
win: only perform maximize frame state updating during ecore-evas callback
running this during csd button activation leads to state mismatches when
maximize is not triggered from the csd button
@fix
Daniel Zaoui [Thu, 12 Nov 2015 06:39:46 +0000 (08:39 +0200)]
Clouseau: handle case when the library is not installed
Eina module errors are printed on the screen when the library is not
installed in the system and Clouseau debug is enabled.
The module pointer is not NULL checked, leading to an error message when trying
to load this NULL module.
@fix
Stefan Schmidt [Wed, 11 Nov 2015 16:47:57 +0000 (17:47 +0100)]
elm_prefs: mark some local symbols static and align thus with their declaration
Stefan Schmidt [Wed, 11 Nov 2015 16:45:13 +0000 (17:45 +0100)]
elm_prefs: remove some unused functions
Stefan Schmidt [Wed, 11 Nov 2015 16:31:48 +0000 (17:31 +0100)]
elm_transit: mark some local symbols static
Stefan Schmidt [Wed, 11 Nov 2015 16:27:29 +0000 (17:27 +0100)]
elm_map: mark some local symbols static
Stefan Schmidt [Wed, 11 Nov 2015 16:23:59 +0000 (17:23 +0100)]
elm_main: mark some local symbols static
shashank.p [Wed, 11 Nov 2015 06:30:58 +0000 (15:30 +0900)]
Genlist: Fixed a possible crash in filter iterator and a typo.
Summary:
1. If the sd->items list is empty any time and container_get is used on filter iterator, it will lead to crash. Solution is to not rely on sd->items and maintain a pointer to container when iterator is created.
2. There was a typo while filter feature was added earlier. Fixed it
@fix
Test Plan: NA
Reviewers: SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: rajeshps, shilpasingh
Differential Revision: https://phab.enlightenment.org/D3319
godly.talias [Tue, 10 Nov 2015 23:15:29 +0000 (15:15 -0800)]
hoversel: add item disabling support.
Summary:
Hoversel items can be disabled using elm_object_item_disabled_set
@feature
Test Plan: elementary_test
Reviewers: prince.dubey, shilpasingh, raster, Hermet, conr2d, cedric
Subscribers: poornima.srinivasan, rajeshps
Differential Revision: https://phab.enlightenment.org/D3122
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Hosang Kim [Tue, 10 Nov 2015 22:31:03 +0000 (14:31 -0800)]
slider: fix slider focus bug
Summary: when slider is focused and slider's indicator mode is not ELM_SLIDER_INDICATOR_VISIBLE_MODE_ON_FOCUS, slider's indicator popup blinked.
Test Plan: elementary_test -> slider -> focus out -> click slider again
Reviewers: seoz, cedric, raster, Hermet, woohyun, CHAN, id213sin
Differential Revision: https://phab.enlightenment.org/D3308
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
woochan lee [Tue, 10 Nov 2015 00:29:05 +0000 (16:29 -0800)]
spinner: code clean up for readability.
Summary: Line change by meaningful paragraph.
Test Plan: N/A
Reviewers: Hermet, cedric
Differential Revision: https://phab.enlightenment.org/D3300
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
woochan lee [Tue, 10 Nov 2015 00:28:19 +0000 (16:28 -0800)]
spinner: add entry filter for accepted only digits and "."
Summary:
When spinner activated with entry, user can input any characters in entry.
It degrades the usability.
Add filter for only can input numbers and "." for case of decimal point existing.
I will add entry filter for limit size as well after this commit.
This spinner features may help for app developer and users too.
@feature
Test Plan:
Run elementary_test
Test various spinner format for check this.
Reviewers: Hermet, cedric
Subscribers: id213sin, shilpasingh
Differential Revision: https://phab.enlightenment.org/D3299
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Tue, 10 Nov 2015 00:13:13 +0000 (16:13 -0800)]
segment_control: fix variable affectation
Summary:
When an Elm_Segment_Control object is created, the constructor calls
the smart_add() behind the scenes. It then calls _update_list() which
calls _position_items(), with the sd->obj unset (because it was set
after calling super constructors). This led to a CRI() (and therefore
to a backtrace) on the creation of each Elm_Segment_Control.
@fix
Test Plan: elementary_test
Reviewers: stefan_schmidt, cedric, raster
Differential Revision: https://phab.enlightenment.org/D3276
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subodh Kumar [Tue, 10 Nov 2015 00:05:05 +0000 (16:05 -0800)]
hoversel: refactor a bit to avoid code duplication.
Summary:
Avoid code duplication
Two dismissal signals at two different places
created some confusion and also code is duplicated.
Also removed some extra space.
Test Plan: NA
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D3269
shashank.p [Tue, 10 Nov 2015 00:03:05 +0000 (16:03 -0800)]
genlist: modified first/last/prev/next get API for filtered list.
Summary: elm_genlist_first_item_get(), elm_genlist_last_item_get(), elm_genlist_item_prev_get(), elm_genlist_item_next_get() should return the next filtered item if filter is applied on the genlist.
Test Plan: test_genlist.c => Genlist Filter demo updated
Reviewers: shilpasingh, cedric, SanghyeonLee
Subscribers: divyesh, rajeshps
Differential Revision: https://phab.enlightenment.org/D3263
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Shinwoo Kim [Tue, 10 Nov 2015 00:00:17 +0000 (16:00 -0800)]
conform: retry connect to indicator when confrom fails connect.
Summary:
An application starts before the indicator has. In this case,
the application should try to connect again with the indicator.
Test Plan:
1. Start an application without the indicator service.
2. Start the indicator service.
Reviewers: raster, Hermet, woohyun, jaehwan, cedric
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3258
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Shilpa Singh [Mon, 9 Nov 2015 22:34:37 +0000 (14:34 -0800)]
naviframe: subtitle,show signal not sent
Summary:
1. When subtitle is set using actual part name "elm.text.subtitle",
subtitle,show signal is not sent issue fix.
2. Remove unnecessary checks, maintain code readability.
@fix
Test Plan:
Set text using edc part name elm.text.subtitle
Reviewers: Hermet, cedric
Reviewed By: cedric
Subscribers: shashank0990
Differential Revision: https://phab.enlightenment.org/D2988
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
woochan lee [Mon, 9 Nov 2015 20:25:27 +0000 (12:25 -0800)]
index: internal item's edje object handling logic changed to improve performance.
Summary:
The box_clear, box_fill internal functions called when almost every internal chage happend.
(resize, theme apply, item append, item delete etc...)
Then those APIs delete/create item's edje object for all of the items.
It's very not good action for performance.
So, i changed this just edje object box unpack/pack instead of delete/create.
@fix
Test Plan:
Working test on elementary_test
and Call all of the index APIs for check this change.
Reviewers: Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3268
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Youngbok Shin [Mon, 9 Nov 2015 20:25:04 +0000 (12:25 -0800)]
toolbar: reduce changing widget parent-child relationship when an item is added.
Summary:
It is an legacy of old code. When the view object of item was edje,
I think there was no meaningless parent-child relationship changes.
But, now, the view object is elm_layout and if we add object in proper order,
we don't need to make an useless parent-child realationship in any moments.
Test Plan: None
Reviewers: woohyun, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3254
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Shilpa Singh [Mon, 9 Nov 2015 20:24:37 +0000 (12:24 -0800)]
toolbar: add item_signal_emit.
Summary:
Application cannot send signals to toolbar item using elm_object_item_signal_emit API.
@feature
Test Plan: Send signal to toolbar item from app using elm_object_item_signal_emit widget.
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D3251
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Youngbok Shin [Mon, 9 Nov 2015 20:24:08 +0000 (12:24 -0800)]
toolbar: remove a legacy code.
Summary:
The icon is already sub object of VIEW(item) by content_set.
We don't need to make icon as a sub object of obj again.
It was used when VIEW(item) is Edje object.
Test Plan: None
Reviewers: Hermet, eagleeye, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3249
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Shilpa Singh [Mon, 9 Nov 2015 20:23:46 +0000 (12:23 -0800)]
colorselector: read color names instead of RGBA when accessibility is set
Summary:
Issue: When accessibility is set, individual color item's RGBA values are read
instead of actual color names.
Solution: Read color names by matching the color RGBA from the array.
Test Plan:
enable accessibility
run elementary test
select colorselector demo
click on individual color palette items
Reviewers: cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3240
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jee-Yong Um [Mon, 9 Nov 2015 20:23:18 +0000 (12:23 -0800)]
hover/hoversel: clean up code for getting edje_object_data
Summary:
There are several lines to get edje_object_data from elm_hover
or elm_hoversel like edje_object_data_get(elm_layout_edje_get(obj), "key");
These codes can be replaced with elm_layout_data_get(obj, "key");
Reviewers: Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3193
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Prince Kumar Dubey [Mon, 9 Nov 2015 20:22:32 +0000 (12:22 -0800)]
conform: if window is in background, indicator must not update the plug information.
Summary:
When the window is in background, for associated conformant, indicator must not update the plug information.
To fix this issue, On window goes to background, the associated plug handled by confromant is deleted.
Test Plan:
On any device (like handset) which should have indicator support, this scenario can be reproduce. I tested on a handset
with gdb attach to running process having window and confromant with indicator support.
Reviewers: raster, Hermet, cedric
Reviewed By: cedric
Subscribers: rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D3177
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Shilpa Singh [Mon, 9 Nov 2015 20:21:09 +0000 (12:21 -0800)]
calendar: weekdays do not get translated when language is dynamically changed issue fix
Summary:
When calendar widget is already created and if we change language,
weekdays do not get translated because weekday string is statically
stored only during create.
Update the weekdays again when object is changed.
@fix
Test Plan:
1.Create and show calendar widget
2.Change the language
Weekdays do not get translated
Reviewers: Hermet, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3149
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
godly.talias [Mon, 9 Nov 2015 20:18:49 +0000 (12:18 -0800)]
hoversel: do item view creation at the time of item addition.
Summary:
Currently hoversel creates the item view when user clicks on hoversel,
So it will cause a delay for the hover to come depending on number
of items as the items in hover have to be created. If item creation
is done during item_add that delay can be avoided and pressed effect also
will become smooth (item_add will be taking more time with this change, but
it happens only once). If applications prefer memory usage more than execution
time, then applications can do item_add in hoversel clicked callback.
Test Plan: elementary_test
Reviewers: raster, Hermet, conr2d, prince.dubey, shilpasingh, cedric
Reviewed By: cedric
Subscribers: rajeshps, poornima.srinivasan
Differential Revision: https://phab.enlightenment.org/D3058
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Daniel Kolesa [Tue, 13 Oct 2015 13:40:07 +0000 (14:40 +0100)]
build: don't provide --eo to eolian_gen
Stefan Schmidt [Mon, 9 Nov 2015 10:46:30 +0000 (11:46 +0100)]
configure: Switch to dev mode again. Merge window for 1.17 is open now
Stefan Schmidt [Mon, 9 Nov 2015 10:08:34 +0000 (11:08 +0100)]
release: Update NEWS and bump version for 1.16.0 release
Stefan Schmidt [Mon, 9 Nov 2015 10:04:36 +0000 (11:04 +0100)]
po: update po files for release
Wonsik Jung [Thu, 5 Nov 2015 11:37:11 +0000 (20:37 +0900)]
win : Prohibiting auto-rendering, until elm_win is shown.
Summary:
Although elm_win is only created and evas_object_show with elm_win is not called,
evas_rendering works sometimes.
This rendering is not necessary. Because on one is shown and just back buffer is allocated.
This patch is the prohibiting auto-rendering, if elm_win is shown by calling evas_object_show()
It is effective for power consumption and reducing memory.
@fix
Test Plan:
1. elementary_test : checking all menus's working
2. modifed bg_example_02 : updated elm_bg's color by animator without evas_object_show(elm_win)
Reviewers: jpeg, jypark, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D3282
Lukasz Stanislawski [Thu, 5 Nov 2015 09:52:28 +0000 (10:52 +0100)]
atspi: add missing SELECTED changed signals
@fix
Jean Guyomarc'h [Thu, 5 Nov 2015 07:12:44 +0000 (16:12 +0900)]
elm_segment_control: fix invalid parameter
Summary:
Eo complained about an invalid type 'Edje_Object' passed to
elm_widget_sub_object_add(). It is the segment control itself
that should be the subject of the call to this function.
@fix
Test Plan: elementary_test: no more Eo errors
Reviewers: cedric, stefan_schmidt
Differential Revision: https://phab.enlightenment.org/D3277
Carsten Haitzler (Rasterman) [Wed, 4 Nov 2015 03:33:46 +0000 (12:33 +0900)]
genlist tree test - minor - show all callbacks called so people know
act as "docs" so people can see what is called when. minor just in elm
test.
chris [Thu, 5 Nov 2015 00:16:11 +0000 (16:16 -0800)]
autoscroll focus: pass the object region position relative to the scroller.
Summary:
The region position passed to region_show and region_bring_in used to be
relative to the object position, not the scroller.
This fixes T1686.
@fix
Reviewers: seoz
Maniphest Tasks: T1686
Differential Revision: https://phab.enlightenment.org/D3168
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Hosang Kim [Tue, 3 Nov 2015 20:29:05 +0000 (12:29 -0800)]
interface_scrollable: delete unnecessary smart callback call.
Summary:
When _elm_interface_scrollable_page_bring_in is called, page is not changed yet.
So "page,changed" smart callback is unnecessary.
Sometimes "page,changed" smart callback is called twice.
Because "drag,stop" and "anim,stop"is called it.
So I add updating current page code.
Test Plan:
elementary_test -> scroller
1. using wheel.
2. using "prev page" and "next page".
3. draging sceen
Reviewers: Hermet, singh.amitesh, cedric, raster, jaehwan, seoz
Differential Revision: https://phab.enlightenment.org/D3260
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Shilpa Singh [Tue, 3 Nov 2015 20:17:03 +0000 (12:17 -0800)]
colorselector: picker spinner UI not proper issue fix.
Summary:
Picker spinner UI not proper, showing blank buttons issue fix.
@fix T2401
Test Plan:
1. Launch elementary_test
2. Select colorselector
3. Tap on picker
4. observe, spinner UI not proper.
Reviewers: cedric, subodh6129
Reviewed By: subodh6129
Maniphest Tasks: T2401
Differential Revision: https://phab.enlightenment.org/D3266
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean-Philippe Andre [Wed, 21 Oct 2015 08:23:10 +0000 (17:23 +0900)]
notify: animate on hide
There was all the necessary code, except that the default
theme did not implement properly the signal & required data.
There is still a problem though, as the "timeout" smart callback
will be called at the start of the animation, so it's not possible
for an app to hide() or del() at this point (that would get
rid of the animation). But there's no other callback after
the animation ends.
elementary_test -to Notify > "Bottom" illustrates this issue.
Cedric BAIL [Mon, 2 Nov 2015 23:54:41 +0000 (15:54 -0800)]
Revert "elm: Add eglfs backend support."
This reverts commit
0d6aedbf44e5c371bddfa2b6b61c9409ed2184e3.
This patch landed a little bit to early.
Nicolas Aguirre [Mon, 2 Nov 2015 23:13:20 +0000 (00:13 +0100)]
elm: Add eglfs backend support.
Felipe Magno de Almeida [Mon, 2 Nov 2015 21:39:55 +0000 (19:39 -0200)]
Remove #include for config.h from C++ public header
Removed #include for elementary_config.h if HAVE_CONFIG_H is
defined. Which causes errors with external projects. Instead,
defined the necessary macros to use the Eo API.
Yeshwanth Reddivari [Mon, 2 Nov 2015 13:59:57 +0000 (19:29 +0530)]
Hoversel: Fix dismiss callback
Summary: Dismiss callback was getting called on hover object instead of hoversel object.
Reviewers: raster, Hermet, alok25, mvsovani, conr2d, singh.amitesh
Reviewed By: singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D3261