platform/upstream/gst-editing-services.git
3 years agolaunch: Add an interactive mode where we can seek etc...
Thibault Saunier [Fri, 4 Sep 2020 14:27:05 +0000 (10:27 -0400)]
launch: Add an interactive mode where we can seek etc...

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/209>

3 years agomeson: Enable some MSVC warnings for parity with GCC/Clang
Nirbheek Chauhan [Wed, 4 Nov 2020 13:17:28 +0000 (18:47 +0530)]
meson: Enable some MSVC warnings for parity with GCC/Clang

This makes it easier to do development with MSVC by making it warn
on common issues that GCC/Clang error out for in our CI configuration.

Continuation from https://gitlab.freedesktop.org/gstreamer/gst-build/-/merge_requests/223

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/220>

3 years agoinit: Fix initialisation crash
Jan Schmidt [Thu, 29 Oct 2020 13:30:52 +0000 (00:30 +1100)]
init: Fix initialisation crash

Fix a case where initialisation fails without setting
the passed-in GError and the caller assumes it will be
set, and add a guard to catch the condition in case it
happens again in the future.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/217>

3 years agoMeson: Use pkg-config generator
Xavier Claessens [Sun, 4 Nov 2018 18:04:45 +0000 (13:04 -0500)]
Meson: Use pkg-config generator

3 years agoutils.c: fix static build
Fabrice Fontaine [Sun, 18 Oct 2020 14:08:36 +0000 (16:08 +0200)]
utils.c: fix static build

Static build fails since version 1.17.1 and
https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/commit/1e488d4311420b5ca193155ad8ab05509c9a4a37
on:

FAILED: tools/ges-launch-1.0
/srv/storage/autobuild/run/instance-2/output-1/host/bin/arm-linux-gcc  -o tools/ges-launch-1.0 tools/ges-launch-1.0.p/ges-validate.c.o tools/ges-launch-1.0.p/ges-launch.c.o tools/ges-launch-1.0.p/ges-launcher.c.o tools/ges-launch-1.0.p/utils.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -Wl,-Bsymbolic-functions -static -Wl,--start-group ges/libges-1.0.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libgstreamer-1.0.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libgobject-2.0.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libglib-2.0.a -pthread /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libpcre.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libffi.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libgmodule-2.0.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libgstbase-1.0.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libgstvideo-1.0.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libgstpbutils-1.0.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libgstaudio-1.0.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libz.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libgsttag-1.0.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libgstcontroller-1.0.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libgio-2.0.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libmount.a /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libblkid.a -lm -Wl,--end-group
/srv/storage/autobuild/run/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/arm-buildroot-linux-uclibcgnueabi/8.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: /srv/storage/autobuild/run/instance-2/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libc.a(err.os): in function `warn':
err.c:(.text+0x1d8): multiple definition of `warn'; tools/ges-launch-1.0.p/utils.c.o:utils.c:(.text+0x9bc): first defined here

So rename warn function to ges_warn
Also prefix ok, print and printerr function by ges_ for consistancy and
run gst-indent on tools/ges-launcher.c

Fixes:
 - http://autobuild.buildroot.org/results/2a528a1185644f5b23d26eb3f2b342e99aa1e493

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/216>

3 years agomeson: actually check glib dependency version
Antonio Ospite [Sun, 18 Oct 2020 18:11:33 +0000 (20:11 +0200)]
meson: actually check glib dependency version

Actually check the version constraint when looking for the glib
dependency.

The version check will make meson use the fallback dependency when the
one from the system is not recent enough, and eventually make the build
succeed even on some older systems like Ubuntu 16.04.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/212>

3 years agomeson: update glib minimum version to 2.56
Stéphane Cerveau [Fri, 16 Oct 2020 11:17:04 +0000 (13:17 +0200)]
meson: update glib minimum version to 2.56

In order to support the symbol g_enum_to_string in various
project using GStreamer ( gst-validate etc.), the glib minimum
version should be 2.56.0.

Remove compat code as glib requirement
is now > 2.56

Version used by Ubuntu 18.04 LTS

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/215>

3 years agoges: Do not recreate auto-transitions when changing clip assets
Thibault Saunier [Fri, 4 Sep 2020 03:32:23 +0000 (23:32 -0400)]
ges: Do not recreate auto-transitions when changing clip assets

Otherwise we loose the configuration of the auto transition, and
it is not required at all in any case.

Fixes https://gitlab.gnome.org/GNOME/pitivi/-/issues/2380

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/208>

3 years agoges: Fix a copy/paste mistake in meson file
Thibault Saunier [Tue, 8 Sep 2020 14:39:10 +0000 (11:39 -0300)]
ges: Fix a copy/paste mistake in meson file

Passed unnoticed because we built against GstValidate

Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/issues/119

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/211>

3 years agovideo-transition: Make smpte props children properties
Thibault Saunier [Fri, 4 Sep 2020 01:15:16 +0000 (21:15 -0400)]
video-transition: Make smpte props children properties

And deprecate old style accessors.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/207>

3 years agoci: include template from gst-ci master branch again
Tim-Philipp Müller [Tue, 8 Sep 2020 16:30:53 +0000 (17:30 +0100)]
ci: include template from gst-ci master branch again

3 years agoBack to development
Tim-Philipp Müller [Tue, 8 Sep 2020 15:59:02 +0000 (16:59 +0100)]
Back to development

3 years agoRelease 1.18.0
Tim-Philipp Müller [Mon, 7 Sep 2020 23:09:25 +0000 (00:09 +0100)]
Release 1.18.0

3 years agodemux: Fixate documentation caps
Thibault Saunier [Fri, 4 Sep 2020 14:43:05 +0000 (10:43 -0400)]
demux: Fixate documentation caps

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/210>

3 years agocomplex_effect_bin_desc: Regenerate expectation for compositor change
Jan Schmidt [Fri, 21 Aug 2020 14:57:06 +0000 (00:57 +1000)]
complex_effect_bin_desc: Regenerate expectation for compositor change

Part of: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/796

3 years agotests: Fix running tests fully uninstalled
Thibault Saunier [Fri, 21 Aug 2020 01:09:31 +0000 (21:09 -0400)]
tests: Fix running tests fully uninstalled

Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/issues/118

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/206>

3 years agoRelease 1.17.90
Tim-Philipp Müller [Thu, 20 Aug 2020 15:16:01 +0000 (16:16 +0100)]
Release 1.17.90

3 years agoges:source: Handle missing elements in converters
Thibault Saunier [Sat, 1 Aug 2020 02:02:01 +0000 (22:02 -0400)]
ges:source: Handle missing elements in converters

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/204>

3 years agosmart-mixer: Move the videoconvert to after the mixer
Thibault Saunier [Wed, 22 Jul 2020 16:02:10 +0000 (12:02 -0400)]
smart-mixer: Move the videoconvert to after the mixer

So that it tries to negotiate with alpha and the alpha channel is
dropped as late as possible in the pipeline.

The compositor is able to do video conversion internally in any case
so having a videoconvert before it is useless.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/204>

3 years agotransition: Enhance name of the elements
Thibault Saunier [Tue, 21 Jul 2020 12:49:35 +0000 (08:49 -0400)]
transition: Enhance name of the elements

Making it simpler to debug

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/204>

3 years agosource: Handle missing elements in converter
Thibault Saunier [Mon, 20 Jul 2020 21:32:39 +0000 (17:32 -0400)]
source: Handle missing elements in converter

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/204>

3 years agovideo-source: Stop giving useless name to frame positioner
Thibault Saunier [Tue, 14 Jul 2020 04:09:32 +0000 (00:09 -0400)]
video-source: Stop giving useless name to frame positioner

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/204>

3 years agotransition: Better document the way alpha is computed for transitions
Thibault Saunier [Mon, 13 Jul 2020 22:18:22 +0000 (18:18 -0400)]
transition: Better document the way alpha is computed for transitions

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/204>

3 years agosmart-mixer: Use the new 'samples-selected' signal to handle queuing in aggregator...
Thibault Saunier [Sun, 12 Jul 2020 17:51:42 +0000 (13:51 -0400)]
smart-mixer: Use the new 'samples-selected' signal to handle queuing in aggregator pads

Since aggregator introduced queueing in its sinkpads the way we set
properties on the pads is incorrect as it doesn't take it into account.
This fixes the issue by using the newly introduced `samples-selected`
signal in aggregator to set the properties right before the compositing
is done.

Also require the compositor we use to be an aggregator.

And add a validate test for it.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/204>

3 years agoges:validate: Allow setting keyframes using the clips directly
Thibault Saunier [Sun, 12 Jul 2020 17:49:36 +0000 (13:49 -0400)]
ges:validate: Allow setting keyframes using the clips directly

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/204>

3 years agoges-source: Ensure that we output stream with segments in time
Thibault Saunier [Sat, 25 Jul 2020 17:14:56 +0000 (13:14 -0400)]
ges-source: Ensure that we output stream with segments in time

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agopipeline: Restrict the presence only if the user didn't explicitly provided one
Thibault Saunier [Thu, 9 Jul 2020 15:10:41 +0000 (11:10 -0400)]
pipeline: Restrict the presence only if the user didn't explicitly provided one

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agotimeline: Add a simplified version of track selection signal
Thibault Saunier [Wed, 8 Jul 2020 19:47:55 +0000 (15:47 -0400)]
timeline: Add a simplified version of track selection signal

Most user do not need to select several tracks for a single
TrackElement and this signal is not binding friendly so
this is adding a simpler, more user and binding friendly version

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agouri-source: Respect user stream selection
Thibault Saunier [Wed, 8 Jul 2020 19:47:12 +0000 (15:47 -0400)]
uri-source: Respect user stream selection

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agolaunch: Also print the position when disabling validate
Thibault Saunier [Wed, 8 Jul 2020 12:02:27 +0000 (08:02 -0400)]
launch: Also print the position when disabling validate

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agolaunch: Print more useful information to stdout
Thibault Saunier [Wed, 8 Jul 2020 12:01:58 +0000 (08:01 -0400)]
launch: Print more useful information to stdout

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agobuild: Add an option to disable examples
Thibault Saunier [Wed, 8 Jul 2020 11:42:38 +0000 (07:42 -0400)]
build: Add an option to disable examples

And make it yield as in other modules

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agolauncher: Re activate smart rendering support
Thibault Saunier [Fri, 3 Jul 2020 22:21:22 +0000 (18:21 -0400)]
launcher: Re activate smart rendering support

Trying to get the best encoding profile for smart rendering when
the user didn't specify anything.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agoges: Fix smart rendering
Thibault Saunier [Fri, 3 Jul 2020 22:16:13 +0000 (18:16 -0400)]
ges: Fix smart rendering

Smart rendering has been broken since, mostly forever, but some code
was there pretending it was supported... let's try to stop pretending.

We now keep track of the smart rendering state in the timeline, track
and sources to be able to:

 * tell decodebin to stop plugging more (decoding elements) as soon as
   downstream supports the format.

 * avoid plugging converters after the source element when smart
   rendering.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agovalidate: Pipe debug output to a file when discovering scenarios
Thibault Saunier [Fri, 3 Jul 2020 22:00:39 +0000 (18:00 -0400)]
validate: Pipe debug output to a file when discovering scenarios

Otherwise `gst-validate-launcher` can get veeery noisy

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agonle: Minor debug enhancement
Thibault Saunier [Fri, 3 Jul 2020 21:59:49 +0000 (17:59 -0400)]
nle: Minor debug enhancement

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agotests: Mark audio identity as audio
Thibault Saunier [Fri, 3 Jul 2020 21:58:16 +0000 (17:58 -0400)]
tests: Mark audio identity as audio

Otherwise GES fallbacks to video...

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agopipeline: stop setting the track caps
Henry Wilkes [Mon, 13 Jan 2020 13:08:24 +0000 (13:08 +0000)]
pipeline: stop setting the track caps

Stop setting the track 'caps' property. The previous code could
overwrite a users own setting of the caps for video and audio caps.
Moreover, the 'caps' property is listed as construct only, and users
will likely expect it to stay the same after a track has been added to a
timeline.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agolauncher: Delay setting rendering setting to right before rendering
Thibault Saunier [Fri, 3 Jul 2020 21:41:28 +0000 (17:41 -0400)]
launcher: Delay setting rendering setting to right before rendering

So that user settings have been applied to the timeline taking into
account any `validatetest` arguments

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agosource: Refactor the way we plug converter elements
Thibault Saunier [Fri, 3 Jul 2020 21:18:51 +0000 (17:18 -0400)]
source: Refactor the way we plug converter elements

Paving the way to skipping converters when rendering smartly

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agopipeline: Do not name urisink as `urisink` as it is useless
Thibault Saunier [Fri, 3 Jul 2020 21:02:45 +0000 (17:02 -0400)]
pipeline: Do not name urisink as `urisink` as it is useless

And actually harmful in case you are debugging several pipelines.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agopipeline: Remove urisink from timeline instead of unrefing it
Thibault Saunier [Fri, 3 Jul 2020 21:01:18 +0000 (17:01 -0400)]
pipeline: Remove urisink from timeline instead of unrefing it

Doing what was suggested in the FIXME and avoiding to unref
something it while we do not actually own it ourself.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agopipeline: Discard encoding profiles that don't match any track
Thibault Saunier [Fri, 3 Jul 2020 20:52:06 +0000 (16:52 -0400)]
pipeline: Discard encoding profiles that don't match any track

Otherwise we get a 'not linked' error and we should just help
the user as we can here.

If the user adds a new track, he should set a new encoding profile
anyway.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agouri*source: Factor out common logic into a GESUriSource private data
Thibault Saunier [Fri, 3 Jul 2020 20:34:21 +0000 (16:34 -0400)]
uri*source: Factor out common logic into a GESUriSource private data

The two classes are *very* close but have different hierarchy so this
introduces a new GESUriSource structure that is used as private
structure by both subclasses and makes most of the logic shared this
way.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years ago*uri-source: Call free from the object ->finalize not ->dispose
Thibault Saunier [Wed, 24 Jun 2020 15:11:11 +0000 (11:11 -0400)]
*uri-source: Call free from the object ->finalize not ->dispose

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>

3 years agomeson: install bash completion helper for ges-launch-1.0
Tim-Philipp Müller [Sat, 25 Jul 2020 18:16:06 +0000 (19:16 +0100)]
meson: install bash completion helper for ges-launch-1.0

Fixes #77

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/203>

3 years agomeson: add 'tools' and 'examples' options
Tim-Philipp Müller [Sat, 25 Jul 2020 18:09:30 +0000 (19:09 +0100)]
meson: add 'tools' and 'examples' options

To optionally disable build of those.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/203>

3 years agoFix retrieving asset metadata on project reload.
AsociTon [Fri, 24 Jul 2020 02:13:05 +0000 (07:43 +0530)]
Fix retrieving asset metadata on project reload.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/202>

3 years agotests: Add test for ges_clip_get_top_effect_index
yatinmaan1@gmail.com [Tue, 21 Jan 2020 10:32:56 +0000 (16:02 +0530)]
tests: Add test for ges_clip_get_top_effect_index

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/201>

3 years agotests: clip: fix test_rate_effects_duration_limit
Guillaume Desmottes [Tue, 14 Jul 2020 08:20:32 +0000 (10:20 +0200)]
tests: clip: fix test_rate_effects_duration_limit

Fix this assertion:
g_value_copy: assertion 'g_value_type_compatible (G_VALUE_TYPE (src_value), G_VALUE_TYPE (dest_value))' failed

'tempo' is a float, not a double.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/199>

3 years agobuild: Add version.h to the headers list
Thibault Saunier [Fri, 10 Jul 2020 12:16:10 +0000 (08:16 -0400)]
build: Add version.h to the headers list

So it is properly installed and the gir contains the required information

Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/issues/75

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/197>

3 years agopitivi-formatter: Also skip the class
Thibault Saunier [Fri, 10 Jul 2020 01:42:50 +0000 (21:42 -0400)]
pitivi-formatter: Also skip the class

3 years agomeson: set release date from .doap file for releases
Tim-Philipp Müller [Wed, 8 Jul 2020 16:33:07 +0000 (17:33 +0100)]
meson: set release date from .doap file for releases

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/196>

3 years agotitle: Make deprecated symbols visible API
Thibault Saunier [Wed, 8 Jul 2020 14:03:43 +0000 (10:03 -0400)]
title: Make deprecated symbols visible API

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/195>

3 years agoBack to development
Tim-Philipp Müller [Fri, 3 Jul 2020 01:04:08 +0000 (02:04 +0100)]
Back to development

3 years agoRelease 1.17.2
Tim-Philipp Müller [Thu, 2 Jul 2020 23:35:20 +0000 (00:35 +0100)]
Release 1.17.2

3 years agodocs: fix links
Mathieu Duponchelle [Tue, 23 Jun 2020 14:11:59 +0000 (16:11 +0200)]
docs: fix links

3 years agoplugins_cache: add base classes
Mathieu Duponchelle [Mon, 22 Jun 2020 22:05:13 +0000 (00:05 +0200)]
plugins_cache: add base classes

3 years agomeson: mark plugins cache target as always stale
Mathieu Duponchelle [Mon, 22 Jun 2020 22:04:52 +0000 (00:04 +0200)]
meson: mark plugins cache target as always stale

3 years agodocs: mark more types as plugin API
Mathieu Duponchelle [Sat, 20 Jun 2020 23:42:26 +0000 (01:42 +0200)]
docs: mark more types as plugin API

3 years agodoc: Stop documenting properties from parents
Thibault Saunier [Sat, 20 Jun 2020 02:56:41 +0000 (22:56 -0400)]
doc: Stop documenting properties from parents

3 years agosmart-video-mixer: Don't call gst_ghost_pad_construct() anymore
Sebastian Dröge [Mon, 22 Jun 2020 09:34:20 +0000 (12:34 +0300)]
smart-video-mixer: Don't call gst_ghost_pad_construct() anymore

It's deprecated, unneeded and doesn't do anything anymore.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/192>

3 years agoBack to development
Tim-Philipp Müller [Fri, 19 Jun 2020 23:28:31 +0000 (00:28 +0100)]
Back to development

3 years agoRelease 1.17.1
Tim-Philipp Müller [Fri, 19 Jun 2020 18:25:56 +0000 (19:25 +0100)]
Release 1.17.1

3 years agoges: Add all missing Since markers from 1.16 onward
Thibault Saunier [Fri, 19 Jun 2020 15:13:24 +0000 (11:13 -0400)]
ges: Add all missing Since markers from 1.16 onward

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/191>

3 years agoasset: Do not try to update proxies when we are in a proxying loop
Thibault Saunier [Tue, 9 Jun 2020 14:07:13 +0000 (10:07 -0400)]
asset: Do not try to update proxies when we are in a proxying loop

This is a regression introduced in
c12b84788d197c714ec32653e2b751079e377c46, this commit simply brings back
the previous behavior.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/issues/113

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/185>

3 years agoges: Refactor the way we plug converters in effects
Thibault Saunier [Tue, 9 Jun 2020 04:03:57 +0000 (00:03 -0400)]
ges: Refactor the way we plug converters in effects

Stopping to do it at the bin description level but properly
plugging them where they are needed and cleanly ghosting the pads
where it makes most sense.

This introduces support for GES to request pads on the most upstream
element in case no static pad can be ghosted.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/187>

3 years agostructured-interface: Add support for setting effects inpoint
Thibault Saunier [Tue, 9 Jun 2020 20:40:11 +0000 (16:40 -0400)]
structured-interface: Add support for setting effects inpoint

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/187>

3 years agotrack-element: Make set_has_internal_source return a boolean
Thibault Saunier [Tue, 9 Jun 2020 20:35:44 +0000 (16:35 -0400)]
track-element: Make set_has_internal_source return a boolean

Telling the user if it is legal to have an internal source in that
particular GESTrackElement.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/187>

3 years agopipeline: doc: Add a note about trying to render before setting rendering settings
Thibault Saunier [Mon, 15 Jun 2020 17:09:39 +0000 (13:09 -0400)]
pipeline: doc: Add a note about trying to render before setting rendering settings

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/189>

3 years agouri-clip: Add a warning about synchronous uri discovery
Thibault Saunier [Mon, 15 Jun 2020 16:23:26 +0000 (12:23 -0400)]
uri-clip: Add a warning about synchronous uri discovery

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/189>

3 years agodocs: Update plugins cache
Thibault Saunier [Tue, 9 Jun 2020 19:22:30 +0000 (15:22 -0400)]
docs: Update plugins cache

3 years agodocs: Update plugins cache
Thibault Saunier [Mon, 8 Jun 2020 14:58:43 +0000 (10:58 -0400)]
docs: Update plugins cache

3 years agotests: enforce I420 format
Guillaume Desmottes [Fri, 5 Jun 2020 13:56:00 +0000 (15:56 +0200)]
tests: enforce I420 format

Tests are assuming video is I420 with a specific chroma and colorimetry
but were not actually enforcing it.
Fixes needed as I420 will no longer be the first video format, see
gst-plugins-base!689

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/184>

4 years agotrack, composition: mark stream id properties as DOC_SHOW_DEFAULT
Mathieu Duponchelle [Thu, 4 Jun 2020 21:14:59 +0000 (23:14 +0200)]
track, composition: mark stream id properties as DOC_SHOW_DEFAULT

and update plugins cache

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/182>

4 years agodoc: Require hotdoc >= 0.11.0
Thibault Saunier [Wed, 3 Jun 2020 22:30:39 +0000 (18:30 -0400)]
doc: Require hotdoc >= 0.11.0

4 years agodocs: Update gst_plugins_cache.json
Sebastian Dröge [Wed, 27 May 2020 13:03:35 +0000 (16:03 +0300)]
docs: Update gst_plugins_cache.json

4 years agoadd missing Since annotations on new API
Guillaume Desmottes [Wed, 3 Jun 2020 07:57:06 +0000 (09:57 +0200)]
add missing Since annotations on new API

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/181>

4 years agoformatter: Do not dereference NULL pointer
Thibault Saunier [Wed, 27 May 2020 23:44:29 +0000 (19:44 -0400)]
formatter: Do not dereference NULL pointer

CID 1461701

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/180>

4 years agoxml-formatter: Add an GST_ERROR when setting control sources fails
Thibault Saunier [Wed, 27 May 2020 23:39:49 +0000 (19:39 -0400)]
xml-formatter: Add an GST_ERROR when setting control sources fails

CID 1463853

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/180>

4 years agovalidate: Wait for state change to consider commit as done
Thibault Saunier [Tue, 26 May 2020 23:14:53 +0000 (19:14 -0400)]
validate: Wait for state change to consider commit as done

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/178>

4 years agovalidate: Stop always muting
Thibault Saunier [Tue, 26 May 2020 23:02:58 +0000 (19:02 -0400)]
validate: Stop always muting

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/178>

4 years agoformatter: Fix saving/loading project with clip speed rate control
Thibault Saunier [Thu, 21 May 2020 21:22:18 +0000 (17:22 -0400)]
formatter: Fix saving/loading project with clip speed rate control

We need to ensure that clips duration is set after time effects are
added and we now need to serialize effects inpoints and max duration.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/177>

4 years agodocs: add some notes on Time in GES
Henry Wilkes [Thu, 21 May 2020 14:42:23 +0000 (15:42 +0100)]
docs: add some notes on Time in GES

These notes cover time coordinates in GES, time effects, time
translations.

It also goes into why keyframes will not work with non-linear time
effects.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/177>

4 years agouri-clip: don't assume duration needs to stay the same
Henry Wilkes [Thu, 21 May 2020 10:25:30 +0000 (11:25 +0100)]
uri-clip: don't assume duration needs to stay the same

ges_uri_clip_asset_get_duration does not tell us what the duration in
the timeline needs to be. Especially when we have time effects, or
effects with finite max-durations. So we should no longer expect the
duration to stay the same when replacing assets. Instead, we just check
that the new max-duration would be compatible with the current in-point
(which was not checked before), and the clip would not be totally
overlapped if its duration-limit changes.

This is based on the assumption that each source is replaced one-to-one
in its track. If a source is replaced with nothing in the same track,
this check may be a little too strong (but still mostly weaker than
before). However, problems could occur if track selection does
something unexpected, such as placing the new source in a track not
previously occupied.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/177>

4 years agoclip: provide an example of using time effects
Henry Wilkes [Wed, 20 May 2020 20:23:03 +0000 (21:23 +0100)]
clip: provide an example of using time effects

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/177>

4 years agotrack-element: use out-point for updating control bindings
Henry Wilkes [Wed, 20 May 2020 20:20:10 +0000 (21:20 +0100)]
track-element: use out-point for updating control bindings

The out-point, which is an internal time, is used instead of the
duration for determining the control binding value at the end of the
element.

Also, allow the user to switch off the auto-clamping of control sources
if they are not desired. And allow them to clamp specific control sources
individually.

Also, fix a lot of memory leaks related to control sources. In
particular, releasing the extra ref gained by source in
g_object_get (binding, "control-source", &source, NULL);

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/177>

4 years agoclip: test for layer in group
Henry Wilkes [Fri, 15 May 2020 17:09:50 +0000 (18:09 +0100)]
clip: test for layer in group

Make sure the layer exists before we try to remove the grouped clips
from it.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/177>

4 years agotimeline-tree: make sure the layer priority refers to an existing layer
Henry Wilkes [Fri, 15 May 2020 13:58:08 +0000 (14:58 +0100)]
timeline-tree: make sure the layer priority refers to an existing layer

If a layer priority sits between the priorities of two layers in the
timeline, i.e. it references a gap in the timeline's layers, then
ges_timeline_append_layer will never fill this gap and create the
desired layer, so the edit in timeline-tree would loop forever. So a
check was added to avoid this.

This would be a usage error, but a user can reasonably end up with a gap
in their layers if they remove a layer from the timeline.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/177>

4 years agoclip: add method for adding top effects
Henry Wilkes [Fri, 15 May 2020 13:53:49 +0000 (14:53 +0100)]
clip: add method for adding top effects

Unlike ges_container_add, this lets you set the index and will check
that track selection did not fail. This is useful for time effects whose
addition would create an unsupported timeline configuration.

Also can use the clip add error in ges_timeline_add_clip to let the user
know when adding a clip to a layer that its in-point is set larger than
the max-duration of its core children.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/177>

4 years agotimeline-tree: take time effects into account when trimming
Henry Wilkes [Fri, 15 May 2020 13:47:15 +0000 (14:47 +0100)]
timeline-tree: take time effects into account when trimming

When trimming the start of a clip, we want to set the in-point of its
children such that whatever data was at the timeline time T still
remains at the timeline time T after the trim, where
  T = MAX (prev_start, new_start)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/177>

4 years agoclip: use time translation for split
Henry Wilkes [Fri, 15 May 2020 13:41:58 +0000 (14:41 +0100)]
clip: use time translation for split

The new in-point should be the media position corresponding to the media
position. media_duration_factor is no longer needed.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/177>

4 years agoclip: fix warning when getting duration-limit
Henry Wilkes [Mon, 18 May 2020 16:34:01 +0000 (17:34 +0100)]
clip: fix warning when getting duration-limit

The duration-limit case was missing a 'break;' statement.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/177>

4 years agoclip: add methods to convert between time coordinates
Henry Wilkes [Tue, 12 May 2020 17:18:09 +0000 (18:18 +0100)]
clip: add methods to convert between time coordinates

Add methods to convert between the timeline time coordinates and the
internal time coordinates of a track element in a clip, taking time
effects into account.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/177>

4 years agoeffect: Add support for time effects
Henry Wilkes [Fri, 15 May 2020 13:28:09 +0000 (14:28 +0100)]
effect: Add support for time effects

Allow the user to register a child property of a base effect as a time
property. This can be used by GES to correctly calculate the
duration-limit of a clip when it has time effects on it. The existing
ges_effect_class_register_rate_property is now used to automatically
register such time effects for rate effects.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/177>

4 years agoerrors: added edit errors
Henry Wilkes [Fri, 15 May 2020 13:25:01 +0000 (14:25 +0100)]
errors: added edit errors

Added more errors to GES_ERROR for when edits fail (other than
programming or usage errors). Also promoted some GST messages if they
related to a usage error.

Also added explanation of timeline overlap rules in user docs.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/177>

4 years agotests: Stop recording gaps in seek_with_stop
Thibault Saunier [Fri, 15 May 2020 16:19:16 +0000 (12:19 -0400)]
tests: Stop recording gaps in seek_with_stop

We have little control over those as they are generated by streamsynchronizer in a not reproducible way

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/175>

4 years agodocs: Remove reference to deinterlacing props in title and video test source
Thibault Saunier [Fri, 15 May 2020 15:53:10 +0000 (11:53 -0400)]
docs: Remove reference to deinterlacing props in title and video test source

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/175>

4 years agovalidate: Fix setting ges properties
Thibault Saunier [Fri, 15 May 2020 22:33:46 +0000 (18:33 -0400)]
validate: Fix setting ges properties

And fix typos.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/175>

4 years agoges: Move TimeOverlayClip out of GESTestClip
Thibault Saunier [Wed, 22 Apr 2020 17:39:21 +0000 (13:39 -0400)]
ges: Move TimeOverlayClip out of GESTestClip

This was complexifying the implementation for very little gain.
Each source type should ideally have its own API.

In that patch we make it so we do not have to subclass anything
but instead use GESAsset to pass information about how the pipeline
should look like.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/175>