Jaeun Choi [Mon, 8 Apr 2019 09:35:57 +0000 (18:35 +0900)]
elm_panel/efl_ui_panel: disable scrolling when obj is disabled
panels were still scrollable while disabled.
this patch fixes it.
Hermet Park [Mon, 8 Apr 2019 06:02:47 +0000 (15:02 +0900)]
evas map: disable anti_aliasing.
We need a proper interface to toggle high-quality mapping,
until that, we disable the anti_aliasing feature.
Since adjecent polygons(such as textpath) shouldn't get this aa feature.
Hermet Park [Mon, 8 Apr 2019 05:53:47 +0000 (14:53 +0900)]
evas map: remove redundant code.
Remove old anti-alias code since high quality map is replaced with new one.
New anti-aliasing is logically same but having a regression bug,
it should be stablized.
Hermet Park [Mon, 8 Apr 2019 04:21:07 +0000 (13:21 +0900)]
canvas map: introduce a new texture mapping for better quality.
Summary:
This new implementation of evas map texture mapping
is designed for high quality rendering same level to GL.
If you use a high-end device, performance is not too bad, you can turn this on.
You might have practical image quality even in software rendering.
Since this implementation still have a few optimization points (+simd)
and stablizings, it may be useful in somewhat limited envrionments right now.
However the functionality definitely works fine, so please turn this on by
demand (anti_alias + smooth) for a while.
{
F3667773} {
F3667776} {
F3667778}
Reviewers: #committers, devilhorns, raster
Reviewed By: #committers, raster
Subscribers: raster, devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8106
Mike Blumenkrantz [Mon, 8 Apr 2019 04:19:56 +0000 (13:19 +0900)]
tests: add evas render test for callbacks
Summary:
verify that all callbacks can be incrementally added and triggered during a
sync render (which is the rendering used in unit testing)
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl_tests
Differential Revision: https://phab.enlightenment.org/D8505
Hermet Park [Mon, 8 Apr 2019 04:15:45 +0000 (13:15 +0900)]
canvas vg: code refactoring.
Summary: Remove unnecessary argument of an internal function.
Reviewers: #committers, jsuya, cedric
Reviewed By: #committers, cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8530
Wonki Kim [Mon, 15 Apr 2019 07:10:33 +0000 (16:10 +0900)]
scroll_mgr: fix a type for some vars to be portable
Summary:
char type can be singed or unsinged according to the standard.
variables for keeping sign value should be sign, and that is the reason
why this patch modify a type for some variables explictly.
Reviewers: eagleeye
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8604
Change-Id: I26054743fe8c184cc02b49bebe0301214c162e94
Hosang Kim [Fri, 12 Apr 2019 11:04:29 +0000 (20:04 +0900)]
efl_ui_widget: _on_sub_obj_hide callback should be called when object is
hidden.
Change-Id: I2802dba654060e3a228e4a0baa6b73f30adfb887
Woochanlee [Fri, 12 Apr 2019 05:56:03 +0000 (14:56 +0900)]
efl_ui_widget: Fix disabled set calling without meaning.
The efl_ui_widget_disabled_set calling even the state is not change when widget create and destroy.
It broken backward compatibility.
T7799
@fix
https://phab.enlightenment.org/D8600
Change-Id: Ib3be163cebf77e86f1aaa510e75454611d6911ce
Myoungwoon Roy, Kim [Fri, 12 Apr 2019 04:58:37 +0000 (13:58 +0900)]
efl: Fix dereference null return value
Change-Id: I7f22cb7dbcd70f0124d2f95b381075cb07f6acad
Inhong Han [Tue, 9 Apr 2019 10:42:00 +0000 (19:42 +0900)]
ecore_imf: change the description of preedit_type
Change-Id: I54f4efb4afaece4ed3ffbff9d841d237e587de30
Shinwoo Kim [Tue, 12 Mar 2019 06:34:59 +0000 (15:34 +0900)]
Remove and update deprecated API
[Remove]
ecore_input_joystick_init
ecore_input_joystick_shutdown
elm_ctxpopup_direction_available_get
elm_win_profiles_set
[Update]
evas_out_add
evas_output_del
evas_output_view_set
evas_output_view_get
Change-Id: I6a9c49801fc395526bf375922625f50a13e38dd9
Jaehyun Cho [Fri, 5 Apr 2019 02:30:05 +0000 (11:30 +0900)]
elementary: fix not to call duplicate theme set
Summary:
Theme is set during finalize in Efl.Ui.Layout_Base.
Therefore, it is not necessary to call theme set function if the widget
inherits Efl.Ui.Layout_Base and its klass is properly set.
Reviewers: zmike, bu5hm4n, eagleeye, akanad, SanghyeonLee, woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8559
Change-Id: I5401c827bb9c7b46e675e01c57e9ca8508580b89
Hermet Park [Mon, 8 Apr 2019 06:02:47 +0000 (15:02 +0900)]
evas map: disable anti_aliasing.
We need a proper interface to toggle high-quality mapping,
until that, we disable the anti_aliasing feature.
Since adjecent polygons(such as textpath) shouldn't get this aa feature.
Change-Id: I8667d728f07a41539ae9c312eee763204e79c16e
Hermet Park [Mon, 8 Apr 2019 05:53:47 +0000 (14:53 +0900)]
evas map: remove redundant code.
Remove old anti-alias code since high quality map is replaced with new one.
New anti-aliasing is logically same but having a regression bug,
it should be stablized.
Change-Id: Idd654768d24b15c15ce035e958fceece15ae4ece
Hermet Park [Mon, 8 Apr 2019 04:16:24 +0000 (13:16 +0900)]
efl_ui_textpath : enable anti-alising for better quality.
Summary:
Current textpath on sw rendering is too jiggled,
quaility is very poor to use.
This option uses better quality texture mapping logic
in order to improve the image quality.
Depends on D8106
Reviewers: #committers
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8465
Change-Id: I572c3fc6c65880807e91fbfb0abd70d7cabfcb8b
Hermet Park [Mon, 8 Apr 2019 04:21:07 +0000 (13:21 +0900)]
canvas map: introduce a new texture mapping for better quality.
Summary:
This new implementation of evas map texture mapping
is designed for high quality rendering same level to GL.
If you use a high-end device, performance is not too bad, you can turn this on.
You might have practical image quality even in software rendering.
Since this implementation still have a few optimization points (+simd)
and stablizings, it may be useful in somewhat limited envrionments right now.
However the functionality definitely works fine, so please turn this on by
demand (anti_alias + smooth) for a while.
{
F3667773} {
F3667776} {
F3667778}
Reviewers: #committers, devilhorns, raster
Reviewed By: #committers, raster
Subscribers: raster, devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8106
Change-Id: I52a50097afb3fd3c427d9026387452383971b5c6
Wonki Kim [Mon, 8 Apr 2019 03:58:18 +0000 (12:58 +0900)]
spec: modify hard-coded version name according to changes on upstream
there is a hard-coded filename for specify a file to archieve as rpm package.
this patch modify it according to changes version name on upstream.
Change-Id: I6f1323ef9543bdd70e4896c541f4f439837bd162
Carsten Haitzler (Rasterman) [Sun, 7 Apr 2019 13:47:35 +0000 (14:47 +0100)]
tests - remove one of the eina strtod tests as libc is failing
see the comments above the test explaining why it's removed (libc
fails, not eina and having our tests fail because eina is a bit more
robust than libc is not a sane thing to have). but here is the comment
for git history spelunking:
this test isn't viable because libc actually fails the conversion (testing
glibc 2.28 on arch linux). either libc doesn't like the space at the start
thus doesn't skip it but assumes END of numbver string thus not converting
and returning NULL, or it doesn't like InFiNiTyfoo in some way, but either
way this test shows eina to be more robust and do some kind of conversion
and libc to fail and return NULL from strtod into the string pointer. it
also doesnt return an infinite fp thus hitting the default: case and thus
failing etc. ... so all in all remove the test as all it does it cause
failures and if anything shows libc to be failing more than eina.
@fix
Carsten Haitzler (Rasterman) [Sun, 7 Apr 2019 13:14:55 +0000 (14:14 +0100)]
tests - fix check header to always include eina due to windows
windows means HAVE_FORK is false... thus missing eina.h and now we
have macros that use eina calls always... so this fixes nbuild of
tests on windows
@fix
Carsten Haitzler (Rasterman) [Sun, 7 Apr 2019 12:08:40 +0000 (13:08 +0100)]
remove vpath test for user dir the test was broken and fixing is insane
so this test fails on windows as getuid isn't there... so this fixes
the windows bild: fix T7728 ... but it also would have failed if $HOME
didn't match what was in the passwd file, and other fallback cases if
they were triggered.
but ... to make this test stay it would have to also change the logic
- check $HOME env first, then pwent entry, if that fails /tmp/UID and
if that fails use /tmp ... the test would effectively be a copy &
paste of the vpath code at which point this is really pointless where
testing is copying the exact (or almost exat) same code into the test.
this is ignoring the #ifdef fun of martching ifdefs that vary on
windows.
the problem is this kind of api is defined very much by the system it
runs on and the environment and situation, so the test has to be as
complex. realistically, instead of copying & pasting the code across
and now having 2 bits of code to possibly mantain (change the lib src
then the test needs changes too as it's a copy & paste), it's just
saner not to have a test for this kind of siutation and accept the
reality of the situation.
@fix
Cedric BAIL [Tue, 2 Apr 2019 22:24:03 +0000 (15:24 -0700)]
eio: do not fail in case of early ECANCEL.
Actually with directory that contain a lot of file and the right order for them,
you would end up getting what you are looking for before you have triggered all
the future callback. In that case, all the future callback are cancelled and
we will get that notification. The test is not failing in this case as we already
got what we wanted.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8541
Cedric BAIL [Thu, 28 Mar 2019 21:09:54 +0000 (14:09 -0700)]
elementary: fix error path during shutdown of fileselector.
During shutdown, sometimes, we can have an error generated on the object
while it is invalidating, but before it is invalidated. This lead to
properties on the object to change to an error state and trigger the
properties changed logic. At this point, the parent has already been
destroyed and we don't really have anything more to do. So let's not
do anything.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8502
Cedric BAIL [Thu, 28 Mar 2019 19:44:31 +0000 (12:44 -0700)]
elementary: it seems I forgot to initialize some meaningful boolean.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8501
Jaehyun Cho [Fri, 5 Apr 2019 04:05:37 +0000 (04:05 +0000)]
elementary: fix not to call duplicate theme set
Theme is set during finalize in Efl.Ui.Layout_Base.
Therefore, it is not necessary to call theme set function if the widget
inherits Efl.Ui.Layout_Base and its klass is properly set.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D8559
Mike Blumenkrantz [Sat, 6 Apr 2019 00:17:27 +0000 (20:17 -0400)]
add EFL_VERSION_1_23 define
Mike Blumenkrantz [Sat, 6 Apr 2019 00:16:44 +0000 (20:16 -0400)]
add EFL_VERSION_1_22 defines
whoops
Mike Blumenkrantz [Sat, 6 Apr 2019 00:13:54 +0000 (20:13 -0400)]
back to dev mode
Mike Blumenkrantz [Fri, 5 Apr 2019 23:12:33 +0000 (19:12 -0400)]
release: Update NEWS and bump version for 1.22.0 release
Vitor Sousa [Fri, 5 Apr 2019 22:59:34 +0000 (19:59 -0300)]
efl-csharp: fix crash when events trigger after C# object `Dispose`
Summary:
Rework general event handling to check individually each event call, if the
object is not alive then the event will not be propagated.
WeakReferences (and lambdas capturing those WeakRefs) are used to ensure this.
Dispose methods in object now take care of checking if efl libraries are still
initialized and thread-safely unregister each event before performing an
efl_unref on the Eo object.
Event handling in C# is now centered around a single dictionary inside the
object: `EoEvents`.
C# event triggers now properly trigger events on C too.
Standardize C# event-triggering methods names (remove underscores).
Some diminished use of static memory due events no longer requiring static key
objects to be registered/unregistered.
Some fixing of white space generation for generated events.
Depends on D8431
Reviewers: lauromoura, felipealmeida, segfaultxavi
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8564
Vitor Sousa [Fri, 5 Apr 2019 22:57:29 +0000 (19:57 -0300)]
efl-csharp: fix resource deallocation causing errors everywhere
Summary:
This commit mainly fixes errors caused by deallocating resources in the garbage
collector thread. Using `ecore_main_loop_thread_safe_call_async` to queue
resource deallocation in the main thread seems to solve it.
Also, some `efl_ref` calls are added in places they were missing, mainly
objects that unref in the destructor thus taking ownership if efl_ref is not
called.
Also fix improper resource deallocation in tests that were causing it to crash,
enabling it to call Efl.All.Shutdown again. This allocation and the deallocation
process was moved from the Eo class constructor to static class methods that are
called in the test 'set up' and 'tear down' methods.
Queuing resource deallocation in the main thread make it mandatory that tests
call `Efl.App.AppMain.Iterate()` if they want to check proper resource
deallocation (like TestFunctionPointers.set_callback_inherited_called_from_c).
Extras:
Remove duplicated declaration of 'eflcustomexportsmono' in meson in order to fix
some linking problems.
Remove some unused code around deallocation functions that had to be reworked.
Object allocation is now supplied with the call site information it expects
(file name and line for _efl_add_start).
Depends on D8550
Test Plan: meson test
Reviewers: felipealmeida, lauromoura, cedric, segfaultxavi
Reviewed By: lauromoura
Subscribers: segfaultxavi
Tags: #efl_language_bindings, #do_not_merge
Differential Revision: https://phab.enlightenment.org/D8431
Lauro Moura [Fri, 5 Apr 2019 22:53:37 +0000 (19:53 -0300)]
csharp: Make classes abstract and rework casting
Summary:
Abstract Eo classes are now proper C# abstract classes.
As a side effect, returning Eo instances from native code was reworked
to return instances of their actual Eo classes instead of previous
behavior of returning a generic Efl.Object and using static_cast.
Instead of `var window = Efl.Ui.Win.static_cast(widget.GetParent());`
Use `var window = widget.GetParent() as Efl.Ui.Win;`
Another side effect was that `efl_constructor` was removed from the list
of supported `Efl.Object` overrides. It is invoked inside
`efl_add_internal_start`, before the bindings makes the association of
the newly created EoId with the C# instance that created it, making the
managed delegate meaningless. C# users then can use regular C#
constructors to initialize fields.
Also changed to set the private data of C#-inherited classes before the
call to constructing methods (aka constructor parameters) so C# classes
can override them correctly.
Fixes T7778
Fixes T7757
Reviewers: vitor.sousa, felipealmeida, segfaultxavi
Reviewed By: vitor.sousa, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7778, T7757, T7702
Differential Revision: https://phab.enlightenment.org/D8550
Marcel Hollerbach [Fri, 5 Apr 2019 12:15:39 +0000 (08:15 -0400)]
meson: correctly use the correct dependency
Summary:
edje_cc calls epp, so we should not only add edje_cc to the depends on
target, but rather also ensure that epp is availble. Additionally, this
removes unneccessary depends on declarations when we do cross compile.
Depends on D8561
Reviewers: zmike, segfaultxavi, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8562
Xavi Artigas [Thu, 4 Apr 2019 17:06:05 +0000 (19:06 +0200)]
docs: Exclude *.NativeStruct from DocFX pages
These are for internal use only.
Also, make filtering rules a bit more robust.
Vincent Torri [Thu, 4 Apr 2019 14:39:05 +0000 (10:39 -0400)]
dist rule: add files to EXTRA_DIST2 inconditionally
Summary: ecore_con and ethumb were adding files to EXTRE_DIST confitionally
Reviewers: cedric, zmike, raster
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8558
Wonki Kim [Thu, 4 Apr 2019 13:14:08 +0000 (09:14 -0400)]
efreetd: remove a tentative global variable definition
Summary:
there is a global variable that is defined tentatively.
this patch modify it not to be tentitive explictly.
Reviewers: raster, cedric, zmike
Reviewed By: raster, zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8551
Mike Blumenkrantz [Wed, 3 Apr 2019 19:53:24 +0000 (15:53 -0400)]
autotools: add another entry test file to dist
Reviewers: vtorri
Reviewed By: vtorri
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8549
Mike Blumenkrantz [Wed, 3 Apr 2019 18:19:04 +0000 (14:19 -0400)]
autotools: add entry test file to dist
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8547
Christopher Michael [Wed, 3 Apr 2019 17:08:59 +0000 (13:08 -0400)]
efl_ui_test_callback: Removed defined but unused function
Hosang Kim [Wed, 3 Apr 2019 13:26:50 +0000 (09:26 -0400)]
evas_callbacks: fix emission of EFL_GFX_ENTITY_EVENT_VISIBILITY_CHANGED
Summary:
When I add "efl_event_callback_add(btn, EFL_GFX_ENTITY_EVENT_VISIBILITY_CHANGED, _cb, NULL)",
_cb is not called. Because of callback_mask is not set correctly.
Test Plan: unit test
Reviewers: zmike, cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8528
Marcel Hollerbach [Tue, 2 Apr 2019 18:50:43 +0000 (14:50 -0400)]
elm_fileselector: disable this test for now
Summary:
this test fails on travis, for the sake of the release we continue
without this tests, after the release we can enable this again with or
without failing tests.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8538
Carsten Haitzler (Rasterman) [Tue, 2 Apr 2019 17:24:04 +0000 (18:24 +0100)]
evas image - fix proxy change propagation to fix e video wallpapers
this fixes propagati[on of changes from img sources to proxies which
broke e's video wallpapers. fixes T7685
Woochanlee [Tue, 2 Apr 2019 16:39:23 +0000 (18:39 +0200)]
C# bindings: Make efl_gesture_Manager.eo available to bindings
Summary:
It was missing.
The efl_gesture_manager has to using in efl_sharp.
Reviewers: zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7550
Differential Revision: https://phab.enlightenment.org/D7249
Jaehyun Cho [Tue, 2 Apr 2019 14:51:05 +0000 (16:51 +0200)]
mono: fix space and brace warnings of StyleCop
Summary:
The following warning rules of StyleCop are checked.
Space rules : SA1000, SA1003, SA1008, SA1009, SA1010, SA1011
Brace rules : SA1500, SA1501, SA1502, SA1503, SA1513
Indentation is also applied.
Reviewers: lauromoura, felipealmeida, vitor.sousa, woohyun
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8485
Lauro Moura [Tue, 2 Apr 2019 14:47:36 +0000 (16:47 +0200)]
csharp: Raise exception when Array is null.
Reviewers: felipealmeida, vitor.sousa, segfaultxavi
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8499
Vincent Torri [Tue, 2 Apr 2019 14:09:24 +0000 (10:09 -0400)]
remove useless check of ws2tcpip.h
Summary: it is useless to check for header files which necessarly exist
Test Plan: compilation
Reviewers: raster, cedric, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8535
Carsten Haitzler (Rasterman) [Tue, 2 Apr 2019 12:57:58 +0000 (13:57 +0100)]
elm naviframe - remove duplicated func prototype in headers
one hade EAPI, one did not and there were 2 anyway, so remove one and
ensure the other has EAPI and the same docs. this should fix T7776
Xavi Artigas [Tue, 2 Apr 2019 12:57:35 +0000 (08:57 -0400)]
docs: Update refs to Efl.Ui.Theme.Apply_Error
Summary:
Proper refs to particular errors cannot be added until T7736 is resolved.
Ref T7717
Test Plan: Only docs updated
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7717
Differential Revision: https://phab.enlightenment.org/D8495
Xavi Artigas [Tue, 2 Apr 2019 12:57:19 +0000 (08:57 -0400)]
docs: Format efl_file.h
Summary:
And polish a bit.
Ref T7717
Test Plan: Only docs updated
Reviewers: zmike
Reviewed By: zmike
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7717
Differential Revision: https://phab.enlightenment.org/D8498
Marcel Hollerbach [Tue, 2 Apr 2019 12:56:28 +0000 (08:56 -0400)]
efl_check: add API to expect a error
Summary:
sometimes it is not enough to just disable aborting on critical error
messages. Sometimes it is better to explicitly expect an error, and fail
the testcase if there is no error.
This is used in later commits here.
Depends on D8417
Reviewers: YOhoho, segfaultxavi, zmike, woohyun, Jaehyun_Cho
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8519
Vincent Torri [Tue, 2 Apr 2019 12:52:17 +0000 (08:52 -0400)]
configure.ac : remove definition of HAVE_ECORE_AUDIO_WASAPI as it is never used
Summary: HAVE_WIN32 is used instead of HAVE_ECORE_AUDIO_WASAPI
Test Plan: compilation
Reviewers: raster, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8532
Vincent Torri [Tue, 2 Apr 2019 12:52:11 +0000 (08:52 -0400)]
elm: allow config_embed to be run out of tree
Test Plan: compilation
Reviewers: raster, cedric, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8533
Marcel Hollerbach [Tue, 2 Apr 2019 12:50:54 +0000 (08:50 -0400)]
ecore: correctly clean up in ecore_fork_reset
Summary:
after a fork does happen, the new process does not have any self created
threads at all. However, _thread_cb can contain suspend calls of
ecore_thread_main_loop_begin. _ecore_main_call_flush will then wait in
the suspend block for the thread to call ecore_thread_main_loop_end.
However, the thread is dead, the end function will never be called.
Hence we should ensure that we definitly kill every entry in _thread_cb
that has a susped flag on true.
This fixes deadlocks while running the testsuites with
EIO_MONITOR_POLL=1
Depends on D8526
Reviewers: cedric, segfaultxavi, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8531
Marcel Hollerbach [Tue, 2 Apr 2019 12:50:48 +0000 (08:50 -0400)]
eio: ensure that the monitor starts when it is called to
Summary:
we need to to this here, otherwise we effectfily start the monitor
later, which means, we can miss a change in the filesystem. However,
this makes things a lot slower.
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8526
Marcel Hollerbach [Tue, 2 Apr 2019 12:50:34 +0000 (08:50 -0400)]
efl_io_model: start early on monitoring
Summary:
Little introduction into what eio did before this commit:
Efl.Io.Model creation:
- direct ls of a directory in a thread (A)
- take all the contents of a directory and feed it slowly back into
the mainloop
- when all events have been feeded back to the mainloop and have been
processed: start monitoring (B)
However, any file created between (A) and (B) will not be in the model,
since not the listing nor the monitoring did caputure it. Hence we need
to start monitoring before we actaully start listing. In the callbacks
we then check if we already published something.
ref T7311
Reviewers: zmike, cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7311
Differential Revision: https://phab.enlightenment.org/D8525
Mike Blumenkrantz [Tue, 2 Apr 2019 12:34:14 +0000 (08:34 -0400)]
tests: unset eina log callback at end of each efl_app promise test
Summary: ensure that this doesn't trigger cascading errors
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8514
Xavi Artigas [Tue, 2 Apr 2019 11:28:48 +0000 (13:28 +0200)]
docs: Fix common misspellings in H files
Fixed all appearances of words from this list in H files:
https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines
Xavi Artigas [Tue, 2 Apr 2019 09:32:05 +0000 (11:32 +0200)]
docs: Fix common misspellings in EO files
Fixed all appearances of words from this list in EO files:
https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines
Lauro Moura [Mon, 1 Apr 2019 22:06:20 +0000 (22:06 +0000)]
eo: Correctly name Realized classes.
The previous preprocessor rule was generating strings like
"\"Efl.App\"_Realized.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8527
Jaehyun Cho [Tue, 2 Apr 2019 07:39:40 +0000 (16:39 +0900)]
Revert "efl_ui_pager: implement unpack_at function"
This reverts commit
913a5bff66dd7a58753ccae1474657ec33350e43.
The commit is reverted because the commit implements features during
feature freeze period before release.
913a5bff66dd7a58753ccae1474657ec33350e43 will be restored after release.
Jaehyun Cho [Tue, 2 Apr 2019 07:36:20 +0000 (16:36 +0900)]
Revert "efl_ui_pager: implement unpack_all/clear function"
This reverts commit
74c48f029632d2260816b4cb3de6dbb40a29f040.
The commit is reverted because the commit implements features during
feature freeze period before release.
74c48f029632d2260816b4cb3de6dbb40a29f040 will be restored after release.
Jaehyun Cho [Tue, 2 Apr 2019 07:35:12 +0000 (16:35 +0900)]
Revert "test/efl_ui_pager_scroll: fix demo"
This reverts commit
30bd541bf264d369e2a96d27fa3ff5139c360e26.
The commit is reverted to revert the following commits.
74c48f029632d2260816b4cb3de6dbb40a29f040
913a5bff66dd7a58753ccae1474657ec33350e43
The above commits will be restored after release and then
30bd541bf264d369e2a96d27fa3ff5139c360e26 will be also restored.
Jaehyun Cho [Tue, 2 Apr 2019 07:29:11 +0000 (16:29 +0900)]
Revert "test/efl_ui_pager: fix demo"
This reverts commit
d3bb1a7342b2725c585d90557926e0c433058e50.
The commit is reverted to revert the following commits.
74c48f029632d2260816b4cb3de6dbb40a29f040
913a5bff66dd7a58753ccae1474657ec33350e43
The above commits will be restored after release and then
d3bb1a7342b2725c585d90557926e0c433058e50 will be also restored.
Jaehyun Cho [Tue, 2 Apr 2019 07:27:35 +0000 (16:27 +0900)]
Revert "elm - fix harmless warning for clean build"
This reverts commit
e3d2a0cf1235beceb3b403e42d2dafed4b4e90e5.
The commit is reverted to revert the following commit.
74c48f029632d2260816b4cb3de6dbb40a29f040
The above commit will be restored after release and then
e3d2a0cf1235beceb3b403e42d2dafed4b4e90e5 will be also restored.
Hosang Kim [Fri, 5 Apr 2019 08:43:59 +0000 (17:43 +0900)]
ecore_wl2_window: check if callback exists before adding it.
Change-Id: I86f41a3a04c0fdde1a73e4469264530e63ee02f0
Wonki Kim [Wed, 3 Apr 2019 07:11:20 +0000 (16:11 +0900)]
meson: Add missed public headers
those header files are necessary files to be installed.
so that this patch added them
Change-Id: I833768e6dd565bb33e5084fda2db9a4c98b1dcd3
Wonki Kim [Wed, 3 Apr 2019 06:12:17 +0000 (15:12 +0900)]
spec: fix a build break
edje_cc uses embryo_cc internally which has been removed before.
so that this patch fixes it.
Change-Id: Ie55bd74ab925167209b73da75cae5ab9f2b8a702
Wonki Kim [Wed, 3 Apr 2019 05:23:11 +0000 (14:23 +0900)]
spec: fix build break by broken dependency
edje-devel had a depedency to edje-tools, but it has been removed.
so that this patch restore it to fix build break
Change-Id: I3bdfca02608739252864c50c68fb13dd062a384c
Hermet Park [Wed, 3 Apr 2019 05:20:40 +0000 (14:20 +0900)]
efl_ui_animation: don't access a null pointer.
Change-Id: Ica448b5b7dd97cfaa5ef5644f692caacf48aa986
Bowon Ryu [Tue, 2 Apr 2019 12:40:22 +0000 (21:40 +0900)]
elm_label: fix build break for legacy api.
this commit related with
b8d3be5aa02b846d42961f74490e02448ef30d1d
@tizen_fix
Change-Id: If2154fe566384ae8dac6c8662d1466700c55f6d9
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
JunsuChoi [Wed, 3 Apr 2019 04:35:01 +0000 (13:35 +0900)]
elm_entry: prevent from accessing null pointer
Summary: change ELM_ENTRY_DATA_GET to ELM_ENTRY_DATA_GET_OR_RETURN_VAL
Test Plan: elm_entry_file_set(NULL, ~~~);
Reviewers: YOhoho, Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8544
Change-Id: I728a485db981b8c54a03476d1daee1e0c8c246bb
Hermet Park [Wed, 27 Mar 2019 07:24:54 +0000 (16:24 +0900)]
vg json: code refactoring.
just rename internal variable.
Change-Id: I0771455090ad9cb52d657585b03be696f389fd14
Hermet Park [Wed, 27 Mar 2019 07:15:24 +0000 (16:15 +0900)]
vg json: set mask parent to current tree node, not the root.
+ clean up trivial code.
Change-Id: I87d60bbcce1c68cd4e9d85199ab10b051ded2fef
Hermet Park [Tue, 2 Apr 2019 08:28:03 +0000 (17:28 +0900)]
canvas vg: code refactoring.
Remove unnecessary argument of an internal function.
Change-Id: Ib3c216997ba2c2fdaaea6d05738fe4d9f09342aa
Hermet Park [Tue, 2 Apr 2019 06:17:24 +0000 (15:17 +0900)]
canvas vg: fix wrong key pass for caching surface.
There is a wrong case that fails caching ector surfaces.
Those vector objects manually constructing shapes,
passed wrong pointer as the cacahing key instead of root node pointer.
This fixes it.
Change-Id: I5f547e896d1d380b2b7fbad00587609f54ce6ec2
Wonki Kim [Wed, 6 Mar 2019 04:45:38 +0000 (13:45 +0900)]
spec: fix a dependencies for devel package properly
package descriptions for edje-devel, elementary-devel was not described properly
they need libraries itself. so that this patch fix it.
Change-Id: I8daa2490b91546ca1083a2adfa69e0e7a02a55e6
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Wonki Kim [Mon, 1 Apr 2019 07:56:05 +0000 (16:56 +0900)]
spec: exclude unused binaries.
this pathc excludes some binaries from the packiging list
Change-Id: Ic967ad3846ce60d0c53b3c85296b0261dbe71be3
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Wonki Kim [Tue, 2 Apr 2019 07:50:21 +0000 (16:50 +0900)]
meson: fix a meson option to install eo files
as before, eo files are installed as default,
however, after some commit, it doesn't for now.
this patch fixes a meson option to install those files.
Change-Id: I1060ba5476533f479a18b86df020a7e051792cdb
JunsuChoi [Tue, 2 Apr 2019 07:39:56 +0000 (16:39 +0900)]
migratino: remove beta tags
@tizen_fix
Change-Id: If2b152273cc9d3fa31a8eac59810e4db7f7cdad5
Jaehyun Cho [Tue, 2 Apr 2019 06:33:04 +0000 (15:33 +0900)]
elm_widget_item_eo.legacy: change @ingroup to Elm_General
The @ingroup of elm_object_item APIs is Elm_General in elm_object_item.h.
Since legacy prefix of Elm_Widget_Item is elm_object_item,
the prefix of Elm_Widget_Item APIs is elm_object_item.
Consequently, to display the legacy Elm_Widget_Item APIs with
elm_object_item APIs, the @ingroup is changed from Elm_Object_Item_Group
to Elm_General.
Change-Id: Ic023a57f15ee3968fb0a5cfa09d9ab33c4adf420
Christopher Michael [Mon, 1 Apr 2019 14:31:08 +0000 (10:31 -0400)]
ecore-drm2: Add missing @ingroup for some doxy
Small patch to add missing @ingroup for doxygen comments, and correct
one that was in the wrong group
@fix
Christopher Michael [Mon, 1 Apr 2019 14:02:57 +0000 (10:02 -0400)]
efl_ui_selection_manager: Don't leak malloc'd data
Summary:
Coverity reports that we potentially leak char *s here. If we do not
have 'data_ret', then the malloc'd 's' sould be freed as we are not
going to use it.
Fixes Coverity CID1396949
@fix
Reviewers: raster, cedric, bu5hm4n, zmike
Reviewed By: bu5hm4n
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8523
Christopher Michael [Mon, 1 Apr 2019 13:05:57 +0000 (09:05 -0400)]
evas-font-dir: Minor formatting fixes
NB: No functional changes
Carsten Haitzler (Rasterman) [Sat, 30 Mar 2019 16:54:19 +0000 (16:54 +0000)]
elm - fix harmless warning for clean build
Carsten Haitzler (Rasterman) [Sat, 30 Mar 2019 16:49:48 +0000 (16:49 +0000)]
elm - fix harmless warning for clean build
Carsten Haitzler (Rasterman) [Sat, 30 Mar 2019 16:49:21 +0000 (16:49 +0000)]
elm - fix harmless warning for clean build
Yeongjong Lee [Sat, 30 Mar 2019 08:49:57 +0000 (08:49 +0000)]
efl_ui_table_layout: calculate cell size with colspan, rowspan property
We should consider occupied cells by colspan, rowspan property.
ref T7753
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8484
Mike Blumenkrantz [Thu, 28 Mar 2019 15:25:21 +0000 (11:25 -0400)]
build: improve autotools generation of elm config
- don't generate and re-link on every make rule
- fix distcheck
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: YeongJong Lee <yj34.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8506
Boris Faure [Fri, 29 Mar 2019 19:21:55 +0000 (20:21 +0100)]
README.meson: fix typo + rewrap
Mike Blumenkrantz [Fri, 29 Mar 2019 17:58:14 +0000 (18:58 +0100)]
tests: abort on errors during genlist expand test, not warnings
Summary:
log level=2 is the warning level, which is not super useful since
there's currently billions of eo warnings occuring in every function
call
Reviewers: cedric, segfaultxavi
Reviewed By: cedric, segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8515
Mike Blumenkrantz [Fri, 29 Mar 2019 17:50:30 +0000 (18:50 +0100)]
eina_log: reset logging callback to default when null is set as the callback
Summary:
passing null here causes any log message to crash the app and is probably not
the intended result
Reviewers: cedric, segfaultxavi
Reviewed By: cedric, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8513
Ali Alzyod [Fri, 29 Mar 2019 13:52:51 +0000 (09:52 -0400)]
elm_entry: Speedup finding new line, prevent readind invalid memory
Summary:
1- Speed up detecting new lines.
```
if (!strncmp(text, "<br", 3) || !strncmp(text, "<ps", 3))
```
This will cause 6 comparisons (if one of conditions did not meet), or at least 3 comparisons.
this is changed to
```
if (!strncmp(text, "<", 1))
```
2- Speedup detecting lines
If this condition is true, we should increment the string for next iteration 3 times, not just one
```
if (!strncmp(text, "<br", 3) || !strncmp(text, "<ps", 3))
```
if '<' founded then 'pr' or 'br', we will skip 3 characters for next iteration.
```
if (!strncmp(text, "<", 1))
{
text++;
len--;
if (!strncmp(text, "br", 2) || !strncmp(text, "ps", 2))
{
text += 2;
len -= 2;
```
3- Prevent reading invalid memory out of the string
```
if (text[3] == '>' || ((text[3] == '/') && (text[4] == '>')))
```
string could reach last char in string (original string ends with "<br")
but now we will check if remaining string length allow comparison :
```
if (text[0] == '>' || (len > 1 && ((text[0] == '/') && (text[1] == '>'))))
```
Test Plan:
```
static int
oldFunc(const char *text)
{
if (!text)
return 0;
while (*text)
{
if (!strncmp(text, "<br", 3) || !strncmp(text, "<ps", 3))
{
if (text[3] == '>' || ((text[3] == '/') && (text[4] == '>')))
{
return 1;
}
}
text++;
}
return 0;
}
static int
newFunc(const char *text)
{
if (!text)
return 0;
char *pTemp = (char *)text;
while (pTemp = strchr(pTemp, '<'))
{
pTemp++;
if (!strncmp(pTemp, "br", 2) || !strncmp(pTemp, "ps", 2))
{
pTemp += 2;
if (pTemp[0] != '\0' && (pTemp[0] == '>' || (pTemp[0] == '/' && pTemp[1] == '>')))
{
return 1;
}
}
}
return 0;
}
int main()
{
int counter = 1000;
srand(time(NULL));
char pStr[50001] = {0};
char AllChars[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789<>";
int AllCharsLen = strlen(AllChars);
for (int i = 0; i < 50000; i++)
pStr[i] = AllChars[rand() % AllCharsLen];
clock_t start, end;
double total_Time1 = 0;
int i;
for (int j = 0; j < 3; j++)
{
if (j == 0)
{
printf("random String\n");
}
else if (j == 1)
{
printf("With Random <br/>\n");
int location = rand()%(5000 - 5);
pStr[location++] = '<';
pStr[location++] = 'b';
pStr[location++] = 'r';
pStr[location++] = '/';
pStr[location++] = '>';
}
else if (j == 2)
{
printf("With Random <ps>\n");
int location = rand()%(5000 - 4);
pStr[location++] = '<';
pStr[location++] = 'p';
pStr[location++] = 's';
pStr[location++] = '>';
}
start = clock();
for (i = 0; i < counter; i++)
oldFunc(pStr);
end = clock();
total_Time1 = ((double)(end - start)) / CLOCKS_PER_SEC;
printf("original = %f has new Line = %i\n", total_Time1, oldFunc(pStr));
start = clock();
for (i = 0; i < counter; i++)
newFunc(pStr);
end = clock();
total_Time1 = ((double)(end - start)) / CLOCKS_PER_SEC;
printf("modified = %f has new line = %i\n\n", total_Time1, newFunc(pStr));
}
}
```
output:
random String
original = 2.523000 has new Line = 0
modified = 0.090000 has new line = 0
With Random <br/>
original = 0.081000 has new Line = 1
modified = 0.003000 has new line = 1
With Random <ps>
original = 0.016000 has new Line = 1
modified = 0.001000 has new line = 1
Reviewers: zmike, woohyun, bowonryu
Reviewed By: zmike
Subscribers: bu5hm4n, segfaultxavi, zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8497
Xavi Artigas [Fri, 29 Mar 2019 13:12:37 +0000 (14:12 +0100)]
docs: Fix build break because of missed EO import
Xavi Artigas [Fri, 29 Mar 2019 13:08:22 +0000 (14:08 +0100)]
docs: Use Eina.Value references en efl_ui_format docs
Marcel Hollerbach [Fri, 29 Mar 2019 12:25:54 +0000 (13:25 +0100)]
efl_ui_layout: ensure that resize_obj is present before emitting signals
otherwise there will be warnings because of calling api on NULL objects.
Differential Revision: https://phab.enlightenment.org/D8512
Marcel Hollerbach [Tue, 26 Mar 2019 09:15:15 +0000 (10:15 +0100)]
efl_ui_widget: move from elm_widget_top_get to provider_find
this resolves a lot of cases where focus_highlight API was called on a
object, which is not a efl_ui_win object. With this patch we ensure that
the object is always a window.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D8476
Marcel Hollerbach [Tue, 26 Mar 2019 08:59:16 +0000 (09:59 +0100)]
efl_ui_widget: add implementation for finding the window
the problem with the previous implementation (just redirect the calls to
the widget_parent then to the efl_parent is that after invalidate its
impossible to find the window where the widget is in. However, there are
cases where we want to have access to the window of the widget, for
example, to invalidate focus highlight etc..
The window of a widget is always constant, and cannot be changed (as the
evas object cannot hop accross different evas)
Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Differential Revision: https://phab.enlightenment.org/D8475
Xavi Artigas [Thu, 28 Mar 2019 16:12:27 +0000 (16:12 +0000)]
docs: Efl.Ui.Layout_Base update theme docs
If docs are present at property and set/get levels only one is used.
Ref T7717
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8494
Xavi Artigas [Fri, 29 Mar 2019 09:30:44 +0000 (09:30 +0000)]
docs: Clarify Efl.Ui.Win exit_on_close methods
exit_on_close and exit_on_all_windows_closed deserve a bit of clarification
since they have very similar meanings.
Also, add proper Eina.Value doc references.
Ref T7717
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8511
Xavi Artigas [Fri, 29 Mar 2019 09:25:02 +0000 (09:25 +0000)]
docs: Add Eina.Value extern to eina_types.eot
Eina.Values are built-in eolian types, accessed through any_value and
any_value_ptr. However, these types cannot be used in doc references.
Adding a placeholder extern struct Eina.Value causes no harm, and will allow
referencing the type from EO docs later on.
In C#, Eina.Value is defined in the manual binding code so the doc reference
resolves to a valid type.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8510