commit-bot@chromium.org [Tue, 29 Oct 2013 15:32:09 +0000 (15:32 +0000)]
commit-bot@chromium.org [Tue, 29 Oct 2013 15:02:17 +0000 (15:02 +0000)]
DM: add --quiet
This has been handy when tossing in other SkDebugf's.
BUG=
R=bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
49323007
git-svn-id: http://skia.googlecode.com/svn/trunk@11998
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 29 Oct 2013 14:06:15 +0000 (14:06 +0000)]
Don't reuse scratch textures patch
https://codereview.chromium.org/
24222004/
git-svn-id: http://skia.googlecode.com/svn/trunk@11997
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 29 Oct 2013 13:59:31 +0000 (13:59 +0000)]
Fix bug in erosion filtering
https://codereview.chromium.org/
50813002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11996
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 29 Oct 2013 13:55:29 +0000 (13:55 +0000)]
svndiff for the windows
R=epoger@google.com
Review URL: https://codereview.chromium.org/
49323006
git-svn-id: http://skia.googlecode.com/svn/trunk@11995
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 29 Oct 2013 07:01:50 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11992
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Oct 2013 22:05:41 +0000 (22:05 +0000)]
Fix narrowing conversion errors from r11986
Although this function only gets used for SkMScalar=float, it gets
compiled in when SkMScalar=double.
R=epoger@google.com
BUG=1764
Author: enne@chromium.org
Review URL: https://codereview.chromium.org/
49463005
git-svn-id: http://skia.googlecode.com/svn/trunk@11991
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Oct 2013 22:05:12 +0000 (22:05 +0000)]
A fix for annoying clang error "unused-const-variabl" in third_party code.
../../third_party/externals/libwebp/src/enc/quant.c:105:23: error: unused variable 'kCoeffThresh' [-Werror,-Wunused-const-variable]
static const uint16_t kCoeffThresh[16] = {
^
1 error generated.
BUG=None
TEST=build with clang, ninja -C out/Debug most.
R=bsalomon@google.com, epoger@google.com, thakis@chromium.org, mtklein@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
47603012
git-svn-id: http://skia.googlecode.com/svn/trunk@11990
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 28 Oct 2013 21:12:50 +0000 (21:12 +0000)]
rebase msaa4 tests that haven't run in a long time
Review URL: https://codereview.chromium.org/
48183006
git-svn-id: http://skia.googlecode.com/svn/trunk@11989
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Mon, 28 Oct 2013 20:40:41 +0000 (20:40 +0000)]
skip android_paint GM in pipe mode
BUG=skia:1763
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
48113010
git-svn-id: http://skia.googlecode.com/svn/trunk@11988
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 28 Oct 2013 20:21:12 +0000 (20:21 +0000)]
gm/internal_links test: add kSkipPipe_Flag until we fix bug 1761
BUG=skia:1761
TBR=reed
Review URL: https://codereview.chromium.org/
49693004
git-svn-id: http://skia.googlecode.com/svn/trunk@11987
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Oct 2013 20:20:54 +0000 (20:20 +0000)]
Remove float/double conversions from SkMatrix44's map2_pf
BUG=chromium:303811
R=reed@google.com
Author: enne@chromium.org
Review URL: https://codereview.chromium.org/
37693004
git-svn-id: http://skia.googlecode.com/svn/trunk@11986
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Oct 2013 19:51:26 +0000 (19:51 +0000)]
DM: add --pipe
internal_links is failing across all three versions. One of the rects doesn't draw.
BUG=
R=epoger@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
47773002
git-svn-id: http://skia.googlecode.com/svn/trunk@11985
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 28 Oct 2013 18:22:19 +0000 (18:22 +0000)]
Whitespace change to pick up buildbot change https://code.google.com/p/skia/source/detail?r=11983
git-svn-id: http://skia.googlecode.com/svn/trunk@11984
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 28 Oct 2013 18:07:44 +0000 (18:07 +0000)]
Cleanup displacement bench
https://codereview.chromium.org/
47553005/
git-svn-id: http://skia.googlecode.com/svn/trunk@11982
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Oct 2013 15:52:02 +0000 (15:52 +0000)]
Enabling validation code in serialization and adding serialization to fuzzer
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=11968
R=reed@google.com, mtklein@google.com, senorblanco@chromium.org, bsalomon@google.com, robertphillips@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
44573002
git-svn-id: http://skia.googlecode.com/svn/trunk@11981
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Oct 2013 15:13:50 +0000 (15:13 +0000)]
Fix for issue 1728: raster vs. gpu text draws with the wrong color
The blend mode for LCD text was not set up correctly when using colors with alpha. This takes the color's alpha value
into account when setting up the blending function.
BUG=Skia:1728
R=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
45363002
git-svn-id: http://skia.googlecode.com/svn/trunk@11980
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 28 Oct 2013 15:09:13 +0000 (15:09 +0000)]
Fix broken MSAA for RGBA
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
46763003
git-svn-id: http://skia.googlecode.com/svn/trunk@11979
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 28 Oct 2013 12:08:52 +0000 (12:08 +0000)]
Reverting r11968 (Enabling validation code in serialization and adding serialization to fuzzer - https://codereview.chromium.org/
44573002) due to failure on Chromium AllQuads test.
git-svn-id: http://skia.googlecode.com/svn/trunk@11974
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 27 Oct 2013 20:50:23 +0000 (20:50 +0000)]
Clean up the GrTHashTable API.
removeAt() and slowFindIndex() were only used by GrFontCache, and didn't really need to exist: they can be replaced by a simple remove() call. This new code should actually be faster; slowFindIndex() was O(N), and this should be O(lg N).
BUG=
R=bsalomon@google.com, jvanverth@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
43383006
git-svn-id: http://skia.googlecode.com/svn/trunk@11973
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Sat, 26 Oct 2013 15:01:08 +0000 (15:01 +0000)]
rebaseline_server: tiny fix to un-break UI when ng-repeate (key, value) has duplicate values
See https://github.com/angular/angular.js/pull/2505
(SkipBuildbotRuns)
TBR=jcgregorio
Review URL: https://codereview.chromium.org/
46063005
git-svn-id: http://skia.googlecode.com/svn/trunk@11972
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Sat, 26 Oct 2013 14:44:22 +0000 (14:44 +0000)]
mass-committing another round of GM results, marked as reviewed-by-human=false
BUG=skia:1759
TBR=bsalomon
Review URL: https://codereview.chromium.org/
46653003
git-svn-id: http://skia.googlecode.com/svn/trunk@11971
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Sat, 26 Oct 2013 14:31:11 +0000 (14:31 +0000)]
rebaseline_server: UI improvements + set reviewed-by-human on commit
- select/clear/toggle all tests
- display "bugs" column
- set reviewed-by-human on commit
- a couple more tiny fixes, TODOs adjusted, etc.
(SkipBuildbotRuns)
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
44123004
git-svn-id: http://skia.googlecode.com/svn/trunk@11970
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 26 Oct 2013 07:01:53 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11969
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 25 Oct 2013 21:04:40 +0000 (21:04 +0000)]
Enabling validation code in serialization and adding serialization to fuzzer
BUG=
R=reed@google.com, mtklein@google.com, senorblanco@chromium.org, bsalomon@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
44573002
git-svn-id: http://skia.googlecode.com/svn/trunk@11968
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 25 Oct 2013 18:40:24 +0000 (18:40 +0000)]
Allow users to build on top of, instead of beneath, SkRefCnt.
Alternative to r11811.
The Chromium half of this can be seen at https://codereview.chromium.org/
40973002/ .
R=reed@google.com
Review URL: https://codereview.chromium.org/
40503002
git-svn-id: http://skia.googlecode.com/svn/trunk@11967
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 25 Oct 2013 18:14:54 +0000 (18:14 +0000)]
Factor out skia_keep_frame_pointer. Handy with perf to get call stacks.
Today it's set when we're running a sanitizer, but it's more generally useful. perf record -g (--call-graph) only works for me if we don't omit the frame pointer.
BUG=
R=bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
41923004
git-svn-id: http://skia.googlecode.com/svn/trunk@11966
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 25 Oct 2013 17:49:08 +0000 (17:49 +0000)]
onCharsToGlyphs to handle non-bmp on Mac.
CTFontGetGlyphsForCharacters is a strange API for non-bmp code points.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/
43463005
git-svn-id: http://skia.googlecode.com/svn/trunk@11965
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 25 Oct 2013 17:04:56 +0000 (17:04 +0000)]
New baselines for imagefiltersgraph GM.
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
44323002
git-svn-id: http://skia.googlecode.com/svn/trunk@11964
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 25 Oct 2013 15:02:57 +0000 (15:02 +0000)]
DM: move --match check earlier to fix the "N GMs x M configs" log line.
BUG=
R=bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
44443002
git-svn-id: http://skia.googlecode.com/svn/trunk@11963
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 25 Oct 2013 14:58:12 +0000 (14:58 +0000)]
Compute clipped src rect once in tiled bitmap draws
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
40403002
git-svn-id: http://skia.googlecode.com/svn/trunk@11962
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 25 Oct 2013 13:39:42 +0000 (13:39 +0000)]
Fix warnings as errors from r11960.
git-svn-id: http://skia.googlecode.com/svn/trunk@11961
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 25 Oct 2013 12:32:16 +0000 (12:32 +0000)]
Disable charsToGlyphs test until Mac can pass.
git-svn-id: http://skia.googlecode.com/svn/trunk@11960
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 25 Oct 2013 07:02:14 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11959
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 24 Oct 2013 22:38:48 +0000 (22:38 +0000)]
Revert unwanted change to verttext.cpp.
git-svn-id: http://skia.googlecode.com/svn/trunk@11958
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 24 Oct 2013 22:32:43 +0000 (22:32 +0000)]
Fix non-bmp in generateCharToGlyph on Mac.
git-svn-id: http://skia.googlecode.com/svn/trunk@11957
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 24 Oct 2013 21:50:12 +0000 (21:50 +0000)]
Add missing braces for r11955.
git-svn-id: http://skia.googlecode.com/svn/trunk@11956
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 24 Oct 2013 21:39:35 +0000 (21:39 +0000)]
Implement charToGlyph on remaining ports.
R=reed@google.com
Review URL: https://codereview.chromium.org/
22859070
git-svn-id: http://skia.googlecode.com/svn/trunk@11955
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 24 Oct 2013 20:55:14 +0000 (20:55 +0000)]
Reduce bitmap sizes in verylargebitmap GM to not crash on windows
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
39033005
git-svn-id: http://skia.googlecode.com/svn/trunk@11954
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 24 Oct 2013 20:03:27 +0000 (20:03 +0000)]
Rebaseline strokes_round and strokes3 on SGX devices
BUG=skia:1752
Review URL: https://codereview.chromium.org/
41083003
git-svn-id: http://skia.googlecode.com/svn/trunk@11953
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Thu, 24 Oct 2013 18:08:45 +0000 (18:08 +0000)]
Changes bench_graph_svg.py test to check_bench_regressions.py test; deletes deprecated chunks in syn_bucket_subdir.
Review URL: https://codereview.chromium.org/
27377002
git-svn-id: http://skia.googlecode.com/svn/trunk@11952
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 24 Oct 2013 17:52:07 +0000 (17:52 +0000)]
Tile large bitmaps that are clipped.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
31033002
git-svn-id: http://skia.googlecode.com/svn/trunk@11951
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 24 Oct 2013 17:44:43 +0000 (17:44 +0000)]
DM: print cache stats after every GPU GM when GR_CACHE_STATS is set
BUG=
R=bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
39743003
git-svn-id: http://skia.googlecode.com/svn/trunk@11950
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 24 Oct 2013 17:44:27 +0000 (17:44 +0000)]
We want to give SkPixelRef a way to signal over to GrResourceCache that it's become pointless to keep around textures based on that SkPixelRef when its pixels change, so that it can be a good citizen and free those textures.
This adds an invalidation listener mechanism to SkPixelRef to let it send this message while still staying ignorant of who's listening.
These messages are tricky to deliver. The SkPixelRefs they originates from and the GrResourceCaches they ultimately end up at may be on different threads; neither class is threadsafe; their object lifetimes are totally independent; it's a many-senders-to-many-receivers relation; and neither codebase should really know about the other.
So I've added a per-message-type global message bus to broadcast messages to threadsafe inboxes. Anyone can post() a message, which will show up in all the inboxes of that type, read whenever the inbox's owner calls poll(). The implementation is _dumb_; it can be improved in several dimensions (inbox size limits, lock-free message delivery) if we find the need.
I took some care to make sure not to send the invalidation message for any SkPixelRef that's sharing a generation ID with another SkPixelRef.
BUG=
R=bsalomon@google.com, scroggo@google.com, reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
26734003
git-svn-id: http://skia.googlecode.com/svn/trunk@11949
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Thu, 24 Oct 2013 16:40:12 +0000 (16:40 +0000)]
[PDF] Rebaseline mac expectations after fixing image unpremtuliplication in r11945
Review URL: https://codereview.chromium.org/
40263003
git-svn-id: http://skia.googlecode.com/svn/trunk@11948
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 24 Oct 2013 15:59:31 +0000 (15:59 +0000)]
Fix drawBitmap() of scratch texture.
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
40163004
git-svn-id: http://skia.googlecode.com/svn/trunk@11947
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 24 Oct 2013 15:38:27 +0000 (15:38 +0000)]
rebaseline_server: cleanup of HTML/Javascript
No behavioral change at all.
(SkipBuildbotRuns)
R=borenet@google.com
Review URL: https://codereview.chromium.org/
31583007
git-svn-id: http://skia.googlecode.com/svn/trunk@11946
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Thu, 24 Oct 2013 15:20:00 +0000 (15:20 +0000)]
[PDF] Add unpremultiply support and a GM (try5)
This is a resubmit of https://codereview.chromium.org/
22831039 which was
reverted because it causes issues on Windows.
BUG=chromium:175548
R=edisonn@google.com
Review URL: https://codereview.chromium.org/
37873003
git-svn-id: http://skia.googlecode.com/svn/trunk@11945
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 24 Oct 2013 15:05:13 +0000 (15:05 +0000)]
Whitespace change to trigger buildbots
git-svn-id: http://skia.googlecode.com/svn/trunk@11944
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 24 Oct 2013 14:42:19 +0000 (14:42 +0000)]
Add note to ignored-tests.txt
BUG=skia:1748
(SkipBuildbotRuns)
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
40353002
git-svn-id: http://skia.googlecode.com/svn/trunk@11943
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Thu, 24 Oct 2013 14:24:59 +0000 (14:24 +0000)]
update pdf-mac gms, after adding duport for perspective shaders in pdf
Review URL: https://codereview.chromium.org/
40313002
git-svn-id: http://skia.googlecode.com/svn/trunk@11942
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 24 Oct 2013 14:25:22 +0000 (14:25 +0000)]
Borrow Android's ARMv6 memory barrier for SkOnce.
BUG=skia:1743
R=bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
34353009
git-svn-id: http://skia.googlecode.com/svn/trunk@11941
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 24 Oct 2013 14:03:01 +0000 (14:03 +0000)]
Minor changes
https://codereview.chromium.org/
39973004/
git-svn-id: http://skia.googlecode.com/svn/trunk@11940
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 24 Oct 2013 13:33:32 +0000 (13:33 +0000)]
Always create an instance when testing GrEffects for SkXfermode and SkArithmeticMode
Previously the TestCreate methods of the effects would create a static
instance and return that for all invocations. This is probably a
copy-paste error going back to initial TestCreate method in r8449. At
that time, the effect was always the same and thus static usage made
sense.
R=bsalomon@google.com, senorblanco@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
39393002
git-svn-id: http://skia.googlecode.com/svn/trunk@11939
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 24 Oct 2013 13:29:38 +0000 (13:29 +0000)]
Fix ModeColorFilterEffect assert during GLProgramsTest
Select random filter mode for the test-case until the mode is not
Dst. SkModeColorFilter with Dst mode will not create a
ModeColorFilterEffect, and thus the case is not implemented.
Also changes it so that each call to ModeColorFilterEffect::TestCreate
creates a new GrEffect. Previously only one static effect was ever
created, due to copy-paste error.
R=bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
39403002
git-svn-id: http://skia.googlecode.com/svn/trunk@11938
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Thu, 24 Oct 2013 13:19:28 +0000 (13:19 +0000)]
PDF: support perspective in simple shaders. (this version does not work well with tilling)
R=vandebo@chromium.org
Review URL: https://codereview.chromium.org/
26389006
git-svn-id: http://skia.googlecode.com/svn/trunk@11937
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 24 Oct 2013 11:24:38 +0000 (11:24 +0000)]
Replacing SkTDArray with SkAutoSTArray to reduce memory allocation overhead in SkTileGrid::search
BUG=https://code.google.com/p/skia/issues/detail?id=1735
R=tomhudson@chromium.org
Author: junov@chromium.org
Review URL: https://codereview.chromium.org/
35633002
git-svn-id: http://skia.googlecode.com/svn/trunk@11936
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 24 Oct 2013 11:12:47 +0000 (11:12 +0000)]
Expose SkPicture::willPlayBackBitmaps()
This returns true if (1) the picture has finished recording and
(2) this picture or any picture drawn into it refers to any bitmaps.
It allows clients doing complicated manipulations of the picture to
early-out when there are no bitmaps present.
BUG=303281
R=reed@google.com
git-svn-id: http://skia.googlecode.com/svn/trunk@11935
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 24 Oct 2013 07:01:59 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11934
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 24 Oct 2013 01:46:11 +0000 (01:46 +0000)]
Apply matrix early in draw bitmap
Committed: http://code.google.com/p/skia/source/detail?r=11930
Reverted: https://code.google.com/p/skia/source/detail?r=11932
R=robertphillips@google.com, senorblanco@chromium.org
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
30593003
git-svn-id: http://skia.googlecode.com/svn/trunk@11933
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 23 Oct 2013 22:19:06 +0000 (22:19 +0000)]
Revert "Apply matrix early in draw bitmap"
This reverts commit
4c446c8eb50b7a6e6f917fae7b4c4ffe5658a949.
Fix build.
git-svn-id: http://skia.googlecode.com/svn/trunk@11932
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Wed, 23 Oct 2013 21:36:43 +0000 (21:36 +0000)]
Revert "[PDF] Add unpremultiply support and a GM (try4)"
This reverts commit r11928
gm seems to crash on windows.
Review URL: https://codereview.chromium.org/
38153003
git-svn-id: http://skia.googlecode.com/svn/trunk@11931
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 23 Oct 2013 21:06:51 +0000 (21:06 +0000)]
Apply matrix early in draw bitmap
R=robertphillips@google.com, senorblanco@chromium.org
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
30593003
git-svn-id: http://skia.googlecode.com/svn/trunk@11930
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Wed, 23 Oct 2013 20:17:29 +0000 (20:17 +0000)]
[PDF] Add unpremultiply support and a GM (try4)
This is a resubmit of https://codereview.chromium.org/
22831039 which was
reverted because it causes issues on Windows (really, release builds).
BUG=chromium:175548
R=edisonn@google.com
Review URL: https://codereview.chromium.org/
33493003
git-svn-id: http://skia.googlecode.com/svn/trunk@11928
2bbb7eff-a529-9590-31e7-
b0007b416f81
humper@google.com [Wed, 23 Oct 2013 19:41:08 +0000 (19:41 +0000)]
rebaseline scaled tilemodes gms on the GPU
git-svn-id: http://skia.googlecode.com/svn/trunk@11927
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 23 Oct 2013 18:41:36 +0000 (18:41 +0000)]
Split up SkXfermode::asNewEffectOrCoeff() into asNewEffect(), asCoeff().
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
37593002
git-svn-id: http://skia.googlecode.com/svn/trunk@11926
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 23 Oct 2013 18:33:18 +0000 (18:33 +0000)]
Follow up to serialization validation code
1 ) Added check for bool to make sure is it either 0 or 1 and not garbage
2 ) Added more solid kernel size checks in SkMatrixConvolutionImageFilter
3 ) Make sure array size is validated in SkMergeImageFilter
BUG=
R=reed@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
23548034
git-svn-id: http://skia.googlecode.com/svn/trunk@11925
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 23 Oct 2013 17:06:21 +0000 (17:06 +0000)]
Initial error handling code
I made it as simple as possible. The impact seems minimal and it should do what's necessary to make this code secure.
BUG=
Committed: http://code.google.com/p/skia/source/detail?r=11247
R=reed@google.com, scroggo@google.com, djsollen@google.com, sugoi@google.com, bsalomon@google.com, mtklein@google.com, senorblanco@google.com, senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
23021015
git-svn-id: http://skia.googlecode.com/svn/trunk@11922
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 23 Oct 2013 16:18:50 +0000 (16:18 +0000)]
use the supplied matrix instead of the texture w/h div for the bicubic GPU effect
BUG=
R=bsalomon@google.com, caryclark@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
37003005
git-svn-id: http://skia.googlecode.com/svn/trunk@11921
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 23 Oct 2013 15:33:44 +0000 (15:33 +0000)]
Lighting filter uses input on raster path
BUG=
R=senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
35703002
git-svn-id: http://skia.googlecode.com/svn/trunk@11918
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 23 Oct 2013 15:32:39 +0000 (15:32 +0000)]
Add support for reading non-rendertarget textures.
Also removes rendertarget flag from GrAtlas texture creation (no
longer needed) and re-enables GrFontCache::dump().
R=robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
29263004
git-svn-id: http://skia.googlecode.com/svn/trunk@11917
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Wed, 23 Oct 2013 15:24:27 +0000 (15:24 +0000)]
TSAN build fix: forgot to pass the address into ANNOTATE_BENIGN_RACE.
BUG=
Review URL: https://codereview.chromium.org/
37403002
git-svn-id: http://skia.googlecode.com/svn/trunk@11916
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 23 Oct 2013 15:07:26 +0000 (15:07 +0000)]
rebaseline_server: add tabs, and ability to submit new baselines to the server
Tabs allow the user to divide the tests into groups:
hide these for now, approve these, etc.
(SkipBuildbotRuns)
R=borenet@google.com
Review URL: https://codereview.chromium.org/
28903008
git-svn-id: http://skia.googlecode.com/svn/trunk@11915
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 23 Oct 2013 14:44:08 +0000 (14:44 +0000)]
SK_ONCE for SkData and SkPathRef
Adds SK_ONCE_FRIEND, to allow SK_DEF_ONCE code to be friends with a class. This had to go in include/core to be visible to headers there.
BUG=
R=reed@google.com, bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
26491003
git-svn-id: http://skia.googlecode.com/svn/trunk@11914
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 23 Oct 2013 14:03:22 +0000 (14:03 +0000)]
Remove GrContext from SkXfermode::[Aa]sNewEffectOrCoeff() and all subclasses,
since it's unused.
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
31853003
git-svn-id: http://skia.googlecode.com/svn/trunk@11913
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 23 Oct 2013 05:42:03 +0000 (05:42 +0000)]
Implement SkColorFilter as a GrGLEffect
Adds GrEffect::willUseInputColor() which indicates whether or not the
input color affects the output of the effect. This is needed for
certain Xfermodes, such as kSrc_Mode. For these modes the color filter
will not use the input color.
An effect with GrEffect::willUseInputColor() true will cause all color
or coverage effects before it to be discarded, as their computations
cannot affect the output. In these cases program is marked as having
white input color.
This fixes an assert when Skia is compiled in a mode that prefers
using uniforms instead of attributes for constants. (Flags
GR_GL_USE_NV_PATH_RENDERING or GR_GL_NO_CONSTANT_ATTRIBUTES). Using
attributes hides the problem where the fragment shader does not need
input color for color filters that ignore DST part of the filter. The
assert would be hit when uniform manager tries to bind an uniform which
has been optimized away by the shader compiler.
Adds specific GrGLSLExpr4 and GrGLSLExpr1 classes. This way the GLSL
expressions like "(v - src.a)" can remain somewhat readable in form of
"(v - src.a())". The GrGLSLExpr<typename> template implements the
generic functionality, GrGLSLExprX is the specialization that exposes
the type-safe interface to this functionality.
Also adds operators so that GLSL binary operators of the form
"(float * vecX)" can be expressed in C++. Before only the equivalent
"(vecX * float)" was possible. This reverts the common blending
calculations to more conventional order, such as "(1-a) * c" instead of
"c * (1-a)".
Changes GrGLSLExpr1::OnesStr from 1 to 1.0 in order to preserve the
color filter blending formula string the same (with the exception of
variable name change).
Shaders change in case of input color being needed:
- vec4 filteredColor;
- filteredColor = (((1.0 - uFilterColor.a) * output_Stage0) + uFilterColor);
- fsColorOut = filteredColor;
+ vec4 output_Stage1;
+ { // Stage 1: ModeColorFilterEffect
+ output_Stage1 = (((1.0 - uFilterColor_Stage1.a) * output_Stage0) + uFilterColor_Stage1);
+ }
+ fsColorOut = output_Stage1;
Shaders change in case of input color being not needed:
-uniform vec4 uFilterColor;
-in vec4 vColor;
+uniform vec4 uFilterColor_Stage0;
out vec4 fsColorOut;
void main() {
- vec4 filteredColor;
- filteredColor = uFilterColor;
- fsColorOut = filteredColor;
+ vec4 output_Stage0;
+ { // Stage 0: ModeColorFilterEffect
+ output_Stage0 = uFilterColor_Stage0;
+ }
+ fsColorOut = output_Stage0;
}
R=bsalomon@google.com, robertphillips@google.com, jvanverth@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
25023003
git-svn-id: http://skia.googlecode.com/svn/trunk@11912
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Tue, 22 Oct 2013 19:42:10 +0000 (19:42 +0000)]
New gm expectations for imagemagnifier
git-svn-id: http://skia.googlecode.com/svn/trunk@11911
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Tue, 22 Oct 2013 18:33:21 +0000 (18:33 +0000)]
Fix a test warning on some linux machines
R=sugoi@google.com
Review URL: https://codereview.chromium.org/
34803004
git-svn-id: http://skia.googlecode.com/svn/trunk@11910
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 22 Oct 2013 16:54:15 +0000 (16:54 +0000)]
Revert "If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance."
This reverts commit r11904
Review URL: https://codereview.chromium.org/
35543002
git-svn-id: http://skia.googlecode.com/svn/trunk@11909
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 22 Oct 2013 16:17:29 +0000 (16:17 +0000)]
if fBitmap is still NULL, return false
git-svn-id: http://skia.googlecode.com/svn/trunk@11908
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 22 Oct 2013 14:49:03 +0000 (14:49 +0000)]
add tests for SkDocument
R=reed@google.com, vandebo@chromium.org
Author: edisonn@google.com
Review URL: https://codereview.chromium.org/
33423002
git-svn-id: http://skia.googlecode.com/svn/trunk@11907
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 22 Oct 2013 13:52:47 +0000 (13:52 +0000)]
Add strokerect to ignored tests list
Review URL: https://codereview.chromium.org/
35223003
git-svn-id: http://skia.googlecode.com/svn/trunk@11906
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 22 Oct 2013 13:19:12 +0000 (13:19 +0000)]
If the path is a rect, call drawRect to raster the geometry in SkCanvas::drawPath to get better performance.
Committed: http://code.google.com/p/skia/source/detail?r=11842
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
23484007
git-svn-id: http://skia.googlecode.com/svn/trunk@11904
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 22 Oct 2013 07:02:30 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@11903
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 22 Oct 2013 00:42:46 +0000 (00:42 +0000)]
More work to integrate skimage with rebaseline tools.
tools/skimage_main.cpp:
Add the ability to write the results to checksum based filenames,
much like GM uses. This will allow using the skpdiff server to
rebaseline images.
Write the keys in the JSON file as <original image>_<pref config>.png,
so it matches gm_json.IMAGE_FILENAME_PATTERN. Also replace '_' with
'-' in the original file name, to avoid confusing the pattern matcher.
The '_' to '-' replacement also happens on the output filename.
Read the keys in a similar manner.
In make_outname, no longer remove a suffix. This fixes a bug where
subset decoding writes multiple subsets to the same file.
tools/rebaseline.py:
Since the filenames written to json files now match
gm_json.IMAGE_FILENAME_PATTERN, enable the option to match based
on configs/tests when rebaselining skimage.
test json files:
Update to match the new format of output.
gm/gm_expectations:
Add a constructor that takes a BitmapAndDigest as input.
tools/tests/skimage_self_test.py:
Test that reading the expectations file just created by skimage with
the same file actually compares to the original file (rather than just
succeeding because expectations were missing).
Change the expectations files to match the new format.
Will require a buildbot change to use the new flag: https://codereview.chromium.org/
27389002/
BUG=1466
R=epoger@google.com
Review URL: https://codereview.chromium.org/
26297004
git-svn-id: http://skia.googlecode.com/svn/trunk@11902
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 21 Oct 2013 22:00:47 +0000 (22:00 +0000)]
Xoom rebaselines.
Note: Some of these had no base versions in GS corresponding to the hashes in the JSON, causing the svndiff script to barf. I hacked it up to let me finish, but it should probably handle the case of a missing hash more gracefully.
TBR=epoger
Review URL: https://codereview.chromium.org/
33303007
git-svn-id: http://skia.googlecode.com/svn/trunk@11900
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 21 Oct 2013 21:30:49 +0000 (21:30 +0000)]
Revert r11880 (Apply matrix early in draw bitmap - https://codereview.chromium.org/
30593003) due to layout test failure
git-svn-id: http://skia.googlecode.com/svn/trunk@11899
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Mon, 21 Oct 2013 21:04:06 +0000 (21:04 +0000)]
GrTHashCache -> GrTHashTable
The class is Table, but the file's Cache. That's confusing.
BUG=
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
32523004
git-svn-id: http://skia.googlecode.com/svn/trunk@11898
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 21 Oct 2013 20:47:31 +0000 (20:47 +0000)]
Image decoder fixes (mostly) around A8.
Opaquness:
When decoding Gray to A8 in libpng, set reallyHasAlpha to true
and add a comment why we do not check for the real answer.
Add comments in jpeg decoder explaining why A8 is not opaque.
Fix a bug where an A8 subset is considered to be opaque.
Other fixes:
In SkJPEGImageDecoder, only allocate as much memory as
needed for each source row, based on the input config.
Also pull out common code into a static function.
When performing the check for requiring unpremultiplied colors,
allow A8 to succeed, since that setting should have no effect on
A8.
Add the check for requiring unpremultiplied colors to subset
decoding.
Fix a bug where attempting to sample gray to A8 does not sample.
R=reed@google.com
Review URL: https://codereview.chromium.org/
26210007
git-svn-id: http://skia.googlecode.com/svn/trunk@11897
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 21 Oct 2013 20:13:42 +0000 (20:13 +0000)]
Revert "Revert "cache SkImage::Info calculation in lazypixelref""
This reverts commit
81eba32ab10f9210c742938819cf1218be5611c9.
ImageDecoder is changed to allow info to be NULL, since it is an output-only parameter.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
33573002
git-svn-id: http://skia.googlecode.com/svn/trunk@11896
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 21 Oct 2013 19:45:38 +0000 (19:45 +0000)]
Revert "cache SkImage::Info calculation in lazypixelref"
This reverts commit
a2537480710aa10b9ab9f8aec98538b79539f47e.
git-svn-id: http://skia.googlecode.com/svn/trunk@11894
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 21 Oct 2013 18:58:17 +0000 (18:58 +0000)]
cache SkImage::Info calculation in lazypixelref
BUG=
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
28493003
git-svn-id: http://skia.googlecode.com/svn/trunk@11893
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 21 Oct 2013 18:49:43 +0000 (18:49 +0000)]
Roll gyp from r1684 to r1765.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
32963002
git-svn-id: http://skia.googlecode.com/svn/trunk@11892
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 21 Oct 2013 18:46:49 +0000 (18:46 +0000)]
ChromeOS and IntelRhb rebaselines.
TBR=robertphillips
Review URL: https://codereview.chromium.org/
32533004
git-svn-id: http://skia.googlecode.com/svn/trunk@11891
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 21 Oct 2013 18:40:25 +0000 (18:40 +0000)]
DM: add --serialize
Plus:
- minor ReplayTask refactoring to share code with SerializeTask
- move --replay to ReplayTask and --serialize to SerializeTask like WriteTask
- when --writePath is given, write failures for Replay and Serialize tasks
- function names have fewer blatant Skia style violations
BUG=
R=bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
32613003
git-svn-id: http://skia.googlecode.com/svn/trunk@11890
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 21 Oct 2013 18:23:30 +0000 (18:23 +0000)]
Third round of matrixconvolution rebaselines, and removal from ignored-tests.txt.
"We have normality. I repeat, we have normality. Anything you still can't cope with is therefore your own problem."
TBR=robertphillips
BUG=
Review URL: https://codereview.chromium.org/
33323002
git-svn-id: http://skia.googlecode.com/svn/trunk@11889
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 21 Oct 2013 17:37:28 +0000 (17:37 +0000)]
Fix out of order destruction error
https://codereview.chromium.org/
33203002/
git-svn-id: http://skia.googlecode.com/svn/trunk@11888
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 21 Oct 2013 17:25:26 +0000 (17:25 +0000)]
GM: remove deprecated --ignoreTests flag
BUG=skia:1730
R=borenet@google.com
Review URL: https://codereview.chromium.org/
27983004
git-svn-id: http://skia.googlecode.com/svn/trunk@11887
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 21 Oct 2013 17:14:37 +0000 (17:14 +0000)]
Add DPI stettings to SkDocument::CreatePDF(). Tests will be added in a future cl, once DPI will be used in SkPDFDevice
R=reed@google.com, bungeman@google.com, vandebo@chromium.org
Author: edisonn@google.com
Review URL: https://codereview.chromium.org/
32233003
git-svn-id: http://skia.googlecode.com/svn/trunk@11886
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 21 Oct 2013 17:04:11 +0000 (17:04 +0000)]
Second round of matrixconvolution rebaselines.
TBR=robertphillips
BUG=
Review URL: https://codereview.chromium.org/
33103002
git-svn-id: http://skia.googlecode.com/svn/trunk@11885
2bbb7eff-a529-9590-31e7-
b0007b416f81