Youngbok Shin [Thu, 12 Jul 2018 09:09:26 +0000 (12:09 +0300)]
evas textblock: adds missing legacy types
Summary:
Adds missing legacy types. The following types were generated in
"*.eo.legacy.h" by Eolian.
- Evas_Textblock
evas_textblock.eo.legacy.h:7:typedef Eo Evas_Textblock;
- Evas_Textblock_Node_Format
evas_textblock.eo.legacy.h:14:typedef struct _Evas_Textblock_Node_Format Evas_Textblock_Node_Format;
@fix
Test Plan: N/A
Reviewers: raster, cedric, herdsman, devilhorns
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6529
Mike Blumenkrantz [Thu, 12 Jul 2018 07:29:51 +0000 (16:29 +0900)]
tests/edje: add test to verify that swallow objects exist during DEL callback
Summary:
this mimics expected behavior by enlightenment
for 2.0, this behavior should likely be changed since the INVALIDATE event
should be the last expected point at which a parent<->child relationship
continues to exist in any form
ref D6540
Depends on D6554
Reviewers: devilhorns, Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6555
Bryce Harrington [Thu, 12 Jul 2018 07:27:15 +0000 (16:27 +0900)]
eina: Spelling fixes
Reviewers: devilhorns, Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6570
Mike Blumenkrantz [Thu, 12 Jul 2018 07:25:15 +0000 (16:25 +0900)]
tests/edje: split edje tests into separate files
Summary:
this will speed up tests and make it slightly less intimidating to
add new tests
Reviewers: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6554
Marcel Hollerbach [Thu, 12 Jul 2018 07:15:59 +0000 (16:15 +0900)]
efl_ui_focus_manager_calc: do not error when the configuraiton is equal
Summary:
Before this was erroring. However, this error was not reporting a bad
situation, thus there is no need to error. This patch fixes errors on
the Popup test when scrollable is set to 1.
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6560
Bryce Harrington [Thu, 12 Jul 2018 07:13:57 +0000 (16:13 +0900)]
eina: Add doxygen in/out tags for binbuf's parameters
Reviewers: devilhorns, Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6571
Mike Blumenkrantz [Wed, 11 Jul 2018 19:50:23 +0000 (15:50 -0400)]
elm/win: don't force opaque bg if alpha is set
Summary:
alpha prevents an opaque bg, so ensure that this is being correctly
detected
worth noting here is that the eo api for win calls through _elm_win_standard_init()
during finalize which ensures that need_bg_solid is set; the legacy api
does not call this during "normal" construction
fix T7129
Depends on D6568
Reviewers: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7129
Differential Revision: https://phab.enlightenment.org/D6569
Mike Blumenkrantz [Wed, 11 Jul 2018 19:50:09 +0000 (15:50 -0400)]
elm/win: correctly track and set x11 shaped state
Summary:
when applying alpha in a non-composited environment, shaped should be
set. when removing alpha in a non-composited environment, shaped should
be unset if it has not previously been explicitly set
@fix
Reviewers: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6568
Hermet Park [Wed, 11 Jul 2018 07:09:31 +0000 (16:09 +0900)]
canvas vg_loader: close opened file after using it.
Summary:
Here opened eina file is just leaked.
close it properly.
@fix.
Reviewers: devilhorns, #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6549
Hermet Park [Wed, 11 Jul 2018 07:08:48 +0000 (16:08 +0900)]
canvas vg: check expcetional case.
Summary: if file is not exists.
Reviewers: devilhorns, #committers, zmike
Reviewed By: #committers, zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6546
Derek Foreman [Tue, 10 Jul 2018 20:53:12 +0000 (16:53 -0400)]
evas_drm: Trim the queue of buffers if we've had extra for too long
Summary:
In fixing T7099 I've also allowed the buffer queue to grow quite large,
so now we should prune it back if it's bigger than it needs to be for
a long time.
ref T7099
Depends on D6565
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7099
Differential Revision: https://phab.enlightenment.org/D6566
Derek Foreman [Tue, 10 Jul 2018 20:53:00 +0000 (16:53 -0400)]
evas_drm: Move MAX_BUFFERS macro from header to source file
Summary:
It's no longer needed in the header because it doesn't change
the size of the structures there anymore.
Depends on D6564
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6565
Derek Foreman [Tue, 10 Jul 2018 20:52:46 +0000 (16:52 -0400)]
evas_drm: Allocate buffers on demand
Summary:
Instead of allocating a fixed number of buffers immediately, allocate
buffers if needed to render to.
Normally we only need 2 buffers, but we've been allocating 3 to handle
worse case behaviour. As T7099 shows, this is not always enough. We
now cap at a max of 10.
For the normal case where we always use 2 this results in a slight
memory reduction (1 buffer) and a slight renering load reduction
because we pick the oldest buffer to render into.
A future patch will trim the buffer queue if it's been too large for
a long time.
fix T7099
Depends on D6563
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7099
Differential Revision: https://phab.enlightenment.org/D6564
Derek Foreman [Tue, 10 Jul 2018 20:13:52 +0000 (16:13 -0400)]
evas_drm: replace outbuf fb array with a list
Summary:
This is just a step towards making it a variable length.
ref T7099
Depends on D6562
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7099
Differential Revision: https://phab.enlightenment.org/D6563
Derek Foreman [Tue, 10 Jul 2018 20:13:18 +0000 (16:13 -0400)]
evas_drm: Make the fbs an array of pointers
Summary:
Use pointers instead of an array of structures, since we're going to
replace the array with a list shortly.
ref T7099
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7099
Differential Revision: https://phab.enlightenment.org/D6562
Mike Blumenkrantz [Tue, 10 Jul 2018 18:44:44 +0000 (14:44 -0400)]
tests/ecore: remove ecore-drm test
Summary:
this caused DSO linker issues when enabled and was only testing
init+shutdown for a deprecated component which has not been actively developed
in some time
Reviewers: devilhorns, ManMower, bu5hm4n
Reviewed By: devilhorns, ManMower
Subscribers: bu5hm4n, ManMower, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6539
Marcel Hollerbach [Tue, 10 Jul 2018 18:44:36 +0000 (14:44 -0400)]
ecore_wl2&elput: correctly fill the key structure
Summary: the key structure has two fields key and keyname, those should be identical to the keystructures from x. the method xkb_keysym_to_utf8 however returns different values for keys like "minus" thus only relying on xkb_keysym_name files this issue.
Reviewers: eagleeye, devilhorns
Reviewed By: eagleeye
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6520
Mike Blumenkrantz [Tue, 10 Jul 2018 15:41:25 +0000 (11:41 -0400)]
efreet: include buildsystem.h in efreet_cache.c
Summary: lib/efreet/efreet_cache.c:121:6: warning: implicit declaration of function 'bs_binary_get' is invalid in C99 [-Wimplicit-function-declaration]
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6556
Derek Foreman [Tue, 10 Jul 2018 15:40:10 +0000 (11:40 -0400)]
ecore_wl2: Include window_v6.x in the dist even if not configured for wayland
Summary:
Release tarballs need this file regardless of whether --enable-wayland is
specified or not.
fix T7120
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7120
Differential Revision: https://phab.enlightenment.org/D6557
Derek Foreman [Tue, 10 Jul 2018 13:43:55 +0000 (09:43 -0400)]
eio_model: Fix deleting files that don't have assigned types yet
Summary:
Trying to delete a file from a creation notification callback can
fail. Sometimes the eio model test would sit forever in select()
waiting for events that will never occur because of this.
This happens since
d84a268a71b09d585f1672b44ade698d7babe28d broke
deleting of files that haven't yet been assigned a type. Before
this commit a delete_me flag would be set before attempting to
build a stat buf asynchronously, and then on completion the file
would be deleted.
I think this was changed because that could potentially race with
other async calls and delete the file sooner than expected. So
instead of reverting I've made a special delete path that shouldn't
race with non-delete paths.
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6543
Mike Blumenkrantz [Tue, 10 Jul 2018 11:31:32 +0000 (07:31 -0400)]
Revert "edje: clean up internal objects during invalidate"
This reverts commit
78cd61034185f07779d70163a38f5ffdffe5507b.
this patch needed a bit more review+testing; it fixes some issues but
creates others
Differential Revision: https://phab.enlightenment.org/D6551
Carsten Haitzler (Rasterman) [Tue, 10 Jul 2018 07:04:01 +0000 (16:04 +0900)]
evas gl-x11 engine - nvidia driver - fix performance drop
this has been going on for a while. on nvidia drivers in gles mode on
x11 there is a massive perf drop to like a few fps with enough windows
if we build for egl/gles instead of opengl. it was the re-creating of
eglimages every frame. put a vendor specific workaround for this and
avoid it. it's not needed there anyway. framerate back to 60fps
smoothness afterwards.
@fix
Hermet Park [Tue, 10 Jul 2018 02:23:18 +0000 (11:23 +0900)]
ui scroll_manager: update doc.
Daniel Hirt [Tue, 10 Jul 2018 02:17:29 +0000 (11:17 +0900)]
Ui.Scroll_Manager: restrict to Efl.Ui.Pan type for 'pan' property
Summary:
The implementation calls efl_ui_pan_xxx on what was assumed to be any
Efl.Canvas.Object. This changes the type to be Efl.Ui.Pan.
Also, reordered headers due to the introduced dependency.
Reviewers: devilhorns, Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6536
Mike Blumenkrantz [Tue, 10 Jul 2018 02:07:53 +0000 (11:07 +0900)]
edje: clean up internal objects during invalidate
Summary:
these objects are destroyed when invalidate is called as a result of the
evas smart object class destroying the smart object at this time
ref D6222
Reviewers: bu5hm4n, devilhorns
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6540
Mike Blumenkrantz [Tue, 10 Jul 2018 02:06:53 +0000 (11:06 +0900)]
tests/ecore-con: add a global timeout timer for all tests
Summary:
it's possible for many tests in this suite to hang indefinitely, so ensure
that they terminate eventually instead of holding up the build
ref T6838
Reviewers: stefan_schmidt, bu5hm4n, devilhorns, Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6838
Differential Revision: https://phab.enlightenment.org/D6542
Hermet Park [Tue, 10 Jul 2018 01:56:59 +0000 (10:56 +0900)]
updated AUTHORS
Bryce Harrington [Tue, 10 Jul 2018 01:55:10 +0000 (10:55 +0900)]
eina: Improve documentation for binbuf/strbuf/ustrbuf
Summary:
These three classes have essentially the same API, just different
underlying data types. This patch seeks to improve the docs for all
three while retaining or improving the consistency between them.
Several functions had completely incorrect documentation (looks like
cut-and-paste mistakes), others had missing or incorrectly named
parameter documentation, typographical errors, or other similar issues.
This also cleans up a lot of spelling and grammar errors, defines return
values as part of @return, and reformats/revises doxygen code for
consistency.
There are no changes to code, except some whitespace cleanup.
Reviewers: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6544
Mike Blumenkrantz [Mon, 9 Jul 2018 20:53:23 +0000 (16:53 -0400)]
elm/ctxpopup: check for content object before removing callbacks during del
Summary: ref T7030
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7030
Differential Revision: https://phab.enlightenment.org/D6541
Derek Foreman [Mon, 9 Jul 2018 20:39:56 +0000 (16:39 -0400)]
tests: Add a password callback for eet_test_identiy
Summary:
For whatever reason the test is stalling for me waiting for me to
entire a password at make time. Provide one internally.
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6528
Marcel Hollerbach [Mon, 9 Jul 2018 20:39:37 +0000 (16:39 -0400)]
elm_focus_legacy: remove wrong EINA_UNUSED
Summary: Depends on D6532
Reviewers: devilhorns, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6533
Marcel Hollerbach [Mon, 9 Jul 2018 20:39:35 +0000 (16:39 -0400)]
elm_focus_legacy: check if top is really a window
Summary:
if not, things are going to fall apart, as manager_top then can be NULL
or invalid. Top has to be a window element, if this is not the case,
then the widget tree of the given widget is dangling somewhere in the
void. Calculating the next object in there or even the active manager
will result in errors, since the active manager is not really the active
manager, but rather just a manager object somewhere in a danging widget
subtree.
Moving the focus into such a dangling widgettree might result in a stuck
focus rect on this object, since the DFS of the focus manager
implementation cannot backtrack anymore into the widgets that are still
part of the widget graph.
Depends on D6531
Reviewers: devilhorns, segfaultxavi, zmike
Reviewed By: segfaultxavi
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6532
Marcel Hollerbach [Mon, 9 Jul 2018 20:39:30 +0000 (16:39 -0400)]
elm_focus_legacy: fix focus moving for legacy
Summary:
elm_object_focus_next was not working correctly for objects where obj is
not the focused object.
fix T5940
Reviewers: devilhorns, segfaultxavi, zmike, stefan_schmidt
Reviewed By: segfaultxavi
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T5940
Differential Revision: https://phab.enlightenment.org/D6531
Xavi Artigas [Mon, 9 Jul 2018 17:32:58 +0000 (13:32 -0400)]
elementary: Avoid passing NULL in some win focus methods
Summary:
This one is rather harmless, as the NULL returned by this fuction is handled
correctly in all places, but this commit removes the runtime warning.
ref T7030
Test Plan: After this commit the warning disappears. Got the warning with win_example.
Reviewers: zmike, bu5hm4n, devilhorns
Reviewed By: devilhorns
Subscribers: netstar, cedric, #committers
Tags: #efl
Maniphest Tasks: T7030
Differential Revision: https://phab.enlightenment.org/D6538
Mike Blumenkrantz [Mon, 9 Jul 2018 17:31:45 +0000 (13:31 -0400)]
tests/eina: make inclusion for define explicit and more compatible
Summary:
signal.h is not included with all build options somehow, making this
a bit unreliable. also check for define existence for random platforms
which don't define this symbol
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: ManMower, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6535
Mike Blumenkrantz [Mon, 9 Jul 2018 17:31:20 +0000 (13:31 -0400)]
tests/ecore: check uid on ecore-file tests
Summary:
these tests will fail if run with root permission, so avoid checking them
when run as root
ref T7094
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7094
Differential Revision: https://phab.enlightenment.org/D6534
Stefan Schmidt [Mon, 9 Jul 2018 14:22:59 +0000 (10:22 -0400)]
eina: remove no longer used function _eina_thread_queue_msg_block_real_free
Summary:
It seems this function is no longer used since some rework. Clean it up.
lib/eina/eina_thread_queue.c:127:1: warning: ‘_eina_thread_queue_msg_block_real_free’ defined but not used [-Wunused-function]
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6537
Xavi Artigas [Fri, 6 Jul 2018 19:00:51 +0000 (15:00 -0400)]
C# bindings: Make efl_loop_timer.eo available to bindings
Summary:
This file contains both legacy and new API code, this makes it a little
difficult to deploy.
In Makefile_Ecore.am files can be marked either as legacy or public.
If it is not in legacy, make distcheck fails because Ecore_Legacy.h includes
efl_loop_timer.eo.h.
If it is not in public, bindings are not generated for it.
It cannot be in both places, or make install fails, refusing to install the
same file twice.
Fortunately, there is an ugly place to put files like this one, and it's
already full of other outcasts, so...
Fixes T7114
Test Plan: make distcheck still works, and C# bindings are generated for efl_loop_timer.eo
Reviewers: zmike, bu5hm4n, devilhorns
Reviewed By: zmike
Subscribers: vitor.sousa, cedric, #committers
Tags: #efl
Maniphest Tasks: T7114
Differential Revision: https://phab.enlightenment.org/D6527
Alastair Poole [Fri, 6 Jul 2018 15:43:39 +0000 (10:43 -0500)]
popup: fix popup sizing when scroll enabled.
Summary:
Force immediate calculate on main_layout after sizing hints set.
@fix T6886
Test Plan: Elementary_test: popup -> select scrollable -> use popup examples.
Reviewers: #committers, zmike, stephenmhouston, bu5hm4n, devilhorns
Reviewed By: #committers, zmike, stephenmhouston
Subscribers: cedric
Tags: #efl
Maniphest Tasks: T6886
Differential Revision: https://phab.enlightenment.org/D6509
Mike Blumenkrantz [Fri, 6 Jul 2018 15:09:51 +0000 (11:09 -0400)]
Revert "edje_cc: temporarily disable aborting compile when namespace validation fails"
Summary:
This reverts commit
0dc492087ed048f153bc45f488f1504034fdcd30.
there are no longer any errors here so this should fail the build any time errors
are introduced
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6525
Derek Foreman [Fri, 6 Jul 2018 15:08:00 +0000 (11:08 -0400)]
selection_manager: Silence silly ERR messages
Summary: These should be DBG, they're not errors.
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6526
Derek Foreman [Fri, 6 Jul 2018 14:16:50 +0000 (10:16 -0400)]
selection_manager: Remove unused variable
Summary:
gcc somehow didn't notice this until an unrelated use of the variable
later was removed. Now it's a warning.
Depends on D6523
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6524
Derek Foreman [Fri, 6 Jul 2018 14:15:40 +0000 (10:15 -0400)]
ee_wayland: Remove extraneous unregister
Summary:
ecore_event_window_unregister(ee->prop.window) is actually *exactly*
the same as ecore_evas_input_event_unregister(ee)
So this sequence just uselessly tries to remove something from an empty
hash table.
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6521
Mike Blumenkrantz [Fri, 6 Jul 2018 00:05:19 +0000 (20:05 -0400)]
build: always check for fork() and clearenv()
these are used in places other than quicklaunch and must be correctly
detected in order for functionality to be enabled
@fix
Differential Revision: https://phab.enlightenment.org/D6517
Mike Blumenkrantz [Thu, 5 Jul 2018 21:26:42 +0000 (17:26 -0400)]
efreet: simplify and fix efreetd launch
this previously used an entire eina prefix to determine where to find
efreetd, when a simpler approach would have been to just pass the directory
where it's being installed
this also inhibited running the correct efreetd during in-tree builds and tests,
as it was using the install prefix instead of the in-tree wrapper script
@fix
fix T6713
Differential Revision: https://phab.enlightenment.org/D6516
Mike Blumenkrantz [Thu, 5 Jul 2018 21:25:29 +0000 (17:25 -0400)]
ecore-con/proxy_helper: fix in-tree run path
this is located in the bin/ecore_con directory, not bin/ecore_con/utils,
so ensure that we pass the correct path in order to avoid not finding the
file
@fix
ref T6713
Differential Revision: https://phab.enlightenment.org/D6515
Mike Blumenkrantz [Thu, 5 Jul 2018 21:11:36 +0000 (17:11 -0400)]
edje_cc: disable efreetd connection
edje_cc does not use any of this functionality, and it's problematic
at build time since efreetd is not run in-tree and does not use in-tree
libraries
ref T6713
Differential Revision: https://phab.enlightenment.org/D6514
Stefan Schmidt [Fri, 6 Jul 2018 12:43:43 +0000 (14:43 +0200)]
release: Update NEWS and bump version for 1.21.0-alpha1 release
Stefan Schmidt [Fri, 6 Jul 2018 10:14:58 +0000 (12:14 +0200)]
Revert "elua: disable this for now"
This reverts commit
7b4ff708dc4063731829cc919e056fdc431d6de1.
This had a side effect of breaking the distcheck build (which I need for
the upcoming alpha today). I talked to Marcel and we agreed on reverting
this for now and come back with a fully working patch afterwards.
Hermet Park [Tue, 3 Jul 2018 06:18:37 +0000 (06:18 +0000)]
elementary textpath: code refactoring.
Don't twist code unnecessarily.
logically same, round() is enough.
Differential Revision: https://phab.enlightenment.org/D6501
Mike Blumenkrantz [Thu, 28 Jun 2018 15:06:26 +0000 (11:06 -0400)]
theme: skip namespace validation for "e/modules/music-control/popup" group
as this group is used by an external application, it can never be modified,
and thus namespacing issues cannot ever be resolved. for this reason there is
no other option except to skip validation of this group
fix T7072
Depends on D6388
Differential Revision: https://phab.enlightenment.org/D6389
Mike Blumenkrantz [Thu, 28 Jun 2018 15:06:13 +0000 (11:06 -0400)]
edje_cc: add 'skip_namespace_validation' keyword
this pairs with the newly-added -N option to denote groups in edc files
which should not be checked for correct namespacing
the option is useful for cases such as music_control.edc,
where a group has been shipping for years with API signals like
"btn,clicked" which cannot be changed since they are used in an external
application and compatibility must be maintained
the documentation for this option explicitly states that it must only be used
inside an #ifdef SKIP_NAMESPACE_VALIDATION block, allowing this keyword to
be easily removed at a later point
ref T7072
@feature
Differential Revision: https://phab.enlightenment.org/D6388
Hosang Kim [Thu, 5 Jul 2018 19:15:55 +0000 (15:15 -0400)]
ecore_evas: skip rendering evas and making animator tick
Summary:
Some ecore_evas such as ecore_evas_extn_plug doesn't have evas.
ecore_evas_extn_plug seems to be Ecore_Evas, but actually it is Evas_Object_Image.
ecore_evas_extn_plug makes new ecore evas, but it only exists to communicate with ecore_evas_extn_socket.
newly ecore evas only open and close file(ecore_evas_extn_socket). so it doesn't have evas.
```
EAPI Evas_Object *
ecore_evas_extn_plug_new_internal(Ecore_Evas *ee_target)
{
...
ee = calloc(1, sizeof(Ecore_Evas));
...
o = evas_object_image_filled_add(ee_target->evas);
...
return o;
}
```
Reviewers: zmike, Hermet, woohyun, raster, devilhorns
Reviewed By: zmike
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6504
Mike Blumenkrantz [Thu, 5 Jul 2018 19:12:45 +0000 (15:12 -0400)]
evas/main: call correct destroy function in evas_free
Summary:
an evas may or may not have a parent; this is legacy api and it's all
confusing
Reviewers: bu5hm4n, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6486
Mike Blumenkrantz [Thu, 5 Jul 2018 19:11:06 +0000 (15:11 -0400)]
tests/eo: add explicit test case for setting an object as its own parent
Summary: Depends on D6489
Reviewers: bu5hm4n, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6490
Mike Blumenkrantz [Fri, 29 Jun 2018 21:10:26 +0000 (17:10 -0400)]
eo/base_class: explicitly refuse to set an object as its own parent
somehow this has been possible until now. no.
@fix
Differential Revision: https://phab.enlightenment.org/D6489
Marcel Hollerbach [Thu, 5 Jul 2018 19:09:21 +0000 (15:09 -0400)]
elm_popup: ensure focus is emitted on this object
Summary:
This mirrors the focus property from the notify to the one from popup.
This is needed to establish legacy behaviour, as earlier popup was able to get focus.
ref T6707
Depends on D6510
Reviewers: zmike, devilhorns
Reviewed By: zmike
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6707
Differential Revision: https://phab.enlightenment.org/D6511
Marcel Hollerbach [Thu, 5 Jul 2018 19:09:18 +0000 (15:09 -0400)]
efl_ui_focus_manager_root_focus: mirror the focus properties correctly
Summary:
this object takes a internal dummy object, and thus the properties
should be mirrored to the real root.
The focus property on the root of the manager is required that the outer world really sees that the focus is on the root or not.
Depends on D6506
Reviewers: zmike, devilhorns
Reviewed By: zmike
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6510
Marcel Hollerbach [Thu, 5 Jul 2018 19:09:14 +0000 (15:09 -0400)]
elua: disable this for now
Summary:
the files that are generated are calling files that dont exist anymore.
This cannot work and is only eating time when building, disable this for
now. It can be reenabled late.
The api missing was removed in
fc88037977dcc39dfd6d817c522cce01f5bfa024.
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: ManMower, cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6506
Chris Michael [Wed, 4 Jul 2018 20:51:21 +0000 (16:51 -0400)]
elementary: Add missing EINA_UNUSED for unused function parameter
Xavi Artigas [Wed, 4 Jul 2018 20:46:26 +0000 (16:46 -0400)]
ecore: fix public/private class separation
Summary:
A few classes were added in the wrong place in the makefile, rendering them
neither public nor legacy, and unaccessible to bindings.
Test Plan:
The Efl.Model_Item class is now accessible to C#, and previously it wasn't.
This class is used in the EO tutorials, which would have needed a rewrite.
make check, examples & distcheck still work.
Reviewers: bu5hm4n, zmike, devilhorns
Reviewed By: zmike, devilhorns
Subscribers: cedric, felipealmeida, lauromoura, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6507
Shinwoo Kim [Thu, 19 Jul 2018 09:25:53 +0000 (18:25 +0900)]
Migration: Fix Build Break
Jiyoun Park [Thu, 24 May 2018 08:59:33 +0000 (17:59 +0900)]
[Title] Fix to the bug which is the shared evas_gl_context with multi window
[Problem] When multi windows are shown, the latest window does not shown.
[Cause] The latest window can not call glViewport with the updated coordinate
[Solution] Force call glViewport when window resizing occurs
[Team] Graphics
Change-Id: I6df3f021385fe24190854abe84cb180d236a9dda
Hermet Park [Wed, 18 Jul 2018 05:26:16 +0000 (14:26 +0900)]
emile image: close file properly.
@fix
Change-Id: Ied6436f4bc4cbb048a5c136ee000909a8bbd3aeb
Joogab Yun [Tue, 17 Jul 2018 08:15:29 +0000 (17:15 +0900)]
ecore_evas_tbm : add tbm_surface_map and unmap at tbm_pixels_acquire()
and release()
Change-Id: I6522c3d7730591cce7975b9d15d6ebc066e4174d
Joogab Yun [Tue, 17 Jul 2018 07:53:33 +0000 (16:53 +0900)]
evas : modified to share resource by each gl backend
Change-Id: I5dfaa8ea94a840f3e1512707699bda8b8e2abf19
Joogab Yun [Mon, 2 Jul 2018 02:46:00 +0000 (11:46 +0900)]
evas_tbm : Add more thread safety
Change-Id: I093469f2f081205f9fa633487313c5b9bded4521
Joogab Yun [Mon, 18 Jun 2018 04:32:14 +0000 (13:32 +0900)]
evas : Change tbm_bufmgr to tbm_dummy_display.
Change-Id: I7d9d88f01a6ff9960b6e0149ee0a55c2e80b41e3
Hermet Park [Fri, 13 Jul 2018 05:11:01 +0000 (05:11 +0000)]
Revert "Revert "evas_gl: fix a TC fail of EGL_SYNC""
This reverts commit
e491817c99e5a5d909af8b11453523dcede495ee.
Change-Id: I55bd46ebbfbff5390a88fa7c09de042fff2ac436
Hermet Park [Fri, 13 Jul 2018 05:10:44 +0000 (05:10 +0000)]
Revert "Revert "evas : remove return null""
This reverts commit
0c6502556008708c8441784525e2015c521c91d8.
Change-Id: I85b4f7e9cf9b3401336e634f7d52e572d8ea80fb
Hermet Park [Fri, 13 Jul 2018 05:08:26 +0000 (14:08 +0900)]
Revert "evas : remove return null"
This reverts commit
87eba6aa9eb2d31f496f845df4c3a79d73405ec1.
temporarily revert for SR.
Change-Id: I70deb73fba407212d585b01dc2cff728a328f0c1
Hermet Park [Fri, 13 Jul 2018 05:07:38 +0000 (14:07 +0900)]
Revert "evas_gl: fix a TC fail of EGL_SYNC"
This reverts commit
a757cd4e390f3f01261f1d3179632be0588354bc.
temporarily revert for SR.
Change-Id: I26d6feb0cae96f38e266df48e66c88f17776c576
Daekwang Ryu [Thu, 12 Jul 2018 06:02:03 +0000 (15:02 +0900)]
evas_gl: fix a TC fail of EGL_SYNC
Change-Id: I55e5972f82b33fc5af155cb85d6e7550f47f08ca
Radoslaw Cybulski [Thu, 12 Jul 2018 09:35:19 +0000 (11:35 +0200)]
Fix crash in tct tests
Change-Id: I5148a0791288b195ee67f6227ffb0118fd615799
Joogab Yun [Wed, 11 Jul 2018 05:24:32 +0000 (14:24 +0900)]
evas : remove return null
Change-Id: I539c597e91da10f9e2d5efcf76b61ac68fccba41
Radoslaw Cybulski [Tue, 10 Jul 2018 10:43:27 +0000 (12:43 +0200)]
Fix for invalid navigation on list widget
Change-Id: I0bc8b2855c44fb8075651e993d0f3c5e4869ec3c
Daekwang Ryu [Mon, 25 Jun 2018 04:05:57 +0000 (13:05 +0900)]
evas_gl: fix EVAS_GL_EGL_SYNC_ON
Change-Id: I6ae26b9fff0db48a4ce001fd006d613b83b11c6a
Youngbok Shin [Mon, 9 Jul 2018 00:57:58 +0000 (09:57 +0900)]
evas textblock: adds missing legacy types
*upstream patch(need a review)
https://phab.enlightenment.org/D6529
@tizen_fix
Change-Id: I5360694dcad68003c0444c1643d81e92e1f40e67
Bowon Ryu [Mon, 9 Jul 2018 05:24:05 +0000 (14:24 +0900)]
elm_toolbar: fix flickering issue when item resized.
resize the box first to avoid flickering of
saved state of the toolbar when ratation changed but not in case of scroll.
Change-Id: I1ba904a8c9a346f707b869f03ebd15e07284566c
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Tomasz Jeschke [Mon, 25 Jun 2018 14:46:22 +0000 (16:46 +0200)]
gengrid: fix component_highlight_grab
Change-Id: I759fcadd0f0403ae5898c77840857c41780a1aae
Oskar Chodowicz [Thu, 5 Jul 2018 15:58:06 +0000 (17:58 +0200)]
Fix navigation at CtxPopup
Change-Id: I20604a51f69fb10e064435fd52bbb1a7e36ee34c
Oskar Chodowicz [Wed, 4 Jul 2018 12:48:58 +0000 (14:48 +0200)]
Fix of invalid scrolling from first to last
fix scroll from first to last at apps-screen
Change-Id: I3926b8302ed28924d232811213ff27ac3a4dcbfd
Joogab Yun [Thu, 5 Jul 2018 05:33:57 +0000 (14:33 +0900)]
evas : fixed downscale sampling issue
Fixed an issue where image wave due to differences in sampling
coordinates when overlapping images
Change-Id: Ice000379c0397b52fd3bd44c84e8a7bb517df6bc
Woochan Lee [Mon, 9 Jul 2018 10:15:15 +0000 (19:15 +0900)]
multibuttonentry: Add Tizen Only features to maintain compatibility.
Change-Id: I64684105f79a6d06a473ff4d889d1f706311f054
Bowon Ryu [Thu, 5 Jul 2018 10:31:30 +0000 (19:31 +0900)]
Revert "Fix structure of AT-SPI genlist subtree"
This reverts commit
e17303010bfe5fe53127c708fc7fa56fc346630b.
Hermet Park [Wed, 4 Jul 2018 01:36:04 +0000 (10:36 +0900)]
Revert "[evasgl] change swap mode when rect size not match tile size"
This reverts commit
9a7a006c5e38e5991ed7707e7fb35e8ceb1a3839.
This stopped partial rendering that breaks tv performance.
We need to make sure the precise scenario that requires this patch.
There may be a better solution to clip the drawing region
with exact multiple of tile size. see...
Change-Id: If9a792d9d3ed93c5fe92e9862f29f4345f3571bd
Hermet Park [Tue, 3 Jul 2018 03:26:59 +0000 (12:26 +0900)]
Revert "eo: Turn thread-validation off for unstable Tizen 5.0 apps which are violating thread-safety."
This reverts commit
017b38c5e98bfa2906782ed172d5d9c997d39414.
No more requirement by VD, so forget this.
Change-Id: Icda4cc71147f0a3cae0c85666fc83243b7186469
Tomasz Jeschke [Tue, 19 Jun 2018 10:51:51 +0000 (12:51 +0200)]
Fix structure of AT-SPI genlist subtree
Change-Id: I3eefa7a6ebcd2f69004032c1d2b706f8545365cc
Hermet Park [Wed, 4 Jul 2018 09:02:00 +0000 (18:02 +0900)]
update res folder that has been changed in upstream.
Change-Id: I12efe0ae0fcad4fdf65fbb96cf49cdb843012493
Bryce Harrington [Wed, 4 Jul 2018 02:12:57 +0000 (11:12 +0900)]
eina: Improve eina_binbuf function documentation
Summary:
Define return values as part of @return.
Cleanup grammar.
Reviewers: devilhorns
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6503
Mike Blumenkrantz [Wed, 4 Jul 2018 01:51:01 +0000 (10:51 +0900)]
evas: add more error messages when passing invalid objects to evas callbacks
Summary:
this should only happen if the user has made a mistake regarding the
existence or type of an object, so ensure that an error message occurs to
help debug any failures which result
fix T6326
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: Hermet
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6326
Differential Revision: https://phab.enlightenment.org/D6322
Bryce Harrington [Tue, 3 Jul 2018 18:44:41 +0000 (14:44 -0400)]
eina: Improve eina_benchmark function documentation
Summary:
Define return values as part of @return.
Clarify that the returned list of files are gnuplot filenames specifically.
Cleanup grammar throughout.
Reviewers: zmike, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6502
Mike Blumenkrantz [Tue, 3 Jul 2018 16:49:08 +0000 (12:49 -0400)]
efreet: use correct path when generating error message about stale efreetd socket
Summary:
using runtime directory in all cases for this is wrong, as ecore-con has a number
of fallback codepaths for the case where runtime directory is not set or not valid.
by using the same ecore-con function which ecore-ipc uses to generate the socket
string, the error message path should always be the same as the path which is
used by efreetd
extra linkage was required by efreet in order to use ecore-con functions, so
the internal lib variable in the build system was modified to provide this
@fix
fix T7045
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7045
Differential Revision: https://phab.enlightenment.org/D6425
Mike Blumenkrantz [Tue, 3 Jul 2018 16:46:49 +0000 (12:46 -0400)]
tests/eina: disable eina debug signal handling test in non-fork mode
Summary: signal tests can only be used in fork mode or else they just fail
Reviewers: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6477
Mike Blumenkrantz [Tue, 3 Jul 2018 16:44:13 +0000 (12:44 -0400)]
tests/ecore-con: fix dns test to use correct ordering
Summary:
it's unclear to me why this test was implemented with the expected
event ordering of SERVER_DEL -> SERVER_ERROR; going as far back
as efl 1.7, the behavior has always been ERROR -> DEL
this fixes the test to verify the expected event ordering on a dns
resolve failure
Depends on D6481
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6482
Mike Blumenkrantz [Tue, 3 Jul 2018 16:42:00 +0000 (12:42 -0400)]
ecore-con/legacy: kill server with DEL event if a dialer error occurs
Summary:
in the course of the efl-net rewrite, the previous relied-upon behavior
sequence of error -> disconnect -> del was broken, and error events no
longer triggered disconnects or server deletion.
the failure was caused by a check for the 'connecting' flag, preventing
DEL events from being triggered
further, the ordering of the events was flipped from ERROR -> DEL to
DEL -> ERROR; this is also fixed now
this caused any failed connection to leak the entire server connection
since existing handlers for the del event were never triggered and the
server was never destroyed
@fix
fix T6330
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6330
Differential Revision: https://phab.enlightenment.org/D6481
Mike Blumenkrantz [Tue, 3 Jul 2018 16:39:36 +0000 (12:39 -0400)]
elm_test: fix invalid read in dnd image drop
Summary:
this selection is data with a specified length, not a terminated string
@fix
Depends on D6484
Reviewers: devilhorns
Subscribers: netstar, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6485
Mike Blumenkrantz [Tue, 3 Jul 2018 16:39:33 +0000 (12:39 -0400)]
efl/selection_manager: fix some invalid memory reads
Summary:
these selections are data with specified lengths, not strings
Depends on D6483
Reviewers: devilhorns, bu5hm4n
Subscribers: bu5hm4n, netstar, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6484
Mike Blumenkrantz [Tue, 3 Jul 2018 16:39:26 +0000 (12:39 -0400)]
efl/selection_manager: make selection manager a child of the app
Summary:
a selection manager is application-wide, not per-window. creating separate
managers for each window duplicates all callbacks for the window's display
server, guaranteeing broken behavior at any time when more than one window
exists
fix T6937
Reviewers: bu5hm4n, devilhorns
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6937
Differential Revision: https://phab.enlightenment.org/D6483
Mike Blumenkrantz [Mon, 2 Jul 2018 18:28:35 +0000 (14:28 -0400)]
eina/debug: remove global lock for session list access
this list is now only accessed from the main thread so there's no reason
to have a lock for it
projects / platform / upstream / efl.git / log