Vitek Karas [Fri, 12 May 2023 20:31:25 +0000 (13:31 -0700)]
Add tests for RUC warnings on override methods (#86015)
These are tests for bug https://github.com/dotnet/runtime/issues/86008.
I also restructured the test file into nested classes some more as it's easier to navigate this way.
Also adds a test for https://github.com/dotnet/runtime/issues/86032.
David Mason [Fri, 12 May 2023 19:41:28 +0000 (12:41 -0700)]
Add ICorProfiler API to allow profiler created providers to have a callback when a session enables them (#80528)
Mark Plesko [Fri, 12 May 2023 19:22:03 +0000 (12:22 -0700)]
Use unique IL assembly names instead of automatic renaming (#85185)
The main motivation for this is that I got stuck trying to write documentation for test merging and test suffixes. We have _il_d for IL and both _d and _cs_d for C# (and similar for _r and others - I'll use _d to denote all such tests here). Only the IL files needed to be separated into different merged groups, yet we split the C# as well.
This change renames the _il_d to just _d (unless there is already an existing _d, likely for a C# version of the test). It then replaces .assembly <name> with .assembly ASSEMBLY_NAME and adds per-configuration "prefix" IL source files with #define ASSEMBLY_NAME <name>_d. Then the rules are simple - tests have unique assembly names and no build-time renaming is required.
This lets me remove the 4 Regression merged groups with ~10 tests each in them. I rebalanced the merged groups where the number of _d tests were larger except HardwareIntrinsics (a unique directory) and Methodical (most of the tests are _d).
Pavel Savara [Fri, 12 May 2023 19:17:54 +0000 (21:17 +0200)]
remove wrap_trace_function (#86158)
Mark Plesko [Fri, 12 May 2023 18:49:51 +0000 (11:49 -0700)]
Convert JIT/SIMD to a merged test group (#85852)
See https://github.com/markples/utils/tree/for-PR-dotnet-runtime-85847-others for ILTransform tool.
* [ILTransform -prociso] Set RequiresProcessIsolation when needed by other properties
* [ILTransform -public] Make test entrypoints accessible
* Manual fixes for [ILTransform -public] - public partial classes
* [ILTransform -ilfact] Main->TestEntryPoint, [Fact], remove OutputType=Exe
* Remove DOTNET_JitFuncInfoLogFile/SIMD.log from JIT/SIMD
* Manual fixes for xUnit1013 - internal methods
* Manually fix case of accessibility of test in nested type
* Add merged group
Mark Plesko [Fri, 12 May 2023 18:49:10 +0000 (11:49 -0700)]
Convert JIT/opt to a merged test group (#85850)
See https://github.com/markples/utils/tree/for-PR-dotnet-runtime-85847-others for ILTransform tool. In this group, I was a bit more aggressive in converting individual tests in [Fact]s and [Theory]s when needing to make manual changes. This required a change to the wrapper generator.
* Manual removal of C# Main args
* Mark async Main test as RPI
* Manual removal of IL Main arg
* Manual fix for badcallee
* [ILTransform -p] Remove _il from project name
* [ILTransform -n] Unique project names
* [ILTransform -m] Remove .module from IL tests
* Rename GitHub_42719: _r means not DebugType=Full, _o for optimize
* [ILTransform -a] Match IL .assembly names to project names
* [ILTransform -prociso] Set RequiresProcessIsolation when needed by other properties
* [ILTransform -sr] Use canonical form for .assembly extern System.Runtime
* [ILTransform -ilfact] Main->TestEntryPoint, [Fact], remove OutputType=Exe
* [ILTransform -public] Make test entrypoints accessible
* Manual fixes for [ILTransform -public] - internal methods to handle internal parameter types
* Handle float constants for InlineData in XUnitWrapperGenerator
* Manual fixes for xUnit1013 - internal methods, convert to [Theory]
* Manual fixes for xUnit1013 - internal methods, disable region
* Add merged group
* Fix mismatch{32,64} by putting the test methods in classes
Mark Plesko [Fri, 12 May 2023 18:48:13 +0000 (11:48 -0700)]
Convert JIT/Generics to a merged test group (#85849)
See https://github.com/markples/utils/tree/for-PR-dotnet-runtime-85847-others for ILTransform tool.
* [ILTransform -p] Remove _il from project names
* [ILTransform -n] Unique project names
* [ILTransform -a] Match IL .assembly names to project names
* [ILTransform -prociso] Set RequiresProcessIsolation when needed by other properties
* [ILTransform -public] Make test entrypoints accessible
* Manual fixes for [ILTransform -public] - internal methods to handle internal parameter types
* [ILTransform -sr] Use canonical form for .assembly extern System.Runtime
* [ILTransform -ilfact] Main->TestEntryPoint, [Fact], remove OutputType=Exe
* Manually created unique project names that were missed due to casing
* Add merged group
dotnet-maestro[bot] [Fri, 12 May 2023 17:53:34 +0000 (12:53 -0500)]
[main] Update dependencies from dotnet/roslyn-analyzers (#86093)
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230510.2
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.3.5-beta1.23258.1 -> To Version 3.3.5-beta1.23260.2
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230512.1
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.3.5-beta1.23258.1 -> To Version 3.3.5-beta1.23262.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Marek Fišera [Fri, 12 May 2023 17:52:09 +0000 (19:52 +0200)]
[wasm] Unify boot config location (#85763)
Load mono-config.json and blazor.boot.json from the same location
Eirik Tsarpalis [Fri, 12 May 2023 17:47:47 +0000 (18:47 +0100)]
Make the STJ source generator cache friendly (#86121)
* Make the STJ source generator cache friendly.
* Address feedback
* Fix GetHashCode implementation.
* Update src/libraries/System.Text.Json/gen/JsonSourceGenerator.Emitter.cs
Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Remove TODO comment.
* Remove TODO comment.
* Update src/libraries/System.Text.Json/gen/Model/ImmutableEquatableArray.cs
Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Address feedback.
* Address feedback
* Expand incremental compilation unit test coverage to include Roslyn tracking.
---------
Co-authored-by: Stephen Toub <stoub@microsoft.com>
dotnet-maestro[bot] [Fri, 12 May 2023 17:40:34 +0000 (12:40 -0500)]
[main] Update dependencies from dotnet/arcade (#86091)
* Update dependencies from https://github.com/dotnet/arcade build
20230510.3
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23259.5 -> To Version 8.0.0-beta.23260.3
* Update dependencies from https://github.com/dotnet/arcade build
20230511.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23259.5 -> To Version 8.0.0-beta.23261.4
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Bruce Forstall [Fri, 12 May 2023 17:01:37 +0000 (10:01 -0700)]
Remove unused multi-dimensional array code (#86133)
MD array processing in the JIT changed with https://github.com/dotnet/runtime/pull/70271,
making all the code that implemented the old processing method unused.
Remove all this unused code.
Fixes #71678
Mike McLaughlin [Fri, 12 May 2023 17:01:21 +0000 (10:01 -0700)]
Fix createdump --crashreport option error (#86137)
Kunal Pathak [Fri, 12 May 2023 16:52:59 +0000 (09:52 -0700)]
Templatize `enregisterLocalVars` in various methods of LSRA (#85144)
* Optimize identifyCandidates()
* Optimize isRegCandidate()
* Optimize initVarRegMaps()
* Optimize processBlockEndAllocation() and processBlockStartLocations()
* Optimize resolveRegisters()
* jit format
* Revert change for initVarRegMask()
* Remove the unneeded assert
* Optimize buildIntervals()
* Fix the revert I did previously
* review feedback
Parker Bibus [Fri, 12 May 2023 16:35:31 +0000 (09:35 -0700)]
[PERF] Reorder urllib and remove --force-reinstall but keep pinned version (#86128)
* Move scenario urllib imports to the last install position.
* Remove force-reinstall from all pip installs in the scenarios-job.yml files.
Stephen Toub [Fri, 12 May 2023 16:33:06 +0000 (12:33 -0400)]
Tweak new OutOfMemory_StringTooLong exception message (#86150)
* Tweak new OutOfMemory_StringTooLong exception message
Add a period, fix the tense (the string isn't created yet), and clarify what it means to be too long.
* Update src/libraries/System.Private.CoreLib/src/Resources/Strings.resx
Jan Kotas [Fri, 12 May 2023 16:18:46 +0000 (09:18 -0700)]
Fix official build of cross DAC components (#86138)
* Fix official build of cross DAC components
Revert changes that broke build of the cross DAC linux-arm components
Fixes #86073
Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>
Tanner Gooding [Fri, 12 May 2023 15:17:49 +0000 (08:17 -0700)]
Expose remaining Avx512 integer intrinsics which don't require VectorMask (#86130)
* Expose Shuffle2x128 and Shuffle4x128 in Avx512F
* Expose various PermuteVar#x#x2 APIs in Avx512F, Avx512BW, and Avx512Vbmi
* Apply formatting patch
* Fix unix build failure
Daniel Svensson [Fri, 12 May 2023 10:43:40 +0000 (12:43 +0200)]
Improve Ascii (and Utf8) encoding (#85266)
* Improve writing of lower vector part in ascii convertion
* from 10 /17 to 1 instruction for 64/32 bit x86
* Add [MethodImpl(MethodImplOptions.AggressiveInlining)] to NarrowUtf16ToAscii_Intrinsified
* rewrite StoreLower without Sse2.StoreScalar
* move helper to Vector128 and call in case conversion
* remove unused helpers
Dong-Heon Jung [Fri, 12 May 2023 10:27:47 +0000 (19:27 +0900)]
[RISC-V] Fix emitOutputInstr (#86078)
- Fix to use instruction code not INS_
Michal Strehovský [Fri, 12 May 2023 08:37:10 +0000 (17:37 +0900)]
Delete more code around reflection blocking (#86139)
We had a bunch of code to carefully compute names in situations where the metadata/names might not be available. Such situations no longer exist.
hrrrrustic [Fri, 12 May 2023 08:15:23 +0000 (11:15 +0300)]
Remove last `!` from Caching.Abstractions (#85918)
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Christopher Watford <132389385+watfordkcf@users.noreply.github.com>
Bruce Forstall [Fri, 12 May 2023 04:02:48 +0000 (21:02 -0700)]
Fix spurious SuperPMI asm diffs (#86132)
Under ELT profiler stress, we encode the un-relocated address
of the `DummyProfilerELTStub` function in the JIT codebase into
the generated code. This can lead to spurious diffs if the address
is different between base and diff JITs (which is likely).
To avoid this, under SuperPMI replay (which we only know in DEBUG
builds currently), use a fixed constant for this address. The code
isn't executed during SuperPMI replay, so it doesn't need to be a
valid code address.
Jeremy Koritzinsky [Fri, 12 May 2023 02:01:50 +0000 (19:01 -0700)]
Update portable linux source-build legs to use AlmaLinux to better represent building on RHEL8 (#86114)
SingleAccretion [Fri, 12 May 2023 01:48:53 +0000 (04:48 +0300)]
Fix an SSA bug from the `ASG` refactoring (#86108)
* Add a test
* Fix an SSA bug from the GT_ASG refactoring
Recording PHIs from analyzable stores is a correctness requirement.
Stephen Toub [Thu, 11 May 2023 23:56:43 +0000 (19:56 -0400)]
Clean up shared ArrayPool naming and add some env var config (#86109)
* Clean up shared ArrayPool naming and add some env var config
We've had several requests to be able to tweak / experiment with how many arrays the shared array pool might store. This adds two environment variables, one that controls the number of partitions the shared pool uses, and one that controls the number of arrays cacheable in each partition. Previously these values were constants.
As part of doing that, I needed to choose names that were a bit more palatable for external consumption, and I renamed thngs in the implementation accordingly.
* Rename file to SharedArrayPool.cs
* Fix naming scheme
* Avoid using globalization
* Avoid using Environment.GetEnvironmentVariable
* Move nopool env var into Environment
* Move static readonly fields to statics type
Katelyn Gadd [Thu, 11 May 2023 23:18:48 +0000 (16:18 -0700)]
[wasm] [jiterp] Fix jit calls and interp entry wrappers (#86120)
Aaron Robinson [Thu, 11 May 2023 21:15:05 +0000 (14:15 -0700)]
Add necessary subset of wide char APIs to minipal (#86055)
* Update minipal with UTF-16 functions
* Remove function redefines from PAL header
* Remove need of PAL_wcslen from LTTNG
generator.
* Remove specified calling conventions for x86
Layomi Akinrinade [Thu, 11 May 2023 21:03:01 +0000 (14:03 -0700)]
Support ConfigurationBinder.GetValue in source-gen (#86076)
* Support ConfigurationBinder.GetValue in source-gen
* Address feedback
Jo Shields [Thu, 11 May 2023 20:09:12 +0000 (16:09 -0400)]
Hardcode the path to libclang from Mariner, not Clang 9 on CentOS 7 (#86096)
* Hardcode the path to libclang from Mariner, not Clang 9 on CentOS 7
Tanner Gooding [Thu, 11 May 2023 19:10:03 +0000 (12:10 -0700)]
Ensure DecomposeRotate correctly orders parameters. (#86066)
* Add a regression test for dotnet/runtime#86207
* Ensure RotateRight and RotateLeft decomposition orders parameters correctly
* Add explicit tests covering the other two DecomposeRotate paths
* Ensure other code paths that create GT_RSH_LO nodes aren't broken
Michal Strehovský [Thu, 11 May 2023 19:07:15 +0000 (04:07 +0900)]
Make casting helpers look more like in CoreCLR (#86029)
* Make casting helpers look more like in CoreCLR
Speeds up casting to interfaces by about 50%. Speeds up casting to classes by about 20%.
There are small differences compared to CoreCLR:
* NativeAOT runtime considers interfaces implementable by arrays to be variant. We don't need to special case casting arrays to non-variant (in IL sense) interfaces because those naturally take the variant paths.
* The base type field on arrays holds the array element type so we need to check for the array case before starting to chase the base hierarchy.
Otherwise the top level helpers now look mostly the same as the CoreCLR ones.
* Make it tailcallable
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Pavel Savara [Thu, 11 May 2023 19:02:02 +0000 (21:02 +0200)]
[browser] loader ES6 module (#85730)
dotnet-maestro[bot] [Thu, 11 May 2023 18:53:47 +0000 (13:53 -0500)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230510.3 (#86090)
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23258.3 -> To Version 1.0.0-prerelease.23260.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
SingleAccretion [Thu, 11 May 2023 17:30:45 +0000 (20:30 +0300)]
Fix printing of arcs for local stores (#86098)
Larry Ewing [Thu, 11 May 2023 17:02:01 +0000 (12:02 -0500)]
Set SelfContained=true for browser-wasm runtimes (#86102)
Alexander Köplinger [Thu, 11 May 2023 16:58:09 +0000 (18:58 +0200)]
Skip ProcessStartInfoTests.TestWindowStyle if COM interop is not supported (#85813)
* Skip ProcessStartInfoTests.TestWindowStyle if COM interop is not supported
This happens on e.g. Mono or NativeAOT and results in this exception:
```
System.Diagnostics.Tests.ProcessStartInfoTests.TestWindowStyle(windowStyle: Normal, useShellExecute: True) [FAIL]
System.PlatformNotSupportedException : COM Interop is not supported on this platform.
Stack Trace:
/_/src/mono/System.Private.CoreLib/src/System/Threading/Thread.Mono.cs(262,0): at System.Threading.Thread.SetApartmentStateUnchecked(ApartmentState state, Boolean throwOnError)
/_/src/libraries/System.Private.CoreLib/src/System/Threading/Thread.cs(521,0): at System.Threading.Thread.SetApartmentState(ApartmentState state, Boolean throwOnError)
/_/src/libraries/System.Private.CoreLib/src/System/Threading/Thread.cs(499,0): at System.Threading.Thread.SetApartmentState(ApartmentState state)
/_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Win32.cs(177,0): at System.Diagnostics.Process.ShellExecuteHelper.ShellExecuteOnSTAThread()
/_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Win32.cs(74,0): at System.Diagnostics.Process.StartWithShellExecuteEx(ProcessStartInfo startInfo)
/_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Win32.cs(25,0): at System.Diagnostics.Process.StartCore(ProcessStartInfo startInfo)
/_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs(1282,0): at System.Diagnostics.Process.Start()
/_/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.Windows.cs(108,0): at System.Diagnostics.Tests.ProcessStartInfoTests.TestWindowStyle(ProcessWindowStyle windowStyle, Boolean useShellExecute)
/_/src/mono/System.Private.CoreLib/src/System/Reflection/MethodInvoker.Mono.cs(30,0): at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, IntPtr* args)
/_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs(59,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
```
* Only skip test on mono
Günther Foidl [Thu, 11 May 2023 16:48:04 +0000 (18:48 +0200)]
Optimizations for Ascii.Equals and Ascii.EqualsIgnoreCase (#85926)
Ivan Povazan [Thu, 11 May 2023 14:52:57 +0000 (16:52 +0200)]
[NativeAOT] Another attempt to prevent stripping exported symbols from executables when explicitly specified (#86050)
Stephen Toub [Thu, 11 May 2023 13:19:27 +0000 (09:19 -0400)]
Fix some nullable annotations / null handling in System.Text.Json (#86077)
The `JsonConverter<T>`s for reference type `T`s need to be able to deal with null. Fix the nullable annotations accordingly. This then led to highlghting that the implementation can null ref if a dictionary returns a null key, so adding appropriate validation of that, too.
Stephen Toub [Thu, 11 May 2023 13:12:28 +0000 (09:12 -0400)]
Remove generated locals in RegexCompiler.LoadSearchValues (#86010)
Rely instead of improvements to JIT's recognition of Unsafe.As.
Egor Bogatov [Thu, 11 May 2023 12:35:16 +0000 (14:35 +0200)]
JIT: Fold typeof(T).TypeHandle.Value (#85804)
Co-authored-by: Andy Ayers <andya@microsoft.com>
Lakshan Fernando [Thu, 11 May 2023 12:11:29 +0000 (05:11 -0700)]
Enabling RuntimeEventSource in NativeAOT (#85424)
* Enabling RuntimeEventSource for counters
* enable exception and assembly count
* FB
* make the exception count thread safe
* revert reflection blocking workaround and open an issue for the CoreCLR exceptioncount fix
* Missed syncing to branch before syncing with main
* Update src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/Assembly.NativeAot.cs
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
* FB
* Removing unnecessary whitespace chang
---------
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Michal Strehovský [Thu, 11 May 2023 10:01:37 +0000 (19:01 +0900)]
Handle cctor dependency on RVA static access (#86081)
Contributes to #68278.
Meri Khamoyan [Thu, 11 May 2023 09:33:40 +0000 (13:33 +0400)]
Change IsolatedStorageFile path for mobile (#83380)
Updated isolated storage root path for mobile platforms
---------
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Jeremy Koritzinsky [Thu, 11 May 2023 08:09:14 +0000 (01:09 -0700)]
Add integration tests for PreserveSig and use the MemberFunction calling convention by default in the ComInterfaceGenerator (#86072)
Marek Fišera [Thu, 11 May 2023 07:55:10 +0000 (09:55 +0200)]
[wasm] Docs on overriding runtime pack in blazor wasm (#85455)
Zoltan Varga [Thu, 11 May 2023 06:32:08 +0000 (23:32 -0700)]
[mono][llvm] Fix the emission of nonnull metadata on loads. (#86071)
Fixes llvm verification errors in newer llvm versions:
```
nonnull metadata must be empty
%49 = load ptr, ptr @aotconst_ldstr_21, align 8, !nonnull !1
```
Zoltan Varga [Thu, 11 May 2023 06:31:51 +0000 (23:31 -0700)]
[mono] Move most runtime callbacks into the MonoRuntimeCallbacks structure. (#86080)
Zoltan Varga [Thu, 11 May 2023 06:14:03 +0000 (23:14 -0700)]
[mono][wasm] Allow linking out some runtime code on wasm. (#86079)
Bruce Forstall [Thu, 11 May 2023 04:41:38 +0000 (21:41 -0700)]
Fix official build after removing win-arm runtime build (#86074)
win-arm CI builds were removed with https://github.com/dotnet/runtime/pull/85947
Will Smith [Thu, 11 May 2023 04:39:02 +0000 (21:39 -0700)]
[JIT] X64 - Centralize peephole optimization for removing redundant `mov` instructions (#85780)
Jan Kotas [Thu, 11 May 2023 03:02:38 +0000 (20:02 -0700)]
Delete Windows arm32 support (#86065)
Zoltan Varga [Wed, 10 May 2023 22:36:48 +0000 (15:36 -0700)]
[mono][aot] Fix an assert. (#86054)
Fixes https://github.com/dotnet/runtime/issues/86052.
dotnet-maestro[bot] [Wed, 10 May 2023 21:51:35 +0000 (16:51 -0500)]
Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230508.1 (#85972)
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.3.5-beta1.23256.1 -> To Version 3.3.5-beta1.23258.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Bruce Forstall [Wed, 10 May 2023 21:42:26 +0000 (14:42 -0700)]
Add linux-x64 hosted tpdiff to superpmi-diffs pipeline (#86021)
* Add linux-x64 hosted tpdiff to superpmi-diffs pipeline
With this, we get instruction count diffs based on clang compiled
native JITs.
* Fix some variables
Also, fix some Python 'lint' issues.
* Fix more path issues, Windows targeting global var
* Feedback
1. Make `determine_jit_name` a utility library function.
All 3 versions were different, so required some adjustments.
jitrollingbuild.py had not previously used `jitutil` so added use
and removed additional duplicated code.
2. Renamed partitions to not use `unix` name. This is purely an internal
name, not exposed.
3. Simplified some FileSeparatorChar usage.
4. Fixed more pylint complaints
Parker Bibus [Wed, 10 May 2023 21:18:05 +0000 (14:18 -0700)]
[PERF] Add arm64 dynamic pgo runs (#86014)
* Add DynamicPGO arm64 linux and windows runs.
* Added parity to performance-setup.sh for pgo (no, dynamic, full) runs.
* Pass the pgoRunType through to the performance (Unix) setup script as well in performance-job.yml.
* Add Linux x64 dynamic pgo.
Vitek Karas [Wed, 10 May 2023 21:01:12 +0000 (14:01 -0700)]
ILLink should keep parameter names for methods which are used to create a delagate (#85831)
This is a fix for https://github.com/dotnet/linker/issues/3061.
If the app creates a delegate over a method and later on access the `Delegate.Method` property it can get a `MethodInfo` which it can use to inspect some aspects of the method, specifically parameter names.
NativeAOT already handles this correctly, but ILLink doesn't and will trim the parameter names away. The correct behavior is to treat such method as reflection accessible (we really don't want to mark the `Delegate.Method` property as trim incompatible).
The ideal way to implement this is to perform full data flow on method addresses, which would allow us to detect which method is the delegate created for. (this is what NativeAOT ends up doing through JIT)
But that is rather complex, an easier solution is to treat any method which address is accessed as reflection enabled. This covers all delegates. It might mark more methods as reflection enabled, but it's very uncommon.
So this change does that, it will mark all methods accessed via `ldftn` (or similar) as reflection enabled.
Additionally this cleans up marking of reflection enabled members in the MarkStep. Specifically there was a distinction between reflection accessed and indirect accessed methods, but the latter only kicked in for the obsolete preserve attributes. It's better to reflection mark those as well. This might cause a small size regression, but it's very unlikely to be even observable.
This requires lot more test changes to enable sane testing:
* In the ILC test infra, track if method was kept with or without reflection metadata (as that is the difference in NativeAOT which will provide parameter names or not)
* Teach both the ILLink and ILC test infras how to handle compiler generated code with the `Kept` attribute validation
* This is in no way complete, but it's an improvement
* Mostly it means that we don't fail the test if a compiler generated code is kept without it being marked with the `Kept` attribute (as that's not always possible)
* Note that we have some support for this for things like backing fields and private implementation details, but nothing which can handle state machines, and closure types for lambdas. These should now be workable, without the ability to verify that they were indeed kept (and how)
* Finally adds tests verifying the new functionality.
Stephen Toub [Wed, 10 May 2023 20:49:47 +0000 (16:49 -0400)]
Add ArgumentException.ThrowIfNullOrWhiteSpace (#86007)
* Add ArgumentException.ThrowIfNullOrWhiteSpace
* Fix tests
Layomi Akinrinade [Wed, 10 May 2023 20:19:12 +0000 (13:19 -0700)]
Capture remaining binding Bind & Get methods for source generator support (#85843)
* Capture remaining binding methods for source generator support
* Capture remaining binding methods for source generator support
* Implement method emission
* Restore binder implemenation
* Complete currently unsupported test annotation
* Clean up method gen implementation
* Refactor for ideal emitted code (for baseline tests)
* Clean up
Sven Boemer [Wed, 10 May 2023 19:54:40 +0000 (12:54 -0700)]
Update linux build instructions (#86062)
To reflect recent series of changes to our official build. This
updates the mentioned images to use floating tags, and clarifies
that the new official build containers all are designed for
cross-building.
Steve Harter [Wed, 10 May 2023 19:15:12 +0000 (14:15 -0500)]
Revert "let user know working directory will be used as content root path by default (#82445)" (#86057)
This reverts commit
c958573654937f9582b6a23522b2ad16cd7dbf96.
dotnet-maestro[bot] [Wed, 10 May 2023 19:06:18 +0000 (14:06 -0500)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230508.3 (#85968)
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23256.3 -> To Version 1.0.0-prerelease.23258.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Wed, 10 May 2023 19:05:24 +0000 (14:05 -0500)]
Update dependencies from https://github.com/dotnet/roslyn build
20230509.11 (#86036)
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-1.23254.5 -> To Version 4.7.0-1.23259.11
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Wed, 10 May 2023 19:04:50 +0000 (14:04 -0500)]
Update dependencies from https://github.com/dotnet/arcade build
20230509.5 (#86034)
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23255.2 -> To Version 8.0.0-beta.23259.5
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Eirik Tsarpalis [Wed, 10 May 2023 18:18:38 +0000 (21:18 +0300)]
Fix null handling of built-in converters. (#86056)
Jeremy Koritzinsky [Wed, 10 May 2023 18:09:44 +0000 (11:09 -0700)]
Add PreserveSig support to ComInterfaceGenerator (#85941)
Sven Boemer [Wed, 10 May 2023 17:09:52 +0000 (10:09 -0700)]
Update mariner images to latest with LLVM 16 (#84676)
This pulls in the updates from
https://github.com/dotnet/dotnet-buildtools-prereqs-docker/commit/
53fee55b4115616c7029782c9733055db1bc565a
and moves to floating tags for the mariner images, which now
build the product with LLVM 16.
Once this flows to dotnet-optimization, this will require updates
to make the LLVM 16 tools available there. Before the opt data
collected with new LLVM flows into runtime, I plan to fix
https://github.com/dotnet/runtime/issues/85785 so that local
builds won't by default require clang-16.
Bruce Forstall [Wed, 10 May 2023 16:59:15 +0000 (09:59 -0700)]
Remove Windows arm32 support (#85947)
* Remove Windows arm32 support
Mostly, remove the CI runs. Windows arm32 product support was removed
before .NET 6.
* Restore a few files
Only change YML files to remove windows_arm runs.
Don't build Windows arm cross components.
Don't touch mono files.
Changing scripts to remove builds, and remove code, can follow.
Katelyn Gadd [Wed, 10 May 2023 16:28:21 +0000 (09:28 -0700)]
Disable autovectorization on wasm (#86038)
7c75cbf added the -msimd128 flag to cmakelists so that the interpreter could use wasm vector intrinsics. That option appears to imply enabling all sorts of auto-vectorization, which may be responsible for the regressions in dotnet/perf-autofiling-issues#17570
Tanner Gooding [Wed, 10 May 2023 16:04:09 +0000 (09:04 -0700)]
Expose various integer intrinsics for Avx512F, Avx512BW, and Avx512CD (#85833)
* Expose AlignRight32 and AlignRight64 on Avx512F
* Expose RotateLeft and RotateRight for Avx512F
* Expose SumAbsoluteDifferencesInBlock32 for Avx512BW + DetectConflicts and LeadingZeroCOunt for Avx512DQ
* Exponse TernaryLogic for Avx512F
* Apply formatting patch
* Ensure side effects are preserved when optimizing certain intrinsic imports
* Ensure the instruction code has the SIMD prefix before trying to encode the register
* Ensure side effects have been accounted for before swapping operands
* Move the complex ternary logic simplification logic to import, since the JIT will never produce such nodes itself
* Ensure gtNewSimdUnOpNode(GT_NOT) uses an in range constant for TernaryLogic
* Remove a new assert added to AND_NOT, logging an issue instead
* Add a missing `break;` statement
* Ensure val1/2/3 are GenTree** so swapping works and add a comment explaining the TernaryLogic table
* Fix formatting of a comment
* Don't double encode the 'vvvv' bits for `emitOutputAM`
* Avoid an assert in gtNewSimdCreateBroadcastNode for TYP_LONG on 32-bit
* Ensure we use CHECK_SPILL_ALL
* Ensure mustExpand is handled for `RotateLeft(Vector###<long>)` on 32-bit
* Make sure all tests are actually running and handle the "maybe no jmp table fallback"
* Handle a couple test issues and ensure we set the constant when normalizing ~B | C
* Ensure ValidateRemaining uses firstOp[i]
Milos Kotlar [Wed, 10 May 2023 15:21:43 +0000 (17:21 +0200)]
Add instructions for running the runtime tests on iOS platforms (#86045)
Alexander Speshilov [Wed, 10 May 2023 14:36:50 +0000 (17:36 +0300)]
Fix BigInteger parse hex strings on negative numbers (#84792)
fixes dotnet#74758
adj123 [Wed, 10 May 2023 14:00:36 +0000 (15:00 +0100)]
fix JsonNode deserialising from null (#85463)
* fix JsonNode deserialising from null
* add further tests for more null-deserialising scenarios
---------
Co-authored-by: Adam Jones <ajones@drwuk.com>
Elinor Fung [Wed, 10 May 2023 13:15:05 +0000 (15:15 +0200)]
Fix mismatched types in native host test error messaging (#85995)
Elinor Fung [Wed, 10 May 2023 13:05:29 +0000 (15:05 +0200)]
Fix NativeLibraryTests for ilasm round-trip (#85991)
Jakob Botsch Nielsen [Wed, 10 May 2023 11:15:15 +0000 (13:15 +0200)]
JIT: Seed stress modes by string hash (#83771)
Instead of using the numeric value of each stress mode inside the enum,
calculate a hash based on the string name. This has the benefit that it
won't change based on new members being added/reordered and reduces
correlation of which stress modes get enabled together.
Fix #83733
Jakob Botsch Nielsen [Wed, 10 May 2023 10:59:54 +0000 (12:59 +0200)]
JIT: Peel offsets from spilled addresses for store decomposition (#85889)
For a block operation like
```
▌ ASG struct (copy)
├──▌ BLK struct<System.Nullable`1, 8>
│ └──▌ ADD byref
│ ├──▌ LCL_VAR ref V00 this
│ └──▌ CNS_INT long 40 Fseq[<unknown field>]
└──▌ LCL_VAR struct<System.Nullable`1, 8>(P) V06 tmp2
└──▌ bool V06.<unknown class>:hasValue (offs=0x00) -> V12 tmp8 (last use)
└──▌ int V06.<unknown class>:value (offs=0x04) -> V13 tmp9 (last use)
```
We would previously spill the ADD(V00, 40) to a local and end up
producing:
```
▌ COMMA void
├──▌ COMMA void
│ ├──▌ ASG byref
│ │ ├──▌ LCL_VAR byref V15 tmp11
│ │ └──▌ ADD byref
│ │ ├──▌ LCL_VAR ref V00 this
│ │ └──▌ CNS_INT long 40 Fseq[<unknown field>]
│ └──▌ ASG bool
│ ├──▌ IND bool
│ │ └──▌ LCL_VAR byref V15 tmp11
│ └──▌ LCL_VAR bool V12 tmp8
└──▌ ASG int
├──▌ IND int
│ └──▌ ADD byref
│ ├──▌ LCL_VAR byref V15 tmp11
│ └──▌ CNS_INT long 4
└──▌ LCL_VAR int V13 tmp9
```
Instead of this we can include the offsets with the field offsets. In
many cases that allows us to avoid any temporary locals, while in other
cases it usually allows us to avoid an instruction in favor of two
larger containments. In this case we instead end up with:
```
▌ COMMA void
├──▌ ASG bool
│ ├──▌ IND bool
│ │ └──▌ ADD byref
│ │ ├──▌ LCL_VAR ref V00 this
│ │ └──▌ CNS_INT long 40 Fseq[<unknown field>]
│ └──▌ LCL_VAR bool V12 tmp8
└──▌ ASG int
├──▌ IND int
│ └──▌ ADD byref
│ ├──▌ LCL_VAR ref V00 this
│ └──▌ CNS_INT long 44 Fseq[<unknown field>, 4]
└──▌ LCL_VAR int V13 tmp9
```
Bruce Forstall [Wed, 10 May 2023 06:05:58 +0000 (23:05 -0700)]
Disable HugeArray1 for crossgen2 x86 (#86020)
Tracking: https://github.com/dotnet/runtime/issues/85747
Kunal Pathak [Wed, 10 May 2023 05:00:45 +0000 (22:00 -0700)]
Misc LSRA throughput improvements (#85842)
* Use BitOperations in few hot methods
* Do not pass RegisterType for non-arm sarchitectures
* Add clearAssignedInterval()
* Consume clearAssignedInterval()
* Do not pass RegisterType for updateInterval()
* Revert the change in genFindLowestBit()
* Revert "Use BitOperations in few hot methods"
This reverts commit
a75a7da436fe616d8226d8f2a4c5d50c0f447827.
* Add the missing case for clearAssignedInterval()
* Remove logging
* jit formatting
* Use popcount intrinsics
* Revert "Use popcount intrinsics"
This reverts commit
0b3da210a8b754521de29d40e01072fb1b01adc7.
* revert unintentional change from superpmi.py
* Revert "Do not pass RegisterType for non-arm sarchitectures"
This reverts commit
46d4d3d88704beca5f0817db3a6e48fc1a14dac6.
* fix the merge conflicts
Andrii Kurdiumov [Wed, 10 May 2023 04:58:03 +0000 (10:58 +0600)]
Allow set GC configuration in NativeAOT (#85921)
Currently NativeAOT uses `uint32_t` for storing configuration values.
There assumption that configuration would take 8 characters in configuration.
If we set value which has 9 characters it would be silently ignored.
For example: `$env:DOTNET_GCHeapHardLimit="
100000000"` which is 4Gb.
On CoreCLR GC uses `uint64_t` so it does not make sense to limit NativeAOT cofiguration
to 32-bit values here
SingleAccretion [Wed, 10 May 2023 04:57:43 +0000 (07:57 +0300)]
Delete rarely used bashing methods and add some documentation on bashing (#85925)
Michal Strehovský [Wed, 10 May 2023 04:02:21 +0000 (13:02 +0900)]
Add aka.ms link for NativeAOT prerequisites to linker not found error messages (#86024)
Zoltan Varga [Wed, 10 May 2023 03:21:17 +0000 (20:21 -0700)]
[mono] Avoid an assert if the class name table is too large. (#85952)
Fixes https://github.com/dotnet/runtime/issues/85917.
Zoltan Varga [Wed, 10 May 2023 03:16:18 +0000 (20:16 -0700)]
[mono][llvm] Fix an assert. (#85950)
Fixes https://github.com/dotnet/runtime/issues/85724.
Stephen Toub [Wed, 10 May 2023 02:00:02 +0000 (22:00 -0400)]
Dedup PemEncoding.TryCountBase64 with Base64.IsValid (#86002)
* Dedup PemEncoding.TryCountBase64 with Base64.IsValid
* Address PR feedback
Jan Kotas [Wed, 10 May 2023 01:46:58 +0000 (18:46 -0700)]
JIT/EE interface cleanup (#85975)
* JIT/EE interface cleanup
- Delete methods, fields and flags related to verification that is no longer supported
- Delete flags for old x86 models that are no longer needed given SSE2
is our baseline
* Assert hardware minbar
Jan Kotas [Wed, 10 May 2023 01:46:04 +0000 (18:46 -0700)]
Make exception count performance counter thread-safe (#86018)
Fixes #85997
Mike McLaughlin [Wed, 10 May 2023 00:32:34 +0000 (17:32 -0700)]
Create a createdump static library for single-file dump generation (#84864)
* Create a createdump static library for single-file and native AOT dump generation
A "createdump_static" lib is now built that is linked into the single-file host and
in the future can be linked into a Native AOT host/app going forward. For single-file
apps most of the same unhandled exception or crash dump generation code is the same
(same env vars, most of all the PAL code is the same) except where createdump executable
was execve, a callback invokes (set by the host) the static createdump lib entry point.
File full dumps are generated (which currently are very large under MacOS) but the user
can put the DAC side-by-side with their app and the smaller heap or mini dumps can be
generated. The SDK could give an option to publish the DAC SXS for a single-file app.
Andy Ayers [Tue, 9 May 2023 23:02:55 +0000 (16:02 -0700)]
JIT: enable profile repairs of OSR entry block weight is zero (#86011)
If the PGO solver finds the OSR entry block weight is zero, schedule the
method for profile repairs (similar to what we do for normal methods when
the method entry block weight is zero, see #84312).
Fixes #85838.
Stephen Toub [Tue, 9 May 2023 22:15:38 +0000 (18:15 -0400)]
Use string.IsNullOrEmpty and ArgumentException.ThrowIfNullOrEmpty in many more places (#85858)
Egor Bogatov [Tue, 9 May 2023 21:42:29 +0000 (23:42 +0200)]
JIT: Update class for Unsafe.As<>() (#85954)
Zoltan Varga [Tue, 9 May 2023 21:30:30 +0000 (14:30 -0700)]
[mono][aot] Generate 'native-indirect' wrappers in full-aot mode. (#85923)
Fixes https://github.com/dotnet/runtime/issues/80853.
Kunal Pathak [Tue, 9 May 2023 21:23:29 +0000 (14:23 -0700)]
Update life of data node for simd12 (#85956)
* Update life of Data() node
* Review feedback
Jakob Botsch Nielsen [Tue, 9 May 2023 21:07:23 +0000 (23:07 +0200)]
SPMI: Use .tar.gz for pintools on Linux (#85999)
We need to preserve executable permissions on these files so use .tar.gz
instead of .zip.
Ankit Jain [Tue, 9 May 2023 20:53:07 +0000 (16:53 -0400)]
[wasm] Use a fixed chrome version for testing (#86012)
`113.0.5672.63`
Andrew Au [Tue, 9 May 2023 19:33:59 +0000 (12:33 -0700)]
Upgrade System.Reflection.Metadata version (#85738)
* Upgrade System.Reflection.Metadata version
* Upgrade System.Collections.Immutable version
Michal Strehovský [Tue, 9 May 2023 19:25:08 +0000 (04:25 +0900)]
Speed up typeof (#85962)
Saw it in BasicMinimalApi profiles. The ultimate fix is to make `RuntimeType` a frozen object, but this will do for now.
Also made a bit of progress in eradicating `EETypePtr` while I'm touching this.
Parker Bibus [Tue, 9 May 2023 19:00:05 +0000 (12:00 -0700)]
Revert "performance-setup.sh requires urllib3 version <2 (#85915)" (#86009)
This reverts commit
b1329633572d124fe43f7d58bb113f59f886e80b.
Jakob Botsch Nielsen [Tue, 9 May 2023 18:35:22 +0000 (20:35 +0200)]
SPMI: Export dynamic symbols in superpmi for unix builds (#85967)
This is necessary for Instrumentor_GetInsCount to get a public symbol
that pin can find.