Thibault Saunier [Fri, 30 Oct 2015 09:52:12 +0000 (10:52 +0100)]
uri-clip: Make sure to instantiate an asset to back GESUriClip-s
Tim-Philipp Müller [Wed, 21 Oct 2015 13:37:26 +0000 (14:37 +0100)]
Automatic update of common submodule
From b99800a to b319909
Sebastian Dröge [Tue, 20 Oct 2015 14:29:42 +0000 (17:29 +0300)]
Use new GST_ENABLE_EXTRA_CHECKS #define
https://bugzilla.gnome.org/show_bug.cgi?id=756870
Sebastian Dröge [Wed, 21 Oct 2015 11:28:54 +0000 (14:28 +0300)]
Automatic update of common submodule
From 9aed1d7 to b99800a
Sebastian Dröge [Fri, 2 Oct 2015 19:27:37 +0000 (22:27 +0300)]
Update GLib dependency to 2.40.0
Justin Kim [Fri, 2 Oct 2015 14:51:56 +0000 (16:51 +0200)]
nlecomposition: free closure actions when disposing
Summary:
After invoking GClosure, the item of action list becomes
orphan so it lost a chance to be freed. In addition, even
when disposing, the list of actions has few items so we
have to check the list.
Reviewers: thiblahute
Projects: #gstreamer_editing_services
Reviewed By: thiblahute
Differential Revision: https://phabricator.freedesktop.org/D324
Justin Kim [Fri, 2 Oct 2015 14:49:31 +0000 (16:49 +0200)]
nlecomposition: fix wrong argument order of GClosureNotify
Summary:
_free_action should follow GClosureNotify type.
```
void
(*GClosureNotify) (gpointer data,
GClosure *closure);
```
Reviewers: thiblahute
Projects: #gstreamer_editing_services
Reviewed By: thiblahute
Differential Revision: https://phabricator.freedesktop.org/D323
Justin Kim [Fri, 2 Oct 2015 14:39:31 +0000 (16:39 +0200)]
track: mixing_operation is handled by its parent
Summary:
Normally, mixing_operation is created and added to nlecomposition
as a child element so it will be freed when nlecomposition is removed
from a track.
Reviewers: thiblahute
Projects: #gstreamer_editing_services
Differential Revision: https://phabricator.freedesktop.org/D319
Justin Kim [Fri, 2 Oct 2015 14:11:33 +0000 (16:11 +0200)]
nleoperation: don't leak iterator
Summary: Once an iterator is created, it should be freed after usage.
Reviewers: thiblahute
Projects: #gstreamer_editing_services
Reviewed By: thiblahute
Differential Revision: https://phabricator.freedesktop.org/D318
Justin Kim [Fri, 2 Oct 2015 14:10:59 +0000 (16:10 +0200)]
asset: simplify if-statement in cache_set_loaded
Summary:
Manual iteration can be replaced with foreach function.
In addition, this patch fixes mismatched GFunc type for
g_list_foreach and adds debug cateory for gst-asset for
convenient debugging.
Reviewers: thiblahute
Reviewed By: thiblahute
Differential Revision: https://phabricator.freedesktop.org/D312
Justin Kim [Fri, 2 Oct 2015 14:08:03 +0000 (16:08 +0200)]
uri-asset: do not reuse a passed GError pointer
Summary: A passed GError is re-allocated when discoverer has no information.
Reviewers: thiblahute
Projects: #gstreamer_editing_services
Reviewed By: thiblahute
Differential Revision: https://phabricator.freedesktop.org/D302
Justin Kim [Thu, 1 Oct 2015 14:26:05 +0000 (16:26 +0200)]
xml-formatter: handle dispose properly
Summary:
To dispose properly, a child object should call same function
of parent class.
Reviewers: thiblahute
Differential Revision: https://phabricator.freedesktop.org/D311
Justin Kim [Thu, 1 Oct 2015 14:06:33 +0000 (16:06 +0200)]
base-xml-formatter: properly handle GFile from wrong uri
Summary:
g_file_new_for_uri never fails so GFile always has valid pointer.
And fix a bug of double unref from D303.
Reviewers: thiblahute
Differential Revision: https://phabricator.freedesktop.org/D310
Justin Kim [Thu, 1 Oct 2015 09:28:38 +0000 (11:28 +0200)]
don't leaks caps and converted strings
Summary:
Valgrind reports trivial leakages related to handling
objects and their converted strings.
Reviewers: thiblahute
Differential Revision: https://phabricator.freedesktop.org/D303
Mathieu Duponchelle [Wed, 30 Sep 2015 12:50:46 +0000 (14:50 +0200)]
track: add gaps when going from READY to PAUSED.
Summary:
The backend commits itself automatically in these cases, so track
needs to do so too.
Reviewers: thiblahute
Reviewed By: thiblahute
Differential Revision: https://phabricator.freedesktop.org/D94
Vineeth TM [Thu, 20 Aug 2015 08:16:50 +0000 (17:16 +0900)]
editing-services: Fix memory leaks when context parse fails
When g_option_context_parse fails, context and error variables are not getting free'd
which results in memory leaks. Free'ing the same.
And replacing g_error_free with g_clear_error, which checks if the error being passed
is not NULL and sets the variable to NULL on free'ing.
https://bugzilla.gnome.org/show_bug.cgi?id=753864
Justin Kim [Wed, 30 Sep 2015 08:11:20 +0000 (17:11 +0900)]
nleoperation: don't leak srcpad
https://bugzilla.gnome.org/show_bug.cgi?id=755860
Justin Kim [Wed, 30 Sep 2015 08:27:26 +0000 (17:27 +0900)]
project: fix a pointer for error message
https://bugzilla.gnome.org/show_bug.cgi?id=755862
Justin Kim [Wed, 30 Sep 2015 08:26:31 +0000 (17:26 +0900)]
project: don't leak GFileInfo
https://bugzilla.gnome.org/show_bug.cgi?id=755862
Justin Kim [Mon, 21 Sep 2015 16:06:00 +0000 (01:06 +0900)]
timeline-element,track,framepositionner: don't leak internal object
https://bugzilla.gnome.org/show_bug.cgi?id=755247
Justin Kim [Wed, 23 Sep 2015 16:30:09 +0000 (01:30 +0900)]
structured-interface: introduce TRY_GET_STRING
TRY_GET uses gst_structure_get. However, if boxed or
string pointer is retrieved by gst_structure_get,
it should be freed properly.
https://bugzilla.gnome.org/show_bug.cgi?id=755480
Justin Kim [Thu, 24 Sep 2015 04:41:30 +0000 (13:41 +0900)]
uri-asset: don't leak uri string
https://bugzilla.gnome.org/show_bug.cgi?id=755505
Thibault Saunier [Mon, 28 Sep 2015 13:59:58 +0000 (15:59 +0200)]
Revert "title-source: Force format with alpha channels out of videotestsrc"
This reverts commit
7d1e1010728a5348674bb9053de6b095cb824984.
This commit was never meant to be committed (at least *not* on master).
Justin Kim [Mon, 28 Sep 2015 04:21:11 +0000 (13:21 +0900)]
structure-parser: define GES_STRUCTURE_PARSER macro
And fix trivial leakages of internal list structure.
https://bugzilla.gnome.org/show_bug.cgi?id=755716
Thibault Saunier [Sun, 27 Sep 2015 13:15:10 +0000 (15:15 +0200)]
title-source: Force format with alpha channels out of videotestsrc
Making sure the user can set a background of the title with an alpha
channel.
Working around https://bugzilla.gnome.org/show_bug.cgi?id=755482 for
the 1.6 branch.
Thibault Saunier [Fri, 25 Sep 2015 10:30:29 +0000 (12:30 +0200)]
Back to development
Thibault Saunier [Fri, 25 Sep 2015 10:29:40 +0000 (12:29 +0200)]
Release 1.6.0
Thibault Saunier [Thu, 24 Sep 2015 11:21:15 +0000 (13:21 +0200)]
ges: Avoid emitting 'child-added/removed' when signal emission stops addition
In the GESTimeline, TrackElement addition to a clip might get cancelled
(and thus the element gets removed), we need to make sure users do not
get wrong signals.
Also document the fact that user should connect to container::child-added
with g_signal_connect_after.
Justin Kim [Tue, 22 Sep 2015 14:10:35 +0000 (23:10 +0900)]
nle{composition,object}: remove unused allocation & trivial leakages
nlecomposition allocates unused 'UpdateCompositionData' and it
causes leakages.
https://bugzilla.gnome.org/show_bug.cgi?id=755417
Justin Kim [Thu, 24 Sep 2015 04:40:27 +0000 (13:40 +0900)]
pipeline: don't leak GstPad
https://bugzilla.gnome.org/show_bug.cgi?id=755505
Justin Kim [Thu, 24 Sep 2015 04:42:16 +0000 (13:42 +0900)]
pitivi-formatter: don't leak internal hash table
https://bugzilla.gnome.org/show_bug.cgi?id=755505
Thibault Saunier [Wed, 23 Sep 2015 19:23:13 +0000 (21:23 +0200)]
video-transition: Make compositor background transparent
Allowing further mixing downstream
Thibault Saunier [Wed, 23 Sep 2015 19:12:33 +0000 (21:12 +0200)]
video-transition: Add a framepositioner at the end of the transitio
So downstream compositor knows the zorder of the various streams
Thibault Saunier [Fri, 18 Sep 2015 16:40:18 +0000 (18:40 +0200)]
Release 1.5.91
Thibault Saunier [Fri, 18 Sep 2015 08:01:44 +0000 (10:01 +0200)]
ges: Namespace NLE utils function into GES
Avoiding name clashes when built statically
Thibault Saunier [Tue, 15 Sep 2015 10:17:19 +0000 (12:17 +0200)]
nle: Avoid unsetting srcpad target after the srcpad is already freed
That leaded to segfaults
Thibault Saunier [Tue, 15 Sep 2015 09:08:29 +0000 (11:08 +0200)]
nle: Stop wrongly set operation segment base time
Inside the composition we actually do not need to have any notion
of what the timing outside the compositon as we already tweak the segment
base time outside the composition. This code was only there to work
around https://bugzilla.gnome.org/show_bug.cgi?id=753196
https://bugzilla.gnome.org/show_bug.cgi?id=754893
Justin Kim [Fri, 11 Sep 2015 07:18:46 +0000 (16:18 +0900)]
nlecomposition: don't leak internal hashtable
https://bugzilla.gnome.org/show_bug.cgi?id=754867
Justin Kim [Fri, 11 Sep 2015 07:13:19 +0000 (16:13 +0900)]
nleobject: don't leak srcpad when disposing
https://bugzilla.gnome.org/show_bug.cgi?id=754867
Justin Kim [Fri, 11 Sep 2015 07:11:40 +0000 (16:11 +0900)]
timeline: don't leak pad in private structure
https://bugzilla.gnome.org/show_bug.cgi?id=754867
Justin Kim [Fri, 11 Sep 2015 00:58:56 +0000 (09:58 +0900)]
ges-launcher: don't leak GError
https://bugzilla.gnome.org/show_bug.cgi?id=754858
Justin Kim [Wed, 9 Sep 2015 14:32:19 +0000 (23:32 +0900)]
ges-launcher: fix double free when argument is invalid
https://bugzilla.gnome.org/show_bug.cgi?id=754783
Thibault Saunier [Fri, 4 Sep 2015 10:01:16 +0000 (12:01 +0200)]
video-source: Use the priority being set to compute zorder
Thibault Saunier [Wed, 2 Sep 2015 21:27:16 +0000 (23:27 +0200)]
video:transition: Set mixer pad zorder
Thibault Saunier [Wed, 2 Sep 2015 15:58:33 +0000 (17:58 +0200)]
video-source: Make sure to set framepositionner zorder when creating it
And fix a computation bug where we would be having mixing order
reversed between layers.
And make sure that the positionner does not mix up Transition handling
of the zorder
Thibault Saunier [Thu, 27 Aug 2015 14:28:42 +0000 (16:28 +0200)]
video-source: Simply set framepositionner->zorder = self->priority
Summary:
Making the code simpler and handling the transition case
where elements are in the same layer (which was failing
/setting same zorders until now).
Reviewers: Mathieu_Du
Differential Revision: https://phabricator.freedesktop.org/D237
Jan Schmidt [Sat, 22 Aug 2015 15:35:18 +0000 (01:35 +1000)]
Use standard GST_PLUGIN_LDFLAGS for the nle plugin
Add the standard GST_PLUGIN_LDFLAGS to the configure.ac file.
Thibault Saunier [Fri, 21 Aug 2015 19:25:27 +0000 (21:25 +0200)]
Add support for static plugins builds
Thibault Saunier [Thu, 20 Aug 2015 15:55:48 +0000 (17:55 +0200)]
Release 1.5.90
Thibault Saunier [Wed, 19 Aug 2015 09:24:11 +0000 (11:24 +0200)]
Move NLE to a dedicated GstPlugin
Summary: Allowing external user to directly use it
Reviewers: Mathieu_Du
Differential Revision: https://phabricator.freedesktop.org/D231
Thibault Saunier [Thu, 23 Jul 2015 09:53:52 +0000 (11:53 +0200)]
nle: Enhance debug logging
Thibault Saunier [Thu, 23 Jul 2015 09:42:48 +0000 (11:42 +0200)]
ges: Do not leak and uselessly create errors
And avoid parenthesis in GstObject names
Thibault Saunier [Thu, 23 Jul 2015 09:40:57 +0000 (11:40 +0200)]
ges: Fix how we handle layer vs layer-priority in the structured interface
Thibault Saunier [Thu, 23 Jul 2015 09:39:04 +0000 (11:39 +0200)]
tests: Do not use gst-structured-interface in the tests
It breaks $ make distcheck
Tim-Philipp Müller [Thu, 16 Jul 2015 16:26:04 +0000 (17:26 +0100)]
Update mailing list in doap file
Thibault Saunier [Thu, 16 Jul 2015 08:54:54 +0000 (10:54 +0200)]
timeline: Remove transitions that can no fit into an auto transition
When activating auto transition mode
Thibault Saunier [Thu, 16 Jul 2015 08:53:17 +0000 (10:53 +0200)]
ges; Minor debug enhancement
Thibault Saunier [Mon, 13 Jul 2015 11:48:40 +0000 (13:48 +0200)]
assets: Avoid deadlock when done initialising asset
Avoid to hold the CACHE lock when setting the GTasks return values.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=752300
Thibault Saunier [Wed, 8 Jul 2015 16:59:33 +0000 (18:59 +0200)]
nleobject: Concider objects as 'inactive' when they have a duration == 0
Thibault Saunier [Wed, 8 Jul 2015 16:59:00 +0000 (18:59 +0200)]
track-element: Handle the case where we have only one keyframe set when interpollating keyframes
Thibault Saunier [Mon, 6 Jul 2015 08:24:33 +0000 (10:24 +0200)]
asset: Port use of deprecated GSimpleAsyncResult to GTask
Stefan Sauer [Fri, 3 Jul 2015 20:00:08 +0000 (22:00 +0200)]
Automatic update of common submodule
From f74b2df to 9aed1d7
Thibault Saunier [Fri, 3 Jul 2015 11:49:57 +0000 (13:49 +0200)]
track-element: Fix splitting bindings and add unit tests
Thibault Saunier [Wed, 1 Jul 2015 16:33:39 +0000 (18:33 +0200)]
structured-interface: Better handle CLOCK_TIME type from GstStructures
Thibault Saunier [Mon, 29 Jun 2015 16:04:32 +0000 (18:04 +0200)]
element: Implement a paste method
Allowing user to copy paste clips very easily
Thibault Saunier [Tue, 23 Jun 2015 14:11:26 +0000 (16:11 +0200)]
timeline: Disable movement that lead to 2 transition at a position
We should never let 3 objects to overlap at a same position, for that
we introduce a "rollback" feature and whenever such an editing happens,
we rollback object position to whatever it was before the move.
Thibault Saunier [Tue, 23 Jun 2015 17:19:29 +0000 (19:19 +0200)]
smart-video-mixer: Always keep a ref on the mixer pad
Thibault Saunier [Tue, 23 Jun 2015 11:27:00 +0000 (13:27 +0200)]
timeline-element: Add a method to get the TrackType it interacts with
API:
+ ges_timeline_element_get_track_types
Thibault Saunier [Fri, 19 Jun 2015 09:08:25 +0000 (11:08 +0200)]
timeline: Never create transitions between rippled objects
In case of groups, we can have track elements that do not belong
directly to the moved_trackelements but will be moved as others. Never
create transition to all object that have a start > moving group start.
Thibault Saunier [Tue, 16 Jun 2015 15:07:40 +0000 (17:07 +0200)]
video-transition: Use a SmartMixer as mixer
So that the frame position metas are parsed and taken into account
Thibault Saunier [Tue, 16 Jun 2015 13:02:18 +0000 (15:02 +0200)]
track-element: Add method to remove control binding
API:
ges_track_element_remove_control_binding
Thibault Saunier [Tue, 16 Jun 2015 11:25:32 +0000 (13:25 +0200)]
ges: Handle absolute GstDirectControlBindings
Thibault Saunier [Sat, 13 Jun 2015 16:48:20 +0000 (18:48 +0200)]
framepositionner: Make use of the new CompositorPad.width/height
So that the scaling is done in the compositor and this way we can cleanly interpolate its value
Thibault Saunier [Fri, 3 Jul 2015 07:19:30 +0000 (09:19 +0200)]
timeline: Never change output media time when trimming start
+ Fix testsuite
https://bugzilla.gnome.org/show_bug.cgi?id=638802
Thibault Saunier [Fri, 3 Jul 2015 07:16:50 +0000 (09:16 +0200)]
track-element: Return right value when editing
We used to always return TRUE which was wrong
+ Fix testsuite and remove randomness from the tests
Thibault Saunier [Wed, 1 Jul 2015 15:28:52 +0000 (17:28 +0200)]
ges: Do not add a final gap at the end of track while rendering
It is not correct to force a black frame at the end of the rendered
video and it also leads to rendering issue with vpX encoders.
https://bugzilla.gnome.org/show_bug.cgi?id=751510
Thibault Saunier [Wed, 1 Jul 2015 09:35:42 +0000 (11:35 +0200)]
clip: Use container priority offset when setting children prios
Instead of trying to compute it ourself which might lead to wrong
behaviour when moving between layer.
+ Make sure that when we reset clip children priority (to make space
for effects,) we update the container knowledge of priority offsets
Thibault Saunier [Tue, 30 Jun 2015 21:13:28 +0000 (23:13 +0200)]
clip: Fix track element priority computation
We were computing the priority offset taking the global MIN_NLE_PRIO
(which is a constant == 2 to make space for the mixing elements) instead
of the layer 'track element' relative priority, leading to very big
offsets on layer with a prio > 0. In the end it leaded to effects having
the same priority as the sources which leads to an undefined behaviour
in NLE.
Thibault Saunier [Wed, 24 Jun 2015 07:06:30 +0000 (09:06 +0200)]
uri-asset: Bump the discoverer timeout to 1 minute
We should by default avoid false timeouts
Thibault Saunier [Sun, 21 Jun 2015 23:52:39 +0000 (01:52 +0200)]
track: Give usefull name to compositions
Thibault Saunier [Thu, 25 Jun 2015 09:03:12 +0000 (11:03 +0200)]
nle: Port tests to the "commit" action signals
Now that nle_object_commit symbol is hidden, we can't use it
in the tests.
Thibault Saunier [Thu, 25 Jun 2015 08:32:46 +0000 (10:32 +0200)]
ges: Unbreeak API after renaming of GNL to NLE
Sebastian Dröge [Thu, 25 Jun 2015 08:28:41 +0000 (10:28 +0200)]
ges: Hide more symbols of headers that are not installed
Sebastian Dröge [Thu, 25 Jun 2015 08:25:48 +0000 (10:25 +0200)]
nle: Remove unused function
nle/nlecomposition.c:2471:1: error: unused function '_parent_or_priority_changed' [-Werror,-Wunused-function]
_parent_or_priority_changed (NleObject * obj, GNode * oldnode,
^
Sebastian Dröge [Thu, 25 Jun 2015 08:24:13 +0000 (10:24 +0200)]
nle: Hide away symbols, they're supposed to be internal
Thibault Saunier [Wed, 24 Jun 2015 15:55:22 +0000 (17:55 +0200)]
Back to development
Thibault Saunier [Wed, 24 Jun 2015 15:44:04 +0000 (17:44 +0200)]
Release 1.5.2
Tim-Philipp Müller [Tue, 23 Jun 2015 08:41:01 +0000 (09:41 +0100)]
nlesource: remove outdated comment
Nicolas Dufresne [Tue, 16 Jun 2015 21:50:38 +0000 (17:50 -0400)]
Automatic update of common submodule
From 6015d26 to f74b2df
Thibault Saunier [Wed, 10 Jun 2015 15:54:20 +0000 (17:54 +0200)]
pipeline: Handle rendering with disabled tracks
Summary:
The user might want to render only some media type of the timeline,
for example he wants to only render the audio part of the timeline.
It was failing as we were not connecting the track but were still trying
to 'render' it.
Depends on D153
Reviewers: Mathieu_Du
Reviewed By: Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D154
Thibault Saunier [Tue, 9 Jun 2015 19:00:44 +0000 (21:00 +0200)]
ges: Raise an error when the discoverer returns != RESULT_OK
And do not try to run the pipeline when that happens
Thibault Saunier [Tue, 9 Jun 2015 18:58:00 +0000 (20:58 +0200)]
uri-asset: Add a way to control discoverer timeout through envvar
Making it possible to run ges-launch test under valgrind for example
Tim-Philipp Müller [Tue, 9 Jun 2015 11:23:59 +0000 (12:23 +0100)]
ges-launch: don't print random position/duration values at startup
Edward Hervey [Tue, 9 Jun 2015 09:30:59 +0000 (11:30 +0200)]
Automatic update of common submodule
From d9a3353 to 6015d26
Stefan Sauer [Mon, 8 Jun 2015 21:08:40 +0000 (23:08 +0200)]
Automatic update of common submodule
From d37af32 to d9a3353
Stefan Sauer [Sun, 7 Jun 2015 21:07:40 +0000 (23:07 +0200)]
Automatic update of common submodule
From 21ba2e5 to d37af32
Stefan Sauer [Sun, 7 Jun 2015 15:32:34 +0000 (17:32 +0200)]
Automatic update of common submodule
From c408583 to 21ba2e5
Stefan Sauer [Sun, 7 Jun 2015 15:16:53 +0000 (17:16 +0200)]
Automatic update of common submodule
From d676993 to c408583
Thibault Saunier [Fri, 5 Jun 2015 17:59:08 +0000 (19:59 +0200)]
timeline: Never snap end when rippling
http://phabricator.freedesktop.org/T74
Thibault Saunier [Fri, 5 Jun 2015 17:58:16 +0000 (19:58 +0200)]
timeline: Never create transition between elements inside the moving context
http://phabricator.freedesktop.org/T74