Eric Erhardt [Thu, 5 Jul 2018 19:26:05 +0000 (14:26 -0500)]
Fix up new projects and usages of dir.props/targets.
Commit migrated from https://github.com/dotnet/corefx/commit/
9b7b8c0b63b7c35a13a91310b141fca8ee2b3d6f
Eric Erhardt [Thu, 5 Jul 2018 19:12:38 +0000 (14:12 -0500)]
Run UpdateVSConfigurations on the current code.
Commit migrated from https://github.com/dotnet/corefx/commit/
1a4b8a2ba40d39abe3c3888caede4e46218e7099
Eric Erhardt [Thu, 5 Jul 2018 19:06:19 +0000 (14:06 -0500)]
Merge master into SdkProj
Commit migrated from https://github.com/dotnet/corefx/commit/
0343b37275d50fa44b8db91bd9ed8364f89600fc
cmpt376edits [Wed, 4 Jul 2018 19:52:39 +0000 (12:52 -0700)]
Improve wording in coding style documentation (dotnet/corefx#30833)
Commit migrated from https://github.com/dotnet/corefx/commit/
20c344cb345c608fe3f5b3ebb4b7da77be52be7c
dotnet-maestro-bot [Wed, 4 Jul 2018 16:12:06 +0000 (09:12 -0700)]
Update CoreFx, CoreSetup to preview1-26704-05, preview1-26704-01, respectively (dotnet/corefx#30835)
Commit migrated from https://github.com/dotnet/corefx/commit/
e7b1711fc3d7e23c8be83716925d22f3fd8d7626
dotnet-maestro-bot [Wed, 4 Jul 2018 11:32:02 +0000 (04:32 -0700)]
Update BuildTools, CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview1-03004-01, preview1-26704-01, preview1-26704-01, beta-26704-00, beta-26704-00, respectively (dotnet/corefx#30824)
Commit migrated from https://github.com/dotnet/corefx/commit/
77e610a1f373157f6015620fdff145461f0e59a0
Anirudh Agnihotry [Wed, 4 Jul 2018 09:18:31 +0000 (02:18 -0700)]
Lazy Initialization of Thread.CurrentPrincipal and implementing GetThreadPrincipal (dotnet/corefx#30765)
Commit migrated from https://github.com/dotnet/corefx/commit/
6fb57a4bfe4504b60b3af769798b96ba15e6c842
Jeremy Kuhne [Wed, 4 Jul 2018 03:36:54 +0000 (20:36 -0700)]
Replace custom synchronized text writer (dotnet/corefx#30796)
TextWriter.Synchronized does this and isn't missing APIs, which can cause derived methods to not be called. Test added.
Commit migrated from https://github.com/dotnet/corefx/commit/
0b868a47b4889fef013539787cf3475d817d893f
Stephen Toub [Wed, 4 Jul 2018 00:25:16 +0000 (20:25 -0400)]
Add more DateTime ParseExact tests for "r" (dotnet/corefx#30818)
Commit migrated from https://github.com/dotnet/corefx/commit/
a02e71d274d0f44613d7b3f2f8590f5b17cfaca3
Maryam Ariyan [Tue, 3 Jul 2018 22:54:48 +0000 (15:54 -0700)]
Updating test to assert milisecond granularity for (dotnet/corefx#30763)
- non any linux or
- OSX non-HFS driver formats
Fixes dotnet/corefx#30472
Commit migrated from https://github.com/dotnet/corefx/commit/
a399e51941f6435063052df8b47182ddca0b4496
Luqun Lou [Tue, 3 Jul 2018 22:41:37 +0000 (15:41 -0700)]
Use public implementation CultureDataSupport (dotnet/corefx#30739)
Commit migrated from https://github.com/dotnet/corefx/commit/
38b71a3a1da3b460bf68c3d0b7d653e04780e054
Jose Perez Rodriguez [Tue, 3 Jul 2018 21:32:50 +0000 (14:32 -0700)]
Configuration changes so that System.Reflection.Emit may compile against netstandard2.0 (dotnet/corefx#30741)
* Configuration changes so that System.Reflection.Emit may compile against
netstandard2.0
* Adding NS2.0 config for System.Reflection.Emit.Lightweight
* Fixing netfx vertical
* Addressing PR Feedback
* Fixing mscorlib facade generation now that there are a few type
conflicts
* Add back Ref.Emit packages
These packages all needed the following workarounds:
1. Matching not-supported implementation assemblies for netstandard1.x
2. Not support implementation for AOT frameworks
3. Ensure we don't add API to old frameworks (eg: UAP10.0.16299, desktop) or frameworks compatible with those (netstandard2).
Commit migrated from https://github.com/dotnet/corefx/commit/
1e72f59677547df9b82fa642fd4f443c6768d743
Tomas Weinfurt [Tue, 3 Jul 2018 21:25:23 +0000 (14:25 -0700)]
use separate kevent() calls on FreeBSD for read and write event notifications. (dotnet/corefx#30688)
* use separate kevent() calls on FreeBSD for read and write events
* add reference to Issue: dotnet/corefx#30698
Commit migrated from https://github.com/dotnet/corefx/commit/
a04ad96f9cabc6fd074098924d32082018888993
Viktor Hofer [Tue, 3 Jul 2018 16:09:00 +0000 (18:09 +0200)]
Fix flacky RegistrationBuilder test
Commit migrated from https://github.com/dotnet/corefx/commit/
465e7c15bd6c2ac13adf44cd9cca799df603282d
Eric Erhardt [Tue, 3 Jul 2018 20:50:46 +0000 (15:50 -0500)]
Moving sign.builds to run on full .NET Framework. (dotnet/corefx#30797)
* Moving sign.builds to run on full .NET Framework.
MicroBuild signing doesn't work when MSBuild is running on .NET Core. So move the signing piece to use MSBuild on full framework.
* Flow SignType property through to sign.builds.
Commit migrated from https://github.com/dotnet/corefx/commit/
b9e62080ed8c297dc1c9c8739b4c780285dbda3b
Stephen Toub [Tue, 3 Jul 2018 17:21:18 +0000 (13:21 -0400)]
Fix SocketAsyncEventArgs' handling of ExecutionContext (dotnet/corefx#30712)
SocketAsyncEventArgs has a few issues with ExecutionContext, presumably stemming from the fact that capturing ExecutionContext in .NET Framework is not a cheap operation. As a result, when this code was written, it was optimized for avoiding calls to ExecutionContext.Capture. The SAEA tries to hold onto a captured ExecutionContext for as long as possible, only re-capturing when either the SAEA is used with a different socket instance or when an event handler is changed. That has several problems, though. First, it largely violates the purpose of ExecutionContext, which is to flow information from the point where the async operation begins to the continuation/callback, but if the context is only being captured when the Socket or handler is changed, then the context isn't actually tied to the location where the async operation begins, and that means that data like that in an AsyncLocal doesn't properly flow across the async point. Second, it means that the SocketAsyncEventArgs (the whole purpose of which is to cache it) can end up keeping state in an ExecutionContext alive well beyond when it should be kept alive, because the SocketAsyncEventArgs is holding onto the ExecutionContext instance until either the Socket or handler is changed.
This commit fixes this behavior. Since ExecutionContext.Capture in .NET Core is relatively cheap (no allocation, primarily just a ThreadStatic access), we now just always capture the context when starting an operation, and then clear it out when completing the operation.
Commit migrated from https://github.com/dotnet/corefx/commit/
851a53bee21639cd65e109b72fd5f9ef90cc0f39
Atsushi Kanamori [Tue, 3 Jul 2018 17:20:24 +0000 (10:20 -0700)]
Add test to ensure FromBase64 bug doesn't regress. (dotnet/corefx#30814)
Convert.FromBase64() had a subtle bug where an illicit
second padding character at the end of the string caused
the decode to "succeed" by dropping the fifth to
last character.
We inadvertently fixed this bug while optimizing that
api in .NetCore 2.1. Adding test to document bug and
ensure we don't regress.
Details in https://github.com/dotnet/corefx/issues/30793
Commit migrated from https://github.com/dotnet/corefx/commit/
f1065c7cf056275b0d206ee077281b8ecfe25d03
dotnet-maestro-bot [Tue, 3 Jul 2018 15:08:48 +0000 (08:08 -0700)]
Update CoreClr, CoreSetup to preview1-26703-04, preview1-26703-01, respectively (dotnet/corefx#30808)
Commit migrated from https://github.com/dotnet/corefx/commit/
d8ae2adab78bc5b4088a18d8cf826867d39774b3
Dan Moseley [Tue, 3 Jul 2018 13:42:54 +0000 (06:42 -0700)]
Minor test fixes for UAP runs (dotnet/corefx#30803)
* Fix BindHandle_DisposedSyncHandleAsHandle_ThrowsArgumentException on UAP
* Fix most of RangeAttributeTests
Commit migrated from https://github.com/dotnet/corefx/commit/
6ee8b75a000eec5b26f256b04902dc19a1db9d35
dotnet-maestro-bot [Tue, 3 Jul 2018 02:38:26 +0000 (19:38 -0700)]
Update CoreClr to preview1-26703-01 (dotnet/corefx#30800)
Commit migrated from https://github.com/dotnet/corefx/commit/
6e443922f36e6a4604d162583150678de97fe6b0
Viktor Hofer [Wed, 27 Jun 2018 21:21:29 +0000 (23:21 +0200)]
Add System.ComponentModel.Composition.Registration
Update packageIndex
Commit migrated from https://github.com/dotnet/corefx/commit/
2e6994336ba7eddb326646d43f1456e753caf47d
Viktor Hofer [Thu, 26 Apr 2018 16:33:27 +0000 (18:33 +0200)]
Cleanup System.ComponentModel.Composition
Fix failing tests & remove noisy output loggings
Use common threadculture and remove unused files
Cleanup test codebase & delete unused files
Remove resource from turd assembly
Auto format documents
Commit migrated from https://github.com/dotnet/corefx/commit/
78bf9d7974d9413eed39ebc4d7b220ce3ed70d92
Eric Erhardt [Mon, 2 Jul 2018 19:30:45 +0000 (14:30 -0500)]
Update the OptionalTooling to work on .NET Core MSBuild. (dotnet/corefx#30762)
* Update the OptionalTooling to work on .NET Core MSBuild.
The official build broke because I moved the Windows build on to .NET Core MSBuild. We have some OptionalTooling that only gets restored during the official build, and the current approach (using project.json) doesn't work on .NET Core MSBuild. So migrating the tooling to use normal MSBuild PackageReferences.
Fix dotnet/corefx#30758
* Respond to PR feedback.
Upper case each section of the package name in the MSBuild version property.
Commit migrated from https://github.com/dotnet/corefx/commit/
6cec67359b15966f5a4f9501ac5e52e0fc3fb1d5
dotnet-maestro-bot [Mon, 2 Jul 2018 19:27:09 +0000 (12:27 -0700)]
Update BuildTools, CoreSetup to preview1-03002-01, preview1-26702-03, respectively (dotnet/corefx#30786)
Commit migrated from https://github.com/dotnet/corefx/commit/
be96620915e0b92a63f48bf41aac4a105e9c689b
Hugh Bellamy [Wed, 13 Jun 2018 16:04:26 +0000 (17:04 +0100)]
Add parameter name where missing
Fixes `SyndicationContentTests.WriteTo_EmptyOrNullName_ThrowsArgumentException`
Fixes `ServiceElementExtensionTests.Ctor_EmptyOuterName_ThrowsArgumentException`
Commit migrated from https://github.com/dotnet/corefx/commit/
434da5cff99deda2131aef1476cad8a61b679455
Hugh Bellamy [Wed, 13 Jun 2018 15:50:15 +0000 (16:50 +0100)]
Add Syndication tests
Commit migrated from https://github.com/dotnet/corefx/commit/
b0edc960e855e159fb9d329df08d47904963d75e
Hugh Bellamy [Wed, 13 Jun 2018 15:49:59 +0000 (16:49 +0100)]
Cleanup Syndication tests
Commit migrated from https://github.com/dotnet/corefx/commit/
e20e5173ac1af975eb52933f06ceec389bdc037e
dotnet-maestro-bot [Mon, 2 Jul 2018 14:23:03 +0000 (07:23 -0700)]
Update CoreClr, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26702-04, preview1-26702-01, beta-26702-00, beta-26702-00, respectively (dotnet/corefx#30778)
Commit migrated from https://github.com/dotnet/corefx/commit/
e06a4fafe03b650960e13be2061eab664ef97995
dotnet-maestro-bot [Sun, 1 Jul 2018 19:10:15 +0000 (12:10 -0700)]
Update CoreClr, CoreSetup to preview1-26701-03, preview1-26701-01, respectively (dotnet/corefx#30773)
Commit migrated from https://github.com/dotnet/corefx/commit/
0256ac2cba4f7f9742d7970978e8c71f279bdef1
Tanner Gooding [Sat, 30 Jun 2018 01:12:52 +0000 (18:12 -0700)]
Fixing the names/parameter types for several Bmi1 HWIntrinsic methods
Commit migrated from https://github.com/dotnet/corefx/commit/
95b21631b4f72e5ecbb6338a3fc7ae9345b5144e
dotnet-maestro-bot [Sat, 30 Jun 2018 12:52:22 +0000 (05:52 -0700)]
Update CoreClr, CoreSetup to preview1-26630-03, preview1-26630-01, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
2f4141169cbb627777781af59187011f6994f920
dotnet-maestro-bot [Sat, 30 Jun 2018 06:00:13 +0000 (23:00 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02929-01, preview1-26630-01, preview1-26628-03, preview1-26629-04, beta-26629-00, beta-26629-00, respectively (master) (dotnet/corefx#30766)
* Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02929-01, preview1-26630-01, preview1-26628-03, preview1-26629-04, beta-26629-00, beta-26629-00, respectively
* Use public implementation API RemoveEventHandler
Commit migrated from https://github.com/dotnet/corefx/commit/
bcbf63568b81239ceb1048b5ad75e6c9f7eb58dc
kasper3 [Fri, 29 Jun 2018 23:48:01 +0000 (02:48 +0300)]
Update brotli to v1.0.5 (dotnet/corefx#30751)
* Update brotli to v1.0.5
* Define BROTLI_SHARED_COMPILATION
* Set headers language to C
* Add brotli-version.txt
Commit migrated from https://github.com/dotnet/corefx/commit/
b17387fd1e3c7b38ab06da917d0a0757d6748534
William Godbe [Fri, 29 Jun 2018 20:19:55 +0000 (13:19 -0700)]
Delay console CPR timer once protocol has worked (dotnet/corefx#30674)
Getting the current cursor position involves writing a particular escape sequence to stdout and then reading/parsing the response. In case the terminal doesn't support the sequence, we use `tcsetattr` to tell the terminal set set c_cc[MIN] to 0 and c_cc[VTIME] to 10; this makes it so that if no input is received within one second, we'll give up on reading the response. If we didn't do this and no response came back, or if a faulty response came back such that we would otherwise just sit there waiting for something that would never come, the console could end up hanging until the user typed the expected sequence.
However, this timeout can cause problems when the terminal is separated by a slow network connection from the console logic, in which case the CPR can time out and the response can end up not only being echoed to the screen, but also interpreted as user input.
This change tracks whether we've ever received a successful CPR response. Until we have, it keeps using 0 for c_cc[MIN], i.e. the minimum number of chars we need to read, such that it relies on the timeout firing and we return when either we've read at least one byte or the timer fires. Once we've successfully read a CPR response, for all future requests, we set c_cc[MIN] to 1. With that, we'll still return once at least one byte is received, but the timer won't start until then, which helps avoid this issue with slow network connections.
Commit migrated from https://github.com/dotnet/corefx/commit/
dd8449ded9dda04f50d8394341e2b9a59bee2b0e
Steve Pfister [Fri, 29 Jun 2018 17:48:18 +0000 (13:48 -0400)]
Switched to as cast in Init because some caller do not have the file map at the start of the param list (refsrc System.Web) (dotnet/corefx#30548)
Commit migrated from https://github.com/dotnet/corefx/commit/
331f135dc4d856ddd1d9751967c790f5f11c734f
Viktor Hofer [Fri, 29 Jun 2018 15:47:53 +0000 (17:47 +0200)]
Regex: reduce allocation slightly, add tests, code cleanup, add parser comments (dotnet/corefx#30632)
* RegexParser & optionsstack ref
* Add test coverage for Group.Synchronized
* Adjust options mode test case
* Add inline comment '#' test branch
* Add comments
* Replace manual ToLower calls by Span.ToLower
* Make applicable fields readonly in parser
* Change to Assert to reduce an if check in one branch
* Code formatting
* Avoid string allocation when IgnoreCase set
Prefix patterns which are passed to RegexBoyerMoore are already
lowercased by the parser. Remove the redundant ToLower() call and assert
the patterns lowercase state
* Add surrogate pair positive & negative tests
* Add test cases for rtl anchor
Commit migrated from https://github.com/dotnet/corefx/commit/
2f259de0bc566f4ef72e486133f71210416e440a
Eric Erhardt [Fri, 29 Jun 2018 14:20:28 +0000 (09:20 -0500)]
Revert WebServer change, since it cannot be an SDK style project.
Commit migrated from https://github.com/dotnet/corefx/commit/
6ccae92a54358ed8b9eb8e4f0f645b53ddc95065
Eric Erhardt [Fri, 29 Jun 2018 02:52:50 +0000 (21:52 -0500)]
Fix up Reflection.Context dir.props/targets to Directory.Build.
Commit migrated from https://github.com/dotnet/corefx/commit/
860888cf06a7fb35ae19474fad42de3eae535821
Eric Erhardt [Fri, 29 Jun 2018 02:28:41 +0000 (21:28 -0500)]
Merge master into SdkProj
Commit migrated from https://github.com/dotnet/corefx/commit/
ec546de620c5248f3662d6aaca989ed382b86b6b
Eric Erhardt [Fri, 29 Jun 2018 01:42:36 +0000 (20:42 -0500)]
Turn off ILLinkTrimAssembly during design-time builds.
Design-time builds don't actually produce an output assembly. So ILLinkTrimAssembly will fail if there is no assembly there. It isn't needed for design-time builds, since now output assembly gets produced.
Commit migrated from https://github.com/dotnet/corefx/commit/
9f6519373568494e5a86bf20d4c6feb018f5b271
Stephen Toub [Thu, 28 Jun 2018 23:38:29 +0000 (19:38 -0400)]
Fix handle double-free in recently added WindowsIdentity test (dotnet/corefx#30731)
Commit migrated from https://github.com/dotnet/corefx/commit/
e36eaec682d5fa81bc1754e89787b0353b9c46b8
Maryam Ariyan [Thu, 28 Jun 2018 23:20:53 +0000 (16:20 -0700)]
Fix compilation for deprecated API on macOS Mojave preview (dotnet/corefx#30716)
* Fix compilation for deprecated API on macOS Mojave preview
Fixes: dotnet/corefx#30599
* Fixing tests on macOS Mojave
Commit migrated from https://github.com/dotnet/corefx/commit/
5e46fe15925c29732f5fdbc333e44c49564e082e
Eric Erhardt [Thu, 28 Jun 2018 16:53:20 +0000 (11:53 -0500)]
Change .csproj to new Configurations property
Change .sln to use the managed C# project system GUID.
Commit migrated from https://github.com/dotnet/corefx/commit/
e05508a62d28f4807f85abe9cb7adf8382f792b4
Eric Erhardt [Thu, 28 Jun 2018 22:32:38 +0000 (17:32 -0500)]
Corefx Windows build on .NET Core MSBuild (dotnet/corefx#30675)
* Corefx Windows build on .NET Core MSBuild
Note: Need to move to the 3.0 SDK because the DiaSymReader.Native shipped in .NET Core's shared framework is out of date. See https://github.com/dotnet/core-setup/issues/4291.
* Workaround .NET Core MSBuild bug.
MSBuild on .NET Core doesn't support non-string resources. However, the ResourceManager tests need to test this scenario. Using the .NET Framework's resgen.exe during the build until the MSBuild bug is fixed.
* Update BuildTools to 2.2.0-preview1-02928-01
Commit migrated from https://github.com/dotnet/corefx/commit/
50ba6a21d8ccb2be551805c98a2106c3477064a0
Marco Rossignoli [Thu, 28 Jun 2018 22:18:54 +0000 (00:18 +0200)]
Override TextWriter.Write{Line}{Async} on StringWriter (dotnet/corefx#30667)
* add overloads
* fix overloads
* add tests
* move test to StringWriterTests.netcoreapp.cs
* revert StringWriterTests.cs updates
* address PR feedback
* fix test
* amend comments
Commit migrated from https://github.com/dotnet/corefx/commit/
57bb0fc7d615649e7a75f02de96be4001b1c3e90
Luqun Lou [Thu, 28 Jun 2018 20:07:54 +0000 (13:07 -0700)]
Remove dependency for IBindableVector Type (dotnet/corefx#30710)
Commit migrated from https://github.com/dotnet/corefx/commit/
1ddcfb9eca7e690a048ef20552bee37bab6cfd30
Luqun Lou [Thu, 28 Jun 2018 20:07:13 +0000 (13:07 -0700)]
Remove Is AppDomainUnloadedException check (dotnet/corefx#30736)
Commit migrated from https://github.com/dotnet/corefx/commit/
71bdfca0613bf66e2e3f41587f6a1d3f62dceb36
Martin Baulig [Thu, 28 Jun 2018 16:28:24 +0000 (12:28 -0400)]
Move 'Internal.Cryptography.Pal.CertificateData' into its own file. (dotnet/corefx#30707)
This moves all the managed pieces of Internal/Cryptography/Pal.OSX/CertificatePal.cs
which are not platform-specific into a separate file to allow them to be used in Mono.
Commit migrated from https://github.com/dotnet/corefx/commit/
a69961ae69608f2271d70e92016b6b3a303abdf6
Atsushi Kanamori [Thu, 28 Jun 2018 16:20:29 +0000 (09:20 -0700)]
Bring back System.Reflection.ICustomTypeProvider (dotnet/corefx#30727)
Fix https://github.com/dotnet/corefx/issues/29958
Commit migrated from https://github.com/dotnet/corefx/commit/
66567f218133234558098feb6d109bc9aa9f8273
Santiago Fernandez Madero [Thu, 28 Jun 2018 16:19:41 +0000 (09:19 -0700)]
Fix ImageFormat.ToString by using it's Guid when comparing to static ImageFormats (dotnet/corefx#30672)
* Fix ImageFormat.ToString by using it's Guid when comparing to static ImageFormats
* Add Image.RawFormat.ToString test
* Skip test on NETFX
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
aaaf87bbddf253726bc4e899659bc22c0ede9601
Santiago Fernandez Madero [Thu, 28 Jun 2018 16:17:11 +0000 (09:17 -0700)]
Fix FontFamily.Name performance by using span and calling the interop code with char pointer (dotnet/corefx#30705)
* Fix FontFamily.Name performance by using span and calling the interop
code with char pointer
* PR Feedback
* Remove added System.Memory reference
Commit migrated from https://github.com/dotnet/corefx/commit/
5d9a3ccdbd1692568b3ea00b891dce9f326285b5
Jiayi Yu [Thu, 28 Jun 2018 16:09:55 +0000 (09:09 -0700)]
Add IsSerializerVersionMatch check (dotnet/corefx#30137)
* add IsSerializerVersionMatch check
* add eventsource for logging
Commit migrated from https://github.com/dotnet/corefx/commit/
1b270a4d56bc421bf7984f6104f878e2a689fb6a
Stephen Toub [Thu, 28 Jun 2018 13:35:47 +0000 (09:35 -0400)]
Merge pull request dotnet/corefx#30662 from dotnet-maestro-bot/master-UpdateDependencies
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02928-01, preview1-26628-01, preview1-26628-01, preview1-26627-03, beta-26627-00, beta-26627-00, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
686eb156e221e547a1cd5bf1a6fbf7bd2f1df812
Stephen Toub [Thu, 28 Jun 2018 13:18:53 +0000 (09:18 -0400)]
Disable Tizen leg on PRs (dotnet/corefx#30715)
It's failing with an updated coreclr:
https://github.com/dotnet/corefx/pull/30662#issuecomment-
400695140
Commit migrated from https://github.com/dotnet/corefx/commit/
6315a412b5489951a5fc3895121d99ce48bd52c8
Fei Peng [Thu, 28 Jun 2018 04:42:00 +0000 (21:42 -0700)]
Fix Aes and Ssse3.Shuffle intrinsic APIs
Commit migrated from https://github.com/dotnet/corefx/commit/
89d9acd8f0c63b5bd64e96070f903cf5a3328f35
John Doe [Thu, 28 Jun 2018 11:49:55 +0000 (04:49 -0700)]
Typo (dotnet/corefx#30721)
* Abbrevation -> Abbreviation
* accesible -> accessible
* acordingly -> accordingly
* Acount -> Account
* Acroding -> According
* actaul -> actual
* Activty -> Activity
* actully -> actually
* Actvitiy -> Activity
* acutal -> actual
Commit migrated from https://github.com/dotnet/corefx/commit/
f4ff3c8a7d00214ebcb7e87ff90a58d90434cb26
Gleb Balykov [Thu, 28 Jun 2018 03:12:24 +0000 (06:12 +0300)]
Fix __Arch for armv7l tests (dotnet/corefx#30639)
Commit migrated from https://github.com/dotnet/corefx/commit/
e36e0b3857e4d333e16191321eb1e9ce0213d1dd
Luqun Lou [Thu, 28 Jun 2018 02:41:42 +0000 (19:41 -0700)]
Remove use of FrameworkEventSourceSupport from S.P.Corelib (dotnet/corefx#30297)
Commit migrated from https://github.com/dotnet/corefx/commit/
96eddf39539879915e5bf570825e78af37149154
dotnet-maestro-bot [Thu, 28 Jun 2018 01:56:08 +0000 (18:56 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02928-01, preview1-26628-01, preview1-26628-01, preview1-26627-03, beta-26627-00, beta-26627-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
23bf4952b7632edaf498d437578aed2e65fc3ce5
Afsaneh Rafighi [Wed, 27 Jun 2018 16:58:44 +0000 (09:58 -0700)]
Merge pull request dotnet/corefx#29697 from AfsanehR/PoolBlockingPeriod
Added PoolBlockingPeriod connection property
Commit migrated from https://github.com/dotnet/corefx/commit/
f487a4c84e6ea02d053fd22546720194b63c8106
Jan Kotas [Wed, 27 Jun 2018 13:51:13 +0000 (06:51 -0700)]
Removes duplicate attributes on Span
Port https://github.com/dotnet/coreclr/pull/18668 to portable Span
Commit migrated from https://github.com/dotnet/corefx/commit/
7012adcffdb1b55386c79c37c9e868d73cfc9869
Afsaneh Rafighi [Wed, 27 Jun 2018 15:46:00 +0000 (08:46 -0700)]
added a margin to test
Commit migrated from https://github.com/dotnet/corefx/commit/
880e4f031cdcce58fc8a4bf6b95c34caa0f9cfa4
Tomas Weinfurt [Wed, 27 Jun 2018 13:28:54 +0000 (06:28 -0700)]
build stub assemblies on FreeBSD from *UnknownUnix* (dotnet/corefx#30663)
* build stub assemblies on FreeBSD from *UnknownUnix*
* feedback from review. move RegisterNetworkChange to common file
* use netcoreapp-Unix for FreeBSD until we have real implementation
Commit migrated from https://github.com/dotnet/corefx/commit/
fc1574ecf3d0b9a9035bc04abae465f27c510dab
Gleb Balykov [Wed, 27 Jun 2018 12:07:20 +0000 (15:07 +0300)]
Update Tizen CI RID (dotnet/corefx#30692)
* Update Tizen RID for CI
* Update Tizen url for rootfs generation
Commit migrated from https://github.com/dotnet/corefx/commit/
cdb337284ccce4a524caca2bdec029a0903b78e5
Santiago Fernandez Madero [Wed, 27 Jun 2018 01:51:31 +0000 (18:51 -0700)]
Disable DrawBezier/DrawLine_PointFs tests (dotnet/corefx#30684)
Commit migrated from https://github.com/dotnet/corefx/commit/
a9aabd2b7cf913f9dd35492d2f3497b2fb269978
Afsaneh Rafighi [Tue, 26 Jun 2018 23:02:39 +0000 (16:02 -0700)]
updated test
Commit migrated from https://github.com/dotnet/corefx/commit/
365505a83751dce6ca0a62f796ac759da7365e2c
Afsaneh Rafighi [Tue, 26 Jun 2018 22:58:41 +0000 (15:58 -0700)]
Merge pull request dotnet/corefx#30342 from AfsanehR/AccessTokenAAD
Azure Active Directory Authentication using Access Token
Commit migrated from https://github.com/dotnet/corefx/commit/
a74bf4200926c47c11ba0383e2bddeaa59227266
Afsaneh Rafighi [Tue, 26 Jun 2018 19:54:34 +0000 (12:54 -0700)]
Merge branch 'master' into AccessTokenAAD
Commit migrated from https://github.com/dotnet/corefx/commit/
da34501f05ede07fb4703ad10ab9b563a3a34790
Tomas Weinfurt [Tue, 26 Jun 2018 18:00:00 +0000 (11:00 -0700)]
add option to handle Ping TTL for raw socket and system utility (dotnet/corefx#30324)
* add option to handle TTL for raw socket and system utility
* add missing blank line
* incorporate feedback and merge with upstream
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
3035218ef5499c8786e242963298181ce22c5745
Afsaneh Rafighi [Tue, 26 Jun 2018 17:43:28 +0000 (10:43 -0700)]
modified the test and addressed review comments
Commit migrated from https://github.com/dotnet/corefx/commit/
286eb8f7898935c59d721d5db4dd9fc04b144673
Michal Strehovský [Tue, 26 Jun 2018 13:57:47 +0000 (15:57 +0200)]
Add regression test for dotnet/corertdotnet/corefx#6016 (dotnet/corefx#30664)
Commit migrated from https://github.com/dotnet/corefx/commit/
271c0832d9b01958e147487352a2ef1eeab15d5c
Stephen Toub [Tue, 26 Jun 2018 05:42:04 +0000 (01:42 -0400)]
Simplify built-in types across corefx tests (dotnet/corefx#30660)
Commit migrated from https://github.com/dotnet/corefx/commit/
7ae1a252d7e68c5513d2658de7a401c37e9b0504
Stephen Toub [Tue, 26 Jun 2018 03:55:07 +0000 (23:55 -0400)]
Merge pull request dotnet/corefx#30570 from dotnet-maestro-bot/master-UpdateDependencies
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02921-01, preview1-26624-03, preview1-26624-03, preview1-26624-01, beta-26622-00, beta-26622-00, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
14d17b207ff405892e56cc0e25c8e20f1f7f672f
Stephen Toub [Mon, 25 Jun 2018 23:54:41 +0000 (19:54 -0400)]
Simplify built-in types across corefx (dotnet/corefx#30656)
Commit migrated from https://github.com/dotnet/corefx/commit/
e0ba7aa8026280ee3571179cc06431baf1dfaaac
Wes Haggard [Mon, 25 Jun 2018 19:46:27 +0000 (12:46 -0700)]
Remove netcorepp2.2 from package testing
Commit migrated from https://github.com/dotnet/corefx/commit/
d77efb0302ed5ca8f029a4960c8b995f193cd16c
Jan Kotas [Sun, 24 Jun 2018 23:28:32 +0000 (16:28 -0700)]
Fixes and workarounds for new CoreCLR
Commit migrated from https://github.com/dotnet/corefx/commit/
32646dfea2e43e4235c2973e10e007e14d62978e
dotnet-maestro-bot [Sun, 24 Jun 2018 13:40:44 +0000 (06:40 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-02921-01, preview1-26624-03, preview1-26624-03, preview1-26624-01, beta-26622-00, beta-26622-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
b3d06972830374351dabeeb3cd71bbbfebeac29d
Luqun Lou [Mon, 25 Jun 2018 12:20:55 +0000 (05:20 -0700)]
Use public implementation MarshalSupport (dotnet/corefx#30494)
* Use public implementation MarshalSupport
* Implement NotifyCollectionChangedEventArgsMarshaler ConvertToManaged and PropertyChangedEventArgsMarshaler ConvertToNative
* Refactor RoGetActivationFactory into Common
* Update according to comments and add an analyzerdata file
Commit migrated from https://github.com/dotnet/corefx/commit/
098d8626dca87dd809fde77784c04eb9d00a2a3d
Afsaneh Rafighi [Mon, 25 Jun 2018 04:11:14 +0000 (21:11 -0700)]
addressed review feedbacks
Commit migrated from https://github.com/dotnet/corefx/commit/
98a9ccb74a6204901d3becd6e453eddd61e5db5d
Jeremy Kuhne [Sun, 24 Jun 2018 18:17:03 +0000 (11:17 -0700)]
Handle empty region scans on Unix.
Commit migrated from https://github.com/dotnet/corefx/commit/
abe3710c12f61c5958477cbf2158c26c417828a9
Jeremy Kuhne [Sun, 24 Jun 2018 04:05:49 +0000 (21:05 -0700)]
Remove GPRECT and GPRECTF
They match directly with Rectangle/RectangleF
Commit migrated from https://github.com/dotnet/corefx/commit/
9123e8ff2ccda39fa0abc2a0aeb07874ff217ae6
Jeremy Kuhne [Sun, 24 Jun 2018 03:32:48 +0000 (20:32 -0700)]
Style cleanup in preparation of perf fixes.
Commit migrated from https://github.com/dotnet/corefx/commit/
a0dd2fc0cf3f53233fee56c81e5eb9bd690e58ac
Meir Blachman [Sun, 24 Jun 2018 18:59:27 +0000 (21:59 +0300)]
docs: ActivityUserGuide.md typo (dotnet/corefx#30634)
Commit migrated from https://github.com/dotnet/corefx/commit/
8c906fbabc79c23c56edcb87b70dd22c7173d76a
Jan Kotas [Sun, 24 Jun 2018 18:58:54 +0000 (11:58 -0700)]
Update to latest released dotnet SDK (dotnet/corefx#30633)
Commit migrated from https://github.com/dotnet/corefx/commit/
4a2154cb309e5d4ecdf2ec2ee0075561f4ca0cd2
Jan Kotas [Sun, 24 Jun 2018 14:18:49 +0000 (07:18 -0700)]
Update performance counter interop to use Span<T> (dotnet/corefx#30614)
* Move NtProcessInfoHelper to ProcessManager.Win32.cs
NtProcessInfoHelper was split between ProcessManager.Win32.cs and ProcessManager.Windows.cs for no good reason
* Update performance counter interop to use Span<T>
This is both faster and more secure
* Delete FEATURE_TRACESWITCH
Commit migrated from https://github.com/dotnet/corefx/commit/
d1cdb1b324ea6b52d2b4026bdcc7c2ee1e00b63c
Filip Navara [Sun, 24 Jun 2018 04:29:39 +0000 (06:29 +0200)]
NetFX compatibility fixes for X500DistinguishedName.
* Don't write a separator after the empty DN
* Make T61String behave like it does on Windows (UTF-8 with a Latin-1 fallback)
* Use the managed decoder on Linux, instead of a lot of P/Invokes back into OpenSSL.
Commit migrated from https://github.com/dotnet/corefx/commit/
5e3aecf952ea5810b82293312fd840d4fdaa13d3
Jeremy Kuhne [Sat, 9 Jun 2018 23:16:27 +0000 (16:16 -0700)]
Kill allocations in GraphicsPath/Graphics
This removes a great deal of the unneeded allocations in GraphicsPath and Graphics. Points and rectangles match the native types exactly and don't need special marshalling outside of pinning arrays.
This removes all usages of GPPOINT/F. Many GPRECT/F usages were removed, but still exist in other classes.
Commit migrated from https://github.com/dotnet/corefx/commit/
7d95fd47402872de4deaca20f46586e0cb330e7c
Jeremy Kuhne [Sat, 23 Jun 2018 19:00:08 +0000 (12:00 -0700)]
Add using for SafeNativeMethods.Gdip
Commit migrated from https://github.com/dotnet/corefx/commit/
cf4ca262a66b4e2e87f90a5565ef474b992707b3
Jeremy Kuhne [Sat, 9 Jun 2018 23:00:07 +0000 (16:00 -0700)]
Clean style in Graphics/GraphicsPath
Make a consistency pass through Graphics & GraphicsPath.
Plan is to follow up with a change that removes the rest of the unnecessary allocations.
This change focuses on the Windows specific code. Some Unix code will be able to be unified with the Windows code once further changes happen. Rather than reformat the Unix code preemptively, leaving for final follow-up.
Commit migrated from https://github.com/dotnet/corefx/commit/
e448b6c5d5c9648ab9c1e6c5490c6f9ac6d1bd4c
Pent Ploompuu [Sat, 23 Jun 2018 23:48:33 +0000 (02:48 +0300)]
Decimal.Remainder tests (dotnet/corefx#30291)
* Decimal.Remainder tests
* Remove quirk for NearNegativeZero/NearPositiveZero scaling issue
Commit migrated from https://github.com/dotnet/corefx/commit/
3e107903bf6070bcae7b10986c0dabb4c7b03454
EdwinEngelen [Sat, 23 Jun 2018 18:55:41 +0000 (20:55 +0200)]
Make ControlChars public (dotnet/corefx#30551)
* Make ControlChars public
Accessibility now matches .NET Framework.
* Correct typo in comment
Commit migrated from https://github.com/dotnet/corefx/commit/
c555c7db2f53392eba90f1dfa1e46de92ebc1ae2
Stephen Toub [Sat, 23 Jun 2018 14:22:18 +0000 (10:22 -0400)]
Change string.Compare(..., Ordinal{IgnoreCase}) == 0 to use Equals (dotnet/corefx#30620)
Commit migrated from https://github.com/dotnet/corefx/commit/
963536c7b4f35363b9837c2f279e522aa237c84e
Luqun Lou [Sat, 23 Jun 2018 02:45:05 +0000 (19:45 -0700)]
Use public implementation WindowsRuntime ExceptionSupport (dotnet/corefx#30440)
Commit migrated from https://github.com/dotnet/corefx/commit/
585a9306ec049548680417e70765820b69c2d70f
Adeel Mujahid [Sat, 23 Jun 2018 02:40:39 +0000 (05:40 +0300)]
Pass RID to crossgen (dotnet/corefx#30562)
Commit migrated from https://github.com/dotnet/corefx/commit/
4aaf685b42201cbdb407c2cd3d3e0bcba72f3977
Alexander Köplinger [Sat, 23 Jun 2018 01:56:53 +0000 (03:56 +0200)]
Fix race in TaskCancelWaitTestCases.TaskCancelWait1() (dotnet/corefx#30615)
When `CancelChildren` is enabled (currently only in the `TaskCancelWait1` test)
we're hitting a race in `TaskCancelWaitTest.CreateTask()`:
1. Let's assume Task A is processing `node`
2. Task A spawns a new Task B for processing `node_1`
3. Task B starts and signals the `_countdownEvent`
4. `RealRun()` on the main thread exits the wait on `_countdownEvent`
5. `RealRun()` calls `Verify()` which loops through all the nodes and calls `VerifyCancel()`
6. We get an assertion because `CancellationToken.IsCancellationRequested` is false
7. Task A continues and sets the CancellationToken, but it is already too late by this point
To fix this race we wait on the task in `RealRun()` before proceeding to
the verification step.
This uncovered another issue:
Since `_countdownEvent` is accessed by multiple threads we have another
race between checking `_countdownEvent.IsSet` and `_countdownEvent.Signal()`.
This caused a `System.InvalidOperationException: Invalid attempt made to decrement the event's count below zero.`
Fixed it by locking access to the `_countdownEvent`.
Fixes https://github.com/dotnet/corefx/issues/20457
Fixes https://github.com/mono/mono/issues/6920
Commit migrated from https://github.com/dotnet/corefx/commit/
69cf791e365c2be6f919929c5ae521b2e070aa5d
Marco Rossignoli [Sat, 23 Jun 2018 00:08:18 +0000 (02:08 +0200)]
Move S.T.M. Span<char> tests to StringTests.cs(part 4) (dotnet/corefx#30301)
* merge IsWhiteSpace.cs
* nit: add space after comma
* fix netfx compat issue
* merge SequenceCompareTo.char.cs SequenceEqual.char.cs StartsWith.char.cs StartsWith.StringComparison.cs
* fix SequenceEqual tests
* merge TrimAnyCharacter.cs
* merge TrimManyCharacters.cs TrimWhiteSpace.cs
* address PR feedback
* Address PR feedback
* address PR feedback
* move ToLower.cs
* move ToUpper.cs and fix some tests
* address PR feedback
* nit spaces
* rename empty to emptyString
* nit spaces
* add missed tests in merge
* fix test
* fix Ctor_SByte test
* remove var for .AsSpan()
Commit migrated from https://github.com/dotnet/corefx/commit/
2566e24c97eb52ca2b0d22a8fe640e3a53230b51
Jeremy Barton [Fri, 22 Jun 2018 22:07:27 +0000 (15:07 -0700)]
Enable testing against NetFX for S.S.C.X509Certificates.Tests
* Make S.S.C.X509Certificates.Tests compile against netstandard
* Fix or disable tests for netfx behavior
* Make the casing of the default X509Store Name value match netfx
* Suppress brainpool GetECDsaPublicKey tests on netfx
Commit migrated from https://github.com/dotnet/corefx/commit/
6fe9969761bce606bdf76f8f580c3c3849fb9327
Michal Strehovský [Fri, 22 Jun 2018 11:50:51 +0000 (04:50 -0700)]
Sync SR class with the CoreRT copy
This ports over the change from
https://github.com/dotnet/corert/commit/dotnet/corefx@
0ac83cb8d6f9ab10df616a608fcf6fdfa6eabe2b.
When UsingResourceKeys is true and we stripped the resources, the
existing code would have returned null.
Commit migrated from https://github.com/dotnet/corefx/commit/
39e96cd8e3b97f8b1a5fce86211cf8fec7ea478a
Jeremy Barton [Fri, 22 Jun 2018 15:29:30 +0000 (08:29 -0700)]
Move new SignedCms/EnvelopedCms API to netcoreapp/uap refs
Commit migrated from https://github.com/dotnet/corefx/commit/
d622e90b0ad884f6d895dec882ccbd60ebd96acb
Hugh Bellamy [Fri, 22 Jun 2018 02:30:32 +0000 (03:30 +0100)]
Consolidate Font code and fix Unix compat bugs (dotnet/corefx#29673)
* Consolidate Font code
* Enable tests that pass already
These already pass - i.e. not as a result of this PR
Commit migrated from https://github.com/dotnet/corefx/commit/
80dc5bbbc8e10b4aaf6450d778fe46e303ce0e99