platform/core/csapi/xsf.git
4 years agoMerge branch '4.3.0'
Stephane Delcroix [Mon, 2 Sep 2019 08:27:50 +0000 (10:27 +0200)]
Merge branch '4.3.0'

4 years agoMerge branch '4.2.0' into 4.3.0
Stephane Delcroix [Mon, 2 Sep 2019 08:22:59 +0000 (10:22 +0200)]
Merge branch '4.2.0' into 4.3.0

4 years agofix merge issue
Stephane Delcroix [Mon, 2 Sep 2019 08:22:06 +0000 (10:22 +0200)]
fix merge issue

4 years agoMerge branch '4.3.0'
Stephane Delcroix [Mon, 2 Sep 2019 06:57:53 +0000 (08:57 +0200)]
Merge branch '4.3.0'

4 years agoMerge branch '4.2.0' into 4.3.0
Stephane Delcroix [Mon, 2 Sep 2019 06:56:41 +0000 (08:56 +0200)]
Merge branch '4.2.0' into 4.3.0

4 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Mon, 2 Sep 2019 06:39:59 +0000 (08:39 +0200)]
Merge branch '4.1.0' into 4.2.0

4 years agoMerge branch '4.0.0' into 4.1.0
Stephane Delcroix [Mon, 2 Sep 2019 06:38:00 +0000 (08:38 +0200)]
Merge branch '4.0.0' into 4.1.0

4 years ago[X] Detect empty property value in markups (#7190)
Stephane Delcroix [Sun, 1 Sep 2019 21:01:44 +0000 (23:01 +0200)]
[X] Detect empty property value in markups (#7190)

- fixes #7187

4 years agoUpdate GitInfo.txt
Samantha Houts [Fri, 30 Aug 2019 00:30:51 +0000 (17:30 -0700)]
Update GitInfo.txt

4 years agoFix NRE for gh 4267 (#7306)
kingces95 [Thu, 29 Aug 2019 23:39:49 +0000 (13:39 -1000)]
Fix NRE for gh 4267 (#7306)

4 years ago[Feature] CarouselView (#5044)
Rui Marinho [Thu, 29 Aug 2019 23:26:23 +0000 (00:26 +0100)]
[Feature] CarouselView (#5044)

* [Spec] Draft carousel

* [Core,Spec] Add IndicatorsView

* [iOS] IndicatorsViewRenderer and CarouselVieRenderer draft

* [Controls] Fix controls gallery linker

* [Core] Remove extra file

* Fix Remove IITemsSource

* [iOS] Implement Scroll and selected item

* [iOS,Android,Core] Refactor to use CurrentItem on CarouselView

* [iOS,Core] Add NumberOfVisbileItems

* [iOS,Core] Add IsScrolling and IsDragging

* [iOS,Core] Add Visual state for carousel items

* [iOS,Core] Add padding to CarouselView

* [iOS,Controls] Fix sample, disable selection on CarouselViewController

* [Core] Add Delta to ScrolledDirectionEventArgs

* Update SelectableItemsViewRenderer.cs

* [Controls] Refactor Carousel examples

* [Controls] Fix csproj

* [iOS] Fix bug with insets with carouselview padding

* [Controls] Fix vm for CarouselXamlGallery

* [Controls] Collection Carousel type demo

* [Core] Add other CarouselView Layouts

* Fix Carousel rebase (#6518)

* Fix rebase Android

* Fix rebase iOS

* Update ItemSizingStrategy

* [Core] Add ItemSizingStrategy None

* [iOS] Allow to override ReuseId and RegisterCells from ItemsViewController

* Remove IndicatorsView

* Remove ICarouselViewController

* Implemented IsDragging on Android

* Implemented Scrolled for Android

* Removed Spacing methods

Spacing is now available on a lower level and we don't need to worry about it

* Fix rebase

* [UnitTests] Add basic CarouselView unit tests

* [iOS] Update CarouselViewLayout

* [iOS,Core] Remove Padding and add PeekAreaInsets

* [iOS] Fix peek area insets update on CarouselView

* [iOS,Core] Remove extra scroll code update

* [iOS] Fix bug ScrollAnimationEnded missing

* [Core] Mark BPK as private

* [Core] Rename NumberOfSideItems

* Update ItemsViewRenderer.cs

* [Android] Remove scroll direction update

* First small UI tests

* [iOS] Carousel Apply suggestions from code review

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* More UI tests and plumbing

* Fix build errors

* [Android] Fix CarouselView sizing on Android

* Implemented IsSwipeEnabled iOS

* Implemented bounce iOS

* Merged with scroll changes ItemsView

* Implemented IsBounceEnabled Android

* [Android] Update position

* Update App.cs

* Added CarouselView Core Gallery sample

* Update ItemsViewController.cs

* Fixed Core Gallery problems with Linker

* Added more CarouselView properties to the Core Gallery sample

* Added new CarouselView sample adding and removing items, etc.

* [Android]Add spacing inset for fist and last item

* [Android] ScrollTo and center item on carousel

* Spelling and not breaking build

* [Android]Use SnapHelper to get centered view

* Make Position work (again) for iOS

* Rebase from master (fixed conflicts)
Fixed Android bug related with the first item inset calcs.
fixes #4996

4 years ago[Android/iOS] RefreshView (#7214)
Shane Neuville [Thu, 29 Aug 2019 21:09:34 +0000 (15:09 -0600)]
[Android/iOS] RefreshView (#7214)

* Swipe To Refresh

* pull in pull to refresh

* api changes

* Added RefreshView CoreGallery and Gallery Samples (using ScrollView, ListView, CollectionView, etc.)

* Code refactoring in RefreshViewRenderer (iOS)

* Updated RefreshView Android Renderer

* Fixed RefreshView Android samples in Core Gallery

* Added initial RefreshView UWP implementation

* Added another UWP RefreshView renderer using WinUI NuGet controls (RefreshContainer)

* - additional linker settings

* - uwp fixes

* - disable SkipMicrosoftUIXamlCheckTargetPlatformVersion check

* Update .nuspec/Xamarin.Forms.targets

* Limited RefreshView in Android to support only content using scroll.
Small changes in RefreshView iOS renderer.
Updated Core Gallery RefreshView samples.

* Fixed Visualizer colors in UWP RefreshView

* Added UWP RefreshPullDirection Platform Specific

* Small changes in code syntax in iOS renderer.

* Removed some unnecessary curly braces .

* Register effect provider in iOS RefreshView

* Changes in RefreshView UWP Dispose

* Added conditional code to manage the refresh control differently if it is iOS 10 or higher.

* Fixed error in Android Core Gallery (Linker)
Code refactoring and small changes (PR Feedback)

* Changes disposing the Android renderer

* - fix SkipMicrosoftUIXamlCheckTargetPlatformVersion so it can be turned off

* Removed UWP RefreshView renderer and Platform Specific

* - remove winui from nuspec

* - remove skip checks from targets

* - remove XamlControlsResources

* - remove skip check on UAP platform

* Revert changes in Android Core Gallery manifiest

* Revert unnecessary space in UAP Platform csproj

* Removed unnecessary new line in UWP Resources

* Simplified RefreshView iOS Renderer.
fixes #5882

4 years ago[iOS] Fix accessibility regressions with hidden views, WebViews, and layouts (#7213)
Samantha Houts [Thu, 29 Aug 2019 18:39:40 +0000 (11:39 -0700)]
[iOS] Fix accessibility regressions with hidden views, WebViews, and layouts (#7213)

* [iOS] Allows views that don't implement ITabStop to be accessible

Also added ITabStop to the WebView renderers

fixes #6894

* [iOS] Don't exclude layouts from a11y tree

fixes #7053

* Add test for 7053

* Add test for 6894

* [iOS] Clear accessibility elements when visibility changes

fixes #6929

* Add test for 6929

* Update Issue6894.cs

4 years agoAdd priority parameter to HandlerAttribute to thwart priority by assembly order ...
Shane Neuville [Thu, 29 Aug 2019 17:42:59 +0000 (11:42 -0600)]
Add priority parameter to HandlerAttribute to thwart priority by assembly order (#7113) fixes #6939

* add priority parameter to handler to thwart priority by assembly order

* - internalize priority

* - fix ui tests

* - remove from uwp

* - registrar fix

4 years agoUpdate issue templates
Samantha Houts [Thu, 29 Aug 2019 17:06:03 +0000 (10:06 -0700)]
Update issue templates

4 years ago[Maps] Add polylines and polygons (#6136)
Joe Manke [Thu, 29 Aug 2019 16:47:57 +0000 (11:47 -0500)]
[Maps] Add polylines and polygons (#6136)

* Add Polyline to Map

* Android Polyline rendering

* iOS polyline renderer

* UWP polyline renderer

* Unregister OnPolylineCollectionChanged in Dispose of UWP renderer

* Add MapElement base class

* Update Android MapRenderer with MapElement

* Update UWP MapRenderer with MapElement

* Update iOS MapRenderer with MapElement

* Add polygons

* Tweak functionality of gallery page

* Rename some things in Android renderer

* Made LoadPolyline and LoadPolygon virtual on UWP

* Fix iOS/Mac MapRenderer compile errors
fixes #1673
fixes #5773

4 years ago[Shell][Tizen] Add the MaterialShellRenderer on Tizen (#6196)
yourina [Thu, 29 Aug 2019 14:12:00 +0000 (10:12 -0400)]
[Shell][Tizen] Add the MaterialShellRenderer on Tizen (#6196)

* [Shell][Tizen] Add the MaterialShellRenderer on Tizen

* Fixed the build fail

* Update namespace

4 years agoFix Android FlyoutBehavior Disabled and add UI Tests (#7254)
Shane Neuville [Wed, 28 Aug 2019 21:27:59 +0000 (15:27 -0600)]
Fix Android FlyoutBehavior Disabled and add UI Tests (#7254)

* fix android flyout behavior and add ui tests

* - fix ui test

* - FlyoutLocked fixes
fixes #7238
fixes #6261

4 years ago[X] OnPlatform use BP.DefaultValue (#7188)
Stephane Delcroix [Wed, 28 Aug 2019 21:23:37 +0000 (23:23 +0200)]
[X] OnPlatform use BP.DefaultValue (#7188)

If no default is provided for {OnPlatform}, default to DefaultValue
if this is targetting a BindableProperty.

Also use other value than null as sentinel, as {x:Null} is a
perfectly valid value.

- fixes #7156

4 years agoListView.Scrolled (#7157)
ksemenenko [Wed, 28 Aug 2019 20:49:20 +0000 (23:49 +0300)]
ListView.Scrolled (#7157)

fixes #4323

4 years agoRemove header padding and propagate elevation (#6970)
Shane Neuville [Wed, 28 Aug 2019 20:45:48 +0000 (14:45 -0600)]
Remove header padding and propagate elevation (#6970)

- fixes #6964

4 years ago[iOS] Implement CollectionView ScrollTo with groups (#7220)
E.Z. Hart [Wed, 28 Aug 2019 17:30:05 +0000 (11:30 -0600)]
[iOS] Implement CollectionView ScrollTo with groups (#7220)

* ScrollTo with groupIndex on iOS

* Add test for scrolling to group/item (objects rather than indexes)

* Fix automation IDs for new fields

* Add missing issue info to test page

* Fix UI tests

* Workaround for problems scrolling to group index/item index on first try

* Make the test page legible on Android

* Remove private modifiers

4 years agofix android content offset on navigated to page (#7265)
Shane Neuville [Wed, 28 Aug 2019 15:59:11 +0000 (09:59 -0600)]
fix android content offset on navigated to page (#7265)

4 years agoMake Label display HTML from a string (#4527)
Gerald Versluis [Wed, 28 Aug 2019 11:25:02 +0000 (13:25 +0200)]
Make Label display HTML from a string (#4527)

* Use UpdateText

* Added missing helper method and UI test

* Added missing helper for UWP

* Added csproj entry for helper

* Resolved rebase conflicts

* Update LabelRenderer.cs

* Update LabelRenderer.cs

* Update LabelRenderer.cs

* iOS Merge error fix

* Feedback

* - uwp fixes

* - android fix empty text

* - ios fix null and setting text when texttype starts as html

* - set _perfectSizeValid = false; after changed AttributedText

Setting the AttributedText causes GetDesiredSize to get called which sets _perfectSizeValid to true but at this point this frame still hasn't adjusted to any size change from *LayoutSubViews*. This resets _perfectSizeValid so after the AttributedText set the desiredsize can get pulled again

* Renamed PlainText to Text

* Fixed initial no HTML styling

4 years agoImplement CollectionView grouping on Android (#7199)
E.Z. Hart [Wed, 28 Aug 2019 01:29:07 +0000 (19:29 -0600)]
Implement CollectionView grouping on Android (#7199)

* Move all the header/footer adjustment to IItemsViewSource
fixes #7121
fixes #7102
partially implements #3172
fixes #7243

* Fix selection bugs introduced by header/footer on Android

* Implement grouping for CollectionView on Android

* Enable grouping tests for Android

* Naming and comment cleanup

* Update Xamarin.Forms.Platform.Android/CollectionView/ListSource.cs

Co-Authored-By: Gerald Versluis <gerald.versluis@microsoft.com>
* Update Xamarin.Forms.Platform.Android/CollectionView/ObservableGroupedSource.cs

4 years agoupdate create-nuget.bat
Chris King [Tue, 27 Aug 2019 20:44:17 +0000 (10:44 -1000)]
update create-nuget.bat

4 years agoAutomated UI Tests (#5880)
Pedro Jesus [Tue, 27 Aug 2019 14:14:32 +0000 (11:14 -0300)]
Automated UI Tests (#5880)

* - automated the Bugzilla43663 and 44476

* - Add instructions in the test

* - Automated Bugzilla43519

* - Add Category in Bugzilla43469

* -Add instructions in Bugzilla42832

* - Automated 42329

* - Automated Bugzilla41271

* - style code

* - Automated Bugzilla40955

* - Automated Bugzilla40824

* - Add instructions to Bugzilla40824

* - Automated and Add instructions Bugzilla40408

* - fix code style in consts

* - Automated Bugzilla40092

* - Automated Bugzilla40092

* - Add instructions in B40092

* - B39987 Fix the preserve atribute; Automated
- Fix B40092 tests

* - Improve in B40092

* Review Bugzilla:
- 40092
- 41271
- 43663

* - Fix the build fails (changed const name)

* -Fix the mapRenderer error

* - Bugzilla 40408 pass in UWP

* - 41271 fix in uwp

* - Fix B42329 in UWP

* - code adjust

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40824.cs

Co-Authored-By: pictos <pedrojesus.cefet@gmail.com>
* - REmove obsolet refernece

* - Revert the Bugzilla40824

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla42329.cs

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla42329.cs

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* - Fidex B42329

* - Fixed B41271

* - Fixed B43519

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40092.cs

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla43663.cs

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40408.cs

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39987.cs

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* - B42329 runs only on Android

4 years agoDisable UWP CollectionViewSource CurrentItem synchronization (#7267) fixes #7194
E.Z. Hart [Tue, 27 Aug 2019 13:59:56 +0000 (07:59 -0600)]
Disable UWP CollectionViewSource CurrentItem synchronization (#7267) fixes #7194

* Disable UWP CollectionViewSource CurrentItem synchronization
Fixes #7194

* Remove unnecessary stuff from test page

4 years agoFix crash with nested CollectionViews on UWP (#7273) fixes #6620
E.Z. Hart [Tue, 27 Aug 2019 13:57:01 +0000 (07:57 -0600)]
Fix crash with nested CollectionViews on UWP (#7273) fixes #6620

Closes #6620

4 years agoFix android to not duplicate titleview with shell (#7276)
Shane Neuville [Tue, 27 Aug 2019 07:19:52 +0000 (01:19 -0600)]
Fix android to not duplicate titleview with shell (#7276)

4 years agofixes toolbox snippet for CollectionView (#7259)
Pavel Yakovlev [Mon, 26 Aug 2019 11:33:14 +0000 (14:33 +0300)]
fixes toolbox snippet for CollectionView (#7259)

4 years ago[Build] Add nightly schedule (#7263)
Rui Marinho [Mon, 26 Aug 2019 11:28:55 +0000 (12:28 +0100)]
[Build] Add nightly schedule (#7263)

* [Build] Add nightly schedule

* Update azure-pipelines.yml

4 years agoMerge branch '4.2.0'
Stephane Delcroix [Mon, 26 Aug 2019 08:25:55 +0000 (10:25 +0200)]
Merge branch '4.2.0'

4 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Mon, 26 Aug 2019 08:24:04 +0000 (10:24 +0200)]
Merge branch '4.1.0' into 4.2.0

4 years ago[Mac] Added support AutomationProperty (#5137)
Pavel Yakovlev [Thu, 22 Aug 2019 14:58:04 +0000 (17:58 +0300)]
[Mac] Added support AutomationProperty (#5137)

* [Mac] Added support AutomationProperty

* revert defaults

* clean code

* Update AutomationPropertiesGallery.cs

4 years ago[Android] Fix MasterDetailContainer fragment handling (#6471)
Kevin Petit [Thu, 22 Aug 2019 14:00:13 +0000 (16:00 +0200)]
[Android] Fix MasterDetailContainer fragment handling (#6471)

* Fix MasterDetailContainer fragment handling.
Transaction is necessarily executed after the view is added.

* Only postpone the transaction if the view is not attached yet.

* typo, private

4 years agoUpdate categories for tests
Rui Marinho [Thu, 22 Aug 2019 13:39:11 +0000 (14:39 +0100)]
Update categories for tests

4 years agoFix NRE fixes #6776 (#7215)
kingces95 [Thu, 22 Aug 2019 13:33:06 +0000 (03:33 -1000)]
Fix NRE fixes #6776 (#7215)

4 years agomake all ShellTabBarAppearanceTracker methods virtual (#7175)
Shane Neuville [Thu, 22 Aug 2019 13:27:44 +0000 (07:27 -0600)]
make all ShellTabBarAppearanceTracker methods virtual (#7175)

4 years ago- Issue 7207 - if current culture of the current thread is not set to the invariant...
Brayan Khosravian [Thu, 22 Aug 2019 13:12:34 +0000 (15:12 +0200)]
- Issue 7207 - if current culture of the current thread is not set to the invariant culture then initializing the app causes a "NUnit.Framework.InconclusiveException" with the exception- message "App did not start for some reason. System.Argument.Exception: 1 is not supported code page. Parameter name: codepage." (#7228)

* - Issue 7207 - if current culture of the current thread is not set to the invariant culture then initializing the app causes a "NUnit.Framework.InconclusiveException" with the exception- message "App did not start for some reason. System.Argument.Exception: 1 is not supported code page. Parameter name: codepage."

* - fixed usings

4 years ago[iOS] fix accessibility of Picker (#5145)
Pavel Yakovlev [Thu, 22 Aug 2019 11:57:45 +0000 (14:57 +0300)]
[iOS] fix accessibility of Picker (#5145)

4 years agoEntry ClearButtonMode (#5277)
Andrei Nitescu [Thu, 22 Aug 2019 11:54:04 +0000 (14:54 +0300)]
Entry ClearButtonMode (#5277)

* Entry ClearButtonMode property (#5277)

* Renamed to ClearButtonVisibility

4 years ago[Tizen] Adds Opt-in Init (#7209)
Kangho Hur [Thu, 22 Aug 2019 11:51:32 +0000 (20:51 +0900)]
[Tizen] Adds Opt-in Init (#7209)

4 years ago[Android] Context actions menu is now updated when changing cells. (#6460) fixes...
Guido Neele [Thu, 22 Aug 2019 11:23:55 +0000 (13:23 +0200)]
[Android] Context actions menu is now updated when changing cells. (#6460) fixes #1455 fixes #4041

* Bugfix of issue 1455. Force SupportActionMode Menu to recreate when it's active and another cell is clicked.

* Added UITest

* Added an assert which checks if the new menu items have been updated.

* Correct project file

* Added a platform specific BindableProperty for the ViewCell to use ContextActions in LegacyMode.

* Update Xamarin.Forms.Core/PlatformConfiguration/AndroidSpecific/ViewCell.cs

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1455.xaml.cs

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
4 years agoUpdate SafeShellTabBarAppearanceTracker.cs (#7165) fixes #6739
Gerald Versluis [Thu, 22 Aug 2019 11:17:26 +0000 (13:17 +0200)]
Update SafeShellTabBarAppearanceTracker.cs (#7165) fixes #6739

4 years agoBasic Header/Footer for UWP CollectionView (#7237)
E.Z. Hart [Thu, 22 Aug 2019 11:10:12 +0000 (05:10 -0600)]
Basic Header/Footer for UWP CollectionView (#7237)

4 years ago[iOS] Fix LayoutCompression Performance Issues #3475 (#7201)
Giampaolo Gabba [Wed, 21 Aug 2019 14:57:40 +0000 (16:57 +0200)]
[iOS] Fix LayoutCompression Performance Issues #3475 (#7201)

* fix #3475

* fix blank lines in project file

* fix issue in gallery to target iOS only

* fixed white spaces in project file (thx r#)

4 years agoFix default cancel button visibility on iOS SearchHandler (#6931)
joepgrooten [Wed, 21 Aug 2019 00:23:02 +0000 (02:23 +0200)]
Fix default cancel button visibility on iOS SearchHandler (#6931)

fixes #6802

4 years agominor fixes (#7178)
adrianknight89 [Mon, 19 Aug 2019 23:05:30 +0000 (18:05 -0500)]
minor fixes (#7178)

4 years agoUpdate README.md (#7196)
Brian Runck [Sun, 18 Aug 2019 16:53:42 +0000 (12:53 -0400)]
Update README.md (#7196)

Fix blog post link

4 years agoMerge branch '4.2.0'
Samantha Houts [Sat, 17 Aug 2019 01:23:01 +0000 (18:23 -0700)]
Merge branch '4.2.0'

4 years agoUpdate Forms.cs
Samantha Houts [Sat, 17 Aug 2019 01:22:38 +0000 (18:22 -0700)]
Update Forms.cs

4 years agoMerge branch '4.2.0'
Samantha Houts [Sat, 17 Aug 2019 00:54:38 +0000 (17:54 -0700)]
Merge branch '4.2.0'

4 years agoMerge branch '4.1.0' into 4.2.0
Samantha Houts [Sat, 17 Aug 2019 00:51:53 +0000 (17:51 -0700)]
Merge branch '4.1.0' into 4.2.0

4 years agoMerge branch '4.0.0' into 4.1.0
Samantha Houts [Sat, 17 Aug 2019 00:46:46 +0000 (17:46 -0700)]
Merge branch '4.0.0' into 4.1.0

4 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Sat, 17 Aug 2019 00:41:04 +0000 (17:41 -0700)]
Merge branch '3.6.0' into 4.0.0

4 years agoFix MDP for iPads running iOS13 (#7173)
Shane Neuville [Sat, 17 Aug 2019 00:34:42 +0000 (18:34 -0600)]
Fix MDP for iPads running iOS13 (#7173)

* Fix MDP for iPads running iOS13

* - remove s_respondsTosetNeedsUpdateOfHomeIndicatorAutoHidden

* - missing ;

4 years ago[Core] FIX RelativeLayout layout error when only width or height specified (#5694)
kicsiede [Fri, 16 Aug 2019 21:23:29 +0000 (23:23 +0200)]
[Core] FIX RelativeLayout layout error when only width or height specified (#5694)

fixes #5581

4 years ago[Shell] Fix back button behavior so that it only applies the property you've set...
Shane Neuville [Fri, 16 Aug 2019 21:22:14 +0000 (15:22 -0600)]
[Shell] Fix back button behavior so that it only applies the property you've set opposed to replacing the entire thing (#6762)

* Fix backbutton behavior to only apply what you've set opposed to replacing everything

* - move GetPropertyIfSet to Core.Internals

* - make GetPropertyIfSet public.
fixes #5744

4 years ago[Tizen] Fix Forms namespace correctly (#7193)
Samantha Houts [Fri, 16 Aug 2019 21:09:25 +0000 (14:09 -0700)]
[Tizen] Fix Forms namespace correctly (#7193)

4 years agoFix MDP for iPads running iOS13 (#7171)
Shane Neuville [Fri, 16 Aug 2019 21:09:00 +0000 (15:09 -0600)]
Fix MDP for iPads running iOS13 (#7171)

4 years agoForce iOS 13 to use Full Screen for Modal (#7174)
Shane Neuville [Fri, 16 Aug 2019 19:33:05 +0000 (13:33 -0600)]
Force iOS 13 to use Full Screen for Modal (#7174)

* Force iOS 13 to use Full Screen for Modal
- Once we are on xCode 11 and can account for swipe dismiss we can make this better

* - Removed s_respondsTosetNeedsUpdateOfHomeIndicatorAutoHidden

4 years ago[Android] Cache typefaces in font image source handler (#6470)
Tomasz Ścisłowicz [Fri, 16 Aug 2019 18:43:30 +0000 (20:43 +0200)]
[Android] Cache typefaces in font image source handler (#6470)

* cache typefaces in font image source handler

* remove private modifier

* use concurrent dictionary

* move caching to FontExtensions

* convert null fontFamily parameter to empty string
fixes #6317
fixes #6949

4 years agoForce iOS 13 to use Full Screen for Modal (#7172)
Shane Neuville [Fri, 16 Aug 2019 18:32:59 +0000 (12:32 -0600)]
Force iOS 13 to use Full Screen for Modal (#7172)

- Once we are on xCode 11 and can account for swipe dismiss we can make this better

4 years agoUpdate Xamarin.Forms.nuspec (#7189)
Gerald Versluis [Fri, 16 Aug 2019 17:28:51 +0000 (19:28 +0200)]
Update Xamarin.Forms.nuspec (#7189)

fixes #7184

4 years ago[Android] Don't dispose the _labelTextColorDefault on Label Fast Renderer (#7163)
Samantha Houts [Fri, 16 Aug 2019 16:39:53 +0000 (09:39 -0700)]
[Android] Don't dispose the _labelTextColorDefault on Label Fast Renderer (#7163)

* Add test case

* [Android] Don't dispose the _labelTextColorDefault on Label Fast Renderer

fixes #6994

* [Android] Don't crash when ListView ItemSource collection cleared

* Update Issue6994.cs

* Update Issue6994.cs

* await
fixes #6994

4 years ago[UWP] Value does not fall with in the expected range Exception while creating NativeV...
Gerald Versluis [Fri, 16 Aug 2019 00:18:01 +0000 (02:18 +0200)]
[UWP] Value does not fall with in the expected range Exception while creating NativeView (#6557)

* Added repro, fix and test

* Apply suggestions from code review

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Merged in double UI test somehow

* Made test Win specific and made it work!
fixes #5886

4 years ago[C] force update size on View updated (#6936)
Stephane Delcroix [Thu, 15 Aug 2019 22:41:06 +0000 (00:41 +0200)]
[C] force update size on View updated (#6936)

4 years agononappcompat check if MDP Icon is null (#7162)
Shane Neuville [Thu, 15 Aug 2019 22:37:52 +0000 (16:37 -0600)]
nonappcompat check if MDP Icon is null (#7162)

fixes #6958

4 years agoReplace IsDesignModeEnabled check with original Context Type Check (#7143)
Shane Neuville [Thu, 15 Aug 2019 22:23:12 +0000 (16:23 -0600)]
Replace IsDesignModeEnabled check with original Context Type Check (#7143)

* remove use of DesignMode just store check in static bool

* - fix set

* - fix last check

* - spelling fix

4 years agoadd profiler instrumentation (#7134)
kingces95 [Thu, 15 Aug 2019 18:34:27 +0000 (08:34 -1000)]
add profiler instrumentation (#7134)

4 years ago[UWP] Multi-window (#2432)
Edwin Wachs [Thu, 15 Aug 2019 17:36:38 +0000 (14:36 -0300)]
[UWP] Multi-window (#2432)

* Changes to support multiple windows on UWP

* Locker on Layout.cs to prevent concurrency

* Changes on UnitTests to work with multi-window

* implemented Xamarin.Forms.Core and UAP Element.Dispatcher

* Implementation on each platform

* Implementation on each platform

* Improved Element casting for Dispatcher utilization

* Correction of the items presented in the code review

* Control Gallery for Multiple Window and Code Review

* [UnitTests]Add missing file

* Correction for Unit Tests

* Correction for Unit Tests

* Correction for Unit Tests - Removed ThreadStatic in Ticker

* removed thread static

* removed thread static into application class

* Update Control Gallery

* Code Review (Changes)

* Comment

* Adjust StackOverflow when close the app

* Performace improvements

* - fix merge and ui test performance

* Name of method and adjust on NavigationProxy

* Adjustments in the implementation of the DispatcherManager

* Updated the ListProxy method and adjust the initialization of dispacther on page.

* Remove GetDispacther method from IPlatformServices and some adjusments of code review.

* Adjust after merge on NavigationProxy

* Register IDispatcherProvider on Xamarin.Forms.Core.UnitTests

* Adjustments for correct unit tests operation

* Adjustments for correct unit tests operation

* remove spaces

* Adjust for UITests

* Remove IsInvokeRequired and adjusted de instance of s_resolutionList

* Remove lock() on ResolveLayoutChanges method

* Make IDispatcher implementations internal

* Removed Dispatcher association from Element and Page class. Removed Child Assignment in Element Class and ThreadStatic Removal from NavigationProxy Property

* Remove DispatcherManager; contain thread static to UWP implementation

* Make dispatcher lazy

* MockDispatcherProvider on Xaml.UnitTests

* Add mock Dispatcher and DispatcherProvider for XAML unit tests

* Revert "Add mock Dispatcher and DispatcherProvider for XAML unit tests"

This reverts commit 134320d348a3812e44507ae0b50459c8f43478e9.

* Add MockDispactcherProvider on Pager.UnitTests

* Revert covariance change

* Centralize dispatcher checking logic

* Add a fallback dispatcher for platforms without a registered DispatcherProvider

* Remove Dispatcher/DispatcherProvider from project

* Allow UI test pages which use ListProxy to get a dispatcher in UITest mode

* Prevent crash instantiating UITest version of Issue2004

* Removed unnecessary old codes

* Clean up whitespace changes

* Remove unused method

4 years ago[iOS] Moved `UITableView` setup selection to `ListViewRenderer` (#7122)
Vinicius Jarina [Thu, 15 Aug 2019 15:45:07 +0000 (11:45 -0400)]
[iOS] Moved `UITableView` setup selection to `ListViewRenderer` (#7122)

* [iOS] Moved `UITableView` setup selection to `ListViewRenderer`

* Setup the selection  from the `ContectActionCell` was causing the Xamarin.Forms previewer to crash.

TL;DR:  The previewer was crashing for a few scenarios, and rendering `ItemPage.xaml` from the Master Detail template.

From stack trace it seems that the `GestureReconizer` of the `ContextActionCell` was collected or disposed, when UIKit calls `GetCell` or `LayoutSubviews`, which calls `SetupSelection` https://github.com/xamarin/Xamarin.Forms/blob/57d507ef0b47d54d4026a07632f88a39a40de0c9/Xamarin.Forms.Platform.iOS/ContextActionCell.cs#L651 the GestureReconizer isn't there anymore, and X.iOS tries to resurrect it, causing a `MissingCtor` exception
https://gist.github.com/viniciusjarina/407952739b7f19eee15df6a5a021192b

The problem seems related to a regression on Mono/Xamarin.iOS, this patch workaround the problem avoiding Xamarin.Forms to try to setup the selection twice, hence avoiding calling `table.GestureRecognizers`.

Fixes: AB#889294
Fixes: AB#927358

* Update Xamarin.Forms.Platform.iOS/ContextActionCell.cs

4 years agoMerge branch '4.2.0'
Stephane Delcroix [Thu, 15 Aug 2019 06:31:01 +0000 (08:31 +0200)]
Merge branch '4.2.0'

4 years agofix merge (#7164)
Stephane Delcroix [Thu, 15 Aug 2019 06:30:07 +0000 (08:30 +0200)]
fix merge (#7164)

4 years agoMerge branch '4.2.0'
Stephane Delcroix [Wed, 14 Aug 2019 18:43:26 +0000 (20:43 +0200)]
Merge branch '4.2.0'

4 years agoMerge branch '4.1.0' into 4.2.0
Stephane Delcroix [Wed, 14 Aug 2019 18:41:24 +0000 (20:41 +0200)]
Merge branch '4.1.0' into 4.2.0

4 years agoMerge branch '4.0.0' into 4.1.0
Stephane Delcroix [Wed, 14 Aug 2019 18:38:33 +0000 (20:38 +0200)]
Merge branch '4.0.0' into 4.1.0

4 years agofixes #6074 (#6982)
Andrei [Wed, 14 Aug 2019 16:42:07 +0000 (19:42 +0300)]
fixes #6074 (#6982)

4 years agoRemove NestedScrollView from the default shell layout (#7032)
Shane Neuville [Wed, 14 Aug 2019 16:06:54 +0000 (10:06 -0600)]
Remove NestedScrollView from the default shell layout (#7032)

* Remove NestedScrollView from the default shell layout

* only set NestedScrollingEnabled if parent is NestedScrollView

* Automate UI Tests

* - remove C#  7.1 feature and fix UI tests for iOS

* -additional c# 7.1 fixes

* -change ui tests to use gestures for scrolling

4 years agoadded static bool and check for iOS 13 (#7041)
David Ortinau [Wed, 14 Aug 2019 15:44:19 +0000 (10:44 -0500)]
added static bool and check for iOS 13 (#7041)

stephane said it was ok, so it's ok. ok? ok.

4 years ago[iOS] make VisualElementExtensions public (#7144)
Shane Neuville [Wed, 14 Aug 2019 15:00:57 +0000 (09:00 -0600)]
[iOS] make VisualElementExtensions public (#7144)

4 years agoFixes issue #7109 in XF 4.0 branch (#7151)
Jonathan Goldberger [Wed, 14 Aug 2019 14:59:50 +0000 (04:59 -1000)]
Fixes issue #7109 in XF 4.0 branch (#7151)

4 years agoUse NSIndexPath.Item instead of .Row in CollectionView (#7107)
E.Z. Hart [Wed, 14 Aug 2019 14:10:45 +0000 (08:10 -0600)]
Use NSIndexPath.Item instead of .Row in CollectionView (#7107)

* Use NSIndexPath.Item in CollectionView (instead of .Row)
Fixes #6737

* Missed a couple of .Row usages

4 years agoUpdate CONTRIBUTING.md (#7153)
Brian Runck [Wed, 14 Aug 2019 09:37:18 +0000 (05:37 -0400)]
Update CONTRIBUTING.md (#7153)

Fix link to Beginner's Guide for Contributing

4 years agoAdd separate MarkerClick and InfoWindowClick events for Pins (#6079)
Joe Manke [Wed, 14 Aug 2019 00:41:11 +0000 (19:41 -0500)]
Add separate MarkerClick and InfoWindowClick events for Pins (#6079)

* Add separate MarkerClick and InfoWindowClick events for Pins

* Mark Pin.Clicked obsolete

* Use for loops to look up Pins in renderers.

* Add custom EventArgs for MapClicked and InfoWindowClicked

* Update MapGalleryPage for new events

* Obsolete messages and other cleanup

* Correct the pragma when calling Pin.SendTapped

* Change obsolete message to say 4.2.0

* Ignore warning on Pin.SendTap() on other platforms

* Update obsolete messages to 4.3.0

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
fixes #2509
fixes #3131
fixes #5490

4 years agoMerge branch '4.2.0'
ShaneN [Tue, 13 Aug 2019 17:27:43 +0000 (11:27 -0600)]
Merge branch '4.2.0'

4 years agoAdded missing NamedSizes for WPF (#7116)
Gerald Versluis [Tue, 13 Aug 2019 09:59:37 +0000 (11:59 +0200)]
Added missing NamedSizes for WPF (#7116)

# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

4 years agoadd wait before WaitForNoElement (#7132)
Shane Neuville [Tue, 13 Aug 2019 09:31:43 +0000 (03:31 -0600)]
add wait before WaitForNoElement (#7132)

4 years agoUpdate ScrollViewRenderer.cs (#6151) (#7133)
Shane Neuville [Tue, 13 Aug 2019 06:41:09 +0000 (00:41 -0600)]
Update ScrollViewRenderer.cs (#6151) (#7133)

4 years ago[Android, previewer] fixes layouts in the preview when using InvokeOnMainThread funct...
Pavel Yakovlev [Tue, 13 Aug 2019 06:32:08 +0000 (09:32 +0300)]
[Android, previewer] fixes layouts in the preview when using InvokeOnMainThread function (#7044)

4 years ago[Android] Update webview to use correct value for WebNavigationEvent (#7089)
Ravinder Jangra [Mon, 12 Aug 2019 21:10:23 +0000 (02:40 +0530)]
[Android] Update webview to use correct value for WebNavigationEvent (#7089)

* Update Android webview to return correct WebNavigationEvent value

* set _eventState on load

4 years ago[Android] Disable AndroidTicker if AnimatorDurationScale is equal or below 0 (#7092)
thisisthekap [Mon, 12 Aug 2019 21:08:16 +0000 (23:08 +0200)]
[Android] Disable AndroidTicker if AnimatorDurationScale is equal or below 0 (#7092)

* disable AndroidTicker if AnimatorDurationScale is equal or below 0

* made IsAnimatorEnabled null safe

* changed defautl behavior of IsAnimatorEnabled to disable animations if android context or context resolver are null

4 years agouse c#7.3 (#7131)
Stephane Delcroix [Mon, 12 Aug 2019 13:27:30 +0000 (15:27 +0200)]
use c#7.3 (#7131)

* use c#7.2

* try 7.3 on CI

* [Build] Specify mono version on android build

4 years agoAdded missing NamedSizes for GTK (#7130)
Javier Suárez Ruiz [Mon, 12 Aug 2019 10:10:41 +0000 (12:10 +0200)]
Added missing NamedSizes for GTK (#7130)

4 years agoMerge branch '4.2.0'
Stephane Delcroix [Mon, 12 Aug 2019 08:38:25 +0000 (10:38 +0200)]
Merge branch '4.2.0'

4 years agoStop the madness (#7123)
kingces95 [Sat, 10 Aug 2019 21:02:41 +0000 (11:02 -1000)]
Stop the madness (#7123)

4 years agoAdd ProfilePage (#7112)
kingces95 [Fri, 9 Aug 2019 20:23:11 +0000 (10:23 -1000)]
Add ProfilePage (#7112)

4 years agoRename InitializationFlags -> ActivationFlags (#7084)
kingces95 [Fri, 9 Aug 2019 20:22:43 +0000 (10:22 -1000)]
Rename InitializationFlags -> ActivationFlags (#7084)

* InitFlags -> ActivationFlags

* renames

4 years ago[UITest] Fix 2951 and moved extension method to be more visible (#7108)
Shane Neuville [Fri, 9 Aug 2019 17:56:00 +0000 (11:56 -0600)]
[UITest] Fix 2951 and moved extension method to be more visible (#7108)

* [UITest] Fix 2951 and moved extension method to be more visible

* fix spacing

* tabs