platform/upstream/dotnet/runtime.git
2 years ago[release/6.0] Update SAN test to account for OpenSSL 3 changes (#63951)
github-actions[bot] [Mon, 7 Feb 2022 18:58:38 +0000 (10:58 -0800)]
[release/6.0] Update SAN test to account for OpenSSL 3 changes (#63951)

* Update SAN test to account for OpenSSL 3 changes.

* Fix test for browser

Co-authored-by: Kevin Jones <kevin@vcsjones.com>
2 years agoserialize SendPacketsAsync tests (#63888)
Anton Firszov [Mon, 7 Feb 2022 18:56:51 +0000 (19:56 +0100)]
serialize SendPacketsAsync tests (#63888)

2 years ago[release/6.0] [wasm][debugger] Fixing error after receiving loaded_files = null ...
Thays Grazia [Mon, 7 Feb 2022 18:46:41 +0000 (15:46 -0300)]
[release/6.0] [wasm][debugger] Fixing error after receiving loaded_files = null (#63739)

* Backporting dotnet#63591

* Fix merge error.

* Fixing html page.

2 years ago[source-build][mono] Do not build Microsoft.NET.Runtime.MonoTargets.Sdk (#63701)
github-actions[bot] [Mon, 7 Feb 2022 18:46:13 +0000 (10:46 -0800)]
[source-build][mono] Do not build Microsoft.NET.Runtime.MonoTargets.Sdk (#63701)

* Does not build due to missing Microsoft.DotNet.CilStrip.Sources
  external dependency in source-build.

* Package is not needed for source-build anyway.

Co-authored-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
2 years ago[release/6.0] Support Single-file executable in Windows 7 (#63533)
NN [Mon, 7 Feb 2022 18:45:35 +0000 (20:45 +0200)]
[release/6.0] Support Single-file executable in Windows 7 (#63533)

* Delay load winrt

* Trivial change to rerun tests

Co-authored-by: Vladimir Sadov <vsadov@microsoft.com>
2 years agobackport 62601 (#62816)
Thays Grazia [Mon, 7 Feb 2022 18:42:11 +0000 (15:42 -0300)]
backport 62601 (#62816)

2 years ago[release/6.0] Update helix queues (#64721)
Santiago Fernandez Madero [Sat, 5 Feb 2022 03:00:23 +0000 (19:00 -0800)]
[release/6.0] Update helix queues (#64721)

2 years agoUpdate branding to 6.0.3 (#64644)
vseanreesermsft [Thu, 3 Feb 2022 00:07:51 +0000 (16:07 -0800)]
Update branding to 6.0.3 (#64644)

* Update branding to 6.0.3

* Clear list of OOB packages built on the branch and always build ref pack

Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
2 years ago[release/6.0] Fix Crossgen2 bug #61104 and add regression test (#64027)
github-actions[bot] [Thu, 20 Jan 2022 17:21:19 +0000 (18:21 +0100)]
[release/6.0] Fix Crossgen2 bug #61104 and add regression test (#64027)

* Fix issue #61104 and add regression test

The issue tracks the runtime regression failure where
Crossgen2-compiled app is unable to locate a type with non-ASCII
characters in its name. The failure was caused by the fact that
Crossgen2 was incorrectly zero-extended the individual characters
when calculating the hash whereas runtime is sign-extending them.

Thanks

Tomas

* Simplify the regression test per Anton's PR feedback

Co-authored-by: Tomas <trylek@microsoft.com>
2 years ago[wasm][debugger] Missing test files (#63148)
Thays Grazia [Fri, 14 Jan 2022 19:00:23 +0000 (16:00 -0300)]
[wasm][debugger] Missing test files (#63148)

Adding test files that were not added on release 6.0 by mistake.

2 years agoFix the MacOS remote unwinder for VS4Mac (#63405)
Mike McLaughlin [Thu, 13 Jan 2022 18:20:13 +0000 (10:20 -0800)]
Fix the MacOS remote unwinder for VS4Mac (#63405)

* Fix the MacOS remote unwinder for VS4Mac

The wrong module was being passed to the remote unwinder because the load bias for shared modules
was being calculated incorrectly.

Issue: https://github.com/dotnet/runtime/issues/63309

* Fix native frame unwind in syscall on arm64 for VS4Mac crash report

From PR in main: https://github.com/dotnet/runtime/pull/63598

Add arm64 version of StepWithCompactNoEncoding for syscall leaf node wrappers that have compact encoding of 0.

Fix ReadCompactEncodingRegister so it actually decrements the addr.

Change StepWithCompactEncodingArm64 to match what MacOS libunwind does for framed and frameless stepping.

arm64 can have frames with the same SP (but different IPs). Increment SP for this condition so createdump's unwind
loop doesn't break out on the "SP not increasing" check and the frames are added to the thread frame list in the
correct order.

Add getting the unwind info for tail called functions like this:

__ZL14PROCEndProcessPvji:
   36630:       f6 57 bd a9     stp     x22, x21, [sp, #-48]!
   36634:       f4 4f 01 a9     stp     x20, x19, [sp, #16]
   36638:       fd 7b 02 a9     stp     x29, x30, [sp, #32]
   3663c:       fd 83 00 91     add     x29, sp, #32
...
   367ac:       e9 01 80 52     mov     w9, #15
   367b0:       7f 3e 02 71     cmp     w19, #143
   367b4:       20 01 88 1a     csel    w0, w9, w8, eq
   367b8:       2e 00 00 94     bl      _PROCAbort
_TerminateProcess:
-> 367bc:       22 00 80 52     mov     w2, #1
   367c0:       9c ff ff 17     b       __ZL14PROCEndProcessPvji

The IP (367bc) returns the (incorrect) frameless encoding with nothing on the stack (uses an incorrect LR to unwind). To fix this
get the unwind info for PC -1 which points to PROCEndProcess with the correct unwind info. This matches how lldb unwinds this frame.

Always address module segment to IP lookup list instead of checking the module regions.

Strip pointer authentication bits on PC/LR.

2 years ago[release/6.0] Use "read" to fetch misaligned 64bit values from bundle header (#63519)
github-actions[bot] [Thu, 13 Jan 2022 16:47:36 +0000 (08:47 -0800)]
[release/6.0] Use "read" to fetch misaligned 64bit values from bundle header (#63519)

* Use "read" to fetch misaligned 64bit values

* remove read_direct

* rename read() -> read_byte()

Co-authored-by: vsadov <8218165+VSadov@users.noreply.github.com>
2 years ago[release/6.0] Build all packages when in source-build (#63653)
Santiago Fernandez Madero [Thu, 13 Jan 2022 00:24:11 +0000 (16:24 -0800)]
[release/6.0] Build all packages when in source-build (#63653)

2 years agoFix custom JsonConverterFactories not working with transitive type/property declarati...
github-actions[bot] [Mon, 10 Jan 2022 23:34:53 +0000 (15:34 -0800)]
Fix custom JsonConverterFactories not working with transitive type/property declarations. (#62643)

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
2 years ago[release/6.0] 1388 xml serializer assembly load context awareness (#61266)
github-actions[bot] [Mon, 10 Jan 2022 23:32:03 +0000 (15:32 -0800)]
[release/6.0] 1388 xml serializer assembly load context awareness (#61266)

* Generate dynamic serialization assembly in the appropriate ALC, and don't keep any hard refs to types that could prevent unloading.

* Add small test for ALC unloading.

* PR feedback; Move into TempAssembly; Strong/Weak lookup tables; Test refinement

* Refining TempAssembly cache; Reflection-based fix; Test corrections

* Mono/wasm test fixup

* Ensure that serializers from XmlMappings don't run afoul of collectible ALCs.

* PR feedback

* Unloadable contexts not yet supported in Mono.

* Fix trimming of types for XmlSerializer tests that got moved out of main test assembly.

* Encapsulating the duality of dealing with unloadable ALC instead of rewriting similar code everywhere.

* Missed new file in last commit.

* Compilation bug not seen locally.

* Perf improvement.

* Remove extraneous line. Test feedback.

* Fix unloadability (#58948)

There is a bug in AppDomain::FindAssembly code path that iterates over
the domain assemblies. The iteration loop leaves the refcount of the
LoaderAllocator related to the returned DomainAssembly bumped, but
nothing ever decrements it. So when a code that needs to be unloaded
ends up in that code path, all the managed things like managed
LoaderAllocator, LoaderAllocatorScout are destroyed, but the unloading
doesn't complete due to the refcount.

We have never found it before as this code path is never executed in any
of the coreclr tests even with unloadability testing option.

(cherry picked from commit 8b38c1973eeaf1c13e8d2729ab1b1fe1a7cf9a5b)

Co-authored-by: Steve Molloy <smolloy@microsoft.com>
Co-authored-by: Jan Vorlicek <jan.vorlicek@volny.cz>
2 years agoMake delegates unsupported by JsonSerializer (#63514)
github-actions[bot] [Mon, 10 Jan 2022 22:35:26 +0000 (14:35 -0800)]
Make delegates unsupported by JsonSerializer (#63514)

Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
2 years agoFix NETStandard library using JSON source gen (#63520)
Eric StJohn [Mon, 10 Jan 2022 22:35:08 +0000 (14:35 -0800)]
Fix NETStandard library using JSON source gen (#63520)

NETStandard libraries using JSON source gen would fail to load on
.NETCore due to missing IsExternalInit in the assembly.

On .NETCore this is defined, whereas on .NETStandard JSON carries an
internal copy.  The compiler emits references to the internal type when
a NETStandard library calls init-only setters in JSON types, but these
references are not satisfied when the library runs on .NETCore.

Fix this by adding a type forward to JSON for the IsExternalInit type.

2 years ago[release/6.0] Fix GENERIC_MATH_FEATURE by making sure we always choose the right...
Santiago Fernandez Madero [Mon, 10 Jan 2022 17:11:21 +0000 (09:11 -0800)]
[release/6.0] Fix GENERIC_MATH_FEATURE by making sure we always choose the right ref (#63525)

2 years ago[release/6.0] Suppress SendPacketsElement_FileStreamMultiPartMixed_MultipleFileStream...
github-actions[bot] [Sat, 8 Jan 2022 20:14:51 +0000 (12:14 -0800)]
[release/6.0] Suppress SendPacketsElement_FileStreamMultiPartMixed_MultipleFileStreams_Success test on Windows 11 (#63526)

2 years agodisable tests unstable on Windows 11 (#63527)
github-actions[bot] [Sat, 8 Jan 2022 03:38:30 +0000 (20:38 -0700)]
disable tests unstable on Windows 11 (#63527)

Co-authored-by: wfurt <tweinfurt@yahoo.com>
2 years ago[wasm] Backport build improvements, and fixes from #61581 (#62757)
Ankit Jain [Sat, 8 Jan 2022 03:36:51 +0000 (22:36 -0500)]
[wasm] Backport build improvements, and fixes from #61581 (#62757)

* [wasm] Disable native strip for tests

* [wasm] improve fixup of symbol names

* [wasm] Extract BuildProject params to BuildProjectOptions record

* [wasm] Add WasmBuild.sln

* [wasm] Add `@(NativeFileReference)` to up-to-date check items for VS

VS does its own tracking of inputs/outputs too, and needs to be told
about `@(NativeFileReference)` items, so a build can get triggered with
F5 when a native file changes.

Based on https://github.com/dotnet/project-system/blob/main/docs/up-to-date-check.md?rgh-link-date=2021-10-26T13%3A23%3A47Z#up-to-date-check

Fixes https://github.com/dotnet/runtime/issues/60862

* MonoAOTCompiler: log failed output as error

* [wasm] Improve error message when runtime pack cannot be found

* [wasm] PInvokeTableGenerator: don't fail on errors in reading custom attributes

Inspired by https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1364890?src=WorkItemMention&src-action=artifact_link

Works around a NRE in CustomAttributeData.AttributeType because it's
ConstructorInfo is null.
The mono side issue: https://github.com/mono/mono/issues/15340

* replace '.', '-', and '+' with '_' instead of their code

2 years agoInclude properties on records for (de)serialization in source-gen (#63454)
github-actions[bot] [Sat, 8 Jan 2022 03:35:54 +0000 (20:35 -0700)]
Include properties on records for (de)serialization in source-gen (#63454)

Co-authored-by: Layomi Akinrinade <layomia@gmail.com>
2 years ago[release/6.0] Fix TimeSpan support in sourcegen (#62191)
github-actions[bot] [Sat, 8 Jan 2022 03:35:01 +0000 (20:35 -0700)]
[release/6.0] Fix TimeSpan support in sourcegen (#62191)

* fix TimeSpan support in sourcegen

* address feedback

* Address feedback

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
2 years agoSuppress warnings about [Obsolete] member usage in JSON src-gen'd code (#63501)
github-actions[bot] [Sat, 8 Jan 2022 03:33:37 +0000 (20:33 -0700)]
Suppress warnings about [Obsolete] member usage in JSON src-gen'd code (#63501)

Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
2 years agoFix bugs with generation for ctor param default values (#62798) (#63493)
Layomi Akinrinade [Sat, 8 Jan 2022 03:32:08 +0000 (22:32 -0500)]
Fix bugs with generation for ctor param default values (#62798) (#63493)

* Fix bugs with generation for ctor param default values

* Address review feedback

* Address feedback

2 years ago[release/6.0] Fix System.Object serialization with custom number handling (#62193)
github-actions[bot] [Sat, 8 Jan 2022 01:01:06 +0000 (17:01 -0800)]
[release/6.0] Fix System.Object serialization with custom number handling (#62193)

* Fix System.Object serialization with custom number handling

* fix typos

* Address feedback

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
2 years ago[release/6.0] Port test-only test fixes (#63507)
Dan Moseley [Fri, 7 Jan 2022 23:33:19 +0000 (16:33 -0700)]
[release/6.0] Port test-only test fixes (#63507)

* Outerloop ports

* Port EFS test fix

* Partially disable test (#59760)

* fix build

2 years ago[release/6.0] Add explicit null-check for tailcalls to VSD (#62769)
github-actions[bot] [Fri, 7 Jan 2022 19:00:15 +0000 (11:00 -0800)]
[release/6.0] Add explicit null-check for tailcalls to VSD (#62769)

* Add explicit null-check for tailcalls to VSD

There is already a comment that this is necessary, but it is only being
done for x86 tailcalls via jit helper. Do it for normal tailcalls to VSD
as well.

Fix #61486

* Revert cleanup to make potential backport easier

Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
2 years ago[release/6.0] Ensure UserSecretsIdAttribute is added to assembly (#63423)
Eric Erhardt [Fri, 7 Jan 2022 18:45:06 +0000 (12:45 -0600)]
[release/6.0] Ensure UserSecretsIdAttribute is added to assembly (#63423)

* [release/6.0] Ensure UserSecretsIdAttribute is added to assembly

When Microsoft.Extensions.Configuration.UserSecrets is referenced transitively, for example through Extensions.Hosting, the UserSecretsIdAttribute isn't getting added to the built assembly. This is because the logic is contained in a `build` folder which is excluded by the dependency from Extensions.Hosting.

The fix is to move the logic to `buildTransitive`, so it gets picked up by NuGet.

Note, we also need to service the Extensions.Hosting package so it references the new UserSecrets version by default.

Fix #63246

* Add a binding redirect in order to fix test failure on netfx.

2 years ago[release/6.0] Undo breaking change in 6.0 in environment variable configuration prefi...
github-actions[bot] [Fri, 7 Jan 2022 16:39:43 +0000 (09:39 -0700)]
[release/6.0] Undo breaking change in 6.0 in environment variable configuration prefix support (#62916)

* Undo breaking change in 6.0 With environment variable configuration provider, undo support for normalizing prefix using double underscore

* Update src/libraries/Microsoft.Extensions.Configuration.EnvironmentVariables/tests/EnvironmentVariablesTest.cs

* Update src/libraries/Microsoft.Extensions.Configuration.EnvironmentVariables/tests/EnvironmentVariablesTest.cs

* update tests, not windows specific

* Update fix for 6.0.x servicing.

Co-authored-by: Maryam Ariyan <maryam.ariyan@microsoft.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
2 years ago[release/6.0] Fix setting timestamp on Windows on readonly files (#62922)
Adam Sitnik [Fri, 7 Jan 2022 16:38:04 +0000 (17:38 +0100)]
[release/6.0] Fix setting timestamp on Windows on readonly files (#62922)

* Fix setting timestamp on Windows on readonly files (#62638)

# Conflicts:
# src/libraries/System.IO.FileSystem/tests/Base/BaseGetSetTimes.cs

* make it compile

* fix build

Co-authored-by: Dan Moseley <danmose@microsoft.com>
2 years ago[release/6.0] WinHttp: always read HTTP/2 streams to the end (#63346)
github-actions[bot] [Fri, 7 Jan 2022 16:37:14 +0000 (09:37 -0700)]
[release/6.0] WinHttp: always read HTTP/2 streams to the end (#63346)

* tests

* enable WINHTTP_OPTION_REQUIRE_STREAM_END on request handles

* set WINHTTP_OPTION_REQUIRE_STREAM_END on the session handle

Co-authored-by: antonfirsov <antonfir@gmail.com>
2 years ago[release/6.0] Making user secrets optional by default (#62917)
github-actions[bot] [Thu, 6 Jan 2022 23:55:37 +0000 (16:55 -0700)]
[release/6.0] Making user secrets optional by default (#62917)

* Making user secrets optional by default

* update test

* Update fix for 6.0.x servicing.

Co-authored-by: Maryam Ariyan <maryam.ariyan@microsoft.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
2 years ago[release/6.0] Fix XXHash for stripe size (#61923)
github-actions[bot] [Thu, 6 Jan 2022 20:04:56 +0000 (12:04 -0800)]
[release/6.0] Fix XXHash for stripe size (#61923)

* Fix XXHash for stripe size

* Add servicing properties to System.IO.Hashing

* Run package validation against 6.0.0 packages and enable it for IO Hashing.

Co-authored-by: Tornhoof <tornhoof@gmail.com>
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
2 years ago[release/6.0] Change macOS activatin injection failure handling (#63393)
Jan Vorlicek [Thu, 6 Jan 2022 19:07:37 +0000 (20:07 +0100)]
[release/6.0] Change macOS activatin injection failure handling (#63393)

Backport of #59045 to release/6.0

The pthread_kill can fail with ENOTSUP on macOS when the target thread
is a dispatch queue thread. Instead of aborting the process, it is
better to fail to inject the activation and rely on return address
hijacking and other means of syncing with GC.

2 years agoUnify the FlushProcessWriteBuffers mechanism for macOS arm64 / x64 (#63301)
github-actions[bot] [Thu, 6 Jan 2022 18:46:06 +0000 (10:46 -0800)]
Unify the FlushProcessWriteBuffers mechanism for macOS arm64 / x64 (#63301)

The macOS arm64 was using a new mechanism to implement FlushProcessWriteBuffers
because the original one based on a wired memory page doesn't work on arm64.
We have seen people hitting problems with the wired memory page allocation on
x64 in the past due to the fact that wired memory is a scarce resource and
in some cases, e.g. in presence of apps that greedily grab all of the available
wired memory pages, we were unable to initialize coreclr and execute any .NET
application.

This change switches x64 to the same mechanism as arm64 to prevent that issue
from happening and updates the minimum supported x64 macOS to 10.14. That's the
version required for the new APIs the change is using. Apple stopped supporting
10.13 a year ago anyways.

Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
2 years agoFix named mutexes on OSX to work between arm64 and emulated x64 processes (#62765)
Koundinya Veluri [Thu, 6 Jan 2022 18:14:27 +0000 (10:14 -0800)]
Fix named mutexes on OSX to work between arm64 and emulated x64 processes (#62765)

- The page size is different between arm64 processes and emulated x64 processes
- The shared memory file size is set to the page size and there was a strict check on the file size, leading to an exception from the second process of a different arch that tries to share the same mutex
- Made the file size check less strict, and allowed an arch to increase but not decrease the file size such that it can be mapped at page size granularity
- Fix for https://github.com/dotnet/runtime/issues/62140 in main

2 years agoFix bug where we reference the entry #0 in the pinned plug queue (#60966) (#63351)
Andrew Au [Thu, 6 Jan 2022 18:14:17 +0000 (10:14 -0800)]
Fix bug where we reference the entry #0 in the pinned plug queue (#60966) (#63351)

We reference entry #0 in the pinned plug queue even if there are no pinned plugs at all and thus the pinned plug queue contains left-over data from the mark phase.

The fix is to initialize saved_pinned_plug_index to a value that is invalid as a pinned plug queue index, and only use saved_pinned_plug_index as an index if  is valid.

Co-authored-by: Peter Sollich <petersol@microsoft.com>
2 years ago[release/6.0] bump sourcebuild leg timeout (#63298)
Santiago Fernandez Madero [Wed, 5 Jan 2022 19:08:12 +0000 (13:08 -0600)]
[release/6.0] bump sourcebuild leg timeout (#63298)

2 years ago[release/6.0] Fix build with Clang 13 (#63314)
Jan Vorlicek [Tue, 4 Jan 2022 22:51:52 +0000 (23:51 +0100)]
[release/6.0] Fix build with Clang 13 (#63314)

* Fix clang 13 induced runtime issues (#62170)

The clang 13 optimizer started to assume that "this" pointer is always
properly aligned. That lead to elimination of some code that was actually
needed.
It also takes pointer aliasing rules more strictly in one place in jit.
That caused the optimizer to falsely assume that a callee with an argument
passed by reference is not modifying that argument and used a stale
copy of the original value at the caller site.

This change fixes both of the issues. With this fix, runtime compiled
using clang 13 seems to be fully functional.

* Fix build with clang 13 (#60328)

2 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20211214.2 (#63007)
dotnet-maestro[bot] [Mon, 3 Jan 2022 16:53:52 +0000 (08:53 -0800)]
Update dependencies from https://github.com/dotnet/arcade build 20211214.2 (#63007)

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21609.4 -> To Version 6.0.0-beta.21614.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2 years agofix issue where HTTP2 connection could be scavenged but not disposed (#62236)
github-actions[bot] [Mon, 3 Jan 2022 16:32:20 +0000 (10:32 -0600)]
fix issue where HTTP2 connection could be scavenged but not disposed (#62236)

Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>
2 years ago[wasm][release/6.0] Reduce number of calls to setTimer (#62705)
Marek Fišera [Mon, 3 Jan 2022 02:26:16 +0000 (03:26 +0100)]
[wasm][release/6.0] Reduce number of calls to setTimer (#62705)

* Port changes to the TimerQueue from https://github.com/dotnet/runtime/pull/62433.

Test is only manual. Xharness version on this branch
triggers timer queue in a way that makes the test useless.

Co-authored-by: Pavel Savara <pavelsavara@microsoft.com>
* Replace main method with plain static method for running timer tests.

* Rename index.html to simple.html to avoid collision with generated index.html for unit tests.

Co-authored-by: Pavel Savara <pavelsavara@microsoft.com>
2 years ago[release/6.0] Do not promote struct locals with holes (#62738)
github-actions[bot] [Mon, 3 Jan 2022 02:20:00 +0000 (20:20 -0600)]
[release/6.0] Do not promote struct locals with holes (#62738)

* Make sure the combined field size matches the struct size

* Fix the condition

* Update test and include containHoles condition

Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
2 years ago[release/6.0] Add runtime-community.yml pipeline and add s390x job (#62808)
Jo Shields [Mon, 3 Jan 2022 02:18:14 +0000 (21:18 -0500)]
[release/6.0] Add runtime-community.yml pipeline and add s390x job (#62808)

* Add runtime-community.yml pipeline and add s390x job (#60255)

(cherry picked from commit 5f3062d81a5caa444308937539ad136b72218c29)

* Don't include s390x in coreclr outerloop runs (#60351)

This was a copy-paste mistake, see https://github.com/dotnet/runtime/pull/60255#issuecomment-942539639

(cherry picked from commit 49cf05cdea3baa22592d08d74ce2f0e2c32786a7)

* Enable for release/*.* branch, not just main

* Fix condition for dependOnEvaluatePaths for runtime-community pipeline (#60552)

It was missed where we set a default value for that variable.

(cherry picked from commit 157a8b5f72f69e18fbd5ec1f549954e3a28f8f71)

* [mono] For cross builds targeting s390x use proper objcopy (#57566)

Co-authored-by: Stefan Schulze Frielinghaus <stefansf@linux.ibm.com>
(cherry picked from commit 616ace39bb8d9431097b433c31caca6dd934d349)

* Use live-built corehost on s390x for creating testhost (#58952)

This allows consuming the dotnet host that was just built instead of relying on a downloaded one.
We need to move the `host` subset build before the `libs` subset so that the artifacts are available before externals.csproj runs.

(cherry picked from commit cab3a63fe3b9810b801ea6a7d9fb958d1af5e380)

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: stefan-sf-ibm <73470131+stefan-sf-ibm@users.noreply.github.com>
2 years ago[release/6.0] Use Ubuntu 18.04 and dotnet-buildtools-prereq docker images for enterpr...
github-actions[bot] [Mon, 3 Jan 2022 02:16:28 +0000 (20:16 -0600)]
[release/6.0] Use Ubuntu 18.04 and dotnet-buildtools-prereq docker images for enterprise linux pipeline (#63014)

* Use Ubuntu 18.04 1ES pools and dotnet-buildtools-prereq docker images for enterprise linux pipeline

Ubuntu 16.04 is no longer available on Azure Pipelines, move to 18.04 on 1ES pool and the Docker images from dotnet-buildtools-prereq.

* Workaround https://github.com/dotnet/runtime/issues/34649

* Use servicing 1ES pool

* Fix property name for turning off PGO data

It was changed in main with https://github.com/dotnet/runtime/commit/4682098d3a435d3f88942ee9e5c6fd426555963a

* Fix property value

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
2 years ago[release/6.0] Don't create multiple large files at the same time (#63032)
David Cantú [Fri, 31 Dec 2021 04:10:51 +0000 (20:10 -0800)]
[release/6.0] Don't create multiple large files at the same time (#63032)

* Move NoInt32OverflowInTheBufferingLogic to OuterLoop and address pending feedback (#60606)

* Don't create multiple large files at the same time (#62519)

* move existing large file tests into a separate type (no code changes)

* don't run the large file tests in parallel

* use FileOptions.DeleteOnClose to ensure that each test removes it's own file

use single large file to test File.ReadAllBytes and ile.ReadAllBytesAsync for both limits

* Fix DisableParallelization build issue

* Apply suggestions from code review

Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
* Update src/libraries/System.IO.FileSystem/tests/LargeFileTests.cs

Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
* Notepad with uppercase (#62487)

Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
2 years ago[release/6.0] Fixing a possible null reference error in WebSocket deflate. (#62716)
github-actions[bot] [Thu, 23 Dec 2021 22:42:38 +0000 (15:42 -0700)]
[release/6.0] Fixing a possible null reference error in WebSocket deflate. (#62716)

* Fixing a possible null reference error in websocket deflate functionality.

* Style feedback.

Co-authored-by: Ivan Zlatanov <ivan@zlatanov.net>
2 years agoRPM package needs to create host symlink (#62925)
Nikola Milosavljevic [Fri, 17 Dec 2021 17:04:26 +0000 (09:04 -0800)]
RPM package needs to create host symlink (#62925)

2 years agoFix createdump failure on MacOS Monterey version 12.0.1. (#62548)
Mike McLaughlin [Fri, 17 Dec 2021 01:39:42 +0000 (17:39 -0800)]
Fix createdump failure on MacOS Monterey version 12.0.1. (#62548)

2 years ago[release/6.0] Fixing regression for AuthType.Anonymous which leads to a NullReferenc...
github-actions[bot] [Thu, 16 Dec 2021 20:56:06 +0000 (12:56 -0800)]
[release/6.0] Fixing regression for AuthType.Anonymous  which leads to a NullReferenceException be thrown. (#62824)

* Fixing regression for AuthType.Anonymous which leads to a NullReferenceException be thrown.

* Adding a unitTest to protect against a regression

* Ensure System.DirectoryServices.Protocols package gets built.

Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com>
2 years agoFix Microsoft.VisualBasic.Core file version (#62848) (#62908)
Santiago Fernandez Madero [Thu, 16 Dec 2021 19:00:11 +0000 (13:00 -0600)]
Fix Microsoft.VisualBasic.Core file version (#62848) (#62908)

2 years agoInclude Microsoft.NETCore.App.Ref pack as part of 6.0.2 release (#62859)
Santiago Fernandez Madero [Thu, 16 Dec 2021 17:02:46 +0000 (11:02 -0600)]
Include Microsoft.NETCore.App.Ref pack as part of 6.0.2 release (#62859)

* Include Microsoft.NETCore.App.Ref pack as part of 6.0.2 release

* Update eng/Versions.props

2 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20211209.4 (#62799)
dotnet-maestro[bot] [Thu, 16 Dec 2021 16:52:26 +0000 (10:52 -0600)]
Update dependencies from https://github.com/dotnet/arcade build 20211209.4 (#62799)

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21560.2 -> To Version 6.0.0-beta.21609.4

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2 years ago[release/6.0] Fixes #62167. WriteAsync may truncate data if called after .Advance...
github-actions[bot] [Thu, 16 Dec 2021 16:48:22 +0000 (10:48 -0600)]
[release/6.0] Fixes #62167. WriteAsync may truncate data if called after .Advance(int) (#62348)

* Fixes #62167. WriteAsync was bugged when writing multiple segments if called after an .Advance(int)

* Add packaging changes to IO Pipelines

Co-authored-by: Kuinox <github@kuinox.io>
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
2 years agoProtecting send message to debugger if it's disables (#62210)
github-actions[bot] [Wed, 15 Dec 2021 20:06:52 +0000 (14:06 -0600)]
Protecting send message to debugger if it's disables (#62210)

Co-authored-by: DESKTOP-GEPIA6N\Thays <thaystg@gmail.com>
2 years ago[release/6.0] [HTTP/3] Fixed stress (#60723)
Anton Firszov [Wed, 15 Dec 2021 19:30:45 +0000 (20:30 +0100)]
[release/6.0] [HTTP/3] Fixed stress (#60723)

* Update msquic

* Remove exclusion of 100-continue

2 years ago<EnablePreviewFeatures> for HttpStress (#60682)
github-actions[bot] [Wed, 15 Dec 2021 19:29:54 +0000 (13:29 -0600)]
<EnablePreviewFeatures> for HttpStress (#60682)

Co-authored-by: Anton Firszov <Anton.Firszov@microsoft.com>
2 years agoBackporting part of pr 62278 (#62543)
Thays Grazia [Wed, 15 Dec 2021 19:23:38 +0000 (16:23 -0300)]
Backporting part of pr 62278 (#62543)

2 years agoBackport PR 60983 (#62283)
Thays Grazia [Wed, 15 Dec 2021 19:20:57 +0000 (16:20 -0300)]
Backport PR 60983 (#62283)

2 years ago[release/6.0] Cache LastAccessed during MemoryCache compaction (#62286)
Eric Erhardt [Wed, 15 Dec 2021 19:19:12 +0000 (13:19 -0600)]
[release/6.0] Cache LastAccessed during MemoryCache compaction (#62286)

* Cache LastAccessed during MemoryCache compaction (#61187)

* Cache LastAccessed during MemoryCache compaction

During cache compaction, we are sorting entries based on their LastAccessed time. However, since the cache entries can still be used concurrently on other threads, the LastAccessed time may be updated in the middle of sorting the entries. This leads to exceptions in a background thread, crashing the process.

The fix is to cache the LastAccessed time outside of the entry when we are adding it to the list. This will ensure the time is stable during the compaction process.

Fix #61032

* Update fix for 6.0.x servicing.

1. Remove the dependency on ValueTuple and use a custom struct instead.
2. Add servicing package changes.
3. In the tests, move the DisableParallelization collection declaration in the test project, since it is only in "Common" in main.

2 years agoMerge pull request #62403 from dotnet/backport/pr-62397-to-release/6.0
Santiago Fernandez Madero [Wed, 15 Dec 2021 19:10:30 +0000 (13:10 -0600)]
Merge pull request #62403 from dotnet/backport/pr-62397-to-release/6.0

[release/6.0] Fix re-initialization of hash objects on CNG.

2 years agoMerge pull request #62789 from vseanreesermsft/internal-merge-6.0-2021-12-14-0948
Santiago Fernandez Madero [Wed, 15 Dec 2021 19:09:40 +0000 (13:09 -0600)]
Merge pull request #62789 from vseanreesermsft/internal-merge-6.0-2021-12-14-0948

Merging internal commits for release/6.0

2 years ago[release/6.0] Use 1ES pool instead of deprecated windows image in "Publish to Build...
github-actions[bot] [Wed, 15 Dec 2021 18:46:47 +0000 (12:46 -0600)]
[release/6.0] Use 1ES pool instead of deprecated windows image in "Publish to Build Asset Registry" job (#62839)

* Use 1ES pool instead of deprecated windows image in "Publish to Build Asset Registry" job

* Use servicing 1ES pool

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
2 years ago[release/6.0] Port #58410: Fix zero initialization use of "initReg" (#62207)
Bruce Forstall [Wed, 15 Dec 2021 18:45:48 +0000 (10:45 -0800)]
[release/6.0] Port #58410: Fix zero initialization use of "initReg" (#62207)

If the only local is an enregistered must-init struct,
we were setting `initReg` to its register (in this case, `xmm0`).
However, `initReg` is expected to be an integer register. In the
test case, with GS cookie stress, the GS cookie code asserted
that `initReg` was an integer register, but it wasn't.

The fix is the change the condition to use the actual register
assigned to the variable (in this case, `xmm0`), not the variable
type (here, `TYP_STRUCT`).

No spmi asm diffs.

Fixes #57911

2 years agoFix method HttpHeadersNonValidated uses to get HeaderDescriptor (#62194)
github-actions[bot] [Wed, 15 Dec 2021 18:45:10 +0000 (12:45 -0600)]
Fix method HttpHeadersNonValidated uses to get HeaderDescriptor (#62194)

We have two non-public methods for getting a HeaderDescriptor from a string name, one static on HeaderDescriptor and one instance on HttpHeaders.  HttpHeadersNonValidated was using the former, but this then doesn't take into account custom logic used by HttpHeaders in other methods, like TryAddWithoutValidation, which means some methods on HttpHeadersNonValidated can't find the corresponding headers.

Co-authored-by: Stephen Toub <stoub@microsoft.com>
2 years ago[release/6.0] Fix calling NLS with Cultures has alternative sort names (#62155)
github-actions[bot] [Wed, 15 Dec 2021 18:41:04 +0000 (12:41 -0600)]
[release/6.0] Fix calling NLS with Cultures has alternative sort names (#62155)

* Fix calling NLS with Cultures has alternative sort names

* Exclude the test for the browser

* Update src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.Nls.cs

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
* Fix test typo

Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
2 years ago[release/6.0] Allow runtimeconfig StartupHooks and Environment StartupHooks to both...
github-actions[bot] [Wed, 15 Dec 2021 18:40:04 +0000 (12:40 -0600)]
[release/6.0] Allow runtimeconfig StartupHooks and Environment StartupHooks to both be present (#62124)

* Allow configProperties "STARTUP_HOOKS" and env "DOTNET_STARTUP_HOOKS" to both be present

* Fix duplicate_property_error property names to reflect the actual duplicate

* fixup! Allow configProperties "STARTUP_HOOKS" and env "DOTNET_STARTUP_HOOKS" to both be present

* Enforce env startup hook precedence over runtimeconfig startup hooks

Co-authored-by: Tom de Goede <tom.degoede@afas.nl>
2 years ago[release/6.0] [HTTP] Scavenge fix (#62008)
github-actions[bot] [Wed, 15 Dec 2021 18:39:20 +0000 (12:39 -0600)]
[release/6.0] [HTTP] Scavenge fix (#62008)

* Guard pool scavenging callback from parallel execution when it takes longer than the timer interval gets triggered

* Dispose connection from the pool in a serate task to not to block the caller (scavenge timer callback)

* feedback

Co-authored-by: ManickaP <mapichov@microsoft.com>
2 years agoThe DestroyStructure API passes null to the IL marshaller for managed valuetypes...
github-actions[bot] [Wed, 15 Dec 2021 18:38:40 +0000 (12:38 -0600)]
The DestroyStructure API passes null to the IL marshaller for managed valuetypes. This is an issue with field marshallers of nested non-blittable types. (#62002)

Co-authored-by: Aaron Robinson <arobins@microsoft.com>
2 years agoEnvironment variable should override property for gcServer. (#61969)
github-actions[bot] [Wed, 15 Dec 2021 18:35:44 +0000 (12:35 -0600)]
Environment variable should override property for gcServer. (#61969)

Add tests for the scenario.

Co-authored-by: Aaron Robinson <arobins@microsoft.com>
2 years agoCheck for time-sensitive work when worker thread starvation is ongoing (#61931)
Koundinya Veluri [Wed, 15 Dec 2021 18:34:44 +0000 (10:34 -0800)]
Check for time-sensitive work when worker thread starvation is ongoing (#61931)

- Otherwise timer callbacks may not run when worker threads are continually starved
- The change is similar to what was done in CoreCLR's native thread pool
- Fixes https://github.com/dotnet/runtime/issues/61804

2 years ago[release/6.0] disable sending NT Authority in TLS handshake if specific trust was...
github-actions[bot] [Wed, 15 Dec 2021 18:29:01 +0000 (12:29 -0600)]
[release/6.0] disable sending NT Authority in TLS handshake if specific trust was specified (#61713)

* diable sending NT Authority if specific trust was specified

* feedback from review

* add missing file

* Apply suggestions from code review

Co-authored-by: Cory Nelson <phrosty@gmail.com>
* one more style update

Co-authored-by: wfurt <tweinfurt@yahoo.com>
Co-authored-by: Cory Nelson <phrosty@gmail.com>
2 years ago[release/6.0] Disable poisoning for large structs (#61601)
github-actions[bot] [Wed, 15 Dec 2021 18:27:03 +0000 (12:27 -0600)]
[release/6.0] Disable poisoning for large structs (#61601)

* Disable poisoning for large structs

For very large structs (> 64K in size) poisoning could end up generating
instructions requiring larger local var offsets than we can handle. This
hits IMPL_LIMIT that throws InvalidProgramException. Turn off poisoning
for larger structs that require more than 16 movs to also avoid the
significant code bloat by the singular movs.

This is a less risky version of #61521 for backporting to .NET 6.

Fix #60852

* Run jit-format

* Add regression test

* Update src/coreclr/jit/codegencommon.cpp

Co-authored-by: Andy Ayers <andya@microsoft.com>
* Don't check poisoning for large struct in test

Since it's disabled, there is nothing to check.

Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
Co-authored-by: Andy Ayers <andya@microsoft.com>
2 years agoDon't run the JIT formatting job in release/6.0 (#61485)
Bruce Forstall [Wed, 15 Dec 2021 18:24:38 +0000 (10:24 -0800)]
Don't run the JIT formatting job in release/6.0 (#61485)

The format job depends on the `main` branch of dotnet/jitutils (which isn't
properly versioned). Avoid future changes to jitutils causing a break in
servicing by disabling the formatting job.

Note that there is very little benefit to maintaining the formatting
CI requirement in servicing anyway.

2 years agoBackport all CI matrix changes from 7.0 to reelase/6.0 (#62538)
Jan Jahoda [Wed, 15 Dec 2021 17:26:43 +0000 (18:26 +0100)]
Backport all CI matrix changes from 7.0 to reelase/6.0 (#62538)

* Replace Debian stretch with bullseye in Helix queues (#57841)

* add W11 test queue (#58570)

* CI matrix change: drop OSX 10.13 (#59084)

* Drop OSX 10.13 from CI matrix

* Drop OSX 10.14 from PR  CI matrix

* CI matrix change: ubuntu (#58987)

* Remove ubuntu 16.04

* Remove another occurence

* enable client certificate test for QUIC on Linux (#59544)

* CI matrix change: debian+centos+sles (#58988)

* CI matrix change: debian+centos+sles

* Adjust the CI matrix based on latest comments

* Rev Alpine WithNode from 3.9 to 3.13 (#57324)

* Rev Alpine WithNode from 3.9 to 3.13
Also,
* update helix queues from 3.12 to 3.13
* add 3.14 helix queues
* update performance job to install cargo from main branch

* Add Alpine 3.13 in rolling CI

* Add missing closing paren

* CI matrix change: add Windows.Server.Core.20H2 (#59572)

* Add Windows.Server.Core.20H2 to CI matrix

* add windows server 20H2

* Remove 20H2 from PR

* Remove 20H2 from PR run

* CI matrix: add openSUSE 15.2 (#59574)

* CI matrix update: add Ubuntu 21.04 (#59578)

* Rollback changes breaking rolling builds (#60040)

* Revert "CI matrix update: add Ubuntu 21.04 (#59578)"

This reverts commit 127a498bfe6202d097c3f290bce2d771ee2fb859.

* Revert "CI matrix: add openSUSE 15.2 (#59574)"

This reverts commit f9025ae80eba0b2f48ef8b413af3d357ff06987f.

* Revert "CI matrix change: add Windows.Server.Core.20H2 (#59572)"

This reverts commit 5ab435e1fa5e9c88ba7ad9bfb251d508746f337b.

* Add runtime-community.yml pipeline and add s390x job (#60255)

* Revert "Add runtime-community.yml pipeline and add s390x job (#60255)"

This reverts commit 4199aa1e8447408450c02c7ad96cacd4655bf767.

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Tomas Weinfurt <tweinfurt@yahoo.com>
Co-authored-by: Krzysztof Wicher <kwicher@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
2 years agoMerge commit '3a25a7f1cc446b60678ed25c9d829420d6321eba' into internal-merge-6.0-2021...
Sean Reeser [Tue, 14 Dec 2021 17:48:14 +0000 (09:48 -0800)]
Merge commit '3a25a7f1cc446b60678ed25c9d829420d6321eba' into internal-merge-6.0-2021-12-14-0948

2 years agoClear list of OOB packages built on 6.0 (#62610)
Santiago Fernandez Madero [Mon, 13 Dec 2021 20:10:13 +0000 (14:10 -0600)]
Clear list of OOB packages built on 6.0 (#62610)

* Clear list of OOB packages built on 6.0

* Bump System.Text.Json servicing version to 2

2 years agoUpdate branding to 6.0.2 (#62493)
vseanreesermsft [Wed, 8 Dec 2021 19:07:25 +0000 (11:07 -0800)]
Update branding to 6.0.2 (#62493)

* Update branding to 6.0.2

* Fix installer test when ref packs are not produced on servicing builds

* Fix syntax

Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
2 years agoFix whitespace
Kevin Jones [Sat, 4 Dec 2021 16:22:48 +0000 (16:22 +0000)]
Fix whitespace

2 years agoFix re-initialization of hash objects on CNG.
Kevin Jones [Sat, 4 Dec 2021 16:07:20 +0000 (11:07 -0500)]
Fix re-initialization of hash objects on CNG.

In .NET 6, we added "real" support for Initialize on hash objects.
However, the Reset call would create a new hash object without the CNG
"resuable" flag. This led to the HashProvider's "_reusable" field and
the actual reusability of the hash instance to disagree.

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 17 Nov 2021 17:32:56 +0000 (17:32 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Add packaging changes for System.Text.Json (#61703)
Santiago Fernandez Madero [Wed, 17 Nov 2021 17:29:23 +0000 (09:29 -0800)]
[release/6.0] Add packaging changes for System.Text.Json (#61703)

* [release/6.0] Add packaging changes for System.Text.Json

* Fix version calculation when using ServicingVersion for dependencies and current package

* Simplify version calculation for servicing

* Disable assembly validation for DirectoryServices as its version is pinned

2 years agoMerge branch 'internal/release/6.0' of https://dev.azure.com/dnceng/internal/_git...
Matt Mitchell [Wed, 17 Nov 2021 15:28:29 +0000 (07:28 -0800)]
Merge branch 'internal/release/6.0' of https://dev.azure.com/dnceng/internal/_git/dotnet-runtime into internal/release/6.0

2 years agoMerge remote-tracking branch 'upstream/release/6.0' into internal/release/6.0
Matt Mitchell [Wed, 17 Nov 2021 15:28:11 +0000 (07:28 -0800)]
Merge remote-tracking branch 'upstream/release/6.0' into internal/release/6.0

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 17 Nov 2021 03:24:16 +0000 (03:24 +0000)]
Merge in 'release/6.0' changes

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 17 Nov 2021 03:22:41 +0000 (03:22 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Disable native ports package validation (#61697)
Santiago Fernandez Madero [Wed, 17 Nov 2021 03:20:21 +0000 (19:20 -0800)]
[release/6.0] Disable native ports package validation (#61697)

2 years agoHostFactoryResolver - Increase default timeout and add env var option (#61688)
Maryam Ariyan [Wed, 17 Nov 2021 03:19:18 +0000 (19:19 -0800)]
HostFactoryResolver - Increase default timeout and add env var option (#61688)

* HostFactoryResolver - Increase default timeout and add env var option

* Add GeneratePackageOnBuild on source csproj

* Add ServicingVersion property

* Update src/libraries/Microsoft.Extensions.HostFactoryResolver/tests/TopLevelStatementsTestsTimeout/TopLevelStatementsTestsTimeout.csproj

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Tue, 16 Nov 2021 21:56:52 +0000 (21:56 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Disable activation host tests that fail with a 6.0 RC2 or newer SDK...
Santiago Fernandez Madero [Tue, 16 Nov 2021 21:53:32 +0000 (13:53 -0800)]
[release/6.0] Disable activation host tests that fail with a 6.0 RC2 or newer SDK (#61654)

* [release/6.0] Disable activation host tests that fail with a 6.0 RC2 or newer SDK

* Update src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj

Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com>
Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Tue, 16 Nov 2021 18:13:21 +0000 (18:13 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Provide locations for src-gen diagnostic output (#61614)
Layomi Akinrinade [Tue, 16 Nov 2021 18:09:58 +0000 (10:09 -0800)]
[release/6.0] Provide locations for src-gen diagnostic output (#61614)

* Provide locations for src-gen diagnostic output

* Fix tests and address feedback

* Add defensive check for context type location

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Tue, 16 Nov 2021 04:40:31 +0000 (04:40 +0000)]
Merge in 'release/6.0' changes

2 years agoStabilize upgrade codes for host msi (#61606)
Nikola Milosavljevic [Tue, 16 Nov 2021 04:37:46 +0000 (20:37 -0800)]
Stabilize upgrade codes for host msi (#61606)

* Stabilize upgrade codes for host msi

* Override ProviderKey with values from 6.0.0 release

* Fixing typo

* Update version of Microsoft.DotNet.Build.Tasks.Installers package

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Mon, 15 Nov 2021 23:36:54 +0000 (23:36 +0000)]
Merge in 'release/6.0' changes

2 years agoFix race condition with cancellation tokens in Read/Flush operations … (#61500)
David Fowler [Mon, 15 Nov 2021 23:34:08 +0000 (15:34 -0800)]
Fix race condition with cancellation tokens in Read/Flush operations … (#61500)

* Fix race condition with cancellation tokens in Read/Flush operations (#59090)

* Fix race condition with cancellation tokens in Read/Write operations
- There's a tight race where UnsafeRegister can fire inline and then ReadAsync never completes. This is because the cancellation token property has not been assigned yet so the callback noops. This change checks the result of the UnsafeRegister operation to see if ran synchronously and throws if it did. We also move any state transitions to after these checks to make sure the PipeAwaitable state doesn't change before throwing.

* Add a debug assert to make sure there's no state change.

* Add if debug

* More if DEBUG

* add packaging changes

* Run validation checks for just netcoreapp

* use targetIdentifier property to avoid function call and use netframework

* simplify some conditions

Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com>
Co-authored-by: Anirudh Agnihotry <anagniho@microsoft.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Mon, 15 Nov 2021 18:20:17 +0000 (18:20 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Update dependencies from dotnet/arcade (#61422)
dotnet-maestro[bot] [Mon, 15 Nov 2021 18:15:23 +0000 (10:15 -0800)]
[release/6.0] Update dependencies from dotnet/arcade (#61422)

* Update dependencies from https://github.com/dotnet/arcade build 20211108.5

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21522.3 -> To Version 6.0.0-beta.21558.5

* Update dependencies from https://github.com/dotnet/arcade build 20211110.2

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21522.3 -> To Version 6.0.0-beta.21560.2

* pin the fileversions in the platformManifest file for ref pack

* Apply suggestions from code review

Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
* Disable SDK Targeting Pack Cache

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Anirudh Agnihotry <anagniho@microsoft.com>
Co-authored-by: Anirudh Agnihotry <anirudhagnihotry098@gmail.com>
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Mon, 15 Nov 2021 04:17:15 +0000 (04:17 +0000)]
Merge in 'release/6.0' changes