Daniel Zaoui [Wed, 25 Feb 2015 08:36:38 +0000 (10:36 +0200)]
DnD/X11: improve callbacks invocations.
There is no reason why drop targets callbacks registered for a specific
type would be invoked when a not supported data is dragged.
This patch fixes it by comparing the data type and the callback type of
the drop target. Only the callbacks supporting the data type are
invoked.
Daniel Zaoui [Wed, 25 Feb 2015 08:36:34 +0000 (10:36 +0200)]
DnD/X11: improve types checking during position event.
During a DnD position event, we need to find the first dropable target
located under the mouse pointer; one of its callbacks has to support
at least one of the types of the dragged data.
This search process was done by strcmp-ing types for every drop target
and for each of their types until a good target is found.
This patch improves the process by comparing types formats, i.e and-ing bits
vectors.
Daniel Zaoui [Wed, 25 Feb 2015 08:36:26 +0000 (10:36 +0200)]
DnD/Wl: clean app callbacks management
Daniel Zaoui [Wed, 25 Feb 2015 08:36:18 +0000 (10:36 +0200)]
DnD/Wl: support multi-layer Drag and Drop
Now, we use the same way as in X11 to determine which dropable target
should receive the drop data.
@feature
Daniel Zaoui [Wed, 25 Feb 2015 08:36:13 +0000 (10:36 +0200)]
DnD: Add line number to debug messages
Daniel Zaoui [Wed, 25 Feb 2015 08:36:09 +0000 (10:36 +0200)]
DnD: generalize internal functions.
They were specific to X11 and should be used for Wayland too.
Daniel Zaoui [Wed, 25 Feb 2015 08:35:43 +0000 (10:35 +0200)]
DnD/Wl: add cancel support
This feature permits cancellation of a DnD operation in the middle.
@feature
Cedric BAIL [Tue, 24 Feb 2015 12:45:40 +0000 (13:45 +0100)]
example: fix after change in eo_do syntax.
Andrii Kroitor [Tue, 24 Feb 2015 12:23:29 +0000 (13:23 +0100)]
elementary_test: fix build on windows
Summary:
added missing header
@fix
Reviewers: cedric, seoz, Hermet
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D2041
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Mike Blumenkrantz [Mon, 23 Feb 2015 21:49:24 +0000 (16:49 -0500)]
edgebindings theme now sets align to setup layout as expected
ref T2144
Tom Hacohen [Mon, 23 Feb 2015 17:12:35 +0000 (17:12 +0000)]
Fix code to conform to recent Eo changes.
Daniel Juyung Seo [Mon, 23 Feb 2015 13:52:41 +0000 (22:52 +0900)]
gitignore: Updated gitignore file.
Daniel Juyung Seo [Mon, 23 Feb 2015 13:45:33 +0000 (22:45 +0900)]
multibuttonentry: Check return value of elm_layout_theme_set.
This fixes coverity CID 1086781.
Daniel Juyung Seo [Mon, 23 Feb 2015 09:57:30 +0000 (18:57 +0900)]
genlist: Add comments for elm,state,focused/unfocused signals.
Jee-Yong Um [Mon, 23 Feb 2015 08:59:52 +0000 (17:59 +0900)]
elm_box: Fix miscalculated items' size issue in homogeneous box
Summary:
When box has expanded items (evas_object_size_hint_weight_set() with EVAS_HINT_EXPAND)
and homogeneous is set (elm_box_homogeneous_set() with EINA_TRUE),
there is a bug that it miscalculates its items size omitting padding size (space among items),
so the last item looks cropped or having smaller size than others.
This patch makes box calculate its items' size correctly.
T2033
Reviewers: Hermet, seoz
Subscribers: seoz, Hermet
Maniphest Tasks: T2033
Differential Revision: https://phab.enlightenment.org/D2016
woochan lee [Mon, 23 Feb 2015 08:48:37 +0000 (17:48 +0900)]
datetime: Fix elm_datetime_field_limit_set.
Summary:
If user sets the limit value using elm_datetime_field_limit_set() API, the filed value will be recalculated.
Even though the value changed in case, value changed signal didn't send to user before.
@fix
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1980
SangHyeon Lee [Mon, 23 Feb 2015 08:57:01 +0000 (17:57 +0900)]
genlist/gengrid : Add upadating 'focus' state in item realized function.
Summary:
When an item is realized, select/disable/expand signal emission to the view object of an item was handled correctly,but there are no updating code for focus state.
@fix
Test Plan: tested by editing genlist/genlist item edc to react on elm,state,focused and move scroll signals to unrealized/realized item again.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: eunue
Differential Revision: https://phab.enlightenment.org/D2024
woochan lee [Mon, 23 Feb 2015 03:48:11 +0000 (12:48 +0900)]
elm_box.eo: Added @ingroup tag.
Summary: The API "elm_box_horizontal_get" missed @ingroup tag. so i added the tag for grouping when doxygen making API documentation.
Reviewers: Hermet, JackDanielZ, Jaehyun, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D1966
Daniel Juyung Seo [Mon, 23 Feb 2015 03:40:49 +0000 (12:40 +0900)]
examples: Fix build error due to the name change.
Sorry for the step by step fix.
Thanks for the report id213sin.
Daniel Juyung Seo [Mon, 23 Feb 2015 02:59:14 +0000 (11:59 +0900)]
configure: Fix break due to name change.
Daniel Juyung Seo [Mon, 23 Feb 2015 01:48:31 +0000 (10:48 +0900)]
performance: Fix typo perfomance -> performance.
Daniel Juyung Seo [Mon, 23 Feb 2015 01:46:53 +0000 (10:46 +0900)]
performance: Cast strlen return with int.
Daniel Juyung Seo [Sun, 22 Feb 2015 23:43:47 +0000 (08:43 +0900)]
elm: Remove redundant finger size adjustment.
This is a successor of
a54da8aab.
Jee-Yong Um [Sat, 21 Feb 2015 04:38:13 +0000 (13:38 +0900)]
elm_panel: make "panel scrollable" work in elementary_test
Summary:
Thumbscroll is disabled in default configuration,
but "scrollable" feature in panel only works when thumbscroll is turned on.
To make "scrollable" work always in elementary test,
this patch enables thumbscroll temporarily regardless of configuration.
(configuration is restored when sample window is closed.)
Reviewers: Hermet, seoz
Subscribers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1983
kabeer khan [Fri, 20 Feb 2015 13:33:04 +0000 (14:33 +0100)]
elm_photocam: add API's to change photocam image orientation
Summary:
Added API's to rotate(90, 180, 270), flip(horizontal, vertical), transpose and transverse Photocam Image.
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: seoz, stephenmhouston, raster, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1541
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
kabeer khan [Fri, 20 Feb 2015 13:26:01 +0000 (14:26 +0100)]
elm_image: changed orient_set code to use evas_object_image_orient_set API
Summary:
evas_image_orient_set is a newly added API to set orientation of evas image.
Using this API to set orientation of image widget.
Also removed Elm_Image_Orient enums and replaced it with Evas_Image_Orient enums.
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: raster, seoz, cedric
Differential Revision: https://phab.enlightenment.org/D1987
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
ChunEon Park [Thu, 19 Feb 2015 06:18:37 +0000 (15:18 +0900)]
Revert "Revert "Revert "win INLINE_IMAGE test now crashes as expected when trying to use it in a non-useless manner"""
This reverts commit
83f94464f1743cfa55e6b39704c605978edcee19.
This is incorrect. both windows evas are different,
we cannot set the child window as the resize object.
Andy Williams [Wed, 18 Feb 2015 08:46:05 +0000 (08:46 +0000)]
entry: Don't unlink empty files when saving @fix T2122.
Simmple fix where we now only unlink if the object we are saving is NULL.
A null terminated string being null is not an error case.
Mike Blumenkrantz [Tue, 17 Feb 2015 22:11:49 +0000 (17:11 -0500)]
Revert "Revert "win INLINE_IMAGE test now crashes as expected when trying to use it in a non-useless manner""
This reverts commit
72ef635ff3b8939509ecfb29ecf19e465b40e652.
changing a test so that it will not crash in a valid use case is not an appropriate fix.
ref T1973
Oleksandr Shcherbina [Tue, 17 Feb 2015 11:51:14 +0000 (12:51 +0100)]
elementary: example showing Evas_3D with elementary widgets and testing some of its feature.
Summary:
This small application for quick testing main features and changes in Evas 3D.
Main features: effects shadow, fog, measuring fps, load 3D model, panel for change
sets light and camera.
Reviewers: Hermet, raster, cedric
Differential Revision: https://phab.enlightenment.org/D1953
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Daniel Juyung Seo [Tue, 17 Feb 2015 00:09:33 +0000 (09:09 +0900)]
transit: Clean up internal variables and function names.
Jee-Yong Um [Mon, 16 Feb 2015 23:34:46 +0000 (08:34 +0900)]
elm_transit: Add elm_transit_go_in() API
Summary:
elm_transit_go() is executed immediately after it is called.
elm_transit_go_in() starts transit in given seconds.
@feature
Reviewers: Hermet, seoz
Reviewed By: seoz
Subscribers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1954
woochan lee [Sat, 14 Feb 2015 13:56:05 +0000 (22:56 +0900)]
multibuttonentry: Item selected callback called twice redundantly.
Summary:
_current_item_change() called at _item_select() internally.
it means _current_item_changed() called two times in vain.
so that's why item select callback called two times.
@fix
Test Plan:
1. Run elementary_test
2. Excute multibuttonentry sample.
3. Added some items and click the item area.
4. Select signal called two times.
Reviewers: Hermet, woohyun, JackDanielZ, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D1955
Hermet [Sat, 14 Feb 2015 04:29:20 +0000 (13:29 +0900)]
panes: improve doc.
Chris Michael [Fri, 13 Feb 2015 14:44:05 +0000 (09:44 -0500)]
elementary: Remove unused variable
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Daniel Kolesa [Fri, 13 Feb 2015 14:22:28 +0000 (14:22 +0000)]
els_tooltip: compiler portability (use full ternary operator)
Jaeun Choi [Fri, 13 Feb 2015 12:28:05 +0000 (21:28 +0900)]
popup: removed button style setting code in theme_apply
popup buttons are created by users
it's inappropriate to set button style in widget code
@fix
kabeer khan [Fri, 13 Feb 2015 07:26:04 +0000 (16:26 +0900)]
elm_photo: sanitise file path
Summary:
Resolved FIXME deal with relative path by sanitising file path
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: stephenmhouston, cedric, seoz, devilhorns
Reviewed By: cedric, seoz, devilhorns
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D1874
Carsten Haitzler (Rasterman) [Fri, 13 Feb 2015 04:14:07 +0000 (13:14 +0900)]
elm scroller - add adnimated and accelerated wheel scroll
now when a whele event comes in, 1. the amount we scroll accelerates
based on time between wheel events (the faster wheel events come out,
the more accel), and 2. we animate to the new position providing a
smooth transition to the new spot rather than a jump. very visually
nice.
@feature
Daniel Juyung Seo [Thu, 12 Feb 2015 13:01:59 +0000 (22:01 +0900)]
genlist: Fix elm_genlist_item_index_get.
The first item's index is 1 not 0.
@fix
Jaeun Choi [Thu, 12 Feb 2015 10:15:57 +0000 (19:15 +0900)]
gengrid: select the focused item on enter key input
there was no way to select an item with key input on ELM_ITEM_SELECT_ON_FOCUS_DISABLE mode.
this patch enables select and multi select with enter/space key input.
@fix
Jaeun Choi [Thu, 12 Feb 2015 08:31:00 +0000 (17:31 +0900)]
genlist: select the focused item on enter key input
there was no way to select an item with key input on ELM_ITEM_SELECT_ON_FOCUS_DISABLE mode.
this patch enables select and multi select with enter/space key input.
@fix
Jee-Yong Um [Wed, 11 Feb 2015 07:49:24 +0000 (16:49 +0900)]
elm_toolbar: remove code duplication
Summary:
elm_coords_finger_size_adjust() is called twice.
It might not be intended.
Reviewers: Hermet, Jaehyun, seoz
Reviewed By: seoz
Subscribers: raster, seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1924
Carsten Haitzler (Rasterman) [Wed, 11 Feb 2015 03:30:18 +0000 (12:30 +0900)]
update po
Mike Blumenkrantz [Tue, 10 Feb 2015 23:09:43 +0000 (18:09 -0500)]
comp theme now allows for modification of focus rect
Jaeun Choi [Tue, 10 Feb 2015 11:58:39 +0000 (20:58 +0900)]
Revert "gengrid: call "selected" callback on entey key input"
This reverts commit
0debdcf1ca166da1c083765bdb1542183fe96427.
Jaeun Choi [Tue, 10 Feb 2015 11:29:47 +0000 (20:29 +0900)]
gengrid: call "selected" callback on entey key input
Carsten Haitzler (Rasterman) [Tue, 10 Feb 2015 10:48:21 +0000 (19:48 +0900)]
elm engine - restore explicit use of ELM_ENGNE env var
this fixes a deprecation of elm engine done just before 1.13 release
that ends up breaking "make doc" and also will make ELM_ENGINE env var
stop working (the latter was intentional). but since this is relied on
for things like make doc - keep the env var and haveit set preferred
engine and let people migrate away from using the engine var EXCEPT
for things like the shot engine
@fix
Daniel Juyung Seo [Tue, 10 Feb 2015 08:15:45 +0000 (17:15 +0900)]
datetime: Clean up datetime module codes.
Jaeun Choi [Tue, 10 Feb 2015 07:01:23 +0000 (16:01 +0900)]
popup: passing right parameter to elm_layout_sizing_eval
pass popup object instead of main_layout to elm_layout_sizing_eval()
so that _elm_popup_elm_layout_sizing_eval is called
@fix
woochan lee [Tue, 10 Feb 2015 05:22:43 +0000 (14:22 +0900)]
multibuttonentry: refactoring(makes button object Elm_Item_Object instead of edje object)
Summary:
There was no consistency with another widget which has item object, basically widgets has Elm_Object_Item object for own's item object.
but multibuttonentry used edje object for item object before.
Test Plan:
1. Run elementary test.
2. Execute multibuttonentry.
3. Doing variety action on multibuttonentry widget.(add, delete, key event, focus etc...)
Reviewers: seoz, woohyun, Jaehyun, Hermet, JackDanielZ
Subscribers: herdsman, cedric
Differential Revision: https://phab.enlightenment.org/D1864
Youngbok Shin [Tue, 10 Feb 2015 04:41:13 +0000 (13:41 +0900)]
panel: Remove error message from elm_panel_add API and _theme_apply func.
Summary:
elm_layout_content_set API calls _elm_panel_elm_container_content_set func.
The panel widget checks the given "parts" string is whether "elm.swallow.event" or not.
To avoid error message and set the given object to the "elm.swallow.event" internally,
the panel widget need to call *_content_set for "elm.swallow.event" part using eo_do_super.
@fix
Test Plan: elementary_test -> panel
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1949
Stefan Schmidt [Mon, 9 Feb 2015 13:09:20 +0000 (14:09 +0100)]
configure: Switch to dev mode again. Merge window for 1.14 is open now.
Stefan Schmidt [Mon, 9 Feb 2015 12:39:59 +0000 (13:39 +0100)]
release: Update NEWS and bump version for 1.13.0 release
Stefan Schmidt [Mon, 9 Feb 2015 11:36:01 +0000 (12:36 +0100)]
elm_config: Avoid access of deleted item data.
This belongs to the fixes raster just did here. It was the only one I was able
to trigger after his fixes.
Last one in a row that fixes T2072.
Carsten Haitzler (Rasterman) [Mon, 9 Feb 2015 11:25:44 +0000 (20:25 +0900)]
elm - list - fix invalid item data scope get
@fix
Carsten Haitzler (Rasterman) [Mon, 9 Feb 2015 11:21:54 +0000 (20:21 +0900)]
elm config - font selector - avoid accessing invalid data on deld items
@fix
Carsten Haitzler (Rasterman) [Mon, 9 Feb 2015 09:20:45 +0000 (18:20 +0900)]
elm list - fix access of deleted items in list when recursing
@fix
Youngbok Shin [Mon, 9 Feb 2015 04:09:05 +0000 (13:09 +0900)]
widgets: Apply default return value according to description in .eo or add description too.
Summary:
1) According to description in .eo file,
some APIs return not 0 when the given object is NULL or not proper object.
But, several APIs are not implemented as those description.
Now, they will return a value as description.
2) If there is no description about the return value when the API fail,
put description according to pair API or old version of elementary.
@fix
Reviewers: woohyun, Hermet, seoz
Differential Revision: https://phab.enlightenment.org/D1933
kabeer khan [Mon, 9 Feb 2015 01:40:29 +0000 (10:40 +0900)]
elm_widget: added evas smart callback descriptions
Summary:
Resolved FIXME filled all smart callbacks and also set it in the constructor
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: seoz
Differential Revision: https://phab.enlightenment.org/D1876
Daniel Juyung Seo [Mon, 9 Feb 2015 01:34:06 +0000 (10:34 +0900)]
test_genlist: Clean up reorder test case.
Igor Murzov [Sat, 7 Feb 2015 12:17:53 +0000 (15:17 +0300)]
Update russian translation
Carsten Haitzler (Rasterman) [Sat, 7 Feb 2015 03:54:11 +0000 (12:54 +0900)]
elm - fix engine config mismatch with new perferred accel vs old engine
the elm config tool only lets you set accel preference. if you set
none, then the old engine config takes charge, but there is no way to
change/set this, so deprecate the old engine set and don't use it.
this accel preference has been around for a while, so use it now
instead.
Sung-Taek Hong [Fri, 6 Feb 2015 12:58:32 +0000 (21:58 +0900)]
elm_slider: modified each slider have its indicator visible mode.
Summary: Added indicator_visible_mode to each slider in order not to make elm_config controlls every sliders.
Reviewers: Hermet, woohyun, seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1887
Daniel Juyung Seo [Fri, 6 Feb 2015 06:15:44 +0000 (15:15 +0900)]
doc: Fix typos in documentations.
Daniel Juyung Seo [Fri, 6 Feb 2015 06:11:32 +0000 (15:11 +0900)]
win_example: Fix win example codes.
- return value in ecore event handler callback.
- remove unnecessary variable.
Youngbok Shin [Fri, 6 Feb 2015 06:06:49 +0000 (15:06 +0900)]
win: fix an issue that profile is erased and set to NULL.
Summary:
When ecore_evas_window_profile_supported_get API return EINA_FALSE,
elm_win widget should not get profile from ecore_evas_window_profile_get API.
@fix
Reviewers: woohyun, Hermet, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D1943
Carsten Haitzler (Rasterman) [Fri, 6 Feb 2015 02:32:55 +0000 (11:32 +0900)]
fix win center trap for elm to pass in h and v params
while this is technically an abi break, it should actually have no
real impact. it will have warnings - sure, but running existing code
will simply not see the extra parammeters on the stack and not use
them so it'll continue to work. if we removed paramms, we'd be in
pain. (same applies to params passed in registers).
this fixes T2031
Carsten Haitzler (Rasterman) [Thu, 5 Feb 2015 11:44:49 +0000 (20:44 +0900)]
elm - win - dont use deprecated func - use new one.
cleanup to match efl 1.13 changes
Jee-Yong Um [Thu, 5 Feb 2015 11:41:16 +0000 (20:41 +0900)]
elm_label: Fixed label disappearing after theme changed
Summary:
There is a bug that text disappears when theme is changed after label shown.
This patch fixed it.
@fix
Reviewers: woohyun, Hermet, Jaehyun, seoz
Subscribers: Jaehyun, seoz
Differential Revision: https://phab.enlightenment.org/D1923
Shinwoo Kim [Thu, 5 Feb 2015 11:02:24 +0000 (20:02 +0900)]
[tooltip] use proper object to set tooltip layer
Summary:
tooltip could be hide by the other object which have lower layer than target object of tooltip.
the layer of content could be changed, when is set to the tooltip as a content.
@fix
Test Plan: check added test lines
Reviewers: cedric, jpeg, seoz, raster
Reviewed By: raster
Subscribers: singh.amitesh, stefan_schmidt, seoz
Differential Revision: https://phab.enlightenment.org/D1889
Jee-Yong Um [Wed, 4 Feb 2015 10:26:06 +0000 (19:26 +0900)]
elm_label: Fixed to prevent slide's autostart before calling elm_label_slide_go()
Summary:
Label should not start sliding before elm_label_slide_go() is called.
However, label starts sliding automatically,
because resize callback emits slide start signal.
This patch prevents label from sliding before calling elm_label_slide_go().
@fix
Reviewers: woohyun, Hermet, seoz
Subscribers: CHAN, woohyun
Differential Revision: https://phab.enlightenment.org/D1906
Jaehwan Kim [Wed, 4 Feb 2015 10:19:45 +0000 (19:19 +0900)]
datetime_module: Fix build warning.
Include the elm_widget.h
Carsten Haitzler (Rasterman) [Wed, 4 Feb 2015 10:04:53 +0000 (19:04 +0900)]
update po
Jaehwan Kim [Wed, 4 Feb 2015 09:52:14 +0000 (18:52 +0900)]
datetime module: include elm_widget_datetime.h instead of elm_priv.h
The external module can't include elm_priv.h.
So Elm_Datetime_Module_Data moves in elm_widget_datetime.h
Daniel Juyung Seo [Wed, 4 Feb 2015 01:27:24 +0000 (10:27 +0900)]
NEWS: Pedantic change of capital letter in NEWS fi.e
Daniel Juyung Seo [Wed, 4 Feb 2015 01:16:57 +0000 (10:16 +0900)]
test_label: Cleanup label wrap test.
- remove unnecessary box.
- use ELM_SCALE_SIZE macro for a better scalability.
VBS [Tue, 3 Feb 2015 23:30:06 +0000 (08:30 +0900)]
Gengrid : Fix memory leak in elm_gengrid_realized_items_update
Summary:
Eina_List from elm_gengrid_realized_items_get must be freed by caller,
but elm_gengrid_realized_items_update doesn't free Eina_List.
So memory leak is happens.
@fix
Test Plan: Call elm_gengrid_realized_items_update repeatly and check memory share increase.
Reviewers: raster, seoz
Differential Revision: https://phab.enlightenment.org/D1903
maxerba [Tue, 3 Feb 2015 20:07:45 +0000 (21:07 +0100)]
Updating serbian translation
Stefan Schmidt [Tue, 3 Feb 2015 09:22:43 +0000 (10:22 +0100)]
release: Update NEWS and bump version for 1.13.0-beta3 release
Youngbok Shin [Tue, 3 Feb 2015 09:17:47 +0000 (10:17 +0100)]
elm_image: fix elm_image_memfile_set API fail when elm_image widget is not visible.
Summary:
It could success only when the widget was visible.
The API must return EINA_TRUE if buffer and size has no problem, not visiblity of widget.
@fix
Reviewers: Hermet, woohyun, jpeg
Differential Revision: https://phab.enlightenment.org/D1917
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Amitesh Singh [Tue, 3 Feb 2015 06:47:32 +0000 (15:47 +0900)]
list/genlist/gengrid/toolbar: set focus/unfocus on item when focus is actually set on widget.
Summary: @Fix
Reviewers: raster, Hermet, seoz
Reviewed By: seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1918
woochan lee [Tue, 3 Feb 2015 02:38:21 +0000 (11:38 +0900)]
multibuttonentry: Delete duplicate running code.
Summary:
When layout clicked, "elm_widget_on_focus()" called with "entry_focus_in()" callback.
The "view update" and "focus set to entry" already call in those callbacks, so i deleted duplicate code and it also make focus issue when user click the entry to add item.
@fix
Test Plan:
Run elementary_test.
1. excute multibuttonentry.
2. click the entry area.
3. see the elm_widget_on_focus called twice.
(layout callback function called view update -> elm_box_unpack called in view update ->
entry lose focus -> on_focus_callback call again)
Reviewers: Hermet, seoz, Jaehyun_Cho, JackDanielZ
Differential Revision: https://phab.enlightenment.org/D1902
Youngbok Shin [Fri, 30 Jan 2015 02:04:24 +0000 (11:04 +0900)]
win: Add default return value at elm_win_type_get API according to API description.
Summary: The API must return ELM_WIN_UNKNOWN (-1) when the given object is improper.
Test Plan: None.
Reviewers: woohyun, JackDanielZ, seoz
Differential Revision: https://phab.enlightenment.org/D1907
Daniel Juyung Seo [Fri, 30 Jan 2015 00:10:43 +0000 (09:10 +0900)]
test_label: Use meaningful test name for label test.
kabeer khan [Thu, 29 Jan 2015 23:02:21 +0000 (08:02 +0900)]
Elm_Entry: Removed empty line and added error message
Summary:
Resolved FIXME in utf8_markup_save by adding error messages
for fopen and fputs command
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: devilhorns, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D1888
Daniel Juyung Seo [Thu, 29 Jan 2015 22:35:16 +0000 (07:35 +0900)]
NEWS: Clean up news file before release.
Daniel Juyung Seo [Thu, 29 Jan 2015 06:28:08 +0000 (15:28 +0900)]
test_panes: Remove unnecessary align/weight set for panes contents.
Stefan Schmidt [Wed, 28 Jan 2015 12:49:00 +0000 (13:49 +0100)]
edje_externals/elm_video: Fix bug where we override the rememberred position
This bug was there from the initial commit of elm_video. Classical
copy&andpaste bug.
CID: 1267207
Daniel Juyung Seo [Tue, 27 Jan 2015 04:11:05 +0000 (13:11 +0900)]
panes: Fix elm_panes_fixed_set.
@fix
Stefan Schmidt [Mon, 26 Jan 2015 14:02:55 +0000 (15:02 +0100)]
NEWS: Manually fix up a news entry
Stefan Schmidt [Mon, 26 Jan 2015 12:09:54 +0000 (13:09 +0100)]
release: Update NEWS and bump version for 1.13.0-beta2 release
Dave Andreoli [Sun, 25 Jan 2015 17:31:59 +0000 (18:31 +0100)]
Icon: choose the fdo icon size using the evas obj geometry
Use the min between w and h of the evas object to
request the size in the icon theme. Fdo icon are always
square (1:1) so min seems correct.
Also improved the test to include a test that do
not relay on the size_hint_min of the icon.
Now in all the test I have done always the correct
fdo icon are used.
Dave Andreoli [Sun, 25 Jan 2015 15:48:21 +0000 (16:48 +0100)]
Revert "Icon: use size_hint_min instead of image_size to know the wanted size"
This reverts commit
75176a789981bd6b1ef0bfcc95793c896b5bde07.
Was not the correct solution, as min_size can be smaller than
the real wanted size. Need to find another solution.
Thanks TAsn to spot this
Dave Andreoli [Sun, 25 Jan 2015 14:48:41 +0000 (15:48 +0100)]
Icon: use size_hint_min instead of image_size to know the wanted size
This @fix fdo icons to load the correct image for the requested size.
Whitout this the small images (16x16) was never used, because once a big
(64x64 for example) image was loaded, that size was used as min.
See the Icon Standard test for a better explanation
Dave Andreoli [Sun, 25 Jan 2015 14:39:43 +0000 (15:39 +0100)]
Icon: no more reimplement sizing_eval
The code there was trying to reload the icon to have an
image that should match the requested size, this was totally
wrong, the calculation was always resulting in an image bigger
than the needed.
It was also useless as this logic is yet handled in the resize
callback.
Dave Andreoli [Sun, 25 Jan 2015 14:16:51 +0000 (15:16 +0100)]
Improve Standard Icon test
You can now select the size of the icons in the list and
also added a single icon that you can resize.
The size of the icons is important as icon themes usually
provide different images for different sizes.
This test now spot out some errors in elm_icon wrt icon
sizing, will fix soon
Dave Andreoli [Fri, 23 Jan 2015 20:44:15 +0000 (21:44 +0100)]
Add correct fdo name for the last added search icon
Stefan Schmidt [Fri, 23 Jan 2015 11:45:33 +0000 (12:45 +0100)]
elm_image: Add missing semi-colon to terminate line.
No compiler warning for this because the macro was terminated with it.
It still looks wrong without it and does no harm.
Stefan Schmidt [Fri, 23 Jan 2015 11:43:49 +0000 (12:43 +0100)]
elm_image: Fix memory leak in GETDAT macro.
Free data2 on error path.
CID: 1265609, 1265610, 1265611, 1265612