Qiu Chaofan [Tue, 8 Dec 2020 06:08:52 +0000 (14:08 +0800)]
[PowerPC] Implement intrinsic for DARN instruction
Instruction darn was introduced in ISA 3.0. It means 'Deliver A Random
Number'. The immediate number L means:
- L=0, the number is 32-bit (higher 32-bits are all-zero)
- L=1, the number is 'conditioned' (processed by hardware to reduce bias)
- L=2, the number is not conditioned, directly from noise source
GCC implements them in three separate intrinsics: __builtin_darn,
__builtin_darn_32 and __builtin_darn_raw. This patch implements the
same intrinsics. And this change also addresses Bugzilla PR39800.
Reviewed By: steven.zhang
Differential Revision: https://reviews.llvm.org/D92465
Arthur Eubanks [Tue, 8 Dec 2020 05:54:38 +0000 (21:54 -0800)]
[test] Fix Transforms/LoopVersioningLICM under NPM
There were already both legacy and new PM RUN lines.
Also make the NPM RUN line actually match the legacy PM RUN line.
Arthur Eubanks [Tue, 8 Dec 2020 05:48:21 +0000 (21:48 -0800)]
[test] Fix Transforms/LoopVectorize under NPM
The -enable-new-pm=1 translation caused loop-vectorize to run on all
functions, then instcombine, rather than all passes on one function then
the next. This caused the output of -debug-only and -print-after to be
interleaved in an unexpected way.
Arthur Eubanks [Tue, 8 Dec 2020 05:17:07 +0000 (21:17 -0800)]
[test] Fix store_cost.ll under NPM
The NPM processes loops in forward program order, whereas the legacy PM
processes them in reverse program order. No reason to test both PMs
here, so just stick to the NPM.
Jonas Devlieghere [Tue, 8 Dec 2020 04:31:07 +0000 (20:31 -0800)]
[lldb] Include thread id in the reproducer trace (NFC)
Include the current thread ID in the reproducer trace during
capture/recording.
Vitaly Buka [Sat, 5 Dec 2020 07:46:58 +0000 (23:46 -0800)]
[NFC][MSan] Round up OffsetPtr in PoisonMembers
getFieldOffset(layoutStartOffset) is expected to point to the first trivial
field or the one which follows non-trivial. So it must be byte aligned already.
However this is not obvious without assumptions about callers.
This patch will avoid the need in such assumptions.
Depends on D92727.
Differential Revision: https://reviews.llvm.org/D92728
Arthur Eubanks [Tue, 8 Dec 2020 03:19:37 +0000 (19:19 -0800)]
[test] Fix widen-iv.ll under NPM
The -loop-flatten legacy pass preserves loop analyses. The legacy PM
will check all passes that preserve loop analyses that they preserve
LCSSA. This implicitly involves running -loop-simplify. The test
shouldn't depend on verify flags being set in order to run
-loop-simplify, so explicitly add it. The new PM ends up not running it
otherwise.
Kai Luo [Tue, 8 Dec 2020 03:22:32 +0000 (03:22 +0000)]
[DAGCombine][PowerPC] Simplify nabs by using legal `smin` operation
Convert `0 - abs(x)` to `smin (x, -x)` if `smin` is a legal operation.
Verification: https://alive2.llvm.org/ce/z/vpquFR
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D92637
Esme-Yi [Tue, 8 Dec 2020 03:20:12 +0000 (03:20 +0000)]
[PowerPC] Correct the bit-width definition for some imm operand in td.
Summary: The imm operands of some instructions are not defined accurately in td.
This is a small patch to correct these definitions.
Reviewed By: steven.zhang
Differential Revision: https://reviews.llvm.org/D91603
Richard Smith [Tue, 8 Dec 2020 02:41:43 +0000 (18:41 -0800)]
Fix assertion failure due to incorrect dependence bits on a DeclRefExpr
that can only be set correctly after instantiating the initializer for a
variable.
Fangrui Song [Tue, 8 Dec 2020 02:40:31 +0000 (18:40 -0800)]
[test] Rewrite split-debug.c
Use generic ELF target triples.
Add missing coverage: -gsplit-dwarf=split -g -fsplit-dwarf-inlining
Reorganize and add comments.
Test -gno-pubnames
Arthur Eubanks [Tue, 8 Dec 2020 01:36:18 +0000 (17:36 -0800)]
[test] Fix LoopFusion tests under NewPM
The legacy pass depended on -loop-simplify running. The NPM does not
allow for a non-analysis pass to depend on another non-analysis pass.
Jessica Paquette [Tue, 1 Dec 2020 19:58:19 +0000 (11:58 -0800)]
[AArch64][GlobalISel] Refactor G_BRCOND selection
`selectCompareBranch` was hard to understand.
Also, it was being needlessly pessimistic with the `ProduceNonFlagSettingCondBr`
case. It assumed that everything in `selectCompareBranch` would emit a TB(N)Z
or C(B)NZ. That's not true; the G_FCMP + G_BRCOND case would never emit those
instructions, and the G_ICMP + G_BRCOND case was capable of emitting an integer
compare + Bcc.
- Refactor `selectCompareBranch` into separate functions based off of what is
feeding the G_BRCOND's condition.
- Move G_BRCOND selection code from `select` to `selectCompareBranch`.
- Remove duplicated constraint code from the code originally in `select`;
`emitTestBit` already handles that, so no need to constrain twice.
- Factor out the G_FCMP + G_BRCOND case into `selectCompareBranchFedByFCmp`.
- Split the G_ICMP + G_BRCOND case into an optimization function,
`tryOptCompareBranchFedByICmp` and a general selection function,
`selectCompareBranchFedByICmp`.
- Reduce the number of things passed to `tryOptAndIntoCompareBranch`.
- Improve documentation.
- Give some variables more descriptive names.
Other than improving the code generation for functions with
speculative_load_hardening by getting the logic correct, this is NFC.
Differential Revision: https://reviews.llvm.org/D92582
Valentin Churavy [Mon, 7 Dec 2020 21:13:57 +0000 (16:13 -0500)]
[VNCoercion] Disallow coercion between different ni addrspaces
I'm not sure if it would be legal by the IR reference to introduce
an addrspacecast here, since the IR reference is a bit vague on
the exact semantics, but at least for our usage of it (and I
suspect for many other's usage) it is not. For us, addrspacecasts
between non-integral address spaces carry frontend information that the
optimizer cannot deduce afterwards in a generic way (though we
have frontend specific passes in our pipline that do propagate
these). In any case, I'm sure nobody is using it this way at
the moment, since it would have introduced inttoptrs, which
are definitely illegal.
Fixes PR38375
Co-authored-by: Keno Fischer <keno@alumni.harvard.edu>
Reviewed By: reames
Differential Revision: https://reviews.llvm.org/D50010
Yaxun (Sam) Liu [Tue, 8 Dec 2020 00:48:59 +0000 (19:48 -0500)]
Fix lit test failure due to 0b81d9
These lit tests now requires amdgpu-registered-target since they
use clang driver and clang driver passes an LLVM option which
is available only if amdgpu target is registered.
Change-Id: I2df31967409f1627fc6d342d1ab5cc8aa17c9c0c
Douglas Yung [Tue, 8 Dec 2020 00:36:58 +0000 (16:36 -0800)]
Fixup test in path to use C:\ instead of D:\ which may be mapped to a removable.
Our internal build bot hit a failure in llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test
because the test was checking for an error message that is emitted when a pdb file is
missing. But when the drive is mapped to a removalable drive (such as a DVD drive) in
Windows, you get a different error message which causes the test to fail.
This fixes the test by changing the drive the missing pdb is expected to be on to C:\
instead of D:\ as that is the drive historically used to install Windows and thus
if present should be a hard drive.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D92787
Richard Smith [Mon, 7 Dec 2020 23:50:18 +0000 (15:50 -0800)]
Fix deserialization cycle in preferred_name attribute.
This is really just a workaround for a more fundamental issue in the way
we deserialize attributes. See PR48434 for details.
Also fix tablegen code generator to produce more correct indentation to
resolve buildbot issues with -Werror=misleading-indentation firing
inside the generated code.
Yaxun (Sam) Liu [Tue, 27 Oct 2020 18:10:02 +0000 (14:10 -0400)]
[AMDGPU] add -mcode-object-version=n
Add option -mcode-object-version=n to control code object version for
AMDGPU.
Differential Revision: https://reviews.llvm.org/D91310
Yaxun (Sam) Liu [Thu, 17 Sep 2020 18:53:24 +0000 (14:53 -0400)]
[clang][AMDGPU] remove mxnack and msramecc options
Remove mxnack and msramecc options since they
are deprecated by --offload-arch.
This is part of https://reviews.llvm.org/D60620
Yaxun (Sam) Liu [Thu, 13 Aug 2020 20:31:51 +0000 (16:31 -0400)]
[HIP] fix bundle entry ID for --
Canonicalize triple used in fat binary. Change from
amdgcn-amd-amdhsa to amdgcn-amd-amdhsa-.
This is part of https://reviews.llvm.org/D60620
Mehdi Amini [Sat, 5 Dec 2020 02:08:38 +0000 (02:08 +0000)]
Add Python binding for MLIR Type Attribute
Differential Revision: https://reviews.llvm.org/D92711
Mehdi Amini [Sat, 5 Dec 2020 01:28:41 +0000 (01:28 +0000)]
Customize exception thrown from mlir.Operation.create() python bindings
The default exception handling isn't very user friendly and does not
point accurately to the issue. Instead we can indicate which of the
operands isn't valid and provide contextual information in the error
message.
Differential Revision: https://reviews.llvm.org/D92710
Yaxun (Sam) Liu [Mon, 7 Dec 2020 22:31:28 +0000 (17:31 -0500)]
[clang][AMDGPU] rename sram-ecc as sramecc
As backend renamed sram-ecc to sramecc, this patch makes
corresponding change in clang.
Differential Revision: https://reviews.llvm.org/D86217
Jessica Paquette [Fri, 4 Dec 2020 23:51:44 +0000 (15:51 -0800)]
[AArch64][GlobalISel] Narrow 128-bit regs to 64-bit regs in emitTestBit
When we have a 128-bit register, emitTestBit would incorrectly narrow to 32
bits always. If the bit number was > 32, then we would need a TB(N)ZX. This
would cause a crash, as we'd have the wrong register class. (PR48379)
This generalizes `narrowExtReg` into `moveScalarRegClass`.
This also allows us to remove `widenGPRBankRegIfNeeded` entirely, since
`selectCopy` correctly handles SUBREG_TO_REG etc.
This does create some codegen changes (since `selectCopy` uses the `all`
regclass variants). However, I think that these will likely be optimized away,
and we can always improve the `selectCopy` code. It looks like we should
revisit `selectCopy` at this point, and possibly refactor it into at least one
`emit` function.
Differential Revision: https://reviews.llvm.org/D92707
Philip Reames [Mon, 7 Dec 2020 22:36:19 +0000 (14:36 -0800)]
Teach isKnownNonEqual how to recurse through invertible multiplies
Build on the work started in 8f07629, and add the multiply case. In the process, more clearly describe the requirement for the operation we're looking through.
Differential Revision: https://reviews.llvm.org/D92726
Jann Horn [Mon, 7 Dec 2020 22:48:41 +0000 (14:48 -0800)]
[clang] Fix noderef for AddrOf on MemberExpr
Committing on behalf of thejh (Jann Horn).
As part of this change, one existing test case has to be adjusted
because it accidentally stripped the NoDeref attribute without
getting caught.
Depends on D92140
Differential Review: https://reviews.llvm.org/D92141
peter klausler [Mon, 7 Dec 2020 20:08:58 +0000 (12:08 -0800)]
[flang] Improve initializer semantics, esp. for component default values
This patch plugs many holes in static initializer semantics, improves error
messages for default initial values and other component properties in
parameterized derived type instantiations, and cleans up several small
issues noticed during development. We now do proper scalar expansion,
folding, and type, rank, and shape conformance checking for component
default initializers in derived types and PDT instantiations.
The initial values of named constants are now guaranteed to have been folded
when installed in the symbol table, and are no longer folded or
scalar-expanded at each use in expression folding. Semantics documentation
was extended with information about the various kinds of initializations
in Fortran and when each of them are processed in the compiler.
Some necessary concomitant changes have bulked this patch out a bit:
* contextual messages attachments, which are now produced for parameterized
derived type instantiations so that the user can figure out which
instance caused a problem with a component, have been added as part
of ContextualMessages, and their implementation was debugged
* several APIs in evaluate::characteristics was changed so that a FoldingContext
is passed as an argument rather than just its intrinsic procedure table;
this affected client call sites in many files
* new tools in Evaluate/check-expression.cpp to determine when an Expr
actually is a single constant value and to validate a non-pointer
variable initializer or object component default value
* shape conformance checking has additional arguments that control
whether scalar expansion is allowed
* several now-unused functions and data members noticed and removed
* several crashes and bogus errors exposed by testing this new code
were fixed
* a -fdebug-stack-trace option to enable LLVM's stack tracing on
a crash, which might be useful in the future
TL;DR: Initialization processing does more and takes place at the right
times for all of the various kinds of things that can be initialized.
Differential Review: https://reviews.llvm.org/D92783
Leonard Chan [Mon, 7 Dec 2020 22:39:42 +0000 (14:39 -0800)]
[clang] Fix noderef for array member of deref expr
Committing on behalf of thejh (Jann Horn).
Given an attribute((noderef)) pointer "p" to the struct
struct s { int a[2]; };
ensure that the following expressions are treated the same way by the
noderef logic:
p->a
(*p).a
Until now, the first expression would be treated correctly (nothing is
added to PossibleDerefs because CheckMemberAccessOfNoDeref() bails out
on array members), but the second expression would incorrectly warn
because "*p" creates a PossibleDerefs entry.
Handle this case the same way as for the AddrOf operator.
Differential Revision: https://reviews.llvm.org/D92140
Mitch Phillips [Mon, 7 Dec 2020 22:30:53 +0000 (14:30 -0800)]
Revert "[test] Fix asan/TestCases/Linux/globals-gc-sections-lld.cpp with -fsanitize-address-globals-dead-stripping"
This reverts commit
140808768d3e5c0f4e52dd42094650f5d282e34a.
Reason: Broke the upstream bots - discussed offline.
Erik Pilkington [Sun, 6 Dec 2020 20:08:12 +0000 (15:08 -0500)]
[clang] Add support for attribute 'swift_async'
This attributes specifies how (or if) a given function or method will be
imported into a swift async method. rdar://
70111252
Differential revision: https://reviews.llvm.org/D92742
Erik Pilkington [Mon, 7 Dec 2020 14:14:25 +0000 (09:14 -0500)]
[clang] Add a new nullability annotation for swift async: _Nullable_result
_Nullable_result generally like _Nullable, except when being imported into a
swift async method. rdar://
70106409
Differential revision: https://reviews.llvm.org/D92495
Mehdi Amini [Mon, 7 Dec 2020 21:57:32 +0000 (21:57 +0000)]
Set the target branch for `arc land` to main
wlei [Mon, 19 Oct 2020 19:55:59 +0000 (12:55 -0700)]
[CSSPGO][llvm-profgen] Context-sensitive profile data generation
This stack of changes introduces `llvm-profgen` utility which generates a profile data file from given perf script data files for sample-based PGO. It’s part of(not only) the CSSPGO work. Specifically to support context-sensitive with/without pseudo probe profile, it implements a series of functionalities including perf trace parsing, instruction symbolization, LBR stack/call frame stack unwinding, pseudo probe decoding, etc. Also high throughput is achieved by multiple levels of sample aggregation and compatible format with one stop is generated at the end. Please refer to: https://groups.google.com/g/llvm-dev/c/1p1rdYbL93s for the CSSPGO RFC.
This change supports context-sensitive profile data generation into llvm-profgen. With simultaneous sampling for LBR and call stack, we can identify leaf of LBR sample with calling context from stack sample . During the process of deriving fall through path from LBR entries, we unwind LBR by replaying all the calls and returns (including implicit calls/returns due to inlining) backwards on top of the sampled call stack. Then the state of call stack as we unwind through LBR always represents the calling context of current fall through path.
we have two types of virtual unwinding 1) LBR unwinding and 2) linear range unwinding.
Specifically, for each LBR entry which can be classified into call, return, regular branch, LBR unwinding will replay the operation by pushing, popping or switching leaf frame towards the call stack and since the initial call stack is most recently sampled, the replay should be in anti-execution order, i.e. for the regular case, pop the call stack when LBR is call, push frame on call stack when LBR is return. After each LBR processed, it also needs to align with the next LBR by going through instructions from previous LBR's target to current LBR's source, which we named linear unwinding. As instruction from linear range can come from different function by inlining, linear unwinding will do the range splitting and record counters through the range with same inline context.
With each fall through path from LBR unwinding, we aggregate each sample into counters by the calling context and eventually generate full context sensitive profile (without relying on inlining) to driver compiler's PGO/FDO.
A breakdown of noteworthy changes:
- Added `HybridSample` class as the abstraction perf sample including LBR stack and call stack
* Extended `PerfReader` to implement auto-detect whether input perf script output contains CS profile, then do the parsing. Multiple `HybridSample` are extracted
* Speed up by aggregating `HybridSample` into `AggregatedSamples`
* Added VirtualUnwinder that consumes aggregated `HybridSample` and implements unwinding of calls, returns, and linear path that contains implicit call/return from inlining. Ranges and branches counters are aggregated by the calling context.
Here calling context is string type, each context is a pair of function name and callsite location info, the whole context is like `main:1 @ foo:2 @ bar`.
* Added PorfileGenerater that accumulates counters by ranges unfolding or branch target mapping, then generates context-sensitive function profile including function body, inferring callee's head sample, callsite target samples, eventually records into ProfileMap.
* Leveraged LLVM build-in(`SampleProfWriter`) writer to support different serialization format with no stop
- `getCanonicalFnName` for callee name and name from ELF section
- Added regression test for both unwinding and profile generation
Test Plan:
ninja & ninja check-llvm
Reviewed By: hoy, wenlei, wmi
Differential Revision: https://reviews.llvm.org/D89723
Vitaly Buka [Sat, 5 Dec 2020 07:47:11 +0000 (23:47 -0800)]
[CodeGen][MSan] Don't use offsets of zero-sized fields
Such fields will likely have offset zero making
__sanitizer_dtor_callback poisoning wrong regions.
E.g. it can poison base class member from derived class constructor.
Differential Revision: https://reviews.llvm.org/D92727
Alex Zinenko [Wed, 2 Dec 2020 11:53:12 +0000 (12:53 +0100)]
[OpenMPIRBuilder] introduce createStaticWorkshareLoop
Introduce a function that creates a statically-scheduled workshare loop
out of a canonical loop created earlier by the OpenMPIRBuilder. This
basically amounts to injecting runtime calls to the preheader and the
after block and updating the trip count. Static scheduling kind is
currently hardcoded and needs to be extracted from the runtime library
into common TableGen definitions.
Differential Revision: https://reviews.llvm.org/D92476
Michael Kruse [Mon, 7 Dec 2020 20:39:32 +0000 (14:39 -0600)]
[Polly][CodeGen] Remove use of ScalarEvolution.
ScalarEvolution::getSCEV cannot be used during codegen. ScalarEvolution
assumes a stable IR and control flow which is under construction during
Polly's CodeGen. In particular, it uses DominatorTree for compute the
backedge taken count. However the DominatorTree is not updated during
codegen.
In this case, SCEV was used to determine the base pointer of an array
access. Replace it by our own function. Polly generates only GEP and
BitCasts for array acceses, i.e. it is sufficient to handle these to to
find the base pointer.
Fixes llvm.org/PR48422
Amy Huang [Thu, 3 Dec 2020 17:03:55 +0000 (09:03 -0800)]
[CodeView] Fix inline sites that are missing code offsets.
When an inline site has a starting code offset of 0, we sometimes
don't emit the starting offset.
Bug: https://bugs.llvm.org/show_bug.cgi?id=48377
Differential Revision: https://reviews.llvm.org/D92590
Nico Weber [Mon, 7 Dec 2020 16:29:25 +0000 (11:29 -0500)]
docs: Add pointer to cmake caches for PGO
Also add a link to end-user PGO documentation.
Differential Revision: https://reviews.llvm.org/D92768
Richard Smith [Thu, 12 Nov 2020 01:12:18 +0000 (17:12 -0800)]
Add new 'preferred_name' attribute.
This attribute permits a typedef to be associated with a class template
specialization as a preferred way of naming that class template
specialization. This permits us to specify that (for example) the
preferred way to express 'std::basic_string<char>' is as 'std::string'.
The attribute is applied to the various class templates in libc++ that have
corresponding well-known typedef names.
Differential Revision: https://reviews.llvm.org/D91311
Amara Emerson [Mon, 7 Dec 2020 20:47:28 +0000 (12:47 -0800)]
[AArch64] Fix some minor coding style issues in AArch64CompressJumpTables
Nathan James [Mon, 7 Dec 2020 20:23:11 +0000 (20:23 +0000)]
[llvm][NFC] Made RefCountBase constructors protected
Matches ThreadSafeRefCountBase and forces the class to be inherited.
Nathan James [Mon, 7 Dec 2020 20:20:08 +0000 (20:20 +0000)]
[llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors
Added a trivial destructor in release mode and in debug mode a destructor that asserts RefCount is indeed zero.
This ensure people aren't manually (maybe accidentally) destroying these objects like in this contrived example.
```lang=c++
{
std::unique_ptr<SomethingRefCounted> Object;
holdIntrusiveOwnership(Object.get());
// Object Destructor called here will assert.
}
```
Reviewed By: dblaikie
Differential Revision: https://reviews.llvm.org/D92480
Derek Schuff [Fri, 4 Dec 2020 21:45:42 +0000 (13:45 -0800)]
[WebAssembly] Add Object and ObjectWriter support for wasm COMDAT sections
Allow sections to be placed into COMDAT groups, in addtion to functions and data
segments.
Also make section symbols unnamed, which allows sections with identical names
(section names are independent of their section symbols, but previously we
gave the symbols the same name as their sections, which results in collisions
when sections are identically-named).
Differential Revision: https://reviews.llvm.org/D92691
Sanjay Patel [Mon, 7 Dec 2020 20:09:21 +0000 (15:09 -0500)]
[SLP] fix typo in debug string; NFC
Aart Bik [Mon, 7 Dec 2020 19:54:58 +0000 (11:54 -0800)]
[mlir][sparse] hoist loop invariant tensor loads in sparse compiler
After bufferization, the backend has much more trouble hoisting loop invariant
loads from the loops generated by the sparse compiler. Therefore, this is done
during sparse code generation. Note that we don't bother hoisting derived
invariant expressions on SSA values, since the backend does that very well.
Still TBD: scalarize reductions to avoid load-add-store cycles
Reviewed By: penpornk
Differential Revision: https://reviews.llvm.org/D92534
Erich Keane [Mon, 7 Dec 2020 19:27:01 +0000 (11:27 -0800)]
Stop ExtractTypeForDeductionGuide from recursing on TypeSourceInfo
As reported in PR48177, the type-deduction extraction ends up going into
an infinite loop when the type referred to has a recursive definition.
This stops recursing and just substitutes the type-source-info the
TypeLocBuilder identified when transforming the base.
Bardia Mahjour [Mon, 7 Dec 2020 19:23:52 +0000 (14:23 -0500)]
[LV] Epilogue Vectorization with Optimal Control Flow - Default Enablement
This patch enables epilogue vectorization by default per reviewer requests.
Differential Revision: https://reviews.llvm.org/D89566
Yu Shan [Mon, 7 Dec 2020 18:58:44 +0000 (10:58 -0800)]
[analyzer] Ignore annotations if func is inlined.
When we annotating a function header so that it could be used by other
TU, we also need to make sure the function is parsed correctly within
the same TU. So if we can find the function's implementation,
ignore the annotations, otherwise, false positive would occur.
Move the escape by value case to post call and do not escape the handle
if the function is inlined and we have analyzed the handle.
Differential Revision: https://reviews.llvm.org/D91902
Valentin Clement [Mon, 7 Dec 2020 19:26:50 +0000 (14:26 -0500)]
[flang][openacc] Add clause validity tests for the kernels directive
Add some clause validity tests for the kernels directive
Reviewed By: sameeranjoshi
Differential Revision: https://reviews.llvm.org/D91873
Stanislav Mekhanoshin [Wed, 25 Nov 2020 20:30:43 +0000 (12:30 -0800)]
[AMDGPU] Annotate vgpr<->agpr spills in asm
Differential Revision: https://reviews.llvm.org/D92125
Marek Kurdej [Mon, 7 Dec 2020 19:07:25 +0000 (20:07 +0100)]
[libc++] [docs] Mark LWG3055 as complete. Use string_view instead of string in path::operator+=(ECharT).
The issue didn't change the behaviour which is tested in libcxx/test/std/input.output/filesystems/class.path/path.member/path.concat.pass.cpp.
The change to use string_view instead of string is not strictly necessary.
<filesystem> was added in commit
998a5c88312066fcc2b2de1358edc76587611354 (Implement <filesystem>).
Reviewed By: #libc, ldionne
Differential Revision: https://reviews.llvm.org/D92731
Florian Hahn [Mon, 7 Dec 2020 18:14:57 +0000 (18:14 +0000)]
[ConstraintElimination] Tweak placement in pipeline.
This patch adds the ConstraintElimination pass to the LTO pipeline and
also runs it after SCCP in the function simplification pipeline.
This increases the number of cases we can elimination. Pending further
tuning.
Jennifer Yu [Fri, 4 Dec 2020 22:54:12 +0000 (14:54 -0800)]
Fix missing error for use of 128-bit integer inside SPIR64 device code.
Emit error for use of 128-bit integer inside device code had been
already implemented in https://reviews.llvm.org/D74387. However,
the error is not emitted for SPIR64, because for SPIR64, hasInt128Type
return true.
hasInt128Type: is also used to control generation of certain 128-bit
predefined macros, initializer predefined 128-bit integer types and
build 128-bit ArithmeticTypes. Except predefined macros, only the
device target is considered, since error only emit when 128-bit
integer is used inside device code, the host target (auxtarget) also
needs to be considered.
The change address:
1. (SPIR.h) Correct hasInt128Type() for SPIR targets.
2. Sema.cpp and SemaOverload.cpp: Add additional check to consider host
target(auxtarget) when call to hasInt128Type. So that __int128_t
and __int128() are allowed to avoid error when they used outside
device code.
3. SemaType.cpp: add check for SYCLIsDevice to delay the error message.
The error will be emitted if the use of 128-bit integer in the device
code.
Reviewed By: Johannes Doerfert and Aaron Ballman
Differential Revision: https://reviews.llvm.org/D92439
Stefan Pintilie [Mon, 7 Dec 2020 18:36:04 +0000 (12:36 -0600)]
[PowerPC] Exploitation of xxeval instruction for AND and NAND
The xxeval instruction was intorduced in Power PC in Power 10.
The instruction accepts three vector registers and an immediate.
Depending on the value of the immediate the instruction can be used
to perform certain bitwise boolean operations (and, or, xor, ...) on
the given vector registers.
This patch implements the AND and NAND patterns that can be used by
the instruction.
Reviewed By: nemanjai, #powerpc, bsaleil, NeHuang, jsji
Differential Revision: https://reviews.llvm.org/D92420
Richard Sandiford [Mon, 7 Dec 2020 18:34:53 +0000 (18:34 +0000)]
[Sema] Make more overload candidate types use iterator_ranges (NFC)
I have a patch that adds another group of candidate types to
BuiltinCandidateTypeSet. Currently two styles are in use: the older
begin/end pairs and the newer iterator_range approach. I think the
group of candidates that I want to add should use iterator ranges,
but I'd also like to consolidate the handling of the new candidates
with some existing code that uses begin/end pairs. This patch therefore
converts the begin/end pairs to iterator ranges as a first step.
No functional change intended.
Differential Revision: https://reviews.llvm.org/D92222
Craig Topper [Mon, 7 Dec 2020 17:45:06 +0000 (09:45 -0800)]
[RISCV] Form GORCI from (or (rotl/rotr X, Bitwidth/2), X).
A rotate by half the bitwidth swaps the bottom and top half which is the same as one of the MSB GREVI stage.
We have to do this as a special combine because we prefer to keep (rotl/rotr X, BitWidth/2) as a rotate rather than a single stage GREVI.
Differential Revision: https://reviews.llvm.org/D92286
Simon Pilgrim [Mon, 7 Dec 2020 18:20:22 +0000 (18:20 +0000)]
[X86] Fix static analyzer warnings. NFCI.
Replace '|' with '||' in condition, and fix case of SignedMode variable.
Simon Pilgrim [Mon, 7 Dec 2020 18:14:26 +0000 (18:14 +0000)]
[DAG] Cleanup by folding some single use VT.getScalarSizeInBits() calls into its comparison. NFCI.
Simon Pilgrim [Mon, 7 Dec 2020 18:10:24 +0000 (18:10 +0000)]
[IPO] Fix operator precedence warning. NFCI.
Check the entire assertion condition before && with the message.
Anton Afanasyev [Mon, 7 Dec 2020 14:27:13 +0000 (17:27 +0300)]
[SLP][Test] Add test for PR46983
AndreyChurbanov [Mon, 7 Dec 2020 16:50:14 +0000 (19:50 +0300)]
[OpenMP] NFC: comment adjusted
Fangrui Song [Mon, 7 Dec 2020 16:46:17 +0000 (08:46 -0800)]
[Parse] Delete unused declarations
Navdeep Kumar [Mon, 7 Dec 2020 09:27:51 +0000 (14:57 +0530)]
[MLIR][Affine] Add affine.for normalization support
Add support to normalize affine.for ops i.e., convert the lower bound to zero
and loop step to one. The Upper bound is set to the trip count of the loop.
The exact value of loopIV is calculated just inside the body of affine.for.
Currently loops with lower bounds having single result are supported. No such
restriction exists on upper bounds.
Differential Revision: https://reviews.llvm.org/D92233
Hans Wennborg [Mon, 7 Dec 2020 16:27:03 +0000 (17:27 +0100)]
Test commit
AndreyChurbanov [Mon, 7 Dec 2020 16:09:07 +0000 (19:09 +0300)]
[OpenMP] libomp: Fix possible NULL dereferences
Check pointer returned by strchr, as it can be NULL in case of broken
format of input string. Introduced new function __kmp_str_loc_numbers
for fast parsing of numbers only in the location string.
Also made some cleanup of __kmp_str_loc_init declaration and usage:
- changed type of init_fname parameter to bool;
- changed input from true to false in places where fname is not used.
Differential Revision: https://reviews.llvm.org/D90962
Yitzhak Mandelbaum [Fri, 4 Dec 2020 15:23:34 +0000 (15:23 +0000)]
[libTooling] Add `describe` combinator for formatting AST nodes for diagnostics.
This new stencil combinator is intended for use in diagnostics and the like.
Differential Revision: https://reviews.llvm.org/D92658
Alexey Bataev [Fri, 4 Dec 2020 17:53:59 +0000 (09:53 -0800)]
[SLP]Merge reorder and reuse shuffles.
It is possible to merge reuse and reorder shuffles and reduce the total
cost of the ivectorization tree/number of final instructions.
Differential Revision: https://reviews.llvm.org/D92668
David Green [Mon, 7 Dec 2020 15:44:40 +0000 (15:44 +0000)]
[ARM] Revert low overhead loops with calls before registry allocation.
This adds code to revert low overhead loops with calls in them before
register allocation. Ideally we would not create low overhead loops with
calls in them to begin with, but that can be difficult to always get
correct. If we want to try and glue together t2LoopDec and t2LoopEnd
into a single instruction, we need to ensure that no instructions use LR
in the loop. (Technically the final code can be better too, as it
doesn't need to use the same registers but that has not been optimized
for here, as reverting loops with calls is expected to be very rare).
It also adds a MVETailPredUtils.h header to share the revert code
between different passes, and provides a place to expand upon, with
RevertLoopWithCall becoming a place to perform other low overhead loop
alterations like removing copies or combining LoopDec and End into a
single instruction.
Differential Revision: https://reviews.llvm.org/D91273
Jon Chesterfield [Mon, 7 Dec 2020 15:23:08 +0000 (15:23 +0000)]
[libomptarget][amdgpu] Add plumbing to call into hostrpc lib, if linked
Andy Wingo [Mon, 30 Nov 2020 15:16:33 +0000 (16:16 +0100)]
[WebAssembly][MC] Fix placement of table section
The table section goes after functions.
Differential Revision: https://reviews.llvm.org/D92323
Jinsong Ji [Mon, 7 Dec 2020 14:50:45 +0000 (09:50 -0500)]
[PowerPC][Clang] Remove QPX support
Clean up QPX code in clang missed in https://reviews.llvm.org/D83915
Reviewed By: #powerpc, steven.zhang
Differential Revision: https://reviews.llvm.org/D92329
Sean Fertile [Mon, 7 Dec 2020 14:28:17 +0000 (09:28 -0500)]
[LLD] Search archives for symbol defs to override COMMON symbols.
This patch changes the archive handling to enable the semantics needed
for legacy FORTRAN common blocks and block data. When we have a COMMON
definition of a symbol and are including an archive, LLD will now
search the members for global/weak defintions to override the COMMON
symbol. The previous LLD behavior (where a member would only be included
if it satisifed some other needed symbol definition) can be re-enabled with the
option '-no-fortran-common'.
Differential Revision: https://reviews.llvm.org/D86142
Michał Górny [Mon, 7 Dec 2020 14:57:44 +0000 (15:57 +0100)]
Revert "[lldb] [POSIX-DYLD] Add libraries from initial eTakeSnapshot action"
This reverts commit
09b08833f301ea375137931d26b7193101f82ceb.
This code is wrong on Linux, and causes ld-linux and linux-vdso to be
reported twice. I need to work on it more.
Nico Weber [Mon, 7 Dec 2020 14:05:46 +0000 (09:05 -0500)]
[lld/mac] Make X86_64::getImplicitAddend not do heap allocations
Speeds up linking Chromium's base_unittests almost 10%. According to ministat:
N Min Max Median Avg Stddev
x 5 0.
72193289 0.
73073196 0.
72560811 0.
72565799 0.
0032265649
+ 5 0.
64069581 0.
67173195 0.
65876389 0.
65796089 0.
011349451
Difference at 95.0% confidence
-0.0676971 +/- 0.0121682
-9.32906% +/- 1.67685%
(Student's t, pooled s = 0.
00834328)
Differential Revision: https://reviews.llvm.org/D92734
Alexey Bataev [Mon, 7 Dec 2020 14:11:28 +0000 (06:11 -0800)]
[SLP]Update test checks, NFC.
Nathan James [Mon, 7 Dec 2020 14:05:49 +0000 (14:05 +0000)]
[clang-tidy][NFC] Streamline CheckOptions error reporting.
Kazushi (Jam) Marukawa [Mon, 7 Dec 2020 10:56:10 +0000 (19:56 +0900)]
[VE] Add vcp and vex intrinsic instructions
Add vcp and vex intrinsic instructions and regression tests.
Reviewed By: simoll
Differential Revision: https://reviews.llvm.org/D92752
Kerry McLaughlin [Mon, 7 Dec 2020 13:20:19 +0000 (13:20 +0000)]
[SVE][CodeGen] Call refineIndexType & refineUniformBase from visitMGATHER
The refineIndexType & refineUniformBase functions added by D90942 can also be used to
improve CodeGen of masked gathers.
These changes were split out from D91092
Reviewed By: sdesmalen
Differential Revision: https://reviews.llvm.org/D92319
Haojian Wu [Mon, 7 Dec 2020 13:02:21 +0000 (14:02 +0100)]
[MemProf] Fix a potential "permission denied" test failure on some systems.
NFC, to make the test more robost.
Petar Avramovic [Mon, 7 Dec 2020 12:59:15 +0000 (13:59 +0100)]
[AMDGPU] Fix default value of glc for mubuf rtn atomics
Mubuf rtn atomics use GLC_1 thus default value for glc operand
should be -1, see https://reviews.llvm.org/D90730.
This allows us to report error when rtn atomic requires glc=1
but does not have glc operand in input.
Differential Revision: https://reviews.llvm.org/D92654
Roman Lebedev [Mon, 7 Dec 2020 12:15:33 +0000 (15:15 +0300)]
[NFC][LoopIdiom] Reshuffle left-shift-until-bittest test coverage (D91038)
Kerry McLaughlin [Mon, 7 Dec 2020 10:39:04 +0000 (10:39 +0000)]
[SVE][CodeGen] Lower scalable masked gathers
Lowers the llvm.masked.gather intrinsics (scalar plus vector addressing mode only)
Changes in this patch:
- Add custom lowering for MGATHER, using getGatherVecOpcode() to choose the appropriate
gather load opcode to use.
- Improve codegen with refineIndexType/refineUniformBase, added in D90942
- Tests added for gather loads with 32 & 64-bit scaled & unscaled offsets.
Reviewed By: sdesmalen
Differential Revision: https://reviews.llvm.org/D91092
Nathan James [Mon, 7 Dec 2020 12:13:56 +0000 (12:13 +0000)]
[clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1
Using bools instead of integers better conveys the expected value of the option.
Reviewed By: Eugene.Zelenko, aaron.ballman
Differential Revision: https://reviews.llvm.org/D92652
Sam McCall [Fri, 4 Dec 2020 08:58:50 +0000 (09:58 +0100)]
Add ability to load a FixedCompilationDatabase from a buffer.
Previously, loading one from a file meant allowing the library to do the IO.
Clangd would prefer to do such IO itself (e.g. to allow caching).
Differential Revision: https://reviews.llvm.org/D92640
Georgii Rymar [Tue, 1 Dec 2020 14:00:03 +0000 (17:00 +0300)]
[llvm-readobj/elf] - Refine the implementation of "printFunctionStackSize".
This rewrites the logic to get rid of "ELFSymbolRef" API where possible.
This allowed to handle possible errors better, improve warnings reported and add new ones.
Also 'reportWarning' was replaced with 'reportUniqueWarning'
Differential revision: https://reviews.llvm.org/D92545
Sam McCall [Mon, 7 Dec 2020 11:54:38 +0000 (12:54 +0100)]
[clangd] Fix windows slashes in project config diagnostics
Sam McCall [Mon, 7 Dec 2020 11:33:34 +0000 (12:33 +0100)]
[clangd] Temporarily test that uncovered broken behavior on windows
Max Kazantsev [Mon, 7 Dec 2020 11:33:07 +0000 (18:33 +0700)]
[Test] Auto-update test checks
Kazushi (Jam) Marukawa [Fri, 4 Dec 2020 11:33:02 +0000 (20:33 +0900)]
[VE] Add vrcp, vrsqrt, vcvt, vmrg, and vshf intrinsic instructions
Add vrcp, vrsqrt, vcvt, vmrg, and vshf intrinsic instructions and
regression tests.
Reviewed By: simoll
Differential Revision: https://reviews.llvm.org/D92750
Pedro Tammela [Sun, 6 Dec 2020 14:30:57 +0000 (14:30 +0000)]
[LLDB] fix error message for one-line breakpoint scripts
LLDB is ignoring compilation errors for one-line breakpoint scripts.
This patch fixes the issues and now the error message of the
ScriptInterpreter is shown to the user.
I had to remove a new-line character for the Lua interpreter since it
was duplicated.
Differential Revision: https://reviews.llvm.org/D92729
Cullen Rhodes [Mon, 30 Nov 2020 11:35:46 +0000 (11:35 +0000)]
[IR] Bail out for scalable vectors in ShuffleVectorInst::isConcat
Shuffle mask for concat can't be expressed for scalable vectors, so we
should bail out. A test has been added that previously crashed, also
tested isIdentityWithPadding and isIdentityWithExtract where we already
bail out.
Reviewed By: sdesmalen
Differential Revision: https://reviews.llvm.org/D92475
Cullen Rhodes [Mon, 30 Nov 2020 11:35:46 +0000 (11:35 +0000)]
[IR] Support scalable vectors in ShuffleVectorInst::increasesLength
Since the length of the llvm::SmallVector shufflemask is related to the
minimum number of elements in a scalable vector, it is fine to just get
the Min field of the ElementCount. This is already done for the similar
function changesLength, tests have been added for both.
Reviewed By: sdesmalen
Differential Revision: https://reviews.llvm.org/D92472
Qiu Chaofan [Mon, 7 Dec 2020 10:31:00 +0000 (18:31 +0800)]
[PowerPC] [Clang] Enable float128 feature on P9 by default
As Power9 introduced hardware support for IEEE quad-precision FP type,
the feature should be enabled by default on Power9 or newer targets.
Reviewed By: steven.zhang
Differential Revision: https://reviews.llvm.org/D90213
Kazushi (Jam) Marukawa [Fri, 4 Dec 2020 11:26:44 +0000 (20:26 +0900)]
[VE] Add vfmad, vfmsb, vfnmad, and vfnmsb intrinsic instructions
Add vfmad, vfmsb, vfnmad, and vfnmsb intrinsic instructions and
regression tests.
Reviewed By: simoll
Differential Revision: https://reviews.llvm.org/D92697
Michał Górny [Mon, 7 Dec 2020 10:20:58 +0000 (11:20 +0100)]
[lldb] [test] Remove duplicate xfail for Testtypedef
The @expectedFailureAll(compiler="clang") decorator works correctly
on FreeBSD these days, so it is sufficient.
Sam McCall [Fri, 4 Dec 2020 23:39:21 +0000 (00:39 +0100)]
[clangd] Publish config file errors over LSP
We don't act as a language server for these files (e.g. don't get open/close
notifications for them), but just blindly publish diagnostics for them.
This works reasonably well in coc.nvim and vscode: they show up in the
workspace diagnostic list and when you open the file.
The only update after the file is reparsed, not as you type which is a bit
janky, but seems a lot better than nothing.
Fixes https://github.com/clangd/clangd/issues/614
Differential Revision: https://reviews.llvm.org/D92704
Haojian Wu [Mon, 7 Dec 2020 09:52:04 +0000 (10:52 +0100)]
[clangd] Add language metrics for recovery AST usage.
Differential Revision: https://reviews.llvm.org/D92157
Hafiz Abid Qadeer [Mon, 7 Dec 2020 09:09:59 +0000 (09:09 +0000)]
Provide default location of sysroot for Baremetal toolchain.
Currently, Baremetal toolchain requires user to pass a sysroot location
using a --sysroot flag. This is not very convenient for the user. It also
creates problem for toolchain vendors who don't have a fixed location to
put the sysroot bits.
Clang does provide 'DEFAULT_SYSROOT' which can be used by the toolchain
builder to provide the default location. But it does not work if toolchain
is targeting multiple targets e.g. arm-none-eabi/riscv64-unknown-elf which
clang is capable of doing.
This patch tries to solve this problem by providing a default location of
the toolchain if user does not explicitly provides --sysroot. The exact
location and name can be different but it should fulfill these conditions:
1. The sysroot path should have a target triple element so that multi-target
toolchain problem (as I described above) could be addressed.
2. The location should not be $TOP/$Triple as this is used by gcc generally
and will be a problem for installing both gcc and clang based toolchain at
the same location.
Reviewed By: jroelofs
Differential Revision: https://reviews.llvm.org/D92677
Oliver Stannard [Mon, 7 Dec 2020 09:04:26 +0000 (09:04 +0000)]
[Lit] Fix flaky test on heavily loaded bots
On some of the slow or heavily-loaded bots, this test was failing
intermittently because the infinite_loop.py script might not emit
anything to stdout before the 1 second timeout, so the "Command Output"
line isn't present in the output. That output isn't really important to
this test, we just care that the process is killed, so we can just rmove
that check line from the test.
Differential revision: https://reviews.llvm.org/D92563
Michał Górny [Mon, 7 Dec 2020 08:31:35 +0000 (09:31 +0100)]
[lldb] [test] Fix continue_to_breakpoint() args in TestThreadStepOut
The test is skipped/xfailing on all platforms, so it seems that the API
got out of sync. Fix that so it returns to a 'proper' failure
on FreeBSD.
Differential Revision: https://reviews.llvm.org/D92746