Panu Matilainen [Wed, 9 Jul 2008 08:55:57 +0000 (11:55 +0300)]
Check for _RPM_4_4_COMPAT in rpmlib.h too
- limits the chances of compat includes not working due to include order
a bit
Panu Matilainen [Tue, 8 Jul 2008 15:35:56 +0000 (18:35 +0300)]
Include legacy compat from rpmlib.h to cover maximum ground
- rpmlib.h is the first thing any old rpm api user includes so this should
cover most cases (only if enabled)
Panu Matilainen [Tue, 8 Jul 2008 15:35:07 +0000 (18:35 +0300)]
Add compat definitions for renamed string functions too
Panu Matilainen [Tue, 8 Jul 2008 15:13:42 +0000 (18:13 +0300)]
Missing cplusplus-wrappers in rpmtd
Panu Matilainen [Tue, 8 Jul 2008 15:11:28 +0000 (18:11 +0300)]
Bunch of dumb macros to make up for renamed functions
- should arrange deprecation warnings on them too...
Panu Matilainen [Tue, 8 Jul 2008 13:49:54 +0000 (16:49 +0300)]
Add deprecation markers for hge etc vector prototypes
Panu Matilainen [Tue, 8 Jul 2008 13:45:44 +0000 (16:45 +0300)]
Add deprecation warnings to all legacy types
Panu Matilainen [Tue, 8 Jul 2008 13:43:46 +0000 (16:43 +0300)]
Compat typedef for Spec -> rpmSpec rename
Panu Matilainen [Tue, 8 Jul 2008 13:42:32 +0000 (16:42 +0300)]
Add mappings from hTAG_t and friends to legacy interfaces
Panu Matilainen [Tue, 8 Jul 2008 13:41:24 +0000 (16:41 +0300)]
Limit the exposure of rpmlegacy.h stuff to bare minimum
Panu Matilainen [Tue, 8 Jul 2008 13:37:23 +0000 (16:37 +0300)]
Shove header legacy interfaces into rpmlegacy.h
- get them out of sight from main header.h
- turn headerSprintf() into macro around headerFormat(), that way
rpmTagTable and rpmHeaderFormats lossage can be hidden away as far
as headerSprintf() use is concerned
Panu Matilainen [Tue, 8 Jul 2008 13:23:22 +0000 (16:23 +0300)]
Add a new legacy compatibility header, kill rpmints.h
- build-time generated rpmints.h causes issues with distcheck and is
not really worth the trouble
- we have all sorts of legacy junk to deal with, sticking them all into
rpmints.h would be just wrong...
Jindrich Novy [Tue, 8 Jul 2008 15:46:54 +0000 (17:46 +0200)]
Initialize optCon
- one could easily segfault the doPatchMacro() code without
the optCon initialization (particularly with jump to "exit" label)
Jindrich Novy [Tue, 8 Jul 2008 15:45:12 +0000 (17:45 +0200)]
Make the default fuzz for %patch is now configurable via macro
- the macro is _default_patch_fuzz
Panu Matilainen [Tue, 8 Jul 2008 10:00:20 +0000 (13:00 +0300)]
Update translations
Panu Matilainen [Tue, 8 Jul 2008 09:59:51 +0000 (12:59 +0300)]
Add ISA-stuff for ia64
Panu Matilainen [Mon, 7 Jul 2008 15:11:59 +0000 (18:11 +0300)]
Missing const in parseUnsignedNum()
Panu Matilainen [Mon, 7 Jul 2008 15:09:49 +0000 (18:09 +0300)]
Teach Fflush() about lzdio
Jindrich Novy [Mon, 7 Jul 2008 12:49:33 +0000 (14:49 +0200)]
Make Source0: equal to Source: again
Jindrich Novy [Mon, 7 Jul 2008 10:59:03 +0000 (12:59 +0200)]
Use proper type in format
Jindrich Novy [Mon, 7 Jul 2008 08:21:30 +0000 (10:21 +0200)]
Remove useless argument to format, d'oh
Panu Matilainen [Mon, 7 Jul 2008 10:28:04 +0000 (13:28 +0300)]
Eliminate couple of timedRead() uses where we control how fd is opened
Panu Matilainen [Mon, 7 Jul 2008 07:52:33 +0000 (10:52 +0300)]
Make verifyAttrs and virtualFileAttributes static
- nothing outside files.c needs
Panu Matilainen [Mon, 7 Jul 2008 07:48:06 +0000 (10:48 +0300)]
Kick out ftpStrerror() and related error code defines
- our url-retrieval error codes depend on the helper used which is
configurable via macros so hardcoding eg curl codes wont work either
- need to figure out something better, pass helper error messages through
FD_t or something...
Panu Matilainen [Mon, 7 Jul 2008 07:42:55 +0000 (10:42 +0300)]
Kick out now unused printNewSpecfile()
Panu Matilainen [Mon, 7 Jul 2008 07:17:21 +0000 (10:17 +0300)]
Kick out ancient, useless and hidden --specedit option
Panu Matilainen [Fri, 4 Jul 2008 15:18:55 +0000 (18:18 +0300)]
Remember to remove ugid.c from POTFILES
Panu Matilainen [Fri, 4 Jul 2008 13:09:42 +0000 (16:09 +0300)]
Stuff rpmio/ugid.[ch] contents to lib/misc.[ch]
- no uses outside librpm itself, and there they can be hidden away from
exported ABI whereas in librpmio they cant
Panu Matilainen [Fri, 4 Jul 2008 12:02:30 +0000 (15:02 +0300)]
Make ufdClose() static, nothing outside rpmio.c needs directly
Panu Matilainen [Fri, 4 Jul 2008 12:00:48 +0000 (15:00 +0300)]
Remove unused ufdGetFile() from librpmio
Panu Matilainen [Fri, 4 Jul 2008 11:53:02 +0000 (14:53 +0300)]
Remove unused _url_debug
Panu Matilainen [Fri, 4 Jul 2008 11:52:47 +0000 (14:52 +0300)]
Bump version to resemble library versioning
Jindrich Novy [Fri, 4 Jul 2008 13:00:09 +0000 (15:00 +0200)]
Really make fuzz=0 default for patches
- and finish the Patch and Source fixup
Jindrich Novy [Fri, 4 Jul 2008 12:58:38 +0000 (14:58 +0200)]
Don't treat Patch and Source as Patch0 and Source0
Panu Matilainen [Fri, 4 Jul 2008 11:33:23 +0000 (14:33 +0300)]
Remove rpmcache from repository
- next to nobody even knew about it, much less used it...
- hardly useful now that solvedb is gone
Panu Matilainen [Fri, 4 Jul 2008 11:22:06 +0000 (14:22 +0300)]
Remove solvedb API and other related stuff
- nobody has used the solvedb for anything in years
- the mechanism + rpmcache are horribly broken on multilib
- solvedb is way too heavyweight to be really usable as a general mechanism
- solver callback hook left in place as that could in theory be usable still
- we need something better to replace this all, getting rid of it now
so we're not stuck with the API forever
Panu Matilainen [Fri, 4 Jul 2008 11:11:47 +0000 (14:11 +0300)]
Kill of rpmtsAvailable()
- long since deprecated and nothing uses it, might as well go
Panu Matilainen [Fri, 4 Jul 2008 10:01:39 +0000 (13:01 +0300)]
Enforce conflicts on colorless files always
- silently swallowing conflicting files when they happen to be in the
same (suitable colored) transaction but conflicting when installed
separately is nothing but inconsistent
- partial fix for rhbz#190209
Panu Matilainen [Fri, 4 Jul 2008 06:17:33 +0000 (09:17 +0300)]
rpmfiFNlink() returns unsigned int
Panu Matilainen [Fri, 4 Jul 2008 06:11:20 +0000 (09:11 +0300)]
Couple of type corrections
- use rpmTag, rpmsenseFlags instead of int32_t
Panu Matilainen [Fri, 4 Jul 2008 06:07:19 +0000 (09:07 +0300)]
Use unsigned integer for epoch, remove unnecessary static
Panu Matilainen [Thu, 3 Jul 2008 14:44:43 +0000 (17:44 +0300)]
Parameter name + doc mismatch on rpmVerifySignature()
Panu Matilainen [Thu, 3 Jul 2008 14:44:13 +0000 (17:44 +0300)]
Change headerPutString() arg name to match the others
- doxygen whines a bit less..
Panu Matilainen [Thu, 3 Jul 2008 14:14:45 +0000 (17:14 +0300)]
Plug leaks in selinux context handling in fsm
Panu Matilainen [Thu, 3 Jul 2008 14:01:52 +0000 (17:01 +0300)]
Plug a memleak on erasure
- on erasure the order of things in ts->order is reverse from that of
rpmtsi-iteration, causing rpmtsiNext() to abort earlier than it should
when things are removed underneath it
- just walk the ts->order table without iteration, it doesn't make any
difference here
Panu Matilainen [Thu, 3 Jul 2008 12:30:04 +0000 (15:30 +0300)]
Make all transaction callback notifications go through rpmtsNotify()
- single point to control how callbacks are made
Panu Matilainen [Thu, 3 Jul 2008 06:11:55 +0000 (09:11 +0300)]
Only try to pubkeys from rpmdb if we non-db keys didn't exist
- try to avoid opening the db unnecessarily, if the keys have been migrated
out of the db, the db probably only has duplicates (right? :)
Panu Matilainen [Wed, 2 Jul 2008 16:07:06 +0000 (19:07 +0300)]
Don't leak memory on duplicate pubkeys
Panu Matilainen [Wed, 2 Jul 2008 16:00:56 +0000 (19:00 +0300)]
Don't leak memory on python expandMacro()
Panu Matilainen [Wed, 2 Jul 2008 15:49:05 +0000 (18:49 +0300)]
Plug a dumb memleak that has crept into rpmReadPackageFile()
- jumps to exit from very early on, make sure sigtd is reset early so
calling rpmtdFreeData() is safe
Panu Matilainen [Wed, 2 Jul 2008 12:08:51 +0000 (15:08 +0300)]
Change rpmts keyring get/set interface to more transparent handling
- add extra parameter to rpmtsGetKeyring() to automatically load up default
keyring if not already set
- rpmtsSetKeyring() with NULL keyring just frees up current keyring
- adjust callers wrt the change
- allows more transparent action for various "legacy" code-paths
Panu Matilainen [Wed, 2 Jul 2008 11:24:20 +0000 (14:24 +0300)]
Add documentation for keyring
Panu Matilainen [Wed, 2 Jul 2008 11:23:30 +0000 (14:23 +0300)]
Make rpmkeyring.h public header
Panu Matilainen [Wed, 2 Jul 2008 10:55:50 +0000 (13:55 +0300)]
Add docs for the new rpmts methods, deprecate rpmtsFindPubkey()
Panu Matilainen [Wed, 2 Jul 2008 10:48:00 +0000 (13:48 +0300)]
Load pubkeys from both files and rpmdb for now
- easy enough and doesn't cost really anything
- at some point, start warning about legacy gpg-keys in rpmdb, suggest
conversion method / do it automatically & such...
Panu Matilainen [Wed, 2 Jul 2008 10:31:12 +0000 (13:31 +0300)]
Some keyring improvements
- keep keyring sorted by keyid, use bsearch for key lookups
- check for key in keyring before adding it to avoid dupes
- actually check that pubkey parameters match the signature on keyring
lookup like was done in rpmtsFindPubkey()
Panu Matilainen [Tue, 1 Jul 2008 14:35:21 +0000 (17:35 +0300)]
Eliminate remaining signature checking bits from rpmts
- rpmdb-specific rpmtsFindPubkey() no longer needed for anything, and
neither are the cached packets and stuff
Panu Matilainen [Tue, 1 Jul 2008 14:32:11 +0000 (17:32 +0300)]
Use keyring even when using pubkeys from rpmdb
- build-time switchable, could easily be run-time too
Panu Matilainen [Tue, 1 Jul 2008 14:00:04 +0000 (17:00 +0300)]
Pass keyring, not the full ts to lowlevel signature routines
- lazy loading of default keyring on ts iteration works nicely for
everything but package signature verification which doesn't access the
db now that the keys are not in the db anymore
- make rpmtsSetKeyring(NULL) load the default keyring, a bit ugly but
it'll have to do for now
Panu Matilainen [Tue, 1 Jul 2008 12:50:05 +0000 (15:50 +0300)]
Eliminate digest calculation statistics from signature code
- if we want them back, they just need to be detached from the ts...
Panu Matilainen [Tue, 1 Jul 2008 12:46:18 +0000 (15:46 +0300)]
Add methods for getting and setting the keyring used by a transaction
- semantics of exactly when and how this is permitted needs more thought...
Panu Matilainen [Tue, 1 Jul 2008 12:38:32 +0000 (15:38 +0300)]
Move keyring related typedefs to rpmtypes.h
Panu Matilainen [Tue, 1 Jul 2008 12:25:06 +0000 (15:25 +0300)]
Proof of concept rpmtsFindPubkey() implementation with the new keyring
- ifdeffed out for now, needs a bit more flesh and a working
import routine
Panu Matilainen [Tue, 1 Jul 2008 12:24:04 +0000 (15:24 +0300)]
Beginnings of an abstract keyring
- in librpmio to avoid dependencies on higher level stuff
- for now it's just an in-memory structure that needs to be populated
by someone simply by feeding in GPG public keys
Panu Matilainen [Tue, 1 Jul 2008 11:35:44 +0000 (14:35 +0300)]
Create ascii armor that rpm itself accepts
Jindrich Novy [Tue, 1 Jul 2008 10:52:16 +0000 (12:52 +0200)]
Update parseNoSource() and addSource() to accept only unsigned SourceXX numbers
Jindrich Novy [Tue, 1 Jul 2008 10:51:08 +0000 (12:51 +0200)]
findSource() eats only unsigned SourceXX numbers
Jindrich Novy [Tue, 1 Jul 2008 10:49:19 +0000 (12:49 +0200)]
doPatchMacro() now uses parseUnsignedNum()
Jindrich Novy [Tue, 1 Jul 2008 10:48:50 +0000 (12:48 +0200)]
doSetupMacro() now uses parseUnsignedNum()
Jindrich Novy [Tue, 1 Jul 2008 10:47:36 +0000 (12:47 +0200)]
doUntar() accepts only unsigned SourceXX numbers
Jindrich Novy [Tue, 1 Jul 2008 10:46:16 +0000 (12:46 +0200)]
Convert doPatch() to use parseUnsignedNum()
Jindrich Novy [Tue, 1 Jul 2008 10:43:47 +0000 (12:43 +0200)]
Use the same number types for SourceXX tags as returned by parseUnsignedNum()
Jindrich Novy [Tue, 1 Jul 2008 10:42:12 +0000 (12:42 +0200)]
Convert Epoch parsing to use parseUnsignedNum()
Jindrich Novy [Tue, 1 Jul 2008 10:41:35 +0000 (12:41 +0200)]
Avoid reading negative constants from SourceXX, PatchXX tags
- convert parseNum() to parseUnsignedNum()
- don't misleadingly declare it to return int, when the result is
always unsigned due to strtoul() call
Panu Matilainen [Tue, 1 Jul 2008 08:22:40 +0000 (11:22 +0300)]
Eliminate the nasty global _dig and _digp variables from rpmpgp
- pass the digest + parameters around as arguments instead
Panu Matilainen [Mon, 16 Jun 2008 14:49:02 +0000 (17:49 +0300)]
Unexport all the umphteen pgp related tables
- nothing outside rpmpgp.c needs
Panu Matilainen [Mon, 16 Jun 2008 14:01:29 +0000 (17:01 +0300)]
Make every pgp function not needed by other parts of rpm static
Panu Matilainen [Mon, 16 Jun 2008 08:12:15 +0000 (11:12 +0300)]
We don't need ts to stash the keyid locally now
Panu Matilainen [Mon, 16 Jun 2008 07:59:23 +0000 (10:59 +0300)]
headerCheck() does not recurse
- it can be re-entered by the way of rpmtsFindPubkey() but that doesn't
matter now as dig etc are local variables
Panu Matilainen [Wed, 25 Jun 2008 08:17:17 +0000 (11:17 +0300)]
Detach pgp digest from transaction set
- pass the pgp container around as argument as needed
- eliminate the related API from rpmts
Panu Matilainen [Sat, 14 Jun 2008 11:48:53 +0000 (14:48 +0300)]
Pass pgpDig around from rpmVerifySignature()
- get the digest once in rpmVerifySignature() and pass to verification
functions, signature is part of the digest so no need for separate call..
Panu Matilainen [Sat, 14 Jun 2008 14:09:50 +0000 (17:09 +0300)]
Detach signature tag data from transaction set
- pass signature tag data around as argument to rpmVerifySignature() as
needed
- eliminate the related API from rpmts
Panu Matilainen [Sat, 14 Jun 2008 11:03:11 +0000 (14:03 +0300)]
Actually use the sigtd passed to verifier functions
Panu Matilainen [Sat, 14 Jun 2008 10:49:37 +0000 (13:49 +0300)]
Start getting signature tag out of transaction set
- collect various signature items into rpmtd and pass around to
verifyFooSignature() checkers
Panu Matilainen [Mon, 30 Jun 2008 12:13:54 +0000 (15:13 +0300)]
(char)NULL doesn't make much sense, use \0 instead
- shuts up another gcc warning
Jindrich Novy [Mon, 30 Jun 2008 10:23:42 +0000 (12:23 +0200)]
Fix missspelling in macro name (_initddir -> _initrddir), thanks to
- Ville Skyttä
- old macro with typo is kept for compatiblity
Panu Matilainen [Mon, 30 Jun 2008 08:28:32 +0000 (11:28 +0300)]
size_t for "left" is wrong, use rpm_loff_t instead
Panu Matilainen [Mon, 30 Jun 2008 08:24:34 +0000 (11:24 +0300)]
strntoul() is supposed to return unsigned long, not int
- the type mismatch busts up handling on largish files...
Panu Matilainen [Fri, 27 Jun 2008 12:15:46 +0000 (15:15 +0300)]
debugedit: Include empty CU current directories (rhbz#444310)
- patch from Jan Kratochvil
Panu Matilainen [Fri, 27 Jun 2008 11:39:39 +0000 (14:39 +0300)]
Use correct formatters for debug-printing in rpmtsInitDSI()
Panu Matilainen [Fri, 27 Jun 2008 10:49:48 +0000 (13:49 +0300)]
Use correct formatters for debug-printing sizes in printSize()
- on x86_64 size_t happens to be 64bit, not so on x86...
Panu Matilainen [Fri, 27 Jun 2008 10:02:23 +0000 (13:02 +0300)]
Adjust python callback for amount+total type change
Panu Matilainen [Thu, 26 Jun 2008 14:52:31 +0000 (17:52 +0300)]
Argh, the tag is LONGSIZE, not LARGESIZE
Jindrich Novy [Thu, 26 Jun 2008 13:58:40 +0000 (15:58 +0200)]
Take new directory into account in rpmbuild test
Jindrich Novy [Thu, 26 Jun 2008 13:56:55 +0000 (15:56 +0200)]
Add new BUILDROOT directory to default rpm build dirs.
Jindrich Novy [Thu, 26 Jun 2008 13:56:11 +0000 (15:56 +0200)]
Add new macros for enabling default build root
Panu Matilainen [Thu, 26 Jun 2008 13:37:06 +0000 (16:37 +0300)]
Make --info work on large packages too
Panu Matilainen [Thu, 26 Jun 2008 13:34:32 +0000 (16:34 +0300)]
Teach build about 64bit payload etc size tags
- only use 64bit variants for packages that actually need it to avoid
breaking compatibility when not needed
- old rpm will bail out "cleanly" (with an obscure error message) if
the 32bit size tags are missing but at least it doesn't crash...
Panu Matilainen [Thu, 26 Jun 2008 13:28:17 +0000 (16:28 +0300)]
Teach rpmAddSignature() and rpmReadSignature() about 64bit tags
- use 64bit size if it exists, otherwise quietly fall back to 32bit one
- can't use tag extensions to convert there as legacy sigtags conflict
with things like RPMTAG_NAME
Panu Matilainen [Thu, 26 Jun 2008 13:23:56 +0000 (16:23 +0300)]
RPMTAG_LONGSIGSIZE and RPMTAG_LONGARCHIVESIZE are signature tags
- move them from regular tag space to sigtag space, fortunately these
don't require special conversion