platform/upstream/gcc.git
4 years agore PR rtl-optimization/92882 (ICE in regstat_bb_compute_calls_crossed, at regstat...
Jakub Jelinek [Tue, 10 Dec 2019 21:05:59 +0000 (22:05 +0100)]
re PR rtl-optimization/92882 (ICE in regstat_bb_compute_calls_crossed, at regstat.c:327 since r279124)

PR rtl-optimization/92882
* regstat.c (regstat_bb_compute_calls_crossed): Don't check
INSN_UID against DF_INSN_SIZE or use DF_INSN_INFO_GET unless
NONDEBUG_INSN_P.

* gfortran.dg/pr92882.f: New test.

From-SVN: r279196

4 years agore PR ipa/92883 (ICE in compare_values_warnv)
Jakub Jelinek [Tue, 10 Dec 2019 21:04:57 +0000 (22:04 +0100)]
re PR ipa/92883 (ICE in compare_values_warnv)

PR ipa/92883
* ipa-cp.c (propagate_vr_across_jump_function): Pass jvr rather
than *jfunc->m_vr to intersect.  Formatting fix.

* gcc.dg/ipa/pr92883.c: New test.

From-SVN: r279194

4 years agore PR middle-end/92825 (Unnecesary stack protection in Firefox's LightPixel.)
Jakub Jelinek [Tue, 10 Dec 2019 21:04:08 +0000 (22:04 +0100)]
re PR middle-end/92825 (Unnecesary stack protection in Firefox's LightPixel.)

PR middle-end/92825
* cfgexpand.c (add_stack_protection_conflicts): Change return type
from void to bool, return true if at least one stack_vars[i].decl
is addressable.
(record_or_union_type_has_array_p, stack_protect_decl_p): Remove.
(expand_used_vars): Don't call stack_protect_decl_p, instead for
-fstack-protector-strong set gen_stack_protect_signal to true
if add_stack_protection_conflicts returned true.  Formatting fixes.
* doc/invoke.texi (-fstack-protector-strong): Clarify that optimized
out variables or variables not living on the stack don't count.
(-fstack-protector): Likewise.  Clarify it affects >= 8 byte arrays
rather than > 8 byte.

* gcc.target/i386/pr92825.c: New test.

From-SVN: r279193

4 years ago* ipa-param-manipulation.c
Jakub Jelinek [Tue, 10 Dec 2019 20:35:30 +0000 (21:35 +0100)]
* ipa-param-manipulation.c
(ipa_param_body_adjustments::register_replacement): Fix comment typo
- accross -> across.
* ipa-sra.c (propagate_used_across_scc_edge, ipa_sra_analysis):
Likewise.
(param_splitting_across_edge): Fix typo in dump message - accross
-> across.

From-SVN: r279188

4 years agoPR c++/92847 - C++20 comparison ambiguity with class template.
Jason Merrill [Tue, 10 Dec 2019 20:12:50 +0000 (15:12 -0500)]
PR c++/92847 - C++20 comparison ambiguity with class template.

This testcase demonstrates that looking at cand->template_decl is not a good
starting place for finding the most general template, as it is only set for
primary templates.

* call.c (cand_parms_match): Handle all templated functions.

From-SVN: r279185

4 years agoFix C++20 structural type vs. private base.
Jason Merrill [Tue, 10 Dec 2019 20:10:59 +0000 (15:10 -0500)]
Fix C++20 structural type vs. private base.

In my patch to implement C++20 "structural type" I tried to set the access
flags on the artificial base fields appropriately, but failed.  I was
copying TREE_PRIVATE from the binfo, but TREE_PRIVATE on binfo is just a
temporary cache for dfs_access_in_type; we really need to get the
inheritance access information from BINFO_BASE_ACCESSES.

* class.c (build_base_field_1): Take access parameter.
(build_base_field): Likewise.
(build_base_fields, layout_virtual_bases): Pass it.
* tree.c (structural_type_p): Improve private base diagnostic.

From-SVN: r279184

4 years agoPR c++/92560 - ICE with decltype and rewritten operator.
Jason Merrill [Tue, 10 Dec 2019 20:06:58 +0000 (15:06 -0500)]
PR c++/92560 - ICE with decltype and rewritten operator.

A call as the immediate operand of decltype is handled differently; we don't
create an object of the return type as we do normally.  But in the case of a
rewritten operator, we're adding another call as a wrapper, so the inner
call doesn't get the special handling.

* call.c (build_new_op_1): Clear tf_decltype on inner call.

From-SVN: r279183

4 years agoBail out in gfc_dep_compare_expr for a NULL argument.
Martin Liska [Tue, 10 Dec 2019 18:57:30 +0000 (19:57 +0100)]
Bail out in gfc_dep_compare_expr for a NULL argument.

2019-12-10  Martin Liska  <mliska@suse.cz>

PR fortran/92874
* dependency.c (gfc_dep_compare_expr): Bail out
when one of the arguments is null.
2019-12-10  Martin Liska  <mliska@suse.cz>

PR fortran/92874
* gfortran.dg/pr92874.f90: New test.

From-SVN: r279181

4 years agore PR fortran/92863 (ICE in gfc_typename)
Thomas Koenig [Tue, 10 Dec 2019 18:31:33 +0000 (18:31 +0000)]
re PR fortran/92863 (ICE in gfc_typename)

2019-12-10  Thomas Koenig  <tkoenig@gcc.gnu.org>

    PR fortran/92863
    * misc.c (gfc_typename): If derived component is NULL for
    derived or class, return "invalid type" or "invalid class",
    respectively.

2019-12-10  Thomas Koenig  <tkoenig@gcc.gnu.org>

    PR fortran/92863
    * gfortran.dg/interface_45.f90: New test.

From-SVN: r279180

4 years agocgraph.c (cgraph_node::verify_node): Verify tp_first_run.
Jan Hubicka [Tue, 10 Dec 2019 17:59:43 +0000 (17:59 +0000)]
cgraph.c (cgraph_node::verify_node): Verify tp_first_run.

* cgraph.c (cgraph_node::verify_node): Verify tp_first_run.
* cgraph.h (cgrpah_node): Turn tp_first_run back to int.
* cgraphunit.c (tp_first_run_node_cmp): Do not watch for overflows.
(expand_all_functions): First expand ordered section and then
unordered.
* profile.c (compute_value_histograms): Error on out of range
tp_first_runs.

From-SVN: r279179

4 years agoTurn tp_first_run counts back to 32bit values.
Jan Hubicka [Tue, 10 Dec 2019 17:54:41 +0000 (17:54 +0000)]
Turn tp_first_run counts back to 32bit values.

* cgraph.c (cgraph_node::verify_node): Verify tp_first_run.
* cgraph.h (cgrpah_node): Turn tp_first_run back to int.
* cgraphunit.c (tp_first_run_node_cmp): Do not watch for overflows.
(expand_all_functions): First expand ordered section and then
unordered.
* lto-partition.c (lto_balanced_map): Fix printing of tp_first_run.
* profile.c (compute_value_histograms): Error on out of range
tp_first_runs.

From-SVN: r279178

4 years agopredict.c (compute_function_frequency): Check for presence of IPA profile.
Jan Hubicka [Tue, 10 Dec 2019 17:47:28 +0000 (18:47 +0100)]
predict.c (compute_function_frequency): Check for presence of IPA profile.

* predict.c (compute_function_frequency): Check for presence of IPA
profile.

From-SVN: r279177

4 years agovarasm.c (default_function_section): Fix confused tests for tp_first_run reordering.
Jan Hubicka [Tue, 10 Dec 2019 17:46:33 +0000 (18:46 +0100)]
varasm.c (default_function_section): Fix confused tests for tp_first_run reordering.

* varasm.c (default_function_section): Fix confused tests for
tp_first_run reordering.

From-SVN: r279176

4 years agolibstdc++: Fix description of std::ios::trunc (PR 92886)
Jonathan Wakely [Tue, 10 Dec 2019 17:35:42 +0000 (17:35 +0000)]
libstdc++: Fix description of std::ios::trunc (PR 92886)

PR libstdc++/92886
* include/bits/ios_base.h (std::ios_base::trunc): Fix comment.

From-SVN: r279175

4 years ago[AArch64] Don't allow partial SVE modes in GPRs
Richard Sandiford [Tue, 10 Dec 2019 16:46:05 +0000 (16:46 +0000)]
[AArch64] Don't allow partial SVE modes in GPRs

With -msve-vector-bits=N, the payload of some partial SVE modes can
be 16 bytes or smaller, which makes them small enough to fit in a
pair of GPRs.  We specifically don't want that, because the payload
is distributed evenly across the SVE register rather than collected
at one end.  Marshalling it into a GPR via register operations would
be expensive.

2019-12-10  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* config/aarch64/aarch64.c (aarch64_hard_regno_mode_ok): Don't
allow SVE modes in GPRs.

gcc/testsuite/
* gcc.target/aarch64/sve/mixed_size_7.c: New test.

From-SVN: r279174

4 years ago[AArch64] Fix INDEX patterns for partial VNx2 modes
Richard Sandiford [Tue, 10 Dec 2019 16:32:40 +0000 (16:32 +0000)]
[AArch64] Fix INDEX patterns for partial VNx2 modes

The INDEX patterns handle partial modes by choosing the container
size rather than the element size, so that the number of lanes
(and thus number of additions) matches the mode.  This means that
all VNx4 modes use .s and all VNx2 modes use .d, etc.

When adding this, I'd forgotten that the choice between Wn and Xn
registers would need to be updated to use the container size too.
For partial VNx2s, we were using .d containers with Wn rather than
Xn source registers.

2019-12-10  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* config/aarch64/iterators.md (vccore): New iterator.
* config/aarch64/aarch64-sve.md (vec_series<mode>): Use it instead
of vwcore.
(*vec_series<mode>_plus): Likewise.

gcc/testsuite/
* gcc.target/aarch64/sve/mixed_size_6.c: New test.

From-SVN: r279173

4 years agolibstdc++: Define __cpp_lib_constexpr_complex macro
Jonathan Wakely [Tue, 10 Dec 2019 16:15:59 +0000 (16:15 +0000)]
libstdc++: Define __cpp_lib_constexpr_complex macro

This is LWG issue 3349.

* include/std/complex (__cpp_lib_constexpr_complex): Define.
* include/std/version (__cpp_lib_constexpr_complex): Likewise.
* testsuite/26_numerics/complex/1.cc: New test.
* testsuite/26_numerics/complex/2.cc: New test.

From-SVN: r279172

4 years agolibstdc++: Reduce header dependencies in <span>
Jonathan Wakely [Tue, 10 Dec 2019 16:15:55 +0000 (16:15 +0000)]
libstdc++: Reduce header dependencies in <span>

* include/std/span: Do not include <tuple> and <utility>.
(tuple_size, tuple_element): Declare.

From-SVN: r279171

4 years agolibstdc++: Fix bug in std::indirect_result_t
Jonathan Wakely [Tue, 10 Dec 2019 16:15:49 +0000 (16:15 +0000)]
libstdc++: Fix bug in std::indirect_result_t

The alias template wasn't working because it applied iter_reference_t to
the pack of iterators before and after passing the pack to the
__indeirect_result helper.

* include/bits/iterator_concepts.h (indirect_result_t): Do not apply
iter_reference_t to parameter pack.
* testsuite/24_iterators/indirect_callable/projected.cc: New test.

From-SVN: r279170

4 years agoAdd tests to verify OpenACC clause locations
Frederik Harwath [Tue, 10 Dec 2019 16:12:58 +0000 (16:12 +0000)]
Add tests to verify OpenACC clause locations

Check that the column information for OpenACC clauses is communicated correctly
to the middle-end, in particular by the Fortran front-end (cf. PR 92793).

2019-12-10  Frederik Harwath  <frederik@codesourcery.com>

gcc/testsuite/
* c-c++-common/goacc/clause-locations.c: New test.
* gfortran.dg/goacc/clause-locations.f90: New test.

From-SVN: r279169

4 years agoUse clause locations in OpenACC nested reduction warnings
Frederik Harwath [Tue, 10 Dec 2019 16:06:12 +0000 (16:06 +0000)]
Use clause locations in OpenACC nested reduction warnings

Since the Fortran front-end now sets the clause locations correctly, we can
emit warnings with more precise locations if we encounter conflicting
operations for a variable in reduction clauses.

2019-12-10  Frederik Harwath  <frederik@codesourcery.com>

gcc/
* omp-low.c (scan_omp_for): Use clause location in warning.

From-SVN: r279168

4 years agoAdd myself to MAINTAINERS file.
Lewis Hyatt [Tue, 10 Dec 2019 14:21:22 +0000 (14:21 +0000)]
Add myself to MAINTAINERS file.

2019-12-10  Lewis Hyatt  <lhyatt@gmail.com>

        * MAINTAINERS (Write After Approval): Add myself.

From-SVN: r279167

4 years agoMake dwarf2out punt for MODE_VECTOR_BOOL
Richard Sandiford [Tue, 10 Dec 2019 12:20:20 +0000 (12:20 +0000)]
Make dwarf2out punt for MODE_VECTOR_BOOL

The dwarf2 handling of vector constants currently divides the vector
into a length (number of elements) and byte element size.  This doesn't
work well for MODE_VECTOR_BOOL, where several elements are packed into
the same byte.

We should probably add a way of encoding this in future, but for now
the safest thing is to punt, like we already do for variable-length
vectors.

2019-12-10  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* dwarf2out.c (loc_descriptor): Punt for MODE_VECTOR_BOOL.
(add_const_value_attribute): Likewise.

gcc/testsuite/
* gcc.target/aarch64/sve/acle/general/debug_4.c: New test.

From-SVN: r279165

4 years agoAdd missing conversion in vect_create_epilog_for_reduction
Richard Sandiford [Tue, 10 Dec 2019 12:20:12 +0000 (12:20 +0000)]
Add missing conversion in vect_create_epilog_for_reduction

The direct_slp_reduc code in vect_create_epilog_for_reduction was
still assuming that all types involved in a reduction are the same
(up to types_compatible_p), whereas we now support differences in
sign.  This was causing an ICE in gcc.dg/vect/pr92324-4.c for SVE.

2019-12-10  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vect-loop.c (vect_create_epilog_for_reduction): When
handling direct_slp_reduc, allow the PHI arguments to have
a different type from the vector elements.

From-SVN: r279164

4 years agoRecord the loop masks needed for EXTRACT_LAST_REDUCTIONs
Richard Sandiford [Tue, 10 Dec 2019 12:20:07 +0000 (12:20 +0000)]
Record the loop masks needed for EXTRACT_LAST_REDUCTIONs

The analysis phase of vectorizable_condition wasn't recording the
loop masks needed by the transform phase.  This meant that the masks
wouldn't be created in the (rare) case that no other statement needed
them.

2019-12-10  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vect-stmts.c (vectorizable_condition): Record the loop
masks required for extract-last reductions.

gcc/testsuite/
* gcc.target/aarch64/sve/clastb_9.c: New test.

From-SVN: r279163

4 years agoFix EXTRACT_LAST_REDUCTION handling of pattern stmts
Richard Sandiford [Tue, 10 Dec 2019 12:20:02 +0000 (12:20 +0000)]
Fix EXTRACT_LAST_REDUCTION handling of pattern stmts

Unlike most vector ops, extract-last reductions replace the original
scalar code in-situ rather than adding an adjacent vector implementation.
I.e.:

   dest_1 = COND_EXPR <...>;

becomes:

   dest_1 = .EXTRACT_LAST (...);

gcc.dg/vect/vect-cond-reduc-4.c was ICEing for SVE because we tried
to replace the pattern statement in this way, rather than replacing
the original scalar statement.

2019-12-10  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vect-stmts.c (vect_finish_replace_stmt): Always use the
original scalar statement rather than a pattern statement.
(vectorizable_condition): Likewise, in the handling of extract-last
reductions.

From-SVN: r279162

4 years agoDisallow EXTRACT_LAST_REDUCTION for reduction chains
Richard Sandiford [Tue, 10 Dec 2019 11:30:49 +0000 (11:30 +0000)]
Disallow EXTRACT_LAST_REDUCTION for reduction chains

gcc.dg/vect/vect-cond-reduc-5.c was ICEing for SVE because we
tried to use an extract-last reduction for a chain of COND_EXPRs.
Adding support for the chained case would be too invasive for stage 3
so this patch explicitly forbids it instead.  I've filed PR92884 for
the possible future work.

2019-12-10  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vect-loop.c (vectorizable_reduction): Don't use
EXTRACT_LAST_REDUCTION for chained reductions.

From-SVN: r279161

4 years agoFortran] PR 92872 – Fix get_CFI_desc
Tobias Burnus [Tue, 10 Dec 2019 10:32:12 +0000 (10:32 +0000)]
Fortran] PR 92872 – Fix get_CFI_desc

        PR fortran/92872
        * trans-array.c (get_CFI_desc): Fix cond whether saved desc exists.

        PR fortran/92872
        * gfortran.dg/bind_c_optional-1.f90: New.

From-SVN: r279160

4 years agoCheck for TYPE_DECL in get_odr_name_for_type
Richard Sandiford [Tue, 10 Dec 2019 09:17:34 +0000 (09:17 +0000)]
Check for TYPE_DECL in get_odr_name_for_type

Make get_odr_name_for_type check for TYPE_DECL in the way that
its caller warn_types_mismatch previously did.

2019-12-10  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* ipa-utils.h (get_odr_name_for_type): Check for a TYPE_DECL.
* ipa-devirt.c (warn_types_mismatch): Don't call xstrdup for the
second demangled name.

gcc/testsuite/
* gcc.dg/lto/tag-1_0.c, gcc.dg/lto/tag-1_1.c: New test.

From-SVN: r279159

4 years agoavx512f-vmovntpd-2.c: Ensure res is 64-byte aligned.
Jakub Jelinek [Tue, 10 Dec 2019 09:02:15 +0000 (10:02 +0100)]
avx512f-vmovntpd-2.c: Ensure res is 64-byte aligned.

* gcc.target/i386/avx512f-vmovntpd-2.c: Ensure res is 64-byte aligned.
* gcc.target/i386/avx512f-vmovntps-2.c: Likewise.

From-SVN: r279158

4 years ago* config/i386/i386.c (IX86_LEA_PRIORITY): Fix comment typos.
Jakub Jelinek [Tue, 10 Dec 2019 09:01:39 +0000 (10:01 +0100)]
* config/i386/i386.c (IX86_LEA_PRIORITY): Fix comment typos.

From-SVN: r279157

4 years agoFix typos in 2 functions.
Martin Liska [Tue, 10 Dec 2019 08:36:56 +0000 (09:36 +0100)]
Fix typos in 2 functions.

2019-12-10  Martin Liska  <mliska@suse.cz>

PR tree-optimization/92862
* predict.c (predict_paths_leading_to_edge): Fix typo from e to e2.
* tree-ssa-loop-niter.c (loop_only_exit_p): Return false
instead of true;

From-SVN: r279156

4 years agolibbacktrace: remove duplicate low_pc/high_pc/range handling
Ian Lance Taylor [Tue, 10 Dec 2019 03:41:49 +0000 (03:41 +0000)]
libbacktrace: remove duplicate low_pc/high_pc/range handling

* dwarf.c (struct pcrange): Define.
(update_pcrange, add_ranges): New static functions.
(add_unit_addr): Change signature to work with add_ranges.  Don't
add base_address here.
(add_unit_ranges): Remove.
(find_address_ranges): Replace str/ranges parameters with
dwarf_sections.  Use update_pcrange and add_ranges.  Change all
callers.
(add_function_range): Change signature to work with add_ranges.
Don't add base_address here.
(add_function_ranges): Remove.
(read_function_entry): Use update_pcrange and add_ranges.

From-SVN: r279154

4 years agoReplace label_text ctor with "borrow" and "take"
David Malcolm [Tue, 10 Dec 2019 02:02:38 +0000 (02:02 +0000)]
Replace label_text ctor with "borrow" and "take"

libcpp's label_text class wraps a text buffer, along with a flag to
determine if it "owns" the buffer.

The existing ctor exposed this directly, but I found it difficult
to remember the sense of flag, so this patch hides the ctor, in
favor of static member functions "borrow" and "take", to make
the effect on ownership explicit in the name.

gcc/c-family/ChangeLog:
* c-format.c (range_label_for_format_type_mismatch::get_text):
Replace label_text ctor called with true with label_text::take.

gcc/c/ChangeLog:
* c-objc-common.c (range_label_for_type_mismatch::get_text):
Replace label_text ctor calls.

gcc/cp/ChangeLog:
* error.c (range_label_for_type_mismatch::get_text): Replace
label_text ctor calls with label_text::borrow.

gcc/ChangeLog:
* gcc-rich-location.c
(maybe_range_label_for_tree_type_mismatch::get_text): Replace
label_text ctor call with label_text::borrow.
* gcc-rich-location.h (text_range_label::get_text): Replace
label_text ctor called with false with label_text::borrow.

libcpp/ChangeLog:
* include/line-map.h (label_text::label_text): Make private.
(label_text::borrow): New.
(label_text::take): New.
(label_text::take_or_copy): New.

From-SVN: r279153

4 years agodiagnostic_show_locus: move initial newline to callers
David Malcolm [Tue, 10 Dec 2019 01:48:42 +0000 (01:48 +0000)]
diagnostic_show_locus: move initial newline to callers

diagnostic_show_locus adds a newline before doing anything (including
the do-nothing-else case).

This patch removes this initial newline, adding it to all callers
of diagnostic_show_locus instead.

Doing so makes diagnostic_show_locus more flexible, allowing it to be
used in my analyzer patch kit for printing diagnostic paths.

gcc/c-family/ChangeLog:
* c-format.c (selftest::test_type_mismatch_range_labels): Remove
initial newline from expected outputs.
* c-opts.c (c_diagnostic_finalizer): Add pp_newline call before
call to diagnostic_show_locus.

gcc/ChangeLog:
* diagnostic-show-locus.c (diagnostic_show_locus): Remove initial
newline.
(selftest::test_diagnostic_show_locus_unknown_location): Remove
initial newline from expected outputs.
(selftest::test_one_liner_simple_caret): Likewise.
(selftest::test_one_liner_caret_and_range): Likewise.
(selftest::test_one_liner_multiple_carets_and_ranges): Likewise.
(selftest::test_one_liner_fixit_insert_before): Likewise.
(selftest::test_one_liner_fixit_insert_after): Likewise.
(selftest::test_one_liner_fixit_remove): Likewise.
(selftest::test_one_liner_fixit_replace): Likewise.
(selftest::test_one_liner_fixit_replace_non_equal_range):
Likewise.
(selftest::test_one_liner_fixit_replace_equal_secondary_range):
Likewise.
(selftest::test_one_liner_fixit_validation_adhoc_locations):
Likewise.
(selftest::test_one_liner_many_fixits_1): Likewise.
(selftest::test_one_liner_many_fixits_2): Likewise.
(selftest::test_one_liner_labels): Likewise.
(selftest::test_one_liner_simple_caret_utf8): Likewise.
(selftest::test_one_liner_caret_and_range_utf8): Likewise.
(selftest::test_one_liner_multiple_carets_and_ranges_utf8):
Likewise.
(selftest::test_one_liner_fixit_insert_before_utf8): Likewise.
(selftest::test_one_liner_fixit_insert_after_utf8): Likewise.
(selftest::test_one_liner_fixit_remove_utf8): Likewise.
(selftest::test_one_liner_fixit_replace_utf8): Likewise.
(selftest::test_one_liner_fixit_replace_non_equal_range_utf8):
Likewise.
(selftest::test_one_liner_fixit_replace_equal_secondary_range_utf8):
Likewise.
(selftest::test_one_liner_fixit_validation_adhoc_locations_utf8):
Likewise.
(selftest::test_one_liner_many_fixits_1_utf8): Likewise.
(selftest::test_one_liner_many_fixits_2_utf8): Likewise.
(selftest::test_one_liner_labels_utf8): Likewise.
(selftest::test_add_location_if_nearby): Likewise.
(selftest::test_diagnostic_show_locus_fixit_lines): Likewise.
(selftest::test_overlapped_fixit_printing): Likewise.
(selftest::test_overlapped_fixit_printing_utf8): Likewise.
(selftest::test_overlapped_fixit_printing_2): Likewise.
(selftest::test_fixit_insert_containing_newline): Likewise.
(selftest::test_fixit_insert_containing_newline_2): Likewise.
(selftest::test_fixit_replace_containing_newline): Likewise.
(selftest::test_fixit_deletion_affecting_newline): Likewise.
(selftest::test_line_numbers_multiline_range): Likewise.
* diagnostic.c (default_diagnostic_finalizer): Add pp_newline call
before call to diagnostic_show_locus.
(diagnostic_append_note): Likewise.

gcc/fortran/ChangeLog:
* error.c (gfc_diagnostic_starter): Add pp_newline call before
call to diagnostic_show_locus.

gcc/testsuite/ChangeLog:
* gcc.dg/plugin/diagnostic_plugin_test_show_locus.c
(custom_diagnostic_finalizer): Add pp_newline call before call to
diagnostic_show_locus.

From-SVN: r279152

4 years agoDaily bump.
GCC Administrator [Tue, 10 Dec 2019 00:16:19 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r279150

4 years ago[PR92116, PR92877] [OpenACC] Replace 'openacc.data_environ' by standard libgomp mechanics
Thomas Schwinge [Mon, 9 Dec 2019 22:52:56 +0000 (23:52 +0100)]
[PR92116, PR92877] [OpenACC] Replace 'openacc.data_environ' by standard libgomp mechanics

libgomp/
PR libgomp/92116
PR libgomp/92877
* oacc-mem.c (lookup_dev): Reimplement.  Adjust all users.
* libgomp.h (struct acc_dispatch_t): Remove 'data_environ' member.
Adjust all users.
* testsuite/libgomp.oacc-c-c++-common/acc_free-pr92503-4-2.c:
Remove XFAIL.
* testsuite/libgomp.oacc-c-c++-common/acc_free-pr92503-4.c:
Likewise.
* testsuite/libgomp.oacc-c-c++-common/pr92877-1.c: New file.

Co-Authored-By: Julian Brown <julian@codesourcery.com>
From-SVN: r279147

4 years ago[PR92503] [OpenACC] Don't silently 'acc_unmap_data' in 'acc_free'
Thomas Schwinge [Mon, 9 Dec 2019 22:52:47 +0000 (23:52 +0100)]
[PR92503] [OpenACC] Don't silently 'acc_unmap_data' in 'acc_free'

libgomp/
PR libgomp/92503
* oacc-mem.c (acc_free): Error out instead of 'acc_unmap_data'.
* testsuite/libgomp.oacc-c-c++-common/acc_free-pr92503-1.c: New
file.
* testsuite/libgomp.oacc-c-c++-common/acc_free-pr92503-2.c:
Likewise.
* testsuite/libgomp.oacc-c-c++-common/acc_free-pr92503-3-2.c:
Likewise.
* testsuite/libgomp.oacc-c-c++-common/acc_free-pr92503-3.c:
Likewise.
* testsuite/libgomp.oacc-c-c++-common/acc_free-pr92503-4-2.c:
Likewise.
* testsuite/libgomp.oacc-c-c++-common/acc_free-pr92503-4.c:
Likewise.
* testsuite/libgomp.oacc-c-c++-common/clauses-1.c: Adjust.
* testsuite/libgomp.oacc-c-c++-common/context-1.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/context-2.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/context-3.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/context-4.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-13.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-14.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-18.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-91.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/nested-1.c: Likewise.

From-SVN: r279146

4 years ago[PR92840] [OpenACC] Refuse 'acc_unmap_data' unless mapped by 'acc_map_data'
Thomas Schwinge [Mon, 9 Dec 2019 22:52:36 +0000 (23:52 +0100)]
[PR92840] [OpenACC] Refuse 'acc_unmap_data' unless mapped by 'acc_map_data'

libgomp/
PR libgomp/92840
* oacc-mem.c (acc_map_data): Clarify reference counting behavior.
(acc_unmap_data): Add error case for 'REFCOUNT_INFINITY'.
* testsuite/libgomp.oacc-c-c++-common/acc_unmap_data-pr92840-1.c:
New file.
* testsuite/libgomp.oacc-c-c++-common/acc_unmap_data-pr92840-2.c:
Likewise.
* testsuite/libgomp.oacc-c-c++-common/acc_unmap_data-pr92840-3.c:
Likewise.
* testsuite/libgomp.oacc-c-c++-common/clauses-1.c: Adjust.
* testsuite/libgomp.oacc-c-c++-common/nested-1.c: Adjust.

From-SVN: r279145

4 years agoPR middle-end/92761 - hash_table::expand invokes assignment on invalid objects
Martin Sebor [Mon, 9 Dec 2019 20:54:11 +0000 (20:54 +0000)]
PR middle-end/92761 - hash_table::expand invokes assignment on invalid objects

PR middle-end/92761 - hash_table::expand invokes assignment on invalid objects
PR middle-end/92762 - hash_table::empty_slow invokes assignment on invalid objects

gcc/ChangeLog:

PR middle-end/92761
PR middle-end/92762
* hash-map-tests.c (test_map_of_type_with_ctor_and_dtor): Tighten
up tests.
* hash-table.h (hash_table::expand): Use placement new to copy
construct objects in uninitialized storage.
(hash_table::empty_slow): Avoid invoking copy assignment on
uninitialized objects.

From-SVN: r279139

4 years agotypeck.c (check_for_casting_away_constness): Add location_t parameter and use it.
Paolo Carlini [Mon, 9 Dec 2019 20:28:39 +0000 (20:28 +0000)]
typeck.c (check_for_casting_away_constness): Add location_t parameter and use it.

gcc/cp
2019-12-09  Paolo Carlini  <paolo.carlini@oracle.com>

* typeck.c (check_for_casting_away_constness): Add location_t
parameter and use it.
(maybe_warn_about_useless_cast): Likewise.
(maybe_warn_about_cast_ignoring_quals): Likewise.
(build_static_cast_1): Likewise.
(build_static_cast): Likewise; sets the location of the returned tree.
(build_reinterpret_cast_1): Likewise.
(build_reinterpret_cast): Likewise; sets the location of the returned
tree.
(build_const_cast_1): Likewise.
(build_const_cast): Likewise; sets the location of the returned tree.
(cp_build_c_cast): Likewise.
(build_c_cast): Adjust.
(build_ptrmemfunc): Adjust calls.
(cp_build_unary_op): Pass the location to invert_truthvalue_loc.
* rtti.c (build_dynamic_cast_1): Add location_t parameter and
use it.
(build_dynamic_cast): Likewise.
* cp-tree.h: Adjust declarations.
* parser.c (cp_parser_postfix_expression): Pass cp_cast_loc to
the various build_*_cast functions.
(get_cast_suggestion): Adjust calls.
(cp_parser_builtin_offsetof): Likewise.
* decl.c (reshape_init): Adjust call.
* method.c (forward_parm): Likewise.
(build_comparison_op): Likewise.
* pt.c (tsubst_copy_and_build): Likewise.
* semantics.c (finish_omp_reduction_clause): Likewise.
(cp_omp_finish_iterators): Likewise.
* tree.c (cp_stabilize_reference): Likewise.
(move): Likewise.
* typeck2.c (build_functional_cast): Likewise.

* typeck2.c (build_functional_cast_1): New.
(build_functional_cast_1): Calls the latter and sets the location
of the returned tree.

/libcc1
2019-12-09  Paolo Carlini  <paolo.carlini@oracle.com>

* libcp1plugin.cc (plugin_build_cast_expr): Adjust build_cast
declaration.

gcc/testsuite
2019-12-09  Paolo Carlini  <paolo.carlini@oracle.com>

* c-c++-common/Wcast-align.c: Check location(s) too.
* c-c++-common/Wcast-function-type.c: Likewise.
* c-c++-common/Wint-to-pointer-cast-1.c: Likewise.
* c-c++-common/Wint-to-pointer-cast-2.c: Likewise.
* c-c++-common/Wint-to-pointer-cast-3.c: Likewise.
* g++.dg/Wcast-function-type.C: Likewise.
* g++.dg/addr_builtin-1.C: Likewise.
* g++.dg/conversion/const2.C: Likewise.
* g++.dg/conversion/dynamic1.C: Likewise.
* g++.dg/conversion/ptrmem2.C: Likewise.
* g++.dg/conversion/ptrmem3.C: Likewise.
* g++.dg/conversion/qual3.C: Likewise.
* g++.dg/conversion/reinterpret3.C: Likewise.
* g++.dg/cpp0x/constexpr-cast.C: Likewise.
* g++.dg/cpp0x/lambda/lambda-conv11.C: Likewise.
* g++.dg/cpp0x/nullptr04.C: Likewise.
* g++.dg/cpp0x/reinterpret_cast2.C: Likewise.
* g++.dg/cpp0x/rv-cast2.C: Likewise.
* g++.dg/cpp1y/lambda-conv1.C: Likewise.
* g++.dg/cpp1z/noexcept-type7.C: Likewise.
* g++.dg/cpp2a/array-conv9.C: Likewise.
* g++.dg/expr/cast11.C: Likewise.
* g++.dg/expr/static_cast8.C: Likewise.
* g++.dg/ext/vector6.C: Likewise.
* g++.dg/other/conversion1.C: Likewise.
* g++.dg/parse/pr26997.C: Likewise.
* g++.dg/rtti/no-rtti.C: Likewise.
* g++.dg/tc1/dr137.C: Likewise.
* g++.dg/template/cast4.C: Likewise.
* g++.dg/warn/Wcast-qual1.C: Likewise.
* g++.dg/warn/Wcast-qual2.C: Likewise.
* g++.dg/warn/Wconditionally-supported-1.C: Likewise.
* g++.dg/warn/Wuseless-cast.C: Likewise.
* g++.dg/warn/pr35711.C: Likewise.
* g++.old-deja/g++.bugs/900227_01.C: Likewise.
* g++.old-deja/g++.bugs/900404_07.C: Likewise.
* g++.old-deja/g++.jason/overload1.C: Likewise.
* g++.old-deja/g++.jason/rfg26.C: Likewise.
* g++.old-deja/g++.jason/rvalue3.C: Likewise.
* g++.old-deja/g++.jason/warning2.C: Likewise.
* g++.old-deja/g++.mike/dyncast4.C: Likewise.
* g++.old-deja/g++.mike/dyncast6.C: Likewise.
* g++.old-deja/g++.mike/p11482.C: Likewise.
* g++.old-deja/g++.mike/p2573.C: Likewise.
* g++.old-deja/g++.mike/p2855.C: Likewise.
* g++.old-deja/g++.mike/p7476.C: Likewise.
* g++.old-deja/g++.mike/p8039.C: Likewise.
* g++.old-deja/g++.other/cast2.C: Likewise.
* g++.old-deja/g++.other/cast3.C: Likewise.
* g++.old-deja/g++.other/dcast1.C: Likewise.
* g++.old-deja/g++.other/dcast2.C: Likewise.

From-SVN: r279138

4 years agoByte vs column awareness for diagnostic-show-locus.c (PR 49973)
Lewis Hyatt [Mon, 9 Dec 2019 20:03:47 +0000 (20:03 +0000)]
Byte vs column awareness for diagnostic-show-locus.c (PR 49973)

contrib/ChangeLog

2019-12-09  Lewis Hyatt  <lhyatt@gmail.com>

PR preprocessor/49973
* unicode/from_glibc/unicode_utils.py: Support script from
glibc (commit 464cd3) to extract character widths from Unicode data
files.
* unicode/from_glibc/utf8_gen.py: Likewise.
* unicode/UnicodeData.txt: Unicode v. 12.1.0 data file.
* unicode/EastAsianWidth.txt: Likewise.
* unicode/PropList.txt: Likewise.
* unicode/gen_wcwidth.py: New utility to generate
libcpp/generated_cpp_wcwidth.h with help from the glibc support
scripts and the Unicode data files.
* unicode/unicode-license.txt: Added.
* unicode/README: New explanatory file.

libcpp/ChangeLog

2019-12-09  Lewis Hyatt  <lhyatt@gmail.com>

PR preprocessor/49973
* generated_cpp_wcwidth.h: New file generated by
../contrib/unicode/gen_wcwidth.py, supports new cpp_wcwidth function.
* charset.c (compute_next_display_width): New function to help
implement display columns.
(cpp_byte_column_to_display_column): Likewise.
(cpp_display_column_to_byte_column): Likewise.
(cpp_wcwidth): Likewise.
* include/cpplib.h (cpp_byte_column_to_display_column): Declare.
(cpp_display_column_to_byte_column): Declare.
(cpp_wcwidth): Declare.
(cpp_display_width): New function.

gcc/ChangeLog

2019-12-09  Lewis Hyatt  <lhyatt@gmail.com>

PR preprocessor/49973
* input.c (location_compute_display_column): New function to help with
multibyte awareness in diagnostics.
(test_cpp_utf8): New self-test.
(input_c_tests): Call the new test.
* input.h (location_compute_display_column): Declare.
* diagnostic-show-locus.c: Pervasive changes to add multibyte awareness
to all classes and functions.
(enum column_unit): New enum.
(class exploc_with_display_col): New class.
(class layout_point): Convert m_column member to array m_columns[2].
(layout_range::contains_point): Add col_unit argument.
(test_layout_range_for_single_point): Pass new argument.
(test_layout_range_for_single_line): Likewise.
(test_layout_range_for_multiple_lines): Likewise.
(line_bounds::convert_to_display_cols): New function.
(layout::get_state_at_point): Add col_unit argument.
(make_range): Use empty filename rather than dummy filename.
(get_line_width_without_trailing_whitespace): Rename to...
(get_line_bytes_without_trailing_whitespace): ...this.
(test_get_line_width_without_trailing_whitespace): Rename to...
(test_get_line_bytes_without_trailing_whitespace): ...this.
(class layout): m_exploc changed to exploc_with_display_col from
plain expanded_location.
(layout::get_linenum_width): New accessor member function.
(layout::get_x_offset_display): Likewise.
(layout::calculate_linenum_width): New subroutine for the constuctor.
(layout::calculate_x_offset_display): Likewise.
(layout::layout): Use the new subroutines. Add multibyte awareness.
(layout::print_source_line): Add multibyte awareness.
(layout::print_line): Likewise.
(layout::print_annotation_line): Likewise.
(line_label::line_label): Likewise.
(layout::print_any_labels): Likewise.
(layout::annotation_line_showed_range_p): Likewise.
(get_printed_columns): Likewise.
(class line_label): Rename m_length to m_display_width.
(get_affected_columns): Rename to...
(get_affected_range): ...this; add col_unit argument and multibyte
awareness.
(class correction): Add m_affected_bytes and m_display_cols
members.  Rename m_len to m_byte_length for clarity.  Add multibyte
awareness throughout.
(correction::insertion_p): Add multibyte awareness.
(correction::compute_display_cols): New function.
(correction::ensure_terminated): Use new member name m_byte_length.
(line_corrections::add_hint): Add multibyte awareness.
(layout::print_trailing_fixits): Likewise.
(layout::get_x_bound_for_row): Likewise.
(test_one_liner_simple_caret_utf8): New self-test analogous to the one
with _utf8 suffix removed, testing multibyte awareness.
(test_one_liner_caret_and_range_utf8): Likewise.
(test_one_liner_multiple_carets_and_ranges_utf8): Likewise.
(test_one_liner_fixit_insert_before_utf8): Likewise.
(test_one_liner_fixit_insert_after_utf8): Likewise.
(test_one_liner_fixit_remove_utf8): Likewise.
(test_one_liner_fixit_replace_utf8): Likewise.
(test_one_liner_fixit_replace_non_equal_range_utf8): Likewise.
(test_one_liner_fixit_replace_equal_secondary_range_utf8): Likewise.
(test_one_liner_fixit_validation_adhoc_locations_utf8): Likewise.
(test_one_liner_many_fixits_1_utf8): Likewise.
(test_one_liner_many_fixits_2_utf8): Likewise.
(test_one_liner_labels_utf8): Likewise.
(test_diagnostic_show_locus_one_liner_utf8): Likewise.
(test_overlapped_fixit_printing_utf8): Likewise.
(test_overlapped_fixit_printing): Adapt for changes to
get_affected_columns, get_printed_columns and class corrections.
(test_overlapped_fixit_printing_2): Likewise.
(test_linenum_sep): New constant.
(test_left_margin): Likewise.
(test_offset_impl): Helper function for new test.
(test_layout_x_offset_display_utf8): New test.
(diagnostic_show_locus_c_tests): Call new tests.

gcc/testsuite/ChangeLog:

2019-12-09  Lewis Hyatt  <lhyatt@gmail.com>

PR preprocessor/49973
* gcc.dg/plugin/diagnostic_plugin_test_show_locus.c
(test_show_locus): Tweak so that expected output is the same as
before the diagnostic-show-locus.c changes.
* gcc.dg/cpp/pr66415-1.c: Likewise.

From-SVN: r279137

4 years agore PR go/92861 (Passes relative time to sem_timedwait on GNU/Hurd)
Ian Lance Taylor [Mon, 9 Dec 2019 18:03:53 +0000 (18:03 +0000)]
re PR go/92861 (Passes relative time to sem_timedwait on GNU/Hurd)

PR go/92861
    runtime: don't define CLOCK_REALTIME in os_hurd.go

    It's already defined in sysinfo.go.

    Patch by Samuel Thibault.

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/210538

From-SVN: r279136

4 years agolibstdc++: Implement ranges::safe_range for C++20 (P1870R1)
Jonathan Wakely [Mon, 9 Dec 2019 17:35:24 +0000 (17:35 +0000)]
libstdc++: Implement ranges::safe_range for C++20 (P1870R1)

This change replaces the __forwarding_range implementation detail with
the ranges::safe_range concept and adds the ranges::enable_safe_range
variable template for opt-in in to the concept.

It also adjusts the begin/end/rbegin/rend customization point objects to
match the new rules for accessing rvalue ranges only when safe to do so.

* include/bits/range_access.h (ranges::enable_safe_range): Define.
(ranges::begin, ranges::end, ranges::rbegin, ranges::rend): Constrain
to only accept types satisfying safe_range and treat argument as an
lvalue when calling a member of performing ADL.
(ranges::__detail::__range_impl, ranges::__detail::__forwarding_range):
Remove.
(ranges::range): Adjust definition.
(ranges::safe_range): Define.
(ranges::iterator_t, ranges::range_difference_t): Reorder definitions
to match the synopsis in the working draft.
(ranges::disable_sized_range): Remove duplicate definition.
* include/experimental/string_view (ranges::enable_safe_range): Add
partial specialization for std::experimental::basic_string_view.
* include/std/ranges (ranges::viewable_range, ranges::subrange)
(ranges::empty_view, ranges::iota_view): Use safe_range. Specialize
enable_safe_range.
(ranges::safe_iterator_t, ranges::safe_subrange_t): Define.
* include/std/span (ranges::enable_safe_range): Add partial
specialization for std::span.
* include/std/string_view (ranges::enable_safe_range): Likewise for
std::basic_string_view.
* testsuite/std/ranges/access/begin.cc: Adjust expected results.
* testsuite/std/ranges/access/cbegin.cc: Likewise.
* testsuite/std/ranges/access/cdata.cc: Likewise.
* testsuite/std/ranges/access/cend.cc: Likewise.
* testsuite/std/ranges/access/crbegin.cc: Likewise.
* testsuite/std/ranges/access/crend.cc: Likewise.
* testsuite/std/ranges/access/data.cc: Likewise.
* testsuite/std/ranges/access/end.cc: Likewise.
* testsuite/std/ranges/access/rbegin.cc: Likewise.
* testsuite/std/ranges/access/rend.cc: Likewise.
* testsuite/std/ranges/empty_view.cc: Test ranges::begin and
ranges::end instead of unqualified calls to begin and end.
* testsuite/std/ranges/safe_range.cc: New test.
* testsuite/std/ranges/safe_range_types.cc: New test.
* testsuite/util/testsuite_iterators.h: Add comment about safe_range.

From-SVN: r279135

4 years agotree.c (build_array_type_1): Add SET_CANONICAL parameter and compute TYPE_CANONICAL...
Eric Botcazou [Mon, 9 Dec 2019 16:41:30 +0000 (16:41 +0000)]
tree.c (build_array_type_1): Add SET_CANONICAL parameter and compute TYPE_CANONICAL from the element type...

* tree.c (build_array_type_1): Add SET_CANONICAL parameter and compute
TYPE_CANONICAL from the element type only if it is true.  Remove a few
obsolete lines and adjust recursive call.
(fld_process_array_type): Adjust call to build_array_type_1.
(build_array_type): Likewise.
(build_nonshared_array_type): Likewise.

From-SVN: r279133

4 years agoFix column information for omp_clauses in Fortran code
Frederik Harwath [Mon, 9 Dec 2019 16:30:25 +0000 (16:30 +0000)]
Fix column information for omp_clauses in Fortran code

The location of all OpenMP/OpenACC clauses on any given line in Fortran code
always points to the first clause on that line. Hence, the column information
is wrong for all clauses but the first one.

Use the correct location for each clause instead.

2019-12-09  Frederik Harwath  <frederik@codesourcery.com>

/gcc/fortran/
* trans-openmp.c (gfc_trans_omp_reduction_list): Pass correct location for each
clause to build_omp_clause.

From-SVN: r279132

4 years agoFix more unrecognised GCN instructions
Andrew Stubbs [Mon, 9 Dec 2019 14:49:08 +0000 (14:49 +0000)]
Fix more unrecognised GCN instructions

2019-12-09  Andrew Stubbs  <ams@codesourcery.com>

gcc/
* config/gcn/gcn-valu.md (gather<mode>_insn_1offset<exec>): Change
%s to %o in asm output.
(gather<mode>_insn_2offsets<exec>): Likewise.

From-SVN: r279131

4 years agoRemove gcc/ prefix
Eric Botcazou [Mon, 9 Dec 2019 14:20:54 +0000 (14:20 +0000)]
Remove gcc/ prefix

From-SVN: r279130

4 years agoFix libdecnumber handling of non-canonical BID significands (PR middle-end/91226).
Joseph Myers [Mon, 9 Dec 2019 13:59:24 +0000 (13:59 +0000)]
Fix libdecnumber handling of non-canonical BID significands (PR middle-end/91226).

As reported in bug 91226, the libdecnumber code used on the host to
interpret DFP values in the BID encoding fails, for _Decimal64 and
_Decimal128, to check for the case where a significand is too large
and so specified in IEEE 754 to be a non-canonical encoding of the
zero significand.  This patch adds the required handling of that case,
together with tests both using -O2 (testing this host code) and -O0
(testing libgcc code, which already worked before the patch); the
tests also cover _Decimal32, which already had the required check.

In the _Decimal128 case, where the code previously completely ignored
the case where the first four bits of the combination field are 1100,
1101 or 1110, the logic for determining the correct quantum exponent
in that case is also newly added by this patch, so tests are added for
that as well (again, libgcc already handled it correctly when the
conversion was done at runtime rather than at compile time).

Bootstrapped with no regressions for x86_64-pc-linux-gnu.

PR middle-end/91226
libdecnumber:
* bid/bid2dpd_dpd2bid.c (_bid_to_dpd64): Handle non-canonical
significands.
(_bid_to_dpd128): Likewise.  Check for case where combination
field starts 1100, 1101 or 1110.

gcc/testsuite:
* gcc.dg/dfp/bid-non-canonical-d128-1.c,
gcc.dg/dfp/bid-non-canonical-d128-2.c,
gcc.dg/dfp/bid-non-canonical-d128-3.c,
gcc.dg/dfp/bid-non-canonical-d128-4.c,
gcc.dg/dfp/bid-non-canonical-d32-1.c,
gcc.dg/dfp/bid-non-canonical-d32-2.c,
gcc.dg/dfp/bid-non-canonical-d64-1.c,
gcc.dg/dfp/bid-non-canonical-d64-2.c: New tests.

From-SVN: r279129

4 years agoarm: fix v[78]-r multilibs when configured with --with-multlib-list=aprofile
Richard Earnshaw [Mon, 9 Dec 2019 13:51:50 +0000 (13:51 +0000)]
arm: fix v[78]-r multilibs when configured with --with-multlib-list=aprofile

When gcc for Arm is configured with --with-multilib-list=aprofile a
misplaced endif directive in the makefile was causing the arm->thumb
mapping for multilibs to be omitted from the reuse rules.  This
resulted in the default multilib being picked rather than the thumb2
opimized version.

* config/arm/t-multilib: Use arm->thumb multilib reuse rules
on a-profile.

From-SVN: r279128

4 years agors6000: Name set<mode>_cc, and delete some old mfcr patterns
Segher Boessenkool [Mon, 9 Dec 2019 13:41:53 +0000 (14:41 +0100)]
rs6000: Name set<mode>_cc, and delete some old mfcr patterns

This names the so far unnamed basic mfcr pattern "set<mode>_cc", and
it deletes all the others (only the ashift one ever was generated, and
even that one only once during a whole bootstrap+regtest, and that one
is questionable -- we don't cost that pattern correctly).

* config/rs6000/rs6000.md (unnamed mfcr define_insn): Name this
set<mode>_cc.
(unnamed define_insn_and_split): Delete.
(unnamed define_insn): Delete.
(unnamed define_insn): Delete.
(unnamed define_split): Delete.

From-SVN: r279127

4 years ago[mid-end] [obvious] Cast to avoid -Wsign-compare warning from r279124
Matthew Malcomson [Mon, 9 Dec 2019 13:16:07 +0000 (13:16 +0000)]
[mid-end] [obvious] Cast to avoid -Wsign-compare warning from r279124

The previous revision adds a comparison that triggers a warning.
Here we simply cast the unsigned integer to a signed one before the
comparison.

gcc/ChangeLog:

2019-12-09  Matthew Malcomson  <matthew.malcomson@arm.com>

* regstat.c (regstat_bb_compute_calls_crossed): Add a cast to
avoid a warning.

From-SVN: r279126

4 years agolibgcc: Fix misuse of USE_EH_FRAME_REGISTRY in crtstuff.c
Jozef Lawrynowicz [Mon, 9 Dec 2019 12:35:55 +0000 (12:35 +0000)]
libgcc: Fix misuse of USE_EH_FRAME_REGISTRY in crtstuff.c

2019-12-09  Jozef Lawrynowicz  <jozef.l@mittosystems.com>

* crtstuff.c (__do_global_dtors_aux): Check if USE_EH_FRAME_REGISTRY is
defined instead of its value.

From-SVN: r279125

4 years ago[mid-end] Add notes to dataflow insn info when re-emitting (PR92410)
Matthew Malcomson [Mon, 9 Dec 2019 12:03:53 +0000 (12:03 +0000)]
[mid-end] Add notes to dataflow insn info when re-emitting (PR92410)

In scheduling passes, notes are removed with `remove_notes` before the
scheduling is done, and added back in with `reemit_notes` once the
scheduling has been decided.

This process leaves the notes in the RTL chain with different insn uid's
than were there before.  Having different UID's (larger than the
previous ones) means that DF_INSN_INFO_GET(insn) will access outside of
the allocated array.

This has been seen in the `regstat_bb_compute_calls_crossed` function.
This patch adds an assert to the `regstat_bb_compute_calls_crossed`
function so that bad accesses here are caught instead of going
unnoticed, and then avoids the problem.

We avoid the problem by ensuring that new notes added by `reemit_notes` have an
insn record given to them.  This is done by adding a call to
`df_insn_create_insn_record` on each note added in `reemit_notes`.
`df_insn_create_insn_record` leaves this new record zeroed out, which appears
to be fine for notes (e.g. `df_bb_refs_record` already does not set
anything except the luid for notes, and notes have no dataflow information to
record).

We add the testcase that Martin found here
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92410#c2 .
This testcase fails with the "regstat.c" change, and then succeeds with the
"haifa-sched.c" change.

There is a similar problem with labels, that the `gcc_assert` catches
when running regression tests in gcc.dg/fold-eqandshift-1.c and
gcc.c-torture/compile/pr32482.c.
This is due to the `cfg_layout_finalize` call in `bb-reorder.c` emitting
new labels, and these labels not having a dataflow df_insn_info member.

We solve this by manually calling `df_recompute_luids` on each basic
block once this pass has finished.

Testing done:
  Ran regression tests on aarch64-none-linux-gnu cross compiler.
  Bootstrapped and ran tests on aarch64-none-linux-gnu native.

gcc/ChangeLog:

2019-12-09  Matthew Malcomson  <matthew.malcomson@arm.com>

PR middle-end/92410
* bb-reorder.c (pass_reorder_blocks::execute): Recompute
dataflow luids once basic blocks have been reordered.
* haifa-sched.c (reemit_notes): Create df insn record for each
new note.
* regstat.c (regstat_bb_compute_calls_crossed): Assert every
insn has an insn record before trying to use it.

gcc/testsuite/ChangeLog:

2019-12-09  Matthew Malcomson  <matthew.malcomson@arm.com>

PR middle-end/92410
* gcc.dg/torture/pr92410.c: New test.

From-SVN: r279124

4 years agolibgcc: Dont define __do_global_dtors_aux if it will be empty
Jozef Lawrynowicz [Mon, 9 Dec 2019 11:41:07 +0000 (11:41 +0000)]
libgcc: Dont define __do_global_dtors_aux if it will be empty

2019-12-09  Jozef Lawrynowicz  <jozef.l@mittosystems.com>

* crtstuff.c (__do_global_dtors_aux): Wrap in #if so it's only defined
if it will have contents.

From-SVN: r279123

4 years ago[PR92511] More testing for OpenACC "present" subarrays
Thomas Schwinge [Mon, 9 Dec 2019 11:40:36 +0000 (12:40 +0100)]
[PR92511] More testing for OpenACC "present" subarrays

In particular, "subset subarrays".

libgomp/
PR libgomp/92511
* testsuite/libgomp.oacc-c-c++-common/copyin-devptr-1.c: Remove
this file...
* testsuite/libgomp.oacc-c-c++-common/copyin-devptr-2.c: ..., and
this file...
* testsuite/libgomp.oacc-c-c++-common/lib-22.c: ..., and this
file...
* testsuite/libgomp.oacc-c-c++-common/lib-30.c: ..., and this
file...
* testsuite/libgomp.oacc-c-c++-common/subset-subarray-mappings-1-r-p.c:
... with their content moved into, and extended in this new file.
* testsuite/libgomp.oacc-c-c++-common/subset-subarray-mappings-1-d-a.c:
New file.
* testsuite/libgomp.oacc-c-c++-common/subset-subarray-mappings-1-d-p.c:
Likewise.
* testsuite/libgomp.oacc-c-c++-common/subset-subarray-mappings-1-r-a.c:
Likewise.
* testsuite/libgomp.oacc-c-c++-common/subset-subarray-mappings-2.c:
Likewise.

From-SVN: r279122

4 years agoAdd 'libgomp.oacc-c-c++-common/map-data-1.c'
Thomas Schwinge [Mon, 9 Dec 2019 11:40:27 +0000 (12:40 +0100)]
Add 'libgomp.oacc-c-c++-common/map-data-1.c'

libgomp/
* testsuite/libgomp.oacc-c-c++-common/map-data-1.c: New file.

From-SVN: r279121

4 years ago[PR92854] Add 'libgomp.oacc-c-c++-common/pr92854-1.c'
Thomas Schwinge [Mon, 9 Dec 2019 11:40:17 +0000 (12:40 +0100)]
[PR92854] Add 'libgomp.oacc-c-c++-common/pr92854-1.c'

... to document the status quo.

libgomp/
PR libgomp/92854
* testsuite/libgomp.oacc-c-c++-common/pr92854-1.c: New file.

From-SVN: r279120

4 years agoAdd 'libgomp.oacc-c-c++-common/host_data-6.c'
Thomas Schwinge [Mon, 9 Dec 2019 11:40:08 +0000 (12:40 +0100)]
Add 'libgomp.oacc-c-c++-common/host_data-6.c'

libgomp/
* testsuite/libgomp.oacc-c-c++-common/host_data-6.c: New file.

From-SVN: r279119

4 years agoIn 'libgomp/target.c:gomp_exit_data', remove open-coded 'gomp_remove_var'
Thomas Schwinge [Mon, 9 Dec 2019 11:39:57 +0000 (12:39 +0100)]
In 'libgomp/target.c:gomp_exit_data', remove open-coded 'gomp_remove_var'

libgomp/
* target.c (gomp_exit_data): Use 'gomp_remove_var'.

From-SVN: r279118

4 years agolibgomp/testsuite/*fortran – make 'stop' values unique
Tobias Burnus [Mon, 9 Dec 2019 11:21:22 +0000 (11:21 +0000)]
libgomp/testsuite/*fortran – make 'stop' values unique

        * testsuite/libgomp.fortran/use_device_addr-3.f90: Make 'stop' codes
        unique.
        * testsuite/libgomp.fortran/use_device_addr-4.f90: Ditto.
        * testsuite/libgomp.fortran/use_device_ptr-optional-2.f90: Ditto.
        * testsuite/libgomp.oacc-fortran/declare-5.f90: Ditto.
        * testsuite/libgomp.oacc-fortran/optional-data-copyin-by-value.f90:
        Ditto.
        * testsuite/libgomp.oacc-fortran/optional-firstprivate.f90: Ditto.
        * testsuite/libgomp.oacc-fortran/optional-update-host.f90: Ditto.

From-SVN: r279117

4 years agoUse OPTION_MASK_ISA2_$target_[SET,UNSET, ] to indicate those for
Hongtao Liu [Mon, 9 Dec 2019 11:20:13 +0000 (11:20 +0000)]
Use OPTION_MASK_ISA2_$target_[SET,UNSET, ] to indicate those for
x_ix86_isa_flags2.

2019-12-09  Hongtao Liu  <hongtao.liu@intel.com>

    * gcc/common/config/i386/i386-common.c
    (OPTION_MASK_ISA_AVX5124FMAPS_SET): Rename to
    OPTION_MASK_ISA2_AVX5124FMAPS_SET.
    (OPTION_MASK_ISA_AVX5124VNNIW_SET, OPTION_MASK_ISA_AVX512BF16_SET,
    OPTION_MASK_ISA_AVX512VP2INTERSECT_SET,
    OPTION_MASK_ISA_PCONFIG_SET, OPTION_MASK_ISA_WBNOINVD_SET,
    OPTION_MASK_ISA_SGX_SET, OPTION_MASK_ISA_CX16_SET,
    OPTION_MASK_ISA_MOVBE_SET, OPTION_MASK_ISA_PTWRITE_SET,
    OPTION_MASK_ISA_MWAITX_SET, OPTION_MASK_ISA_CLZERO_SET,
    OPTION_MASK_ISA_RDPID_SET, OPTION_MASK_ISA_VAES_SET,
    OPTION_MASK_ISA_MOVDIR64B_SET, OPTION_MASK_ISA_WAITPKG_SET,
    OPTION_MASK_ISA_CLDEMOTE_SET, OPTION_MASK_ISA_ENQCMD_SET,
    OPTION_MASK_ISA_AVX5124FMAPS_UNSET,
    OPTION_MASK_ISA_AVX5124VNNIW_UNSET,
    OPTION_MASK_ISA_AVX512BF16_UNSET,
    OPTION_MASK_ISA_AVX512VP2INTERSECT_UNSET,
    OPTION_MASK_ISA_PCONFIG_UNSET, OPTION_MASK_ISA_WBNOINVD_UNSET,
    OPTION_MASK_ISA_SGX_UNSET, OPTION_MASK_ISA_CX16_UNSET,
    OPTION_MASK_ISA_MOVBE_UNSET, OPTION_MASK_ISA_PTWRITE_UNSET,
    OPTION_MASK_ISA_MWAITX_UNSET, OPTION_MASK_ISA_CLZERO_UNSET,
    OPTION_MASK_ISA_RDPID_UNSET, OPTION_MASK_ISA_VAES_UNSET,
    OPTION_MASK_ISA_MOVDIR64B_UNSET, OPTION_MASK_ISA_WAITPKG_UNSET,
    OPTION_MASK_ISA_CLDEMOTE_UNSET, OPTION_MASK_ISA_ENQCMD_UNSET,
    OPTION_MASK_ISA_AVX5124FMAPS, OPTION_MASK_ISA_AVX5124VNNIW,
    OPTION_MASK_ISA_AVX512BF16, OPTION_MASK_ISA_AVX512VP2INTERSECT,
    OPTION_MASK_ISA_PCONFIG, OPTION_MASK_ISA_WBNOINVD,
    OPTION_MASK_ISA_SGX, OPTION_MASK_ISA_CX16, OPTION_MASK_ISA_MOVBE,
    OPTION_MASK_ISA_PTWRITE, OPTION_MASK_ISA_MWAITX,
    OPTION_MASK_ISA_CLZERO, OPTION_MASK_ISA_RDPID,
    OPTION_MASK_ISA_VAES, OPTION_MASK_ISA_MOVDIR64B,
    OPTION_MASK_ISA_WAITPKG, OPTION_MASK_ISA_CLDEMOTE,
    OPTION_MASK_ISA_ENQCMD): Ditto.
    * gcc/config/i386/i386-builtin.def
    (OPTION_MASK_ISA_AVX5124FMAPS, OPTION_MASK_ISA_AVX5124VNNIW,
    OPTION_MASK_ISA_AVX512BF16, OPTION_MASK_ISA_AVX512VP2INTERSECT,
    OPTION_MASK_ISA_WBNOINVD, OPTION_MASK_ISA_PTWRITE,
    OPTION_MASK_ISA_RDPID, OPTION_MASK_ISA_VAES,
    OPTION_MASK_ISA_MOVDIR64B, OPTION_MASK_ISA_ENQCMD): Ditto.
    * gcc/config/i386/i386-builtins.c (OPTION_MASK_ISA_MWAITX,
    OPTION_MASK_ISA_CLZERO, OPTION_MASK_ISA_WAITPKG,
    OPTION_MASK_ISA_CLDEMOTE, OPTION_MASK_ISA_WBNOINVD): Ditto.
    * gcc/config/i386/i386-c.c
    (OPTION_MASK_ISA_AVX5124FMAPS, OPTION_MASK_ISA_AVX5124VNNIW,
    OPTION_MASK_ISA_AVX512BF16, OPTION_MASK_ISA_AVX512VP2INTERSECT,
    OPTION_MASK_ISA_PCONFIG, OPTION_MASK_ISA_WBNOINVD,
    OPTION_MASK_ISA_SGX, OPTION_MASK_ISA_CX16, OPTION_MASK_ISA_MOVBE,
    OPTION_MASK_ISA_PTWRITE, OPTION_MASK_ISA_MWAITX,
    OPTION_MASK_ISA_CLZERO, OPTION_MASK_ISA_RDPID,
    OPTION_MASK_ISA_VAES, OPTION_MASK_ISA_MOVDIR64B,
    OPTION_MASK_ISA_WAITPKG, OPTION_MASK_ISA_CLDEMOTE,
    OPTION_MASK_ISA_ENQCMD): Ditto.
    * gcc/config/i386/i386-option.c: Ditto
    * gcc/config/i386/i386.opt: Ditto..
    * gcc/config/i386/i386.h: (TARGET_ISA_AVX5124FMAPS,
    TARGET_ISA_AVX5124VNNIW,  TARGET_ISA_AVX512BF16,
    TARGET_ISA_AVX512VP2INTERSECT, TARGET_ISA_PCONFIG,
    TARGET_ISA_WBNOINVD, TARGET_ISA_SGX, TARGET_ISA_CX16,
    TARGET_ISA_MOVBE, TARGET_ISA_PTWRITE, TARGET_ISA_MWAITX,
    TARGET_ISA_CLZERO, TARGET_ISA_RDPID, TARGET_ISA_VAES,
    TARGET_ISA_MOVDIR64B, TARGET_ISA_WAITPKG, TARGET_ISA_CLDEMOTE)
    TARGET_ISA_ENQCMD): Ditto.

From-SVN: r279116

4 years ago[GCC, Vect] Fix costing for vector shifts
Sudakshina Das [Mon, 9 Dec 2019 10:22:01 +0000 (10:22 +0000)]
[GCC, Vect] Fix costing for vector shifts

While looking at the vectorization for following example, we realized that
even though vectorizable_shift function was distinguishing vector shifted
by vector from vector shifted by scalar, while modelling the cost it would
always add the cost of building a vector constant despite not needing it for
vector shifted by scalar.

This patch fixes this by using scalar_shift_arg to determine whether we need
to build a vector for the second operand or not. This causes the test case
below to now vectorize.

gcc/ChangeLog:

2019-12-09  Sudakshina Das  <sudi.das@arm.com>
    Richard Sandiford  <richard.sandiford@arm.com>

* tree-vect-stmt.c (vectorizable_shift): Condition ndts for
vect_model_simple_cost call on scalar_shift_arg.

gcc/testsuite/ChangeLog:

2019-12-09  Sudakshina Das  <sudi.das@arm.com>

* gcc.dg/vect/vect-shift-5.c: New test.

Co-Authored-By: Richard Sandiford <richard.sandiford@arm.com>
From-SVN: r279114

4 years agore PR tree-optimization/92834 (misssed SLP vectorization in LightPixel)
Jakub Jelinek [Mon, 9 Dec 2019 10:13:18 +0000 (11:13 +0100)]
re PR tree-optimization/92834 (misssed SLP vectorization in LightPixel)

PR tree-optimization/92834
* match.pd (A - ((A - B) & -(C cmp D)) -> (C cmp D) ? B : A,
A + ((B - A) & -(C cmp D)) -> (C cmp D) ? B : A): New simplifications.

* gcc.dg/tree-ssa/pr92834.c: New test.

From-SVN: r279113

4 years agore PR tree-optimization/89007 ([SVE] Implement generic vector average expansion)
Prathamesh Kulkarni [Mon, 9 Dec 2019 09:59:42 +0000 (09:59 +0000)]
re PR tree-optimization/89007 ([SVE] Implement generic vector average expansion)

2019-12-09  Prathamesh Kulkarni  <prathamesh.kulkarni@linaro.org>

PR tree-optimization/89007
* tree-vect-patterns.c (vect_recog_average_pattern): If there is no
target support available, generate code to distribute rshift over plus
and add a carry.

testsuite/
* gcc.target/aarch64/sve/pr89007-1.c: New test.
* gcc.target/aarch64/sve/pr89007-2.c: Likewise.

From-SVN: r279112

4 years agolibstdc++: Improve testing for path::operator+=(const string&)
Jonathan Wakely [Mon, 9 Dec 2019 09:59:00 +0000 (09:59 +0000)]
libstdc++: Improve testing for path::operator+=(const string&)

* testsuite/27_io/filesystem/path/concat/strings.cc: Test more cases.

From-SVN: r279111

4 years agolibstdc++: fix buffer overflow in path::operator+= (PR92853)
Jonathan Wakely [Mon, 9 Dec 2019 09:58:56 +0000 (09:58 +0000)]
libstdc++: fix buffer overflow in path::operator+= (PR92853)

When concatenating a path ending in a root-directory onto another path,
we added an empty filename to the end of the path twice, but only
reserved space for one. That meant the second write went past the end of
the allocated buffer.

PR libstdc++/92853
* src/c++17/fs_path.cc (filesystem::path::operator+=(const path&)):
Do not process a trailing directory separator twice.
* testsuite/27_io/filesystem/path/concat/92853.cc: New test.
* testsuite/27_io/filesystem/path/concat/path.cc: Test more cases.

From-SVN: r279110

4 years agoCome up with constructors of symtab_node, cgraph_node and varpool_node.
Martin Liska [Mon, 9 Dec 2019 09:00:42 +0000 (10:00 +0100)]
Come up with constructors of symtab_node, cgraph_node and varpool_node.

2019-12-09  Martin Liska  <mliska@suse.cz>

PR ipa/92737
* cgraph.c (symbol_table_test::symbol_table_test): Fix
coding style.
* cgraph.h (symtab_node::symtab_node): New constructor.
(cgraph_node::cgraph_node): Likewise.
(varpool_node::varpool_node): Likewise.
(symbol_table::allocate_cgraph_symbol): Use newly
created constructor.
(symbol_table::allocate_cgraph_symbol): Remove.
* cgraphunit.c (symtab_terminator): Likewise.
* varpool.c (varpool_node::create_empty): Use newly
created constructor.

From-SVN: r279109

4 years agolibstdc++: Add C++20 P1032 constexpr to _GLIBCXX_DEBUG array
François Dumont [Mon, 9 Dec 2019 08:44:15 +0000 (08:44 +0000)]
libstdc++: Add C++20 P1032 constexpr to _GLIBCXX_DEBUG array

* testsuite/23_containers/array/tuple_interface/get_debug_neg.cc:
Fix static_assert line number.
* testsuite/23_containers/array/tuple_interface/
tuple_element_debug_neg.cc: Likewise.

From-SVN: r279108

4 years agoEnable mask movement for VCOND_EXPR under avx512f for
Hongtao Liu [Mon, 9 Dec 2019 04:16:24 +0000 (04:16 +0000)]
Enable mask movement for VCOND_EXPR under avx512f for
128/256-bit vector when integer mask is available.

Changelog
gcc/
PR target/92686
* config/i386/sse.md
(*<avx512>_cmp<mode>3<mask_scalar_merge_name><round_saeonly_name>,
*<avx512>_cmp<mode>3<mask_scalar_merge_name>,
*<avx512>_ucmp<mode>3<mask_scalar_merge_name>,
*<avx512>_ucmp<mode>3<mask_scalar_merge_name>): New.
* config/i386/i386.c (ix86_print_operand): New operand substitution.
* config/i386/i386-expand.c (ix86_valid_mask_cmp_mode):
New function.
(ix86_expand_sse_cmp): Relax condition for integer mask from
512-bit vector to all 128/256/512-bit vector. Delete code gen
for avx512f compare patterns since we have generic pattern now.
(ix86_expand_sse_movcc): Adjust condition and codegen for
maskcmp.
(ix86_expand_int_sse_cmp): Don't canonicalize the comparison
when corresponding vector compare is available.

gcc/testsuite/
* gcc.target/i386/pr92686.inc: New file.
* gcc.target/i386/avx512bw-pr92686-vpcmp-1.c: New test.
* gcc.target/i386/avx512bw-pr92686-vpcmp-intelasm-1.c: Ditto.
* gcc.target/i386/avx512bw-pr92686-vpcmp-2.c: Ditto.
* gcc.target/i386/avx512vl-pr92686-vpcmp-1.c: Ditto.
* gcc.target/i386/avx512vl-pr92686-vpcmp-intelasm-1.c: Ditto.
* gcc.target/i386/avx512vl-pr92686-vpcmp-2.c: Ditto.
* gcc.target/i386/avx512bw-pr92686-movcc-1.c: Ditto.
* gcc.target/i386/avx512bw-pr92686-movcc-2.c: Ditto.
* gcc.target/i386/avx512vl-pr92686-movcc-1.c: Ditto.
* gcc.target/i386/avx512vl-pr92686-movcc-2.c: Ditto.
* gcc.target/i386/avx512vl-pr88547-1.c: Adjust testcase.
* gcc.target/i386/pr88547-1.c: Ditto.

From-SVN: r279107

4 years agore PR go/92861 (Passes relative time to sem_timedwait on GNU/Hurd)
Ian Lance Taylor [Mon, 9 Dec 2019 03:43:33 +0000 (03:43 +0000)]
re PR go/92861 (Passes relative time to sem_timedwait on GNU/Hurd)

PR go/92861
    runtime: use absolute time for sem_timedwait

    Patch by Samuel Thibault.

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/210457

From-SVN: r279106

4 years agoDaily bump.
GCC Administrator [Mon, 9 Dec 2019 00:16:21 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r279104

4 years agocvt.c (maybe_warn_nodiscard): Add workaround for GCC 3.4-4.4 - cast msg to (const...
Jakub Jelinek [Sun, 8 Dec 2019 23:22:45 +0000 (00:22 +0100)]
cvt.c (maybe_warn_nodiscard): Add workaround for GCC 3.4-4.4 - cast msg to (const char *) in conditional...

* cvt.c (maybe_warn_nodiscard): Add workaround for GCC 3.4-4.4 - cast
msg to (const char *) in conditional expressions.  Formatting fixes.

From-SVN: r279101

4 years agoNew bswap testcase.
Andrew Pinski [Sun, 8 Dec 2019 21:59:25 +0000 (21:59 +0000)]
New bswap testcase.

2019-12-08  Andrew Pinski  <apinski@marvell.com>

        * gcc.c-torture/execute/bswap-3.c: New test.

From-SVN: r279100

4 years agoRevert commit r279023.
Sandra Loosemore [Sun, 8 Dec 2019 17:12:50 +0000 (12:12 -0500)]
Revert commit r279023.

2019-12-08  Sandra Loosemore  <sandra@codesourcery.com>

Revert commit r279023.

2019-12-05  Sandra Loosemore  <sandra@codesourcery.com>

gcc/
* config/nios2/linux.h (LINK_EH_SPEC): Define.

gcc/testsuite/
* g++.target/nios2/hello-pie.C: New.
* g++.target/nios2/nios2.exp: New.

From-SVN: r279094

4 years agoFix overflows in -fprofile-reorder-functions
Jan Hubicka [Sun, 8 Dec 2019 17:02:30 +0000 (18:02 +0100)]
Fix overflows in -fprofile-reorder-functions

This patch fixes three sissues with -fprofile-reorder-functions:
1) First is that tp_first_run is stored as 32bit integer while it can easily
   overflow (and does so during Firefox profiling).
2) Second problem is that flag_profile_functions can
   not be tested w/o function context.
   The changes to expand_all_functions makes it to work on mixed units by
   first outputting all functions w/o -fprofile-reorder-function (or with no
   profile info) and then outputting in first_run order
3) LTO partitioner was mixing up order by tp_first_run and by order.
   for no_reorder we definitly want to order via first, while for everything
   else we want to roder by second.

I have also merged duplicated comparators since they are bit fragile into
tp_first_run_node_cmp.

I originaly started to look into this because of undefined symbols with
Firefox PGO builds.  These symbols went away with fixing these bug but I am not
quite sure how. it is possible that there is another problem in lto_blanced_map
but even after reading the noreorder code few times carefuly I did not find it.
Other explanation would be that our new qsort with broken comparator due to
overflow can actualy remove some entries in the array, but that sounds bit
crazy.

Bootstrapped/regested x86_64-linux.

* cgraph.c (cgraph_node::dump): Make tp_first_run 64bit.
* cgraph.h (cgrpah_node): Likewise.
(tp_first_run_node_cmp): Deeclare.
* cgraphunit.c (node_cmp): Rename to ...
(tp_first_run_node_cmp): ... this; export; watch for 64bit overflows;
clear tp_first_run for no_reorder and !flag_profile_reorder_functions.
(expand_all_functions): Collect tp_first_run and normal functions to
two vectors so the other functions remain sorted. Do not check for
flag_profile_reorder_functions it is function local flag.
* profile.c (compute_value_histograms): Update tp_first_run printing.

* lto-partition.c (node_cmp): Turn into simple order comparsions.
(varpool_node_cmp): Remove.
(add_sorted_nodes): Use node_cmp.
(lto_balanced_map): Use tp_first_run_node_cmp.

From-SVN: r279093

4 years agoopts.c (common_handle_option): Do not clear ipa_reference for -fprofile-use.
Jan Hubicka [Sun, 8 Dec 2019 17:00:42 +0000 (18:00 +0100)]
opts.c (common_handle_option): Do not clear ipa_reference for -fprofile-use.

* opts.c (common_handle_option): Do not clear ipa_reference for
-fprofile-use.

From-SVN: r279092

4 years agoFix tp_first_run update in split_function.
Jan Hubicka [Sun, 8 Dec 2019 16:57:20 +0000 (17:57 +0100)]
Fix tp_first_run update in split_function.

The value 0 in tp_first_run is special meaing that profile is unknown.  We
should not set it to 1.

* ipa-split.c (split_function): Preserve 0 tp_first_run.

From-SVN: r279091

4 years agoSilence overactive sanity check with -fpartial-profile-training
Jan Hubicka [Sun, 8 Dec 2019 14:02:43 +0000 (15:02 +0100)]
Silence overactive sanity check with -fpartial-profile-training

do_estimate_edge_time tests that cached and real values matches. This test
is not working precisely for global profiles because of roundoff issues when
profile of clones is subtracted from profile of offline body.  This is checked
by presence of ipa counter. This breaks with partial profile training because
we turn IPA profiles to local when they drop to 0.

* ipa-inline-analysis.c (do_estimate_edge_time): Silence overactive
sanity check.

From-SVN: r279090

4 years agore PR tree-optimization/92860 (Global flags affected by -O settings are clobbered...
Jan Hubicka [Sun, 8 Dec 2019 13:50:32 +0000 (14:50 +0100)]
re PR tree-optimization/92860 (Global flags affected by -O settings are clobbered by optimize attribute)

PR tree-optimization/92860
* common.opt (fprofile-reorder-functions, ftoplevel-reorder): Add
Optimization flag.

From-SVN: r279089

4 years agoError on Associate with a program.
Thomas Koenig [Sun, 8 Dec 2019 13:42:42 +0000 (13:42 +0000)]
Error on Associate with a program.

2018-12-08  Thomas Koenig  <tkoenig@gcc.gnu.org>

    PR fortran/92780
    * resolve.c (resolve_assoc_var): Issue error if the associating
    entity is a program.

2018-12-08  Thomas Koenig  <tkoenig@gcc.gnu.org>

    PR fortran/92780
    * gfortran.dg/associate_50.f90: New test.

From-SVN: r279088

4 years agore PR fortran/92764 (ICE in gfc_procedure_use)
Thomas Koenig [Sun, 8 Dec 2019 13:02:54 +0000 (13:02 +0000)]
re PR fortran/92764 (ICE in gfc_procedure_use)

2018-12-08  Thomas Koenig  <tkoenig@gcc.gnu.org>

    PR fortran/92764
    * interface.c (gfc_procedure_use): Check for existence of derived
    component before using (twice).

2018-12-08  Thomas Koenig  <tkoenig@gcc.gnu.org>

    PR fortran/92764
    * gfortran.dg/interface_44.f90: New test.

From-SVN: r279087

4 years agore PR fortran/92755 (ICE in gfc_dep_resolver, at fortran/dependency.c:2123)
Thomas Koenig [Sun, 8 Dec 2019 12:25:15 +0000 (12:25 +0000)]
re PR fortran/92755 (ICE in gfc_dep_resolver, at fortran/dependency.c:2123)

2019-12-08  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/92755
* dependency.c (gfc_dep_resolver):  Move skipping of _data ref
into the loop.

2019-12-08  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/92755
* gfortran.dg/dependency_57.f90: New test.

From-SVN: r279086

4 years agoFix ia32 testsuite failures from C2x attributes on types
Rainer Orth [Sun, 8 Dec 2019 10:51:58 +0000 (10:51 +0000)]
Fix ia32 testsuite failures from C2x attributes on types

* g++.dg/cpp0x/gen-attrs-36.C: Update expected diagnostics.
* g++.dg/cpp0x/gen-attrs-37.C: Likewise.
* g++.dg/cpp0x/gen-attrs-8.C: Likewise.

From-SVN: r279085

4 years agoDaily bump.
GCC Administrator [Sun, 8 Dec 2019 00:16:24 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r279084

4 years agoFix libstdc++ compiling for an aarch64 multilib with big-endian.
Andrew Pinski [Sun, 8 Dec 2019 00:08:55 +0000 (00:08 +0000)]
Fix libstdc++ compiling for an aarch64 multilib with big-endian.

2019-12-07  Andrew Pinski  <apinski@marvell.com>

        * config/cpu/aarch64/opt/ext/opt_random.h: Wrap around with check
        for little-endian like ext/random is done.

From-SVN: r279081

4 years agoPR c++/91678 - wrong error with decltype and location wrapper.
Marek Polacek [Sat, 7 Dec 2019 17:35:54 +0000 (17:35 +0000)]
PR c++/91678 - wrong error with decltype and location wrapper.

Compiling this testcase results in a bogus "invalid cast" error; this occurs
since the introduction of location wrappers in finish_id_expression.

Here we are parsing the decltype expression via cp_parser_decltype_expr which
can lead to calling various fold_* and c-family routines.  They use
non_lvalue_loc, but that won't create a NON_LVALUE_EXPR wrapper around a location
wrapper.

So before the location wrappers addition cp_parser_decltype_expr would return
NON_LVALUE_EXPR <c>.  Now it returns VIEW_CONVERT_EXPR<float *>(c), but the
STRIP_ANY_LOCATION_WRAPPER immediately following it strips the location wrapper,
and suddenly we don't know whether we have an lvalue anymore.  And that's sad
because then decltype produces the wrong type, causing nonsense errors.

* fold-const.c (maybe_lvalue_p): Handle VIEW_CONVERT_EXPR.

* g++.dg/cpp0x/decltype73.C: New test.

From-SVN: r279077

4 years agore PR middle-end/90840 (ICE in simplify_subreg, at simplify-rtx.c:6441)
Eric Botcazou [Sat, 7 Dec 2019 12:20:44 +0000 (12:20 +0000)]
re PR middle-end/90840 (ICE in simplify_subreg, at simplify-rtx.c:6441)

PR middle-end/90840
* expr.c (expand_assignment): In the case of a CONCAT on the LHS, make
sure to pass a valid inner mode in calls to simplify_gen_subreg.

From-SVN: r279076

4 years agoFortran] PR 92793 - fix column used for error diagnostic
Tobias Burnus [Sat, 7 Dec 2019 11:07:07 +0000 (11:07 +0000)]
Fortran] PR 92793 - fix column used for error diagnostic

        PR fortran/92793
        * trans.c (gfc_get_location): Declare.
        * trans.c (gfc_get_location): Define; returns column-corrected location.
        (trans_runtime_error_vararg, gfc_trans_runtime_check,
        gfc_generate_module_code): Use new function.
        * trans-array.c (gfc_trans_auto_array_allocation): Likewise.
        * trans-common.c (build_field, get_init_field, create_common): Likewise.
        * trans-decl.c (gfc_build_label_decl, gfc_get_symbol_decl): Likewise.
        * trans-openmp.c (gfc_trans_omp_reduction_list, gfc_trans_omp_clauses):
        Likewise.
        * trans-stmt.c (gfc_trans_if_1): Likewise.

From-SVN: r279075

4 years agoFix @multitable handling in texi2pod.pl
Richard Sandiford [Sat, 7 Dec 2019 09:57:04 +0000 (09:57 +0000)]
Fix @multitable handling in texi2pod.pl

While trying out Dennis's Armv8.6-A patch, I noticed that texi2pod.pl
didn't handle the new @multitable correctly.  There were two problems:

(1) @multitables nested in other @tables inherited the @item type from
    the enclosing @table.  Since the new @multitable is in a @table @samp,
    we applied @samp markup to the @multitable @items.  This in turn
    meant that it captured the @tab separator in the @item markup.

    Fixed by pushing an empty item code onto the stack.

(2) We didn't handle @headitem.  Fixed by enclosing it in italics,
    like we do for section headings.  This causes it to be underlined
    in the man output.

2019-12-07  Richard Sandiford  <richard.sandiford@arm.com>

contrib/
* texi2pod.pl: Handle @headitems in @multitables, printing them
in italics.  Push an empty item code onto the stack.

From-SVN: r279074

4 years agore PR c/87488 (hyperlink filenames in diagnostics)
Tobias Burnus [Sat, 7 Dec 2019 08:24:14 +0000 (08:24 +0000)]
re PR c/87488 (hyperlink filenames in diagnostics)

PR c/87488
* pretty-print.c (pp_begin_url, pp_end_url, test_urls): Use BEL
instead of ST sequence to terminate OSC 8 strings.

Co-Authored-By: David Malcolm <dmalcolm@redhat.com>
Co-Authored-By: Jakub Jelinek <jakub@redhat.com>
From-SVN: r279073

4 years agoDaily bump.
GCC Administrator [Sat, 7 Dec 2019 00:16:19 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r279072

4 years agore PR c++/92831 (CWG1299 extend_ref_init_temps_1 punts on COND_EXPRs)
Jakub Jelinek [Fri, 6 Dec 2019 23:43:45 +0000 (00:43 +0100)]
re PR c++/92831 (CWG1299 extend_ref_init_temps_1 punts on COND_EXPRs)

PR c++/92831
* call.c (build_conditional_expr_1): For ?: with omitted middle
operand use cp_stabilize_reference if arg1 is glvalue_p rather than
just if it is lvalue_p.

* g++.dg/ext/temp-extend1.C: New test.

From-SVN: r279069

4 years agoFix read buffer overflow in split_directories
Tim Ruehsen [Fri, 6 Dec 2019 22:20:06 +0000 (22:20 +0000)]
Fix read buffer overflow in split_directories

        * make-relative-prefix.c (split_directories):
        Return early on empty 'name'

From-SVN: r279068

4 years agoAdd test for c++/92451.
Marek Polacek [Fri, 6 Dec 2019 22:12:51 +0000 (22:12 +0000)]
Add test for c++/92451.

This was ICEing from r277865 to r278786.

* g++.dg/overload/error4.C: New test.

From-SVN: r279067

4 years agoparser.c (cp_parser_diagnose_invalid_type_name): Mention that concept is also availab...
Jakub Jelinek [Fri, 6 Dec 2019 21:18:58 +0000 (22:18 +0100)]
parser.c (cp_parser_diagnose_invalid_type_name): Mention that concept is also available with -std=c++2a.

* parser.c (cp_parser_diagnose_invalid_type_name): Mention
that concept is also available with -std=c++2a.

From-SVN: r279066

4 years agoc-cppbuiltin.c (c_cpp_builtins): Don't define __cpp_consteval for now.
Jakub Jelinek [Fri, 6 Dec 2019 21:18:10 +0000 (22:18 +0100)]
c-cppbuiltin.c (c_cpp_builtins): Don't define __cpp_consteval for now.

* c-cppbuiltin.c (c_cpp_builtins): Don't define __cpp_consteval for
now.

* g++.dg/cpp2a/feat-cxx2a.C: Don't test __cpp_consteval for now.

From-SVN: r279065

4 years agoPR c++/92831 - CWG 1299, not extending temporary lifetime for ?:
Jakub Jelinek [Fri, 6 Dec 2019 20:16:27 +0000 (21:16 +0100)]
PR c++/92831 - CWG 1299, not extending temporary lifetime for ?:

* cp-tree.h (extend_ref_init_temps): Add a new argument with NULL
default arg.
* call.c (set_up_extended_ref_temp): Add COND_GUARD argument, pass it
down to extend_ref_init_temps.  Before pushing cleanup, if COND_GUARD
is non-NULL, create a bool temporary if needed, initialize to false
and guard the cleanup with the temporary being true.
(extend_ref_init_temps_1): Add COND_GUARD argument, pass it down
to recursive calls and set_up_extended_ref_temp.  Handle COND_EXPR.
(extend_ref_init_temps): Add COND_GUARD argument, pass it down to
recursive calls and to extend_ref_init_temps_1.

* g++.dg/cpp0x/temp-extend2.C: New test.

From-SVN: r279064

4 years agore PR go/92820 (libgo.so.15 has executable stack)
Ian Lance Taylor [Fri, 6 Dec 2019 19:52:46 +0000 (19:52 +0000)]
re PR go/92820 (libgo.so.15 has executable stack)

PR go/92820
    runtime: only build go-context for x86 GNU/Linux

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/210258

From-SVN: r279063

4 years agore PR other/29842 ([meta-bug] outstanding patches / issues from STMicroelectronics)
Ian Lance Taylor [Fri, 6 Dec 2019 19:37:39 +0000 (19:37 +0000)]
re PR other/29842 ([meta-bug] outstanding patches / issues from STMicroelectronics)

PR go/29842
    runtime: update HURD support for mOS now being embedded

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/210285

From-SVN: r279062