Linus Mårtensson [Wed, 8 May 2013 12:10:07 +0000 (14:10 +0200)]
build: add android support
Resolves minor discrepancies between android and standard POSIX systems.
In addition, some configure parameters were added, and a helper-script
for android configuration. Ideally, this script should be merged into
the standard configure script.
To build for android, source the android-configure script with an NDK
path:
source ./android-configure ~/android-ndk-r8d
This will create an android standalone toolchain and export the
necessary environment parameters.
After that, build as normal:
make -j8
After the build, you should now have android-compatible NodeJS binaries.
Krzysztof Chrapka [Tue, 4 Jun 2013 15:01:14 +0000 (17:01 +0200)]
readline: strip ctrl chars for prompt width calc
Use regular expression to strip vt ansi escape codes from display when
calulating prompt display width and cursor position
Fixes #3860 and #5628.
Fedor Indutny [Mon, 17 Jun 2013 10:11:13 +0000 (12:11 +0200)]
tls: session API returns
isaacs [Mon, 17 Jun 2013 01:56:00 +0000 (18:56 -0700)]
doc: Correct TLS deprecation notices
Ben Noordhuis [Sun, 16 Jun 2013 23:23:57 +0000 (01:23 +0200)]
stream_wrap: fix signed/unsigned comparison warning
Ben Noordhuis [Sun, 16 Jun 2013 23:22:41 +0000 (01:22 +0200)]
cares: fix uninitialized variable warning
Suppress the following warning:
../../src/cares_wrap.cc: In function ‘v8::Handle<v8::Value>
node::cares_wrap::SetServers(const v8::Arguments&)’:
../../src/cares_wrap.cc:1017:5: warning: ‘uv_ret.uv_err_s::code’
may be used uninitialized in this function [-Wuninitialized]
Fedor Indutny [Thu, 13 Jun 2013 19:47:31 +0000 (21:47 +0200)]
tls: share socket._hadError with http_client
Fedor Indutny [Thu, 13 Jun 2013 13:36:00 +0000 (15:36 +0200)]
tls: introduce TLSSocket based on tls_wrap binding
Split `tls.js` into `_tls_legacy.js`, containing legacy
`createSecurePair` API, and `_tls_wrap.js` containing new code based on
`tls_wrap` binding.
Remove tests that are no longer useful/valid.
Fedor Indutny [Tue, 11 Jun 2013 10:59:10 +0000 (12:59 +0200)]
tls_wrap: embed TLS encryption into streamwrap
Fedor Indutny [Tue, 11 Jun 2013 10:55:49 +0000 (12:55 +0200)]
stream_wrap: introduce StreamWrapCallbacks
StreamWrapCallbacks is a helper class for incepting into uv_stream_t*
management process.
Fedor Indutny [Tue, 11 Jun 2013 10:52:27 +0000 (12:52 +0200)]
process: abstract out HandleToStream
Originally contributed by @tjfontaine, but modified to be faster and
more generic.
Fedor Indutny [Thu, 13 Jun 2013 11:29:15 +0000 (13:29 +0200)]
crypto: clear error on return in AddCRL
Fedor Indutny [Tue, 11 Jun 2013 14:11:48 +0000 (16:11 +0200)]
crypto: ensure that read head is always non-empty
Fedor Indutny [Thu, 13 Jun 2013 10:59:29 +0000 (12:59 +0200)]
crypto: do not deallocate embedded buffer
Fedor Indutny [Tue, 11 Jun 2013 10:49:03 +0000 (12:49 +0200)]
crypto: fix excessive buffer allocation
Allocate buffer only if the next one isn't free.
Trevor Norris [Tue, 11 Jun 2013 21:30:16 +0000 (14:30 -0700)]
string_bytes: write strings using new API
StringBytes::Write now uses new v8 API and also does preliminary check
if the string is external, then will use external memory instead.
Trevor Norris [Sun, 9 Jun 2013 22:54:30 +0000 (15:54 -0700)]
string_bytes: use external for large strings
When large strings are used they cause v8's GC to spend a lot more time
cleaning up. In these cases it's much faster to use external string
resources.
UTF8 strings do not use external string resources because only one and
two byte external strings are supported.
EXTERN_APEX is the value at which v8's GC overtakes performance.
The following table has the type and buffer size that use to encode the
strings as rough estimates of the percentage of performance gain from
this patch (UTF8 is missing because they cannot be externalized).
encoding 128KB 1MB 5MB
-----------------------------
ASCII 58% 208% 250%
HEX 15% 74% 86%
BASE64 11% 74% 71%
UCS2 2% 225% 398%
BINARY 2234% 1728% 2305%
BINARY is so much faster across the board because of using the new v8
WriteOneByte API.
Trevor Norris [Sun, 9 Jun 2013 21:34:11 +0000 (14:34 -0700)]
string_bytes: implement new v8 API
v8 has a new API to write out strings to memory. This has been
implemented.
One other change of note is BINARY encoded strings have a new
implementation. This has improved performance substantially.
Trevor Norris [Sun, 9 Jun 2013 21:20:01 +0000 (14:20 -0700)]
lint: add mising isolates and minor style fixes
Ben Noordhuis [Tue, 11 Jun 2013 22:24:41 +0000 (00:24 +0200)]
test: fix up weakref.cc after v8 api change
Ben Noordhuis [Tue, 11 Jun 2013 22:07:26 +0000 (00:07 +0200)]
src: upgrade after v8 api change
The prototype of v8::Persistent<T>::MakeWeak() has changed. Update the
code in src/ to follow suit.
Ben Noordhuis [Mon, 8 Apr 2013 18:34:11 +0000 (20:34 +0200)]
v8: reapply floating patches
Ben Noordhuis [Tue, 11 Jun 2013 21:45:46 +0000 (23:45 +0200)]
v8: upgrade to v3.19.13
Fedor Indutny [Fri, 7 Jun 2013 11:31:24 +0000 (15:31 +0400)]
crypto: free excessive memory in NodeBIO
Before this commit NodeBIO never shrank, possibly consuming a lot of
memory (depending on reader's haste).
All buffers between write_head's child and read_head should be
deallocated on read, leaving only space left in write_head and in the
next buffer.
Ben Noordhuis [Fri, 7 Jun 2013 14:47:54 +0000 (16:47 +0200)]
src: unexport node_isolate
Commit
0bba5902 accidentally (or maybe erroneously) added node_isolate
to src/node.h and src/node_object_wrap.h.
Undo that, said variable is not for public consumption. Add-on authors
should use v8::Isolate::GetCurrent() instead.
I missed that while reviewing. Mea culpa.
Fixes #5639.
isaacs [Wed, 5 Jun 2013 20:38:38 +0000 (13:38 -0700)]
Merge remote-tracking branch 'ry/v0.10'
Conflicts:
ChangeLog
deps/uv/AUTHORS
deps/uv/ChangeLog
deps/uv/src/unix/linux-core.c
deps/uv/src/version.c
deps/uv/src/win/timer.c
lib/url.js
src/node_version.h
test/simple/test-url.js
isaacs [Wed, 5 Jun 2013 06:43:29 +0000 (23:43 -0700)]
net: Destroy when not readable and not writable
This is only relevant for CentOS 6.3 using kernel version 2.6.32.
On other linuxes and darwin, the `read` call gets an ECONNRESET in that
case. On sunos, the `write` call fails with EPIPE.
However, old CentOS will occasionally send an EOF instead of a
ECONNRESET or EPIPE when the client has been destroyed abruptly.
Make sure we don't keep trying to write or read more in that case.
Fixes #5504
However, there is still the question of what libuv should do when it
gets an EOF. Apparently in this case, it will continue trying to read,
which is almost certainly the wrong thing to do.
That should be fixed in libuv, even though this works around the issue.
isaacs [Tue, 4 Jun 2013 21:38:41 +0000 (14:38 -0700)]
Now working on v0.10.11
isaacs [Tue, 4 Jun 2013 21:38:29 +0000 (14:38 -0700)]
blog: Release v0.10.10
isaacs [Tue, 4 Jun 2013 21:38:10 +0000 (14:38 -0700)]
Merge branch 'v0.10.10-release' into v0.10
isaacs [Tue, 4 Jun 2013 19:13:46 +0000 (12:13 -0700)]
2013.06.04, Version 0.10.10 (Stable)
* uv: Upgrade to 0.10.10
* npm: Upgrade to 1.2.25
* url: Properly parse certain oddly formed urls (isaacs)
* stream: unshift('') is a noop (isaacs)
isaacs [Tue, 4 Jun 2013 19:11:03 +0000 (12:11 -0700)]
uv: Upgrade to 0.10.10
Ben Noordhuis [Tue, 21 May 2013 21:04:58 +0000 (23:04 +0200)]
url: remove unused global variable
isaacs [Tue, 4 Jun 2013 18:42:32 +0000 (11:42 -0700)]
npm: Upgrade to 1.2.25
isaacs [Tue, 4 Jun 2013 18:22:14 +0000 (11:22 -0700)]
doc: ChangeLog update for v0.8.24
isaacs [Tue, 4 Jun 2013 18:19:10 +0000 (11:19 -0700)]
blog: 0.8 is maintenace, not stable
isaacs [Tue, 4 Jun 2013 18:12:54 +0000 (11:12 -0700)]
blog: Release v0.8.24
isaacs [Tue, 4 Jun 2013 18:12:44 +0000 (11:12 -0700)]
blog: Release v0.10.9
Ben Noordhuis [Tue, 4 Jun 2013 10:21:58 +0000 (12:21 +0200)]
src: replace ngx-queue.h with queue.h
No functional changes, just one less entry in the LICENSE file.
Nick Desaulniers [Tue, 4 Jun 2013 07:09:00 +0000 (00:09 -0700)]
src: wrap macros in `do {...} while (0)`
Wrapped two macros in do {...} while (0) blocks and lined up
backslashes. Uses up semicolon in contexts where a dangling semicolon
is erroneous.
isaacs [Mon, 3 Jun 2013 23:02:51 +0000 (16:02 -0700)]
url: Set href to null by default
isaacs [Mon, 3 Jun 2013 20:39:57 +0000 (13:39 -0700)]
url: Properly parse certain oddly formed urls
In cases where there are multiple @-chars in a url, Node currently
parses the hostname and auth sections differently than web browsers.
This part of the bug is serious, and should be landed in v0.10, and
also ported to v0.8, and releases made as soon as possible.
The less serious issue is that there are many other sorts of malformed
urls which Node either accepts when it should reject, or interprets
differently than web browsers. For example, `http://a.com*foo` is
interpreted by Node like `http://a.com/*foo` when web browsers treat
this as `http://a.com%3Bfoo/`.
In general, *only* the `hostEndingChars` should be the characters that
delimit the host portion of the URL. Most of the current `nonHostChars`
that appear in the hostname should be escaped, but some of them (such as
`;` and `%` when it does not introduce a hex pair) should raise an
error.
We need to have a broader discussion about whether it's best to throw in
these cases, and potentially break extant programs, or return an object
that has every field set to `null` so that any attempt to read the
hostname/auth/etc. will appear to be empty.
isaacs [Mon, 3 Jun 2013 17:50:02 +0000 (10:50 -0700)]
stream: unshift('') is a noop
In some cases, the http CONNECT/Upgrade API is unshifting an empty
bodyHead buffer onto the socket.
Normally, stream.unshift(chunk) does not set state.reading=false.
However, this check was not being done for the case when the chunk was
empty (either `''` or `Buffer(0)`), and as a result, it was causing the
socket to think that a read had completed, and to stop providing data.
This bug is not limited to http or web sockets, but rather would affect
any parser that unshifts data back onto the source stream without being
very careful to never unshift an empty chunk. Since the intent of
unshift is to *not* change the state.reading property, this is a bug.
Fixes #5557
Fixes LearnBoost/socket.io#1242
isaacs [Fri, 31 May 2013 18:52:57 +0000 (11:52 -0700)]
Merge remote-tracking branch 'ry/v0.10'
Conflicts:
ChangeLog
src/node_version.h
Trevor Norris [Thu, 30 May 2013 23:51:41 +0000 (16:51 -0700)]
process: use Tock for nextTickQueue items
v8 plays very well with constructed objects, so we're using one in the
nextTickQueue.
Trevor Norris [Thu, 30 May 2013 22:09:50 +0000 (15:09 -0700)]
src: remove old comment code
Now that maxTickDepth no longer exists there's no depth index on
infoBox. Forgot to remove the comment about this.
Trevor Norris [Thu, 30 May 2013 17:33:29 +0000 (10:33 -0700)]
process: remove spinner
Remove the need to call start/stop the uv_idle spinner between
MakeCallbacks. The one place where the tick processor needs to be kicked
is where a user catches uncaughtException. For that we'll now use
setImmediate, which accomplishes the same task.
isaacs [Thu, 30 May 2013 18:28:07 +0000 (11:28 -0700)]
Now working on v0.10.10
isaacs [Thu, 30 May 2013 18:27:50 +0000 (11:27 -0700)]
Merge branch 'v0.10.9-release' into v0.10
isaacs [Thu, 30 May 2013 17:31:07 +0000 (10:31 -0700)]
2013.05.30, Version 0.10.9 (Stable)
* npm: Upgrade to 1.2.24
* uv: Upgrade to v0.10.9
* repl: fix JSON.parse error check (Brian White)
* tls: proper .destroySoon (Fedor Indutny)
* tls: invoke write cb only after opposite read end (Fedor Indutny)
* tls: ignore .shutdown() syscall error (Fedor Indutny)
isaacs [Thu, 30 May 2013 17:19:45 +0000 (10:19 -0700)]
npm: Upgrade to 1.2.24
Trevor Norris [Thu, 30 May 2013 08:38:19 +0000 (01:38 -0700)]
process: remove max tick check for domains
maxTickDepth checks have been removed for domains and replaced with a
flag that checks if the last callback threw. If it did then execution of
the remaining tickQueue is deferred to the spinner.
This is to prevent domains from entering a continuous loop when an error
callback also throws an error.
Trevor Norris [Wed, 29 May 2013 22:19:34 +0000 (15:19 -0700)]
process: remove maxTickDepth from _tickCallback
Removes the check for maxTickDepth for non-domain callbacks. So a user
can starve I/O by setting a recursive nextTick.
The domain case is more complex and will be addressed in another commit.
Trevor Norris [Wed, 29 May 2013 21:52:10 +0000 (14:52 -0700)]
process: relocate needSpinner calls
It's only necessary to request the spinner once tickDone has been
called, and not on every nextTick.
Andrew Paprocki [Tue, 28 May 2013 17:16:16 +0000 (13:16 -0400)]
vm: fix race condition in watchdog cleanup
Previous code was calling uv_loop_delete() directly on a running loop,
which led to race condition aborts/segfaults within libuv. This change
changes the watchdog thread to call uv_run() with UV_RUN_ONCE so that
the call exits after either the timer times out or uv_async_send() is
called from the main thread in Watchdog::Destroy(). The timer/async
handles are then closed and uv_run() with UV_RUN_DEFAULT is called so
that libuv has a chance to cleanup before the thread exits. The main
thread meanwhile calls uv_thread_join() and then uv_loop_delete() to
complete the cleanup.
Kiyoshi Nomo [Wed, 22 May 2013 14:22:21 +0000 (23:22 +0900)]
doc: remove `bufferSize` option
`bufferSize` option has been removed in b0f6789.
Ryunosuke SATO [Sat, 25 May 2013 20:03:02 +0000 (05:03 +0900)]
events: define properties on prototype
Speeds up EventEmitter object construction by about 15-20%.
Brian White [Sun, 26 May 2013 16:26:39 +0000 (12:26 -0400)]
repl: fix JSON.parse error check
Before this, entering something like:
> JSON.parse('066');
resulted in the "..." prompt instead of displaying the expected
"SyntaxError: Unexpected number"
Brian White [Wed, 29 May 2013 03:36:26 +0000 (23:36 -0400)]
buffer: return `this` in fill() for chainability
Fedor Indutny [Thu, 30 May 2013 09:35:24 +0000 (13:35 +0400)]
tls: proper .destroySoon
1. Emit `sslOutEnd` only when `_internallyPendingBytes() === 0`.
2. Read before checking `._halfRead`, otherwise we'll see only previous
value, and will invoke `._write` callback improperly.
3. Wait for both `end` and `finish` events in `.destroySoon`.
4. Unpipe encrypted stream from socket to prevent write after destroy.
Bert Belder [Wed, 29 May 2013 23:09:54 +0000 (01:09 +0200)]
uv: upgrade to v0.11.4
Ben Noordhuis [Sun, 26 May 2013 19:42:23 +0000 (21:42 +0200)]
buffer: guard against integer overflow
Ben Noordhuis [Sun, 26 May 2013 19:41:20 +0000 (21:41 +0200)]
buffer: simplify ReadFloatGeneric offset checks
Ben Noordhuis [Sun, 26 May 2013 19:21:57 +0000 (21:21 +0200)]
os: use IsBigEndian() in GetEndianness() function
Ben Noordhuis [Sun, 26 May 2013 19:17:35 +0000 (21:17 +0200)]
buffer: guard against pointer aliasing issues
Ben Noordhuis [Sun, 26 May 2013 18:32:37 +0000 (20:32 +0200)]
src: add endianness helper functions
Ben Noordhuis [Sun, 26 May 2013 18:04:17 +0000 (20:04 +0200)]
src: simplify HandleWrap initialization
Ben Noordhuis [Sun, 26 May 2013 15:06:45 +0000 (17:06 +0200)]
src: replace c-style casts with c++-style casts
Ben Noordhuis [Wed, 29 May 2013 21:12:11 +0000 (23:12 +0200)]
Merge remote-tracking branch 'origin/v0.10'
Conflicts:
deps/uv/ChangeLog
deps/uv/src/unix/stream.c
deps/uv/src/version.c
lib/tls.js
Ben Noordhuis [Wed, 29 May 2013 14:35:00 +0000 (16:35 +0200)]
doc: sending dgram handles only works on unix
Daniel G. Taylor [Wed, 15 May 2013 19:16:09 +0000 (13:16 -0600)]
https: Add `secureProtocol` docs
Add `secureProtocol` parameter docs to the https.request method.
Daniel G. Taylor [Wed, 15 May 2013 19:14:20 +0000 (13:14 -0600)]
tls: Add `secureProtocol` docs
Add `secureProtocol` parameter docs to the tls.connect method.
isaacs [Tue, 28 May 2013 19:10:14 +0000 (12:10 -0700)]
uv: Upgrade to v0.10.9
Fedor Indutny [Mon, 27 May 2013 10:44:33 +0000 (14:44 +0400)]
tls: invoke write cb only after opposite read end
Stream's `._write()` callback should be invoked only after it's opposite
stream has finished processing incoming data, otherwise `finish` event
fires too early and connection might be closed while there's some data
to send to the client.
see #5544
Fedor Indutny [Tue, 28 May 2013 13:50:38 +0000 (17:50 +0400)]
tls: ignore .shutdown() syscall error
Quote from SSL_shutdown man page:
The output of SSL_get_error(3) may be misleading,
as an erroneous SSL_ERROR_SYSCALL may be flagged even though
no error occurred.
Also, handle all other errors to prevent assertion in `ClearError()`.
isaacs [Sat, 25 May 2013 00:16:08 +0000 (17:16 -0700)]
Merge remote-tracking branch 'ry/v0.10'
Conflicts:
AUTHORS
ChangeLog
configure
deps/uv/ChangeLog
deps/uv/src/unix/darwin.c
deps/uv/src/unix/stream.c
deps/uv/src/version.c
deps/v8/src/isolate.cc
deps/v8/src/version.cc
lib/http.js
src/node_version.h
Rafael Henrique Moreira [Sat, 25 May 2013 03:49:49 +0000 (03:49 +0000)]
doc: add link to Brazilian Node community
Add a link to the Brazilian community portal.
Rafael Henrique Moreira [Sat, 25 May 2013 04:01:25 +0000 (04:01 +0000)]
doc: remove broken links on community page
Links to Node Manual and Node Bits both are broken, so this commit
removes them from the community page.
isaacs [Fri, 24 May 2013 22:45:59 +0000 (15:45 -0700)]
blog: Post for v0.10.8
isaacs [Fri, 24 May 2013 22:45:46 +0000 (15:45 -0700)]
Now working on 0.10.9
isaacs [Fri, 24 May 2013 22:44:04 +0000 (15:44 -0700)]
Merge branch 'v0.10.8-release' into v0.10
isaacs [Fri, 24 May 2013 21:45:24 +0000 (14:45 -0700)]
2013.05.24, Version 0.10.8 (Stable)
* v8: update to 3.14.5.9
* uv: upgrade to 0.10.8
* npm: Upgrade to 1.2.23
* http: remove bodyHead from 'upgrade' events (Nathan Zadoks)
* http: Return true on empty writes, not false (isaacs)
* http: save roundtrips, convert buffers to strings (Ben Noordhuis)
* configure: respect the --dest-os flag consistently (Nathan Rajlich)
* buffer: throw when writing beyond buffer (Trevor Norris)
* crypto: Clear error after DiffieHellman key errors (isaacs)
* string_bytes: strip padding from base64 strings (Trevor Norris)
isaacs [Fri, 24 May 2013 22:06:03 +0000 (15:06 -0700)]
doc: Minor fixup in http doc re bodyHead
Fedor Indutny [Fri, 24 May 2013 21:02:34 +0000 (01:02 +0400)]
tls: retry writing after hello parse error
When writing bad data to EncryptedStream it'll first get to the
ClientHello parser, and, only after it will refuse it, to the OpenSSL.
But ClientHello parser has limited buffer and therefore write could
return `bytes_written` < `incoming_bytes`, which is not the case when
working with OpenSSL.
After such errors ClientHello parser disables itself and will
pass-through all data to the OpenSSL. So just trying to write data one
more time will throw the rest into OpenSSL and let it handle it.
isaacs [Fri, 24 May 2013 21:41:43 +0000 (14:41 -0700)]
npm: Upgrade to 1.2.23
isaacs [Fri, 24 May 2013 21:41:00 +0000 (14:41 -0700)]
uv: upgrade to 0.10.8
Nathan Zadoks [Fri, 24 May 2013 17:34:38 +0000 (19:34 +0200)]
http: remove bodyHead from 'upgrade' events
Streams2 makes this unnecessary.
An empty buffer is provided for compatibility.
isaacs [Fri, 24 May 2013 15:57:30 +0000 (08:57 -0700)]
Remove .travis.yml file.
This leads people to dump their fork build info into the IRC channel,
which is noisy and unhelpful.
Timothy J Fontaine [Thu, 23 May 2013 23:23:07 +0000 (16:23 -0700)]
buffer: special case empty string writes
Prior to 119354f we specifically handled passing a zero length string
to write on a buffer, restore that functionality.
isaacs [Thu, 23 May 2013 22:12:13 +0000 (15:12 -0700)]
http: Return true on empty writes, not false
Otherwise, writing an empty string causes the whole program to grind to
a halt when piping data into http messages.
This wasn't as much of a problem (though it WAS a bug) in 0.8 and
before, because our hyperactive 'drain' behavior would mean that some
*previous* write() would probably have a pending drain event, and cause
things to start moving again.
Timothy J Fontaine [Thu, 23 May 2013 20:40:40 +0000 (13:40 -0700)]
v8: re-apply floating patches
Timothy J Fontaine [Thu, 23 May 2013 20:57:59 +0000 (13:57 -0700)]
v8: fix GetLocalizedMessage usage
As is the backport of the abort on uncaught exception wouldn't compile
because we it was passing in `this` when it was unnecessary.
Timothy J Fontaine [Thu, 23 May 2013 20:39:12 +0000 (13:39 -0700)]
v8: update to 3.14.5.9
Timothy J Fontaine [Sun, 31 Mar 2013 03:56:39 +0000 (20:56 -0700)]
systemtap: add tapset for node user probes
This makes systemtap tracing prettier, you can do things like `stap -e
'probe node_http_server_request { println(probestr); }'`
Timothy J Fontaine [Sun, 31 Mar 2013 02:51:17 +0000 (19:51 -0700)]
dtrace: unify dtrace and systemtap interfaces
Timothy J Fontaine [Wed, 22 May 2013 18:32:54 +0000 (11:32 -0700)]
timers: use uv_now instead of Date.now
This saves a few calls to gettimeofday which can be expensive, and
potentially subject to clock drift. Instead use the loop time which
uses hrtime internally.
fixes #5497
Ben Noordhuis [Wed, 22 May 2013 19:43:35 +0000 (21:43 +0200)]
http: save roundtrips, convert buffers to strings
This commit adds an optimization to the HTTP client that makes it
possible to:
* Pack the headers and the first chunk of the request body into a
single write().
* Pack the chunk header and the chunk itself into a single write().
Because only one write() system call is issued instead of several,
the chances of data ending up in a single TCP packet are phenomenally
higher: the benchmark with `type=buf size=32` jumps from 50 req/s to
7,500 req/s, a 150-fold increase.
This commit removes the check from
e4b716ef that pushes binary encoded
strings into the slow path. The commit log mentions that:
We were assuming that any string can be concatenated safely to
CRLF. However, for hex, base64, or binary encoded writes, this
is not the case, and results in sending the incorrect response.
For hex and base64 strings that's certainly true but binary strings
are 'das Ding an sich': string.length is the same before and after
decoding.
Fixes #5528.
Trevor Norris [Wed, 22 May 2013 23:09:06 +0000 (16:09 -0700)]
src: remove unused comment
Now that Context::New(Isolate*) returns Local, the removed comment is
no longer applicable that there is a Persistent which will need to be
disposed.
Trevor Norris [Wed, 22 May 2013 20:04:41 +0000 (13:04 -0700)]
src: upgrade to new v8 api
Small change that Context::New requires an isolate and returns Local
instead of Persistent.
Ben Noordhuis [Mon, 8 Apr 2013 18:34:11 +0000 (20:34 +0200)]
v8: reapply floating patches