Matthias Clasen [Mon, 20 May 2013 10:38:41 +0000 (06:38 -0400)]
Convert some gio tests to installed tests
Matthias Clasen [Mon, 20 May 2013 01:49:51 +0000 (21:49 -0400)]
Make gobject tests installable
This makes the gobject tests run as part of the ostree integration
tests.
Milo Casagrande [Sun, 19 May 2013 11:30:46 +0000 (13:30 +0200)]
[l10n] Updated Italian translation.
Colin Walters [Mon, 6 May 2013 13:47:00 +0000 (09:47 -0400)]
Add --enable-installed-tests configure option
See https://live.gnome.org/GnomeGoals/InstalledTests for more
information.
The tests now support being run both uninstalled and installed, so
'make check' works for those who want it. For tests which need data
files, the way this works is they look in the compiled in value of
SRCDIR by default, and the generated tests use "env G_TEST_DATA=" to
override that.
This patch only converts glib/tests for now; if this patch looks good,
I'll do the rest of the tests.
https://bugzilla.gnome.org/show_bug.cgi?id=699079
Colin Walters [Mon, 6 May 2013 13:24:25 +0000 (09:24 -0400)]
glib/tests: Drop unnecessary SRCDIR definitions
It's always going to be defined, we don't support compiling these
tests "by hand". This is a cleanup commit for the installed tests
work.
https://bugzilla.gnome.org/show_bug.cgi?id=699079
Colin Walters [Fri, 3 May 2013 22:36:43 +0000 (18:36 -0400)]
glib/tests: Use explicit file listings
This is a preparatory commit for installed tests work; having things
cleanly categorized helps.
https://bugzilla.gnome.org/show_bug.cgi?id=699079
Colin Walters [Fri, 3 May 2013 22:13:51 +0000 (18:13 -0400)]
glib/tests/mappedfile: Copy test file before writing to it
This way we're *always* testing writability rather than only sometimes
doing it in the source directory.
https://bugzilla.gnome.org/show_bug.cgi?id=699079
Jorge Pérez Pérez [Wed, 15 May 2013 21:05:10 +0000 (23:05 +0200)]
Added Aragonese translation
Adrian Bunk [Mon, 13 May 2013 22:48:37 +0000 (01:48 +0300)]
m4macros/glib-gettext.m4: Don't use AC_HEADER_STDC
AC_HEADER_STDC is obsolete (pre-C89 headers are no longer an issue),
and the resulting STDC_HEADERS define is anyway not used.
https://bugzilla.gnome.org/show_bug.cgi?id=700263
Shankar Prasad [Tue, 14 May 2013 09:56:07 +0000 (15:26 +0530)]
updated kn translations
Dan Winship [Mon, 13 May 2013 15:47:12 +0000 (11:47 -0400)]
tests/slice: use G_GNUC_BEGIN_IGNORE_DEPRECATIONS
rather than implementing it by hand
Dan Winship [Mon, 13 May 2013 15:38:53 +0000 (11:38 -0400)]
gtestutils: use g_clear_pointer
Dan Winship [Wed, 5 Dec 2012 16:28:53 +0000 (11:28 -0500)]
gtestutils: deprecate g_test_trap_fork()
https://bugzilla.gnome.org/show_bug.cgi?id=679683
Dan Winship [Sat, 24 Nov 2012 20:58:36 +0000 (15:58 -0500)]
tests: port from g_test_trap_subprocess() to g_test_trap_fork()
https://bugzilla.gnome.org/show_bug.cgi?id=679683
Dan Winship [Sun, 25 Nov 2012 16:50:09 +0000 (11:50 -0500)]
tests/protocol: redo a bit
Rather than overloading --verbose, just skip the tests that aren't
supposed to be run in the parent process (so that if you do run the
toplevel test with --verbose, it doesn't immediately error out).
https://bugzilla.gnome.org/show_bug.cgi?id=679683
Dan Winship [Sat, 24 Nov 2012 20:58:27 +0000 (15:58 -0500)]
gtestutils: add g_test_trap_subprocess()
g_test_trap_fork() doesn't work on Windows and is potentially flaky on
unix anyway given the fork-but-don't-exec. Replace it with
g_test_trap_subprocess(), which re-spawns the same program with
arguments telling it to run a specific (otherwise-ignored) test case.
Make the existing g_test_trap_fork() unit tests be unix-only (they
never passed on Windows anyway), and add a parallel set of
g_test_trap_subprocess() tests.
Also fix the logic of gtestutils's "-p" argument (which is used by the
subprocess tests); previously if you had tests "/foo/bar" and
"/foo/bar/baz", and ran the test program with "-p /foo/bar/baz", it
would run "/foo/bar" too. Fix that and add tests.
https://bugzilla.gnome.org/show_bug.cgi?id=679683
Dan Winship [Wed, 19 Dec 2012 20:59:55 +0000 (15:59 -0500)]
g_test_trap_fork: don't blow away the SIGCHLD handler
Not sure why it was doing this, but it's not necessary (all of glib's
tests pass fine without it), and it breaks tests that try to use
g_spawn_sync() or GChildWatchSource after doing a g_test_trap_fork().
https://bugzilla.gnome.org/show_bug.cgi?id=679683
Dan Winship [Sun, 25 Nov 2012 18:52:20 +0000 (13:52 -0500)]
tests/spawn-*.c: fix on Windows
Need to append ".exe" to the spawned binary name on Windows
https://bugzilla.gnome.org/show_bug.cgi?id=679683
Christian Persch [Sun, 12 May 2013 19:52:54 +0000 (21:52 +0200)]
app: Document when floating variants are consumed
Bug #700203.
ManojKumar Giri [Fri, 10 May 2013 06:38:27 +0000 (12:08 +0530)]
Updated Odia Translation.
Matthias Clasen [Thu, 9 May 2013 20:02:52 +0000 (16:02 -0400)]
Clarify GValueArray docs
Don't refer to Quicksort in the documentation of
g_value_array_sort, but just to qsort().
Krishnababu Krothapalli [Thu, 9 May 2013 12:33:09 +0000 (18:03 +0530)]
Updated Telugu Translations
Zeeshan Ali (Khattak) [Tue, 20 Mar 2012 20:40:32 +0000 (22:40 +0200)]
Fix minor typos in GSocketConnectable example code
Sebastian Dröge [Mon, 6 May 2013 14:06:48 +0000 (16:06 +0200)]
Declare res_init() for builds against Android's Bionic
res_init() exists in the C library here and as such is detected
by configure, but it is not declared in any header.
Dan Winship [Sun, 5 May 2013 20:50:43 +0000 (16:50 -0400)]
GProxyAddressEnumerator: add default-port property
Although none of the in-tree GSocketConnectable types need it, other
types (like SoupAddress) may find it useful to be able to pass a URI
and a default-port to GProxyAddressEnumerator separately (the same way
you can with GNetworkAddress). So add a default-port property.
https://bugzilla.gnome.org/show_bug.cgi?id=698877
Matthias Clasen [Sun, 5 May 2013 01:10:43 +0000 (21:10 -0400)]
Document all gtester-report options
The --subunit option was missing from the man page.
Matthias Clasen [Sun, 5 May 2013 01:08:18 +0000 (21:08 -0400)]
Document all glib-mkenums placeholders
The @ENUMPREFIX@ placeholder was missing in the man page.
Matthias Clasen [Sun, 5 May 2013 01:05:24 +0000 (21:05 -0400)]
Document all glib-genmarshal options
The --stdinc option was missing from the man page.
Matthias Clasen [Sun, 5 May 2013 01:03:00 +0000 (21:03 -0400)]
Fix a typo
Matthias Clasen [Sun, 5 May 2013 01:01:35 +0000 (21:01 -0400)]
Document all gdbus-codegen options
The --help and --xml-files options were missing from the man page.
Dan Winship [Thu, 2 May 2013 14:14:57 +0000 (10:14 -0400)]
gbitlock: fix this to not unconditionally use futex emulation
Ryan accidentally committed some debugging code a long time ago,
causing this file to always use futex emulation even when real futex
support was available. I noticed this a while later and pointed it out
to him, and assumed he was going to fix it, but I guess he assumed I
was going to fix it, and then neither of us did...
https://bugzilla.gnome.org/show_bug.cgi?id=699500
Matthias Clasen [Fri, 3 May 2013 01:00:57 +0000 (21:00 -0400)]
Silently handle icon being NULL
While an emblemed icon without a base icon is not very
useful, no need to crash here.
This was crashing the object finalization test in gtk.
Emmanuele Bassi [Sun, 14 Apr 2013 20:04:41 +0000 (21:04 +0100)]
binding: Add an explicit unbind()
Higher order languages with garbage collection can have issues releasing
a binding, as they do not control the last reference being dropped on
the binding, source, or target instances.
https://bugzilla.gnome.org/show_bug.cgi?id=698018
Colin Walters [Thu, 2 May 2013 15:39:11 +0000 (11:39 -0400)]
tests/mappedfile: Also handle ENOMEM
The RHEL6.4 kernel gives me that instead of EINVAL.
https://bugzilla.gnome.org/show_bug.cgi?id=699485
Dan Winship [Thu, 2 May 2013 17:58:25 +0000 (13:58 -0400)]
gobject: rename an unused parameter to make AIX happy
Simon McVittie [Thu, 2 May 2013 15:50:01 +0000 (16:50 +0100)]
GSocks5Proxy: don't crash if parsing negotiation reply fails
The GError should be initialized to NULL, otherwise we'll
"pile up" errors, then try to free an uninitialized pointer.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=699493
Rajesh Ranjan [Thu, 2 May 2013 08:15:46 +0000 (13:45 +0530)]
hindi update
Matej Urbančič [Wed, 1 May 2013 18:32:44 +0000 (20:32 +0200)]
Updated Slovenian translation
Matthias Clasen [Wed, 1 May 2013 09:20:02 +0000 (05:20 -0400)]
Bump version to 2.37.1
Matthias Clasen [Wed, 1 May 2013 04:16:25 +0000 (00:16 -0400)]
Add 2.38 indexes to the docs
Matthias Clasen [Wed, 1 May 2013 04:15:06 +0000 (00:15 -0400)]
Updates
Tim Lunn [Wed, 1 May 2013 00:39:26 +0000 (10:39 +1000)]
gio: fix small leak
https://bugzilla.gnome.org/show_bug.cgi?id=699361
Ryan Lortie [Sun, 21 Apr 2013 14:55:40 +0000 (10:55 -0400)]
GApplication: don't leak 'hint' on remote Open
We were using format string "s" to deconstruct the open hint into a
'const gchar *' which, of course, we never freed. Fix that.
Cosimo Cecchi [Fri, 26 Apr 2013 21:11:02 +0000 (17:11 -0400)]
bytesicon: don't use g_object_unref() on GBytes
We need to use g_bytes_unref()
https://bugzilla.gnome.org/show_bug.cgi?id=699001
Cosimo Cecchi [Fri, 26 Apr 2013 21:07:41 +0000 (17:07 -0400)]
bytesicon: fix a memory leak
https://bugzilla.gnome.org/show_bug.cgi?id=698999
Colin Walters [Fri, 26 Apr 2013 12:12:01 +0000 (08:12 -0400)]
configure: Assume C90 compatible malloc() prototype
This ancient code was attempting to cope with (unknown) systems whose
malloc() prototype was incompatible with the standard. This test was
fragile; it would break if the build environment provided -Wall in
CFLAGS.
Now that it's 2013, let's assume that target systems have a sane
malloc(). If someone complains, we can revisit this.
https://bugzilla.gnome.org/698716
Ryan Lortie [Fri, 26 Apr 2013 15:27:51 +0000 (11:27 -0400)]
g_object_new: check for NULL from _constructor()
There is some code in the wild (like in gnome-session) that does this
from its custom _constructor() implementation:
{
GObject *obj;
obj = ((chain up));
if (!object_is_viable (obj))
{
g_object_unref (obj);
return NULL;
}
else
return obj;
}
This has never been a valid use of GObject and this code has always
caused memory to be leaked[1] by growing the construction_objects list.
The ability to legitimately return NULL from a constructor was exactly
the reason that we created GInitable, in fact.
That doesn't change the fact that the g_object_new() rewrite will crash
in this case, so instead of doing that, let's emit a critical and avoid
the crash. This will allow people to upgrade their GLib without also
upgrading their gnome-session. Meanwhile, people can fix their broken
code.
[1] not in the strictest sense of the word, because it's still reachable
Shantha kumar [Fri, 26 Apr 2013 06:10:25 +0000 (11:40 +0530)]
Tamil Translation Updated
Mike Ruprecht [Thu, 25 Apr 2013 07:24:53 +0000 (02:24 -0500)]
gio/tests: Find "true" in PATH opposed to hardcoding the location
Not all systems have /usr/bin/true. Some have it in /bin/true.
Instead of trying to guess a hardcoded path to find it, let
g_app_info_create_from_commandline() internally search PATH
to find the program.
https://bugzilla.gnome.org/show_bug.cgi?id=698655
Milo Casagrande [Thu, 25 Apr 2013 07:01:11 +0000 (09:01 +0200)]
[l10n] Updated Italian translation.
Cosimo Cecchi [Wed, 24 Apr 2013 15:58:47 +0000 (11:58 -0400)]
docs: fix docs for g_icon_[de]serialize()
Piotr Drąg [Tue, 23 Apr 2013 22:01:48 +0000 (00:01 +0200)]
Updated Polish translation
Ryan Lortie [Thu, 28 Mar 2013 03:34:30 +0000 (23:34 -0400)]
GObject: substantially rework g_object_new()
Make a number of improvements to g_object_new():
- instead of looking up the GParamSpec for the named property once in
g_object_new() (in order to collect) and then again in g_object_newv
(when actually setting the property), g_object_new_internal() is a
new function that takes the GParamSpec on the interface to avoid the
second lookup
- in the case that ->constructor() is not set, we need not waste time
creating an array of GObjectConstructParam to pass in. Just directly
iterate the list of parameters, calling set_property() on each.
- instead of playing with linked lists to keep track of the construct
properties, realise that the number of construct properties that we
will set is exactly equal to the length of the construct_properties
list on GObjectClass and the only thing that may change is where the
value comes from (in the case that it was passed in)
This assumption was already implicit in the existing code and can be
seen from the sizing of the array used to hold the construct
properties, but it wasn't taken advantage of to make things simpler.
- instead of allocating and filling a separate array of the
non-construct properties just re-iterate the passed-in list and set
all properties that were not marked G_PARAM_CONSTRUCT (since the ones
that were construct params were already used during construction)
- use the new g_param_spec_get_default_value() API instead of
allocating and setting the GValue for each construct property that
wasn't passed from the user
Because we are now iterating the linked list of properties in-order we
need to append to that list during class initialising instead of
prepending.
These changes show a very small improvement on the simple-construction
performance testcase (probably just noise) and they improve the
complex-construction case by ~30%.
Thanks to Alex Larsson for reviews and fixes.
https://bugzilla.gnome.org/show_bug.cgi?id=698056
Ryan Lortie [Tue, 23 Apr 2013 15:11:20 +0000 (11:11 -0400)]
GParamSpec: add g_param_spec_get_default_value()
The way of getting the default value out of a GParamSpec is to allocate
a GValue, initialise it, then call g_param_spec_set_default() to set the
default value into that GValue.
This is exactly how we handle setting the default value for all of the
construct properties that were not explicitly passed to g_object_new().
Instead of doing the alloc/init/store on all construct properties on
every call to g_object_new(), we can cache those GValues in the private
data of the GParamSpec itself and reuse them.
This patch does not actually make that change to g_object_new() yet, but
it adds the API to GParamSpec so that a future patch to GObject can make
the change.
https://bugzilla.gnome.org/show_bug.cgi?id=698056
Ryan Lortie [Tue, 23 Apr 2013 14:38:23 +0000 (10:38 -0400)]
GType: add accessor for instance private offset
Since instance private data is now always at a constant offset to the
instance pointer, we can add an accessor for it that doesn't also
require an instance.
The idea is that classes can call this from their class_init and store
it in a file-scoped static variable and use that to find their private
data on instances very quickly, without a priv pointer.
https://bugzilla.gnome.org/show_bug.cgi?id=698056
Ryan Lortie [Tue, 23 Apr 2013 17:26:48 +0000 (13:26 -0400)]
Partially revert "Merge waitpid() from g_spawn_sync into gmain()"
This partially reverts commit
ce0022933c255313e010b27f977f4ae02aad1e7e.
It used to be safe to use g_spawn_sync() from processes that had their
own SIGCHLD handler because it simply called wait(). When it was
changed to depend on the GLib child watching infrastructure this meant
that GLib had to own the SIGCHLD handler.
This caused hangs in at least Pidgin.
The patch contained two other improvements to the child watch code which
we want to keep, so only revert the changes to gspawn itself.
https://bugzilla.gnome.org/show_bug.cgi?id=698081
Ryan Lortie [Tue, 23 Apr 2013 18:30:42 +0000 (14:30 -0400)]
Test GUnixSocketAddress construction
This test fails without the previous fix and works properly with it.
https://bugzilla.gnome.org/show_bug.cgi?id=698686
Ryan Lortie [Tue, 23 Apr 2013 17:38:33 +0000 (13:38 -0400)]
GUnixSocketAddress: fix construct parameter issue
GUnixSocketAddress has some very strange logic for interpreting its
construct paramters. This logic behaves differently in these two cases:
g_object_new (G_TYPE_UNIX_SOCKET_ADDRESS,
"abstract", FALSE,
"address-type", ...,
NULL);
and
g_object_new (G_TYPE_UNIX_SOCKET_ADDRESS,
"address-type", ...,
NULL);
even though the default value for "abstract" is already FALSE.
Change the way the code works so that it is not sensitive to people
merely setting a property to its default value.
https://bugzilla.gnome.org/show_bug.cgi?id=698686
Ryan Lortie [Tue, 23 Apr 2013 15:59:09 +0000 (11:59 -0400)]
gtype: tweak valgrind hints
The valgrind client requests were not producing the intended result in
some cases, so step up our game a bit.
Ryan Lortie [Mon, 22 Apr 2013 22:32:05 +0000 (18:32 -0400)]
Revert "GObject: prevent installing properties after init"
This reverts commit
ddb0ce14215cd62c7a2497d6cf9f2ea63c40ebb5.
Colin's smoke testing has found issues in at least gjs and
gnome-settings-daemon. We'll need to see if we can address those.
Ryan Lortie [Mon, 22 Apr 2013 21:37:18 +0000 (17:37 -0400)]
GObject: prevent installing properties after init
GObject has previously allowed installing properties after class_init
has finished running. This means that you could install some of your
own properties on G_TYPE_OBJECT, for example, although they wouldn't
have worked properly.
Prevent this from happening. Require that all properties are installed by
the time class_init has finished.
Complaints go to this bug:
https://bugzilla.gnome.org/show_bug.cgi?id=698614
Ryan Lortie [Mon, 22 Apr 2013 16:33:30 +0000 (12:33 -0400)]
gtype: put private data before the instance
Classically, a GTypeInstance has had the following layout:
[[[[GTypeInstance] GObject] TypeA] TypeB] [TypeAPrivate] [TypeBPrivate]
where TypeB is a subclass of TypeA which is a GObject. Both TypeA and
TypeB use pivate data.
The main problem with this approach is that the offset between a pointer
to an instance of TypeA and the TypeAPrivate is not constant: it changes
depending on the depth of derivation and the size of the instance
structures of the derived types. For example, changing the size of the
TypeB structure in the above example would push the TypeAPrivate further
along.
This complicates the implementation of g_type_instance_get_private().
In particular, during object construction when the class pointer to the
'complete type' of the object is not yet stored in the header of the
GTypeInstance, we need a lookup table in order to be able to implement
g_type_instance_get_private() accurately.
We can avoid this problem by storing the private data before the
structures, in reverse order, like so:
[TypeBPrivate] [TypeAPrivate] [[[[GTypeInstance] GObject] TypeA] TypeB]
Now the distance between TypeA and TypeAPrivate depends only on the size
of GObject and GTypeInstance, which are static. Even in the case of
TypeB, the distance is not statically known but can be determined at
runtime and is constant (because we will know the size of TypeAPrivate
by the time we initialise TypeB and it won't change).
This approach requires a slighty dirty trick: allocating extra memory
_before_ the pointer we return from g_type_create_instance(). The main
problem with this is that it will cause valgrind to behave very badly,
reporting almost everything as "possibly lost".
We can correct for this by including a few valgrind client requests in
order to inform it that the start of the GTypeInstance should be
considered a block of memory and that pointers to it should mean that
this block is reachable. In order to make the private data reachable,
we also declare it as a block and include an extra pointer from the end
of the primary block pointing back at it. All of this is only done if
we are running under Valgrind.
https://bugzilla.gnome.org/show_bug.cgi?id=698595
Ryan Lortie [Mon, 22 Apr 2013 16:28:44 +0000 (12:28 -0400)]
gslice: disable by default under valgrind
All experienced GLib hackers know that G_SLICE=always-malloc is
absolutely essential when valgrinding but many users of GLib don't know
about this and get hit pretty hard when valgrinding their programs.
When initialising gslice, add a check to see if we are running under
valgrind and disable ourselves if we are.
We only do the check in the case that G_SLICE= was not specified in the
environment, so setting it to an empty string will prevent this default
behaviour.
I considered modifying gslice to use the VALGRIND_MALLOCLIKE_BLOCK
client request in all cases in order to just mark the blocks properly
but these calls are not free and gslice is pretty hyper-optimised. It's
easier to just disable gslice completely and this way we only have to do
one check during startup. It's also theoretically possible that someone
might want to use valgrind to debug gslice, in which case the extra
annotations would probably cause quite a lot of difficulty.
https://bugzilla.gnome.org/show_bug.cgi?id=698595
Ryan Lortie [Mon, 22 Apr 2013 16:10:35 +0000 (12:10 -0400)]
Add a copy of valgrind.h to glib/
This is a BSD-licenced header file that is designed to be copy-pasted
into programs. It will allow us to detect if we are running under
Valgrind and send "client requests" to it.
We will use this for a couple of reasons in upcoming patches.
https://bugzilla.gnome.org/show_bug.cgi?id=698595
Ryan Lortie [Sat, 20 Apr 2013 22:55:03 +0000 (18:55 -0400)]
GMenu: add g_menu_item_set_icon() convenience
This function takes a GIcon, serialises it and sets the resulting
GVariant as the "icon" attribute on the menu item. We will need to add
a patch to Gtk to actually consume this icon.
Also add G_MENU_ATTRIBUTE_ICON.
https://bugzilla.gnome.org/show_bug.cgi?id=688820
Jasper St. Pierre [Mon, 22 Apr 2013 17:12:12 +0000 (13:12 -0400)]
tests: Fix appinfo test
Daniel Mustieles [Mon, 22 Apr 2013 15:49:06 +0000 (17:49 +0200)]
Updated Spanish translation
Sweta Kothari [Mon, 22 Apr 2013 10:23:10 +0000 (15:53 +0530)]
Updated gujarati file
Piotr Drąg [Sun, 21 Apr 2013 22:37:20 +0000 (00:37 +0200)]
Updated POTFILES.in
Ryan Lortie [Sat, 20 Apr 2013 22:50:21 +0000 (18:50 -0400)]
GIcon: add g_icon_[de]serialize()
Add support for serialising a GIcon to a GVariant and deserialising the
result back to a GIcon.
This solves a number of problems suffered by the existing to_string()
API, primarily these:
- not forcing the icon to be a utf8 string means that we can
efficiently encode a PNG (ie: just give the array of bytes)
- there is no need to ensure that proper types are loaded before using
the deserialisation interface. 'Foreign' icon types will probably
emit a serialised format the deserialises to a GBytesIcon.
We additionally clearly document what is required for being a consumer
or implementation of #GIcon.
Further patches will be required to GdkPixbuf and GVfsIcon to bring
their implementations in line with the new rules (essentially: introduce
implementations of the new serialize() API).
https://bugzilla.gnome.org/show_bug.cgi?id=688820
Ryan Lortie [Sat, 20 Apr 2013 21:23:31 +0000 (17:23 -0400)]
Introduce GBytesIcon
GBytesIcon is an icon that has a GBytes inside of it where the GBytes
contains some sort of encoded image in a widely-recognised file format.
Ideally this will be a PNG.
It implements GLoadableIcon, so GTK will already understand how to use
it, but we will add another patch there to make things more efficient.
https://bugzilla.gnome.org/show_bug.cgi?id=688820
Ryan Lortie [Sat, 20 Apr 2013 20:41:09 +0000 (16:41 -0400)]
GIcon: pure re-factor of _from_string()
Split out the 'simple string format' cases of URIs, file paths and
themed icons to a separate function.
This function will be shared by g_icon_deserialize().
https://bugzilla.gnome.org/show_bug.cgi?id=688820
Jasper St. Pierre [Sat, 20 Apr 2013 19:13:42 +0000 (15:13 -0400)]
gdesktopappinfo: Allow getting the desktop ID from the filename
Lars Uebernickel [Sat, 20 Apr 2013 22:58:14 +0000 (18:58 -0400)]
gactionmap: don't require GActionGroup
https://bugzilla.gnome.org/show_bug.cgi?id=698478
Lars Uebernickel [Sat, 20 Apr 2013 15:44:21 +0000 (11:44 -0400)]
g_variant_get_data_as_bytes: return a sub-bytes if necessary
https://bugzilla.gnome.org/show_bug.cgi?id=698457
Ryan Lortie [Sat, 20 Apr 2013 15:44:53 +0000 (11:44 -0400)]
GVariant: add new g_variant_new_take_string() API
Lots of people have variously asked for APIs like
g_variant_new_string_printf() in order to avoid having to use
g_strdup_printf(), create a GVariant using g_variant_new_string(), then
free the temporary string.
Instead of supporting that, plus a million other potential cases,
introduce g_variant_new_take_string() as a compromise.
It's not possible to write:
v = g_variant_new_take_string (g_strdup_printf (....));
to get the desired result and avoid the extra copies. In addition, it
works with many other functions.
https://bugzilla.gnome.org/show_bug.cgi?id=698455
Sébastien Wilmet [Wed, 17 Apr 2013 14:37:55 +0000 (16:37 +0200)]
Add async version of g_file_make_directory()
https://bugzilla.gnome.org/show_bug.cgi?id=548353
Sébastien Wilmet [Wed, 17 Apr 2013 13:07:03 +0000 (15:07 +0200)]
GFile: fix the *_async_thread()
In the *_async_thread() functions, call the corresponding synchronous
function instead of calling the interface vfunc, which can be NULL.
In some cases the check for the vfunc == NULL was done, but to be
consistent it is better to always call the synchronous version (and the
code is simpler).
https://bugzilla.gnome.org/show_bug.cgi?id=548353
Ryan Lortie [Mon, 8 Apr 2013 19:27:16 +0000 (15:27 -0400)]
GMenu: add g_menu_remove_all() API
Removes all of the items from a GMenu. The keyboard indicator wants to
do this as part of refreshing the layout list, as an example.
https://bugzilla.gnome.org/show_bug.cgi?id=697601
Ryan Lortie [Wed, 17 Apr 2013 16:12:20 +0000 (12:12 -0400)]
GVariant parser: tweak lexer for format strings
Tweak the lexer so that '[%s]' gets parsed as three separate tokens,
instead of the closing bracket getting sucked into the format string.
Ryan Lortie [Wed, 17 Apr 2013 16:08:00 +0000 (12:08 -0400)]
GVariant parser: turn two asserts into soft errors
Parsing wrongly-typed GVariant text format data is a well-defined
operation and it ought to result in a GError. We do that for most
cases, but 'v' and 'ay' were being treated differently. Fix those as
well.
Robert Bragg [Wed, 17 Apr 2013 08:35:50 +0000 (04:35 -0400)]
utils: avoid redundant set/endpwent around getpwuid
set/endpwent are only required for iterating through passwd entries
using getpwent(). Since we are explicitly requesting a passwd entry
for a uid then the set/endpwent calls are redundant.
Removing these redundant calls is required for building on Android
since their C library doesn't implement these.
https://bugzilla.gnome.org/show_bug.cgi?id=645881
Giovanni Campagna [Fri, 12 Apr 2013 15:25:15 +0000 (17:25 +0200)]
GVariant: fix transfer annotation
g_variant_new_from_bytes() returns a floating reference, so it
must be annotated (transfer none)
https://bugzilla.gnome.org/show_bug.cgi?id=697887
Emilio Pozuelo Monfort [Sat, 13 Apr 2013 10:02:24 +0000 (12:02 +0200)]
check-abis.sh: allow _ftext as that's leaked on mips
https://bugzilla.gnome.org/show_bug.cgi?id=697942
Sebastian Dröge [Wed, 28 Nov 2012 15:55:54 +0000 (16:55 +0100)]
Fix compilation on Android with the bionic C library
https://bugzilla.gnome.org/show_bug.cgi?id=689223
Jasper St. Pierre [Wed, 27 Mar 2013 20:41:44 +0000 (16:41 -0400)]
bookmarkfile: Fix annotations on GBookmarkFile
Marek Kasik [Wed, 10 Apr 2013 11:48:49 +0000 (13:48 +0200)]
tests: Add test for disabled help options
Test whether help options are hidden when they are disabled
by g_option_context_set_help_enabled(.., FALSE).
https://bugzilla.gnome.org/show_bug.cgi?id=697652
Marek Kasik [Tue, 9 Apr 2013 16:03:53 +0000 (18:03 +0200)]
Don't show help options when help is disabled
Check whether help is enabled when creating help text
in g_option_context_get_help().
https://bugzilla.gnome.org/show_bug.cgi?id=697652
Jason Quinn [Thu, 11 Apr 2013 09:00:38 +0000 (05:00 -0400)]
building.xml: Fix a typo of "fo" to "of"
https://bugzilla.gnome.org/show_bug.cgi?id=697771
Balázs Úr [Wed, 10 Apr 2013 21:33:20 +0000 (23:33 +0200)]
Updated Hungarian translation
Sébastien Wilmet [Thu, 31 Jan 2013 17:45:32 +0000 (18:45 +0100)]
Add async version of g_file_trash()
https://bugzilla.gnome.org/show_bug.cgi?id=548353
Sébastien Wilmet [Thu, 31 Jan 2013 17:44:24 +0000 (18:44 +0100)]
Add missing details in GFile documentation
https://bugzilla.gnome.org/show_bug.cgi?id=548353
Dan Winship [Wed, 10 Apr 2013 15:39:12 +0000 (11:39 -0400)]
gmain: fix double-unlock in g_main_context_unref()
When unreffing a context with sources still attached, it would end up
unlocking an already-unlocked context, causing crashes on platforms
that (unlike Linux) actually check for that.
https://bugzilla.gnome.org/show_bug.cgi?id=697595
Lionel Landwerlin [Fri, 5 Apr 2013 14:21:23 +0000 (15:21 +0100)]
gunixmounts: remove warning on unused variable
https://bugzilla.gnome.org/show_bug.cgi?id=697367
Robert Ancell [Wed, 10 Apr 2013 03:53:14 +0000 (15:53 +1200)]
Fix deprecation warning for g_io_channel_read
Руслан Ижбулатов [Tue, 9 Apr 2013 12:09:33 +0000 (14:09 +0200)]
win32: Allow POSIX threads to be used if --with-threads=posix
All tests pass with this patch AND a good pthreads implementation
(i'm using winpthreads, not pthreads-w32).
https://bugzilla.gnome.org/show_bug.cgi?id=697626
Руслан Ижбулатов [Tue, 9 Apr 2013 12:02:54 +0000 (14:02 +0200)]
win32: Fix warning
Руслан Ижбулатов [Sat, 3 Dec 2011 03:08:26 +0000 (07:08 +0400)]
Use AC_LINK_IFELSE instead of AC_TRY_COMPILE
Fixes #665445
Lars Uebernickel [Mon, 8 Apr 2013 06:13:10 +0000 (08:13 +0200)]
g_dbus_connection_signal_subscribe: add path and namespace matching
https://bugzilla.gnome.org/show_bug.cgi?id=695156
James Turner [Fri, 5 Apr 2013 19:29:55 +0000 (15:29 -0400)]
g_atomic_int_get, g_atomic_pointer_get: accept const arguments
https://bugzilla.gnome.org/show_bug.cgi?id=697386