platform/upstream/freerdp.git
4 years agoserver: proxy: client use PIXEL_FORMAT_BGRA32 (easier to write frames to bitmap)
kubistika [Tue, 22 Oct 2019 13:01:00 +0000 (16:01 +0300)]
server: proxy: client use PIXEL_FORMAT_BGRA32 (easier to write frames to bitmap)

4 years agochannels: rdpgfx: export API to create rdpgfx client
kubistika [Tue, 22 Oct 2019 12:58:05 +0000 (15:58 +0300)]
channels: rdpgfx: export API to create rdpgfx client

4 years agowinpr: utils: image: fix const correctness
kubistika [Mon, 2 Sep 2019 13:02:55 +0000 (16:02 +0300)]
winpr: utils: image: fix const correctness

4 years agoFixes hub was not found! error
AzureusNation [Fri, 18 Oct 2019 09:44:24 +0000 (10:44 +0100)]
Fixes hub was not found! error

Again as with auto usb detection strtol needs to use base 10 and force to use base 10 else the conversion does not work correctly.

4 years agoFixes Auto USB Redirection
AzureusNation [Fri, 18 Oct 2019 09:21:58 +0000 (10:21 +0100)]
Fixes Auto USB Redirection

Base 0 does not work when converting the string to long int. This ends up not showing the correct device id and sometimes the wrong bus id. By changing it to base 10 conversion instead of base 0 this fixes the issue of auto redirect usb devices.

4 years agordp: count in/out bytes and packets
David Fort [Tue, 22 Oct 2019 21:35:18 +0000 (23:35 +0200)]
rdp: count in/out bytes and packets

4 years agoFix some static analizer warnings
asapelkin [Wed, 16 Oct 2019 16:49:24 +0000 (19:49 +0300)]
Fix some static analizer warnings

4 years agoserver: proxy: client: terminate the connection if pre connect hook fails
kubistika [Tue, 22 Oct 2019 07:38:25 +0000 (10:38 +0300)]
server: proxy: client: terminate the connection if pre connect hook fails

4 years agochannels: cliprdr: client: fix leak in cliprdr_packet_send
kubistika [Fri, 18 Oct 2019 12:02:59 +0000 (15:02 +0300)]
channels: cliprdr: client: fix leak in cliprdr_packet_send

4 years agochannels: cliprdr: improved common cliprdr api
kubistika [Thu, 17 Oct 2019 15:59:07 +0000 (18:59 +0300)]
channels: cliprdr: improved common cliprdr api

4 years agochannels: cliprdr: reformat cliprdr_common.c
kubistika [Sun, 15 Sep 2019 11:48:12 +0000 (14:48 +0300)]
channels: cliprdr: reformat cliprdr_common.c

4 years agochannels: cliprdr: get rid of duplicated server and client code
kubistika [Sun, 15 Sep 2019 10:53:56 +0000 (13:53 +0300)]
channels: cliprdr: get rid of duplicated server and client code

4 years agochannels: cliprdr: remove formatDataResp.dwFlags
kubistika [Sun, 15 Sep 2019 10:51:32 +0000 (13:51 +0300)]
channels: cliprdr: remove formatDataResp.dwFlags

According to the channel docs, this field is only used in format data
request. Therefore, there's no need to hold it in the response. cliprdr
server code was copy-pasted from client code, therefore this must be
some leftover.

4 years agoMerge pull request #5657 from akallabeth/warning_fixes2
Martin Fleisz [Thu, 17 Oct 2019 15:00:57 +0000 (17:00 +0200)]
Merge pull request #5657 from akallabeth/warning_fixes2

Warning fixes2

4 years agoMerge pull request #5648 from akallabeth/h264_dyn
Martin Fleisz [Thu, 17 Oct 2019 10:54:43 +0000 (12:54 +0200)]
Merge pull request #5648 from akallabeth/h264_dyn

H264 runtime detection

4 years agoFixed compilation warnings.
Armin Novak [Wed, 16 Oct 2019 12:54:05 +0000 (14:54 +0200)]
Fixed compilation warnings.

4 years agoFixed missing initializer
Armin Novak [Wed, 16 Oct 2019 12:53:42 +0000 (14:53 +0200)]
Fixed missing initializer

4 years agoFixed floating point calculations.
Armin Novak [Wed, 16 Oct 2019 12:53:27 +0000 (14:53 +0200)]
Fixed floating point calculations.

4 years agoMerge pull request #5646 from akallabeth/realloc_fixes
Martin Fleisz [Mon, 7 Oct 2019 08:43:11 +0000 (10:43 +0200)]
Merge pull request #5646 from akallabeth/realloc_fixes

Fixed #5645: realloc return handling

4 years agoLet shadow server detect H264 support at runtime
Armin Novak [Mon, 7 Oct 2019 07:47:03 +0000 (09:47 +0200)]
Let shadow server detect H264 support at runtime

4 years agoAllow freerdp clients to function with WITH_OPENH264_LOADING
Armin Novak [Mon, 7 Oct 2019 07:31:20 +0000 (09:31 +0200)]
Allow freerdp clients to function with WITH_OPENH264_LOADING

If no library can be loaded at runtime ignore H264 capabilities.
This allows a build with only OpenH264 support and dynamic loading
enabled to function when no openh264 library was detected.

4 years agoMerge pull request #5644 from akallabeth/nsc_cleanup
Martin Fleisz [Mon, 7 Oct 2019 07:01:26 +0000 (09:01 +0200)]
Merge pull request #5644 from akallabeth/nsc_cleanup

Cleaned up NSC API

4 years agoFixed windows shadow server startup issue.
Armin Novak [Fri, 4 Oct 2019 15:13:00 +0000 (17:13 +0200)]
Fixed windows shadow server startup issue.

4 years agoFixed leak in verify_cb.
Armin Novak [Fri, 4 Oct 2019 13:52:46 +0000 (15:52 +0200)]
Fixed leak in verify_cb.

4 years agoAdded /buildconfig command line for shadow.
Armin Novak [Fri, 4 Oct 2019 13:02:08 +0000 (15:02 +0200)]
Added /buildconfig command line for shadow.

4 years agoFixed #5645: realloc return handling
Armin Novak [Fri, 4 Oct 2019 12:49:30 +0000 (14:49 +0200)]
Fixed #5645: realloc return handling

4 years agoMerge pull request #5639 from akallabeth/error_category
Martin Fleisz [Fri, 4 Oct 2019 11:32:07 +0000 (13:32 +0200)]
Merge pull request #5639 from akallabeth/error_category

Added function to get an error category for better error handling.

4 years agoRemoved check for wrong buffer size.
Armin Novak [Fri, 4 Oct 2019 09:46:14 +0000 (11:46 +0200)]
Removed check for wrong buffer size.

4 years agoMerge pull request #5643 from akallabeth/openh264_fixes
Martin Fleisz [Fri, 4 Oct 2019 09:23:29 +0000 (11:23 +0200)]
Merge pull request #5643 from akallabeth/openh264_fixes

fixed openh264 related issues, thx to mythos from IRC

4 years agoMerge pull request #5641 from akallabeth/settings_use_after_free
Martin Fleisz [Fri, 4 Oct 2019 09:07:37 +0000 (11:07 +0200)]
Merge pull request #5641 from akallabeth/settings_use_after_free

Fixed use after free.

4 years agoCleaned up NSC API
Armin Novak [Fri, 4 Oct 2019 08:13:43 +0000 (10:13 +0200)]
Cleaned up NSC API

4 years agofixed openh264 related issues, thx to mythos from IRC
Armin Novak [Fri, 4 Oct 2019 08:23:43 +0000 (10:23 +0200)]
fixed openh264 related issues, thx to mythos from IRC

4 years agoFixed use after free.
Armin Novak [Thu, 3 Oct 2019 14:15:52 +0000 (16:15 +0200)]
Fixed use after free.

4 years agoAdded function to get an error category for better error handling.
Armin Novak [Thu, 3 Oct 2019 08:59:45 +0000 (10:59 +0200)]
Added function to get an error category for better error handling.

4 years agoMerge pull request #5634 from akallabeth/error_code_update
Martin Fleisz [Thu, 3 Oct 2019 06:45:44 +0000 (08:45 +0200)]
Merge pull request #5634 from akallabeth/error_code_update

Added missing error codes.

4 years agoMerge pull request #5636 from akallabeth/silence_cmake
Martin Fleisz [Wed, 2 Oct 2019 14:48:42 +0000 (16:48 +0200)]
Merge pull request #5636 from akallabeth/silence_cmake

Fix #5635: Silence double WITH_CUPS definition.

4 years agoMerge pull request #5633 from akallabeth/event_fd_fix
David Fort [Wed, 2 Oct 2019 14:34:34 +0000 (16:34 +0200)]
Merge pull request #5633 from akallabeth/event_fd_fix

GetEventFileDescriptor return handle internal event.

4 years agoFix #5635: Silence double WITH_CUPS definition.
Armin Novak [Wed, 2 Oct 2019 14:24:12 +0000 (16:24 +0200)]
Fix #5635: Silence double WITH_CUPS definition.

4 years agoFixed format string.
Armin Novak [Wed, 2 Oct 2019 14:01:36 +0000 (16:01 +0200)]
Fixed format string.

4 years agoAdded missing error codes.
Armin Novak [Wed, 2 Oct 2019 13:15:59 +0000 (15:15 +0200)]
Added missing error codes.

4 years agoGetEventFileDescriptor return handle internal event.
Armin Novak [Wed, 2 Oct 2019 12:58:32 +0000 (14:58 +0200)]
GetEventFileDescriptor return handle internal event.

4 years agorail: Update to latest spec version 28.0
Martin Fleisz [Wed, 2 Oct 2019 09:32:30 +0000 (11:32 +0200)]
rail: Update to latest spec version 28.0

4 years agoMerge pull request #5630 from akallabeth/fastpath_reset
Martin Fleisz [Wed, 2 Oct 2019 09:10:07 +0000 (11:10 +0200)]
Merge pull request #5630 from akallabeth/fastpath_reset

Reset fastpath on disconnect, fixes #5629

4 years agoReset fastpath on disconnect, fixes #5629
Armin Novak [Wed, 2 Oct 2019 08:21:48 +0000 (10:21 +0200)]
Reset fastpath on disconnect, fixes #5629

4 years agoMerge pull request #5628 from akallabeth/handle_fix
Martin Fleisz [Wed, 2 Oct 2019 07:18:50 +0000 (09:18 +0200)]
Merge pull request #5628 from akallabeth/handle_fix

Fix WINPR_EVENT and WINPR_TIMER structs.

4 years agoFix WINPR_EVENT and WINPR_TIMER structs.
akallabeth [Tue, 1 Oct 2019 19:03:03 +0000 (21:03 +0200)]
Fix WINPR_EVENT and WINPR_TIMER structs.

Both structs must have the same base members so that the event
handle can be extracted at the same offset.

4 years agoMerge pull request #5596 from akallabeth/wlog_cache_ptr
Martin Fleisz [Tue, 1 Oct 2019 13:57:17 +0000 (15:57 +0200)]
Merge pull request #5596 from akallabeth/wlog_cache_ptr

Speedup for WLog_* macros, cache the log pointer

4 years agocommon: Fix handling of redirectdrives setting
Martin Fleisz [Tue, 1 Oct 2019 13:38:31 +0000 (15:38 +0200)]
common: Fix handling of redirectdrives setting

4 years agordpdr: Fix error code reporting for create PDUs
Martin Fleisz [Tue, 1 Oct 2019 12:04:10 +0000 (14:04 +0200)]
rdpdr: Fix error code reporting for create PDUs

4 years agowlog: Fix uninitialized type in wLogMessage
Martin Fleisz [Tue, 1 Oct 2019 10:14:45 +0000 (12:14 +0200)]
wlog: Fix uninitialized type in wLogMessage

4 years agoMerge pull request #5623 from akallabeth/gateway_error_string
Martin Fleisz [Tue, 1 Oct 2019 09:41:01 +0000 (11:41 +0200)]
Merge pull request #5623 from akallabeth/gateway_error_string

Map gateway errors in freerdp_get_last_error_name

4 years agoMerge pull request #5616 from akallabeth/drive_prefer_absolute_path
Martin Fleisz [Tue, 1 Oct 2019 09:40:38 +0000 (11:40 +0200)]
Merge pull request #5616 from akallabeth/drive_prefer_absolute_path

Fix #5603: Prefer absolute path for /drive: syntax.

4 years agoMap gateway errors in freerdp_get_last_error_name
Armin Novak [Tue, 1 Oct 2019 07:47:26 +0000 (09:47 +0200)]
Map gateway errors in freerdp_get_last_error_name

4 years agoserver: proxy: register input and update callbacks in post connect
kubistika [Wed, 25 Sep 2019 13:10:04 +0000 (16:10 +0300)]
server: proxy: register input and update callbacks in post connect

To avoid a race in which the server received an input event before
proxy's client is initialized, we now only register input and update
callbacks after client is initialized and safe to use.

4 years agoserver: proxy: refactor pf_context_create_client_context
kubistika [Wed, 25 Sep 2019 13:09:36 +0000 (16:09 +0300)]
server: proxy: refactor pf_context_create_client_context

4 years agoserver: proxy: support auto reconnect
kubistika [Wed, 25 Sep 2019 13:09:15 +0000 (16:09 +0300)]
server: proxy: support auto reconnect

4 years agoserver: proxy: separate client and server security settings
kubistika [Wed, 18 Sep 2019 13:08:25 +0000 (16:08 +0300)]
server: proxy: separate client and server security settings

4 years agoMerge pull request #5621 from akallabeth/santize_rdp_file_strings
Martin Fleisz [Fri, 27 Sep 2019 07:28:20 +0000 (09:28 +0200)]
Merge pull request #5621 from akallabeth/santize_rdp_file_strings

Trim all RDP file string options except passwords.

4 years agoTrim all RDP file string options except passwords.
Armin Novak [Thu, 26 Sep 2019 14:58:41 +0000 (16:58 +0200)]
Trim all RDP file string options except passwords.

4 years agoFix #5603: Prefer absolute path for /drive: syntax.
Armin Novak [Tue, 24 Sep 2019 13:44:34 +0000 (15:44 +0200)]
Fix #5603: Prefer absolute path for /drive: syntax.

4 years agoMerge pull request #5614 from akallabeth/better_gateway_error
Martin Fleisz [Tue, 24 Sep 2019 14:28:17 +0000 (16:28 +0200)]
Merge pull request #5614 from akallabeth/better_gateway_error

Better gateway error reporting

4 years agoMerge pull request #5615 from akallabeth/rdp_relaxed_parse
Martin Fleisz [Tue, 24 Sep 2019 14:27:54 +0000 (16:27 +0200)]
Merge pull request #5615 from akallabeth/rdp_relaxed_parse

Added option to parse RDP files relaxed.

4 years agoAdded option to parse RDP files relaxed.
Armin Novak [Tue, 24 Sep 2019 08:01:08 +0000 (10:01 +0200)]
Added option to parse RDP files relaxed.

4 years agoFix #5612: proper return values.
Armin Novak [Tue, 24 Sep 2019 07:45:35 +0000 (09:45 +0200)]
Fix #5612: proper return values.

4 years agoSetting freerdp_last_error in gateway error response.
Armin Novak [Mon, 23 Sep 2019 09:26:55 +0000 (11:26 +0200)]
Setting freerdp_last_error in gateway error response.

4 years agoBetter log message for resetting last error state.
Armin Novak [Mon, 23 Sep 2019 09:22:45 +0000 (11:22 +0200)]
Better log message for resetting last error state.

4 years agoMerge pull request #5610 from akallabeth/centos_fix
Martin Fleisz [Mon, 23 Sep 2019 08:31:51 +0000 (10:31 +0200)]
Merge pull request #5610 from akallabeth/centos_fix

Centos fix

4 years agoMerge pull request #5609 from akallabeth/printer_default_backend
Martin Fleisz [Mon, 23 Sep 2019 07:04:23 +0000 (09:04 +0200)]
Merge pull request #5609 from akallabeth/printer_default_backend

Fix #5606: Fall back to loading default printer backend.

4 years agoFix ##5593: duplicated typedef.
akallabeth [Sun, 22 Sep 2019 14:42:31 +0000 (16:42 +0200)]
Fix ##5593: duplicated typedef.

4 years agoFix #5593: Do not use diagnostics pragma inside functions
akallabeth [Sun, 22 Sep 2019 14:37:52 +0000 (16:37 +0200)]
Fix #5593: Do not use diagnostics pragma inside functions

4 years agoFix #5606: Fall back to loading default printer backend.
akallabeth [Sun, 22 Sep 2019 14:22:41 +0000 (16:22 +0200)]
Fix #5606: Fall back to loading default printer backend.

4 years agoMerge pull request #5578 from kubistika/proxy/refactor
Bernhard Miklautz [Thu, 19 Sep 2019 08:55:08 +0000 (10:55 +0200)]
Merge pull request #5578 from kubistika/proxy/refactor

sever: proxy: code refactor

4 years agoMerge pull request #5595 from volth/patch-3
David Fort [Tue, 17 Sep 2019 05:34:40 +0000 (07:34 +0200)]
Merge pull request #5595 from volth/patch-3

avoid blurry filter when scaling factor is 2x, 3x, etc

4 years agoSpeedup for WLog_* macros, cache the log pointer
Armin Novak [Sun, 15 Sep 2019 07:59:31 +0000 (09:59 +0200)]
Speedup for WLog_* macros, cache the log pointer

WLog_Get(tag) is quite expensive if called repeatedly.
With this patch the pointer is cached on first call.

4 years agoavoid blurry filter when scaling factor is 2x, 3x, etc
volth [Sat, 14 Sep 2019 17:57:45 +0000 (17:57 +0000)]
avoid blurry filter when scaling factor is 2x, 3x, etc

4 years agoMerge pull request #5591 from akallabeth/mac_hotplug_fix
Martin Fleisz [Thu, 12 Sep 2019 12:46:06 +0000 (14:46 +0200)]
Merge pull request #5591 from akallabeth/mac_hotplug_fix

Use stat instead of lstat to iterate /Volumes

4 years agoUse stat instead of lstat to iterate /Volumes
Armin Novak [Thu, 12 Sep 2019 12:35:01 +0000 (14:35 +0200)]
Use stat instead of lstat to iterate /Volumes

Some entries are symbolic links, so follow them and check the link
target for being a directory.

4 years agoMerge pull request #5590 from akallabeth/hotplug_fix
Martin Fleisz [Thu, 12 Sep 2019 10:04:55 +0000 (12:04 +0200)]
Merge pull request #5590 from akallabeth/hotplug_fix

Hotplugging only for drive redirection.

4 years agoHotplugging only for drive redirection.
Armin Novak [Thu, 12 Sep 2019 08:51:55 +0000 (10:51 +0200)]
Hotplugging only for drive redirection.

4 years agoMerge pull request #5589 from akallabeth/strtol_error_check
Martin Fleisz [Wed, 11 Sep 2019 12:33:10 +0000 (14:33 +0200)]
Merge pull request #5589 from akallabeth/strtol_error_check

Tighter error checking for integer options in RDP file.

4 years agoMerge pull request #5582 from akallabeth/win_server_fixes
Martin Fleisz [Wed, 11 Sep 2019 12:29:50 +0000 (14:29 +0200)]
Merge pull request #5582 from akallabeth/win_server_fixes

Fix windows shadow server issues reported in #5577

4 years agoTighter error checking for integer options in RDP file.
Armin Novak [Wed, 11 Sep 2019 09:45:59 +0000 (11:45 +0200)]
Tighter error checking for integer options in RDP file.

4 years agoserver: proxy: config: fix mem leak
kubistika [Wed, 11 Sep 2019 11:14:43 +0000 (14:14 +0300)]
server: proxy: config: fix mem leak

4 years agoMerge pull request #5588 from akallabeth/last_error_reset
Martin Fleisz [Wed, 11 Sep 2019 08:55:49 +0000 (10:55 +0200)]
Merge pull request #5588 from akallabeth/last_error_reset

Reset last error state after a hostname was resolved successfully.

4 years agoReset last error state after a hostname was resolved successfully.
Armin Novak [Wed, 11 Sep 2019 08:43:17 +0000 (10:43 +0200)]
Reset last error state after a hostname was resolved successfully.

4 years agoMerge pull request #5587 from akallabeth/rdp_parser_case_insensitive
Martin Fleisz [Wed, 11 Sep 2019 08:37:08 +0000 (10:37 +0200)]
Merge pull request #5587 from akallabeth/rdp_parser_case_insensitive

Compare rdp file options case insensitive

4 years agoCompare rdp file options case insensitive
Armin Novak [Wed, 11 Sep 2019 08:23:17 +0000 (10:23 +0200)]
Compare rdp file options case insensitive

4 years agoMerge pull request #5583 from akallabeth/mac_bundle_paths
Martin Fleisz [Tue, 10 Sep 2019 10:31:11 +0000 (12:31 +0200)]
Merge pull request #5583 from akallabeth/mac_bundle_paths

mac os bundles should not put libraries/addins in a subfolder.

4 years agomac os bundles should not put libraries/addins in a subfolder.
Armin Novak [Tue, 10 Sep 2019 10:21:40 +0000 (12:21 +0200)]
mac os bundles should not put libraries/addins in a subfolder.

4 years agoAdd MOUSEEVENTF_HWHEEL define if not found in windows.h
Armin Novak [Tue, 10 Sep 2019 07:28:48 +0000 (09:28 +0200)]
Add MOUSEEVENTF_HWHEEL define if not found in windows.h

4 years agoFix windows shadow server issues reported in #5577
Armin Novak [Tue, 10 Sep 2019 06:52:37 +0000 (08:52 +0200)]
Fix windows shadow server issues reported in #5577

4 years agoserver: proxy: client: only try NLA if credentials available
kubistika [Tue, 10 Sep 2019 07:11:00 +0000 (10:11 +0300)]
server: proxy: client: only try NLA if credentials available

4 years agoserver: proxy: get rid of unnecessary casts
kubistika [Mon, 9 Sep 2019 08:25:09 +0000 (11:25 +0300)]
server: proxy: get rid of unnecessary casts

4 years agoserver: proxy: drop local unix socket listen option
kubistika [Sun, 8 Sep 2019 15:13:41 +0000 (18:13 +0300)]
server: proxy: drop local unix socket listen option

4 years agoserver: proxy: refactor
kubistika [Sun, 8 Sep 2019 15:10:50 +0000 (18:10 +0300)]
server: proxy: refactor

4 years agoserver: proxy: refactor usage of pf_context_copy_settings
kubistika [Sun, 8 Sep 2019 12:18:45 +0000 (15:18 +0300)]
server: proxy: refactor usage of pf_context_copy_settings

4 years agoserver: proxy: make sure module's pre connect only called once
kubistika [Sun, 8 Sep 2019 12:08:15 +0000 (15:08 +0300)]
server: proxy: make sure module's pre connect only called once

4 years agoserver: proxy: config: remove duplicate declaration of config macros
kubistika [Sun, 8 Sep 2019 12:06:22 +0000 (15:06 +0300)]
server: proxy: config: remove duplicate declaration of config macros

4 years agoMerge pull request #5569 from akallabeth/dynamic_printer_backend
Martin Fleisz [Fri, 6 Sep 2019 08:08:40 +0000 (10:08 +0200)]
Merge pull request #5569 from akallabeth/dynamic_printer_backend

Dynamic printer backend

4 years agoModified printer backend to allow dynamic backends.
Armin Novak [Wed, 4 Sep 2019 15:17:47 +0000 (17:17 +0200)]
Modified printer backend to allow dynamic backends.