platform/core/ml/nnfw.git
5 years ago[neurun] Promote OperandContext to ExecutorBase (#4864)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 26 Mar 2019 23:57:50 +0000 (08:57 +0900)]
[neurun] Promote OperandContext to ExecutorBase (#4864)

As all the executors have OperandContext in common, we can promote it to
its base class `ExecutorBase`.

Part of #4823

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoEnable external IO memory set validation test (#4860)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Mar 2019 11:20:15 +0000 (20:20 +0900)]
Enable external IO memory set validation test (#4860)

Implement NNAPI to set input and output using external memory

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoEnable supported validation test (#4862)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Mar 2019 08:25:55 +0000 (17:25 +0900)]
Enable supported validation test (#4862)

Enable validation test
- SetInput
- SestOutput
- EventWait

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoMake sure standalone scripts are not source'd (#4853)
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Tue, 26 Mar 2019 06:34:51 +0000 (15:34 +0900)]
Make sure standalone scripts are not source'd (#4853)

Scripts under standalone are supposed to run, not sourced.
On error, it would exit, it may cause the shell terminated.
To prevent unintended use style, each script is checked whether
it is sourced or not.

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
5 years agoRemove gbs build check for cpu backend build (#4858)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Mar 2019 06:10:53 +0000 (15:10 +0900)]
Remove gbs build check for cpu backend build (#4858)

To build neurun cpu backend, check tensorflow lite internal source code instead of gbs build flag

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Move out of the graph of neurun to collect the model's information (#4838)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 26 Mar 2019 04:56:41 +0000 (13:56 +0900)]
[neurun] Move out of the graph of neurun to collect the model's information (#4838)

This commit moves out of the graph of neurun to collect the model's infomation.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoRemove architecture check for backend build (#4854)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Mar 2019 04:19:32 +0000 (13:19 +0900)]
Remove architecture check for backend build (#4854)

To build neurun acl_cl backend, check acl support instead of target architecture name
Fix arm architecture flag bug

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoCheck invalid NNAPI input and output index (#4849)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Mar 2019 02:24:43 +0000 (11:24 +0900)]
Check invalid NNAPI input and output index (#4849)

* Check invalid NNAPI input and output index

Check too large index by return invalid index value in wrppaer function

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Fix validation check log

5 years ago[neurun] Enable ArgMax, Dequantize, Mean ops (#4751)
김수진/Quality Tool Lab(SR)/Engineer/삼성전자 [Tue, 26 Mar 2019 02:24:17 +0000 (11:24 +0900)]
[neurun] Enable ArgMax, Dequantize, Mean ops (#4751)

* [neurun] Enable ArgMax, Dequantize, Mean ops

This commit enables `ArgMax`, `Dequantize`, `Mean` ops for `acl_cl`.

* fix build break

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoCheck input and output tensor length (#4847)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Mar 2019 00:53:12 +0000 (09:53 +0900)]
Check input and output tensor length (#4847)

Check correctness of length for input and output tensor setting based on NNAPI spec

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoFix test script bug (#4837)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Mar 2019 11:09:20 +0000 (20:09 +0900)]
Fix test script bug (#4837)

* Fix test script bug

- Check copy and script failure
- Fix test driver parameter

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Add set -e for all standalone scripts

5 years agoFix rootfs default setting bug (#4846)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Mar 2019 10:19:26 +0000 (19:19 +0900)]
Fix rootfs default setting bug (#4846)

Fix rootfs default setting bug by changing path

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Extract OperandContext from Plan (#4834)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 25 Mar 2019 10:19:15 +0000 (19:19 +0900)]
[neurun] Extract OperandContext from Plan (#4834)

Extract OperandContext from Plan so OperandContext can be merged in
ExecutorBase. (Both Executor and DataflowExecutor contains
OperandContext so we can promote it to ExecutorBase, later.)

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoMove util for frontend only (#4843)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Mar 2019 10:02:38 +0000 (19:02 +0900)]
Move util for frontend only  (#4843)

* Move util for frontend only

Move util implementation for NNAPI frontend only

* Define static function for convert

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoChange compiler::TensorInfo to model::operand::Info (#4830)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Mar 2019 10:01:58 +0000 (19:01 +0900)]
Change compiler::TensorInfo to model::operand::Info (#4830)

Change compiler::TensorInfo to model::operand::Info
All data fields in TensorInfo is model operand's info

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRedo TensorBuilderSet as unordered_set (#4836)
Дилшоджон Умронхонович Пошшоев/AI Tools Lab /SRR/Engineer/삼성전자 [Mon, 25 Mar 2019 09:33:57 +0000 (12:33 +0300)]
Redo TensorBuilderSet as unordered_set (#4836)

Redo TensorBuilderSet as unordered_set since we don't care if it is
sorted or not

Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
5 years agoRename toolchain setting files (#4839)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Mar 2019 09:15:43 +0000 (18:15 +0900)]
Rename toolchain setting files (#4839)

- Rename toolchain setting directory and files for cross build to cmake/buildtool/cross/toolchain_$(TARGET_ARCH_LC)-$(TARGET_OS).cmake
- Remove needless x86-64 cross build toolchain setting

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoMove cmake options (#4841)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Mar 2019 05:07:42 +0000 (14:07 +0900)]
Move cmake options (#4841)

Move cmake options for build and download into cmake/CfgOptionFlgs.cmake

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoIntroduce tensor interface and class for interpreter (#4818)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Mar 2019 03:21:16 +0000 (12:21 +0900)]
Introduce tensor interface and class for interpreter (#4818)

Introduce tensor interface for interpreter
Introduce ROTensor (read-only tensor) and Tensor (writable tensor) class
Generate interpreter tensor when input/output is set

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Abstract compilation into functions (#4803)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Fri, 22 Mar 2019 08:41:35 +0000 (17:41 +0900)]
[neurun] Abstract compilation into functions (#4803)

* [neurun] Abstract compilation into functions

Abstract compilation procedure as a function for each Executors.
They are introduced as static, private and has a parameter and a return
value. It is intended to explicitly show which is input and output for
compilation.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
* Rename functions prefix - compile to create

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Replace uint32_t with Index in Set (#4816)
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Fri, 22 Mar 2019 07:31:05 +0000 (16:31 +0900)]
[neurun] Replace uint32_t with Index in Set (#4816)

operand::Set and operation::Set have hardcoded uint32_t and assertion,
which is based on wrong assumption that Index is always uint32_t.
This patch replaces uint32_t with Index.

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
5 years agoFix tizen cross build bug (#4831)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 22 Mar 2019 06:30:41 +0000 (15:30 +0900)]
Fix tizen cross build bug (#4831)

Fix to use nnfw command in tizen cross build script

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoCleanup virtual function declarations in neurun backends (#4791)
Андрей Шедько/AI Tools Lab /SRR/Engineer/삼성전자 [Fri, 22 Mar 2019 03:45:27 +0000 (06:45 +0300)]
Cleanup virtual function declarations in neurun backends (#4791)

Cleanup virtual function declarations in neurun cpu and acl_cl backends

Signed-off-by: Andrei Shedko <a.shedko@samsung.com>
5 years ago[neurun] Remove unneeded dependency of neurun-core on tflite (#4817)
Сергей Баранников/AI Tools Lab /SRR/Engineer/삼성전자 [Fri, 22 Mar 2019 00:44:52 +0000 (03:44 +0300)]
[neurun] Remove unneeded dependency of neurun-core on tflite (#4817)

Looks like it is a remnant of times when neurun was being built as a single library (now it is divided into several parts, such as core, front end and back end).

Signed-off-by: Sergei Barannikov <s.barannikov@samsung.com>
5 years agoRemove skiplist for pacl x86-64 (#4821)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 23:42:44 +0000 (08:42 +0900)]
Remove skiplist for pacl x86-64 (#4821)

Remove skiplist for pacl x86-64 because pacl is not available for x86-64

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoEnable NNAPI compilation validation test (#4808)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 23:35:44 +0000 (08:35 +0900)]
Enable NNAPI compilation validation test (#4808)

* Enable NNAPI compilation validation test

Enable ValidationTestCompilation.Finish test
Define compile state STARTED

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Rename NONE to CREATED

5 years agoRemove simple operation in ARMComputeEx (#4814)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 10:49:29 +0000 (19:49 +0900)]
Remove simple operation in ARMComputeEx (#4814)

Remve simple operation in ARMComputeEx except pack/unpack

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agomake distclean should remove nnapi generated tests (#4812)
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Thu, 21 Mar 2019 10:49:09 +0000 (19:49 +0900)]
make distclean should remove nnapi generated tests (#4812)

`make distclean` should remove all derived files after git cloned.
nnapi generated tests are among them.

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
5 years agoAdd reduce max and custom operator framework test (#4811)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 10:48:51 +0000 (19:48 +0900)]
Add reduce max and custom operator framework test (#4811)

Add custom op for reduce max and reduce sum test (for tizen build)
Add custom op squared difference and abs test
Add reduce_max op test

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoSet input and output tensor info for interpreter (#4798)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 10:48:06 +0000 (19:48 +0900)]
Set input and output tensor info for interpreter (#4798)

- Set input and output tensor info for interpreter
- Fix TensorInfo bug
- Remove sink/source implementation

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRemove NENormalizationLayer (#4813)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 10:07:36 +0000 (19:07 +0900)]
Remove NENormalizationLayer (#4813)

Remove deprecated NENormalizationLayer and NENormalizationLayerExKernel implementation

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Enable Gather, Neg, Abs ops (#4740)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 21 Mar 2019 05:20:40 +0000 (14:20 +0900)]
[neurun] Enable Gather, Neg, Abs ops (#4740)

This commit enables `Gather`, `Neg`, `Abs` ops for `acl_cl`.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoEnable NNAPI I/O identify validation check (#4810)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 05:06:46 +0000 (14:06 +0900)]
Enable NNAPI I/O identify validation check (#4810)

Enable ValidationTestIdentify.DuplicateInputs and ValidationTestIdentify.DuplicateOutputs for acl_cl kernel
Enable all ValidationTestIdentify test for cpu kernel

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Add additional skip lists related to unsupported U8 (#4809)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 21 Mar 2019 03:46:03 +0000 (12:46 +0900)]
[neurun] Add additional skip lists related to unsupported U8 (#4809)

As We've discussed in #4797 and already merged skip list PR #4805, but some tests related to unsupported U8 are also failed.
This commit adds additional skip lists related to unsupported U8.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years ago[Tools] tool to convert pb file (binary) to pbtxt file (text) (#4788)
윤현식/On-Device Lab(SR)/Principal Engineer/삼성전자 [Thu, 21 Mar 2019 02:18:15 +0000 (11:18 +0900)]
[Tools] tool to convert pb file (binary) to pbtxt file (text) (#4788)

* [Tools] Convert pb file to pbtxt file

This tool converts frozen pb file in tensorflow to pbtxt text file.

Signed-off-by: Hyun Sik Yoon <hyunsik.yoon@samsung.com>
* remove common.py

* remove underbar from parameter

5 years agoIntroduce paramter checker (#4804)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 01:40:39 +0000 (10:40 +0900)]
Introduce paramter checker (#4804)

Introduce parameter checker. As a first commit,
- Check add node only
- Check activation paramter is constant only

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRename reduce max operation (#4806)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 21 Mar 2019 01:25:00 +0000 (10:25 +0900)]
Rename reduce max operation (#4806)

Rename NNAPI Ex operation for reduce max
TENSORFLOW_MAX_EX -> REDUCE_MAX_EX
Update NeuralNetworksEx.h comment

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRemove const keyword from converting functions in NNAPIConvert (#4802)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 21 Mar 2019 01:06:45 +0000 (10:06 +0900)]
Remove const keyword from converting functions in NNAPIConvert (#4802)

This commit removes const keyword from converting functions in NNAPIConvert.
In general, const is used on a return value of RVO because const affect move semantics.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoAppend nnapi tests of comparison into skiplist of neurun (#4805)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 21 Mar 2019 01:05:45 +0000 (10:05 +0900)]
Append nnapi tests of comparison into skiplist of neurun (#4805)

This commit appends nnapi tests of comparison into skiplist of neurun.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoCleanup build warnings (#4794)
Vladimir Plazun/AI Tools Lab /SRR/Engineer/삼성전자 [Thu, 21 Mar 2019 00:28:13 +0000 (03:28 +0300)]
Cleanup build warnings (#4794)

Remove redundant `virtual` declarations and use `override` instead( as per Core Guidelines C.128 )

Signed-off-by: Vladimir Plazun <v.plazun@samsung.com>
5 years ago[neurun] Merge Equal and NotEqual to Comparison op (#4797)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 20 Mar 2019 08:37:04 +0000 (17:37 +0900)]
[neurun] Merge Equal and NotEqual to Comparison op (#4797)

In https://github.sec.samsung.net/STAR/nnfw/pull/4738#discussion_r156180, we've discussed to group all operations in `::arm_compute::ComparisonOperation`.
This commit introduces `ComparisonNode` that includes operations in `::::arm_compute::ComparisonOperation` and intergrate `Equal` and `NotEqual` to `ComparisonNode`

`ComparisonNode` can be support below.

```
enum class ComparisonType
 {
   Equal,
   NotEqual,
   Greater,
   GreaterEqual,
   Less,
   LessEqual
 };
```

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoFix cmake regular expression bug (#4790)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 20 Mar 2019 07:36:22 +0000 (16:36 +0900)]
Fix cmake regular expression bug (#4790)

Use variable setting instead of regular expression
because option setting by cmake configure is not working
It is temporary solution until changing option setting for each architecture

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Enable Equal, SquaredDifference, TopKV2 ops (#4738)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 20 Mar 2019 04:32:40 +0000 (13:32 +0900)]
[neurun] Enable Equal, SquaredDifference, TopKV2 ops (#4738)

* [neurun] Enable Equal, SquaredDifference, TopKV2 ops

This commit enables `Equal`, `SquaredDifference`, `TopKV2` ops for `acl_cl`.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* Fix build break

5 years ago[neurun] Remove unnecessary target include dirs (#4787)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 20 Mar 2019 02:11:50 +0000 (11:11 +0900)]
[neurun] Remove unnecessary target include dirs (#4787)

Remove `target_include_directories` for NEURUN_INCLUDE_DIR.
However variable NEURUN_INCLUDE_DIR cannot be removed for now since
cpu/acl_cl kernel module improperly depend on this dir.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoFix missing symbol in logging backend (#4793)
Vladimir Plazun/AI Tools Lab /SRR/Engineer/삼성전자 [Wed, 20 Mar 2019 01:12:22 +0000 (04:12 +0300)]
Fix missing symbol in logging backend (#4793)

* Fix missing symbol in logging backend

Add missing ANeuralNetworksCompilation_free in logging backend

Signed-off-by: Vladimir Plazun <v.plazun@samsung.com>
* Format fix

Signed-off-by: Vladimir Plazun <v.plazun@samsung.com>
5 years ago[neurun] Extract core module CMakeLists.txt (#4789)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 19 Mar 2019 08:09:46 +0000 (17:09 +0900)]
[neurun] Extract core module CMakeLists.txt (#4789)

Extract CMakeLists.txt file for neurun/core.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoSave backend dlopen handle (#4784)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 19 Mar 2019 08:07:32 +0000 (17:07 +0900)]
Save backend dlopen handle (#4784)

Save backend dlopen handle in map member variable
It uses to avoid warning by handle lost without dlclose(), but it will be used to other purpose later

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Enable LogicalOr, LogicalNot ops (#4734)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 19 Mar 2019 08:06:49 +0000 (17:06 +0900)]
[neurun] Enable LogicalOr, LogicalNot ops (#4734)

* [neurun] Enable LogicalOr, LogicalNot ops

Related : #3708

This commit enables `LogicalOr`, `LogicalNot` ops for `acl_cl`.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* Change LogicalOr kernel to CLBitwiseOr

* Fix build break

5 years agoIntroduce TensorInfo for interpreter (#4780)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 19 Mar 2019 06:45:52 +0000 (15:45 +0900)]
Introduce TensorInfo for interpreter (#4780)

Introduce TensorInfo for interpreter
Current implementation is copy of compiler::TensorInfo

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoInterpreter unittest (#4783)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 19 Mar 2019 06:45:18 +0000 (15:45 +0900)]
Interpreter unittest (#4783)

* Interpreter unittest

Introduce interpreter unittest: unittest for ExecManager

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Add comment and namespace

5 years ago[neurun] Re-organize neurun core directories (#4781)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 19 Mar 2019 03:58:45 +0000 (12:58 +0900)]
[neurun] Re-organize neurun core directories (#4781)

Introduce core directory and separate headers into two types - private
and public. Public header may be used by frontend and backend
implemenatations.

New directory structure is as follows:

```
- neurun
  - frontend (as-is)
  - backend  (as-is)
  - core
    - include
    - src
```

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoRemove "externals/CMakeLists.txt" (#4777)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 19 Mar 2019 00:35:20 +0000 (09:35 +0900)]
Remove "externals/CMakeLists.txt" (#4777)

This commit moves all the scripts related android support into contrib/
directory, and removes "externals/CMakeLists.txt" from the repo.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoUse pre-built TensorFlow Lite (#4779)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 12:30:54 +0000 (21:30 +0900)]
Use pre-built TensorFlow Lite (#4779)

This commit updates TensorFlow Lite CMake package to lookup pre-built
binaries from the system if BUILD_TENSORFLOW_LITE is set as OFF.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoCheck format all files as default (#4775)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 09:34:07 +0000 (18:34 +0900)]
Check format all files as default (#4775)

Check format all c and c++ files as default

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRequire TensorFlow Lite when building nnfw_lib_tflite (#4774)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 09:33:52 +0000 (18:33 +0900)]
Require TensorFlow Lite when building nnfw_lib_tflite (#4774)

nnfw_lib_tflite depends on TensorFlow Lite, but there is no explicit
find_package statement.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years ago[neurun] Organize directories of backend impls (#4773)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 18 Mar 2019 08:24:31 +0000 (17:24 +0900)]
[neurun] Organize directories of backend impls (#4773)

Extract backend implementations outside of `src` directory.

Now the directory structure is:

```
- neurun
  - frontend
    - nnapi
  - backend
    - acl_cl
    - cpu
  - src (will be `core`)
```

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoIntroduce interpreter ExecManager (#4747)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 08:24:03 +0000 (17:24 +0900)]
Introduce interpreter ExecManager (#4747)

To introduce interpreter ExecManager, rename Interpereter class
ExecManager will handle execution environment and invoke intepreter
Execution environment and interpreter will be introduced as separated module later

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoMove scripts related with tflite_benchmark_model (#4770)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 08:14:40 +0000 (17:14 +0900)]
Move scripts related with tflite_benchmark_model (#4770)

This commit extracts scripts related with tflite_benchmark_model
from "externals/CMakeLists.txt", and move these scripts into
tflite_benchmark_model project.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoAllow multiple TensorFlowLite package request (#4771)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 07:25:44 +0000 (16:25 +0900)]
Allow multiple TensorFlowLite package request (#4771)

The current implementation does not work in the presence of multiple
nnfw_find_package(TensorFlowLite ...) invocations.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years ago[neurun] Enable PReLU, TransposeConv, SQRT ops (#4733)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 18 Mar 2019 06:42:37 +0000 (15:42 +0900)]
[neurun] Enable PReLU, TransposeConv, SQRT ops (#4733)

This commit enables `PReLU`, `TransposeConv`, `SQRT` ops for `acl_cl`.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoFix format in contrib (#4762)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 05:08:11 +0000 (14:08 +0900)]
Fix format in contrib (#4762)

Fix format in contrib except benchmark_acl
(bencmark_acl is ported codes from arm compute)

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Fix NNAPI frontend directory structure (#4769)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 18 Mar 2019 04:59:50 +0000 (13:59 +0900)]
[neurun] Fix NNAPI frontend directory structure (#4769)

Reduce redundant frontend directory.

From `neurun/frontend/nnapi/frontend` to `neurun/frontend/nnapi`.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoIntroduce TensorFlow Lite package (#4766)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 04:55:22 +0000 (13:55 +0900)]
Introduce TensorFlow Lite package (#4766)

This commit extracts TensorFlow Lite build script from
"external/CMakeLists.txt", and makes is as a separate TensorFlow
Lite package.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoUse regular expression to check arm architecture (#4765)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 04:46:46 +0000 (13:46 +0900)]
Use regular expression to check arm architecture (#4765)

Use regular arm* and aarch* to check arm architecture

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Enable EmbeddingLookup, L2Normalization, HashtableLookup ops (#4707)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 18 Mar 2019 04:37:31 +0000 (13:37 +0900)]
[neurun] Enable EmbeddingLookup, L2Normalization, HashtableLookup ops (#4707)

* [neurun] Enable EmbeddingLookup, L2Normalization, HashtableLookup ops

This commit enables `EmbeddingLookup`, `L2Normalization`, `HashtableLookup` ops for `acl_cl`.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* Add comment

5 years agoSet initialize member in PermuteLayer (#4764)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 04:36:58 +0000 (13:36 +0900)]
Set initialize member in PermuteLayer (#4764)

Set initialize member _type in PermuteLayer

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoFix logging runtime format (#4767)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 03:46:44 +0000 (12:46 +0900)]
Fix logging runtime format (#4767)

Fix logging runtime format and check all runtimes

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoDo NOT use CMAKE_CURRENT_SOURCE_DIR for tflite build (#4761)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 18 Mar 2019 01:29:09 +0000 (10:29 +0900)]
Do NOT use CMAKE_CURRENT_SOURCE_DIR for tflite build (#4761)

The current tflite build script uses the hardcoded location of TensorFlow
source code.

This commit removes such hardcoded location and uses TensorFlowSource_DIR
variable instead.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years ago[neurun] Separate CMakeLists for frontend/nnapi (#4760)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 18 Mar 2019 01:06:00 +0000 (10:06 +0900)]
[neurun] Separate CMakeLists for frontend/nnapi (#4760)

Separate CMakeLists for frontend/nnapi. And corresponding inclusion path
fixes.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoCache generated tests (#4755)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Sun, 17 Mar 2019 23:51:34 +0000 (08:51 +0900)]
Cache generated tests (#4755)

Do not generate generated tests unless related files are changed.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoIntroduce boolean types into internal operand (#4759)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Fri, 15 Mar 2019 09:53:11 +0000 (18:53 +0900)]
Introduce boolean types into internal operand (#4759)

This commit introduces boolean types into internal operand.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoOff downloading ACL Source on gbs build (#4741)
이춘석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 15 Mar 2019 04:25:35 +0000 (13:25 +0900)]
Off downloading ACL Source on gbs build (#4741)

- Off downloading ACL Source on gbs build

Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
5 years agoUse nnfw command in Makefile (#4746)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 15 Mar 2019 04:21:54 +0000 (13:21 +0900)]
Use nnfw command in Makefile (#4746)

This commit updates Makefile to access nnfw internal through top-level
nnfw command (instead of using cmake directly).

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoRemove SetIO test's dependency with frontend (#4742)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 23:41:28 +0000 (08:41 +0900)]
Remove SetIO test's dependency with frontend (#4742)

Remove SetIO test's dependency by using neurun core
Prepare divide frontend-unittest, core-unittest and backend-unittest,

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoFix OperationCodeEx of nnapi (#4749)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 23:41:16 +0000 (08:41 +0900)]
Fix OperationCodeEx of nnapi (#4749)

This commit fixes OperationCodeEx number.
  - ANEURALNETWORKS_REDUCE_MIN_EX : 500021 -> 50021
  - ANEURALNETWORKS_PRELU_EX : 500022 -> 50022

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years ago[neurun] Remove the things related to "NN API name". (#4748)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 11:43:53 +0000 (20:43 +0900)]
[neurun] Remove the things related to "NN API name". (#4748)

This commit Removes the things related to "NN API name".

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoRemove runtime in Makefile (#4744)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 11:21:31 +0000 (20:21 +0900)]
Remove runtime in Makefile (#4744)

Remove deprecated build option runtime

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[acl] Use lws_hint() instead of default parameter (#4745)
윤지영/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 10:28:49 +0000 (19:28 +0900)]
[acl] Use lws_hint() instead of default parameter (#4745)

This commit applies `lws_hint()` in the case of below operators.
TensorFlowMax, TensorFlowSum, EXP, GATHER, CAST, PAD

Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
5 years agoIntroduce ONE_HOT, GREATER_EQUAL and LESS operation into NeuralNetworsEx.h (#4736)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 07:48:05 +0000 (16:48 +0900)]
Introduce ONE_HOT, GREATER_EQUAL and LESS operation into NeuralNetworsEx.h (#4736)

* Introduce ONE_HOT_EX operation in NeuralNetworksEx.h

This commit introduces ONE_HOT_EX operation in NeuralNetworsEx.h.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
* Introduce GREATER_EQUAL_EX and LESS_EX operations in NeuralNetworksEx.h

This commit introduces GREATER_EQUAL_EX and LESS_EX operations in NeuralNetworksEx.h

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoCheck aarch for arm-related build option (#4735)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 07:27:52 +0000 (16:27 +0900)]
Check aarch for arm-related build option (#4735)

Check aarch32 and aarch64 for BUILD_ARMCOMPUTE and BUILD_PURE_ARM_COMPUTE default

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoAdd mobiilenet to model benchmark list (#4732)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 07:15:22 +0000 (16:15 +0900)]
Add mobiilenet to model benchmark list (#4732)

Add mobiilenet to model benchmark list

5 years agoFix gbs build script (#4731)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 07:01:20 +0000 (16:01 +0900)]
Fix gbs build script (#4731)

Use nnfw command instead of run (removed)

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Remove unused header inclusions (#4730)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 05:56:45 +0000 (14:56 +0900)]
[neurun] Remove unused header inclusions (#4730)

Remove unused header inclusions which causes unnecessary coupling.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoRemove CMake branch for Android build (#4729)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 04:30:06 +0000 (13:30 +0900)]
Remove CMake branch for Android build (#4729)

Let's use fine-control over each component later.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoRevert same padding calculation (#4727)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 14 Mar 2019 03:50:25 +0000 (12:50 +0900)]
Revert same padding calculation (#4727)

Revert same padding calculation because current padding calculation is incorrect

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Add missing generated tests (#4725)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 01:42:08 +0000 (10:42 +0900)]
[neurun] Add missing generated tests (#4725)

In #4667, I've missed generated tests related that ops because of rebasing.
This commit adds missing generated tests.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years ago[neurun] Update same_padding helper (#4723)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 01:31:00 +0000 (10:31 +0900)]
[neurun] Update same_padding helper (#4723)

In #3629, `same_padding` helper is updated to correct.
This commit updates to the same as `same_padding` of `PACL`.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years ago[neurun] Enable L2Pool2D op (#4688)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 00:29:09 +0000 (09:29 +0900)]
[neurun] Enable L2Pool2D op (#4688)

This commit enables `L2Pool2D` op for `acl_cl`.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years ago[neurun] Prepend license to wrapper/execution.cc (#4718)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 14 Mar 2019 00:28:10 +0000 (09:28 +0900)]
[neurun] Prepend license to wrapper/execution.cc (#4718)

License block for this file was missing.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoRemove testbuild in Makefile (#4693)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 10:52:11 +0000 (19:52 +0900)]
Remove testbuild in Makefile (#4693)

Remove deprecated build option testbuild
Now svace and coverity use make all

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRemove `run` script that is not used any more (#4717)
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Wed, 13 Mar 2019 10:44:09 +0000 (19:44 +0900)]
Remove `run` script that is not used any more (#4717)

`run` is replaced with `nnfw` script.

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
5 years agoDo NOT update global link directory setting (#4716)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 10:42:40 +0000 (19:42 +0900)]
Do NOT update global link directory setting (#4716)

This commit removes global link_directories in the top-level
CMakeLists.txt.

This command was introduced as a workaround for CI build failure, but is
no longer required.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoCoverage report for neurun (#4706)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 09:40:53 +0000 (18:40 +0900)]
Coverage report for neurun (#4706)

Change coverage report target to neurun, not pure runtime

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoFix SetIO test (#4715)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 09:16:34 +0000 (18:16 +0900)]
Fix SetIO test (#4715)

- Remove dynamic casting
- Remove unused header
- Remove unused alias

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoMake clean and distclean for external handling (#4649)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 09:14:57 +0000 (18:14 +0900)]
Make clean and distclean for external handling (#4649)

* Make clean and clean_all for external handling

make clean: clean only workdir
make clean_all: clean workdir and external stamp file

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* change command clean_all to distclean

5 years ago[neurun] Enable Floor, SpaceToDepth ops (#4686)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 13 Mar 2019 07:24:30 +0000 (16:24 +0900)]
[neurun] Enable Floor, SpaceToDepth ops (#4686)

This commit enables `Floor`, `SpaceToDepth` for `acl_cl`.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoSet the default value of BUILD_PURE_ARM_COMPUTE (#4710)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 07:19:44 +0000 (16:19 +0900)]
Set the default value of BUILD_PURE_ARM_COMPUTE (#4710)

Now, the default value of BUILD_PURE_ARM_COMPUTE is decided according to
the target architecture.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoUse add_subdirectories for contrib and tools (#4708)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 07:18:47 +0000 (16:18 +0900)]
Use add_subdirectories for contrib and tools (#4708)

This commit simplifies "contrib/CMakeLists.txt" and
"tools/CMakeLists.txt" using "add_subdirectories" function.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoAllow explicit control over CMake with configure command (#4702)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 06:19:57 +0000 (15:19 +0900)]
Allow explicit control over CMake with configure command (#4702)

This commit updates "nnfw configure" to pass all of its command-line arguments
to CMake, which allows users to control all the CMake options explicitly.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years ago[neurun] Extract NNAPI frontend from src (#4705)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 13 Mar 2019 06:16:31 +0000 (15:16 +0900)]
[neurun] Extract NNAPI frontend from src (#4705)

This commit extracts NNAPI implementations (e.g. ANeuralNetworksModel_create)
from "src" and moves it to newly introduced frontend/nnapi directory.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>