platform/upstream/glslang.git
4 years agoMerge pull request #2210 from Flakebi/ubsan
John Kessenich [Mon, 11 May 2020 16:43:58 +0000 (10:43 -0600)]
Merge pull request #2210 from Flakebi/ubsan

Explicitly mark EShLanguageMask as unsigned

4 years agoExplicitly mark some enums as unsigned
Sebastian Neubauer [Fri, 8 May 2020 11:52:18 +0000 (13:52 +0200)]
Explicitly mark some enums as unsigned

This allows casting from and to any unsigned value, previously this was
undefined behavior.

This fixes ubsan complaining in `TParseContext::layoutQualifierCheck`,
where `~EShLangComputeMask` is used.

4 years agoFix #2191: Error check for indexing reference containing unsize array.
John Kessenich [Fri, 1 May 2020 14:19:59 +0000 (08:19 -0600)]
Fix #2191: Error check for indexing reference containing unsize array.

4 years agoGLSL: Separate out swizzle handling (potentially fixing bugs).
John Kessenich [Fri, 1 May 2020 09:07:54 +0000 (03:07 -0600)]
GLSL: Separate out swizzle handling (potentially fixing bugs).

Noticed this when looking at swizzles.  It's at least better structure,
removing hard-to-see early returns, which might be contributing to bugs.

4 years agoMerge pull request #2205 from pmistryNV/GL_EXT_blend_func_extended
John Kessenich [Fri, 1 May 2020 08:42:49 +0000 (02:42 -0600)]
Merge pull request #2205 from pmistryNV/GL_EXT_blend_func_extended

Add support for es extension GL_EXT_blend_func_extended

4 years agoMerge branch 'master' into GL_EXT_blend_func_extended
John Kessenich [Fri, 1 May 2020 08:41:31 +0000 (02:41 -0600)]
Merge branch 'master' into GL_EXT_blend_func_extended

4 years agoMerge pull request #2204 from pmistryNV/GL_EXT_shader_implicit_conversions
John Kessenich [Fri, 1 May 2020 08:40:36 +0000 (02:40 -0600)]
Merge pull request #2204 from pmistryNV/GL_EXT_shader_implicit_conversions

Add support for extension GL_EXT_shader_implicit_conversions

4 years agoAdd support for es extension GL_EXT_blend_func_extended
Pankaj Mistry [Tue, 21 Apr 2020 18:33:57 +0000 (11:33 -0700)]
Add support for es extension GL_EXT_blend_func_extended
* Introduces builtin variables gl_SecondaryFragColorEXT and gl_SecondaryFragDataEXT
* Introduces builtin constant gl_MaxDualSourceDrawBuffersEXT
* enables support for layout qualifier "index" in es profile

4 years agoMerge branch 'master' into GL_EXT_shader_implicit_conversions
John Kessenich [Fri, 1 May 2020 05:09:13 +0000 (23:09 -0600)]
Merge branch 'master' into GL_EXT_shader_implicit_conversions

4 years agoAdd support for extension GL_EXT_shader_integer_mix (#2203)
pmistryNV [Fri, 1 May 2020 04:41:33 +0000 (21:41 -0700)]
Add support for extension GL_EXT_shader_integer_mix (#2203)

4 years agoAdd support for extension GL_EXT_shader_implicit_conversions
Pankaj Mistry [Mon, 27 Apr 2020 00:52:31 +0000 (17:52 -0700)]
Add support for extension GL_EXT_shader_implicit_conversions
Updated extension management in TIntermediate class.

4 years agoFix #2201: Improve const and copy constructor for TVarLivePair.
John Kessenich [Thu, 30 Apr 2020 07:56:38 +0000 (01:56 -0600)]
Fix #2201: Improve const and copy constructor for TVarLivePair.

4 years agoAdd support for extension GL_ARB_vertex_attrib_64bit (#2193)
pmistryNV [Wed, 29 Apr 2020 12:58:49 +0000 (05:58 -0700)]
Add support for extension GL_ARB_vertex_attrib_64bit (#2193)

4 years agoAdd support for extension GL_ARB_texture_query_lod. (#2194)
pmistryNV [Tue, 28 Apr 2020 05:46:54 +0000 (22:46 -0700)]
Add support for extension GL_ARB_texture_query_lod. (#2194)

4 years agoRemove unused Es310Desktop430 (#2200)
dan sinclair [Tue, 28 Apr 2020 04:05:24 +0000 (00:05 -0400)]
Remove unused Es310Desktop430 (#2200)

This variable is no longer used, remove.

4 years agoAdd support for extension GL_ARB_shading_language_packing (#2192)
pmistryNV [Mon, 27 Apr 2020 08:46:32 +0000 (01:46 -0700)]
Add support for extension GL_ARB_shading_language_packing (#2192)

4 years agoMove to SPIR-V 1.5 Rev. 3, bump revision, remove a status from README.
John Kessenich [Mon, 27 Apr 2020 08:12:05 +0000 (02:12 -0600)]
Move to SPIR-V 1.5 Rev. 3, bump revision, remove a status from README.

4 years agoNote about Build Status.
John Kessenich [Fri, 24 Apr 2020 18:01:14 +0000 (12:01 -0600)]
Note about Build Status.

4 years agoMove to latest SPIR-V header, and bump glslang revision.
John Kessenich [Fri, 24 Apr 2020 14:46:32 +0000 (08:46 -0600)]
Move to latest SPIR-V header, and bump glslang revision.

4 years agoAdd support for extension GL_ARB_shader_storage_buffer_object (#2184)
pmistryNV [Thu, 23 Apr 2020 04:46:52 +0000 (21:46 -0700)]
Add support for extension GL_ARB_shader_storage_buffer_object (#2184)

Enable below features for GL Core version 420:
* layout qualifier "std430"
* storage qualifier "buffer"
* atomic memory functions

4 years agoTPpToken: Fix compiling on clang-10 (#2189)
Phillip Stephens [Wed, 22 Apr 2020 14:19:43 +0000 (07:19 -0700)]
TPpToken: Fix compiling on clang-10 (#2189)

4 years agoxcode warnings fix (#2188)
MennoVink [Tue, 21 Apr 2020 13:06:12 +0000 (15:06 +0200)]
xcode warnings fix (#2188)

4 years agoAdd support for extension GL_ARB_shader_image_size (#2185)
pmistryNV [Mon, 20 Apr 2020 02:47:54 +0000 (19:47 -0700)]
Add support for extension GL_ARB_shader_image_size (#2185)

4 years agoAdd support for extension GL_ARB_shader_bit_encoding (#2183)
pmistryNV [Fri, 17 Apr 2020 11:24:12 +0000 (04:24 -0700)]
Add support for extension GL_ARB_shader_bit_encoding (#2183)

4 years agoSupport multiple swizzled out operands (#2175)
Cody Northrop [Tue, 14 Apr 2020 03:59:49 +0000 (21:59 -0600)]
Support multiple swizzled out operands (#2175)

Swizzled out operands were added in bbbd9a2a. This was sufficient
for most tests, but we ran into problems with umulExtended and
imulExtended, which have two.

This CL converts the tracking values to vectors so multiple operands
can be supported.

Test: KHR-GLES31.core.shader_bitfield_operation.*
Test: ctest

4 years agoFix #2178: Allow specialization constants for texel offsets.
John Kessenich [Mon, 13 Apr 2020 04:56:17 +0000 (22:56 -0600)]
Fix #2178: Allow specialization constants for texel offsets.

4 years agoGet rid of all warnings with MSVC and clang-cl (#2177)
Malacath-92 [Fri, 10 Apr 2020 08:39:16 +0000 (10:39 +0200)]
Get rid of all warnings with MSVC and clang-cl (#2177)

4 years agoAdd support for EXT_ray_flags_primitive_culling. (#2173)
alelenv [Thu, 9 Apr 2020 04:09:20 +0000 (21:09 -0700)]
Add support for EXT_ray_flags_primitive_culling. (#2173)

Fixes issue #2169.

4 years agoError message: Finish addressing #2097, better texture error message.
John Kessenich [Tue, 7 Apr 2020 08:18:23 +0000 (02:18 -0600)]
Error message: Finish addressing #2097, better texture error message.

4 years agoRemove extra semicolons (#2170)
Ryan Harrison [Fri, 3 Apr 2020 05:04:09 +0000 (01:04 -0400)]
Remove extra semicolons (#2170)

This is causing downstream users compiler errors if they have Werror or other
particularly restrictive flags turned on.

4 years agoShader interface matching rework to fix #2136 (#2156)
Malcolm Bechard [Thu, 2 Apr 2020 08:03:53 +0000 (04:03 -0400)]
Shader interface matching rework to fix #2136 (#2156)

* rework how shader interface block naming rules are handled

* Fixes 2136

According to the spec, shader interfaces (uniform blocks, buffer
blocks, input blocks, output blocks) all should be matched up via
their block names across all compilation units, not instance names.
Also, all block names can be re-used between all 4 interface types
without conflict. This change makes it so all of these blocks are
matched and remapped using block name and not by instance name.
Additional the rule that matched uniform and buffer blocks must
either be anonymous or named (but not nessearily the same name) is
now imposed.

* add warning if instance names differ between matched shader interfaces

* Add test cases from #2137 which is now fixed as well.

* replace some tab characters with spaces

* buffer blocks and uniform blocks now share the same block namespace

4 years agoBuild warning: Fix #2167: Remove nested reuse of 'unreachable'.
John Kessenich [Wed, 1 Apr 2020 06:46:57 +0000 (00:46 -0600)]
Build warning: Fix #2167: Remove nested reuse of 'unreachable'.

4 years agoBump revision.
John Kessenich [Tue, 31 Mar 2020 06:02:31 +0000 (00:02 -0600)]
Bump revision.

4 years agoMerge pull request #2166 from alelenv/rq_lvalue_fix
John Kessenich [Tue, 31 Mar 2020 05:24:14 +0000 (23:24 -0600)]
Merge pull request #2166 from alelenv/rq_lvalue_fix

Error out assignments to objects of rayQueryEXT type.

4 years agoError assigns to objects of rayQueryEXT type.
alelenv [Mon, 30 Mar 2020 17:24:30 +0000 (10:24 -0700)]
Error assigns to objects of rayQueryEXT type.

4 years agoMerge pull request #2164 from dj2/unused
John Kessenich [Mon, 30 Mar 2020 14:35:39 +0000 (08:35 -0600)]
Merge pull request #2164 from dj2/unused

Remove unused variables.

4 years agoRemove unused variables.
dan sinclair [Mon, 30 Mar 2020 14:03:11 +0000 (10:03 -0400)]
Remove unused variables.

This CL removes two unused variables from the initialization code.

4 years agoMerge pull request #2162 from ntfshard/small_fix
John Kessenich [Mon, 30 Mar 2020 06:33:09 +0000 (00:33 -0600)]
Merge pull request #2162 from ntfshard/small_fix

Humble fix

4 years agoFix #2163: improve comments for addProcess() and the preamble.
John Kessenich [Mon, 30 Mar 2020 06:27:31 +0000 (00:27 -0600)]
Fix #2163: improve comments for addProcess() and the preamble.

4 years agoprintf format
ntfs.hard [Sun, 29 Mar 2020 22:48:15 +0000 (01:48 +0300)]
printf format

4 years agounused var
ntfs.hard [Sun, 29 Mar 2020 22:38:21 +0000 (01:38 +0300)]
unused var

4 years agobitwise on boolean
ntfs.hard [Sun, 29 Mar 2020 22:32:23 +0000 (01:32 +0300)]
bitwise on boolean

4 years agoopposite inner condition
ntfs.hard [Sun, 29 Mar 2020 21:55:49 +0000 (00:55 +0300)]
opposite inner condition

4 years agoMerge pull request #2160 from greg-lunarg/kg110
John Kessenich [Sat, 28 Mar 2020 04:28:15 +0000 (22:28 -0600)]
Merge pull request #2160 from greg-lunarg/kg110

Update spirv-tools known_good to latest stable

4 years agoUpdate spirv-tools known_good to latest stable
Greg Fischer [Fri, 27 Mar 2020 17:34:45 +0000 (11:34 -0600)]
Update spirv-tools known_good to latest stable

4 years agoMerge pull request #2159 from neslimsah/master
John Kessenich [Fri, 27 Mar 2020 14:23:46 +0000 (08:23 -0600)]
Merge pull request #2159 from neslimsah/master

GL_EXT_ray_query accelerationStructureEXT

4 years agoMerge pull request #2157 from neslimsah/master
John Kessenich [Fri, 27 Mar 2020 01:46:35 +0000 (19:46 -0600)]
Merge pull request #2157 from neslimsah/master

GL_EXT_ray_query pass-by-reference issues

4 years agoaccelerationStructureEXT - issue #2152
Neslisah Torosdagli [Thu, 26 Mar 2020 23:32:52 +0000 (19:32 -0400)]
accelerationStructureEXT - issue #2152

4 years agoaccelerationStructureEXT - issue #2152
Neslisah Torosdagli [Thu, 26 Mar 2020 22:51:18 +0000 (18:51 -0400)]
accelerationStructureEXT - issue #2152

4 years agopass by reference updates
Neslisah Torosdagli [Thu, 26 Mar 2020 16:24:31 +0000 (12:24 -0400)]
pass by reference updates

4 years agoMerge branch 'master' of https://github.com/neslimsah/glslang
Neslisah Torosdagli [Thu, 26 Mar 2020 15:08:54 +0000 (11:08 -0400)]
Merge branch 'master' of https://github.com/neslimsah/glslang

4 years agopass-by-reference updates
Neslisah Torosdagli [Thu, 26 Mar 2020 14:52:33 +0000 (10:52 -0400)]
pass-by-reference updates

4 years agoMerge pull request #1 from KhronosGroup/master
Neslisah Torosdagli [Thu, 26 Mar 2020 15:06:00 +0000 (11:06 -0400)]
Merge pull request #1 from KhronosGroup/master

sync to KhronosGroup/glslang

4 years agoMerge pull request #2154 from GMNGeoffrey/patch-1
John Kessenich [Thu, 26 Mar 2020 06:18:25 +0000 (00:18 -0600)]
Merge pull request #2154 from GMNGeoffrey/patch-1

Add missing braces to if condition

4 years agoAdd missing braces to if condition
Geoffrey Martin-Noble [Thu, 26 Mar 2020 03:52:43 +0000 (20:52 -0700)]
Add missing braces to if condition

The indentation implies this was the intention. Noticed the issue while trying to compile our code with -Werror -Wall

4 years agoMerge pull request #2139 from neslimsah/master
John Kessenich [Wed, 25 Mar 2020 14:18:33 +0000 (08:18 -0600)]
Merge pull request #2139 from neslimsah/master

GL_EXT_ray_query updates

4 years agoswitch format update
Neslisah Torosdagli [Wed, 25 Mar 2020 12:13:32 +0000 (08:13 -0400)]
switch format update

4 years agoMerge branch 'master' of https://github.com/neslimsah/glslang
Neslisah Torosdagli [Wed, 25 Mar 2020 01:51:11 +0000 (21:51 -0400)]
Merge branch 'master' of https://github.com/neslimsah/glslang

4 years agocopyright notice changes removed from unchanged files
Neslisah Torosdagli [Wed, 25 Mar 2020 00:39:34 +0000 (20:39 -0400)]
copyright notice changes removed from unchanged files

4 years agocopyright notice changes removed from unchanged files
Neslisah Torosdagli [Wed, 25 Mar 2020 00:39:34 +0000 (20:39 -0400)]
copyright notice changes removed from unchanged files

4 years agocopyright notice changes removed from unchanged files
Neslisah Torosdagli [Tue, 24 Mar 2020 16:22:27 +0000 (12:22 -0400)]
copyright notice changes removed from unchanged files

4 years agospirv.hpp reverted to commit f368dcbb7d8af23f0cba3015d0f4dda9dc3aa66d
Neslisah Torosdagli [Tue, 24 Mar 2020 16:02:20 +0000 (12:02 -0400)]
spirv.hpp reverted to commit f368dcbb7d8af23f0cba3015d0f4dda9dc3aa66d

4 years ago.travis updated to origin, rayQueryCheck removed
Neslisah Torosdagli [Tue, 24 Mar 2020 14:24:50 +0000 (10:24 -0400)]
.travis updated to origin, rayQueryCheck removed

4 years agoMerge pull request #2149 from kainino0x/web-fix-cmake2.8
John Kessenich [Tue, 24 Mar 2020 10:18:51 +0000 (04:18 -0600)]
Merge pull request #2149 from kainino0x/web-fix-cmake2.8

Fix build on CMake 2.8, and fix Web build

4 years agoconst rayFlag defs used in the test cases in stead of numerical values
Neslisah Torosdagli [Tue, 24 Mar 2020 03:09:44 +0000 (23:09 -0400)]
const rayFlag defs used in the test cases in stead of numerical values

4 years agocompute and fragment shader test_cases added for rayQuery
Neslisah Torosdagli [Tue, 24 Mar 2020 01:56:21 +0000 (21:56 -0400)]
compute and fragment shader test_cases added for rayQuery

4 years agorayQuery test cases added
Neslisah Torosdagli [Tue, 24 Mar 2020 01:34:09 +0000 (21:34 -0400)]
rayQuery test cases added

4 years agorayQueryEXT function parameter
Neslisah Torosdagli [Tue, 24 Mar 2020 01:05:26 +0000 (21:05 -0400)]
rayQueryEXT function parameter

4 years agorayQueryEXT assignment is allowed.
Neslisah Torosdagli [Tue, 24 Mar 2020 00:25:52 +0000 (20:25 -0400)]
rayQueryEXT assignment is allowed.

4 years agotest names updated
Neslisah Torosdagli [Mon, 23 Mar 2020 23:20:24 +0000 (19:20 -0400)]
test names updated

4 years agoupdate README
Kai Ninomiya [Mon, 23 Mar 2020 19:50:33 +0000 (12:50 -0700)]
update README

4 years agoFix build on CMake 2.8, and fix Web build
Kai Ninomiya [Mon, 23 Mar 2020 19:26:53 +0000 (12:26 -0700)]
Fix build on CMake 2.8, and fix Web build

And suppress some warnings that are too verbose in Web builds.

4 years agowait time increased for the install
Neslisah Torosdagli [Mon, 23 Mar 2020 17:49:16 +0000 (13:49 -0400)]
wait time increased for the install

4 years agorayQuery test cases disabled
Neslisah Torosdagli [Mon, 23 Mar 2020 15:36:06 +0000 (11:36 -0400)]
rayQuery test cases disabled

4 years agoMerge pull request #2146 from aaronfranke/file-formatting
John Kessenich [Sat, 21 Mar 2020 08:45:39 +0000 (02:45 -0600)]
Merge pull request #2146 from aaronfranke/file-formatting

Make file formatting comply with POSIX and Unix standards

4 years agoMake file formatting comply with POSIX and Unix standards
Aaron Franke [Sat, 21 Mar 2020 07:20:25 +0000 (03:20 -0400)]
Make file formatting comply with POSIX and Unix standards

UTF-8, LF, no BOM, and newlines at the end of files

4 years agoMerge branch 'master' of https://github.com/neslimsah/glslang
Neslisah Torosdagli [Fri, 20 Mar 2020 22:35:57 +0000 (18:35 -0400)]
Merge branch 'master' of https://github.com/neslimsah/glslang

4 years agoGL_EXT_ray_query glslang updates, and test cases added.
Neslisah Torosdagli [Fri, 20 Mar 2020 22:23:27 +0000 (18:23 -0400)]
GL_EXT_ray_query glslang updates, and test cases added.

4 years agoMerge pull request #2141 from courtney-g/bug_2140
John Kessenich [Fri, 20 Mar 2020 05:05:41 +0000 (23:05 -0600)]
Merge pull request #2141 from courtney-g/bug_2140

Fix MSVC build issue - remove invalid character

4 years agoFix MSVC build issue - remove invalid character
Courtney Goeltzenleuchter [Thu, 19 Mar 2020 21:31:31 +0000 (15:31 -0600)]
Fix MSVC build issue - remove invalid character

On Windows the single quote used in a comment was showing up as some
special character that the Microsoft compiler didn't like.

Bug #2140

4 years agocomment update, rayQueryEXT is writable, readonly check removed.
Neslisah Torosdagli [Thu, 19 Mar 2020 20:34:40 +0000 (16:34 -0400)]
comment update, rayQueryEXT is writable, readonly check removed.

4 years agoGL_EXT_ray_query updates
Torosdagli [Thu, 19 Mar 2020 15:09:57 +0000 (11:09 -0400)]
GL_EXT_ray_query updates

4 years agoFix #2132: constant matrix constructor from single non-scalar argument
John Kessenich [Wed, 18 Mar 2020 16:27:59 +0000 (10:27 -0600)]
Fix #2132: constant matrix constructor from single non-scalar argument

4 years agocomment update, rayQueryEXT is writable, readonly check removed.
Neslisah Torosdagli [Thu, 19 Mar 2020 20:34:40 +0000 (16:34 -0400)]
comment update, rayQueryEXT is writable, readonly check removed.

4 years agoGL_EXT_ray_query updates
Torosdagli [Thu, 19 Mar 2020 15:09:57 +0000 (11:09 -0400)]
GL_EXT_ray_query updates

4 years agoFix #2132: constant matrix constructor from single non-scalar argument
John Kessenich [Wed, 18 Mar 2020 16:27:59 +0000 (10:27 -0600)]
Fix #2132: constant matrix constructor from single non-scalar argument

4 years agocomment update, rayQueryEXT is writable, readonly check removed.
Neslisah Torosdagli [Thu, 19 Mar 2020 20:34:40 +0000 (16:34 -0400)]
comment update, rayQueryEXT is writable, readonly check removed.

4 years agoGL_EXT_ray_query updates
Neslisah Torosdagli [Thu, 19 Mar 2020 20:26:40 +0000 (16:26 -0400)]
GL_EXT_ray_query updates

4 years agoGL_EXT_ray_query updates
Torosdagli [Thu, 19 Mar 2020 15:09:57 +0000 (11:09 -0400)]
GL_EXT_ray_query updates

4 years agoMerge pull request #2135 from alelenv/rt_shaderlang_enums
John Kessenich [Wed, 18 Mar 2020 18:16:30 +0000 (12:16 -0600)]
Merge pull request #2135 from alelenv/rt_shaderlang_enums

Re-add NV enums for raytracing to prevent build breaks.

4 years agoRe-add NV enums for raytracing to prevent build breaks.
alelenv [Wed, 18 Mar 2020 16:30:05 +0000 (09:30 -0700)]
Re-add NV enums for raytracing to prevent build breaks.

4 years agoFix #2132: constant matrix constructor from single non-scalar argument
John Kessenich [Wed, 18 Mar 2020 16:27:59 +0000 (10:27 -0600)]
Fix #2132: constant matrix constructor from single non-scalar argument

4 years agoBump version (also fix line endings the grammar).
John Kessenich [Wed, 18 Mar 2020 14:35:40 +0000 (08:35 -0600)]
Bump version (also fix line endings the grammar).

4 years agoMerge pull request #2130 from dgkoch/EXT_ray_tracing
John Kessenich [Wed, 18 Mar 2020 04:14:21 +0000 (22:14 -0600)]
Merge pull request #2130 from dgkoch/EXT_ray_tracing

Add support for GLSL_EXT_ray_tracing

4 years agoupdate known_good
Daniel Koch [Tue, 17 Mar 2020 23:51:11 +0000 (19:51 -0400)]
update known_good

4 years agoAdd support for GLSL_EXT_ray_tracing
Daniel Koch [Wed, 18 Mar 2020 00:42:47 +0000 (20:42 -0400)]
Add support for GLSL_EXT_ray_tracing

and SPV_KHR_ray_tracing

4 years agoSPV headers: Bump up to the latest header.
John Kessenich [Tue, 17 Mar 2020 14:00:41 +0000 (08:00 -0600)]
SPV headers: Bump up to the latest header.

This contains the base for ray tracing extensions.

4 years agoMerge pull request #2129 from jeffbolznv/memoryBarrierAtomicCounter
John Kessenich [Tue, 17 Mar 2020 07:05:35 +0000 (01:05 -0600)]
Merge pull request #2129 from jeffbolznv/memoryBarrierAtomicCounter

Forbid memoryBarrierAtomicCounter for Vulkan compiles

4 years agoForbid memoryBarrierAtomicCounter for Vulkan compiles
Jeff Bolz [Tue, 17 Mar 2020 04:53:04 +0000 (23:53 -0500)]
Forbid memoryBarrierAtomicCounter for Vulkan compiles

4 years agoFix #2005. Allow multiple compilation units to declare identical push_constant blocks...
Malcolm Bechard [Mon, 16 Mar 2020 14:51:15 +0000 (10:51 -0400)]
Fix #2005. Allow multiple compilation units to declare identical push_constant blocks (#2123)

* Fixes #2005

Allow multiple units in a stage to have push_constants as long
as the blocks match.
Requires #2006 to be fixed to be functional.

* tweaks to #2005 fix after some testing

* add unit tests for push constants across multiple compilation units

For #2005

* update reference output for tests that fail validation

* fix uninitialized result.validationResult