Rafal Walczyna [Thu, 21 Nov 2019 10:46:10 +0000 (11:46 +0100)]
[MediaController] Fix removing invalid listener
CommandListener was removed instead of ChangeRequestPlaybackInfoListener.
It was impossible to add ChangeRequestPlaybackInfoListener again.
Verification: tct passrate 100%.
Tested in GoogleChrome console on TM1 and KantM2.
Change-Id: Iff0ea6026581b3649592ee5bde3bfb625ceb35e4
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
[version] 2.37
Change-Id: Ib1de6d53a704c6321d70c5202b5a5fcc3b055ead
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
[version] 2.36
Change-Id: I99c7c0258b677468f6a163e03a7807411dbbde56
[Bluetooth] Fixed issues related to BLE
[Bug/Fix]
1. Prevent possible crash in case of invalid data passed from native
2. Prevent type mismatch exception in JS in case of LE devices advertising
serviceData.
[Verification] tct passrate 100%
Checked in chrome console and le device with serviceData.
Change-Id: Iecc9929a77a1acfd1b33eb325ea287011b9a6096
[version] 2.35
Change-Id: Ifc5a4e534e395579031af9d3d115389b7545ab77
Rafal Walczyna [Fri, 27 Sep 2019 08:33:30 +0000 (10:33 +0200)]
[Filesystem] Source code auto-formatting
Used: ./code_format src/ -c -js
Change-Id: I1a27efa220445342ec42ef5327d06ac7bdd40ca9
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Szymon Jastrzebski [Fri, 12 Jan 2018 10:07:53 +0000 (11:07 +0100)]
[Archive] Fix for retrieving virtual roots
Current implmentation gets only internal virtual roots. This change adds
getting external roots as well.
[Verification] TCT Archive passed with 100% p.r.
Change-Id: Ia961dd276901ed31d42b22d93148d51066276163
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Rafal Walczyna [Tue, 24 Sep 2019 14:23:38 +0000 (16:23 +0200)]
[Filesystem] List of virtual roots for resolve function fixed.
Current implementation of virtual roots list did not include internal0 or
external memory i.e. SDCard or USBDrive. It results in not working resolve()
function, when location to resolve was on external memory.
Verification: TCT - 100 % pass.
Change-Id: I11c2537a7f5643f8c9ccfe2f45be9f3bce3edf00
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
[Application] Fixed path of getAppSharedURI
Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy
New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner users 4096 Jul 18 13:06 .
drwxr-xr-x 5 owner users 4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw 58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner users 4096 Jul 18 13:06 trusted
Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res
[Verification] Checked manually in chrome console
TCT Application 100% passrate
Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09
Arkadiusz Pietraszek [Mon, 8 Jul 2019 08:20:14 +0000 (10:20 +0200)]
[Project][Filesystem] Fix needed after code formating of tizen_3.0 branch
Prietter code formatter treated obiect properties named 'null' and 'undefined' as keywords that should not be in apostrophes and removed those apostrophes.
This change has been reverted and //prettier-ignore tags has been added.
Change-Id: I78d502b9f674397f01c959031ad37fa139dd0b16
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Piotr Kosko [Wed, 3 Jul 2019 09:00:58 +0000 (09:00 +0000)]
Merge "[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener." into tizen_3.0
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.
Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
[version] 2.34
Change-Id: Idd416b0d826a58f7bbc72edb07d4570aa3319212
Arkadiusz Pietraszek [Thu, 27 Jun 2019 09:14:58 +0000 (11:14 +0200)]
[Mediacontroller] Setter fixes for shuffleMode, repeatMode end position in MediaControllerPlaybackInfo
Previous implementation intended to check for null and undefined and in reality didn't allow for setting 'false' or '0' values.
Change-Id: I03194e81d5d0bd5ef97a88d01a014f758a6ca49d
[version] 2.33
Change-Id: I2a04c187950845b460b398c9b16ad963c4c2330f
Arkadiusz Pietraszek [Wed, 3 Apr 2019 11:09:04 +0000 (13:09 +0200)]
[Project] JS code formatting
All project *.js files were formatted with eslint tool, to eliminate CodingRule_Auto negative marks.
Additionally Prettier tool was used for unified line breaking rules.
In few cases, the tool did not break line for very long object definitions e.g.
HumanActivityRecorderPressureData.prototype.constructor = HumanActivityRecorderPressureData;
in such cases, line was broken manually and flag // prettier-ignore was added to ignore next node.
Change-Id: I537435c652abad22364421fc4c5ebddd411defbf
[Content] isFavorite added to editableAttributes array
[Bug] Since 2.3 isFavorite is an editableAttribute, which was missing
in editableAttributes array. Now added it there.
[Verification] Code compiles without errors.
Change-Id: Ib5266a66920f0050fd5c25287602514bc4ea3762
Piotr Kosko [Wed, 17 Apr 2019 10:35:16 +0000 (10:35 +0000)]
Merge "[Project][Codeformat] Added prettier as partial formatter for JS" into tizen_3.0
Piotr Kosko [Wed, 17 Apr 2019 10:34:30 +0000 (10:34 +0000)]
Merge "[Project][code_formatter] Added u options and changed JS formatting and validating tools" into tizen_3.0
[Project][Codeformat] Added prettier as partial formatter for JS
[Feature] Existing solution check the format using eslint and fix
some issues with predefined rules (which match the requirements
of review.tizen.org CodingRule_Auto bot rules.
However the tool checks the validity, it does not provide auto
formating of too long lines issues.
To ensure such feature, the new tool was introduced and executed before
eslint validation.
Thanks to prettier, the line breaks are unified and handled the same
way in whole project.
Change-Id: I077036521307ef28fda5388ecab01b8d850ad3e3
[version] 2.32
Change-Id: Idb24a1afa087aa101cebcfde7d46d283d459c956
[Filesystem] listFiles method of File ignores files without access
[Bug] Files with invalid SMACK labels (not allowed to be accessed by app)
caused exception about missing member ("location is required argument").
Fix ignores the files that cannot be accessed.
[Verification] Manually checked with Chrome console and trying to list files
with invalid SMACK label. Files are being ignored.
100% passrate for filesystem module.
Change-Id: I48ed83ebbba5d0c6cfa0e597f083a7a1abce17fa
Arkadiusz Pietraszek [Wed, 27 Mar 2019 14:29:37 +0000 (15:29 +0100)]
[Project][code_formatter] Added u options and changed JS formatting and validating tools
Now eslint is used to format js files.
Not all issues can be fixed by eslint, so it prints list of issues for user to fix.
All 'u' options in formatter format appropriate files, that was changed from last commit.
Since files to format are not commited, this script backs up those files.
[Verification] Script executes without errors and proper files are chosen to format. Formated .js files have 4 spaces of indentation.
Change-Id: I10509ce3f639b25cca7e68e95e7c9419d9d82304
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 11:19:48 +0000 (12:19 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201880/
Change-Id: I26f3ae8991218e97d1a55cf6a0abffba622ed25f
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
[version] 2.31
Change-Id: Ic8c3ade13866c7e55ee660346c3a79103f29d006
[Archive][Exif] Added checking return value of fseek
SVACE issues: 246302, 246317
Change-Id: If4f803b9db18c352912290b25df706a21cd07853
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
[version] 2.30
Change-Id: I701491ee275a9540c9ddb821f420898629a3f5ca
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Pawel Wasowski [Wed, 19 Dec 2018 18:05:20 +0000 (19:05 +0100)]
[Messaging] Prevent crash on getMessageServices call
Calling tizen.messaging.getMessageServices() multiple times at
short intervals used to cause a crash, due to race condition, occurring
between different threads, modifying the same MessagingManager
instance's fields.
The fix moves execution of the underlying implementation to the main
thread - it is not called concurrently. The function execution time
is typically below 2 ms, so moving it to the main thread should
not worsen user experience.
[Verification] tct-tizen-messaging-email-tests pass rate: 100%
tct-tizen-messaging-sms-tests pass rate: 100%
tct-tizen-messaging-mms-tests pass rate: 100%
A code snippet, that used to cause a crash, does not
cause crash now:
for (var i = 0; i < 1000; ++i) {
tizen.messaging.getMessageServices('messaging.email',
s=>{console.log(s);},
e=>{console.error(e);});
}
Change-Id: I2f140281e64aeffea1ad9ca15f99ee38378693d3
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Lukasz Bardeli [Wed, 5 Dec 2018 09:18:08 +0000 (10:18 +0100)]
[MessagePort] Fixed issue with removeMessagePortListener without any added earlier
If any listener was added before remove then error was thrown
'Cannot read property length of undefined'
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I96000345ae483a9fa2c0b50a6be0ece427ce8e1b
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
[version] 2.29
Change-Id: I27c09aef9adc3ba125477521e95a85633b0e702d
[Common] Added missing return statement
[Bug] When parsing invalid message, exception is catched, but the control
is not finished. Going to following lines, other exception would be raised.
We need to finish execution for invalid message.
[Verification] Code compiles without errors.
Change-Id: I65784e775b9a765332c4a1f0a19b8184e896872c
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Piotr Kosko [Mon, 22 Oct 2018 12:16:20 +0000 (14:16 +0200)]
[version] 2.28
Change-Id: Icfae075f33085630150a69087c7dc8ccd78c9697
Pawel Wasowski [Fri, 19 Oct 2018 10:03:02 +0000 (12:03 +0200)]
[Messaging] Refactor MessageConversation related code
Refactoring was requested to get rid of duplicated and unnecessary
code.
[Verification] TCT pass rate: 100%
Change-Id: Iee2eacf50ca89ea60e89b283d3aac24111cfd5e5
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Fri, 24 Aug 2018 16:12:09 +0000 (18:12 +0200)]
[Messaging] Fix sorting and filtering issues in findConversations
The commit fixes the following problems of email service's findConversations:
- conversations sorted with regard to timestamp, subject, to, from attributes
were ordered incorrectly
- an attempt to sort results with regard to unreadMessages, isRead, cc,
bcc, lastMessageId attributes resulted in throwing a JS exception
- unreadMessages attribute value depended on the offset argument value
- filtering by unreadMessages, did not work
The commit changes also the method of creation of MessageConversation
from database records. It may be quicker than the previous one,
that unnecessarily retrieved numerous messages from the database several times.
[Verification] TCT Pass rate: 100%
Several filters and sort modes were tested manually,
with Chrome DevTools.
Change-Id: I6196e316ff2b1477c909d528859ef980237454b6
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Piotr Kosko [Tue, 2 Oct 2018 12:08:07 +0000 (14:08 +0200)]
[version] 2.27
Change-Id: I7aa0f9e1384347db1d0b045ef46542fcd5e8c7a2
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 2 Oct 2018 11:25:19 +0000 (13:25 +0200)]
[Archive][Exif] Added missing error checking
[Verification] Code compiles without errors.
Change-Id: I588a1d08f4dea4a19038653b2889a1daa5b45673
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Thu, 20 Sep 2018 07:01:37 +0000 (09:01 +0200)]
[version] 2.26
Change-Id: Ibb8feb4665aee4761dc2592147bdd41743bed13d
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Thu, 20 Sep 2018 06:40:06 +0000 (08:40 +0200)]
[Bluetooth] Fixing the memory releasing issue
[Verification] Code compiles without errors.
TCT passrate 100%.
Change-Id: I4a7b516635b7d2a3bfc96359fa4d51543b0eb4e0
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Thu, 16 Aug 2018 08:42:15 +0000 (10:42 +0200)]
[version] 2.25
Change-Id: If58254886f7fa6188e597e4d20dcb30f0ef60234
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Pawel Kaczmarczyk [Wed, 8 Aug 2018 12:32:16 +0000 (14:32 +0200)]
[SystemInfo][Bluetooth][Push] Add misssing deprecation warnings since Tizen 3.0
[Verification]
Code compiles
tct-systeminfo-tizen-tests passrate 100%
Change-Id: I41db5325ac94ca042069551a41161e5b968e51d3
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Pawel Kaczmarczyk [Wed, 18 Jul 2018 13:45:45 +0000 (15:45 +0200)]
[HAM] Fix throwing exceptions for getHumanActivityData
[Bug] getHumanActivityData method accepts only 'PEDOMETER'
and 'HRM' values of HumanActivityType enum as type
parameter. Any other value should cause NotSupportedError,
but implementation leaded to UnknownError instead.
[Verification] AutoTCT 100% passrate
Change-Id: Id5145d76f8957527e28f42c9b1c3141b11b8e5ca
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Pawel Kaczmarczyk [Thu, 26 Jul 2018 07:05:03 +0000 (09:05 +0200)]
[NFC] Minor fixes
[Bugs]
1. In special cases records objects were created as empty
2. If NFCPeerDetectCallback or NFCTagDetectCallback did
not have defined function to call on action an TypeError
would be thrown.
[Verification] tct-nfc-tizen-tests passrate 100%
Change-Id: I32d6cbdc05c491f42100580a1cfe021c4c877bfc
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Lukasz Bardeli [Thu, 12 Jul 2018 05:38:20 +0000 (07:38 +0200)]
[version] 2.24
Change-Id: I612a9ec9977025efbbb35fa2c58e4c3ec8226b79
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Pawel Kaczmarczyk [Tue, 10 Jul 2018 13:35:36 +0000 (15:35 +0200)]
[HRM] Fix for resetting pedometer data after calling start
[Bug] Pedometer properties were not reset
back to zero after calling start again.
[Verification] Auto TCT passrate 100%
Manual (wearable and mobile emulators) 100%
Change-Id: I4b961a5c05224accb7ff482c570b3dd3aa352bb4
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Piotr Kosko [Fri, 18 May 2018 11:44:31 +0000 (13:44 +0200)]
[version] 2.23
Change-Id: I7634bdecaab795b4f9db8b76ecc92a8ee00da755
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Rafal Walczyna [Wed, 16 May 2018 12:29:03 +0000 (14:29 +0200)]
[humanactivitymonitor] Fixing rRinterval value in heartRate data
rRinterval was always 0. This value is now available, but measurement
is not present in unified builds. It was tested on R765 and R600 with
solis binaries and it worked fine.
[verification] AutoTCT - 100% pass
Change-Id: I3c181c53e0832f429774f86277bcaeda4708c0b7
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Lukasz Bardeli [Thu, 10 May 2018 06:43:35 +0000 (08:43 +0200)]
[Iotcon] Prevent iotcon from call timeout after found resource
In ResourceFoundCallback after some resource was found, timeout will
never be called.
[Verification] Code compiles without error. TCT tests passrate 100%
Change-Id: I96ca592eb94e14c374b6eab99ca1956108f37154
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Piotr Kosko [Wed, 25 Apr 2018 10:42:27 +0000 (12:42 +0200)]
[version] 2.22
Change-Id: I75c3fdd794b62946720fc5cb537c437ab33843bd
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 24 Apr 2018 10:40:19 +0000 (12:40 +0200)]
[Filesystem] Fixing file filter
[Bug]
1. FileFilter name was not matching '%' wildcard on the beginning of filename
2. wildcard escaping need to be done by using '\\%' not '\%' - proper comment
added in code to ease future investigations.
[Verification] Code compiles successfully.
TCT passrate is 100%.
Below code:
var filter = "piotr\\%kosko%";
function onsuccess(files) {
console.log("There are " + files.length + " in the selected folder");
for (var i =0; i < files.length; ++i) { console.log(files[i].name) }
}
function onerror(error) {
console.log("The error " + error.message +
" occurred when listing the files in the selected folder");
}
tizen.filesystem.resolve("documents", function(dir) {
dir.listFiles(onsuccess, onerror, {name: filter});
}, function(e) { console.log("Error " + e.message);}, "r");
for filter "piotr\\%kosko%" filters file:
piotr%koskoTest
for filter "%kosko%" filter files:
piotrkoskoTest
piotrkosko
piotrTestkoskoTest
kosko
piotr%koskoTest
piotr%kosko
Change-Id: If7e6c3c3ad97a3d01a800916ba73c5f7749ae0cb
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 18 Apr 2018 08:28:21 +0000 (10:28 +0200)]
[version] 2.21
Change-Id: Id7ba90815fd7970998c28343c0b1e5cce6fac32f
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 18 Apr 2018 06:51:51 +0000 (06:51 +0000)]
Merge "[IoTcon] Fix query creation for requests" into tizen_3.0
Rafal Walczyna [Tue, 17 Apr 2018 12:39:23 +0000 (14:39 +0200)]
[IoTcon] Fix query creation for requests
[Bug] query was not created properly when there was no
resource interface set
[Verification] 100% passrate on TM1
Change-Id: Iea1db9418fe10e9fad56a9bb7de1c34c95cbc5dd
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Piotr Kosko [Wed, 18 Apr 2018 06:11:18 +0000 (08:11 +0200)]
[Spec] Fixing build dependency
[Verification] Code compiles without errors.
Change-Id: I7bc3f9c4ed440ab00822366c49843228be626b62
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 17 Apr 2018 12:56:43 +0000 (12:56 +0000)]
Merge "[Power] Prevent override of power level locked with Web API" into tizen_3.0
Piotr Kosko [Tue, 17 Apr 2018 12:54:29 +0000 (12:54 +0000)]
Merge "[Power] Refactoring module" into tizen_3.0
Lukasz Bardeli [Tue, 17 Apr 2018 08:45:24 +0000 (10:45 +0200)]
[Application] Add removing event_handler in destructor.
Removing all event_handler from events while closing application.
Without removing event_handler it is possible that native api will call
event with destroyed data. This fix is to prevent such situation
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I94d1fbb85ad47ca6dbcba6c56cd043521952860e
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Pawel Wasowski [Wed, 4 Apr 2018 16:33:30 +0000 (18:33 +0200)]
[Power] Prevent override of power level locked with Web API
Chromium used to override power level locked by Web API with its own
settings. The level set by Web API was not restored.
From now on, Chromium will not override power level lock, after receiving
"__DisableChromiumInternalPowerLock" message from the Web API
and will be able to control the locked power level,
after receiving "__EnableChromiumInternalPowerLock" message.
Change-Id: Ia14f873766e26bd02ae7eecb182c69e0b6af00e8
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Szymon Jastrzebski [Tue, 10 Oct 2017 06:56:25 +0000 (08:56 +0200)]
[Power] Refactoring module
Previous implementation depended partly on Deviced functions through the
dbus interface. Currently, the implementation uses only DeviceD Native API
(except the ReleaseBrightness and SetBrightness methods).
TheReleaseBrightness is still not wrapped into the Native C DeviceD API).
[Verification] TCT pass: A/M - 100%.
Change-Id: I03124c0d332bf03cd5481ac2b38c9e5c9a534063
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Fri, 6 Apr 2018 07:29:15 +0000 (09:29 +0200)]
[version] 2.20
Change-Id: I8c11218bf7cb61b4dcc530a205e7a4bfc1d94be9
Rafal Walczyna [Fri, 6 Apr 2018 07:19:43 +0000 (09:19 +0200)]
[Messaging] Fixed permissions of temporary file used for messaging
File created by mkstemp() gives permissions only for user,
that's why msg-service could not read from file and body of message was empty.
[Verification] 100% passrate on TM1
Change-Id: I290277294459ca96392b9a97adccded1664a426d
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Piotr Kosko [Tue, 3 Apr 2018 08:12:44 +0000 (10:12 +0200)]
[Download] Fixed unexpected result of fixing coverity issues
[Bug] When running on TV device, checking status of cellular network
returned not supported error, the checking status of cellular needed
to be moved into correct section instead of running this code in common
code part.
[Verification] TCT result - 100%
Change-Id: I6cb171034588b2616222bde4101a278c491fdc52
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 28 Mar 2018 11:06:10 +0000 (13:06 +0200)]
[version] 2.19
Change-Id: Ic8848b54eda46b98bd609e0d4254548a8c5beb04
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 28 Mar 2018 11:00:13 +0000 (11:00 +0000)]
Merge "[common] Coverity issues fix" into tizen_3.0
Piotr Kosko [Tue, 27 Mar 2018 12:59:02 +0000 (14:59 +0200)]
[common] Coverity issues fix
[Feature] Fixed coverity issues with below ids:
110914, 110006, 108656, 107626, 107387,
107077, 106006, 108993, 108297, 106912
Additionally fixed potential crash in download API -
in case of native function failure, the "success" response
is not trying to be build.
[Verification] 100% passrate for modules:
application, bluetooth, download, exif, filesystem, messaging-*
Change-Id: I8d9482501a7375962408186feaa5ecd1f0826b1d
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Rafal Walczyna [Tue, 27 Mar 2018 11:55:44 +0000 (13:55 +0200)]
[common] Fixing coverity issues
Issues: 110672, 108789, 108137, 107617,
106435, 112265, 112254, 107669, 105923
[Verification] 100% passrate in:
bookmark, calendar, contact, content, datacontrol,
filesystem, keymanager
Change-Id: Id667a94fe653f831a8cfdd70813c8ace91e1cf5d
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Lukasz Wojciechowski [Sat, 10 Mar 2018 02:25:34 +0000 (03:25 +0100)]
[Push] Prefix string type with namespace std
The patch fixes build break in Tizen:4.0:Unified.
The string type without std::string is not recognized by compiler.
Change-Id: I048bad0a1d71cb841965a84b2d11d2afb9c19eea
Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
(cherry picked from commit
a2c7a32a5fbc41e6bf20c891797c786e946628c9)
Piotr Kosko [Fri, 23 Mar 2018 11:10:31 +0000 (12:10 +0100)]
[version] 2.18
Change-Id: I171c24fc4170a519fef7fde45b4e223843cf33c0
Piotr Kosko [Fri, 23 Mar 2018 11:05:34 +0000 (11:05 +0000)]
Merge "[NFC] Fix isActivatedHandlerFunctions return values" into tizen_3.0
Rafal Walczyna [Fri, 23 Mar 2018 10:05:05 +0000 (11:05 +0100)]
[NFC] Fix isActivatedHandlerFunctions return values
Functions IsActivatedHandlerForCategory and IsActivatedHandlerForAID
always return false. After fix they work properly.
TCT tests needs fixing, after fix there will be 100% passrate.
Tested on TW1 tizen3.0
Change-Id: I9a4833d4073e512e9414e63325515ebfa8d6b8a4
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Pawel Kaczmarczyk [Mon, 19 Mar 2018 14:45:33 +0000 (15:45 +0100)]
[Systeminfo] Fix for incorrect USB storage capacity
USB_DEVICE has not been reporting correct capacity values
on TV profile. It was caused by different way of handling
reading storage properties.
[Fix]
Each storage type is treated in the same way when
getting information about storage's space.
[Verification] Tested in Chromium cosole
tct-systeminfo-tizen-tests passrate: 100%
tct-filesystem-tizen-tests passrate: 100%
Change-Id: I1d2a8a40a2cac18d5961a301bdd3e586cc3eedad
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Piotr Kosko [Mon, 26 Feb 2018 09:33:00 +0000 (10:33 +0100)]
[version] 2.17
Change-Id: I3bf56e2b79bff86daefb7b9c3c8d53b41d5ac22c
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Fri, 23 Feb 2018 13:50:55 +0000 (13:50 +0000)]
Merge "[NFC] Fix memory management problems" into tizen_3.0
Pawel Wasowski [Mon, 12 Feb 2018 11:14:15 +0000 (12:14 +0100)]
[NFC] Fix memory management problems
This commit prevents crashes, fixing 2 memory management problems:
1. user_data passed to nfc_tag_transceive was deleted twice
2. buffer argument of tagTransceiveCb was deleted inside the function;
according to Native NFC API reference: "buffer will be automatically
destroyed when the callback function returns. (Do not release buffer.)"
[Verification] NFCTag.transceive() function was tested in Chrome
DevTools console and worked fine.
Change-Id: I509c368d817b6663373ba0614af73402f8ad47a6
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Michal Bistyga [Thu, 8 Feb 2018 12:41:42 +0000 (13:41 +0100)]
[Calendar] Fixing multiple bugs in calendar API
3 bugs has been fixed:
1) User couldn't add new calendar to database
1a) Resolved by sending new object, no calendar through JSON
2) Calendar object was not updated with id got from native layer
2a) Resolved by returning id to js layer and...
2b) Changing setting its as result.id, not just a result
3) Every event has been set to calendar with id 0
3a) Resolved by utilizing not used calendarId attribute
[Verification]
verified in chrome console
tct-tests 100% passrate
Change-Id: I5edcf33d8dd753fc044d2b61677439145f4a73d1
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Piotr Kosko [Fri, 9 Feb 2018 08:52:54 +0000 (08:52 +0000)]
Merge "[Filesystem] Fix return on error in FileWriteString and FileWriteBytes" into tizen_3.0
Jakub Skowron [Wed, 7 Feb 2018 14:02:53 +0000 (15:02 +0100)]
[Filesystem] Fix return on error in FileWriteString and FileWriteBytes
Change-Id: I0377b1a7eaa60a1b5d50c759005d2c6063400332
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Piotr Kosko [Mon, 5 Feb 2018 12:48:16 +0000 (13:48 +0100)]
[SecureElement][NFC][Messageport] Fixing casting problems
[Bug] Casting double -> char should not be done directly.
[Verification] Passing values greater than 127 to API makes that
values are correctly translated.
TCT passrate 100%.
Change-Id: I786392fd3be2e7d0eb5211e224a25c8078f383e9
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Mon, 5 Feb 2018 06:49:29 +0000 (07:49 +0100)]
[version] 2.16
Change-Id: I7316b54e3c6ab3fe41b5e2e1ac6e4b1a9e7dfa35
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Mon, 5 Feb 2018 06:10:16 +0000 (06:10 +0000)]
Merge "[Bluetooth] Fixing undefined behaviour during cast" into tizen_3.0
Michal Bistyga [Fri, 2 Feb 2018 15:09:33 +0000 (16:09 +0100)]
[NFC] Fixing undefined behaviour during static_cast to unsigned char
Validation:
Automatic tests 100% pass rate
TODO manual tests
Change-Id: I9c15efc77c82f0f7e4019913b2bd02d0f8047bb1
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Michal Bistyga [Fri, 2 Feb 2018 11:37:08 +0000 (12:37 +0100)]
[Bluetooth] Fixing undefined behaviour during cast
Char is unsigned by default on ARM architecture. static_cast from double to unsigned char is undefined behaviour and complier overwritten any negative value with 0.
[Validation]
tests 100% pass rate
Change-Id: Iec39a3c17b18ec7aa4f020fe5de709d66fa426fd
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Piotr Kosko [Fri, 26 Jan 2018 10:04:18 +0000 (11:04 +0100)]
[version] 2.15
- version increased
- fixed minor style issue
Change-Id: I70a371ce7e6834bf73c413e19de37111168c9147
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Fri, 26 Jan 2018 09:01:47 +0000 (09:01 +0000)]
Merge "[Utils] Fix Long conversion (allow hex string value)" into tizen_3.0
Jakub Skowron [Wed, 17 Jan 2018 13:27:09 +0000 (14:27 +0100)]
[Utils] Fix Long conversion (allow hex string value)
Until now string "0x15" would be converted 0. This change affects
all numeric conversions which use _toLong.
According to https://www.w3.org/TR/WebIDL-1/#es-long value
should be initialized by ToNumber, which is defined in
https://tc39.github.io/ecma262/#sec-tonumber-applied-to-the-string-type
and allows value to be in form of HexIntegerLiteral.
Change-Id: Ib719ce8fd5beccc5947b761dc905c49ac0469490
Lukasz Bardeli [Thu, 25 Jan 2018 10:53:43 +0000 (11:53 +0100)]
[Download] Fix preventing crash. Prevent call callback twice
Add condition to prevent call some callback twice and modify body of methods
OnFinished, OnCanceled and OnFailed to prevent crash.
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I7d194b4d762a52f0281e22555bfd54caa3cb4579
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Rafal Walczyna [Thu, 25 Jan 2018 09:01:43 +0000 (10:01 +0100)]
[humanactivitymonitor] Fix crash when WRIST_UP event was called
[Verification] Tested with custom app - event fires properly
Auto test on TW2 - 100% passrate
Change-Id: I762a2a0950c4b17333f78b11eb320680f8ec1128
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Piotr Kosko [Thu, 18 Jan 2018 12:32:21 +0000 (13:32 +0100)]
[version] 2.14
Change-Id: I7b9924c14471bce00e2e5eaf607080c869ad92b1
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Thu, 18 Jan 2018 11:45:51 +0000 (11:45 +0000)]
Merge "[Filesystem] Remove unused Base64 and UTF-8 functions" into tizen_3.0
Piotr Kosko [Thu, 18 Jan 2018 11:45:14 +0000 (11:45 +0000)]
Merge "[Filesystem] Speed up conversion to octet in writeBytes" into tizen_3.0
Piotr Kosko [Thu, 18 Jan 2018 11:44:56 +0000 (11:44 +0000)]
Merge "[Filesystem] Write file performace improvement (binary data through UTF-8)" into tizen_3.0
Piotr Kosko [Thu, 18 Jan 2018 11:44:07 +0000 (11:44 +0000)]
Merge "[Filesystem] Read file performace improvement (binary data through UTF-8)" into tizen_3.0
Jakub Skowron [Wed, 17 Jan 2018 16:04:49 +0000 (17:04 +0100)]
[Filesystem] Remove unused Base64 and UTF-8 functions
removed: encodeString, decode, decodeString, getCodePoint,
_utf8_encode, _utf8_decode
Change-Id: I269cd71eb252e2f6ea9b266a50acde3f769db50e
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Jakub Skowron [Wed, 17 Jan 2018 14:43:31 +0000 (15:43 +0100)]
[Filesystem] Speed up conversion to octet in writeBytes
Do not use validateArgs to validate each value in array
Change-Id: I9ac59f59187c7f57a0213778d0f2552cb9de4538
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Jakub Skowron [Wed, 17 Jan 2018 12:46:16 +0000 (13:46 +0100)]
[Filesystem] Write file performace improvement (binary data through UTF-8)
Improve performance of write, writeBytes, writeBase64 by
pushing binary data through UTF-8 null-terminated string.
Byte 0x00 is encoded as U+0100.
Removed class FilesystemFile.
[Verification] TCT pass rate is 100%
tct-filesystem-tizen-tests
Change-Id: Iee5983a429ed484eb0fd6a6d35ea794d292de8de
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Jakub Skowron [Wed, 10 Jan 2018 06:54:35 +0000 (07:54 +0100)]
[Filesystem] Read file performace improvement (binary data through UTF-8)
Improve performance of readBytes, readBase64 by pushing binary data
through UTF-8 null-terminated string.
Byte 0x00 is encoded as U+0100.
Removed not used functions in FilesystemFile. Improved performance of
readAsText.
[Verification] TCT pass rate is 100%
tct-filesystem-tizen-tests
Change-Id: I41fe2f9c7855721b38ad4bbf268e8eb7851b10eb
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Rafal Walczyna [Wed, 17 Jan 2018 13:43:45 +0000 (14:43 +0100)]
[humanactivitymonitor] Fix timestamp in HumanActivityRecognitionData
[Verification] auto and manual tests which use this data pass
Change-Id: I8f174925147c561cfcf22590cc5d4b5abbbba506
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
(cherry picked from commit
f3123977c14bad5410ee36b520f07c4061d4fc3a)
Piotr Kosko [Tue, 16 Jan 2018 09:38:34 +0000 (10:38 +0100)]
[version] 2.13
Code format was also fixed
Change-Id: Iae0d214d3caeeb67cdbfe1938718863d70a15789
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Thu, 11 Jan 2018 08:23:10 +0000 (08:23 +0000)]
Merge "[NFC] Fix for passing wrong values to APDU response" into tizen_3.0
Arkadiusz Pietraszek [Mon, 8 Jan 2018 15:23:33 +0000 (16:23 +0100)]
[Filesystem] Fix to commit
ce958812096 to read 64 Kb and greater files
Commit
ce958812096 has introduced error in which only first 64 Kb of
text file was read.
[Verification] TCT pass rate is 100%
Automated tests has been run:
tct-archive-tizen-tests
tct-systeminfo-tizen-tests
tct-content-tizen-tests
tct-filesystem-tizen-tests
Change-Id: I266c839e78af9420bdad328e8fa4332bdc16b8a4