Stephane Delcroix [Mon, 18 Mar 2019 21:58:36 +0000 (22:58 +0100)]
[X] Allow empty property xaml-elements (#5550)
- fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/817710?src=WorkItemMention&src-action=artifact_link
- reverts #4582
David Ortinau [Mon, 18 Mar 2019 18:52:49 +0000 (13:52 -0500)]
[iOS,Shell] Fix tab bar style color alignment to match Android (#5075)
* Set the same TabBar color styles as Android
* unified on title color, made names consistent, and commented unused properties.
Stephane Delcroix [Mon, 18 Mar 2019 10:25:47 +0000 (11:25 +0100)]
[X] recover from memberaccessEx
- fixes #5589
Shane Neuville [Mon, 18 Mar 2019 09:27:22 +0000 (03:27 -0600)]
remove maps.design (#5583)
Shane Neuville [Sat, 16 Mar 2019 01:19:53 +0000 (19:19 -0600)]
remove left over sealed on Material Entry Renderer (#5586)
Rui Marinho [Sat, 16 Mar 2019 01:13:14 +0000 (01:13 +0000)]
[Android] Fix issue when Message is null on Android API19 (#5562)
* [Android] Fix issue when Message is null on Android API19
* added kitkat check and moved check to extension method
* - remove awaken for kit kat and just catch all NPE
* - remove using
Rui Marinho [Fri, 15 Mar 2019 21:45:17 +0000 (21:45 +0000)]
[Shell,Core] Add better exception messages for wrong or non existing content (#5566)
fixes #5081
Shane Neuville [Fri, 15 Mar 2019 21:43:04 +0000 (15:43 -0600)]
[Android] fix focus event on android and add UI Tests (#5528)
* fix focus event for material entry and add ui tests
* fix iOS
* - Focused
fixes #5509
Stephane Delcroix [Fri, 15 Mar 2019 00:42:54 +0000 (01:42 +0100)]
[X] resilient to unyped x:Name (#5552)
Allow the previewer to recover from an x:Name attribute on a element
with unresolved type.
- fixes #5546
- closes #5547
Rui Marinho [Thu, 14 Mar 2019 15:31:44 +0000 (15:31 +0000)]
[Controls] Only register AppCompact renderer if running in that context
Stephane Delcroix [Thu, 14 Mar 2019 08:21:19 +0000 (09:21 +0100)]
[X] resilience on markup (#5532)
let the previewer intercepts and recover from misformatted markups
- fixes #5508
- closes #5527
Samantha Houts [Wed, 13 Mar 2019 21:51:38 +0000 (14:51 -0700)]
[Housekeeping] Be more polite (#5539)
Andrei Nitescu [Wed, 13 Mar 2019 19:24:22 +0000 (21:24 +0200)]
Fix Map ItemsSource bp name (#5499)
Shane Neuville [Wed, 13 Mar 2019 16:03:32 +0000 (10:03 -0600)]
[Android] ensure scrollbar has been initialized (#5462)
* [Android] ensure scrollbar has been initialized
* fix comments
* Update Xamarin.Forms.ControlGallery.Android/CustomRenderers.cs
Pavel Yakovlev [Tue, 12 Mar 2019 23:58:05 +0000 (02:58 +0300)]
[UWP] added Win2D.uwp dependency to nuget (#5475)
fixes #5188
Akihiko Odaki [Fri, 22 Feb 2019 00:56:42 +0000 (09:56 +0900)]
[XamlC] Identify generic instance types correctly when importing ctor (#5309)
The old implementation fails to identify generic instance types for typed
binding getter, whose type is:
System.Func`2<TSource, ValueTuple<TProperty, bool>>
This fixes the issue by taking generic arguments into account.
Tim Barham [Tue, 12 Mar 2019 21:36:12 +0000 (07:36 +1000)]
Fix NamedSize in Previewer (#5496)
In the previewer, ConvertTextAppearanceToSize() returns -0.5 for all values. Return default value if we get a size of 0 or less.
Shane Neuville [Mon, 11 Mar 2019 20:45:38 +0000 (14:45 -0600)]
Fix up Sandbox to work with previewer and add android material reference in (#5513)
* fix sandbox to work with previewer
* small page fixes
Stephane Delcroix [Mon, 11 Mar 2019 13:38:34 +0000 (14:38 +0100)]
[X] recover from missing markup type (#5485)
- fixes #5484
Samantha Houts [Thu, 7 Mar 2019 22:44:10 +0000 (14:44 -0800)]
[Maps} move design dll to the design folder (#5481)
- fixes #5472
Shane Neuville [Tue, 5 Mar 2019 18:07:57 +0000 (11:07 -0700)]
Uwp restart uitests on crash (#5420)
* [UWP] if a UI tests crashes the UWP window this will restart the window so all the rest of the tests can run
* simplify
E.Z. Hart [Tue, 5 Mar 2019 18:06:27 +0000 (11:06 -0700)]
[iOS] Check new element before creating placeholder label (#5432)
* Check new element before creating placeholder label
* additional checks
* create placeholder once
Shane Neuville [Mon, 4 Mar 2019 23:43:22 +0000 (16:43 -0700)]
[Android] remove android specific target (#5442)
* [Android] get rid of specific android targets
* change to AndroidApplication
* remove before/after targets
* MonoAndroid
Shane Neuville [Sat, 2 Mar 2019 03:15:08 +0000 (20:15 -0700)]
fix changed apis (#5426)
* fix changed apis
* increment language version
* bring some back
* update font
* VisualElement fixes
fixes #4644
fixes #5170
Samantha Houts [Fri, 1 Mar 2019 18:06:34 +0000 (10:06 -0800)]
Merge branch '3.5.0' into 3.6.0
Samantha Houts [Fri, 1 Mar 2019 17:59:21 +0000 (09:59 -0800)]
Reverts "[Xaml] require escaping curly braces (#4723)" and "[X] only require escaping if starts with '{' (#5169)" (#5424)
* Revert "[X] only require escaping if starts with '{' (#5169)"
This reverts commit
cd73391c3a2d7ff60a95449cac255c1425e81a43.
* Revert "[Xaml] require escaping curly braces (#4723)"
This reverts commit
6753ace40e68f8aa6d45eefa90117f5650984c6f.
* Make sure parsing doesn't fail when there *are* curly braces now
Pavel Yakovlev [Fri, 1 Mar 2019 17:22:18 +0000 (20:22 +0300)]
[iOS] Fix tapping a ViewCell after close ContextActionMenu (#5425) fixes #4987
Samantha Houts [Fri, 1 Mar 2019 02:10:53 +0000 (18:10 -0800)]
Merge branch '3.5.0' into 3.6.0
Stephane Delcroix [Fri, 1 Mar 2019 00:17:13 +0000 (01:17 +0100)]
[X] bubble markup exception to previewer (#5411)
- fixes #5407
E.Z. Hart [Thu, 28 Feb 2019 20:02:49 +0000 (13:02 -0700)]
Fix iOS EmptyView crash; properly handle EmptyView swapping (#5353)
Stephane Delcroix [Thu, 28 Feb 2019 19:41:34 +0000 (20:41 +0100)]
[X] allow previewer fallback on rootnode (#5413)
* [X] allow previewer fallback on rootnode
- fixes #5410
* additional test case
Shane Neuville [Thu, 28 Feb 2019 18:57:20 +0000 (11:57 -0700)]
[Android] Remove changes to IVisualElementRenderer so it remains backwards compatible (#5398)
* return IVisualElementRenderer to previous state
* set to internal
kingces95 [Thu, 28 Feb 2019 02:32:57 +0000 (16:32 -1000)]
previewer; PageRenderer trap for missing bg image (#5342)
* previewer; PageRenderer trap for missing bg image
* previewer; PageRenderer trap for missing bg image
* fix macOS; remove ext for macOS
fixes #5300
Samantha Houts [Thu, 28 Feb 2019 02:21:59 +0000 (18:21 -0800)]
Merge branch '3.5.0' into 3.6.0
Samantha Houts [Thu, 28 Feb 2019 02:08:47 +0000 (18:08 -0800)]
[iOS, Android] Prevent NREs in ScrollViews (#5383)
* Add null checks on new code paths added in #4522
fixes #5161
* Fix cast...
Fixes #5247
E.Z. Hart [Thu, 28 Feb 2019 02:06:48 +0000 (19:06 -0700)]
Allow SelectableItemsViewRenderer/Adapted to deselect ViewHolders not in the RecyclerView's child collection (#5358)
Fixes #5078
Stephane Delcroix [Thu, 28 Feb 2019 01:58:58 +0000 (02:58 +0100)]
[X] more conv exception, bubble to previewer (#5400)
Catch more exception cases, make sure the previewer can recover from them
- fixes #5397
Pavel Yakovlev [Thu, 28 Feb 2019 01:49:11 +0000 (04:49 +0300)]
[Android, iOS] added re-measure of TimePicker after change value (#4999)
ShaneN [Thu, 28 Feb 2019 01:19:57 +0000 (18:19 -0700)]
[UITests] remove extra reference
Shane Neuville [Thu, 28 Feb 2019 01:04:52 +0000 (18:04 -0700)]
[Android] move android renderers to separate nuget (#5405)
* [Android] move renderers to separate nuget
* additional android dependency
* rebase with material changes
* add android to material check
* simplify assembly info
* - add context to Init for future cases
Shane Neuville [Wed, 27 Feb 2019 23:48:45 +0000 (16:48 -0700)]
[Visual] Visual tidy (#5356)
* [Visual] remove visual flag and tidy up code
* - added basic loading ui test
* change material namespaces to be Xamarin.Forms.Material.<Platform>
* api 19 fixes
* fix casing on resources
Dan Siegel [Wed, 27 Feb 2019 21:20:14 +0000 (13:20 -0800)]
directly load specified Font Family or other valid PostScript Font Name fixes #5372 (#5373)
Matthew Leibowitz [Wed, 27 Feb 2019 21:03:40 +0000 (23:03 +0200)]
Fix the issue when building on a mac (#5406)
- mac should not build this assembly, but as it has to do so, exclude everything
Andrei [Wed, 27 Feb 2019 21:02:49 +0000 (00:02 +0300)]
fix https://github.com/xamarin/Xamarin.Forms/issues/5346 (#5379)
Shane Neuville [Wed, 27 Feb 2019 00:58:40 +0000 (17:58 -0700)]
[UWP] fix so tests are compatible with UWP (#4984)
* [UWP] fix so tests are compatible with UWP
* [UWP] when UI tests run don't load issues list
* [uwp] add preload of tests back in
* added UWP Ignore
Shane Neuville [Tue, 26 Feb 2019 19:46:48 +0000 (12:46 -0700)]
[Visual] Material Editor (#5345)
* [Material] Visual
* - gallery and simplify android renderers
* Update Xamarin.Forms.Material.iOS/MaterialEditorRenderer.cs
* Update Xamarin.Forms.Platform.Android/Material/MaterialEditorRenderer.cs
* wire up done and fix ph bug
* - ios fix auto sizing issues
* fix NRE
* - Android: fix bounce and IsreadOnly
- iOS: fix IsReadonly and sizing issue
* - fix editor
* Fix ios Editor to shrink when lines are deleted
* Update Xamarin.Forms.Material.iOS/MaterialMultiLineTextField.cs
* - formatting fixes
Stephane Delcroix [Tue, 26 Feb 2019 19:09:16 +0000 (20:09 +0100)]
[previewer] resilience on createvalue (#5369)
- fixes #5171
Stephane Delcroix [Tue, 26 Feb 2019 19:07:17 +0000 (20:07 +0100)]
[X] wrap typeconverter exceptions in XPE (#5388)
- fixes #5378
Shane Neuville [Tue, 26 Feb 2019 17:38:10 +0000 (10:38 -0700)]
[Visual] Check if assembly is dynamic before calling GetExportedTypes (#5389)
* check if assembly is dynamic
* add filenotfound catch
Shane Neuville [Tue, 26 Feb 2019 17:22:48 +0000 (10:22 -0700)]
[Android] add build error if TargetFramework is too low (#5350)
* [Android] add build error if TargetFramework is to low
* change to Corecompile
* add disable condition
Matthew Leibowitz [Tue, 26 Feb 2019 13:59:29 +0000 (15:59 +0200)]
Visual equality (#5380)
No one gets to go to the top, not even the great Material Design. All pages are equal, and are listed alphabetically.
Shane Neuville [Mon, 25 Feb 2019 20:54:02 +0000 (13:54 -0700)]
[Visual] Visual xaml and Visual registrations (#5304)
* [visual] add intellisense popups for visual
* Add visual registrations into type converter
* combine VisualMarker and VisualRendererMarker
* remove visual from class name for intellisense
* set Match Parent to internal
* Remove register code and just scan assemblies
* [Visual] Add Visual Attribute and some additional attribute checks
* remove registrar changes
* renamed to specific VisualTypes
* - move check up to LINQ statement
* Make sure the other platforms can create visuals
* fix renderer names
* move stepper renderer
* rename converter
Jeremy Marcus [Mon, 25 Feb 2019 19:44:00 +0000 (14:44 -0500)]
Update BindableLayout.cs to fix #5213 (#5243)
- fixes #5213
* Add Test for BindableLayout RemoveAll
* Update BindableLayout.cs to fix RemoveAll exception
* Missing using statements
Stephane Delcroix [Mon, 25 Feb 2019 07:20:29 +0000 (08:20 +0100)]
Merge branch '3.5.0' into 3.6.0
Shane Neuville [Mon, 25 Feb 2019 03:21:39 +0000 (20:21 -0700)]
[Visual] Material Pickers (#5194)
* [Material] Change Picker EditText fields to Material
* [Visual] add material placeholder properties
* - add ios placeholder changes
* - remove placeholder apis
* - shrink entry fields when they have no place holder
* - invalidate measure
* - remove marshalling
Pavel Yakovlev [Sun, 24 Feb 2019 18:00:31 +0000 (21:00 +0300)]
[Android CollectionView] Fixes crash when ItemSource Changed (#5146)
Pavel Yakovlev [Sat, 23 Feb 2019 09:30:47 +0000 (12:30 +0300)]
[Android iOS Visual] fixes background in ActivityIndicator (#5283)
* [Android, iOS Visual] fixes background in AcrivityIndicator
* [Android] reduce nesting layouts
* [Android] simplification
* Some calculations for iOS
* [Android] removed padding, added size limit
[iOS] fixes stroke width
* [iOS] default size as in Android
* Use the Android ratio of 10 instead of the spec of 12
* [Android] fix API23
* [iOS] fix unexpected padding
* [Android] fixes padding in API 23 -- IsRunning -- added gallery
* [Android] fixes start with IsRunning = false
* [Android] again fix isRunning
* address comments
Matthew Leibowitz [Fri, 22 Feb 2019 19:51:45 +0000 (21:51 +0200)]
[Material] [Android, iOS] Materializing the stepper (#5027)
* [Android] [Material] Refactored the Stepper on Android #5011
- reuse code between default and material
- added material stepper
* [Android] [Material] Using the "Fast" renderer style for the stepper #5011
- switched the button style to the outlined buttons
* [Android] [Material] Adding the tab stops support (#5000)
* [Android] [Material] Switching back to a traditional renderer for now to get tabstops working
* [Material] [iOS] Added a Material stepper for iOS
* [Material] [Android, iOS] Addressed the PR feedback
* [Material] Remove private
* Update MaterialStepperRenderer.cs
* Update StepperRendererManager.cs
* Fixed the merge issues
* add steppers to visual gallery
* The material stepper buttons now resize to fit the available space.
* Update Xamarin.Forms.Controls/ControlGalleryPages/VisualGallery.xaml
Co-Authored-By: mattleibow <mattleibow@live.com>
* [Material] [Stepper] Don't set the background color for steppers
- we still need to decide on the logic behind the coloring of outline buttons
* Fixed the Android accessibility
* Change UI tests to not use a Text search for locating stepper controls
Shane Neuville [Fri, 22 Feb 2019 15:29:25 +0000 (08:29 -0700)]
[Material] rename iOS assembly to be non platform specific (#5332)
* [Material] rename iOS assembly
* fix title and Internals Visible To
Stephane Delcroix [Fri, 22 Feb 2019 00:59:48 +0000 (01:59 +0100)]
[CSS] fix mapping for vertical-align (#5275)
Rui Marinho [Fri, 22 Feb 2019 00:23:32 +0000 (00:23 +0000)]
[Android] Fix SearchBar renderer height on API24 (#5329)
Shane Neuville [Thu, 21 Feb 2019 20:22:39 +0000 (15:22 -0500)]
[Android] Include default proguard file so user doesn't have to create rules for XF (#5143)
* [2709] Add default proguard config file
* add proguard.cfg file to nuspec
Tim Barham [Thu, 21 Feb 2019 01:24:18 +0000 (11:24 +1000)]
Fix NRE in Android ResourceManager when reference resource in Previewer (#5331)
Fixes part of #5300
(cherry picked from commit
fb59591580ea474e7f48e5941854fd790dc5a8cb)
Andrei Nitescu [Tue, 19 Feb 2019 14:55:19 +0000 (16:55 +0200)]
[iOS] Fixed updating Label TextDecorations when no Text is set (#5013)
- fixes #5003
- fixes #5149
- fixes #5258
Stephane Delcroix [Tue, 19 Feb 2019 14:26:30 +0000 (15:26 +0100)]
[XamlC] compiled binding to int indexers (#5271)
- fixes #5254
Stephane Delcroix [Tue, 19 Feb 2019 14:25:51 +0000 (15:25 +0100)]
[XamlC] avoid cast exception on overriden members (#5269)
avoid InvalidCastException if an event is overriden with the new keyword
to a bindableproperty. Kids, DO NOT EVER DO THIS AT HOME.
- fixes #5256 for XamlC
Matthew Leibowitz [Tue, 19 Feb 2019 12:36:59 +0000 (14:36 +0200)]
[iOS] Fix the layout of the button (#5221) * fixes #5160
- it appears that iOS has a nice little delay when setting the title to the layout
Tim Barham [Tue, 19 Feb 2019 11:34:26 +0000 (21:34 +1000)]
Fix NRE in Android ResourceManager when reference resource in Previewer (#5305)
Fixes part of #5300
Stephane Delcroix [Tue, 19 Feb 2019 10:17:02 +0000 (11:17 +0100)]
Add (passing) test for #5290
Stephane Delcroix [Mon, 18 Feb 2019 11:49:11 +0000 (12:49 +0100)]
Merge branch '3.5.0' into 3.6.0
Stephane Delcroix [Thu, 14 Feb 2019 19:08:16 +0000 (20:08 +0100)]
[C] Binding null on nullable (#5255)
* fixes #5274
bindings should allow null for nullable valuetypes!
* [C] Binding null on nullable
@kicsiede's fix for #5242, plus unit test, targetted to 3.6.0
- closes #5242
Shane Neuville [Mon, 18 Feb 2019 11:31:55 +0000 (04:31 -0700)]
[iOS] add single parameter constructor back (#5281) * fixes #5278
Shane Neuville [Mon, 18 Feb 2019 11:30:08 +0000 (04:30 -0700)]
Setup sandbox app inside our project (#5264)
* [Visual] Material Pickers and setup sandbox app
* Fixed the ambiguous types for UWP
E.Z. Hart [Mon, 18 Feb 2019 11:21:10 +0000 (04:21 -0700)]
Implement FlowDirection propagation to items in CollectionView (#5051) * fixes #4583
* Implement FlowDirection propagation to items in CollectionView; fixes #4583
* Run logical child detachment via CellDisplayingEnded
* Fix Visual propagation on iOS
* Fix Visual propagation on Android
* Fix rebase error
Rui Marinho [Mon, 18 Feb 2019 11:18:50 +0000 (11:18 +0000)]
Collectionview uitest (#5231)
* [UITests] Add basic CollectionView tests
* [UITests] Enable uitests ObservableCollectionGallery
* [UITests] Update itemssource
* Update Xamarin.Forms.Controls/GalleryPages/CollectionViewGalleries/CollectionViewGallery.cs
Co-Authored-By: rmarinho <me@ruimarinho.net>
Stephane Delcroix [Thu, 14 Feb 2019 19:08:16 +0000 (20:08 +0100)]
[C] Binding null on nullable (#5255)
* fixes pull #4453
bindings should allow null for nullable valuetypes!
* [C] Binding null on nullable
@kicsiede's fix for #5242, plus unit test, targetted to 3.6.0
- closes #5242
Stephane Delcroix [Thu, 14 Feb 2019 09:54:30 +0000 (10:54 +0100)]
Add AllowMultiple=true to QueryPropertyAttribute (#5180) (#5251)
In the process of building a demo app (https://github.com/matthewrdev/xamarin-forms-4), I discovered that I could not apply multiple parameters; doing so would cause a compile-time error.
The usage of this property in ShellContent, specifically in ApplyQueryAttributes, indicates that the intended behaviour is to allow users to specify multiple URL arguments that will be applied onto the page. Changing AllowMultiple to true fixes this.
For reference, when AllowMultiple is not explicitly set, it's default value is false. See: https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/concepts/attributes/attributeusage.
Samantha Houts [Thu, 14 Feb 2019 00:55:00 +0000 (16:55 -0800)]
Merge branch '3.5.0' into 3.6.0
Rui Marinho [Thu, 14 Feb 2019 00:22:40 +0000 (00:22 +0000)]
[Android] Fix ImageRenderer URI (#5241)
* ignore check if imageview isn't set
* [Controls] Add repo case for #5172
* [Controls] Use xf github image url
fixes #5172
Yun Chen [Wed, 13 Feb 2019 23:42:11 +0000 (12:42 +1300)]
apply Remove suggestion bar in iOS picker (#4634)
fixes #4629
Matthew Leibowitz [Wed, 13 Feb 2019 23:36:55 +0000 (01:36 +0200)]
[Material] [Android, iOS] Added Slider and ProgressBar (#5209)
* [Android Material] Linear Progress Indicator (#5079)
Merging into the material "slider" / "progress" bar branch so that we can share some code as they are the same control
* [Material] [Slider, ProgressBar] Updated the progress bard and added the slider
* Renamed the gallery
fixes #5008
fixes #5079
fixes #5018
Andrei Nitescu [Wed, 13 Feb 2019 23:33:14 +0000 (01:33 +0200)]
Fixed passing container (#5158)
fixes #5156
Samantha Houts [Wed, 13 Feb 2019 23:21:31 +0000 (15:21 -0800)]
Revert "[Android] fixes issue content set after an await is not visible (#4861)" (#5245)
This reverts commit
bf0733129dda78349c14d7cb6ae39cd61ebe2288.
Stephane Delcroix [Wed, 13 Feb 2019 21:41:45 +0000 (22:41 +0100)]
Backport some 3.6 previewer changes to 3.5 (#5227)
* [X] add callback for previewer on failing ctor (#5101)
Add a callback when object instantiation or creation fails, so the
previewer can replace it by an educated guess
* Allow the previewer to use design flag on RDs (#5096)
* [Xaml] Better handling of exception on properties (#5099)
Allow the previewer to recover and continue on throwing property setters
or BindableProperties.
* [Previewer] Fallback for factorymethod not found (#5139)
- fixes #5138
* [previewer] more info to the callback (#5155)
Shane [Wed, 13 Feb 2019 15:31:49 +0000 (10:31 -0500)]
Merge branch '3.5.0' into 3.6.0
E.Z. Hart [Tue, 12 Feb 2019 20:27:00 +0000 (13:27 -0700)]
Reinstate and obsolete IPlatform, et al (#5181)
* Reanimate IPlatform and mark it obsolete
* Reinstate IPlatform everywhere in case someone is using it or subscribing to
PlatformSet
* Revert breaking parameter name change
* Obsolete IsEnabledPropertyName
* Reinstate and obsolete Realized property and constructor
* Escape string format so solution will build
* Fix previewer reflection test
* Fix interface on Tizen/TizenPlatformServices
* Update Xamarin.Forms.Core/Element.cs
Co-Authored-By: hartez <hartez@users.noreply.github.com>
Shane Neuville [Tue, 12 Feb 2019 13:37:26 +0000 (06:37 -0700)]
Missing visual falling not falling back to registered default renderer (#5179)
Gerald Versluis [Tue, 12 Feb 2019 13:25:22 +0000 (14:25 +0100)]
Fixed opening of multiple picker dialogs on Android (#4911) fixes #4909
Shane Neuville [Tue, 12 Feb 2019 13:05:51 +0000 (06:05 -0700)]
Cake build script (#5074)
* cake
* cake
* android fix
* fix clean
* version fix
* android deploy updates
* move to cake tools
* add clean bin obj back in
* git versioning
* fix vs mac target
* vs mac fixes
* remove default config on sh
* add UAP pdbs
Stephane Delcroix [Mon, 11 Feb 2019 08:15:42 +0000 (09:15 +0100)]
Merge branch '3.5.0' into 3.6.0
Stephane Delcroix [Fri, 8 Feb 2019 19:32:35 +0000 (20:32 +0100)]
[X] only require escaping if starts with '{' (#5169)
- fixes #5152
E.Z. Hart [Fri, 8 Feb 2019 12:18:44 +0000 (05:18 -0700)]
[iOS] CollectionView multi-item Add/Remove/Replace/Move (#5055)
* Split file by class
* Handle multiple moving items on iOS
* Make replacer indexes more intuitive
* Handle multi-item replacement on iOS
* More robust Remove implementation
* Make Replace test indexes include the end index; don't determine startIndex when removing
unless necessary.
Stephane Delcroix [Thu, 7 Feb 2019 20:39:38 +0000 (21:39 +0100)]
[previewer] more info to the callback (#5155)
Stephane Delcroix [Thu, 7 Feb 2019 16:30:41 +0000 (17:30 +0100)]
[Previewer] Fallback for factorymethod not found (#5139)
- fixes #5138
E.Z. Hart [Wed, 6 Feb 2019 20:24:57 +0000 (13:24 -0700)]
Prevent snap helpers from snapping until the user interacts with scro… (#5065)
* Prevent snap helpers from snapping until the user interacts with scrolling; fixes #4935
* Lower sensitivity for snapping to kick in on Android
* Remove underscore in method name
Stephane Delcroix [Tue, 5 Feb 2019 08:12:25 +0000 (09:12 +0100)]
[Xaml] don't use context before checking it's not null (#5124)
Rui Marinho [Mon, 4 Feb 2019 20:01:49 +0000 (20:01 +0000)]
[Controls] Ignore random failures on AppCenter
Stephane Delcroix [Mon, 4 Feb 2019 14:45:49 +0000 (15:45 +0100)]
[Xaml] Better handling of exception on properties (#5099)
Allow the previewer to recover and continue on throwing property setters
or BindableProperties.
Rui Marinho [Mon, 4 Feb 2019 13:02:23 +0000 (13:02 +0000)]
[Build] Use wildcards on triggers (#5126)
E.Z. Hart [Mon, 4 Feb 2019 12:38:38 +0000 (05:38 -0700)]
[iOS] Implement ItemSizingStrategy hint property for CollectionView (#5094)
* Add ItemSizingStrategy to CollectionView in Core;
Create test harness for changing ItemSizingStrategy;
Handle ItemSizingStrategy and ItemSizingStrategy changes on iOS;
* Update test bed to better illustrate changes
* No need for DetermineCellSize to be internal
* Conserve precious bits by removing `private` modifier
partially implements #3172