Lei Zhang [Thu, 2 Jan 2020 03:39:28 +0000 (22:39 -0500)]
[mlir][spirv] Fix links in docs and update dialect docs
Summary:
This commit fixes links to code directories and uses doc links on
mlir.llvm.org where possible. The docs in TableGen dialect definition
is also updated to reflect recent developments.
Reviewed By: mravishankar
Differential Revision: https://reviews.llvm.org/D72051
Craig Topper [Thu, 2 Jan 2020 03:06:05 +0000 (19:06 -0800)]
[X86] Add x86_regcallcc calling convention to function declaration recently added in a test.
The callsite had the calling convention, but not the function itself.
Nico Weber [Thu, 2 Jan 2020 03:06:31 +0000 (22:06 -0500)]
[gn build] (manually) merge
68a235d07f9e70
Brian Gesiak [Thu, 2 Jan 2020 01:24:14 +0000 (20:24 -0500)]
[Coroutines] const-ify internal helpers (NFC)
Several helpers internal to llvm/Transforms/Coroutines do not use
'const' for parameters that are not modified. Add const where possible.
Craig Topper [Thu, 2 Jan 2020 02:14:13 +0000 (18:14 -0800)]
[X86] Add test cases for regcall function that takes a long double as a parameter, but does not return a long double.
I believe we are incorrectly doing some FP stack manipulations
after the call.
Craig Topper [Thu, 2 Jan 2020 01:30:05 +0000 (17:30 -0800)]
[RegisterClassInfo] Use SmallVector::assign instead of resize to make sure we erase previous contents from all entries of the vector.
resize only writes to elements that get added. Any elements that
already existed maintain their previous value. In this case we're
trying to erase cached information so we should use assign which
will write to every element.
Found while trying to add new tests to an existing X86 test and
noticed register allocation changing in other functions.
Brian Gesiak [Thu, 2 Jan 2020 01:07:34 +0000 (20:07 -0500)]
[Coroutines] Rename "legacy" passes (NFC)
A series of patches beginning with https://reviews.llvm.org/D71898
propose to add an implementation of the coroutine passes to the new pass
manager. As part of these changes, the coroutine passes that implement
the legacy pass manager interface are renamed, to `<PassName>Legacy`.
This mirrors similar changes that have been made to many other passes in
LLVM as they've been transitioned to support both old and new pass
managers.
This commit splits out the renaming portion of that patch and commits it
in advance as an NFC (no functional change intended) commit. It renames:
* `CoroEarly` => `CoroEarlyLegacy`
* `CoroSplit` => `CoroSplitLegacy`
* `CoroElide` => `CoroElideLegacy`
* `CoroCleanup` => `CoroCleanupLegacy`
Saleem Abdulrasool [Thu, 2 Jan 2020 00:57:00 +0000 (16:57 -0800)]
build: make `LLVM_ENABLE_ZLIB` a tri-bool for users
Treat the flag `LLVM_ENABLE_ZLIB` as a tri-bool, `FORCE_ON` being `ON`,
and `ON` being an auto-detect. This is needed as many of the builders
enable the flag without having zlib available.
Saleem Abdulrasool [Wed, 1 Jan 2020 23:01:04 +0000 (15:01 -0800)]
build: reduce CMake handling for zlib
Rather than handling zlib handling manually, use `find_package` from CMake
to find zlib properly. Use this to normalize the `LLVM_ENABLE_ZLIB`,
`HAVE_ZLIB`, `HAVE_ZLIB_H`. Furthermore, require zlib if `LLVM_ENABLE_ZLIB` is
set to `YES`, which requires the distributor to explicitly select whether
zlib is enabled or not. This simplifies the CMake handling and usage in
the rest of the tooling.
Fangrui Song [Wed, 1 Jan 2020 23:55:14 +0000 (15:55 -0800)]
[mlir] Fix -Wrange-loo-analysis warnings
for (const auto &x : llvm::zip(..., ...))
->
for (auto x : llvm::zip(..., ...))
The return type of zip() is a wrapper that wraps a tuple of references.
> warning: loop variable 'p' is always a copy because the range of type 'detail::zippy<detail::zip_shortest, ArrayRef<long> &, ArrayRef<long> &>' does not return a reference [-Wrange-loop-analysis]
Fangrui Song [Wed, 1 Jan 2020 23:28:48 +0000 (15:28 -0800)]
[lld] Fix -Wrange-loop-analysis warnings
One instance looks like a false positive:
lld/ELF/Relocations.cpp:1622:14: note: use reference type 'const std::pair<ThunkSection *, uint32_t> &' (aka 'cons
t pair<lld::elf::ThunkSection *, unsigned int> &') to prevent copying
for (const std::pair<ThunkSection *, uint32_t> ts : isd->thunkSections)
It is not changed in this commit.
Alexandre Ganea [Wed, 1 Jan 2020 22:23:06 +0000 (17:23 -0500)]
[polly][Support] Un-break polly tests
Previously, the polly unit tests were stuck in a infinite loop.
There was an edge case in StringRef::count() introduced by
9f6b13e5cce96066d7262d224c971d93c2724795, where an empty 'Str' would cause the function to never exit.
Also fixed usage in polly.
Alexandre Ganea [Wed, 1 Jan 2020 22:05:16 +0000 (17:05 -0500)]
[mlir] Fix compilation warnings
Fixes:
- (MSVC) F:\llvm-project\mlir\lib\Dialect\Linalg\Analysis\DependenceAnalysis.cpp(103): warning C4551: function call missing argument list
- (Clang) tools\mlir\lib\Dialect\SPIRV\SPIRVCanonicalization.inc(232,1): warning: unused function 'populateWithGenerated' [-Wunused-function]
Alexandre Ganea [Tue, 31 Dec 2019 19:04:29 +0000 (14:04 -0500)]
[mlir] Fix linking with LLD
The issue is that /WHOLEARCHIVE is interpreted differently in LLD, which needs the same exact path as the .lib; whereas link.exe can take the library name, withoutout a path or extension, if that was already supplied on the cmd-line. I'll write a follow-up patch to fix the issue in LLD.
Alexandre Ganea [Tue, 31 Dec 2019 19:00:31 +0000 (14:00 -0500)]
[mlir] Fix warnings when compiling with Clang 9.0
Fixes: warning: comparison of integers of different signs: 'const unsigned int' and '(anonymous namespace)::OperationPrinter::(anonymous enum at F:\llvm-project\mlir\lib\IR\AsmPrinter.cpp:1444:3)' [-Wsign-compare]
Saleem Abdulrasool [Wed, 1 Jan 2020 22:19:41 +0000 (14:19 -0800)]
tests: XFAIL/UNSUPPORTED tests on Windows
Now that we are building the python bindings on Windows once more, the
extended testsuite is running. Mark a few failing tests and skip a few
tests which hang. This should at least bring the bot back to green
without reverting the Python changes which are an improvement for the
build system and enable another ~35% of the test suite which was
previously disabled.
Nikita Popov [Wed, 1 Jan 2020 19:09:40 +0000 (20:09 +0100)]
[InstCombine] Preserve inbounds when merging with zero-index GEP (PR44423)
This addresses https://bugs.llvm.org/show_bug.cgi?id=44423.
If one of the GEPs is inbounds and the other is zero-index,
we can also preserve inbounds.
Differential Revision: https://reviews.llvm.org/D72060
Raphael Isemann [Wed, 1 Jan 2020 21:42:25 +0000 (22:42 +0100)]
[lldb][NFC] Simplify CompilerType constructors/destructors and fix unused variable warning
CompilerType has no virtual functions and no statements in its constructors,
so we can simplify this code. This also allows Clang to emit unused variable warnings
for CompilerType, so I also removed one unused variable that otherwise causes -Werror
builds to fail.
Mark de Wever [Wed, 1 Jan 2020 21:19:18 +0000 (22:19 +0100)]
Revert "Adds -Wrange-loop-analysis to -Wall"
The sanitizer-x86_64-linux buildbot failed to build lld with -Werror.
This reverts commit
d8117542ac57f6051674ca70ea14c0e0d7d9b046.
Nikita Popov [Wed, 1 Jan 2020 19:09:40 +0000 (20:09 +0100)]
[InstCombine] Fix incorrect inbounds on GEP of GEP (PR44425)
This fixes https://bugs.llvm.org/show_bug.cgi?id=44425. We need to
drop inbounds if one of the GEPs is not inbounds. This was already
done when creating a new GEP, but not when modifying in place.
Differential Revision: https://reviews.llvm.org/D72059
Lorenzo Casalino [Wed, 1 Jan 2020 19:53:16 +0000 (19:53 +0000)]
[MachineScheduler] improve reuse of 'releaseNode'method
The 'SchedBoundary::releaseNode' is merely invoked for releasing the Top/Bottom root nodes.
However, 'SchedBoundary::releasePending' uses its same logic to check if the Pending queue
has any releasable SUnit.
It is possible to slightly modify the body of the two, allowing re-use of the former ('releaseNode')
in the latter.
Patch by Lorenzo Casalino <lorenzo.casalino93@gmail.com>
Reviewers: MatzeB, fhahn, atrick
Reviewed By: fhahn
Differential Revision: https://reviews.llvm.org/D65506
Nikita Popov [Wed, 1 Jan 2020 19:27:20 +0000 (20:27 +0100)]
[InstCombine] Add tests for PR44423 and PR44425; NFC
Nikita Popov [Wed, 1 Jan 2020 19:25:13 +0000 (20:25 +0100)]
[InstCombine] Regenerate test checks; NFC
Nikita Popov [Wed, 1 Jan 2020 10:15:13 +0000 (11:15 +0100)]
[InstCombine] Add tests for sub nuw of geps; NFC
Tests for PR44419.
Craig Topper [Wed, 1 Jan 2020 18:29:09 +0000 (10:29 -0800)]
[X86] Call SimplifyMultipleUseDemandedBits from combineVSelectToBLENDV if the condition is used by something other than select conditions.
We might be able to bypass some nodes on the condition path.
Differential Revision: https://reviews.llvm.org/D71984
Mark de Wever [Wed, 1 Jan 2020 16:23:18 +0000 (17:23 +0100)]
Adds -Wrange-loop-analysis to -Wall
This makes the range loop warnings part of -Wall.
Fixes PR32823: Warn about accidental coping of data in range based for
Differential Revision: https://reviews.llvm.org/D68912
Mark de Wever [Wed, 1 Jan 2020 16:23:20 +0000 (17:23 +0100)]
Improve Wrange-loop-analyses for rvalue reference
The Wrange-loop-analyses warns if a copy is made. Suppress this warning when
a temporary is bound to a rvalue reference.
While fixing this issue also found a copy-paste error in test6, which is also
fixed.
Differential Revision: https://reviews.llvm.org/D71806
Mark de Wever [Wed, 1 Jan 2020 16:23:19 +0000 (17:23 +0100)]
Adds fixit hints to the -Wrange-loop-analysis
Differential Revision: https://reviews.llvm.org/D68913
Mark de Wever [Wed, 1 Jan 2020 16:23:21 +0000 (17:23 +0100)]
[NFC] Fixes -Wrange-loop-analysis warnings
This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall.
Differential Revision: https://reviews.llvm.org/D71857
Raphael Isemann [Wed, 1 Jan 2020 17:47:44 +0000 (18:47 +0100)]
[lldb][NFC] Make some checks more readable in Variable::PrivateAutoComplete
David Green [Mon, 30 Dec 2019 13:01:09 +0000 (13:01 +0000)]
[ARM] Add +mve feature to mve tests. NFC
Sylvestre Ledru [Wed, 1 Jan 2020 11:55:59 +0000 (12:55 +0100)]
clang-tidy doc: Remove severities as they don't make consensus
Reviewers: jdoerfert, aaron.ballman
Reviewed By: aaron.ballman
Subscribers: whisperity, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72049
Liu, Chen3 [Tue, 31 Dec 2019 03:38:17 +0000 (11:38 +0800)]
add strict float for round operation
Differential Revision: https://reviews.llvm.org/D72026
Fangrui Song [Wed, 1 Jan 2020 08:15:28 +0000 (00:15 -0800)]
[MC][TargetMachine] Delete MCTargetOptions::MCPIECopyRelocations
clang/lib/CodeGen/CodeGenModule performs the -mpie-copy-relocations
check and sets dso_local on applicable global variables. We don't need
to duplicate the work in TargetMachine shouldAssumeDSOLocal.
Verified that -mpie-copy-relocations can still emit PC relative
relocations for external variable accesses.
clang -target x86_64 -fpie -mpie-copy-relocations -c => R_X86_64_PC32
clang -target aarch64 -fpie -mpie-copy-relocations -c => R_AARCH64_ADR_PREL_PG_HI21+R_AARCH64_LDST64_ABS_LO12_NC
Fangrui Song [Tue, 31 Dec 2019 23:00:59 +0000 (15:00 -0800)]
[ELF][RISCV][test] Test absolute/PC-relative/branch relocations to undefined weak symbols
Hideto Ueno [Wed, 1 Jan 2020 06:25:19 +0000 (15:25 +0900)]
[Attributor] AAValueConstantRange: Value range analysis using constant range
This patch introduces `AAValueConstantRange`, which answers a possible range for integer value in a specific program point.
One of the motivations is propagating existing `range` metadata. (I think we need to change the situation that `range` metadata cannot be put to Argument).
The state is a tuple of `ConstantRange` and it is initialized to (known, assumed) = ([-∞, +∞], empty).
Currently, AAValueConstantRange is created when AAValueSimplify cannot
simplify the value.
Supported
- BinaryOperator(add, sub, ...)
- CmpInst(icmp eq, ...)
- !range metadata
`AAValueConstantRange` is not intended to extend to polyhedral range value analysis.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D71620
Craig Topper [Wed, 1 Jan 2020 05:40:58 +0000 (21:40 -0800)]
[X86] Fix typo in getCMovOpcode.
The 64-bit HasMemoryOperand line was using CMOV32rm instead of
CMOV64rm. Not sure how to test this. We have no test coverage
that passes true for HasMemoryOperand.
Craig Topper [Wed, 1 Jan 2020 04:29:41 +0000 (20:29 -0800)]
[X86] Add X87 FCMOV support to X86FlagsCopyLowering.
Fixes PR44396
Matt Arsenault [Mon, 30 Dec 2019 19:46:24 +0000 (14:46 -0500)]
DAG: Stop trying to fold FP -(x-y) -> y-x in getNode with nsz
This was increasing the number of instructions when fsub was legalized
on AMDGPU with no signed zeros enabled. This fold should be guarded by
hasOneUse, and I don't think getNode should be doing that. The same
fold is already done as a regular combine through isNegatibleForFree.
This does require duplicating, even though isNegatibleForFree does
this combine already (and properly checks hasOneUse) to avoid one PPC
regression. In the regression, the outer fneg has nsz but the fsub
operand does not. isNegatibleForFree only sees the operand, and
doesn't see it's used from a nsz context. A nsz parameter needs to be
added and threaded through isNegatibleForFree to avoid this.
Fangrui Song [Tue, 31 Dec 2019 23:06:31 +0000 (15:06 -0800)]
[ELF][RISCV] Improve error message for unknown relocations
Like rLLD354040.
Craig Topper [Tue, 31 Dec 2019 23:57:17 +0000 (15:57 -0800)]
[X86] Constant fold KSHIFT of an all zeros vector to just an all zeros vector.
Craig Topper [Tue, 31 Dec 2019 23:06:47 +0000 (15:06 -0800)]
[X86][InstCombine] Add constant folding and simplification support for pdep and pext
The instructions use a mask to either pack disjoint bits together(pext) or spread bits to disjoint locations(pdep). If the mask is all 0s then no bits are extracted or deposited. If the mask is all ones, then the source value is written to the result since no compression or expansion happens. Otherwise if both the source and mask are constant we can walk the bits in the source/mask and calculate the result.
There other crazier things we could do like computeKnownBits or turning pext into shift/and if only a single contiguous range of bits is extracted.
Fixes PR44389
Differential Revision: https://reviews.llvm.org/D71952
Craig Topper [Tue, 31 Dec 2019 23:05:21 +0000 (15:05 -0800)]
[X86] Use carry flag from add for (seteq (add X, -1), -1).
If we just subtracted 1 and are checking if the result is -1. We can use the carry flag from the ADD instead of an explicit CMP. I'm using the same checks for the add users as EmitTest.
Fixes one case from PR44412
Differential Revision: https://reviews.llvm.org/D72019
Craig Topper [Tue, 31 Dec 2019 22:04:09 +0000 (14:04 -0800)]
[LegalizeVectorOps][AArch64] Stop asking for v4f16 fp_round and fp_extend to be promoted.
These operations are needed as building blocks for promoting so they
can't be promoted themselves.
This appeared to work because the fp_extend query type for operation
actions is the result type, not the input type so it never triggered
in the legalizer.
For fp_round, the vector op legalizer just ended up creating a
nop fp_extend that was elided by getNode, followed by a nop
fp_round that was also elided by getNode. This was followed by
a final fp_round from v4f32 back to vf416 which was CSEd to the
original node. Then legalize vector ops just believed that node
legalized to itself. LegalizeDAG took another crack at promoting
it, but didn't have a handler so just skipped it with a debug
message saying it wasn't promoted.
This patch just removes the operation actions to avoid this
non-sense. Found while trying to refactor LegalizeVectorOps to
handle multiple result nodes better.
Matt Arsenault [Tue, 31 Dec 2019 18:51:52 +0000 (13:51 -0500)]
AMDGPU: Precommit test showing extra instructions are introduced
Martin Storsjö [Tue, 31 Dec 2019 19:38:43 +0000 (21:38 +0200)]
Revert "[Diagnostic] Add ftabstop to -Wmisleading-indentation"
This reverts commit
b47b35ff51b355a446483777155290541ab64fae.
This caused failed asserts (Assertion `FIDAndOffset.second >
ColNo && "Column number smaller than file offset?"' failed.)
on a source file with a single line containing
"int main (void) { for( int i = 0; i < 9; i++ ); return 0; }".
Michael Liao [Wed, 25 Dec 2019 05:47:18 +0000 (00:47 -0500)]
[amdgpu] Fix scoreboard updating on `s_waitcnt_vscnt`.
Summary: - Other counters are accidentally cleared.
Subscribers: arsenm, kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71866
Alexey Bataev [Tue, 31 Dec 2019 17:41:57 +0000 (12:41 -0500)]
[OPENMP]Emit artificial threprivate vars as threadlocal, if possible.
It may improve performance for declare reduction constructs.
Jacques Pienaar [Tue, 31 Dec 2019 18:56:24 +0000 (10:56 -0800)]
[mlir][docs] Remove redundant path prefix
./ is not needed.
Craig Topper [Tue, 31 Dec 2019 18:57:58 +0000 (10:57 -0800)]
[X86] Add test case for opposite branch condition for PR44412. NFC
Craig Topper [Tue, 31 Dec 2019 18:33:30 +0000 (10:33 -0800)]
[CodeGen] Emit conj/conjf/confjl libcalls as fneg instructions if possible.
We already recognize the __builtin versions of these, might as well
recognize the libcall version.
Differential Revision: https://reviews.llvm.org/D72028
Jacques Pienaar [Tue, 31 Dec 2019 17:52:19 +0000 (09:52 -0800)]
[mlir] Make code blocks more consistent
Use the same form specification for the same type of code.
Sanjay Patel [Tue, 31 Dec 2019 17:29:53 +0000 (12:29 -0500)]
[InstCombine] fold zext of masked bit set/clear
This does not solve PR17101, but it is one of the
underlying diffs noted here:
https://bugs.llvm.org/show_bug.cgi?id=17101#c8
We could ease the one-use checks for the 'clear'
(no 'not' op) half of the transform, but I do not
know if that asymmetry would make things better
or worse.
Proofs:
https://rise4fun.com/Alive/uVB
Name: masked bit set
%sh1 = shl i32 1, %y
%and = and i32 %sh1, %x
%cmp = icmp ne i32 %and, 0
%r = zext i1 %cmp to i32
=>
%s = lshr i32 %x, %y
%r = and i32 %s, 1
Name: masked bit clear
%sh1 = shl i32 1, %y
%and = and i32 %sh1, %x
%cmp = icmp eq i32 %and, 0
%r = zext i1 %cmp to i32
=>
%xn = xor i32 %x, -1
%s = lshr i32 %xn, %y
%r = and i32 %s, 1
Sanjay Patel [Tue, 31 Dec 2019 17:00:07 +0000 (12:00 -0500)]
[InstCombine] add/adjust tests for masked bit; NFC
Stephen Kelly [Sun, 29 Dec 2019 19:21:57 +0000 (19:21 +0000)]
Implement additional traverse() overloads
Summary:
These overloads make it possible to wrap unless(), anyOf(), has() etc
with the traverse matcher.
Reviewers: aaron.ballman
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71977
Stephen Kelly [Sun, 29 Dec 2019 19:19:55 +0000 (19:19 +0000)]
Unnest struct in Matcher implementation
This allows implementation of the traverse() matcher to surround
matchers like unless().
Stephen Kelly [Sun, 29 Dec 2019 19:19:35 +0000 (19:19 +0000)]
Match code following lambdas when ignoring invisible nodes
Reviewers: aaron.ballman
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71976
Johannes Doerfert [Tue, 31 Dec 2019 16:55:07 +0000 (10:55 -0600)]
[Attributor][Fix] Avoid leaking memory after D68765
Nikita Popov [Tue, 31 Dec 2019 16:42:38 +0000 (17:42 +0100)]
Revert "[InstCombine] Fix infinite loop due to bitcast <-> phi transforms"
This reverts commit
27a0795943fee0f30b995fe5165428afc2dfd402.
Seems to break test-suite.
Jinsong Ji [Tue, 31 Dec 2019 16:24:35 +0000 (16:24 +0000)]
[PowerPC][NFC] Fix clang-tidy warning
Reported by
https://results.llvm-merge-guard.org/amd64_debian_testing_clang8-726/clang-tidy.txt
/mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11672:10:
warning: invalid case style for variable 'isEQ'
[readability-identifier-naming]
bool isEQ = (MI.getOpcode() == PPC::ANDI_rec_1_EQ_BIT ||
^~~~
IsEq
/mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11679:14:
warning: invalid case style for variable 'dl'
[readability-identifier-naming]
DebugLoc dl = MI.getDebugLoc();
^~
Dl
Sven van Haastregt [Tue, 31 Dec 2019 15:30:02 +0000 (15:30 +0000)]
[OpenCL] Remove redundant foreach in OpenCLBuiltins.td; NFC
Remove various `foreach` declarations where the iterator is used only
once. This makes the .td file more compact.
Sanjay Patel [Tue, 31 Dec 2019 15:25:41 +0000 (10:25 -0500)]
[AArch64] add test for fsub+fneg; NFC
D72015 proposes to restrict the current behavior.
Sanjay Patel [Mon, 30 Dec 2019 19:56:57 +0000 (14:56 -0500)]
[InstCombine] add tests for masked bit set/clear; NFC
Nikita Popov [Sat, 7 Dec 2019 11:21:22 +0000 (12:21 +0100)]
[InstCombine] Fix infinite loop due to bitcast <-> phi transforms
Fix for https://bugs.llvm.org/show_bug.cgi?id=44245.
The optimizeBitCastFromPhi() and FoldPHIArgOpIntoPHI() end up
fighting against each other, because optimizeBitCastFromPhi()
assumes that bitcasts of loads will get folded. This doesn't happen
here, because a dangling phi node prevents the one-use fold in
https://github.com/llvm/llvm-project/blob/master/llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp#L620-L628 from triggering.
This patch fixes the issue by adding manually removing the old phis.
Differential Revision: https://reviews.llvm.org/D71164
Nicolas Vasilache [Mon, 30 Dec 2019 20:41:12 +0000 (15:41 -0500)]
[mlir][Linalg] Delete unused LinalgLibraryOps.td
Summary: This has been previously renamed to LinalgStructuredOps.td
Reviewers: ftynse
Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, llvm-commits, ftynse
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72013
Miloš Stojanović [Tue, 31 Dec 2019 13:14:41 +0000 (14:14 +0100)]
[llvm-exegesis] Check counters before running
Check if the appropriate counters for the specified mode are defined on
the target. This is checked before any other work is done.
Differential Revision: https://reviews.llvm.org/D71927
Sam Parker [Tue, 31 Dec 2019 11:31:06 +0000 (11:31 +0000)]
[ARM][TypePromotion] Re-enable by default
Re-enable the pass after it was reverted and the bug fixed.
Michael Platings [Mon, 30 Dec 2019 08:21:42 +0000 (08:21 +0000)]
Fix external-names.c test when separator is \\
This fixes the following failure:
C:\[...]\llvm\tools\clang\test\VFS\external-names.c:34:26: error: CHECK-DEBUG-EXTERNAL: expected string not found in input
// CHECK-DEBUG-EXTERNAL: ![[Num]] = !DIFile(filename: "{{[^"]*}}Inputs{{.}}external-names.h"
^
[...]
<stdin>:42:54: note: possible intended match here
!10 = !DIFile(filename: "C:/[...]\\llvm\\tools\\clang\\test\\VFS\\Inputs\\external-names.h", directory: "")
Differential Revision: https://reviews.llvm.org/D71991
Connor Abbott [Tue, 31 Dec 2019 11:11:35 +0000 (12:11 +0100)]
[InstCombine] Don't rewrite phi-of-bitcast when the phi has other users
Judging by the existing comments, this was the intention, but the
transform never actually checked if the existing phi's would be removed.
See https://bugs.llvm.org/show_bug.cgi?id=44242 for an example where
this causes much worse code generation on AMDGPU.
Differential Revision: https://reviews.llvm.org/D71209
Connor Abbott [Tue, 31 Dec 2019 11:10:06 +0000 (12:10 +0100)]
[InstCombine] Add tests for PR44242
Differential Revision: https://reviews.llvm.org/D71260
Sylvestre Ledru [Tue, 31 Dec 2019 10:56:17 +0000 (11:56 +0100)]
clang-tidy doc: modernize-make-unique has an autofix
Ilya Biryukov [Tue, 31 Dec 2019 09:21:52 +0000 (10:21 +0100)]
[Attributor] Suppress unused warnings when assertions are disabled. NFC
Johannes Doerfert [Fri, 11 Oct 2019 01:23:17 +0000 (20:23 -0500)]
[Utils] Deal with occasionally deleted functions
When functions exist for some but not all run lines we need to be
careful when selecting the prefix. So far, a common prefix was
potentially chosen as there was never a "conflict" that would have
caused otherwise. With this patch we avoid common prefixes if they
are used by run lines that do not emit the function.
Reviewed By: lebedev.ri
Differential Revision: https://reviews.llvm.org/D68850
Johannes Doerfert [Thu, 10 Oct 2019 06:39:16 +0000 (01:39 -0500)]
[Attributor] Function signature rewrite infrastructure
As part of the Attributor manifest we want to change the signature of
functions. This patch introduces a fairly generic interface to do so.
As a first, very simple, use case, we remove unused arguments. A second
use case, pointer privatization, will be committed with this patch as
well.
A lot of the code and ideas are taken from argument promotion and we
run all argument promotion tests through this framework as well.
Reviewed By: uenoku
Differential Revision: https://reviews.llvm.org/D68765
Craig Topper [Tue, 31 Dec 2019 07:41:35 +0000 (23:41 -0800)]
[X86] Slightly improve our attempted error recovery for 64-bit -mno-sse2 in LowerCallResult to use FP1 if there are two return values.
If the return value is a struct of 2 doubles we need two return
registers.
If SSE2 is disabled we can't return in XMM registers like the ABI says.
After logging an error we attempt to recover by using FP0 instead
of an XMM register. But if the return needs two registers, we may have
already used FP0. So if the register we were supposed to copy to is
XMM1, copy to FP1 in the recovery instead.
This seems to fix the assertion/crash in PR44413.
Johannes Doerfert [Tue, 31 Dec 2019 08:11:30 +0000 (02:11 -0600)]
[Utils][Fix] Minor test result change
Shengchen Kan [Tue, 31 Dec 2019 08:08:05 +0000 (16:08 +0800)]
[NFC] Style cleanup
1. make function Is16BitMemOperand static
2. Use Doxygen features in comment
3. Rename functions to make them start with a lower case letter
Johannes Doerfert [Fri, 1 Nov 2019 17:51:26 +0000 (12:51 -0500)]
[Utils] Reuse argument variable names in the body
If we have `int foo(int a) { return a; }` and we run with --function-signature
enabled, we want a single variable declaration for `a` which is reused
later.
Reviewed By: lebedev.ri
Differential Revision: https://reviews.llvm.org/D69722
Johannes Doerfert [Fri, 11 Oct 2019 01:32:04 +0000 (20:32 -0500)]
[Utils] Allow update_test_checks to scrub attribute annotations
Attribute annotations on calls, e.g., #0, are not useful on their own.
This patch adds a flag to update_test_checks.py to scrub them.
Reviewed By: lebedev.ri
Differential Revision: https://reviews.llvm.org/D68851
Johannes Doerfert [Tue, 31 Dec 2019 07:27:50 +0000 (01:27 -0600)]
[Attributor] Propagate known align from arguments to call sites arguments
Since the information is known we can simply use it at the call site.
This is especially useful for callbacks but also helps regular calls.
The test changes are mechanical.
Johannes Doerfert [Thu, 10 Oct 2019 06:19:57 +0000 (01:19 -0500)]
[Attributor] Use abstract call sites to determine associated arguments
This is the second step after D67871 to make use of abstract call sites.
In this patch the argument we associate with a abstract call site
argument can be the one in the callback callee instead of the one in the
callback broker.
Caveat: We cannot allow no-alias arguments for problematic callbacks:
As described in [1], adding no-alias (or restrict) to arguments could
break synchronization as the synchronization effect, e.g., a barrier,
does not "alias" with the pointer anymore. This disables no-alias
annotation for potentially problematic arguments until we implement the
fix described in [1].
Reviewed By: uenoku
Differential Revision: https://reviews.llvm.org/D68008
[1] Compiler Optimizations for OpenMP, J. Doerfert and H. Finkel,
International Workshop on OpenMP 2018,
http://compilers.cs.uni-saarland.de/people/doerfert/par_opt18.pdf
Johannes Doerfert [Tue, 31 Dec 2019 06:57:00 +0000 (00:57 -0600)]
[Attributor] Annotate the memory behavior of call site arguments
Especially for callbacks, annotating the call site arguments is
important. Doing so exposed a too strong dependence of AAMemoryBehavior
on AANoCapture since we handle the case of potentially captured pointers
explicitly.
The changes to the tests are all mechanical.
Shengchen Kan [Tue, 31 Dec 2019 07:10:08 +0000 (15:10 +0800)]
[NFC] Make X86MCCodeEmitter::isPCRel32Branch static
David Blaikie [Tue, 31 Dec 2019 06:32:08 +0000 (22:32 -0800)]
Revert "DebugInfo: Fix rangesBaseAddress DICompileUnit bitcode serialization/deserialization"
Seeing some curious CFI failures internally - which makes little sense
to me, as I don't think anyone is using this flag (even us,
internally)... so sounds like a bug in my code somewhere (possibly a
latent one that propagating this flag exposed, not sure). Reverting
while I investigate.
This reverts commit
c51b45e32ef7f35c11891f60871aa9c2c04cd991.
Shengchen Kan [Tue, 31 Dec 2019 06:23:07 +0000 (14:23 +0800)]
[NFC] Style cleanup
1. Remove function is64BitMode() and use STI.hasFeature(X86::Mode16Bit) directly
2. Use Doxygen features in comment
3. Rename functions to make them start with a lower case letter
4. Format the code with clang-format
River Riddle [Tue, 31 Dec 2019 04:49:47 +0000 (20:49 -0800)]
[mlir] Refactor operation results to use a single use list for all results of the operation.
Summary: A new class is added, IRMultiObjectWithUseList, that allows for representing an IR use list that holds multiple sub values(used in this case for OpResults). This class provides all of the same functionality as the base IRObjectWithUseList, but for specific sub-values. This saves a word per operation result and is a necessary step in optimizing the layout of operation results. For now the use list is placed on the operation itself, so zero-result operations grow by a word. When the work for optimizing layout is finished, this can be moved back to being a trailing object based on memory/runtime benchmarking.
Reviewed By: jpienaar
Differential Revision: https://reviews.llvm.org/D71955
Craig Topper [Tue, 31 Dec 2019 03:07:36 +0000 (19:07 -0800)]
[TargetLowering][AMDGPU] Make scalarizeVectorLoad return a pair of SDValues instead of creating a MERGE_VALUES node. NFCI
This allows us to clean up some places that were peeking through
the MERGE_VALUES node after the call. By returning the SDValues
directly, we can clean that up.
Unfortunately, there are several call sites in AMDGPU that wanted
the MERGE_VALUES and now need to create their own.
Craig Topper [Tue, 31 Dec 2019 02:01:59 +0000 (18:01 -0800)]
[SelectionDAG] Fix copy/paste mistake in comment. NFC
I think this was copied from scalarizeVectorLoad where that is
what happens.
jasonliu [Tue, 31 Dec 2019 03:29:50 +0000 (03:29 +0000)]
[NFC] Add comments in unit test aix-xcoff-toc.ll to clarify the intent
Address David's post review comment in https://reviews.llvm.org/D71667.
Add comments to clarify what we are testing in that file.
Craig Topper [Mon, 30 Dec 2019 22:40:56 +0000 (14:40 -0800)]
[X86] Add test case for PR44412. NFC
Craig Topper [Mon, 30 Dec 2019 21:25:23 +0000 (13:25 -0800)]
[CodeGen] Use IRBuilder::CreateFNeg for __builtin_conj
This replaces the fsub -0.0 idiom with an fneg instruction. We didn't see to have a test that showed the current codegen. Just some tests for constant folding and a test that was only checking the declare lines for libcalls. The latter just checked that we did not have a declare for @conj when using __builtin_conj.
Differential Revision: https://reviews.llvm.org/D72012
Craig Topper [Mon, 30 Dec 2019 21:24:08 +0000 (13:24 -0800)]
[CodeGen] Use CreateFNeg in buildFMulAdd
We have an fneg instruction now and should use it instead of the fsub -0.0 idiom. Looks like we had no test that showed that we handled the negation cases here so I've added new tests.
Differential Revision: https://reviews.llvm.org/D72010
Eric Astor [Mon, 30 Dec 2019 21:11:28 +0000 (16:11 -0500)]
Remove a redundant `default:` on an exhaustive switch(enum).
Johannes Doerfert [Mon, 30 Dec 2019 20:58:28 +0000 (14:58 -0600)]
[OpenMP][FIX] Generalize a test check line
The new check line is compatible with the clang code generation check
line as it allows a 64 and 32 bit value.
I hope this makes the llvm-clang-win-x-armv7l buildbot happy.
Jon Chesterfield [Mon, 30 Dec 2019 20:49:56 +0000 (20:49 +0000)]
[libomptarget][nfc] Change unintentional target_impl prefix to kmpc_impl
Jinsong Ji [Mon, 30 Dec 2019 20:21:46 +0000 (20:21 +0000)]
[PowerPC][docs] Update Embedded PowerPC docs in Compiler Writers Info page
Summary:
Embedded PowerPC are still actively supported, especially SPE...
So update some important references here:
* adding EREF
* adding SPE/VLE ref
Delete deprecated ones into "Other documents..".
Reviewers: #powerpc, jhibbits, hfinkel
Reviewed By: #powerpc, jhibbits
Subscribers: wuzish, merge_guards_bot, nemanjai, shchenz, steven.zhang, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72008
Johannes Doerfert [Thu, 26 Dec 2019 17:23:38 +0000 (11:23 -0600)]
[OpenMP] Use the OpenMPIRBuilder for `omp parallel`
This allows to use the OpenMPIRBuilder for parallel regions. Code was
extracted from D61953 and adapted to work with the new version (D70109).
All but one feature should be supported. An update of this patch will
provide test coverage and privatization other than shared.
Reviewed By: fghanim
Differential Revision: https://reviews.llvm.org/D70290
Johannes Doerfert [Fri, 27 Dec 2019 21:53:37 +0000 (15:53 -0600)]
[OpenMP] Use the OpenMPIRBuilder for `omp cancel`
An `omp cancel parallel` needs to be emitted by the OpenMPIRBuilder if
the `parallel` was emitted by the OpenMPIRBuilder. This patch makes
this possible. The cancel logic is shared with the cancel barriers.
Testing is done via unit tests and the clang cancel_codegen.cpp file
once D70290 lands.
Reviewed By: JonChesterfield
Differential Revision: https://reviews.llvm.org/D71948
Eric Astor [Mon, 30 Dec 2019 19:33:56 +0000 (14:33 -0500)]
[X86][AsmParser] re-introduce 'offset' operator
Summary:
Amend MS offset operator implementation, to more closely fit with its MS counterpart:
1. InlineAsm: evaluate non-local source entities to their (address) location
2. Provide a mean with which one may acquire the address of an assembly label via MS syntax, rather than yielding a memory reference (i.e. "offset asm_label" and "$asm_label" should be synonymous
3. address PR32530
Based on http://llvm.org/D37461
Fix broken test where the break appears unrelated.
- Set up appropriate memory-input rewrites for variable references.
- Intel-dialect assembly printing now correctly handles addresses by adding "offset".
- Pass offsets as immediate operands (using "r" constraint for offsets of locals).
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D71436
Matt Arsenault [Sun, 8 Sep 2019 22:11:51 +0000 (18:11 -0400)]
AMDGPU/GlobalISel: Select mul24 intrinsics