platform/upstream/gstreamer.git
20 years agofix gettext/automake problem fix underquoted macros
Thomas Vander Stichele [Wed, 11 Feb 2004 16:25:44 +0000 (16:25 +0000)]
fix gettext/automake problem fix underquoted macros

Original commit message from CVS:
fix gettext/automake problem
fix underquoted macros

20 years agowhoops, de-conflictify
Andy Wingo [Wed, 11 Feb 2004 13:28:59 +0000 (13:28 +0000)]
whoops, de-conflictify

Original commit message from CVS:
whoops, de-conflictify

20 years agogst/gstpad.c (gst_pad_custom_new): Add a FIXME, this is a hacky way to do inheritance.
Andy Wingo [Wed, 11 Feb 2004 13:26:04 +0000 (13:26 +0000)]
gst/gstpad.c (gst_pad_custom_new): Add a FIXME, this is a hacky way to do inheritance.

Original commit message from CVS:
2004-02-10  Andy Wingo  <wingo@pobox.com>

* gst/gstpad.c (gst_pad_custom_new): Add a FIXME, this is a hacky
way to do inheritance.
(gst_pad_get_event_masks, gst_pad_get_event_masks_default)
(gst_pad_get_query_types, gst_pad_get_query_types_default):
Routine docs.
(gst_pad_set_link_function, gst_pad_set_fixate_function)
(gst_pad_set_getcaps_function): Doc from Dave's negotation random
doc.
(gst_pad_unlink, gst_pad_is_linked): Docs.
(gst_pad_renegotiate): A brief description of capsnego.
(gst_pad_try_set_caps): Document.
(gst_pad_try_set_caps_nonfixed): Document.
(gst_pad_can_link_filtered, gst_pad_link_filtered): Doc fixes.
(gst_pad_set_parent): Deprecated (although not out of the API).
(gst_pad_get_parent): Deprecated, although many plugins use this.
(gst_pad_add_ghost_pad, gst_pad_remove_ghost_pad): Doc that these
are private and will go away in 0.9.
(gst_pad_perform_negotiate): Doc.
(gst_pad_link_unnegotiate): I think this is meant to be static.
(gst_pad_get_negotiated_caps, gst_pad_get_pad_template_caps)
(gst_pad_template_get_caps_by_name, gst_pad_check_compatibility)
(gst_pad_get_peer): Doc updates.
(gst_pad_caps_change_notify): Doc.
(gst_pad_alloc_buffer, gst_pad_push, gst_static_pad_template_get)
(gst_ghost_pad_new): Doc fixes.

* gst/gstobject.c (gst_object_get_parent, gst_object_unparent)
(gst_object_check_uniqueness):

* gst/gstelement.c (gst_element_add_pad)
(gst_element_add_ghost_pad, gst_element_remove_pad)
(gst_element_remove_ghost_pad, gst_element_get_pad)
(gst_element_get_static_pad, gst_element_get_pad_list)
(gst_element_class_get_pad_template_list)
(gst_element_class_get_pad_template): Work on the docs.
(gst_element_get_pad_template_list): Uses the class method.
(gst_element_get_compatible_pad_template): Docs, and consolidate
some test conditions.
(gst_element_get_pad_from_template): New static function.
(gst_element_request_compatible_pad): Docs, and work with
non-request compatible templates.
(gst_element_get_compatible_pad_filtered): Docs and remove
redundant checks.
(gst_element_get_compatible_pad, gst_element_link_pads_filtered)
(gst_element_link_filtered, gst_element_link_many)
(gst_element_link, gst_element_link_pads)
(gst_element_unlink_many): Docs.

2004-02-05  Andy Wingo  <wingo@pobox.com>

* gst/gstpad.c (_gst_real_pad_fixate_accumulator):
s/pointer/boxed/.

* gst/gstmarshal.list (VOID:BOXED, BOXED:BOXED): New marshallers.

* gst/gstpad.c (gst_real_pad_class_init): Use a BOXED:BOXED
marshaller for ::fixate, and VOID:BOXED for ::caps-nego-failed,
with the type=GST_TYPE_CAPS. This allows language bindings to know
what kind of data they're dealing with.

* gst/gstcaps.c (_gst_caps_value_init): GBoxed values initialize
to NULL when g_value_init is called. GstCaps, which rolls its own
type implementation, now does the same instead of allocating empty
caps.
(_gst_caps_initialize, _gst_caps_collect_value,
_gst_caps_lcopy_value): Provide collect_value and lcopy_value type
table methods. This allows G_VALUE_COLLECT to work.

2004-02-05  Andy Wingo  <wingo@pobox.com>

* configure.ac:
* testsuite/Makefile.am (SUBDIRS):
* testsuite/ghostpads/Makefile.am:
* testsuite/ghostpads/ghostpads.c: A new test for ghost pads.

* gst/gstpad.c (gst_pad_add_ghost_pad, gst_pad_remove_ghost_pad):
These two routines are the only ones that set
GST_GPAD_REALPAD(gpad), the ghost pad list, and the ghost pad's
pad template. They should be made static, depending on ABI needs.
(gst_real_pad_dispose): Handle the case of ghost pads without a
parent. Assert after dealing with ghost pads that the ghost pad
list is empty.
(gst_ghost_pad_class_init): New property added, ::real-pad. Can be
set after creation.
(gst_ghost_pad_dispose): Set ::real-pad to NULL.
(gst_ghost_pad_set_property, gst_ghost_pad_get_property): New
functions. set_property will call add_ghost_pad/remove_ghost_pad
as appropriate.
(gst_ghost_pad_new): All the work is offloaded to g_object_new.

* gst/gstelement.c (gst_element_add_pad): Handle ghost pads as well.
(gst_element_add_ghost_pad): Remove code duplicated from _add_pad.
(gst_element_remove_pad): Handle ghost pads as well.
(gst_element_remove_ghost_pad): Deprecated (could be removed,
depending on API-stability needs).

2004-02-05  Andy Wingo  <wingo@pobox.com>

* gst/gstbin.[ch]: (gst_bin_get_by_interface): GTypes are scalars,
of course they're const

20 years agoremove unversioned feedback script
Thomas Vander Stichele [Wed, 11 Feb 2004 12:48:40 +0000 (12:48 +0000)]
remove unversioned feedback script

Original commit message from CVS:
remove unversioned feedback script

20 years agoversion gst-feedback
Thomas Vander Stichele [Wed, 11 Feb 2004 12:48:09 +0000 (12:48 +0000)]
version gst-feedback

Original commit message from CVS:
version gst-feedback

20 years agofile gst-feedback-0.6 was initially added on branch BRANCH-GSTREAMER-0_6.
Thomas Vander Stichele [Wed, 11 Feb 2004 12:46:55 +0000 (12:46 +0000)]
file gst-feedback-0.6 was initially added on branch BRANCH-GSTREAMER-0_6.

Original commit message from CVS:
file gst-feedback-0.6 was initially added on branch BRANCH-GSTREAMER-0_6.

20 years agofile gst-feedback-0.6.1.in was initially added on branch BRANCH-GSTREAMER-0_6.
Thomas Vander Stichele [Wed, 11 Feb 2004 12:46:55 +0000 (12:46 +0000)]
file gst-feedback-0.6.1.in was initially added on branch BRANCH-GSTREAMER-0_6.

Original commit message from CVS:
file gst-feedback-0.6.1.in was initially added on branch BRANCH-GSTREAMER-0_6.

20 years agogst/gstpad.c: Fix format strings for GST_PTR_FORMAT.
David Schleef [Wed, 11 Feb 2004 08:28:54 +0000 (08:28 +0000)]
gst/gstpad.c: Fix format strings for GST_PTR_FORMAT.

Original commit message from CVS:
* gst/gstpad.c: (gst_pad_link_intersect), (gst_pad_link_fixate),
(gst_pad_try_set_caps): Fix format strings for GST_PTR_FORMAT.

20 years agogst/gstevent.c: Sometimes a tag event arrives but the structure does not contain...
Julien Moutte [Tue, 10 Feb 2004 11:57:27 +0000 (11:57 +0000)]
gst/gstevent.c: Sometimes a tag event arrives but the structure does not contain a valid tag list. Adding a safety ch...

Original commit message from CVS:
2004-02-10  Julien MOUTTE <julien@moutte.net>

* gst/gstevent.c: (_gst_event_free): Sometimes a tag event arrives but
the structure does not contain a valid tag list. Adding a safety check
to remove a noisy warning in that case.

20 years agofix name of core elements
Thomas Vander Stichele [Tue, 10 Feb 2004 10:30:24 +0000 (10:30 +0000)]
fix name of core elements

Original commit message from CVS:
fix name of core elements

20 years agolibs/gst/bytestream/bytestream.c: We should not shout that loud when len is 0. Just...
Julien Moutte [Mon, 9 Feb 2004 22:05:15 +0000 (22:05 +0000)]
libs/gst/bytestream/bytestream.c: We should not shout that loud when len is 0. Just return 0 silently.

Original commit message from CVS:
2004-02-09  Julien MOUTTE <julien@moutte.net>

* libs/gst/bytestream/bytestream.c: (gst_bytestream_peek): We should
not shout that loud when len is 0. Just return 0 silently.

20 years agogst/gstdata.c: Adding a categorized debug on data_ref because data_unref has one...
Julien Moutte [Mon, 9 Feb 2004 09:11:50 +0000 (09:11 +0000)]
gst/gstdata.c: Adding a categorized debug on data_ref because data_unref has one and i prefer the debug to be symetric.

Original commit message from CVS:
2004-02-09  Julien MOUTTE  <julien@moutte.net>

* gst/gstdata.c: (gst_data_ref): Adding a categorized debug on data_ref
because data_unref has one and i prefer the debug to be symetric.
* gst/gstqueue.c: (gst_queue_locked_flush): Fix a huge memleak. Buffers
were refed when added to the queue and unrefed only once when the queue
was flushed. Now the flush handler unref the buffers two times : first
unref for the ref added when pushing in the queue's tail and second
unref to destroy the flushed buffer.

20 years agofix docs for cvfix docs for cvss
Thomas Vander Stichele [Sun, 8 Feb 2004 18:50:40 +0000 (18:50 +0000)]
fix docs for cvfix docs for cvss

Original commit message from CVS:
fix docs for cvfix docs for cvss

20 years agoTrying to fix the mess that I made with the two previous commits.
Ramon Garcia Fernandez [Sat, 7 Feb 2004 15:51:39 +0000 (15:51 +0000)]
Trying to fix the mess that I made with the two previous commits.

Original commit message from CVS:

Trying to fix the mess that I made with the two previous commits.

First commit, doing something wrong (fixing comparisons of signed and unsigned).
Second commit, trying to revert the previous, but changing other things and
reverting unrelated work of other people.
And this third, hopefully fixes it.

20 years agoReverted changes made to fix unsigned-signed warnings after hearing comments on IRC...
Ramon Garcia Fernandez [Sat, 7 Feb 2004 15:37:21 +0000 (15:37 +0000)]
Reverted changes made to fix unsigned-signed warnings after hearing comments on IRC. Thans to teus

Original commit message from CVS:
Reverted changes made to fix unsigned-signed warnings after hearing comments on IRC. Thans to teus

20 years agofixed compilation warnings of comparison between signed and unsigned
Ramon Garcia Fernandez [Sat, 7 Feb 2004 13:34:27 +0000 (13:34 +0000)]
fixed compilation warnings of comparison between signed and unsigned

Original commit message from CVS:
fixed compilation warnings of comparison between signed and unsigned

20 years agodocs/random/ds/0.9-suggested-changes: Random ramblings
David Schleef [Sat, 7 Feb 2004 01:23:13 +0000 (01:23 +0000)]
docs/random/ds/0.9-suggested-changes: Random ramblings

Original commit message from CVS:
* docs/random/ds/0.9-suggested-changes: Random ramblings
* gst/elements/gstfilesrc.c: (gst_filesrc_get_mmap): Cast size_t
to int before printing.
* gst/parse/grammar.y: Fix gcc-2.95 style variadic macros.
* gst/parse/parse.l: same.  See bug #129600

20 years agogst/gstindex.c: (gst_index_add_association): Add gst_index_add_associationv() and...
David Schleef [Fri, 6 Feb 2004 18:17:56 +0000 (18:17 +0000)]
gst/gstindex.c: (gst_index_add_association): Add gst_index_add_associationv() and clean up gst_index_add_association(...

Original commit message from CVS:
* gst/gstindex.c: (gst_index_add_format), (gst_index_add_id),
(gst_index_add_entry), (gst_index_add_associationv),
(gst_index_add_association): Add gst_index_add_associationv()
and clean up gst_index_add_association(). #127133

20 years agocheck out common with right tag
Thomas Vander Stichele [Fri, 6 Feb 2004 17:54:40 +0000 (17:54 +0000)]
check out common with right tag

Original commit message from CVS:
check out common with right tag

20 years agofix testsuite from segfaulting
Thomas Vander Stichele [Fri, 6 Feb 2004 16:25:31 +0000 (16:25 +0000)]
fix testsuite from segfaulting

Original commit message from CVS:
fix testsuite from segfaulting

20 years agoremove release
Thomas Vander Stichele [Fri, 6 Feb 2004 13:09:26 +0000 (13:09 +0000)]
remove release

Original commit message from CVS:
remove release

20 years agobump nano add release target
Thomas Vander Stichele [Fri, 6 Feb 2004 13:07:20 +0000 (13:07 +0000)]
bump nano add release target

Original commit message from CVS:
bump nano
add release target

20 years agoso i odn't forget
Thomas Vander Stichele [Fri, 6 Feb 2004 11:53:15 +0000 (11:53 +0000)]
so i odn't forget

Original commit message from CVS:
so i odn't forget

20 years agocompile before checkin
Benjamin Otte [Thu, 5 Feb 2004 23:51:34 +0000 (23:51 +0000)]
compile before checkin

Original commit message from CVS:
compile before checkin

20 years agogst/: put reverted patch back in
Benjamin Otte [Thu, 5 Feb 2004 23:46:13 +0000 (23:46 +0000)]
gst/: put reverted patch back in

Original commit message from CVS:
2004-02-06  Benjamin Otte  <in7y118@public.uni-hamburg.de>

* gst/gstcaps.h:
* gst/gstelement.c: (gst_element_base_class_init),
(gst_element_class_set_details), (gst_element_clear_pad_caps):
* gst/gstpad.c: (gst_pad_link_intersect), (gst_pad_link_fixate),
(gst_pad_try_set_caps), (gst_pad_can_link_filtered),
(gst_real_pad_dispose):
* gst/gststructure.c: (gst_structure_free),
(gst_structure_from_string):
put reverted patch back in
* gst/gstelement.c: (gst_element_remove_pad):
free explicit caps if they're set
* gst/gstpad.c: (_gst_pad_default_fixate_func):
copy the structure when fixating

20 years agolatest fixes
Christian Schaller [Thu, 5 Feb 2004 20:28:22 +0000 (20:28 +0000)]
latest fixes

Original commit message from CVS:
latest fixes

20 years agogst/: Revert POINTER->BOXED change in signal marshaller.
David Schleef [Thu, 5 Feb 2004 18:59:42 +0000 (18:59 +0000)]
gst/: Revert POINTER->BOXED change in signal marshaller.

Original commit message from CVS:
* gst/gstmarshal.list:
* gst/gstpad.c: (gst_real_pad_class_init),
(_gst_real_pad_fixate_accumulator):
Revert POINTER->BOXED change in signal marshaller.

20 years agobump reqd version of gtk-doc
Thomas Vander Stichele [Thu, 5 Feb 2004 15:10:14 +0000 (15:10 +0000)]
bump reqd version of gtk-doc

Original commit message from CVS:
bump reqd version of gtk-doc

20 years agogst/gstpad.c (_gst_real_pad_fixate_accumulator): s/pointer/boxed/.
Andy Wingo [Thu, 5 Feb 2004 13:51:26 +0000 (13:51 +0000)]
gst/gstpad.c (_gst_real_pad_fixate_accumulator): s/pointer/boxed/.

Original commit message from CVS:
2004-02-05  Andy Wingo  <wingo@pobox.com>

* gst/gstpad.c (_gst_real_pad_fixate_accumulator):
s/pointer/boxed/.

* gst/gstmarshal.list (VOID:BOXED, BOXED:BOXED): New marshallers.

* gst/gstpad.c (gst_real_pad_class_init): Use a BOXED:BOXED
marshaller for ::fixate, and VOID:BOXED for ::caps-nego-failed,
with the type=GST_TYPE_CAPS. This allows language bindings to know
what kind of data they're dealing with.

* gst/gstcaps.c (_gst_caps_value_init): GBoxed values initialize
to NULL when g_value_init is called. GstCaps, which rolls its own
type implementation, now does the same instead of allocating empty
caps.
(_gst_caps_initialize, _gst_caps_collect_value,
_gst_caps_lcopy_value): Provide collect_value and lcopy_value type
table methods. This allows G_VALUE_COLLECT to work.

2004-02-05  Andy Wingo  <wingo@pobox.com>

* configure.ac:
* testsuite/Makefile.am (SUBDIRS):
* testsuite/ghostpads/Makefile.am:
* testsuite/ghostpads/ghostpads.c: A new test for ghost pads.

* gst/gstpad.c (gst_pad_add_ghost_pad, gst_pad_remove_ghost_pad):
These two routines are the only ones that set
GST_GPAD_REALPAD(gpad), the ghost pad list, and the ghost pad's
pad template. They should be made static, depending on ABI needs.
(gst_real_pad_dispose): Handle the case of ghost pads without a
parent. Assert after dealing with ghost pads that the ghost pad
list is empty.
(gst_ghost_pad_class_init): New property added, ::real-pad. Can be
set after creation.
(gst_ghost_pad_dispose): Set ::real-pad to NULL.
(gst_ghost_pad_set_property, gst_ghost_pad_get_property): New
functions. set_property will call add_ghost_pad/remove_ghost_pad
as appropriate.
(gst_ghost_pad_new): All the work is offloaded to g_object_new.

* gst/gstelement.c (gst_element_add_pad): Handle ghost pads as well.
(gst_element_add_ghost_pad): Remove code duplicated from _add_pad.
(gst_element_remove_pad): Handle ghost pads as well.
(gst_element_remove_ghost_pad): Deprecated (could be removed,
depending on API-stability needs).

2004-02-05  Andy Wingo  <wingo@pobox.com>

* gst/gstbin.[ch]: (gst_bin_get_by_interface): GTypes are scalars,
of course they're const

20 years agoprint configure lien
Thomas Vander Stichele [Thu, 5 Feb 2004 13:34:10 +0000 (13:34 +0000)]
print configure lien

Original commit message from CVS:
print configure lien

20 years agorevert patch that breaks applications revert this patch after release so everything...
Thomas Vander Stichele [Thu, 5 Feb 2004 13:32:09 +0000 (13:32 +0000)]
revert patch that breaks applications revert this patch after release so everything can be fixed properly

Original commit message from CVS:
revert patch that breaks applications
revert this patch after release so everything can be fixed properly

20 years agoignore file BRANCH-RELEASE-0_7_4-ROOT
Thomas Vander Stichele [Thu, 5 Feb 2004 11:05:02 +0000 (11:05 +0000)]
ignore file

Original commit message from CVS:
ignore file

20 years agogst/gsttag.*: remove duplicated field GST_TAG_APPLICATION. It's GST_TAG_ENCODER
Benjamin Otte [Thu, 5 Feb 2004 02:58:48 +0000 (02:58 +0000)]
gst/gsttag.*: remove duplicated field GST_TAG_APPLICATION. It's GST_TAG_ENCODER

Original commit message from CVS:
2004-02-05  Benjamin Otte  <in7y118@public.uni-hamburg.de>

* gst/gsttag.c: (_gst_tag_initialize):
* gst/gsttag.h:
remove duplicated field GST_TAG_APPLICATION. It's GST_TAG_ENCODER

20 years agoFix some memleaks:
David Schleef [Thu, 5 Feb 2004 02:44:34 +0000 (02:44 +0000)]
Fix some memleaks:

Original commit message from CVS:
Fix some memleaks:
* gst/autoplug/gstspider.c: (gst_spider_request_new_pad),
(gst_spider_plug_from_srcpad):
* gst/autoplug/gstspideridentity.c: (gst_spider_identity_link):

20 years agogst/gstelement.c: Make sure we have a GstRealPad before accessing its structure members.
David Schleef [Thu, 5 Feb 2004 02:30:53 +0000 (02:30 +0000)]
gst/gstelement.c: Make sure we have a GstRealPad before accessing its structure members.

Original commit message from CVS:
* gst/gstelement.c: (gst_element_clear_pad_caps): Make sure we have
a GstRealPad before accessing its structure members.

20 years agoupdate translation
Thomas Vander Stichele [Wed, 4 Feb 2004 23:32:44 +0000 (23:32 +0000)]
update translation

Original commit message from CVS:
update translation

20 years agogst/gstclock.*: reset padding, remove unused fields
Benjamin Otte [Wed, 4 Feb 2004 22:35:12 +0000 (22:35 +0000)]
gst/gstclock.*: reset padding, remove unused fields

Original commit message from CVS:
2004-02-04  Benjamin Otte  <in7y118@public.uni-hamburg.de>

* gst/gstclock.c: (gst_clock_init), (gst_clock_set_speed),
(gst_clock_get_speed):
* gst/gstclock.h:
reset padding, remove unused fields

20 years agogst/autoplug/gstspideridentity.c: use get_allowed_caps, not get_caps (fixes #132519)
Benjamin Otte [Wed, 4 Feb 2004 22:16:30 +0000 (22:16 +0000)]
gst/autoplug/gstspideridentity.c: use get_allowed_caps, not get_caps (fixes #132519)

Original commit message from CVS:
2004-02-04  Benjamin Otte  <in7y118@public.uni-hamburg.de>

* gst/autoplug/gstspideridentity.c:
(gst_spider_identity_sink_loop_type_finding):
use get_allowed_caps, not get_caps (fixes #132519)
* gst/elements/gsttypefind.c: (stop_typefinding):
use correct order when sending buffers and seeking

20 years agoreset padding
Thomas Vander Stichele [Wed, 4 Feb 2004 21:59:27 +0000 (21:59 +0000)]
reset padding

Original commit message from CVS:
reset padding

20 years agomore ignores
Thomas Vander Stichele [Wed, 4 Feb 2004 21:40:08 +0000 (21:40 +0000)]
more ignores

Original commit message from CVS:
more ignores

20 years agoadding more ignores
Thomas Vander Stichele [Wed, 4 Feb 2004 21:39:30 +0000 (21:39 +0000)]
adding more ignores

Original commit message from CVS:
adding more ignores

20 years agoincrement current, reset padding
Thomas Vander Stichele [Wed, 4 Feb 2004 21:35:39 +0000 (21:35 +0000)]
increment current, reset padding

Original commit message from CVS:
increment current, reset padding

20 years agoappease libtool gods bump to prerel version
Thomas Vander Stichele [Wed, 4 Feb 2004 21:29:38 +0000 (21:29 +0000)]
appease libtool gods bump to prerel version

Original commit message from CVS:
appease libtool gods
bump to prerel version

20 years agosmall updates
Thomas Vander Stichele [Wed, 4 Feb 2004 21:09:12 +0000 (21:09 +0000)]
small updates

Original commit message from CVS:
small updates

20 years agofirst prerel
Thomas Vander Stichele [Wed, 4 Feb 2004 21:05:12 +0000 (21:05 +0000)]
first prerel

Original commit message from CVS:
first prerel

20 years agodocs/random/ds/0.9-suggested-changes: random notes
David Schleef [Wed, 4 Feb 2004 19:38:33 +0000 (19:38 +0000)]
docs/random/ds/0.9-suggested-changes: random notes

Original commit message from CVS:
* docs/random/ds/0.9-suggested-changes: random notes
* gst/elements/gstfakesrc.c: (gst_fakesrc_get_formats),
(gst_fakesrc_get_query_types), (gst_fakesrc_get_event_mask):
Replace GST_PAD_EVENT_MASK_FUNCTION() (et al.) with its
expansion.
* gst/elements/gstfilesink.c: (gst_filesink_get_formats),
(gst_filesink_get_query_types): same
* gst/elements/gstfilesrc.c: (gst_filesrc_get_event_mask),
(gst_filesrc_get_query_types), (gst_filesrc_get_formats): same
* gst/gstcaps.h: deprecate GST_DEBUG_CAPS(), and fix the macro
to use new GST_PTR_FORMAT.
* gst/gstelement.h: deprecate function factory macros
GST_ELEMENT_QUERY_TYPE_FUNCTION(), GST_ELEMENT_EVENT_MASK_FUNCTION().
These are our last variadic macros that can't be replaced with
inlines.  Celebrate!  Also fix a typo in an #ifdef that was
attempting to deprecate gst_element_clock_wait().
* gst/gstevent.h: same
* gst/gstpad.c: (gst_pad_link_intersect), (gst_pad_link_fixate),
(gst_pad_try_set_caps): replace GST_DEBUG_CAPS() with GST_DEBUG()
* gst/gstpad.h: deprecate function factory macros similar to above.

20 years agodistcheck fix
Thomas Vander Stichele [Wed, 4 Feb 2004 19:09:08 +0000 (19:09 +0000)]
distcheck fix

Original commit message from CVS:
distcheck fix

20 years agoadd -common package with frontend scripts
Thomas Vander Stichele [Wed, 4 Feb 2004 18:46:26 +0000 (18:46 +0000)]
add -common package with frontend scripts

Original commit message from CVS:
add -common package with frontend scripts

20 years agoreturn after printing versions
Thomas Vander Stichele [Wed, 4 Feb 2004 18:37:48 +0000 (18:37 +0000)]
return after printing versions

Original commit message from CVS:
return after printing versions

20 years agoinstall docs versioned
Thomas Vander Stichele [Wed, 4 Feb 2004 18:27:39 +0000 (18:27 +0000)]
install docs versioned

Original commit message from CVS:
install docs versioned

20 years agoadd gst-run wrapper code build original tools as versioned tools
Thomas Vander Stichele [Wed, 4 Feb 2004 18:02:55 +0000 (18:02 +0000)]
add gst-run wrapper code build original tools as versioned tools

Original commit message from CVS:
add gst-run wrapper code
build original tools as versioned tools

20 years agogst/gstevent.c: actually break; inside the switch statement
Benjamin Otte [Wed, 4 Feb 2004 17:24:23 +0000 (17:24 +0000)]
gst/gstevent.c: actually break; inside the switch statement

Original commit message from CVS:
2004-02-04  Benjamin Otte  <in7y118@public.uni-hamburg.de>

* gst/gstevent.c: (_gst_event_free):
actually break; inside the switch statement
* gst/parse/grammar.y:
fix memleak where GValues weren't unset

20 years agogst/gststructure.c: fix huge memleak
Benjamin Otte [Tue, 3 Feb 2004 22:13:13 +0000 (22:13 +0000)]
gst/gststructure.c: fix huge memleak

Original commit message from CVS:
2004-02-03  Benjamin Otte  <in7y118@public.uni-hamburg.de>

* gst/gststructure.c: (gst_structure_from_string):
fix huge memleak
* gst/elements/gsttypefind.c: (gst_type_find_element_have_type),
(new_entry), (gst_type_find_element_chain):
* gst/gstelement.c: (gst_element_base_class_init),
(gst_element_class_set_details):
* gst/gstpad.c: (gst_pad_can_link_filtered):
fix smaller memleaks
* gst/gstpad.c: (gst_real_pad_dispose):
check that explicit caps are gone
* gst/gststructure.c: (gst_structure_free):
actually free the structure
* gst/gstelement.c: (gst_element_clear_pad_caps):
unset explicit caps

20 years agomore simplifying
Thomas Vander Stichele [Tue, 3 Feb 2004 18:29:36 +0000 (18:29 +0000)]
more simplifying

Original commit message from CVS:
more simplifying

20 years agouse AM_CFLAGS
Thomas Vander Stichele [Tue, 3 Feb 2004 18:26:03 +0000 (18:26 +0000)]
use AM_CFLAGS

Original commit message from CVS:
use AM_CFLAGS

20 years agofix debug message
Thomas Vander Stichele [Tue, 3 Feb 2004 15:01:46 +0000 (15:01 +0000)]
fix debug message

Original commit message from CVS:
fix debug message

20 years agoadd GstPoptOption to work around evil poptOption struct def make sure popt is i18n...
Thomas Vander Stichele [Tue, 3 Feb 2004 14:59:32 +0000 (14:59 +0000)]
add GstPoptOption to work around evil poptOption struct def make sure popt is i18n'd expand gnome example

Original commit message from CVS:
add GstPoptOption to work around evil poptOption struct def
make sure popt is i18n'd
expand gnome example

20 years agoadd error symbol start translating gst-inspect
Thomas Vander Stichele [Tue, 3 Feb 2004 11:23:59 +0000 (11:23 +0000)]
add error symbol start translating gst-inspect

Original commit message from CVS:
add error symbol
start translating gst-inspect

20 years agofixing docs errors
Thomas Vander Stichele [Tue, 3 Feb 2004 10:47:26 +0000 (10:47 +0000)]
fixing docs errors

Original commit message from CVS:
fixing docs errors

20 years agogst/: get rid of gstmarshal.h dependency. It's not needed.
Benjamin Otte [Tue, 3 Feb 2004 03:31:26 +0000 (03:31 +0000)]
gst/: get rid of gstmarshal.h dependency. It's not needed.

Original commit message from CVS:
2004-02-03  Benjamin Otte  <in7y118@public.uni-hamburg.de>

* gst/parse/Makefile.am:
* gst/gstobject.h:
get rid of gstmarshal.h dependency. It's not needed.
* gst/gst.h:
* gst/elements/gstfakesink.c:
* gst/elements/gstfakesrc.c:
* gst/elements/gstidentity.c:
* gst/gstbin.c:
* gst/gstelement.c:
* gst/gstindex.c:
* gst/gstobject.c:
* gst/gstpad.c:
* gst/gstthread.c:
* gst/gstxml.c:
* libs/gst/control/dparam.c:
* libs/gst/control/dparammanager.c:
include gstmarshal.h.
Fixes #132045

20 years agogst/elements/gstfilesrc.*: don't ref the filesrc when creating mmaped buffers. Don...
Benjamin Otte [Tue, 3 Feb 2004 00:27:09 +0000 (00:27 +0000)]
gst/elements/gstfilesrc.*: don't ref the filesrc when creating mmaped buffers. Don't keep a list of not-yet-destroyed...

Original commit message from CVS:
2004-02-03  Benjamin Otte  <in7y118@public.uni-hamburg.de>

* gst/elements/gstfilesrc.c: (gst_filesrc_init),
(gst_filesrc_dispose), (gst_filesrc_free_parent_mmap),
(gst_filesrc_map_region), (gst_filesrc_get_mmap):
* gst/elements/gstfilesrc.h:
don't ref the filesrc when creating mmaped buffers. Don't keep a
list of not-yet-destroyed buffers.
* gst/gstbuffer.h:
Deprecated BST_BUFFER_FREE_FUNC and GST_BUFFER_COPY_FUNC

20 years agoremove textdomain call
Thomas Vander Stichele [Mon, 2 Feb 2004 22:01:23 +0000 (22:01 +0000)]
remove textdomain call

Original commit message from CVS:
remove textdomain call

20 years agodocs/pwg/: All sort of documentation... Forgot what. Point is that I want this in...
Ronald S. Bultje [Mon, 2 Feb 2004 21:52:46 +0000 (21:52 +0000)]
docs/pwg/: All sort of documentation... Forgot what. Point is that I want this in before I leave. The 'other-*' will ...

Original commit message from CVS:
2004-02-02  Ronald Bultje  <rbultje@ronald.bitfreak.net>

* docs/pwg/advanced-events.xml:
* docs/pwg/advanced-scheduling.xml:
* docs/pwg/intro-basics.xml:
* docs/pwg/other-manager.xml:
* docs/pwg/other-nton.xml:
* docs/pwg/other-ntoone.xml:
* docs/pwg/other-oneton.xml:
* docs/pwg/pwg.xml:
All sort of documentation... Forgot what. Point is that I want this
in before I leave. The 'other-*' will be the last section and will
explain issues specific to these type of elements.

20 years agogst/elements/gstfilesrc.c: set all the values on buffers that we can
Benjamin Otte [Mon, 2 Feb 2004 21:18:54 +0000 (21:18 +0000)]
gst/elements/gstfilesrc.c: set all the values on buffers that we can

Original commit message from CVS:
2004-02-02  Benjamin Otte  <in7y118@public.uni-hamburg.de>

* gst/elements/gstfilesrc.c: (gst_filesrc_map_region),
(gst_filesrc_get_read):
set all the values on buffers that we can

20 years agoChange usage of isblah() to g_ascii_isblah() to be more locale independent. (#133076)
David Schleef [Mon, 2 Feb 2004 21:08:52 +0000 (21:08 +0000)]
Change usage of isblah() to g_ascii_isblah() to be more locale independent.  (#133076)

Original commit message from CVS:
Change usage of isblah() to g_ascii_isblah() to be more locale
independent.  (#133076)
* gst/gsturi.c: (gst_uri_protocol_check_internal):
* gst/gstutils.c:
* gst/parse/parse.l:

20 years agoFix memory leaks:
David Schleef [Mon, 2 Feb 2004 20:25:02 +0000 (20:25 +0000)]
Fix memory leaks:

Original commit message from CVS:
reviewed by: David Schleef  <ds@schleef.org>
Fix memory leaks:
* gst/gstcaps.c: (gst_caps_to_string):
* gst/registries/gstxmlregistry.c:
(gst_xml_registry_add_path_list_func),
(gst_xml_registry_parse_padtemplate):

20 years agosuffix error with period
Thomas Vander Stichele [Mon, 2 Feb 2004 17:29:30 +0000 (17:29 +0000)]
suffix error with period

Original commit message from CVS:
suffix error with period

20 years agoreinclude accidentally deleted line
Benjamin Otte [Mon, 2 Feb 2004 17:25:45 +0000 (17:25 +0000)]
reinclude accidentally deleted line

Original commit message from CVS:
reinclude accidentally deleted line

20 years agosuffix errors with .
Thomas Vander Stichele [Sat, 31 Jan 2004 22:40:27 +0000 (22:40 +0000)]
suffix errors with .

Original commit message from CVS:
suffix errors with .
update translation

20 years agosuffix errors with period.
Thomas Vander Stichele [Sat, 31 Jan 2004 19:30:31 +0000 (19:30 +0000)]
suffix errors with period.

Original commit message from CVS:
suffix errors with period.
use (NULL) over NULL

20 years agoadd path for element throwing error
Thomas Vander Stichele [Sat, 31 Jan 2004 19:09:38 +0000 (19:09 +0000)]
add path for element throwing error

Original commit message from CVS:
add path for element throwing error

20 years agodocs/random/mimetypes: update raw int/float info
Benjamin Otte [Sat, 31 Jan 2004 11:17:43 +0000 (11:17 +0000)]
docs/random/mimetypes: update raw int/float info

Original commit message from CVS:
2004-01-31  Benjamin Otte  <in7y118@public.uni-hamburg.de>

* docs/random/mimetypes:
update raw int/float info
* gst/gsttag.c: (_gst_tag_initialize):
* gst/gsttag.h:
add GST_TAG_ENCODER

20 years agogst/cothreads.c: Add another fallback if MAP_ANONYMOUS is missing (#132991)
David Schleef [Fri, 30 Jan 2004 21:26:15 +0000 (21:26 +0000)]
gst/cothreads.c: Add another fallback if MAP_ANONYMOUS is missing (#132991)

Original commit message from CVS:
* gst/cothreads.c: Add another fallback if MAP_ANONYMOUS is
missing (#132991)

20 years agoparts of the patch submitted in bug #113913
Benjamin Otte [Fri, 30 Jan 2004 20:48:13 +0000 (20:48 +0000)]
parts of the patch submitted in bug #113913

Original commit message from CVS:
2004-01-30  Laurent Vivier <Laurent.Vivier@bull.net>

reviewed by Benjamin Otte
parts of the patch submitted in bug #113913

* configure.ac:
use AC_C_INLINE. Use = instead of == with test
* examples/plugins/example.c:
* gst/autoplug/gstspideridentity.c:
* gst/elements/gstfdsrc.c:
* gst/elements/gstfilesrc.c:
* gst/elements/gstidentity.c:
* gst/elements/gstmultidisksrc.c:
* gst/elements/gststatistics.c:
* gst/gstelement.c:
* gst/gstobject.c:
* gst/gstpad.c:
* gst/gstpipeline.c:
* gst/gstthread.c:
don't end enums with a comma
* gst/gstindex.c: (gst_index_compare_func):
do explicit casting to gint
* gst/gsttrace.c: (gst_trace_text_flush):
#define strsize as a macro

20 years agofixing up double symbols
Thomas Vander Stichele [Fri, 30 Jan 2004 19:11:50 +0000 (19:11 +0000)]
fixing up double symbols

Original commit message from CVS:
fixing up double symbols

20 years agomake sure all API gets built sync .c with .h
Thomas Vander Stichele [Fri, 30 Jan 2004 19:06:13 +0000 (19:06 +0000)]
make sure all API gets built sync .c with .h

Original commit message from CVS:
make sure all API gets built
sync .c with .h

20 years agocvsignore updates
Benjamin Otte [Fri, 30 Jan 2004 17:59:15 +0000 (17:59 +0000)]
cvsignore updates

Original commit message from CVS:
cvsignore updates

20 years agothird time I try commiting this today, let's hope I watch the result this time
Thomas Vander Stichele [Fri, 30 Jan 2004 17:01:46 +0000 (17:01 +0000)]
third time I try commiting this today, let's hope I watch the result this time

Original commit message from CVS:
third time I try commiting this today, let's hope I watch the result this time

20 years agoadd pro audio doc
Andy Wingo [Fri, 30 Jan 2004 14:19:46 +0000 (14:19 +0000)]
add pro audio doc

Original commit message from CVS:
add pro audio doc

20 years agolibs/gst/bytestream/bytestream.c: Reverting my event handling patch.
Julien Moutte [Fri, 30 Jan 2004 12:14:34 +0000 (12:14 +0000)]
libs/gst/bytestream/bytestream.c: Reverting my event handling patch.

Original commit message from CVS:
2004-01-30  Julien Moutte  <julien@moutte.net>

* libs/gst/bytestream/bytestream.c: Reverting my event handling patch.
Ronald will fix riffread.

20 years agoReverting my fix so that ronald can fix rifflib
Julien Moutte [Fri, 30 Jan 2004 12:00:28 +0000 (12:00 +0000)]
Reverting my fix so that ronald can fix rifflib

Original commit message from CVS:
Reverting my fix so that ronald can fix rifflib

20 years agodocs/pwg/advanced-interfaces.xml: Added tuner interface docs.
Ronald S. Bultje [Fri, 30 Jan 2004 12:00:16 +0000 (12:00 +0000)]
docs/pwg/advanced-interfaces.xml: Added tuner interface docs.

Original commit message from CVS:
2004-01-30  Ronald Bultje  <rbultje@ronald.bitfreak.net>

* docs/pwg/advanced-interfaces.xml:
Added tuner interface docs.

20 years agoseriously, using cvs over slow lines just sucks.
Thomas Vander Stichele [Fri, 30 Jan 2004 07:58:54 +0000 (07:58 +0000)]
seriously, using cvs over slow lines just sucks.

Original commit message from CVS:
seriously, using cvs over slow lines just sucks.
*sigh*, finishing commit

20 years agodocs/random/mimetypes: correct Theora information
Benjamin Otte [Fri, 30 Jan 2004 03:54:08 +0000 (03:54 +0000)]
docs/random/mimetypes: correct Theora information

Original commit message from CVS:
2004-01-30  Benjamin Otte  <in7y118@public.uni-hamburg.de>

* docs/random/mimetypes:
correct Theora information
* gst/gstelement.h:
make GST_ELEMENT_ERROR do a GST_ERROR_OBJECT

20 years agoGST_ELEMENT_ERROR
Thomas Vander Stichele [Thu, 29 Jan 2004 23:17:58 +0000 (23:17 +0000)]
GST_ELEMENT_ERROR

Original commit message from CVS:
GST_ELEMENT_ERROR

20 years agogst/elements/gstfilesrc.c: Fixing seeking by making FLUSH happen again and even befor...
Julien Moutte [Thu, 29 Jan 2004 22:43:41 +0000 (22:43 +0000)]
gst/elements/gstfilesrc.c: Fixing seeking by making FLUSH happen again and even before DISCONT.

Original commit message from CVS:
2004-01-29  Julien MOUTTE  <julien@moutte.net>

* gst/elements/gstfilesrc.c: (gst_filesrc_get),
(gst_filesrc_uri_handler_init): Fixing seeking by making FLUSH happen
again and even before DISCONT.
* gst/gstpad.c: (gst_pad_event_default): Remove a unused switch case.
* libs/gst/bytestream/bytestream.c: (gst_bytestream_get_next_buf): Fix
bytestream so that it's not stopping to fill the bytestream if events
different than EOS or DISCONT are received. Instead it process them so
that they go downstream.

20 years agofix non-validating docbook make sure validation gets checked before building
Thomas Vander Stichele [Thu, 29 Jan 2004 17:25:18 +0000 (17:25 +0000)]
fix non-validating docbook make sure validation gets checked before building

Original commit message from CVS:
fix non-validating docbook
make sure validation gets checked before building

20 years agodocs/pwg/advanced-events.xml: Adding documentation on advanced event handling (up...
Julien Moutte [Thu, 29 Jan 2004 12:46:19 +0000 (12:46 +0000)]
docs/pwg/advanced-events.xml: Adding documentation on advanced event handling (up and downstream).

Original commit message from CVS:
2004-01-29  Julien MOUTTE <julien@moutte.net>

* docs/pwg/advanced-events.xml: Adding documentation on advanced event
handling (up and downstream).
* docs/pwg/advanced-interfaces.xml: Make it coherent with the
my_filter thing.

20 years agodocs/pwg/advanced-tagging.xml: Add docs about tag writing.
Ronald S. Bultje [Thu, 29 Jan 2004 12:35:01 +0000 (12:35 +0000)]
docs/pwg/advanced-tagging.xml: Add docs about tag writing.

Original commit message from CVS:
2004-01-29  Ronald Bultje  <rbultje@ronald.bitfreak.net>

* docs/pwg/advanced-tagging.xml:
Add docs about tag writing.

20 years agoUgh, stupid shift
Ronald S. Bultje [Thu, 29 Jan 2004 11:00:25 +0000 (11:00 +0000)]
Ugh, stupid shift

Original commit message from CVS:
Ugh, stupid shift

20 years agodocs/pwg/advanced-tagging.xml: Add a part about tag reading and application signallin...
Ronald S. Bultje [Thu, 29 Jan 2004 10:56:53 +0000 (10:56 +0000)]
docs/pwg/advanced-tagging.xml: Add a part about tag reading and application signalling... Tag writing still needs to ...

Original commit message from CVS:
2004-01-29  Ronald Bultje  <rbultje@ronald.bitfreak.net>

* docs/pwg/advanced-tagging.xml:
Add a part about tag reading and application signalling... Tag
writing still needs to be documented.
* gst/elements/gstfilesrc.c: (gst_filesrc_set_location):
We can set file locations in READY, too.

20 years agodocs/random/ds/element-checklist: Adding some notes about src events.
Julien Moutte [Thu, 29 Jan 2004 10:35:29 +0000 (10:35 +0000)]
docs/random/ds/element-checklist: Adding some notes about src events.

Original commit message from CVS:
2004-01-29  Julien MOUTTE <julien@moutte.net>

* docs/random/ds/element-checklist: Adding some notes about src
events.

20 years agodocs/random/mimetypes: Update docs to point to correct elements for various mimetypes...
Ronald S. Bultje [Thu, 29 Jan 2004 09:28:58 +0000 (09:28 +0000)]
docs/random/mimetypes: Update docs to point to correct elements for various mimetypes, and some more errors pointed o...

Original commit message from CVS:
2004-01-29  Ronald Bultje  <rbultje@ronald.bitfreak.net>

* docs/random/mimetypes:
Update docs to point to correct elements for various mimetypes, and
some more errors pointed out by Stéphane LOEUILLET (aka LeRoutier)
<stephane.loeuillet@tiscali.fr>.

20 years agodocs/pwg/intro-basics.xml: rewrite bufferpool stuff.
David Schleef [Thu, 29 Jan 2004 03:05:56 +0000 (03:05 +0000)]
docs/pwg/intro-basics.xml: rewrite bufferpool stuff.

Original commit message from CVS:
* docs/pwg/intro-basics.xml: rewrite bufferpool stuff.

20 years agodocs/random/mimetypes: update docs for audio/x-raw-float. Add "buffer-frames=0 means...
Benjamin Otte [Thu, 29 Jan 2004 02:24:52 +0000 (02:24 +0000)]
docs/random/mimetypes: update docs for audio/x-raw-float. Add "buffer-frames=0 means undefined"

Original commit message from CVS:
2004-01-29  Benjamin Otte  <in7y118@public.uni-hamburg.de>

* docs/random/mimetypes:
update docs for audio/x-raw-float. Add "buffer-frames=0 means
undefined"
* gst/elements/gstfilesrc.c: (gst_filesrc_set_location):
make it only work in NULL.
* gst/gstcaps.c:
don't posion NULL caps
* gst/gstelement.c: (gst_element_set_time):
add debugging statement
* gst/gstelement.c: (gst_element_emit_found_tag),
(gst_element_found_tag_func), (gst_element_found_tags):
* gst/gstelement.h:
These functions take const taglists
* gst/gstpad.c: (gst_pad_proxy_getcaps):
fix memleak
* gst/gstpad.c: (gst_pad_event_default):
make more effort on handling discont and clocks, g_warn if everything
fails
* gst/gststructure.c: (gst_structure_remove_fields),
(gst_structure_remove_fields_valist):
* gst/gststructure.h:
add gst_structure_remove_fields(_valist)
* gst/gsttag.c:
fix doc glitch

20 years agodocs/random/ds/element-checklist: Notes about gst_caps_to_string()
David Schleef [Thu, 29 Jan 2004 01:44:08 +0000 (01:44 +0000)]
docs/random/ds/element-checklist: Notes about gst_caps_to_string()

Original commit message from CVS:
* docs/random/ds/element-checklist: Notes about gst_caps_to_string()
* gst/registries/gstxmlregistry.c: (gst_xml_registry_save_caps):
Fix memory leakage of gst_caps_to_string().
Use GST_PTR_FORMAT instead of gst_caps_to_string():
* gst/autoplug/gstsearchfuncs.c: (gst_autoplug_sp):
* gst/autoplug/gstspideridentity.c: (spider_find_suggest),
(gst_spider_identity_sink_loop_type_finding):
* gst/elements/gsttypefind.c: (gst_type_find_element_have_type),
(find_suggest):
* gst/gstpad.c: (gst_pad_try_relink_filtered),
(gst_pad_set_explicit_caps):
* gst/parse/grammar.y:

20 years agoconfigure.ac: Add detection for HAVE_PRINTF_EXTENSION and
David Schleef [Thu, 29 Jan 2004 01:20:23 +0000 (01:20 +0000)]
configure.ac: Add detection for HAVE_PRINTF_EXTENSION and

Original commit message from CVS:
* configure.ac: Add detection for HAVE_PRINTF_EXTENSION and
GST_PRINTF_EXTENSION_FORMAT_DEFINE.
* docs/random/ds/0.9-suggested-changes: Notes from Company.
* gst/gstcaps.c: (gst_caps_to_string): Add comment.
* gst/gstconfig.h.in: Add define for GST_PTR_FORMAT
* gst/gstinfo.c: (_gst_debug_init), (gst_debug_print_object),
(gst_debug_log_default), (_gst_info_printf_extension),
(_gst_info_printf_extension_arginfo):  Add printf extension.
* gst/gstinfo.h: remove G_GNUC_PRINTF, because it doesn't work with %P
* gst/gststructure.c: (gst_structure_to_string),
(_gst_structure_parse_value): Use gst_value_deserialize() and
remove old code.
* gst/gstvalue.c: (gst_value_deserialize_fourcc),
(gst_value_deserialize_boolean), (gst_strtoi),
(gst_value_deserialize_int), (gst_value_deserialize_double),
(gst_value_deserialize_string), (gst_value_deserialize): Implement
a bunch of deserialize functions and gst_value_deserialize.
* gst/gstvalue.h: er, _de_serialize, not unserialize
* testsuite/caps/string-conversions.c: (main): We don't currently
handle (float) in caps, so convert these to (double).
* testsuite/debug/Makefile.am: Add new test for the printf extension
* testsuite/debug/printf_extension.c: (main): same

20 years agodocs/random/company/time: Add some docs about clocking and time
Benjamin Otte [Wed, 28 Jan 2004 22:02:22 +0000 (22:02 +0000)]
docs/random/company/time: Add some docs about clocking and time

Original commit message from CVS:
2004-01-28  Benjamin Otte  <in7y118@public.uni-hamburg.de>

* docs/random/company/time:
Add some docs about clocking and time

20 years agodocs/pwg/advanced-interfaces.xml: Adding XOverlay documentation.
Julien Moutte [Wed, 28 Jan 2004 17:45:47 +0000 (17:45 +0000)]
docs/pwg/advanced-interfaces.xml: Adding XOverlay documentation.

Original commit message from CVS:
2004-01-28  Julien MOUTTE <julien@moutte.net>

* docs/pwg/advanced-interfaces.xml: Adding XOverlay documentation.

20 years agofix up id's
Thomas Vander Stichele [Wed, 28 Jan 2004 15:51:14 +0000 (15:51 +0000)]
fix up id's

Original commit message from CVS:
fix up id's