platform/upstream/dotnet/runtime.git
7 years agoImprove GenTreeUseEdgeIterator.
Pat Gavlin [Thu, 9 Mar 2017 02:45:17 +0000 (18:45 -0800)]
Improve GenTreeUseEdgeIterator.

Instead of executing a rather long set of conditionals on each call
to `GenTreeUseEdge::operator++`, decide on the function that will be
used to advance the iterator's state in the constructor.

Commit migrated from https://github.com/dotnet/coreclr/commit/b8ad6487ad0912ae658395df2e85130d61d9d049

7 years agoMerge pull request dotnet/coreclr#10220 from dotnet/revert-10206-MultiQueue
Gaurav Khanna [Sat, 18 Mar 2017 04:35:47 +0000 (21:35 -0700)]
Merge pull request dotnet/coreclr#10220 from dotnet/revert-10206-MultiQueue

Revert "Add support for Multiqueing jobs in Helix"

Commit migrated from https://github.com/dotnet/coreclr/commit/880fdbad68e4a587c2e1b136839bb5cf0b74cf09

7 years agoMerge pull request dotnet/coreclr#10274 from AndyAyersMS/FixMoreCasing
Andy Ayers [Sat, 18 Mar 2017 04:04:56 +0000 (21:04 -0700)]
Merge pull request dotnet/coreclr#10274 from AndyAyersMS/FixMoreCasing

Fix yet another casing issue.

Commit migrated from https://github.com/dotnet/coreclr/commit/80c5747c17856d74689a56228405ef586ea629b1

7 years agoFix overflow when computing dwWeight in CPUGroupInfo::InitCPUGroupInfoArray (dotnet...
Han Lee [Sat, 18 Mar 2017 03:26:06 +0000 (20:26 -0700)]
Fix overflow when computing dwWeight in CPUGroupInfo::InitCPUGroupInfoArray (dotnet/coreclr#10104)

Fix overflow in dwWeight when there are large number of CPU groups

Commit migrated from https://github.com/dotnet/coreclr/commit/d8e91d3febea933dce2bb2e0825ffcea1c76480d

7 years agoMerge pull request dotnet/coreclr#10241 from briansull/refactor1
Brian Sullivan [Sat, 18 Mar 2017 01:01:26 +0000 (18:01 -0700)]
Merge pull request dotnet/coreclr#10241 from briansull/refactor1

Refactor the flag test of BBF_PROF_WEIGHT

Commit migrated from https://github.com/dotnet/coreclr/commit/a761b9b985f60be14deadd9015313f8d2a34033d

7 years agoFix triggers for ILLINK job (dotnet/coreclr#10244)
Swaroop Sridhar [Sat, 18 Mar 2017 00:13:34 +0000 (17:13 -0700)]
Fix triggers for ILLINK job (dotnet/coreclr#10244)

This change has the following fixes:
1) Fix the trigger phrase for ILLink jobs so that PRs can request ILLink runs per architecture.

2) Pass the linker location explicitly on the runtest.cmd command line
instead of using the %ILLink% variable, since the build/run steps
are different command shells.

3) Don't run the x86compatijit configuration daily in the lab

Commit migrated from https://github.com/dotnet/coreclr/commit/65f6120ddd0197076f3cd247f273c213a0a78272

7 years agoFix yet another casing issue.
Andy Ayers [Fri, 17 Mar 2017 23:58:23 +0000 (16:58 -0700)]
Fix yet another casing issue.

This might be what is causing the TFS mirror to have hiccups.

Commit migrated from https://github.com/dotnet/coreclr/commit/1a3cc212885cc302ccabf967ea640c4f1c971fe6

7 years agoFileStream.Unix: open with CLOEXEC unless FileShare.Inheritable set (dotnet/coreclr...
Tom Deseyn [Fri, 17 Mar 2017 23:54:45 +0000 (00:54 +0100)]
FileStream.Unix: open with CLOEXEC unless FileShare.Inheritable set (dotnet/coreclr#10251)

* FileStream.Unix: open with CLOEXEC unless FileShare.Inheritable set

* PR feedback

Commit migrated from https://github.com/dotnet/coreclr/commit/f29a051ee1829937cde011ee28bbd17557d35e0b

7 years agoMerge pull request dotnet/coreclr#10238 from pgavlin/SeekUnrollLimit
Pat Gavlin [Fri, 17 Mar 2017 21:39:09 +0000 (14:39 -0700)]
Merge pull request dotnet/coreclr#10238 from pgavlin/SeekUnrollLimit

Reduce case iteration counts in SeekUnroll.

Commit migrated from https://github.com/dotnet/coreclr/commit/dc2f78c071cc68e5925e47a1162b2187d0f8c216

7 years agoRefactor the flag test of BBF_PROF_WEIGHT
Brian Sullivan [Thu, 16 Mar 2017 23:45:17 +0000 (16:45 -0700)]
Refactor the flag test of BBF_PROF_WEIGHT
to always call the new method hasProfileWeight()

Commit migrated from https://github.com/dotnet/coreclr/commit/8602b75d969b542e98afd92f56a328c4480bb317

7 years agoMerge pull request dotnet/coreclr#10259 from AndyAyersMS/FixNoway
Andy Ayers [Fri, 17 Mar 2017 21:01:28 +0000 (14:01 -0700)]
Merge pull request dotnet/coreclr#10259 from AndyAyersMS/FixNoway

JIT: Fix noway_assert when inlining

Commit migrated from https://github.com/dotnet/coreclr/commit/408390ebf141738118924db3694bc487c8634f56

7 years agoMerge pull request dotnet/coreclr#10263 from dotnet-bot/from-tfs
Andy Ayers [Fri, 17 Mar 2017 21:01:18 +0000 (14:01 -0700)]
Merge pull request dotnet/coreclr#10263 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/5ab3b019f9ffbfb83378b4c6bf3478d7450e5227

7 years agoMerge pull request dotnet/coreclr#10260 from sdmaclea/PR-ARM64-REMOVE-X19-WORKAROUND
Rahul Kumar [Fri, 17 Mar 2017 20:26:00 +0000 (13:26 -0700)]
Merge pull request dotnet/coreclr#10260 from sdmaclea/PR-ARM64-REMOVE-X19-WORKAROUND

[Arm64/Unix] Remove x19 corruption workaround

Commit migrated from https://github.com/dotnet/coreclr/commit/f716e452863e6d988959813d3f07a087eb87500f

7 years agoClean up GenTreePutArgStk (dotnet/coreclr#10239)
Bruce Forstall [Fri, 17 Mar 2017 20:01:47 +0000 (13:01 -0700)]
Clean up GenTreePutArgStk (dotnet/coreclr#10239)

Consolidate constructors; go from 4 to 2.

Reduce `#ifdef` in callers.

Commit migrated from https://github.com/dotnet/coreclr/commit/008aacc003c9b49f8780196df3b653b03b93f09e

7 years agoMerge pull request dotnet/coreclr#10245 from rahku/fix10048
Rahul Kumar [Fri, 17 Mar 2017 19:49:57 +0000 (12:49 -0700)]
Merge pull request dotnet/coreclr#10245 from rahku/fix10048

LoadFromStream should throw badimageformat early on

Commit migrated from https://github.com/dotnet/coreclr/commit/b6aec9bd4b6e5e026669cd7432b3f37aeec14190

7 years agoLoadFromStream should throw badimageformat early on
Rahul Kumar [Fri, 17 Mar 2017 03:27:58 +0000 (20:27 -0700)]
LoadFromStream should throw badimageformat early on

Commit migrated from https://github.com/dotnet/coreclr/commit/9dceb5b8f105ec45c647c201f3fa9fff88d28bcd

7 years agoMerge pull request dotnet/coreclr#10253 from dotnet/mirror-merge-9051394
Jan Kotas [Fri, 17 Mar 2017 19:43:40 +0000 (12:43 -0700)]
Merge pull request dotnet/coreclr#10253 from dotnet/mirror-merge-9051394

Mirror changes from dotnet/corert

Commit migrated from https://github.com/dotnet/coreclr/commit/2f302a2afb57087418c882e85d5cefd4b3cacd81

7 years agofix syntax error in build.sh (dotnet/coreclr#10256)
Buyduck [Fri, 17 Mar 2017 19:38:35 +0000 (22:38 +0300)]
fix syntax error in build.sh (dotnet/coreclr#10256)

Commit migrated from https://github.com/dotnet/coreclr/commit/5befe83dd00b365407945a11db1e03619f415aa1

7 years agoDelete unused ReferenceLocalMscorlib property from test proj files (dotnet/coreclr...
Jan Kotas [Fri, 17 Mar 2017 18:44:10 +0000 (11:44 -0700)]
Delete unused ReferenceLocalMscorlib property from test proj files (dotnet/coreclr#10250)

Deleted a few other irrelevant properties as well while I was on it.

Fixes dotnet/coreclr#7711

Commit migrated from https://github.com/dotnet/coreclr/commit/25dbd547bc7372906357699a24d7cf76786a50c8

7 years agoAdd reflection roots for tests calling CreateInstance() (dotnet/coreclr#10242)
Swaroop Sridhar [Fri, 17 Mar 2017 18:22:18 +0000 (11:22 -0700)]
Add reflection roots for tests calling CreateInstance() (dotnet/coreclr#10242)

Add the XML files identifying the reflection roots to keep the
type (and constructors threof) which are used by tests as
Activator.CreateInstance(typeof(T))

Commit migrated from https://github.com/dotnet/coreclr/commit/d1bdbf1bee3ecdbcd96a5a78a45bf097e3a38951

7 years agofix formatting
Andy Ayers [Fri, 17 Mar 2017 18:09:55 +0000 (11:09 -0700)]
fix formatting

Commit migrated from https://github.com/dotnet/coreclr/commit/2bd4aa3cb112f5403163e8d9266f3027bec86895

7 years agoMerge pull request dotnet/coreclr#10192 from AndyAyersMS/InterfaceDevirt
Andy Ayers [Fri, 17 Mar 2017 18:04:35 +0000 (11:04 -0700)]
Merge pull request dotnet/coreclr#10192 from AndyAyersMS/InterfaceDevirt

Interface devirt

Commit migrated from https://github.com/dotnet/coreclr/commit/8208cb59f24c43444c0049e8f3f39d3f6a34b647

7 years agoAddress feedback.
Pat Gavlin [Fri, 17 Mar 2017 18:02:24 +0000 (11:02 -0700)]
Address feedback.

Commit migrated from https://github.com/dotnet/coreclr/commit/287464997f594f3468e59598e08fee08f697ee44

7 years ago[Arm64/Unix] Remove x19 corruption workaround
Steve MacLean, Qualcomm Datacenter Technologies, Inc [Thu, 16 Mar 2017 16:20:39 +0000 (16:20 +0000)]
[Arm64/Unix] Remove x19 corruption workaround

Commit migrated from https://github.com/dotnet/coreclr/commit/c479cc7ed5d049aa0f085dfdc4484c399a6a7187

7 years agoJIT: Fix noway_assert when inlining
Andy Ayers [Fri, 17 Mar 2017 07:21:50 +0000 (00:21 -0700)]
JIT: Fix noway_assert when inlining

The jit keeps track of which inline arguments can be modified via starg
during the inlinee IL prescan to ensure that a temp is used to represent
such arguments in the inlined body. There is a noway_assert the a starg
is procecssed during importation that double-checks that a temp is really
being used, and this assert was firing.

The prescan guraded the starg tracking with a check to avoid an out-of-bounds
write into the argument table when scanning bad IL with bogus argument numbers.
The predicate was checking the argument number against lvaTableCount.
Unfortunately for inlinees this value is not related to the number of arguments.
In particular it some rare cases it may be an underestimate so the prescan might
end up failing to note a starg. If the the jit then tries to inline and the
caller passes a constant, the assert will then fire.

Fix is to update the guard to use the number of callee arguments. This is
known to be less than the table size by earlier checks.

Added a test case.

Closes dotnet/coreclr#9891.

Commit migrated from https://github.com/dotnet/coreclr/commit/0380bad51faf5ef608208f1ead8294dcf8519ce0

7 years agoDelete moved files
Jan Kotas [Fri, 17 Mar 2017 17:19:33 +0000 (10:19 -0700)]
Delete moved files

Commit migrated from https://github.com/dotnet/coreclr/commit/cefbfbd3d9b0c0ce1efc0b5c51ae0a9ec0fdc0c6

7 years agoAttribute the other types used by FileStream. Adds the internal methods the old CoreF...
Jeremy Kuhne [Fri, 17 Mar 2017 00:21:10 +0000 (17:21 -0700)]
Attribute the other types used by FileStream. Adds the internal methods the old CoreFX uses.

https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=396302&_a=edit

[tfs-changeset: 1651151]

Commit migrated from https://github.com/dotnet/coreclr/commit/6cc92a84d44e14b3ff37fcd4f9bb504cf74e4aa5

7 years agoCompilerServices APIs
Fadi Hanna [Thu, 16 Mar 2017 23:10:28 +0000 (16:10 -0700)]
CompilerServices APIs

[tfs-changeset: 1651141]

Commit migrated from https://github.com/dotnet/coreclr/commit/9d2a4a9f30ca6a6d0d538548f7972e2c0d8cfeb8

7 years agoMerge pull request dotnet/coreclr#10248 from mikedn/fix-vnarrbound
Joseph Tremoulet [Fri, 17 Mar 2017 14:05:23 +0000 (10:05 -0400)]
Merge pull request dotnet/coreclr#10248 from mikedn/fix-vnarrbound

Fix ValueNumStore::IsVNArrLenUnsignedBound checks

Commit migrated from https://github.com/dotnet/coreclr/commit/e93885ed5ecf92c74056d5489add26dbcd527f1b

7 years agoMerge pull request dotnet/coreclr#10201 from cod7alex/add_csharp_editorconfig_codesty...
Tanner Gooding [Fri, 17 Mar 2017 13:50:00 +0000 (06:50 -0700)]
Merge pull request dotnet/coreclr#10201 from cod7alex/add_csharp_editorconfig_codestyle_settings

Added to .editorconfig csharp code style settings supported by VS 2017

Commit migrated from https://github.com/dotnet/coreclr/commit/ce118e5722bc647180d25bf946dd4b91629a0ab9

7 years ago[x86/Linux] Pass return buffer on reverse P/Invoke (dotnet/coreclr#10226)
Jonghyun Park [Fri, 17 Mar 2017 02:41:24 +0000 (11:41 +0900)]
[x86/Linux] Pass return buffer on reverse P/Invoke (dotnet/coreclr#10226)

* Pass return buffer on reverse P/Invoke

* Use PLATFORM_UNIX and track m_cbRetPop locally

* Declare cbRetPop UINT16 instead of int

Commit migrated from https://github.com/dotnet/coreclr/commit/bcc0a1d528b78f5e05bf7973090f33ef2403e685

7 years agoSupport devirtulization of Encoders (dotnet/coreclr#10229)
Ben Adams [Fri, 17 Mar 2017 01:36:22 +0000 (01:36 +0000)]
Support devirtulization of Encoders (dotnet/coreclr#10229)

* Seal more final inherited internal types

Commit migrated from https://github.com/dotnet/coreclr/commit/6a4a941248e22f9b97691879f16b6de5b4f8e6a1

7 years agoneed to account for the allocated bytes correctly for the following: (dotnet/coreclr...
Maoni Stephens [Fri, 17 Mar 2017 00:57:49 +0000 (17:57 -0700)]
need to account for the allocated bytes correctly for the following: (dotnet/coreclr#10162)

need to account for the allocated bytes accurately for the following cases

Commit migrated from https://github.com/dotnet/coreclr/commit/8bc067c194f0b44e95c6e6a490b99078a2fa9719

7 years agoMerge pull request dotnet/coreclr#10235 from dotnet/mirror-merge-9050192
Alex Perovich [Fri, 17 Mar 2017 00:44:20 +0000 (19:44 -0500)]
Merge pull request dotnet/coreclr#10235 from dotnet/mirror-merge-9050192

Mirror changes from dotnet/corert

Commit migrated from https://github.com/dotnet/coreclr/commit/0c3d8c7fa54bd77ef2df23b8364812affe8deb10

7 years agoMove the MemberInfo-derived Info classes to the shared partition. (dotnet/coreclr...
Atsushi Kanamori [Fri, 17 Mar 2017 00:23:51 +0000 (17:23 -0700)]
Move the MemberInfo-derived Info classes to the shared partition. (dotnet/coreclr#10236)

* Copy over CoreRt prose member by member.

* Transplant the CoreRt version of the files.

This is now just a reordering. Verified
by sorting the old and new versions of the
file and diffin.

* Move to shared partition.

* Looks like the #if FEATURE_COMINTEROP wasn't just for show...

Take EventInfo.cs back to unshared status for now...

Commit migrated from https://github.com/dotnet/coreclr/commit/c6b82ac3d83ecebc124d6a39065f4e6723aa320b

7 years ago[Local GC] Break EE dependency on GC's generation table and alloc lock in single...
Sean Gillespie [Fri, 17 Mar 2017 00:18:28 +0000 (17:18 -0700)]
[Local GC] Break EE dependency on GC's generation table and alloc lock in single-proc scenarios (dotnet/coreclr#10065)

* Remove usage of the generation table from the EE by introducing an
EE-owned GC alloc context used for allocations on single-proc machines.

* Move the GC alloc lock to the EE side of the interface

* Repair the Windows ARM build

* Move the decision to use per-thread alloc contexts to the EE

* Rename the lock used by StartNoGCRegion and EndNoGCRegion to be more indicative of what it is protecting

* Address code review feedback 2 (enumerate the global alloc context as a part of GCToEEInterface)

* Code review feedback (3)

* Address code review feedback (move some GC-internal globals to gcimpl.h and gc.cpp)

* g_global_alloc_lock is a dword, not a qword - fixes a deadlock

* Move GlobalAllocLock to gchelpers.cpp and switch to preemptive mode when spinning

* Repair the Windows x86 build

Commit migrated from https://github.com/dotnet/coreclr/commit/1b827b5a82f8c6f8a9ed760ee127938dea5a7ea4

7 years agoMerge pull request dotnet/coreclr#10240 from pgavlin/fixerrorlevel
Pat Gavlin [Fri, 17 Mar 2017 00:08:05 +0000 (17:08 -0700)]
Merge pull request dotnet/coreclr#10240 from pgavlin/fixerrorlevel

Fix test failure detection when dumps are enabled.

Commit migrated from https://github.com/dotnet/coreclr/commit/54368dad5842089ed7b6a444fa50116d2c0a0b09

7 years agoFix test failure detection when dumps are enabled.
Pat Gavlin [Thu, 16 Mar 2017 23:37:16 +0000 (16:37 -0700)]
Fix test failure detection when dumps are enabled.

Commit migrated from https://github.com/dotnet/coreclr/commit/03bce7880d867b85e39616cf5d0f13e9850167c5

7 years agoAdd a lab job for Coreclr testing via ILLINK (dotnet/coreclr#10200)
Swaroop Sridhar [Thu, 16 Mar 2017 23:12:46 +0000 (16:12 -0700)]
Add a lab job for Coreclr testing via ILLINK (dotnet/coreclr#10200)

This commit adds a job that:
1) Clones https://github.com/mono/linker
2) Builds the linker for netcoreapp2.0
3) Builds CoreCLR and tests using the IlLinker built above

The job is run daily, and can be reqested from PRs as necessary.

Commit migrated from https://github.com/dotnet/coreclr/commit/a49486160e8b822609dae192ad5606bfc5c4ec05

7 years agoReduce case iteration counts in SeekUnroll.
Pat Gavlin [Thu, 16 Mar 2017 23:08:06 +0000 (16:08 -0700)]
Reduce case iteration counts in SeekUnroll.

This test was taking too long to run on x86. After investigation, it
does not appear that there is a fundamental problem with the code
generated for the test; rather, it seems that we are running an
excessive number of iterations when using this test as a correctness
test. This change reduces the number of times we run each case from 10
to 1 unless otherwise specified on the command line.

Commit migrated from https://github.com/dotnet/coreclr/commit/13867720e00706ade79e6030f6e8441fbfdef41c

7 years agoFix ValueNumStore::IsVNArrLenUnsignedBound checks
Mike Danes [Thu, 16 Mar 2017 21:38:45 +0000 (23:38 +0200)]
Fix ValueNumStore::IsVNArrLenUnsignedBound checks

VNFuncApp::m_func should be checked first to be sure that m_args[0] and m_args[1] contain valid VNs. It's not clear if m_func can ever be something other than a binary func in the case of a relop VN but the code doesn't look right as it is.

Commit migrated from https://github.com/dotnet/coreclr/commit/54b1709d4625d9c70a42b2e1321ae9594c49f858

7 years agoAdd IBC support to managed build (dotnet/coreclr#10180)
Daniel Podder [Thu, 16 Mar 2017 21:37:07 +0000 (14:37 -0700)]
Add IBC support to managed build (dotnet/coreclr#10180)

Add a new build switch, `ibcinstrument`, that adds `/Tuning` on the `crossgen`
command line when building System.Private.CoreLib and its peers. Automatically
consume IBC optdata during builds when these conditions are met:

1. `ibcinstrument` is *not* passed to the build,
2. optdata is available
3. ibcmerge is available

Note that `optdata` will not yet be restored with this change; once packages for
master are made available, a new package reference will still need to be added.
This PR attempts to unblock manually testing IBC, as well as surrounding
CI/infrastructure work.

To help produce an IBC-optimized build using manually generated profile data,
run the newly added `tests/scripts/optdata/bootstrap.py` script. It will
configure the build to consume IBC data from a path automatically, and print out
that path where profile data can be copied.

Commit migrated from https://github.com/dotnet/coreclr/commit/1b64c03493a4b7e4336f0dabbdf4ed980f0d109c

7 years agoAdd some test cases
Andy Ayers [Wed, 15 Mar 2017 15:16:59 +0000 (08:16 -0700)]
Add some test cases

Commit migrated from https://github.com/dotnet/coreclr/commit/4e021953d8421ed6d53d8d0ff5bef2d09a738c5e

7 years agoInterface call devirtualization: jit side of changes
Andy Ayers [Thu, 16 Mar 2017 15:30:58 +0000 (08:30 -0700)]
Interface call devirtualization: jit side of changes

Unblock VM queries where the base class is an interface (queries
where the implementing class is also an interface are still blocked
as no resolution is possible). Pass along the context handle that
the jit got from getCallInfo.

Commit migrated from https://github.com/dotnet/coreclr/commit/2c8b3ae4c1786968f387af9c78a343e0a561869b

7 years agoInterface call devirtualization: VM side of changes
Andy Ayers [Thu, 16 Mar 2017 15:30:17 +0000 (08:30 -0700)]
Interface call devirtualization: VM side of changes

Extend resolveVirtualMethod to take in the owner type needed to resolve
shared generic interface calls, and implement VM support for interface
call devirtualization. Add a check that the class presented by the jit
implements the interface, to catch cases where the IL is missing type
casts.

Update jit GUID, SPMI and zap to reflect the changed signature.

Commit migrated from https://github.com/dotnet/coreclr/commit/00f13f2fb04c21fc1675ce264ef7291cbcec67a1

7 years agoFix CoreCLR build break in shared corelib partition (dotnet/coreclr#2997)
Jan Kotas [Thu, 16 Mar 2017 19:47:52 +0000 (12:47 -0700)]
Fix CoreCLR build break in shared corelib partition (dotnet/coreclr#2997)

Move RelocatedTypeAttribute under PROJECTN ifdef

Commit migrated from https://github.com/dotnet/coreclr/commit/d4872c2a6438edf03f775d5892aee0e5b964b405

7 years agoEnable FileStream in ProjectN build, use CreateFile2 instead of CreateFile.
Jeremy Kuhne [Thu, 16 Mar 2017 01:38:22 +0000 (18:38 -0700)]
Enable FileStream in ProjectN build, use CreateFile2 instead of CreateFile.

[tfs-changeset: 1651001]

Commit migrated from https://github.com/dotnet/coreclr/commit/c7f78e86e7e168a590bda635f3a5c195195befb2

7 years agoRemoved check for the maximum quantity of arguments (dotnet/coreclr#10232)
Buyduck [Thu, 16 Mar 2017 20:24:17 +0000 (23:24 +0300)]
Removed check for the maximum quantity of arguments (dotnet/coreclr#10232)

Commit migrated from https://github.com/dotnet/coreclr/commit/f1087c7acbc4dc1bc4556af629a67ea606a96713

7 years agoUpdate CoreClr to beta-25116-01 (dotnet/coreclr#10163)
dotnet bot [Thu, 16 Mar 2017 20:16:01 +0000 (13:16 -0700)]
Update CoreClr to beta-25116-01 (dotnet/coreclr#10163)

Commit migrated from https://github.com/dotnet/coreclr/commit/d4ae90091d5dfad544bcca2d20188055392dd815

7 years agoFixing more file-class correspondence violations. (dotnet/coreclr#10231)
Atsushi Kanamori [Thu, 16 Mar 2017 19:27:56 +0000 (12:27 -0700)]
Fixing more file-class correspondence violations. (dotnet/coreclr#10231)

* Cloned files.

* Reduce each file to its namesake class.

* Cleanup

* Fix build break.

Commit migrated from https://github.com/dotnet/coreclr/commit/a3cd6bc2cde83c5e9a87253cd5fe7ed8aaafbde3

7 years agoMerge pull request dotnet/coreclr#10214 from pgavlin/TimeoutCrashDumps
Pat Gavlin [Thu, 16 Mar 2017 18:49:26 +0000 (11:49 -0700)]
Merge pull request dotnet/coreclr#10214 from pgavlin/TimeoutCrashDumps

Take crash dumps for timed-out tests.

Commit migrated from https://github.com/dotnet/coreclr/commit/0d02d3bc5cab6ea40c4c431cbbcc7e14a5332835

7 years agoRemove a default argument in gentree.cpp to fix internal builds.
Pat Gavlin [Thu, 16 Mar 2017 17:10:09 +0000 (10:10 -0700)]
Remove a default argument in gentree.cpp to fix internal builds.

[tfs-changeset: 1651089]

Commit migrated from https://github.com/dotnet/coreclr/commit/41afefafd606c9f9b2c94a16d6ce20289589de35

7 years agoTake crash dumps for timed-out tests.
Pat Gavlin [Thu, 16 Mar 2017 00:28:42 +0000 (17:28 -0700)]
Take crash dumps for timed-out tests.

This change updates the test infrastructure to collect crash dumps for
tests that time out. We've been seeing a number of tests that only time
out in CI (e.g. dotnet/coreclr#10076); hopefully this will help us root-cause the
timeouts.

Commit migrated from https://github.com/dotnet/coreclr/commit/6f30002fc917cdacd4d0565f05ded920ab17f830

7 years agoMerge pull request dotnet/coreclr#10164 from stephentoub/fs_pipe_crash
Stephen Toub [Thu, 16 Mar 2017 16:46:19 +0000 (12:46 -0400)]
Merge pull request dotnet/coreclr#10164 from stephentoub/fs_pipe_crash

Ignore FileStream.FlushWriteBuffer failures during finalization

Commit migrated from https://github.com/dotnet/coreclr/commit/7d8e1382eea401386890bc38065fa9b8ef76141e

7 years agoDelete mscorlib facade (dotnet/coreclr#10157)
Jan Kotas [Thu, 16 Mar 2017 14:32:12 +0000 (07:32 -0700)]
Delete mscorlib facade (dotnet/coreclr#10157)

Fixes dotnet/coreclr#7607

Commit migrated from https://github.com/dotnet/coreclr/commit/84aab5f59d023849b9ccdc290e698e4a61ac75a2

7 years agoMerge pull request dotnet/coreclr#10177 from eerhardt/TZPosixNames
Eric Erhardt [Thu, 16 Mar 2017 12:45:32 +0000 (07:45 -0500)]
Merge pull request dotnet/coreclr#10177 from eerhardt/TZPosixNames

Support bracket enclosed names in TZ POSIX rules

Commit migrated from https://github.com/dotnet/coreclr/commit/8f4861922d1761bfcb339d2474fd1b414cec8004

7 years agoHide types which are now public in corefx (dotnet/coreclr#10142)
Rahul Kumar [Thu, 16 Mar 2017 07:51:50 +0000 (00:51 -0700)]
Hide types which are now public in corefx (dotnet/coreclr#10142)

Commit migrated from https://github.com/dotnet/coreclr/commit/14207f4d68ec9d16ad88b424bc60c452a30742aa

7 years agoMinor fix to address ?: VC conformance improvement. (dotnet/coreclr#10208)
Yuriy Solodkyy [Thu, 16 Mar 2017 04:55:53 +0000 (21:55 -0700)]
Minor fix to address ?: VC conformance improvement. (dotnet/coreclr#10208)

Visual C++ has made some conformance changes to conditional operator
that will be available under /permissive- and which make the inference of
result type of the conditional operator in these 2 places ambiguous. This
happens because the class type in one of the arguments provides both: the
constructor from and the conversion operator to T - LCWSTR here.

Commit migrated from https://github.com/dotnet/coreclr/commit/67f40646d76d914ab7f099df25768c73c4f55bad

7 years agoTemporarily disable flaky sleep test (dotnet/coreclr#10221)
Matt Mitchell [Thu, 16 Mar 2017 04:55:25 +0000 (21:55 -0700)]
Temporarily disable flaky sleep test (dotnet/coreclr#10221)

Commit migrated from https://github.com/dotnet/coreclr/commit/6a10391e57742487dd2458213d61c35f31139a4c

7 years agoFix Convert.FromBase64CharArray with empty array (dotnet/coreclr#10224)
Stephen Toub [Thu, 16 Mar 2017 04:55:11 +0000 (00:55 -0400)]
Fix Convert.FromBase64CharArray with empty array (dotnet/coreclr#10224)

Commit migrated from https://github.com/dotnet/coreclr/commit/9870e4edc898d24fb5d066b08d1472a03e4c75c5

7 years ago[x86/Linux] Fix NativeCallableTest (dotnet/coreclr#10060)
Evgeny Pavlov [Thu, 16 Mar 2017 04:30:37 +0000 (07:30 +0300)]
[x86/Linux] Fix NativeCallableTest (dotnet/coreclr#10060)

* [x86/Linux] Fix NativeCallableTest

* Move m_cbActualArgSize adjustment outside if statement

* [x86/Linux] Adjust m_cbActualArgSize in case pStubMD == NULL

* [x86/Linux] Move m_cbActualArgSize calculation to #else part of '#ifdef _TARGET_X86_'

* [x86/Linux] Remove redundant computations, add comments for m_cbActualArgSize meaning

Commit migrated from https://github.com/dotnet/coreclr/commit/6f3aa999a842cfa4bf83415e88ea7fb1650ab5bf

7 years agoMerge pull request dotnet/coreclr#10168 from eerhardt/PortablePDBs
Eric Erhardt [Thu, 16 Mar 2017 04:25:55 +0000 (23:25 -0500)]
Merge pull request dotnet/coreclr#10168 from eerhardt/PortablePDBs

Make portable PDBs on Unix instead of no symbols at all.

Commit migrated from https://github.com/dotnet/coreclr/commit/debcfa9e83bb9d5896f922fd8682241dec79d5e7

7 years agoEnable use of Volatile<T> on arm64 to get correct memory consistency (dotnet/coreclr...
Rahul Kumar [Thu, 16 Mar 2017 04:11:22 +0000 (21:11 -0700)]
Enable use of Volatile<T> on arm64 to get correct memory consistency (dotnet/coreclr#10212)

Commit migrated from https://github.com/dotnet/coreclr/commit/271431af41f9a1a3287bb936e847ac6d8e2fb887

7 years agoClean up fcall.h (dotnet/coreclr#10158)
Jonghyun Park [Thu, 16 Mar 2017 04:05:56 +0000 (13:05 +0900)]
Clean up fcall.h (dotnet/coreclr#10158)

Commit migrated from https://github.com/dotnet/coreclr/commit/cd95a2e99450f892e56d9703cc71ddd682421e62

7 years agoReorder stack arguments on reverse P/Invoke (dotnet/coreclr#10217)
Jonghyun Park [Thu, 16 Mar 2017 04:05:30 +0000 (13:05 +0900)]
Reorder stack arguments on reverse P/Invoke (dotnet/coreclr#10217)

Commit migrated from https://github.com/dotnet/coreclr/commit/e55c985fb2c833b332581680f050bf7ebaa98f5f

7 years ago[x86/Linux] Fix IL_STUB_PInvoke with RetBuf (dotnet/coreclr#10144)
Hanjoung Lee [Thu, 16 Mar 2017 03:29:34 +0000 (12:29 +0900)]
[x86/Linux] Fix IL_STUB_PInvoke with RetBuf (dotnet/coreclr#10144)

* [x86/Linux] Fix IL_STUB_PInvoke with RetBuf

Fix calling convention and IL_STUB_PInvoke for native functions
which was problematic for native functions that has
a RetBuf argument(struct size <= 8) on x86/Linux.

Fix dotnet/coreclr#10027

Commit migrated from https://github.com/dotnet/coreclr/commit/9422f47c5de802d877c08f9f5118471b375239b1

7 years agoRevert "Add support for Multiqueing jobs in Helix"
William Godbe [Thu, 16 Mar 2017 01:17:15 +0000 (18:17 -0700)]
Revert "Add support for Multiqueing jobs in Helix"

Commit migrated from https://github.com/dotnet/coreclr/commit/036c2c06cf3bc0746891cf5684e8c31ad7c5ff41

7 years agoMerge pull request dotnet/coreclr#10218 from dotnet/revert-10213-buildType
William Godbe [Thu, 16 Mar 2017 01:16:25 +0000 (18:16 -0700)]
Merge pull request dotnet/coreclr#10218 from dotnet/revert-10213-buildType

Revert "Add BuildType to helixpublish.proj"

Commit migrated from https://github.com/dotnet/coreclr/commit/60a73101ad8becbec2ad7d00b6451d135becc074

7 years agoMerge pull request dotnet/coreclr#10219 from dotnet/revert-10210-distroRid
William Godbe [Thu, 16 Mar 2017 01:16:06 +0000 (18:16 -0700)]
Merge pull request dotnet/coreclr#10219 from dotnet/revert-10210-distroRid

Revert "Make user specify RID for publishing test native bins into"

Commit migrated from https://github.com/dotnet/coreclr/commit/0a81735ec7c6397f99f91c838ff9ec588283ef57

7 years agoRevert "Make user specify RID for publishing test native bins into"
William Godbe [Thu, 16 Mar 2017 01:15:56 +0000 (18:15 -0700)]
Revert "Make user specify RID for publishing test native bins into"

Commit migrated from https://github.com/dotnet/coreclr/commit/42bf84445b9edbfd7a22e15936cf7ea8b13a3f16

7 years agoRevert "Add BuildType to helixpublish.proj"
William Godbe [Thu, 16 Mar 2017 01:15:28 +0000 (18:15 -0700)]
Revert "Add BuildType to helixpublish.proj"

Commit migrated from https://github.com/dotnet/coreclr/commit/ec6111af130c265276d0b0bd77bed359c6f6d554

7 years agoMerge pull request dotnet/coreclr#9876 from sdmaclea/PR-ARM64-ForeignThreadExceptions...
Rahul Kumar [Thu, 16 Mar 2017 00:46:48 +0000 (17:46 -0700)]
Merge pull request dotnet/coreclr#9876 from sdmaclea/PR-ARM64-ForeignThreadExceptionsNative

[Arm64] Enable building ForeignThreadExceptionsNative

Commit migrated from https://github.com/dotnet/coreclr/commit/02c8cc90b9cfb2ab6b111b4e0c4f1a6d17e5d4a1

7 years agoFix ToTitleCase Functionality for Dutch Cultures (dotnet/coreclr#10195)
Rion Williams [Thu, 16 Mar 2017 00:38:04 +0000 (19:38 -0500)]
Fix ToTitleCase Functionality for Dutch Cultures (dotnet/coreclr#10195)

* Add Methods to Handle Dutch Titlecasing

Added the `IsDutchCulture` and `IsIjAtCurrentPosition` methods to handle
resolving a special-case for Dutch titlecasing, which should properly
capitalize any instances of "IJ" at the beginning of a titlecased word.

* Moved `IsDutchCase()` Call Into Local Variable

Moved the check for Dutch culture outside of the title-loop to avoid unnecessary evaluations.

* Performance Changes and Improvements to Dutch Titlecasing

Removed `IsDutchCulture()` method in favor of an inline approach relying
on the `StartsWith()` method; Remove the `IsIjAtCurrentPosition()`
method in favor of another inline approach to improve performance.

* Minor Formatting Change

Added space for `isDutchCulture` line, as it managed to disappear somewhere along the way.

Commit migrated from https://github.com/dotnet/coreclr/commit/50232d6448e63ccd04fa9e92199292621b049d5c

7 years agoMerge pull request dotnet/coreclr#10213 from wtgodbe/buildType
William Godbe [Thu, 16 Mar 2017 00:27:03 +0000 (17:27 -0700)]
Merge pull request dotnet/coreclr#10213 from wtgodbe/buildType

Add BuildType to helixpublish.proj

Commit migrated from https://github.com/dotnet/coreclr/commit/1af419659034d9297b95240e889e4571ccefa710

7 years agoAdd BuildType to helixpublish.proj
wtgodbe [Thu, 16 Mar 2017 00:26:47 +0000 (17:26 -0700)]
Add BuildType to helixpublish.proj

Commit migrated from https://github.com/dotnet/coreclr/commit/d4f1d88974ca533d6dcf604e2a7c4f560388b500

7 years agoChange CoreCLR to use Sierra (dotnet/coreclr#10173)
Matt Mitchell [Thu, 16 Mar 2017 00:06:54 +0000 (17:06 -0700)]
Change CoreCLR to use Sierra (dotnet/coreclr#10173)

* Switch to full 10.12
* Disable query performance counter test

Commit migrated from https://github.com/dotnet/coreclr/commit/bf90ab4abff1b5e1a2780b0e7ed2ae8c5826e597

7 years agoMerge pull request dotnet/coreclr#10210 from wtgodbe/distroRid
William Godbe [Wed, 15 Mar 2017 23:06:35 +0000 (16:06 -0700)]
Merge pull request dotnet/coreclr#10210 from wtgodbe/distroRid

Make user specify RID for publishing test native bins into

Commit migrated from https://github.com/dotnet/coreclr/commit/4065f0fd553025f3bf028b5a3018c026909473be

7 years agoMerge pull request dotnet/coreclr#10206 from wtgodbe/MultiQueue
William Godbe [Wed, 15 Mar 2017 23:04:47 +0000 (16:04 -0700)]
Merge pull request dotnet/coreclr#10206 from wtgodbe/MultiQueue

Add support for Multiqueing jobs in Helix

Commit migrated from https://github.com/dotnet/coreclr/commit/6ed7bf42bd604ea136ca9c03d9fedcad86be4864

7 years agoMigrate MethodBase.cs over to the shared partition. (dotnet/coreclr#10202)
Atsushi Kanamori [Wed, 15 Mar 2017 22:52:05 +0000 (15:52 -0700)]
Migrate MethodBase.cs over to the shared partition. (dotnet/coreclr#10202)

* Replace each member with CoreRt prose.

* Lightup IsConstructedGenericMethod

* Copy over CoreRt MethodBase.cs (this is now just a reordering)

* Move MethodBase.cs verbative over to shared partition.

* AAAAND.... it looks like this exercise exposed a bug in CoreRt.

* Resolved merge conflict

Commit migrated from https://github.com/dotnet/coreclr/commit/450ac8f965586c7b28488b6af16855a383da6278

7 years agoMake user specify RID for publishing test native bins into
wtgodbe [Wed, 15 Mar 2017 22:49:20 +0000 (15:49 -0700)]
Make user specify RID for publishing test native bins into

Commit migrated from https://github.com/dotnet/coreclr/commit/2758c911699794e791779682f2383f5d230f62e1

7 years agoMove System.Convert code to shared partition (dotnet/coreclr#10178)
Alex Perovich [Wed, 15 Mar 2017 22:42:02 +0000 (17:42 -0500)]
Move System.Convert code to shared partition (dotnet/coreclr#10178)

* Move System.Convert code to shared partition
* Use ReferenceEquals for type equality

Commit migrated from https://github.com/dotnet/coreclr/commit/65ca581afb6ad852e4533fcbaaa2f02269d8c2df

7 years agoAdd support for Multiqueing jobs in Helix
wtgodbe [Wed, 15 Mar 2017 21:39:41 +0000 (14:39 -0700)]
Add support for Multiqueing jobs in Helix

Commit migrated from https://github.com/dotnet/coreclr/commit/d229d0021869b1fafaeb51c512300925f7d3c5e5

7 years agoMerge pull request dotnet/coreclr#10196 from wtgodbe/fixHelix
William Godbe [Wed, 15 Mar 2017 21:35:19 +0000 (14:35 -0700)]
Merge pull request dotnet/coreclr#10196 from wtgodbe/fixHelix

Build Targeting Pack after restoring packages

Commit migrated from https://github.com/dotnet/coreclr/commit/f9149fd4af753c9862710bf9aed35b508a95501c

7 years agoPrepare MethodBase.cs for migration to shared partition. (dotnet/coreclr#10194)
Atsushi Kanamori [Wed, 15 Mar 2017 19:55:21 +0000 (12:55 -0700)]
Prepare MethodBase.cs for migration to shared partition. (dotnet/coreclr#10194)

* Clone the files w/out changes.

* Distill each file to its intended subset.

* Minimize usings.

* Renamed to *.CoreClr.cs - extended free car wash to fix the nits.

Commit migrated from https://github.com/dotnet/coreclr/commit/eb54ecde215f4aa705151f66e8b3b593ca0b3772

7 years agoBuild Targeting Pack after restoring packages
wtgodbe [Wed, 15 Mar 2017 19:05:21 +0000 (12:05 -0700)]
Build Targeting Pack after restoring packages

Commit migrated from https://github.com/dotnet/coreclr/commit/ee8d950930e6efc8568ddafe4fd5c925ce1b1145

7 years agoMerge pull request dotnet/coreclr#10166 from alpencolt/ryu-arm-arr-tests
Bruce Forstall [Wed, 15 Mar 2017 18:01:56 +0000 (11:01 -0700)]
Merge pull request dotnet/coreclr#10166 from alpencolt/ryu-arm-arr-tests

Added Array tests to CodeGenBringUpTests

Commit migrated from https://github.com/dotnet/coreclr/commit/4abd845c8908fad3a8e92a403471c61701fa76da

7 years agoAdd support for testing via ILLINK
Swaroop Sridhar [Wed, 15 Mar 2017 17:40:25 +0000 (10:40 -0700)]
Add support for testing via ILLINK

Add support for testing via ILLINK

This commit has the following changes:
1) Setup the testing infrastructure to run the CoreCLR tests after linking through ILLinker
    `runtest.cmd /link <path-to-illink.exe>`
2) The linker is taken as an argument for runtest.cmd, typically the corebuild of
    https://github.com/mono/linker
3) Tests are run by linking the test binaries and all libraries except `System.Private.Corelib.dll`
4) For tests that use reflection, setup Reflection roots in source directories as `<test>.reflect.xml`

Commit migrated from https://github.com/dotnet/coreclr/commit/7f8ba1a8bd20ce2330b8d733f1e51959470fdd8f

7 years agoSupport bracket enclosed names in TZ POSIX rules
Eric Erhardt [Tue, 14 Mar 2017 17:49:43 +0000 (12:49 -0500)]
Support bracket enclosed names in TZ POSIX rules

The POSIX time zone rules at the end of a tzfile have been updated to allow digits, plus signs and minus signs in the time zone names by enclosing the name in `<` and `>` characters. TimeZoneInfo's parsing logic was written using an older version of the spec, so it didn't have support for this format.

Fix https://github.com/dotnet/corefx/issues/16962

Commit migrated from https://github.com/dotnet/coreclr/commit/4bcc0d5d9e8870bfb579c069c2d5b4dd3b4b3b1e

7 years agoReplace MemberInfo.cs with the CoreRt version and move to shared partition. (dotnet...
Atsushi Kanamori [Wed, 15 Mar 2017 13:40:24 +0000 (06:40 -0700)]
Replace MemberInfo.cs with the CoreRt version and move to shared partition. (dotnet/coreclr#10167)

* Move file verbatim.

* Port over CoreRT style sans reordering.

* Final replacement with CoreRt file.

Commit migrated from https://github.com/dotnet/coreclr/commit/44df0f37ce9e4e4ea63718ba0b4e74d53970037a

7 years agoAdded Array tests to CodeGenBringUpTests
Alexander Soldatov [Tue, 14 Mar 2017 13:34:39 +0000 (16:34 +0300)]
Added Array tests to CodeGenBringUpTests

Commit migrated from https://github.com/dotnet/coreclr/commit/f734e77607bdf9b39049216948fc6ce243c69852

7 years agoMerge pull request dotnet/coreclr#10145 from hqueue/arm/ryujit/shiftrotate_decomposed...
Bruce Forstall [Wed, 15 Mar 2017 04:27:57 +0000 (21:27 -0700)]
Merge pull request dotnet/coreclr#10145 from hqueue/arm/ryujit/shiftrotate_decomposed_long

[Ryujit/ARM32] Support shift and rotate for decomposed long

Commit migrated from https://github.com/dotnet/coreclr/commit/19e1cd299da301d1b2cb18ae8479595dbfc7224c

7 years agoJIT: preliminaries to improve types (dotnet/coreclr#10172)
Andy Ayers [Wed, 15 Mar 2017 02:45:10 +0000 (19:45 -0700)]
JIT: preliminaries to improve types (dotnet/coreclr#10172)

Refactor the logic in `impDevirtualizeCall` so that the part that determines
the type of a tree for ref types is now a new utility method that can be called
elsewhere.

Update the utility to examine calls more closely. For inline candidates that
return shared types, try and use the context to get to the unshared version of the
type. For calls that are not inline candidates, look at the type in the signature
available to the jit w/o context.

Call the utility when we've created a temp for an inlinee's argument and the
argument is not modified in the inlinee body. If we already thought we knew the
type of the temp exactly, ensure that this new information agrees.

Rework the logic in `impDevirtualizeCall` in anticipation of interface call
devirtualization. Update the diagnostic stream to indicate the kind of call
devirtualized and the primary reason why devirtualization happened.
Avoid fetching class and method names unless they're going to be used. Likewise
try not to fetch attributes if we already have them on hand.

Commit migrated from https://github.com/dotnet/coreclr/commit/3ea5447c9b090e621aed9e20a580178e97dabf8f

7 years agoMerge pull request dotnet/coreclr#9276 from benaadams/sealed-encodings
Stephen Toub [Tue, 14 Mar 2017 23:59:24 +0000 (19:59 -0400)]
Merge pull request dotnet/coreclr#9276 from benaadams/sealed-encodings

Support Encoding devirtualization

Commit migrated from https://github.com/dotnet/coreclr/commit/b178cb3fa54304cde31c15696b9262dcb4b655b1

7 years agoMerge pull request dotnet/coreclr#10152 from jashook/assert_pcodes_pcodesstart_lt_256
Jarret Shook [Tue, 14 Mar 2017 23:27:28 +0000 (16:27 -0700)]
Merge pull request dotnet/coreclr#10152 from jashook/assert_pcodes_pcodesstart_lt_256

[Arm64] Always add UWC_END

Commit migrated from https://github.com/dotnet/coreclr/commit/1fc0f7caa16111c2775e2eb156ddb6ae7f9a7172

7 years agoMerge pull request dotnet/coreclr#10023 from parjong/fix/clr_abi
Bruce Forstall [Tue, 14 Mar 2017 23:07:35 +0000 (16:07 -0700)]
Merge pull request dotnet/coreclr#10023 from parjong/fix/clr_abi

Update CLR ABI PSPSym Section

Commit migrated from https://github.com/dotnet/coreclr/commit/d003d3c0efe81330768d68289b19dd3ca0758880

7 years agoMerge pull request dotnet/coreclr#10171 from pgavlin/TestWrapperTimeouts
Pat Gavlin [Tue, 14 Mar 2017 21:12:56 +0000 (14:12 -0700)]
Merge pull request dotnet/coreclr#10171 from pgavlin/TestWrapperTimeouts

Do not wait on std{out,err} when a test times out.

Commit migrated from https://github.com/dotnet/coreclr/commit/9b51e55be675b4b823f7a969f25f9ad024953da0

7 years agoMerge pull request dotnet/coreclr#10176 from wtgodbe/BuildToolsAgain
William Godbe [Tue, 14 Mar 2017 20:49:08 +0000 (13:49 -0700)]
Merge pull request dotnet/coreclr#10176 from wtgodbe/BuildToolsAgain

Update Buildtools Version

Commit migrated from https://github.com/dotnet/coreclr/commit/67572c23bdcfaec4379f442da2bdc66d0b80c972

7 years agoMerge pull request dotnet/coreclr#10175 from wtgodbe/NonWindowsTargetingPack
William Godbe [Tue, 14 Mar 2017 20:48:46 +0000 (13:48 -0700)]
Merge pull request dotnet/coreclr#10175 from wtgodbe/NonWindowsTargetingPack

Copy Targeting Pack files into Core_Root for Non-Windows

Commit migrated from https://github.com/dotnet/coreclr/commit/c8fbad1e47e045735b4f32a08bb1b6857a4acc0a

7 years agoFix tz rules (dotnet/coreclr#10169)
Tarek Mahmoud Sayed [Tue, 14 Mar 2017 19:12:04 +0000 (12:12 -0700)]
Fix tz rules (dotnet/coreclr#10169)

* Fix the TZ Rule data on Linux

On Linux when the caller ask for the TZ adjustment rules we convert the internal stored rule data from UTC to local time. we used to TZI.Convert which is wrong because calculating the start the daylight start time should always not include the daylight delta because we didn't start the daylight saving yet. and calculating the end of daylight should always include the daylight delta because we were in the daylight saving period.

The fix here is manually calculating the start and end of the daylight saving inside the rule

* Revert the comment change

* Add a comment

Commit migrated from https://github.com/dotnet/coreclr/commit/c2b5d5a707e3bb037df847e17b4e55e19fd5bfa8

7 years agoUpdate Buildtools Version
wtgodbe [Tue, 14 Mar 2017 19:10:29 +0000 (12:10 -0700)]
Update Buildtools Version

Commit migrated from https://github.com/dotnet/coreclr/commit/af6c544ca264d89c8a4e538512feb24bb7d7a928