Chris 'BinGOs' Williams [Mon, 19 Nov 2012 11:07:57 +0000 (11:07 +0000)]
Update Unicode-Collate to CPAN version 0.93
[DELTA]
0.93 Sun Nov 18 18:13:42 2012
- DUCET is updated (for Unicode 6.2.0) as Collate/allkeys.txt.
! Please notice that allkeys.txt will be overwritten if you have had
other allkeys.txt already.
- The default UCA_Version is 26.
- Locale/*.pl (except fr.pl) and CJK/Korean.pm are updated.
- modified tests: loc_es.t, loc_estr.t, version.t in t.
Steffen Mueller [Mon, 19 Nov 2012 06:48:03 +0000 (07:48 +0100)]
Fix test-skipping logic for File::Glob under no-taint-perl
Steffen Mueller [Mon, 19 Nov 2012 06:39:23 +0000 (07:39 +0100)]
CPAN for EU::ParseXS is now at 3.18
Steffen Mueller [Mon, 19 Nov 2012 06:33:29 +0000 (07:33 +0100)]
Complete ExtUtils::ParseXS/EU::Typemaps version bump
This moves to 3.18 across the entire distribution for a new CPAN release
and completes the changelog.
Daniel Dragan [Sun, 18 Nov 2012 23:37:18 +0000 (18:37 -0500)]
refactor pp_padsv
This commit rearranges the autos in a way to minimize the number of vars
saved across calls. By calculating TARG after EXTEND, TARG does not need
to be saved across a conditional stack grow call. In order to not read
the pad slot and PL_curpad twice (once for TARG, once for save_clearsv),
a * to the pad slot is saved in a volatile. var padentry is calced after
the EXTEND call, but before save_clearsv, and is not saved across
save_clearsv. TARG's scope was not extended to the vifify_ref call, since
1. SP (TOPs assignment) will be referenced anyway after vivify_ref and
this can not be removed.
2. All of pp_padsv has only 3 non-vol inter func vars, my_perl, SP and op.
Adding TARG to remain live past any call (save_clearsv) would add a 4th
non-vol var to this opcode and increase the total stack frame size by
1 pointer, either to save a non-vol reg, or to put TARG directly on the
stack (platform dependent).
The SPAGAIN and RETURN combo was strange, since we fetch global SP, and
then write it right back. But in the old code, the RETURN, if the if branch
is not taken would be required for the XPUSHs. SAVECLEARSV macro included
addr of op, would wouldn't work here, so the func was called directly.
Originally I kept the SAVECLEARSV, but the asm of Visual C showed
recalcing of the pad slot in SAVECLEARSV even though no calls are made in
my revision between EXTEND and SAVECLEARSV, so I forced the compiler to
cache the pad slot. By removing a 2nd PL_curpad dereference, in theory
the CPU can toss a chunk of the pad array from CPU cache away sooner.
TOPs does not inc/dec local SP, so a PUTBACK is not required after
vivify_ref. Brief comments added to explain the unusual code on first
glance. PL_op was cached to remove a couple "*(my_perl+4)"s that were
PL_op being reread after the 2 calls. PL_op caching was the last change I
did. Without PL_op caching, pp_padsv has max 2 cross func saved autos but
was 0x77 long. With PL_op caching, pp_padsv now has 3 saved autos, but is
only 0x72 since some "*(my_perl+4)"s were removed. Since Linux/Win32 32 bit
x86 has only 3 (without ebp) or 4 (with ebp) non-vol regs, this func post
PL_op caching still uses no C stack vars (but nonvol regs are saved and
restored of course). This patch is similar in concept to commit fdf4ddd .
The machine size of pp_padsv dropped from 0x85 to 0x72 for me after this
commit.
Daniel Dragan [Mon, 19 Nov 2012 02:16:39 +0000 (21:16 -0500)]
reduce scope of a var in save_clearsv
svp is a pointer to a pad array slice. It is derefed to set a sv flag.
It's optimized scope previous extended past the savestack_grow call. By
moving the flag setting before any calls in save_clearsv, svp does not have
to be carried across any calls. On some platforms there will be a benefit
(args transfered in vol regs for example, AMD64 Win64), on others none
since it will be reread from the stack after any child call anyway. I
assume the SvPADSTALE_off flag will have no effect on the panic croak.
After this commit, the only auto var carried through a call is
offset_shifted (and unavoidably my_perl).
I saw a drop in the size of save_clearsv from 0x5A to 0x58. The saving
and use of 1 nonvol reg on x86 32 bit VC 2003 was reduced, total stack
frame reduced by 1 pointer, since VC 2003 read svp off the stack only
once at the start of save_clearsv and kept it in a nonvol reg for the rest
of this func's body.
Father Chrysostomos [Mon, 19 Nov 2012 02:52:53 +0000 (18:52 -0800)]
perlhack: Note why some t/op tests avoid test.pl
Father Chrysostomos [Mon, 19 Nov 2012 02:36:12 +0000 (18:36 -0800)]
Stop \P{Assigned} from leaking
I suspect this leak also applies to any large character classes.
An HV created with newHV has a reference count of 1, so doing
newRV_inc on it will cause a leak.
Father Chrysostomos [Mon, 19 Nov 2012 02:44:16 +0000 (18:44 -0800)]
utf8.c: Fix a minor refcounting bug caused by 02c8547
Under some circumstances it could cause a hash to point to a freed
element. But the hash itself was leaking, so it caused on problems,
as no attempt to free its element again was made.
The next commit will stop the hash from leaking.
Father Chrysostomos [Mon, 19 Nov 2012 01:45:09 +0000 (17:45 -0800)]
Request that regcomp.c:S_regpposixcc be inlined
It is only called from one spot.
Father Chrysostomos [Mon, 19 Nov 2012 01:44:20 +0000 (17:44 -0800)]
Stop /[.zog.]/ and /[[.zog.]]/ from leaking
Before croaking, we need to free any SVs we might have allocated tem-
porarily. Also, Simple_vFAIL does not free the regular expression.
For that we need vFAIL.
Father Chrysostomos [Mon, 19 Nov 2012 01:29:33 +0000 (17:29 -0800)]
gv.t: Suppress warning
Father Chrysostomos [Mon, 19 Nov 2012 00:11:20 +0000 (16:11 -0800)]
Inline regcomp.c:S_checkposixcc into its only caller
In the next commit, it will need to access other variables around its
call site.
Tony Cook [Sun, 18 Nov 2012 23:41:32 +0000 (10:41 +1100)]
fix -DPERL_GLOBAL_STRUCT builds broken with the hash merge
note: this failed to build in smoke-me eg.
http://perl.develop-help.com/raw/?id=131750
Father Chrysostomos [Sun, 18 Nov 2012 22:11:07 +0000 (14:11 -0800)]
perldelta: hash function still needs mention
Father Chrysostomos [Sun, 18 Nov 2012 22:09:21 +0000 (14:09 -0800)]
gv.t: More *foo{NAME,PACKAGE} tests
Father Chrysostomos [Sun, 18 Nov 2012 21:29:56 +0000 (13:29 -0800)]
Stop $unicode =~ /[[:posix:]]/ from leaking
If we have just created an SV, it has a reference count of 1, so using
newRV_inc on it will create a leak. So we need to use newRV_noinc and
do SvREFCNT_inc in those cases where the SV is not new.
This has leaked since v5.17.3-117-g87367d5.
Father Chrysostomos [Sun, 18 Nov 2012 06:56:07 +0000 (22:56 -0800)]
Stop prototype("CORE::...") errors from leaking
They have leakd since v5.17.0-54-g1b08e05.
Father Chrysostomos [Sun, 18 Nov 2012 06:49:57 +0000 (22:49 -0800)]
Stop local $_[0] from leaking
local $_[0] puts the current $_[0] on to the savestack and gives the
array a brand new SV. If the array is not marked REAL, it holds no
reference counts on its elements. @_ is surreal by default.
The localisation code was making @_ hold a reference count on its new
element. The restore code was assuming it had a reference count, so
everything worked out if $_[0] was not modified after localisation.
But if the array is surreal, then modifications to it will assume that
it does *not* hold a reference count on $_[0]. So doing shift, or
@_=undef would cause the new element to leak.
Also, taking a reference to the array (\@_) will trigger, making
the reference count of all elements increeas, likwies leaking the
new element.
Since there is only one REAL flag, which indicates that all elements
of the array are reference-counted, we cannot have some elements ref-
erence-counted and some not (which local $_[0] does), and have every-
thing behave correctly.
So the only solution is to reify arrays before localising
their elements.
Father Chrysostomos [Sun, 18 Nov 2012 02:37:32 +0000 (18:37 -0800)]
More perlδ stuff
Father Chrysostomos [Sun, 18 Nov 2012 01:32:20 +0000 (17:32 -0800)]
Make *_{ARRAY} reify
Otherwise *_{ARRAY} returned from a sub will be kenotic, in the lit-
eral sense. (If you don’t understand that, just look at the test.)
Father Chrysostomos [Sun, 18 Nov 2012 01:22:01 +0000 (17:22 -0800)]
Document and test *glob{NAME} and *glob{PACKAGE}
These have been supported since *foo{THING} was added in perl 5.005.
If only I had known about these sooner.... I could have been writing
*$AUTOLOAD{NAME} all this time!
James E Keenan [Mon, 22 Oct 2012 01:49:03 +0000 (21:49 -0400)]
All tests should have descriptions.
Father Chrysostomos [Sat, 17 Nov 2012 20:44:31 +0000 (12:44 -0800)]
Increase $XS::APItest::VERSION to 0.45
Daniel Dragan [Sat, 17 Nov 2012 07:20:50 +0000 (02:20 -0500)]
refactor pp_rand
Reduce liveness of various variables. srand relies on nothing but a THX
so do that first and don't calculate a local SP yet. Put the EXTEND near SP
calculation. This might refresh SP. MAXARG access PL_op. The POPs balances
the stack. var sv is kept in a volatile, it is out of scope after the SvNV.
Through the SvNV, only 2 autos/regs are carried my_perl and SP.
dTARGET again uses PL_op but it and PUSHs and PUTBACK make no calls. SP is
out of scope after the PUTBACK. In macro Drand01 is the next call. XPUSHn
uses SvSETMAGIC. This is replaced with sv_setnv_mg since rand is not hot.
Now TARG is out of scope. Only my_perl remains in scope. NORMAL uses
PL_op for the 3rd and final time. All x86 32bit C stack usage was for
saving nonvol regs and 2 auto NVs (asm limitations prevent from keeping
it in a normal reg I guess)(VC2003). Caching PL_op->op_next at dTARGET to
avoid a 3rd PL_op dereference was tried with
SV * targ; (op_next = NORMAL), (GETTARGET), (PUSHs(TARG)), (PUTBACK);
to allow reordering, but it generated a stack auto on Visual C even
though 1 non vol reg (edi) was available. Another untried idea would be to
declare a OP * and set it to PL_op, then do the op_next and op_targ derefs,
but with the above mess, PL_op was derefed once by compiler optimization
but still the stack var was used. Also maintainability contributed to
scrapping the idea. The 1.0 assigns are reordered by comp in a way
that all of them happen after the SvNV but before the next call, which
is rand(), so they are fine order of execution wise. The comment about
SP or TARG means either dTARGET is done before the SvNV and SP is out of
scope before SvNV but SV * targ has to be saved across the SvNV, or SP is
saved across the SvNV. A choice was made save SP since the C code would
be more complicated, probably with gotos and initialing sv to NULL if
dTARGET/PUTBACK had to happen after conditional MAXARG/TOPs
unconditionally, but SvNV is conditonally called. The improvements in
this commit are not specific to x86-32 but all platforms and cpus.
The function dropped from 0xFF to 0xEB for me.
Father Chrysostomos [Sat, 17 Nov 2012 19:01:42 +0000 (11:01 -0800)]
[perl #115756] Fix XS::APItest::SvIsCOW
SvIsCOW returns a flag which will turn into 0 if truncated to 8 bits.
Father Chrysostomos [Sat, 17 Nov 2012 18:49:11 +0000 (10:49 -0800)]
8c34e50dc slowed down detruction with no DESTROY
I changed it to cache the DESTROY method in SvSTASH(stash), instead
of amagic tables, for the sake of speed. But I made no distinction
between ‘no cache’ and ‘no DESTROY method’. So classes with no
DESTROY method became as slow as perl 5.6.
To solve that, I’m using an adjusted pointer (following the example
of warnings.h) to mean ‘intentionally blank’.
I also fixed two instances of the DESTROY cache not being updated,
introduced by that commit.
Yves Orton [Sat, 17 Nov 2012 13:12:04 +0000 (14:12 +0100)]
Hash Function Change - Murmur hash and true per process hash seed
This patch does the following:
*) Introduces multiple new hash functions to choose from at build
time. This includes Murmur-32, SDBM, DJB2, SipHash, SuperFast, and
One-at-a-time. Currently this is handled by muning hv.h. Configure
support hopefully to follow.
*) Changes the default hash to Murmur hash which is faster than the
old default One-at-a-time.
*) Rips out the old HvREHASH mechanism and replaces it with a
per-process random hash seed.
*) Changes the old PL_hash_seed from an interpreter value to a
global variable. This means it does not have to be copied during
interpreter setup or cloning.
*) Changes the format of the PERL_HASH_SEED variable to a hex
string so that hash seeds longer than fit in an integer are possible.
*) Changes the return of Hash::Util::hash_seed() from a number to a
string. This is to accomodate hash functions which have more bits than
can be fit in an integer.
*) Adds new functions to Hash::Util to improve introspection of hashes
-) hash_value() - returns an integer hash value for a given string.
-) bucket_info() - returns basic hash bucket utilization info
-) bucket_stats() - returns more hash bucket utilization info
-) bucket_array() - which keys are in which buckets in a hash
More details on the new hash functions can be found below:
Murmur Hash: (v3) from google, see
http://code.google.com/p/smhasher/wiki/MurmurHash3
Superfast Hash: From Paul Hsieh.
http://www.azillionmonkeys.com/qed/hash.html
DJB2: a hash function from Daniel Bernstein
http://www.cse.yorku.ca/~oz/hash.html
SDBM: a hash function sdbm.
http://www.cse.yorku.ca/~oz/hash.html
SipHash: by Jean-Philippe Aumasson and Daniel J. Bernstein.
https://www.131002.net/siphash/
They have all be converted into Perl's ugly macro format.
I have not done any rigorous testing to make sure this conversion
is correct. They seem to function as expected however.
All of them use the random hash seed.
You can force the use of a given function by defining one of
PERL_HASH_FUNC_MURMUR
PERL_HASH_FUNC_SUPERFAST
PERL_HASH_FUNC_DJB2
PERL_HASH_FUNC_SDBM
PERL_HASH_FUNC_ONE_AT_A_TIME
Setting the environment variable PERL_HASH_SEED_DEBUG to 1 will make
perl output the current seed (changed to hex) and the hash function
it has been built with.
Setting the environment variable PERL_HASH_SEED to a hex value will
cause that value to be used at the seed. Any missing bits of the seed
will be set to 0. The bits are filled in from left to right, not
the traditional right to left so setting it to FE results in a seed
value of "
FE000000" not "
000000FE".
Note that we do the hash seed initialization in perl_construct().
Doing it via perl_alloc() (via init_tls) causes problems under
threaded builds as the buffers used for reentrant srand48 functions
are not allocated. See also the p5p mail "Hash improvements blocker:
portable random code that doesnt depend on a functional interpreter",
Message-ID:
<CANgJU+X+wNayjsNOpKRqYHnEy_+B9UH_2irRA5O3ZmcYGAAZFQ@mail.gmail.com>
Father Chrysostomos [Sat, 17 Nov 2012 18:13:10 +0000 (10:13 -0800)]
leakfinder: More exceptions
Father Chrysostomos [Sat, 17 Nov 2012 18:09:16 +0000 (10:09 -0800)]
perlδ
Father Chrysostomos [Fri, 16 Nov 2012 18:00:50 +0000 (10:00 -0800)]
[perl #114864] Don’t use amt for DESTROY
DESTROY has been cached in overload tables since
perl-5.6.0-2080-g32251b2, making it 4 times faster than before (over-
load tables are faster than method lookup).
But it slows down symbol lookup on stashes with overload tables,
because overload tables use magic, and SvRMAGICAL results in calls to
mg_find on every hash lookup.
By reusing SvSTASH(stash) to cache the DESTROY method (if the stash
is unblessed, of course, as most stashes are), we can avoid making
all destroyable stashes magical and also speed up DESTROY lookup
slightly more.
The results:
• 10% increase in stash lookup speed after destructors. That was just
testing $Foo::{x}. Other stash lookups will have other overheads
that make the difference less impressive.
• 5% increase in DESTROY lookup speed. I was using an empty DESTROY
method to test this, so, again, real DESTROY methods will have more
overhead and less speedup.
Craig A. Berry [Sat, 17 Nov 2012 17:24:43 +0000 (11:24 -0600)]
Preserve case of command-line arguments on VMS.
OpenVMS releases of the last decade or so have had this capability
but it's still not the default. But it's a reasonable default for
Perl, so enable it in our initialization code.
Unfortunately this feature does not work unless extended parse has
been enabled in the process before invoking Perl. Enabling
extended parse in our initialization code doesn't do any good
because DCL has already parsed the arguments before we get there.
So we will be limited to documenting that things work better with
extended parse and that the test suite assumes it's enabled.
Yves Orton [Sat, 17 Nov 2012 13:10:59 +0000 (14:10 +0100)]
add .gdb_history to .gitignore
Yves Orton [Sat, 17 Nov 2012 13:04:38 +0000 (14:04 +0100)]
Add a utility macro for reading hex digits.
Karl checked and it seems it actually works on EBCDIC as well
as on ASCII.
Yves Orton [Sat, 17 Nov 2012 13:02:18 +0000 (14:02 +0100)]
make regcharclass hash order determinisitic
Yves Orton [Sat, 17 Nov 2012 11:58:12 +0000 (12:58 +0100)]
Eliminate test from generated cp macros
Sayeth Karl:
In the _cp macros, the final test can be simplified:
/*** GENERATED CODE ***/
#define is_VERTWS_cp(cp) \
( ( 0x0A <= cp && cp <= 0x0D ) || ( 0x0D < cp && \
( 0x85 == cp || ( 0x85 < cp && \
( 0x2028 == cp || ( 0x2028 < cp && \
0x2029 == cp ) ) ) ) ) )
That 0x2028 < cp can be omitted and it will still mean the same thing.
And So Be It.
David Mitchell [Fri, 16 Nov 2012 18:04:49 +0000 (18:04 +0000)]
clone() wasn't cloning the whole stack
When cloning stacks (e.g. for fake fork), the stack is cloned
by copying the stack AV pointed to by PL_curstackinfo; but the
AvFILL on that AV may not be up to date, resulting in the top N
items of the stack not being cloned. Fix by saving PL_stack_sp
back into AvFILL(PL_curstack) before cloning
Steve Hay [Fri, 16 Nov 2012 14:21:06 +0000 (14:21 +0000)]
Oops, fix memory leak just introduced by
3fcdbd32b2
Steve Hay [Fri, 16 Nov 2012 09:11:36 +0000 (09:11 +0000)]
Don't try to ansify the path if it is empty
Fixes a possible crash (manifested when running with the page heap enabled)
when running after clearing PATH, which at least one test in op/taint.t
does.
Tony Cook [Fri, 16 Nov 2012 11:14:16 +0000 (22:14 +1100)]
under -Dusedl there are no warnings about the other dl_ functions
without usedl, the warnings are like:
Subroutine DynaLoader::dl_error redefined at (eval 1) line 2
... warnings about every other DynaLoader function
Subroutine DynaLoader::dl_error redefined at (eval 2) line 2
with usedl, only dl_error is defined, so the other warnings disappear,
since the regexp expected two new-lines between the dl_error warnings
the test failed.
The change makes one of the newlines optional.
Tony Cook [Fri, 16 Nov 2012 09:57:32 +0000 (20:57 +1100)]
leakfinder.pl requires XS::APItest which isn't built with -Uusedl
Daniel Dragan [Thu, 15 Nov 2012 20:11:10 +0000 (15:11 -0500)]
save_freeop is not an expression, remove PL_Xpv
save_freeop and SAVEFREEOP are never used in expressions only statements.
Using PL_Xpv is never ideal. For me .text section dropped from 0xC1DFF to
0xC1DBF after applying this.
Father Chrysostomos [Thu, 15 Nov 2012 23:55:50 +0000 (15:55 -0800)]
leakfinder.pl: More exceptions
Father Chrysostomos [Thu, 15 Nov 2012 23:53:13 +0000 (15:53 -0800)]
[perl #115742] Push a new pad for recursive DB::DB
When invoking the debugger recursively, pp_dbstate needs to push a new
pad (like pp_entersub) so that DB::DB doesn’t stomp on the lexical
variables belonging to the outer call.
Father Chrysostomos [Thu, 15 Nov 2012 20:46:36 +0000 (12:46 -0800)]
perlre: Fix syntax error in example
Father Chrysostomos [Thu, 15 Nov 2012 20:38:27 +0000 (12:38 -0800)]
perlfunc: Correct note about eval in DB package
It’s where the subroutine is defined, not the current package,
that matters.
#!perl -l
sub { my $x = 3; foo(); print $x }->();
sub foo { package DB; eval q"$x = 42" }
__END__
3
#!perl -l
sub { my $x = 3; DB::foo(); print $x }->();
package DB;
sub foo { package main; eval q"$x = 42"; }
__END__
42
Father Chrysostomos [Thu, 15 Nov 2012 02:08:34 +0000 (18:08 -0800)]
leakfinder.pl: Run evals four times
With three times we still get false positives
Father Chrysostomos [Thu, 15 Nov 2012 02:05:04 +0000 (18:05 -0800)]
leakfinder.pl: More exceptions
David Mitchell [Thu, 15 Nov 2012 22:46:31 +0000 (22:46 +0000)]
[MERGE] refactor pp_iter
Refactor the code in this hot function. Chiefly, the if/else chain
was replaced with a single switch statment, and various bits of code were
tidied up, duplicate code eliminated, local vars added to avoid repeated
evaluation of expressions etc; along with big whitespace changes to fix up
indentation etc afterwards.
With these changes, these trivial benchamarks run about 7% faster:
$x++ for @a; # @a has 30_000 elements
$x++ for 1..30_000;
while this one stayed about the same, presumably due to the relatively
costly overhead of sv_inc():
$x++ for 'aaa' .. 'zzz';
David Mitchell [Thu, 15 Nov 2012 22:34:40 +0000 (22:34 +0000)]
pp_iter: final whitespace/comment tidy up
reindent the LAZYSV block to be consistent with the other two;
move the comments to be on the same line as the case statements,
and fix the indent on the RETPUSHYES.
Only whitespace/moving comment changes; nothing functional
David Mitchell [Tue, 13 Nov 2012 13:12:31 +0000 (13:12 +0000)]
pp_iter: refactor CXt_LOOP_LAZYSV branch
David Mitchell [Tue, 13 Nov 2012 12:51:05 +0000 (12:51 +0000)]
pp_iter: refactor CXt_LOOP_LAZYIV branch
David Mitchell [Tue, 13 Nov 2012 12:20:34 +0000 (12:20 +0000)]
pp_iter: a bit more refactoring of CXt_LOOP_FOR branch
David Mitchell [Tue, 13 Nov 2012 11:55:19 +0000 (11:55 +0000)]
pp_iter: factor out some common code in CXt_LOOP_FOR
David Mitchell [Tue, 13 Nov 2012 11:15:01 +0000 (11:15 +0000)]
pp_iter: move var declarations to narrower scope
David Mitchell [Tue, 13 Nov 2012 11:02:36 +0000 (11:02 +0000)]
pp_iter: reindent after removing if block
only whitespace changes
David Mitchell [Tue, 13 Nov 2012 10:57:35 +0000 (10:57 +0000)]
pp_iter: move RETPUSHYES outside switch
David Mitchell [Tue, 13 Nov 2012 10:52:49 +0000 (10:52 +0000)]
pp_iter: reindent code after previous change
Only whitespace changes
David Mitchell [Tue, 13 Nov 2012 10:35:34 +0000 (10:35 +0000)]
pp_iter: replace if/else with switch
Makes the code neater and slightly faster
Craig A. Berry [Thu, 15 Nov 2012 17:12:25 +0000 (11:12 -0600)]
Fix unescaped left brace warning in uni/parser.t.
Which was causing the test to fail (on VMS at least) with
"unexpected output at test 0".
Father Chrysostomos [Wed, 14 Nov 2012 22:19:52 +0000 (14:19 -0800)]
dump.c: Fix non-mad threaded build error
This was introduced by
75a6ad4aa3.
C preprocessors treat the ‘aTHX_ foo’ in MACRO(aTHX_ foo) as a sin-
gle argument.
Father Chrysostomos [Wed, 14 Nov 2012 21:02:48 +0000 (13:02 -0800)]
SVf_IsCOW
As discussed in ticket #114820, instead of using READONLY+FAKE to mark
a copy-on-write string, we should make it a separate flag.
There are many modules in CPAN (and 1 in core, Compress::Raw::Zlib)
that assume that SvREADONLY means read-only. Only one CPAN module,
POSIX::pselect will definitely be broken by this. Others may need to
be tweaked. But I believe this is for the better.
It causes all tests except ext/Devel-Peek/t/Peek.t (which needs a tiny
tweak still) to pass under PERL_OLD_COPY_ON_WRITE, which is a prereq-
uisite for any new COW scheme that creates COWs under the same cir-
cumstances.
Father Chrysostomos [Wed, 14 Nov 2012 19:22:56 +0000 (11:22 -0800)]
leakfinder.pl: Duh!
I hadn’t tested this before I committed it. It had a syntax error.
Reini Urban [Wed, 14 Nov 2012 18:33:43 +0000 (12:33 -0600)]
Combine duplicate dump code
Combine op_flags and op_private dumper for MAD (xml) and -Dx dump.
Add some previously missing flags.
Daniel Dragan [Wed, 14 Nov 2012 11:18:54 +0000 (06:18 -0500)]
remove most calls to strlen in S_force_ident
I saw strlen("\"") being called here, where the string came from
Perl_yylex. This commit provides a shortcut to not call strlen for a
1 character + null character string.
Father Chrysostomos [Wed, 14 Nov 2012 14:10:37 +0000 (06:10 -0800)]
Stop eval "END OF TERMS" from leaking
I found this memory leak by evaluating lines of the Copying file as
Perl code. :-)
The parser requires yylex to return exactly one token with each call.
Sometimes yylex needs to record a few tokens ahead of time, so its
puts them in its forced token stack. The next call to yylex then pops
the pending token off that stack.
Ops belong to their subroutines. If the subroutine is freed before
its root is attached, all the ops created when PL_compcv pointed
to that sub are freed as well. To avoid crashes, the ops on the
savestack and the forced token stack are specially marked so they are
not freed when the sub is freed.
When it comes to evaluating "END OF TERMS AND CONDITIONS", the END
token causes a subroutine to be created and placed in PL_compcv. The
OF token is treated by the lexer as a method call on the TERMS pack-
age. The TERMS token is placed in the forced token stack as an sv in
an op for a WORD token, and a METHOD token for OF is returned. As
soon as the parser sees the OF, it generates an error, which results
in LEAVE_SCOPE being called, which frees the subroutine for END while
TERMS is still on the forced token stack. So the subroutine’s op
cleanup skips that op. Then the parser calls back into the lexer,
which returns the TERMS token from the forced token stack. Since
there has been an error, the parser discards that token, so the op
is never freed. The forced token stack cleanup that happens in
parser_free does not catch this, as the token is no longer on
that stack.
Earlier, to solve the problem of yylex returning freed ops to the
parser, resulting in crashes, I set the op_savefree flag on ops on the
forced token stack. But that resulted in a leak.
So now I am using a different approach: When the sub is freed and
frees all its ops, have it also look in the parser’s forced token
stack, freeing any ops that belong to it, and setting the point-
ers to null.
Father Chrysostomos [Wed, 14 Nov 2012 07:41:19 +0000 (23:41 -0800)]
Stop my subs with syntax errors from leaking
Karl Williamson [Mon, 12 Nov 2012 23:43:12 +0000 (16:43 -0700)]
utf8.c: Don't copy a buffer to itself
memcpy(), which is what Copy() resolves to, is not supposed to handle
the possibility of overlapping source and destination. In some cases
in this code, the source and destination pointers are identical. What
should happen then is a no-op, so just don't do the copy in that case.
If the ptrs aren't identical, they won't otherwise overlap, so the
Copy() is valid except for when they are identical.
Chris 'BinGOs' Williams [Wed, 14 Nov 2012 14:46:15 +0000 (14:46 +0000)]
Update Unicode-Collate to CPAN version 0.92
[DELTA]
0.92 Wed Nov 14 20:58:19 2012
- fix: index() etc. with preprocess/normalization should be always croaked.
- doc: referred to the latest UTS #10 and updated its section numbers.
- supported the identical level (see 'identical' in POD).
- Now UCA_Version 26 (for Unicode 6.2.0) is supported.
- added ident.t in t.
- modified tests: cjkrange.t, compatui.t, hangtype.t, index.t,
overcjk0.t, overcjk1.t, test.t, view.t in t.
* But the default UCA_Version is still 24.
(In the next release, UCA_Version 26 will be the default.)
Chris 'BinGOs' Williams [Wed, 14 Nov 2012 14:44:56 +0000 (14:44 +0000)]
Sync Module-CoreList in Maintainers.pl with CPAN
Father Chrysostomos [Wed, 14 Nov 2012 06:49:36 +0000 (22:49 -0800)]
leakfinder.pl: more exceptions
Father Chrysostomos [Wed, 14 Nov 2012 05:54:32 +0000 (21:54 -0800)]
Fix various mad eval leaks
Several SVs that exist for the sake of mad dumps were being set up
even for normal execution.
Father Chrysostomos [Wed, 14 Nov 2012 00:47:24 +0000 (16:47 -0800)]
op.c: Fix mad+POISON build under clang
Craig A. Berry [Wed, 14 Nov 2012 01:20:38 +0000 (19:20 -0600)]
Preserve case for the current perldelta on VMS.
Both MMS and MMK upcase whenever there is a double macro expansion,
but by going through only one expansion, we can preserve the case
of the target filename on copy under extended parse.
Tony Cook [Tue, 13 Nov 2012 23:44:25 +0000 (10:44 +1100)]
dTHX implies dVAR, using both fails to build under -DPERL_GLOBAL_STRUCT
Father Chrysostomos [Tue, 13 Nov 2012 22:53:33 +0000 (14:53 -0800)]
leakfinder.pl: More exceptions
Father Chrysostomos [Tue, 13 Nov 2012 22:52:09 +0000 (14:52 -0800)]
Fix assertion failures with anon subs
In commit
9ffcdca1f50, I did not take into account that the newATTRSUB’s
caller makes sure that the CV is freed if it is an anonymous sub. So I
only needed to free the sub explicitly after a syntax error for a named
sub.
By returning 0 for anonymous subs as well, I ended up causing assertion
failures. Why I wasn’t getting them before I don’t know, as I was using
a debugging build.
Father Chrysostomos [Tue, 13 Nov 2012 20:44:16 +0000 (12:44 -0800)]
Stop /(??{})/ from leaking temporary regexps
Father Chrysostomos [Tue, 13 Nov 2012 17:10:09 +0000 (09:10 -0800)]
regexec.c: Safer stack handling for re-evals
I don’t believe there is an actual bug here (only a theoretical one), but comparing pointers into an array that has been reallocated meanwhile is not a good idea.
Eric Brine\" (via RT) [Tue, 13 Nov 2012 10:42:47 +0000 (02:42 -0800)]
Silence two build warnings on systems where ivsize > ptrsize.
# New Ticket Created by "Eric Brine"
# Please include the string: [perl #115710]
# in the subject line of all future correspondence about this issue.
# <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=115710 >
This is a bug report for perl from ikegami@adaelis.com,
generated with the help of perlbug 1.39 running under perl 5.14.2.
-----------------------------------------------------------------
[Please describe your issue here]
Attached patch silences two build warnings on systems where ivsize >
ptrsize.
They are safe to ignore, a side-effect of a function with a polymorphic
interface.
cv = find_runcv_where(FIND_RUNCV_level_eq, iv, NULL);
cv = find_runcv_where(FIND_RUNCV_padid_eq, PTR2IV(p), NULL); // p is a
PADNAMELIST*
[Please do not change anything below this line]
-----------------------------------------------------------------
Father Chrysostomos [Tue, 13 Nov 2012 08:00:45 +0000 (00:00 -0800)]
leakfinder.pl: More exceptions
Father Chrysostomos [Tue, 13 Nov 2012 07:46:16 +0000 (23:46 -0800)]
leakfinder.pl: Run code more times
Sometimes a piece of code will still create new SVs on the second
or even the third iteration, but not after that. That doesn’t count
as a leak.
Eric Brine [Tue, 13 Nov 2012 00:40:49 +0000 (19:40 -0500)]
Do a better job of escaping components of ldlibpth for the shell
It's not unusual, for example, for the search path to include "(" and ")" in cygwin.
Father Chrysostomos [Tue, 13 Nov 2012 07:11:34 +0000 (23:11 -0800)]
Prune dead code in pp_ctl.c:pp_goto
We croak if CxTYPE(cx) == CXt_EVAL before reaching the code
in question.
Father Chrysostomos [Tue, 13 Nov 2012 07:04:16 +0000 (23:04 -0800)]
Don’t leak subs containing syntax errors
I fixed this for BEGIN blocks earlier, but missed the fact that
all subs are affected.
When called without an o argument (from newANONATTRSUB), newATTRSUB
is expected to return a CV with an unowned reference count of which
the caller will take ownership. We cannot have newATTRSUB returning
a freed CV, so we have it return null instead. But that means
ck_anoncode and pm_runtime have to account for that.
Father Chrysostomos [Tue, 13 Nov 2012 04:10:56 +0000 (20:10 -0800)]
Stop anon subs with bad attributes from leaking
Father Chrysostomos [Tue, 13 Nov 2012 00:04:07 +0000 (16:04 -0800)]
Stop goto &sub from leaking when it croaks
Chris 'BinGOs' Williams [Mon, 12 Nov 2012 23:49:19 +0000 (23:49 +0000)]
Update IO-Compress to CPAN version 2.058
[DELTA]
2.058 12 November 2012
* RT# 81119: Latest IO::Compress 2.057 fails tests on 5.8.x
Chris 'BinGOs' Williams [Mon, 12 Nov 2012 23:46:12 +0000 (23:46 +0000)]
Update Compress-Raw-Bzip2 to CPAN version 2.058
[DELTA]
2.058 12 November 2012
* No Changes
Chris 'BinGOs' Williams [Mon, 12 Nov 2012 23:44:13 +0000 (23:44 +0000)]
Update Compress-Raw-Zlib to CPAN version 2.058
[DELTA]
2.058 12 November 2012
* No Changes
Father Chrysostomos [Mon, 12 Nov 2012 20:45:43 +0000 (12:45 -0800)]
Add Tom Wyant’s e-mail to AUTHORS
Father Chrysostomos [Mon, 12 Nov 2012 20:42:55 +0000 (12:42 -0800)]
perlvar: two spaces after dots
Tom Wyant [Mon, 12 Nov 2012 20:41:38 +0000 (12:41 -0800)]
Documentation of non-handle IO::Handle methods in perlvar.pod
The documentation to IO::Handle says that certain methods may not be set
on file handles, only statically. It would be nice (in my perhaps
not-so-humble opinion) if the distinction between per-filehandle and
non-perl-filehandle methods were recognized in perlvar.pod. The appended
universal diff is my cut at this.
diff a/pod/perlvar.pod b/pod/perlvar.pod
Daniel Dragan [Mon, 12 Nov 2012 16:08:44 +0000 (11:08 -0500)]
pv->pvn for literals in pp_require and Perl_sv_derived_from_pvn
I found these 2 strlens while stepping through the interp while running a
script and both came from a pp_require. UNIVERSAL::can was not modified
since it is more rarely called than pp_require. A better more through
investigation of version obj comparison and upgrading will need to be done
in the future (new funcs needed for the derived/upg_version idiom, remove
the upg_version since it was changed to always be a ver obj, etc).
Lukas Mai [Mon, 12 Nov 2012 17:21:28 +0000 (18:21 +0100)]
fix typo in comment
Daniel Dragan [Mon, 12 Nov 2012 08:22:12 +0000 (03:22 -0500)]
more dTHX optimizations
Either delay fetching of the context, or move the declaration close to the
first usage point, or remove the dependency on a context.
Daniel Dragan [Sat, 10 Nov 2012 17:49:38 +0000 (12:49 -0500)]
add items checking to Internals::SvREFCNT
Add item count checking to Internals::SvREFCNT in case prototype is
bypassed. Getting rid of the undef saves some instructions. Reading
SvREFCNT(sv) only once save an instruction.
Daniel Dragan [Mon, 12 Nov 2012 14:19:10 +0000 (06:19 -0800)]
clean up the users of PL_no_mem
This commit eliminates a couple strlen()s of a literal. "Out of memory!\n"
and PL_no_mem did not string pool on Visual C, so PL_no_mem was given a
length. This commit removes S_write_no_mem and replaces it with nonstatic.
Perl_croak_no_mem was made nocontext to save instructions in it's callers.
NORETURN_FUNCTION_END caused a syntax error on Visual C C++ mode and
therefore was removed.
Ricardo Signes [Mon, 12 Nov 2012 14:21:01 +0000 (09:21 -0500)]
Merge branch 'debugger-refactoring' into blead
Shlomi Fish [Wed, 7 Nov 2012 22:37:51 +0000 (00:37 +0200)]
Small cleanups.