E.Z. Hart [Mon, 16 Sep 2019 14:23:55 +0000 (08:23 -0600)]
Fix horizontal layout issues introduced in 7456; fixes #7519 fixes #7524 (#7522)
E.Z. Hart [Mon, 16 Sep 2019 13:02:58 +0000 (07:02 -0600)]
Implement EmptyView on UWP (#7438)
Javier Suárez Ruiz [Mon, 16 Sep 2019 12:13:07 +0000 (14:13 +0200)]
Added Carousel SnapBehavior Core sample (#7444)
ShaneN [Sun, 15 Sep 2019 00:52:56 +0000 (18:52 -0600)]
merge 4.2.0 into 4.3.0
Shane Neuville [Sun, 15 Sep 2019 00:40:55 +0000 (18:40 -0600)]
Check if Control is ready before interacting with Native control (#7523)
* Check if control is ready before setting Text
* - make 7.0 compatible
E.Z. Hart [Fri, 13 Sep 2019 09:55:27 +0000 (03:55 -0600)]
Remove extra properties from CarouselView API (#7456)
* Remove Header/Footer properties from CarouselView
* Limit CarouselView to LinearItemsLayout
* Rework inheritance for UWP
* Split files by class
* Fix up Tizen renderer
Samantha Houts [Thu, 12 Sep 2019 22:55:09 +0000 (15:55 -0700)]
Merge branch '4.2.0' into 4.3.0
Samantha Houts [Thu, 12 Sep 2019 22:52:45 +0000 (15:52 -0700)]
Merge branch '4.1.0' into 4.2.0
Jonathan Peppers [Thu, 12 Sep 2019 22:36:35 +0000 (17:36 -0500)]
[xamlc] new <XFXamlCValidateOnly> MSBuild property for Debug builds (#7407)
XamlC is currently enabled for most Xamarin.Forms projects in `Debug`
and `Release` configurations. It enables faster startup/runtime
performance, XAML-syntax checking at build time--both quiet useful!
However, there is a build-time cost to using XamlC: each assembly is
loaded via Mono.Cecil, IL generated, and saved back to disk as an
additional step after Rosyln has compiled the assembly.
The proposal would be to add a new experimental MSBuild property, that
can be enabled for `Debug` mode such as:
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<!-- ... -->
<XFXamlCValidateOnly>True</XFXamlCValidateOnly>
</PropertyGroup>
This would do the following:
* `OptimizeIL` is skipped.
* Assemblies are analyzed, but no changes written to disk.
* No symbols are loaded via Mono.Cecil, we don't need them if we
aren't writing back to disk!
This will improve build performance, and we don't lose the build-time
error checking for XAML.
Down the road, we could consider moving the MSBuild property to be the
default for `Debug` builds or change the Xamarin templates. I think it
would be wise to require developers to opt-in to try this out.
~~ Results ~~
I tested this change by building the ControlGallery after changing one
line of XAML:
msbuild Xamarin.Forms.ControlGallery.Android\Xamarin.Forms.ControlGallery.Android.csproj /clp:performancesummary /p:XFXamlCValidateOnly=True
Before:
1979 ms XamlCTask 1 calls
After:
923 ms XamlCTask 1 calls
I *only* tested `Debug` builds.
Right, so it's faster. But let's keep the entire developer loop in
mind, how much slower is startup?
Before:
09-05 14:37:32.274 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s890ms
09-05 14:38:30.178 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s848ms
09-05 14:38:40.300 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s848ms
After:
09-05 14:40:38.512 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s894ms
09-05 14:40:55.497 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s856ms
09-05 14:41:03.754 1169 1192 I ActivityManager: Displayed AndroidControlGallery.AndroidControlGallery/md546303760447087909496d02dc7b17ae8.Activity1: +3s897ms
After three runs, it seems this app suffers 25-50ms slowdown to
startup, and gains 1 second of build time improvement. A good net-win!
Other apps that have significantly more XAML will have different
results. I suspect the build time improvement will be even better, but
the hit to startup could be worse. With this setting opt-in, we can
experiment and find out.
Mahmoud Ali [Thu, 12 Sep 2019 22:36:02 +0000 (19:36 -0300)]
Warn on Styles validation instead of throwing exception (#7495)
* Warn on Styles validation instead of throwing exception
* Correct tests
fixes #6907
Shane Neuville [Thu, 12 Sep 2019 21:27:04 +0000 (15:27 -0600)]
add check to see if ShellContent is Visible one (#7460)
Shane Neuville [Thu, 12 Sep 2019 20:06:39 +0000 (14:06 -0600)]
fix NRE on _itemsSource when using IEnumerable (#7480)
Samantha Houts [Thu, 12 Sep 2019 20:02:49 +0000 (13:02 -0700)]
[iOS] If ListView is disposed before callback happens, return early (#7428)
* Add test case
* Update Issue7371.cs
* Update Issue7371.cs
* [iOS] If ListView is disposed before callback happens, return early
fixes #7371
Stephane Delcroix [Thu, 12 Sep 2019 00:35:40 +0000 (02:35 +0200)]
visualDiagnostics (#7474)
Javier Suárez Ruiz [Wed, 11 Sep 2019 23:40:26 +0000 (01:40 +0200)]
Hide some CarouselView methods from IntelliSense (#7475)
* Hide SetCurrentItem and SetIsDragging CarouselView methods from Intellisense
* Added required using to use EditorBrowsable
E.Z. Hart [Wed, 11 Sep 2019 23:31:29 +0000 (17:31 -0600)]
Leave BindingContext intact when recycling TemplatedItemViewHolder (#7426) fixes #6889
Fixes #6889
Shane Neuville [Wed, 11 Sep 2019 17:29:17 +0000 (11:29 -0600)]
Fix direction of walking when calculating effective FlyoutBehavior (#7459)
* fix direction of walking
* Update Xamarin.Forms.Core/Shell/Shell.cs
Shane Neuville [Wed, 11 Sep 2019 16:28:21 +0000 (10:28 -0600)]
move await to Begin Invoke and check for disposed (#7192)
Shane Neuville [Wed, 11 Sep 2019 07:14:27 +0000 (01:14 -0600)]
Wrong type checked after casting to type being searched for (#7461)
* wrong type checked when searching for parent
* Update Xamarin.Forms.Platform.Android/ViewExtensions.cs
Co-Authored-By: Stephane Delcroix <stephane@delcroix.org>
* - add api level check for ui tests
- fixes #7329
Shane Neuville [Wed, 11 Sep 2019 07:10:59 +0000 (01:10 -0600)]
Dispose of HttpResponseMessage after stream is used (#7431)
- fixes #7248
ShaneN [Tue, 10 Sep 2019 21:32:39 +0000 (15:32 -0600)]
Merge 4.2.0 into 4.3.0
Shane Neuville [Tue, 10 Sep 2019 21:25:17 +0000 (15:25 -0600)]
Update support libraries from 28.0.0.1 to 28.0.0.3 (#7389)
* update support to 28.0.0.3
* - bump sandbox support versions
* - update nuspecs
Shane Neuville [Tue, 10 Sep 2019 15:05:55 +0000 (09:05 -0600)]
[Tests]Update to Xamarin.UITest 3.0 and NUnit 3.0 (#6332) (#7031)
* [Tests]Update to Xamarin.UITest 3.0 and NUnit 3.0 (#6332)
* - increment test nugets
* - adapter folder
* - uitest version
* add wait for 34632
E.Z. Hart [Mon, 9 Sep 2019 15:46:07 +0000 (09:46 -0600)]
[iOS] More intelligent cell resizing (#7285)
* More intelligent cell resizing; fix infinite layout loop and crash;
Reuse template views instead of re-creating them every time;
Fixes #7128
* Fix attribute ambiguity
* Drop trailing 'and'
E.Z. Hart [Mon, 9 Sep 2019 11:00:04 +0000 (05:00 -0600)]
Implement Move, Replace, and Reset for UWP CollectionView collection changes (#7384)
Stephane Delcroix [Mon, 9 Sep 2019 07:50:17 +0000 (09:50 +0200)]
Merge branch '4.2.0' into 4.3.0
Rui Marinho [Sat, 7 Sep 2019 22:07:50 +0000 (23:07 +0100)]
[UItests] Fix CarouselView tests (#7379)
* Update testcloud agent
* [UITests] Fix uitests for CarouselView
* [UITests] Fix the rest of uitests for the position
* [UITests] Use the drag api to swipe the Carousel
* Update CarouselViewUITests.cs
* [Uitests] Enable CarouselViewVertical
* [UITests] Try a new fix for UITests
Shane Neuville [Sat, 7 Sep 2019 07:11:41 +0000 (01:11 -0600)]
[UWP] RefreshView (#7319)
* UWP Swipe Refresh implementation
* - target platform warnings for UWP
* - move dictionary registration to code
* - remove SkipMicrosoftUIXamlCheckTargetPlatformVersion
Shane Neuville [Sat, 7 Sep 2019 07:09:47 +0000 (01:09 -0600)]
Queue Page.Display actions until platform is ready (#7316)
* Queue Page.Display actions until platform is ready
* - fix click
* - set IsPlatformEnabled enabled for Display tests
Rui Marinho [Thu, 5 Sep 2019 23:33:50 +0000 (00:33 +0100)]
[Build] Bump msbuild locator move to VS2019 (#7415)
* Bump msbuild locator
* Update test adapter
* Update build-windows.yml
* Update azure-pipelines.yml
* Update build-windows.yml
Samantha Houts [Thu, 5 Sep 2019 17:27:20 +0000 (10:27 -0700)]
Merge branch '4.2.0' into 4.3.0
Stephane Delcroix [Thu, 5 Sep 2019 12:18:03 +0000 (14:18 +0200)]
[X] do not throw here
Shane Neuville [Thu, 5 Sep 2019 00:28:24 +0000 (18:28 -0600)]
Fix RTL behavior for MasterDetailsPage when running on iOS 13 iPads (#7271)
* Fix RTL on iOS 13 tablets with MDP
* - add backgrounding extension for iOS
fixes #7224
fixes #7266
Javier Suárez Ruiz [Wed, 4 Sep 2019 22:52:21 +0000 (00:52 +0200)]
Fixed issue updating the PeekAreaInsets property value (#7382)
Javier Suárez Ruiz [Wed, 4 Sep 2019 13:48:51 +0000 (15:48 +0200)]
[Android, iOS] Fix CarouselView Issues (#7366)
* Fixed CarouselViewGalleries sample on Android
* Protect NRE setting the CurrentItem
* Fixed issue changing the ItemsSource
* Fixed issues with NumberOfSideItems and PeekAreaInsects properties on Android
* Fixed formatting
* Fix ItemSpacing issue on Android
* Fixed vertical peek insets iOS
* Center item after change ItemSpacing
Improve IsSwipeEnabled logic on Android (disable swipe but not touch)
* Update max slider value when item count is updated
* Update CarouselCodeGallery.cs
* NoOfSideItems in test page
Shane Neuville [Tue, 3 Sep 2019 23:52:42 +0000 (17:52 -0600)]
Fix iOS footer and header to layout left and right for horizontal layout (#7308) fixes #7246
* fix iOS footer and header to layout left and right for horizontal layout
* - however much
Stephane Delcroix [Tue, 3 Sep 2019 20:45:22 +0000 (22:45 +0200)]
[X] Reuse baseclass namescope if it exists (#7356)
* [X] chain debug ctors
* unit test for 7097
* [X] Reuse baseclass namescope if it exists
If a xaml control derives from another xaml control, thy both should share the same
NameScope. This add a check if the xaml root already has a NameScope (set by the base)
and reuses it.
This fixes 2 regressions introduced by #7040 and some other unreported edge cases.
- fixes #7097
- fixes #7286
* avoid repeting linq queries
E.Z. Hart [Tue, 3 Sep 2019 17:03:16 +0000 (11:03 -0600)]
Verify sections exist before calling NumberOfItemsInSection; fixes #7338 (#7354)
fixes #7338
Kevin Petit [Tue, 3 Sep 2019 16:25:46 +0000 (18:25 +0200)]
[Android] Correctly dispose TabbedPageRenderer (#4974)
* Correctly dispose TabbedPageRenderer.
The fragments created are now removed and the listeners are now correctly cleaned during dispose.
* Added issue UI test.
* Fix carousel fragment manager and pager disposing.
* Fix test 2338 implementation.
* Apply review.
* Set to null fragmentManager on dispose.
* Use GetFragmentManager extension method.
Co-Authored-By: Shane Neuville <shane94@hotmail.com>
* Revert some changes.
* Apply review comment.
bentmar [Mon, 2 Sep 2019 20:26:57 +0000 (22:26 +0200)]
[Android] fix animations not animating (#7298)
* [Android] fix animations not animating
fixes #7255
fixes #7291
fixes #7278
I found that if the Animation duration scale setting has never been changed in the developer settings, the scale we get will allways be 0. So instead of defaulting to 0 we default to 1. This means if i havent touched the setting it will behave as it did pre 4.2.
Also if somehow the context is null, we should default to enabling animations since this is far more "normal" than disabling animations.
* Update Xamarin.Forms.Platform.Android/AndroidTicker.cs
Co-Authored-By: Javier Suárez Ruiz <javiersuarezruiz@hotmail.com>
* Fix code
* Use tabs, return false if fail, enable warning
Shane Neuville [Mon, 2 Sep 2019 16:30:06 +0000 (10:30 -0600)]
[Android] Check if Shell Flyout header is null before trying to use it (#7333)
* Check if flyout header is null
* - remove mono args from csproj
Rui Marinho [Mon, 2 Sep 2019 16:04:57 +0000 (17:04 +0100)]
[iOS] Fix Scrolled, don't use UITableView delegate (#7328)
Stephane Delcroix [Mon, 2 Sep 2019 10:27:44 +0000 (12:27 +0200)]
try fo fix CI builds
Stephane Delcroix [Mon, 2 Sep 2019 08:22:59 +0000 (10:22 +0200)]
Merge branch '4.2.0' into 4.3.0
Stephane Delcroix [Mon, 2 Sep 2019 08:22:06 +0000 (10:22 +0200)]
fix merge issue
Stephane Delcroix [Mon, 2 Sep 2019 06:56:41 +0000 (08:56 +0200)]
Merge branch '4.2.0' into 4.3.0
Stephane Delcroix [Mon, 2 Sep 2019 06:39:59 +0000 (08:39 +0200)]
Merge branch '4.1.0' into 4.2.0
Stephane Delcroix [Mon, 2 Sep 2019 06:38:00 +0000 (08:38 +0200)]
Merge branch '4.0.0' into 4.1.0
Stephane Delcroix [Sun, 1 Sep 2019 21:01:44 +0000 (23:01 +0200)]
[X] Detect empty property value in markups (#7190)
- fixes #7187
kingces95 [Thu, 29 Aug 2019 23:39:49 +0000 (13:39 -1000)]
Fix NRE for gh 4267 (#7306)
Rui Marinho [Thu, 29 Aug 2019 23:26:23 +0000 (00:26 +0100)]
[Feature] CarouselView (#5044)
* [Spec] Draft carousel
* [Core,Spec] Add IndicatorsView
* [iOS] IndicatorsViewRenderer and CarouselVieRenderer draft
* [Controls] Fix controls gallery linker
* [Core] Remove extra file
* Fix Remove IITemsSource
* [iOS] Implement Scroll and selected item
* [iOS,Android,Core] Refactor to use CurrentItem on CarouselView
* [iOS,Core] Add NumberOfVisbileItems
* [iOS,Core] Add IsScrolling and IsDragging
* [iOS,Core] Add Visual state for carousel items
* [iOS,Core] Add padding to CarouselView
* [iOS,Controls] Fix sample, disable selection on CarouselViewController
* [Core] Add Delta to ScrolledDirectionEventArgs
* Update SelectableItemsViewRenderer.cs
* [Controls] Refactor Carousel examples
* [Controls] Fix csproj
* [iOS] Fix bug with insets with carouselview padding
* [Controls] Fix vm for CarouselXamlGallery
* [Controls] Collection Carousel type demo
* [Core] Add other CarouselView Layouts
* Fix Carousel rebase (#6518)
* Fix rebase Android
* Fix rebase iOS
* Update ItemSizingStrategy
* [Core] Add ItemSizingStrategy None
* [iOS] Allow to override ReuseId and RegisterCells from ItemsViewController
* Remove IndicatorsView
* Remove ICarouselViewController
* Implemented IsDragging on Android
* Implemented Scrolled for Android
* Removed Spacing methods
Spacing is now available on a lower level and we don't need to worry about it
* Fix rebase
* [UnitTests] Add basic CarouselView unit tests
* [iOS] Update CarouselViewLayout
* [iOS,Core] Remove Padding and add PeekAreaInsets
* [iOS] Fix peek area insets update on CarouselView
* [iOS,Core] Remove extra scroll code update
* [iOS] Fix bug ScrollAnimationEnded missing
* [Core] Mark BPK as private
* [Core] Rename NumberOfSideItems
* Update ItemsViewRenderer.cs
* [Android] Remove scroll direction update
* First small UI tests
* [iOS] Carousel Apply suggestions from code review
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* More UI tests and plumbing
* Fix build errors
* [Android] Fix CarouselView sizing on Android
* Implemented IsSwipeEnabled iOS
* Implemented bounce iOS
* Merged with scroll changes ItemsView
* Implemented IsBounceEnabled Android
* [Android] Update position
* Update App.cs
* Added CarouselView Core Gallery sample
* Update ItemsViewController.cs
* Fixed Core Gallery problems with Linker
* Added more CarouselView properties to the Core Gallery sample
* Added new CarouselView sample adding and removing items, etc.
* [Android]Add spacing inset for fist and last item
* [Android] ScrollTo and center item on carousel
* Spelling and not breaking build
* [Android]Use SnapHelper to get centered view
* Make Position work (again) for iOS
* Rebase from master (fixed conflicts)
Fixed Android bug related with the first item inset calcs.
fixes #4996
Shane Neuville [Thu, 29 Aug 2019 21:09:34 +0000 (15:09 -0600)]
[Android/iOS] RefreshView (#7214)
* Swipe To Refresh
* pull in pull to refresh
* api changes
* Added RefreshView CoreGallery and Gallery Samples (using ScrollView, ListView, CollectionView, etc.)
* Code refactoring in RefreshViewRenderer (iOS)
* Updated RefreshView Android Renderer
* Fixed RefreshView Android samples in Core Gallery
* Added initial RefreshView UWP implementation
* Added another UWP RefreshView renderer using WinUI NuGet controls (RefreshContainer)
* - additional linker settings
* - uwp fixes
* - disable SkipMicrosoftUIXamlCheckTargetPlatformVersion check
* Update .nuspec/Xamarin.Forms.targets
* Limited RefreshView in Android to support only content using scroll.
Small changes in RefreshView iOS renderer.
Updated Core Gallery RefreshView samples.
* Fixed Visualizer colors in UWP RefreshView
* Added UWP RefreshPullDirection Platform Specific
* Small changes in code syntax in iOS renderer.
* Removed some unnecessary curly braces .
* Register effect provider in iOS RefreshView
* Changes in RefreshView UWP Dispose
* Added conditional code to manage the refresh control differently if it is iOS 10 or higher.
* Fixed error in Android Core Gallery (Linker)
Code refactoring and small changes (PR Feedback)
* Changes disposing the Android renderer
* - fix SkipMicrosoftUIXamlCheckTargetPlatformVersion so it can be turned off
* Removed UWP RefreshView renderer and Platform Specific
* - remove winui from nuspec
* - remove skip checks from targets
* - remove XamlControlsResources
* - remove skip check on UAP platform
* Revert changes in Android Core Gallery manifiest
* Revert unnecessary space in UAP Platform csproj
* Removed unnecessary new line in UWP Resources
* Simplified RefreshView iOS Renderer.
fixes #5882
Samantha Houts [Thu, 29 Aug 2019 18:39:40 +0000 (11:39 -0700)]
[iOS] Fix accessibility regressions with hidden views, WebViews, and layouts (#7213)
* [iOS] Allows views that don't implement ITabStop to be accessible
Also added ITabStop to the WebView renderers
fixes #6894
* [iOS] Don't exclude layouts from a11y tree
fixes #7053
* Add test for 7053
* Add test for 6894
* [iOS] Clear accessibility elements when visibility changes
fixes #6929
* Add test for 6929
* Update Issue6894.cs
Shane Neuville [Thu, 29 Aug 2019 17:42:59 +0000 (11:42 -0600)]
Add priority parameter to HandlerAttribute to thwart priority by assembly order (#7113) fixes #6939
* add priority parameter to handler to thwart priority by assembly order
* - internalize priority
* - fix ui tests
* - remove from uwp
* - registrar fix
Samantha Houts [Thu, 29 Aug 2019 17:06:03 +0000 (10:06 -0700)]
Update issue templates
Joe Manke [Thu, 29 Aug 2019 16:47:57 +0000 (11:47 -0500)]
[Maps] Add polylines and polygons (#6136)
* Add Polyline to Map
* Android Polyline rendering
* iOS polyline renderer
* UWP polyline renderer
* Unregister OnPolylineCollectionChanged in Dispose of UWP renderer
* Add MapElement base class
* Update Android MapRenderer with MapElement
* Update UWP MapRenderer with MapElement
* Update iOS MapRenderer with MapElement
* Add polygons
* Tweak functionality of gallery page
* Rename some things in Android renderer
* Made LoadPolyline and LoadPolygon virtual on UWP
* Fix iOS/Mac MapRenderer compile errors
fixes #1673
fixes #5773
yourina [Thu, 29 Aug 2019 14:12:00 +0000 (10:12 -0400)]
[Shell][Tizen] Add the MaterialShellRenderer on Tizen (#6196)
* [Shell][Tizen] Add the MaterialShellRenderer on Tizen
* Fixed the build fail
* Update namespace
Shane Neuville [Wed, 28 Aug 2019 21:27:59 +0000 (15:27 -0600)]
Fix Android FlyoutBehavior Disabled and add UI Tests (#7254)
* fix android flyout behavior and add ui tests
* - fix ui test
* - FlyoutLocked fixes
fixes #7238
fixes #6261
Stephane Delcroix [Wed, 28 Aug 2019 21:23:37 +0000 (23:23 +0200)]
[X] OnPlatform use BP.DefaultValue (#7188)
If no default is provided for {OnPlatform}, default to DefaultValue
if this is targetting a BindableProperty.
Also use other value than null as sentinel, as {x:Null} is a
perfectly valid value.
- fixes #7156
ksemenenko [Wed, 28 Aug 2019 20:49:20 +0000 (23:49 +0300)]
ListView.Scrolled (#7157)
fixes #4323
Shane Neuville [Wed, 28 Aug 2019 20:45:48 +0000 (14:45 -0600)]
Remove header padding and propagate elevation (#6970)
- fixes #6964
E.Z. Hart [Wed, 28 Aug 2019 17:30:05 +0000 (11:30 -0600)]
[iOS] Implement CollectionView ScrollTo with groups (#7220)
* ScrollTo with groupIndex on iOS
* Add test for scrolling to group/item (objects rather than indexes)
* Fix automation IDs for new fields
* Add missing issue info to test page
* Fix UI tests
* Workaround for problems scrolling to group index/item index on first try
* Make the test page legible on Android
* Remove private modifiers
Shane Neuville [Wed, 28 Aug 2019 15:59:11 +0000 (09:59 -0600)]
fix android content offset on navigated to page (#7265)
Gerald Versluis [Wed, 28 Aug 2019 11:25:02 +0000 (13:25 +0200)]
Make Label display HTML from a string (#4527)
* Use UpdateText
* Added missing helper method and UI test
* Added missing helper for UWP
* Added csproj entry for helper
* Resolved rebase conflicts
* Update LabelRenderer.cs
* Update LabelRenderer.cs
* Update LabelRenderer.cs
* iOS Merge error fix
* Feedback
* - uwp fixes
* - android fix empty text
* - ios fix null and setting text when texttype starts as html
* - set _perfectSizeValid = false; after changed AttributedText
Setting the AttributedText causes GetDesiredSize to get called which sets _perfectSizeValid to true but at this point this frame still hasn't adjusted to any size change from *LayoutSubViews*. This resets _perfectSizeValid so after the AttributedText set the desiredsize can get pulled again
* Renamed PlainText to Text
* Fixed initial no HTML styling
E.Z. Hart [Wed, 28 Aug 2019 01:29:07 +0000 (19:29 -0600)]
Implement CollectionView grouping on Android (#7199)
* Move all the header/footer adjustment to IItemsViewSource
fixes #7121
fixes #7102
partially implements #3172
fixes #7243
* Fix selection bugs introduced by header/footer on Android
* Implement grouping for CollectionView on Android
* Enable grouping tests for Android
* Naming and comment cleanup
* Update Xamarin.Forms.Platform.Android/CollectionView/ListSource.cs
Co-Authored-By: Gerald Versluis <gerald.versluis@microsoft.com>
* Update Xamarin.Forms.Platform.Android/CollectionView/ObservableGroupedSource.cs
Chris King [Tue, 27 Aug 2019 20:44:17 +0000 (10:44 -1000)]
update create-nuget.bat
Pedro Jesus [Tue, 27 Aug 2019 14:14:32 +0000 (11:14 -0300)]
Automated UI Tests (#5880)
* - automated the Bugzilla43663 and 44476
* - Add instructions in the test
* - Automated Bugzilla43519
* - Add Category in Bugzilla43469
* -Add instructions in Bugzilla42832
* - Automated 42329
* - Automated Bugzilla41271
* - style code
* - Automated Bugzilla40955
* - Automated Bugzilla40824
* - Add instructions to Bugzilla40824
* - Automated and Add instructions Bugzilla40408
* - fix code style in consts
* - Automated Bugzilla40092
* - Automated Bugzilla40092
* - Add instructions in B40092
* - B39987 Fix the preserve atribute; Automated
- Fix B40092 tests
* - Improve in B40092
* Review Bugzilla:
- 40092
- 41271
- 43663
* - Fix the build fails (changed const name)
* -Fix the mapRenderer error
* - Bugzilla 40408 pass in UWP
* - 41271 fix in uwp
* - Fix B42329 in UWP
* - code adjust
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40824.cs
Co-Authored-By: pictos <pedrojesus.cefet@gmail.com>
* - REmove obsolet refernece
* - Revert the Bugzilla40824
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla42329.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla42329.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* - Fidex B42329
* - Fixed B41271
* - Fixed B43519
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40092.cs
Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla43663.cs
Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40408.cs
Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39987.cs
Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* - B42329 runs only on Android
E.Z. Hart [Tue, 27 Aug 2019 13:59:56 +0000 (07:59 -0600)]
Disable UWP CollectionViewSource CurrentItem synchronization (#7267) fixes #7194
* Disable UWP CollectionViewSource CurrentItem synchronization
Fixes #7194
* Remove unnecessary stuff from test page
E.Z. Hart [Tue, 27 Aug 2019 13:57:01 +0000 (07:57 -0600)]
Fix crash with nested CollectionViews on UWP (#7273) fixes #6620
Closes #6620
Shane Neuville [Tue, 27 Aug 2019 07:19:52 +0000 (01:19 -0600)]
Fix android to not duplicate titleview with shell (#7276)
Pavel Yakovlev [Mon, 26 Aug 2019 11:33:14 +0000 (14:33 +0300)]
fixes toolbox snippet for CollectionView (#7259)
Rui Marinho [Mon, 26 Aug 2019 11:28:55 +0000 (12:28 +0100)]
[Build] Add nightly schedule (#7263)
* [Build] Add nightly schedule
* Update azure-pipelines.yml
Stephane Delcroix [Mon, 26 Aug 2019 08:25:55 +0000 (10:25 +0200)]
Merge branch '4.2.0'
Stephane Delcroix [Mon, 26 Aug 2019 08:24:04 +0000 (10:24 +0200)]
Merge branch '4.1.0' into 4.2.0
Pavel Yakovlev [Thu, 22 Aug 2019 14:58:04 +0000 (17:58 +0300)]
[Mac] Added support AutomationProperty (#5137)
* [Mac] Added support AutomationProperty
* revert defaults
* clean code
* Update AutomationPropertiesGallery.cs
Kevin Petit [Thu, 22 Aug 2019 14:00:13 +0000 (16:00 +0200)]
[Android] Fix MasterDetailContainer fragment handling (#6471)
* Fix MasterDetailContainer fragment handling.
Transaction is necessarily executed after the view is added.
* Only postpone the transaction if the view is not attached yet.
* typo, private
Rui Marinho [Thu, 22 Aug 2019 13:39:11 +0000 (14:39 +0100)]
Update categories for tests
kingces95 [Thu, 22 Aug 2019 13:33:06 +0000 (03:33 -1000)]
Fix NRE fixes #6776 (#7215)
Shane Neuville [Thu, 22 Aug 2019 13:27:44 +0000 (07:27 -0600)]
make all ShellTabBarAppearanceTracker methods virtual (#7175)
Brayan Khosravian [Thu, 22 Aug 2019 13:12:34 +0000 (15:12 +0200)]
- Issue 7207 - if current culture of the current thread is not set to the invariant culture then initializing the app causes a "NUnit.Framework.InconclusiveException" with the exception- message "App did not start for some reason. System.Argument.Exception: 1 is not supported code page. Parameter name: codepage." (#7228)
* - Issue 7207 - if current culture of the current thread is not set to the invariant culture then initializing the app causes a "NUnit.Framework.InconclusiveException" with the exception- message "App did not start for some reason. System.Argument.Exception: 1 is not supported code page. Parameter name: codepage."
* - fixed usings
Pavel Yakovlev [Thu, 22 Aug 2019 11:57:45 +0000 (14:57 +0300)]
[iOS] fix accessibility of Picker (#5145)
Andrei Nitescu [Thu, 22 Aug 2019 11:54:04 +0000 (14:54 +0300)]
Entry ClearButtonMode (#5277)
* Entry ClearButtonMode property (#5277)
* Renamed to ClearButtonVisibility
Kangho Hur [Thu, 22 Aug 2019 11:51:32 +0000 (20:51 +0900)]
[Tizen] Adds Opt-in Init (#7209)
Guido Neele [Thu, 22 Aug 2019 11:23:55 +0000 (13:23 +0200)]
[Android] Context actions menu is now updated when changing cells. (#6460) fixes #1455 fixes #4041
* Bugfix of issue 1455. Force SupportActionMode Menu to recreate when it's active and another cell is clicked.
* Added UITest
* Added an assert which checks if the new menu items have been updated.
* Correct project file
* Added a platform specific BindableProperty for the ViewCell to use ContextActions in LegacyMode.
* Update Xamarin.Forms.Core/PlatformConfiguration/AndroidSpecific/ViewCell.cs
Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1455.xaml.cs
Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
Gerald Versluis [Thu, 22 Aug 2019 11:17:26 +0000 (13:17 +0200)]
Update SafeShellTabBarAppearanceTracker.cs (#7165) fixes #6739
E.Z. Hart [Thu, 22 Aug 2019 11:10:12 +0000 (05:10 -0600)]
Basic Header/Footer for UWP CollectionView (#7237)
Giampaolo Gabba [Wed, 21 Aug 2019 14:57:40 +0000 (16:57 +0200)]
[iOS] Fix LayoutCompression Performance Issues #3475 (#7201)
* fix #3475
* fix blank lines in project file
* fix issue in gallery to target iOS only
* fixed white spaces in project file (thx r#)
joepgrooten [Wed, 21 Aug 2019 00:23:02 +0000 (02:23 +0200)]
Fix default cancel button visibility on iOS SearchHandler (#6931)
fixes #6802
adrianknight89 [Mon, 19 Aug 2019 23:05:30 +0000 (18:05 -0500)]
minor fixes (#7178)
Brian Runck [Sun, 18 Aug 2019 16:53:42 +0000 (12:53 -0400)]
Update README.md (#7196)
Fix blog post link
Samantha Houts [Sat, 17 Aug 2019 01:23:01 +0000 (18:23 -0700)]
Merge branch '4.2.0'
Samantha Houts [Sat, 17 Aug 2019 01:22:38 +0000 (18:22 -0700)]
Update Forms.cs
Samantha Houts [Sat, 17 Aug 2019 00:54:38 +0000 (17:54 -0700)]
Merge branch '4.2.0'
Samantha Houts [Sat, 17 Aug 2019 00:51:53 +0000 (17:51 -0700)]
Merge branch '4.1.0' into 4.2.0
Samantha Houts [Sat, 17 Aug 2019 00:46:46 +0000 (17:46 -0700)]
Merge branch '4.0.0' into 4.1.0
Samantha Houts [Sat, 17 Aug 2019 00:41:04 +0000 (17:41 -0700)]
Merge branch '3.6.0' into 4.0.0
Shane Neuville [Sat, 17 Aug 2019 00:34:42 +0000 (18:34 -0600)]
Fix MDP for iPads running iOS13 (#7173)
* Fix MDP for iPads running iOS13
* - remove s_respondsTosetNeedsUpdateOfHomeIndicatorAutoHidden
* - missing ;
kicsiede [Fri, 16 Aug 2019 21:23:29 +0000 (23:23 +0200)]
[Core] FIX RelativeLayout layout error when only width or height specified (#5694)
fixes #5581
Shane Neuville [Fri, 16 Aug 2019 21:22:14 +0000 (15:22 -0600)]
[Shell] Fix back button behavior so that it only applies the property you've set opposed to replacing the entire thing (#6762)
* Fix backbutton behavior to only apply what you've set opposed to replacing everything
* - move GetPropertyIfSet to Core.Internals
* - make GetPropertyIfSet public.
fixes #5744
Samantha Houts [Fri, 16 Aug 2019 21:09:25 +0000 (14:09 -0700)]
[Tizen] Fix Forms namespace correctly (#7193)