platform/upstream/llvm.git
22 months ago[BOLT][NFC] Make DWOId std::optional
Amir Ayupov [Wed, 21 Dec 2022 18:09:46 +0000 (10:09 -0800)]
[BOLT][NFC] Make DWOId std::optional

Reviewed By: #bolt, ayermolo

Differential Revision: https://reviews.llvm.org/D140450

22 months ago[RISCV] Add more test cases to select.ll. NFC
Craig Topper [Wed, 21 Dec 2022 18:20:59 +0000 (10:20 -0800)]
[RISCV] Add more test cases to select.ll. NFC

These are test for select (and (x , 0x1) == 0), (z ^ y), y ) and select (and (x , 0x1) == 0), (z | y), y )

These can be made branchless by using ((x-1) & z ) ^ y.

22 months ago[ARC] Fix build after createMachineFunctionInfo change 69e75ae695d9ef1360a2a1fbefd6e0...
Fangrui Song [Wed, 21 Dec 2022 18:35:05 +0000 (10:35 -0800)]
[ARC] Fix build after createMachineFunctionInfo change 69e75ae695d9ef1360a2a1fbefd6e0e0456c3f7b

22 months ago[AArch64] Additional RSHRN pattern tests. NFC
David Green [Wed, 21 Dec 2022 18:32:52 +0000 (18:32 +0000)]
[AArch64] Additional RSHRN pattern tests. NFC

22 months ago[libc++] Rename __tuple to __tuple_dir to avoid file collision
Michał Górny [Sun, 4 Dec 2022 06:39:41 +0000 (07:39 +0100)]
[libc++] Rename __tuple to __tuple_dir to avoid file collision

Rename the `__tuple` directory in libc++ headers to `__tuple_dir`
to avoid file collision when installing.  Historically, `__tuple` has
been a file and it has been replaced by a directory
in 2d52c6bfae801b016dd3627b8c0e7c4a99405549.  Replacing a regular file
with a directory (or more importantly, the other way around when
downgrading) is not universally supported.  Since this is an internal
header, its actual name should not matter, so just rename it to avoid
problems.

Differential Revision: https://reviews.llvm.org/D139270

22 months ago[mlir][py] Enable building ops with raw inputs
Jacques Pienaar [Wed, 21 Dec 2022 18:10:31 +0000 (10:10 -0800)]
[mlir][py] Enable building ops with raw inputs

For cases where we can automatically construct the Attribute allow for more
user-friendly input. This is consistent with C++ builder generation as well
choice of which single builder to generate here (most
specialized/user-friendly).

Registration of attribute builders from more pythonic input is all Python side.
The downside is that
  * extra checking to see if user provided a custom builder in op builders,
  * the ODS attribute name is load bearing
upside is that
  * easily change these/register dialect specific ones in downstream projects,
  * adding support/changing to different convenience builders are all along with
    the rest of the convenience functions in Python (and no additional changes
    to tablegen file or recompilation needed);

Allow for both building with Attributes as well as raw inputs. This change
should therefore be backwards compatible as well as allow for avoiding
recreating Attribute where already available.

Differential Revision: https://reviews.llvm.org/D139568

22 months ago[flang] Use Assign() runtime for copy-in/copy-out.
Slava Zakharin [Wed, 21 Dec 2022 01:13:25 +0000 (17:13 -0800)]
[flang] Use Assign() runtime for copy-in/copy-out.

The loops generated under IsContiguous check for copy-in/copy-out
result in LLVM backend spending too much time optimizing them.
At the same time, the copy loops do not provide any optimization
opportunities with the surrounding code (since they are executed
under runtime IsContiguous check), so the copy code may be optimized
on its own and this can be done in runtime.

I thought I could implement and use new APIs for packing/unpacking
non-contiguous data (interfaces added in D136378), but then I found
that Assign() is already doing what is needed. If performance
becomes an issue for these loops, we can optimize code in Assign()
rather than creating new APIs.

Thus, this change makes use of Assign() for copy-in/copy-out
of boxed objects, and this is done only if the objects
are non-contiguous during execution. Copies for non-boxed
objects (e.g. for passing as VALUE dummy argument) are still
done inline, because they can potentially be optimized with
surrounding loops.

I added internal -inline-copyinout-for-boxes option to revert to the old
behavior just to make it easier to triage performance regressions,
if any appear after the change.

CPU2017/521.wrf compiles for 2179 seconds without the change and
the module_dm.f90 compiled with -O0 (without -O0 this single
module compiles for 5775 seconds). With the change total compilation
time of the benchmark reduces to 722 seconds.

Differential Revision: https://reviews.llvm.org/D140446

22 months ago[mlir] Fix SameOperandsAndResultType to check encoding.
Jacques Pienaar [Wed, 21 Dec 2022 17:49:18 +0000 (09:49 -0800)]
[mlir] Fix SameOperandsAndResultType to check encoding.

Encoding was accidentally left out here even though it forms part of the type.
This is small tightening step and I'll look at follow on to tighten more.

Differential Revision: https://reviews.llvm.org/D140445

22 months agomlir/LinalgOps: fix name of generated .yamlgen in comments
Ramkumar Ramachandra [Tue, 13 Dec 2022 16:43:36 +0000 (17:43 +0100)]
mlir/LinalgOps: fix name of generated .yamlgen in comments

Signed-off-by: Ramkumar Ramachandra <r@artagnon.com>
Differential Revision: https://reviews.llvm.org/D139946

22 months ago[Driver] Fix tests not to fail randomly on Windows
Paul Robinson [Wed, 21 Dec 2022 17:36:36 +0000 (09:36 -0800)]
[Driver] Fix tests not to fail randomly on Windows

These used a regex that didn't guard against backslashes, so
getting "lucky" with a temp dir name could make them fail.

22 months agoRevert "BEGIN_PUBLIC"
Mitch Phillips [Wed, 21 Dec 2022 17:18:01 +0000 (09:18 -0800)]
Revert "BEGIN_PUBLIC"

This reverts commit a6d6d40d8bd062514fc379a6bf70fb1b7220be6f.

Reason: Broke the ASan/MSan bots. More information in phabricator:
https://reviews.llvm.org/D140406

22 months ago[libc++] Add FreeBSD ABI list
Ed Maste [Tue, 20 Dec 2022 20:21:11 +0000 (15:21 -0500)]
[libc++] Add FreeBSD ABI list

Generated via `nina generate-cxx-abilist`.

Reviewed By: Mordante, ldionne, philnik
Differential Revision: https://reviews.llvm.org/D140431

22 months ago[NFC][libc++][chrono] Improves test coverage.
Mark de Wever [Thu, 1 Dec 2022 17:56:40 +0000 (18:56 +0100)]
[NFC][libc++][chrono] Improves test coverage.

The function year_month_weekday::sys_days should work properly with a
weekday index of 0 per [time.cal.ymwd.members]/20. This adds a test for
this case.

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D139126

22 months ago[NFC] Add --check-globals to an autogen test cmdline
Jeremy Morse [Wed, 21 Dec 2022 16:42:34 +0000 (16:42 +0000)]
[NFC] Add --check-globals to an autogen test cmdline

In c6d7e80ec4c17 this test was converted from hand written to autogenerated,
during which the relevant metadata CHECKs were dropped. In D85172 the intention
of the CHECK lines is to ensure that for two dbg.declares with different
inlining scopes, attached to the same alloca, two sets of dbg.values will be
generated with the same set of inlining scopes. Without metadata checks, a
single DILocation can match the !dbg CHECKs.

22 months ago[docs] Update an example
Paul Robinson [Wed, 21 Dec 2022 16:41:38 +0000 (08:41 -0800)]
[docs] Update an example

22 months ago[docs] Add tips on writing test constraints
Paul Robinson [Wed, 21 Dec 2022 15:09:35 +0000 (07:09 -0800)]
[docs] Add tips on writing test constraints

22 months ago[libc++] Adds __cpp_lib_constexpr_algorithms to utility.
Mark de Wever [Tue, 20 Dec 2022 17:02:36 +0000 (18:02 +0100)]
[libc++] Adds __cpp_lib_constexpr_algorithms to utility.

Implements:
- LWG3792 __cpp_lib_constexpr_algorithms should also be defined in <utility>

Depends on D140407

Reviewed By: #libc, philnik, ldionne

Differential Revision: https://reviews.llvm.org/D140413

22 months ago[libc++][doc] Adds Kona plenary papers and issues.
Mark de Wever [Tue, 20 Dec 2022 06:59:11 +0000 (07:59 +0100)]
[libc++][doc] Adds Kona plenary papers and issues.

Directly marked entries with Nothing to do where applicable.

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D140407

22 months ago[clang] Remove overly restrictive aggregate paren init logic
Alan Zhao [Mon, 19 Dec 2022 18:04:06 +0000 (10:04 -0800)]
[clang] Remove overly restrictive aggregate paren init logic

Previously, we would only attempt to perform a parenthesized aggregate
initialization if constructor initialization failed for only the default
constructor, default copy constructor, and default move constructor. The
original intent of this logic was to reject initializing objects that
have failed resolving a user-defined constructor. However, this check is
redundant because we check for isAggregate() before attempting to
perform a parenthesized aggregate initialization, and classes that have
user-defined or user-declared constructors are not aggregates.
Furthermore, this check is too restrictive - the following valid
examples fail:
* Aggregate class with user-defined destructor - fails because default
  move constructors are not generated for classes with user-defined
  destructors
  (https://github.com/llvm/llvm-project/issues/54040#issuecomment-1356926048)
* Concept-guarded conversion operator on an aggregate's member:
  (https://github.com/llvm/llvm-project/issues/54040#issuecomment-1356931745)

The solution therefore is to remove this logic; existing tests still
pass, and the previously failing examples now compile.

Reviewed By: ilya-biryukov

Differential Revision: https://reviews.llvm.org/D140327

22 months ago[InstCombine] Bubble vector.reverse of binop operands to their result.
Paul Walker [Mon, 17 Oct 2022 13:45:09 +0000 (14:45 +0100)]
[InstCombine] Bubble vector.reverse of binop operands to their result.

This mirrors a similar shufflevector transformation so the same
effect is obtained for scalable vectors. The transformation is
only performed when it can be proven the number of resulting
reversals is not increased. By bubbling the reversals from operand
to result this should typically be the case and ideally leads to
back-back shuffles that can be elimitated entirely.

Differential Revision: https://reviews.llvm.org/D139342

22 months ago[InstCombine] Bubble vector.reverse of select operands to their result.
Paul Walker [Mon, 17 Oct 2022 13:45:09 +0000 (14:45 +0100)]
[InstCombine] Bubble vector.reverse of select operands to their result.

This mirrors a similar shufflevector transformation so the same
effect is obtained for scalable vectors. The transformation is
only performed when it can be proven the number of resulting
reversals is not increased. By bubbling the reversals from operand
to result this should typically be the case and ideally leads to
back-back shuffles that can be elimitated entirely.

Differential Revision: https://reviews.llvm.org/D139339

22 months ago[InstCombine] Bubble vector.reverse of compare operands to their result.
Paul Walker [Mon, 17 Oct 2022 13:45:09 +0000 (14:45 +0100)]
[InstCombine] Bubble vector.reverse of compare operands to their result.

This mirrors a similar shufflevector transformation so the same
effect is obtained for scalable vectors. The transformation is
only performed when it can be proven the number of resulting
reversals is not increased. By bubbling the reversals from operand
to result this should typically be the case and ideally leads to
back-back shuffles that can be elimitated entirely.

Differential Revision: https://reviews.llvm.org/D139340

22 months agollvm-reduce: Remove test dependence on registered targets
Matt Arsenault [Wed, 21 Dec 2022 15:46:23 +0000 (10:46 -0500)]
llvm-reduce: Remove test dependence on registered targets

This reverts e4b126cc2d33033a5538d72a88f6aa153ac8b757 and
e57ab8fe91f06e71d3de2df07e6c7efd2f0c6078.

This previously depended on where the target happened to construct (or
not) the MachineFunctionInfo during the initial MIR construction. Now
that the MachineFunctionInfo is consistently constructed at
MachineFunction construction time, this should always work.

22 months agoCodeGen: Don't lazily construct MachineFunctionInfo
Matt Arsenault [Thu, 18 Jun 2020 13:00:16 +0000 (09:00 -0400)]
CodeGen: Don't lazily construct MachineFunctionInfo

This fixes what I consider to be an API flaw I've tripped over
multiple times. The point this is constructed isn't well defined, so
depending on where this is first called, you can conclude different
information based on the MachineFunction. For example, the AMDGPU
implementation inspected the MachineFrameInfo on construction for the
stack objects and if the frame has calls. This kind of worked in
SelectionDAG which visited all allocas up front, but broke in
GlobalISel which hasn't visited any of the IR when arguments are
lowered.

I've run into similar problems before with the MIR parser and trying
to make use of other MachineFunction fields, so I think it's best to
just categorically disallow dependency on the MachineFunction state in
the constructor and to always construct this at the same time as the
MachineFunction itself.

A missing feature I still could use is a way to access an custom
analysis pass on the IR here.

22 months ago[PowerPC] Implement P10 Byte Reverse Insructions
Lei Huang [Tue, 20 Dec 2022 16:11:55 +0000 (10:11 -0600)]
[PowerPC] Implement P10 Byte Reverse Insructions

Generate brh, brw and brd instructions for byte-swap operations
on P10 and generating a single instruction for a 32-bit swap followed
by a 16-bit right shift.

Reviewed By: stefanp

Differential Revision: https://reviews.llvm.org/D140414

22 months ago[AArch64] Combine Trunc(DUP) -> DUP
David Green [Wed, 21 Dec 2022 14:59:59 +0000 (14:59 +0000)]
[AArch64] Combine Trunc(DUP) -> DUP

This adds a simple fold of TRUNCATE(AArch64ISD::DUP) -> AArch64ISD::DUP,
which can help generate more optimal UMULL sequences, and seems useful
in general.

Differential Revision: https://reviews.llvm.org/D140289

22 months ago[InstCombine] Recursively replace select value equivalence
Nikita Popov [Wed, 21 Dec 2022 14:41:54 +0000 (15:41 +0100)]
[InstCombine] Recursively replace select value equivalence

In the X == C ? f(X) : Y -> X == C ? f(C) : Y fold, perform the
replacement in f(X) recursively. For now, this just goes two
instructions up rather than one instruction up.

22 months ago[InstCombine] Combine ZExt (B - A) + ZExt(A) to ZExt(B)
luxufan [Wed, 21 Dec 2022 14:47:12 +0000 (22:47 +0800)]
[InstCombine] Combine ZExt (B - A) + ZExt(A) to ZExt(B)

Combine ZExt (B - A) + ZExt(A) to ZExt(B)
https://alive2.llvm.org/ce/z/ESUwPi

Reviewed By: spatel

Differential Revision: https://reviews.llvm.org/D139930

22 months ago[LV] Move SCEV caching workaround to executePlan (NFC).
Florian Hahn [Wed, 21 Dec 2022 14:36:24 +0000 (14:36 +0000)]
[LV] Move SCEV caching workaround to executePlan (NFC).

As suggested by @Ayal in D92132.

This avoids having to duplicate the workaround in multiple places.

22 months ago[InstCombine] Add additional tests for select value equivalence fold (NFC)
Nikita Popov [Wed, 21 Dec 2022 14:46:51 +0000 (15:46 +0100)]
[InstCombine] Add additional tests for select value equivalence fold (NFC)

22 months ago[libc++] Also install libclang in the Docker image
Nikolas Klauser [Tue, 20 Dec 2022 19:21:31 +0000 (20:21 +0100)]
[libc++] Also install libclang in the Docker image

This is now everything that is required for clang-tidy checks.

Reviewed By: #libc, ldionne

Spies: libcxx-commits, arichardson

Differential Revision: https://reviews.llvm.org/D140424

22 months agoSCCPSolver: Remove unnecessary set empty check
Matt Arsenault [Tue, 20 Dec 2022 13:20:28 +0000 (08:20 -0500)]
SCCPSolver: Remove unnecessary set empty check

22 months agoRevert "Reland "[pgo] Avoid introducing relocations by using private alias""
Hans Wennborg [Wed, 21 Dec 2022 14:21:04 +0000 (15:21 +0100)]
Revert "Reland "[pgo] Avoid introducing relocations by using private alias""

This caused lld on mac to assert when building instrumented clang (or
instrumented code in general). See comment on the code review for
reproducer.

> In many cases, we can use an alias to avoid a symbolic relocations,
> instead of using the public, interposable symbol. When the instrumented
> function is in a COMDAT, we can use a hidden alias, and still avoid
> references to discarded sections.
>
> New compiler-rt tests are Linux only for now.
>
> Previous versions of this patch allowed the compiler to name the
> generated alias, but that would only be valid when the functions were
> local. Since the alias may be used across TUs we use a more
> deterministic naming convention, and add a `.local` suffix to the alias
> name just as we do for relative vtables aliases.
>
> Reviewed By: phosek
>
> Differential Revision: https://reviews.llvm.org/D137982

This reverts commit c42e50fede53bbcce79095e7c8115f26826c81ae.

22 months ago[AMDGPU][GlobalISel] Fix mapping G_FREEZE
Mirko Brkusanin [Wed, 21 Dec 2022 14:05:30 +0000 (15:05 +0100)]
[AMDGPU][GlobalISel] Fix mapping G_FREEZE

Differential Revision: https://reviews.llvm.org/D140416

22 months ago[AArch64][SVE][CodeGen] Prefer ld1r* over indexed-load when consumed by a splat
Peter Waller [Mon, 12 Dec 2022 15:49:58 +0000 (15:49 +0000)]
[AArch64][SVE][CodeGen] Prefer ld1r* over indexed-load when consumed by a splat

If a load is consumed by a single splat, don't consider indexed loads.

This is an alternative implementation to D138581.

Depends on D139637.

Differential Revision: https://reviews.llvm.org/D139850

22 months ago[SLP]Integrate looking through shuffles logic into ShuffleInstructionBuilder.
Alexey Bataev [Tue, 13 Dec 2022 20:45:16 +0000 (12:45 -0800)]
[SLP]Integrate looking through shuffles logic into ShuffleInstructionBuilder.

Added BaseShuffleAnalysis as a base class for ShuffleInstructionBuilder
and integrated shuffle logic from shuffles for externally used scalars
into this class. This class is used as the main container that
implements smart shuffle instruction builder logic.
ShuffleInstructionBuilder uses this logic.
ShuffleInstructionBuilder is also used in building of the shuffle for
the externally used scalars instead of lambdas, which are now part of BaseShuffleAnalysis class.

Differential Revision: https://reviews.llvm.org/D140100

22 months ago[lit] Document the 'target=<triple>' feature
Paul Robinson [Mon, 12 Dec 2022 19:51:41 +0000 (11:51 -0800)]
[lit] Document the 'target=<triple>' feature

Differential Revision: https://reviews.llvm.org/D139869

22 months ago[LV] Support widened induction variables in epilogue vectorization.
Florian Hahn [Wed, 21 Dec 2022 13:58:50 +0000 (13:58 +0000)]
[LV] Support widened induction variables in epilogue vectorization.

Code generation now uses the start VPValue of induction recipes.

This makes it possible to adjust the start value of the epilogue
vector loop to use the 'resume' value of the main vector loop.

Fixes #59459.

Reviewed By: Ayal

Differential Revision: https://reviews.llvm.org/D92132

22 months ago[JT] check xor operand is exactly the same in processBranchOnXOR
Yingchi Long [Sat, 10 Dec 2022 15:03:26 +0000 (23:03 +0800)]
[JT] check xor operand is exactly the same in processBranchOnXOR

Reproducer:

    ; RUN: opt -S -jump-threading < %s
    define void @test() {
    entry:
    br i1 false, label %loop, label %exit

    loop:
    %bool = phi i1 [ %xor, %loop.latch ], [ false, %entry ]
    %cmp = icmp eq i16 0, 1
    %xor = xor i1 %cmp, %bool
    br i1 %bool, label %loop.latch, label %exit

    loop.latch:
    %dummy = phi i16 [ 0, %loop ]
    br label %loop

    exit:
    ret void
    }

On this occassion, phi node %bool is actually %xor, and doing substitution causes assertion failure.

Fixes: https://github.com/llvm/llvm-project/issues/58812

Reviewed By: nikic

Differential Revision: https://reviews.llvm.org/D139783

22 months ago[hwasan] Convert tests to check 'target=...'
Paul Robinson [Wed, 21 Dec 2022 13:41:00 +0000 (05:41 -0800)]
[hwasan] Convert tests to check 'target=...'

Part of the project to eliminate special handling for triples in lit
expressions.

22 months agoBEGIN_PUBLIC
Aliia Khasanova [Wed, 21 Dec 2022 13:37:25 +0000 (14:37 +0100)]
BEGIN_PUBLIC
Add a shortened printing/parsing form for linalg.map and linalg.reduce.
END_PUBLIC

Differential Revision: https://reviews.llvm.org/D140406

22 months ago[compiler-rt] Simplify lit test thumb checks
Paul Robinson [Wed, 21 Dec 2022 13:31:38 +0000 (05:31 -0800)]
[compiler-rt] Simplify lit test thumb checks

22 months agoclang: Respect function address space for __builtin_function_start
Matt Arsenault [Wed, 21 Dec 2022 13:09:56 +0000 (08:09 -0500)]
clang: Respect function address space for __builtin_function_start

Fixes assertion.

22 months agoclang: Fix another assert from not respecting function address spaces
Matt Arsenault [Wed, 21 Dec 2022 12:57:49 +0000 (07:57 -0500)]
clang: Fix another assert from not respecting function address spaces

22 months agoclang: Use correct address space for redeclared functions
Matt Arsenault [Wed, 21 Dec 2022 12:33:18 +0000 (07:33 -0500)]
clang: Use correct address space for redeclared functions

Fixes assert/verifier error with AVR.

22 months ago[LV] Add test for #59459.
Florian Hahn [Wed, 21 Dec 2022 13:23:25 +0000 (13:23 +0000)]
[LV] Add test for #59459.

22 months ago[libcxxabi] Use 'target=' consistently
Paul Robinson [Wed, 21 Dec 2022 13:22:10 +0000 (05:22 -0800)]
[libcxxabi] Use 'target=' consistently

22 months ago[clang/xray] Convert tests to check 'target=...'
Paul Robinson [Wed, 21 Dec 2022 13:17:56 +0000 (05:17 -0800)]
[clang/xray] Convert tests to check 'target=...'

Part of the project to eliminate special handling for triples in lit
expressions.

22 months ago[mlir] Make `LocalAliasAnalysis` extesible
Ivan Butygin [Mon, 19 Dec 2022 21:26:07 +0000 (22:26 +0100)]
[mlir] Make `LocalAliasAnalysis` extesible

This is an alternative to https://reviews.llvm.org/D138761 . Instead of adding ad-hoc attributes to existing `LocalAliasAnalysis`, expose `aliasImpl` method so user can override it.

Differential Revision: https://reviews.llvm.org/D140348

22 months ago[DWARFv4][DWARFv5][DWARFLinker] support debug_macinfo/debug_macro tables.
Alexey Lapshin [Fri, 23 Sep 2022 06:34:26 +0000 (09:34 +0300)]
[DWARFv4][DWARFv5][DWARFLinker] support debug_macinfo/debug_macro tables.

This patch adds handling of debug_macinfo/debug_macro tables to the DWARFLinker.
It uses already existing code for reading tables from DWARFDebugMacro.h.
It adds new code writing tables into the DwarfStreamer::emitMacroTables.

Differential Revision: https://reviews.llvm.org/D140223

22 months ago[clang] Do not extend i8 return values to i16 on AVR.
Ben Shi [Tue, 13 Dec 2022 04:07:40 +0000 (12:07 +0800)]
[clang] Do not extend i8 return values to i16 on AVR.

Reviewed By: Miss_Grape, aykevl

Differential Revision: https://reviews.llvm.org/D139908

22 months ago[X86] combine-and.ll - add 256 and 512 bit test coverage for scalar broadcast
Evgenii Kudriashov [Wed, 21 Dec 2022 11:58:25 +0000 (19:58 +0800)]
[X86] combine-and.ll - add 256 and 512 bit test coverage for scalar broadcast

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D139991

22 months ago[mlir][bufferize] Fix tensor copy insertion for dynamic tensors
Matthias Springer [Wed, 21 Dec 2022 11:39:19 +0000 (12:39 +0100)]
[mlir][bufferize] Fix tensor copy insertion for dynamic tensors

TensorCopyInsertion inserts bufferization.alloc_tensor ops in case of RaW conflicts. If such a tensor is dynamically shaped, tensor.dim ops are inserted. There is an optimization for ops such as tensor.extract_slice: A copy of the result is created instead of the operand. Afterwards, all uses of the result are updated. E.g.:

```
%0 = tensor.extract_slice ... : tensor<?xf32> to tensor<?xf32>
%1 = tensor.dim %0, %c0 : tensor<?xf32>
%2 = bufferization.alloc_tensor(%dim) : tensor<?xf32>
```

All uses of %0, except for tensor.dim and bufferization.alloc_tensor (if any), should be replaced. Before this change, the use in tensor.dim was also replaced, resulting in IR that had a dominance error.

Note: There is no test case for this fix because the bug cannot be triggered with tensor.extract_slice, which implements an interface to reify result shapes. This bug appeared in an external project with a tensor.extract_slice-like op that does not implement that interface, in which case tensor.dim ops must be created. We do not have such an op in MLIR to trigger this bug.

Differential Revision: https://reviews.llvm.org/D140471

22 months ago[ARM] Convert some tests to opaque pointers (NFC)
Nikita Popov [Wed, 21 Dec 2022 11:36:15 +0000 (12:36 +0100)]
[ARM] Convert some tests to opaque pointers (NFC)

22 months ago[ARM] Regenerate test checks (NFC)
Nikita Popov [Wed, 21 Dec 2022 11:32:56 +0000 (12:32 +0100)]
[ARM] Regenerate test checks (NFC)

22 months ago[AArch64] GlobalIsel codegen for gpr CTZ
Ties Stuij [Wed, 21 Dec 2022 11:08:55 +0000 (11:08 +0000)]
[AArch64] GlobalIsel codegen for gpr CTZ

If feature CSSC is available, CTTZ intrinsics are lowered using the CTZ
instruction when using GlobalIsel.

spec:
https://developer.arm.com/documentation/ddi0602/2022-09/Base-Instructions/CTZ--Count-Trailing-Zeros-

Reviewed By: paquette

Differential Revision: https://reviews.llvm.org/D139418

22 months ago[RISCV] Omit SRA in case of setlt or setge with zero constant
Elena Lepilkina [Wed, 14 Dec 2022 15:37:44 +0000 (18:37 +0300)]
[RISCV] Omit SRA in case of setlt or setge with zero constant

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D140206

22 months ago[Precommit][RISCV] Test folding for RISCVISD::BR_CC node
Elena Lepilkina [Fri, 16 Dec 2022 06:49:11 +0000 (09:49 +0300)]
[Precommit][RISCV] Test folding for RISCVISD::BR_CC node

Precommit test for https://reviews.llvm.org/D140206

22 months ago[AAch64] Optimize muls with operands having enough zero bits.
bipmis [Wed, 21 Dec 2022 11:14:45 +0000 (11:14 +0000)]
[AAch64] Optimize muls with operands having enough zero bits.

Fix the regression in the reported test case lagarith-preproc.c.
Specfic to the incorrect umsubl generation.

Differential Revision: https://reviews.llvm.org/D139411

22 months ago[SCEV] Help getLoopInvariantExitCondDuringFirstIterations deal with complex `umin...
Max Kazantsev [Wed, 21 Dec 2022 05:47:36 +0000 (12:47 +0700)]
[SCEV] Help getLoopInvariantExitCondDuringFirstIterations deal with complex `umin` exit counts. PR59615

Recent improvements in symbolic exit count computation revealed some problems with
SCEV's ability to find invariant predicate during first iterations. Ultimately it is based on its
ability to prove some facts for value on the last iteration. This last value, when it includes
`umin` as part of exit count, isn't always simplified enough. The motivating example is following:

https://github.com/llvm/llvm-project/issues/59615

Could not prove:
```
        Pred = 36, LHS = (-1 + (-1 * (2147483645 umin (-1 + %var)<nsw>))<nsw> + %var), RHS = %var
        FoundPred = 36, FoundLHS = {1,+,1}<nuw><nsw><%bb3>, FoundRHS = %var
```
Can prove:
```
        Pred = 36, LHS = (-1 + (-1 * (-1 + %var)<nsw>)<nsw> + %var), RHS = %var
        FoundPred = 36, FoundLHS = {1,+,1}<nuw><nsw><%bb3>, FoundRHS = %var
```

Here ` (2147483645 umin (-1 + %var)<nsw>)` is exit count composed of two parts from
two different exits: `2147483645 ` and `(-1 + %var)<nsw>`. When it was only one (latter)
analyzeable exit, for it everything was easily provable. Unfortunately, in general case `umin`
in one of `add`'s operands doesn't guarantee that the whole sum reduces, especially in presence
of negative steps and lack of `nuw`. I don't think there is a generic legal way to somehow play
around this `umin`.

So the ad-hoc solution is following: if we failed to find an equivalent predicate that is invariant
during first `MaxIter` iterations, and `MaxIter = umin(a, b, c...)`, try to find solution for at least one
of `a`, `b`, `c`... Because they all are `uge` than `MaxIter`, whatever is true during `a (b, c)` iterations
is also true during `MaxIter` iterations.

Differential Revision: https://reviews.llvm.org/D140456
Reviewed By: nikic

22 months ago[lld][ARM] support absolute thunks for Armv4T Thumb and interworking
Ties Stuij [Wed, 21 Dec 2022 10:08:19 +0000 (10:08 +0000)]
[lld][ARM] support absolute thunks for Armv4T Thumb and interworking

changes:
- BLX: The Arm architecture versions that support the branch and link
  instruction (BLX), can rewrite BLs in place when a state change from Arm<->Thumb
  is required. Armv4T does not have BLX and so needs thunks for state changes.
- v4T Thumb long branches needed their own thunk. We could have used the v6M
  implementation, but v6M doesn't have Arm state and must resolve to rather
  inefficient stack reshuffling. We also can't reuse v7 thumb thunks as they use
  MOVV/MOVT, which wasn't available yet for v4T.
- Remove the `lack of BLX' warning. LLVM only supports Arm Architecture versions
  upwards of v4, which we now all support in LLD.
- renamed existing thunks to better reflect their use:
  ARMV5ABSLongThunk -> ARMV5LongLdrPcThunk,
  ARMV5PILongThunk -> ARMV4PILongThunk
- removed isCompatibleWith method from ARMV5ABSLongThunk and ARMV5PILongThunk,
  as they were identical to the ARMThunk parent class implementation.

Support for (efficient) position independent thunks for v4T will be added in a
follow-up patch, including possible related thunk renaming and code comment
cleanup.

Reviewed By: MaskRay, peter.smith

Differential Revision: https://reviews.llvm.org/D139888

22 months agoRevert "[AMDGPU][SILowerSGPRSpills] Spill SGPRs to virtual VGPRs"
Christudasan Devadasan [Wed, 21 Dec 2022 10:41:30 +0000 (16:11 +0530)]
Revert "[AMDGPU][SILowerSGPRSpills] Spill SGPRs to virtual VGPRs"

This reverts commit 40ba0942e2ab1107f83aa5a0ee5ae2980bf47b1a.

22 months ago[SelectionDAG] Fix EmitCopyFromReg for cloned nodes
Jay Foad [Tue, 20 Dec 2022 17:19:01 +0000 (17:19 +0000)]
[SelectionDAG] Fix EmitCopyFromReg for cloned nodes

Change EmitCopyFromReg to check all users of cloned nodes (as well as
non-cloned nodes) instead of assuming that they all copy the defined
value back to the same physical register.

This partially reverts 968e2e7b3db1 (svn r62356) which claimed:

  CreateVirtualRegisters does trivial copy coalescing. If a node def is
  used by a single CopyToReg, it reuses the virtual register assigned to
  the CopyToReg. This won't work for SDNode that is a clone or is itself
  cloned. Disable this optimization for those nodes or it can end up
  with non-SSA machine instructions.

This is true for CreateVirtualRegisters but r62356 also updated
EmitCopyFromReg where it is not true. Firstly EmitCopyFromReg only
coalesces physical register copies, so the concern about SSA form does
not apply. Secondly making the loop over users in EmitCopyFromReg
conditional on `!IsClone && !IsCloned` breaks the handling of cloned
nodes, because it leaves MatchReg set to true by default, so it assumes
that all users will copy the defined value back to the same physical
register instead of actually checking.

Differential Revision: https://reviews.llvm.org/D140417

22 months ago[SelectionDAG] Precommit EmitCopyFromReg test for D140417
Jay Foad [Tue, 20 Dec 2022 17:51:20 +0000 (17:51 +0000)]
[SelectionDAG] Precommit EmitCopyFromReg test for D140417

22 months ago[cmake] Copy llvm-driver-template.cpp.in into build dir as well
Nikita Popov [Wed, 21 Dec 2022 10:40:33 +0000 (11:40 +0100)]
[cmake] Copy llvm-driver-template.cpp.in into build dir as well

We were copying it into the installed version of the directory,
but not into the one in the build directory. Because of that it
was not directly usable as a cmake module by subprojects that
also use the driver functionality.

22 months ago[Attributor] potential constant values for PHI and Load
Sameer Sahasrabuddhe [Wed, 21 Dec 2022 09:55:55 +0000 (15:25 +0530)]
[Attributor] potential constant values for PHI and Load

AAPotentialConstantValues now works for PHI and Load by simply examinig
AAPotentialValues for the instruction itself.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D140371

22 months ago[mlir] Add RuntimeVerifiableOpInterface and transform
Matthias Springer [Wed, 21 Dec 2022 09:51:10 +0000 (10:51 +0100)]
[mlir] Add RuntimeVerifiableOpInterface and transform

Static op verification cannot detect cases where an op is valid at compile time but may be invalid at runtime.

An example of such an op is `memref::ExpandShapeOp`.

Invalid at compile time: `memref.expand_shape %m [[0, 1]] : memref<11xf32> into memref<2x5xf32>`

Valid at compile time (because we do not know any better): `memref.expand_shape %m [[0, 1]] : memref<?xf32> into memref<?x5xf32>`. This op may or may not be valid at runtime depending on the runtime shape of `%m`.

Invalid runtime ops such as the one above are hard to debug because they can crash the program execution at a seemingly unrelated position or (even worse) compute an invalid result without crashing.

This revision adds a new op interface `RuntimeVerifiableOpInterface` that can be implemented by ops that provide additional runtime verification. Such runtime verification can be computationally expensive, so it is only generated on an opt-in basis by running `-generate-runtime-verification`. A simple runtime verifier for `memref::ExpandShapeOp` is provided as an example.

Differential Revision: https://reviews.llvm.org/D138576

22 months ago[AMDGPU][GFX11][DOC][NFC] Add GFX11 assembler syntax description
Dmitry Preobrazhensky [Wed, 21 Dec 2022 09:49:48 +0000 (12:49 +0300)]
[AMDGPU][GFX11][DOC][NFC] Add GFX11 assembler syntax description

22 months ago[AMDGPU][MC][NFC] MUBUF/MTBUF code cleanup
Piotr Sobczak [Tue, 20 Dec 2022 16:42:13 +0000 (17:42 +0100)]
[AMDGPU][MC][NFC] MUBUF/MTBUF code cleanup

Refactor code to reduce code duplication and improve maintainability.

- Extract BUF_Pseudo common base class
- Refactor getMUBUFInsDA
- Refactor getMUBUFAtomicInsDA
- Refactor getMTBUFInsDA
- Refactor getMUBUFAsmOps
- Refactor getMTBUFAsmOps

Differential Revision: https://reviews.llvm.org/D140410

22 months ago[Clang][CGDebugInfo][ObjC] Mark objc bitfields with the DIFlagBitfield flag
Juan Manuel MARTINEZ CAAMAÑO [Wed, 21 Dec 2022 08:38:47 +0000 (03:38 -0500)]
[Clang][CGDebugInfo][ObjC] Mark objc bitfields with the DIFlagBitfield flag

Reviewed By: aprantl

Differential Revision: https://reviews.llvm.org/D140195

22 months ago[clang][AST] Compare UnresolvedLookupExpr in structural equivalence.
Balázs Kéri [Wed, 21 Dec 2022 08:31:29 +0000 (09:31 +0100)]
[clang][AST] Compare UnresolvedLookupExpr in structural equivalence.

Reviewed By: gamesh411

Differential Revision: https://reviews.llvm.org/D136848

22 months ago[RISCV] Enable the LocalStackSlotAllocation pass support.
LiDongjin [Tue, 22 Nov 2022 09:23:58 +0000 (17:23 +0800)]
[RISCV] Enable the LocalStackSlotAllocation pass support.

Differential Revision: https://reviews.llvm.org/D98101

Co-authored-by: luxufan <luxufan@iscas.ac.cn>
22 months ago[clang-tidy] Fix crash in bugprone-suspicious-realloc-usage.
Balázs Kéri [Wed, 21 Dec 2022 08:05:43 +0000 (09:05 +0100)]
[clang-tidy] Fix crash in bugprone-suspicious-realloc-usage.

The problem occurs if a statement is found by the checker that has a null child.
Fixes issue #59518.

Reviewed By: hokein

Differential Revision: https://reviews.llvm.org/D140194

22 months ago[DAGCombine] Fix mistake in a comment. NFC
Craig Topper [Wed, 21 Dec 2022 08:26:27 +0000 (00:26 -0800)]
[DAGCombine] Fix mistake in a comment. NFC

22 months ago[RISCV] Simplify some code in SELECT_CC combine. NFC
Craig Topper [Wed, 21 Dec 2022 05:31:19 +0000 (21:31 -0800)]
[RISCV] Simplify some code in SELECT_CC combine. NFC

An integer SELECT_CC should have all XLenVT operands, we don't
need to handle other cases.

22 months ago[Test] Precommit test for PR59615
Max Kazantsev [Wed, 21 Dec 2022 04:38:17 +0000 (11:38 +0700)]
[Test] Precommit test for PR59615

22 months agoRevert "[NFC][SROA] `speculateSelectInstLoads()`: play nice with typed pointers for...
Max Kazantsev [Wed, 21 Dec 2022 04:17:49 +0000 (11:17 +0700)]
Revert "[NFC][SROA] `speculateSelectInstLoads()`: play nice with typed pointers for now"

This reverts commit 9f27f4536e19e93349b0662338408efe6d1cb2fd.

Supposed to be NFC, but broke buildbots (test addrspacecast.ll is failing).

22 months ago[CSKY] Fix compiling error due to the interface change
Zi Xuan Wu (Zeson) [Wed, 21 Dec 2022 03:51:06 +0000 (11:51 +0800)]
[CSKY] Fix compiling error due to the interface change

22 months ago[Clang] Emit "min-legal-vector-width" attribute for X86 only
Phoebe Wang [Wed, 21 Dec 2022 03:39:11 +0000 (11:39 +0800)]
[Clang] Emit "min-legal-vector-width" attribute for X86 only

This is an alternative way of D139627 suggested by Craig. Creently only X86 backend uses this attribute. Let's just emit for X86 only.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D139701

22 months ago[X86] Replace getOperand calls with an existing variable. NFC
Craig Topper [Wed, 21 Dec 2022 03:26:51 +0000 (19:26 -0800)]
[X86] Replace getOperand calls with an existing variable. NFC

22 months agoReplace void* with std::byte* in AsyncRuntime
yijiagu [Wed, 21 Dec 2022 03:00:26 +0000 (19:00 -0800)]
Replace void* with std::byte* in AsyncRuntime

Replace void* with std::byte* in AsyncRuntime to make it clear that these pointers point to a memory region.

Reviewed By: ezhulenev

Differential Revision: https://reviews.llvm.org/D140428

22 months ago[clangd] Avoid triggering linkage computation for decl with unstable linkage in Symbo...
Nathan Ridge [Tue, 20 Dec 2022 09:31:33 +0000 (04:31 -0500)]
[clangd] Avoid triggering linkage computation for decl with unstable linkage in SymbolRelevanceSignals::computeASTSignals()

Fixes https://github.com/clangd/clangd/issues/1427

Differential Revision: https://reviews.llvm.org/D140379

22 months ago[RISCV][NFC] Add policy operand for RISCVISD::VSLIDEUP_VL and RISCVISD::VSLIDEDOWN_VL.
Yeting Kuo [Tue, 20 Dec 2022 12:28:53 +0000 (20:28 +0800)]
[RISCV][NFC] Add policy operand for RISCVISD::VSLIDEUP_VL and RISCVISD::VSLIDEDOWN_VL.

There is room for optimization to use tail agnostic vslideup/vslidedown to lower
some vector operations. D125546 is an revision for the kind of optimization.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D140393

22 months ago[RISCV] Add XVentanaCondOps to RISCVSExtWRemoval.
Craig Topper [Wed, 21 Dec 2022 02:46:07 +0000 (18:46 -0800)]
[RISCV] Add XVentanaCondOps to RISCVSExtWRemoval.

22 months agoReference: not-shift.ll before new peepholes.
Noah Goldstein [Tue, 20 Dec 2022 09:14:40 +0000 (17:14 +0800)]
Reference: not-shift.ll before new peepholes.

Differential Revision: https://reviews.llvm.org/D140362

22 months agoRevert "llvm-reduce: Try to fix test on windows"
Matt Arsenault [Wed, 21 Dec 2022 02:28:58 +0000 (21:28 -0500)]
Revert "llvm-reduce: Try to fix test on windows"

This reverts commit 3b0b0965c4eb603af5d97733775df315ba2241a1.

I hadn't noticed 638b25711540ff7897750ab07592b3d168e65aca

22 months ago[NFC][SROA] `speculateSelectInstLoads()`: play nice with typed pointers for now
Roman Lebedev [Wed, 21 Dec 2022 02:15:28 +0000 (05:15 +0300)]
[NFC][SROA] `speculateSelectInstLoads()`: play nice with typed pointers for now

As requested in https://reviews.llvm.org/D138238#inline-1356685

22 months ago[X86] avx512fp16: add missing instruction selection patterns for "i16" `VMOVSH`
Roman Lebedev [Wed, 21 Dec 2022 01:51:52 +0000 (04:51 +0300)]
[X86] avx512fp16: add missing instruction selection patterns for "i16" `VMOVSH`

For all other patterns, we consistently have both I and F variants,
let's not diverge.

Fixes https://github.com/llvm/llvm-project/issues/59628

22 months ago[llvm-extract] Don't forget to link to Analysis component
Roman Lebedev [Wed, 21 Dec 2022 02:03:31 +0000 (05:03 +0300)]
[llvm-extract] Don't forget to link to Analysis component

```
[ 50% 1/2][ 50% 00:01 + 00:01] Linking CXX executable bin/llvm-extract
FAILED: bin/llvm-extract
: && /usr/bin/clang++-15 -O3 -g -ggdb -march=native -UNDEBUG -gsplit-dwarf -gz -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -g -ggdb -march=native -UNDEBUG -gsplit-dwarf -gz -Wl,--gdb-index -Wl,--color-diagnostics     -Wl,--gc-sections tools/llvm-extract/CMakeFiles/llvm-extract.dir/llvm-extract.cpp.o -o bin/llvm-extract  -Wl,-rpath,"\$ORIGIN/../lib"  lib/libLLVMPasses.so.16git  lib/libLLVMIRPrinter.so.16git  lib/libLLVMipo.so.16git  lib/libLLVMBitWriter.so.16git  lib/libLLVMIRReader.so.16git  lib/libLLVMCore.so.16git  lib/libLLVMSupport.so.16git  -Wl,-rpath-link,/builddirs/llvm-project/build-Clang15/lib && :
ld: error: undefined symbol: llvm::AnalysisManager<llvm::Loop, llvm::LoopStandardAnalysisResults&>::AnalysisManager()
>>> referenced by llvm-extract.cpp:326 (/repositories/llvm-project/llvm/tools/llvm-extract/llvm-extract.cpp:326)
>>>               tools/llvm-extract/CMakeFiles/llvm-extract.dir/llvm-extract.cpp.o:(main)
>>> referenced by llvm-extract.cpp:373 (/repositories/llvm-project/llvm/tools/llvm-extract/llvm-extract.cpp:373)
>>>               tools/llvm-extract/CMakeFiles/llvm-extract.dir/llvm-extract.cpp.o:(main)
>>> referenced by llvm-extract.cpp:394 (/repositories/llvm-project/llvm/tools/llvm-extract/llvm-extract.cpp:394)
>>>               tools/llvm-extract/CMakeFiles/llvm-extract.dir/llvm-extract.cpp.o:(main)

ld: error: undefined symbol: llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>::AnalysisManager()
>>> referenced by llvm-extract.cpp:328 (/repositories/llvm-project/llvm/tools/llvm-extract/llvm-extract.cpp:328)
>>>               tools/llvm-extract/CMakeFiles/llvm-extract.dir/llvm-extract.cpp.o:(main)
>>> referenced by llvm-extract.cpp:375 (/repositories/llvm-project/llvm/tools/llvm-extract/llvm-extract.cpp:375)
>>>               tools/llvm-extract/CMakeFiles/llvm-extract.dir/llvm-extract.cpp.o:(main)
>>> referenced by llvm-extract.cpp:396 (/repositories/llvm-project/llvm/tools/llvm-extract/llvm-extract.cpp:396)
>>>               tools/llvm-extract/CMakeFiles/llvm-extract.dir/llvm-extract.cpp.o:(main)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
```

22 months agollvm-reduce: Try to fix test on windows
Matt Arsenault [Wed, 21 Dec 2022 01:34:27 +0000 (20:34 -0500)]
llvm-reduce: Try to fix test on windows

It seems to not like the environment variable set syntax.

22 months agoFix test added in 95abdeb to set environment variables in a way that works on both...
Douglas Yung [Wed, 21 Dec 2022 01:31:01 +0000 (17:31 -0800)]
Fix test added in 95abdeb to set environment variables in a way that works on both Windows and linux.

This should fix the test failure on Windows bots such as https://lab.llvm.org/buildbot/#/builders/216/builds/14829.

22 months ago[mlir][sparse] add initialize() API to LoopEmitter to support post-constructor initia...
Peiming Liu [Wed, 21 Dec 2022 01:11:14 +0000 (01:11 +0000)]
[mlir][sparse] add initialize() API to LoopEmitter to support post-constructor initialization

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D140444

22 months agoRevert "[AArch64] FMV support and necessary target features dependencies."
Mitch Phillips [Wed, 21 Dec 2022 01:16:32 +0000 (17:16 -0800)]
Revert "[AArch64] FMV support and necessary target features dependencies."

This reverts commit e43924a75145d2f9e722f74b673145c3e62bfd07.

Reason: Patch broke the MSan buildbots. More information is available on
the original phabricator review: https://reviews.llvm.org/D127812

22 months agoRevert "[AArch64][NFC] Fix aarch64 target features test."
Mitch Phillips [Wed, 21 Dec 2022 01:16:17 +0000 (17:16 -0800)]
Revert "[AArch64][NFC] Fix aarch64 target features test."

This reverts commit bf94eac6a3f7c5cd8941956d44c15524fa3751bd.

Reason: Depends on reverted change https://reviews.llvm.org/D127812

22 months agoRevert "[AArch64][compiler-rt] Fix HWCAP_CPUID not defined in some cases."
Mitch Phillips [Wed, 21 Dec 2022 01:15:38 +0000 (17:15 -0800)]
Revert "[AArch64][compiler-rt] Fix HWCAP_CPUID not defined in some cases."

This reverts commit a43f36142c501e2d3f4797ef938db4e0c5e0eeec.

Reason: Depends on reverted change https://reviews.llvm.org/D127812

22 months ago[mlir][sparse] refactored codegen environment into its own file
Aart Bik [Tue, 20 Dec 2022 23:42:11 +0000 (15:42 -0800)]
[mlir][sparse] refactored codegen environment into its own file

Also, as a proof of concept, all functionality related to reductions
has been refactored into private fields and a clean public API. As a
result, some dead code was found as well. This approach also simplifies
asserting on a proper environment state for each call.

NOTE: making all other fields private and migrating more methods into
      this new class is still TBD in yes another next revision!

Reviewed By: Peiming

Differential Revision: https://reviews.llvm.org/D140443

22 months ago[clang] Re-apply change to avoid passing -stdlib=libc++ spuriously to CC1 on Darwin
Louis Dionne [Tue, 20 Dec 2022 23:04:53 +0000 (18:04 -0500)]
[clang] Re-apply change to avoid passing -stdlib=libc++ spuriously to CC1 on Darwin

Previously, we would be passing down -stdlib=libc++ from the Driver
to CC1 whenever the default standard library on the platform was libc++,
even if -stdlib= had not been passed to the Driver. This meant that we
would pass -stdlib=libc++ in nonsensical circumstances, such as when
compiling C code.

This logic had been added in b534ce46bd40 to make sure that header
search paths were set up properly. However, since libc++ is now the
default Standard Library on Darwin, passing this explicitly is not
required anymore. Indeed, if no -stdlib= is specified, CC1 will end
up using libc++ if it queries which standard library to use, without
having to be told.

Not passing -stdlib= at all to CC1 on Darwin should become possible
once CC1 stops relying on it to set up framework search paths.

Furthermore, this commit also removes a diagnostic checking whether the
deployment target is too old to support libc++. Nowadays, all supported
deployment targets use libc++ and compiling with libstdc++ is not
supported anymore. The Driver was the wrong place to issue this
diagnostic since it doesn't know whether libc++ will actually be linked
against (e.g. C vs C++), which would lead to spurious diagnostics.
Given that these targets are not supported anymore, we simply drop
the diagnostic instead of trying to refactor it into CC1.

This is a re-application of 6540f32db09c which had been reverted in
49dd02bd0819 because it broke a compiler-rt test. The test had broken
because we were compiling C code and passing -stdlib=libc++, which Clang
will now warn about.

rdar://103198514

Differential Revision: https://reviews.llvm.org/D139938

22 months ago[mlir][sparse] introduce LevelFormat which do not encoding level properties of a...
Peiming Liu [Tue, 20 Dec 2022 23:49:17 +0000 (23:49 +0000)]
[mlir][sparse] introduce LevelFormat which do not encoding level properties of a sparse tensor level.

Reviewed By: aartbik, wrengr

Differential Revision: https://reviews.llvm.org/D140442

22 months ago[NFC][llvm-exegesis] Ensure that target options show up in --help
Roman Lebedev [Wed, 21 Dec 2022 00:38:10 +0000 (03:38 +0300)]
[NFC][llvm-exegesis] Ensure that target options show up in --help

Fixes https://github.com/llvm/llvm-project/issues/59377

22 months ago[-Wunsafe-buffer-usage] Suppress an assertion for visiting VarDecl twice.
Artem Dergachev [Tue, 20 Dec 2022 22:58:35 +0000 (14:58 -0800)]
[-Wunsafe-buffer-usage] Suppress an assertion for visiting VarDecl twice.

The assertion doesn't seem to hold due to ASTMatchers traversing code
inside GNU StmtExpr twice. This can screw up our algorithm's invariants.
We need a further investigation to properly fix this issue, but for now
let's avoid the crash.