mihaip@chromium.org [Wed, 28 Sep 2011 20:06:29 +0000 (20:06 +0000)]
Add Mac Skia GPU bots to builders.py
https://bugs.webkit.org/show_bug.cgi?id=69016
Reviewed by Eric Seidel.
This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
GPU tests.
* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 28 Sep 2011 19:55:44 +0000 (19:55 +0000)]
Fix a regression in r96060. ResourceLoader shouldn't get
initialized with a null DocumentLoader.
https://bugs.webkit.org/show_bug.cgi?id=69004
Patch by Nate Chapin <japhet@chromium.org> on 2011-09-28
Reviewed by Csaba Osztrogonác.
This should fix a debug crash in some platforms in
plugins/js-from-destroy.html
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::init): Move the activeDocumentLoader() null checks back
to SubresouceLoader::create().
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Wed, 28 Sep 2011 19:54:01 +0000 (19:54 +0000)]
One more shot at fixing GTK+, this seems to make the dependencies
work.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-28
* GNUmakefile.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 28 Sep 2011 19:53:09 +0000 (19:53 +0000)]
Merge bug#68580, bug#68932 for DFG JIT with JSVALUE32_64
https://bugs.webkit.org/show_bug.cgi?id=69017
Reviewed by Oliver Hunt.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 28 Sep 2011 19:24:24 +0000 (19:24 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.
Reviewed by Oliver Hunt.
* fast/js/array-prototype-properties-expected.txt: Added.
* fast/js/array-prototype-properties.html: Added.
* fast/js/script-tests/array-prototype-properties.js: Added.
- Added layout test for array prototype functions with undefined as this value.
* ietestcenter/Javascript/15.4.4.14-5-28-expected.txt:
* ietestcenter/Javascript/15.4.4.15-5-28-expected.txt:
- These tests now pass.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Wed, 28 Sep 2011 19:15:16 +0000 (19:15 +0000)]
GTK+ build fix 3 - the return of the marshal.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-28
* GNUmakefile.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 28 Sep 2011 19:14:17 +0000 (19:14 +0000)]
Rebaseline fast/canvas/canvas-composite-transformclip.html and
fast/canvas/canvas-composite.html for Chromium Snow Leopard GPU.
* platform/chromium-gpu-mac/fast/canvas/canvas-composite-expected.png:
* platform/chromium-gpu-mac/fast/canvas/canvas-composite-transformclip-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 28 Sep 2011 19:02:57 +0000 (19:02 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=64679
Fix bugs in Array.prototype this handling.
Reviewed by Oliver Hunt.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
- These methods should throw if this value is undefined.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Wed, 28 Sep 2011 18:39:07 +0000 (18:39 +0000)]
Second try at fixing the GTK+ build.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-28
Source/WebKit2:
* GNUmakefile.am:
Tools:
* GNUmakefile.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Wed, 28 Sep 2011 18:14:09 +0000 (18:14 +0000)]
Try to fix GTK+ build.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-28
* GNUmakefile.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
imasaki@chromium.org [Wed, 28 Sep 2011 18:09:05 +0000 (18:09 +0000)]
[Chromium] remove a passing test from the test expectation file.
https://bugs.webkit.org/show_bug.cgi?id=69008
Reviewed by David Levin.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 28 Sep 2011 18:06:54 +0000 (18:06 +0000)]
CSP doesn't work for a wide variety of cases
https://bugs.webkit.org/show_bug.cgi?id=68921
Reviewed by Darin Adler.
Patch suggested by Sam Weinig. It's unclear to me how to test this
change because all our tests run on non-default ports, which is why we
have this bug in the first place. Mozilla uses a proxy while testing
so they can test with URLs like http://example.com, but we don't have
such a facility.
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPSource::portMatches):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 28 Sep 2011 18:05:03 +0000 (18:05 +0000)]
Value profiling in baseline JIT for JSVALUE32_64
https://bugs.webkit.org/show_bug.cgi?id=68750
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-27
Reviewed by Geoff Garen.
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_mul):
(JSC::JIT::emit_op_div):
* jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_call_put_result):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_get_global_var):
* jit/JITStubCall.h:
(JSC::JITStubCall::callWithValueProfiling):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 17:56:10 +0000 (17:56 +0000)]
[GTK] Fix webkit2 unit tests in debug builds
https://bugs.webkit.org/show_bug.cgi?id=69006
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2011-09-28
Reviewed by Martin Robinson.
We are currently using the WorQueue name as thread name which in
this moment can be com.apple.WebKit.ProcessLauncher or
com.apple.CoreIPC.ReceiveQueue. Both names are longer than 31
characters which is the limit of Visual Studio for thread
names. When log is enabled createThread() will assert instead of
truncate the name, so we need to make sure we don't use a name
longer than 31 characters.
* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::platformInitialize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 28 Sep 2011 17:54:24 +0000 (17:54 +0000)]
Rebaseline svg/filters/animate-fill.svg for Chromium.
* platform/chromium-cg-mac/svg/filters/animate-fill-expected.png: Added.
* platform/chromium-mac/svg/filters/animate-fill-expected.png: Added.
* platform/chromium-win/svg/filters/animate-fill-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 17:46:54 +0000 (17:46 +0000)]
Let TestWebKitAPI and webkit_unit_tests work for chromium-win
https://bugs.webkit.org/show_bug.cgi?id=68680
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-28
Reviewed by Tony Chang.
* Scripts/run-chromium-webkit-unit-tests:
* Scripts/webkitdirs.pm:
(determineBaseProductDir):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 17:40:14 +0000 (17:40 +0000)]
[Gtk] Implement textInputController.doCommand
https://bugs.webkit.org/show_bug.cgi?id=66496
Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-09-28
Reviewed by Martin Robinson.
Source/WebKit/gtk:
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::doCommand): Function definition for doCommand
callback. Converted Incoming command to match with WebCore::Editor CommandMap.
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
Tools:
* DumpRenderTree/gtk/TextInputController.cpp:
(doCommandCallback): Callback function for textInputController.doCommand
LayoutTests:
Removed skipped tests under textInputController.doCommand for Gtk Port.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fsamuel@chromium.org [Wed, 28 Sep 2011 17:36:03 +0000 (17:36 +0000)]
[Chromium] Seperate GTK specific Gyp rules from X11 Gyp rules
https://bugs.webkit.org/show_bug.cgi?id=68936
Reviewed by Tony Chang.
Source/WebCore:
Chromium need to be built without Gtk for future version of ChromiumOS.
* WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
* WebKit.gyp:
* public/gtk/WebFontInfo.h:
* public/linux/WebFontInfo.h: Copied from Source/WebKit/chromium/public/gtk/WebFontInfo.h.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Wed, 28 Sep 2011 17:28:05 +0000 (17:28 +0000)]
watchlist: Suggest corrections for typos and improve error message consistency.
https://bugs.webkit.org/show_bug.cgi?id=68976
Reviewed by Adam Barth.
* Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
for typos and improve consistency of the error messages.
* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
and improve the regex that were already present.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 17:19:08 +0000 (17:19 +0000)]
Revert change which broke displaying end script tags in view-source, instead
deal with any trailing </script> tag included by mistake in the XSSAuditor
itself. Correct tests to detect the missing close tags.
https://bugs.webkit.org/show_bug.cgi?id=68898
Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-28
Reviewed by Adam Barth.
Source/WebCore:
* html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::end):
* html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::nextToken):
* html/parser/XSSAuditor.cpp:
(WebCore::startsHTMLEndTagAt):
(WebCore::XSSAuditor::snippetForJavaScript):
LayoutTests:
* fast/frames/resources/viewsource-frame-2.html:
* fast/frames/viewsource-plain-text-tags-expected.txt:
* fast/frames/viewsource-plain-text-tags.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 17:15:20 +0000 (17:15 +0000)]
Wrong integer checks in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68985
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-28
Reviewed by Geoffrey Garen.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 28 Sep 2011 17:06:59 +0000 (17:06 +0000)]
Remove empty directories.
Source/JavaScriptCore:
* wtf/brew: Removed.
* wtf/unicode/brew: Removed.
Source/WebCore:
* editing/brew: Removed.
* page/brew: Removed.
* platform/brew: Removed.
* platform/graphics/brew: Removed.
* platform/network/brew: Removed.
* platform/text/brew: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Wed, 28 Sep 2011 17:05:55 +0000 (17:05 +0000)]
watchlist: Add support for matching added or deleted lines.
https://bugs.webkit.org/show_bug.cgi?id=68972
Reviewed by Adam Barth.
* Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
* Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
* Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
to the pattern match to only have the diff lines instead of the DiffFile.
* Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
Add tests for the new patterns and combinations of the patterns.
* Scripts/webkitpy/common/watchlist/watchlistparser.py:
Sort imports. Add changeline support.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 28 Sep 2011 16:57:17 +0000 (16:57 +0000)]
Web Inspector: optional arguments support for the frontend needs to be extended.
https://bugs.webkit.org/show_bug.cgi?id=69005
Generator supports optional arguments but they are transferred by value.
It is not suitable if the used type doesn't have operator bool.
I'll transfer such arguments by pointer.
Reviewed by Pavel Feldman.
Build is the test.
* inspector/CodeGeneratorInspector.pm:
(generateFrontendFunction):
(paramTypeTraits):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didFailLoading):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 28 Sep 2011 16:24:23 +0000 (16:24 +0000)]
[GTK] Loader client implementation for WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=68085
Reviewed by Martin Robinson.
Adds a new object, WebKitWebLoaderClient, that emits signals for
every page loader callback.
* GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitWebLoaderClient.cpp: Added.
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(webkitWebLoaderClientConstructed):
(webkitWebLoaderClientSetProperty):
(webkitWebLoaderClientGetProperty):
(webkit_web_loader_client_init):
(webkit_web_loader_client_class_init):
* UIProcess/API/gtk/WebKitWebLoaderClient.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Create the loader client for the view.
(webkit_web_view_init):
(webkit_web_view_get_loader_client): Get the current loader client.
(webkit_web_view_set_loader_client): Set a new loader client.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/tests/testloading.c: Added.
(serverCallback):
(webLoadingFixtureSetup):
(webLoadingFixtureTeardown):
(getURIForPath):
(loadStatusProvisionalLoadStarted):
(loadStatusProvisionalLoadReceivedServerRedirect):
(loadStatusProvisionalLoadFailed):
(loadStatusLoadCommitted):
(loadStatusLoadFinished):
(loadStatusLoadFailed):
(testLoadingStatus):
(loadErrorProvisionalLoadStarted):
(loadErrorProvisionalLoadFailed):
(loadErrorLoadFinished):
(testLoadingError):
(main):
* UIProcess/API/gtk/webkit2marshal.list: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 28 Sep 2011 16:20:57 +0000 (16:20 +0000)]
[GTK] Add WebKitError to GTK+ WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=68508
Reviewed by Martin Robinson.
Source/WebKit2:
Add WebKitNetworkError enum to define network errors.
* GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitError.cpp: Added.
(webkit_network_error_quark):
* UIProcess/API/gtk/WebKitError.h:
* UIProcess/API/gtk/WebKitPrivate.h: Add
COMPILE_ASSERT_MATCHING_ENUM macro.
* UIProcess/API/gtk/webkit2.h: Add WebKitError.h and
WebKitEnumTypes.h
Tools:
* GNUmakefile.am: Add path to webkitgtk derived sources to the
include path.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 15:52:19 +0000 (15:52 +0000)]
Reflected attribute input.size wraps on negative values (Chrome), or
returns them (Safari).
https://bugs.webkit.org/show_bug.cgi?id=44886
Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-09-28
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/dom/HTMLInputElement/input-size-attribute.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute):
LayoutTests:
* fast/dom/HTMLInputElement/input-size-attribute-expected.txt: Added.
* fast/dom/HTMLInputElement/input-size-attribute.html: Added.
* fast/dom/HTMLInputElement/script-tests/size-attribute.js:
* fast/dom/HTMLInputElement/size-attribute-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 28 Sep 2011 15:01:41 +0000 (15:01 +0000)]
Web Inspector: Add support for search in single resource to page agent.
https://bugs.webkit.org/show_bug.cgi?id=68998
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/search/search-in-resource.html
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
* inspector/ContentSearchUtils.h:
* inspector/Inspector.json:
* inspector/InspectorPageAgent.cpp:
(WebCore::buildObjectForSearchMatch):
(WebCore::InspectorPageAgent::searchInResource):
* inspector/InspectorPageAgent.h:
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.searchInContent):
* inspector/front-end/SourceFile.js:
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):
* inspector/front-end/UISourceCode.js:
(WebInspector.ContentProvider.prototype.requestContent):
(WebInspector.ContentProvider.prototype.searchInContent):
LayoutTests:
* http/tests/inspector/search/search-in-resource-expected.txt: Added.
* http/tests/inspector/search/search-in-resource.html: Added.
* http/tests/inspector/search/search-in-resources.html:
* http/tests/inspector/search/search-test.js:
(initialize_SearchTest.InspectorTest.dumpSearchResults):
(initialize_SearchTest.InspectorTest.dumpSearchMatches):
(initialize_SearchTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 28 Sep 2011 14:30:54 +0000 (14:30 +0000)]
Web Inspector: It'd be useful to have performance stats for the back-end to front-end communication channel.
https://bugs.webkit.org/show_bug.cgi?id=69002
Reviewed by Yury Semikhatsky.
* inspector/CodeGeneratorInspector.pm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 28 Sep 2011 14:28:43 +0000 (14:28 +0000)]
[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396
Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-28
Reviewed by Csaba Osztrogonác.
* platform/wk2/Skipped: Skip svg/animations/animate-from-to-keyTimes.html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 28 Sep 2011 14:02:35 +0000 (14:02 +0000)]
Unreviewed, GTK baselines for new tests.
* platform/gtk/fast/multicol/float-paginate-empty-lines-expected.png: Added.
* platform/gtk/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
* platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
* platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Wed, 28 Sep 2011 13:53:31 +0000 (13:53 +0000)]
Web Inspector: live edit cursor always appears at the beginning of the file.
https://bugs.webkit.org/show_bug.cgi?id=68900
Reviewed by Pavel Feldman.
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype._updateSelectionOnStartEditing):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 28 Sep 2011 13:41:19 +0000 (13:41 +0000)]
Unreviewed, skip 2 64-bits Debug crashers on GTK.
* platform/gtk/Skipped: Skip
fast/borders/inline-mask-overlay-image-outset-vertical-rl.html and plugins/js-from-destroy.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Wed, 28 Sep 2011 12:35:16 +0000 (12:35 +0000)]
[EFL] Remove *void* parameter in internal functions
https://bugs.webkit.org/show_bug.cgi?id=68867
Reviewed by Andreas Kling.
As a step to let ewk be compliant with webkit coding style,
we need to remove *void* parameter in internal functions.
* ewk/ewk_private.h:
* ewk/ewk_settings.cpp:
(ewk_settings_web_database_default_quota_get):
* ewk/ewk_util.cpp:
(ewk_util_dpi_get):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 28 Sep 2011 12:35:09 +0000 (12:35 +0000)]
[Qt] Unreviewed gardening, update expected file after r95745.
* platform/qt-4.8/editing/deleting/merge-whitespace-pre-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 28 Sep 2011 11:56:36 +0000 (11:56 +0000)]
Web Inspector: Refactor searching in inspector, add test (fixed non regex search).
https://bugs.webkit.org/show_bug.cgi?id=68930
Reviewed by Yury Semikhatsky.
Source/WebCore:
Search moved out from page agent.
Fixed search for non regex case which is not yet used.
Test: http/tests/inspector/search/search-in-resources.html
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/ContentSearchUtils.cpp: Added.
(WebCore::ContentSearchUtils::createSearchRegexSource):
(WebCore::ContentSearchUtils::createSearchRegex):
(WebCore::ContentSearchUtils::countRegularExpressionMatches):
* inspector/ContentSearchUtils.h: Added.
* inspector/InspectorPageAgent.cpp:
(WebCore::hasTextContent):
(WebCore::InspectorPageAgent::cachedResourceContent):
(WebCore::textContentForCachedResource):
(WebCore::buildObjectForSearchResult):
(WebCore::InspectorPageAgent::searchInResources):
* inspector/front-end/utilities.js:
():
LayoutTests:
* http/tests/inspector/search/resources/search.css: Added.
(div.searchTestUniqueString):
(div.searchTestUniqueString:hover):
* http/tests/inspector/search/resources/search.html: Added.
* http/tests/inspector/search/resources/search.js: Added.
(searchTestUniqueString):
(doSomething):
* http/tests/inspector/search/search-in-resources-expected.txt: Added.
* http/tests/inspector/search/search-in-resources.html: Added.
* http/tests/inspector/search/search-test.js: Added.
(initialize_SearchTest.InspectorTest.dumpSearchResults):
(initialize_SearchTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 28 Sep 2011 11:25:41 +0000 (11:25 +0000)]
[GTK] missing WebKit2 support in run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=68992
Rubber-stamped by Andreas Kling.
* Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
webkit2 directory.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 28 Sep 2011 10:56:05 +0000 (10:56 +0000)]
[GTK] Fix Programs/unittests/webkit2/testwebview
https://bugs.webkit.org/show_bug.cgi?id=68993
Reviewed by Philippe Normand.
* GNUmakefile.am: Add -DWEBKIT_EXEC_PATH.
* UIProcess/API/gtk/tests/testwebview.c:
(main): Get WebProcess path from WEBKIT_EXEC_PATH environment
variable.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 09:54:22 +0000 (09:54 +0000)]
Implement a PopStateEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68896
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-28
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/pop-state-event-constructor.html
* bindings/v8/custom/V8EventConstructors.cpp: Added a PopStateEvent constructor.
* dom/PopStateEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled pop-state-event-constructor.html, since now V8 has the PopStateEvent constructor.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Wed, 28 Sep 2011 09:45:13 +0000 (09:45 +0000)]
[Texmap] Allow TextureMapperGL to work without a GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=68980
Reviewed by Andreas Kling.
Perform a null-check for m_context and initialize that variable.
If a graphics-context doesn't exist, we don't need to reset it.
No new functionality so no new tests.
* platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 28 Sep 2011 09:42:14 +0000 (09:42 +0000)]
Unreviewed fix for test.
* inspector/performance/resources/inspector-startup-time.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 28 Sep 2011 09:30:27 +0000 (09:30 +0000)]
Web Inspector: UI performance test for Inspector start-up time is required.
https://bugs.webkit.org/show_bug.cgi?id=68986
Reviewed by Yury Semikhatsky.
* inspector/performance/resources/inspector-startup-time.html: Added.
* inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 09:27:55 +0000 (09:27 +0000)]
Implement an ErrorEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68336
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-28
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/error-event-constructor.html
* bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::getKeyValue): Returns an unsigned value corresponding to a given key.
* bindings/v8/OptionsObject.h:
* bindings/v8/custom/V8EventConstructors.cpp: Added the ErrorEvent constructor.
* dom/ErrorEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled fast/events/constructors/error-event-constructor.html,
since V8 now has the constructor for ErrorEvent.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 28 Sep 2011 09:27:35 +0000 (09:27 +0000)]
[GTK] build-webkit --no-webkit2 still builds WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68892
Reviewed by Martin Robinson.
Take the --no-webkit2 option in account when building WebKitGTK+.
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(buildAutotoolsProject):
(buildGtkProject):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rgabor@webkit.org [Wed, 28 Sep 2011 08:47:08 +0000 (08:47 +0000)]
[Qt][GTK] Skip http/tests/multipart/stop-crash.html because it fails after r96174.
https://bugs.webkit.org/show_bug.cgi?id=68979
Reviewed by Csaba Osztrogonác.
* platform/gtk/Skipped: Skip http/tests/multipart/stop-crash.html failing
* platform/qt/Skipped: Skip http/tests/multipart/stop-crash.html failing
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Wed, 28 Sep 2011 08:28:35 +0000 (08:28 +0000)]
WebKitLinkedOnOrAfter() check is ineffective for Solar Walk app-specific hack.
https://bugs.webkit.org/show_bug.cgi?id=68863
Reviewed by Darin Adler.
The SolarWalk binary does not link against WebKit.framework directly,
so calling NSVersionOfLinkTimeLibrary() will not return the version of
WebKit against which SolarWalk was linked. Since Solar Walk has
released an update that addresses the issue for which this app-specific
hack was originally added, we should just remove the hack.
Source/WebCore:
* WebCore.exp.in: Remove applicationIsSolarWalkMac().
* platform/RuntimeApplicationChecks.cpp: Ditto.
* platform/RuntimeApplicationChecks.h: Ditto.
Source/WebKit:
* WebKit.xcodeproj/project.pbxproj: Remove SolarWalkQuirksUserScript.js.
Source/WebKit/mac:
* Misc/SolarWalkQuirksUserScript.js: Removed.
* WebView/WebView.mm: Removed needsSolarWalkQuirksScript(),
leakSolarWalkQuirksUserScriptContents(), and
-[WebView _injectSolarWalkQuirksScript].
(-[WebView _commonInitializationWithFrameName:groupName:]): Do not
inject the Solar Walk quirks script.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rgabor@webkit.org [Wed, 28 Sep 2011 08:21:05 +0000 (08:21 +0000)]
fast/canvas/crash-set-font.html failing on all platform because
getCSSCanvasContext needs 4 parameters
https://bugs.webkit.org/show_bug.cgi?id=66291
Reviewed by Csaba Osztrogonác.
* fast/canvas/crash-set-font.html: adding the fourth parameter
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Wed, 28 Sep 2011 08:06:48 +0000 (08:06 +0000)]
Fix potential SVG performance regression (over-invalidation of caches) from 96052
https://bugs.webkit.org/show_bug.cgi?id=68941
<rdar://problem/
10196224>
Reviewed by Zoltan Herczeg.
Only invalidate the cache of a filter when target style changes, as of the different types of cached
resources, only filters make use of the style of the target element and thus need to be invalidated
when the target style changes.
No new tests, performance improvement.
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientUpdatedFromElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 08:02:15 +0000 (08:02 +0000)]
[EFL] Allow to skip count parameter in ewk_view_repaints_get and ewk_view_scroll_requests_get.
https://bugs.webkit.org/show_bug.cgi?id=65842
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-09-28
Reviewed by Ryosuke Niwa.
Makes the count parameter in ewk_view_repaints_get and ewk_view_scroll_requests_get
as an optional parameter. Developer may pass NULL to skip returning the number of elements
of the requested array.
* ewk/ewk_view.cpp:
(ewk_view_repaints_get):
(ewk_view_scroll_requests_get):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Wed, 28 Sep 2011 08:00:47 +0000 (08:00 +0000)]
[Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68895
Unreviewed manual rebaseline for linux gpu.
* platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Wed, 28 Sep 2011 07:54:24 +0000 (07:54 +0000)]
[Chromium] Layout Test svg/custom/oversized-pattern-scale.svg and svg/custom/transformed-pattern-clamp-svg-root.svg are flaky
https://bugs.webkit.org/show_bug.cgi?id=68982
Unreviewed test_expectations.txt update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 28 Sep 2011 07:46:21 +0000 (07:46 +0000)]
Web Inspector: Unreviewed. Slight adjustment of the test content for better representation of the performance.
* inspector/performance/resources/show-panel.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Wed, 28 Sep 2011 07:44:19 +0000 (07:44 +0000)]
Unreviewed rebaseline pservers-grad-14-b again.
* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
* platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
* platform/chromium/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Wed, 28 Sep 2011 07:39:30 +0000 (07:39 +0000)]
Layout Test fast/multicol/float-paginate-empty-lines.html and some svg tests are failing
https://bugs.webkit.org/show_bug.cgi?id=68970
Unreviewed fix for a lint error in test_expectations.txt
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 07:22:38 +0000 (07:22 +0000)]
Missing initialization of member in ImageFrameQt class
https://bugs.webkit.org/show_bug.cgi?id=68943
Patch by Adenilson Cavalcanti <adenilson.silva@openbossa.org> on 2011-09-28
Reviewed by Kenneth Rohde Christiansen.
No new tests, this fixes internal implementation detail.
* platform/image-decoders/qt/ImageFrameQt.cpp:
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 07:12:40 +0000 (07:12 +0000)]
[EFL] URL of resources are not decoded.
https://bugs.webkit.org/show_bug.cgi?id=66540
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-09-28
Reviewed by Ryosuke Niwa.
Fix ewk_frame_resources_location_get which was returning the encoded URL of resources.
As a result characters for instance, %20 occurred. For now returned strings are decoded.
* ewk/ewk_frame.cpp:
(ewk_frame_resources_location_get):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 28 Sep 2011 07:02:42 +0000 (07:02 +0000)]
Make Chromium Win Release (Tests) a core builder
https://bugs.webkit.org/show_bug.cgi?id=68906
Reviewed by Adam Barth.
Add Chromium Win Release (Tests) to the list of core builders.
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 28 Sep 2011 06:46:35 +0000 (06:46 +0000)]
[Qt] Unreviewed gardening. Add platform specific expected result for new test introduced in r96149.
* platform/qt/fast/multicol/float-paginate-empty-lines-expected.png: Added.
* platform/qt/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Wed, 28 Sep 2011 06:32:38 +0000 (06:32 +0000)]
Defer call to CSSValue::isPrimitiveValue(), saves ~4% in CSSStyleSelector::applyProperty().
https://bugs.webkit.org/show_bug.cgi?id=68964
Reviewed by Eric Seidel.
No new tests / no functionality changed.
Doing value->isPrimitiveValue() is relatviely expensive, so moving it after the early returns but
before the result is used saves a significant number of cycles. (Tested with Shark profiler in Safari).
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Wed, 28 Sep 2011 05:43:38 +0000 (05:43 +0000)]
[Chromium] Layout Test fast/canvas/canvas-composite-transformclip.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68895
Unreviewed rebaseline for skia r2300 roll.
* platform/chromium-cg-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
* platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png:
* platform/chromium-gpu-win/fast/canvas/canvas-composite-transformclip-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
* platform/chromium/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Wed, 28 Sep 2011 05:37:17 +0000 (05:37 +0000)]
Layout Test fast/multicol/float-paginate-empty-lines.html and some svg tests are failing
https://bugs.webkit.org/show_bug.cgi?id=68970
Unreviewed test_expectations.txt update
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 28 Sep 2011 05:33:21 +0000 (05:33 +0000)]
DFG JIT cannot compile op_new_object, op_new_array,
op_new_array_buffer, or op_new_regexp
https://bugs.webkit.org/show_bug.cgi?id=68580
Reviewed by Oliver Hunt.
This implements all four opcodes, but has op_new_regexp turns off
by default because it unveils some bad speculation logic when
compiling string-validate-input.
With op_new_regexp turned off, this is a 5% win on Kraken and a
0.7% speed-up on V8. Neutral on SunSpider.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasConstantBuffer):
(JSC::DFG::Node::startConstant):
(JSC::DFG::Node::numConstants):
(JSC::DFG::Node::hasRegexpIndex):
(JSC::DFG::Node::regexpIndex):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isKnownArray):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Wed, 28 Sep 2011 05:23:51 +0000 (05:23 +0000)]
Unreviewed. Fix a build error in WebKit EFL.
When web socket is disabled, there is a build break in WebKit EFL port.
Currently, web socket is enabled by default in build-webkit script.
Thus, the web socket is also enabled in EFL script of cmake build system for now.
Because, WebKit EFL developers can't work on latest WebKit trunk.
However, IMO, we should fix build errors when web socket is disabled.
* Source/cmake/OptionsEfl.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 28 Sep 2011 05:04:20 +0000 (05:04 +0000)]
Simplify ReplaceSelectionCommand::positionAtStartOfInsertedContent
https://bugs.webkit.org/show_bug.cgi?id=68939
Reviewed by Darin Adler.
Simplified ReplaceSelectionCommand::positionAtStartOfInsertedContent.
This change revealed a bug in removeUnrenderedTextNodesAtEnds that text nodes without any visible
text at ends are not removed when it has a render object. Fixed the bug by checking the length of
the rendered text. (Tested by editing/pasteboard/pasting-word-in-div-extra-line.html)
This further revealed that caretMaxRenderedOffset doesn't return an offset and caretMaxRenderedOffset
on InlineBox, InlineTextBox, RenderObject, RenderBR, RenderPlaced are never called. To address this
issue, renamed caretMaxRenderedOffset to renderedTextLength for RenderText and removed the rest.
* dom/Position.cpp:
(WebCore::Position::rendersInDifferentPosition):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::nodeHasVisibleRenderText): Added.
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Calls nodeHasVisibleRenderText.
(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Simplified.
* editing/visible_units.cpp:
(WebCore::startOfParagraph): Calls renderedTextLength.
(WebCore::endOfParagraph): Ditto.
* rendering/InlineBox.cpp: Removed caretMaxRenderedOffset.
* rendering/InlineBox.h: Ditto.
* rendering/InlineTextBox.cpp: Ditto.
* rendering/InlineTextBox.h: Ditto.
* rendering/RenderBR.cpp: Ditto.
* rendering/RenderBR.h: Ditto.
* rendering/RenderObject.cpp: Ditto.
* rendering/RenderObject.h: Ditto.
* rendering/RenderReplaced.cpp: Ditto.
* rendering/RenderReplaced.h: Ditto.
* rendering/RenderText.cpp:
(WebCore::RenderText::renderedTextLength): Renamed from caretMaxRenderedOffset.
* rendering/RenderText.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 04:56:31 +0000 (04:56 +0000)]
[chromium] LayerRenderChromium asserts about leaking textures.
https://bugs.webkit.org/show_bug.cgi?id=68190
Patch by James Robinson <jamesr@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.
This introduces an interface TextureAllocator that the TextureManager uses to allocate/deallocate textures.
This means that TextureManager does not need to depend directly on GraphicsContext3D, other than for the format
enum type, making it more testable. It also allows us to track the allocations by subclassing TextureAllocator
to make sure we aren't leaking any textures.
* WebCore.gypi:
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateCompositorResources):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::renderSurfaceTextureAllocator):
(WebCore::LayerRendererChromium::contentsTextureAllocator):
* platform/graphics/chromium/LayerTextureUpdater.h:
* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
* platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
* platform/graphics/chromium/ManagedTexture.h:
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::memoryUseBytes):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::evictAndDeleteAllTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):
* platform/graphics/chromium/TextureManager.h:
(WebCore::TextureAllocator::~TextureAllocator):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/TrackingTextureAllocator.cpp: Added.
(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::~TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::createTexture):
(WebCore::TrackingTextureAllocator::deleteTexture):
* platform/graphics/chromium/TrackingTextureAllocator.h: Copied from Source/WebCore/platform/graphics/chromium/ManagedTexture.h.
(WebCore::TrackingTextureAllocator::create):
(WebCore::TrackingTextureAllocator::currentMemoryUseBytes):
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::updateTexture):
* platform/graphics/chromium/VideoLayerChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
* platform/graphics/chromium/WebGLLayerChromium.h:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnCCThread):
(WebCore::CCLayerTreeHost::commitToOnCCThread):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::contentsTextureAllocator):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawSurface):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 04:03:24 +0000 (04:03 +0000)]
[chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested
https://bugs.webkit.org/show_bug.cgi?id=68967
Patch by James Robinson <jamesr@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.
When updating the scheduler state, we should only initiate a new commit flow if a commit has been requested (as
opposed to only a redraw).
Covered by the unit test CCLayerTreeHostTestSetNeedsRedraw with USE(THREADED_COMPOSITING) set to true.
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 28 Sep 2011 03:39:36 +0000 (03:39 +0000)]
DFG JIT should speculate more aggressively on reads of array.length
https://bugs.webkit.org/show_bug.cgi?id=68932
Reviewed by Oliver Hunt.
This is a 2% speed-up on Kraken, neutral elsewhere.
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 28 Sep 2011 03:37:23 +0000 (03:37 +0000)]
garden-o-matic should load faster and inform the user what is happening
https://bugs.webkit.org/show_bug.cgi?id=68954
Reviewed by Dimitri Glazkov.
This test disables the expected failures tab. The web inspector showed
that loading the data for this tab was slowing down the loading time
for the whole app. We need to find a way to load that data lazily.
This patch also improves the update message to better describe the
progress the app is making analyzing data from the buildbot.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Wed, 28 Sep 2011 02:58:50 +0000 (02:58 +0000)]
Add layout test for WaveShaperNode
https://bugs.webkit.org/show_bug.cgi?id=68925
Reviewed by Kenneth Russell.
* webaudio/waveshaper-expected.txt: Added.
* webaudio/waveshaper.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 28 Sep 2011 02:48:41 +0000 (02:48 +0000)]
garden-o-matic should show the first result when examining results
https://bugs.webkit.org/show_bug.cgi?id=68960
Reviewed by Dimitri Glazkov.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 02:30:27 +0000 (02:30 +0000)]
Implement a PageTransitionEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68067
Patch by Kentaro Hara <haraken@chromium.com> on 2011-09-27
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/page-transition-event-constructor.html
* bindings/v8/custom/V8EventConstructors.cpp: Added the PageTransitionEvent constructor.
* dom/PageTransitionEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled page-transition-event-constructor.html, since now V8 has a PageTransitionEvent constructor.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Sep 2011 02:02:18 +0000 (02:02 +0000)]
Implement a MessageEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68883
Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-27
Reviewed by Adam Barth.
Source/WebCore:
The spec for MessageEvent is here:
http://www.whatwg.org/specs/web-apps/current-work/#messageevent
Currently, some tests in fast/events/constructors/message-event-constructor.html
are failing or crashing in DRT, as we commented in the test file.
This is because MessageEvent.data is implemented as SerializedScriptValue,
and thus it cannot keep ScriptValue passed by JavaScript.
This is the same issue as the bug (https://bugs.webkit.org/show_bug.cgi?id=68345).
We will soon make a follow-up patch to fix these failures, after this
patch is landed.
Test: fast/events/constructors/message-event-constructor.html
* bindings/generic/EventConstructors.h: Added a definition for the MessageEvent constructor.
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Generates MessagePortArray from the list of message ports in the format of JSValues.
* bindings/js/JSDictionary.h:
* bindings/js/JSEventConstructors.cpp: Added #includes for MessageEvent.
* dom/MessageEvent.cpp:
(WebCore::MessageEventInit::MessageEventInit):
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
* dom/MessageEvent.h: Added a definition for MessageEvent. Removed an extra leading spaces.
(WebCore::MessageEvent::create):
(WebCore::MessageEvent::origin):
(WebCore::MessageEvent::lastEventId):
(WebCore::MessageEvent::source):
(WebCore::MessageEvent::ports):
(WebCore::MessageEvent::dataType):
(WebCore::MessageEvent::dataAsSerializedScriptValue):
(WebCore::MessageEvent::dataAsString):
(WebCore::MessageEvent::dataAsBlob):
(WebCore::MessageEvent::dataAsArrayBuffer):
* dom/MessageEvent.idl: Makes MessageEvent constructible.
LayoutTests:
message-event-constructor.html checks the behavior of the MessageEvent constructor.
* fast/dom/constructed-objects-prototypes-expected.txt: Now window has MessageEvent.
* fast/events/constructors/message-event-constructor-expected.txt: Added.
* fast/events/constructors/message-event-constructor.html: Added.
* platform/chromium/test_expectations.txt: Skipped message-event-constructor.html, since V8 does not yet have the MessageEvent constructor.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 28 Sep 2011 01:52:21 +0000 (01:52 +0000)]
DFG JIT - merge changes between 95905 - 96175
https://bugs.webkit.org/show_bug.cgi?id=68963
Reviewed by Sam Weinig.
Merge missing changes from bug#68677, bug#68784, bug#68785.
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ericu@chromium.org [Wed, 28 Sep 2011 01:46:08 +0000 (01:46 +0000)]
[Chromium/FileWriter] race condition in FileWriter completion can lead to assert
https://bugs.webkit.org/show_bug.cgi?id=67684
Reviewed by David Levin.
Source/WebCore:
Tests: fast/filesystem/file-writer-abort-continue.html
fast/filesystem/file-writer-abort.html
Track the state of the backend and be prepared for reentrant user
requests. Limit recursion depth to an arbitrary small constant.
* fileapi/FileWriter.cpp: Lots of event-handling changes.
* fileapi/FileWriter.h:
LayoutTests:
* fast/filesystem/file-writer-abort-continue-expected.txt: Added.
* fast/filesystem/file-writer-abort-continue.html: Added.
* fast/filesystem/file-writer-abort-expected.txt: Added.
* fast/filesystem/file-writer-abort.html: Added.
* fast/filesystem/resources/file-writer-abort-continue.js: Added.
* fast/filesystem/resources/file-writer-abort.js: Added.
* fast/filesystem/resources/file-writer-events.js: Fixed a copy-paste error.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Wed, 28 Sep 2011 01:12:10 +0000 (01:12 +0000)]
svg/custom/oversized-pattern-scale.svg is useless because the interesting part of the test is off the screen
https://bugs.webkit.org/show_bug.cgi?id=68945
Reviewed by Darin Adler.
Change oversized-pattern-scale so that the interesting part of the pattern is on the screen,
and so that it doesn't draw a scrollbar (making it platform-independent).
Change transformed-pattern-clamp-svg-root so that it doesn't draw a gradient, making it platform-independent.
* svg/custom/oversized-pattern-scale-expected.png:
* svg/custom/oversized-pattern-scale-expected.txt:
* svg/custom/oversized-pattern-scale.svg:
* svg/custom/transformed-pattern-clamp-svg-root-expected.png:
* svg/custom/transformed-pattern-clamp-svg-root-expected.txt:
* svg/custom/transformed-pattern-clamp-svg-root.svg:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 28 Sep 2011 01:09:33 +0000 (01:09 +0000)]
Get JSVALUE32_64 DFG JIT building on OS X.
https://bugs.webkit.org/show_bug.cgi?id=68961
Reviewed by Geoff Garen.
* Merge bug #68763 (DFG JIT should not eagerly initialize integer tags in the register file).
* Forward-declare functions in DFGOperations.cpp
* UNUSED_PARAM for unused arguments
* NO_RETURN for unimplemented function that ASSERT_NOT_REACHED
* Fix argument types handled by OpInfo constructor.
* Use SYMBOL_STRING instead of STRINGIZE for asm symbols.
* Add files to Xcode project.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 28 Sep 2011 01:01:59 +0000 (01:01 +0000)]
http/tests/navigation/anchor-basic.html is flaky on Snow Leopard Release Bot
https://bugs.webkit.org/show_bug.cgi?id=34222
Reviewed by Ryosuke Niwa.
Add waitUntilDone/notifyDone to eliminate flakiness on mac. Without it, the img onload handler
doesn't always run. Also reduce the multipart timeout (should help to unblock other http requests).
* http/tests/multipart/stop-crash-expected.txt:
* http/tests/multipart/stop-crash.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 28 Sep 2011 00:25:01 +0000 (00:25 +0000)]
Unreviewed, rolling out r96141.
http://trac.webkit.org/changeset/96141
https://bugs.webkit.org/show_bug.cgi?id=68190
Breaks PrerenderBrowserTest.PrerenderHTML5Video in
browser_tests
* WebCore.gypi:
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateCompositorResources):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::createLayerTexture):
(WebCore::LayerRendererChromium::deleteLayerTexture):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::setContentsTextureMemoryUseBytes):
* platform/graphics/chromium/LayerTextureUpdater.h:
* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
* platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
* platform/graphics/chromium/ManagedTexture.h:
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::memoryUseBytes):
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::evictAndDeleteAllTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):
* platform/graphics/chromium/TextureManager.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/TrackingTextureAllocator.cpp: Removed.
* platform/graphics/chromium/TrackingTextureAllocator.h: Removed.
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::updateTexture):
* platform/graphics/chromium/VideoLayerChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
* platform/graphics/chromium/WebGLLayerChromium.h:
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTextures):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp.rej: Removed.
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawSurface):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 27 Sep 2011 23:51:09 +0000 (23:51 +0000)]
[chromium] Guard accelerated skia drawing logic with its own define to remove dependency on USE(THREADED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=68953
Reviewed by Kenneth Russell.
The accelerated drawing code is incompatible with threaded compositing. Rather than tying the two behaviors
together via USE(THREADED_COMPOSITING), this patch guards the accelerated drawing code with its own USE() guard
so the features can advance independently. Today, it's not safe to set both of these flags.
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 27 Sep 2011 23:48:49 +0000 (23:48 +0000)]
Bug fixes for GetById, PutById, and GetByOffset in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68755
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-27
Reviewed by Gavin Barraclough.
We need to load/store and repatch both tag and payload of a property
for GetById/PutById. Also reorder the loads of tag and payload for
GetByOffset as the result tag GPR could reuse the storage GPR.
* bytecode/StructureStubInfo.h:
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchByIdSelfAccess):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Tue, 27 Sep 2011 23:42:12 +0000 (23:42 +0000)]
watchlist: Add support for cc and message rules.
https://bugs.webkit.org/show_bug.cgi?id=68950
Reviewed by Adam Barth.
* Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
the cc's and messages for a patch.
* Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
* Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
for the rules.
* Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
A generic encapsulation of either a message list or a cc list.
* Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 27 Sep 2011 23:32:23 +0000 (23:32 +0000)]
Macro assembler branch8 & 16 methods vary in treatment of upper bits
https://bugs.webkit.org/show_bug.cgi?id=68301
Reviewed by Sam Weinig.
Fix for branch16 - remove it!
No performance impact.
* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.h:
* assembler/MacroAssemblerARMv7.h:
* assembler/MacroAssemblerMIPS.h:
* assembler/MacroAssemblerSH4.h:
* assembler/MacroAssemblerX86Common.h:
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Tue, 27 Sep 2011 23:24:53 +0000 (23:24 +0000)]
Slightly improve performance of CSSStyleApplyProperty handler lookup.
https://bugs.webkit.org/show_bug.cgi?id=68868
Reviewed by Eric Seidel.
No new tests as no functionality changed.
* css/CSSStyleApplyProperty.h:
(WebCore::CSSStyleApplyProperty::propertyHandler):
Make propertyHandler() public and remove redirecting functions.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Perform property handler lookup once and reuse the result.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 27 Sep 2011 23:11:49 +0000 (23:11 +0000)]
Chromium baselines for fast/multicol/float-paginate-empty-lines.html
after r96149 and 96162.
* platform/chromium-linux/fast/multicol/float-paginate-empty-lines-expected.png: Added.
* platform/chromium-mac/fast/multicol/float-paginate-empty-lines-expected.png: Added.
* platform/chromium-win/fast/multicol/float-paginate-empty-lines-expected.png: Added.
* platform/chromium-win/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 27 Sep 2011 23:05:01 +0000 (23:05 +0000)]
[V8] element.dataset.nonExistingKey should return undefined.
https://bugs.webkit.org/show_bug.cgi?id=68877
Reviewed by Nate Chapin.
Source/WebCore:
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyGetter): Uses v8StringOrUndefined() instead of v8String().
LayoutTests:
* fast/dom/dataset-expected.txt: Updated.
* fast/dom/script-tests/dataset.js: Add a test case.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 27 Sep 2011 22:53:56 +0000 (22:53 +0000)]
Chromium rebaseline after r96155.
* platform/chromium-cg-mac/svg/custom/pattern-excessive-malloc-expected.png: Added.
* platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png: Added.
* platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
* platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png: Added.
* platform/chromium-win/svg/custom/pattern-excessive-malloc-expected.png:
* platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
* platform/chromium/svg/custom/oversized-pattern-scale-expected.png: Added.
* platform/mac/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
* platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Tue, 27 Sep 2011 22:46:51 +0000 (22:46 +0000)]
Source/JavaScriptCore: Add static version of JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=68741
Reviewed by Darin Adler.
In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::getCallDataVirtual):
(JSC::JSCallbackFunction::getCallData):
* API/JSCallbackFunction.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getCallDataVirtual):
(JSC::::getCallData):
* API/JSObjectRef.cpp:
(JSObjectIsFunction):
(JSObjectCallAsFunction):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getCallDataVirtual):
(JSC::ArrayConstructor::getCallData):
* runtime/ArrayConstructor.h:
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::getCallDataVirtual):
(JSC::BooleanConstructor::getCallData):
* runtime/BooleanConstructor.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getCallDataVirtual):
(JSC::DateConstructor::getCallData):
* runtime/DateConstructor.h:
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::getCallDataVirtual):
(JSC::ErrorConstructor::getCallData):
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::getCallDataVirtual):
(JSC::FunctionConstructor::getCallData):
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::getCallDataVirtual):
(JSC::FunctionPrototype::getCallData):
* runtime/FunctionPrototype.h:
* runtime/InternalFunction.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getCallDataVirtual):
(JSC::JSCell::getCallData):
* runtime/JSCell.h:
(JSC::getCallData):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getCallDataVirtual):
(JSC::JSFunction::getCallData):
* runtime/JSFunction.h:
* runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::getCallDataVirtual):
(JSC::NativeErrorConstructor::getCallData):
* runtime/NativeErrorConstructor.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getCallDataVirtual):
(JSC::NumberConstructor::getCallData):
* runtime/NumberConstructor.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getCallDataVirtual):
(JSC::ObjectConstructor::getCallData):
* runtime/ObjectConstructor.h:
* runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):
* runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getCallDataVirtual):
(JSC::RegExpConstructor::getCallData):
* runtime/RegExpConstructor.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getCallDataVirtual):
(JSC::StringConstructor::getCallData):
* runtime/StringConstructor.h:
Source/JavaScriptGlue: Add static version of JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=68741
Reviewed by Darin Adler.
In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.
* JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCallFunction):
* UserObjectImp.cpp:
(UserObjectImp::getCallDataVirtual):
(UserObjectImp::getCallData):
* UserObjectImp.h:
Source/WebCore: Add static version of JSCell::visitChildren
https://bugs.webkit.org/show_bug.cgi?id=68404
Reviewed by Darin Adler.
No new tests.
In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.
* WebCore.exp.in:
* bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::visitChildrenVirtual):
(WebCore::JSAttr::visitChildren):
* bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContext::visitChildrenVirtual):
(WebCore::JSAudioContext::visitChildren):
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::JSCSSRule::visitChildrenVirtual):
(WebCore::JSCSSRule::visitChildren):
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::visitChildrenVirtual):
(WebCore::JSCSSStyleDeclaration::visitChildren):
* bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::JSCanvasRenderingContext::visitChildrenVirtual):
(WebCore::JSCanvasRenderingContext::visitChildren):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::visitChildrenVirtual):
(WebCore::JSDOMGlobalObject::visitChildren):
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitChildrenVirtual):
(WebCore::JSDOMWindow::visitChildren):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::visitChildrenVirtual):
(WebCore::JSDOMWindowShell::visitChildren):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSJavaScriptAudioNodeCustom.cpp:
(WebCore::JSJavaScriptAudioNode::visitChildrenVirtual):
(WebCore::JSJavaScriptAudioNode::visitChildren):
* bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::visitChildrenVirtual):
(WebCore::JSMessageChannel::visitChildren):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::visitChildrenVirtual):
(WebCore::JSMessagePort::visitChildren):
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::visitChildrenVirtual):
(WebCore::JSNamedNodeMap::visitChildren):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::visitChildrenVirtual):
(WebCore::JSNode::visitChildren):
* bindings/js/JSNodeFilterCustom.cpp:
(WebCore::JSNodeFilter::visitChildrenVirtual):
(WebCore::JSNodeFilter::visitChildren):
* bindings/js/JSNodeIteratorCustom.cpp:
(WebCore::JSNodeIterator::visitChildrenVirtual):
(WebCore::JSNodeIterator::visitChildren):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::visitChildrenVirtual):
(WebCore::JSSVGElementInstance::visitChildren):
* bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorker::visitChildrenVirtual):
(WebCore::JSSharedWorker::visitChildren):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::JSStyleSheet::visitChildrenVirtual):
(WebCore::JSStyleSheet::visitChildren):
* bindings/js/JSTreeWalkerCustom.cpp:
(WebCore::JSTreeWalker::visitChildrenVirtual):
(WebCore::JSTreeWalker::visitChildren):
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::visitChildrenVirtual):
(WebCore::JSWebGLRenderingContext::visitChildren):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::visitChildrenVirtual):
(WebCore::JSWorkerContext::visitChildren):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitChildrenVirtual):
(WebCore::JSXMLHttpRequest::visitChildren):
* bindings/js/JSXPathResultCustom.cpp:
(WebCore::JSXPathResult::visitChildrenVirtual):
(WebCore::JSXPathResult::visitChildren):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::visitChildrenVirtual):
(WebCore::JSTestObj::visitChildren):
* bindings/scripts/test/JS/JSTestObj.h:
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeObject::visitChildren):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
* bridge/qt/qt_runtime.h:
* workers/WorkerContext.h:
Source/WebKit/mac: Add static version of JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=68741
Reviewed by Darin Adler.
In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
Source/WebKit2: Add static version of JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=68741
Reviewed by Darin Adler.
In this patch we just extract the bodies of the virtual getCallData methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of getCallData into our own method table stored in
ClassInfo. We need to convert the methods to static methods because static methods
can be represented as function pointers rather than pointers to member functions, and
function pointers are smaller and faster to call than pointers to member functions.
* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::getCallDataVirtual):
(WebKit::JSNPMethod::getCallData):
* WebProcess/Plugins/Netscape/JSNPMethod.h:
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getCallDataVirtual):
(WebKit::JSNPObject::getCallData):
* WebProcess/Plugins/Netscape/JSNPObject.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Tue, 27 Sep 2011 22:43:27 +0000 (22:43 +0000)]
Unreviewed. Remove duplicate FilterOperation{s}.h that were
accidentally added to the top level of the Xcode project.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 27 Sep 2011 22:11:41 +0000 (22:11 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68940
Narrow the float/lines pagination heuristic to only kick in if
the previous line broke cleanly and if the floats are occurring
at the start of the line.
Reviewed by Dan Bernstein.
Source/WebCore:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::positionNewFloatOnLine):
LayoutTests:
* fast/regions/webkit-flow-float-pushed-to-last-region.html:
* platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 22:04:21 +0000 (22:04 +0000)]
webkit-patch doesn't like UTF-8 characters in reviewers names
https://bugs.webkit.org/show_bug.cgi?id=63452
Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-27
Reviewed by Eric Seidel.
* Scripts/webkit-patch:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 21:47:30 +0000 (21:47 +0000)]
Add a mechanism to test for the compositing tree mutated during painting
https://bugs.webkit.org/show_bug.cgi?id=68738
Patch by James Robinson <jamesr@chromium.org> on 2011-09-27
Reviewed by Adam Barth.
Source/WebCore:
Sets a static bool during GraphicsLayer::paintGraphicsLayerContents and ASSERT()s that we never create or
destroy a GraphicsLayer inside this function. Painting should never mutate the GraphicsLayer tree.
Test: compositing/video/video-with-invalid-source.html
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):
LayoutTests:
Adds a test that caused compositing to be disabled during painting before r95863 due to a video load failing.
* compositing/video/video-with-invalid-source-expected.txt: Added.
* compositing/video/video-with-invalid-source.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96160
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 27 Sep 2011 21:45:54 +0000 (21:45 +0000)]
take padding/border on flexbox into account with direction:rtl
https://bugs.webkit.org/show_bug.cgi?id=68846
Reviewed by David Hyatt.
Source/WebCore:
Use the logicalWidth of the flexbox instead of it's availableLogicalWidth
so that we include the flexbox's border and padding.
Also, change all uses of availableLogicalWidth to contentLogicalWidth.
The former takes multi-column into account. Multi-column flexboxes don't
make any sense, so there's no point in calling availableLogicalWidth.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::flowAwareLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
* rendering/RenderFlexibleBox.h:
LayoutTests:
* css3/flexbox/writing-modes-expected.txt:
* css3/flexbox/writing-modes.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 27 Sep 2011 21:25:17 +0000 (21:25 +0000)]
Chromium test expectations update.
Make new fast/canvas/canvas-composite.html GPU expectation more specific,
since on Leopard it was conflicting with an older one.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 27 Sep 2011 21:19:16 +0000 (21:19 +0000)]
Unreviewed, rolling out r96139.
http://trac.webkit.org/changeset/96139
https://bugs.webkit.org/show_bug.cgi?id=68933
Broke table-percent-height.html on Mac bots (Requested by
mwenge2 on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-27
Source/WebCore:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
* rendering/RenderBox.h:
LayoutTests:
* fast/replaced/table-percent-width-expected.txt: Removed.
* fast/replaced/table-percent-width.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96157
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reed@google.com [Tue, 27 Sep 2011 21:12:28 +0000 (21:12 +0000)]
need to rebseline these once new aa-gdi-text code lands in skia
https://bugs.webkit.org/show_bug.cgi?id=68920
Reviewed by Kenneth Russell.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Tue, 27 Sep 2011 21:06:17 +0000 (21:06 +0000)]
REGRESSION(65665): Pattern size being clamped to SVG size can prevent transformed elements from being fully covered by userSpaceOnUse patterns
https://bugs.webkit.org/show_bug.cgi?id=67700
<rdar://problem/
10125102>
Reviewed by Darin Adler.
Clamp all resources to the same size, 4096x4096 (arbitrarily chosen), instead of to the size
of the <svg> element. This fixes the case where a transformed element displays part of a resource
outside of the size of the <svg> element.
When drawing an oversized pattern into its tile image, scale the content down to fit. When drawing
the tile image to the screen, scale it back up to fit the expected area. This will cause pixelation
when patterns are over the 4k limit.
Tests: svg/custom/transformed-pattern-clamp-svg-root.svg, svg/custom/oversized-pattern-scale.svg
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
(WebCore::RenderSVGResourcePattern::createTileImage):
* rendering/svg/RenderSVGResourcePattern.h:
* rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::clampedAbsoluteTargetRect):
* rendering/svg/SVGImageBufferTools.h:
pattern-excessive-malloc is so excessive that it runs into the floating point precision barrier
when determining the scale to draw the pattern at; drop the size two orders of magnitude, which is
still very excessive but easier to draw with.
Add a test (transformed-pattern-clamp-svg-root.svg) that ensures that patterns on transformed
elements are displayed correctly, instead of being clamped to the size of the <svg> element.
Add a test (oversized-pattern-scale.svg) that ensures that oversized patterns are correctly drawn
into the pattern tile scaled down and then are scaled back up when drawn to the screen.
* platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/mac/svg/custom/pattern-excessive-malloc-expected.txt:
* platform/qt/svg/custom/pattern-excessive-malloc-expected.txt:
* svg/custom/pattern-excessive-malloc-expected.txt:
* svg/custom/pattern-excessive-malloc.svg:
* svg/custom/oversized-pattern-scale-expected.png: Added.
* svg/custom/oversized-pattern-scale-expected.txt: Added.
* svg/custom/oversized-pattern-scale.svg: Added.
* svg/custom/transformed-pattern-clamp-svg-root.svg: Added.
* svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added.
* svg/custom/transformed-pattern-clamp-svg-root-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96155
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 27 Sep 2011 21:04:04 +0000 (21:04 +0000)]
<rdar://problem/
10098679> Assertion failure in RenderLayer::paintPaginatedChildLayer()
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/dynamic/layer-no-longer-paginated.html
FrameView::layout() calls adjustViewSize() before calling RenderLayer::updateLayerPositions().
The former may trigger painting with a layer tree that is not entirely up-to-date. Specifically,
the isPaginated() state of a layer may be incorrect, leading to the assertion in this bug. Instead
of asserting, return early and count on the upcoming updateLayerPositions() to repaint as needed.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintPaginatedChildLayer): Replaced the assertion with an early return.
LayoutTests:
* fast/dynamic/layer-no-longer-paginated-expected.txt: Added.
* fast/dynamic/layer-no-longer-paginated.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 27 Sep 2011 21:02:34 +0000 (21:02 +0000)]
garden-o-matic examine buttons shows both expected and unexpected failures
https://bugs.webkit.org/show_bug.cgi?id=68918
Reviewed by Dimitri Glazkov.
This was a copy/paste error when I refactored this classes to share
more code.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 27 Sep 2011 20:55:00 +0000 (20:55 +0000)]
offsetTop/offsetLeft return the wrong values for horizontal-bt/vertical-rl writing modes
https://bugs.webkit.org/show_bug.cgi?id=68304
Reviewed by David Hyatt.
Source/WebCore:
When grabbing the x/y values of the RenderBox, we need to take writing mode
flipping into account.
Test: fast/dom/offset-position-writing-modes.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::locationIncludingFlipping):
* rendering/RenderBox.h:
(WebCore::RenderBox::yFlippedForWritingMode):
(WebCore::RenderBox::xFlippedForWritingMode):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):
LayoutTests:
* css3/flexbox/writing-modes-expected.txt:
* css3/flexbox/writing-modes.html:
* fast/dom/offset-position-writing-modes-expected.txt: Added.
* fast/dom/offset-position-writing-modes.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Tue, 27 Sep 2011 20:54:16 +0000 (20:54 +0000)]
Rapidly refreshing a feMorphology[erode] with r=0 can sometimes cause display corruption
https://bugs.webkit.org/show_bug.cgi?id=68816
<rdar://problem/
10186468>
Reviewed by Simon Fraser.
If a filter returns without writing into its result buffer, make sure to return an cleared buffer.
Test: svg/filters/feMorphology-zero-radius.svg
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc