MyungJoo Ham [Mon, 11 Apr 2016 04:49:27 +0000 (13:49 +0900)]
ARM: fix build warning for unw usage
The warning is coming from libunwind-arm, not coreclr.
Libunwind-arm uses SP/PC registers along with other registers,
which clang complains.
fix #4259
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Sejong Oh [Tue, 12 Apr 2016 00:19:29 +0000 (17:19 -0700)]
Merge pull request #4101 from sejongoh/detect_ldsfld_access_non_static_field
Check if LDSFLD accesses non-static field
Mike McLaughlin [Tue, 12 Apr 2016 00:06:44 +0000 (17:06 -0700)]
Merge pull request #4277 from mikem8361/rpath
Unable to debug coreclr apps on Debian 8.2 (Issue #4263)
Mike McLaughlin [Mon, 11 Apr 2016 22:37:42 +0000 (15:37 -0700)]
Unable to debug coreclr apps on Debian 8.2 (Issue #4263)
Add set(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE) to dbi and sos cmake files.
Mike McLaughlin [Mon, 11 Apr 2016 23:55:44 +0000 (16:55 -0700)]
Merge pull request #4218 from mikem8361/symbols
Add symbol packages for coreclr runtime.
Andy Ayers [Mon, 11 Apr 2016 23:52:45 +0000 (16:52 -0700)]
Merge pull request #4272 from AndyAyersMS/FixSpectralNorm
Fix validation of spectralnorm under xunit-performance
Sean Gillespie [Mon, 11 Apr 2016 22:58:49 +0000 (15:58 -0700)]
Merge pull request #4113 from swgillespie/long_running_gc
Create Long-running GC test job for the CI
Aditya Mandaleeka [Mon, 11 Apr 2016 22:24:11 +0000 (15:24 -0700)]
Merge pull request #4157 from chuckries/master
Fix error return in getPath
Maoni Stephens [Mon, 11 Apr 2016 22:22:15 +0000 (15:22 -0700)]
Merge pull request #4266 from janvorli/fix-brick-table-issue
Fix brick table issue on Unix
Yi Zhang (CLR) [Mon, 11 Apr 2016 22:15:28 +0000 (15:15 -0700)]
Merge pull request #4261 from yizhang82/byvalarray_fix
Fix ByValArray support.
ByValArray marshalling is implemented actually in OleVariant.cpp, which implements both regular array marshalling and variant marshalling). Regular array marshalling code should be supported in x-plat but it was incorrectly #ifdef-ed out. Fix by only #ifdef the COM interop VARIANT part.
Fix #4262 and #4194
Mike McLaughlin [Tue, 5 Apr 2016 00:52:15 +0000 (17:52 -0700)]
Add symbol packages for coreclr runtime.
Depends on the new buildtools symbol support.
Update build tools version containing the new symbol file support.
Mike McLaughlin [Mon, 11 Apr 2016 21:54:33 +0000 (14:54 -0700)]
Merge remote-tracking branch 'upstream/master'
Andy Ayers [Mon, 11 Apr 2016 21:21:56 +0000 (14:21 -0700)]
Fix validation of spectralnorm under xunit-performance
The valiation code wasn't correctly for the iteration strategy
used by xunit-performance.
Closes #4270.
Michelle McDaniel [Mon, 11 Apr 2016 20:21:45 +0000 (13:21 -0700)]
Merge pull request #4269 from adiaaida/longSub
Add support for x86 long subtract operator
Bruce Forstall [Mon, 11 Apr 2016 19:23:33 +0000 (12:23 -0700)]
Merge pull request #4206 from BruceForstall/RyujitX86
Clean up JIT build rules
Bruce Forstall [Mon, 11 Apr 2016 19:23:02 +0000 (12:23 -0700)]
Merge pull request #4221 from BruceForstall/Cleanup1
Cleanup: be consistent about compCalleeFPRegsSavedMask #ifdefs
Bruce Forstall [Mon, 11 Apr 2016 19:22:46 +0000 (12:22 -0700)]
Merge pull request #4239 from BruceForstall/Cleanup2
Cleanup: remove getFramePointerReg()
Bruce Forstall [Mon, 11 Apr 2016 19:22:25 +0000 (12:22 -0700)]
Merge pull request #4242 from BruceForstall/Cleanup3
Add genEstablishFramePointer() to enapsulate frame pointer creation
Bruce Forstall [Mon, 11 Apr 2016 19:21:56 +0000 (12:21 -0700)]
Merge pull request #4243 from BruceForstall/Cleanup4
Minor JIT changes
Sean Gillespie [Mon, 11 Apr 2016 19:02:07 +0000 (12:02 -0700)]
Add longgc to a new assert
Sean Gillespie [Mon, 11 Apr 2016 18:52:16 +0000 (11:52 -0700)]
Add new trigger phrases to documentation
Sean Gillespie [Fri, 11 Mar 2016 23:48:56 +0000 (15:48 -0800)]
Create Long-running GC test job for the CI
Sejong Oh [Wed, 6 Apr 2016 00:52:14 +0000 (17:52 -0700)]
Fix JIT crash with static function accessing non-static field
The IL below is invalid since the static function acceses the non-static
field. On Desktop CRL, JIT throws a verification exception. However, CoreCLR
doesn't support verification and JIT crashes. This fix makes JIT throw a
invalid program exception if verification is disabled.
.field int32 i
.method static int32 f()
{
ldsfld int32 Test::i
ret
}
The test also expects InvalidProgramException instead of
VerificationException.
Russ Keldorph [Mon, 11 Apr 2016 18:11:35 +0000 (11:11 -0700)]
Merge pull request #4268 from RussKeldorph/ignore
Add missing arch-specifc strings in .gitignore
Michelle McDaniel [Mon, 11 Apr 2016 17:24:41 +0000 (10:24 -0700)]
Add support for x86 long subtract operator
With #3296, we have all the support for subtracting longs on x86. Subtract
can use the same logic as addition for longs.
Fixes #4189.
Yi Zhang (CLR) [Mon, 11 Apr 2016 06:59:35 +0000 (23:59 -0700)]
ByValArray marshaling support is implemented in OleVariant.cpp (which actually implements both regular array marshalling and variant marshalling) and is incorrectly #ifdef-ed out under x-plat. Fix by only #ifdef the COM interop VARIANT part.
Re-enable ByValArray test as well.
Russ Keldorph [Wed, 30 Mar 2016 18:16:40 +0000 (11:16 -0700)]
Add missing arch-specifc strings in .gitignore
I would prefer that the test build not drop cruft outside of designated
folders like bin, but unless/until that happens we should at least make
the architectures' builds consistent.
Lubomir Litchev [Mon, 11 Apr 2016 14:58:49 +0000 (07:58 -0700)]
Merge pull request #4240 from LLITCHEV/Issue4147
Add test for issue 4115.
Andy Ayers [Mon, 11 Apr 2016 14:44:21 +0000 (07:44 -0700)]
Merge pull request #4245 from AndyAyersMS/ModelPolicy
Inliner: initial version of a model-based policy
Jan Vorlicek [Mon, 11 Apr 2016 11:42:07 +0000 (13:42 +0200)]
Fix brick table issue on Unix
There is a problem with Clang compiling a loop that sets a range of brick
table entries that are "shorts" as a memset. That causes it to be written
by bytes in some cases on OSX (and it is a mere chance that the memset on
Linux is implemented so that it doesn't use byte access).
This was causing corruption of the brick table on OSX.
The fix is to mark the pointer that iterates over the brick table as volatile
to prevent the compiler from using the memset.
Jan Kotas [Mon, 11 Apr 2016 06:03:19 +0000 (20:03 -1000)]
Merge pull request #3990 from myungjoo/testing/fix3856
Fix Linux-ARM Broken Stack w/ ThePreStub
Jan Kotas [Mon, 11 Apr 2016 06:00:34 +0000 (20:00 -1000)]
Merge pull request #4257 from jkotas/noexecstack
Pass noexecstack option to the assembler on Linux
Lubomir Litchev [Sun, 10 Apr 2016 20:46:01 +0000 (13:46 -0700)]
Add a test for Issue 4147.
This checkin adds a test for Issue 4147.
Yi Zhang (CLR) [Sun, 10 Apr 2016 04:59:35 +0000 (21:59 -0700)]
Merge pull request #4250 from yizhang82/nativevariant_fix
Fix GetObjectForNativeVariant test issue. It should roundtrip the actual object instead of IntPtr. Also add proper variant clean up code.
Fix #4192.
Jan Kotas [Sun, 10 Apr 2016 04:15:42 +0000 (18:15 -1000)]
Pass noexecstack option to the assembler on Linux
Jan Kotas [Sun, 10 Apr 2016 01:51:18 +0000 (15:51 -1000)]
Merge pull request #4253 from jamesqo/faulty-trues
Fix a couple of erroneous assert(trues)
Yi Zhang (CLR) [Sun, 10 Apr 2016 01:13:51 +0000 (18:13 -0700)]
Merge pull request #4256 from yizhang82/chararray_fix
Change Marshal.SizeOf to sizeof to calculate buffer size because Marshal.Copy copies managed contents, while Marshal.SizeOf gives native size. Fix #4254
Yi Zhang (CLR) [Sat, 9 Apr 2016 20:18:36 +0000 (13:18 -0700)]
Change Marshal.SizeOf to sizeof because Marshal.Copy copies managed contents and does not do marshalling.
Yi Zhang (CLR) [Sat, 9 Apr 2016 19:44:17 +0000 (12:44 -0700)]
Merge pull request #4249 from yizhang82/lptstr_fix
Fix LPTSTRTest failure - it has a incorrect constant probably due to bad merge. Fix #4197
Yi Zhang (CLR) [Sat, 9 Apr 2016 06:22:51 +0000 (23:22 -0700)]
Fix GetObjectForNativeVariant test issue. It should roundtrip the actual object instead of IntPtr. Also add proper variant clean up code.
NOTE that I had to keep Marshal.IUnknownForObject call to force COM initialization.
Mike McLaughlin [Sat, 9 Apr 2016 18:26:05 +0000 (11:26 -0700)]
Merge remote-tracking branch 'upstream/master'
Yi Zhang (CLR) [Sat, 9 Apr 2016 02:39:48 +0000 (19:39 -0700)]
Fix LPTSTRTest failure - it has a incorrect constant probably due to bad porting. Also remove StringMarshal tests from issues.targets
James Ko [Sat, 9 Apr 2016 14:48:02 +0000 (10:48 -0400)]
Fix a couple of erroneous assert(trues)
Matt Ellis [Sat, 9 Apr 2016 06:08:54 +0000 (23:08 -0700)]
Merge pull request #4248 from dotnet/revert-4199-struct16-abi
Revert "ARM64 Work Item 3817, 3524 - Struct16 decomposition"
Jan Kotas [Sat, 9 Apr 2016 04:34:40 +0000 (18:34 -1000)]
Revert "ARM64 Work Item 3817, 3524 - Struct16 decomposition"
Rama krishnan Raghupathy [Sat, 9 Apr 2016 04:33:40 +0000 (21:33 -0700)]
Merge pull request #4162 from ramarag/ResolveWorkerChainLookupAsmStub
[Arm64]:Fixing the Logic of ResolveWorkerChainLookupAsmStub for VSD
Michal Strehovský [Sat, 9 Apr 2016 02:10:55 +0000 (19:10 -0700)]
Merge pull request #4202 from MichalStrehovsky/applicationException
Remove usage of ApplicationException in tests
Rama Krishnan Raghupathy [Fri, 8 Apr 2016 02:40:30 +0000 (19:40 -0700)]
[Arm64]:Fixing the Logic of ResolveWorkerChainLookupAsmStub
Andy Ayers [Fri, 8 Apr 2016 02:43:09 +0000 (19:43 -0700)]
Inliner: initial version of a model-based policy
Add a model-based size predictor to the `DiscretionaryPolicy` and
dump its data along with observations. This can be used to assess
the performance of the model. Currently using a linear model that
can explain about 55% of the variability in code size impact for
mscorlib. Whether this holds up for other situations is still to
be determined.
Create a `ModelPolicy` that relies on this code size model to make
inlining decisions. This is very much a work in progress as the code
size models are still not well vetted and there is no real code
quality model yet.
Sean Gillespie [Sat, 9 Apr 2016 00:24:08 +0000 (17:24 -0700)]
Merge pull request #4207 from swgillespie/437657
Remove a test that doesn't provide much value, fails in parallel test…
Brian Sullivan [Fri, 8 Apr 2016 23:59:18 +0000 (16:59 -0700)]
Merge pull request #4199 from briansull/struct16-abi
ARM64 Work Item 3817, 3524 - Struct16 decomposition
Bruce Forstall [Fri, 8 Apr 2016 23:20:31 +0000 (16:20 -0700)]
Minor JIT changes
Add a useful assert about SP to FP offsets.
Add "const" to a few member functions.
Bruce Forstall [Fri, 8 Apr 2016 23:15:29 +0000 (16:15 -0700)]
Add genEstablishFramePointer() to enapsulate frame pointer creation
Bruce Forstall [Fri, 8 Apr 2016 23:06:22 +0000 (16:06 -0700)]
Cleanup: replace getFramePointerReg() with preexisting genFramePointerReg()
Bruce Forstall [Fri, 8 Apr 2016 22:38:51 +0000 (15:38 -0700)]
Cleanup: be consistent about compCalleeFPRegsSavedMask #ifdefs
Mike McLaughlin [Fri, 8 Apr 2016 22:28:04 +0000 (15:28 -0700)]
Merge remote-tracking branch 'upstream/master'
Mike McLaughlin [Fri, 8 Apr 2016 22:27:29 +0000 (15:27 -0700)]
Merge pull request #4205 from mikem8361/sosfx2
Better sos message for runtime not initialized
Mike McLaughlin [Fri, 8 Apr 2016 22:23:43 +0000 (15:23 -0700)]
Merge remote-tracking branch 'upstream/master'
Pat Gavlin [Fri, 8 Apr 2016 22:20:11 +0000 (15:20 -0700)]
Merge pull request #4163 from pgavlin/GCInfoQSort
Replace CQuickSort with qsort in GC info encoders.
Brian Sullivan [Fri, 8 Apr 2016 19:08:24 +0000 (12:08 -0700)]
ARM64 Work Item 3817, 3524 - Struct16 decomposition
Changes to support passing of MultiReg structs using GT_LISTs
Optional support for struct promotion for multireg structs:
To enable set FEATURE_MULTIREG_STRUCT_PROMOTE to 1
Morphs the 16-byte structs at the end of fgMorphArgs
Careful refactoring to avoid changes to UNIX_AMD64 code
Covers all of the 16-byte struct expansion cases in fgMorph
Added function header comments
Passing the tests for Arm64
No AsmDiffs for non-Arm64 targets.
Codegen uses Contained nodes for PUTARG_STK 16-byte stack args
Created a genPutArgStk method for Arm64
Sean Gillespie [Fri, 8 Apr 2016 21:43:31 +0000 (14:43 -0700)]
Remove a test that doesn't provide much value, fails in parallel test environments, and p/invokes to kernel32.dll
Matt Ellis [Fri, 8 Apr 2016 21:03:49 +0000 (14:03 -0700)]
Merge pull request #4198 from dotnet-bot/from-tfs
Merge changes from TFS
Matt Mitchell [Fri, 8 Apr 2016 20:56:30 +0000 (13:56 -0700)]
Merge pull request #4203 from mmitche/remove-unused
Remove unecessary jobs
Mike McLaughlin [Fri, 8 Apr 2016 20:45:28 +0000 (13:45 -0700)]
Better sos message for runtime not initialized
Also fixed the corerun sos command checked build problem.
Matt Mitchell [Fri, 8 Apr 2016 20:35:34 +0000 (13:35 -0700)]
Remove unecessary jobs
The jobs that involve multiple build stages (like most things xplat) always use the native bits from the default scenario. Remove builds that are unused
Bruce Forstall [Fri, 8 Apr 2016 18:29:56 +0000 (11:29 -0700)]
Clean up JIT build rules
Add SIMD files to x86 build (they aren't used, yet).
Separate out the LEGACY_BACKEND files, to be explicit about them.
Make protojit and standalone build rules more similar.
Michal Strehovský [Fri, 8 Apr 2016 18:51:23 +0000 (11:51 -0700)]
Remove usage of ApplicationException in tests
ApplicationException is not in the .NET Core profile. Most of these
tests only use it to crash the test with an unhandled exception and it
doesn't matter what exception type it is.
Matt Ellis [Fri, 8 Apr 2016 18:33:47 +0000 (11:33 -0700)]
Add missing .gitmirrorall file
[tfs-changeset: 1594511]
Tijoy Tom Kalathiparambil [Fri, 8 Apr 2016 17:50:34 +0000 (10:50 -0700)]
Merge branch 'botaberg-port_interop_tests'
Tijoy Tom Kalathiparambil [Fri, 8 Apr 2016 17:50:00 +0000 (10:50 -0700)]
Merge branch 'port_interop_tests' of https://github.com/botaberg/coreclr into botaberg-port_interop_tests
tijoytom [Fri, 8 Apr 2016 17:43:56 +0000 (10:43 -0700)]
Merge pull request #4164 from yizhang82/lpstr_test_fix
Fix LPSTR test failure due to incorrect implementation of strncpy_s.
tijoytom [Fri, 8 Apr 2016 17:28:43 +0000 (10:28 -0700)]
Merge pull request #4160 from tijoytom/master
Windows specific Marshal APIs test.
Pat Gavlin [Fri, 8 Apr 2016 02:19:53 +0000 (19:19 -0700)]
Replace CQuickSort with qsort in GC info encoders.
This removes another utilcode dependency from the GC info encoders.
Davis Goodin [Fri, 8 Apr 2016 15:22:12 +0000 (10:22 -0500)]
Merge pull request #3642 from dagood/remove-hardcoded-versions
Remove hardcoded versions from runtests.proj
Jan Kotas [Fri, 8 Apr 2016 14:01:03 +0000 (04:01 -1000)]
Merge pull request #4165 from myungjoo/trivialfix/doc1
Typo: incorrect pathname in documentation
MyungJoo Ham [Fri, 8 Apr 2016 06:19:06 +0000 (15:19 +0900)]
Typo: incorrect pathname in documentation
build-rootfs.sh is at ./cross/, not ./ .
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Yi Zhang (CLR) [Fri, 8 Apr 2016 05:12:06 +0000 (22:12 -0700)]
Fix LPSTR test failure due to incorrect implementation of strncpy_s. It was implemented using snprintf and didn't account for the null terminator behavioral difference. Test is now passing after the fix. We should see if we can always use xplat helpers in all platforms for easier debugging.
Michal Strehovský [Fri, 8 Apr 2016 05:07:10 +0000 (22:07 -0700)]
Merge pull request #4155 from MichalStrehovsky/debuggableAttribute
Remove mscorlib 1.x strong references from tests
Jan Kotas [Fri, 8 Apr 2016 03:56:04 +0000 (17:56 -1000)]
Merge pull request #4161 from yizhang82/remove-marshal
Remove Marshal.Read/Write (AsAny object) overload from CoreCLR.
Michal Strehovský [Fri, 8 Apr 2016 03:39:01 +0000 (20:39 -0700)]
Merge pull request #4134 from MichalStrehovsky/junkAttributes
Delete junk attributes in tests
Yi Zhang (CLR) [Thu, 7 Apr 2016 23:04:23 +0000 (16:04 -0700)]
Remove Marshal.Read/Write (AsAny object) overload from CoreCLR. I don't expect anyone to use these overloads and it doesn't make sense to keep them. Their semantics are rather convoluted and most likely not what you might expect.
Tijoy Tom Kalathiparambil [Fri, 8 Apr 2016 00:17:43 +0000 (17:17 -0700)]
Windows specific Marshal APIs test.
Kyungwoo Lee [Fri, 8 Apr 2016 00:03:21 +0000 (17:03 -0700)]
Merge pull request #4159 from kyulee1/update3
ARM64: Update email notification3 -- testing
Kyungwoo Lee [Fri, 8 Apr 2016 00:01:01 +0000 (17:01 -0700)]
ARM64: Update email notification3 -- testing
William Godbe [Thu, 7 Apr 2016 23:38:33 +0000 (16:38 -0700)]
Merge pull request #4125 from wtgodbe/errLog
Add error logging to 4 PAL tests that fail periodically on OSX
Chuck Ries [Thu, 7 Apr 2016 23:26:57 +0000 (16:26 -0700)]
Fix error return in getPath
The call to PathCharString.Set returns true on succes, so this code path
was returning false if it succeeded in setting lpPathFileName to
lpFileNameString. It looks like this is just a holdover from the way
this code used to be written.
William Godbe [Thu, 7 Apr 2016 23:23:35 +0000 (16:23 -0700)]
Merge pull request #4149 from wtgodbe/triggerPhrases
Add documentation for CI Trigger Phrases
wtgodbe [Thu, 7 Apr 2016 19:50:14 +0000 (12:50 -0700)]
Add documentation for CI Trigger Phrases
Matt Ellis [Thu, 7 Apr 2016 23:09:17 +0000 (16:09 -0700)]
Merge pull request #4131 from dotnet/Petermarcu-patch-2
Updating Readme to point to .NET Core SDK
Kyungwoo Lee [Thu, 7 Apr 2016 23:07:47 +0000 (16:07 -0700)]
Merge pull request #4153 from kyulee1/update2
ARM64: Update email notification2
Kyungwoo Lee [Thu, 7 Apr 2016 22:00:59 +0000 (15:00 -0700)]
ARM64: Update email notification2
Only for arm64 group (both PR/Push) -- testing.
Andy Ayers [Thu, 7 Apr 2016 22:44:21 +0000 (15:44 -0700)]
Merge pull request #4148 from AndyAyersMS/InlineOpcodeBins
Inliner: update DiscretionaryPolicy to look at opcodes and arg info
Michal Strehovský [Thu, 7 Apr 2016 22:28:04 +0000 (15:28 -0700)]
Remove mscorlib 1.x strong references from tests
Referencing mscorlib 1.x forces ILASM to emit a reference to the legacy
DebuggableAttribute constructor (the one that takes bools). That
constructor is not in the .NET Core profile and not all core base class
libraries will have it.
See src/ilasm/asmman.cpp#L389.
Deepak Shankargouda [Thu, 7 Apr 2016 22:22:00 +0000 (15:22 -0700)]
Fixing failures of CscBench, Serialization and Deserialization perf tests (#4151)
Kyungwoo Lee [Thu, 7 Apr 2016 21:44:08 +0000 (14:44 -0700)]
Merge pull request #4152 from kyulee1/updateemail
ARM64: Update email notification
Pat Gavlin [Thu, 7 Apr 2016 21:40:04 +0000 (14:40 -0700)]
Merge pull request #4037 from pgavlin/SimplerHashTable
Remove non-portable dependencies from SimplerHashTable.
Andy Ayers [Thu, 31 Mar 2016 23:29:09 +0000 (16:29 -0700)]
Inliner: update DiscretionaryPolicy to look at opcodes and arg info
Have the `DiscretionaryPolicy` do some simple opcode histogramming
to try and provide better observations for code size estimation.
Likewise, look at the types and sizes of arguments and report those.
Kyungwoo Lee [Thu, 7 Apr 2016 20:23:58 +0000 (13:23 -0700)]
ARM64: Update email notification
Only sending email for Windows run when push occurs.
Skip sending email for private run (PR).
Jan Vorlicek [Thu, 7 Apr 2016 20:16:53 +0000 (22:16 +0200)]
Merge pull request #4106 from janvorli/add-hosting-api-header
Add header file for the hosting API
Kyungwoo Lee [Thu, 7 Apr 2016 18:19:14 +0000 (11:19 -0700)]
Merge pull request #4144 from kyulee1/email
ARM64: Add email notification for failing job