platform/upstream/efl.git
4 years agoevas json: up-to-date vector-tree logging.
Hermet Park [Wed, 27 Nov 2019 08:51:42 +0000 (17:51 +0900)]
evas json: up-to-date vector-tree logging.

4 years agogesture_manager: Changed function param to reduce internal function calls.
Woochanlee [Wed, 27 Nov 2019 05:24:01 +0000 (14:24 +0900)]
gesture_manager: Changed function param to reduce internal function calls.

Summary:
The filter_event function calling a lot of times when it runs.

This can help performance by reducing the number of calls to the efl_data_scope_get() function.

Reviewers: Hermet, smohanty, bu5hm4n

Reviewed By: Hermet

Subscribers: zmike, bu5hm4n, q66, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10437

4 years agoEfl.Text.Attribute_Factory
Ali Alzyod [Wed, 27 Nov 2019 04:04:31 +0000 (13:04 +0900)]
Efl.Text.Attribute_Factory

Summary:
Implementation of new Efl.Text.Attribute_Factory class which replace the annotation interface.

Currently, we have two public methods:

```
void efl_text_attribute_factory_attribute_insert(const Efl_Text_Cursor *start, const Efl_Text_Cursor *end, const char *format)
unsigned int efl_text_attribute_factory_attribute_clear(const Efl_Text_Cursor *start, const Efl_Text_Cursor *end);
```

Other methods will be internal methods, for the time being, we will redesign internal methods

Reviewers: woohyun, tasn, segfaultxavi, bu5hm4n, zmike

Subscribers: zmike, q66, cedric, segfaultxavi, bu5hm4n, a.srour, #committers, #reviewers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10646

4 years agoworkaround: disable efl_access on csharp 33/218733/1
Jaehyun Cho [Wed, 27 Nov 2019 10:50:31 +0000 (19:50 +0900)]
workaround: disable efl_access on csharp

Change-Id: I01c97b045b3bf7991ece00afc049e4dd2b4bf193

4 years agomono: disable efl_access on csharp 20/216520/2
Yeongjong Lee [Mon, 28 Oct 2019 01:48:29 +0000 (10:48 +0900)]
mono: disable efl_access on csharp

Change-Id: Iccbb6f3cfd6c8337f76b059cff459617b2f4f700

4 years agoefl_mono: disable focus manager on csharp 89/208089/10
Yeongjong Lee [Fri, 14 Jun 2019 01:20:54 +0000 (10:20 +0900)]
efl_mono: disable focus manager on csharp

@tizne_fix

Change-Id: Ifc6df8586ff55c88b897843354ef78f411c07baf

4 years agoelm_focus: implement legay focus for Efl.Ui.Widgets 27/194627/10
Yeongjong Lee [Thu, 1 Nov 2018 02:06:54 +0000 (11:06 +0900)]
elm_focus: implement legay focus for Efl.Ui.Widgets

@tizne_fix

Change-Id: If38a0ccc35e3d7211b52068f20cb7189866f0b5f

4 years agoRevert "elm_panel: disable efl_ui_focus_layer functions" 09/216509/2
Yeongjong Lee [Sun, 27 Oct 2019 23:38:28 +0000 (08:38 +0900)]
Revert "elm_panel: disable efl_ui_focus_layer functions"

This reverts commit e1b29036cac3d6da98e0cc79c9e9ff8ad8ddce3c.

Change-Id: I489500c1ecbff5eb6aec905427e64bb7054433d9

4 years agoRevert "Revert "elm_widget: disable focus manager in tizen"" 08/216508/2
Yeongjong Lee [Sun, 27 Oct 2019 23:38:08 +0000 (08:38 +0900)]
Revert "Revert "elm_widget: disable focus manager in tizen""

This reverts commit 9bde69ee8e54f3f9ef80ce1e60e13187282654f8.

Change-Id: I06ff90c0c267d2baf533df29c12c9c56745a3afa

4 years agocsharp: CA1717 - Add [Flags] for enums accepted/tizen/unified/20191127.141709 submit/tizen/20191126.214239
Lauro Moura [Tue, 26 Nov 2019 14:56:57 +0000 (11:56 -0300)]
csharp: CA1717 - Add [Flags] for enums

Summary:
Using the naive approach of checking if the name ends with `Flags`.

Ref T8411

Depends on D10708

Reviewers: brunobelo, segfaultxavi, felipealmeida, YOhoho

Reviewed By: felipealmeida

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8411

Differential Revision: https://phab.enlightenment.org/D10709

4 years agocsharp: Iterate more in GC-dependent test
Lauro Moura [Tue, 26 Nov 2019 14:56:51 +0000 (11:56 -0300)]
csharp: Iterate more in GC-dependent test

Summary:
The inheritance test depends on the objects being actively destroyed.
Currently this happens in a two step process, where first the C#
object is collected from the GC. As this happens in a separate thread,
we schedule a callback to run in the main loop to actually unref the
EO object.

This commit adds more iterations to make sure the EO of the parent is
unref'd and releases the child.

This should be the last C#-related CI test failure

Ref T8313

Reviewers: stefan_schmidt, brunobelo, felipealmeida

Reviewed By: felipealmeida

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8313

Differential Revision: https://phab.enlightenment.org/D10612

4 years agopyolian: Add helper functions for simple scripts
Lauro Moura [Tue, 26 Nov 2019 14:56:41 +0000 (11:56 -0300)]
pyolian: Add helper functions for simple scripts

Summary:
These two functions encapsulate some code that commonly is repeated
through pyolian scripts.

With these, a minimal example (provided `src/scripts/pyolian` is in
the PYTHONPATH) could be done with:

```
import os

from pyolian import eolian

SCAN_FOLDER = os.path.join(eolian.in_tree_src_dir(), 'src', 'lib')
eolian_db = eolian.parse_folders(SCAN_FOLDER)

for cls in eolian_db.classes:
    print(cls)
```

Reviewers: segfaultxavi, DaveMDS, felipealmeida

Reviewed By: felipealmeida

Subscribers: cedric, #reviewers, #committers, felipealmeida, brunobelo

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10589

4 years agopyolian: Add a method to get the hierarchy of extensions
Lauro Moura [Tue, 26 Nov 2019 14:56:31 +0000 (11:56 -0300)]
pyolian: Add a method to get the hierarchy of extensions

Summary:
To be used by the test generator

Depends on D10420

Test Plan: test in the diff

Reviewers: DaveMDS, herb, segfaultxavi, felipealmeida

Reviewed By: felipealmeida

Subscribers: cedric, brunobelo, #reviewers, felipealmeida, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10421

4 years agopyolian: full_inherit must recurse parent too
Lauro Moura [Tue, 26 Nov 2019 14:55:01 +0000 (11:55 -0300)]
pyolian: full_inherit must recurse parent too

Test Plan: run tests

Reviewers: segfaultxavi, herb, DaveMDS, felipealmeida

Reviewed By: felipealmeida

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10420

4 years agocsharp: Add more since tags to members
Lauro Moura [Tue, 26 Nov 2019 14:13:47 +0000 (11:13 -0300)]
csharp: Add more since tags to members

Summary:
- Class constructors and other members
- Aliases fields

ref T8359

Reviewers: felipealmeida, segfaultxavi, brunobelo, woohyun

Reviewed By: felipealmeida

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8359

Differential Revision: https://phab.enlightenment.org/D10419

4 years agoecore_timer: add NULL checking for timer data.
Hosang Kim [Fri, 22 Nov 2019 09:16:47 +0000 (09:16 +0000)]
ecore_timer: add NULL checking for timer data.

When timer is not created, a crash occurs.
For example, when user create ecore timer in the pthread..
Of course this is not the correct usage, but printing ERR message is enough.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10714

4 years agoeo: add missing move tag
Yeongjong Lee [Fri, 22 Nov 2019 07:29:27 +0000 (07:29 +0000)]
eo: add missing move tag

`efl_access_action_actions_get`
the list is created by `eina_list_append`

`efl_ui_format_values_set`
the accessor is freed in that function.
`efl_ui_format_values_get`
The accessor is created by `eina_inarray_accessor_new`

`efl_core_command_line_command_access`
The accessor is created by `eina_array_accessor_new`

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10720

4 years agoeo: add move tag to iterator
Yeongjong Lee [Fri, 22 Nov 2019 06:13:25 +0000 (06:13 +0000)]
eo: add move tag to iterator

It is impossible to reuse iterator after `EINA_ITERATOR_FOREACH`(`eina_iterator_next`).

E.g.
```
eina_init();

eina_file_dir_list("/home/", EINA_FALSE, _print_cb, NULL);

it = eina_file_ls("/home/");
EINA_ITERATOR_FOREACH(it, f_name)
  {
     printf("%s\n", f_name);
     eina_stringshare_del(f_name);
  }
EINA_ITERATOR_FOREACH(it, f_name)
  {
     printf("Again %s\n", f_name);
     eina_stringshare_del(f_name);
  }
eina_iterator_free(it);
```
`Agian ...` is never printed.

Therefore, iterator always need `@move` tag to avoid unexpected behavior without
any error message.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10719

4 years agoedje_calc: Creation macro that perform edje calc, regardless of the edje size.
Woochanlee [Tue, 26 Nov 2019 04:57:16 +0000 (13:57 +0900)]
edje_calc: Creation macro that perform edje calc, regardless of the edje size.

Summary: edje_recalc_do() needs to be executed regardless of the size of edje in order to deliver edje properties for the API that the user calls.

Reviewers: cedric, Hermet, Jaehyun_Cho, smohanty

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10724

4 years agovg_common_json: Fix a missing of free after using
JunsuChoi [Tue, 26 Nov 2019 04:50:00 +0000 (13:50 +0900)]
vg_common_json: Fix a missing of free after using

Summary: iterator itr will leak by going out the function widthout freeing.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10736

4 years agoEfl.Canvas.Image: Add skeleton code Efl.Gfx.Frame_Controller.sector
JunsuChoi [Tue, 26 Nov 2019 01:54:37 +0000 (10:54 +0900)]
Efl.Canvas.Image: Add skeleton code Efl.Gfx.Frame_Controller.sector

Summary:
Sector is a property with start, end frame and sector name information
that can be used when playing a specific section.
Sector play is not supported for Efl.Canvas.Image yet.
So we add skeleton code with comments.
This is also for full implements of the Efl.Gfx.Frame_Controller interface.

Test Plan: N/A

Reviewers: Hermet, bu5hm4n

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10718

4 years agoRevert "elm_multibuttonentry: delete ELM_LAYOUT_MIXIN" 19/218619/1
Woochanlee [Tue, 26 Nov 2019 05:58:26 +0000 (14:58 +0900)]
Revert "elm_multibuttonentry: delete ELM_LAYOUT_MIXIN"

This reverts commit c046a2ffd4754a84c3eca3c0b60e2c5be12c31e5.

Change-Id: I625bdecbfeab83a6cf0da33402337b33f8babf46

4 years agoefl_ui_multi_selectable: clean this up accepted/tizen/unified/20191126.124656 submit/tizen/20191125.210615
Marcel Hollerbach [Wed, 20 Nov 2019 12:36:02 +0000 (12:36 +0000)]
efl_ui_multi_selectable: clean this up

this commit merges common functions from efl_ui_multi_selectable and
efl_ui_multi_selectable_async. Additionally, the two different aspects
of accessing the elements in a multi_selectable widget (numerical or
object based) are now abstracted into interfaces called range_numeric and
range_object. numeric APIs are also prefixed with id's, so its possible
for one widget to implement both (if there will ever be the demand to do
that in future).

The main reason for this split is:
- there is no good common path between mvvm based multi_selectable and
object based multi_Selectable, so there is no way that both sides would
benefit, without the other one suffering.
- If we find later on the demand to implement both on one widget, we now
can fully do that
- Common API is available for both types, so its less API and less
confusion for the API user.

ref T7871
ref T8265

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10675

4 years agotheme: Delete max that seems not right.
Woochanlee [Mon, 25 Nov 2019 10:10:41 +0000 (19:10 +0900)]
theme: Delete max that seems not right.

Summary:
It prevents popup edje resize.
So not we cant see slider indicator.
T8483

before that edje calc in render time.
But now we dont calc for no size edje.

Limit max 0 0 is really looks weird.

Test Plan: elementary_test->slider ->check indicator.

Reviewers: eagleeye, Hermet, cedric, smohanty, Jaehyun_Cho

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8483

Differential Revision: https://phab.enlightenment.org/D10721

4 years agoEfl.Canvas.Vg.Container : Initialize mask buffer for SUB, INS composition.
JunsuChoi [Mon, 25 Nov 2019 10:04:30 +0000 (19:04 +0900)]
Efl.Canvas.Vg.Container : Initialize mask buffer for SUB, INS composition.

Summary:
   If composite method is substract or intersect, buffer needs initialize.

Test Plan: N/A

Reviewers: Hermet, kimcinoo, smohanty

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10732

4 years agovector lottie: Set visibility vg node
JunsuChoi [Mon, 25 Nov 2019 04:39:01 +0000 (13:39 +0900)]
vector lottie: Set visibility vg node

Summary:
All nodes reset their visibility when they are reused.
Therefore, visibility must be set true if mVisibile is true.

Test Plan: N/A

Reviewers: Hermet, kimcinoo, smohanty

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10731

Change-Id: I5531fff3ad43c4529b1070f6af3092ae5952a628

4 years agoevas vector: initialize data member properly.
Hermet Park [Mon, 25 Nov 2019 04:26:52 +0000 (13:26 +0900)]
evas vector: initialize data member properly.

user entry root should be initialized to null before accessing it.

in a certain scenario it could occur a crash with an invalid root data.

@fix

Change-Id: Ia2897f7897c131bbd8a9d206d8dd181678d7c460

4 years agoevas_textblock: cursor function null check at start
ali [Fri, 22 Nov 2019 18:32:01 +0000 (15:32 -0300)]
evas_textblock: cursor function null check at start

Reviewers: segfaultxavi, woohyun, lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10727

4 years agocsharp: Fix helper function
Lauro Moura [Fri, 22 Nov 2019 15:01:59 +0000 (12:01 -0300)]
csharp: Fix helper function

Summary: Was failing if the suffix were equal to the source string

Reviewers: felipealmeida, segfaultxavi, YOhoho, brunobelo

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10708

4 years agotext: Fix struct definition
Lauro Moura [Fri, 22 Nov 2019 14:43:22 +0000 (15:43 +0100)]
text: Fix struct definition

Summary:
Efl_Text_Cursor_Handle was being declared twice, confusing the C#
generator. This commits updates it to be singly defined in the
text_types eot file.

Reviewers: segfaultxavi, ali.alzyod

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10726

4 years agoefl_ui_internal_text_interactive: fix undefined symbol issue
WooHyun Jung [Fri, 22 Nov 2019 11:51:06 +0000 (12:51 +0100)]
efl_ui_internal_text_interactive: fix undefined symbol issue

Summary: This fixes an issue from d7352f4db41dc8975eaeb3f79dff326338a5a63c.

Reviewers: segfaultxavi, bu5hm4n

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10725

4 years agoEfl.Text.Cursor: Add missing documentation
Xavi Artigas [Fri, 22 Nov 2019 11:50:35 +0000 (12:50 +0100)]
Efl.Text.Cursor: Add missing documentation

This was breaking the C# bindings build.

4 years agoefl_ui_table: modify comparing logic
Wonki Kim [Fri, 22 Nov 2019 11:40:17 +0000 (12:40 +0100)]
efl_ui_table: modify comparing logic

Summary:
pad.h/v are integer varaibles, and also parameters h/v are too.
so that it is not needed to compare them like they are floating pointer.

Reviewers: bu5hm4n, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10722

4 years agodocs: Remove repeated words
Xavi Artigas [Fri, 22 Nov 2019 09:39:33 +0000 (10:39 +0100)]
docs: Remove repeated words

This had already been pointed out in the review.

4 years agoRevert "wl egl - use platform get display" 42/218542/2 accepted/tizen/unified/20191125.223325 submit/tizen/20191125.101119
Hermet Park [Mon, 25 Nov 2019 07:58:19 +0000 (16:58 +0900)]
Revert "wl egl - use platform get display"

This reverts commit cca636d3da1d67eb8dff50c753a8f7a5371801be.

Tizen doesn't support egl extension apis yet.

Change-Id: Ib253446a9e4b3d57082e4b2211d95e1c6a7fe69e

4 years agotextblock: fixes build error 06/218506/2
WooHyun Jung [Mon, 25 Nov 2019 03:03:21 +0000 (12:03 +0900)]
textblock: fixes build error

This patch fixes build errors came from below Cursor patch.
ccc44f88265868e892444ccd88a037cc57fd9c47

Change-Id: I3a504b600c3aaf38fb9214d4d9a366bdd4540447

4 years agoEfl.Text.Cursor 05/218505/2
Ali Alzyod [Fri, 22 Nov 2019 08:35:54 +0000 (17:35 +0900)]
Efl.Text.Cursor

Summary:
Implementation of new cursor text object.

This Patch Contains :
1- Remove Efl.Text.Cursor & Efl.Text_Markup_Interactive interfaces and replace them with one Class Efl.Text.Cursor
   => there are some modifications on cursor methods

2- Update all related classes to use Efl.Text.Cursor object instead of the old interfaces

3- If class uses Efl.Text_Cursor_Cursor (handle), mainly annotation it will stay as it is until we update other annotations into attribute_factory

4- Add main cursor property into efl.text.interactive

5- Add cursor_new method in efl.ui.text  (I think we may move it into efl.text.interactive interface)

There still some parts that need discussion: especially cursor movement functionality, I prefer to move function with Enum, instead of special function for each movement.

```
enum @beta Efl.Text.Cursor_Move_Type
{
   [[Text cursor movement types]]
   char_next,       [[Advances to the next character]]
   char_prev,       [[Advances to the previous character]]
   cluster_next,    [[Advances to the next grapheme cluster]]
   cluster_prev,    [[Advances to the previous grapheme cluster]]
   paragraph_start, [[Advances to the first character in this paragraph]]
   paragraph_end,   [[Advances to the last character in this paragraph]]
   word_start,      [[Advance to current word start]]
   word_end,        [[Advance to current word end]]
   line_start,      [[Advance to current line first character]]
   line_end,        [[Advance to current line last character]]
   paragraph_first, [[Advance to current paragraph first character]]
   paragraph_last,  [[Advance to current paragraph last character]]
   paragraph_next,  [[Advances to the start of the next text node]]
   paragraph_prev   [[Advances to the end of the previous text node]]
}
move {
         [[Move the cursor]]
         params {
            @in type: Efl.Text.Cursor_Move_Type; [[The type of movement]]
         }
         return: bool; [[True if actually moved]]
      }
```

or old way:
```
char_next {
         [[Advances to the next character]]
         // FIXME: Make the number of characters we moved by? Useful for all the other functions
         return: bool; [[True if actually moved]]
      }
      char_prev {
         [[Advances to the previous character]]
         return: bool; [[True if actually moved]]
      }

      char_delete {
         [[Deletes a single character from position pointed by given cursor.]]
      }

      cluster_next {
         [[Advances to the next grapheme cluster]]
         return: bool; [[True if actually moved]]
      }
      cluster_prev {
         [[Advances to the previous grapheme cluster]]
         return: bool; [[True if actually moved]]
      }

      // FIXME: paragraph_end is inconsistent with word_end. The one goes to the last character and the other after the last character.
      paragraph_start {
         [[Advances to the first character in this paragraph]]
         return: bool; [[True if actually moved]]
      }
      paragraph_end {
         [[Advances to the last character in this paragraph]]
         return: bool; [[True if actually moved]]
      }
      word_start {
         [[Advance to current word start]]
         return: bool; [[True if actually moved]]
      }
      word_end {
         [[Advance to current word end]]
         return: bool; [[True if actually moved]]
      }
      line_start {
         [[Advance to current line first character]]
         return: bool; [[True if actually moved]]
      }
      line_end {
          [[Advance to current line last character]]
         return: bool; [[True if actually moved]]
      }
      paragraph_first {
         [[Advance to current paragraph first character]]
         return: bool; [[True if actually moved]]
      }
      paragraph_last {
         [[Advance to current paragraph last character]]
         return: bool; [[True if actually moved]]
      }
      paragraph_next {
         [[Advances to the start of the next text node]]
         return: bool; [[True if actually moved]]
      }
      paragraph_prev {
         [[Advances to the end of the previous text node]]
         return: bool; [[True if actually moved]]
      }
```

Reviewers: woohyun, tasn, segfaultxavi

Reviewed By: woohyun

Subscribers: a.srour, bu5hm4n, segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10542

Change-Id: Ief0e4c1bb22e40f44dd17986264ca10ceb69d3a8

4 years agoRevert "Revert "Revert "evas_textblock: content fit feature""" 04/218504/2
WooHyun Jung [Mon, 25 Nov 2019 02:24:26 +0000 (11:24 +0900)]
Revert "Revert "Revert "evas_textblock: content fit feature"""

This reverts commit 0e0c6caf166b76f6b86c70c1bc558cdb48e5c2ea.

Change-Id: Ifac1ffb4f983edd49e743c6967a1fd2b44704618

4 years agoelementary widget: ++safety 31/218531/1
Hermet Park [Mon, 25 Nov 2019 06:33:11 +0000 (15:33 +0900)]
elementary widget: ++safety

null checking for invalid objects.

Change-Id: I2406f470666d8da24b0c993f7c17dfaad5e6bf9f

4 years agovector lottie: Set visibility vg node 11/218511/1
JunsuChoi [Mon, 25 Nov 2019 04:39:01 +0000 (13:39 +0900)]
vector lottie: Set visibility vg node

Summary:
All nodes reset their visibility when they are reused.
Therefore, visibility must be set true if mVisibile is true.

Test Plan: N/A

Reviewers: Hermet, kimcinoo, smohanty

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10731

Change-Id: I85b0b5f268d32f1e38b358b79686a41631811ba9

4 years agoevas vector: initialize data member properly. 09/218509/2
Hermet Park [Mon, 25 Nov 2019 04:26:52 +0000 (13:26 +0900)]
evas vector: initialize data member properly.

user entry root should be initialized to null before accessing it.

in a certain scenario it could occur a crash with an invalid root data.

@fix

Change-Id: Ieed18d04c05b86796d16d67cafec91dc2edc5806

4 years agoFix some minor security issues 30/218230/3
Oskar Chodowicz [Wed, 20 Nov 2019 12:00:24 +0000 (13:00 +0100)]
Fix some minor security issues

Change-Id: Ib733f54593666018eefdce3e73295b2cac8658ba

4 years agovector lottie: reset vg tree each frames. 26/218326/2
Hermet Park [Thu, 21 Nov 2019 08:37:33 +0000 (17:37 +0900)]
vector lottie: reset vg tree each frames.

Since vector tree nodes are reusing instead of reconstrucion,
We make it sure that dangling nodes invisible by clearing all nodes visibility.

Only valid nodes will be reset to visible while setting up in the progress.

Change-Id: Ifc1dc255f9fcefc6bafbd91149ea809bf9b85bdb

4 years agoefl_canvas_object_animation: fix possible invalid pointer submit/tizen/20191121.215843
Marcel Hollerbach [Thu, 21 Nov 2019 17:41:08 +0000 (18:41 +0100)]
efl_canvas_object_animation: fix possible invalid pointer

now if one of the event handlers calls animation_stop in a callback to
EFL_CANVAS_OBJECT_ANIMATION_EVENT_ANIMATION_PROGRESS_UPDATED, then
pd->in will be freeed. Which means, in the next event handler the
address taken by &pd->in->progress might be invalid, leading to a crash.

With this commit this is a address on the stack, which should fix this.

4 years agoefl_canvas_object_animation: make this all more safe
Marcel Hollerbach [Thu, 21 Nov 2019 11:22:41 +0000 (12:22 +0100)]
efl_canvas_object_animation: make this all more safe

Summary:
when a callback is called, the in pointer might be free'ed, we should be
more carefull with that.

fix CID1407682

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10713

4 years agoelm/hoversel: Recalculate items before box calculate.
JunsuChoi [Thu, 21 Nov 2019 10:49:01 +0000 (19:49 +0900)]
elm/hoversel: Recalculate items before box calculate.

Summary:
After the item is packed into the box,
the min of the item can be initialized with content_set working.
content_set calls parent_set and checks the theme when calling parent_set.
At that time, if theme is changed in the parent of layout using hoversel,
call theme_apply(efl_ui_layout) to make min value 0, 0.
This patch can avoid it.

Test Plan: N/A

Reviewers: YOhoho, Hermet, woohyun, zmike, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10712

Change-Id: I7bbd46ef8a63e5486f70f48c111f0693a07cb8b5

4 years agoeina_matrix: replace cosf by cos to gain more accuracy
Wonki Kim [Thu, 21 Nov 2019 08:43:42 +0000 (17:43 +0900)]
eina_matrix: replace cosf by cos to gain more accuracy

Summary:
cos function is much much more accurate than cosf.
this patch replaces cosf by cos to gain more accuracy.

Reviewers: cedric, jsuya, vtorri

Subscribers: vtorri, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10695

Change-Id: Ifb99e744dd0fead9cda77a1e3697798b824f27eb

4 years agovector lottie: reset vg tree each frames.
Hermet Park [Thu, 21 Nov 2019 08:37:33 +0000 (17:37 +0900)]
vector lottie: reset vg tree each frames.

Since vector tree nodes are reusing instead of reconstrucion,
We make it sure that dangling nodes invisible by clearing all nodes visibility.

Only valid nodes will be reset to visible while setting up in the progress.

4 years agoRevert "evas animation: removed unnecessray checking."
Hermet Park [Thu, 21 Nov 2019 08:45:36 +0000 (17:45 +0900)]
Revert "evas animation: removed unnecessray checking."

This reverts commit 959c503a718ed548fa3251fc245bfe9c8c82d521.

4 years agovector json: checking valid pointer before accessing it.
Hermet Park [Thu, 21 Nov 2019 08:28:54 +0000 (17:28 +0900)]
vector json: checking valid pointer before accessing it.

Change-Id: I74465ba115411db610b196253ac08454b8f29a2c

4 years agoevas animation: removed unnecessray checking.
Hermet Park [Thu, 21 Nov 2019 08:26:21 +0000 (17:26 +0900)]
evas animation: removed unnecessray checking.

pd->in is already verified earlier.

4 years agoelm/hoversel: Recalculate items before box calculate. 45/218345/1
JunsuChoi [Thu, 21 Nov 2019 10:49:01 +0000 (19:49 +0900)]
elm/hoversel: Recalculate items before box calculate.

Summary:
After the item is packed into the box,
the min of the item can be initialized with content_set working.
content_set calls parent_set and checks the theme when calling parent_set.
At that time, if theme is changed in the parent of layout using hoversel,
call theme_apply(efl_ui_layout) to make min value 0, 0.
This patch can avoid it.

Test Plan: N/A

Reviewers: YOhoho, Hermet, woohyun, zmike, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10712

Change-Id: Ib0237ebdef99a79d7418ecdadd44941ef2e03a48

4 years agowearable: add positioned item get API for wearable support 29/218329/2
Hosang Kim [Thu, 21 Nov 2019 09:12:30 +0000 (18:12 +0900)]
wearable: add positioned item get API for wearable support

Change-Id: Id76a721035f2d05913df6e8f83886ba2ccb0f14d

4 years agoeina_matrix: replace cosf by cos to gain more accuracy 28/218328/1
Wonki Kim [Thu, 21 Nov 2019 08:43:42 +0000 (17:43 +0900)]
eina_matrix: replace cosf by cos to gain more accuracy

Summary:
cos function is much much more accurate than cosf.
this patch replaces cosf by cos to gain more accuracy.

Reviewers: cedric, jsuya, vtorri

Subscribers: vtorri, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10695

Change-Id: I6b646b630ce385e6b157838aca7c6a411eb71a30

4 years agoRevert "evas animation: removed unnecessray checking." 25/218325/1
Hermet Park [Thu, 21 Nov 2019 08:45:36 +0000 (17:45 +0900)]
Revert "evas animation: removed unnecessray checking."

This reverts commit 959c503a718ed548fa3251fc245bfe9c8c82d521.

Change-Id: I27f99c5ab67447365a64c4616727b33cd7b8354e

4 years agovector json: checking valid pointer before accessing it. 20/218320/2
Hermet Park [Thu, 21 Nov 2019 08:28:54 +0000 (17:28 +0900)]
vector json: checking valid pointer before accessing it.

Change-Id: I97abee823eb3f7290bb60aa3e829f47692145cff

4 years agoevas animation: removed unnecessray checking. 19/218319/2
Hermet Park [Thu, 21 Nov 2019 08:26:21 +0000 (17:26 +0900)]
evas animation: removed unnecessray checking.

pd->in is already verified earlier.

Change-Id: I34752c4461345a2391de9bbf5a1f18c08d10990d

4 years agowearable : add item classes for wearable support 53/218153/3
SangHyeon Jade Lee [Wed, 20 Nov 2019 04:41:57 +0000 (13:41 +0900)]
wearable : add item classes for wearable support

Change-Id: I60a9ba8b5bcea2545ad82f87f595eaa441eeb597

4 years agoefl_ui: apply circle position manager for wearable 21/218121/3
SangHyeon Jade Lee [Tue, 19 Nov 2019 08:21:15 +0000 (17:21 +0900)]
efl_ui: apply circle position manager for wearable

Change-Id: If187b2276d7f0b746be2d49a823d12aeb9e5099b

4 years agoedje: fix to remove Efl.Canvas.Animation_Player
Jaehyun Cho [Thu, 21 Nov 2019 06:41:18 +0000 (15:41 +0900)]
edje: fix to remove Efl.Canvas.Animation_Player

Since json support in edc is TIZEN_ONLY feature, the logic of json
support in edc is fixed to remove Efl.Canvas.Animation_Player.

@tizen_only

Change-Id: Idf738bd7bde153361c4a99abd823354c68f9023a

4 years agoefl_canvas_object_animation: check if animation stops during animation
Jaehyun Cho [Thu, 21 Nov 2019 06:30:21 +0000 (15:30 +0900)]
efl_canvas_object_animation: check if animation stops during animation

It is checked if animation stopped in the animation_progress,updated
callback by user.

4 years agocsharp: Components enum are flags now.
Bruno da Silva Belo [Wed, 20 Nov 2019 22:07:21 +0000 (19:07 -0300)]
csharp: Components enum are flags now.

Reviewers: lauromoura, felipealmeida, YOhoho

Reviewed By: lauromoura

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8411

Differential Revision: https://phab.enlightenment.org/D10541

4 years agocsharp: Hiding p-invokes.
Bruno da Silva Belo [Wed, 20 Nov 2019 21:37:48 +0000 (18:37 -0300)]
csharp: Hiding p-invokes.

Summary: ref T8406

Reviewers: lauromoura, felipealmeida, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8406

Differential Revision: https://phab.enlightenment.org/D10651

4 years agocsharp: CA1307 Add CultureInfo to generated code.
Lauro Moura [Wed, 20 Nov 2019 21:34:08 +0000 (18:34 -0300)]
csharp: CA1307 Add CultureInfo to generated code.

Summary:
For the struct fields with strings when implementing `GetHashCode`.

Ref T8405

Reviewers: brunobelo, felipealmeida, YOhoho

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8405

Differential Revision: https://phab.enlightenment.org/D10696

4 years agocsharp: Specifying StringComparison.
Bruno da Silva Belo [Wed, 20 Nov 2019 19:57:14 +0000 (16:57 -0300)]
csharp: Specifying StringComparison.

Summary: ref T8405

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8405

Differential Revision: https://phab.enlightenment.org/D10650

4 years agotooling: add configuration file for lgtm.com service
Stefan Schmidt [Wed, 20 Nov 2019 08:57:05 +0000 (09:57 +0100)]
tooling: add configuration file for lgtm.com service

It seems they run this on many Github projects automatically now:
https://lgtm.com/projects/g/Enlightenment/efl

From my playing around it had 970 "recommendations" to fix our FIXME
tags. Filtering out this noise by using this config file to exclude the
query.

It also seems to pick up the python scripts as Python2 and has wrong
reporting due to this as well.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10699

4 years agoecore_input_evas: fix ouble use of include guard define
Stefan Schmidt [Wed, 20 Nov 2019 08:08:54 +0000 (09:08 +0100)]
ecore_input_evas: fix ouble use of include guard define

We used the ecore_input define here in ecore_evas_input. Use a unique
name for this file.

Reported-By: https://lgtm.com/projects/g/Enlightenment/efl/
Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10698

4 years agoeo: there is no need to count callbacks here
Marcel Hollerbach [Sun, 17 Nov 2019 11:09:23 +0000 (12:09 +0100)]
eo: there is no need to count callbacks here

we are going to add this description anyways, no need to count here
again. I think this is not really making anything really faster, its
more keeping things consistance.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10689

4 years agoremove efl_canvas_animation_player
Marcel Hollerbach [Thu, 14 Nov 2019 11:54:31 +0000 (12:54 +0100)]
remove efl_canvas_animation_player

this now all migrated to Efl.Canvas.Object.Animation

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10667

4 years agoevas: migrate the vg json example
Marcel Hollerbach [Mon, 18 Nov 2019 02:44:15 +0000 (11:44 +0900)]
evas: migrate the vg json example

Summary:
i was not able to run the example before this commit, nor after this
commit. However, i had to migrate this, as i want to remove the player
object.
Depends on D10637

Reviewers: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10666

4 years agoefl_ui_spotlight_manager stack: move away from player object
Marcel Hollerbach [Sun, 10 Nov 2019 19:00:50 +0000 (20:00 +0100)]
efl_ui_spotlight_manager stack: move away from player object

with this commit we move from using the player object to using the mixin
that was introduced a few commits before. The new mixin is way easier to
use here, we safe a lot of code, we also only need 1 object instead of
4. (And overall, everything just gets sooooo much more easier).

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10637

4 years agoelementary: move away from normal player to the new animation mixin
Marcel Hollerbach [Sun, 10 Nov 2019 18:10:02 +0000 (19:10 +0100)]
elementary: move away from normal player to the new animation mixin

the mixin can handle the same things as the player. Additionally, the
usage of the mixin simplifies the animation usage alot.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10636

4 years agointroduce efl_canvas_object_animation
Marcel Hollerbach [Thu, 7 Nov 2019 10:24:21 +0000 (11:24 +0100)]
introduce efl_canvas_object_animation

this brings the animation to the canvas object. All the controls of the
animation now do now require a player object anymore, you can just use
the API that is directly on the Efl.Canvas.Object object.

wip animation player replacement

Differential Revision: https://phab.enlightenment.org/D10615

4 years agoUnify "animated" flags
Xavi Artigas [Mon, 11 Nov 2019 16:38:08 +0000 (16:38 +0000)]
Unify "animated" flags

There exist several flags to indicate whether an object should be animated, with inconsistent names:
Efl.Canvas.Layout.animation: bool indicating if Edje animations should be played
Efl.Ui.Spotlight_Manager.animation_enabled: bool indicating if page transitions should be animated
Efl.Canvas.Animation_Player.animation: Efl.Canvas.Animation object

This commit unifies all of them: "animated" is now a flag, and "animation" is an object.

Note: Animation_Player is in the process of being replaced by an "animation" property in the
Efl.Canvas.Object, hence the need for non-clashing animation flags.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10645

4 years agovector container: don't copy composite target duplicatedly.
Hermet Park [Wed, 20 Nov 2019 05:09:00 +0000 (14:09 +0900)]
vector container: don't copy composite target duplicatedly.

Container copied composite target in prior to duplicate children,

the composite target is one of the children, it should skip to handle it again.

Change-Id: Ib54413c53e8baf1d004efbd47c13232c809c13ea

4 years agocsharp: Fix CA1815 for generated structs and aliases
Lauro Moura [Tue, 19 Nov 2019 04:48:01 +0000 (01:48 -0300)]
csharp: Fix CA1815 for generated structs and aliases

Summary: Adds IEquatable<T> and friends.

Reviewers: felipealmeida, YOhoho, brunobelo

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, segfaultxavi, #committers

Tags: #efl

Maniphest Tasks: T8418

Differential Revision: https://phab.enlightenment.org/D10694

4 years agoefl_ui_scrollable: add new event for destination information. 83/218183/9
Hosang Kim [Wed, 20 Nov 2019 06:32:09 +0000 (15:32 +0900)]
efl_ui_scrollable: add new event for destination information.

Scroll manager send a signal to widget when destination of scroll is
finalized.

Change-Id: Icfaebcdd5ad281f967cddb72efca75d149c9432a

4 years agovg_common_json: Apply image's alpha color 61/218161/1
JunsuChoi [Mon, 14 Oct 2019 08:40:14 +0000 (17:40 +0900)]
vg_common_json: Apply image's alpha color

Summary:
This patch needs latest rlottie that contain below commit.
https://github.com/Samsung/rlottie/commit/c3ab82ec2c207cfba2df6eb51d80dd532c93a710

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10368

Change-Id: Idfe3c6c476e0f5b23a82a8872f0aa4f5d6d1128b

4 years agovector container: don't copy composite target duplicatedly. 58/218158/1
Hermet Park [Wed, 20 Nov 2019 05:09:00 +0000 (14:09 +0900)]
vector container: don't copy composite target duplicatedly.

Container copied composite target in prior to duplicate children,

the composite target is one of the children, it should skip to handle it again.

Change-Id: I9a3074ca858f7827ab7d8315ed4446370952a8f0

4 years agoevas font: Enhance brightness. 87/218087/2
Hermet Park [Tue, 19 Nov 2019 08:22:18 +0000 (17:22 +0900)]
evas font: Enhance brightness.

For the clear font visuals, we're adjusting the brightness by a trial-error.
This adjust seems improving the font quality for wearable devices.

Change-Id: I9c10d82f3481ac139779610ffbcd4bb0b6fe0de9

4 years agoecore-wl2: Add API to find a window by given surface accepted/tizen/unified/20191120.034538 submit/tizen/20191119.214155
Christopher Michael [Tue, 19 Nov 2019 14:37:11 +0000 (09:37 -0500)]
ecore-wl2: Add API to find a window by given surface

This patch adds a convenience function to find a window by a given
wl_surface.

@feature

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_type functions
Christopher Michael [Tue, 19 Nov 2019 14:31:46 +0000 (09:31 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_type functions

ref T8016

4 years agoecore-wl2: Add API to return window type
Christopher Michael [Tue, 19 Nov 2019 14:28:27 +0000 (09:28 -0500)]
ecore-wl2: Add API to return window type

Small patch whichs adds a new API to return the type of a given window

@feature

4 years agoecore-wl2: Add API to return the compositor object from a given display
Christopher Michael [Tue, 19 Nov 2019 14:23:18 +0000 (09:23 -0500)]
ecore-wl2: Add API to return the compositor object from a given display

This patch adds a convenience function to get the wl_compositor object
from a given display

@feature

4 years agoecore-wl2: Add API to find a connected display given a name
Christopher Michael [Tue, 19 Nov 2019 14:16:31 +0000 (09:16 -0500)]
ecore-wl2: Add API to find a connected display given a name

This patch adds a convenience function to find a connected display
given a name

@feature

4 years agoecore-wl2: Add API to find a window by surface
Christopher Michael [Tue, 19 Nov 2019 14:01:53 +0000 (09:01 -0500)]
ecore-wl2: Add API to find a window by surface

This patch adds a convenience API that can be used to find a window
based on wl_surface.

@feature

4 years agotests/ecore_wl2: Add test for ecore_wl2_window_geometry functions
Christopher Michael [Tue, 19 Nov 2019 13:37:29 +0000 (08:37 -0500)]
tests/ecore_wl2: Add test for ecore_wl2_window_geometry functions

ref T8016

4 years agodocs: Copy all images to output folder
Xavi Artigas [Mon, 18 Nov 2019 14:20:38 +0000 (15:20 +0100)]
docs: Copy all images to output folder

Summary:
Doxygen only copies to the output folder ("html") images included through
the \image tag. However, we have several images included using \htmlonly
blocks with <img> tags inside, which also need copying.
Old makefiles included code to manually copy all pngs, and this patch does
the same for meson.
I apologize for needing an external script just to run "cp -rf", it looks
like meson does not allow wildcards passed to "cp".
Files not in the output folder won't be included in the tarball and won't
be distributed.

Test Plan:
Generated documentation now includes images for pages like:
`group__Eina__List__Group.html#details`

Reviewers: bu5hm4n, lauromoura

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers, myoungwoon

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10690

4 years agoslider: fix behavior of slider when mirrored
Bowon Ryu [Tue, 19 Nov 2019 05:04:05 +0000 (14:04 +0900)]
slider: fix behavior of slider when mirrored

Summary:
The vertical slider(!horizontal) should not be inverted when mirrored.
This patch fixes and cleans up this.

Test Plan:
elementary_test -to slider
elementary_test -to efl.ui.slider

UI-Mirroring on/off and observe vertical slides.

Reviewers: woohyun, cedric, bu5hm4n

Reviewed By: woohyun

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10693

4 years agocsharp: Add IEquatable on classes.
Lauro Moura [Thu, 14 Nov 2019 19:27:14 +0000 (16:27 -0300)]
csharp: Add IEquatable on classes.

Summary: ref T8418

Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8418

Differential Revision: https://phab.enlightenment.org/D10647

4 years agoevas vector: removed useless calls.
Hermet Park [Tue, 19 Nov 2019 04:22:50 +0000 (13:22 +0900)]
evas vector: removed useless calls.

It turns out ector engine doesn't use any color mixing with gradients fill.
Removed unnecessarities unless we can find a way to use them in the future.

4 years agovector svg: apply fill-opacity to graidents fill objects.
Hermet Park [Tue, 19 Nov 2019 04:18:42 +0000 (13:18 +0900)]
vector svg: apply fill-opacity to graidents fill objects.

If node has a fill-opacity attirbute it must propagtes it to
its fill objects.

Previous our implementation missed this behavior.

@fix

Change-Id: I098cc964efbb2705d5bebc2ed3333040d03ba89b

4 years agoecore_timer: add NULL checking for timer data. 05/218105/3
Hosang Kim [Tue, 19 Nov 2019 10:14:13 +0000 (19:14 +0900)]
ecore_timer: add NULL checking for timer data.

Change-Id: If19962540f49a8e1c82f3544792adfa3480d7ffe

4 years agoefl_ui_win: Enabled auto_norender_withdrawn. 95/218095/2
Woochanlee [Tue, 19 Nov 2019 09:16:37 +0000 (18:16 +0900)]
efl_ui_win: Enabled auto_norender_withdrawn.

Upstream wayland doesn't have iconify_changed callback.
But tizen supports it own extension library.

@tizen_feature

Change-Id: Id6c75dd781c68aa7783330ffe4462192173bd1b3

4 years agovector svg: apply fill-opacity to graidents fill objects. 41/218041/1
Hermet Park [Tue, 19 Nov 2019 04:18:42 +0000 (13:18 +0900)]
vector svg: apply fill-opacity to graidents fill objects.

If node has a fill-opacity attirbute it must propagtes it to
its fill objects.

Previous our implementation missed this behavior.

@fix

Change-Id: I84105b162c845565bb182c83e84e5623eaa8925c

4 years agoRevert "Revert "vg_common_svg: Support opacity attribute of <g> element"" 40/218040/1
Hermet Park [Tue, 19 Nov 2019 04:32:17 +0000 (13:32 +0900)]
Revert "Revert "vg_common_svg: Support opacity attribute of <g> element""

This reverts commit 8a03085d6b97943a720397231de87d58e9d46e44.

Revert again after Tizen 5.5 M2 Public release.

Change-Id: I9e632e8848f95e3d423f13a2473fdd442cdc3454

4 years agoslider: fix value error from step submit/tizen/20191118.220200
Bowon Ryu [Mon, 18 Nov 2019 12:25:26 +0000 (21:25 +0900)]
slider: fix value error from step

Summary:
When the slider moves using step,
_drag_value_fetch(), _val_fetch() calculates a value from position of edje_part.
Then the calculated value is updated.
However, this causes a slight error.

This patch updates value ​​first when moving with steps.

* Test Example

```
Evas_Object *sl = elm_slider_add(bx);
elm_slider_min_max_set(sl, -5, 5);
elm_slider_value_set(sl, 0.0);
elm_slider_step_set(sl, 0.1);
evas_object_size_hint_align_set(sl, EVAS_HINT_FILL, EVAS_HINT_FILL);
evas_object_size_hint_weight_set(sl, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_smart_callback_add(sl, "changed", _change_cb, NULL);
```
```
void
_change_cb(void *data, Evas_Object *obj, void *event_info EINA_UNUSED)
{
   double val = elm_slider_value_get(obj);

   if (val == -5.0) printf("val[%f] == -5.0 \n", val);
   if (val == -4.0) printf("val[%f] == -4.0 \n", val);
   if (val == -3.0) printf("val[%f] == -3.0 \n", val);
   if (val == -2.0) printf("val[%f] == -2.0 \n", val);
   if (val == -1.0) printf("val[%f] == -1.0 \n", val);
   if (val == 0.0) printf("val[%f] == 0.0 \n", val);
   if (val == 1.0) printf("val[%f] == 1.0 \n", val);
   if (val == 2.0) printf("val[%f] == 2.0 \n", val);
   if (val == 3.0) printf("val[%f] == 3.0 \n", val);
   if (val == 4.0) printf("val[%f] == 4.0 \n", val);
   if (val == 5.0) printf("val[%f] == 5.0 \n", val);
}
```

If you move the slider using step in this test,
You can see that some logs are not visible. (Some values ​​are incorrect)

Test Plan:
elementary_test -to slider
elementary_test -to efl.ui.slider

Reviewers: woohyun, cedric, bu5hm4n

Reviewed By: woohyun, bu5hm4n

Subscribers: bu5hm4n, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10662

4 years agodocs: Typos in ninja doc screen output
Xavi Artigas [Mon, 18 Nov 2019 11:30:22 +0000 (12:30 +0100)]
docs: Typos in ninja doc screen output

4 years agodoxygen: Prevent auto-linking of invalid links
Xavi Artigas [Mon, 18 Nov 2019 10:57:30 +0000 (11:57 +0100)]
doxygen: Prevent auto-linking of invalid links

Anything starting with http://, ftp:// or file:// is automatically
converted into a link by doxygen. However, we have a few instances
where we do not want this. Fortunately, doxygen allows using % to
forbid specific words from being linked.

4 years agoeldbus: only free the data when the future is resolved or rejected.
Cedric BAIL [Fri, 15 Nov 2019 17:39:38 +0000 (09:39 -0800)]
eldbus: only free the data when the future is resolved or rejected.

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10684