Fix queueFamilyIndex in synchronization tests

Invalid index is used, instead of retrieving queueFamilyIndex

Components: Vulkan

VK-GL-CTS issue: 3996

Affected tests:
dEQP-VK.synchronization.internally_synchronized_objects.*

Change-Id: I69aabf6199437cc26f519c257a3b26ee1605f8ef

Enable instance extensions when creating robustness device

Custom robustness context enables device extensions without enabling any
of the required instance extensions

Components:
Framework Vulkan VulkanSC

VK-GL-CTS issue: 3958

Affected tests:
dEQP-VK.*
dEQP-VKSC.*

Change-Id: I06d7d914eceb5aec97f723f726f97168341d8da5

Remove invalid dedicated allocation tests with bind offset

When dedicated allocation is used VkMemoryRequirements::size must match
VkMemoryAllocateInfo::allocationSize

Components: Vulkan

VK-GL-CTS issue: 3947

Affected tests:
dEQP-VK.api.copy_and_blit.*

Change-Id: I6eb0939746504566750b1cc958e1704cbf15ae51

Fix enabling timelineSemaphore feature

The feature was only enabled if the extension was used and not when
vulkan version 1.2 was used

Components: Vulkan

VK-GL-CTS issue: 3955

Affected tests:
dEQP-VK.*.smoke.timeline_semaphores
dEQP-VKSC.*.smoke.timeline_semaphores

Change-Id: If1b6fb3a6b0f6ef6e54b3bc2f36f1a7a55fd5fab

Fix missing cmd buffer reset flag in query_pool_results tests

Command buffer is begun multiple times when command pool was created
without VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT

Components: Vulkan

VK-GL-CTS issue: 3983

Affected tests:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.query_pool_results.*

Change-Id: If5445bb51c3b3a7b1aebd5397ef97f0f57dc7a9d

Limit call of getQueryPoolResults to BUILD_TYPE_DEVICE

When the buildType is BUILD_TYPE_HOST, queryPool results are retrieved immediately to the CPU, and queryPool is not set to the result value.
Due to unset value at queryPool, later calling getQueryPoolResults causes the size to be messed up, and assertion to be trigerred.
The intention to call getQueryPoolResults is for BUILD_TYPE_DEVICE where you need to wait for cmdBuffer to be executed.
Call of getQueryPoolResults should only be made if the build type is BUILD_TYPE_DEVICE.

Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.copy_within_pipeline.cpu.*

Components: Vulkan

https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/4016

Change-Id: I2e8c3dc9c56c98c288bba17d6c4074a9b88e0851

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I869c5e50453097a134dfa73defee01f9512b1bcb

Remove VK_PIPELINE_CREATE_DERIVATIVE_BIT for pipeline libraries in util

vkPipelineConstructionUtil creates pipeline libraries with same flags as
the main pipeline, but base pipeline handle is never provided

Components: Vulkan, Framework

VK-GL-CTS issue: 3994

Affected tests:
dEQP-VK.pipeline.*

Change-Id: If30b3caebd00463587a00f9e82810b53a7b72eb6

Fix color blend state in FSR tests

The attachment count used in pColorBlendState must match the attachment
count in the subpass the pipeline is created with

Components: Vulkan

VK-GL-CTS issue: 3993

Affected tests:
dEQP-VK.pipeline.*.multisample_with_fragment_shading_rate.*

Change-Id: Ic208371f7a6c704f169c3c16f0c19836014dcd85

Fix enabling pipeline libraries in push descriptor tests

Add missing required extension and enable the required feature for
pipeline libraries

Components: Vulkan

VK-GL-CTS issue: 3989

Affected tests:
dEQP-VK.pipeline.*.push_descriptor.*

Change-Id: Ibd7b588e822e94e42a405c2d3bb8c3ef81bd4aa0

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I62bf1f49ff0dab41398a140dc29ca17a46142be5

Enable dynamicRendering feature in FSR tests using it

Fragment shading rate tests using dynamic rendering did not enable the
feature

Components: Vulkan

VK-GL-CTS issue: 3953

Affected tests:
dEQP-VK.fragment_shading_rate.dynamic_rendering.attachment_rate.*

Change-Id: I0959c88f42d820bed3b58473d45693bbcbd28896

Fix barriers in dynamic rendering fragment density tests

Addeded additional barrier to ensure work on subsampled image is
complete before copy to output image.

Affects: dEQP-VK.dynamic_rendering.fragment_*

Components: Vulkan

VK-GL-CTS Issue: 3796

Change-Id: I5875f22b7fd3ccb47c9762067cb57048011115c0

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I995d279b4aa7949762e1321013c1ae56c2bacad5

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Iccd8336664b28aaa5c009f7da85295995a8297eb

Add missing buffer features check in image store tests

Check if format supports storage write for VkBufferView where
OpTypeImage is Unknown

Components: Vulkan

VK-GL-CTS issue: 3765

Affected tests:
dEQP-VK.image.store.without_format.*

Change-Id: I74365f2f753fb61397d83403098a288cdcf53953

Fix resetting command buffer in ray tracing tests

VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT must be set to reset
command buffer and add missing reset

Components: Vulkan

VK-GL-CTS issue: 3960

Affected tests:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.*

Change-Id: Icc5029fc796bff7cf095cbb78832483463cdaaaa

Fix ds attachment formats in dynamic rendering with inheritance

In VkCommandBufferInheritanceRenderingInfoKHR the depthAttachmentFormat
must have a depth aspect or be VK_FORMAT_UNDEFINED, and the
stencilAttachmentFormat must have a stencil aspect or be
VK_FORMAT_UNDEFINED

Components: Vulkan

VK-GL-CTS issue: 3970

Affected tests:
dEQP-VK.dynamic_rendering.*

Change-Id: I6d3248643a7a2b1f5761833828889e3484a25a57

Fix VkPipelineRenderingCreateInfoKHR formats in dynamic rendering tests

depthAttachmentFormat must include a depth aspect and stencilAttachment
format must include a stencil aspect

Components: Vulkan

VK-GL-CTS issue: 3952

Affected tests:
dEQP-VK.dynamic_rendering.*

Change-Id: Ifbbadb4f2917fb36fef669f1fc0a0eae6d0c7802

Enable used features in present_id_wait tests

Featuers presentId and presentWait are used, but not enabled

Components: Vulkan

VK-GL-CTS issue: 3957

Affected tests:
dEQP-VK.wsi.win32.present_id_wait.*

Change-Id: Ia6e899d65c05a81876c5d46b8426425c10b657f1

Add image format support check in sparse render target tests

Check if format is supported for the test

Components: Vulkan

VK-GL-CTS issue: 3961

Affected tests:
dEQP-VK.*.suballocation.sparserendertarget.*

Change-Id: I9878d04465839ce73f9f6661e263a114c01037fb

Fix rendering flags in secondary command buffers tests

VkCommandBufferInheritanceRenderingInfo::flags must match
VkRenderingInfo::flags excluding
VK_RENDERING_CONTENTS_SECONDARY_COMMAND_BUFFERS_BIT

Components: Vulkan

VK-GL-CTS issue: 3987

Affected tests:
dEQP-VK.multiview.dynamic_rendering.secondary_cmd_buffer.*

Change-Id: I205594a88fbe7baf60146121e05b75201be9b46b

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I56e0faf8f022888c1d28b368d7852a83575ae57d

Check if stage is supported with subgroup size

When using required subgroup size, shader stage used must be a bit in
VkPhysicalDeviceSubgroupSizeControlProperties requiredSubgroupSizeStages

Components: Vulkan

VK-GL-CTS issue: 3962

Affected tests:
dEQP-VK.reconvergence.*

Change-Id: Ie2109b6974c4da57f19e8d321e27ccbad1298c71

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Iea1e614855e2a12ab124da1dd1f24f2aaa938406

Fix dedicated allocations in split frame rendering tests

The image bound to dedicated memory must match the image from
VkMemoryDedicatedAllocateInfo

Components: Vulkan

VK-GL-CTS issue: 3971

Affected tests:
dEQP-VK.device_group.sfr_*

Change-Id: I23684ae6777d575da5eb244dfd856946ba67aa4a

Fix external memory opaque fd tests for MacOS

Components: Vulkan

VK-GL-CTS issue: 3981

Affected tests:
dEQP-VK.api.external.memory.*

Change-Id: I21a169aab047e58bc716d2aa69426b23af9295f2

Fix attachment load op in framebuffer compatible render pass tests

If image layout is VK_LAYOUT_UNDEFINED the loadOp of
VkAttachmentDescription must not be VK_ATTACHMENT_LOAD_OP_LOAD

Components: Vulkan

VK-GL-CTS issue:3948

Affected tests:
dEQP-VK.api.pipeline.renderpass.framebuffer_compatible_renderpass

Change-Id: I4b31df7fa9ca56d9c31af1326b8036f81e9d80fe

Fix errors in imageless framebuffer tests

Attachment must not be VK_ATTACHMENT_LOAD_OP_LOAD if initialLayout is
VK_IMAGE_LAYOUT_UNDEFINED
If framebuffer flags contain VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT then
image usage must include VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT

Components: Vulkan

VK-GL-CTS issue: 3969

Affected tests:
dEQP-VK.imageless_framebuffer.*

Change-Id: Ie588c547f8f55710eeffdccea94dd552dd8559a2

Use only required buffer usage bit in robustness tests

Using all bits requires additional checks for format support

Components: Vulkan

VK-GL-CTS issue: 3959

Affected tests:
dEQP-VK.robustness.*

Change-Id: I7a7c9e338b1e38a2d028f1fcffd6196bb75fa285

Fix srcStageMask in vkCmdWaitEvents in external fence tests

If event is set with vkSetEvent the srcStageMask must be
VK_PIPELINE_STAGE_HOST_BIT

Components: Vulkan

VK-GL-CTS issue: 3979

Affected tests:
dEQP-VK.api.external.fence.*

Change-Id: I9ca6fb5bdb597639cd5cb88afdbb03dde565acd8

Fix srcStageMask in vkCmdWaitEvents in secondary cmd buffers tests

If event is set with vkCmdSetEvent the srcStageMask must be
VK_PIPELINE_STAGE_HOST_BIT

Components: Vulkan

VK-GL-CTS issue: 3980

Affected tests:
dEQP-VK.api.command_buffers.secondary_execute_twice

Change-Id: Ib784e454ecf2bead488a267a069111da16ddfa8d

Fix memory allocation tests with device coherent memory

Extension VK_AMD_device_coherent_memory needs to be enabled in order ot
use VkPhysicalDeviceCoherentMemoryFeaturesAMD

Components: Vulkan

VK-GL-CTS issue: 3973

Affected tests:
dEQP-VK.memory.allocation.*

Change-Id: Ia866ab947bbd1af867f409053f830598965dea12

Fix color blend state in multisample tests

If the subpass the pipeline is created with has no color attachment the
attachmentCount of pColorBlendState must also be 0

Components: Vulkan

VK-GL-CTS issue: 3991

Affected tests:
dEQP-VK.pipeline.multisample.alpha_to_coverage_no_color_attachment.*

Change-Id: I37ca31e3114ca3e840759b118365f41b1a9565a1

Fix signal order tests timeline semaphore value

The new timeline semaphore value must be greater than the current value
of the semaphore

Components: Vulkan

VK-GL-CTS issue: 3978

Affected tests:
dEQP-VK.synchronization.signal_order.*

Change-Id: I7f1276dda7739f7817148550fd1b0782d9045849

Add checking drawIndirectCount in conditional rendering tests.

Affects:
dEQP-VK.conditional_rendering.*_indirect_count

Components: Vulkan

VK-GL-CTS issue: 4012

Change-Id: Iad77cebba4a84833f7733a2f8041285623a000bc

Fix image barriers in image to image copy tests

The same image barriers are used twice if clearDestination is used,
the oldLayout of the second barrier does not match the current layout of
the image

Components: Vulkan

VK-GL-CTS issue: 3956

Affected tests:
dEQP-VK.api.copy_and_blit.*.image_to_image.*

Change-Id: I2623e70f3d4f0b97f9f941e4e6cb2760fd2c9d74

Fix srcStageMask in buffer_marker tests

If srcAccessMask in pipeline barrier is VK_ACCESS_TRANSFER_WRITE_BIT the
srcStageMask must be VK_PIPELINE_STAGE_TRANSFER_BIT

Components: Vulkan

VK-GL-CTS issue: 3963

Affected tests:
dEQP-VK.api.buffer_marker.compute.default_mem.*

Change-Id: I0a5957d714c4c5cb9f2855421cd78683b7b7b819

Enable features in synchrnozation tests custom device

The custom device used in synchrnonization utils does not enable any
features, but uses for example geometryShader

Components: Vulkan

VK-GL-CTS issue: 3964

Affected tests:
dEQP-VK.synchronization.*

Change-Id: Ia8f46b3e1ca519f0436f7545ef1b1a80652dbc88

Remove invalid unmatched flags test

The test is removed as it tries to perform a test case which is not
allowed by valid usage descriptions

This test was already removed from main, but not older release branches

Components: Vulkan

VK-GL-CTS issue: 3621

Removed tests:
dEQP-VK.api.device_init.create_device_queue2_unmatched_flags

Change-Id: I42c21222f7c3a066ca07b967bdde54dbb3007336

Fix barriers in synchronization2 tests

Stage VK_PIPELINE_STAGE_2_PRE_RASTERIZATION_SHADERS_BIT_KHR
is not supported with access mask VK_ACCESS_2_VERTEX_ATTRIBUTE_READ_BIT
or VK_ACCESS_2_INDEX_READ_BIT

Components: Vulkan

VK-GL-CTS issue: 3977

Affected tests:
dEQP-VK.synchronization2.*

Change-Id: I0c40b798e80fda98cdda49788210331a878f6bd5

Fix errors in buffer_marker tests

If srcAccessMask is VK_ACCESS_TRANSFER_WRITE_BIT the stage mask must be
VK_PIPELINE_STAGE_TRANSFER_BIT
If vkFreeDescriptors is called, the descriptor pool must have been
created with VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT

Components: Vulkan

VK-GL-CTS issue: 3984

Affected tests:
dEQP-VK.api.buffer_marker.*.default_mem.*

Change-Id: Iaec7d2a74f7d4084258206d4c96cc112c23e38f8

Add checking VK_KHR_ray_tracing_pipeline extension.

Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.copy_within_pipeline.*

Components: Vulkan

VK-GL-CTS issue: 3824

Change-Id: Iac1380eb2f2d458570271217e433cd0bcd147b99

Add missing check for imageCubeArray feature

Feature imageCubeArray needs to be enabled when image views use type
VK_IMAGE_VIEW_TYPE_CUBE_ARRAY

Components: Vulkan

VK-GL-CTS issue: 3910

Affected tests:
dEQP-VK.api.object_management.*

Change-Id: Ie49c70b7311b29609bec5e1cc6f5570c33002d90

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I13cee5dfaf58ba9c06024c662874b2e614b0e653

Fix samples in VkCoarseSampleLocationNV tests

VkCoarseSampleLocationNV::sample must be less than the number of
coverage samples in each pixel belongning to the fragment

Components: Vulkan

VK-GL-CTS issue: 3995

Affected tests:
dEQP-VK.dynamic_state.*.viewport_coarse_sample_order_nv.*

Change-Id: Ia44906d0129d0af9374b44ca1f6a423b31285311

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: Ifd90e4e5ecda6ae1d2290de8eb20633655115e71

Enable minLod feature in mipmap tests using it

Components: Vulkan

VK-GL-CTS issue: 3936

Affected tests:
dEQP-VK.texture.mipmap.*

Change-Id: Idc2adff0a34eeea3e5bec594d20b1cd5cfa586b3

Add missing required extension in pageable memory tests

VK_EXT_memory_priority is required to be enabled when
VK_EXT_pageable_device_local_memory is used

Components: Vulkan

VK-GL-CTS issue: 3931

Affected tests:
dEQP-VK.memory.binding.priority_dynamic.*

Change-Id: If544fe39b6481f6da628002c8f0f61ea85e8c668

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I0f56252e649dc089c025e312de8c86498f1ef024

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Iaf8dc48ac02ba8e3f6713bf1e5c212eeb8a934b8

Fix pipeline barrier in multisample resolve tests

srcAccessMask and dstAccessMask must be supported by the pipeline stages
used in the barrier

Components: Vulkan

VK-GL-CTS issue: 3934

Affected tests:
dEQP-VK.dynamic_rendering.suballocation.multisample_resolve.*

Change-Id: Ic2d4976875c67ece548a92e236f778fe77740ef5

Fix basic dynamic rendering tests

Create pipeline with correct information for depth/stencil
and correctly inherit in secondary command buffers.

Affects:
dEQP-VK.dynamic_rendering.basic.*

Components: Vulkan

VK-GL-CTS issue: 3939

Change-Id: Ide926862c5272d7ef5cafcaf40b47e338b071edb

Fix multisample resolve tests with integer formats

If attachments use an integer format, resolveMode must be either
VK_RESOLVE_MODE_NONE or VK_RESOLVE_MODE_SAMPLED_ZERO_BIT

Components: Vulkan

VK-GL-CTS issue: 3935

Affected tests:
dEQP-VK.*.multisample_resolve.*

Change-Id: I3b410d06185a2572e4e199a23e0dffec9b457a22

Fix FSR tests with imageless framebuffers

If framebuffer is created with imageless bit then pViewFormats must
include the format used in VkAttachmentDescription

This was fixed once already, but was undone with a bad merge

Components: Vulkan

VK-GL-CTS issue: 3943

Affected tests:
dEQP-VK.fragment_shading_rate.*.basic.*

Change-Id: I40cf4c47d397a10c690708fa06a932ff13cd2db2

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Ice60c62e6d9ad661427fc8fe22b55e7859552b15

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Icb63b934b1b399deb129bce52cc5b91cce1def10

Simplify feature checking in YCbCr tests

Components: Vulkan
VK-GL-CTS Issue: 3937
Affects: dEQP-VK.ycbcr.*

Change-Id: I55fe0172efe4e64127927a10c08cc08d741ed817

Fix FSI tests flusing non host visible memory

Test try to flush memory that does not have host visible bit

Components: Vulkan

VK-GL-CTS issue: 3944

Affected tests:
dEQP-VK.fragment_shader_interlock.*

Change-Id: If7e1294a3d01e6c1dbd1bf08d9902c476ed5a2bd

Fix bad depth/stencil sync for depth_range_unrestricted

The synchronisation for the depth image was only for the late fragment
tests stage and only for writing. Since the depth test needs to read the
existing value the sync requires the READ bit and should apply at the
earliest stage that might perform the test (EARLY_FRAGMENT_TESTS, rather
than LATE_FRAGMENT_TESTS).

Component: Vulkan
Affects: dEQP-VK.pipeline.depth_range_unrestricted.*

Change-Id: I329e0f201735d0241c35f37a33379f361334f43e

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: Ib2d8b8d33b980e04dc91b99178695dd532ccc382

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: Ieb8b8d81d541424af1ee485685c8a16f933280fe

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I8ad2098c00b273cc4e80b471529aa1e1c1d457e1

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I9f0144577e533e509a8a26ef61a76fdefa6b26da

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I596aa3ecd9c4fb713c76e19a9e7d753909f13f67

lower local size for some amber KHR_workgroup_memory_explicit_layout tests

Some of these tests use a local size that exceeds the minimum requirement
in the spec and don't check whether the implementation supports it.

Rewrite the tests to use the minimum limit required by the spec for
maxComputeWorkGroupInvocations, which is 128, so that the test can
run on any implementation.

VK-GL-CTS issue: 3913
Components: Vulkan
Affects:
dEQP-VK.compute.workgroup_memory_explicit_layout.copy_memory.*
dEQP-VK.compute.workgroup_memory_explicit_layout.zero_ext.*

Change-Id: I4e8135d8d60e044f92ed5c53648fda24f067edc0

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I69b15479584e309ff31e12b315aeb42b01410e61

Fix using device coherent memory without enabling the feature

Components: Vulkan

VK-GL-CTS issue: 3921

Affected tests:
dEQP-VK.memory.allocation.*

Change-Id: I4eb9e1ab6f22487573bfe14affa75396962145c8

Fix modifier tests - Add Invalidate memory before host read.

After performing copyImagetoBuffer buffers no invalidation was given
before reading from host. Add the invalidate operation for buffer
before reading.

Components: Vulkan
VK-GL-CTS Issue: 3929

Affected tests:
dEQP-VK.transform_feedback.simple.*

Change-Id: I57dd4d65e9894e85f7d0c5adc4682f45e046bc02

Fix build in C++20 mode.

* Compound assignments to volatiles are deprecated.  Use non-compound
  forms.
* Math between disparate enums is deprecated.  Use constexprs.
* The full definition of a type T must be visible for code that
  instantiates std::vector<T>.  Reorder code to guarantee this.

Components: Framework

Bug: chromium:1284275
Change-Id: I75a99b5c09cc911f2312aabe85f49aadff84dc51

Reintroduce tests for VK_EXT_color_write_enable extension

Adding tests back in to enable coverage for this feature

VK-GL-CTS Issue: 3759
Components: Vulkan

Affects:
dEQP-VK.pipeline.*.color_write_enable_maxa.cwe_after_bind.*
dEQP-VK.pipeline.*.color_write_enable_maxa.cwe_before_bind.*

Change-Id: Ia43d495097038272df407ac633a05ce729af3ea3

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I590325438900e9a2d08d5abe584d63a50a0781f7

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: Ib404387348df248f2a0a6e50f22813bf004c4935

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I5a2183d155a48675e5ef2edc90f4323fe59a9032

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Id151a00583138c75f0ef53f559a3465dabcfdf6e

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I58b46f7b755b5f731d3865d16b2e248eb0653501

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Idcb4f9a2cb008e61fcfcd45aaed0e31be4cf8e1b

Fix wrong calculation to check diff between floats.

Affects:
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.graphics.*

Components: Vulkan

VK-GL-CTS issue: 3916

Change-Id: I05d2b7375c0bd34b6b7fffabbfe52969009ea218

VK_EXT_pipeline_creation_feedback: Invalid feedback is legal

The tests incorrectly required that
VK_PIPELINE_CREATION_FEEDBACK_VALID_BIT be set in
VkPipelineCreationFeedbackCreateInfo::pPipelineCreationFeedback.
However, the tests already and correctly permit the bit to be unset in
VkPipelineCreationFeedbackCreateInfo::pPipelineStageCreationFeedbacks.

The Vulkan 1.3.225 spec says:
    An implementation should write pipeline creation feedback to
    pPipelineCreationFeedback and may write pipeline stage creation
    feedback to pPipelineStageCreationFeedbacks. An implementation must
    set or clear the VK_PIPELINE_CREATION_FEEDBACK_VALID_BIT in
    VkPipelineCreationFeedback::flags for pPipelineCreationFeedback and
    every element of pPipelineStageCreationFeedbacks.

Components: Vulkan
VK-GL-CTS Issue: 3912
Affects:
dEQP-VK.pipeline.creation_feedback.*

Signed-off-by: Chad Versace <chadversary@google.com>
Change-Id: I4eb37b5888a4d780b4b0b12f9c65960aca9f7806

Stay within the minimum required limit for maxUniformBufferRange

The biggest one was i64vec4 which consumed 128kB. Now it fits within the
16384 byte minimum supported buffer range.

Affects:
dEQP-VK.robustness.buffer_access.vertex.*
dEQP-VK.robustness.buffer_access.fragment.*
dEQP-VK.robustness.buffer_access.compute.*

Components: Vulkan

VK-GL-CTS issue: 3776

Change-Id: Ib71dce12a346bce79a9b719e227cd6ddfb0d64b6

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I46fc9aef51fa742fdaf5159861d3f9f68326cf3d

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: Iaf496a1c9317287562c43d586010ee9cbc744bc8

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: Ib963ea274243454803090094d0ac61136ab8e998

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Ibfc38c618b170dc12bcd04c2db36ed3e0e3b386a

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: If2412675c25225c696d61dec802d76ed8001180e

Fix unsupported condition in memory requirements test

This fixes parantheses to not require VK_KHR_sampler_ycbcr_conversion
extension for non-YCbCr formats

VK-GL-CTS Issue: 3902

Affects: dEQP-VK.memory.requirements.*

Components: Vulkan
Change-Id: I17c58fb1f085e7d32dea9aceb2b9e421990499a5

Fix device_memory_report test

allocation_failed test for VK_EXT_device_memory_report attempts to
allocate UINT64_MAX bytes of memory in order to deliberately trigger
an allocation failure. However, vkAllocateMemory also has VU in which
allocationSize must be less than or equal to
VkPhysicalDeviceMemoryProperties::memoryHeaps[memindex].size .

VK-GL-CTS issue: 3775

Components: Vulkan

Affects:
dEQP-VK.memory.device_memory_report.vk_device_memory.allocation_failed

Change-Id: I0b9db1beb1e7b01d369d5ee6bbfb93c2eb3e1c97

Fix undefined behaviour by allowing NaNs

One graphicsfuzz test contains computations with the float constant 0x1.8p+128.
This constant represents a NaN value. The computation with undef in the test
allows any optimization/triggers undefined behavior and the driver is free
to crash. Adding OpExecutionMode %4 SignedZeroInfNanPreserve 32 to the CTS fixes
this by allowing NaNs.

Affects:
dEQP-VK.graphicsfuzz.cov-instruction-simplify-atanh-log-undefined

Components: Vulkan

VK-GL-CTS issue: 3787

Change-Id: I2442bc4f50add8b8f779dbfae3c5fe2be8fd85f4

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Id9e93b66b2242c3b789e5742b84432c1ba8b355e

Remove non-compliant event wait test

Removed tests:
dEQP-VK.api.command_buffers.record_simul_use_primary
dEQP-VK.api.command_buffers.record_simul_use_secondary

Components: Vulkan

VK-GL-CTS issue: 3432

Change-Id: I297b53dcee56bec69e3abd3693639f64e462a574

Rework platform memory limits

Some OpenGL tests in openglcts and kc_cts used Vulkan platform class to
get the available system / device memory. The memory limits are not
Vulkan related.

This CL moves the getMemoryLimits function to the base class of all
platforms, so the functions can be accessed from openglcts without
referencing any Vulkan files.

Affects:

dEQP-VK.info.memory_limits
dEQP-VK.api.buffer.suballocation.*
dEQP-VK.api.buffer.dedicated_alloc.*
dEQP-VK.api.object_management.*
dEQP-VK.memory.allocation.*
dEQP-VK.memory.device_group_allocation.*
dEQP-VK.pipeline.render_to_image.*.small.*
dEQP-VK.pipeline.render_to_image.*.huge.*

KHR-GL4*.shader_image_load_store.advanced-*

Components:
Vulkan, OpenGL, Framework

VK-GL-CTS issue: 3360

Change-Id: I0743a83148c946d962fd793c8771f2c3c2e33ecc

VK_EXT_pipeline_creation_feedback: Add indentation

No change in behavior.

Add an indentation level to some code. This prepares for the next
commit, making its diff understandable.

Components: Vulkan

Change-Id: I31e5f706ca6f05b42682a862c740bc4953a91f9b

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I80a5e97d6ee8d7d15c8d67de7f084f7f3fd239e0

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I3dcb14db985ef75cff08dae8e346cefd7a27ff19

Adds reset watchdog timer to timeline sempahore tests

Tests go through many iterations which exceeds test
max time when matchdog timer is enabled

Components: Vulkan
VK-GL-CTS Issue: 3884

Affects:
dEQP-VK.synchronization*.basic.timeline_semaphore.chain

Change-Id: Id257b7162d49cfaf5b78c198cdc932f74c0d4a2b

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: I1be609e78cf12d03a7db1430364c332ec1ac37ae

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: If088fd987f51bff07712612cfc9672f1cddd1df6

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I17c7fc7a6c0dde2555e90873105027b0f26e94ad

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: Ia1e9c64b9149680d40e6c2deff9e64725c227439

Improve the error message when storing uncomressed images fails.

It's been ambiguous since the output doesn't have any information when
storing an uncompressed image fails.

Affects:
dEQP-VK.image.texel_view_compatible.compute.basic.*

Components: Vulkan

VK-GL-CTS issue: 3897

Change-Id: I923efb15a9927c87c581dc3c96115b5d6c0b2580