Christian Ulmann [Fri, 7 Apr 2023 12:18:28 +0000 (14:18 +0200)]
[mlir][llvm] Add missing bit manipulation intrs
This commit adds three missing bit manipulation intrinsics.
LangRef: https://llvm.org/docs/LangRef.html#bit-manipulation-intrinsics
Reviewed By: gysit
Differential Revision: https://reviews.llvm.org/D147711
Krishna Narayanan [Fri, 7 Apr 2023 12:08:47 +0000 (08:08 -0400)]
Update static_assert message for redundant cases
There are some simple messages where an expansion isn't particularly
helpful or needed. We aim to eliminate expansions that don't add much
value for user (this will give us slightly more room or prioritise to
have longer diagnostics elsewhere).
The test case for which it has been tested:
```
constexpr auto is_gitlab = false;
constexpr auto is_weekend = false;
static_assert(is_gitlab or is_weekend);
```
Previous warning/error message:
```
<source>:4:1: error: static assertion failed due to requirement 'is_gitlab || is_weekend'
static_assert(is_gitlab or is_weekend);
^ ~~~~~~~~~~~~~~~~~~~~~~~
<source>:4:25: note: expression evaluates to 'false || false'
static_assert(is_gitlab or is_weekend);
~~~~~~~~~~^~~~~~~~~~~~~
```
Currrent warning/error message:
```
<source>:4:1: error: static assertion failed due to requirement 'is_gitlab'
static_assert(is_gitlab or is_weekend);
^ ~~~~~~~~~
```
This patch aims to remove some redundant cases of static assert messages
where the expansions are particularly unhelpful. In this particular
patch, we have ignored the printing of diagnostic warnings for binary
operators with logical OR operations.
This is done to prioritise and prefer to emit longer diagnostic
warnings for more important concerns elsewhere.
Differential Revision: https://reviews.llvm.org/D146376
Clement Courbet [Thu, 10 Nov 2022 09:03:14 +0000 (10:03 +0100)]
[clang-tidy]bugprone-fold-init-type
Handle iterators that do not define a `value_type` type alias.
Get the value type from the return type of `Iter::operator*` instead.
Differential Revision: https://reviews.llvm.org/D137782
Florian Hahn [Fri, 7 Apr 2023 12:11:03 +0000 (13:11 +0100)]
[VPlan] Add VPInterleaveRecipe::NeedsMaskForGaps field (NFCI).
This patch adds a NeedsMaskForGaps field to VPInterleaveRecipe to record
whether a mask for gaps is needed. This removes a dependence on the cost
model in VPlan code-generation.
Reviewed By: Ayal
Differential Revision: https://reviews.llvm.org/D147467
Guillaume Chatelet [Fri, 7 Apr 2023 11:58:20 +0000 (11:58 +0000)]
[libc][NFC] Simplify op_generic
Guillaume Chatelet [Fri, 7 Apr 2023 11:57:39 +0000 (11:57 +0000)]
[libc] Use SFINAE to implement is_signed/is_unsigned
This allows to use the type traits with types that are non constructible from integers.
Guillaume Chatelet [Fri, 7 Apr 2023 11:24:12 +0000 (11:24 +0000)]
[libc] Add value_type to cpp::array
Markus Böck [Fri, 7 Apr 2023 10:29:55 +0000 (12:29 +0200)]
[mlir][ODS] Verify type constraint in `TypeAttrOf`
The current implementation does not verify the type constraint, meaning that any type that happens to be of the same C++ type would pass the verifier.
E.g. a `TypeAttrOf<I64>` would happily accept a `i32` since both satisfy `isa<IntegerType>()`.
This patch fixes that by adding an optional type predicate parameter to `TypeAttrBase` that the type within `TypeAttr` has to satisfy. `TypeAttrOf` then simply passes the predicate of its type parameter as argument.
Differential Revision: https://reviews.llvm.org/D147778
Jay Foad [Fri, 7 Apr 2023 10:07:50 +0000 (11:07 +0100)]
[AMDGPU] Fix comment in SIOptimizeExecMaskingPreRA
Tomás Longeri [Fri, 7 Apr 2023 08:09:12 +0000 (10:09 +0200)]
Fix Bazel build after "Implement Pass and Dialect plugins for mlir-opt"
Differential Revision: https://reviews.llvm.org/D147766
Guillaume Chatelet [Fri, 7 Apr 2023 08:07:51 +0000 (08:07 +0000)]
[libc][NFC] Simplify type_traits
Max Kazantsev [Fri, 7 Apr 2023 07:58:26 +0000 (14:58 +0700)]
[Test] Add one more test on IRCE & regenerate checks
Job Noorman [Fri, 7 Apr 2023 07:47:41 +0000 (09:47 +0200)]
[JITLink][RISCV] ADD/SUB relocs: read value from working memory
The various ADD/SUB relocations work by reading the current value the
relocation points to, transforming it, and then writing it back to
memory. While the current implementation writes the value back to
working memory, it reads the current value from the execution address of
the relocation. This causes at least wrong results, but often crashes,
when the addresses of working memory are not equal to execution
addresses. This patch fixes this by reading the current value from
working memory.
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D147693
Corentin Jabot [Fri, 7 Apr 2023 07:42:54 +0000 (09:42 +0200)]
[Clang] Fix markup in cxx_status
This reverts the changes to cxx_status introduced
by https://reviews.llvm.org/D146178, as it did
break the html markup
While This PR resolves a bug related to concepts,
it doesn't seem useful to change the advertised implementation
of that paper many years after the fact, especially as the
paper encompasses many issue resolution.
YongKang Zhu [Fri, 7 Apr 2023 05:17:35 +0000 (22:17 -0700)]
Fix the two gmoules-prefered-name-* tests
Add missing "REQUIRES: asserts" for the two tests added in commit
711a64412749ae73709562b591ab1609a3ee7751 (Diff: D145803).
Reviewed By: chapuni
Differential Revision: https://reviews.llvm.org/D147764
Kai Sasaki [Fri, 7 Apr 2023 06:55:55 +0000 (15:55 +0900)]
[mlir][affine] Vectorizer test notifies the case with the unparallel loop with reduction
Vectorizer test does not support unparallel loop since no parallel reduction is available. We can emit the informational message instead of crashing the cli in such a case.
Fixes https://github.com/llvm/llvm-project/issues/61842
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D147765
Weining Lu [Fri, 7 Apr 2023 05:38:44 +0000 (13:38 +0800)]
[libunwind][LoongArch] Restore $r1 before $r4 in `jumpto`
$ra should be restored before $a0, otherwise the baseaddress ($a0) would
be destroyed. See file `UnwindRegistersSave.S` for reference.
This also makes libcxx and libcxxabi regtest pass for the `-DLIBCXXABI_USE_LLVM_UNWINDER=ON` build.
Reviewed By: MaskRay, xen0n, #libunwind
Differential Revision: https://reviews.llvm.org/D147372
zhanglimin [Fri, 7 Apr 2023 05:40:58 +0000 (13:40 +0800)]
[libunwind][test] Add test to check for unw_resume()
This is here for local unwinding, which unw_resume() restores
the machine state and then directly resumes execution in the
target stack frame.
Reviewed By: wangleiat
Differential Revision: https://reviews.llvm.org/D147371
Serguei Katkov [Fri, 31 Mar 2023 05:40:42 +0000 (12:40 +0700)]
[InstCombine] Add support for maximum(a,b) + minimum(a,b) => a + b
Unfortunately alive2 cannot prove the correctness due to fails by timeout even for
float type half.
However it should be correct. If a and b are not NaN, maximum and minimum will just
return different values (a and b) and take into account a + b == b + a this is the same.
If a or b is NaN, than maximum and minimum are equal to NaN and NaN + NaN is NaN.
a + b is also a NaN.
In terms of preserving fast flags, we cannot preserve ninf due to
minimum(NaN, Infinity) == maximum(NaN, Infinity) == NaN,
minimum(NaN, Infinity) +ninf maximum(NaN, Infinity) == NaN +ninf NaN = NaN
However transformation will change
minimum(NaN, Infinity) + maximum(NaN, Infinity) to NaN +ninf Infinity == poison.
But if fadd is marked as nnan, we can preserve because NaN +ninf/nnan NaN = poison as well.
The same optimization for
maximum(a,b) * minimum(a,b) => a * b
is added.
All said above for fadd is correct for fmul.
Reviewed By: mkazantsev
Differential Revision: https://reviews.llvm.org/D147299
Lang Hames [Fri, 7 Apr 2023 05:32:21 +0000 (05:32 +0000)]
Revert "[ORC] LLJIT updates: ExecutorNativePlatform, default link order, ..."
This reverts commit
371cb1af61d668234a242b34c773c146cb9077e7, which broke some
unit tests (see e.g. https://lab.llvm.org/buildbot#builders/139/builds/38754).
Serguei Katkov [Fri, 7 Apr 2023 04:16:29 +0000 (11:16 +0700)]
[InstCombine] Add support for max(a,b) + min(a,b) => a + b. Re-land.
The same optimization for
max(a,b) * min(a,b) => a * b
is added.
Correctness check:
uadd: https://alive2.llvm.org/ce/z/2rXDek
sadd: https://alive2.llvm.org/ce/z/zNu_er
uadd + nuw/nsw: https://alive2.llvm.org/ce/z/EaiNjB
sadd + nuw/nsw: https://alive2.llvm.org/ce/z/w_2Nrs
umul: https://alive2.llvm.org/ce/z/dgXRLr
smul: https://alive2.llvm.org/ce/z/hBjGzz
umul + nuw/nsw: https://alive2.llvm.org/ce/z/EaiNjB
smul + nuw/nsw: https://alive2.llvm.org/ce/z/87MNeS
Reviewed By: goldstein.w.n
Differential Revision: https://reviews.llvm.org/D147296
Lang Hames [Thu, 6 Apr 2023 18:28:25 +0000 (18:28 +0000)]
[ORC] LLJIT updates: ExecutorNativePlatform, default link order, Process JD.
This commit includes several related ergonomic improvements to LLJIT.
(1) Adds a default JITDylibSearchOrder to be appended to the initial link order
of JITDylibs created via LLJIT::createJITDylib (dropping any duplicate entries).
This was introduced to support automatic reflection of process symbols (see
(2) below), but has been made visible to clients as it's generically useful,
e.g. if clients have some extra set of libraries that they want to be visible
to JIT'd code by default.
The default JITDylibSearchOrder is only appended to the link order of JITDylibs
created via LLJIT::createJITDylib, and will not be apply to JITDylibs created by
directly calling the underlying ExecutionSession -- in that case clients can set
up the link order manually.
(2) Makes process symbols visible to JIT'd code by default via the new "Process"
JITDylib, which is added to the default link order.
LLJIT clients usually want symbols in the executor process to be accessible to
JIT'd code. Until now clients have been left to set this up themselves by adding
a DynamicLibrarySearchGenerator to the Main JITDylib. This patch adds a new
process symbols JITDylib that will be created by default (with an
EPCDynamicLibrarySearchGenerator attached) and added to the default link order,
making process symbols available to JIT'd code.
Clients who do not want process symbols to be visible to JIT'd code by default
can call setLinkProcessSymbolsByDefault(false) on their LLJITBuilder to disable
this:
LLJITBuilder()
...
.setLinkProcessSymbolsByDefault(false)
...
.create();
Clients can also call setProcessSymbolsJITDylibSetup to take over responsibility
for configuring the process symbols JITDylib (the callback that the client
supplies will be called on the bare process symbols JITDylib immediately after
it is created).
If setLinkProcessSymbolsByDefault(false) is called and no JITDylib setup
callback has been set then the process symbols JITDylib will not be created and
LLJIT::getProcessSymbolsJITDylib will return null.
(3) Adds an ExecutorNativePlatform utility that makes it easier to enable
native platform features.
Some object format features (e.g. native static initializers and thread locals)
require runtime support in the executing process. Support for these features in
ORC is implemented cooperatively between the ORC runtime and the LLVM Platform
subclasses (COFFPlatform, ELFNixPlatform, and MachOPlatform).
ExecutorNativePlatfrom simplifies the process of loading the ORC runtime and
creating the appropriate platform class for the executor process.
ExecutorNativePlatform takes a path to the ORC runtime (or a MemoryBuffer
containing the runtime) and other required runtimes for the executor platform
(e.g. MSVC on Windows) and then configures LLJIT with an appropriate platform
class based on the executor's target triple:
LLJITBuilder()
.setPlatformSetUp(ExecutorNativePlatform("/path/to/orc-runtime.a"));
(The ORC runtime is built as part of compiler-rt, and the exact name of the
archive is platform dependent).
The ORC runtime and platform symbols will be added to a new "Platform" JITDylib,
which will be added to the *front* of the default link order (so JIT'd code will
prefer symbol definitions in the platform/runtime to definitions in the executor
process).
ExecutorNativePlatform assumes that the Process JITDylib is available, as
the ORC runtime may depend on symbols provided by the executor process.
Differential Revision: https://reviews.llvm.org/D144276
Serguei Katkov [Fri, 7 Apr 2023 04:14:28 +0000 (11:14 +0700)]
Revert "[InstCombine] Add support for max(a,b) + min(a,b) => a + b."
Revert commit due to failure on buildbot:
error: 'match_combine_or' may not intend to support class template argument deduction
This reverts commit
b86a06ef284f2637bef89bf5bb20157a8b195568.
Serguei Katkov [Fri, 31 Mar 2023 02:35:06 +0000 (09:35 +0700)]
[InstCombine] Add support for max(a,b) + min(a,b) => a + b.
The same optimization for
max(a,b) * min(a,b) => a * b
is added.
Correctness check:
uadd: https://alive2.llvm.org/ce/z/2rXDek
sadd: https://alive2.llvm.org/ce/z/zNu_er
uadd + nuw/nsw: https://alive2.llvm.org/ce/z/EaiNjB
sadd + nuw/nsw: https://alive2.llvm.org/ce/z/w_2Nrs
umul: https://alive2.llvm.org/ce/z/dgXRLr
smul: https://alive2.llvm.org/ce/z/hBjGzz
umul + nuw/nsw: https://alive2.llvm.org/ce/z/EaiNjB
smul + nuw/nsw: https://alive2.llvm.org/ce/z/87MNeS
Reviewed By: goldstein.w.n
Differential Revision: https://reviews.llvm.org/D147296
Matthias Springer [Fri, 7 Apr 2023 03:02:17 +0000 (12:02 +0900)]
[mlir][tblgen] Emit interface decls in definition order in the .td file
Interface decls were previously sorted by name. This lead to problems when using interface inheritance when both interfaces are defined in the same .td file. The derived interface must appear after the base interface, otherwise the generated C++ will not compile.
With this change, interfaces will compile as long as the base interface is defined before derived interfaces in the .td file.
Differential Revision: https://reviews.llvm.org/D147689
Chia-hung Duan [Thu, 6 Apr 2023 00:08:10 +0000 (00:08 +0000)]
Reland D146570 "[scudo] Switch to use MemMap in tests"
This reverts commit
89cc5304969ded574550e0ad113f59f3d4f50303 and fix the
variable shadowing bug.
Differential Revision: https://reviews.llvm.org/D147672
Matthias Springer [Fri, 7 Apr 2023 02:43:41 +0000 (11:43 +0900)]
[mlir][SCF] ValueBoundsOpInterface: Support `scf.for` results and iter_args
If an `scf.for` loop yields an equal index-typed value or a shaped value with the same dimension sizes (in comparison to the corresponding iter_arg), bounds can be computed for the iter_arg and the OpResult of the `scf.for` op.
Differential Revision: https://reviews.llvm.org/D146306
Lang Hames [Thu, 6 Apr 2023 19:10:33 +0000 (19:10 +0000)]
[ORC] Add a JITDylib::addToLinkOrder convenience method.
This appends the given JITDylibSearchOrder to the JITDylib's existing one.
Matthias Springer [Fri, 7 Apr 2023 02:33:55 +0000 (11:33 +0900)]
[mlir][Interfaces] ValueBoundsOpInterface: Compute constant bounds
Add a helper function that computes a constant (`int64_t`) bound. The `stopCondition` is optional: If none is provided, the traversal continues until a constant bound could be computed.
Differential Revision: https://reviews.llvm.org/D146296
Matthias Springer [Fri, 7 Apr 2023 02:05:14 +0000 (11:05 +0900)]
[mlir][linalg] ValueBoundsOpInterface: Add LinalgOps
Also add a few more complex test cases.
Differential Revision: https://reviews.llvm.org/D145806
Mehdi Amini [Fri, 7 Apr 2023 02:11:11 +0000 (19:11 -0700)]
Revert "[mlir][sparse][gpu] end-to-end example with sparse GPU pipeline"
This reverts commit
bf94afa10e5101f401f191f0386a9316cf0a5cda.
The bot is broken: https://lab.llvm.org/buildbot/#/builders/61/builds/42062
Mehdi Amini [Fri, 7 Apr 2023 02:10:28 +0000 (19:10 -0700)]
Revert "[mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs"
This reverts commit
a2c63d7f0b77ae92c97974d0630625d83a0745ce.
The bot is broken: https://lab.llvm.org/buildbot/#/builders/61/builds/42062
Matthias Springer [Fri, 7 Apr 2023 01:56:18 +0000 (10:56 +0900)]
[mlir][SCF] Add ValueBoundsOpInterface impl for scf.for
Only induction variables are supported. iter_args will be supported in a
subsequent change.
Differential Revision: https://reviews.llvm.org/D145804
Matthias Springer [Fri, 7 Apr 2023 01:47:22 +0000 (10:47 +0900)]
[mlir][Interfaces] ValueBoundsOpInterface: Support LB and UB bounds
This change also adds support for `affine.min` and `affine.max` ops.
Differential Revision: https://reviews.llvm.org/D145787
Matthias Springer [Fri, 7 Apr 2023 01:33:13 +0000 (10:33 +0900)]
[mlir][tensor] Fix gcc build (ValueBoundsOpInterface)
The order of evaluation of a sum (e.g., `a() + b()`) is unspecified in
C++. clang evaluates left-to-right. gcc evaluate right-to-left. This led
to slighly different (but equivalent) affine_map in a test and the
FileCheck did not match anymore.
Fabian Mora [Fri, 7 Apr 2023 00:01:00 +0000 (17:01 -0700)]
Implement Pass and Dialect plugins for mlir-opt
Implementation of Pass and Dialect Plugins that mirrors LLVM Pass Plugin
implementation from the new pass manager.
Currently the implementation only supports using the pass-pipeline option
for adding passes. This restriction is imposed by the `PassPipelineCLParser`
variable in mlir/lib/Tools/mlir-opt/MlirOptMain.cpp:114 that loads the
parse options statically before parsing the cmd line args.
```
mlir-opt stanalone-plugin.mlir --load-dialect-plugin=lib/libStandalonePlugin.so --pass-pipeline="builtin.module(standalone-switch-bar-foo)"
```
Reviewed By: rriddle, mehdi_amini
Differential Revision: https://reviews.llvm.org/D147053
Mehdi Amini [Fri, 7 Apr 2023 01:28:11 +0000 (18:28 -0700)]
Revert "Implement Pass and Dialect plugins for mlir-opt"
This reverts commit
e9b415870dc3036f989c03eb553473aed614658a.
This landed without the right authorship.
Mehdi Amini [Fri, 7 Apr 2023 00:01:00 +0000 (17:01 -0700)]
Implement Pass and Dialect plugins for mlir-opt
Implementation of Pass and Dialect Plugins that mirrors LLVM Pass Plugin implementation from the new pass manager.
Currently the implementation only supports using the pass-pipeline option for adding passes. This restriction is imposed by the `PassPipelineCLParser` variable in mlir/lib/Tools/mlir-opt/MlirOptMain.cpp:114 that loads the parse options statically before parsing the cmd line args.
```
mlir-opt stanalone-plugin.mlir --load-dialect-plugin=lib/libStandalonePlugin.so --pass-pipeline="builtin.module(standalone-switch-bar-foo)"
```
Reviewed By: rriddle
Differential Revision: https://reviews.llvm.org/D147053
Ruiling Song [Thu, 6 Apr 2023 06:31:55 +0000 (14:31 +0800)]
AMDGPU: mark SET_INACTIVE_* as convergent operation
set_inactive is actually a kind of operation that is passing certain
value from active threads to inactive threads. In later WWM operation,
the activated threads which were disabled before would read such
values passed to them by set_inactive operation. So I think the
set_inactive is a convergent operation.
Differential Revision: https://reviews.llvm.org/D147683
Ruiling Song [Thu, 6 Apr 2023 06:04:50 +0000 (14:04 +0800)]
AMDGPU: Add a test to show bad compilation to set_inactive
The set_inactive was originally inside a if branch, but was incorrectly
hoisted out of the loop. So the lanes that were disabled later after the
if() branch inside the loop were not set correctly. It should stay in
the if branch.
Differential Revision: https://reviews.llvm.org/D147682
Richard Smith [Fri, 7 Apr 2023 00:50:46 +0000 (17:50 -0700)]
Reject attempts to initialize non-aggregate types from a designated
initializer list.
This previously led to some weird behaviors where we would unwrap the
initializer list expression and then try to use the DesignatedInitExprs
as constructor arguments.
Under the C++20 language rules, it's not valid to initialize a
reference-to-aggregate from a designated initializer list, but we have
historically accepted that, as do other compilers, and we continue to
accept that with this change. I've asked WG21 whether this should be
considered a wording defect.
LiaoChunyu [Fri, 7 Apr 2023 00:37:21 +0000 (08:37 +0800)]
[RISCV] Add DAG combine to fold (sub 0, (setcc x, 0, setlt)) -> (sra x , xlen - 1)
The result of sub + setcc is 0 or 1 for all bits.
The sra instruction get the same result.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D147538
Ben Shi [Mon, 3 Apr 2023 07:58:39 +0000 (15:58 +0800)]
[LoongArch] Optimize multiplication with immediates
Optimize "(mul r, c)" to "(SLLI (ALSL r, r, i0), i1)", in which
"c = (1 + (1 << i0)) << i1".
Reviewed By: SixWeining
Differential Revision: https://reviews.llvm.org/D147428
Ben Shi [Mon, 3 Apr 2023 07:29:32 +0000 (15:29 +0800)]
[LoongArch][NFC] Add tests of multiplication with immediates (for D147428)
Reviewed By: SixWeining
Differential Revision: https://reviews.llvm.org/D147427
Michael Buch [Thu, 6 Apr 2023 10:06:54 +0000 (11:06 +0100)]
[ReleaseNotes] DebugInfo: preferred_name attribute changes
Describes changes made in D145803.
Differential Revision: https://reviews.llvm.org/D147695
Michael Buch [Sat, 11 Mar 2023 00:48:53 +0000 (00:48 +0000)]
[lldb][test] Add tests for clang::PreferredNameAttr formatting
Add some tests to make sure we're formatting structures
with preferred names correctly.
Differential Revision: https://reviews.llvm.org/D145832
Michael Buch [Fri, 10 Mar 2023 16:46:47 +0000 (16:46 +0000)]
[clang][DebugInfo] Emit DW_AT_type of preferred name if available
With this patch, whenever we emit a `DW_AT_type` for some declaration
and the type is a template class with a `clang::PreferredNameAttr`, we
will emit the typedef that the attribute refers to instead. I.e.,
```
0x123 DW_TAG_variable
DW_AT_name "var"
DW_AT_type (0x123 "basic_string<char>")
0x124 DW_TAG_structure_type
DW_AT_name "basic_string<char>"
```
...becomes
```
0x123 DW_TAG_variable
DW_AT_name "var"
DW_AT_type (0x124 "std::string")
0x124 DW_TAG_structure_type
DW_AT_name "basic_string<char>"
0x125 DW_TAG_typedef
DW_AT_name "std::string"
DW_AT_type (0x124 "basic_string<char>")
```
We do this by returning the preferred name typedef `DIType` when
we create a structure definition. In some cases, e.g., with `-gmodules`,
we don't complete the structure definition immediately but do so later
via `completeClassData`, which overwrites the `TypeCache`. In such cases
we don't actually want to rewrite the cache with the preferred name. We
handle this by returning both the definition and the preferred typedef
from `CreateTypeDefinition` and let the callee decide what to do with
it.
Essentially we set up the types as:
```
TypeCache[Record] => DICompositeType
ReplaceMap[Record] => DIDerivedType(baseType: DICompositeType)
```
For now we keep this behind LLDB tuning.
**Testing**
- Added clang unit-test
- `check-llvm`, `check-clang` pass
- Confirmed that this change correctly repoints
`basic_string` references in some of my test programs.
- Will add follow-up LLDB API tests
Differential Revision: https://reviews.llvm.org/D145803
Alex Langford [Thu, 6 Apr 2023 21:47:29 +0000 (14:47 -0700)]
[lldb][NFC] Delete unused function Breakpoint::GetEventIdentifier
This is unused
Differential Revision: https://reviews.llvm.org/D147746
Caslyn Tonelli [Mon, 3 Apr 2023 21:56:49 +0000 (21:56 +0000)]
[libc] Add strxfrm Implementation
Introduce `strxfrm` and unit tests. The current implementation is
introduced without locale support.
The simplified function performs a `memcpy` if the `n` value is large
enough to store the source len + '\0', otherwise `dest` is unmodified.
Ticket: https://fxbug.dev/124217
Differential Revision: https://reviews.llvm.org/D147478
Lang Hames [Fri, 7 Apr 2023 00:00:51 +0000 (17:00 -0700)]
[ORC-RT] Fix testcase after
4c7f53b99c0.
4c7f53b99c0 changed the debug logging for GDB registration. This testcase just
needed to be updated to look for the new string.
Alexey Bataev [Thu, 6 Apr 2023 18:02:10 +0000 (11:02 -0700)]
[SLP][NFC]Make adjustExtracts/needToDelay members of ShuffleInstructionBuilder.
Make adjustExtracts/needToDelay lambdas members of ShuffleInstructionBuilder to allow to overload them later for cost model.
Differential Revision: https://reviews.llvm.org/D147730
Michael Maitland [Mon, 27 Mar 2023 20:14:38 +0000 (13:14 -0700)]
[LV][NFC] Improve complexity of fixing users of recurrences
The original loop has O(MxN) since `is_contained` iterates over
all incoming values. This change makes it so only the phis
which use the value as an incoming value are iterated over so
it is now O(M).
Differential Revision: https://reviews.llvm.org/D146999
Richard Smith [Thu, 6 Apr 2023 22:22:06 +0000 (15:22 -0700)]
Revert "Revert "[Modules] Remove unnecessary check when generating name lookup table in ASTWriter""
This re-lands commit
db987b9589be1eb604fcb74c85b410469e31485f,
previously reverted in commit
1e0709167f5edd330889f51bb203c458bdb5e359,
with a fix for a pre-existing bug in how we write constructor names into
lookup tables that was exposed by that change.
As yet, we've been unable to produce a reduced testcase for this bug,
but we understand the problem: if we write out a lookup table for a
class which has two constructor names, and we only have local lookup
results for one of those constructor names, then we will write out a
lookup table where the "all the constructors" lookup result contains
results for only one of the constructor names.
Jonas Devlieghere [Thu, 6 Apr 2023 19:47:14 +0000 (12:47 -0700)]
[lldb] Add an LLDB_DEPRECATED macro similar to LLVM_DEPRECATED
Add an LLDB_DEPRECATED macro similar to LLVM_DEPRECATED. We cannot
directly reuse the LLVM one, because it's defined in Compiler.h which is
not something we can include in the SB API.
For the SB API, the macro is undef'd if:
1. We're building the SWIG bindings. We might still want to expose
deprecated methods to our scripting users.
2. We're targeting anything older than C++14 as the [[deprecated]]
attribute was added for C++14 and the SB API can be used by
projects compiling against an older language version.
Differential revision: https://reviews.llvm.org/D147736
Shafik Yaghmour [Thu, 6 Apr 2023 21:40:39 +0000 (14:40 -0700)]
[Clang][Attributes] Add MeaningfulToClassTemplateDefinition to unavailable attribute
There may be cases in which we want to diagnose a type as unavailable but it may
not be complete at the time. Setting MeaningfulToClassTemplateDefinition fixes
this issue.
This fixes: https://github.com/llvm/llvm-project/issues/61815
Differential Revision: https://reviews.llvm.org/D147495
Dave Lee [Thu, 6 Apr 2023 20:50:05 +0000 (13:50 -0700)]
[lldb] Rename test module.map files to module.modulemap (NFC)
The name `module.modulemap` is convention.
> Clang will also search for a file named `module.map`. This behavior is deprecated and
> we plan to eventually remove it.
Florian Hahn [Thu, 6 Apr 2023 20:16:37 +0000 (21:16 +0100)]
[LV] Move conditional MaskForGaps construction to load case.
Conditionally setting MaskForGaps is only needed for loads. This avoid
re-computing MaskForGaps for stores.
Suggested as independent cleanup in D147467.
max [Thu, 6 Apr 2023 20:07:12 +0000 (15:07 -0500)]
Add gpu::HostUnregisterOp
Without explicitly unregistering you will get
```
'cuMemHostRegister(ptr, sizeBytes, 0)' failed with 'CUDA_ERROR_HOST_MEMORY_ALREADY_REGISTERED'
```
in CUDA (for example) after repeated runs (e.g., during benchmarking the same kernel).
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D147277
Alexey Bataev [Thu, 6 Apr 2023 18:56:19 +0000 (11:56 -0700)]
[SLP][NFC]Evaluate FMF for reductions before the loop, no need to
reevaluate it.
Robert Suderman [Thu, 6 Apr 2023 18:33:29 +0000 (18:33 +0000)]
[mlir][math] Update math arith expansions for vectorization
The math arithmetic expansions do not support vectorized types.
Updated the lowerings so that they support vectorized types. This
includes a different implementation for `math.ctlz` to be a binary
search and not have variable termination time.
Reviewed By: jpienaar, NatashaKnk
Differential Revision: https://reviews.llvm.org/D147289
Anna Thomas [Thu, 6 Apr 2023 18:35:02 +0000 (14:35 -0400)]
Precommit test from D147662
Robert Suderman [Thu, 6 Apr 2023 18:23:52 +0000 (18:23 +0000)]
[mlir][arith] Add expansion pattern for ext/trunc of bf16
bf16 has a trivial truncation/extension behavior with F32 that
can be described in elementary arith operations. Include some
expansions to efficiently convert including rounding towards
infinity for f32 to bf16 truncation.
Reviewed By: jpienaar
Differential Revision: https://reviews.llvm.org/D147585
Min-Yih Hsu [Mon, 3 Apr 2023 20:18:17 +0000 (13:18 -0700)]
[M68k] Add subtarget features for M68881/2 FPU
Note that technically both M68000/010 can use M68881, despite the fact
that usually only M68020 and newer ISAs are equipped with M68881/2.
M68040 and newer processors have builtin M68882.
Differential Revision: https://reviews.llvm.org/D147479
Alex Brachet [Thu, 6 Apr 2023 17:48:28 +0000 (17:48 +0000)]
[libc] Implement strsep
Differential Revision: https://reviews.llvm.org/D147503
Jonas Devlieghere [Thu, 6 Apr 2023 17:27:06 +0000 (10:27 -0700)]
[lldb] Add an overload to SetModuleLoadAddress that takes an unsigned value
Currently, SBTarget::SetModuleLoadAddress does not accept large slides
needed to load images in high memory. This function should always have
taken an unsigned as the slide, as it immediately passes it to
Target::SetSectionLoadAddress which takes an unsigned.
This patch adds an overload and exposes that to SWIG instead of the
signed variant. I've marked the signed variant as deprecated and added
check that the slide is positive.
rdar://
101355155
Differential revision: https://reviews.llvm.org/D147482
Alexey Bataev [Thu, 6 Apr 2023 13:03:03 +0000 (06:03 -0700)]
[SLP]Fix emission of the masks in shuffles for undefs.
If the value is used in the expression, need to adjust the mask before
applying the mask. Plus, need to fix the analysis of the phi nodes for
reused scalars.
Ilya Biryukov [Thu, 6 Apr 2023 16:59:45 +0000 (18:59 +0200)]
[Sema] Populate declarations inside TypeLocs for some invalid types
This also reverts
282cae0b9a602267ad7ef622f770066491332a11 as the
particular crash is now handled by the new code.
Before this change Clang would always leave declarations inside the
type-locs as `null` if the declarator had an invalid type. This patch
populates declarations even for invalid types if the structure of the
type and the type-locs match.
There are certain cases that may still cause crashes. These happen when
Clang recovers the type in a way that is not reflected in the
declarator's structure, e.g. adding a pointer when it was not present in
the code for ObjC interfaces or ignoring pointers written in the code
in C++ with auto return type (`auto* foo() -> int`). Those cases look
fixable with a better recovery strategy and I plan to follow up with
more patches to address those.
The first attempt caused 31 tests from `check-clang` to crash due to
different structure of the types and type-locs after certain errors. The
good news is that the failure is localized and mismatch in structures is
discovered by assertions inside `DeclaratorLocFiller`. Some notable
cases caught by existing tests:
- Invalid chunks when type is fully ignored and replace with int or now.
Crashed in `C/C2x/n2838.c`.
- Invalid return types in lambdas. Crashed in `CXX/drs/dr6xx.cpp`.
- Invalid member pointers. Crashed in `CXX/dcl.dcl/dcl.spec/dcl.type/dcl.spec.auto/p3-generic-lambda-1y.cpp`
- ObjC recovery that adds pointers. Crashed in `SemaObjC/blocks.m`
This change also updates the output of `Index/complete-blocks.m`.
Not entirely sure what causes the change, but the new function signature
is closer to the source code, so this seems like an improvement.
Reviewed By: aaron.ballman, erichkeane
Differential Revision: https://reviews.llvm.org/D146971
Keith Smiley [Wed, 5 Apr 2023 21:46:06 +0000 (14:46 -0700)]
[lld-macho] Add new -reproducible flag
As of Xcode 14.3 it passes -reproducible by default to ld64. It seems
this flag was added in ld64 with Xcode 14.0, but it is not documented.
Through my testing the only thing I have seen it do is the same as
ZERO_AR_DATE, but it's possible it does more, or will do more in the
future. Since we already default to this option, this is more about
handling the command line flag to maintain Xcode compatibility than
anything else.
Differential Revision: https://reviews.llvm.org/D147663
aabhinavg [Sun, 26 Mar 2023 05:57:46 +0000 (11:27 +0530)]
[Docs][typo] Done the required fix for the #61690
Differential Revision: https://reviews.llvm.org/D146898
Jacques Pienaar [Thu, 6 Apr 2023 16:41:22 +0000 (09:41 -0700)]
Revert "Implement Pass and Dialect plugins for mlir-opt"
Breaks bot.
This reverts commit
d4c873b044aeebaa43e6989fb1f9606530ec60cf.
Luke Lau [Wed, 5 Apr 2023 12:14:51 +0000 (13:14 +0100)]
[RISCV] Lower scalar_to_vector
Loads of fixed length vectors with irregular element counts are
sometimes emitted as a scalar load + scalar_to_vector.
Previously the scalar_to_vector wasn't legal and so was scalarized
further. This patch handles it by lowering it to a vmv.s.x.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D147608
Luke Lau [Wed, 5 Apr 2023 10:02:41 +0000 (11:02 +0100)]
[RISCV] Add tests for loads and stores of illegal fixed length vectors
I was investigating why getMemoryOpCost was so expensive for these fixed length vector types, so I've added these tests to see what was going on.
It looks like there's some room for codegen improvement before we adjust the cost model.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D147607
Nikita Popov [Thu, 6 Apr 2023 16:29:32 +0000 (18:29 +0200)]
[InstCombine] Regenerate all test checks (NFC)
Due to an improvement to name preservation, a lot of InstCombine
tests now show spurious diffs when regenerated.
Rather than regenerating individual files when they get touched,
mass-regenerate all UTC-based InstCombine tests. I have then reset
a number of files showing suspicious diffs where the UTC output
has clearly been manually adjusted. I apologize if I missed
anything in the mass of changes.
Nico Weber [Thu, 6 Apr 2023 16:35:44 +0000 (12:35 -0400)]
Revert "[AMDGPU] Add Lower Bound to PipelineSolver"
This reverts commit
3c42a58c4f20ae3b621733bf5ee6d57c912994a9.
Breaks tests on mac, see https://reviews.llvm.org/rG3c42a58c4f20ae3b621733bf5ee6d57c912994a9#1191724
Fabian Mora [Thu, 6 Apr 2023 16:09:00 +0000 (09:09 -0700)]
Implement Pass and Dialect plugins for mlir-opt
Implementation of Pass and Dialect Plugins that mirrors LLVM Pass Plugin implementation from the new pass manager.
Currently the implementation only supports using the pass-pipeline option for adding passes. This restriction is imposed by the `PassPipelineCLParser` variable in mlir/lib/Tools/mlir-opt/MlirOptMain.cpp:114 that loads the parse options statically before parsing the cmd line args.
```
mlir-opt stanalone-plugin.mlir --load-dialect-plugin=lib/libStandalonePlugin.so --pass-pipeline="builtin.module(standalone-switch-bar-foo)"
```
Reviewed By: rriddle
Differential Revision: https://reviews.llvm.org/D147053
Craig Topper [Thu, 6 Apr 2023 16:33:01 +0000 (09:33 -0700)]
[RISCV] Use PseudoInstExpansion for PseudoReadVLENB and PseudoReadVL. NFC
This lets tablegen generated the code and avoids a string lookup
of the CSR name at runtime.
Lang Hames [Thu, 6 Apr 2023 04:14:45 +0000 (04:14 +0000)]
[ORC][ORC-RT][ELF] Move selection of eh-frame registration APIs into orc-rt.
ORC's ELF platform support prefers the newer libunwind registration functions
(__unw_add_dynamic_eh_frame_section, __unw_remove_dynamic_eh_frame_section) when
they're available, and falls back to the older registration functions
(__register_frame, __deregister_frame) when they're not.
Until now the choice of registration functions has been made on the controller
side in ELFNixPlatform: The platform JITDylib was searched for the registration
functions and aliases set depending on which ones were found. This patch drops
that selection logic from ELFNixPlatform and instead uses weak imports of the
registration functions in elfnix_platform.cpp to identify which ones are
available and choose which ones to use.
This has a few small benefits:
(1) The registration functions don't need to be defined in the same JITDylib as
the ORC runtime -- it's sufficient for them to be defined in a JITDylib that the
ORC runtime's JITDylib links against.
(2) THe elfnix_platfrom code is more readable, as we don't have to dig into
ELFNixPlatform.cpp on the controller side to discover the definition of the
registration aliases.
(3) We may save a separate round-trip to look up the registration APIs (the
lookup will be folded into the ordinary external symbol lookup when linking the
runtime).
Nico Weber [Thu, 6 Apr 2023 16:27:47 +0000 (12:27 -0400)]
[gn] port
f3d9abf1f87c more (use X86GenFoldTables.inc)
Mahesh Ravishankar [Thu, 6 Apr 2023 16:10:45 +0000 (16:10 +0000)]
[mlir][LLVM] Add an attribute to control use of bare-pointer calling convention.
Currently the use of bare pointer calling convention is controlled
globally through use of an option in the `LLVMTypeConverter`. To allow
more fine-grained control use an attribute on a function to drive the
calling convention to use.
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D147494
Alexey Bataev [Thu, 6 Apr 2023 15:20:19 +0000 (08:20 -0700)]
[SLP]Fix delete of the extractelement with users.
Made the condition for the erasing of the gathered extractelements
stricter, remove it only if it has single vectorized use, otherwise
leave it for instcombiner/instsimplify analysis.
Philip Reames [Thu, 6 Apr 2023 16:13:10 +0000 (09:13 -0700)]
[LAA] Cleanup casting in replaceSymbolicStrideSCEV [nfc]
Nico Weber [Thu, 6 Apr 2023 16:10:45 +0000 (12:10 -0400)]
[gn] port
f3d9abf1f87c (use X86GenFoldTables.inc)
Joe Nash [Wed, 5 Apr 2023 21:13:22 +0000 (17:13 -0400)]
[AMDGPU] NFC. Make preserve-hi16.ll test auto-generated
Akshay Baviskar [Thu, 6 Apr 2023 05:20:51 +0000 (10:50 +0530)]
[MLIR][Affine] Fix generateUnrolledLoop utility
generateUnrolledLoop was assuming that the yielded value is always generated in
the Block corresponding to the loop being unrolled. Thus, it was updating the
last yielded values with it's cloned value. However, if the yielded value is not
generated in the same Block then the cloned value and it's corresponding mapping
won't exist, resulting in a crash. Fix this.
Reviewed By: bondhugula
Differential Revision: https://reviews.llvm.org/D146931
Vimal Patel [Thu, 6 Apr 2023 05:14:43 +0000 (10:44 +0530)]
Emit error message instead of asserting
test-affine-parametric-tile pass was crashing on an incorrect input.
Instead it should emit an error message and exit.
Fixes: https://github.com/llvm/llvm-project/issues/61528
Reviewed By: mehdi_amini, bondhugula
Differential Revision: https://reviews.llvm.org/D147595
Valentin Clement [Thu, 6 Apr 2023 15:40:34 +0000 (08:40 -0700)]
[flang][NFC] Update polymorphic design document to reflect implementation
Update the design document to reflect the actual implementation
of polymorphic entities.
Reviewed By: jeanPerier, PeteSteinfeld
Differential Revision: https://reviews.llvm.org/D147665
OCHyams [Thu, 6 Apr 2023 15:32:58 +0000 (16:32 +0100)]
Revert (2) "[Assignment Tracking] Enable by default"
Revert D146987 for the 2nd time.
This reverts commit
91a0740474e3c4fe0bde8ff5699115bf808ca23f
Buildbot: https://lab.llvm.org/buildbot/#/builders/70/builds/36007
Philip Reames [Thu, 6 Apr 2023 15:23:08 +0000 (08:23 -0700)]
[LAA] Continue moving utilities to sole use to isolate symbolic stride reasoning [nfc]
Philip Reames [Thu, 6 Apr 2023 15:11:48 +0000 (08:11 -0700)]
[LV] Remove a cover function with a single use [nfc]
And more importantly, move the fixme to the sole caller where it actually makes sense in context.
Matthias Springer [Thu, 6 Apr 2023 14:55:43 +0000 (23:55 +0900)]
[mlir][arith] Fix CMake build
Dávid Bolvanský [Thu, 6 Apr 2023 14:54:26 +0000 (16:54 +0200)]
Revert "[InlineCost] isKnownNonNullInCallee - handle also dereferenceable attribute"
This reverts commit
3b5ff3a67c1f0450a100dca34d899ecd3744cb36.
Dávid Bolvanský [Thu, 6 Apr 2023 14:54:00 +0000 (16:54 +0200)]
Dávid Bolvanský [Thu, 6 Apr 2023 14:50:16 +0000 (16:50 +0200)]
[AttrDocs] Enhance musttail attribute documentation
Based on info from https://github.com/llvm/llvm-project/issues/54964
Dávid Bolvanský [Thu, 6 Apr 2023 09:09:51 +0000 (11:09 +0200)]
xxx
Dávid Bolvanský [Thu, 6 Apr 2023 08:02:38 +0000 (10:02 +0200)]
[InlineCost] isKnownNonNullInCallee - handle also dereferenceable attribute
OCHyams [Thu, 6 Apr 2023 14:26:11 +0000 (15:26 +0100)]
Reapply "[Assignment Tracking] Enable by default"
Re-land D146987.
This reverts commit
43825d19318695be48abe6f042369da00fbb808b (revert)
which reverts
aa32490bfe0b957c4f5583e14304f5e34b2b9bce (original commit).
OCHyams [Thu, 6 Apr 2023 13:23:19 +0000 (14:23 +0100)]
[Assignment Tracking][SROA] Fix fragment when slice size equals variable size
Correctly handle the case of splitting an alloca which backs contiguous
distinct variables, where a slice's size equals the size of a backed variable.
We need to ensure that we don't generate fragments expressions with fragments
of the same size as the variable as this is a verifier error.
Prior to this patch a fragment expression would be created in this
situation. e.g. splitting an alloca i64 with two adjacent 32-bit variables into
two 32-bit allocas, the new dbg.assign expressions would contain
(DW_OP_LLVM_fragment, 0, 32) and (DW_OP_LLVM_fragment, 32, 32) even though
those fragments cover each variable entirely.
Reviewed By: jmorse
Differential Revision: https://reviews.llvm.org/D147696
Alexis Engelke [Fri, 10 Mar 2023 14:20:30 +0000 (15:20 +0100)]
[MC] Always encode instruction into SmallVector
All users of MCCodeEmitter::encodeInstruction use a raw_svector_ostream
to encode the instruction into a SmallVector. The raw_ostream however
incurs some overhead for the actual encoding.
This change allows an MCCodeEmitter to directly emit an instruction into
a SmallVector without using a raw_ostream and therefore allow for
performance improvments in encoding. A default path that uses existing
raw_ostream implementations is provided.
Reviewed By: MaskRay, Amir
Differential Revision: https://reviews.llvm.org/D145791
Aaron Ballman [Thu, 6 Apr 2023 13:52:39 +0000 (09:52 -0400)]
Fix a failed assertion when dumping the AST to JSON
We were trying to mangle templated names and the Microsoft mangler does
not have an implementation for mangling dependent names. Instead, we
now skip trying to print the mangled name if the AST node is still a
templated node rather than a fully resolved node.
Fixes https://github.com/llvm/llvm-project/issues/61440
NAKAMURA Takumi [Thu, 6 Apr 2023 13:27:20 +0000 (22:27 +0900)]
[Bazel] Rework llvm-tblgen for X86ManualFoldTables.def
It is easier to introduce header-only library.