platform/upstream/libSkiaSharp.git
11 years agorebaseline convex paths after test was changed.
bsalomon@google.com [Thu, 15 Aug 2013 19:49:42 +0000 (19:49 +0000)]
rebaseline convex paths after test was changed.

git-svn-id: http://skia.googlecode.com/svn/trunk@10750 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotemporary kES2_GrGLBinding alias to unblock DEPS roll
bsalomon@google.com [Thu, 15 Aug 2013 19:45:26 +0000 (19:45 +0000)]
temporary kES2_GrGLBinding alias to unblock DEPS roll

git-svn-id: http://skia.googlecode.com/svn/trunk@10749 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomissing header from previous commit
bsalomon@google.com [Thu, 15 Aug 2013 18:57:53 +0000 (18:57 +0000)]
missing header from previous commit

git-svn-id: http://skia.googlecode.com/svn/trunk@10748 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRename kES2_GrGLBinding to kES_GrGLBinding. Step 0 for supporting ES3.
bsalomon@google.com [Thu, 15 Aug 2013 18:54:39 +0000 (18:54 +0000)]
Rename kES2_GrGLBinding to kES_GrGLBinding. Step 0 for supporting ES3.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23185004

git-svn-id: http://skia.googlecode.com/svn/trunk@10747 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline GMs for Galaxy Nexus: looks like updated fonts and some GMs out of date.
jvanverth@google.com [Thu, 15 Aug 2013 18:24:53 +0000 (18:24 +0000)]
Rebaseline GMs for Galaxy Nexus: looks like updated fonts and some GMs out of date.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10746 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnable coverage when drawing to the stencil buffer.
commit-bot@chromium.org [Thu, 15 Aug 2013 18:16:41 +0000 (18:16 +0000)]
Enable coverage when drawing to the stencil buffer.

Currently, we set kEmitTransBlack_BlendOptFlag when drawing to the stencil buffer - but that
prevents masks from being drawn correctly as they receive full coverage and no fragments get
discarded.

R=bsalomon@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23197003

git-svn-id: http://skia.googlecode.com/svn/trunk@10745 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix repeated point quads/cubics in convex pr and update convexpaths GM
commit-bot@chromium.org [Thu, 15 Aug 2013 18:16:27 +0000 (18:16 +0000)]
Fix repeated point quads/cubics in convex pr and update convexpaths GM

R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/23034003

git-svn-id: http://skia.googlecode.com/svn/trunk@10744 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd missing fallback blending to SkA8_Shader_Blitter::blitMask()
commit-bot@chromium.org [Thu, 15 Aug 2013 18:16:07 +0000 (18:16 +0000)]
Add missing fallback blending to SkA8_Shader_Blitter::blitMask()

Similarly to SkA8_Shader_Blitter::blitAntiH() and SkA8_Shader_Blitter::blitH(), blitMask() should handle a missing SkXfermode gracefully.

R=reed@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22867008

git-svn-id: http://skia.googlecode.com/svn/trunk@10743 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline GMs for Nexus-10: looks like fonts changed due to OS upgrade.
jvanverth@google.com [Thu, 15 Aug 2013 18:15:20 +0000 (18:15 +0000)]
Rebaseline GMs for Nexus-10: looks like fonts changed due to OS upgrade.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10742 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoone more flakly GL_LINES win7/intel/gpu test to ignore
bsalomon@google.com [Thu, 15 Aug 2013 17:42:33 +0000 (17:42 +0000)]
one more flakly GL_LINES win7/intel/gpu test to ignore

git-svn-id: http://skia.googlecode.com/svn/trunk@10741 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExpect to fail on images with GL_LINES snapping issue on win7/intel/gpu
bsalomon@google.com [Thu, 15 Aug 2013 17:10:28 +0000 (17:10 +0000)]
Expect to fail on images with GL_LINES snapping issue on win7/intel/gpu

git-svn-id: http://skia.googlecode.com/svn/trunk@10740 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotry one last time for xfermodes3 pdf rebaselines, will delete if this doesn't stick
bsalomon@google.com [Thu, 15 Aug 2013 15:40:31 +0000 (15:40 +0000)]
try one last time for xfermodes3 pdf rebaselines, will delete if this doesn't stick

git-svn-id: http://skia.googlecode.com/svn/trunk@10739 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Unpremultiply SkBitmaps for PDF output"
scroggo@google.com [Thu, 15 Aug 2013 14:51:04 +0000 (14:51 +0000)]
Revert "Unpremultiply SkBitmaps for PDF output"

This reverts commit 16a6c9d28c8ef6f827d50ef258005fa5ec971bd9.

Seems to be breaking all of the windows debug bots in GM.

git-svn-id: http://skia.googlecode.com/svn/trunk@10737 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline Ubuntu after revert of r10705 (in r10729)
robertphillips@google.com [Thu, 15 Aug 2013 14:16:52 +0000 (14:16 +0000)]
Rebaseline Ubuntu after revert of r10705 (in r10729)

git-svn-id: http://skia.googlecode.com/svn/trunk@10731 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPerformance trigger rebaselines
robertphillips@google.com [Thu, 15 Aug 2013 13:55:00 +0000 (13:55 +0000)]
Performance trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10730 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r10705 (ARM Skia NEON patches - 04 - Clean SkFixed / SkLONGLONG) due to 1000...
robertphillips@google.com [Thu, 15 Aug 2013 13:43:23 +0000 (13:43 +0000)]
Revert r10705 (ARM Skia NEON patches - 04 - Clean SkFixed / SkLONGLONG) due to 1000+ linux_layout failures (build.chromium.org/p/tryserver.chromium/builders/linux_layout_rel/builds/18997/steps/webkit_tests/logs/stdio)

git-svn-id: http://skia.googlecode.com/svn/trunk@10729 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomore xfermodes3 rebaselines
bsalomon@google.com [Thu, 15 Aug 2013 13:43:01 +0000 (13:43 +0000)]
more xfermodes3 rebaselines

git-svn-id: http://skia.googlecode.com/svn/trunk@10728 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 15 Aug 2013 07:01:06 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10727 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: workaround gyp issue with multiple files, not being translated into an...
edisonn@google.com [Wed, 14 Aug 2013 22:05:06 +0000 (22:05 +0000)]
pdfviewer: workaround gyp issue with multiple files, not being translated into an array in linux (works in mac, as per spec)

Review URL: https://codereview.chromium.org/23157003

git-svn-id: http://skia.googlecode.com/svn/trunk@10726 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUnpremultiply SkBitmaps for PDF output
commit-bot@chromium.org [Wed, 14 Aug 2013 22:02:23 +0000 (22:02 +0000)]
Unpremultiply SkBitmaps for PDF output

BUG=skia:236, chromium:175548
R=vandebo@chromium.org, edisonn@google.com, reed@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22329003

git-svn-id: http://skia.googlecode.com/svn/trunk@10725 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRefactor GM to separate config parsing, attempt 2
commit-bot@chromium.org [Wed, 14 Aug 2013 21:56:47 +0000 (21:56 +0000)]
Refactor GM to separate config parsing, attempt 2

R=vandebo@chromium.org, reed@google.com, edisonn@google.com, epoger@google.com, scroggo@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23072014

git-svn-id: http://skia.googlecode.com/svn/trunk@10724 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd blend optimization helpers and use to convert rect draws to clears.
commit-bot@chromium.org [Wed, 14 Aug 2013 21:56:37 +0000 (21:56 +0000)]
Add blend optimization helpers and use to convert rect draws to clears.

R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/22558003

git-svn-id: http://skia.googlecode.com/svn/trunk@10723 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline xfermodes3 after change to the test.
bsalomon@google.com [Wed, 14 Aug 2013 21:55:32 +0000 (21:55 +0000)]
rebaseline xfermodes3 after change to the test.

git-svn-id: http://skia.googlecode.com/svn/trunk@10722 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: make pdfviewer compile on mac
edisonn@google.com [Wed, 14 Aug 2013 21:35:27 +0000 (21:35 +0000)]
pdfviewer: make pdfviewer compile on mac

Review URL: https://codereview.chromium.org/23163007

git-svn-id: http://skia.googlecode.com/svn/trunk@10721 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake xfermodes3 GM also test stroked rects
commit-bot@chromium.org [Wed, 14 Aug 2013 19:20:45 +0000 (19:20 +0000)]
Make xfermodes3 GM also test stroked rects

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/22866002

git-svn-id: http://skia.googlecode.com/svn/trunk@10720 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix path issues on mac and win for skpdiff_server.py
commit-bot@chromium.org [Wed, 14 Aug 2013 19:20:35 +0000 (19:20 +0000)]
fix path issues on mac and win for skpdiff_server.py

R=djsollen@google.com, epoger@google.com, jvanverth@google.com

Author: zachr@google.com

Review URL: https://chromiumcodereview.appspot.com/22650009

git-svn-id: http://skia.googlecode.com/svn/trunk@10719 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoallow both GDI and DW fontmgrs at the same time
reed@google.com [Wed, 14 Aug 2013 18:59:28 +0000 (18:59 +0000)]
allow both GDI and DW fontmgrs at the same time

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23058002

git-svn-id: http://skia.googlecode.com/svn/trunk@10718 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDeletes warning on no graph outputs, since we don't output graphs anymore.
bensong@google.com [Wed, 14 Aug 2013 18:37:27 +0000 (18:37 +0000)]
Deletes warning on no graph outputs, since we don't output graphs anymore.
Review URL: https://codereview.chromium.org/23071002

git-svn-id: http://skia.googlecode.com/svn/trunk@10717 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: 1) debug code for drawText (show magenta background for text, to show...
edisonn@google.com [Wed, 14 Aug 2013 18:26:20 +0000 (18:26 +0000)]
pdfviewer: 1) debug code for drawText (show magenta background for text, to show text even when we fail to load/show it), 2) some cleanup: refactor and rename classes and files

Review URL: https://codereview.chromium.org/23020003

git-svn-id: http://skia.googlecode.com/svn/trunk@10716 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix crash when querying a runtime config that is defined in environment
commit-bot@chromium.org [Wed, 14 Aug 2013 18:14:37 +0000 (18:14 +0000)]
Fix crash when querying a runtime config that is defined in environment

Fix crash when querying a runtime config in case when there's no
skia.conf file and the config variable is still defined in the
environment.

Runs the added SkRTConf::UnitTest test as part of new "UnitTest" test.

Previous version of the patch failed Windows build due to setenv usage.
On Windows, use _putenv_s instead.

BUG=skia:1494
R=bsalomon@google.com, humper@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/23174002

git-svn-id: http://skia.googlecode.com/svn/trunk@10715 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDelete compare_baselines.py and download_baselines.py ; we use rebaseline.py now
epoger@google.com [Wed, 14 Aug 2013 18:14:31 +0000 (18:14 +0000)]
Delete compare_baselines.py and download_baselines.py ; we use rebaseline.py now

Review URL: https://codereview.chromium.org/23082002

git-svn-id: http://skia.googlecode.com/svn/trunk@10714 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRefactor GrGLUniformManager::UniformHandle to initialize itself by default
commit-bot@chromium.org [Wed, 14 Aug 2013 18:14:19 +0000 (18:14 +0000)]
Refactor GrGLUniformManager::UniformHandle to initialize itself by default

Refactor GrGLUniformManager::UniformHandle to initialize itself to
"invalid" state by default. This simplifies the effect
constructors. In the future, it should also help catch potential
uninitialized uniform variable usage.

Remove unneeded explicit uniform handle validity assertions before the
handle usage. The assertion will always be made when handle is
converted to index.

BUG=skia:1492
R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/22340010

git-svn-id: http://skia.googlecode.com/svn/trunk@10713 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoupdate expectations after SkLONGLONG change
reed@google.com [Wed, 14 Aug 2013 16:22:02 +0000 (16:22 +0000)]
update expectations after SkLONGLONG change

BUG=

Review URL: https://codereview.chromium.org/23198003

git-svn-id: http://skia.googlecode.com/svn/trunk@10712 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNexus 7 performance trigger rebaseline
robertphillips@google.com [Wed, 14 Aug 2013 15:43:18 +0000 (15:43 +0000)]
Nexus 7 performance trigger rebaseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10711 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAnother Win7 performance trigger rebaseline
robertphillips@google.com [Wed, 14 Aug 2013 15:40:30 +0000 (15:40 +0000)]
Another Win7 performance trigger rebaseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10710 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r10707. Unreviewed.
jvanverth@google.com [Wed, 14 Aug 2013 14:29:29 +0000 (14:29 +0000)]
Reverting r10707. Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@10709 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Refactor gmmain to separate out config parsing"
scroggo@google.com [Wed, 14 Aug 2013 14:07:09 +0000 (14:07 +0000)]
Revert "Refactor gmmain to separate out config parsing"

This reverts commit 210340a02d7d56890a1630cc307b7263fbe9106f.

git-svn-id: http://skia.googlecode.com/svn/trunk@10708 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix hairline pathrenderer for Nexus-10. Switches to using additional
commit-bot@chromium.org [Wed, 14 Aug 2013 13:02:13 +0000 (13:02 +0000)]
Fix hairline pathrenderer for Nexus-10. Switches to using additional
geometry and passing in the coverage value instead.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=10640

R=robertphillips@google.com, egdaniel@google.com, bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/22486003

git-svn-id: http://skia.googlecode.com/svn/trunk@10707 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoeffects: Replaces uses of GrAssert with SkASSERT.
commit-bot@chromium.org [Wed, 14 Aug 2013 12:09:00 +0000 (12:09 +0000)]
effects: Replaces uses of GrAssert with SkASSERT.

This is the first step on migrating from GrAssert to SkASSERT as requested by
Brian.

R=bsalomon@google.com, robertphillips@google.com, scroggo@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22418006

git-svn-id: http://skia.googlecode.com/svn/trunk@10706 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoARM Skia NEON patches - 04 - Clean SkFixed / SkLONGLONG
commit-bot@chromium.org [Wed, 14 Aug 2013 11:43:52 +0000 (11:43 +0000)]
ARM Skia NEON patches - 04 - Clean SkFixed / SkLONGLONG

It removes SkLONGLONG and uses int64_t to implement the  SkFixed
operations for which a SkLONGLONG version existed. It also
removes the 32 bit version that are being replaced.

BUG=
R=djsollen@google.com, reed@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18539004

git-svn-id: http://skia.googlecode.com/svn/trunk@10705 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix build with SK_SUPPORT_UNITTEST on
commit-bot@chromium.org [Wed, 14 Aug 2013 11:36:27 +0000 (11:36 +0000)]
Fix build with SK_SUPPORT_UNITTEST on

Fix build with SK_SUPPORT_UNITTEST on. Parenthesis with && and || is
fixed similarly to r1386.

BUG=skia:1493
R=scroggo@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/22732004

git-svn-id: http://skia.googlecode.com/svn/trunk@10704 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRefactor gmmain to separate out config parsing
commit-bot@chromium.org [Wed, 14 Aug 2013 11:36:15 +0000 (11:36 +0000)]
Refactor gmmain to separate out config parsing

R=vandebo@chromium.org, reed@google.com, edisonn@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/21715002

git-svn-id: http://skia.googlecode.com/svn/trunk@10703 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWin7 performance trigger rebaseline
robertphillips@google.com [Wed, 14 Aug 2013 11:35:25 +0000 (11:35 +0000)]
Win7 performance trigger rebaseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10702 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 14 Aug 2013 07:01:14 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10701 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd Android config for Intel RHB
borenet@google.com [Tue, 13 Aug 2013 20:32:22 +0000 (20:32 +0000)]
Add Android config for Intel RHB

Corresponding buildbot change: https://codereview.chromium.org/22840005/

R=djsollen@google.com

Review URL: https://codereview.chromium.org/23046003

git-svn-id: http://skia.googlecode.com/svn/trunk@10699 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd root files from chrome
reed@google.com [Tue, 13 Aug 2013 19:11:15 +0000 (19:11 +0000)]
add root files from chrome

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23111002

git-svn-id: http://skia.googlecode.com/svn/trunk@10696 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNexus 7 performance trigger rebaselines
robertphillips@google.com [Tue, 13 Aug 2013 17:26:59 +0000 (17:26 +0000)]
Nexus 7 performance trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10695 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix int-to-scalar warnings
reed@google.com [Tue, 13 Aug 2013 15:33:17 +0000 (15:33 +0000)]
fix int-to-scalar warnings

git-svn-id: http://skia.googlecode.com/svn/trunk@10693 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agobench_util: allow optional whitespace in CSV format
epoger@google.com [Tue, 13 Aug 2013 15:12:33 +0000 (15:12 +0000)]
bench_util: allow optional whitespace in CSV format
BUG=https://code.google.com/p/skia/issues/detail?id=1500
R=bensong@google.com

Review URL: https://codereview.chromium.org/23069003

git-svn-id: http://skia.googlecode.com/svn/trunk@10692 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoexpose instance methods on SkTypefaceCache
reed@google.com [Tue, 13 Aug 2013 14:59:17 +0000 (14:59 +0000)]
expose instance methods on SkTypefaceCache

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23067003

git-svn-id: http://skia.googlecode.com/svn/trunk@10691 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix mac build errors related to new gm
djsollen@google.com [Tue, 13 Aug 2013 14:48:09 +0000 (14:48 +0000)]
fix mac build errors related to new gm

Review URL: https://codereview.chromium.org/22937005

git-svn-id: http://skia.googlecode.com/svn/trunk@10690 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPrevent picture recording from over optimizing the culling of clips.
djsollen@google.com [Tue, 13 Aug 2013 14:29:06 +0000 (14:29 +0000)]
Prevent picture recording from over optimizing the culling of clips.

BUG=skia:1496
R=mtklein@google.com, reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/22875008

git-svn-id: http://skia.googlecode.com/svn/trunk@10689 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove uncalled local functions
reed@google.com [Tue, 13 Aug 2013 13:25:09 +0000 (13:25 +0000)]
remove uncalled local functions

BUG=

Review URL: https://codereview.chromium.org/22924004

git-svn-id: http://skia.googlecode.com/svn/trunk@10688 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake android_run_skia exit with the correct code
borenet@google.com [Mon, 12 Aug 2013 17:21:43 +0000 (17:21 +0000)]
Make android_run_skia exit with the correct code

R=djsollen@google.com

Review URL: https://codereview.chromium.org/22812003

git-svn-id: http://skia.googlecode.com/svn/trunk@10684 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Add SkCanvas::drawPosTextBounded."
reed@google.com [Mon, 12 Aug 2013 15:40:11 +0000 (15:40 +0000)]
Revert "Add SkCanvas::drawPosTextBounded."

This reverts commit e158aea941a6202a40b75fcee013d002089854bb.

This was an experimental API change. We will reintroduce this feature
with a different API approach, and support it w/ detailed testing
and performance measurements.

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/22861002

git-svn-id: http://skia.googlecode.com/svn/trunk@10680 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix malformed gypi file that was missing commas
djsollen@google.com [Mon, 12 Aug 2013 14:57:54 +0000 (14:57 +0000)]
fix malformed gypi file that was missing commas

R=torne@chromium.org

Review URL: https://codereview.chromium.org/22841003

git-svn-id: http://skia.googlecode.com/svn/trunk@10678 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSkTDynamicHash
mtklein@google.com [Mon, 12 Aug 2013 14:51:25 +0000 (14:51 +0000)]
SkTDynamicHash
  - add validate()
  - make add() and remove() strict
  - fill in maybeShrink()
  - make grow and shrink thresholds configurable.
  - fix issue where we were getting filled with deleted items - we need to count them as occupied when determining if we should grow

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/22571010

git-svn-id: http://skia.googlecode.com/svn/trunk@10677 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIf any change is made to the public API then make sure there is an LGTM from an owner.
rmistry@google.com [Mon, 12 Aug 2013 14:51:20 +0000 (14:51 +0000)]
If any change is made to the public API then make sure there is an LGTM from an owner.

This feature has been requested by reed@.

If no LGTM is found from an owner then the following msg is displayed:

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com')

(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/22453004

git-svn-id: http://skia.googlecode.com/svn/trunk@10676 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate Skia Android tools.
djsollen@google.com [Mon, 12 Aug 2013 12:30:04 +0000 (12:30 +0000)]
Update Skia Android tools.

This CL moves the skia_launcher out of the system/bin and into
/data/local/tmp; removes the need to package our shared libs in an
apk; and updates all the scripts to work in the new environment.

R=mtklein@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/22617002

git-svn-id: http://skia.googlecode.com/svn/trunk@10673 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert of r10671 (Experiments on calculating reciprocal of square root) due to bots...
robertphillips@google.com [Mon, 12 Aug 2013 12:02:28 +0000 (12:02 +0000)]
Revert of r10671 (Experiments on calculating reciprocal of square root) due to bots failures:

Win7: http://108.170.217.252:10117/builders/Build-Win7-VS2010-x86-Debug/builds/715/steps/BuildMost/logs/stdio
Win8: http://108.170.217.252:10117/builders/Build-Win8-VS2012-x86-Debug/builds/383/steps/BuildMost/logs/stdio
Mac10.6: http://108.170.217.252:10117/builders/Build-Mac10.6-GCC-x86-Debug/builds/1259/steps/BuildMost/logs/stdio

git-svn-id: http://skia.googlecode.com/svn/trunk@10672 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExperiments on calculating reciprocal of square root
commit-bot@chromium.org [Mon, 12 Aug 2013 08:37:51 +0000 (08:37 +0000)]
Experiments on calculating reciprocal of square root

BUG=
R=reed@google.com, rmistry@chromium.org, bsalomon@google.com, tomhudson@chromium.org, tomhudson@google.com

Author: yang.gu@intel.com

Review URL: https://chromiumcodereview.appspot.com/21755002

git-svn-id: http://skia.googlecode.com/svn/trunk@10671 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agor10473 introduced a space between bench values; adjusting the corresponding regexp...
bensong@google.com [Sun, 11 Aug 2013 21:59:01 +0000 (21:59 +0000)]
r10473 introduced a space between bench values; adjusting the corresponding regexp. (SkipBuildbotRuns).
Review URL: https://codereview.chromium.org/22447004

git-svn-id: http://skia.googlecode.com/svn/trunk@10670 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverted r10654 (Fix crash when querying a runtime config that is defined in environm...
robertphillips@google.com [Sun, 11 Aug 2013 13:20:18 +0000 (13:20 +0000)]
Reverted r10654 (Fix crash when querying a runtime config that is defined in environment) due to compilation failure on Chromium win_layout bot

git-svn-id: http://skia.googlecode.com/svn/trunk@10669 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 10 Aug 2013 07:01:19 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10668 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r10659: Add a map homogenous points to SkMatrix
jvanverth@google.com [Fri, 9 Aug 2013 21:06:38 +0000 (21:06 +0000)]
Revert r10659: Add a map homogenous points to SkMatrix

git-svn-id: http://skia.googlecode.com/svn/trunk@10667 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAll rSomethingTo() immediately following a close() are relative to the point we close...
commit-bot@chromium.org [Fri, 9 Aug 2013 19:48:26 +0000 (19:48 +0000)]
All rSomethingTo() immediately following a close() are relative to the point we closed from, not the point we close to.  Fix that.

Seems like this has been broken since the stone ages.

BUG=skia:1474, code.google.com/p/android/issues/detail?id=41216
R=bsalomon@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/22681006

git-svn-id: http://skia.googlecode.com/svn/trunk@10666 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReland "Make WebP decoding independent of stream length."
scroggo@google.com [Fri, 9 Aug 2013 19:22:00 +0000 (19:22 +0000)]
Reland "Make WebP decoding independent of stream length."

This reverts commit 1de924955b103c4f5dc9c46a06527d6a37e6cb70.

When reading the stream, only read as much as will fit in the
allocated buffer.

BUG=skia:1495

Review URL: https://codereview.chromium.org/22629010

git-svn-id: http://skia.googlecode.com/svn/trunk@10665 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove include from the header paths
djsollen@google.com [Fri, 9 Aug 2013 16:11:36 +0000 (16:11 +0000)]
remove include from the header paths

R=robertphillips@google.com, torne@chromium.org

Review URL: https://codereview.chromium.org/22450005

git-svn-id: http://skia.googlecode.com/svn/trunk@10664 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoallow NULL in writeString/readString
commit-bot@chromium.org [Fri, 9 Aug 2013 16:03:05 +0000 (16:03 +0000)]
allow NULL in writeString/readString

BUG=skia:1469, code.google.com/p/android/issues/detail?id=58257
R=scroggo@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/22359003

git-svn-id: http://skia.googlecode.com/svn/trunk@10662 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove exported headers and add all public headers into dictionary for reference...
djsollen@google.com [Fri, 9 Aug 2013 15:45:35 +0000 (15:45 +0000)]
Remove exported headers and add all public headers into dictionary for reference by clients.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/22613003

git-svn-id: http://skia.googlecode.com/svn/trunk@10661 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTemporarily disable pathinterior_gpu on Nexus-10.
jvanverth@google.com [Fri, 9 Aug 2013 15:24:01 +0000 (15:24 +0000)]
Temporarily disable pathinterior_gpu on Nexus-10.

git-svn-id: http://skia.googlecode.com/svn/trunk@10660 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a map homogenous points to SkMatrix
egdaniel@google.com [Fri, 9 Aug 2013 15:07:10 +0000 (15:07 +0000)]
Add a map homogenous points to SkMatrix

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/22330004

git-svn-id: http://skia.googlecode.com/svn/trunk@10659 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd initial baselines for new GM xfermodes3
bsalomon@google.com [Fri, 9 Aug 2013 14:32:46 +0000 (14:32 +0000)]
Add initial baselines for new GM xfermodes3

git-svn-id: http://skia.googlecode.com/svn/trunk@10658 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemoving deprecated constructors and setDevice from SkDeferredCanvas
commit-bot@chromium.org [Fri, 9 Aug 2013 14:24:59 +0000 (14:24 +0000)]
Removing deprecated constructors and setDevice from SkDeferredCanvas

R=senorblanco@google.com, senorblanco@chromium.org
BUR=crbug.com/270143

Author: junov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22385011

git-svn-id: http://skia.googlecode.com/svn/trunk@10657 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r10651: Make WebP decoding independent of stream length.
jvanverth@google.com [Fri, 9 Aug 2013 14:24:30 +0000 (14:24 +0000)]
Reverting r10651: Make WebP decoding independent of stream length.

git-svn-id: http://skia.googlecode.com/svn/trunk@10656 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove uneeded SK_API declaration.
djsollen@google.com [Fri, 9 Aug 2013 13:49:13 +0000 (13:49 +0000)]
remove uneeded SK_API declaration.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/22432005

git-svn-id: http://skia.googlecode.com/svn/trunk@10655 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix crash when querying a runtime config that is defined in environment
commit-bot@chromium.org [Fri, 9 Aug 2013 13:23:56 +0000 (13:23 +0000)]
Fix crash when querying a runtime config that is defined in environment

Fix crash when querying a runtime config in case when there's no
skia.conf file and the config variable is still defined in the
environment.

Runs the added SkRTConf::UnitTest test as part of new "UnitTest" test.

BUG=skia:1494
R=bsalomon@google.com, humper@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/22650007

git-svn-id: http://skia.googlecode.com/svn/trunk@10654 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNexus 7 Performance trigger rebaseline
robertphillips@google.com [Fri, 9 Aug 2013 12:43:02 +0000 (12:43 +0000)]
Nexus 7 Performance trigger rebaseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10653 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCleanup the ARM blitrow optimizations
djsollen@google.com [Fri, 9 Aug 2013 12:35:08 +0000 (12:35 +0000)]
Cleanup the ARM blitrow optimizations

R=mtklein@google.com

Review URL: https://codereview.chromium.org/22229002

git-svn-id: http://skia.googlecode.com/svn/trunk@10652 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake WebP decoding independent of stream length.
djsollen@google.com [Fri, 9 Aug 2013 12:32:48 +0000 (12:32 +0000)]
Make WebP decoding independent of stream length.

There's a case in Android, when the SkStream passed to WebP decoder may have
incorrect length (stream->getLength()). This is observed, if the App decodes
an image (size > 80KB) using: 'ParcelFileDescriptor --> BitmapFactory.decodeStream()'.
This CL updates the WebP incremental decoding loop to not rely on stream->getLength().

R=scroggo@google.com, vikasa@google.com

Review URL: https://codereview.chromium.org/22672003

git-svn-id: http://skia.googlecode.com/svn/trunk@10651 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 9 Aug 2013 07:01:22 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10650 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThis attempts to replicate some bad cache behavior Mozilla reported.
commit-bot@chromium.org [Thu, 8 Aug 2013 22:55:21 +0000 (22:55 +0000)]
This attempts to replicate some bad cache behavior Mozilla reported.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/22411005

git-svn-id: http://skia.googlecode.com/svn/trunk@10649 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert rebaselines for r10640.
jvanverth@google.com [Thu, 8 Aug 2013 22:44:13 +0000 (22:44 +0000)]
Revert rebaselines for r10640.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10648 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r10640: Fix hairline pathrenderer for Nexus-10.
jvanverth@google.com [Thu, 8 Aug 2013 22:42:37 +0000 (22:42 +0000)]
Revert r10640: Fix hairline pathrenderer for Nexus-10.

git-svn-id: http://skia.googlecode.com/svn/trunk@10647 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline Nexus-S and Nexus-4 GMs for r10640. Disabled complexclip_bw_layer_gpu
jvanverth@google.com [Thu, 8 Aug 2013 21:24:41 +0000 (21:24 +0000)]
Rebaseline Nexus-S and Nexus-4 GMs for r10640. Disabled complexclip_bw_layer_gpu
for Nexus-S due to glitch.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10646 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd new GM to targeted at rect->clear optimization with different xfermodes.
commit-bot@chromium.org [Thu, 8 Aug 2013 21:13:38 +0000 (21:13 +0000)]
Add new GM to targeted at rect->clear optimization with different xfermodes.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/22264010

git-svn-id: http://skia.googlecode.com/svn/trunk@10645 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMore rebaselines for r10640. Unreviewed.
jvanverth@google.com [Thu, 8 Aug 2013 20:42:19 +0000 (20:42 +0000)]
More rebaselines for r10640. Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@10644 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline images for r10640. Unreviewed.
jvanverth@google.com [Thu, 8 Aug 2013 20:07:12 +0000 (20:07 +0000)]
Rebaseline images for r10640. Unreviewed.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10643 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding 2 functions to the Skia API
commit-bot@chromium.org [Thu, 8 Aug 2013 19:20:05 +0000 (19:20 +0000)]
Adding 2 functions to the Skia API

I need wrappers for both SkOrderedReadBuffer and SkOrderedWriteBuffer inside Chromium in order to do the IPC serialization of Skia SkImageFilter objects.

See https://codereview.chromium.org/21271002/

BUG=
R=djsollen@google.com, scroggo@google.com, reed@google.com

Author: sugoi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22591002

git-svn-id: http://skia.googlecode.com/svn/trunk@10642 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline images for r10535. Reviewed by djsollen.
jvanverth@google.com [Thu, 8 Aug 2013 18:54:12 +0000 (18:54 +0000)]
Rebaseline images for r10535. Reviewed by djsollen.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10641 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix hairline pathrenderer for Nexus-10. Switches to using additional
commit-bot@chromium.org [Thu, 8 Aug 2013 18:22:07 +0000 (18:22 +0000)]
Fix hairline pathrenderer for Nexus-10. Switches to using additional
geometry and passing in the coverage value instead.

BUG=
R=robertphillips@google.com, bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/22486003

git-svn-id: http://skia.googlecode.com/svn/trunk@10640 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: remove text save/restore (not needed) and verify that colorspace dictionar...
edisonn@google.com [Thu, 8 Aug 2013 12:54:01 +0000 (12:54 +0000)]
pdfviewer: remove text save/restore (not needed) and verify that colorspace dictionary exists before using it

Review URL: https://codereview.chromium.org/22436003

git-svn-id: http://skia.googlecode.com/svn/trunk@10639 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: add ability to run on gpu
edisonn@google.com [Thu, 8 Aug 2013 12:42:13 +0000 (12:42 +0000)]
pdfviewer: add ability to run on gpu

Review URL: https://codereview.chromium.org/22684002

git-svn-id: http://skia.googlecode.com/svn/trunk@10638 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCreate a gypi that contains all the SK_API header files for use by clients (i.e....
djsollen@google.com [Thu, 8 Aug 2013 12:31:05 +0000 (12:31 +0000)]
Create a gypi that contains all the SK_API header files for use by clients (i.e. chromium).

R=robertphillips@google.com, torne@chromium.org

Review URL: https://codereview.chromium.org/22474010

git-svn-id: http://skia.googlecode.com/svn/trunk@10637 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: remove save/restore used with q/Q operators (we already do there save...
edisonn@google.com [Thu, 8 Aug 2013 11:40:26 +0000 (11:40 +0000)]
pdfviewer: remove save/restore used with q/Q operators (we already do there save and restore)

Review URL: https://codereview.chromium.org/22678003

git-svn-id: http://skia.googlecode.com/svn/trunk@10636 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoARM Skia NEON patches - 11 - Blitter_RGB16
commit-bot@chromium.org [Thu, 8 Aug 2013 10:51:45 +0000 (10:51 +0000)]
ARM Skia NEON patches - 11 - Blitter_RGB16

Blitter_RGB16: fixes and improvements

- fix alpha calculation: it was still using the old version of
  SkAlpha255To256. 11 more tests pass in gm.

- clean a lot the code: the existing code was "a bit" messy with
  a lot of duplicated hardcoded constants, got rid of all this.

- improve speed a little: part of it as a side-effect of the change
  in the way alpha is calculated but also by grouping loads and stores.

One "issue" was present and still remains: the NEON code doesn't give
the same result as the black blitter on black. It accounts for dozens
of mismatches in gm. Is this considered "not too bad"? Would you be
interested in a NEON version of the black blitter? The current
comments seem to indicate that the black blitter is here only to give
a performance boost when NEON is not presents so I didn't write a NEON
version.

BUG=
R=djsollen@google.com, tomhudson@google.com, reed@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18666005

git-svn-id: http://skia.googlecode.com/svn/trunk@10635 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 8 Aug 2013 07:01:20 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10634 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse Path Ops to generate PDF clips
commit-bot@chromium.org [Thu, 8 Aug 2013 02:52:05 +0000 (02:52 +0000)]
Use Path Ops to generate PDF clips

R=vandebo@chromium.org, edisonn@google.com, caryclark@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/21161003

git-svn-id: http://skia.googlecode.com/svn/trunk@10633 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r10603 (Remove operator== from SkPaint) due to Chrome failures
robertphillips@google.com [Wed, 7 Aug 2013 22:36:29 +0000 (22:36 +0000)]
Revert r10603 (Remove operator== from SkPaint) due to Chrome failures

git-svn-id: http://skia.googlecode.com/svn/trunk@10632 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNew baselines for imagefiltersbase, after r10626.
senorblanco@chromium.org [Wed, 7 Aug 2013 21:36:15 +0000 (21:36 +0000)]
New baselines for imagefiltersbase, after r10626.

TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/22623004

git-svn-id: http://skia.googlecode.com/svn/trunk@10631 2bbb7eff-a529-9590-31e7-b0007b416f81