Jaechul Lee [Wed, 21 Jun 2023 07:20:56 +0000 (16:20 +0900)]
Add configuration for preprocessor
preprocessor functionality makes a build error in the VD repo.
because it doesn't have some packages such as rnnoise, libaudio-effect,
webrtc-audio-processing.
This configuration would be removed after the packages are completely included.
[Version] 15.0.45
[Issue Type] Build Break(VD)
Change-Id: I5685f0f2852746f3c1ac7257ee98474d9a721bcb
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Fri, 16 Jun 2023 05:43:32 +0000 (14:43 +0900)]
Change TYPE to METHOD
audio_effect_type_e has been changed to audio_effect_method_e.
[Version] 15.0.44
[Issue Type] Update
Change-Id: Ia0e3ddfca0346addfb3de6e7fe317f613ae347d1
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 19 Jun 2023 07:43:37 +0000 (16:43 +0900)]
Fix coverity issue(UNUSED_VALUE)
[Version] 15.0.43
[Issue Type] Coverity(1677535)
Change-Id: I9b8e6c67e9a2fc96da95b31b8e8c21a84d2a2d96
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Wed, 10 May 2023 08:20:56 +0000 (17:20 +0900)]
Use libaudio-effect module
* Moved every plugin to libaudio-effect
* Added a dependency on libaudio-effect
[Version] 15.0.42
[Issue Type] New feature
Change-Id: Ib32588d6138258647af5df5ce0f622289003ad49
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 13 Feb 2023 06:24:37 +0000 (15:24 +0900)]
Add noise suppression functionality
* Added the processor_holder structure for multi preprocessing.
* Added the processor_reference structure for receiving reference data.
* Added a NS method based on rnnoise.
* Added filesrc reference method.
* Replaced tizenaudio-echo-cancel with module-tizenaudio-preprocessor.
* Had dependencies on webrtc-audio-processing and rnnoise.
* Changed folder name echo-cancel to preprocessor.
* Disabled noise suppression functionality in method_webrtc.
* Removed method_adrian.
[Version] 15.0.41
[Issue Type] New feature
Change-Id: I22bfdffadabe4c9dbd08ce432c8d72a8f4d41dc4
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Mon, 8 May 2023 06:50:31 +0000 (15:50 +0900)]
Fix typos
[Version] 15.0.40
[Issue Type] Cleanup
Change-Id: If7c751c3aa28b411487ef3029a8ac76f8e810b43
Seungbae Shin [Fri, 7 Apr 2023 11:55:35 +0000 (20:55 +0900)]
device-manager: support external tv source device for tv product
[Version] 15.0.39
[Issue Type] Product
- tv source will use DEVICE_TYPE_FORWARDING
- unnecessary public operation code related to DEVICE_TYPE_FORWARDING will be disabled for the tv product build.
Change-Id: I18c18ffe5ff2b7d5417d45dd0b2868e5068393fa
Seungbae Shin [Tue, 11 Apr 2023 06:54:49 +0000 (15:54 +0900)]
tizenaudio-policy: Fix ASAN stack-buffer-overflow defect
==pulseaudio==586==ERROR: AddressSanitizer: stack-buffer-overflow
WRITE of size 8 at 0x007ffa2fa500 thread T0
[Version] 15.0.38
[Issue Type] Bug
Change-Id: Icb95313682de9acb7390196df5be03df122a2f26
Jaechul Lee [Fri, 31 Mar 2023 02:41:46 +0000 (11:41 +0900)]
tizen-sink2/source2: Fix abort when disconnecting USB devices
[Version] 15.0.37
[Issue Type] Bug
Change-Id: I79b5e88f7c2595c436d2863241c6d52b3687ad6b
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
jaechul lee [Tue, 17 Jan 2023 02:05:17 +0000 (02:05 +0000)]
Merge "echo-cancel: Allow various period size" into tizen
Jaechul Lee [Fri, 13 Jan 2023 05:16:45 +0000 (14:16 +0900)]
echo-cancel: Allow various period size
It allows sink's buffer size more/less than source's buffer size.
For example, it's able to set like sink 25ms, source 15ms.
[Version] 15.0.36
[Issue Type] Update
Change-Id: I8b697674ee20d46f7b9159e66c229cb2469540d0
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Fri, 13 Jan 2023 11:28:31 +0000 (20:28 +0900)]
fixup! tizen-device: add sample spec and return it for connected device list
fixes the following potential ASAN issue by retrieving device sample spec just in time.
==pulseaudio==605==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x007f940031f0
0x007f940031f0 is located 424 bytes to the right of 1480-byte region [0x007f94002a80,0x007f94003048)
[Version] 15.0.36
[Issue Type] ASAN
Change-Id: Id3d111cc4a73d026be3c31c6a4ba7a3a6f97d835
Seungbae Shin [Wed, 28 Dec 2022 08:05:15 +0000 (17:05 +0900)]
stream-manager-dbus: return device id also for get_current_media_routing_path method
API related: sound_manager_get_current_media_playback_device_id()
[Version] 15.0.35
[Issue Type] Update
Change-Id: I27cbad83700c20262cf5ed5e88987755ff5d7523
Seungbae Shin [Tue, 13 Dec 2022 08:59:44 +0000 (17:59 +0900)]
device-manager: update hdmi device management mechanism
This update is based on the latest RPI kernel,
the related obsolete hdmi handling code is now removed.
[Version] 15.0.34
[Issue Type] Update
Change-Id: I994fb43982c394cfa600219f51cd259a9b14e27f
Seungbae Shin [Tue, 25 Oct 2022 12:29:40 +0000 (21:29 +0900)]
sound-player: support fd-passing for supporting container playback
[Version] 15.0.33
[Issue Type] Feature
Change-Id: I34f8c474a9ac9e5d882d4616bd9de9d1e49ab5a8
Jaechul Lee [Fri, 21 Oct 2022 02:55:55 +0000 (11:55 +0900)]
tizen-sink/source: fix svace defects
This commit fixes warnings as follows
NO_CAST.INTEGER_OVERFLOW
SEC_INVALID_ASSIGNMENT_WITH_UNSIGNED_VALUES
[Version] 15.0.32
[Issue Type] Svace
Change-Id: I901662abb6efdc5171d58d4042e5e4140a69c1d0
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Thu, 20 Oct 2022 10:42:36 +0000 (19:42 +0900)]
ladspa/acm: fix svace defects
Checker: SEC_DO_NOT_USE_INT_IN_FOR_LOOP
SEC_DO_NOT_ASSIGN_SIZE_OF_INT
[Version] 15.0.31
[Issue Type] Svace
Change-Id: Idfe703452c983f3cd5f49c3a6c7a6ad6ae8a6720
Seungbae Shin [Thu, 6 Oct 2022 11:38:53 +0000 (20:38 +0900)]
tizen-device: add sample spec and return it for connected device list
[Version] 15.0.30
[Issue Type] Feature
Change-Id: I6a541a0d71f2924e778989c999a67b7b7310bf0f
Seungbae Shin [Wed, 28 Sep 2022 04:35:46 +0000 (13:35 +0900)]
sound-player: stop all other existence sound playbacks if requested
[Version] 15.0.29
[Issue Type] Feature
Change-Id: Ife2480f0afc993165186e6f7b1cd04dbe16539fe
Jaechul Lee [Tue, 16 Aug 2022 07:45:25 +0000 (16:45 +0900)]
Fix mismatching between enum and method_table
enums should be matched to method_table because the enum is used as an
index.
[Version] 15.0.28
[Issue Type] Bug
Change-Id: I55b3e001ff035ca1983b96efcea3c8e4728f513a
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Mon, 8 Aug 2022 08:27:01 +0000 (17:27 +0900)]
fixup! fixup! Enable webrtc-audio-processing by default
Fix the following crash error due to invalid enumeration value.
processor.c: pa_processor_get_method(498) > processing method is selected. request_method(reference_copy), method_to_string((null))
processor.c: pa_processor_new(169) > Assertion 'method < PA_PROCESSOR_METHOD_MAX' failed at src/echo-cancel/processor.c:169, function pa_processor_new(). Aborting.
[Version] 15.0.27
[Issue Type] Bug
Change-Id: I331fbea04be4a2d0471b916082f3da298c31a851
Jaechul Lee [Mon, 18 Jul 2022 04:46:15 +0000 (13:46 +0900)]
fixup! Enable webrtc-audio-processing by default
[Version] 15.0.26
[Issue Type] Bug
Change-Id: I683f8ca264196f01107f4713129e21ab233650ca
Jaechul Lee [Mon, 27 Jun 2022 08:41:30 +0000 (17:41 +0900)]
Enable webrtc-audio-processing by default
[Version] 15.0.25
[Issue Type] Improvement
Change-Id: Icb43727592ce90077ed6badf8481680dccc57ef1
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 4 Jul 2022 02:30:59 +0000 (11:30 +0900)]
echo-cancel: Fix coverity issues (PARAMETER_HIDDEN)
[Version] 15.0.24
[Issue Type] Coverity
Change-Id: Ia5f389a408b7bb97ab379215939d9b910aebb8ee
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Thu, 30 Jun 2022 04:10:12 +0000 (13:10 +0900)]
echo-cancel: Replace 'algo' prefix with 'method'
[Version] 15.0.23
[Issue Type] Rename
Change-Id: I8eee586036ef0f107f94413285b22a5736284318
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Tue, 28 Jun 2022 07:42:58 +0000 (16:42 +0900)]
tizenaudio-util: Fix loading errors
This patch fixes undefined symbol: pa_tz_util_pcm_open_by_*
[Version] 15.0.22
[Issue Type] Runtime error
Change-Id: I7c172938d4480348445458a56e1ba9a8ddf14de2
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Thu, 2 Jun 2022 02:20:43 +0000 (11:20 +0900)]
Improve latency difference between reference and capture source
* Not allow negative latency
* Added mchstreamer specific code
* Fixed build warning on aarch64
[Version] 15.0.21
[Issue Type] Improvement
Change-Id: Idd6c4337ec6567e52dd86bbca5c194a897804b43
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Fri, 3 Dec 2021 02:15:30 +0000 (11:15 +0900)]
Support external device playback and capture on sink2/source2
module-alsa-card tries to use 'device_id' that is from udev but
tizenaudio-sink2/source2 can't load devices with device_id.
This patch makes devices load with device_id and device_string both.
[Version] 15.0.20
[Issue Type] New feature
Change-Id: I2dcd7b4abdc88abacec5ba997050217c0c8bfc48
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Sangchul Lee [Tue, 21 Jun 2022 08:05:56 +0000 (17:05 +0900)]
Rename __TIZEN_INTERNAL_BT_SCO__ to __TIZEN_TV_EXTERNAL_BT_SCO__
The 'external bt sco' feature is only for tv binary. So, the preprocessor
definition name is changed to have __TIZEN_TV_ prefix as well as to invert
the meaning of the previous name.
[Version] 15.0.19
[Issue Type] Rename
Change-Id: Iff1847574b925d8fb72efc3687f1926d3e110b8e
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Mon, 13 Jun 2022 12:37:50 +0000 (21:37 +0900)]
device-manager: Add builtin tv-mic support
[Version] 15.0.18
[Issue Type] Improvement
Change-Id: If35aa1bffa27588629124e97bf7249688782d492
Seungbae Shin [Thu, 16 Jun 2022 14:48:35 +0000 (23:48 +0900)]
device-manager: avoid registering the built-in device if not loaded properly
Previously, it was shown that the built-in device exists even module is not loaded correctly.
Now, this change fixed that mismatch.
[Version] 15.0.17
[Issue Type] Bug
Change-Id: I6c78231e62c75ac759964697ee2e079a80bb58c3
Jaechul Lee [Tue, 17 May 2022 06:41:12 +0000 (15:41 +0900)]
Revert "aec-manager: Add audio AEC manager"
This reverts commit
f49985f02d8d1e49a4e2075f3b9f2d651c571770.
[Version] 15.0.16
[Issue Type] Cleanup
Change-Id: Ie7a9341ff90acd3aa26ed38d51ce140fffb02c0f
Jaechul Lee [Tue, 30 Nov 2021 02:19:34 +0000 (11:19 +0900)]
Separate tizenaudio-sink2 and module-tizenaudio-sink2
pa_tizenaudio_source2_new/sink2_new were added in order to support usb
device playback/capture. These function will be called in
module-tizenaudio-sink2/source2 and module-alsa-card.
[Version] 15.0.15
[Issue Type] Improvement
Change-Id: Id1d2d852f4c8982ac4c622cd2d326589ca46ca69
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Fri, 29 Apr 2022 01:42:16 +0000 (10:42 +0900)]
tizenaudio-echo-cancel: Fix coverity defect (Dereference null return value)
[Version] 15.0.14
[Issue Type] Coverity
Change-Id: I69359a1fc8dfd988ab37cc24a9cc4f2f287396eb
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Thu, 14 Apr 2022 06:00:24 +0000 (15:00 +0900)]
tizenaudio-sink/source: Fix crash when pulseaudio exit
* Fix pulseaudio crash (pactl exit)
* symbol mismatching(pa_processor_push_reference)
* aarch64 build warning
[Version] 15.0.13
[Issue Type] Bug
Change-Id: I0d7f0d44a95cd9667746529ed1f03151ec92e64a
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Thu, 21 Apr 2022 08:15:38 +0000 (17:15 +0900)]
tizenaudio-echo-cancel: Fix UNINIT.LOCAL_VAR
This patch fixes the svace and convention issues
* Fix svace issue
* Relace echo with referece
[Version] 15.0.12
[Issue Type] SVACE
Change-Id: I8ebe7e724c090fc4ce8bfa120b0e596d95723a2d
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Thu, 21 Apr 2022 03:52:07 +0000 (12:52 +0900)]
sound-player: Fix INTEGER_OVERFLOW defect
[Version] 15.0.11
[Issue Type] Svace
Change-Id: I224d3ac72c27a1b184baf72933bbe5618a073d45
Jaechul Lee [Tue, 29 Mar 2022 08:06:43 +0000 (17:06 +0900)]
tizenaudio-echo-cancel: Support reference raw copy functionality
processing echo-cancellation in module-tizenaudio-echo-cancel moved to processor
modules for supporting reference copy.
* created reference copy
* removed delayq
[Version] 15.0.10
[Issue Type] New Feature
Change-Id: Id4529e7f6225b1c3f1d6e499bc915aaef1a940c5
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 28 Mar 2022 02:20:50 +0000 (11:20 +0900)]
tizenaudio-echo-cancel: Find reference sink by proplist
[Version] 15.0.9
[Issue Type] New Feature
Change-Id: I28c7c2cb5a569f7f1159ee1a6aa2a4ede54ed0cc
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 28 Mar 2022 05:00:35 +0000 (14:00 +0900)]
tones: Fix coverity issues
The issue of coverity(1286168) was fixed
[Version] 15.0.8
[Issue Type] Coverity
Change-Id: I5eaaa3e59050963ad207634bae5a68631b9b286e
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Thu, 24 Mar 2022 07:57:45 +0000 (16:57 +0900)]
Add default_method to module parameters
Use default method that is configured at init function if
source-output's 'echo_cancel' property is set to 'default'
[Version] 15.0.7
[Issue Type] Improvement
Change-Id: I137282f954cd01b1eb5e08aedd3f2a5a075e74d6
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 28 Mar 2022 02:33:13 +0000 (11:33 +0900)]
Fix coverity issues
The issue of coverity(1286103) was fixed
[Version] 15.0.6
[Issue Type] Coverity
Change-Id: I3e4b5ca2e925642cc4574136b07a3c736b9a2e69
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 14 Mar 2022 06:29:30 +0000 (15:29 +0900)]
Support webrtc-audio-processsing echo-cancellation
[Version] 15.0.5
[Issue Type] New Feature
Change-Id: Ib3227c185779353747af7f930de13535988b467c
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Tue, 15 Mar 2022 02:17:22 +0000 (11:17 +0900)]
Support stream-based echo-cancellation
* Added module-tizenaudio-echo-cancel (Supported adrian, speex)
* Added processor module that processes resampled pcm data
* Added a few messages in sink2/source2
[Version] 15.0.4
[Issue Type] New Feature
Change-Id: Ie6e8c3de0bf5fec20c3a087daf377fdcbd82303b
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
jungsup lee [Mon, 21 Feb 2022 04:17:50 +0000 (13:17 +0900)]
tizenaudio-sink: Reset pollfd's revents after use
revents should be cleared after handling POLLERR. mainloop send a lot of
async message to I/O thread that is stucking on writing pcm. After that,
I/O thread couldn't call poll api because of handling asyncq message.
[Version] 15.0.3
[Issue Type] Bug fix
Change-Id: Ib806cdd77a86fae648b08a5b5e1edc1ed60fbec5
Signed-off-by: jungsup lee <jungsup4.lee@samsung.com>
Sangchul Lee [Wed, 23 Feb 2022 05:40:50 +0000 (14:40 +0900)]
device-manager: Add null check in handle_device_connected()
When the last parameter of handle_device_connected() is NULL,
it gets the required structure again from the list referring to
device-map.json. The result is checked now to avoid unwanted
assertion by other functions.
[Version] 15.0.2
[Issue Type] Improvement
Change-Id: Id3c07d579b1d273386a6eab2e6618abf27baabf8
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Tue, 22 Feb 2022 10:34:43 +0000 (19:34 +0900)]
device-manager: Fix svace issues (DEREF_OF_NULL.RET.STAT)
- Add null check for pulse_device_get_proplist()
- Use foreach macro for dynarray on handle_internal_pulse_device()
- Remove unnecessary braces
- Fix some invalid indents
- Revise some code format
[Version] 15.0.1
[Issue Type] Svace
Change-Id: I9ae16c35194f94633063b38b49ff133d9372538d
Seungbae Shin [Mon, 27 Dec 2021 05:56:49 +0000 (14:56 +0900)]
Fix for pulseaudio 15.0 upgrade
[Version] 15.0.0
[Issue Type] Core Upgrade
Change-Id: Ie55fa522a3d1e08c8e898ce626a1a199c0f994e6
Jeongmo Yang [Tue, 28 Dec 2021 05:36:01 +0000 (14:36 +0900)]
stream-manager: Deactivate ducking for audio HAL when stream ducking is removed
Previously, deactivation ducking for audio HAL could be missed.
[Version] 13.0.81
[Issue Type] Bug fix
Change-Id: Ide1206dc98f1dd354cb23e6c8cf06361a1d815e3
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Seungbae Shin [Wed, 27 Oct 2021 10:48:01 +0000 (19:48 +0900)]
device-manager: use container dedicated device-map json
[Version] 13.0.80
[Issue Type] Container
Change-Id: If81c7aed340369e451980142d7c677ff22053f98
Seungbae Shin [Thu, 21 Oct 2021 02:33:28 +0000 (11:33 +0900)]
Fix coverity issues (CHECKED_RETURN / PW.PARAMETER_HIDDEN)
+ Fix minor aarch64 build warning
[Version] 13.0.79
[Issue Type] Build
Change-Id: Ie7ed49cf73beb95ce5db332d6595aa6c6def27ab
jungsup lee [Thu, 14 Oct 2021 08:33:19 +0000 (17:33 +0900)]
tizenaudio-sink: Print log when snd_pcm_avail() return small value continuously
[Version] 13.0.78
[Issue Type] Debugging
Change-Id: I982d1ee7cf7a5d0546902aec9f7a498278b4014a
Jaechul Lee [Mon, 27 Sep 2021 05:58:18 +0000 (14:58 +0900)]
Fix DEREF_OF_NULL.RET.PROC.STAT
[Version] 13.0.77
[Issue Type] VD svace
DF210918-00186
Change-Id: I21b72e6fd96ab07521cb807bc26c44e148c00162
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Fri, 24 Sep 2021 12:27:12 +0000 (21:27 +0900)]
Fix aarch64 build warnings
Fixes following warnings:
- cast to pointer from integer of different size [-Wint-to-pointer-cast]
- format '%llu' expects argument of type 'long long unsigned int', but argument 9 has type 'pa_usec_t' {aka 'long unsigned int'} [-Wformat=]
- format '%d' expects argument of type 'int', but argument 7 has type 'size_t' {aka 'long unsigned int'} [-Wformat=]
[Version] 13.0.76
[Issue Type] Build
Change-Id: I55a043c48107c3a3c6bf71cbb8b81f54c504180d
Seungbae Shin [Thu, 23 Sep 2021 12:25:03 +0000 (21:25 +0900)]
sound-player: fix memory leak in case of stopping playback
eos signal with the cause must be sent to client to make proper subscription release
[Version] 13.0.75
[Issue Type] Bug fix
Change-Id: Id318f1a4d18eafeea4e343eef6c02ee63ca2960f
Jaechul Lee [Wed, 8 Sep 2021 04:49:32 +0000 (13:49 +0900)]
tizenaudio-sink2/source2: Fix frames_to_write calculation
[Version] 13.0.74
[Issue Type] Bug fix
Change-Id: Ida9fcab0c380fc71125f64dc90d8a186840f40ae
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Mon, 13 Sep 2021 00:16:49 +0000 (09:16 +0900)]
device-manager: Fix svace defect (DEREF_OF_NULL.RET.PROC.STAT)
[Version] 13.0.73
[Issue Type] Svace
Change-Id: If07027bfc1f37a296aedf440e03fa04040c42ad1
jungsup lee [Wed, 8 Sep 2021 04:54:40 +0000 (13:54 +0900)]
device-manager-dbus: always place bt-sco device at first in device list
[Version] 13.0.72
[Issue Type] Improvement
Change-Id: I15efd7b12c48a3278ad64e9fdb7a2f409cf4183f
jaechul lee [Mon, 6 Sep 2021 06:33:40 +0000 (06:33 +0000)]
Merge "device-manager: Support to load sink2/source2" into tizen
Seungbae Shin [Mon, 15 Mar 2021 07:45:23 +0000 (16:45 +0900)]
support external bt-sco device for tv
[Version] 13.0.71
[Issue Type] Improvement
Change-Id: Ic9d3d00c5a48e319203468550efa5fb40f6f243d
Jaechul Lee [Thu, 12 Aug 2021 05:45:46 +0000 (14:45 +0900)]
device-manager: Support to load sink2/source2
pulseaudio tries to load tizenaudio-sink2/source2 instead of
tizenaudio-sink/source if 'tizen2' keyword is found in device-map file.
[Version] 13.0.71
[Issue Type] Improvement
Change-Id: Ie9c67f4888fb628961811d906e4d6c396700b14e
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 9 Aug 2021 03:41:48 +0000 (12:41 +0900)]
tizenaudio-source2: Use hardware interrupt for capture
* Remove unused arguments
* Use fixed latency
* Use poll event
[Version] 13.0.70
[Issue Type] Improvement
Change-Id: I8be80005a1f8f5ec0e126c76fc54253e2510ea17
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Wed, 4 Aug 2021 01:01:56 +0000 (10:01 +0900)]
tizenaudio-sink2: Use hardware interrupt for playback
* Remove unused arguments (block_msec, max_request_msec)
* Use fixed latency
* Use poll event
[Version] 13.0.69
[Issue Type] Improvement
Change-Id: I404474e0da9837df6fc202cc793af0b5d2c6d799
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Fri, 30 Jul 2021 04:45:30 +0000 (13:45 +0900)]
device-manager: remove checking module arguments
The comparison of the mod args would be failed if unknown args in
device-manager are added like 'echo=1' and it doesn't need to check
module args validation because each module already checks it.
All arguments would be parsed in case of passing NULL.
[Version] 13.0.68
[Issue Type] Improvement
Change-Id: I2be900ef82ecdedc5c181bdc919cd439d0a4b67d
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 2 Aug 2021 05:47:18 +0000 (14:47 +0900)]
Add module-tizenaudio-sink2/source2
module-tizenaudio-sink2/source2 that are copies of
tizenaudio-sink/source without AEC parts were added for a experimental
functionality such as mmap, echo cancel, and non-interleave.
Change-Id: I09588a5d90737da6e2ee9c8b3fd574db012e71f5
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Mon, 31 May 2021 07:23:04 +0000 (16:23 +0900)]
stream-manager-dbus: Add rpi playback route method handler
[Version] 13.0.67
[Issue Type] Internal feature
Change-Id: Iff4048c39bb7601066f21b58a2176a50377c96b9
Seungbae Shin [Tue, 29 Jun 2021 12:35:46 +0000 (21:35 +0900)]
fixup! tizenaudio-sink/source: write or read by calculated period size instead of fixed time.
[Version] 13.0.66
[Issue Type] Bug
Change-Id: I59f0fe0901e6f07a9a071cd29f08e681162dc527
Seungbae Shin [Mon, 17 May 2021 08:57:49 +0000 (17:57 +0900)]
tizenaudio-sink/source: write or read by calculated period size instead of fixed time.
As this code is workaround code for supporting various hw model such as qualcomm board,
will be refactored soon by using parameters given at loading time.
In addition, use _hal_sysconfdir instead of _sysconfdir macro in spec
[Version] 13.0.65
[Issue Type] Bring-up
Change-Id: I96fef562cd7af2a67d3bed90b5db9f4def3edad4
Seungbae Shin [Thu, 10 Jun 2021 08:40:50 +0000 (17:40 +0900)]
Fix SVACE defect (MEMORY_LEAK.EX)
[Version] 13.0.64
[Issue Type] Svace
Change-Id: I1535c4d0f48d2be2e6c4fc54c2b30a6c668dd59e
Seungbae Shin [Tue, 1 Jun 2021 07:55:06 +0000 (16:55 +0900)]
stream/device-manager: use PA_DEFAULT_CONFIG_DIR instead of hardcoding for configuration path
[Version] 13.0.63
[Issue Type] New HAL
Change-Id: I9e5072c5db449a699b231275883608a55f77f288
Seungbae Shin [Tue, 27 Apr 2021 11:12:24 +0000 (20:12 +0900)]
device-manager: enhance some if-else cascaded statements
[Version] 13.0.62
[Issue Type] Revise
Change-Id: I9f8ac0a13e3ee0ed92530f466537e7290e4e16e0
Jaechul Lee [Mon, 29 Mar 2021 05:17:04 +0000 (14:17 +0900)]
aec-manager: Add audio AEC manager
added new feature
[Version] 13.0.61
[Issue Type] New feature
Change-Id: I401390836ee34ea4444180e9725febd1720ac4a4
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Sangchul Lee [Tue, 6 Apr 2021 02:24:46 +0000 (11:24 +0900)]
tizenaudio-policy: Apply new loopback module management
Comparing with the previous logic, it is now possible to
load multiple loopback modules.
- Each loopback module can be loaded per parent id.
- Loading trigger point is moved from route_change_hook_cb()
to select_device_by_manual_routing()
It relates to VPR-402.
[Version] 13.0.60
[Issue Type] New feature
Change-Id: I516f541a1af0548b99c2f3c80e98e12756776117
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 18 Mar 2021 23:58:42 +0000 (08:58 +0900)]
tizenaudio-policy: Preparation for new loopback module management
[Version] 13.0.59
[Issue Type] Improvement
Change-Id: I1fa78fdc41913f0db7e8d08b0ebe4d4c33b21c62
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 17 Mar 2021 04:22:30 +0000 (13:22 +0900)]
stream-manager: Pass parent id when calling callback for selecting sink or source
It is also fixed to pass parent_id as unsigned integer to
STREAM CONNECTION CHANGED callback.
[Version] 13.0.58
[Issue Type] Improvement
Change-Id: I64d300df0c7cc3f68fa97d6bffb809e38421801f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Wed, 24 Mar 2021 07:08:00 +0000 (16:08 +0900)]
stream-manager: handle ramp finished task only at the main thread
Sometimes sd handle is accessed simultaneously in different thread, which may leads to memory corruption.
This patch makes to handle ramp finish task directly only if inside of main thread.
Otherwise, request a message to make it handle from the main thread.
To avoid possible deadlock, request by posting(async) instead of send(sync).
[Version] 13.0.57
[Issue Type] Bug fix
Change-Id: I178dbc5b29adccc6f74e41b7e105681c3fd570d0
Seungbae Shin [Tue, 23 Mar 2021 11:30:55 +0000 (20:30 +0900)]
Revert "stream-manager: handle ramp finished task at core mainloop"
[Version] 13.0.56
[Issue Type] Revert
This reverts commit
5e4cb76033a4a929c90b4dfb57e69c42ec3f58cc.
Change-Id: I04b5587085b31c29ed57dabac3c42ccc0b4f9869
Seungbae Shin [Fri, 19 Mar 2021 05:34:21 +0000 (14:34 +0900)]
stream-manager: handle ramp finished task at core mainloop
Sometimes sd handle is accessed simultaneously, which may leads to memory corruption.
[Version] 13.0.55
[Issue Type] Bug fix
Change-Id: I214c58c1ccde292c918033aaded695f6b59324ef
Sangchul Lee [Thu, 18 Mar 2021 12:19:13 +0000 (21:19 +0900)]
Add support for notifying stream connection information to the policy implementation
[Version] 13.0.54
[Issue Type] New feature
Change-Id: I63ebdd3e62a40d54b04e0ac83f1654015e6095cb
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 18 Mar 2021 11:32:50 +0000 (20:32 +0900)]
stream-manager: Rename enum and function
Incorrect names are revised generically to embrace the actual doing
in the function.
[Version] 13.0.53
[Issue Type] Rename
Change-Id: I2860404667916d7487131fccc02de4fa141f7074
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 18 Mar 2021 11:23:31 +0000 (20:23 +0900)]
stream-manager: Apply designated initializers to arrays
[Version] 13.0.52
[Issue Type] Refactoring
Change-Id: If23ef59b2702618943f2029bd4bcaf35015bba3d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Wed, 17 Mar 2021 07:05:44 +0000 (16:05 +0900)]
stream-manager-dbus: remove unnessary dbus_launch_mdnsd()
mdnsd is changed to launch by socket activation
[Version] 13.0.51
[Issue Type] Dependancy
Change-Id: Id957b580d877c802d282fe746248564998552b20
Sangchul Lee [Tue, 16 Mar 2021 05:36:54 +0000 (14:36 +0900)]
stream-manager-dbus: Update mute vconf only after internal set is successful
[Version] 13.0.50
[Issue Type] Bug fix
Change-Id: Id58f2d54e5a88c583f87ab2ecaa56823b36fd8b3
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Mon, 8 Mar 2021 08:47:34 +0000 (17:47 +0900)]
stream-manager-dbus: fix improper null handling on handle_get_current_volume_type()
[Version] 13.0.49
[Issue Type] Bug fix
Change-Id: I067eeadf9deabcc17676df254984437920765be4
Seungbae Shin [Thu, 4 Mar 2021 04:02:13 +0000 (13:02 +0900)]
stream-manager-dbus: update volume vconf only after internal set is successful
[Version] 13.0.48
[Issue Type] Bug fix
Change-Id: I9238bbe1602b43f1ac1c56ef0029d248ddb56a22
Jeongmo Yang [Tue, 9 Feb 2021 11:52:10 +0000 (20:52 +0900)]
stream-manager-dbus: Skip virtual stream for ducking streams
- The ducking state is never changed because of virtual stream.
[Version] 13.0.47
[Issue Type] Bug fix
Change-Id: I545f381f8868c40eaa8562bcdf4f6ae3afecfb63
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Jaechul Lee [Mon, 25 Jan 2021 05:25:32 +0000 (14:25 +0900)]
hal-interface: Use hal audio api
+ remove minor build warning
[Version] 13.0.46
[Issue Type] Enhancement
Change-Id: Iac9337a9c6f654723eb956f7f7a6b2a85deef8d6
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
jungsup lee [Tue, 5 Jan 2021 06:01:46 +0000 (15:01 +0900)]
device-manager: handle rtsp device
handle rtsp device as network type device
[Version] 13.0.45
[Issue Type] Update
Change-Id: I90e4965c34db184f6177b19cf6e1874a13175723
Signed-off-by: jungsup lee <jungsup4.lee@samsung.com>
Seungbae Shin [Mon, 4 Jan 2021 15:52:21 +0000 (00:52 +0900)]
tizenaudio-policy: unload modules safely when daemon is on shutdown
[Version] 13.0.44
[Issue Type] Bug
Change-Id: Ib92c5cbff8bb48b40eef5685dc5549894a58cdd8
Sangchul Lee [Mon, 28 Dec 2020 08:56:16 +0000 (17:56 +0900)]
stream-manager: Revise conditions to invoke ducking state changed signal
In sink_input_ramp_finish_cb(), it is fixed to send the signal only if
the previous state of stream ducking is DUCKING or UNDUCKING.
Some logs are revised for easy debugging.
[Version] 13.0.43
[Issue Type] Improvement
Change-Id: Ib857d6146afe3279436fa155bf18b0d45e9d1909
Signed-off-by: Sangchul Lee <sangchul1011@gmail.com>
Sangchul Lee [Wed, 23 Dec 2020 05:21:38 +0000 (14:21 +0900)]
tizenaudio-policy: Set use_internal_codec value of combine sink
When a stream is finished, routing path should be updated for one
of remaining streams. If one of them is using internal audio codec
with a combine sink, it should also be updated for the stream.
This patch sets the use_internal_codec value of the combine sink to
true when loading the module if needed.
A function to load the combine module is added and applied.
[Version] 13.0.42
[Issue Type] Bug fix / Refactoring
Change-Id: I02950f4df59535039409b9c75c627dc770c66462
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Fri, 11 Dec 2020 08:50:16 +0000 (17:50 +0900)]
tone-player: Fix asan defect (stack-buffer-underflow)
==pulseaudio==799==ERROR: AddressSanitizer: stack-buffer-underflow on address 0xbdc65da0 at pc 0xb5c397ad bp 0xbdc60db0 sp 0xbdc60e00
READ of size 22 at 0xbdc65da0 thread T0
#0 0xb5c397aa in printf_common(void*, char const*, std::__va_list) (/usr/lib/libasan.so+0x757aa)
#1 0xb5c3b11c in vsnprintf (/usr/lib/libasan.so+0x7711c)
#2 0xb58ca3ba in pa_vsnprintf (/usr/lib/pulseaudio/libpulsecommon-13.0.so+0x4a3ba)
#3 0xb58ddcd8 in pa_log_levelv_meta (/usr/lib/pulseaudio/libpulsecommon-13.0.so+0x5dcd8)
#4 0xb58dd5c6 in pa_log_level_meta (/usr/lib/pulseaudio/libpulsecommon-13.0.so+0x5d5c6)
#5 0xb2e262d8 in module_tone_player_LTX_pa__init (/usr/lib/pulse-13.0/modules/module-tone-player.so+0x22d8)
#6 0xb5ab7072 in pa_module_load (/usr/lib/pulseaudio/libpulsecore-13.0.so+0x56072)
#7 0xb5a9818e in pa_cli_command_load (/usr/lib/pulseaudio/libpulsecore-13.0.so+0x3718e)
#8 0xb5aa06b2 in pa_cli_command_execute_line_stateful (/usr/lib/pulseaudio/libpulsecore-13.0.so+0x3f6b2)
#9 0xb5aa11c4 in pa_cli_command_execute_file_stream (/usr/lib/pulseaudio/libpulsecore-13.0.so+0x401c4)
#10 0x1810a in main (/usr/bin/pulseaudio+0x1810a)
#11 0xb5440c80 in __libc_start_main (/lib/libc.so.6+0x1ac80)
[Version] 13.0.41
[Issue Type] Bug
Change-Id: Ib0c1987d14ac42d47b7e6036b12c1313b275b151
Jaechul Lee [Wed, 9 Dec 2020 03:39:58 +0000 (12:39 +0900)]
tizenaudio-policy: Add max_latency_msec to 100ms
This patch improves the latency of null-src
[Version] 13.0.40
[Issue Type] Improvement
Change-Id: Idf6b2c985dd400a04f71ae5892ed6bd6517612fb
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Sangchul Lee [Thu, 19 Nov 2020 06:37:20 +0000 (15:37 +0900)]
stream-manager: Invoke ramp finish hook when ducking stream is corked
If a user corks a stream that ducking is in progress, it can not get
a ramp finish callback from the pulseaudio core. It leads to invalid
state of the stream ducking handle, therefore it is fixed to trigger
the callback forcedly when this situation happens.
[Version] 13.0.39
[Issue Type] Bug fix
Change-Id: Icbe7d4ce2d70fcbfbba9afb2555a38308df18349
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Jaechul Lee [Wed, 4 Nov 2020 05:20:36 +0000 (14:20 +0900)]
Add null-sink argument norewinds=1
null-sink takes almost 2 seconds when starting to play sound.
[Version] 13.0.38
[Issue Type] Improvement
Change-Id: If53a67c1f822f032f8f3590566b4eaa3b6265d7c
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Thu, 29 Oct 2020 08:51:05 +0000 (17:51 +0900)]
Fix various improper memory handling bugs
- memory leaks due to missing message unref
- memory leaks due to missing dbus string array free.
- potential memory corruption due to passing different size of data type.
- use-after-free of string retrieved by dbus_message_iter_get_basic()
- use duplicated string for strtok_r()
[Version] 13.0.37
[Issue Type] Bug
Change-Id: I6dea62168cef2fd1387f1e1a3ffc37eb2fe47fa5
Seungbae Shin [Thu, 29 Oct 2020 07:34:37 +0000 (16:34 +0900)]
stream-manager-dbus: use pa dbus wrapper function if possible
[Version] 13.0.36
[Issue Type] Revise
Change-Id: Ib30dd5934fa4a2554652feb550937d15a2fa177f
Seungbae Shin [Wed, 28 Oct 2020 11:17:32 +0000 (20:17 +0900)]
device-manager-dbus: use pa dbus wrapper function if possible
[Version] 13.0.35
[Issue Type] Revise
Change-Id: I926a1860bc43b789ae5cf5490973f92b9ddd6cbd
Seungbae Shin [Tue, 27 Oct 2020 11:08:46 +0000 (20:08 +0900)]
device-manager-dbus: fix crash of getting empty supported samplerates/formats
[Version] 13.0.34
[Issue Type] Bug
Change-Id: I8faab3479f9bf2daa87d0f818b50f1a95e96caeb
Seungbae Shin [Wed, 2 Sep 2020 08:35:14 +0000 (17:35 +0900)]
Fix build warnings
[Version] 13.0.33
[Issue Type] Build
Change-Id: Idf96facb42ef0260e96ac1d1af4e9ec131c999a7