Matthias Clasen [Sat, 31 May 2014 12:54:16 +0000 (08:54 -0400)]
docs: Add a 2.42 api index
Edward Hervey [Fri, 30 May 2014 10:25:27 +0000 (12:25 +0200)]
GParamSpec: Use new fundamental instance check
https://bugzilla.gnome.org/show_bug.cgi?id=730984
Edward Hervey [Wed, 28 May 2014 08:59:14 +0000 (10:59 +0200)]
gobject: Use fast fundamental instance type check
Speeds up g_object_ref/_unref by 50%-65% (i.e. takes 60-65% of the time
it used to take).
https://bugzilla.gnome.org/show_bug.cgi?id=730984
Edward Hervey [Wed, 28 May 2014 08:57:28 +0000 (10:57 +0200)]
gtype: Add check for fundamental instance type
When checking whether an instance is of a given fundamental type (such
as G_TYPE_OBJECT), we can avoid over 60%+ of the cost of checking types.
https://bugzilla.gnome.org/show_bug.cgi?id=730984
Matthias Clasen [Fri, 30 May 2014 14:21:43 +0000 (10:21 -0400)]
Fix the closure test in continuous
This test has the same problem as the mapping-test - it uses
SIGUSR1 without checking the signal mask. Apply the same fix
here.
Matthias Clasen [Fri, 30 May 2014 14:18:36 +0000 (10:18 -0400)]
Fix the mapping test in continuous
It turns out that due to a recent gdm change, the inherited
signal mask has SIGUSR1 blocked - which is bad news for
tests using SIGUSR1. Fix the test by explicitly checking the
signal mask before using SIGUSR1.
Thiago Santos [Thu, 29 May 2014 22:13:37 +0000 (19:13 -0300)]
gconvert: mention that the g_convert len should be in bytes
Some charsets have each char with more than one byte, make it clear that
the length should be in bytes
https://bugzilla.gnome.org/show_bug.cgi?id=730963
Matthias Clasen [Wed, 28 May 2014 10:14:56 +0000 (06:14 -0400)]
Add more debug spew to the mapping-test
Philip Withnall [Tue, 27 May 2014 14:50:00 +0000 (15:50 +0100)]
gvariant: Clarify type and format strings in the docs
'@' and '&' are only used in format strings as prefixes to type
strings and not to full format strings.
https://bugzilla.gnome.org/show_bug.cgi?id=729269
Matthias Clasen [Wed, 28 May 2014 02:13:33 +0000 (22:13 -0400)]
mapping-test: Add debug spew
This might help figuring out why the test is failing in continuous.
Dan Winship [Tue, 27 May 2014 13:39:46 +0000 (09:39 -0400)]
gio/tests/network-address: fix when no network is available
GResolver doesn't do full validation of its inputs, so in some of
these tests, the fact that we were getting back
G_RESOLVER_ERROR_NOT_FOUND is because the junk string was getting
passed to an upstream DNS resolver, which returned NXDOMAIN. But if
there's no network on the machine then we'd get
G_RESOLVER_ERROR_INTERNAL instead in that case.
Ryan Lortie [Mon, 26 May 2014 15:34:48 +0000 (17:34 +0200)]
GLib 2.41.0
Ryan Lortie [Mon, 26 May 2014 21:01:25 +0000 (23:01 +0200)]
gio tests: rm xdgconfighome on 'make clean'
Ryan Lortie [Mon, 26 May 2014 15:33:57 +0000 (17:33 +0200)]
Revert "gvariant: Fix confusion between type and format strings in the docs"
This reverts commit
fca1b83be74c9840037cfee84015fd8460cc33f9.
The original documentation was correct.
https://bugzilla.gnome.org/show_bug.cgi?id=729269
Philip Withnall [Fri, 16 May 2014 22:08:10 +0000 (23:08 +0100)]
gtestutils: Error out if /dev/null stdin redirection fails
https://bugzilla.gnome.org/show_bug.cgi?id=730189
Evan Nemerson [Wed, 21 May 2014 07:27:36 +0000 (00:27 -0700)]
gio: port annotations from the Vala metadata.
https://bugzilla.gnome.org/show_bug.cgi?id=730493
Chun-wei Fan [Fri, 23 May 2014 02:14:16 +0000 (10:14 +0800)]
config.h.win32.in: Define _WIN32_WINNT Conditionally
This is done so that _WIN32_WINNT may be overridden in the project files,
if needed, so that one can access the Vista+ (or so) Windows APIs easier
by using "preprocessor defines" (or so) in the Visual C++ project files.
Matthias Clasen [Thu, 22 May 2014 21:22:56 +0000 (17:22 -0400)]
Try to fix mapping-test
The mapping-test is failing under gnome-continuous. I suspect this
is simply due to running many tests in parallel, and mapping-test
being racy. Replace the blind sleep by signals, to avoid the
races.
Murray Cumming [Tue, 29 Apr 2014 11:21:41 +0000 (13:21 +0200)]
GDBusError enum: Remove trailing comma.
This is helpful to people using the g++ --pedantic option.
Marek Kasik [Thu, 22 May 2014 09:00:14 +0000 (11:00 +0200)]
gobject: unref unused class
If g_type_class_ref() returns a class which is not
a GObjectClass we need to unref it before return in
object_interface_check_properties().
https://bugzilla.gnome.org/show_bug.cgi?id=706983
Matthias Clasen [Wed, 21 May 2014 11:40:09 +0000 (07:40 -0400)]
Trivial: fix a guard comment
The conventional comment for the #endif at the bottom of the
header was not matching the #ifdef at the top in glib-private.h.
Fix that.
Philip Withnall [Sat, 17 May 2014 11:08:58 +0000 (12:08 +0100)]
gdbus-tool: Remove dead variables
Coverity issues: #1159447, #1159446
https://bugzilla.gnome.org/show_bug.cgi?id=730295
Philip Withnall [Fri, 16 May 2014 20:47:24 +0000 (21:47 +0100)]
gthread: Fix use of a local variable after it went out of scope
This could theoretically cause problems, although in practice we would
have seen them by now (the bug was introduced in 2012).
Coverity issue: #1159486
https://bugzilla.gnome.org/show_bug.cgi?id=730277
Philip Withnall [Fri, 16 May 2014 21:09:29 +0000 (22:09 +0100)]
gsubprocess: Add a missing va_end() call
Coverity issues: #1214070, #1214069
https://bugzilla.gnome.org/show_bug.cgi?id=730278
Chun-wei Fan [Mon, 19 May 2014 06:49:39 +0000 (14:49 +0800)]
Update config.h.win32.in for Newer Windows
Make use of if_indextoname() and if_nametoindex() when building against
Window Vista/Server 2008 or later, as these are provided by the system.
This is not turned on by default as we still want to support XP and
Server 2003-turn this on by changing _WIN32_WINNT to 0x600 or later prior
to compiling GLib.
https://bugzilla.gnome.org/show_bug.cgi?id=730352
Marek Černocký [Sun, 18 May 2014 06:38:05 +0000 (08:38 +0200)]
Updated Czech translation
Yosef Or Boczko [Fri, 16 May 2014 01:37:21 +0000 (04:37 +0300)]
Updated Hebrew translation
Philip Withnall [Thu, 15 May 2014 11:16:00 +0000 (12:16 +0100)]
gsocket: Add missing preconditions to g_socket_send_message()
https://bugzilla.gnome.org/show_bug.cgi?id=730190
Philip Withnall [Thu, 15 May 2014 09:18:38 +0000 (10:18 +0100)]
gresource-tool: Fix an FD leak in an error path
Coverity issues: #1214054, #1214055, #1214056
Philip Withnall [Thu, 15 May 2014 09:15:26 +0000 (10:15 +0100)]
gtestutils: Don’t free unassigned variables in an error path
If the stream is invalid, msg.nums and msg.strings have not been
assigned to, so don’t free them.
Coverity issue: #1159505
Matthias Clasen [Tue, 13 May 2014 03:05:41 +0000 (23:05 -0400)]
Avoid overeager warning about deprecated properties
Construct properties are always set during construction.
It makes no sense to warn about this even if the property
is marked as deprecated; the deprecation warning should
only be issues for explicit uses of the property after
construction.
https://bugzilla.gnome.org/show_bug.cgi?id=730045
Matthias Clasen [Thu, 8 May 2014 03:08:50 +0000 (23:08 -0400)]
Remove some markup from docs
Chun-wei Fan [Tue, 18 Mar 2014 04:54:10 +0000 (12:54 +0800)]
gio/gtestdbus.c: Fix write_config_file() for Windows
Windows does not like g_unlink() to be called on files whose file
descriptor is still open, so doing that would cause a permission
denied error. Since the fd is not used in that function after
acquiring the temp file, close it earlier before
g_file_set_contents(), so that it can complete successfully.
This fixes a number of GTK+ tests on Windows.
https://bugzilla.gnome.org/show_bug.cgi?id=719344
Sébastien Wilmet [Sun, 11 May 2014 21:41:23 +0000 (23:41 +0200)]
doc: better ordering of GSubprocessLauncher functions
Take the same order as the header.
Daniel Mustieles [Sat, 10 May 2014 17:43:59 +0000 (19:43 +0200)]
Updated Spanish translation
Tom Tromey [Fri, 21 Feb 2014 19:16:00 +0000 (19:16 +0000)]
gobject.py: Port to gdb 7.7 frame filter API
https://bugzilla.gnome.org/show_bug.cgi?id=623552
Sébastien Wilmet [Mon, 21 Apr 2014 12:50:53 +0000 (14:50 +0200)]
doc: various improvements
- GSubprocessLauncher exists since 2.40, not 2.36
- more logical order for g_markup functions
- fix short description of GMarkup
- GMarkupParser: specify that some parameters are NULL-terminated.
- g_string_new (NULL); is possible.
- other trivial fixes.
https://bugzilla.gnome.org/show_bug.cgi?id=728983
Lukasz Skalski [Fri, 9 May 2014 13:06:52 +0000 (15:06 +0200)]
gio: cleanup gdbusmessage.c file
* removed passing GError to ensure_input_padding() function
- it was necessary before commit
3e5214c15c2a19b64d74e714
when we used GData*Streams and GMemoryInputStream with
g_seekable_seek() - now it's useless,
* removed checking return value of ensure_input_padding()
function - in previous implementation (like above)
g_seekable_seek() could return FALSE - now it's always TRUE,
* removed passing GError to g_memory_buffer_read_*() functions
and checking returned value - it also has been inherited after
old implementation with g_data_input_stream_read_*() functions
- now it's also useless
* cleaned up code formatting,
https://bugzilla.gnome.org/show_bug.cgi?id=729875
Ryan Lortie [Thu, 8 May 2014 20:16:35 +0000 (16:16 -0400)]
tests: add testcase for {Only,Not}ShowIn
https://bugzilla.gnome.org/show_bug.cgi?id=729813
Ryan Lortie [Thu, 8 May 2014 12:57:50 +0000 (08:57 -0400)]
AppInfo: use XDG_CURRENT_DESKTOP for OnlyShowIn
Expand the functionality of g_desktop_app_info_set_desktop_env() to
include the possibility of passing strings containing ':' characters (as
some apps, such as gnome-session, are directly passing the value of
XDG_CURRENT_DESKTOP). At the same time, deprecate it, since now we get
the list from the environment variable for ourselves.
Modify the checks in g_desktop_app_info_get_show_in() to deal with
multiple items listed in XDG_CURRENT_DESKTOP. For example, if we find
that we have
XDG_CURRENT_DESKTOP=GNOME-Classic:GNOME
and a desktop file contains:
OnlyShowIn=GNOME
then we will show this file because of the fallback to GNOME. If the
file _also_ contains the line:
NotShowIn=GNOME-Classic
Then we will not show it, because GNOME-Classic comes before GNOME in
XDG_CURRENT_DESKTOP.
https://bugzilla.gnome.org/show_bug.cgi?id=729813
Ryan Lortie [Fri, 15 Nov 2013 19:44:33 +0000 (14:44 -0500)]
tests: add tests for GDesktopAppInfo Implements=
https://bugzilla.gnome.org/show_bug.cgi?id=712391
Ryan Lortie [Fri, 15 Nov 2013 19:44:11 +0000 (14:44 -0500)]
docs: add two missing symbols on GDesktopAppInfo
https://bugzilla.gnome.org/show_bug.cgi?id=712391
Ryan Lortie [Fri, 15 Nov 2013 19:40:37 +0000 (14:40 -0500)]
Add g_desktop_app_info_get_implementations()
This provides support for the draft addition of 'Implements=' to the Desktop
Entry specification.
https://bugzilla.gnome.org/show_bug.cgi?id=712391
Matthias Clasen [Tue, 6 May 2014 00:30:35 +0000 (20:30 -0400)]
Add a testcase for the previous fix
This testcase tests that short option arguments are
not erroneously added to the remaining argument array
when g_option_context_set_ignore_unknown_options is
called.
https://bugzilla.gnome.org/show_bug.cgi?id=729563
Kjell Ahlstedt [Mon, 5 May 2014 12:40:31 +0000 (14:40 +0200)]
goption: Don't include parsed option values in G_OPTION_REMAINING
After a call to g_option_context_set_ignore_unknown_options(context, TRUE),
the values of short options were included in the array returned by a
G_OPTION_REMAINING option.
https://bugzilla.gnome.org/show_bug.cgi?id=729563
Lionel Landwerlin [Tue, 21 Jan 2014 19:12:08 +0000 (19:12 +0000)]
gio: iostream: use GTask instead of internal pointer
This fixes an infinite recursion loop when calling
g_io_stream_close_async() on a SoupIOStream.
https://bugzilla.gnome.org/show_bug.cgi?id=722723
Mathieu Bridon [Mon, 5 May 2014 10:30:56 +0000 (18:30 +0800)]
Fix some typos in documentation
Philip Withnall [Fri, 2 May 2014 07:42:06 +0000 (09:42 +0200)]
docs: Add a README.rationale documenting major design decisions
It will be useful to document the major decisions which affect the whole
of GLib in one centralised, easily-greppable file, otherwise they will
get lost forever in Bugzilla.
This file should contain a brief explanation of the decision and its
rationale, plus a link to further discussion (e.g. on a mailing list or
bug report).
This contains an initial discussion about use of compiler attributes in
GLib.
https://bugzilla.gnome.org/show_bug.cgi?id=113075
Philip Withnall [Thu, 28 Nov 2013 20:39:56 +0000 (20:39 +0000)]
gstrfuncs: Add missing preconditions to g_str_match_string()
https://bugzilla.gnome.org/show_bug.cgi?id=113075
Dan Winship [Sat, 3 May 2014 21:24:48 +0000 (17:24 -0400)]
gio: add a missing property to GDummyTlsConnection
GDummyTlsConnection didn't implement the "interaction" property,
meaning you'd get warnings if you tried to set it while creating a
GTlsConnection when using the dummy backend. (Of course, trying to
create the GTlsConnection will fail anyway, but it ought to fail
without hitting any g_warnings.)
Pau Iranzo [Fri, 2 May 2014 10:41:30 +0000 (12:41 +0200)]
[l10n] Update Catalan translation
Philip Withnall [Wed, 30 Apr 2014 14:58:21 +0000 (16:58 +0200)]
docs: Fix some minor typos in the GVariant documentation
https://bugzilla.gnome.org/show_bug.cgi?id=729269
Philip Withnall [Wed, 30 Apr 2014 14:37:30 +0000 (16:37 +0200)]
gvariant: Fix confusion between type and format strings in the docs
‘@’ and ‘&’ are only used in format strings, not type strings.
https://bugzilla.gnome.org/show_bug.cgi?id=729269
Philip Withnall [Tue, 29 Apr 2014 07:47:14 +0000 (08:47 +0100)]
gobject: Document that classes/objects/interfaces are zero-filled
On initialisation, GObject guarantees to zero-fill
class/object/interface structures. Document this so people don’t spend
forever writing:
my_object->priv->some_member = NULL;
my_object->priv->some_other_member = NULL;
https://bugzilla.gnome.org/show_bug.cgi?id=729167
Matej Urbančič [Mon, 28 Apr 2014 19:47:39 +0000 (21:47 +0200)]
Updated Slovenian translation
Matej Urbančič [Mon, 28 Apr 2014 19:45:20 +0000 (21:45 +0200)]
Updated Slovenian translation
Matej Urbančič [Mon, 28 Apr 2014 19:28:16 +0000 (21:28 +0200)]
Updated Slovenian translation
Lars Uebernickel [Mon, 28 Apr 2014 07:26:32 +0000 (09:26 +0200)]
gmenuexporter: fix protocol documentation link
Enrico Nicoletto [Sun, 27 Apr 2014 00:19:44 +0000 (00:19 +0000)]
Updated Brazilian Portuguese translation
Juan Pablo Ugarte [Fri, 25 Apr 2014 22:35:58 +0000 (19:35 -0300)]
Added type check to GPermission public functions.
Philip Withnall [Thu, 24 Apr 2014 08:26:12 +0000 (09:26 +0100)]
gresolver: Ensure GThreadedResolver always sets an error if resolution fails
It was previously possible for GThreadedResolver to return an empty list
and no error in response to a g_resolver_lookup_by_name() call, if it
happened that all the addresses returned by getaddrinfo() could not be
converted from native addresses to GSocketAddresses.
Fix that by setting a G_RESOLVER_ERROR_NOT_FOUND if the returned list is
empty.
https://bugzilla.gnome.org/show_bug.cgi?id=728776
Philip Withnall [Thu, 24 Apr 2014 08:24:48 +0000 (09:24 +0100)]
gresolver: Document that GResolver lists are non-empty on success
The documentation previously wasn’t clear about whether the GResolver
methods could return an empty list and no error. On balance, this seems
like a bad idea, and GResolver should commit to always return a
non-empty list, or an error (which should be G_RESOLVER_ERROR_NOT_FOUND
if the list would otherwise be empty).
https://bugzilla.gnome.org/show_bug.cgi?id=728776
Dan Winship [Thu, 24 Apr 2014 16:15:55 +0000 (12:15 -0400)]
gio: remove an unneeded pragma
ddf82a25 removed the use of non-literal format strings from
gthreadedresolver.c, but left the "#pragma GCC diagnostic ignored
-Wformat-nonliteral" behind.
Volker Sobek [Wed, 16 Apr 2014 21:56:02 +0000 (23:56 +0200)]
docs: Remove <!-- --> comment before plural s
These did show up in the html. Since symbol names are checked for a
trailing plural s when generating the docs, the links stay functional
after removing these comments.
https://bugzilla.gnome.org/show_bug.cgi?id=728380
Philip Withnall [Wed, 6 Nov 2013 10:54:06 +0000 (10:54 +0000)]
gaction: Minor clarifications in the GAction documentation
https://bugzilla.gnome.org/show_bug.cgi?id=728350
Antoine Jacoutot [Wed, 16 Apr 2014 08:27:09 +0000 (10:27 +0200)]
platform_get_argv0: drop unneeded headers for OpenBSD
And properly set the size of len.
There is also no need for realloc(), g_malloc0 will do just fine.
https://bugzilla.gnome.org/show_bug.cgi?id=728280
Philip Withnall [Sat, 19 Apr 2014 17:22:24 +0000 (18:22 +0100)]
gfile: More explicitly document the context for GFileProgressCallback
Be more explicit in the documentation for g_file_copy_async() about
which GMainContext its progress callback is executed in.
https://bugzilla.gnome.org/show_bug.cgi?id=728565
marablack3 [Fri, 18 Apr 2014 17:55:02 +0000 (17:55 +0000)]
Updated Greek translation
Philip Withnall [Wed, 16 Apr 2014 18:03:56 +0000 (19:03 +0100)]
gio: Document that GSocket is not thread safe
https://bugzilla.gnome.org/show_bug.cgi?id=726318
Philip Withnall [Wed, 19 Feb 2014 18:02:37 +0000 (18:02 +0000)]
hmac: Add support for SHA-512 in GHmac
The block size wasn’t configured before, so calling g_hmac_new() with
G_CHECKSUM_SHA512 would hit a g_assert_not_reached() and explode.
Implement G_CHECKSUM_SHA512 and add unit tests for HMACs with SHA-256
and SHA-512 using the test vectors from RFC 4868.
https://bugzilla.gnome.org/show_bug.cgi?id=724741
Ryan Lortie [Wed, 16 Apr 2014 11:53:58 +0000 (07:53 -0400)]
Revert "Bug 724590 - GSlice slab_stack corruption"
This reverts commit
c49ec3c8d7a90589308ce1b87a92bc627335ffd2.
John Ralls [Mon, 17 Feb 2014 23:51:38 +0000 (15:51 -0800)]
Bug 724590 - GSlice slab_stack corruption
Dereference allocation->contention_counters before trying to take the
address of an element.
Volker Sobek [Tue, 15 Apr 2014 14:18:59 +0000 (16:18 +0200)]
docs: Use markdown links in all .c and .h files
Commit
e7fd3de86d60 already did most of this.
https://bugzilla.gnome.org/show_bug.cgi?id=728285
Ryan Lortie [Tue, 15 Apr 2014 18:10:39 +0000 (14:10 -0400)]
gdesktopappinfo: fix a crasher
During the time that we are expanding the strv, it is not
null-terminated. Use the strv_len variable instead to bound the search
for duplicates.
Alberto Ruiz [Tue, 15 Apr 2014 16:56:26 +0000 (18:56 +0200)]
gio: fix g-i annotations in g_settings_schema_source_list_schemas()
Ryan Lortie [Thu, 10 Apr 2014 16:00:40 +0000 (12:00 -0400)]
tests: use mimeapps.list over defaults.list
defaults.list is deprecated, so use mimeapps.list as a filename instead.
https://bugzilla.gnome.org/show_bug.cgi?id=728040
Ryan Lortie [Wed, 9 Apr 2014 12:44:18 +0000 (08:44 -0400)]
GDesktopAppInfo: rewrite content type code
Redo the code for type-based selection of applications (all,
recommended, default, fallback) based on the new DesktopFileDir
structures that we introduced last cycle.
At the same time, we expand the functionality to add support for the new
features of the specification:
- moving ~/.local/share/applications/mimeapps.list to ~/.config/
- per-desktop default applications (via XDG_CURRENT_DESKTOP)
- sysadmin customisation of defaults (via /etc/xdg/mimeapps.list)
- deprecation of the old defaults.list, favouring the use of
/usr/share/applications/mimeapps.list (or gnome-mimeapps.list) to
accomplish the same
We modify the mimeapps testcase to check for mimeapps.list having been
created in XDG_CONFIG_HOME instead of XDG_DATA_HOME.
The modification is a net reduction of code (due to less duplication in
bookkeeping). It is also an increase in performance and reduction in
memory consumption (due to simplified data structures). Finally, it
removes the stat-based timestamp checking in favour of the
GFileMonitor-based approach that was already being used in the
implementation of DesktopFileDir (in order to know if we had to rescan
the desktop files themselves).
https://bugzilla.gnome.org/show_bug.cgi?id=728040
Ryan Lortie [Fri, 11 Apr 2014 02:32:28 +0000 (22:32 -0400)]
mimetype tests: don't depend on specific behaviour
We currently assume that setting an application as the default will take
it to the front of the list of supported applications for a given type,
but this is not necessarily true.
Check instead that the application is actually set as default.
https://bugzilla.gnome.org/show_bug.cgi?id=728040
Ryan Lortie [Thu, 10 Apr 2014 15:49:21 +0000 (11:49 -0400)]
appmonitor test: avoid /usr/share
Set XDG_DATA_DIRS to make sure we don't use /usr/share from the
appmonitor test. We will soon throw a warning if we find defaults.list,
so make sure we don't open ourselves up to that if there is one on the
system.
https://bugzilla.gnome.org/show_bug.cgi?id=728040
Ryan Lortie [Wed, 9 Apr 2014 22:59:20 +0000 (18:59 -0400)]
tests: expand 'apps' tool
Add modes to output the applications found for get_default_,
get_recommended_, get_fallback_ and get_all_for_type().
https://bugzilla.gnome.org/show_bug.cgi?id=728040
Ryan Lortie [Wed, 9 Apr 2014 23:14:37 +0000 (19:14 -0400)]
mimeapps test: fix defaults vs. recommended
The desktop file for myapp3 didn't declare support for image/png, but
the testcase expects it to be recommended on the basis of it being the
default app according to defaults.list.
This will not work in the future -- we will only list apps that actually
support the filetype in question, unless they've been explicitly added
as associations.
https://bugzilla.gnome.org/show_bug.cgi?id=728040
Ryan Lortie [Wed, 9 Apr 2014 23:23:27 +0000 (19:23 -0400)]
desktop-app-info test: use g_assert_strcmp()
Replace some assert(strcmp()) with g_assert_strcmp() so that we get
better output in case of failures.
https://bugzilla.gnome.org/show_bug.cgi?id=728040
Antoine Jacoutot [Thu, 10 Apr 2014 09:16:44 +0000 (11:16 +0200)]
build: also unset LIBS when LDFLAGS is unset
On OpenBSD, libintl is installed under /usr/local/lib. When configure
checks unset LDFLAGS, LIBS should also be unset otherwise we end up with
-lintl which cannot be found resulting to the compile check to fail.
https://bugzilla.gnome.org/show_bug.cgi?id=727939
Colin Walters [Sat, 12 Apr 2014 17:26:29 +0000 (13:26 -0400)]
gdesktopappinfo: Don't double free sn_id
Not sure why mclasen added a g_free() in that path, it was just wrong.
We free it correctly later.
Colin Walters [Sat, 12 Apr 2014 17:21:20 +0000 (13:21 -0400)]
gdesktopappinfo: Initialize sn_id to NULL
Otherwise we'll be freeing a random stack pointer.
Antoine Jacoutot [Thu, 10 Apr 2014 08:40:16 +0000 (10:40 +0200)]
openbsd: remove -pthread
This is not needed any longer; libpthread is properly included in
shared libs on OpenBSD where -pthread -lpthread mean the same.
Matthias Clasen [Fri, 11 Apr 2014 22:46:38 +0000 (15:46 -0700)]
Deal with startup notify id being NULL
The app launch context may just not support startup notification,
in which case, g_app_launch_context_get_startup_notify_id() will
return NULL.
Failure to take this into account leads to criticals like this:
gnome-session[8489]: GLib-CRITICAL: g_variant_new_take_string: assertion 'string != NULL' failed
gnome-session[8489]: GLib-CRITICAL: g_variant_new_variant: assertion 'value != NULL' failed
gnome-session[8489]: GLib-CRITICAL: g_variant_get_type: assertion 'value != NULL' failed
gnome-session[8489]: GLib-CRITICAL: g_variant_type_is_subtype_of: assertion 'g_variant_type_check (type)' failed
https://bugzilla.gnome.org/show_bug.cgi?id=728066
Emmanuele Bassi [Mon, 10 Mar 2014 15:16:44 +0000 (15:16 +0000)]
gparam: Add G_PARAM_READWRITE to GParamFlags
Using a #define for an enumeration value buys us nothing, and it's
mostly historical baggage that makes binding GObject needlessly
complicated.
https://bugzilla.gnome.org/show_bug.cgi?id=726037
Cosimo Cecchi [Thu, 10 Apr 2014 01:07:38 +0000 (18:07 -0700)]
gapplication-tool: ensure object paths are valid
Hyphens are not valid characters for DBus object paths; see the similar
code in gapplicationimpl-dbus.c
https://bugzilla.gnome.org/show_bug.cgi?id=727928
Cosimo Cecchi [Thu, 10 Apr 2014 01:07:22 +0000 (18:07 -0700)]
gapplication-tool: fix a typo
This must have never worked.
https://bugzilla.gnome.org/show_bug.cgi?id=727928
Dan Winship [Wed, 9 Apr 2014 13:57:46 +0000 (09:57 -0400)]
g_str_has_prefix: don't call strlen(str)
There's no reason to check the length of @str in g_str_has_prefix(),
since if it's shorter than @prefix, the strncmp() will fail anyway.
And besides making the function less efficient, it also breaks code
like:
if (buf->len >=3 && g_str_has_prefix (buf->data, "foo"))
...
which really looks like it ought to work whether buf->data is
nul-terminated or not.
https://bugzilla.gnome.org/show_bug.cgi?id=727890
Debarshi Ray [Thu, 10 Apr 2014 13:26:45 +0000 (15:26 +0200)]
giomodule: Add a NULL guard to extension_point_get_extension_by_name
... otherwise a NULL input will lead to a crash in strcmp.
https://bugzilla.gnome.org/show_bug.cgi?id=727964
Alexandre Rostovtsev [Mon, 2 Sep 2013 17:59:18 +0000 (13:59 -0400)]
gobject: try to link with -Wl,-z,nodelete
Since the type system does not support reloading its data and assumes
that libgobject remains loaded for the lifetime of the process, we
should link libgobject with a flag indicating that it can't be unloaded.
https://bugzilla.gnome.org/show_bug.cgi?id=707298
Colin Walters [Thu, 3 Apr 2014 18:05:45 +0000 (14:05 -0400)]
g_file_copy: Don't set GError when we intend to ignore errors
For better or worse, the current g_file_copy intention was to ignore
errors copying metadata, but we still set the GError, while returning
TRUE.
https://bugzilla.gnome.org/show_bug.cgi?id=727559
Stef Walter [Wed, 9 Apr 2014 14:14:11 +0000 (16:14 +0200)]
gio: Add newer dbus UnknownXxxx and PropertyReadOnly errors
Add G_DBUS_ERROR codes for:
* org.freedesktop.DBus.Error.UnknownObject
* org.freedesktop.DBus.Error.UnknownInterface
* org.freedesktop.DBus.Error.UnknownProperty
* org.freedesktop.DBus.Error.PropertyReadOnly
These were discussed on the dbus mailing list
and introduced in the following libdbus commit:
2c34514620c4b79ea4ec71d1db583379138d01ac
https://bugzilla.gnome.org/show_bug.cgi?id=727900
Dan Winship [Wed, 9 Apr 2014 14:39:45 +0000 (10:39 -0400)]
gtlscertificate: fix certificate list parsing with trailing comments
g_tls_certificate_list_new_from_file() was supposed to ignore non-PEM
content, but it accidentally required that there not be anything after
the last certificate. Fix that.
https://bugzilla.gnome.org/show_bug.cgi?id=727692
Daniel Korostil [Sun, 6 Apr 2014 13:28:40 +0000 (16:28 +0300)]
Updated Ukrainian translation
Marek Kasik [Thu, 3 Apr 2014 15:35:22 +0000 (17:35 +0200)]
GApplication: Don't decrease use_count below 0
Place an assert for use_count to be at least 1
in g_application_release() so we don't decrease
it below 0.
https://bugzilla.gnome.org/show_bug.cgi?id=727551
David King [Fri, 4 Apr 2014 09:42:56 +0000 (10:42 +0100)]
docs: Fix typo in g_unichar_iswide_cjk() comment
Paolo Borelli [Thu, 3 Apr 2014 09:33:33 +0000 (11:33 +0200)]
Add a small note to g_cclosure_marshal_generic docs
reviewed-by: Emmanuele Bassi