Thays Grazia [Wed, 28 Jul 2021 10:40:34 +0000 (07:40 -0300)]
[mono] Add GC unsafe transition to mono_unhandled_exception (#56380)
* Fix assert gc_unsafe.
* Update src/mono/mono/metadata/object.c
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
Adam Sitnik [Wed, 28 Jul 2021 10:16:15 +0000 (12:16 +0200)]
don't fail the file extraction when we can't set last write time (#56370)
Jakob Botsch Nielsen [Wed, 28 Jul 2021 08:27:36 +0000 (10:27 +0200)]
Properly rebuild optimization data when it changes (#56397)
The timestamp of the merged .mibc file was set to when the tool was
invoked, while the inputs have a timestamp from when they were created
in the training scenarios. That means the target to create the merged
.mibc file would not run incrementally until many weeks later.
To fix add an --inherit-timestamp flag to dotnet-pgo that makes the
merged output inherit the max timestamp from the inputs. This is not
ideal as it means incrementally going backwards does not work, but it's
better than the previous behavior.
Fix #53637
Jan Vorlicek [Wed, 28 Jul 2021 08:23:38 +0000 (10:23 +0200)]
Make open function calls in coreclr EINTR resilient on macOS (#56403)
It was reported that on macOS, the open syscall can sometimes
return EINTR if it is interrupted by a signal even if the
signal has a handler installed with SA_RESTART.
There was just one call to open in the coreclr that
didn't have EINTR handled and that can be called on macOS, so
this change fixes it.
There are two places in the libraries in the included 3rd party
code - the brotli and the zlib - that don't have this treatment yet.
We may want to update them unless the policy we have for them is
to make changes upstream.
Viktor Hofer [Wed, 28 Jul 2021 08:12:18 +0000 (10:12 +0200)]
Fix dependency from EventLog to TraceSource ref (#56417)
* Fix dependency from EventLog to TraceSource ref
This regressed with https://github.com/dotnet/runtime/commit/
663c40dbc4ccedf82e38e96391c28695da0e418f. Reference projects should never reference source projects. This is one of the reasons why slngen creates different solution files now.
* Update Microsoft.Extensions.DependencyInjection.Abstractions.csproj
Egor Bogatov [Wed, 28 Jul 2021 05:49:10 +0000 (08:49 +0300)]
Fix comments in asm with JitDiffableDasm=1 (#56416)
* Avoid asserts in DasmDiffable mode
* simplify
* Make formatter happier
* Address feedback
Stephen Toub [Wed, 28 Jul 2021 01:50:15 +0000 (21:50 -0400)]
Catch TcpClient ctor exceptions in FtpWebRequest.CreateConnectionAsync (#56379)
Steve Harter [Wed, 28 Jul 2021 01:35:54 +0000 (20:35 -0500)]
Add interop between serializer and DOMs (#56112)
David Wrighton [Tue, 27 Jul 2021 23:41:19 +0000 (16:41 -0700)]
Fix type loader not recognizing overridden method (#56337)
* Fix type loader not recognizing overridden method
- Result of a bad change when removing support for full stub dispatch in .NET 4.0 timeframe (circa 2008)
- Caused issue when the following set of conditions were all true
- The type implements an interface
- The interface has more virtual methods on it than the number of virtual methods on the base type of the type.
- The base type implements the interface partially (and the partial implementation has a slot number greater than the number of virtual methods on the base type + its base types)
- The type does not re-implement the interface methods implemented by the base type.
- The comment referred to situations where stub dispatch was used to resolve non-virtual calls which is a very long time removed feature and is not applicable to today's codebase.
- Not reachable with versions of C# that shipped before the default interfaces feature, but with that feature became easily reachable. Has been a bug since .NET 4 for handwritten IL.
Fixes #44533
John Salem [Tue, 27 Jul 2021 22:55:00 +0000 (15:55 -0700)]
Prevent Segfault in EventPipe on disable (#56104)
Mateo Torres-Ruiz [Tue, 27 Jul 2021 22:24:16 +0000 (15:24 -0700)]
Update runtimeconfig.json and deps.json paths when these break past the MAX_PATH threshold (#56224)
* Update runtimeconfig paths if we exceed MAX_PATH
* Add test
* PR feedback
* Get apphost for all platforms
* Probe bundle first
Fix return value of realpath
* Check for empty path upfront
Tomáš Matoušek [Tue, 27 Jul 2021 22:16:59 +0000 (15:16 -0700)]
Use native allocator instead of pinning when decompressing embedded PDB (#56336)
Steve Pfister [Tue, 27 Jul 2021 21:49:17 +0000 (17:49 -0400)]
Specify win-x64 as a valid platform in the microsoft-net-runtime-* workloads for iOS/tvOS/MacCatalyst (#56311)
In a prior change, win-x64 was specified for runtimes-*, but it is also needed in the other workloads
Jan Vorlicek [Tue, 27 Jul 2021 21:40:28 +0000 (23:40 +0200)]
Fix FailFast message formatting race (#56388)
* Fix FailFast message formatting race
SystemNative::GenericFailFast uses a global buffer for messages shorter than certain size.
When multiple threads call FailFast at the same time, they all use the same buffer,
overwriting each other's message. That leads to a problem on Unix when the message is
converted to UTF-8 using two calls to WideCharToMultiByte and another thread changes
the message to a longer one between those two calls. So the buffer size the first
call determines is no longer sufficient.
Stephen Toub [Tue, 27 Jul 2021 21:17:03 +0000 (17:17 -0400)]
Try to fix finalizer-based async tests (#56384)
A dump from a failure showed the finalizable object we're relying on was unrooted and waiting for finalization. Issue more Collects to see if that helps.
Noah Falk [Tue, 27 Jul 2021 20:41:54 +0000 (13:41 -0700)]
Fix MetricsEventSource tests (#56382)
Last week I added a change to the error handling behavior when MetricEventSource
is enabled by multiple listeners and didn't properly update the tests.
1. The major issue was timout failures which were being caused because there is
a bug in EventListener where it doesn't notify EventSources that the source has
been disabled when the listener is disposed. This in turn caused every tests after
the first to reject the new EventListener because the EventSource believed it was
still in use by the first EventListener.
(EventListener bug is tracked https://github.com/dotnet/runtime/issues/56378)
2. A secondary issue is that I didn't update the test which was explicitly verifying
the behavior where the EventSource emits an error in response to having two
listeners and I had changed the product behavior there.
Fixes:
1. I worked around the EventListener bug by explicitly calling DisableEvents().
I also updated OnEventWritten to log the MultipleSessionsNotSupportedError
so that any future error that is similar has more obvious diagnostic logging.
2. I updated the test with new expectation that the 1st listener continues normal
operation and the 2nd listener is the one that gets rejected.
I also did a little refactoring and added a 2nd tests of multiple listeners to confirm
it works if the first one is disabled before the 2nd one starts.
Alexander Köplinger [Tue, 27 Jul 2021 20:06:31 +0000 (22:06 +0200)]
Remove invalid Castle.DynamicProxy.Internal.AbstractInvocation from ILLink descriptor files (#56392)
The type is actually in the `Castle.DynamicProxy` namespace, not the `.Internal` one.
This causes an error with newer linker versions.
The whole `Castle.DynamicProxy` namespace is already preserved so we can remove the entry for AbstractInvocation.
Mitchell Hwang [Tue, 27 Jul 2021 19:37:04 +0000 (15:37 -0400)]
[libraries][iOS][tvOS][MacCatalyst] Remove ActiveIssue from no longer… (#56401)
* [libraries][iOS][tvOS][MacCatalyst] Remove ActiveIssue from no longer failing Microsoft.Extensions.Hosting.Unit.Tests
* Remove StopAsyncWithCancellation Active Issue as well
Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
Mitchell Hwang [Tue, 27 Jul 2021 19:04:37 +0000 (15:04 -0400)]
Remove ActiveIssues from tests no longer failing (#56393)
Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
Steve Pfister [Tue, 27 Jul 2021 18:40:15 +0000 (14:40 -0400)]
Have HttpClientHandler throw the InnerException when catching TargetInvocationException (#56334)
Originally on mobile workloads when UseNativeHttpHandler is set to true, all reflection method invokes
bubbled up a TargetInvocationException. To make the details a bit more readable, we will instead rethrow
the InnerException.
Fixes https://github.com/dotnet/runtime/issues/56089
Miha Zupan [Tue, 27 Jul 2021 18:39:44 +0000 (11:39 -0700)]
Surface exceptions thrown by LoopbackSocksServer (#56396)
Eirik Tsarpalis [Tue, 27 Jul 2021 18:10:54 +0000 (21:10 +0300)]
fix ByteArrayConverter null handling inconsistencies. (#56390)
Fixes #49728.
Adam Sitnik [Tue, 27 Jul 2021 18:07:49 +0000 (20:07 +0200)]
Add tests for reads and writes beyond EOF (#56395)
* ensure that reads beyond EOF return 0
* ensure that writes beyond EOF extend the file and the content is zeroed
Andy Ayers [Tue, 27 Jul 2021 17:53:44 +0000 (10:53 -0700)]
JIT: more fixes for VN loop dependence tracking (#56184)
Specify `Overwrite` when setting loop dependence map entries, as we may
refine the initial result.
Fixes #56174.
Extract loop dependence of `VNF_PhiMemoryDef`.
Fixes new case noted in #55936, and 13/16 or so other cases Jakob sent
me privately. Also update a comment and fix tests to work better with
jitstress per other notes on that PR.
Koundinya Veluri [Tue, 27 Jul 2021 16:59:14 +0000 (09:59 -0700)]
Fix thread pool hang (#56346)
* Fix thread pool hang
- In https://github.com/dotnet/runtime/pull/53471 the thread count goal was moved out of `ThreadCounts`, it turns out that are a few subtle races that it was avoiding. There are other ways to fix it, but I've added the goal back into `ThreadCounts` for now.
- Reverted PR https://github.com/dotnet/runtime/pull/55985, which worked around the issue in the CI
Fixes https://github.com/dotnet/runtime/issues/55642
* Revert "mitigation for quic tests hangs (#55985)"
This reverts commit
0a5e93b09fe92cf866456552eef78a95bf6fdf27.
Jan Vorlicek [Tue, 27 Jul 2021 16:51:28 +0000 (18:51 +0200)]
Update CG2 ArgIterator to match the runtime one (#56059)
* Update CG2 ArgIterator to match the runtime one
The goal of the change is primarily to make it correct for the Apple
Silicon where the calling convention slightly differs from the
Unix ARM64 one, especially in passing arguments smaller than a pointer
size on stack.
Adam Sitnik [Tue, 27 Jul 2021 16:13:38 +0000 (18:13 +0200)]
avoid ReadFile syscall if we know that there is nothing to read from file (#56387)
* avoid ReadFile syscall if we know that there is nothing to read from file
* Apply suggestions from code review
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Adam Sitnik [Tue, 27 Jul 2021 16:10:34 +0000 (18:10 +0200)]
serialize the access to mutable shared state in System.IO.Packaging (#56367)
Miha Zupan [Tue, 27 Jul 2021 13:31:34 +0000 (06:31 -0700)]
Specify RunContinuationsAsynchronously in DNS telemetry test (#56368)
Tarek Mahmoud Sayed [Tue, 27 Jul 2021 13:07:43 +0000 (06:07 -0700)]
Fix Invariant Test Configuration (#56340)
Tomas Weinfurt [Tue, 27 Jul 2021 13:07:25 +0000 (06:07 -0700)]
pull in new version of msquic (#56344)
Tomas Weinfurt [Tue, 27 Jul 2021 13:06:42 +0000 (06:06 -0700)]
fix CloseAsync_ByServer_AcceptThrows quic test (#56355)
Ulrich Weigand [Tue, 27 Jul 2021 13:05:21 +0000 (15:05 +0200)]
Skip finalizer test if precise GC is not supported (#56364)
* Finalizer_OperationNotCompleted_CompletesOperation assumes precise GC
Jakob Botsch Nielsen [Tue, 27 Jul 2021 12:43:08 +0000 (14:43 +0200)]
Disable tests requiring large contiguous memory allocation on 32-bit platforms (#56366)
Fix #56197
Stephen Toub [Tue, 27 Jul 2021 11:40:36 +0000 (07:40 -0400)]
Tighten up some ArrayPool.Return usage (#56229)
Avoid potential problems if Return were to throw an exception after having already put the array back into the pool.
Karel Zikmund [Tue, 27 Jul 2021 10:55:54 +0000 (12:55 +0200)]
Disable test SendAsync_WithZeroLengthHeaderName_Throws (#56363)
Test: System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_MsQuic.SendAsync_WithZeroLengthHeaderName_Throws
Disabled test tracked by #56292
Stephen Toub [Tue, 27 Jul 2021 10:40:25 +0000 (06:40 -0400)]
Update compiler version to enable CallerArgumentExpression (#56349)
Miha Zupan [Tue, 27 Jul 2021 09:28:10 +0000 (02:28 -0700)]
Honor ThrowOnEventWriteErrors for exceptions thrown by EventListeners (#56232)
Miha Zupan [Tue, 27 Jul 2021 09:26:42 +0000 (02:26 -0700)]
Add timeouts to IPInterfaceProperties tests (#56319)
* Add timeouts to IPInterfaceProperties tests
* Use common Timeout value and Xunit output helper
* Add Threading.Tasks using
Egor Bogatov [Tue, 27 Jul 2021 09:02:22 +0000 (12:02 +0300)]
Display class names and string literals in asm (#55970)
Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
Egor Bogatov [Tue, 27 Jul 2021 09:01:26 +0000 (12:01 +0300)]
Fix an assert in emitOffsetToLabel (#56278)
Mitchell Hwang [Tue, 27 Jul 2021 06:36:43 +0000 (02:36 -0400)]
Skip environment variable access calls for non OSX apple platforms (#56320)
Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
Santiago Fernandez Madero [Tue, 27 Jul 2021 06:22:08 +0000 (23:22 -0700)]
Globally disable implicit namespaces (#56348)
Andrew Au [Tue, 27 Jul 2021 06:17:54 +0000 (23:17 -0700)]
Fix ReliabilityFramework code formatting (#56342)
Vitek Karas [Tue, 27 Jul 2021 04:43:17 +0000 (06:43 +0200)]
Fix an error printed out when install_location file is missing (#56327)
The app will still run, but we must not print out anything in that case.
Fixes #56219
Chris Ross [Tue, 27 Jul 2021 02:56:13 +0000 (19:56 -0700)]
Update SR.cs (#56332)
Steve Pfister [Tue, 27 Jul 2021 01:40:32 +0000 (21:40 -0400)]
Split mobile specific ILLink.Substitutions into its own file (#56306)
It was discovered in #56161 that mobile specific HttpClientHandler substitutions were sticking around even for non mobile builds. This change moves the substitution into ILLink.Substitutions.mobile.xml.
Tomas Weinfurt [Tue, 27 Jul 2021 01:36:38 +0000 (18:36 -0700)]
quic test improvements (#56043)
* quic test improvements
* fix incorrect use of PassingTestTimeout
* feedback from review
Dan Moseley [Tue, 27 Jul 2021 01:30:34 +0000 (19:30 -0600)]
Fix .vsconfig (#56339)
* Fix .vsconfig
* Remove vs2022 only item
Jo Shields [Tue, 27 Jul 2021 00:48:34 +0000 (20:48 -0400)]
Create manifest installers and VS manifests (#56308)
Brian Sullivan [Mon, 26 Jul 2021 21:25:25 +0000 (14:25 -0700)]
Fix for issue 55241 (#56230)
Don't decrement our budget once we have reached 0
Ulrich Weigand [Mon, 26 Jul 2021 21:23:41 +0000 (23:23 +0200)]
Upgrade to msbuild version 16.10 (#56025)
* Fixes https://github.com/dotnet/runtime/issues/54826
* Adjust net472 dependencies of Microsoft.NETCore.Platforms.Tests
David Wrighton [Mon, 26 Jul 2021 20:18:49 +0000 (13:18 -0700)]
Remove crossgen comparison jobs (#56193)
- We no longer have crossgen
- The jobs didn't detect that failure and have been wasting CPU time on every PR
Layomi Akinrinade [Mon, 26 Jul 2021 20:02:43 +0000 (13:02 -0700)]
Seal JsonSourceGenerationOptionsAttribute (#56317)
David Wrighton [Mon, 26 Jul 2021 19:59:58 +0000 (12:59 -0700)]
Report that allocations may have side effects for all types outside of the version bubble (#56177)
Fixes #45628
Miha Zupan [Mon, 26 Jul 2021 19:03:15 +0000 (12:03 -0700)]
Include time taken on DNS queue in events (#56208)
* Include time taken on DNS queue in events
* Add test
* Add usings
* More usings
* Move Assert out of EventListener callback
Johan Lorensson [Mon, 26 Jul 2021 17:55:28 +0000 (19:55 +0200)]
Change MonoProfiler provider GUID to be based on algorithm used by TraceEvent library. (#56286)
TraceEvent uses an algorithm defined in http://www.ietf.org/rfc/rfc4122.txt
to get an EventSource GUID from its name. This is used for newer EventSource
providers, and doesn't need changes to TraceEvent code to be detected.
This commit adjust MonoProfiler EventSource provider GUID to the version
calculated by that algorithm.
Anton Firszov [Mon, 26 Jul 2021 17:41:12 +0000 (19:41 +0200)]
Fix some DualMode connect test issues (#56226)
Fixes #55053, fixes #54677
Anton Firszov [Mon, 26 Jul 2021 17:39:31 +0000 (19:39 +0200)]
Disable BeginReceiveFrom_RemoteEpIsReturnedWhenCompletedSynchronously on catalyst (#56304)
Alexander Köplinger [Mon, 26 Jul 2021 17:33:45 +0000 (19:33 +0200)]
Fix error message when publishing logs in Restore internal tools step (#56307)
In https://dev.azure.com/dnceng/internal/_build/results?buildId=1250178&view=results we hit an issue where the 'Restore internal tools' step failed, but AzDO only highlights the failure in the 'Publish Logs' step because the directory didn't exist.
This happens because the restore step was not passing along the build configuration so it defaults to Debug instead of Release, leading to the log directory we try to publish not existing.
Natalia Kondratyeva [Mon, 26 Jul 2021 15:52:58 +0000 (17:52 +0200)]
HTTP/3 send FIN together with headers if no body (#56221)
Fixes #55347
Theodore Tsirpanis [Mon, 26 Jul 2021 15:41:50 +0000 (18:41 +0300)]
Use more `ReadOnlySpan<byte>`s in `System.Reflection.MetadataLoadContext` (#56207)
* Use spans instead of byte arrays in `MetadataLoadContext.Utf8Constants`.
* Optimize Helpers.ToUtf16(ReadOnlySpan<byte>).
It avoids a byte array allocation on all frameworks.
And remove an unused overload of it.
* Address PR feedback.
* Fix ArgumentNullExceptions.
lord-executor [Mon, 26 Jul 2021 15:15:54 +0000 (17:15 +0200)]
Explicit test for service provider IDisposable implementation (dotnet#56181) (#56227)
Jan Vorlicek [Mon, 26 Jul 2021 14:39:22 +0000 (16:39 +0200)]
Implement new way of return address hijacking (#55946)
* Implement new way of return address hijacking
This change implements a new way of return address hijacking for Intel
CET enabled Windows devices. It uses a mechanism created by the Windows
team for this purpose. The existing mechanism that just patches the
return address by an address of our helper routine would result in
process killing as it would seem like a ROP exploit.
Karel Zikmund [Mon, 26 Jul 2021 14:25:19 +0000 (16:25 +0200)]
Disable DNS tests failing on Ubuntu 16.04 and Debian 9 (#56296)
Disabled tests tracked by #56295
Pavel Savara [Mon, 26 Jul 2021 13:02:49 +0000 (15:02 +0200)]
Disable failing wasm test SendReceive_VaryingLengthBuffers_Success (#56293)
Filip Navara [Mon, 26 Jul 2021 11:59:26 +0000 (13:59 +0200)]
Add tvOS specific build of System.Net.Mail (#56185)
Ref: https://github.com/xamarin/xamarin-macios/pull/12011#issuecomment-
885149485
Badre BSAILA [Mon, 26 Jul 2021 11:57:33 +0000 (13:57 +0200)]
Adjust exception message for headers having non-ASCII chars (#55886)
Reuse existing resource string.
Fixes #55310
Kevin Jones [Mon, 26 Jul 2021 10:55:08 +0000 (06:55 -0400)]
Keep X509 handle alive while in use when reading certificate data (#56277)
* Add test for thread racing certificate usage and disposal
* Implement changes to keep the X509* alive while in use.
Karel Zikmund [Mon, 26 Jul 2021 10:45:11 +0000 (12:45 +0200)]
Disable test ResponseCancellation_ServerReceivesCancellation (#56291)
Test: System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuic.ResponseCancellation_ServerReceivesCancellation
Disabled test tracked by #56194
Karel Zikmund [Mon, 26 Jul 2021 10:26:32 +0000 (12:26 +0200)]
Disable test System.Net.Quic.Tests.MsQuicTests.ConnectWithCertificateCallback (#56264)
Disabled test tracked by #56263
Vlad Brezae [Mon, 26 Jul 2021 07:21:56 +0000 (10:21 +0300)]
[mono] Disable test relying on precise GC (#56139)
Johan Lorensson [Mon, 26 Jul 2021 06:35:28 +0000 (08:35 +0200)]
Fix Windows build of ds-ipc-pal-socket.c and make FD_CLOEXEC best effort. (#56141)
Up until https://github.com/dotnet/runtime/pull/55850 it was possible
to build using diagnostic server socket PAL on Windows for local testing.
NOTE, this is not a config we build on CI since it is not used by any
products (diagnostic server PAL on Windows uses NamedPipes), but useful
for local testing.
The same PR also included calls to fcntl using FD_CLOEXEC in case platform
doesn't define SOCK_CLOEXEC. Since this is a Linux specific flag, it might not
be defined on several targeted platforms. Failures calling fcntl using
FD_CLOEXEC was also triggering an EP_ASSERT but that is only on debug
builds. Most calls to fcntl using FD_CLOEXEC in runtime PAL layers
(both CoreCLR and MonoVM) doesn't check for errors in this case
and sees the operation as best effort, like done here
https://github.com/dotnet/runtime/blob/
b937677e8f8601848d29bc072a93cc0c6e21576d/src/libraries/Native/Unix/System.Native/pal_networking.c#L2499.
We should do the same in ds-ipc-pal-socket.c making sure it won't break
any potential platform not fully supporting it or if we are really concerned
about this error, handle it as real error failing creation of socket, but
that needs to be tested on mobile platforms (not running TCP/IP PAL on CI).
Mike McLaughlin [Sun, 25 Jul 2021 19:13:32 +0000 (12:13 -0700)]
Fix createdump crash on alpine 3.12 and above. (#56272)
Finally hit an existing problem in createdump (since 2.1) where the std::set<MemoryRegions> in
ThreadInfo::GetThreadStack() where it is calling CrashInfo::SearchMemoryRegions with m_crashInfo.OtherMappings()
which returns a copy of the set of MemoryRegions instead of a reference. On alpine 3.12 musl, this set copy
is freed right away when it goes out of scope as soon as SearchMemoryRegions returns. On any other Linux distro
and MacOS the set doesn't get freed/invalidated as soon.
Return references to the threads and memory region sets in the CrashInfo functions.
Stephen Toub [Sun, 25 Jul 2021 15:27:40 +0000 (11:27 -0400)]
Tweak code gen for Guid parsing (#56210)
* Tweak code gen for Guid parsing
* Further tweak to use nuint/nint
Huo Yaoyuan [Sun, 25 Jul 2021 05:33:52 +0000 (13:33 +0800)]
Cleanup rotate patterns (#54099)
* Clean RotateLeft
* Cleanup RotateRight
Karel Zikmund [Sun, 25 Jul 2021 01:53:47 +0000 (03:53 +0200)]
Disable test ResponseCancellation_BothCancellationTokenAndDispose_Success (#56266)
Steve Berdy [Sat, 24 Jul 2021 21:22:46 +0000 (17:22 -0400)]
Fix duplicated path.Contains check and other checks in Path.GetFullPath (#55373)
Steve Berdy [Sat, 24 Jul 2021 21:21:53 +0000 (17:21 -0400)]
Edit IOException docs in ZipFile.ExtractToDirectory (#55762)
Geoff Kizer [Sat, 24 Jul 2021 21:06:10 +0000 (14:06 -0700)]
HTTP3: Fix issue with GOAWAY handling and implement graceful shutdown logic in Http3LoopbackServer (#56134)
* add IsMockProvider/IsMsQuicProvider on QuicTestBase
* add tests for AcceptStreamAsync and Open*Stream when/after the connection is closed/disposed, and related product fixes
* fix issue with GOAWAY handling and add graceful shutdown logic to Http3LoopbackConnection
* PR feedback
Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>
Jeff Handley [Sat, 24 Jul 2021 14:56:42 +0000 (10:56 -0400)]
Prevent divide-by-zero in ImageAnimator for images with 0 delay between frames (#56223)
Stephen Toub [Sat, 24 Jul 2021 13:40:29 +0000 (09:40 -0400)]
Revert Version.TryFormat changes (#56051)
* Revert Version.TryFormat changes to use interpolated strings
This was already optimized to use spans directly. Using our new span-based interpolated string handler was simpler code, but a few more nanoseconds. Reverting.
* Tweak original code
Make error handling a bit more clear, and use uint formatting rather than int formatting for small perf boost.
Egor Bogatov [Sat, 24 Jul 2021 08:28:33 +0000 (11:28 +0300)]
Don't set onlyParseItemsDefinedInAssembly in Composite mode (#56050)
Egor Bogatov [Sat, 24 Jul 2021 08:28:21 +0000 (11:28 +0300)]
dotnet-pgo: ignore native libs passed via -r *.dll (#56168)
Manish Godse [Sat, 24 Jul 2021 05:20:26 +0000 (22:20 -0700)]
[WIP] Add new GC Standalone pipeline (#54024)
* Add new GC Regions pipeline
* removing osx legs from standalone.
Ulrich Weigand [Sat, 24 Jul 2021 04:36:12 +0000 (06:36 +0200)]
Build support for s390x: installers and packages (#53950)
* Introduce "PrimaryRuntimeFlavor" concept, set to Mono for s390x
* Enable installers, packages, and archives when building the
PrimaryRuntimeFlavor, even when this is Mono instead of CoreCLR
* Update default subsets in eng/Subsets.props to take
PrimaryRuntimeFlavor into account
* Skip packaging singlefilehost when not available (due to building
with the Mono runtime flavor)
* Only build the IL tools packages in coreclr-packages.proj
when building with the Mono runtime flavor
Wei Zheng [Sat, 24 Jul 2021 04:32:45 +0000 (12:32 +0800)]
Fix incorrect result right shifting specific negative BigInteger by 32 bits (#54115)
Aaron Robinson [Fri, 23 Jul 2021 23:35:38 +0000 (16:35 -0700)]
Make callouts to interoplib in preemptive mode that can call back into runtime (#56199)
* Make sure all callouts to interoplib that can call back into runtime transition to PREEMPT mode.
David Cantú [Fri, 23 Jul 2021 21:46:44 +0000 (14:46 -0700)]
Disable tests blocking clean CI for Unix (#56242)
Steve Pfister [Fri, 23 Jul 2021 21:29:07 +0000 (17:29 -0400)]
Fix iOS/Android InvariantMode functional test (#56231)
The android test was not handling CultureNotFoundException and was crashing.
Fixes https://github.com/dotnet/runtime/issues/51016
Matt Mitchell [Fri, 23 Jul 2021 20:59:43 +0000 (13:59 -0700)]
Fix Microsoft.DotNet.Build.Tasks.Installers property name (#56218)
Marie Píchová [Fri, 23 Jul 2021 19:32:00 +0000 (19:32 +0000)]
[QUIC] Certificate name validation (#56175)
* Shared CertificateValidation and used in S.N.Quic
* adressed feedback
* Post merge
* Added tests
Jakob Botsch Nielsen [Fri, 23 Jul 2021 17:41:52 +0000 (19:41 +0200)]
Reenable poisoning test in non R2R jobs (#56149)
Fix #55062
Sergey Andreenko [Fri, 23 Jul 2021 17:13:16 +0000 (10:13 -0700)]
Supported contained bitcast under STORE_LCL_VAR/FLD on arm32/64. (#56122)
* Return contained bitcast to arm lowering.
* Supported contained bitcast for arm64.
* support contained bitcast arm32.
* Fix arm32.
* fix
* fix assert
* improve comments
Steve Pfister [Fri, 23 Jul 2021 16:40:37 +0000 (12:40 -0400)]
[Mono] Cleans up test build when targeting iOS/tvOSSimulator on arm64. Enables arm64 sim on CI (#55577)
Tarek Mahmoud Sayed [Fri, 23 Jul 2021 16:36:39 +0000 (09:36 -0700)]
Change reading time zone display names (#56171)
Tarek Mahmoud Sayed [Fri, 23 Jul 2021 16:33:04 +0000 (09:33 -0700)]
Ensure MeterListener.RecordObservableInstruments invoking all instruments callbacks (#56183)
Anton Firszov [Fri, 23 Jul 2021 15:37:13 +0000 (17:37 +0200)]
Fix static Socket.ConnectAsync for DnsEndPoint containing IPv6-mapped address string (#56102)
Fixes #56099
Jo Shields [Fri, 23 Jul 2021 14:20:49 +0000 (10:20 -0400)]
Add explicit dependency on System.Reflection.Metadata to the RuntimeConfigParser task. (#56152)
This change adds an explicit dependency on System.Reflection.Metadata to the RuntimeConfigParser task when targeting the full .net framework.
Closes: #55277
Steve Pfister [Fri, 23 Jul 2021 14:04:06 +0000 (10:04 -0400)]
Reenable some Android Globalization tests (#56147)
Android ICU seems to have slight behavioral differences with Turkish and Slovak cultures. This change skips the data items that do have difficulty.
Additionally, there are a few other tests that were failing because the test data should have been the same as what we use on desktop. Adjusted accordingly.
Fixes #36672