dnickless [Wed, 11 Jan 2017 21:48:55 +0000 (16:48 -0500)]
Merge branch 'master' of https://github.com/dotnet/coreclr
Sven Boemer [Wed, 11 Jan 2017 21:32:56 +0000 (13:32 -0800)]
Merge pull request #8570 from sbomer/dasm_automation
Fix some problems with the ubuntu dasm output
Andy Ayers [Wed, 11 Jan 2017 21:20:57 +0000 (13:20 -0800)]
Merge pull request #8551 from AndyAyersMS/FinallyCloning
Finally cloning
Joseph Tremoulet [Wed, 11 Jan 2017 19:47:11 +0000 (14:47 -0500)]
Merge pull request #8880 from JosephTremoulet/SimplifyHeapPhiArg
Simplify HeapPhiArg
Thiago Camargos Lopes [Wed, 11 Jan 2017 19:12:22 +0000 (17:12 -0200)]
Add parameterless overloads of TrimStart/TrimEnd (#8834)
Add parameterless overloads of TrimStart/TrimEnd
Stephen Toub [Wed, 11 Jan 2017 17:35:06 +0000 (12:35 -0500)]
Merge pull request #8892 from stephentoub/enumeq_ser
Fix deserialization of EnumEqualityComparer
Hyeongseok Oh [Wed, 11 Jan 2017 14:37:21 +0000 (23:37 +0900)]
[ARM32/Linux] Fix cross-architecture build error: T_CONTEXT (#8888)
confusion of T_CONTEXT and CONTEXT in projects
- cee_dac
- gc_wks
related issue: #8885
Stephen Toub [Wed, 11 Jan 2017 13:58:53 +0000 (08:58 -0500)]
Fix deserialization of EnumEqualityComparer
Its deserialization ctor is getting removed by the rewriter, causing deserialization of its instances to fail.
Stephen Toub [Wed, 11 Jan 2017 13:52:58 +0000 (08:52 -0500)]
Merge pull request #8868 from stephentoub/linkedcts_array
Remove array allocation from CTS.CreateLinkedTokenSource
Andy Ayers [Thu, 1 Dec 2016 02:16:17 +0000 (18:16 -0800)]
JIT: Finally Optimizations
Adds two optimization for try-finallys: empty finally removal and
finally cloning.
Empty finally removal identifies trivially empty finally clauses and
removes the entire try-finally EH region. COde in the try is "promoted"
to be in the parent EH region (or method region). Empty finallys often
appear after inlining empty Dispose methods. Removing a try-finally with
an empty finally both reduces code size and improves code speed.
Finally cloning duplicates the code for the finally and 'inlines' it
along one of the normal exit paths from the try. This improves code
speed in the typical case where there is no exception raised while
the try is active. It generally increases code size slightly. However,
finallys are rare enough that the overall code size increase across
all methods is quite small. The jit will clone most finallys, provided
they are not too large, and are not contained in or contain other EH
constructs. If a try contains multiple exit paths only the final "fall
through" path will be optimized.
These optimizations are enabled for all target architectures. Finally
cloning is currently disabled for desktop CLR because more work is needed
to support thread abort.
More details on both optimizations can be found in the design document
added as part of this commit.
In debug builds, finally cloning can be selectively disabled or enabled
by setting COMPlus_JitEnableFinallyCloning to 0 or 1 respectively. This
config setting can thus be used override the default behavior (cloning
enabled for CoreCLR, disabled otherwise) for diagnostic or testing purposes.
Closes #1505. Closes #8065.
sandreenko [Wed, 11 Jan 2017 01:12:52 +0000 (17:12 -0800)]
Merge pull request #8862 from sandreenko/ReversePInvoke-encoding-in-gc
SetReversePInvokeFrameSlot into gcInfo for reversePInvoke
Sedar Gokbulut [Wed, 11 Jan 2017 00:54:16 +0000 (16:54 -0800)]
Add Microsoft.NETCore.Native package (2nd attempt) (#8882)
* Adding Microsoft.NETCore.Native package (#8791)
* "Adding Microsoft.NETCore.Native package"
* Adding generic linux configuration to Microsoft.NETCore.Native package
* Fixing the OSX pkgproj of Microsoft.NETCore.Native to include S.Globalization.Native.dylib and not .so
* Fixing the osx release build.
Jonghyun Park [Wed, 11 Jan 2017 00:48:43 +0000 (09:48 +0900)]
[x86/Linux] Fix WIN64EXCEPTIONS build error (#8629)
* Move GetUnwindInfo and GetNumberOfUnwindInfos into the real code header
This commit fixes #8342.
* Use WIN64EXCEPTIONS instead of _TARGET_X86_
* Revise FaultingExceptionFrame
This commit revises FaultingExceptionFrame to support WIN64EXCEPTIONS in
x86/Linux port.
* Add RUNTIME_FUNCTION__EndAddress as NYI
* Revise regdisp.h
* Revise eetwain.h
* Comment out exinfo.cpp if WIN64EXCEPTIONS is defined
* Revises excep.cpp
* Fix mistmatch in ThrowControlForThread defintion
* Revises cgenx86.cpp
* Disable SEH-based exception handlers when WIN64EXCEPTIONS is defined
* Revise stackwalk.cpp
* Revise jitinterface.cpp
* Revise readytorun.h
* Revise dbgipcevents.h
* Revise zapcode.cpp
* Revise clrnt.h
* Fix Windows build error
* Mark FaultingExceptionFrame::UpdateRegDisplay as NYI
* Revise per feedback
* Revert #if defined(..) as #ifdef
* Fix style changes
* Fix style changes
* Remove #undef _TARGET_X86_
* 2nd attempt to fix Windows build error
* Revise per feedback
* Revert the chagnes in clrdefinitions.cmake and add BIT32 in CMakeLists.txt
* Use !BIT64 instead of BIT32
* Include exceptionhandling.cpp and gcinfodecoder.cpp in build
This commit includes exceptionhandling.cpp and gcinfodecoder.cpp in
build, and fixes related compile errors.
* Fix COMPlus_EndCatch undefined reference
* Fix build error
* Fix GcInfoDecoder-related undefined references
* Fix AdjustContextForVirtualStub undefined reference
* Fix GetCallerSP undefined reference
* Fix ResetThreadAbortState undefined reference
* Attempt to fix Windows build error
* Fix CLRNoCatchHandler undefined reference
* Another attemp to fix Windows build error
* Fix GetXXXFromRedirectedStubStackFrame undefined references
* Fix Windows Build Error
* Add RtlpGetFunctionEndAddress and RtlVirtualUnwind as NYI
* Fix undefined references on JIT helpers
* Enable Dummy Application Run with WIN64EXCEPTIONS
* Revert "Move GetUnwindInfo and GetNumberOfUnwindInfos into the real code header"
This reverts commit
c2bad85ac1136be3c6fb6ad7eedc5b3814b2ab29.
* Use indirect code header when WIN64EXCEPTIONS is enabled
* Port 'SyncRegDisplayToCurrentContext' and 'FillRegDisplay'
* Revise style 'RUNTIME_FUNCTION__SetUnwindInfoAddress'
* Extract out HandlerData from #ifdef region
* Add UNIXTODO
* Add UNIXTODO
* Port 'GetRegdisplayReturnValue'
* Fix incorrect comment
* Remove messages that mentions WIN32EXCEPTIONS
* Revise AdjustContextForWriteBarrier
* Port 'FaultingExceptionFrame::UpdateRegDisplay'
* Extract out 'AdjustContextForVirtualStub' and 'CLRNoCatchHandler' from #ifdef region
* Merge two #ifdef regions
* Set WIN64EXCEPTIONS as a default for x86/Linux
* Remove unnecessary #ifdef from ThrowControlForThread
* Remove unnecessary stubs
* Add Dependency Check between Compile Flags
* Revise per feedback
Carol Eidt [Wed, 11 Jan 2017 00:20:41 +0000 (16:20 -0800)]
Merge pull request #8881 from CarolEidt/FixPutArgStk
Fix handling of PutArgStk
SaeHie Park [Tue, 10 Jan 2017 23:43:23 +0000 (08:43 +0900)]
[x86/Linux] Fix generic context(hidden arg) position (#8848)
This fixes how to handle generic context position in x86 by num of arguments
SaeHie Park [Tue, 10 Jan 2017 23:42:12 +0000 (08:42 +0900)]
[x86/Linux] Introduce UNIX_X86_ABI definition (#8863)
Add UNIX_X86_ABI definition for Unix/Linux specific ABI parts
First will be for 16 byte stack alignment codes
Carol Eidt [Tue, 10 Jan 2017 22:19:46 +0000 (14:19 -0800)]
Updates based on PR review.
Pat Gavlin [Tue, 10 Jan 2017 22:04:12 +0000 (14:04 -0800)]
Merge pull request #8876 from pgavlin/LVAThroughput
Do not rerun LVA if only live-out has changed.
Carol Eidt [Tue, 10 Jan 2017 21:55:47 +0000 (13:55 -0800)]
Fix handling of PutArgStk
GT_PUTARG_STK doesn't produce a value, so it should have the GTK_NOVALUE flag set.
Although the dstCount was being set to zero by the parent call, localDefUse was also being set, causing a register to be allocated. Fixing this produces a number of improvements due to reuse of constant registers that were otherwise unnecessarily "overwritten" by the localDefUse.
Also on x86, GT_LONG shouldn't be used to pass a long, since GT_LONG should always be a value-producing node. Instead, use the existing GT_FIELD_LIST approach.
Andy Ayers [Tue, 10 Jan 2017 21:42:32 +0000 (13:42 -0800)]
Merge pull request #8867 from AndyAyersMS/BinaryTreesVariant
JIT: Add BinaryTrees benchmark variant
Joseph Tremoulet [Fri, 30 Dec 2016 16:43:32 +0000 (08:43 -0800)]
Simplify HeapPhiArg
There's no need to have two "modes" of heap phi args; we can simply always
store the SSA number, which has always already been computed and stored in
the bbHeapSsaNumOut field of the pred already when the HeapPhiArg is
created. We weren't using the block for anything other than to fetch the
pred's ssa-out number.
The code to add a try-begin block's predecessors' live-out heap defs to
the try's handlers' phis used to assert that the phi args being added
correspond to different blocks. While they do correspond to different
blocks, it turns out that sometimes those different blocks have the same
live-out heap def. This redundancy hasn't been hurting anything, and
de-duplication could be fairly expensive, so in this change I've simply
removed the assertion and left the redundancy as-is.
Sergey Andreenko [Tue, 10 Jan 2017 19:34:40 +0000 (11:34 -0800)]
don't copy LclVarDsc
Pat Gavlin [Tue, 10 Jan 2017 19:12:22 +0000 (11:12 -0800)]
Format code.
Sergey Andreenko [Mon, 9 Jan 2017 23:29:05 +0000 (15:29 -0800)]
SetReversePInvokeFrameSlot into gcInfo for reversePInvoke
Michelle McDaniel [Tue, 10 Jan 2017 18:52:11 +0000 (10:52 -0800)]
Merge pull request #8874 from adiaaida/addx86ReleasePRTrigger
Add x86 Release PR Trigger
Andy Ayers [Tue, 10 Jan 2017 18:35:59 +0000 (10:35 -0800)]
Match CoreFX update of arm-softfp -> armel (#8875)
Pat Gavlin [Mon, 9 Jan 2017 20:12:14 +0000 (12:12 -0800)]
Do not rerun LVA if only live-out has changed.
If only the live-out set for a block changes during live variable
analysis, the LVA algorithm does not need to be re-run. As per the
dataflow equations for LVA:
liveOut(block) = union(liveIn(s) for all s in successors(block))
Thus, unless a change to the live-out set for a block propagates through
to a change to the live-in set for that block, it will not affect the
live-in/out sets of any of its predecessors and liveness need not be
re-run.
Michelle McDaniel [Tue, 10 Jan 2017 17:48:49 +0000 (09:48 -0800)]
Add x86 Release PR Trigger
Currently, only checked runs can be triggered for x86. This adds a trigger
for release runs as well.
Michelle McDaniel [Tue, 10 Jan 2017 17:38:30 +0000 (09:38 -0800)]
Merge pull request #8861 from adiaaida/updateSeekUnroll
Reduce SeekUnroll iter count
Michelle McDaniel [Mon, 9 Jan 2017 21:07:35 +0000 (13:07 -0800)]
Reduce SeekUnroll iter count
On non-hardware accelerated platforms, reduce the inner iteration count in
SeekUnroll. This test was timing out in x86 release builds because the
iteration count was too high.
John Chen [Tue, 10 Jan 2017 06:15:50 +0000 (22:15 -0800)]
Merge pull request #8859 from JohnChen0/pinvoke
Enable PInvoke analyzer for S.P.CoreLib.dll
mikedn [Tue, 10 Jan 2017 05:00:39 +0000 (07:00 +0200)]
Default gcAllowVeryLargeObjects to true (#8853)
* Default gcAllowVeryLargeObjects to true
* Update tests for gcAllowVeryLargeObjects
These 2 tests appear to rely on gcAllowVeryLargeObjects being false in that they expect an exception to be thrown when allocating a very large array.
Increase the number of array elements so that an OutOfMemoryException is always thown no matter what value gcAllowVeryLargeObjects has. 81*98*58*36*74*4 is
4906065024 which is larger than 2^32, the theoretical array length limit.
Stephen Toub [Tue, 10 Jan 2017 03:01:28 +0000 (22:01 -0500)]
Remove array allocation from CTS.CreateLinkedTokenSource
The most common uses of CreateLinkedTokenSource involve passing in one or two tokens, but even for these cases we end up allocating an array of registrations. This commit fixes that.
Andy Ayers [Tue, 10 Jan 2017 00:17:27 +0000 (16:17 -0800)]
JIT: Add BinaryTrees benchmark variant
Add a variant that uses a class and out parameter instead of returning
a struct by value. This variant is similar to version 3 from the benchmarks
games site, but with validation added and parallelism removed.
See related analysis in #8837. According to xunit-perf runs, this version's
performance is improved (~10%) by enabling the model inlining policy. When
the model policy is enabled the inliner will inline the two outermost calls
to `ChildTreeNodes` in the innermlost loop.
Also, make sure the new and the original version to build the same way in
release and debug.
sandreenko [Mon, 9 Jan 2017 23:27:48 +0000 (15:27 -0800)]
Merge pull request #8858 from sandreenko/CoreRT-PInvoke
Update PInvoke inlining restrictions for CoreRT
Pat Gavlin [Mon, 9 Jan 2017 21:34:14 +0000 (13:34 -0800)]
Merge pull request #8856 from pgavlin/LVAThroughput
Encapsulate live var analysis in its own class.
John Chen (CLR) [Mon, 9 Jan 2017 20:19:14 +0000 (12:19 -0800)]
Enable PInvoke analyzer for S.P.CoreLib.dll
John Chen [Mon, 9 Jan 2017 20:11:39 +0000 (12:11 -0800)]
Merge pull request #8854 from JohnChen0/heva
Enable HighEntropyVA in mscorlib.dll
Pat Gavlin [Mon, 9 Jan 2017 19:36:28 +0000 (11:36 -0800)]
Format code and improve a function name.
Pat Gavlin [Mon, 9 Jan 2017 19:20:23 +0000 (11:20 -0800)]
Fix some comments.
Pat Gavlin [Mon, 9 Jan 2017 18:41:16 +0000 (10:41 -0800)]
Encapsulate live var analysis in its own class.
This change moves the implementation of live variable analysis from a
single function into a class in which the per-block portion of the
algorithm is contained in its own function. There is no functional
change.
dotnet bot [Mon, 9 Jan 2017 17:18:20 +0000 (09:18 -0800)]
Update CoreClr, CoreFx to beta-24909-02, beta-24909-02, respectively (#8836)
John Chen (CLR) [Mon, 9 Jan 2017 17:18:10 +0000 (09:18 -0800)]
Enable HighEntropyVA in mscorlib.dll
Sven Boemer [Wed, 30 Nov 2016 18:29:59 +0000 (10:29 -0800)]
Fix some problems with the ubuntu dasm output
- Re-enable the default build archiving in jitdiff scenarios so that the
windows _bld job will publish correct build artifacts for the
ubuntu_jitdiff_tst job to consume.
- Use relative paths in the generated scripts to avoid drive letters in
bash scripts.
- Fix exit code reporting in bash wrapper scripts.
- Upgrade jit-dasm version to use version with improved error handling
- Upgrade jit-analyze version to use same dependencies as jit-dasm
Russ Keldorph [Mon, 9 Jan 2017 16:49:35 +0000 (08:49 -0800)]
Merge pull request #8830 from RussKeldorph/hugeexprx86
Disable hugeexpr1 test under JitStress modes
Jonghyun Park [Mon, 9 Jan 2017 11:51:44 +0000 (20:51 +0900)]
Add two missing #ifdef related with FEATURE_CORRUPTING_EXCEPTIONS (#8850)
Jonghyun Park [Mon, 9 Jan 2017 11:14:58 +0000 (20:14 +0900)]
Fix x86/Linux Release Build Error (#8852)
Stephen Toub [Sun, 8 Jan 2017 18:25:17 +0000 (13:25 -0500)]
Remove lazy initialization of Task.CompletedTask (#8846)
Remove lazy initialization of Task.CompletedTask
Jan Kotas [Sat, 3 Dec 2016 05:42:18 +0000 (21:42 -0800)]
Update PInvoke inlining restrictions for CoreRT
Sean Gillespie [Sat, 7 Jan 2017 00:21:11 +0000 (16:21 -0800)]
[Local GC] Move Software Write Watch's write barrier updates to GCToEEInterface::StompWriteBarrier (#8605)
* Move Software Write Watch's write barrier updates to use the new
GCToEEInterface::StompWriteBarrier to stomp the EE's write barrier.
* Address code review feedback, move SetCardsAfterBulkCopy to EE side of the interface
Pat Gavlin [Sat, 7 Jan 2017 00:07:11 +0000 (16:07 -0800)]
Merge pull request #8835 from pgavlin/RemoveAsgdLclVar
Remove the `asgdLclVar` analysis from liveness.
Rahul Kumar [Sat, 7 Jan 2017 00:04:48 +0000 (16:04 -0800)]
Merge pull request #8808 from rahku/cleanup
Hide types implemented in corefx
Davis Goodin [Fri, 6 Jan 2017 23:00:32 +0000 (17:00 -0600)]
Update CLI to 1.0.0-preview2-1-003182, BuildTools to 1.0.27-prerelease-01205-03 (#8829)
* Update CLI to 1.0.0-preview2-1-003182, BuildTools to 1.0.27-prerelease-01205-03
* Add BuildVersion.targets and required properties to test directory's dir.props
Pat Gavlin [Fri, 6 Jan 2017 22:12:35 +0000 (14:12 -0800)]
Simplify lclNum fetching and a few assertions.
Rahul Kumar [Wed, 30 Nov 2016 20:08:47 +0000 (12:08 -0800)]
Hide types implemented in corefx
Russ Keldorph [Fri, 6 Jan 2017 21:42:09 +0000 (13:42 -0800)]
Merge pull request #8832 from RussKeldorph/corefxtests
Fix archival and test result steps for corefx tests
Russ Keldorph [Fri, 6 Jan 2017 17:00:17 +0000 (09:00 -0800)]
Disable hugeexpr1 test under JitStress modes
This test runs out of memory on x86 when its huge expressions combine with
STRESS_CLONE_EXPR. In this case, the "OptimizationSensitive" label isn't ideal,
but the meaning is what we need: don't run this under JitStress modes.
This is disabled at build time for x86, which means that if x64-built tests are
run on other architectures, e.g. ARM or ARM64, this change won't take effect.
Davis Goodin [Fri, 6 Jan 2017 20:16:18 +0000 (14:16 -0600)]
Swap wget and curl to fix init-tools capability check (#8831)
Pat Gavlin [Fri, 6 Jan 2017 19:11:19 +0000 (11:11 -0800)]
Remove the `asgdLclVar` analysis from liveness.
This analysis is not necessary for correctness and does not appear to
have any impact on the generated code: in particualr, internal assembly
diffs show no changes with this analysis disabled.
For example, consider the following statement:
`(asg (lclVar V0) (add (lclVar V0) (icon 4)))`
Under the `asgdLclVar` analysis, the visit of the lclVar node that is an
operand to the add would mark the lclVar node that is the target of the
assignment with `GTF_VAR_USEDEF` and exit without adding V0 to the
current set of used lclVars. Instead, the visit of the lclVar node that
is the target of the assignment would add V0 to both the set of used
lclVar nodes and the set of defined lclVar nodes.
With this analysis disabled, the visit of the lclVar node that is an
operand to the add will add V0 to the set of used lclVar nodes and the
visit of the lclVar node that is the target of the assignment will add
V0 to the set of defined lclVar nodes. In both cases, the result is the
same.
Aditya Mandaleeka [Fri, 6 Jan 2017 19:26:29 +0000 (11:26 -0800)]
Merge pull request #8825 from adityamandaleeka/fix_jit_dasm
Fix check for JIT dasm
James Ko [Fri, 6 Jan 2017 19:21:42 +0000 (14:21 -0500)]
Delete unused InteropServices types (#8765)
Russ Keldorph [Fri, 6 Jan 2017 18:59:40 +0000 (10:59 -0800)]
Fix archival and test result steps for corefx tests
These archival and testResult groovy calls were using absolute paths, which is
apparently incorrect. Change then to use relative paths and make things
consistent between Windodws and Ubuntu runs.
dotnet bot [Fri, 6 Jan 2017 18:56:32 +0000 (10:56 -0800)]
Update CoreClr, CoreFx to beta-24906-01, beta-24906-02, respectively (#8826)
Jürgen Hötzel [Fri, 6 Jan 2017 00:15:49 +0000 (01:15 +0100)]
Use POSIX "command" instead of non-standard "which" (#8823)
GNU which might not be installed on a minimal GNU/Linux installation.
Refs #6994 and #7025.
Pat Gavlin [Thu, 5 Jan 2017 23:57:58 +0000 (15:57 -0800)]
Merge pull request #8820 from pgavlin/RemoveVarTmp
Remove `BasicBlock::bbVarTmp`.
Aditya Mandaleeka [Thu, 5 Jan 2017 23:06:39 +0000 (15:06 -0800)]
Fix check for JIT dasm.
Gaurav Khanna [Thu, 5 Jan 2017 21:43:19 +0000 (13:43 -0800)]
Merge pull request #8781 from hqueue/arm/rootfs/tizen
Add Tizen rootfs for armel
Gaurav Khanna [Thu, 5 Jan 2017 18:59:50 +0000 (10:59 -0800)]
Merge pull request #8818 from SedarG/sedarg
Revert "Adding Microsoft.NETCore.Native package (#8791)"
Pat Gavlin [Thu, 5 Jan 2017 18:11:39 +0000 (10:11 -0800)]
Remove `BasicBlock::bbVarTmp`.
This field was never used.
Gaurav Khanna [Thu, 5 Jan 2017 17:55:59 +0000 (09:55 -0800)]
Merge pull request #8813 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24904-03, beta-24905-02, respectively (master)
Sedar Gokbulut [Thu, 5 Jan 2017 16:53:53 +0000 (08:53 -0800)]
Revert "Adding Microsoft.NETCore.Native package (#8791)"
This reverts commit
eea7b4691c0a489435814e48a257a9d047475006.
Dan Moseley [Thu, 5 Jan 2017 16:52:34 +0000 (08:52 -0800)]
fix link
Fix https://github.com/dotnet/coreclr/issues/8816
dotnet-bot [Thu, 5 Jan 2017 15:45:36 +0000 (15:45 +0000)]
Update CoreClr, CoreFx to beta-24904-03, beta-24905-02, respectively
Hyeongseok Oh [Thu, 5 Jan 2017 12:32:44 +0000 (21:32 +0900)]
Use x86 crossbuild for cross-architecture component on x64-linux (#8722)
* Use x86 crossbuild for cross-architecture component on x64-linux
Fix build.sh and build system generator to use x86 cross-build system on x64-linux
- x86-host/ARM32-target cross-architecture component build on x64 linux
- use x86 root file system and cross buildtool
* Modify build.sh
- define new function: build_cross_arch_component
- fix typo
* Additional fix: build.sh
add usage description
- environment variable: CAC_ROOTFS_DIR
- argument: crosscomponent
Hyung-Kyu Choi [Thu, 5 Jan 2017 06:17:18 +0000 (15:17 +0900)]
Update cmake file for armel
Enable build using Tizen rootfs
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
pius.lee [Tue, 3 Jan 2017 10:19:11 +0000 (19:19 +0900)]
Add a script to fetch tizen packages
Fetch packages for build RootFS by XML information in download.tizen.org
Signed-off-by: pius.lee <pius.lee@samsung.com>
Hyung-Kyu Choi [Thu, 5 Jan 2017 05:48:10 +0000 (14:48 +0900)]
Add Tizen rootfs for armel
- This rootfs can be used for CoreCLR, CoreFX and Core-Setup.
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Hyung-Kyu Choi [Thu, 5 Jan 2017 09:29:49 +0000 (18:29 +0900)]
Use armel instead of arm-softfp (#8771)
* Use armel instead of arm-softfp for CoreCLR
- Update scripts for rootfs, build, build system generation and CI
- Update managed build project
- Rename rootfs directory
- Fix bug in rootfs script related to lldb package
lldb package only usable lldb-3.5-dev for jessie/arm-softfp
We cannot get lldb-3.6-dev or lldb-3.8-dev from jessie/arm-softfp repository
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Singed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Update ARM32 CI script
We don't need a patch anymore, because we fixed cmake file.
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Jan Vorlicek [Thu, 5 Jan 2017 01:37:25 +0000 (02:37 +0100)]
Fix unsigned_abs function on Unix (#8805)
The unsigned_abs function in jit.h is implemented using labs function.
However labs has 32 bit argument / result, while the unsigned_abs expects
it to be 64 bit.
The correct function to use for FEATURE_PAL is llabs. But since we now have
abs overload for __int64 in pal.h, we can just remove the #ifdef for FEATURE_PAL
and use the same implementation for both Unix and Windows.
Pat Gavlin [Thu, 5 Jan 2017 00:34:55 +0000 (16:34 -0800)]
Merge pull request #8809 from pgavlin/FixJitStressFailure
Add a missing ref count bump in DecomposeLclFld.
Sivarv [Wed, 4 Jan 2017 23:36:58 +0000 (15:36 -0800)]
Merge pull request #8711 from sivarv/simdAbsOpt
Accelerate Abs intrinsic even in cases where there is no direct instruction support available.
Pat Gavlin [Wed, 4 Jan 2017 23:30:13 +0000 (15:30 -0800)]
Fix VSO 359733. (#8803)
* Fix VSO 359733.
This bug was an assertion when extracting side effects that failed when
checking that the presence or absence of value numbers on the head of
the side effect list matched the presence or absence of value numbers on
the node being added to the list. This condition does not hold when
remorphing, as remorphing may create nodes without value numbers. In
this case, the new comma node will have no value numbers for
conservative correctness. The failing assertion was weakened to allow
the presence/absence of value numbers on the head of the list and the
node being added to differ during remorphing.
Michelle McDaniel [Wed, 4 Jan 2017 22:36:45 +0000 (14:36 -0800)]
Merge pull request #8804 from adiaaida/devdiv_362706
Fix DevDiv 362706
Pat Gavlin [Wed, 4 Jan 2017 22:36:17 +0000 (14:36 -0800)]
Add a missing ref count bump in DecomposeLclFld.
DecomposeLclFld transforms a single lclFld node into two lclFld nodes
that reference the same lclVar, but was missing a corresponding ref
count bump. This was causing a failure in JIT/Methodical/fp/exgen/10w5d_cs_do
under JITStress=1 and JITStress=2.
Jan Vorlicek [Wed, 4 Jan 2017 21:05:43 +0000 (22:05 +0100)]
Fix NULL string printing in printf (#8800)
The functions implementing various printf flavors in PAL were not handling
correctly the case when a string pointer passed to them for %S and %s formats
was NULL. Instead of printing `(null)`, they were crashing.
This change fixes the problem and also adds PAL tests to verify it is working
properly.
Michelle McDaniel [Wed, 4 Jan 2017 17:42:19 +0000 (09:42 -0800)]
Fix DevDiv 362706
The issue here was that when we morphed a mod into a sub mul div, we would
ultimately decrease the ref counts to the numerator of the original mod
without performing a corresponding increase. The fix is to increase the
ref count when morphing into the sub mul div.
sivarv [Thu, 22 Dec 2016 22:59:32 +0000 (14:59 -0800)]
Accelerate Abs intrinsic even in cases where there is no direct instruction support available.
Michelle McDaniel [Wed, 4 Jan 2017 19:32:11 +0000 (11:32 -0800)]
Merge pull request #8802 from adiaaida/fixCorefxGroovy
Do not supply fx_root to run-corefx-tests
adiaaida [Wed, 4 Jan 2017 18:30:28 +0000 (10:30 -0800)]
Do not validate fx_root in run-corefx-tests
Users are able to supply an fx_root that does not yet exist and
run-corefx-tests.py will create that directory. However,
run-corefx-tests.py checks to confirm that fx_root already exists when
we validate. This causes the script to exit with an error when fx_root
does not yet exist. This change modifies run-corefx-tests.py so that we
do not validate the fx_root path.
This change also fixes the path to WORKSPACE for ubuntu corefx testing
in netci.groovy.
Sedar Gokbulut [Wed, 4 Jan 2017 19:21:20 +0000 (11:21 -0800)]
Adding Microsoft.NETCore.Native package (#8791)
* "Adding Microsoft.NETCore.Native package"
* Adding generic linux configuration to Microsoft.NETCore.Native package
* Fixing the OSX pkgproj of Microsoft.NETCore.Native to include S.Globalization.Native.dylib and not .so
Jan Kotas [Wed, 4 Jan 2017 17:18:14 +0000 (09:18 -0800)]
Merge pull request #8719 from jkotas/native-buffer
Use ArrayPool for PathHelper
Stephen Toub [Wed, 4 Jan 2017 15:48:29 +0000 (10:48 -0500)]
Merge pull request #8796 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to beta-24904-02, beta-24904-01, respectively (master)
Jan Kotas [Wed, 4 Jan 2017 14:31:17 +0000 (06:31 -0800)]
Path normalization performance improvements
- Use const variant of path separators in the Path implementation
- Add fast paths for common cases to hot parsing routines
- Avoid redundant caches for MaxPath on Unix
Jan Kotas [Mon, 26 Dec 2016 08:08:01 +0000 (00:08 -0800)]
Delete unused file
Jan Kotas [Wed, 21 Dec 2016 23:46:53 +0000 (15:46 -0800)]
Use ArrayPool for PathHelper
Replace special unmanaged memory pool used by PathHelper by shared ArrayPool. Custom memory pools are not good for global system performance, and the particular implementation of the unmanaged memory pool was also problematic for CoreRT port because of its dependencies.
SaeHie Park [Wed, 4 Jan 2017 14:06:24 +0000 (23:06 +0900)]
[x86/Linux] Implement ResolveWorkerChainLookupAsmStub (#8780)
Replace ResolveWorkerChainLookupAsmStub with actual implementation
- code is copied from Win32 version
- replaced some parts to compile in linux
SaeHie Park [Wed, 4 Jan 2017 10:10:13 +0000 (19:10 +0900)]
[x86/Linux] Implement SinglecastDelegateInvokeStub (#8799)
Implement SinglecastDelegateInvokeStub for x86/Linux
- Code copied from that of AMD64 and some translation
- Fixes LargeObjectAlloc.exe unit test case and maybe others
dotnet-bot [Wed, 4 Jan 2017 09:44:37 +0000 (09:44 +0000)]
Update CoreClr, CoreFx to beta-24904-02, beta-24904-01, respectively
Julien Couvreur [Wed, 4 Jan 2017 02:09:17 +0000 (18:09 -0800)]
Remove un-necessary ITuple constraint (#8793)
Stephen A. Imhoff [Wed, 4 Jan 2017 00:43:59 +0000 (16:43 -0800)]
Redo some argument name corrections (#8727)
* TraceLogging
* SignatureHelper
* RuntimeReflectionExtensions
* RuntimeHandles - Public
* SemaphoreSlim - Public
* Directory - Public
* ModuleBuilder - Public
* EncoderFallback - Public - Test Failures
* StringBuilder - Public - Test Failures