sandholm@chromium.org [Mon, 20 Sep 2010 10:36:21 +0000 (10:36 +0000)]
Changed the RegExp benchmark to exercise the regexp engine on different
inputs by scrambling the input strings.
Review URL: http://codereview.chromium.org/3435012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5493
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Mon, 20 Sep 2010 09:29:12 +0000 (09:29 +0000)]
Show RegExp calls in the profile.
It turns out they were filtered out. But when I unfiltered them, I
discovered another issue: when DevTools run, regexp literals get
recompiled each time they called (looks like this is concerned with
switching to full compiler), so I ended up having multiple entries for
the same regexp. To fix this, I changed the way of how code entries
equivalence is considered.
BUG=crbug/55999
TEST=cctest/test-profile-generator/ProfileNodeFindOrAddChildForSameFunction
(the test isn't for the whole issue, but rather for equivalence testing)
Review URL: http://codereview.chromium.org/3426008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5492
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
floitschV8@gmail.com [Mon, 20 Sep 2010 09:18:00 +0000 (09:18 +0000)]
Added precision mode to fast-dtoa.
Review URL: http://codereview.chromium.org/2000004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5491
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Mon, 20 Sep 2010 08:43:35 +0000 (08:43 +0000)]
Remove unused variable from Scanner class.
BUG=None
TEST=compiles
Patch from Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/3413015
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5490
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 17 Sep 2010 12:55:27 +0000 (12:55 +0000)]
Make preparsing data reusable.
Fix bug in writing symbol ids over 128.
Review URL: http://codereview.chromium.org/3416010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5485
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Fri, 17 Sep 2010 12:08:50 +0000 (12:08 +0000)]
Add missing x87 instructions fisttp and fst to the disassembler.
Review URL: http://codereview.chromium.org/3408011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5484
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Fri, 17 Sep 2010 09:56:47 +0000 (09:56 +0000)]
Fix direct loading of global function prototypes:
We must also check the current context has not changed.
The bug reported by Florian.
Review URL: http://codereview.chromium.org/3410014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5483
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 17 Sep 2010 08:34:53 +0000 (08:34 +0000)]
Make some runtime arguments checks be RUNTIME_ASSERT, not ASSERT.
Review URL: http://codereview.chromium.org/3411013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5482
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Thu, 16 Sep 2010 21:40:42 +0000 (21:40 +0000)]
Add breakOnCaughtException and breakOnUncaughtException flags
Review URL: http://codereview.chromium.org/3275011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5480
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kaznacheev@chromium.org [Thu, 16 Sep 2010 10:55:37 +0000 (10:55 +0000)]
Prevent inline constructor generation when duplicate properties are present in the constructor.
Currenly the constructor like this:
function f() {
this.a = 0;
this.a = 1;
this.a = 2;
}
creates a map with duplicate desciptors which is bad in many ways.
Review URL: http://codereview.chromium.org/3434004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5476
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Thu, 16 Sep 2010 09:18:08 +0000 (09:18 +0000)]
Fix a regression in character-at stub when doing a keyed load on a string.
Loading from out-of-range has to go to the runtime system to check if there
exists a property with that index in the prototype.
Review URL: http://codereview.chromium.org/3410011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5471
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Thu, 16 Sep 2010 09:10:34 +0000 (09:10 +0000)]
Clean up the insertion of nops (signalling non-inlined loads and
stores) in the full codegens.
Review URL: http://codereview.chromium.org/3431010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5470
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 16 Sep 2010 08:51:13 +0000 (08:51 +0000)]
Really fix Mac build, and lint.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5469
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 16 Sep 2010 08:39:27 +0000 (08:39 +0000)]
Fix compilation issue on Mac
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5468
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 16 Sep 2010 08:23:34 +0000 (08:23 +0000)]
Enhance SafeStackFrameIterator to avoid triggering assertions in debug mode.
When running profiling in debug mode, several assertions in frame
iterators that are undoubtedly useful when iterator is started from a
VM thread in a known "good" state, may fail when running over a stack
of a suspended VM thread. This patch makes SafeStackFrameIterator
to proactively check addresses and bail out from iteration early,
before an assertion will be triggered.
BUG=crbug/55565
Review URL: http://codereview.chromium.org/3436006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5467
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 16 Sep 2010 08:17:46 +0000 (08:17 +0000)]
Fix x64 compilation error. Patch from tfarina@chromium.org
http://codereview.chromium.org/3442004/show
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5466
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Thu, 16 Sep 2010 07:24:15 +0000 (07:24 +0000)]
X64: Templating Smi-macros to use both Label and NearLabel.
Added some more uses of NearLabel.
Review URL: http://codereview.chromium.org/3381005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5465
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 15 Sep 2010 12:17:41 +0000 (12:17 +0000)]
Made the use of past tense more consistent in change log.
Review URL: http://codereview.chromium.org/3425005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5461
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Wed, 15 Sep 2010 11:43:12 +0000 (11:43 +0000)]
Add support for near labels.
This change introduces near labels in the assembler, allowing us to
uptimize forward jumps (conditional and unconditional) if we can
guarantee that the jump is witin range -128 to +127.
I changed a large fractions of the existing Labels to NearLabels, and
left out cases where it was not immediately clear if it could be used
or not (not immediately clear means labels covering a large code
block, or used in function calls which we could potentially change to
accept near labels).
Review URL: http://codereview.chromium.org/3388004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5460
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 15 Sep 2010 10:58:25 +0000 (10:58 +0000)]
Prepare push to trunk. We are now working on version 2.4.5.
Review URL: http://codereview.chromium.org/3429006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5459
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Wed, 15 Sep 2010 10:54:35 +0000 (10:54 +0000)]
Made predata smaller by storing symbol data in variable length base-128.
Remove position from symbol data - they must come in the correct order anyway.
Review URL: http://codereview.chromium.org/3384003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5458
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 15 Sep 2010 10:22:55 +0000 (10:22 +0000)]
Replace 2 ARM ldr instructions with one ldrd in the code generated
for a SubStringStub and StringCompareStub in the ARM backend. This
is a commit of http://codereview.chromium.org/3341012 for Andreas
Anyuru.
Review URL: http://codereview.chromium.org/3387003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5457
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Wed, 15 Sep 2010 10:14:25 +0000 (10:14 +0000)]
Make the CompareStub and the UnaryOpStub accept smi inputs.
The stubs get an additional flag for including the smi code
inside the stub. This allows us to generate more compact code
if we don't want to inline the smi case outside the stub.
Review URL: http://codereview.chromium.org/3388005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5456
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Tue, 14 Sep 2010 17:48:56 +0000 (17:48 +0000)]
Attempt to collect more garbage before panicking with out of memory.
Currently weak handles retain an object for another GC round (oftem times,
major GC round.) Instrumenting Chromium shows that navigation leaves
many global objects which are only collected in next go. Let's
attempt to collect more garbage when approacing OOM condition.
Review URL: http://codereview.chromium.org/3327021
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5455
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Tue, 14 Sep 2010 16:38:02 +0000 (16:38 +0000)]
Add a few missing nops to signal no inlined code was generated.
Review URL: http://codereview.chromium.org/3399005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5454
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Tue, 14 Sep 2010 15:16:32 +0000 (15:16 +0000)]
Allow List::sort, with an integer comparison function, to sort 64-bit pointers in profile-generator. Change a static const int member to be declared and defined only inside the class declaration in class Runtime.
Review URL: http://codereview.chromium.org/3424002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5453
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Tue, 14 Sep 2010 15:11:24 +0000 (15:11 +0000)]
Add support for abortion in v8::OutputStream.
It's a good idea to allow receiver to interrupt data transmission.
Review URL: http://codereview.chromium.org/3409002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5452
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Tue, 14 Sep 2010 14:52:53 +0000 (14:52 +0000)]
Move inlined function declarations and support from codegen.* to runtime.*.
Review URL: http://codereview.chromium.org/3293002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5451
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Tue, 14 Sep 2010 11:49:06 +0000 (11:49 +0000)]
Implement heap snapshots serialization into JSON. API is designed
to avoid storing serialized snapshot on VM, instead it is emitted
using output stream interface.
The size of JSON emitted is roughly equal to used heap size
(when stored as an ASCII string).
Now a whole heap snapshot can be serialized and transmitted outside
VM. This makes possible:
- implementing non-async UI for heap snapshots inspection;
- storing heap snapshots for further inspection;
- remote profiling (we can even implement a snapshotting mode
where a snapshot isn't even stored in VM, only transmitted --
good for mobile devices);
- creating tools for outside heap snapshots processing, e.g.
converting to HPROF.
Review URL: http://codereview.chromium.org/3311028
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5450
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sandholm@chromium.org [Mon, 13 Sep 2010 13:55:26 +0000 (13:55 +0000)]
Recalibrate benchmarks.
Review URL: http://codereview.chromium.org/3300031
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5449
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Mon, 13 Sep 2010 09:10:47 +0000 (09:10 +0000)]
Prepare push to trunk. We are now working on version 2.4.4.
Review URL: http://codereview.chromium.org/3308028
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5446
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kasperl@chromium.org [Mon, 13 Sep 2010 06:13:20 +0000 (06:13 +0000)]
Implement for-in cache validity checking in the full codegen on IA-32.
Review URL: http://codereview.chromium.org/3376003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5445
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Fri, 10 Sep 2010 10:57:07 +0000 (10:57 +0000)]
Handle both global and local variables potentially shadowed by
eval-introduced variables in full-codegen.
Make sure that x64 assembler records source positions for calls.
Review URL: http://codereview.chromium.org/3357022
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5441
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 10 Sep 2010 09:22:41 +0000 (09:22 +0000)]
Move string-search functions to separate file.
Review URL: http://codereview.chromium.org/3291021
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5440
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 10 Sep 2010 08:21:01 +0000 (08:21 +0000)]
Fix bug in Array.prototype.indexOf/lastIndexOf when called on non-sparse non-arrays.
Review URL: http://codereview.chromium.org/3358025
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5439
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Fri, 10 Sep 2010 08:12:34 +0000 (08:12 +0000)]
Cosmetic change, list author names in AUTHORS alphabetically.
Review URL: http://codereview.chromium.org/3311025
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5438
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 10 Sep 2010 07:08:03 +0000 (07:08 +0000)]
Added Michael Smith to Authors file (author of revision 5436).
Review URL: http://codereview.chromium.org/3327013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5437
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 10 Sep 2010 07:00:28 +0000 (07:00 +0000)]
make Date.parse properly handle TZ offsets
This makes, e.g., Date.parse("2010-08-31T22:35:36-09:00") work as
expected. Without this change, the "-9:00" timezone-offset portion
causes V8 to fail to properly parse that string into a date.
BUG=http://code.google.com/p/v8/issues/detail?id=857
TEST=Try Date.parse("2010-08-31T22:35:36-09:00") and make sure
that it gets parsed without errors and does not return NaN.
Review URL: http://codereview.chromium.org/3318017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5436
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Thu, 9 Sep 2010 17:45:21 +0000 (17:45 +0000)]
Landing 3338012: Move a function below to private section.
Review URL: http://codereview.chromium.org/3295023
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5434
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Thu, 9 Sep 2010 13:38:01 +0000 (13:38 +0000)]
Custom call IC for String.fromCharCode.
Review URL: http://codereview.chromium.org/3291015
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5433
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Thu, 9 Sep 2010 12:57:32 +0000 (12:57 +0000)]
Add sparse array handling to Array.protoype.indexOf/lastIndexOf.
Review URL: http://codereview.chromium.org/3132046
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5432
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Thu, 9 Sep 2010 11:49:21 +0000 (11:49 +0000)]
Avoid collecting symbol info for one-off preparsing.
Review URL: http://codereview.chromium.org/3356010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5431
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 9 Sep 2010 10:44:24 +0000 (10:44 +0000)]
Handle global variables potentially shadowed by eval-introduced
variables in full-codegen.
Review URL: http://codereview.chromium.org/3295022
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5430
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sandholm@chromium.org [Wed, 8 Sep 2010 12:57:50 +0000 (12:57 +0000)]
Change threshold for using ComplexIndexOf (using Boyer-Moore string
search) from 5 to 7.
Review URL: http://codereview.chromium.org/3294016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5429
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sandholm@chromium.org [Wed, 8 Sep 2010 11:05:54 +0000 (11:05 +0000)]
Store pattern.length() in a local.
Review URL: http://codereview.chromium.org/3300020
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5428
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Wed, 8 Sep 2010 10:33:15 +0000 (10:33 +0000)]
Don't generate preparse data if lazy-flag is false.
Review URL: http://codereview.chromium.org/3304012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5427
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Wed, 8 Sep 2010 06:20:09 +0000 (06:20 +0000)]
Prepare push of version 2.4.2 to trunk.
Review URL: http://codereview.chromium.org/3324010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5424
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
podivilov@chromium.org [Tue, 7 Sep 2010 15:34:16 +0000 (15:34 +0000)]
Move stack check below while statement.
Call to Runtime_StackGuard should be generated after loop body.
Otherwise, break position will be the previous position before
loop statement.
Review URL: http://codereview.chromium.org/3302012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5423
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kaznacheev@chromium.org [Tue, 7 Sep 2010 13:33:40 +0000 (13:33 +0000)]
Avoid pushing arguments twice in GenericBinaryOpStub.
Under some conditions (ADD, non-number arguments passed in registers)
GenerateRegisterArgumentsPush was called twice and the stack broke.
Review URL: http://codereview.chromium.org/3290012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5422
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Tue, 7 Sep 2010 12:52:16 +0000 (12:52 +0000)]
Avoid (some) symbol lookups at parse time if preparse data is available.
Review URL: http://codereview.chromium.org/3308010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5421
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
serya@chromium.org [Tue, 7 Sep 2010 11:32:20 +0000 (11:32 +0000)]
Removing a wrong check.
A strings which represents an array index with length 8 and 9 digits do not pass this check. However generated hash is valid.
Review URL: http://codereview.chromium.org/3295017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5420
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Tue, 7 Sep 2010 11:09:45 +0000 (11:09 +0000)]
Fix the ambigous Operand(0) for newer C++ compilers.
Review URL: http://codereview.chromium.org/3351010/show
Committed for Thiago Farina <tfarina@chromium.org>
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5419
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Tue, 7 Sep 2010 09:15:15 +0000 (09:15 +0000)]
Ensure that empty descriptor array is marked before visiting any maps in marking phase.
Review URL: http://codereview.chromium.org/3318014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5416
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 6 Sep 2010 12:54:41 +0000 (12:54 +0000)]
Add test for calls to native runtime functions in extensions.
Review URL: http://codereview.chromium.org/3356007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5415
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Mon, 6 Sep 2010 12:50:11 +0000 (12:50 +0000)]
Turn visitor_id into a byte field and free back one word in Map.
Review URL: http://codereview.chromium.org/3364007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5414
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Mon, 6 Sep 2010 11:31:07 +0000 (11:31 +0000)]
Prepare push to trunk. Now working on version 2.4.2.
Review URL: http://codereview.chromium.org/3305012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5411
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Mon, 6 Sep 2010 09:10:11 +0000 (09:10 +0000)]
Improve performance of Error.stack when stack contains local functions.
BUG=http://crbug.com/53303
TEST=Use the test case attached in the bug report.
Patch by Xianzhu Wang <wangxianzhu@google.com>
Review URL: http://codereview.chromium.org/3167042
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5410
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Fri, 3 Sep 2010 12:59:52 +0000 (12:59 +0000)]
Add and use AsciiAlphaToLower. Move RemoveLast test. Add Clear test. This is a commit of codereview.chromium.org/3307003/show http://codereview.chromium.org/3312007/show and http://codereview.chromium.org/3341002/show for tfarina
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5409
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 3 Sep 2010 12:56:08 +0000 (12:56 +0000)]
Fix compilation on 64-bit Windows (a third try)
Review URL: http://codereview.chromium.org/3295014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5408
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 3 Sep 2010 12:31:43 +0000 (12:31 +0000)]
Fix compilation on 64-bit Windows (a second try)
TBR=pmehta@chromium.org
Review URL: http://codereview.chromium.org/3290009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5406
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Fri, 3 Sep 2010 12:10:44 +0000 (12:10 +0000)]
Handle argument conversion in StringAddStub.
In case one of the arguments is known to be a string we emit a few
fast conversion attempts for the other. This allows using the
StringAddStub instead of STRING_ADD_{LEFT,RIGHT} builtins.
Review URL: http://codereview.chromium.org/3338007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5405
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 3 Sep 2010 12:00:05 +0000 (12:00 +0000)]
Fix compilation on 64-bit Windows
TBR=pmehta@chromium.org
Review URL: http://codereview.chromium.org/3333015
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5404
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 3 Sep 2010 11:31:58 +0000 (11:31 +0000)]
Add API callback for tracking allocated memory
Allows the host application to provide a mechanism for notification and custom logging through a callback (set through the API V8::AddMemoryAllocationCallback and removed through V8::RemoveMemoryAllocationCallback), when V8 allocates ro frees memory.
This replaces the current histogram data "V8.ExecutableMemoryMax" by allowing usage data to be logged by the application as required rather than always through V8.
BUG=http://crbug.com/54222
TEST=Set the callback function with the API and cause V8 to allocate memory.
Patch by Paul Mehta <pmehta@chromium.org>
Review URL: http://codereview.chromium.org/3329006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5403
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 2 Sep 2010 10:18:44 +0000 (10:18 +0000)]
Clang compatibility changes. This is a commit of codereview.chromium.org/3364002 for coldredlemur
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5402
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 2 Sep 2010 08:30:52 +0000 (08:30 +0000)]
ARM: Handle bitwise operations with literal Smi for 32bits integers without calling the GenericBinaryOpStub. Refactored and updated the routine to convert a signed int to a double. This is a commit of codereview.chromium.org/3247008 for Rodolph Perfetta.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5401
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Thu, 2 Sep 2010 07:36:30 +0000 (07:36 +0000)]
Fix parsing of /**/--> on first line of input.
BUG=53548
TEST=
Review URL: http://codereview.chromium.org/3330001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5400
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Thu, 2 Sep 2010 07:35:35 +0000 (07:35 +0000)]
Fix bug in JSON character quote table.
Review URL: http://codereview.chromium.org/3349006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5399
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Thu, 2 Sep 2010 07:09:28 +0000 (07:09 +0000)]
Make JSON.stringify not quote non-ASCII characters. Fix bug 855.
Review URL: http://codereview.chromium.org/3336001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5398
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Wed, 1 Sep 2010 17:20:36 +0000 (17:20 +0000)]
ia32 StringAddStub: fast two character case.
Review URL: http://codereview.chromium.org/3327001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5397
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Wed, 1 Sep 2010 17:01:58 +0000 (17:01 +0000)]
Don't access PagedSpace::executability after the object has been destroyed
Review URL: http://codereview.chromium.org/3344001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5395
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Wed, 1 Sep 2010 13:13:31 +0000 (13:13 +0000)]
Remove CodeGenerator::PatchInlineRuntimeEntry and replace its single use in test-log-stack-tracer.cc with an alternative implementation.
Review URL: http://codereview.chromium.org/3311002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5392
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Wed, 1 Sep 2010 13:08:39 +0000 (13:08 +0000)]
Fix memory overrun possibility during tick samples processing.
This really can cause crash described in crbug/51919.
BUG=51919
TEST=NONE
Review URL: http://codereview.chromium.org/3334001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5391
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Wed, 1 Sep 2010 12:25:46 +0000 (12:25 +0000)]
Initialize all VariableProxy fields in its constructor
Review URL: http://codereview.chromium.org/3330002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5390
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Wed, 1 Sep 2010 06:37:49 +0000 (06:37 +0000)]
Prepare push of version 2.4.0 to trunk. Now working on version 2.4.1.
Review URL: http://codereview.chromium.org/3303002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5387
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Tue, 31 Aug 2010 14:16:01 +0000 (14:16 +0000)]
CPU profiler: limit the number of simultaneously collected profiles.
This is related to Chromium issue 51919
BUG=51919
TEST=test-profile-generator/Issue51919
Review URL: http://codereview.chromium.org/3287005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5384
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Tue, 31 Aug 2010 12:20:22 +0000 (12:20 +0000)]
Fix win64 compilation (using static_cast)
Review URL: http://codereview.chromium.org/3225011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5383
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Tue, 31 Aug 2010 10:39:12 +0000 (10:39 +0000)]
Simplify Array.splice by simply returning the result of AllocateEmptyJSArray.
Review URL: http://codereview.chromium.org/3216014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5382
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Tue, 31 Aug 2010 10:39:02 +0000 (10:39 +0000)]
Remove assertion that is no longer valid in InitializeStringSearch.
This assertion is no longer valid because r5380 changes the assumption
about the pat parameter.
In addition, we embed the no allocation part of StringSplit in a block
to reenable allocation later in that method.
Review URL: http://codereview.chromium.org/3254010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5381
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sandholm@chromium.org [Tue, 31 Aug 2010 09:22:53 +0000 (09:22 +0000)]
Simplify code by removing special-casing for single-character patterns
Review URL: http://codereview.chromium.org/3276004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5380
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Tue, 31 Aug 2010 08:05:42 +0000 (08:05 +0000)]
Get gcc to check that we don't ignore return values of functions that can
fail to allocate because we need a GC.
Review URL: http://codereview.chromium.org/3274008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5379
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Tue, 31 Aug 2010 08:05:33 +0000 (08:05 +0000)]
Address some issues with detecting the architecture. See
http://code.google.com/p/v8/issues/detail?id=429
Review URL: http://codereview.chromium.org/3261003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5378
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Tue, 31 Aug 2010 07:31:25 +0000 (07:31 +0000)]
Fix mozilla and debug check failures.
This removes the expected failure of a mozilla test that we now pass
(an empty array is returned if Array.splice is called with no
arguments) and fixes debug check failure by allocating a new empty
array using AllocateEmptyArray if splice is called with zero arguments
(makes sure we can always create a handle).
Review URL: http://codereview.chromium.org/3218010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5377
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Mon, 30 Aug 2010 18:08:50 +0000 (18:08 +0000)]
Follow Safari and Firefox in returning empty array from array splice
with no arguments.
Review URL: http://codereview.chromium.org/3277005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5375
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Mon, 30 Aug 2010 13:39:07 +0000 (13:39 +0000)]
Set the code pointer when compiling a function.
Without this fix LazyCompile has to be called twice to set it.
Review URL: http://codereview.chromium.org/3253003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5374
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Mon, 30 Aug 2010 13:30:54 +0000 (13:30 +0000)]
Fix a error in SamplingCircularQueue found using Valgrind memcheck.
Review URL: http://codereview.chromium.org/3251004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5373
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Mon, 30 Aug 2010 12:34:32 +0000 (12:34 +0000)]
Force relinking of paged space if first attempt to recommit from space fails.
That could improve chances for commit success as currently,
if we moved free pages out of order, we cannot shrink spaces.
However, when we experience problems commiting from space back, we should
use most of resources at our disposal.
Also get rid of currently unused parameter to DeallocateFunction.
Review URL: http://codereview.chromium.org/3260001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5372
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
antonm@chromium.org [Mon, 30 Aug 2010 12:26:58 +0000 (12:26 +0000)]
Add os_error stat to oom_dump utility.
Review URL: http://codereview.chromium.org/3150028
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5371
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 30 Aug 2010 11:48:07 +0000 (11:48 +0000)]
Remove dependence of code-stubs on codegen, the virtual frame code generator. Move some functions used by code-stubs and full-codegen from codegen to macro-assembler.
Review URL: http://codereview.chromium.org/3169049
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5370
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Mon, 30 Aug 2010 08:54:43 +0000 (08:54 +0000)]
Add functionality for finding code objects from a pc that points into
the code object's instructions.
This allows us to find a code object using just the pc. This approach
uses a cache (PcToCodeCache) to make sure we don't continuously have
to iterate heap pages.
This change eliminates the need for cooking and uncooking of stack frames.
Review URL: http://codereview.chromium.org/3226014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5369
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 30 Aug 2010 07:10:40 +0000 (07:10 +0000)]
Improve header file inclusions. Drop some unneeded includes, and add some needed ones.
Review URL: http://codereview.chromium.org/3253001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5366
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Fri, 27 Aug 2010 13:23:14 +0000 (13:23 +0000)]
Fix regress-851.js to use assertNull instead of assertFalse.
Review URL: http://codereview.chromium.org/3232002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5365
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Fri, 27 Aug 2010 13:06:50 +0000 (13:06 +0000)]
Check result of JSObject::NormalizeElements() in JSObject::PreventExtensions().
Normalization requires allocation so Failure object can be returned.
BUG=http://code.google.com/p/v8/issues/detail?id=851
TEST=test/mjsunit/regress/regress-851.js
Review URL: http://codereview.chromium.org/3262001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5364
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
serya@chromium.org [Fri, 27 Aug 2010 12:16:00 +0000 (12:16 +0000)]
Fixing build error r5362 (adding missing files).
Review URL: http://codereview.chromium.org/3258001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5363
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
serya@chromium.org [Fri, 27 Aug 2010 11:47:12 +0000 (11:47 +0000)]
Using array index hash code for string-to-number conversion.
Review URL: http://codereview.chromium.org/3141022
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5362
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 27 Aug 2010 08:26:29 +0000 (08:26 +0000)]
Reordered function entries in PreParse data to be ordered by start position.
Also add skip to entry, to skip pre-data for the body of the function.
Preparser data is now only accessed linearly, in the same order it was created.
Review URL: http://codereview.chromium.org/3185026
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5361
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 27 Aug 2010 07:41:46 +0000 (07:41 +0000)]
Fix presumbit errors in previous commit
TBR=kasperl@chromium.org
Review URL: http://codereview.chromium.org/3249001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5360
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 27 Aug 2010 07:26:35 +0000 (07:26 +0000)]
Add file missing from last commit.
TBR=kasperl@chromium.org
Review URL: http://codereview.chromium.org/3248001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5359
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 27 Aug 2010 07:08:03 +0000 (07:08 +0000)]
Cleanup the way the debugger stores live registers when entering at a break
The live registers are now only stored to the expression stack with the non pointer values being stored as smis (on the 32-bit platforms these values are assumed to be 31-bit max).
This makes the CEntryStub entry/exit code much simpler, and there is no longer any need for a mode (debug or normal) on it.
Fix a missing live register when breaking at ARM keyed load.
Review URL: http://codereview.chromium.org/3141047
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5358
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Thu, 26 Aug 2010 13:59:37 +0000 (13:59 +0000)]
Fast string construct stub (ia32 only for now).
Review URL: http://codereview.chromium.org/3211002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5357
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Thu, 26 Aug 2010 13:03:17 +0000 (13:03 +0000)]
Fix indention in v8natives.js - no functionality change.
Review URL: http://codereview.chromium.org/3110041
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5354
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00