Kent Hansen [Wed, 3 Aug 2011 13:05:25 +0000 (15:05 +0200)]
Add QIntrusiveList::contains() function
QIntrusiveList is nice, but it needs a contains() function.
Change-Id: I17adf63db080ffd39acac18cd8ecb23e48d76ed6
Reviewed-on: http://codereview.qt.nokia.com/2569
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Jedrzej Nowacki [Wed, 3 Aug 2011 15:07:17 +0000 (17:07 +0200)]
Remove dead code.
Structure was not used.
Change-Id: Ib3a67f8a1850c211bb0b0700c10153eb9ab6441a
Reviewed-on: http://codereview.qt.nokia.com/2583
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
Bea Lam [Wed, 3 Aug 2011 05:40:58 +0000 (15:40 +1000)]
Fix ListView refill() where delegate size == 0
When refilling, if a delegate item is positioned at the start of the
buffer, it should only be removed if its height is > 0. Otherwise
refill() will constantly remove it in removeNonVisibleItems() and
add it again in the next frame in addVisibleItems().
Regression from
aa99d4f5cb4f1f512d1db90536752b518dbea449
Task-number: QTBUG-20712
Change-Id: I21d25fde21e0b559a378c9e202ace58947417a4d
Reviewed-on: http://codereview.qt.nokia.com/2541
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Michael Brasser [Thu, 4 Aug 2011 03:51:24 +0000 (13:51 +1000)]
Improved support for multiple to/from values in Transition.
Trim the strings (previously "state1,state2" would work, but not
"state1, state2", and document the feature.
Task-number: QTBUG-14713
Change-Id: Ie0c5f803754751008c3e1bf766f08914f743338f
Reviewed-on: http://codereview.qt.nokia.com/2592
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Bea Lam [Thu, 4 Aug 2011 05:02:37 +0000 (15:02 +1000)]
Rework threading internals in XmlListModel to avoid global static
QTBUG-20629 reports a crash on destruction of XmlListModel when
cleaning up the global static for the QDeclarativeXmlQuery object.
The fix restructures the internals to be like the threading structure
used for QDeclarativePixmapReader which doesn't use a global static.
Task-number: QTBUG-20629
Reviewed-by: Martin Jones
(cherry picked from commit
422f4e8ec53b917fad09a3e671fd93048dde72ed in
qt-qml-staging:master)
Change-Id: Ic26164947abab67ec9d8f1ae68c20961e7af8a2b
Reviewed-on: http://codereview.qt.nokia.com/2595
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Chris Adams [Wed, 3 Aug 2011 04:00:57 +0000 (14:00 +1000)]
Improve error messages from compiler for signals and slots
This commit ensures that correct line and column information is
provided in some cases (duplicate signal or method name, etc).
Task-number: QTBUG-15076
Change-Id: I483bdc92ef4f1d1d2ff565bb957385fd495672da
Reviewed-on: http://codereview.qt.nokia.com/1619
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Chris Adams [Tue, 12 Jul 2011 04:05:24 +0000 (14:05 +1000)]
Honour the resettable flag of aliased properties
Previously, alias properties were not considered isResettable even
if the property they alias is resettable. This commit ensures that
the IsResettable flag is set for alias properties iff the aliased
property is resettable, and that it is honoured during property
reset operations.
Task-number: QTBUG-18182
Change-Id: I9cab11923a952df72e976a48489a78b24a34314f
Reviewed-on: http://codereview.qt.nokia.com/1471
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Michael Brasser [Thu, 4 Aug 2011 00:30:46 +0000 (10:30 +1000)]
Add enabled property to Transition.
Task-number: QTBUG-14488
Change-Id: I3619a0d26e99e2c19f50a63013dedc151b07154c
Reviewed-on: http://codereview.qt.nokia.com/2591
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Chris Adams [Wed, 3 Aug 2011 05:45:47 +0000 (15:45 +1000)]
Fix crash in QDeclarativeProperty
This commit ensures that we don't attempt to dereference a null
pointer in QDeclarativeProperty. It also fixes a unit test failure
by adding appropriate test files.
Related to commit
9f9b23fd7943a3d125cb1cc9f333ce430b2706ea
Task-number: QTBUG-14697
Change-Id: Ic60521e46401835029e293349a00610342d0d58f
Reviewed-on: http://codereview.qt.nokia.com/2538
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Tue, 2 Aug 2011 00:46:23 +0000 (10:46 +1000)]
Typo
Change-Id: I8be86a999eed0cc028415027e888515377cd37ad
Reviewed-on: http://codereview.qt.nokia.com/2461
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Jedrzej Nowacki [Tue, 2 Aug 2011 11:14:26 +0000 (13:14 +0200)]
Improve QJSValueIterator implementation.
The old implementation was a hack, it had some memory leak (in case of
deleted engine) and performance problems (for example all names were
copied to separate QList instance instead of reusing v8::Array).
Change-Id: Ic70ad511127a8c05df3c627e4496083004c6452a
Reviewed-on: http://codereview.qt.nokia.com/2512
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Peter Varga [Mon, 30 May 2011 14:23:29 +0000 (16:23 +0200)]
Remove FIXME from the v8base.pri
Check the version of gcc and use -fno-strict-aliasing flag when it's
4.5.
Merge-request: 1
(This patch was cherry-pick from QtScript module)
Reviewed-by: Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Change-Id: I0086ec374c7cfd4c0842198734318c915c6cea8d
Reviewed-on: http://codereview.qt.nokia.com/2515
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Andrew den Exter [Wed, 3 Aug 2011 05:51:06 +0000 (15:51 +1000)]
Add some guidelines for declaring objects as properties of Components.
Task-number: QTBUG-20198
Change-Id: Id8ba8901be6c4f06974d1afd32f1932f867e2544
Reviewed-on: http://codereview.qt.nokia.com/2540
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Michael Brasser [Wed, 3 Aug 2011 01:01:52 +0000 (11:01 +1000)]
Prevent Binding from crashing when its target object is deleted.
Task-number: QTBUG-20692
Change-Id: Ia9a3d532c45baf01b8c20c7aac9ef373942a75d8
Reviewed-on: http://codereview.qt.nokia.com/2531
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Caio Marcelo de Oliveira Filho [Tue, 2 Aug 2011 23:31:19 +0000 (20:31 -0300)]
qmltest: Fix SignalSpy to use TestUtil helper functions
Previously the callerFile() and callerLine() functions were exposed as
properties of the QtTest module, but now they are available in the
TestUtil component. TestCase was updated but SignalSpy wasn't.
Change-Id: Ic3f35e6f096b28c443e8aadaa78732a8a15dc284
Reviewed-on: http://codereview.qt.nokia.com/2528
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Jedrzej Nowacki [Mon, 1 Aug 2011 11:31:19 +0000 (13:31 +0200)]
Enable tst_QJSEngine::stacktrace test.
The test can be enabled because QJSValueIterator is back.
Change-Id: I33a84b0e584137ecff0d65c2a6152ca972e863f1
Reviewed-on: http://codereview.qt.nokia.com/2440
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Jedrzej Nowacki [Mon, 1 Aug 2011 10:48:34 +0000 (12:48 +0200)]
Enable globalObjectProperties_enumerate test.
The test can be enabled because QJSValueIterator is back.
Change-Id: I81220ea17470663dab799eb818168480d2df1a54
Reviewed-on: http://codereview.qt.nokia.com/2439
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Thorbjørn Lindeijer [Mon, 18 Apr 2011 15:20:49 +0000 (17:20 +0200)]
Introduced a CONFIG option that enables declarative debug services
This replaces the need for applications to explicitly make a call to
enable the debug services, and rather does it in declarative.h when the
'declarative_debug' CONFIG option is used.
Done-with: Kai Koehne
Reviewed-by: Martin Jones
Reviewed-by: Michael Brasser
(cherry picked from commit
5517cc588c39814530b8bfd957821f55be42acf2)
Change-Id: Iacfc5a9b2ca0c2610288cf86f190b4a9950cacd1
Reviewed-on: http://codereview.qt.nokia.com/2436
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Andrew den Exter [Mon, 1 Aug 2011 03:09:10 +0000 (13:09 +1000)]
Add a currentItem property to PathView.
Task-number: QTBUG-16347
Change-Id: I6df4b2d7c5f325e84d54ed5befd66e20b64cc7e0
Reviewed-on: http://codereview.qt.nokia.com/2421
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Charles Yin [Fri, 29 Jul 2011 00:38:35 +0000 (10:38 +1000)]
Cancel mousearea pressed state when window is deactivated
Change-Id: I1cc21c338576a2ac3b1e8e282e8e4de3bc63759a
Task-number:QTBUG-19904
Reviewed-on: http://codereview.qt.nokia.com/2357
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Chris Adams [Tue, 12 Jul 2011 05:55:01 +0000 (15:55 +1000)]
Ensure that the prototype chain is checked in property Get
This commit ensures that the prototype chain is checked during
property Get operations on QObjects and other types in QML by
returning an empty handle from the property Get interceptor if
no valid property with the given name is found.
Task-number: QTBUG-20336
Change-Id: I670ee211c74c0fdcb68c3f91b29fcc0ea8b55d6f
Reviewed-on: http://codereview.qt.nokia.com/1477
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Chris Adams [Tue, 2 Aug 2011 00:04:16 +0000 (10:04 +1000)]
Add support for comparing value-type properties
This commit allows value-types to be compared with each other and
with variants. It also adds a toString() function for each value
type, to allow conversion to (and comparison with) string.
Task-number: QTBUG-14731
Change-Id: I5bde2820917b2fe19b581724977398680617de34
Reviewed-on: http://codereview.qt.nokia.com/1636
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Bea Lam [Mon, 1 Aug 2011 06:56:45 +0000 (16:56 +1000)]
Fix content position for key navigation with StrictlyEnforceRange
If a ListView had highlight ranges and StrictlyEnforceRange, but no
highlight item, the content would not move to the correct position
when incrementCurrentIndex() and decrementCurrentIndex() were invoked.
trackedPositionChanged() shouldn't take the current section pos into
account because this is already calculated by FxListItemSG::position()
(this wasn't the case when the code in trackedPositionChanged() was
originally written).
Task-number: QTBUG-20287
Change-Id: I1624b5afd1efbe27630349143b7af2b486cfa260
Reviewed-on: http://codereview.qt.nokia.com/2429
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Rohan McGovern [Sun, 31 Jul 2011 23:22:06 +0000 (09:22 +1000)]
sync.profile: remove dependency on qtscript
Since
d410ad364ec0b8877797145c68a4d7c3c98ce1c0, qtdeclarative does not
depend on qtscript.
Change-Id: I29f6eed7fa399fab16eae9493b0dae4ad4d505d7
Reviewed-on: http://codereview.qt.nokia.com/2406
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Martin Jones [Tue, 2 Aug 2011 03:58:49 +0000 (13:58 +1000)]
Views with no delegate crash when items are inserted.
Check that we have a valid VisualModel before reacting to model
changes.
Change-Id: I6107e8fb8942a3625e501ab549a337f1affd4fbd
Fixes: QTBUG-20640
Reviewed-on: http://codereview.qt.nokia.com/2481
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Alan Alpert [Mon, 1 Aug 2011 06:20:26 +0000 (16:20 +1000)]
Allow descendant chains to simultaneously be hovered.
Matches GV behaviour. Also fixes a bug in QSGMouseArea,
which we aren't fixing for QtQuick 1.
Task-number: QTBUG-18175
Change-Id: I4ecac7b908504f28de830732c731281407d7b0bc
Reviewed-on: http://codereview.qt.nokia.com/2422
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Bea Lam [Tue, 2 Aug 2011 00:53:52 +0000 (10:53 +1000)]
Call base class init() from QSGListViewPrivate
Regression from
9b5f9c8056186c9cf3c40dbac66e5f90369339dc when
QSGItemView was created.
Also fixed other reimplemented methods in QSGListViewPrivate to call
their base class functions (which are currently empty) and changed
some virtual methods in QSGItemViewPrivate to non-virtual where they
didn't need to be virtual.
Task-number: QTBUG-20679
Change-Id: I489593b3eab4f5bbb4126906f170342d1e8811cd
Reviewed-on: http://codereview.qt.nokia.com/2462
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Bea Lam [Tue, 2 Aug 2011 04:36:12 +0000 (14:36 +1000)]
Fix broken GridView moved() test
Test values for moving multiple items were incorrect.
Change-Id: I184afee6c44df240ef39450c530ff5991cd591e5
Reviewed-on: http://codereview.qt.nokia.com/2485
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Martin Jones [Mon, 1 Aug 2011 05:49:33 +0000 (15:49 +1000)]
Nesting PathView and Flickable causes PathView to stop at wrong offset
Don't stop current animation until a drag is actually initiated.
Also ensure we handle a stolen grab sensibly.
Change-Id: I0ad493595fb85e1c9bace2d805184f911341fce2
Fixes: QTBUG-19439
Reviewed-on: http://codereview.qt.nokia.com/2420
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Martin Jones [Mon, 1 Aug 2011 05:00:30 +0000 (15:00 +1000)]
View highlight could stop tracking currentItem.
This happens if the currentIndex is changed
while the view is moving. The only time the highlight should
not move to the currentItem is in StrictlyEnforceRange mode when
the user is moving the view.
Change-Id: I4d04174c88cde180f9f8a01cbd33af3edbcc3d4d
Fixes: QTBUG-16936
Reviewed-on: http://codereview.qt.nokia.com/2416
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Alan Alpert [Mon, 1 Aug 2011 08:26:57 +0000 (18:26 +1000)]
Allow custom parser types to still get signal handlers generated
Specifically, QDeclarativeListModelParser ought to have this behaviour.
Task-number: QTBUG-19763
Change-Id: I9d6ee07d1e17a027b254b87d20d1a93795c55744
Reviewed-on: http://codereview.qt.nokia.com/2431
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Andrew den Exter [Mon, 1 Aug 2011 06:27:01 +0000 (16:27 +1000)]
Don't enable qmlscene compability mode for commented out imports.
Valid import statements should be at the start of a line, maybe
preceded by some white space.
Task-number: QTBUG-20649
Change-Id: I1944bce0d30e680ebdb0798f5ae4e8c91a057a13
Reviewed-on: http://codereview.qt.nokia.com/2423
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Gunnar Sletta [Mon, 1 Aug 2011 11:30:46 +0000 (13:30 +0200)]
define for timing
Change-Id: Id91e47be0c2706de7871f3492725c577063ae5fb
Reviewed-on: http://codereview.qt.nokia.com/2438
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
Yann Bodson [Mon, 1 Aug 2011 04:57:12 +0000 (14:57 +1000)]
Add Image changes to whatsnew.qdoc
Change-Id: Ie197d8a6a927d9250ca975ae602b827fb894f39e
Reviewed-on: http://codereview.qt.nokia.com/2415
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
Michael Brasser [Mon, 1 Aug 2011 02:32:10 +0000 (12:32 +1000)]
Fix Binding to correctly restore bindings even when a binding loop is involved.
Change-Id: Ie8f9731d9f4834d8b94272ef792dc7ad0235ce78
Reviewed-on: http://codereview.qt.nokia.com/2409
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Michael Brasser [Mon, 1 Aug 2011 00:43:54 +0000 (10:43 +1000)]
Correctly pause animation when paused in starting ScriptAction.
Task-number: QTBUG-13598
Change-Id: Ibd54f4e014eff301b57451081b7f7b35d1bed740
Reviewed-on: http://codereview.qt.nokia.com/2408
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Simon Hausmann [Fri, 29 Jul 2011 08:25:44 +0000 (10:25 +0200)]
Merge the QJSEngine and QJSValue development branch into
This replaces the dependency to QtScript with two new builtin classes
QJSValue and QJSEngine.
This is still work in progress, development continues now in the master branch.
Change-Id: I7f5487feb45c972f25a22b10cc81b9218b9805de
Reviewed-on: http://codereview.qt.nokia.com/2299
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
Andrew den Exter [Fri, 29 Jul 2011 07:49:04 +0000 (17:49 +1000)]
Bump the XmlListModel get test import to QtQuick 2.0.
Change-Id: I62d65f24fac2b56b7f3efff5dc6e2e9056f53edd
Reviewed-on: http://codereview.qt.nokia.com/2383
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Michael Brasser [Fri, 29 Jul 2011 06:55:22 +0000 (16:55 +1000)]
Document (lack of) support for sharing animation instances.
Task-number: QTBUG-19040
Change-Id: Iacbd16bdf48c95bc9e84cac3bd3f704c35a03707
Reviewed-on: http://codereview.qt.nokia.com/2381
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Michael Brasser [Fri, 29 Jul 2011 03:10:25 +0000 (13:10 +1000)]
Ensure bindings on pause work correctly.
Defer the actual pause, in the same way we defer the actual start.
Task-number: QTBUG-19080
Change-Id: I500e5aa6678cbb5321979fda31f60d6d6e19a61e
Reviewed-on: http://codereview.qt.nokia.com/2366
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Aaron Kennedy [Fri, 29 Jul 2011 04:17:11 +0000 (14:17 +1000)]
Doc
Change-Id: I46c4ec5f41e5a1074d8c01f883409ee439bd09e2
Task-number: QTBUG-19741
Reviewed-on: http://codereview.qt.nokia.com/2368
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Fri, 29 Jul 2011 03:53:35 +0000 (13:53 +1000)]
Mark objects from Component.createObject() as destructible
Change-Id: I00a1a2b5cca80c3e2ea097690cadf21581e1356d
Task-number: QTBUG-20626
Reviewed-on: http://codereview.qt.nokia.com/2367
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Fri, 29 Jul 2011 02:28:09 +0000 (12:28 +1000)]
Fix alias warnings in QDeclarativeCompiler
Task-number: QTBUG-19736 QTBUG-19693
Change-Id: Ice6b9e0d4f11c75350a3028af5d2479d435d1f69
Reviewed-on: http://codereview.qt.nokia.com/2364
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Fri, 29 Jul 2011 02:28:03 +0000 (12:28 +1000)]
Fix alias warnings in QV8QObjectWrapper
Task-number: QTBUG-19736 QTBUG-19693
Change-Id: I4f6c56dc4f60224dd79e669099c198b883429f54
Reviewed-on: http://codereview.qt.nokia.com/2363
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Aaron Kennedy [Fri, 29 Jul 2011 02:28:00 +0000 (12:28 +1000)]
Fix alias warnings in V4
Task-number: QTBUG-19736 QTBUG-19693
Change-Id: I6b9c2c167bfe60bcd3c5af7d53ec79c5eec60b74
Reviewed-on: http://codereview.qt.nokia.com/2362
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Aaron Kennedy [Fri, 29 Jul 2011 02:27:54 +0000 (12:27 +1000)]
Fix alias warnings in QDeclarativeVME
Task-number: QTBUG-19736 QTBUG-19693
Change-Id: Ieab2c7274852b39fc4222132dedc738ab663d4f9
Reviewed-on: http://codereview.qt.nokia.com/2361
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Yann Bodson [Fri, 29 Jul 2011 04:41:16 +0000 (14:41 +1000)]
Add sourceComponentChanged signal to Loader
When setting the 'sourceComponent' property in Loader, we emit
a sourceChanged signal with source == "". We should emit
sourceComponentChanged instead.
Task-number: QTBUG-20628
Change-Id: If5f8f389b7dc214e729b366d82fe4d32827408ee
Reviewed-on: http://codereview.qt.nokia.com/2371
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Michael Brasser [Thu, 7 Jul 2011 03:10:35 +0000 (13:10 +1000)]
Document state fast-forwarding.
Task-number: QTBUG-16049
Change-Id: Ib64cc8ec9396d426e623481a69f5a4a1b0fe5ec5
Reviewed-on: http://codereview.qt.nokia.com/2370
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Michael Brasser [Fri, 29 Jul 2011 04:40:59 +0000 (14:40 +1000)]
Document how to have two MouseAreas simultaneously hovered.
Task-number: QTBUG-17228
Change-Id: Icfb3774429f0f19084f126a0b87699f1d03220f6
Reviewed-on: http://codereview.qt.nokia.com/2369
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Aaron Kennedy [Fri, 29 Jul 2011 02:27:40 +0000 (12:27 +1000)]
Fix alias warnings in QDeclarativeV8Handle
Task-number: QTBUG-19736 QTBUG-19693
Change-Id: I1fd1a3146aa7be933f60917a562211142c2460bc
Reviewed-on: http://codereview.qt.nokia.com/2360
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Aaron Kennedy [Thu, 28 Jul 2011 08:39:34 +0000 (18:39 +1000)]
Fix alias warnings in QDeclarativeGuard
Task-number: QTBUG-19736 QTBUG-19693
Change-Id: Id3aefe56bc1e33757b8c407f2022b49cc136f00b
Reviewed-on: http://codereview.qt.nokia.com/2359
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Michael Brasser [Fri, 29 Jul 2011 00:41:47 +0000 (10:41 +1000)]
Correctly set ending path percent if none is provided.
Task-number: QTBUG-19818
Change-Id: I5377551d041b593864d56e4449c133deb47d3b45
Reviewed-on: http://codereview.qt.nokia.com/2358
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Martin Jones [Thu, 28 Jul 2011 23:29:04 +0000 (09:29 +1000)]
Clicking on a disabled ListView's delegate breaks mouse interaction
A disabled Flickable should not filter children.
Change-Id: I9f0d8fbfd0922b5c6a9eaffa69212867359f79e0
Fixes: QTBUG-20584
Reviewed-on: http://codereview.qt.nokia.com/2354
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Alan Alpert [Fri, 29 Jul 2011 00:35:58 +0000 (10:35 +1000)]
Code cleanup
Change-Id: I97ecc41fcb7255981c863996064cf6d6bae7ebbb
Reviewed-on: http://codereview.qt.nokia.com/2356
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Charles Yin [Tue, 26 Jul 2011 00:47:13 +0000 (10:47 +1000)]
Add .arg() for Javascript String type
Change-Id: I973032189c40bfa4d5450396f5bad1a7c81ac68b
Task-number:QTBUG-16734
Reviewed-by:Michael Brasser
Reviewed-on: http://codereview.qt.nokia.com/2134
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Charles Yin [Wed, 27 Jul 2011 02:07:42 +0000 (12:07 +1000)]
XmlListModel.status is Ready right after creation (should be Null)
And whenever both the source the xml properties are empty, the status
should be Null as well.
Change-Id: I62936d9389b524833422a871b596b99cc93cc734
Task-number:QTBUG-18724
Reviewed-by:Michael Brasser
Reviewed-on: http://codereview.qt.nokia.com/2231
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Charles Yin [Wed, 27 Jul 2011 03:03:59 +0000 (13:03 +1000)]
remove motionchart demo (uncompleted)
Change-Id: I4e6b068ca9ceb0b7f76a6548d1b7a8789bc4bf39
Reviewed-on: http://codereview.qt.nokia.com/2237
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Alan Alpert [Thu, 28 Jul 2011 10:11:52 +0000 (20:11 +1000)]
Jump to same model index (if it exists) when the model changes
For PathView, ListView does this already.
Task-number: QTBUG-19059
Change-Id: Id09087ad372e46661794b0cb15cb30fc88802c4b
Reviewed-on: http://codereview.qt.nokia.com/2330
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Thu, 28 Jul 2011 10:21:58 +0000 (20:21 +1000)]
Augment SpringAnimation::damping documentation
Task-number: QTBUG-20120
Change-Id: Ifaa0e7eaa0f61052680338a6cfd35bb6aca63157
Reviewed-on: http://codereview.qt.nokia.com/2333
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Thu, 28 Jul 2011 06:59:23 +0000 (16:59 +1000)]
Document stops as default property of Gradient
This will hopefully be copied to the QtQuick2 item when we write docs
for them.
Task-number: QTBUG-16045
Change-Id: I427b468630b59bd4bd6eca907ab12a66ee219d29
Reviewed-on: http://codereview.qt.nokia.com/2320
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Kim Motoyoshi Kalland [Wed, 27 Jul 2011 09:06:00 +0000 (11:06 +0200)]
Renamed ShaderEffectItem to ShaderEffect and some API changes.
The ShaderEffectItem was renamed to ShaderEffect to be consistent
with other QML element names. The GLSL uniform variable
qt_ModelViewProjectionMatrix was renamed to qt_Matrix which is
easier to type and remember. The GridMesh element was removed.
The mesh resolution is now specified simply with a QSize.
To make the transition easier, the old API will continue to work
for some time, but will output warnings if used. Eventually, I
will remove the old API completely.
Change-Id: Iec4f2aa624a2c76a7db6750c58f73dbcb316ab6a
Reviewed-on: http://codereview.qt.nokia.com/2270
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Gunnar Sletta [Thu, 28 Jul 2011 11:26:51 +0000 (13:26 +0200)]
compile when qreal is a float
Change-Id: I1e5c592f1cacb0a3a80e15b53011efb134db29f7
Reviewed-on: http://codereview.qt.nokia.com/2336
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Alan Alpert [Thu, 28 Jul 2011 05:36:44 +0000 (15:36 +1000)]
Clip to bounding rect
Bounding rect varies from width/height in some cases, like Rectangle.
This restores rectangle clipping behaviour to be the same as QtQuick 1.
Task-number: QTBUG-20547
Change-Id: I2b6edc662a0026219d73b52878d2f4c046fef7f0
Reviewed-on: http://codereview.qt.nokia.com/2317
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
Alan Alpert [Fri, 22 Jul 2011 07:45:59 +0000 (17:45 +1000)]
Add some more properties to JS particle type
Adds the current position, velocity and acceleration.
While we're at it, renaming the velocity vars from sx,sy to vx,vy
Change-Id: I87f582169c7873c45a6fd453052b25c4dc940f3e
Reviewed-on: http://codereview.qt.nokia.com/2021
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Alan Alpert [Wed, 20 Jul 2011 03:46:52 +0000 (13:46 +1000)]
Initial CustomEmitter and CustomAffector implementation
Currently basic and can't access all properties.
Change-Id: I66efc235112cffcf1a3ca5cc69099a5d09ec7691
Reviewed-on: http://codereview.qt.nokia.com/1950
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Michael Brasser [Wed, 27 Jul 2011 00:19:26 +0000 (10:19 +1000)]
Allow Qt enum values in ListElement.
Task-number: QTBUG-16547
Change-Id: Id215cea5cdaaaef8ff8a06a0bde682f95c91e416
Reviewed-by: Aaron Kennedy
Reviewed-on: http://codereview.qt.nokia.com/2227
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Michael Brasser [Wed, 27 Jul 2011 03:13:50 +0000 (13:13 +1000)]
Support QT_TRANSLATE_NOOP in ListElement.
Task-number: QTBUG-16289
Change-Id: I13e6859de185478e2c6c9486d8deeda103dd7b90
Reviewed-on: http://codereview.qt.nokia.com/2238
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Michael Brasser [Wed, 27 Jul 2011 05:30:40 +0000 (15:30 +1000)]
Fix translation context for QML files.
Use the base file name as done in QtQuick 1, rather
than using the entire path. This also fixes QTBUG-17255
for QtQuick 2.
Change-Id: Ia27f6539f82d6caf6e7060b89ff1996d42ffb9cb
Reviewed-on: http://codereview.qt.nokia.com/2246
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Michael Brasser [Wed, 27 Jul 2011 06:15:45 +0000 (16:15 +1000)]
Remove reference to deleted file.
Change-Id: Ie75506c5a9d61eb50e7e2f1027b72e1c041200a9
Reviewed-on: http://codereview.qt.nokia.com/2249
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Yann Bodson [Thu, 28 Jul 2011 07:44:07 +0000 (17:44 +1000)]
BorderImage inner rect should have a positive size
Task-number: QTBUG-19527
Change-Id: I7cba15cc8ca4679d92f2e456ed95629702ea27a1
Reviewed-on: http://codereview.qt.nokia.com/2322
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
Aaron Kennedy [Wed, 27 Jul 2011 04:23:49 +0000 (14:23 +1000)]
Don't jump around when maximumEasingTime is specified
Task-number: QTBUG-20436
Change-Id: I477c42d55e712e141403b3a95d1c9b0685df5f0d
Reviewed-on: http://codereview.qt.nokia.com/2240
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Charles Yin [Mon, 25 Jul 2011 04:27:52 +0000 (14:27 +1000)]
Fix bug 20505: Offline Storage API: wrong types of row fields
fields types should be returned as same as defined, not strings.
Change-Id: I9a0d03acb79850e93cc9266e2595ee61af2089a0
Task-number:QTBUG-20505
Reviewed-on: http://codereview.qt.nokia.com/2065
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Bea Lam [Thu, 28 Jul 2011 06:10:46 +0000 (16:10 +1000)]
Fix auto-repeat key navigation for GridView
Shouldn't set moveReason=SetIndex in key navigation. ListView didn't
do this in its keyPress implementation.
Added extra tests for GridView and ListView.
Task-number: QTBUG-20408
Change-Id: Iaf0f331d3ba4f037c5bbc0a41418dd656b5a3695
Reviewed-on: http://codereview.qt.nokia.com/2318
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Martin Jones [Thu, 28 Jul 2011 05:06:02 +0000 (15:06 +1000)]
ListView doesn't show new 1st item currentItem is removed.
If the new 1st item becomes the currentItem after removal
it was positioned incorrectly because the currentItem is positioned
based on visibleIndex, which was updated after the currentItem
was updated. Move visibleIndex update before currentItem update.
Change-Id: Iaf92a41eefe7bce093e3000d17f5496dba144bcd
Fixes: QTBUG-20575
Reviewed-on: http://codereview.qt.nokia.com/2316
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Martin Jones [Thu, 28 Jul 2011 00:49:37 +0000 (10:49 +1000)]
Add dragging properties to Flickable
This allows the user to determine when a movement is due to the
user dragging the view directly, i.e. excluding any flick that
occurs after the touch is released.
Change-Id: Idf4b699946f808da6fa34ec21a3d2cb2f0ec9de6
Fixes: QTBUG-19685
Reviewed-on: http://codereview.qt.nokia.com/2310
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Alan Alpert [Mon, 25 Jul 2011 05:12:17 +0000 (15:12 +1000)]
Manage m_activeCount centrally
Fixes issue where it wasn't being managed right and kept going negative.
This commit also adds setVisible in a few places missed by the last
change.
Task-number: QTBUG-20437
Change-Id: I4efaab7b34784dfbc42dd1acd0a5be3b38a8605a
Reviewed-on: http://codereview.qt.nokia.com/2074
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Alan Alpert [Tue, 26 Jul 2011 00:50:19 +0000 (10:50 +1000)]
Remove forwardTo code
Committed by accident but slipped through the cracks somehow.
Change-Id: I64f172e5615de439987438b9300077e79503174e
Reviewed-on: http://codereview.qt.nokia.com/2135
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Alan Alpert [Thu, 21 Jul 2011 02:15:34 +0000 (12:15 +1000)]
Drive ParticleSystem with an animation instead
This will be helpful later, and also keeps the work in the main thread.
Change-Id: Idf4b9e82a40f31a0b70edda731b85b6c853a1dac
Reviewed-on: http://codereview.qt.nokia.com/1909
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Bea Lam [Wed, 27 Jul 2011 08:30:05 +0000 (18:30 +1000)]
Fix moving of multiple items, and moving items backwards
To fix backward movements, all backward movements are now flipped
into forward movements (as is done in ListModel implemenation).
Movement of multiple items wasn't working as views weren't removing
the right indexes in these cases.
Task-number: QTBUG-19208
Change-Id: I9866ddabc241c066bb77329a6761d500d79aaf61
Reviewed-on: http://codereview.qt.nokia.com/2262
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Charles Yin [Tue, 26 Jul 2011 23:57:37 +0000 (09:57 +1000)]
Fix XmlHttpRequest setHeader bug
Setting XMLHttpRequest raw header makes header name uppercase, the name
should be kept as it is.
Task-number:QTBUG-20472
Change-Id: I8aa8988d6d18d71ee71a7d2f9c3246b20f006f3c
Reviewed-on: http://codereview.qt.nokia.com/2225
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Alan Alpert [Wed, 27 Jul 2011 06:25:38 +0000 (16:25 +1000)]
Delete scene if you aren't going to use it.
Also make QDeclarativeOpenMetaObjectType zero its engine when the engine
dies, because this was leading to problems when the scene wasn't
deleted. Also fixes a few other potential deletion problems.
Change-Id: I37fa2d1a0b438a6ea7d8cf4c5c9d0bd869faa959
Reviewed-on: http://codereview.qt.nokia.com/2250
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Martin Jones [Wed, 27 Jul 2011 08:11:21 +0000 (18:11 +1000)]
A change in ListView's header height can cause it to overlap the items
If there are no visibleItems the header has no choice but to
set visiblePos to a value after itself.
Change-Id: I7748db46272989e421eeca88577b6fcf79814b5b
Fixes: QTBUG-19844
Reviewed-on: http://codereview.qt.nokia.com/2254
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Martin Jones [Wed, 27 Jul 2011 06:56:08 +0000 (16:56 +1000)]
Fix insertion of one item in ListView.
Off-by-one meant that the item was not created by the ListView.
Change-Id: If9658487a615e189c21c419e4d29e7e709e05cef
Fixes: QTBUG-19675
Reviewed-on: http://codereview.qt.nokia.com/2251
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Martin Jones [Wed, 27 Jul 2011 04:42:48 +0000 (14:42 +1000)]
The views have many +/- 1 which are causing errors.
Remove them all. endPosition() etc. now refer to the position() +
size() rather than position() + size() - 1.
Change-Id: I6ddf98def39971ee2e2c3c2d0a1df97781290782
Fixes: QTBUG-20020
Reviewed-on: http://codereview.qt.nokia.com/2243
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Martin Jones [Wed, 27 Jul 2011 00:08:58 +0000 (10:08 +1000)]
View highlight flickers with highlightRangeMode: ApplyRange
The view position was alternating between the start and end
of the highlight range if the range < delegate size. Now
favor the range start in this case, as per StrictlyEnforceRange.
Change-Id: Icb895f972ccb9598ecf7238259093584c43ae291
Fixes: QTBUG-18067
Reviewed-on: http://codereview.qt.nokia.com/2226
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Andrew den Exter [Thu, 28 Jul 2011 01:17:21 +0000 (11:17 +1000)]
Fix crash when a model defines its own modelData role.
Don't create a duplicate modelData property if one has already been
created from the model's roles.
Task-number: QTBUG-18801
Change-Id: Ic46763a9dc067cfb53b0655d991c553b3b10f023
Reviewed-on: http://codereview.qt.nokia.com/2312
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Andrew den Exter [Wed, 27 Jul 2011 07:54:04 +0000 (17:54 +1000)]
Update ListModel's internal indexes when items are inserted/removed.
The changed signals of cached items were being emitted with
incorrect indexes if a previous item in the list was inserted or
removed, resulting in changes not being reflected in views.
Task-number: QTBUG-20286
Change-Id: Id2fb8e2875c6cbd4f2e4d14ef859b7a7a4bac8d9
Reviewed-on: http://codereview.qt.nokia.com/2252
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Andrew den Exter [Wed, 27 Jul 2011 04:23:14 +0000 (14:23 +1000)]
Don't clip the cursor at the far right of a TextInput.
The cursor is allowed to exceed the boundaries of a TextInput so that
the text alignment is consistent with the Text element and the bounding
rect of TextInput is expanded to allow for that. To avoid clipping
the contentSize also needs to be expanded, and the horizontal scrolling
should be calculated against the non-expanded size.
Task-number: QTBUG-18818
Change-Id: I09e3a7aff9c2e8a333e8a3f9796683563b3e124a
Reviewed-on: http://codereview.qt.nokia.com/2242
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Bea Lam [Wed, 27 Jul 2011 08:19:01 +0000 (18:19 +1000)]
Fix positioning of items after move
If a move happened after a contentY change but before a refill, the
position of the first visible item wasn't calculated correctly.
If the first item from visibleItems was above the content start
position and a move operation caused the items below it to move
away, this first item was not being moved to the correct position
(i.e. above the next available visible item) causing the following
visible items to be positioned incorrectly on the next refill.
ListView supported this previously but only adjusted positioning for
items before the content position, instead of for all moved items.
Fixed for both ListView and GridView and added more move-related tests.
Task-number: QTBUG-20528
Change-Id: I2ba1a2f5e49f790e694c6e1486f649f10d09c256
Reviewed-on: http://codereview.qt.nokia.com/2261
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Bea Lam [Wed, 27 Jul 2011 07:57:48 +0000 (17:57 +1000)]
Don't move view content position item 0 is being replaced
Usually if item 0 moves down, the next item becomes the first visible
item and all content moves down. Don't do this if another item is
moving up to take its place.
Change-Id: If625cfc0eaa70fd1094c7bc0fdd29f5f56766a42
Reviewed-on: http://codereview.qt.nokia.com/2260
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Charles Yin [Thu, 28 Jul 2011 00:19:23 +0000 (10:19 +1000)]
increase the tryCompare timeout value to make the CI happy
Change-Id: I9561213295969f3064637584f45deb66f56c071b
Reviewed-on: http://codereview.qt.nokia.com/2309
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Charles Yin [Mon, 25 Jul 2011 04:55:32 +0000 (14:55 +1000)]
fix canvas arc drawing bug
Task-number:QTBUG-20523
Change-Id: I6ff71c12ffb66407cc5bbb4783e4c957ab740ac7
Reviewed-on: http://codereview.qt.nokia.com/2068
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Charles Yin [Wed, 20 Jul 2011 06:13:31 +0000 (16:13 +1000)]
polish canvas stock chart example
Change-Id: Ie79859af8572c3c79185d98c54c2aae35190d257
Reviewed-on: http://codereview.qt.nokia.com/1908
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Charles Yin [Mon, 18 Jul 2011 06:51:55 +0000 (16:51 +1000)]
put all context2d code into context2d directory
Change-Id: I38442c8d2bcb9f2dcaa433b6bcfd7dbc21439f63
Reviewed-on: http://codereview.qt.nokia.com/1907
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Alan Alpert [Tue, 26 Jul 2011 06:47:09 +0000 (16:47 +1000)]
Fix Column/Row size when no items being positioned
Change-Id: I0bf55c13e55856dd7292e5eda159086096dea86b
Reviewed-on: http://codereview.qt.nokia.com/2158
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Martin Jones [Tue, 26 Jul 2011 23:19:47 +0000 (09:19 +1000)]
Document view touch interaction with their content.
Fixes: QTBUG-18601
Change-Id: I9e793fa205d0eb2f2c312a9a73559720a4d4f00a
Reviewed-on: http://codereview.qt.nokia.com/2223
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Kent Hansen [Tue, 26 Jul 2011 10:53:00 +0000 (12:53 +0200)]
Don't build V8 as a static library
In the future, we'll need to be able to export the V8
symbols from the QtDeclarative library, which requires
compiling V8 straight in. It's not possible to achieve
this using a static library.
Change-Id: Ie9e31984d2c03639a311cef11ddd33ba0aa15fd9
Reviewed-on: http://codereview.qt.nokia.com/2187
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
Martin Jones [Tue, 26 Jul 2011 06:28:19 +0000 (16:28 +1000)]
A long press should allow onClicked if there is no onPressAndHold
Fixes: QTBUG-19726
Change-Id: I896c9264c1cf408dcd533b5d6d463d53c785d787
Reviewed-on: http://codereview.qt.nokia.com/2155
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Michael Brasser [Mon, 25 Jul 2011 06:43:55 +0000 (16:43 +1000)]
Fix crash when assigning a list property to transitions.
This fixes the crash, but doesn't actually assign any
Transitions (the transitions list will now be empty, rather
than contain a null Transition object). Correct assignment
is a general language issue, and will be fixed separately.
Task-number: QTBUG-20227
Change-Id: Ie224d06b1d8bb82d03c5eba378affb7167f08724
Reviewed-by: Alan Alpert
Reviewed-on: http://codereview.qt.nokia.com/2152
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
Michael Brasser [Mon, 25 Jul 2011 23:42:46 +0000 (09:42 +1000)]
Cleanup QMLViewer properly when exiting via File->Quit.
Task-number: QTBUG-14972
Change-Id: I9b8738fe0ae94a1bbed7427f137a6ab5c7a8ff86
Reviewed-on: http://codereview.qt.nokia.com/2154
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
projects / profile / ivi / qtdeclarative.git / log